Page MenuHomePhabricator
Feed Advanced Search

Yesterday

ProhtMeyhet added a comment to D11668: exactness: fix comparision.

There is enough time to add a space between will and be :-)

Thu, Apr 9, 7:10 AM · efl

Mon, Apr 6

ProhtMeyhet triaged T8649: gcc9, exactness: warning: ‘%s’ directive argument is null [-Wformat-overflow=] as Trivial priority.
Mon, Apr 6, 10:32 AM · efl
ProhtMeyhet closed T8587: ../src/lib/eina/eina_config.h:83: warning: "EINA_ENABLE_LOG" redefined as Resolved.

I've git cloned a new copy and this seems to be gone. Only guess I have is that ninja didn't clean everything or maybe some meson bug.... Only thing remains now are some unused warnings in generated .eo.c code and a format error :D :

Mon, Apr 6, 10:17 AM · efl
ProhtMeyhet added a comment to T8587: ../src/lib/eina/eina_config.h:83: warning: "EINA_ENABLE_LOG" redefined.

hum, eina_config.h has a #pragma once in its head. I know that is not a standard way.

Mon, Apr 6, 5:53 AM · efl

Sun, Apr 5

ProhtMeyhet added a comment to D11368: emile: fix a potentional resource leaking..

@bu5hm4n, @ProhtMeyhet are you happy with the rebased version now?

Sun, Apr 5, 4:46 PM · efl

Fri, Mar 27

ProhtMeyhet added a comment to D11561: Wallpaper/Theme Selector - add button for online themes/wallpapers using extra (extra.e.org).

Overall I like this idea :-)

Fri, Mar 27, 7:35 PM · enlightenment-git

Mon, Mar 23

ProhtMeyhet added a commit to T8151: RFC: Text interfaces design proposal: rEa3ae1b0ac2db: e auth - use our memclear and fill it out with modern zeroing methods.
Mon, Mar 23, 6:06 PM · efl: api

Thu, Mar 12

ProhtMeyhet added a comment to T8624: EDJE_CC error.

No, that's the index value within the parts. parts_count - 1.

Thu, Mar 12, 1:52 PM · Restricted Project

Mar 10 2020

ProhtMeyhet edited projects for T7133: Hdd partitions are not shown in EFM, added: enlightenment-git; removed Restricted Project.

The subject was pretty late. Can you give me a clear answer about this problem? Is it just a problem for me or a general problem?

Mar 10 2020, 7:18 AM · enlightenment-git, Restricted Project, efl: system integration

Mar 9 2020

ProhtMeyhet added a comment to T8622: Mouse pointer shifted ~10px.

another post

Mar 9 2020, 11:06 AM · E on FreeBSD, enlightenment-git
ProhtMeyhet added a comment to T8622: Mouse pointer shifted ~10px.

I am not sure that it is really FreBSD specific, but I cannot test on Linux now.

Mar 9 2020, 9:11 AM · E on FreeBSD, enlightenment-git
ProhtMeyhet added a project to T8622: Mouse pointer shifted ~10px: E on FreeBSD.
Mar 9 2020, 8:11 AM · E on FreeBSD, enlightenment-git
ProhtMeyhet added a comment to T8562: efl does not build on macOS anymore.

@seeker could you write us a patch? Either upload it here or create a diff here. Any other textform (email, paste) would probably also helpful, but less desirable.

Mar 9 2020, 7:39 AM · efl, macOS
ProhtMeyhet added a comment to T8624: EDJE_CC error.

also why is the ERR substracting -1 from pc->parts_count, while in the if it is not? Either the the if is wrong or the ERR debug output will not give you the actual information.

Mar 9 2020, 7:29 AM · Restricted Project
ProhtMeyhet assigned T8624: EDJE_CC error to netstar.

This error was introduced in e8e637a79a6 . @netstar, could you please have a look?

Mar 9 2020, 7:21 AM · Restricted Project
ProhtMeyhet added a project to T8622: Mouse pointer shifted ~10px: enlightenment-git.

Is this on BSD? And on X11?

Mar 9 2020, 7:10 AM · E on FreeBSD, enlightenment-git

Mar 7 2020

ProhtMeyhet added a comment to D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.

I think there are alot of similar cases in the source code

Mar 7 2020, 1:31 AM · efl

Mar 6 2020

ProhtMeyhet requested review of D11472: eina: Docs/Comments: eina_safety_checks: Correct grammar, spelling mistakes and be more clearer.
Mar 6 2020, 1:35 PM · efl
devilhorns awarded D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used a Like token.
Mar 6 2020, 1:27 PM · efl
ProhtMeyhet added a comment to D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.

The parameter for git diff that shows you more lines to see if obj is used is -U

Mar 6 2020, 1:24 PM · efl
ProhtMeyhet requested review of D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.
Mar 6 2020, 1:22 PM · efl

Feb 20 2020

ProhtMeyhet updated subscribers of D11368: emile: fix a potentional resource leaking..

in the github link, a patch looks like below.

Feb 20 2020, 7:47 PM · efl

Feb 19 2020

ProhtMeyhet added a comment to D11377: evas_textblock: reduce unneeded calculation.

Please keep in mind that this is legacy API. If we change something like this. Then we have a quite big chance that we will cause hard trouble for people that wrote apps with efl. Why not just leave it as it is, and *not* cause any trouble? The performance impact here cannot be that bad, yet i am still missing a single prove that this lines causes any performance issues... On the other side, if someone complained about this using too much time if you pass NULL, NULL simply DO NOT CALL IT THEN.

Feb 19 2020, 11:26 PM · efl
ProhtMeyhet added a comment to D11377: evas_textblock: reduce unneeded calculation.

The if(w) and if(h) are rather standard ways to say "If the caller provided a place to store this data, then store it, otherwise do nothing". It is convenient for those cases were the caller is only interested in some of the return values, because it does not need to provide storage space for data it is not interested in.

Feb 19 2020, 11:22 PM · efl
ProhtMeyhet added a comment to D11377: evas_textblock: reduce unneeded calculation.

Calling these methods with w == h == NULL looks like an error. Shouldn't we print something? Maybe with an EINA_SAFETY macro?

Feb 19 2020, 3:35 AM · efl

Feb 7 2020

ProhtMeyhet added a comment to D11297: efl-check: do not print expected errors.

But if you want to do it beautiful, this could be a meson configure option ?

Feb 7 2020, 4:01 AM · efl

Feb 6 2020

ProhtMeyhet added a comment to T8217: Desktop dimensions corrupted after longer sleep.

... and I should be be giving more details. The difference I see between those two is just the following

Feb 6 2020, 4:23 AM · enlightenment-git
ProhtMeyhet updated subscribers of T8217: Desktop dimensions corrupted after longer sleep.
In T8217#150357, @mbert wrote:

Sorry, I noticed this comment a bit late. Here's the output you were asking for.

Before:


After:

Feb 6 2020, 4:19 AM · enlightenment-git
ProhtMeyhet added a comment to D11297: efl-check: do not print expected errors.

Correct :)

Feb 6 2020, 4:08 AM · efl
ProhtMeyhet added a comment to D11297: efl-check: do not print expected errors.

general question: without this

Feb 6 2020, 3:59 AM · efl

Feb 5 2020

ProhtMeyhet added a project to T8604: Efl.ui.textbox longpress on scrollbar: efl.

Could you please in the future add tags on your own? A priority would be helpful as well.

Feb 5 2020, 10:31 AM · efl

Feb 4 2020

ProhtMeyhet added a comment to T8601: Next Screen / Previous Screen keyboard shortcuts are backwards..

*cough* *cough* please, Simon, you are capable of adding tags on your own. Please do in the future.

Feb 4 2020, 5:52 PM · enlightenment-git
ProhtMeyhet triaged T8601: Next Screen / Previous Screen keyboard shortcuts are backwards. as Trivial priority.
Feb 4 2020, 5:50 PM · enlightenment-git

Feb 2 2020

ProhtMeyhet triaged T8598: Can't change/turn off any Transitions (Startup, Change Background, Desk Change) anymore as Normal priority.
Feb 2 2020, 10:26 AM · enlightenment-git
ProhtMeyhet created T8598: Can't change/turn off any Transitions (Startup, Change Background, Desk Change) anymore.
Feb 2 2020, 10:26 AM · enlightenment-git

Jan 31 2020

ProhtMeyhet added a comment to D11171: edje: Add null check.

ahhhrg, just running it in gdb gives me a bus error:

Jan 31 2020, 7:16 AM · efl
ProhtMeyhet added a comment to D11171: edje: Add null check.

Oh, now that is interesting - can you create a ticket, and share the backtrace there ?

Jan 31 2020, 7:13 AM · efl
ProhtMeyhet added a comment to D11171: edje: Add null check.

I compiled with ggc-9.2

Jan 31 2020, 7:11 AM · efl
ProhtMeyhet added a comment to D11171: edje: Add null check.

elementary_test fails because errors are now printed.

Jan 31 2020, 6:46 AM · efl
ProhtMeyhet closed D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.
Jan 31 2020, 5:33 AM · efl

Jan 30 2020

ProhtMeyhet added a comment to D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.

this is really turning into a hunt.

Jan 30 2020, 11:22 PM · efl
ProhtMeyhet updated the diff for D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.
Jan 30 2020, 11:20 PM · efl
ProhtMeyhet added a comment to D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.

Follow up on D11237. Please see T8591 for details.

Jan 30 2020, 10:58 PM · efl
ProhtMeyhet updated the summary of D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.
Jan 30 2020, 10:55 PM · efl
ProhtMeyhet requested review of D11254: edje: use EINA_UNUSED consistently after in function signatures -- part2.
Jan 30 2020, 10:55 PM · efl
ProhtMeyhet added a comment to D11171: edje: Add null check.

Sounds like a good idea, however, now the tests dont pass anymore :/

Jan 30 2020, 8:50 AM · efl
ProhtMeyhet closed D11237: edje: use EINA_UNUSED consistently after declaration in function signatures.
Jan 30 2020, 8:37 AM · efl

Jan 29 2020

ProhtMeyhet closed T8593: "Dependency "libopenjp2" not found," despite being installed [opensuse] as Invalid.

meh [insert profanity]

Jan 29 2020, 3:52 PM · Restricted Project
ProhtMeyhet added a comment to T8593: "Dependency "libopenjp2" not found," despite being installed [opensuse].

have you thought of providing the openjpeg devel pkgs like all other devel pkgs for deps... or disabling the jp2k loader? :)

Jan 29 2020, 3:36 PM · Restricted Project
ProhtMeyhet added a comment to T8592: Terminilogy is forcing display of tab.

Yes, it is resolved. Twitter bug report is the future :-)

Jan 29 2020, 10:16 AM
ProhtMeyhet retitled D11237: edje: use EINA_UNUSED consistently after declaration in function signatures from edje: use EINA_UNUSED consistently after in function signatures to edje: use EINA_UNUSED consistently after declaration in function signatures.
Jan 29 2020, 9:23 AM · efl
ProhtMeyhet closed T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)? as Resolved.

For edje resolved: D11237 .

Jan 29 2020, 9:22 AM · efl
ProhtMeyhet added a reviewer for D11237: edje: use EINA_UNUSED consistently after declaration in function signatures: devilhorns.
Jan 29 2020, 9:20 AM · efl
ProhtMeyhet added a comment to D11237: edje: use EINA_UNUSED consistently after declaration in function signatures.

I didn't want to put this in the commit comment. Please see T8591 for details.

Jan 29 2020, 9:20 AM · efl
ProhtMeyhet requested review of D11237: edje: use EINA_UNUSED consistently after declaration in function signatures.
Jan 29 2020, 9:18 AM · efl
ProhtMeyhet updated the task description for T8593: "Dependency "libopenjp2" not found," despite being installed [opensuse].
Jan 29 2020, 8:57 AM · Restricted Project
ProhtMeyhet triaged T8593: "Dependency "libopenjp2" not found," despite being installed [opensuse] as Showstopper Issues priority.
Jan 29 2020, 8:55 AM · Restricted Project
ProhtMeyhet added a comment to T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)?.

From a compiler stand point, I do not think that it actually makes a difference ... tho that Could depend on the compiler. It's been EFL preference that they come After so if you would like to make some patches to fix those, that would be great.

Jan 29 2020, 7:58 AM · efl
ProhtMeyhet added a comment to T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)?.

Normally, we use it After the variable

Jan 29 2020, 7:23 AM · efl
ProhtMeyhet added a comment to D11189: edje_legacy: avoid calling any functions if part is NULL.

yeah! my first commit!

Jan 29 2020, 4:23 AM · efl
ProhtMeyhet closed D11189: edje_legacy: avoid calling any functions if part is NULL.
Jan 29 2020, 3:46 AM · efl
ProhtMeyhet added a comment to D11189: edje_legacy: avoid calling any functions if part is NULL.

the do { } while(0) there doesn't help either, but my uploaded file was one without this adjustment.

Jan 29 2020, 2:54 AM · efl
ProhtMeyhet added a comment to D11189: edje_legacy: avoid calling any functions if part is NULL.

@ProhtMeyhet what is the problem with the macro ?

Also - can you ensure that the tests do pass ?

Jan 29 2020, 2:52 AM · efl

Jan 28 2020

ProhtMeyhet added a comment to T8581: some administrative questions about tags/bugs/new tasks in phab with regard to New Users/Bug Reporters.

I can't comment on all of it but here are my thoughts on this.
We should try to configure phab to have like a template bug report users can use to fill in details we would need for debugging. Adding a default efl or enlightenment tag (unknown maybe) could be a good idea. A template should also tell them what to put in the tag (if they build from git, use a distro package,e tc)

Jan 28 2020, 2:27 PM · Restricted Project
ProhtMeyhet added a comment to T8581: some administrative questions about tags/bugs/new tasks in phab with regard to New Users/Bug Reporters.
In T8581#150128, @zmike wrote:

The numbered tags are milestones. Phabricator automatically closes the previous milestone when a new one is created, and there's no way (that I'm aware of) to change this behavior without modifying the underlying code.

Jan 28 2020, 2:18 PM · Restricted Project
ProhtMeyhet triaged T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)? as Trivial priority.
Jan 28 2020, 2:17 PM · efl
ProhtMeyhet triaged T8590: raster: what does "freach" mean? as Pending on user input priority.
Jan 28 2020, 1:53 PM
ProhtMeyhet created T8590: raster: what does "freach" mean?.
Jan 28 2020, 1:52 PM

Jan 25 2020

ProhtMeyhet triaged T8587: ../src/lib/eina/eina_config.h:83: warning: "EINA_ENABLE_LOG" redefined as Normal priority.
Jan 25 2020, 2:06 PM · efl
ProhtMeyhet planned changes to D11189: edje_legacy: avoid calling any functions if part is NULL.

updated the same "fix" to the other functions in eina_legacy.c. Does not change functionality.

Jan 25 2020, 11:11 AM · efl
ProhtMeyhet updated the diff for D11189: edje_legacy: avoid calling any functions if part is NULL.
Jan 25 2020, 11:06 AM · efl
ProhtMeyhet updated the diff for D11189: edje_legacy: avoid calling any functions if part is NULL.
Jan 25 2020, 11:04 AM · efl
ProhtMeyhet created T8587: ../src/lib/eina/eina_config.h:83: warning: "EINA_ENABLE_LOG" redefined.
Jan 25 2020, 10:57 AM · efl
ProhtMeyhet added a comment to D11189: edje_legacy: avoid calling any functions if part is NULL.

only thing I'm not sure about is if I should use EINA_SAFETY_ON_NULL_RETURN as part is an argument to those functions and the macro EINA_SAFETY_ON_NULL_RETURN would at least log that there has been a NULL given.

Jan 25 2020, 12:25 AM · efl
ProhtMeyhet requested review of D11189: edje_legacy: avoid calling any functions if part is NULL.
Jan 25 2020, 12:14 AM · efl

Jan 24 2020

ProhtMeyhet added a comment to D11171: edje: Add null check.

Isn't the EINA_UNUSED wrong on the function argument Eo *obj ? Because the macro GET_REAL_PART_ON_FAIL_RETURN looks like this and it includes obj

Jan 24 2020, 8:48 PM · efl
ProhtMeyhet added a comment to D11171: edje: Add null check.

I think you should better use the macro EINA_SAFETY_ON_NULL_RETURN here, and probably before GET_REAL_PART_ON_FAIL_RETURN().

Jan 24 2020, 8:23 AM · efl
ProhtMeyhet added a comment to T8583: testing testing testing 1 2 3.

I am become death, the destroyer of worlds.

Jan 24 2020, 4:32 AM
ProhtMeyhet added a comment to T8583: testing testing testing 1 2 3.

Cowards die many times before their deaths,
The valiant never taste of death but once.

Jan 24 2020, 4:15 AM

Jan 23 2020

ProhtMeyhet added a comment to T8316: Notification popup doesn't close.

It doesn't change, same issue

It seems to be related to the default theme

Jan 23 2020, 7:05 PM · enlightenment-git

Jan 22 2020

ProhtMeyhet added a comment to T5574: Enlightenment uses excessive CPU when a window is opened but not yet shown.

Is this still an issue?

Jan 22 2020, 11:09 AM · Restricted Project, enlightenment-git
ProhtMeyhet added a comment to T8316: Notification popup doesn't close.

I can't reproduce this.

Jan 22 2020, 11:08 AM · enlightenment-git
ProhtMeyhet triaged T8581: some administrative questions about tags/bugs/new tasks in phab with regard to New Users/Bug Reporters as High priority.
Jan 22 2020, 10:38 AM · Restricted Project
ProhtMeyhet triaged T6877: Unlock screen and keyboard layouts don't go with each other well as Normal priority.
Jan 22 2020, 9:00 AM · enlightenment-git, enlightenment20
ProhtMeyhet added a comment to T6877: Unlock screen and keyboard layouts don't go with each other well.

Is this still an issue? I seem to remember raster changed something with multiple keyboard layouts... can't find it atm, though.

Jan 22 2020, 9:00 AM · enlightenment-git, enlightenment20
ProhtMeyhet triaged T8217: Desktop dimensions corrupted after longer sleep as Normal priority.

can you please post the output of the following terminal commands before and after this happens?

Jan 22 2020, 8:22 AM · enlightenment-git

Jan 21 2020

ProhtMeyhet added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

I went full stupid and only needed like 70% stupid

Jan 21 2020, 1:42 PM · efl

Jan 20 2020

ProhtMeyhet added a comment to T8282: eina_cpu.c: Enum assigned with not its enum values..

This assignment/declaration itself is not a problem

Jan 20 2020, 7:38 AM

Jan 15 2020

ProhtMeyhet added a comment to T8577: Rich Text Editor Example.

Don't forget there is already ecrire which could serve as a quick start.

Jan 15 2020, 4:17 PM
ProhtMeyhet added inline comments to D11068: efl.ui.textbox: paste in mouse button 2.
Jan 15 2020, 4:21 AM · efl

Jan 13 2020

ProhtMeyhet edited projects for T8562: efl does not build on macOS anymore, added: efl; removed efl (efl-1.22).
Jan 13 2020, 4:09 AM · efl, macOS
ProhtMeyhet added a project to T8562: efl does not build on macOS anymore: efl (efl-1.22).

@jayji could you have a look? It's from your commit c03876d611fca41d02513fb07d3d275f64bcf0cd and also has a FIXME there:

Jan 13 2020, 4:09 AM · efl, macOS

Jan 12 2020

ProhtMeyhet added a comment to D10172: c/cxx: Fix warning from clang -Weverything..

Could you please post the compiler warnings? Because just casting a return value like the following will solve compiler warnings, but sadly may just solve those, but - worse - may not resolve any bugs, but even hide them in the future. Especially this strlen call doesn't seem right:

Jan 12 2020, 3:54 PM · efl

Jan 11 2020

ProhtMeyhet edited projects for T8553: VSynced checkbox allows toggle to "enabled" when in" software mode", added: enlightenment-git; removed enlightenment_settings.
Jan 11 2020, 10:47 AM · enlightenment-git
ProhtMeyhet added a project to T8560: "xkill" on open EFM window kills the whole Desktop.: enlightenment-git.

Yep, I don't think this is fixable as EFM is tightly integrated for various reasons into the enlightenment display manager itself.

Jan 11 2020, 10:46 AM · enlightenment-git

Jan 9 2020

ProhtMeyhet added a project to T8558: When opening EFM desktops hangs due to "qtdemux" segfaulting: enlightenment-git.

Also, please state again here so those who could solve it will know:

Jan 9 2020, 1:03 PM · enlightenment-git
ProhtMeyhet added a project to T8559: Strange keyboard behavior if EFM directory (or nothing) is selected: enlightenment-git.

Could you please tell us which version of enlightenment you are using and on which OS/Distribution? Or are you on Git and build yourself?

Jan 9 2020, 12:59 PM · enlightenment-git

Jan 4 2020

ProhtMeyhet added a comment to T7803: E 0.22.4 all X UI hangs on FreeBSD.

testing a bit more, this script is very effective for stopping e for up to 5 seconds for me. First send a via notify-send which returns immediately, start date and then shellementary. Needs a bit higher load and a hardware accelerated video playing. Browsers like Firefox and Chromium are helpful as well. Restarts after 900 seconds which seems enough to purge the kernel cache of shellementary and its librarys.

Jan 4 2020, 1:11 PM · E on FreeBSD, enlightenment20, enlightenment-git
ProhtMeyhet added a comment to T7803: E 0.22.4 all X UI hangs on FreeBSD.

For me I've found a relatively reliable testcase for this: shellementary. When I play a video, have a browser open and a system load roughly equal to the number of cpu cores, e hangs for up to 5 seconds when opening it the first time. So it seems either e or Xorg is waiting for the creation of this window, but shellementary sometimes takes too long (maybe on memory init?)

Jan 4 2020, 8:21 AM · E on FreeBSD, enlightenment20, enlightenment-git

Dec 23 2019

ProhtMeyhet added inline comments to D10884: examples: js: make sure we declare all variables.
Dec 23 2019, 6:34 AM · efl