Page MenuHomePhabricator
Feed Advanced Search

May 26 2020

zmike closed D11862: build: disable leak detection in address sanitizer build for tests as well.
May 26 2020, 6:55 AM · efl
zmike accepted D11862: build: disable leak detection in address sanitizer build for tests as well.

Timeouts should be 60s for all test suites, as that's historically been the number I've used as the maximum (and is what CI uses).

May 26 2020, 6:54 AM · efl

May 22 2020

zmike added a comment to D11868: edje: markup flag should be TRUE in legacy edje_object_part_text_set.

Can this test code be added as a unit test?

May 22 2020, 5:44 AM · efl
zmike accepted D11869: ecore_wl2_window: do not unmap subsurface in hide.

From Wayland protocol:

A sub-surface becomes mapped, when a non-NULL wl_buffer is applied
and the parent surface is mapped. The order of which one happens
first is irrelevant. A sub-surface is hidden if the parent becomes
hidden, or if a NULL wl_buffer is applied. These rules apply
recursively through the tree of surfaces.
May 22 2020, 5:43 AM · efl

May 21 2020

zmike added a comment to D11864: evas image: reload after alpha_set.

This should probably have a unit test which verifies the load callback is called on the elm_image at some point

May 21 2020, 7:07 AM · efl

May 18 2020

zmike added a comment to T8723: EFL_CANVAS_LAYOUT_BETA still used ?.

Defines of the format EFL_[A-Z0-9_]_BETA are generated from eo-based APIs through eolian. As such, the "usedness" of each define can be determined by checking the corresponding eo file (in this case efl_canvas_layout.eo) to determine if the class is still in beta (noted by the @beta tag in the class declaration at the top of the file).

May 18 2020, 6:25 AM · efl

May 14 2020

zmike added a reviewer for D11807: Merge efreet_mime efreet_trash into efreet: englebass.
May 14 2020, 6:48 AM · efl

May 13 2020

zmike closed D11818: elm: refactor legacy _icon_signal_emit.
May 13 2020, 7:03 AM · efl

May 12 2020

zmike requested review of D11818: elm: refactor legacy _icon_signal_emit.
May 12 2020, 8:44 AM · efl
zmike closed D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:26 AM · efl
zmike closed D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:24 AM · efl
zmike closed D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:24 AM · efl
zmike closed D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.
May 12 2020, 8:24 AM · efl
zmike accepted D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.
May 12 2020, 8:21 AM · efl
zmike accepted D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:20 AM · efl
zmike accepted D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:20 AM · efl
zmike accepted D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.
May 12 2020, 8:19 AM · efl
zmike updated the diff for D11816: build: fix void* use in pointer maths.

cast harder

May 12 2020, 7:54 AM · efl
zmike added a comment to D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.

The premise here is that the default state of the theme should match the default state of the widget, and thus there's no need to ever send signals here before finalize because they can never be anything but the default. This is only ever not the case with the unified API, when it's possible to change properties during construction.

May 12 2020, 7:45 AM · efl
zmike added a comment to D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.

https://travis-ci.org/github/Enlightenment/efl/builds/686131015

May 12 2020, 7:05 AM · efl
zmike added a comment to D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.

https://travis-ci.org/github/Enlightenment/efl/builds/686131015

May 12 2020, 7:05 AM · efl
zmike added a comment to D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.

https://travis-ci.org/github/Enlightenment/efl/builds/686131015

May 12 2020, 7:04 AM · efl
zmike added a comment to D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.

Hm this breaks unified API usage, but technically that's unsupported for legacy widgets. Probably ok...

May 12 2020, 7:04 AM · efl
zmike closed D11508: evas_object_textblock: reduce layout calculations.
May 12 2020, 7:00 AM · efl
zmike accepted D11508: evas_object_textblock: reduce layout calculations.

Seems ok.

May 12 2020, 6:59 AM · efl
zmike added a comment to D11817: build: enable -Wpointer-arith for dev builds.

https://travis-ci.org/github/Enlightenment/efl/builds/686127452

May 12 2020, 6:55 AM · efl
zmike requested review of D11817: build: enable -Wpointer-arith for dev builds.
May 12 2020, 6:54 AM · efl
zmike added a child revision for D11816: build: fix void* use in pointer maths: D11817: build: enable -Wpointer-arith for dev builds.
May 12 2020, 6:54 AM · efl
zmike requested review of D11816: build: fix void* use in pointer maths.
May 12 2020, 6:54 AM · efl
zmike updated the diff for D11793: evas: resolve float compare warnings.

typo

May 12 2020, 6:45 AM · efl
zmike updated the diff for D11795: evas/gl: resolve float compare warnings.

typo

May 12 2020, 6:43 AM · efl
zmike updated the diff for D11793: evas: resolve float compare warnings.

typo

May 12 2020, 6:40 AM · efl

May 11 2020

zmike added a comment to D11508: evas_object_textblock: reduce layout calculations.

https://travis-ci.org/github/Enlightenment/efl/builds/685677870

May 11 2020, 6:59 AM · efl

May 8 2020

zmike added a comment to D11800: build: enable -Wfloat-compare by default for dev builds.

https://travis-ci.org/github/Enlightenment/efl/builds/684395440

May 8 2020, 6:05 AM · efl

May 7 2020

zmike requested review of D11800: build: enable -Wfloat-compare by default for dev builds.
May 7 2020, 11:54 AM · efl
zmike added a child revision for D11799: static/triangulator: resolve float compare warnings: D11800: build: enable -Wfloat-compare by default for dev builds.
May 7 2020, 11:54 AM · efl
zmike requested review of D11799: static/triangulator: resolve float compare warnings.
May 7 2020, 11:53 AM · efl
zmike added a child revision for D11798: edje: resolve float compare warnings: D11799: static/triangulator: resolve float compare warnings.
May 7 2020, 11:53 AM · efl
zmike requested review of D11798: edje: resolve float compare warnings.
May 7 2020, 11:53 AM · efl
zmike added a child revision for D11797: exactness: resolve float compare warnings: D11798: edje: resolve float compare warnings.
May 7 2020, 11:52 AM · efl
zmike requested review of D11797: exactness: resolve float compare warnings.
May 7 2020, 11:52 AM · efl
zmike added a child revision for D11796: examples: resolve float compare warnings: D11797: exactness: resolve float compare warnings.
May 7 2020, 11:52 AM · efl
zmike requested review of D11796: examples: resolve float compare warnings.
May 7 2020, 11:51 AM · efl
zmike added a child revision for D11795: evas/gl: resolve float compare warnings: D11796: examples: resolve float compare warnings.
May 7 2020, 11:51 AM · efl
zmike requested review of D11795: evas/gl: resolve float compare warnings.
May 7 2020, 11:51 AM · efl
zmike added a child revision for D11794: evas/filter: resolve float compare warnings: D11795: evas/gl: resolve float compare warnings.
May 7 2020, 11:50 AM · efl
zmike requested review of D11794: evas/filter: resolve float compare warnings.
May 7 2020, 11:50 AM · efl
zmike added a child revision for D11793: evas: resolve float compare warnings: D11794: evas/filter: resolve float compare warnings.
May 7 2020, 11:50 AM · efl
zmike requested review of D11793: evas: resolve float compare warnings.
May 7 2020, 11:49 AM · efl
zmike added a child revision for D11792: evas/events: fix conditional for emitting source mouse move events: D11793: evas: resolve float compare warnings.
May 7 2020, 11:49 AM · efl
zmike requested review of D11792: evas/events: fix conditional for emitting source mouse move events.
May 7 2020, 11:49 AM · efl
zmike added a child revision for D11791: elm: resolve float comparison warnings: D11792: evas/events: fix conditional for emitting source mouse move events.
May 7 2020, 11:48 AM · efl
zmike requested review of D11791: elm: resolve float comparison warnings.
May 7 2020, 11:48 AM · efl
zmike added a child revision for D11790: bin/elm: resolve float compare warnings: D11791: elm: resolve float comparison warnings.
May 7 2020, 11:48 AM · efl
zmike requested review of D11790: bin/elm: resolve float compare warnings.
May 7 2020, 11:47 AM · efl
zmike added a child revision for D11789: tests: resolve float comparison warnings: D11790: bin/elm: resolve float compare warnings.
May 7 2020, 11:47 AM · efl
zmike requested review of D11789: tests: resolve float comparison warnings.
May 7 2020, 11:47 AM · efl
zmike added a child revision for D11788: edje_cc: consistently use eina macros for all float comparisons: D11789: tests: resolve float comparison warnings.
May 7 2020, 11:46 AM · efl
zmike requested review of D11788: edje_cc: consistently use eina macros for all float comparisons.
May 7 2020, 11:46 AM · efl
zmike added a child revision for D11787: edje_cc: fix comparisons for possible non-float values: D11788: edje_cc: consistently use eina macros for all float comparisons.
May 7 2020, 11:46 AM · efl
zmike requested review of D11787: edje_cc: fix comparisons for possible non-float values.
May 7 2020, 11:46 AM · efl
zmike added a child revision for D11786: eina: resolve float comparison warnings: D11787: edje_cc: fix comparisons for possible non-float values.
May 7 2020, 11:46 AM · efl
zmike requested review of D11786: eina: resolve float comparison warnings.
May 7 2020, 11:45 AM · efl

May 4 2020

zmike closed D9536: evas_textblock: optimize calculate main format once in layout setup stage.
May 4 2020, 12:26 PM · efl
zmike accepted D9536: evas_textblock: optimize calculate main format once in layout setup stage.
May 4 2020, 12:25 PM · efl
zmike added a comment to D11508: evas_object_textblock: reduce layout calculations.

A proxy object is an image object with a source. So it could be created with image_add() -> source_set(). Specifically the case I was thinking of was when source_visible is false in the legacy codepath, but I forgot that we use a different flag for that.

May 4 2020, 11:44 AM · efl
zmike added a comment to D9536: evas_textblock: optimize calculate main format once in layout setup stage.

Oh great. Can you update the commit log with a reference to the name of the expedite test used at the bottom? I'll land after

May 4 2020, 11:42 AM · efl
zmike added a comment to D9536: evas_textblock: optimize calculate main format once in layout setup stage.

Whoops this one got away from me. The tests do pass now, but, as @cedric said previously, this is a significant optimization patch, and it should include at least some sort of expedite benchmark along with some results in the commit log here.

May 4 2020, 6:31 AM · efl
zmike added a comment to D11508: evas_object_textblock: reduce layout calculations.

Okay, but a proxy object can be rendered even if its source is hidden, so it seems to me like this patch would break that. Can you check?

May 4 2020, 6:12 AM · efl

Apr 30 2020

zmike closed T8690: efl_get_error as Resolved.

We already have this as eina_error_get(). It just isn't implemented or used widely.

Apr 30 2020, 6:23 AM · efl: api
zmike closed D11766: ecore_evas: only define these eina errors once.
Apr 30 2020, 6:23 AM · efl
zmike accepted D11766: ecore_evas: only define these eina errors once.
Apr 30 2020, 6:21 AM · efl

Apr 29 2020

zmike closed T8689: elm file selector can't open subdirs in expandable mode as Resolved by committing rEFLf21df93595f1: elm_fileselector: support expandable items.
Apr 29 2020, 8:47 AM · efl (efl-1.24)
zmike closed D11765: elm_fileselector: support expandable items.
Apr 29 2020, 8:47 AM · efl
zmike accepted D11765: elm_fileselector: support expandable items.

I guess my interpretation of that comment was that it acknowledged the problem that was happening without this patch where the model monitoring/processing was screwed up, but maybe I was just reading too much into it.

Apr 29 2020, 8:22 AM · efl
zmike added a comment to D11765: elm_fileselector: support expandable items.

Sure, but by successfully changing the model now it seems like that covers the case that the comment was mentioning, doesn't it?

Apr 29 2020, 7:12 AM · efl
zmike added a comment to D11765: elm_fileselector: support expandable items.

I recall seeing a TODO comment about monitoring for subitems which is probably addressed by this patch. Can you remove that to avoid future confusion?

Apr 29 2020, 6:46 AM · efl

Apr 28 2020

zmike added a comment to T8689: elm file selector can't open subdirs in expandable mode.

I spent some time on this, and it seems that the model created in _populate() to generate the listing for this case is destroyed in _process_last(). This occurs due to efl_model_children_count_get() returning 0 since the underlying filter model is expecting to process asynchronously even though the io model has already filled in its file data. The model being filtered is destroyed before it can filter, which prevents any files from being processed.

Apr 28 2020, 11:14 AM · efl (efl-1.24)
zmike added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

Seems to be installed as part of google-noto-emoji-color-fonts-20190829-1.fc31.noarch on my machine. I'm running it through travis now to confirm https://travis-ci.org/github/Enlightenment/efl/builds/680581257

Apr 28 2020, 6:58 AM · efl

Apr 27 2020

zmike added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

I get this error if I try to run the test:

Apr 27 2020, 7:12 AM · efl
zmike requested review of D11760: tests/elm: add callback testing to image memfile test.
Apr 27 2020, 6:53 AM · efl
zmike requested review of D11759: elm/cnp: remove const from static function return.
Apr 27 2020, 6:52 AM · efl

Apr 24 2020

zmike added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

Good work on the test, some minor cleanups and it looks ok to me

Apr 24 2020, 8:55 AM · efl
zmike requested changes to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.
Apr 24 2020, 8:53 AM · efl

Apr 23 2020

zmike added a comment to D11746: elm: add basic support for efl_part to elm_widget_item.

Not actually sure if this is useful (and we shouldn't be considering merging before the release), but I thought maybe it'd be interesting to start a discussion.

Apr 23 2020, 6:52 AM · efl
zmike added a comment to D11752: tests/elm: add more naviframe tests.

No, it's not a FIXME, just a note for anyone considering adding tests for it.

Apr 23 2020, 6:49 AM · efl

Apr 22 2020

zmike requested review of D11752: tests/elm: add more naviframe tests.
Apr 22 2020, 10:26 AM · efl
zmike added a child revision for D11751: tests/elm: add util callback for capturing event_info in smart callbacks: D11752: tests/elm: add more naviframe tests.
Apr 22 2020, 10:26 AM · efl
zmike requested review of D11751: tests/elm: add util callback for capturing event_info in smart callbacks.
Apr 22 2020, 10:25 AM · efl
zmike requested review of D11750: tests/elm: add some more specific convenience macros for size checks.
Apr 22 2020, 10:25 AM · efl
zmike requested review of D11749: tests/elm: check all objects for signal interface before calling signal funcs.
Apr 22 2020, 10:24 AM · efl
zmike requested review of D11748: tests/elm: add a list sizing test.
Apr 22 2020, 10:23 AM · efl
zmike added a child revision for D11747: elm/list: avoid erroring on non-elm item contents: D11748: tests/elm: add a list sizing test.
Apr 22 2020, 10:23 AM · efl
zmike requested review of D11747: elm/list: avoid erroring on non-elm item contents.
Apr 22 2020, 10:23 AM · efl
zmike requested review of D11746: elm: add basic support for efl_part to elm_widget_item.
Apr 22 2020, 10:22 AM · efl
zmike added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

We already have unit tests which trigger key and mouse events.

Apr 22 2020, 7:21 AM · efl
zmike added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

It seems like the test case provided could be made into a unit test which programmatically moves the text cursor?

Apr 22 2020, 6:10 AM · efl

Apr 21 2020

zmike resigned from D10242: build: install eo files per default.

yea whatever

Apr 21 2020, 8:02 AM · efl
zmike accepted D11730: efl_ui_focus_manager_calc: correctly flag elements used.
Apr 21 2020, 8:00 AM · efl
zmike requested changes to D11727: exactness: use convinience ecore_file function to get dir.

From memory, I think path now needs to be freed.

Apr 21 2020, 6:55 AM · efl