Page MenuHomePhabricator
Feed Advanced Search

Yesterday

zmike requested review of D9091: tests: add functional unit tests for radio widgets.
Fri, Jun 14, 10:13 AM · efl
zmike added a comment to T7898: efl.ui.format.

https://i.imgur.com/m4vDHwO.gifv

Fri, Jun 14, 10:10 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

We try to leave some functionality to the imagination of the user; no docs can possibly hope to capture the gestalt of efl's splendor.

Fri, Jun 14, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.

I think you would use the callback?

Fri, Jun 14, 9:07 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 9:06 AM · efl
zmike added a comment to T7900: efl.pack_table.

Future me.

Fri, Jun 14, 9:04 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike accepted D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Oh ok.

Fri, Jun 14, 9:04 AM · efl
zmike accepted D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 9:03 AM · efl
zmike added a comment to T7897: efl.ui.spin.

I agree with both of the above ideas.

Fri, Jun 14, 7:15 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7873: efl.ui.image.

I am wondering if we could not get rid of Efl.Ui.Image_Error and just use Eina_Error.

As for total percentage, if I remember correctly it is to reflect the multiple step of loading the image. You could be on a 50% of the downloading, but there is still decompressing, uploading texture and so on, so total percentage might be 25% with no indication on time that it would take to do the other percent.

Fri, Jun 14, 7:14 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7847: efl.ui.clickable.

After some thought, I think maybe an improvement on this could be using changed and changed,primary, where the latter indicates the left button has been pressed on a standard mouse configuration. This more definitively handles the case of e.g., left-handed mouse configuration for Xorg/Wayland and we can mention that the primary event will continue to work for right-handed configurations.

Fri, Jun 14, 7:10 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7866: efl.ui.nstate from Backlog to Evaluating on the efl: api board.
Fri, Jun 14, 7:01 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7866: efl.ui.nstate.

Does this class need to exist?

Fri, Jun 14, 7:01 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7900: efl.pack_table.

This is a good point. Let's cut it.

Fri, Jun 14, 6:59 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7976: Efl.Ui.Clickable_Clicked from Backlog to trivial on the efl: api board.
Fri, Jun 14, 6:57 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7976: Efl.Ui.Clickable_Clicked.

This seems pretty straightforward?

Fri, Jun 14, 6:57 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested changes to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Still a minor doc nit and then I'm okay with it.

Fri, Jun 14, 6:51 AM · efl
zmike added a comment to T7893: efl.ui.slider.

I think that's also not quite what we want either?

Fri, Jun 14, 6:48 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to D9060: efl_ui_radio: cleanup API.

One of the main points of the efl_add extended construction mechanics was to allow things like this, where you could set all the properties during construction. The only thing that perhaps was not clearly defined from here would be e.g., whether packing the widget into a box during construction is allowed, but probably we did want that functionality too so that every function can be called during construction.

Fri, Jun 14, 6:47 AM · efl
zmike requested review of D9089: efl_ui/layout: apply theme during constructor if widget class has been set.

This doesn't change any existing mechanics, it just calls theme apply at the end of construction if the widget's class has already been set. As you can see, if the theme apply fails then it maintains the current behavior; I think this fallback will only be triggered for actual error cases, however.

Fri, Jun 14, 6:44 AM · efl: widgets

Thu, Jun 13

zmike added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Yeah, creating logical groups of widgets might make sense, but I see no benefit right now for widgets other than Radio Buttons...

Related: How do you create in Elm a box around a set of widgets to visually group them? Like elementary_test does.

Thu, Jun 13, 9:51 AM · efl
zmike added a comment to D8919: efl_ui_navigation_bar: migrate to active_view.

A couple points on the issues raised by @segfaultxavi:

  • it's not a crash, the test is intentionally written to close if the prev button is clicked from the first layout
  • this looks like a widget/clickable: the problem here is that the window is destroyed from the click callback out of clickable, but widget itself listens directly to evas mouse events (_obj_mouse_up) and then propagates focus from the widget class's mouse-up callback
Thu, Jun 13, 9:50 AM · efl
zmike added a comment to T7893: efl.ui.slider.

I think the issue for me is that changed is still in the signal name, and changed implies that a change was completed. Having changed,stable or similar is weird because it implies that regular changed events are not "complete".

Thu, Jun 13, 9:35 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

it does seem like there is more use case for this than just the radio widget...

I cannot see them. Which ones do you have in mind?
The Radio_Box makes sure there's only one radio button selected. What functionality does Widget_Box offer to its children widgets?

Thu, Jun 13, 9:20 AM · efl
zmike added a comment to T7893: efl.ui.slider.

That's a good point, but stable has sort of a weird feel to it as well.

Thu, Jun 13, 9:13 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested changes to D9060: efl_ui_radio: cleanup API.

I've fixed this behavior with D9089, so all those changes can be removed since they should work as expected once that patch lands.

Thu, Jun 13, 7:39 AM · efl
zmike added a parent revision for D9060: efl_ui_radio: cleanup API: D9089: efl_ui/layout: apply theme during constructor if widget class has been set.
Thu, Jun 13, 7:38 AM · efl
zmike added a child revision for D9089: efl_ui/layout: apply theme during constructor if widget class has been set: D9060: efl_ui_radio: cleanup API.
Thu, Jun 13, 7:38 AM · efl: widgets
zmike requested review of D9089: efl_ui/layout: apply theme during constructor if widget class has been set.
Thu, Jun 13, 7:38 AM · efl: widgets
zmike added a commit to T7865: efl.ui.check: rEFL3a5f506b0e87: efl_ui_check: make it undependend of nstate.
Thu, Jun 13, 6:22 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9018: efl_ui_check: make it undependend of nstate.
Thu, Jun 13, 6:22 AM · efl
zmike moved T7863: efl.ui.direction from Evaluating to Stabilized on the efl: api board.
Thu, Jun 13, 6:17 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7853: efl.text_interactive.

Maybe Efl.Text_Cursor_Info ?

Thu, Jun 13, 6:17 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7964: Efl.Input.Key.

This is basically copied out of X11 terminology since that's what EFL was originally written around. key is the name of the key that was pressed (determined after processing) while key_name is the raw name of the key that was pressed. compose is compose keys...you know...where you press your compose key and get those funny little marks that non-english languages need.

Thu, Jun 13, 6:16 AM · efl (efl-1.23), efl: api
zmike added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

I'm wondering if we want to have some kind of Widget_Box class that can be used by various widgets instead of a specific Radio_Box. Maybe not all widgets would support or use this type of thing, but as I pointed out previously it does seem like there is more use case for this than just the radio widget...

Thu, Jun 13, 6:14 AM · efl
zmike added a comment to T7965: Efl.Input.Hold.

I'm not sure if it needs to be; I've never seen it used by an application. @cedric what do you think?

Thu, Jun 13, 6:12 AM · efl (efl-1.23), efl: api
zmike added a comment to T7897: efl.ui.spin.

I agree with both of the above ideas.

Thu, Jun 13, 6:11 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to D9060: efl_ui_radio: cleanup API.

I'll check some things out. Other than the constructor usage this seems okay.

Thu, Jun 13, 6:10 AM · efl
zmike moved T7578: efl.ui.view from Evaluating to Stabilized on the efl: api board.
Thu, Jun 13, 6:06 AM · efl (efl-1.23), efl: api
zmike added a comment to T7578: efl.ui.view.

Docs need to be improved for everything, that's not a blocker. It seems like this is simple enough that nothing could go wrong.

Thu, Jun 13, 6:06 AM · efl (efl-1.23), efl: api

Wed, Jun 12

zmike moved T7847: efl.ui.clickable from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 9:52 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7847: efl.ui.clickable.

It feels a bit weird to split the clicked event between [primary button] and [any button]?

Wed, Jun 12, 9:52 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7897: efl.ui.spin from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 9:51 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.

This special_value is pretty weird. It feels like it should be a format thing?

Wed, Jun 12, 9:50 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.
struct @beta Efl.Ui.Spin_Special_Value
{
   [[Special value]]
   value: double; [[Target value]]
   label: string; [[String to replace]]
}
Wed, Jun 12, 9:49 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7893: efl.ui.slider from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 9:49 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7893: efl.ui.slider.

The changed events should send the current value, otherwise I guess this is okay?

Wed, Jun 12, 9:49 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7873: efl.ui.image.

The progress struct seems okay, the error struct is weird and I hate it; if there's no error then the status should be 0 since that's how Eina_Error works (and status is an Eina_Error), and there should be no bool.

Wed, Jun 12, 9:47 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7873: efl.ui.image.

also includes:

Wed, Jun 12, 9:44 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7873: efl.ui.image from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 9:43 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7973: Efl.Input.Value.

This should, at minimum, be renamed to something like Pointer_State or something including the word Pointer.

Wed, Jun 12, 9:41 AM · efl (efl-1.23), efl: api
zmike added a comment to T7578: efl.ui.view.

What's going on with this?

Wed, Jun 12, 9:40 AM · efl (efl-1.23), efl: api
zmike added a comment to T7863: efl.ui.direction.

This is done?

Wed, Jun 12, 9:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7580: efl.ui.factory.

So is this okay or what?

Wed, Jun 12, 9:40 AM · efl (efl-1.23), efl: api
zmike added a comment to T7729: Efl.Gfx.Event.Render_Post uses list<>.

@cedric are we doing anything with this?

Wed, Jun 12, 9:39 AM · efl (efl-1.23), Restricted Project, efl: api
zmike added a comment to T7853: efl.text_interactive.

This seems mostly okay, though I would expect that the event would pass the selection info...possibly as an array[2] of cursors?

Wed, Jun 12, 9:34 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7880: efl.ui.bg from Evaluating to trivial on the efl: api board.
Wed, Jun 12, 9:24 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7880: efl.ui.bg.

This is just a hybrid layout+image object with a defined theme (group efl/bg). Pretty simple, seems okay.

Wed, Jun 12, 9:24 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7865: efl.ui.check.

I'm not aware of any kind of tristate type widget, I guess this was some kind of future-proofing? Would be good to get @woohyun or @Jaehyun_Cho to reply here.

Wed, Jun 12, 9:21 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7867: efl.ui.radio.

@bu5hm4n can you update this with what it's (probably) going to look like after all your changes land?

Wed, Jun 12, 9:19 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added inline comments to D9060: efl_ui_radio: cleanup API.
Wed, Jun 12, 9:19 AM · efl
zmike closed D9088: ci: travis: switch to newer distro releases.
Wed, Jun 12, 8:44 AM · efl
zmike accepted D9088: ci: travis: switch to newer distro releases.
Wed, Jun 12, 8:43 AM · efl
zmike added a comment to D9088: ci: travis: switch to newer distro releases.

nvm I see

Wed, Jun 12, 8:43 AM · efl
zmike added a comment to D9088: ci: travis: switch to newer distro releases.

Is there a travis result I can check to verify that this works?

Wed, Jun 12, 8:43 AM · efl
zmike closed T7701: Rename Efl.Ui.Stack as Resolved.

This is now something else entirely so I'm closing the task.

Wed, Jun 12, 7:42 AM · efl: api
zmike moved T7945: enum Efl.Text_Style_Underline_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7944: enum Efl.Text_Style_Shadow_Direction from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7943: enum Efl.Text_Style_Effect_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7942: enum Efl.Text_Style_Backing_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7941: enum Efl.Text_Style_Strikethrough_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7940: enum Efl.Text_Format_Wrap from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7938: enum Efl.Text_Font_Slant from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7937: enum Efl.Text_Font_Width from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7936: enum Efl.Text_Font_Bitmap_Scalable from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7935: enum Efl.Text_Font_Weight from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7934: type Efl.Font.Size from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7933: struct Efl.Ui.Text_Change_Info from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7916: enum Efl.Ui.Selection_Format from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl (efl-1.23), efl: api
zmike moved T7915: enum Efl.Ui.Selection_Type from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl (efl-1.23), efl: api
zmike moved T7914: struct Efl.Ui.Selection_Changed from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl (efl-1.23), efl: api
zmike moved T7913: function Efl.Ui.Selection_Data_Ready from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl (efl-1.23), efl: api
zmike moved T7896: efl.access.value from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7886: efl.access.selection from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:39 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7874: efl.ui.draggable from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7858: efl.text_markup from Backlog to trivial on the efl: api board.
Wed, Jun 12, 7:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7857: efl.text_style from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7856: efl.text_format from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7855: efl.text_font from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:38 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7853: efl.text_interactive from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 7:37 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7854: efl.text from Backlog to trivial on the efl: api board.
Wed, Jun 12, 7:37 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7851: efl.access.editable.text from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7850: efl.access.text from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7880: efl.ui.bg from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7865: efl.ui.check from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7867: efl.ui.radio from Backlog to Evaluating on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7849: efl.ui.text from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:36 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike moved T7587: efl.access.action from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:36 AM · efl (efl-1.23), efl: api
zmike moved T7573: efl.ui.l10n from Backlog to needs experts on the efl: api board.
Wed, Jun 12, 7:36 AM · efl (efl-1.23), efl: api