Page MenuHomePhabricator
Feed Advanced Search

Yesterday

segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Hmmmm... you are correct. We had not found any such case before.

Wed, Jun 26, 11:49 PM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7865: efl.ui.check.
Wed, Jun 26, 6:43 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi reassigned T7717: docs todo from segfaultxavi to myoungwoon.
Wed, Jun 26, 4:31 AM · efl (efl-1.23), efl: docs, efl: api
segfaultxavi added a comment to T7946: enum Efl.Ui.Popup_Align.

Besides what @bu5hm4n just said:

Wed, Jun 26, 3:48 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9178: csharp: fix Eina_Stringshare support in containers for manual and generated API.

Adding @segfaultxavi to know if he is OK with the change in the Efl.Csharp.Application.OnInitialize method.

Wed, Jun 26, 12:49 AM · efl
segfaultxavi added a comment to T7865: efl.ui.check.

Yeah, definitely. selected is about choosing one option among many, and we only care about on or off here.
I could go with active but it looks too similar with enabled (meaning that the widget can be interacted with)... how about check, cross, mark, stroke or check_state?

Wed, Jun 26, 12:38 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

I'll work on this then.

Wed, Jun 26, 12:26 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi moved T7898: efl.ui.format from Backlog to Evaluating on the efl: api board.
Wed, Jun 26, 12:25 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Jun 25

segfaultxavi closed D9153: evas_common_format_color_parse: support color names.
Tue, Jun 25, 10:28 AM · efl
segfaultxavi accepted D9153: evas_common_format_color_parse: support color names.

@segfaultxavi to be honest I do not know what is the meaning of this calculation, why it multiple each color channel with alpha.

It's probably because it works with premultiplied alpha.

Tue, Jun 25, 10:27 AM · efl
segfaultxavi added a comment to D9153: evas_common_format_color_parse: support color names.

Sure, sure, I'm not questioning the theory... I just said I want to see what our CI thinks about it :D

Tue, Jun 25, 9:40 AM · efl
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

Well, there is now. Kill. This. With. Fire.

Tue, Jun 25, 9:22 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D9153: evas_common_format_color_parse: support color names.

I like that you used an already-existing function (bsearch), let's see if it is available in all platforms.

Tue, Jun 25, 8:18 AM · efl
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

Well, if it's a list, it's fugly. Why don't we use an Eina list? or array? or literally ANY other thing before the words first, second, third, ...

Tue, Jun 25, 7:44 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

This is how I would like this mixin to work:

Tue, Jun 25, 7:40 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7947: Efl.Ui.Anchor_Popup.

I would like to know the meaning of those extraterrestrial first, second, third, ... parameters to align_priority. What is that?

Tue, Jun 25, 7:23 AM · efl (efl-1.23), efl: language bindings
segfaultxavi edited the content of Main.
Tue, Jun 25, 7:14 AM
segfaultxavi edited the content of Efl Api Stabilization Workflow.
Tue, Jun 25, 7:12 AM · efl: api
segfaultxavi added a comment to T7895: efl.ui.range_display.

+1

Tue, Jun 25, 6:30 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated the task description for T7895: efl.ui.range_display.
Tue, Jun 25, 6:30 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi created Efl Api Stabilization Workflow.
Tue, Jun 25, 6:14 AM · efl: api

Mon, Jun 24

segfaultxavi added a comment to T7948: Efl.Ui.Alert_Popup.

I also think using the enum in the event info is good enough, and that using parts would complicate things too much.
If anybody needs a more flexible popup, he can always extend from Efl.Ui.Popup, no?

Mon, Jun 24, 4:13 AM · efl (efl-1.23), efl: language bindings

Sat, Jun 22

segfaultxavi requested changes to D9153: evas_common_format_color_parse: support color names.

Hi @ali.alzyod, nice work!

Sat, Jun 22, 3:49 AM · efl

Fri, Jun 21

segfaultxavi resigned from D9105: evas: add a test for loading Android 9patch file..

Ah, OK. Since I found no reference to it in the code I thought it was a mistake :)

Fri, Jun 21, 9:12 AM · efl
segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Scrollbars can just ignore the inverted flag. We will document it. I think users will understand :)

Fri, Jun 21, 7:09 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

@CHAN Why would you call it formatted_string_set? It's a property, so the _set and _get will be generated automatically for C.

Fri, Jun 21, 4:47 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7967: Efl.Input.Event.

So we agree one of the two sets of flags should be removed?

Fri, Jun 21, 2:52 AM · efl (efl-1.23), efl: api

Thu, Jun 20

segfaultxavi requested changes to D9105: evas: add a test for loading Android 9patch file..

What's that 9patch_test.9.png.png file?

Thu, Jun 20, 11:26 PM · efl
segfaultxavi added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

@cedric can you also rename the other two region properties?
Maybe in another patch, to avoid a whole patchset rebase...

Thu, Jun 20, 10:37 PM · efl
segfaultxavi added a comment to T7967: Efl.Input.Event.

OK, but that's weird, we have no such convenience proxies anywhere else.

Thu, Jun 20, 9:01 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7967: Efl.Input.Event.

I mean that the event_flags property (which is @pure virtual) already has flags named processed and scrolling. Why do we also have processed and scrolling properties (regular properties)???

Thu, Jun 20, 8:21 AM · efl (efl-1.23), efl: api
segfaultxavi added inline comments to D9142: efl_input_device: split up has_pointer_cap.
Thu, Jun 20, 8:04 AM · efl
segfaultxavi added a commit to T7867: efl.ui.radio: rEFLff97b0ed3dec: Efl.Ui.Radio: Update docs.
Thu, Jun 20, 8:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D9061: Efl.Ui.Radio: Update docs.
Thu, Jun 20, 8:03 AM · efl
segfaultxavi added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

You made me look into this in more detail, and I found another issue. There's another property here called border_center_fill which is very related to the newly introduced content_zone. These two need to be consistent.

Thu, Jun 20, 7:58 AM · efl
segfaultxavi accepted D9141: efl_input_key: compose -> compose_string.
Thu, Jun 20, 7:36 AM · efl
segfaultxavi added a comment to T7967: Efl.Input.Event.

I do not understand this part:

@property processed {
   [[$true if @.event_flags indicates the event is on hold.]]

From the flag's description in efl_input_types.eot it looks like a better name would be in_process.

Thu, Jun 20, 7:28 AM · efl (efl-1.23), efl: api
segfaultxavi added inline comments to D9142: efl_input_device: split up has_pointer_cap.
Thu, Jun 20, 7:21 AM · efl
segfaultxavi accepted D9135: efl_input_pointer: rename tool to touch_id.

No further doc concerns.

Thu, Jun 20, 7:21 AM · efl
segfaultxavi added a comment to T7900: efl.pack_table.

Exactly. Right now there's only the combined property and we cannot find a good name for it, so I propose to split it. The separate properties are hopefully easier to name.

Thu, Jun 20, 7:13 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi accepted D9136: efl_canvas_scene: we never provided a object as event type here.

Seems legit.

Thu, Jun 20, 7:00 AM · efl
segfaultxavi added inline comments to D9132: efl_input_pointer: rename tool to touch_id.
Thu, Jun 20, 5:21 AM · efl
segfaultxavi closed D9131: evas_textblock: more descriptive parameter names.
Thu, Jun 20, 5:08 AM · efl
segfaultxavi accepted D9131: evas_textblock: more descriptive parameter names.

Sure, much clearer and no harm done :)

Thu, Jun 20, 5:07 AM · efl
segfaultxavi added a comment to T7898: efl.ui.format.

@CHAN The only usability issue is that it is not clear what happens when you use both format_cb and format_string. Better docs will fix that.

Thu, Jun 20, 5:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

We already have the format_cb mechanism in place which allows the user to do anything he wants.

Thu, Jun 20, 3:27 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

cell_column_get and cell_row_get are my last offer.

Thu, Jun 20, 3:10 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7893: efl.ui.slider.

@woohyun I was trying to push the fix and I could not because you beat me by 1h :D

Thu, Jun 20, 2:47 AM · efl: api, efl (efl-1.23), efl: language bindings
Herald raised the priority of T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set from High to Showstopper Issues.
Thu, Jun 20, 1:44 AM · regression, efl
segfaultxavi added a comment to T8017: efl-mono: in-tree examples do not build anymore.

The texteditor example can be fixed by setting Multiline after calling SetHintSizeMin, so there's something bogus there. I'll create a ticket.

Thu, Jun 20, 1:37 AM · efl: language bindings
segfaultxavi added a comment to T8017: efl-mono: in-tree examples do not build anymore.

Happens also in C, so I guess you can submit your build fixes and we'll take care of the rendering errors later.

Thu, Jun 20, 1:28 AM · efl: language bindings
segfaultxavi added a comment to T8017: efl-mono: in-tree examples do not build anymore.

Hmmm.... The texteditor example starts with a single-line text entry, which expands to use all available space once you enter any char. It should be maximized from the beginning.

Thu, Jun 20, 1:27 AM · efl: language bindings
segfaultxavi added a comment to D9096: evas: add support for stretchable region..

Docs look mostly fine now... remaining nuances should be taken care of in a general documentation sweep later on.

Thu, Jun 20, 1:16 AM · efl
segfaultxavi added a comment to T7893: efl.ui.slider.

@escwyp is right, legacy sliders are broken now (take elementary_config's Scale slider, for example). I'm looking into it.

Thu, Jun 20, 1:08 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Jun 19

segfaultxavi added a comment to T7900: efl.pack_table.

I like big charts and I cannot lie.

Wed, Jun 19, 7:29 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

Allow me to summarize these interfaces because I am loosing perspective. Efl.Pack_Table and Efl.Pack_Linear are the interfaces to handle 2D and 1D arrangements of widgets, respectively. The important thing here is that they are consistent, I think.

Wed, Jun 19, 3:52 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi updated subscribers of T7494: C#: Mark protected methods as protected.

I think this is (again) an example of something that EO supports and one of the binding languages does not.

Wed, Jun 19, 1:46 AM · efl: language bindings
segfaultxavi added a commit to T7895: efl.ui.range_display: rEFL969c7f72877c: efl_ui_range_display: range_min_max -> range_limits.
Wed, Jun 19, 1:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi closed D9110: efl_ui_range_display: range_min_max -> range_limits.
Wed, Jun 19, 1:03 AM · efl: api
segfaultxavi accepted D9110: efl_ui_range_display: range_min_max -> range_limits.

Looks fine, builds fine, tests are fine.

Wed, Jun 19, 1:03 AM · efl: api
segfaultxavi added a comment to T4834: Efl.Ui.Slider step property is weird.

Looks like the result is that the API is fine, but there are implementation issues.

Wed, Jun 19, 12:52 AM · efl: api, efl: widgets
segfaultxavi added a comment to T7946: enum Efl.Ui.Popup_Align.

Yeah, that's a good point! Let's use two floats and get rid of another type :)

Wed, Jun 19, 12:46 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Jun 18

segfaultxavi accepted D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

The problems I was seeing disappear after adding the whole patchset, so I got no further issues with this.

Tue, Jun 18, 10:16 AM · efl
segfaultxavi added a comment to T7858: efl.text_markup.

Dunno how to read that

Tue, Jun 18, 9:25 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7964: Efl.Input.Key.

That much I concede.

Tue, Jun 18, 9:23 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7898: efl.ui.format.

Yes, that is the concept.

Tue, Jun 18, 9:21 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

The callback can handle every case. format_string is useful for printf-like strings, and I think special_value could be beneficial too.
I would not consider it a corner case, since that is how spinners with weekday names, or month names are implemented.

Tue, Jun 18, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7895: efl.ui.range_display.

We seem to have far more properties in our API with limit than with min_max, so OK, I buy that.

Tue, Jun 18, 9:16 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

Shouldn't all users of this class use Efl.Ui.Layout_Orientation instead?
For example, Efl.Ui.Scrollbar should implement the Efl.Ui.Layout_Orientable interface instead of defining its own enum with the same values.

Tue, Jun 18, 6:24 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7858: efl.text_markup.

What kind of markup do we actually use? Is this documented anywhere?

Tue, Jun 18, 4:03 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added inline comments to D8920: efl_ui_stack: remove!.
Tue, Jun 18, 3:55 AM · efl
segfaultxavi added a comment to T7854: efl.text.

Don't know how it could be bad, given how simple it is.

Tue, Jun 18, 3:46 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

Some of my comments regarding docs have not been addressed yet, so I am not approving this!
(Remember to mark comments as done to avoid forgetting about them)

Tue, Jun 18, 3:42 AM · efl
segfaultxavi added a comment to T7964: Efl.Input.Key.

Well, OK. This seems general enough (by the sheer amount of properties it has) to future-proof us for the time being. It only needs docs.

Tue, Jun 18, 3:32 AM · efl (efl-1.23), efl: api
segfaultxavi added a comment to T7893: efl.ui.slider.

It's not the same thing. You can receive steady events before receiving the drag,stop event.

Tue, Jun 18, 3:26 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

I agree it is convenient to be able to access both axes at the same time. Let's leave table_size, but we still need a new name for it, though.

Tue, Jun 18, 3:20 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

Agreed. This is confusing. This is how it works (after examining the code):

Tue, Jun 18, 2:47 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

OK, I think the special_value property is redundant if we use the Efl.Ui.Format mixin. Probably a leftover from older times.

Tue, Jun 18, 2:32 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7894: efl.ui.range_interactive.

Yep, just verified. Looks good to me.

Tue, Jun 18, 2:26 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7895: efl.ui.range_display.

This looks OK to me too. Docs need polishing, as usual.

Tue, Jun 18, 2:17 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

Hmmmm... @Jaehyun_Cho raises a good point. It is weird that push always packs to index 0 whereas pop unpacks from active_index. We need to use the same approach on both methods.

Tue, Jun 18, 1:31 AM · efl

Mon, Jun 17

segfaultxavi added a comment to D9096: evas: add support for stretchable region..

Weird indentation suggests you mixed tabs and spaces... there's a special circle in hell for people of your kind.

Mon, Jun 17, 10:47 AM · efl
segfaultxavi added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

I've read all image-related eo files and I cannot find any property named "area". What did you have in mind, @zmike?

Mon, Jun 17, 7:52 AM · efl
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi this depends on the parameter, when delete_on_transition_end is true, then the user does not need to care about the value of the promise [...] When the user passes false as argument, then the user *needs* to handle the value of the promise.

OK, understood. I am OK with using an Eina_Future.

Mon, Jun 17, 7:15 AM · efl
segfaultxavi added a comment to D9091: tests: add functional unit tests for radio widgets.

This will need to adapt after D9058 lands.
Also, it could check that there's only one selected button in the group. That's an issue I am facing now.

Mon, Jun 17, 5:31 AM · efl
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

This still does not work for me (buttons are not mutually exclusive), I am currently debugging. I would appreciate if anybody else tested this patch and told me if it works for him.

Mon, Jun 17, 4:52 AM · efl

Sat, Jun 15

segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@bu5hm4n I'm not arguing against using a Promise, I'm just trying to see if there are alternatives :)

Sat, Jun 15, 6:46 AM · efl

Fri, Jun 14

segfaultxavi added a comment to D9060: efl_ui_radio: cleanup API.

Good point! Agreed!

Fri, Jun 14, 11:03 AM · efl
segfaultxavi added a comment to T7898: efl.ui.format.

https://media.giphy.com/media/oOX5qIDkzDjeo/giphy.gif

Fri, Jun 14, 9:45 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

I've written my concerns in T7898.

Fri, Jun 14, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

This class needs serious doc love. I do not understand how format_cb and format_string are supposed to interact. Also, Format_Func_Cb only has input parameters, no output, where is the formatted string supposed to be written?

Fri, Jun 14, 9:17 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

And I still don't know how would you implement the special values with a format string.

Fri, Jun 14, 8:25 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

When you say "Let us cut it"... who exactly is us? 😁

Fri, Jun 14, 8:22 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added inline comments to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.
Fri, Jun 14, 8:20 AM · efl
segfaultxavi requested review of D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 7:59 AM · efl
segfaultxavi added a comment to T7847: efl.ui.clickable.

I like "primary" more than "any", yep.

Fri, Jun 14, 7:11 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi assigned T8012: Support default values @property's keys and method's params in eo to lauromoura.

So, if I understood correctly, when a parameter has a default value in an Eo file like this:

center @beta {
   params {
      @in h : bool(true);
      @in v : bool(true);
   }
Fri, Jun 14, 4:14 AM · efl: language bindings, Restricted Project
segfaultxavi added a reviewer for D9070: eo: add an API entry for custom instantiation of Eo objects for binding usage: q66.

Probably @q66 also wants to know about this.

Fri, Jun 14, 4:10 AM · efl
segfaultxavi triaged T8017: efl-mono: in-tree examples do not build anymore as Normal priority.
Fri, Jun 14, 2:59 AM · efl: language bindings
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Thanks. And I see the Unified equivalent is Efl.Ui.Frame. I had never come across it.

Fri, Jun 14, 2:01 AM · efl