Page MenuHomePhabricator
Feed Advanced Search

Today

segfaultxavi accepted D8424: efl_ui_selection: give this event a better name.

Understood. Makes sense. This is a beta mixin anyway :)

Wed, Mar 20, 8:22 AM · efl
segfaultxavi accepted D8421: elm_gesture_layer: Use flag returned by gesture callbacks.

Thanks a lot for a very detailed answer :)

Wed, Mar 20, 8:11 AM · efl
segfaultxavi accepted D8423: efl_ui_list_view: remove not used event.

Not even emitted from the class? Nice.

Wed, Mar 20, 7:51 AM · efl
segfaultxavi added a comment to D8424: efl_ui_selection: give this event a better name.

What is the Window Manager's selection? I mean, what is the difference between EFL's selection the WM's selection?
To be sure, EFL's selection is what happens when you select text (shift+cursors) in a text entry, right?

Wed, Mar 20, 7:45 AM · efl
segfaultxavi closed D8422: efl: Add missing docs to parameters..
Wed, Mar 20, 6:13 AM · efl
segfaultxavi accepted D8422: efl: Add missing docs to parameters..
Wed, Mar 20, 6:12 AM · efl
segfaultxavi requested changes to D8422: efl: Add missing docs to parameters..
Wed, Mar 20, 5:40 AM · efl
segfaultxavi edited projects for T5730: No Consistency of smart callbacks for DISABLED widgets, added: efl; removed efl: language bindings.
Wed, Mar 20, 5:28 AM · efl
segfaultxavi added a comment to T7760: Document event info calling convention.

I clarified a bit what this task is about. I am not sure where these docs would fit, though.
The user-facing part (retrieving event info from an event struct) probably goes here:
https://www.enlightenment.org/develop/guides/c/core/events.md
But I don't know about the internal part (calling efl_event_callback_call). Maybe in the docs for efl_event_callback_call in Eo.h?
How many methods exist which accept an event_info?

Wed, Mar 20, 5:21 AM · Restricted Project, efl (efl-1.22), efl: api
segfaultxavi renamed T7760: Document event info calling convention from Document our new calling convention to Document event info calling convention.
Wed, Mar 20, 5:17 AM · Restricted Project, efl (efl-1.22), efl: api
segfaultxavi added a comment to D8421: elm_gesture_layer: Use flag returned by gesture callbacks.

This looks like an obvious fix, but how can I check the results?
New API elementary_test (Gesture) does not seem to be working for me at this moment.
Old API elementary_test (Gesture Layer 1, 2 and 3) all seem to be working just fine without this patch.

Wed, Mar 20, 5:09 AM · efl
segfaultxavi added a commit to T5328: Refactor/rename container, pack, ... interface: rEFL37c703437a4d: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 4:54 AM · efl, Restricted Project
segfaultxavi added a commit to T5719: Force all apis to be implemented: rEFL37c703437a4d: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 4:54 AM · Restricted Project, efl: language bindings, Restricted Project
segfaultxavi closed D8420: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 4:54 AM · efl
segfaultxavi accepted D8420: efl.pack_table: inherit efl.pack instead of efl.pack_linear.

Makes sense and simplifies code. Builds and passes tests.

Wed, Mar 20, 4:54 AM · efl
segfaultxavi added a comment to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

I am having troubles understanding how Index works. Please, correct me if I am wrong.
Negative indices only mean that you count from last to first, instead of first to last, right?
So, if a container has 4 items, you can access the first one using index 0 or index -4, and you can access the last item using index 3 or index -1. Correct?
In this case, the docs could be clarified a bit.
Also, some methods (like pack_content_get) accept the [-count, count-1] range, whereas other methods accept the [0, count-1] range (like pack_index_get). The docs for each method should clearly state the valid range.

Wed, Mar 20, 4:40 AM · efl
segfaultxavi edited projects for T7761: eina: eina_future_as_value needs improved docs, added: efl: docs; removed efl.
Wed, Mar 20, 4:03 AM · efl: docs
segfaultxavi renamed T7761: eina: eina_future_as_value needs improved docs from eina: eina_future_as_value might be misleading to eina: eina_future_as_value needs improved docs.
Wed, Mar 20, 4:03 AM · efl: docs
segfaultxavi closed D8370: csharp: Remove missing doc warning by filling them..
Wed, Mar 20, 3:36 AM · efl
segfaultxavi accepted D8370: csharp: Remove missing doc warning by filling them..
Wed, Mar 20, 3:35 AM · efl
segfaultxavi closed D8012: mono-docs: Use @since tags properly.
Wed, Mar 20, 3:23 AM · efl

Yesterday

segfaultxavi reopened D8395: efl_ui_widget: resolve warning about multiple defines.

I just reverted the landing in 8c39c0e2512732ed08a40552df52c4b4f791018f

Tue, Mar 19, 8:51 AM · efl
segfaultxavi closed D8395: efl_ui_widget: resolve warning about multiple defines.
Tue, Mar 19, 8:42 AM · efl
segfaultxavi accepted D8395: efl_ui_widget: resolve warning about multiple defines.
Tue, Mar 19, 8:38 AM · efl
segfaultxavi accepted D8397: efl-csharp: Add back I prefix for interfaces..

Doc refs are OK, and everything builds and passes tests.

Tue, Mar 19, 8:35 AM · efl
segfaultxavi added a commit to T7752: C#: Get rid of all lower-cased methods: rEFLd10ee74b9773: csharp: rename add/remove event handler.
Tue, Mar 19, 8:10 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi closed D8396: csharp: rename add/remove event handler.
Tue, Mar 19, 8:10 AM · efl
segfaultxavi accepted D8396: csharp: rename add/remove event handler.
Tue, Mar 19, 8:02 AM · efl
segfaultxavi added a comment to T7757: C#: Remove static_cast method.

Using the language mechanisms for casting (obj as Efl.Ui.Button) sounds better than having a custom method, from an API point of view. I do not know how hard that is, though.

Tue, Mar 19, 7:49 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a comment to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

Understood, but eina_future_as_value() does not wrap an Eina_Future in the value, it wraps an Eina_Promise, so... misleading :)

Tue, Mar 19, 7:42 AM · efl
segfaultxavi triaged T7761: eina: eina_future_as_value needs improved docs as Trivial priority.
Tue, Mar 19, 7:41 AM · efl: docs

Mon, Mar 18

segfaultxavi added a comment to D8353: elm_focus_legacy: Fix resource leaks.

This has broken the build for me:

../src/lib/elementary/elm_focus_legacy.c: In function ‘elm_object_focus_next’:
../src/lib/elementary/elm_focus_legacy.c:248:19: warning: implicit declaration of function ‘ELM_WIDGET_DATA_GET’;
Mon, Mar 18, 11:58 AM · efl
segfaultxavi closed D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mon, Mar 18, 11:48 AM · efl
segfaultxavi accepted D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.

The obvious fix is obvious.

Mon, Mar 18, 11:39 AM · efl
segfaultxavi added a comment to T7751: C#: Add back the I prefix to interfaces.

What? Are we going to change the API now?

Mon, Mar 18, 11:35 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a comment to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

First off, thank you both for giving my brain the opportunity to hurt so much.

Mon, Mar 18, 8:53 AM · efl
segfaultxavi resigned from D8367: elm_gengrid: speed up update order calls.

OK, thanks. I see there's a mild improvement in scrolling speed. It would be nice if this test output some numbers :)

Mon, Mar 18, 8:07 AM · efl
segfaultxavi requested changes to D8370: csharp: Remove missing doc warning by filling them..
Mon, Mar 18, 7:28 AM · efl
segfaultxavi added a comment to D8367: elm_gengrid: speed up update order calls.

Docs are a bit better now :)

Mon, Mar 18, 5:42 AM · efl
segfaultxavi added a comment to D8381: elm_fileselector_entry: only create model once.

Hmmm... I still get lots of errors on shutdown, including:

CRI<87656>:eo ../src/lib/eo/eo.c:1954 efl_unref() Calling efl_unref instead of efl_del or efl_parent_set(NULL). Temporary fallback in place triggered.
ERR<87656>:eina_safety ../src/lib/efl/interfaces/efl_interfaces_main.c:105 efl_part() safety check failed: efl_ref_count(r) == 1 is false
ERR<87656>:eina_safety ../src/lib/efl/interfaces/efl_interfaces_main.c:105 efl_part() safety check failed: efl_ref_count(r) == 1 is false
ERR<87656>:eo ../src/lib/eo/eo.c:1988 efl_unref() Obj:Efl.Canvas.Layout_Part_Invalid@0x400000244779. User refcount (-1) < 0. Too many unrefs.
ERR<87656>:eo ../src/lib/eo/eo_base_class.c:682 efl_del() Calling efl_del on object Efl.Canvas.Layout_Part_Invalid@0x40000005a335[4] with no parent is not advised any more.
ERR<87656>:eo ../src/lib/eo/eo.c:1988 efl_unref() Obj:Efl.Canvas.Layout_Part_Invalid@0x40000005a335. User refcount (-1) < 0. Too many unrefs.
ERR<87656>:eo ../src/lib/eo/eo.c:1988 efl_unref() Obj:Efl.Canvas.Layout_Part_Invalid@0x400000199835. User refcount (-1) < 0. Too many unrefs.
ERR<87656>:eo ../src/lib/eo/eo.c:1988 efl_unref() Obj:Efl.Canvas.Layout_Part_Invalid@0x400000244779. User refcount (-1) < 0. Too many unrefs.

Which is the error that this patch is supposed to fix?

Mon, Mar 18, 5:11 AM · efl
segfaultxavi closed D8380: examples_checks: add more configurations to how to run examples.
Mon, Mar 18, 4:48 AM · efl
segfaultxavi accepted D8380: examples_checks: add more configurations to how to run examples.

BEFORE PATCH:

Failed: 39/300
Errored: 78/300
Success: 207/300

AFTER PATCH:

Failed: 28/300
Errored: 74/300
Success: 219/300

So this patch makes this little script a bit more helpful.

Mon, Mar 18, 4:47 AM · efl
segfaultxavi closed D8379: edje-multisense: add the theme file.
Mon, Mar 18, 4:43 AM · efl
segfaultxavi accepted D8379: edje-multisense: add the theme file.

The example works now. Previously it was saying:

ERR<50510>: ../src/examples/edje/edje-multisense.c:42 create_my_group() could not load 'example_group' from multisense.edj: File Does Not Exist
Mon, Mar 18, 4:43 AM · efl
segfaultxavi closed D8378: edje-swallow2: differeniate between build dir and source dir.
Mon, Mar 18, 4:40 AM · efl
segfaultxavi accepted D8378: edje-swallow2: differeniate between build dir and source dir.

Confirmed that this allows running the example without being in the source directory.
I guess autotools does not get a fix, but since it's going to be deprecated, it's not a big deal.

Mon, Mar 18, 4:39 AM · efl
segfaultxavi closed D8377: inwin_example: shot can never be the preferend engine.
Mon, Mar 18, 4:34 AM · efl
segfaultxavi accepted D8377: inwin_example: shot can never be the preferend engine.

Confirmed that this fixes a segfault. Also, makes sense.

Mon, Mar 18, 4:33 AM · efl
segfaultxavi removed a parent revision for D8377: inwin_example: shot can never be the preferend engine: D8376: index_example_02: fix index example.
Mon, Mar 18, 4:32 AM · efl
segfaultxavi removed a child revision for D8376: index_example_02: fix index example: D8377: inwin_example: shot can never be the preferend engine.
Mon, Mar 18, 4:32 AM · efl
segfaultxavi closed D8376: index_example_02: fix index example.
Mon, Mar 18, 4:26 AM · efl
segfaultxavi accepted D8376: index_example_02: fix index example.

Confirmed: this fixes a segfault.

Mon, Mar 18, 4:26 AM · efl
segfaultxavi closed D8322: efl: remove EFL_EO_API_SUPPORT macro.
Mon, Mar 18, 4:14 AM · efl
segfaultxavi accepted D8322: efl: remove EFL_EO_API_SUPPORT macro.
Mon, Mar 18, 4:13 AM · efl
segfaultxavi requested changes to D8322: efl: remove EFL_EO_API_SUPPORT macro.

Builds and passes tests. Simple test apps (hello-cmd tutorial) can be compiled without defining EFL_EO_API_SUPPORT nor EFL_BETA_API_SUPPORT.

Mon, Mar 18, 3:58 AM · efl
segfaultxavi requested changes to D8367: elm_gengrid: speed up update order calls.
Mon, Mar 18, 2:48 AM · efl

Sun, Mar 17

segfaultxavi requested changes to D8370: csharp: Remove missing doc warning by filling them..

This removes ALL mono doc warnings except one. I want to land this! (but fix these issues first).

Sun, Mar 17, 8:41 AM · efl
segfaultxavi updated the task description for T7702: Remove internally generated classes from EFL# doc.
Sun, Mar 17, 8:12 AM · documentation, efl: language bindings
segfaultxavi added a commit to T7702: Remove internally generated classes from EFL# doc: rEFL8dca5fe677b2: csharp: Rename register_event_proxies..
Sun, Mar 17, 8:12 AM · documentation, efl: language bindings
segfaultxavi closed D8369: csharp: Rename register_event_proxies..
Sun, Mar 17, 8:12 AM · efl
segfaultxavi accepted D8369: csharp: Rename register_event_proxies..
Sun, Mar 17, 8:09 AM · efl
segfaultxavi updated the task description for T7702: Remove internally generated classes from EFL# doc.
Sun, Mar 17, 8:07 AM · documentation, efl: language bindings
segfaultxavi added a commit to T7702: Remove internally generated classes from EFL# doc: rEFL2865b7cddb8a: cshar: Remove unused variables..
Sun, Mar 17, 8:02 AM · documentation, efl: language bindings
segfaultxavi closed D8368: cshar: Remove unused variables..
Sun, Mar 17, 8:02 AM · efl
segfaultxavi accepted D8368: cshar: Remove unused variables..

10 removed lines + 0 added lines = instant approval.

Sun, Mar 17, 7:59 AM · efl

Fri, Mar 15

segfaultxavi added a comment to T7407: efl-mono: Crash on focus callback when quitting focus example.

It only happens for me in the C# version, no in the C version. But at least I got a bit of a backtrace:

#0  0x00000000400378cb in  ()
#1  0x00007ffff1b36cb7 in efl_canvas_group_need_recalculate_set () at /usr/local/lib/x86_64-linux-gnu/libevas.so.1
#2  0x00007ffff2efb270 in  () at /usr/local/lib/x86_64-linux-gnu/libelementary.so
#3  0x00007ffff60007f0 in  ()
#4  0x00007fffffffc0e0 in  ()
#5  0x00007ffff31add40 in _EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED () at /usr/local/lib/x86_64-linux-gnu/libelementary.so
#6  0x0000000000000000 in  ()
Fri, Mar 15, 6:49 AM · Restricted Project, efl: language bindings
segfaultxavi moved T7722: efl-mono: Generate documentation file with meson from InProgress to Done on the efl: language bindings board.
Fri, Mar 15, 6:19 AM · efl: language bindings, Restricted Project, efl (efl-1.22)
segfaultxavi abandoned D7618: efl-api: Mark Efl.Io.Closer as stable.

Fixed somewhere else.

Fri, Mar 15, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7619: efl-api: Mark Efl.Io.Writer as stable.

Fixed somewhere else.

Fri, Mar 15, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7620: efl-api: Mark Efl.Io.Reader as stable.

Fixed somewhere else.

Fri, Mar 15, 6:14 AM · DO NOT MERGE, efl
segfaultxavi closed D8361: eo: efl_object_legacy_only_event_description_get is an internal only function, make it so..
Fri, Mar 15, 3:54 AM · efl
segfaultxavi accepted D8361: eo: efl_object_legacy_only_event_description_get is an internal only function, make it so..

Hooray for making things private!
(also, everything is still building and passing tests)

Fri, Mar 15, 3:54 AM · efl
segfaultxavi added a comment to D8359: elementary: only apply text when the object is still alive..

Would be nice if the commit message explained WHY this is needed (what is the problem being fixed). Otherwise, reviewers will have a hard time figuring out how to check this. That's the reason for the "Test plan" section.

Fri, Mar 15, 3:39 AM · efl
segfaultxavi added a comment to T7702: Remove internally generated classes from EFL# doc.
  • _StructConversion classes: Do they need to be public?

    I'll create a task for it.

Thanks!

Fri, Mar 15, 3:35 AM · documentation, efl: language bindings
segfaultxavi closed D8330: csharp: Remove uneeded legacy event declaration..
Fri, Mar 15, 2:55 AM · efl
segfaultxavi accepted D8330: csharp: Remove uneeded legacy event declaration..
if (number_of_removed_lines > number of_added_lines) approve_patch_automatically();
Fri, Mar 15, 2:55 AM · efl
segfaultxavi closed T7722: efl-mono: Generate documentation file with meson as Resolved by committing rEFL9c99397cda5f: meson: Enable generation of C# docs..
Fri, Mar 15, 2:45 AM · efl: language bindings, Restricted Project, efl (efl-1.22)
segfaultxavi closed D8331: meson: Enable generation of C# docs..
Fri, Mar 15, 2:45 AM · efl
segfaultxavi accepted D8331: meson: Enable generation of C# docs..

Works as expected.

Fri, Mar 15, 2:31 AM · efl

Thu, Mar 14

segfaultxavi closed D8356: ci: add missing double quote for osx autotools.
Thu, Mar 14, 12:14 PM · Restricted Project
segfaultxavi accepted D8356: ci: add missing double quote for osx autotools.

After that commit message you can submit whatever you want and I'll approve it.

Thu, Mar 14, 12:09 PM · Restricted Project
segfaultxavi moved T7702: Remove internally generated classes from EFL# doc from TODO to InProgress on the efl: language bindings board.
Thu, Mar 14, 11:19 AM · documentation, efl: language bindings
segfaultxavi updated the task description for T7702: Remove internally generated classes from EFL# doc.
Thu, Mar 14, 11:19 AM · documentation, efl: language bindings
segfaultxavi added a commit to T7702: Remove internally generated classes from EFL# doc: rEFLaa7ec616647b: docfx: Hide *Concrete classes from docs.
Thu, Mar 14, 11:16 AM · documentation, efl: language bindings

Wed, Mar 13

segfaultxavi added a comment to D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.

I was hoping this would also fix the simple Hello World tutorial, which has never worked in the past 1.5 years:
https://git.enlightenment.org/tools/examples.git/tree/tutorial/c/hello-gui/src/gui_main.c

Wed, Mar 13, 2:48 AM · efl

Tue, Mar 12

segfaultxavi closed D8304: Efl_Core.h include Efl.h unconditionally.
Tue, Mar 12, 6:22 AM · efl: api
segfaultxavi accepted D8304: Efl_Core.h include Efl.h unconditionally.

Yup, this fixes the problem I was mentioning in D8244.

Tue, Mar 12, 6:21 AM · efl: api
segfaultxavi resigned from D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I have no further documentation concerns. I will let others do the code review.
Thanks!

Tue, Mar 12, 2:39 AM · efl
segfaultxavi accepted D8283: ui.widget: fix theme_apply working in sub_object_add.

Works again in my Ubuntu 18.04

Tue, Mar 12, 2:33 AM · efl

Mon, Mar 11

segfaultxavi accepted D8293: efl.ui.win: add event info to 'rotation,changed' event and rename.
Mon, Mar 11, 1:17 PM · efl: api
segfaultxavi accepted D8295: efl_ui_focus_composition: get geometry from canvas object not adapter.

Builds and I verified that the new geometry,changed event sends the correct geometry info, without any ERRs on the console.

Mon, Mar 11, 11:44 AM · efl: api
segfaultxavi accepted D8296: api: mark efl.loop_timer stable.

Nothing wrong here.

Mon, Mar 11, 11:38 AM · efl: api
segfaultxavi accepted D8294: efl.ui.win: merge fullscreen+maximize events to use *,changed naming.

Builds and works as expected.

Mon, Mar 11, 11:28 AM · efl: api
segfaultxavi requested changes to D8293: efl.ui.win: add event info to 'rotation,changed' event and rename.
Mon, Mar 11, 11:22 AM · efl: api
segfaultxavi accepted D8292: efl: mark most generated eina.error vars as @beta.

Sure, no harm done, but until we add support for vars in mono, this does not have much impact there.

Mon, Mar 11, 11:20 AM · efl: api
segfaultxavi accepted D8291: autotools: add more files to EXTRA_DIST2.

Fixes make distcheck as advertised. I cannot comment on whether this is the right way or not, though.

Mon, Mar 11, 9:54 AM · efl: api
segfaultxavi accepted D8290: efl.input.interface: mark seat_event_filter @beta.
Mon, Mar 11, 8:49 AM · efl: api
segfaultxavi closed D8289: edje.types: mark Efl.Canvas.Layout_Part_Type beta again.
Mon, Mar 11, 8:34 AM · efl: api
segfaultxavi accepted D8289: edje.types: mark Efl.Canvas.Layout_Part_Type beta again.

Maketh sense.

Mon, Mar 11, 8:33 AM · efl: api
segfaultxavi closed D8288: efl.input.types: mark enums beta again and use legacy types in legacy code.
Mon, Mar 11, 8:27 AM · efl: api