Page MenuHomePhabricator
Feed Advanced Search

Today

Hermet closed T7811: Enventor fails to compile with latest EFL library as Resolved.
Sat, Aug 17, 11:04 AM · Restricted Project, Enventor
Hermet added a comment to T7811: Enventor fails to compile with latest EFL library.

@Hermet Thanks for looking into this.
I can use my machine as another testbed for it when you have started working on enventor.

Sat, Aug 17, 10:59 AM · Restricted Project, Enventor

Yesterday

Hermet closed D9580: evas: fix png regression issue.
Fri, Aug 16, 12:55 AM · efl
Hermet accepted D9580: evas: fix png regression issue.
Fri, Aug 16, 12:54 AM · efl

Tue, Aug 13

Hermet closed D9476: evas_map: draw what map did not draw before..
Tue, Aug 13, 8:40 PM · efl
Hermet accepted D9476: evas_map: draw what map did not draw before..
Tue, Aug 13, 8:39 PM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated some doc syntax for c# generation.

Tue, Aug 13, 1:49 AM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated some doc syntax for c# generation.

Tue, Aug 13, 1:37 AM · efl
Hermet resigned from D9533: evas/textblock: optimize layouting when textblock has empty text.
Tue, Aug 13, 12:07 AM · efl
Hermet closed D9555: efl_ui_animation_view: change to Animation_View_State to resolve name conflict.
Tue, Aug 13, 12:07 AM · efl

Mon, Aug 12

Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

I think the overall widget looks fine beside the fact that elm_transit is used (which is IMO not good, but i might be able to life with it :P~). However, the other topic is Efl.Player: Volume and mute can just be generally ignored and return always 0 and true. The more important part here is, that we have a unified interface for playable entities. If they are splitted, what is the difference between this play here and the play in efl_player (same applies to all the other properties)? What are we going to do to not have colliding names ?
In general, if we do not have a common ground, we cannot build up specification tests for it - we cannot build up helper classes, we are super limited in future actions we can take.

Mon, Aug 12, 10:14 PM · efl
Hermet accepted D9555: efl_ui_animation_view: change to Animation_View_State to resolve name conflict.
Mon, Aug 12, 7:30 PM · efl
Hermet added a comment to D9476: evas_map: draw what map did not draw before..

if other properties has been changed such as texture uv, image, point color, smooth option, antialiasing, etc
Does here it needs to check out all the property diff?

Mon, Aug 12, 7:29 PM · efl
Hermet closed D9543: edje/style: Remove redundant style tags from style text..
Mon, Aug 12, 7:19 PM · efl
Hermet accepted D9543: edje/style: Remove redundant style tags from style text..

I tested the code history, it works fine with this patch as well.

Mon, Aug 12, 7:16 PM · efl
Hermet requested changes to D9476: evas_map: draw what map did not draw before..

I guess this function won't be triggered if user just make it object visible again without any map update,

Mon, Aug 12, 5:53 AM · efl

Fri, Aug 9

Hermet closed D9534: evas/textblock: optmize textblock format parsing..
Fri, Aug 9, 1:37 AM · efl
Hermet accepted D9534: evas/textblock: optmize textblock format parsing..
Fri, Aug 9, 1:37 AM · efl

Thu, Aug 8

Hermet requested changes to D9534: evas/textblock: optmize textblock format parsing..
Thu, Aug 8, 10:29 PM · efl
Hermet accepted D9534: evas/textblock: optmize textblock format parsing..

the solution is very clean and simple, looks good to me. but one comment.

Thu, Aug 8, 10:29 PM · efl
Hermet added a reviewer for D9533: evas/textblock: optimize layouting when textblock has empty text: bowonryu.
Thu, Aug 8, 10:13 PM · efl
Hermet requested changes to D9533: evas/textblock: optimize layouting when textblock has empty text.

What if text is changed to none from actual text, relayout shouldn't be performed?

Thu, Aug 8, 10:11 PM · efl
Hermet closed D9532: edje: optimize color_class_recursive_find_helper() function.
Thu, Aug 8, 10:02 PM · efl
Hermet accepted D9532: edje: optimize color_class_recursive_find_helper() function.
Thu, Aug 8, 10:02 PM · efl
Hermet closed D9531: eina/hash: optimize eina_hash_find() when hash is empty..
Thu, Aug 8, 10:00 PM · efl
Hermet accepted D9531: eina/hash: optimize eina_hash_find() when hash is empty..
Thu, Aug 8, 9:59 PM · efl

Tue, Aug 6

Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

I think the overall widget looks fine beside the fact that elm_transit is used (which is IMO not good, but i might be able to life with it :P~). However, the other topic is Efl.Player: Volume and mute can just be generally ignored and return always 0 and true. The more important part here is, that we have a unified interface for playable entities. If they are splitted, what is the difference between this play here and the play in efl_player (same applies to all the other properties)? What are we going to do to not have colliding names ?
In general, if we do not have a common ground, we cannot build up specification tests for it - we cannot build up helper classes, we are super limited in future actions we can take.

Tue, Aug 6, 8:40 PM · efl

Mon, Aug 5

Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated

Mon, Aug 5, 11:02 PM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

added spec test.

Mon, Aug 5, 10:59 PM · efl
Hermet added inline comments to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Mon, Aug 5, 10:49 PM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

added efl_ui_animation_view.h in Efl_Ui.h

Mon, Aug 5, 10:48 PM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated code as to follow review comments.

Mon, Aug 5, 9:56 PM · efl
Hermet added inline comments to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Mon, Aug 5, 9:28 PM · efl
Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

added comment.

Mon, Aug 5, 7:05 PM · efl
Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
In D9451#176006, @zmike wrote:
In D9451#175836, @zmike wrote:

Why does this have a legacy API? I don't think we should be adding more legacy API at this point...

I think still we should take care of Legacy and Interfaces both, if many legacy apps(exisiting apps) want it and requires keeping using legacy world.

Also, you shouldn't use @since in the eo docs considering this widget is not stable, and thus the API is not "released".

Well, I don't think it's the matter because the interface is tagged with beta, we could update the since date later (Or if you argue then we can remove it, Do you like it?). 
In point of legacy API, those apis could be released officially regardless of interface. The widget legacy apis actually used earlier in Tizen a year ago with lottie feature, I think we could target to release this in 1.23, if it's stable enough. maybe we can make it sure before.

I'm not sure that reviewing legacy API is the best use of time when we're trying to move quickly on unified API, which is why I brought this up. I think we should be focusing on unified APIs now and trying to encourage people to try building apps without legacy wherever possible. Adding more legacy API like this just adds more codepaths to the repo which will likely never be used or adequately tested.

I don't think either of the points I raised are blockers for this patch, I just wanted to make sure we were aware of what we were doing here.

Mon, Aug 5, 7:05 PM · efl
Hermet requested changes to D9476: evas_map: draw what map did not draw before..

Looks bad to me if _evas_map_calc_geom_change() is called twice.
And what happens if _evas_map_calc_map_geometry() is not called in the next frame?

Mon, Aug 5, 2:16 AM · efl
Hermet closed D9492: ector_software_rasterizer: Add default value for stroke's miter_limit.
Mon, Aug 5, 2:09 AM · efl
Hermet accepted D9492: ector_software_rasterizer: Add default value for stroke's miter_limit.
Mon, Aug 5, 2:08 AM · efl

Sun, Aug 4

Hermet requested review of D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

Updated comments.

Sun, Aug 4, 11:08 PM · efl
Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
In D9451#175836, @zmike wrote:

Why does this have a legacy API? I don't think we should be adding more legacy API at this point...

I think still we should take care of Legacy and Interfaces both, if many legacy apps(exisiting apps) want it and requires keeping using legacy world.
Sun, Aug 4, 11:07 PM · efl

Fri, Aug 2

Hermet added inline comments to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Fri, Aug 2, 1:28 AM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated

Fri, Aug 2, 1:27 AM · efl

Thu, Aug 1

Hermet added a comment to V45: Final vote on Enlightenment Developer Days 2019 date and location.

Will try to attend, but not Sure. :)

Thu, Aug 1, 6:38 PM
Hermet added inline comments to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Thu, Aug 1, 4:08 AM · efl
Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

Elementary_Test Patch : https://phab.enlightenment.org/D9472

Thu, Aug 1, 4:05 AM · efl
Hermet updated the summary of D9472: elementary_test: Add the animation view test.
Thu, Aug 1, 4:03 AM · efl
Hermet planned changes to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Thu, Aug 1, 4:00 AM · efl
Hermet requested changes to D9472: elementary_test: Add the animation view test.

If it failed to load json, how about display just svg + notification text rather than disable the test (when json loader is not ready),
i.e) "Evas Vg Json (Lottie) Loader is not supported, Only Static Vector Image is available!");

Thu, Aug 1, 3:51 AM · efl

Wed, Jul 31

Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

will add sample and test code patches.
any feedback welcomed.

Wed, Jul 31, 12:01 AM · efl
Hermet added reviewers for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation.: committers, jsuya.
Wed, Jul 31, 12:00 AM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

remove json build option.

Wed, Jul 31, 12:00 AM · efl

Tue, Jul 30

Hermet requested review of D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Tue, Jul 30, 11:58 PM · efl

Thu, Jul 25

Hermet closed D9390: ector: Prevent access to NULL buffer in software rasterizer.
Thu, Jul 25, 9:13 PM · efl
Hermet accepted D9390: ector: Prevent access to NULL buffer in software rasterizer.
Thu, Jul 25, 9:12 PM · efl

Wed, Jul 24

Hermet closed D9301: evas image: apply filter at runtime.
Wed, Jul 24, 11:04 PM · efl
Hermet accepted D9301: evas image: apply filter at runtime.
Wed, Jul 24, 11:01 PM · efl
Hermet closed D9362: evas/map: permit evas_map_free(NULL).
Wed, Jul 24, 10:48 PM · efl
Hermet accepted D9362: evas/map: permit evas_map_free(NULL).
Wed, Jul 24, 10:48 PM · efl

Tue, Jul 23

Hermet requested changes to D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Is there any reason that filter only targets to group object? but not a single canvas object?
We can generally support filter for all types of graphical objects.

Tue, Jul 23, 11:18 PM · efl

Mon, Jul 22

Hermet requested changes to D9362: evas/map: permit evas_map_free(NULL).

This removes the validation check of map handle as well.
we can just add prevent null handling.

Mon, Jul 22, 1:04 AM · efl
Hermet accepted D9362: evas/map: permit evas_map_free(NULL).
Mon, Jul 22, 1:02 AM · efl
Hermet closed D9314: efl_ui_textpath: deprecate elm_textpath_circle_set().
Mon, Jul 22, 1:02 AM · efl
Hermet closed D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface..
Mon, Jul 22, 1:01 AM · efl

Sun, Jul 21

Hermet closed D9351: evas_vg_json: Add image embedded example.
Sun, Jul 21, 9:54 PM · efl
Hermet closed D9220: vg_common_json : Support image data of node.
Sun, Jul 21, 9:53 PM · efl
Hermet closed D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Sun, Jul 21, 9:53 PM · efl
Hermet closed D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Sun, Jul 21, 9:35 PM · efl
Hermet accepted D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Sun, Jul 21, 9:28 PM · efl

Jul 17 2019

Hermet accepted D9220: vg_common_json : Support image data of node.
Jul 17 2019, 10:30 PM · efl
Hermet accepted D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Jul 17 2019, 10:24 PM · efl
Hermet requested changes to D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

Please check a comment.

Jul 17 2019, 10:23 PM · efl
Hermet added a comment to D9338: vg_common_svg: Gradient stop color use premultiplied color..

Currently, we could use both efl_gfx_color_set() and vg node color_set(),
one is designed for premultipled, one is not,

Jul 17 2019, 1:44 AM · efl
Hermet closed D9338: vg_common_svg: Gradient stop color use premultiplied color..
Jul 17 2019, 1:16 AM · efl
Hermet accepted D9338: vg_common_svg: Gradient stop color use premultiplied color..
Jul 17 2019, 1:15 AM · efl

Jul 15 2019

Hermet closed D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Jul 15 2019, 5:25 AM · efl
Hermet accepted D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Jul 15 2019, 5:24 AM · efl
Hermet closed D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Jul 15 2019, 5:23 AM · efl
Hermet accepted D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Jul 15 2019, 5:22 AM · efl
Hermet added a comment to D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface..

With its current functionality, I think this class should be named Efl.Ui.Text_Circle and the property should be radius.

Or is this widgwt capable of drawing other shapes? @Hermet? @zmike? @bu5hm4n?

Jul 15 2019, 3:35 AM · efl
Hermet requested changes to D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

Could you please attach an actual issue example in the code?

Jul 15 2019, 3:32 AM · efl
Hermet requested changes to D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

Please check a comment.

Jul 15 2019, 3:01 AM · efl
Hermet accepted D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Jul 15 2019, 2:40 AM · efl

Jul 14 2019

Hermet added a reviewer for D9314: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Jul 14 2019, 10:29 PM · efl
Hermet requested review of D9314: efl_ui_textpath: deprecate elm_textpath_circle_set().
Jul 14 2019, 10:28 PM · efl
Hermet abandoned D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().
Jul 14 2019, 10:27 PM · efl
Hermet updated the diff for D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().

added deprecated flag

Jul 14 2019, 10:26 PM · efl
Hermet abandoned D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().

@kimcinoo Sorry, screwed up the patch by mistake, please see https://phab.enlightenment.org/D9314

Jul 14 2019, 10:25 PM · efl
Hermet added a reviewer for D9313: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Jul 14 2019, 10:24 PM · efl
Hermet requested review of D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().
Jul 14 2019, 10:24 PM · efl
Hermet updated the diff for D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().

moved deprecated api to elm_deprecated.
and added @deprecated tag.

Jul 14 2019, 10:20 PM · efl
Hermet closed D9311: efl.h: avoid redefinition of typedef 'Efl_Gfx_Path_Command'.
Jul 14 2019, 10:14 PM · efl
Hermet accepted D9311: efl.h: avoid redefinition of typedef 'Efl_Gfx_Path_Command'.
Jul 14 2019, 10:09 PM · efl

Jul 11 2019

Hermet accepted D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Jul 11 2019, 7:55 PM · efl
Hermet accepted D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Jul 11 2019, 7:54 PM · efl

Jul 10 2019

Hermet requested changes to D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

Please check comments.

Jul 10 2019, 9:44 PM · efl
Hermet requested changes to D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.

Please check comments.

Jul 10 2019, 8:36 PM · efl
Hermet requested changes to D9220: vg_common_json : Support image data of node.

Please check comments.

Jul 10 2019, 8:22 PM · efl
Hermet added a reviewer for D9261: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Jul 10 2019, 4:32 AM · efl
Hermet requested review of D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().
Jul 10 2019, 4:31 AM · efl
Hermet added reviewers for D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface.: kimcinoo, jsuya.
Jul 10 2019, 4:30 AM · efl