Page MenuHomePhabricator
Feed Advanced Search

Today

cedric added a comment to D7662: elementary: enable efl_ui_suite tests..
In D7662#135555, @zmike wrote:

Probably worth pointing out in the commit log that this is only for the meson build

Fri, Jan 18, 11:06 AM · efl
cedric added inline comments to D7661: elementary: add internal Efl_Ui_Model_Average..
Fri, Jan 18, 9:52 AM · efl
cedric accepted D7691: Efl.Loop.Timer.interval is a constructor property.

I think it easier to have a timer interval set right away, otherwise it is hard to know when did the counting start. With constructors property, we solve that problem by defining that the timer start running as soon as the object is finalized.

Fri, Jan 18, 9:50 AM · efl

Yesterday

cedric added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

hmm... yeah I agreed with that point. so I'll update the patch with making it inherit from layout.

Thu, Jan 17, 5:43 PM · efl
cedric updated the diff for D7665: elementary: add test for Efl.Ui.Model_Average..

Rebase.

Thu, Jan 17, 4:45 PM · efl
cedric updated the diff for D7664: elementary: add a test for Efl.Ui.Model_Exact..

Rebase.

Thu, Jan 17, 4:45 PM · efl
cedric updated the diff for D7663: elementary: add a test for Efl.Ui.Model_Homogeneous..

Rebase.

Thu, Jan 17, 4:45 PM · efl
cedric updated the diff for D7662: elementary: enable efl_ui_suite tests..

Rebase.

Thu, Jan 17, 4:45 PM · efl
cedric updated the diff for D7661: elementary: add internal Efl_Ui_Model_Average..

Rebase and improve documentation.

Thu, Jan 17, 4:45 PM · efl
cedric updated the diff for D7660: elementary: add internal Efl_Ui_Model_Exact..

Rebase and improve documentation.

Thu, Jan 17, 4:44 PM · efl
cedric updated the diff for D7659: elementary: add internal Efl_Ui_Model_Homogeneous..

Rebase and improve documentation.

Thu, Jan 17, 4:43 PM · efl
cedric updated the diff for D7658: elementary: add internal Efl_Ui_Model_Size..

Rebase and improve documentation.

Thu, Jan 17, 4:43 PM · efl
cedric updated the diff for D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..

Rebase.

Thu, Jan 17, 4:43 PM · efl
cedric updated the diff for D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class..

Rebase.

Thu, Jan 17, 4:42 PM · efl
cedric updated the diff for D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class..

Rebase.

Thu, Jan 17, 4:42 PM · efl
cedric updated the diff for D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..

Rebase and improve documentation.

Thu, Jan 17, 4:41 PM · efl
cedric updated the diff for D7653: ecore: fix memory leak when shutding down the application..

Rebase.

Thu, Jan 17, 4:40 PM · efl
cedric updated the diff for D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..

Rebase.

Thu, Jan 17, 4:40 PM · efl
cedric updated the diff for D7651: eina: add tests for the new Eina_Value convert functions..

Rebase.

Thu, Jan 17, 4:40 PM · efl
cedric updated the diff for D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..

Rebase and fix documentation.

Thu, Jan 17, 4:39 PM · efl
cedric updated the diff for D7649: eina: add tests for Eina_Value utility function eina_value_*_get..

Rebase and improve tests to check result.

Thu, Jan 17, 4:39 PM · efl
cedric added a comment to T7516: Enable local override of class.

If you call efl_class_get on the object given to any .constructor function, you will get the leaf class that was requested, not the class you are in. So a code like this in Efl.Ui.Widget.constructor would more or less do the job :

Thu, Jan 17, 11:52 AM · Restricted Project, efl, Restricted Project
cedric accepted D7605: theme: fix odd state setting on some items for list/genlist/gengrid.
Thu, Jan 17, 11:35 AM · efl
cedric accepted D7606: theme: correct part name in program for elm/hover/base/main_menu_submenu/default.
Thu, Jan 17, 11:34 AM · efl
cedric accepted D7607: theme: remove a ton of invalid part description references in various programs.
Thu, Jan 17, 11:34 AM · efl
cedric added a comment to T7597: efl.loop.

I don't think this one landed yet. Except from that I am ok with the rest of the class.

Thu, Jan 17, 11:33 AM · efl: api, efl (efl-1.22)
cedric added a comment to T7596: efl.app.

I don't see any issue with this class.

Thu, Jan 17, 11:31 AM · efl: api, efl (efl-1.22)
cedric added a comment to T7598: efl.task.

I think that arg_count, arg_append,arg_value and arg_reset are not a nice API for any binding as it look very foreign. Better API would be either to just have an Eina_Array or Eina_List based API. This would allow most binding to do something like :

Thu, Jan 17, 11:29 AM · efl: api, efl (efl-1.22)
cedric accepted D7608: edje_cc: fail upon detecting invalid part description references in programs.
Thu, Jan 17, 11:12 AM · efl
cedric accepted D7570: Make Efl.Ui.Closer an interface instead of mixin.
Thu, Jan 17, 10:08 AM · efl
cedric added a comment to D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..

Ugh, the amount of code repetition! Are you sure yo do not want to use a macro for that?

Thu, Jan 17, 9:49 AM · efl
cedric accepted D7626: elm: restore old elm_web behaviour.
Thu, Jan 17, 9:32 AM · efl

Wed, Jan 16

cedric requested review of D7665: elementary: add test for Efl.Ui.Model_Average..
Wed, Jan 16, 6:31 PM · efl
cedric added a child revision for D7664: elementary: add a test for Efl.Ui.Model_Exact.: D7665: elementary: add test for Efl.Ui.Model_Average..
Wed, Jan 16, 6:31 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7665: elementary: add test for Efl.Ui.Model_Average..
Wed, Jan 16, 6:31 PM · efl: mvvm
cedric requested review of D7664: elementary: add a test for Efl.Ui.Model_Exact..
Wed, Jan 16, 6:31 PM · efl
cedric added a child revision for D7663: elementary: add a test for Efl.Ui.Model_Homogeneous.: D7664: elementary: add a test for Efl.Ui.Model_Exact..
Wed, Jan 16, 6:31 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7664: elementary: add a test for Efl.Ui.Model_Exact..
Wed, Jan 16, 6:31 PM · efl: mvvm
cedric requested review of D7663: elementary: add a test for Efl.Ui.Model_Homogeneous..
Wed, Jan 16, 6:31 PM · efl
cedric added a child revision for D7662: elementary: enable efl_ui_suite tests.: D7663: elementary: add a test for Efl.Ui.Model_Homogeneous..
Wed, Jan 16, 6:31 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7663: elementary: add a test for Efl.Ui.Model_Homogeneous..
Wed, Jan 16, 6:30 PM · efl: mvvm
cedric requested review of D7662: elementary: enable efl_ui_suite tests..
Wed, Jan 16, 6:30 PM · efl
cedric added a child revision for D7661: elementary: add internal Efl_Ui_Model_Average.: D7662: elementary: enable efl_ui_suite tests..
Wed, Jan 16, 6:30 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7662: elementary: enable efl_ui_suite tests..
Wed, Jan 16, 6:30 PM · efl: mvvm
cedric requested review of D7661: elementary: add internal Efl_Ui_Model_Average..
Wed, Jan 16, 6:30 PM · efl
cedric added a child revision for D7660: elementary: add internal Efl_Ui_Model_Exact.: D7661: elementary: add internal Efl_Ui_Model_Average..
Wed, Jan 16, 6:30 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7661: elementary: add internal Efl_Ui_Model_Average..
Wed, Jan 16, 6:30 PM · efl: mvvm
cedric requested review of D7660: elementary: add internal Efl_Ui_Model_Exact..
Wed, Jan 16, 6:30 PM · efl
cedric added a child revision for D7659: elementary: add internal Efl_Ui_Model_Homogeneous.: D7660: elementary: add internal Efl_Ui_Model_Exact..
Wed, Jan 16, 6:30 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7660: elementary: add internal Efl_Ui_Model_Exact..
Wed, Jan 16, 6:30 PM · efl: mvvm
cedric requested review of D7659: elementary: add internal Efl_Ui_Model_Homogeneous..
Wed, Jan 16, 6:30 PM · efl
cedric added a child revision for D7658: elementary: add internal Efl_Ui_Model_Size.: D7659: elementary: add internal Efl_Ui_Model_Homogeneous..
Wed, Jan 16, 6:30 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7659: elementary: add internal Efl_Ui_Model_Homogeneous..
Wed, Jan 16, 6:29 PM · efl: mvvm
cedric requested review of D7658: elementary: add internal Efl_Ui_Model_Size..
Wed, Jan 16, 6:29 PM · efl
cedric added a child revision for D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name.: D7658: elementary: add internal Efl_Ui_Model_Size..
Wed, Jan 16, 6:29 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7658: elementary: add internal Efl_Ui_Model_Size..
Wed, Jan 16, 6:29 PM · efl: mvvm
cedric requested review of D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..
Wed, Jan 16, 6:29 PM · efl
cedric added a child revision for D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class.: D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..
Wed, Jan 16, 6:29 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..
Wed, Jan 16, 6:29 PM · efl: mvvm
cedric requested review of D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class..
Wed, Jan 16, 6:29 PM · efl
cedric added a child revision for D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class.: D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class..
Wed, Jan 16, 6:29 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class..
Wed, Jan 16, 6:29 PM · efl: mvvm
cedric requested review of D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class..
Wed, Jan 16, 6:29 PM · efl
cedric requested review of D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..
Wed, Jan 16, 6:29 PM · efl
cedric added a child revision for D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get.: D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class..
Wed, Jan 16, 6:29 PM · efl
cedric added a child revision for D7653: ecore: fix memory leak when shutding down the application.: D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..
Wed, Jan 16, 6:29 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric requested review of D7653: ecore: fix memory leak when shutding down the application..
Wed, Jan 16, 6:28 PM · efl
cedric added a child revision for D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it.: D7653: ecore: fix memory leak when shutding down the application..
Wed, Jan 16, 6:28 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7653: ecore: fix memory leak when shutding down the application..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric requested review of D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..
Wed, Jan 16, 6:28 PM · efl
cedric added a child revision for D7651: eina: add tests for the new Eina_Value convert functions.: D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..
Wed, Jan 16, 6:28 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric requested review of D7651: eina: add tests for the new Eina_Value convert functions..
Wed, Jan 16, 6:28 PM · efl
cedric added a child revision for D7650: eina: add Eina_Value helper that convert efficiently to a target native C type.: D7651: eina: add tests for the new Eina_Value convert functions..
Wed, Jan 16, 6:28 PM · efl
cedric requested review of D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..
Wed, Jan 16, 6:28 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7651: eina: add tests for the new Eina_Value convert functions..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric added a child revision for D7649: eina: add tests for Eina_Value utility function eina_value_*_get.: D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..
Wed, Jan 16, 6:28 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..
Wed, Jan 16, 6:28 PM · efl: mvvm
cedric requested review of D7649: eina: add tests for Eina_Value utility function eina_value_*_get..
Wed, Jan 16, 6:27 PM · efl
cedric added a revision to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7649: eina: add tests for Eina_Value utility function eina_value_*_get..
Wed, Jan 16, 6:27 PM · efl: mvvm
cedric closed T7530: Fix eina promise data store, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Wed, Jan 16, 4:10 PM · Restricted Project, efl, Restricted Project
cedric closed T7530: Fix eina promise data store as Resolved.
Wed, Jan 16, 4:10 PM · efl (efl-1.22), efl: data types, Restricted Project
cedric closed D7578: eina: remove eina_promise_data_get has it lead to risky use..
Wed, Jan 16, 4:10 PM · efl
cedric closed D7593: efl_app: add "standby" event.
Wed, Jan 16, 3:58 PM · efl
cedric added a commit to T5494: EO: elm policy API: rEFL5ab4784bbd31: efl_app: add "standby" event.
Wed, Jan 16, 3:58 PM · efl (efl-1.22), efl: widgets
cedric closed D7592: evas: fix big endian pixman image rendering.
Wed, Jan 16, 3:58 PM · efl
cedric closed T6562: Elm Entry file_set fails when using a 0 size file as Resolved by committing rEFLbb091424776c: elm_entry: make file loading succeed on 0-sized files.
Wed, Jan 16, 3:58 PM · efl: widgets
cedric closed D7647: elm_entry: make file loading succeed on 0-sized files.
Wed, Jan 16, 3:58 PM · efl: widgets
cedric requested changes to D7648: edje: apply maps to textblock cursors and backgrounds.

I will have to ask for some change actually.

Wed, Jan 16, 3:43 PM · efl: layout engine
cedric updated subscribers of D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

I like the way it is.

Wed, Jan 16, 3:27 PM · efl
cedric added a comment to D7594: efl_app: add 'exit_on_windows_close' property and unit test.

I don't like the side config class concept very much. It is really a side thing that don't seem to match the rest of the infrastructure. I am not sure I also read you correctly, but I think you agree on STANDBY event on the Efl.App object. So the only question is where is this property get/set defined? In that case what do you think if it was a class property on Efl.Ui.Win ?

You read me correctly. Having it as class function on efl.ui.win sounds actaully not *that* wrong to me (it cannot be on the object, as all objects are defining 1 property, not every obejct 1 property). The reason why i liked the idea of a Efl.Ui.Temp_Config/App_Config is, that we likely will have more config values there, which are right now in elm_config but don't make really sense there, Just a few from my head:

  • A software came definitly wants to have hardware accel, or something that does heavy UI stuff, so you probebly want to have your app beeing accelated, without setting the whole system to hardware accelation
  • elm_config_selection_unfocused_clear_get (also applies to other focus properties) really depends on the UI you have and you probebly don't want to have that behaviour
Wed, Jan 16, 3:14 PM · efl
cedric accepted D7627: efl: add free functions to owned types.
Wed, Jan 16, 3:09 PM · efl
cedric accepted D7640: efl_ui_list_view_types: add a free function to the struct type.

@felipealmeida @SanghyeonLee : this patch is useful now, but we should just get rid of this data type it is not something that should be exposed in our API.

Wed, Jan 16, 3:06 PM · efl
cedric added a comment to D7647: elm_entry: make file loading succeed on 0-sized files.

Looks good now.

Wed, Jan 16, 3:03 PM · efl: widgets
cedric accepted D7647: elm_entry: make file loading succeed on 0-sized files.
Wed, Jan 16, 3:03 PM · efl: widgets
cedric accepted D7648: edje: apply maps to textblock cursors and backgrounds.

This make sense and I guess another figment of our lack of tests.

Wed, Jan 16, 3:02 PM · efl: layout engine
cedric added a comment to D7344: evas map: calc map geometry when it is out of screen.

ping

Wed, Jan 16, 2:46 PM · efl
cedric closed D7367: ui/flip: fix efl_pack usage.
Wed, Jan 16, 2:45 PM · efl