Page MenuHomePhabricator
Feed Advanced Search

Sun, Nov 17

cedric accepted D10689: eo: there is no need to count callbacks here.
Sun, Nov 17, 8:35 AM · efl
cedric closed D10660: eo: do not over compute the hash when propagating events..
Sun, Nov 17, 3:13 AM · efl
cedric closed D10659: eo: no need to oversize type..
Sun, Nov 17, 3:12 AM · efl
cedric closed D10658: eo: refactor shortcut for EFL_EVENT_DESTRUCT event..
Sun, Nov 17, 3:12 AM · efl

Fri, Nov 15

cedric closed D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..
Fri, Nov 15, 11:52 AM · efl
cedric accepted D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..
Fri, Nov 15, 11:51 AM · efl
cedric accepted D10636: elementary: move away from normal player to the new animation mixin.
Fri, Nov 15, 11:39 AM · efl
cedric accepted D10637: efl_ui_spotlight_manager stack: move away from player object.
Fri, Nov 15, 11:34 AM · efl
cedric accepted D10667: remove efl_canvas_animation_player.
Fri, Nov 15, 11:31 AM · efl
cedric added a reviewer for D10666: evas: migrate the vg json example: Hermet.
Fri, Nov 15, 11:30 AM · efl
cedric requested review of D10688: elementary: improve data layout for Efl.Ui.PositionManager*..
Fri, Nov 15, 11:26 AM · efl
cedric added a child revision for D10687: elementary: reduce events triggered by Efl.Ui.PositionManager.: D10688: elementary: improve data layout for Efl.Ui.PositionManager*..
Fri, Nov 15, 11:26 AM · efl
cedric requested review of D10687: elementary: reduce events triggered by Efl.Ui.PositionManager..
Fri, Nov 15, 11:26 AM · efl
cedric added a child revision for D10686: elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView.: D10687: elementary: reduce events triggered by Efl.Ui.PositionManager..
Fri, Nov 15, 11:26 AM · efl
cedric requested review of D10686: elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView..
Fri, Nov 15, 11:26 AM · efl
cedric added a child revision for D10685: elementary: reduce event generation during object creation by Efl.Ui.WidgetFactory.: D10686: elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView..
Fri, Nov 15, 11:26 AM · efl
cedric requested review of D10685: elementary: reduce event generation during object creation by Efl.Ui.WidgetFactory..
Fri, Nov 15, 11:26 AM · efl
cedric requested review of D10684: eldbus: only free the data when the future is resolved or rejected..
Fri, Nov 15, 9:44 AM · efl
cedric added a revision to T8142: ASAN detected heap use after free in eldbus test suite: D10684: eldbus: only free the data when the future is resolved or rejected..
Fri, Nov 15, 9:44 AM
cedric added inline comments to D10678: efl_ui_layout: Fix "theme,changed" callback not being called in legacy widget cases..
Fri, Nov 15, 9:21 AM · efl
cedric added a comment to D10675: efl_ui_multi_selectable: clean this up.

Efl.Ui.Multi_Selectable_Index_Range and Efl.Ui.Multi_Selectable_Object_Range?

Fri, Nov 15, 9:19 AM · efl

Thu, Nov 14

cedric added a comment to T8351: Improve focus support.

efl_ui_list_view_example_3 still has some issue with focus, but I am not sure where it is coming from. Maybe it is a different task.

Thu, Nov 14, 5:22 PM · efl: mvvm
cedric requested review of D10677: elementary: improve focus memory for Efl.Ui.CollectionView..
Thu, Nov 14, 5:20 PM · efl
cedric added a revision to T8351: Improve focus support: D10677: elementary: improve focus memory for Efl.Ui.CollectionView..
Thu, Nov 14, 5:20 PM · efl: mvvm
cedric requested changes to D10675: efl_ui_multi_selectable: clean this up.
Thu, Nov 14, 1:06 PM · efl
cedric closed D10674: edje: Remove warnings.
Thu, Nov 14, 10:52 AM · efl
cedric accepted D10674: edje: Remove warnings.
Thu, Nov 14, 10:51 AM · efl
cedric added a comment to D10598: edje: implement text_class override at object level.

As I said the patch looks good and should go on, but not without addressing the past behavior in a way that application that might rely on it would be broken. I have proposed two possible path. If you have other idea to fix it, I will be fine. As long as the application can still have that feature in some way.

I think we will add new functions to change override classes at file level (get/set). I think classes are only (size, color, and text)

Thu, Nov 14, 10:32 AM · efl
cedric triaged T8475: Small step improvement for edje file format as Wishlist priority.
Thu, Nov 14, 10:30 AM
cedric closed D10605: edje_calc: Exception handling if no calculation is required..
Thu, Nov 14, 10:09 AM · efl
cedric accepted D10605: edje_calc: Exception handling if no calculation is required..

Great.

Thu, Nov 14, 10:08 AM · efl
cedric updated the diff for D10660: eo: do not over compute the hash when propagating events..

rebase

Thu, Nov 14, 9:33 AM · efl
cedric updated the diff for D10659: eo: no need to oversize type..

rebase

Thu, Nov 14, 9:33 AM · efl
cedric updated the diff for D10658: eo: refactor shortcut for EFL_EVENT_DESTRUCT event..

rebase

Thu, Nov 14, 9:33 AM · efl

Wed, Nov 13

cedric requested review of D10660: eo: do not over compute the hash when propagating events..
Wed, Nov 13, 4:09 PM · efl
cedric added a child revision for D10659: eo: no need to oversize type.: D10660: eo: do not over compute the hash when propagating events..
Wed, Nov 13, 4:09 PM · efl
cedric requested review of D10659: eo: no need to oversize type..
Wed, Nov 13, 4:08 PM · efl
cedric added a child revision for D10658: eo: refactor shortcut for EFL_EVENT_DESTRUCT event.: D10659: eo: no need to oversize type..
Wed, Nov 13, 4:08 PM · efl
cedric requested review of D10658: eo: refactor shortcut for EFL_EVENT_DESTRUCT event..
Wed, Nov 13, 4:08 PM · efl
cedric closed T8357: Switching between selection mode is broken as Resolved.
Wed, Nov 13, 2:41 PM · efl: mvvm
cedric closed T8357: Switching between selection mode is broken, a subtask of T8356: Improve efl_ui_list_view_example_3, as Resolved.
Wed, Nov 13, 2:41 PM · efl: mvvm
cedric closed D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Wed, Nov 13, 12:18 PM · efl
cedric closed D10633: efl: remove useless printf from Efl Container Model tests..
Wed, Nov 13, 12:18 PM · efl
cedric closed D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..
Wed, Nov 13, 12:18 PM · efl
cedric closed D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..
Wed, Nov 13, 12:17 PM · efl
cedric closed D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Wed, Nov 13, 12:17 PM · efl
cedric closed D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..
Wed, Nov 13, 12:17 PM · efl
cedric closed D10623: ecore: properly handle children destruction in Efl.BooleanModel..
Wed, Nov 13, 12:17 PM · efl
cedric updated the diff for D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10633: efl: remove useless printf from Efl Container Model tests..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10623: ecore: properly handle children destruction in Efl.BooleanModel..
Wed, Nov 13, 9:47 AM · efl
cedric updated the diff for D10634: efl: improve Efl.BooleanModel test by checking the child del case..

rebase and fix assert.

Wed, Nov 13, 9:20 AM · efl
cedric updated the diff for D10633: efl: remove useless printf from Efl Container Model tests..

rebase

Wed, Nov 13, 9:19 AM · efl
cedric updated the diff for D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..

rebase

Wed, Nov 13, 9:19 AM · efl
cedric updated the diff for D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..

rebase

Wed, Nov 13, 9:19 AM · efl
cedric updated the diff for D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..

rebase

Wed, Nov 13, 9:18 AM · efl
cedric updated the diff for D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..

rebase

Wed, Nov 13, 9:18 AM · efl
cedric updated the diff for D10623: ecore: properly handle children destruction in Efl.BooleanModel..

rebase

Wed, Nov 13, 9:18 AM · efl
cedric planned changes to D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Wed, Nov 13, 7:22 AM · efl

Mon, Nov 11

cedric added a comment to D10598: edje: implement text_class override at object level.

As I said the patch looks good and should go on, but not without addressing the past behavior in a way that application that might rely on it would be broken. I have proposed two possible path. If you have other idea to fix it, I will be fine. As long as the application can still have that feature in some way.

Mon, Nov 11, 10:09 AM · efl

Sun, Nov 10

cedric added a comment to D10598: edje: implement text_class override at object level.

This patch is a good idea, I think, but it is most likely breaking some existing application as before when you applied a style it would propagate everywhere the same file was loaded. If an application does rely on this it would be broken I would think. I am not expert on this part of the code, so I might be wrong, but if I am right, I think that we should most likely continue to update the edf->styles hash on every call to edje_object_text_class_set and handle the fallback case when a style is not found on the object to look on the file.

From function description of edje_object_text_class_set() (Sorry can't find link due to broken links in documentation, but you will find it in code)

...
@brief Sets Edje text class.
This function sets the text class for the edje
...

So this function should change text_class at edje object level not file level.

Sun, Nov 10, 3:20 PM · efl
cedric added a comment to D10634: efl: improve Efl.BooleanModel test by checking the child del case..

The assert is not found ...

Sun, Nov 10, 3:11 PM · efl
cedric added a comment to D10634: efl: improve Efl.BooleanModel test by checking the child del case..

This is the test you're looking for.

Sun, Nov 10, 12:32 PM · efl
cedric added inline comments to D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Sun, Nov 10, 12:32 PM · efl
cedric added a comment to D10623: ecore: properly handle children destruction in Efl.BooleanModel..

There is a test in phab somewhere waiting for you to review it. I forgot the number will try to find later.

Sun, Nov 10, 12:31 PM · efl
cedric added inline comments to D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Sun, Nov 10, 12:30 PM · efl
cedric added a comment to D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..

Because their wasn't a test for it until now 😓

Sun, Nov 10, 12:14 PM · efl

Fri, Nov 8

cedric added a comment to T8126: Long term extention for Position_Manager.

Before all that kind of optimization, I think we will need to revise the API of the position manager and its internal a bit. Main issue I am seeing:

  • The collection needs to throttle position manager sizing information request and make sure batch request are not overwhelming the main loop.

There have been a nice way to distinguish between caching sizing calls, and real sizing infos. That was not enough ?

Fri, Nov 8, 3:25 PM · Restricted Project, efl: mvvm, efl: widgets
cedric requested review of D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Fri, Nov 8, 12:17 PM · efl
cedric added a child revision for D10633: efl: remove useless printf from Efl Container Model tests.: D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Fri, Nov 8, 12:16 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Fri, Nov 8, 12:16 PM · efl: mvvm
cedric requested review of D10633: efl: remove useless printf from Efl Container Model tests..
Fri, Nov 8, 12:16 PM · efl
cedric added a child revision for D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel.: D10633: efl: remove useless printf from Efl Container Model tests..
Fri, Nov 8, 12:16 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10633: efl: remove useless printf from Efl Container Model tests..
Fri, Nov 8, 12:16 PM · efl: mvvm
cedric requested review of D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..
Fri, Nov 8, 12:16 PM · efl
cedric added a child revision for D10631: ecore: remove the composited children from the source of an Efl.CompositeModel.: D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..
Fri, Nov 8, 12:16 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10632: ecore: correctly apply the offset on the upper part of the boolean mask for Efl.BooleanModel..
Fri, Nov 8, 12:16 PM · efl: mvvm
cedric requested review of D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..
Fri, Nov 8, 12:16 PM · efl
cedric added a child revision for D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView.: D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..
Fri, Nov 8, 12:16 PM · efl
cedric updated the diff for D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..

rebase

Fri, Nov 8, 12:16 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10631: ecore: remove the composited children from the source of an Efl.CompositeModel..
Fri, Nov 8, 12:16 PM · efl: mvvm
cedric updated the diff for D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..

rebase and improve logic to reduce over fetching model/entity.

Fri, Nov 8, 12:15 PM · efl
cedric updated the diff for D10623: ecore: properly handle children destruction in Efl.BooleanModel..

rebase

Fri, Nov 8, 12:15 PM · efl
cedric added a comment to T8126: Long term extention for Position_Manager.

Before all that kind of optimization, I think we will need to revise the API of the position manager and its internal a bit. Main issue I am seeing:

  • The collection needs to throttle position manager sizing information request and make sure batch request are not overwhelming the main loop.
  • Any change on the item size is currently throwing all cache out from the position manager (and in general the position manager give up on its cache way to easily).
  • There is no way for the collection view to inform the position manager of information like item average size or total view port size which would avoid batching size request unnecessarily.
Fri, Nov 8, 10:30 AM · Restricted Project, efl: mvvm, efl: widgets
cedric accepted D10628: elm: apply the same fix we needed in entry to other scrollable widgets.

This isn't an ideal patch, but I don't really have a better idea on how to make this happen on theme apply otherwise as scrollable is an interface :-(

Fri, Nov 8, 9:40 AM · efl

Thu, Nov 7

cedric requested review of D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Thu, Nov 7, 4:24 PM · efl
cedric added a child revision for D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView.: D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Thu, Nov 7, 4:23 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10625: elementary: fix initialization order and memory leak when setting model on Efl.Ui.CollectionView..
Thu, Nov 7, 4:23 PM · efl: mvvm
cedric requested review of D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..
Thu, Nov 7, 4:23 PM · efl
cedric added a child revision for D10623: ecore: properly handle children destruction in Efl.BooleanModel.: D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..
Thu, Nov 7, 4:23 PM · efl
cedric requested review of D10623: ecore: properly handle children destruction in Efl.BooleanModel..
Thu, Nov 7, 4:23 PM · efl
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10624: elementary: fix recursive case during model fetch in Efl.Ui.CollectionView..
Thu, Nov 7, 4:23 PM · efl: mvvm
cedric added a revision to T8358: Item suppression make selection a bit buggy: D10623: ecore: properly handle children destruction in Efl.BooleanModel..
Thu, Nov 7, 4:23 PM · efl: mvvm
cedric triaged T8469: Review index use as High priority.
Thu, Nov 7, 1:29 PM · efl: mvvm
cedric added a comment to T7871: efl.ui.multi_selectable.

After some more back and forth with @bu5hm4n discussion on IRC, it seems very hard to actually merge those two multiselect interface as they do have different constraint.

Thu, Nov 7, 1:25 PM · efl: api, efl: language bindings
cedric closed D10621: elementary: watch event on the model Efl.Ui.CollectionView use directly..
Thu, Nov 7, 1:24 PM · efl