Page MenuHomePhabricator
Feed Advanced Search

Today

JackDanielZ added a comment to D6950: db: introduce [de]serializing _DB as a file.

I tried to make it work. It seems ok now, at least the DB display output is the same before and after load. I attached the patch here. Please update latest ea_gen and apply the patch.

Tue, Nov 13, 3:10 PM

Sun, Nov 11

JackDanielZ added a comment to D6950: db: introduce [de]serializing _DB as a file.

I will try to work on it this week and update you asap.

Sun, Nov 11, 3:24 AM
JackDanielZ closed D7239: Inspect: support to print the exu diff result to standard output.
Sun, Nov 11, 1:34 AM
JackDanielZ accepted D7239: Inspect: support to print the exu diff result to standard output.
Sun, Nov 11, 1:32 AM
JackDanielZ closed D7250: db: fix _db_clear() to refer to proper variable.
Sun, Nov 11, 1:31 AM
JackDanielZ accepted D7250: db: fix _db_clear() to refer to proper variable.
Sun, Nov 11, 1:30 AM

Thu, Nov 8

JackDanielZ added inline comments to D7239: Inspect: support to print the exu diff result to standard output.
Thu, Nov 8, 2:34 AM
JackDanielZ added a comment to D7227: Spy: Prevent unexpected pointer dereference.

The problem with setting data to NULL is that it is internally used by elm_index. When the item is created, this data (no matter func) is set as the data of the item and is then used to find the item...

Thu, Nov 8, 2:33 AM

Wed, Nov 7

JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

What I meant:
For example, you need to run 100 tests together. You create some txt file with the tests name per line. You execute exactness with this file, -b the path to the exu files and other params that I don't remember. You attach to the Ecore_Exe some type "exactness_suite" or whatever you want. When you receive output in _output_exe_cb/_end_exe_cb, you parse to find some specific lines e.g STATUS test_20181107_1443_01 START... and other events such as COMPARE, OK, FAIL(3/7)... For each such event lines, you update your list item with the right status/color... That's why I don't understand why you need yohoho patch. His patch is usable only when the test is finished, but cannot help you to give live update. I just pushed the patch of the STATUS.
If the test failed, double-click can display the different images. To do this, you just need to open the exu output and show it.

Wed, Nov 7, 5:04 AM
JackDanielZ added a comment to D7239: Inspect: support to print the exu diff result to standard output.

If it is with the goal to parse it, so don't use the colors. Less pretty but more practical. Go for it!

Wed, Nov 7, 4:36 AM

Mon, Nov 5

JackDanielZ added inline comments to D7239: Inspect: support to print the exu diff result to standard output.
Mon, Nov 5, 3:08 AM

Sun, Nov 4

JackDanielZ added a reviewer for D7237: Slider: fix callback invocation: eagleeye.
Sun, Nov 4, 7:24 AM · efl
JackDanielZ requested review of D7237: Slider: fix callback invocation.
Sun, Nov 4, 7:22 AM · efl

Sat, Nov 3

JackDanielZ added a comment to D7227: Spy: Prevent unexpected pointer dereference.

Why setting data to NULL is needed? When I run the test, it is a success. I encountered this kind of problem and I fixed the issue with 28ab3df2.

Sat, Nov 3, 11:33 AM
JackDanielZ closed D7229: gui: prevent potentional race-condition.
Sat, Nov 3, 11:24 AM
JackDanielZ accepted D7229: gui: prevent potentional race-condition.

Well, theoretically, it shouldn't happen. Anyway, it seems nicer :-)

Sat, Nov 3, 11:24 AM
JackDanielZ closed D7236: gui: turn fileselector expandable mode off.
Sat, Nov 3, 11:12 AM
JackDanielZ accepted D7236: gui: turn fileselector expandable mode off.

Do you know if/when there will be a fix for this bug?

Sat, Nov 3, 11:12 AM

Fri, Nov 2

JackDanielZ added inline comments to D6950: db: introduce [de]serializing _DB as a file.
Fri, Nov 2, 3:31 AM
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

Hi Junsu,

Fri, Nov 2, 3:16 AM

Thu, Nov 1

JackDanielZ added a comment to D7217: GUI: update db panel.

Bloody phab, I didn't finish my comments:

Thu, Nov 1, 4:08 AM
JackDanielZ added a comment to D7217: GUI: update db panel.

Hi Bowon,

Thu, Nov 1, 3:51 AM
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

I needed the threads to generate the ML files in parallel. I didn't want to do it externally because building the DB takes relatively a lot of time.

Thu, Nov 1, 1:46 AM

Wed, Oct 31

JackDanielZ abandoned D7223: Meson: add themes path to Elementary pc file.
Wed, Oct 31, 1:48 PM · efl
JackDanielZ accepted D7224: meson: allow setting of custom pc variables.

Seems great here funny boy!

Wed, Oct 31, 1:48 PM · efl
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

I know that my question can seem dumb but... why do you need threads? There is no calculation at all there, only pass to the main loop, meaning the threads mechanism won't block anything.

Wed, Oct 31, 1:45 PM
JackDanielZ added a reviewer for D7223: Meson: add themes path to Elementary pc file: bu5hm4n.
Wed, Oct 31, 1:21 AM · efl
JackDanielZ requested review of D7223: Meson: add themes path to Elementary pc file.
Wed, Oct 31, 1:21 AM · efl

Tue, Oct 30

JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

Hi Junsu,

Tue, Oct 30, 11:51 PM

Sat, Oct 27

JackDanielZ closed D7218: GUI : Add "Discard error apps" feature.
Sat, Oct 27, 9:51 AM
JackDanielZ accepted D7218: GUI : Add "Discard error apps" feature.
Sat, Oct 27, 9:49 AM

Fri, Oct 26

JackDanielZ closed D7215: GUI : Add "Remove directory path" feature.
Fri, Oct 26, 1:15 AM
JackDanielZ accepted D7215: GUI : Add "Remove directory path" feature.
Fri, Oct 26, 1:15 AM
JackDanielZ added a comment to D6950: db: introduce [de]serializing _DB as a file.

I added comments on how I think EET can be used for the DB.

Fri, Oct 26, 1:13 AM
JackDanielZ added a comment to D7215: GUI : Add "Remove directory path" feature.

Please rename the ticket

Fri, Oct 26, 12:28 AM
JackDanielZ closed D7212: GUI : Fix read for filename extension.
Fri, Oct 26, 12:27 AM
JackDanielZ accepted D7212: GUI : Fix read for filename extension.
Fri, Oct 26, 12:26 AM

Thu, Oct 25

JackDanielZ added a comment to D7212: GUI : Fix read for filename extension.

You are right, it is wrong. I thought it was strrchr there. Why not just changing to strrchr?

Thu, Oct 25, 11:46 PM
JackDanielZ closed D7210: Add shared option to make a binary as a shared object.
Thu, Oct 25, 11:34 PM
JackDanielZ accepted D7210: Add shared option to make a binary as a shared object.
Thu, Oct 25, 11:34 PM
JackDanielZ added a comment to D7215: GUI : Add "Remove directory path" feature.

You mean remove, right? Because export is very confusing to me. Export is more taking some directory to export it to somewhere else, with another format...

Thu, Oct 25, 11:29 PM
JackDanielZ added a comment to D7212: GUI : Fix read for filename extension.

Hi Junsu,

Thu, Oct 25, 11:22 PM
JackDanielZ added inline comments to D7206: ea_gen: Load config env with local_config.sh.
Thu, Oct 25, 2:07 AM
JackDanielZ closed D7209: Data: update efl_01.patch file.
Thu, Oct 25, 1:31 AM
JackDanielZ accepted D7209: Data: update efl_01.patch file.
Thu, Oct 25, 1:31 AM
JackDanielZ closed D7207: ea_gen : Prevent empty parent names..
Thu, Oct 25, 1:29 AM
JackDanielZ accepted D7207: ea_gen : Prevent empty parent names..
Thu, Oct 25, 1:29 AM

Tue, Oct 23

JackDanielZ closed D7202: Overwrite eet config file once env var is passed.
Tue, Oct 23, 11:08 PM
JackDanielZ accepted D7202: Overwrite eet config file once env var is passed.
Tue, Oct 23, 11:07 PM

Sat, Oct 20

JackDanielZ closed D7184: Meson: set vieet as executable.
Sat, Oct 20, 11:41 PM · efl
JackDanielZ closed D7178: Meson: link elementary_test with rdynamic.
Sat, Oct 20, 11:39 PM · efl
JackDanielZ added a reviewer for D7184: Meson: set vieet as executable: bu5hm4n.
Sat, Oct 20, 11:21 PM · efl
JackDanielZ requested review of D7184: Meson: set vieet as executable.
Sat, Oct 20, 11:21 PM · efl
JackDanielZ updated the diff for D7178: Meson: link elementary_test with rdynamic.

Fix the previous update

Sat, Oct 20, 11:15 PM · efl
JackDanielZ updated the diff for D7178: Meson: link elementary_test with rdynamic.

Add the flag to the other elementary binaries

Sat, Oct 20, 11:14 PM · efl

Thu, Oct 18

JackDanielZ added a comment to D7178: Meson: link elementary_test with rdynamic.

I asked you first! On my side, I need this flag only for this binary. But it seems better if we use it for all. If you are ok with that, I will update this patch

Thu, Oct 18, 11:27 PM · efl
JackDanielZ added a reviewer for D7178: Meson: link elementary_test with rdynamic: bu5hm4n.

Do you think we need to add this flag to all the EFL binaries?

Thu, Oct 18, 1:17 PM · efl
JackDanielZ requested review of D7178: Meson: link elementary_test with rdynamic.
Thu, Oct 18, 12:43 PM · efl

Sep 30 2018

JackDanielZ added a comment to D7037: genlist: fix item show/bring in coordinate calculation with zero-sized pan..

Hi guys,

Sep 30 2018, 9:09 AM · efl

Sep 20 2018

JackDanielZ closed D7076: GUI: new menu implement.
Sep 20 2018, 1:19 PM
JackDanielZ accepted D7076: GUI: new menu implement.
Sep 20 2018, 1:19 PM
JackDanielZ added a comment to D7076: GUI: new menu implement.

Thank you, seems great! I fixed the warnings.

Sep 20 2018, 1:19 PM
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

Hi Hermet,

Sep 20 2018, 12:58 AM · efl

Sep 17 2018

JackDanielZ closed D7034: Spy: Fix elm_toolbar_item_menu_get hooking function name.
Sep 17 2018, 3:46 AM
JackDanielZ accepted D7034: Spy: Fix elm_toolbar_item_menu_get hooking function name.
Sep 17 2018, 3:45 AM

Sep 15 2018

JackDanielZ closed D7032: GUI: Code clean up and bug fix for tab..
Sep 15 2018, 10:14 AM
JackDanielZ accepted D7032: GUI: Code clean up and bug fix for tab..
Sep 15 2018, 10:14 AM

Sep 13 2018

JackDanielZ closed D6993: GUI: Tab implement.
Sep 13 2018, 6:53 AM
JackDanielZ accepted D6993: GUI: Tab implement.
Sep 13 2018, 6:52 AM
JackDanielZ added a comment to D7025: C Gen: Modify to generate the class within the callback, if parent is genlist.item..

I pushed the fix for the configuration. Good catch! Now I think you should have Elm.Genlist.Item as kl. real_kl should not be used there as it may be confusing.

Sep 13 2018, 6:47 AM

Sep 12 2018

JackDanielZ added inline comments to D7025: C Gen: Modify to generate the class within the callback, if parent is genlist.item..
Sep 12 2018, 6:04 AM

Sep 11 2018

JackDanielZ added a comment to D6993: GUI: Tab implement.

And please fix the warnings! :-)

Sep 11 2018, 1:24 PM
JackDanielZ added a comment to D6993: GUI: Tab implement.

It seems really good now! Thank you!

Sep 11 2018, 1:21 PM
JackDanielZ reopened D6919: evas image: fix a bug in image preloading..

ping?

Sep 11 2018, 1:13 PM · efl
JackDanielZ closed D6994: Spy : Support EA_CREATE, EA_MODIFY function of item class.
Sep 11 2018, 1:11 PM
JackDanielZ accepted D6994: Spy : Support EA_CREATE, EA_MODIFY function of item class.
Sep 11 2018, 1:11 PM
JackDanielZ closed D7021: Spy : Set index widget as legacy.
Sep 11 2018, 12:55 PM
JackDanielZ accepted D7021: Spy : Set index widget as legacy.
Sep 11 2018, 12:54 PM
JackDanielZ closed D7020: Spy : Set notify widget as legacy.
Sep 11 2018, 12:53 PM
JackDanielZ accepted D7020: Spy : Set notify widget as legacy.
Sep 11 2018, 12:51 PM
JackDanielZ closed D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.
Sep 11 2018, 12:49 PM
JackDanielZ accepted D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.
Sep 11 2018, 12:49 PM

Sep 8 2018

JackDanielZ closed D7005: Spy : Set panel widget as legacy.
Sep 8 2018, 1:32 PM
JackDanielZ added a comment to D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.

Hi Junsu,

Sep 8 2018, 1:30 PM
JackDanielZ accepted D7005: Spy : Set panel widget as legacy.
Sep 8 2018, 1:28 PM
JackDanielZ closed D7004: Spy : Using efl_part if part isn't default when using efl_content_set.
Sep 8 2018, 1:27 PM
JackDanielZ accepted D7004: Spy : Using efl_part if part isn't default when using efl_content_set.
Sep 8 2018, 1:27 PM
JackDanielZ closed D7003: Spy : Add elm_slider legacy APIs and set legacy widget.
Sep 8 2018, 1:23 PM
JackDanielZ accepted D7003: Spy : Add elm_slider legacy APIs and set legacy widget.
Sep 8 2018, 12:38 PM
JackDanielZ added a comment to D7003: Spy : Add elm_slider legacy APIs and set legacy widget.

Thank you for the patch! Did you investigate the size issue?

Sep 8 2018, 12:38 PM
JackDanielZ closed D6914: Using efl_add_ref when called efl_add if parent is null.
Sep 8 2018, 12:32 PM
JackDanielZ accepted D6914: Using efl_add_ref when called efl_add if parent is null.

Sorry for the delay, I just saw it now (Too much Phab mails)

Sep 8 2018, 12:32 PM

Sep 7 2018

JackDanielZ added a comment to D6993: GUI: Tab implement.

Hi Bowon,

Sep 7 2018, 12:21 AM

Sep 6 2018

JackDanielZ closed D7002: Add My.Grid eo and elm_grid_pack_set legacy API.
Sep 6 2018, 11:29 PM
JackDanielZ accepted D7002: Add My.Grid eo and elm_grid_pack_set legacy API.
Sep 6 2018, 11:28 PM
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

http://www.enlightenment.org/ss/e-5b9219b15fe6c3.46092975.jpg

Sep 6 2018, 11:25 PM · efl
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

Hi Hermet,

Sep 6 2018, 11:24 PM · efl
JackDanielZ added a comment to D6993: GUI: Tab implement.

Hi Bowon,

Sep 6 2018, 1:13 PM

Sep 5 2018

JackDanielZ closed D6990: Spy : Modify lagacy function name for elm_photo.
Sep 5 2018, 10:51 PM
JackDanielZ accepted D6990: Spy : Modify lagacy function name for elm_photo.
Sep 5 2018, 10:51 PM