remove libweb dependency for libwebpdemux
Thu, May 28
Add checking return value for getting next frame
Wed, May 27
Mon, May 25
modified code for comments
This is tested by my environments and removed the duplicated register cases.
clean up the codes
update sample codes
Thu, May 21
Tue, May 19
for DnD-4: when the drag object moved to the target object and the drag is finished, the target->currently_inside flag should be false. but _enter_state_changed_cb dose not change the target->currently_inside flag to false when drag is done.
for CnP-1: I think this is the policy problem, we decide to allow the copy and paste without the input changes.
for CnP-2: The problem is that the call of loss_callback can be different depends on the server. I think it's better to give same result regardless the server.
for CnP-2 (new case)
I have a question about elm_cnp_loss_callback_set() function.
I think the loss_callback behavior is changed compared to before.
The serial is updated by only input codes, so when we try to copy and paste using button(the serial is updated and copy and paste work well)
src/lib/ecore_wl2/ecore_wl2_input.c:697: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:721: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:768: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:942: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:969: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1062: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1241: input->display->serial = serial;
Mon, May 18
before EFL_UI_DND_EVENT_DROP_ENTERED and EFL_UI_DND_EVENT_DROP_LEFT event are triggered by only motion events.
but the events in _enter_state_change_cb() will emit additional event to the application.
DnD-1: drop event register twice is not reproduced with the patch in my environment.
I have question about _enter_state_change_cb(), I think in _motion_cb() we emit EFL_UI_DND_EVENT_DROP_LEFT, EFL_UI_DND_EVENT_DROP_ENTER already.
should we emit the event in _enter_state_change_cb()?
(before the drag enter and leave event are triggered by the drag object moves)
I think this seems to be bug, there is a case that drop_target is added twice.
I think the drop left and drop entered event order are important.
I created the patch for resolving DnD2 problem.
please review this :)
Fri, May 15
Mon, May 11
Wed, May 6
Apr 12 2020
Mar 17 2020
Mar 16 2020
This patch looks very similar to D11511. Can you take into account the comments I made there?
Updating D11514: evas_vg: refined the documentation for evas vector APIs
evas_vg: refined the evas vector APIs set
hello, thanks for the comment, I will divide this patch for readability(D11513 is the first path of this)
Evas_Vg_Join enum values refers to src/lib/efl/interfaces/efl_gfx_types.eot:71(Efl.Gfx.Join)
and in case of other comments, I will change to follow your comments.
Looks like you are defining new enums here that are already present in Eo files. Can you explain why?
=> because I think legacy APIs should use legacy enum values, so I defined evas enum types
ex) for hiding gfx enums
evas_vg_shape_path_set(Evas_Vg_Shape *obj, const Evas_Vg_Path_Command *op, const double *points)
evas_vg_shape_stroke_dash_get(Evas_Vg_Shape *obj, const Evas_Vg_Dash **dash, unsigned int *length)
evas_vg_gradient_stop_set(Evas_Vg_Gradient *obj, const Evas_Vg_Gradient_Stop *colors, unsigned int length)
evas_vg_shape_stroke_dash_set(Eo *obj, const Evas_Vg_Dash *dash, unsigned int length)
I think @zmike worked on the move of this stuff from Legacy to Eo some time ago, it might be worth asking his opinion.
abandon this revision
evas_vg: refined the documentation for evas vector APIs
updated version for new evas enums
I will update as other patch
Mar 11 2020
Mar 4 2020
updated codes for adding documentation
Jan 8 2020
I checked this codes on my desktop and it is reproduced with x11 environment.
In case of pasting twice, it is blocked by below codes.
Dec 5 2019
Dec 4 2019
Nov 6 2019
Nov 5 2019
update the codes
add @beta tag
modified the codes
Nov 4 2019
Oct 14 2019
I made a patch that synchronizes with the upstream code.
Actually the upstream eolian grammar has been changed from 2019.Oct
so I added more verbs and modifyed the event and function names.
You can apply this patch after rebasing.
Oct 13 2019
Sep 4 2019
Sep 3 2019
Aug 29 2019
After zmike's refactoring the popup, the enum will be removed
Aug 27 2019
In fact, I don't have enough time to handle this since I have to migrate upstream code to tizen until next wednesday.
and I should make the entire EflSharp UnitTest set until end of september. I think the amount of TC set that I have to make quite large.
so I'm not sure to answer :(
You mean that making the parts class for the buttons, right?
I also agree with your opinion and I think the parts should implement content and text interfaces for the setting text and icon of buttons
Aug 25 2019
Aug 20 2019
I talked with woohyun about this refactoring for popup,
we have to finish this task until early september since we will start the release for EflSharp after the middle of september.
please take care of this schedule.
The application developers in tizen need two types of popup such as context style and alert style
In case of the context style like elm_ctxpopup of efl needs priority align feature because the context popup should be shown depending on mouse position and in the screen boundary.
when the context popup is created near the screen boundary, the priority is used to find the optimal position of the context popup which the user wants.
In case of the alert style like elm_popup of efl needs align feature because some developer want the popup to be aligned whenever the screen is resized.
However If there are some ways to set the priority using algin hints or find optimal position, I think we can remove the priority set API :)
Aug 12 2019
Hi, I agree to your opinion, the usage of the anchor popup align is different from base popup.
so I think the align feature in anchor popup should be separated from Efl.Ui.Popup.Align
and make the anchor popup has its own priority align features.
Jul 25 2019
Jul 2 2019
I agreed with you :)
abandon this patch
Jun 27 2019
Jun 26 2019
I agree to bu5hm4n's opinion and I think segfaultxavi's idea can be good alternatives.
It looks good for me :)
The enum values support the alignment setting for the very high frequent alignment.
I think this is the important factor from the user perspective.
Also there need to add left_top, right_top, left_bottom, right_bottom enum values.
Jun 24 2019
I think the max_size_hint is different with popup_size.
the max_size in efl_ui_popup means the maximum size that the popup can expand.
If the max_size_hint is used to change the popup size, the popup will not be expandable.
Therefore, I think it's not good to change popup_size to max_size_hint.
In case of the alignment API of popup, It is designed to notify the options to the users.
To use this API makes the code simple and easy.
Jun 5 2019
Jun 4 2019
Apr 24 2019
No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.
The goto is unnecessary, syntax error means a long jump
Hi, you mean these codes are intended?
but actually the following codes are not reachable.
2198: if (is_enum)
2199: eo_lexer_syntax_error(ls, "enums cannot have @free");
Apr 23 2019
Apr 22 2019