Wed, Jul 29
Thu, Jul 16
Jun 17 2020
This patch will be replaced with D11979
clean up the codes
In my opinion, if Efl.Ui.Image needs to do the same, I think I can handle this on line 939. Is it only necessary to support legacy?
Jun 15 2020
update source codes
Jun 12 2020
update source code
Jun 11 2020
update source code
Jun 9 2020
update codes based on comments
change the API name
remove interface and support legacy API
May 28 2020
remove libweb dependency for libwebpdemux
Add checking return value for getting next frame
May 27 2020
May 25 2020
modified code for comments
This is tested by my environments and removed the duplicated register cases.
clean up the codes
update sample codes
May 21 2020
May 19 2020
for DnD-4(1): I think the event enter and left in _motion_cb, the event enter and left in _enter_state_change_cb are different. the events in motion_cb are triggered by motion.
but the events in _enter_state_change_cb are triggered by wayland enter and left events.
I have a doubt to serve same events about both cases.
for DnD-4(2): when the drag object moved to the target object and the drag is finished, the target->currently_inside flag should be false. but _enter_state_changed_cb dose not change the target->currently_inside flag to false when drag is done.
for CnP-2 (new case)
I have a question about elm_cnp_loss_callback_set() function.
I think the loss_callback behavior is changed compared to before.
The serial is updated by only input codes, so when we try to copy and paste using button(the serial is updated and copy and paste work well)
src/lib/ecore_wl2/ecore_wl2_input.c:697: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:721: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:768: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:942: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:969: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1062: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1241: input->display->serial = serial;
May 18 2020
before EFL_UI_DND_EVENT_DROP_ENTERED and EFL_UI_DND_EVENT_DROP_LEFT event are triggered by only motion events.
but the events in _enter_state_change_cb() will emit additional event to the application.
for DnD-1: drop event register twice is not reproduced with the patch in my environment.
I have question about _enter_state_change_cb(), I think in _motion_cb() we emit EFL_UI_DND_EVENT_DROP_LEFT, EFL_UI_DND_EVENT_DROP_ENTER already.
should we emit the event in _enter_state_change_cb()?
(before the drag enter and leave event are triggered by the drag object moves)
I think this seems to be bug, there is a case that drop_target is added twice.
how about remove _drop_event_register() in elm_drop_target_add()?
I think the drop left and drop entered event order are important.
I created the patch for resolving DnD-2 problem.
please review this :)
May 15 2020
May 11 2020
May 6 2020
Apr 12 2020
Mar 17 2020
Mar 16 2020
This patch looks very similar to D11511. Can you take into account the comments I made there?
Updating D11514: evas_vg: refined the documentation for evas vector APIs
evas_vg: refined the evas vector APIs set
hello, thanks for the comment, I will divide this patch for readability(D11513 is the first path of this)
Evas_Vg_Join enum values refers to src/lib/efl/interfaces/efl_gfx_types.eot:71(Efl.Gfx.Join)
and in case of other comments, I will change to follow your comments.
Looks like you are defining new enums here that are already present in Eo files. Can you explain why?
=> because I think legacy APIs should use legacy enum values, so I defined evas enum types
ex) for hiding gfx enums
evas_vg_shape_path_set(Evas_Vg_Shape *obj, const Evas_Vg_Path_Command *op, const double *points)
evas_vg_shape_stroke_dash_get(Evas_Vg_Shape *obj, const Evas_Vg_Dash **dash, unsigned int *length)
evas_vg_gradient_stop_set(Evas_Vg_Gradient *obj, const Evas_Vg_Gradient_Stop *colors, unsigned int length)
evas_vg_shape_stroke_dash_set(Eo *obj, const Evas_Vg_Dash *dash, unsigned int length)
I think @zmike worked on the move of this stuff from Legacy to Eo some time ago, it might be worth asking his opinion.
abandon this revision
evas_vg: refined the documentation for evas vector APIs
updated version for new evas enums
I will update as other patch
Mar 11 2020
Mar 4 2020
updated codes for adding documentation