Page MenuHomePhabricator
Feed Advanced Search

Today

lauromoura closed T8145: C/C#: Efl.Ui.Table causes app do not quit and froze as Resolved.
Fri, Aug 23, 11:33 AM · efl: language bindings
lauromoura requested review of D9733: elm: Fix Scrollable_Content namespace.
Fri, Aug 23, 10:56 AM · efl
lauromoura added a comment to D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

Still applies and test runs cleanly.

Fri, Aug 23, 7:56 AM · efl
lauromoura reassigned T8172: C#: Correct order of access modifiers and inheritance modifiers from lauromoura to brunobelo.

Sure.

Fri, Aug 23, 6:05 AM

Yesterday

lauromoura added a comment to D9717: csharp: Revamp dotnet support.

Tentative patch. Added DO_NOT_MERGE while we get feedback from @woohyun and @Jaehyun_Cho regarding this dotnet change.

Thu, Aug 22, 8:31 PM · DO NOT MERGE, efl
lauromoura added a task to D9717: csharp: Revamp dotnet support: T8168: C#: Build with dotnet and upstream meson.
Thu, Aug 22, 8:29 PM · DO NOT MERGE, efl
lauromoura added a revision to T8168: C#: Build with dotnet and upstream meson: D9717: csharp: Revamp dotnet support.
Thu, Aug 22, 8:29 PM · efl: language bindings
lauromoura requested review of D9717: csharp: Revamp dotnet support.
Thu, Aug 22, 8:28 PM · DO NOT MERGE, efl
lauromoura requested review of D9714: csharp: Only build extension methods for beta.
Thu, Aug 22, 4:40 PM · efl
lauromoura accepted D9638: csharp: add legacy eo in mono blacklist.
Thu, Aug 22, 8:06 AM · efl
lauromoura accepted D9690: eolian-mono: Add support for partial classes.

Good to go.

Thu, Aug 22, 8:05 AM · efl
lauromoura removed a project from D9653: csharp: Add bindable factory parts support: DO NOT MERGE.
Thu, Aug 22, 6:55 AM · efl

Wed, Aug 21

lauromoura added a comment to T8166: C#: Remove I prefix from argument structs for class events.

The interface name was added to the struct name in order to avoid collisions between event arg structures with the same name. Removing this prefix leads at least to the following clashes:

Wed, Aug 21, 2:56 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

From C# guidelines in https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-type-members#names-of-events:

Wed, Aug 21, 1:01 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

Here is a list of generated events from the C# files. (without the prefix).

Wed, Aug 21, 12:59 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura assigned T8034: C#: Make C# classes partials to felipealmeida.
Wed, Aug 21, 12:07 PM · efl: language bindings
lauromoura moved T8034: C#: Make C# classes partials from Backlog to InProgress on the efl: language bindings board.
Wed, Aug 21, 12:07 PM · efl: language bindings
lauromoura added a comment to T8165: C#: Hide unecessary API.

We could try hiding them but AFAIR they should be public so inherited classes can use them.

Wed, Aug 21, 11:54 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8164: C#: Event args suffix.

Evt today comes from the name of the event. Related to T8163

Wed, Aug 21, 11:53 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

This could be kinda tricky to do in a generic way. We may end up having to build a list of irregular verbs and their past tense in order to generate them.

Wed, Aug 21, 11:47 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

We may encounter some difficulty generating the files in sub folders as a meson issue [1] limits the output of custom_target command to be placed in the same folder as it is called.

Wed, Aug 21, 11:35 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8168: C#: Build with dotnet and upstream meson as High priority.
Wed, Aug 21, 11:30 AM · efl: language bindings
lauromoura triaged T8167: C#: Fix indentation and blanklines as High priority.
Wed, Aug 21, 11:05 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8166: C#: Remove I prefix from argument structs for class events as High priority.
Wed, Aug 21, 11:02 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8165: C#: Hide unecessary API as High priority.
Wed, Aug 21, 11:01 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8164: C#: Event args suffix as High priority.
Wed, Aug 21, 10:57 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8163: C#: Event naming as High priority.
Wed, Aug 21, 10:56 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8162: C#: .cs file naming with PascalCase as High priority.
Wed, Aug 21, 10:55 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Tue, Aug 20

lauromoura added a comment to D9653: csharp: Add bindable factory parts support.

This is a tentative patch with the C# syntax changes for factory binding static parts that are based on Efl.IContent.

Tue, Aug 20, 4:57 PM · efl
lauromoura added a task to D9653: csharp: Add bindable factory parts support: T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono.
Tue, Aug 20, 4:55 PM · efl
lauromoura added a revision to T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono: D9653: csharp: Add bindable factory parts support.
Tue, Aug 20, 4:54 PM · efl: mvvm
lauromoura requested review of D9653: csharp: Add bindable factory parts support.
Tue, Aug 20, 4:54 PM · efl
lauromoura accepted D9604: efl: use a @static function so that binding can pick it up..
Tue, Aug 20, 1:11 PM · efl
lauromoura accepted D9635: elementary: use the right function for creating object from Efl.Ui.Factory..
Tue, Aug 20, 12:40 PM · efl
lauromoura accepted D9603: elementary: prefer use of Efl unified API..
Tue, Aug 20, 12:32 PM · efl
lauromoura accepted D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..
Tue, Aug 20, 12:26 PM · efl
lauromoura accepted D9579: elementary: switch Efl.Ui.Factory API to a batch API and update all class using it..
Tue, Aug 20, 12:10 PM · efl
lauromoura accepted D9638: csharp: add legacy eo in mono blacklist.

Looks good alongside D9637.

Tue, Aug 20, 9:09 AM · efl
lauromoura added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

Just one thing, can you test how do the generated DocFX pages look like when tuples are involved?

Tue, Aug 20, 7:56 AM · efl

Mon, Aug 19

lauromoura added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

Oh, also updated after small conflict with @static in the test eo.

Mon, Aug 19, 4:05 PM · efl
lauromoura updated the diff for D9577: eolian-mono: Add support for multi-value properties with tuples.

Update with header cleanup and testing properties

Mon, Aug 19, 4:04 PM · efl
lauromoura commandeered D9577: eolian-mono: Add support for multi-value properties with tuples.
Mon, Aug 19, 4:04 PM · efl
lauromoura added a comment to D9564: csharp: MVVM parts support.

arc patch didn't retrieve a different commit message

Mon, Aug 19, 1:43 PM · efl
lauromoura updated the summary of D9564: csharp: MVVM parts support.
Mon, Aug 19, 1:42 PM · efl
lauromoura updated the diff for D9564: csharp: MVVM parts support.

Update commit message

Mon, Aug 19, 1:31 PM · efl
lauromoura added a comment to D9627: elm: avoid clash in Collection.Focus_Manager.

:P

Mon, Aug 19, 1:19 PM · efl
lauromoura closed D9627: elm: avoid clash in Collection.Focus_Manager.
Mon, Aug 19, 9:21 AM · efl
lauromoura requested review of D9627: elm: avoid clash in Collection.Focus_Manager.
Mon, Aug 19, 7:23 AM · efl
lauromoura requested review of D9626: pyolian: Update after event and binbuf keywords.
Mon, Aug 19, 7:20 AM · efl

Fri, Aug 16

lauromoura renamed T8145: C/C#: Efl.Ui.Table causes app do not quit and froze from Efl.Ui.Table causes app do not quit and froze to C#: Efl.Ui.Table causes app do not quit and froze.
Fri, Aug 16, 3:01 PM · efl: language bindings
lauromoura added a reviewer for D9564: csharp: MVVM parts support: woohyun.
Fri, Aug 16, 6:32 AM · efl
lauromoura added a comment to D9564: csharp: MVVM parts support.

Patch is good for review and merging.

Fri, Aug 16, 6:25 AM · efl
lauromoura removed a project from D9564: csharp: MVVM parts support: DO NOT MERGE.
Fri, Aug 16, 6:25 AM · efl

Thu, Aug 15

lauromoura added inline comments to D9577: eolian-mono: Add support for multi-value properties with tuples.
Thu, Aug 15, 7:16 PM · efl
lauromoura accepted D9575: eolian-cxx: Fix use after free for base variable.
Thu, Aug 15, 6:30 PM · efl
lauromoura accepted D9576: eolian-mono: Use correct allocator to free with free, and not delete.
Thu, Aug 15, 6:30 PM · efl
lauromoura added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

I'll leave the technical details to the c# people, but I think it is a bit late in the day to change the c# bindings syntax now. Not impossible, though.
All name clashes were already solved a long time ago by renaming properties named like classes. Only these three remained (Key, Hold and Text) because they were in a blacklist in the c# generator and I forgot about them.

Thu, Aug 15, 7:09 AM · efl

Wed, Aug 14

lauromoura updated the diff for D9564: csharp: MVVM parts support.

Update the test after updates in the C binding process

Wed, Aug 14, 11:48 AM · efl
lauromoura updated the diff for D9563: elementary: Avoid segfault when part is not set..

Update getting the pd from the correct class and emitting the property,bound event.

Wed, Aug 14, 11:45 AM · efl
lauromoura created T8133: C#: Support multi-value properties.
Wed, Aug 14, 10:09 AM

Tue, Aug 13

lauromoura added a comment to D9564: csharp: MVVM parts support.

Added the DO NOT MERGE tag so we can start reviewing this while we fix an issue regarding getting the part from the binder.

Tue, Aug 13, 7:55 PM · efl
lauromoura added a project to D9564: csharp: MVVM parts support: DO NOT MERGE.
Tue, Aug 13, 7:54 PM · efl
lauromoura requested review of D9564: csharp: MVVM parts support.
Tue, Aug 13, 7:54 PM · efl
lauromoura added a child revision for D9563: elementary: Avoid segfault when part is not set.: D9564: csharp: MVVM parts support.
Tue, Aug 13, 7:54 PM · efl
lauromoura requested review of D9563: elementary: Avoid segfault when part is not set..
Tue, Aug 13, 7:43 PM · efl

Mon, Aug 12

lauromoura added a comment to T7616: Modify meson project to find and use dotnet csc correctly.

Still having some issues regarding package caching. Nuget seems too conservative to restore a recently built Efl.Csharp package, even with restore -f --no-cache, etc. Just works after cleaning the package registry.

Mon, Aug 12, 8:20 PM
lauromoura added a comment to T7616: Modify meson project to find and use dotnet csc correctly.

I've updated the branch with some improvements:

Mon, Aug 12, 3:27 PM

Fri, Aug 9

lauromoura added a comment to T7675: Do not allow static-function polymorphism.
In T7675#139845, @tasn wrote:

Would it be a reasonable compromise to borrow the @static modifier from Python and use it alongside @class?

@static sounds like a good solution for T8118, but what's the advantage over just "floating"? Compatibility with languages that don't allow floating functions? How does C# handle "floating" structs btw? Do they have to be in a class too or is it OK to have them floating?

Fri, Aug 9, 6:37 AM · BBQ, efl: data types, Restricted Project

Thu, Aug 8

lauromoura added a comment to T7675: Do not allow static-function polymorphism.
In T7675#139819, @tasn wrote:

@lauromoura: I think I already addressed your comment too in my reply to @felipealmeida , please let me know if that's not the case.

Thu, Aug 8, 3:42 PM · BBQ, efl: data types, Restricted Project
lauromoura added a comment to T7675: Do not allow static-function polymorphism.

Do we have a use-case where we get the class type dynamically? If we use it statically, this is just syntax-sugar. And not even very sweet since it makes the code bigger.

Thu, Aug 8, 2:41 PM · BBQ, efl: data types, Restricted Project

Wed, Aug 7

lauromoura requested review of D9524: cxx: Fix funcptr c_args declaration..
Wed, Aug 7, 10:45 AM · efl
lauromoura added a comment to T7616: Modify meson project to find and use dotnet csc correctly.

Mhm - i have not looked in detail, but to me this seems like this breaks dependency tracking of the .cs files ? I a

Wed, Aug 7, 6:30 AM

Tue, Aug 6

lauromoura added a comment to T7616: Modify meson project to find and use dotnet csc correctly.

I've been trying another approach, as dotnet seems to be designed to be used through its regular cli commands (dotnet build, dotnet run, dotnet pack, etc.).

Tue, Aug 6, 9:36 PM
lauromoura closed D9487: docs: Improve Efl.Input.Key docs.
Tue, Aug 6, 2:05 AM · efl

Mon, Aug 5

lauromoura accepted D9484: efl_input_hold: replace hold property name with input_hold.

Yeah, this is good to go. Regarding Text, it is being discussed in the mentioned task in the diff summary.

Mon, Aug 5, 2:00 PM · efl
lauromoura updated the diff for D9457: csharp: fix ownership of value types in arrays and lists.

Rebase after conflict in klass_def.hh (doc_summary was added after this was accepted).

Mon, Aug 5, 1:44 PM · efl
lauromoura commandeered D9457: csharp: fix ownership of value types in arrays and lists.
Mon, Aug 5, 1:43 PM · efl
lauromoura updated the diff for D9487: docs: Improve Efl.Input.Key docs.

Rebase, updating with the new property name.

Mon, Aug 5, 1:33 PM · efl
lauromoura commandeered D9487: docs: Improve Efl.Input.Key docs.
Mon, Aug 5, 7:02 AM · efl

Fri, Aug 2

lauromoura added a comment to D9418: cxx: Add license to CXX bindings..

I think @jpeg did some patch for the C++ binding. I think it is required that everyone who did contribute code to this agree to the license change.

Fri, Aug 2, 10:52 AM · efl
lauromoura added inline comments to D9487: docs: Improve Efl.Input.Key docs.
Fri, Aug 2, 9:25 AM · efl

Thu, Aug 1

lauromoura accepted D9478: mono-docs: Add misc struct docs.

Accepting as the suggested changes were addressed in D9481 and D9482

Thu, Aug 1, 11:58 AM · efl
lauromoura added a parent revision for D9481: csharp: Avoid generating empty <value> tags Depends on D9478: D9478: mono-docs: Add misc struct docs.
Thu, Aug 1, 11:54 AM · efl
lauromoura added a child revision for D9478: mono-docs: Add misc struct docs: D9481: csharp: Avoid generating empty <value> tags Depends on D9478.
Thu, Aug 1, 11:54 AM · efl
lauromoura requested review of D9482: csharp: Add a documentation_string generator.
Thu, Aug 1, 11:52 AM · efl
lauromoura added a child revision for D9481: csharp: Avoid generating empty <value> tags Depends on D9478: D9482: csharp: Add a documentation_string generator.
Thu, Aug 1, 11:52 AM · efl
lauromoura requested review of D9481: csharp: Avoid generating empty <value> tags Depends on D9478.
Thu, Aug 1, 11:52 AM · efl
lauromoura added inline comments to D9478: mono-docs: Add misc struct docs.
Thu, Aug 1, 7:42 AM · efl

Wed, Jul 31

lauromoura added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Updating after big changes.

  • Rebase
  • MVVM C# classes working
  • Added some docs
  • Improved testing

    One change this version adds is that the Efl.Mono_Model_Internal class was moved to be built into the custom exports library instead of ecore, as it is a binding-specific class and this library is already imported by the binding.
Wed, Jul 31, 2:15 PM · efl: language bindings, Unknown Object (Project)
lauromoura accepted D9468: eolian-cxx: Generate eot files.
Wed, Jul 31, 1:51 PM · efl
lauromoura accepted D9469: eolian-cxx: Add special type tags to make function_wrapper specializations unique.
Wed, Jul 31, 1:25 PM · efl
lauromoura accepted D9467: csharp: re-enable binbuf tests with -Dmono-beta=false.

Working good

Wed, Jul 31, 12:44 PM · efl
lauromoura accepted D9457: csharp: fix ownership of value types in arrays and lists.
Wed, Jul 31, 12:30 PM · efl
lauromoura added a comment to T8093: Name conflict between class and property.

For Efl.Canvas.Text, I think it should be TextView (since it is most basic text element), TextLabel is more advanced element to show one line text.

Efl.Ui.Text can be "Textbox" or "Textblock" but again it may be conflicted with legacy canvas textblock

Question ?
Efl.Ui.Text and Efl.Canvas.Text are interfaces or objects ? if they are interfaces why donot we use "I" infront to detect that they are interfaces like Efl.UI.IText

Wed, Jul 31, 8:04 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Jul 30

lauromoura updated the diff for D9418: cxx: Add license to CXX bindings..

Update with copyright notice directing to AUTHORS file

Tue, Jul 30, 4:25 PM · efl
lauromoura updated the diff for D9414: csharp: Add licensing information..

Update with copyright notice directing to AUTHORS file for better tracking

Tue, Jul 30, 4:24 PM · efl
lauromoura requested review of D9449: csharp: Add EFL_BETA guards around new test.
Tue, Jul 30, 1:08 PM · efl
lauromoura requested review of D9448: ecore: Fix download test..
Tue, Jul 30, 12:02 PM · efl
lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Rebase and some small updates:

Tue, Jul 30, 11:09 AM · efl: language bindings, Restricted Project

Mon, Jul 29

lauromoura requested review of D9443: csharp: Add marshal support for Eina.ValueType.
Mon, Jul 29, 3:57 PM · efl