Page MenuHomePhabricator
Feed All Stories

Today

cedric added a comment to T8151: RFC: Text interfaces design proposal.
In T8151#140366, @tasn wrote:

Another note: I can already see how it's going to be very difficult to keep track of comments and discussion if we do it here in phab. The discussion has already diverged (@cedric and @ali.alzyod asked about different things), should me move it to edevelop? Or do you fellas prefer keeping it here?

Mon, Aug 19, 2:00 PM · efl: api
tasn added a comment to T8151: RFC: Text interfaces design proposal.

Another note: I can already see how it's going to be very difficult to keep track of comments and discussion if we do it here in phab. The discussion has already diverged (@cedric and @ali.alzyod asked about different things), should me move it to edevelop? Or do you fellas prefer keeping it here?

Mon, Aug 19, 1:55 PM · efl: api
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

@zmike can you please close this one

Mon, Aug 19, 1:54 PM · efl
tasn added a comment to T8151: RFC: Text interfaces design proposal.

Thanks @zmike! Rest of you: I'll answer tomorrow. :)

Mon, Aug 19, 1:51 PM · efl: api
tasn added a comment to D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.

I haven't looked at the actual code, but I do plan on making textblock2 work on grapheme clusters too, so this is inline with that change.
Though maybe I'd wait with this until TB2 is in, hopefully in a few weeks?

Mon, Aug 19, 1:50 PM · efl
lauromoura added a comment to D9564: csharp: MVVM parts support.

arc patch didn't retrieve a different commit message

Mon, Aug 19, 1:43 PM · efl
lauromoura updated the summary of D9564: csharp: MVVM parts support.
Mon, Aug 19, 1:42 PM · efl
felipealmeida added a comment to D9564: csharp: MVVM parts support.

arc patch didn't retrieve a different commit message

Mon, Aug 19, 1:40 PM · efl
cedric accepted D9564: csharp: MVVM parts support.

Update commit message

Mon, Aug 19, 1:37 PM · efl
zmike added a project to T8151: RFC: Text interfaces design proposal: efl: api.

This is a substantial project (and accompanying RFC), so I'm adding everyone who may have interest in reviewing your proposal.

Mon, Aug 19, 1:33 PM · efl: api
lauromoura updated the diff for D9564: csharp: MVVM parts support.

Update commit message

Mon, Aug 19, 1:31 PM · efl
lauromoura added a comment to D9627: elm: avoid clash in Collection.Focus_Manager.

:P

Mon, Aug 19, 1:19 PM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

The main Idea for efldocument and layoutmanager, is to break textblock into multiple objects, and expose functionality (for future purposes like extending functionality or optimizations)
EflDocument
By Document I mean something similar to :
https://doc.qt.io/qt-5/qtextdocument.html (or like https://developer.apple.com/documentation/appkit/nsdocument if we want to extend it more)
Where this class is responsible for store and parse formatted text, build text-nodes and format-nodes, cursor works on efldocument.

TextBlock internally contains efldocument, and text formatting and cursor functionality are processed by efldocument 
- Suppose user want edit text in background thread, then he does not need textblock, he can work directly on efldocument
- multiple textblock  object can share same efldocument
- efldocument will contains extended functionality to save and load files from Disk and Memory.
Mon, Aug 19, 1:08 PM · efl: api
cedric added a comment to T8151: RFC: Text interfaces design proposal.

I do not understand the reason and link between the markup factory and the textblock. Could you clarify it a bit? How does the factory knows on which textblock it is working? Why do we need a factory instead of having the call directly on the textblock (What are the benefit?)? Can we use one factory on multiple textblock at the same time?

Mon, Aug 19, 12:12 PM · efl: api
zmike requested review of D9634: tests/scroller: start unit tests for efl.ui.scroller.
Mon, Aug 19, 12:09 PM · efl: widgets
zmike added a child revision for D9633: tests/elm: add util functions for triggering wheel events: D9634: tests/scroller: start unit tests for efl.ui.scroller.
Mon, Aug 19, 12:09 PM · efl: widgets
zmike requested review of D9633: tests/elm: add util functions for triggering wheel events.
Mon, Aug 19, 12:09 PM · efl: widgets
zmike added a child revision for D9632: elm/hoversel: manually trigger group_calc for internal objects: D9633: tests/elm: add util functions for triggering wheel events.
Mon, Aug 19, 12:09 PM · efl
vtorri closed T8104: macros used to detect mmap functions as Resolved.
Mon, Aug 19, 11:36 AM · Restricted Project
cedric closed D9489: evas_textblock: markup text: improve handling invalide escape characters.
Mon, Aug 19, 11:33 AM · efl
cedric closed D9309: evas_common: parse color in rgb()/rgba() format.
Mon, Aug 19, 11:33 AM · efl
cedric closed D9376: evas_textblock: reduce _evas_textblock_changed calls with markup_text_append.
Mon, Aug 19, 11:33 AM · efl
cedric accepted D9489: evas_textblock: markup text: improve handling invalide escape characters.
Mon, Aug 19, 11:32 AM · efl
cedric accepted D9309: evas_common: parse color in rgb()/rgba() format.
Mon, Aug 19, 11:32 AM · efl
cedric accepted D9376: evas_textblock: reduce _evas_textblock_changed calls with markup_text_append.
Mon, Aug 19, 11:32 AM · efl
ali.alzyod added reviewers for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs: woohyun, bowonryu.
Mon, Aug 19, 11:19 AM · efl
tasn added a comment to T8151: RFC: Text interfaces design proposal.

Thanks for your comments, my reply is inline:

Mon, Aug 19, 10:57 AM · efl: api
zmike requested review of D9632: elm/hoversel: manually trigger group_calc for internal objects.
Mon, Aug 19, 10:40 AM · efl
zmike added a child revision for D9631: elm/hoversel: avoid calling api functions on null hoversel objects: D9632: elm/hoversel: manually trigger group_calc for internal objects.
Mon, Aug 19, 10:40 AM · efl
zmike added a revision to T8127: Text context menu in entry is broken: D9632: elm/hoversel: manually trigger group_calc for internal objects.
Mon, Aug 19, 10:40 AM · efl
zmike requested review of D9631: elm/hoversel: avoid calling api functions on null hoversel objects.
Mon, Aug 19, 10:40 AM · efl
bu5hm4n updated the diff for D9630: efl_ui_position_manager_common: generalize code.

this needs rebasing

Mon, Aug 19, 10:13 AM · efl
bu5hm4n requested review of D9630: efl_ui_position_manager_common: generalize code.
Mon, Aug 19, 10:10 AM · efl
bu5hm4n added a child revision for D9609: replace item_container benchmark: D9630: efl_ui_position_manager_common: generalize code.
Mon, Aug 19, 10:10 AM · efl
bu5hm4n added inline comments to D9629: introduce default item.
Mon, Aug 19, 10:10 AM · efl
cedric added inline comments to D9629: introduce default item.
Mon, Aug 19, 10:03 AM · efl
cedric requested changes to D9564: csharp: MVVM parts support.

Neat. Just please correct the commit message :

var error = factory.PartName().PartProperty().Bind(modelProperty);

Should be :

var error = factory.PartName().PropertyName().Bind(modelProperty);
Mon, Aug 19, 9:52 AM · efl
bu5hm4n requested review of D9629: introduce default item.
Mon, Aug 19, 9:52 AM · efl
cedric accepted D9619: efl_ui_widget: optimize size / position setting.
Mon, Aug 19, 9:50 AM · efl
cedric accepted D9618: efl_ui_focus_manager_calc: use a mempool instead of calloc / free.
Mon, Aug 19, 9:50 AM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

Hello @tasn, these are most comment I think of right now :

Mon, Aug 19, 9:49 AM · efl: api
cedric requested changes to D9629: introduce default item.
Mon, Aug 19, 9:49 AM · efl
cedric added a comment to T8142: ASAN detected heap use after free in eldbus test suite.

Most likely I won't have time to look at this this week before I go on holiday. I will try to, but if by Friday I haven't proposed a patch for this, consider it will be done in September.

Mon, Aug 19, 9:43 AM
cedric added a comment to D9547: edje/optimization: keep a style hash for fast retrival of styles.

Collision handling in hash is normal (passing same pointer will be just a collision case) so my guess is that it will just append the data and in hash_find() it will just find the first data and return.

Mon, Aug 19, 9:42 AM · efl
cedric added a reviewer for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs: tasn.
Mon, Aug 19, 9:39 AM · efl
cedric requested changes to D9557: efl_ui : update theme set only theme config is exist.

Oh, indeed, this is solving the same thing. Just with my change it will more a pain to merge it.

Mon, Aug 19, 9:30 AM · efl
cedric abandoned D9600: elementary: Efl.Ui.Layout_Factory should not set the theme if there isn't any defined..
Mon, Aug 19, 9:29 AM · efl
cedric planned changes to D9602: elementary: Efl.Ui.Layout_Factory should not set the theme if there isn't any defined..

Why is this 2 times in phab ?

Mon, Aug 19, 9:29 AM · efl
cedric updated subscribers of D9622: csharp: add SetKeyValue and GetKeyValue to EoWrapper.

Eo object have a full infrastructure to support this... except it is not defined in the .eo. I have been wondering for months why we did not implement them in the .eo. @lauromoura, @felipealmeida, @bu5hm4n, @segfaultxavi, @zmike : Do you see any good reason why our data association function are not proper eo function?

Mon, Aug 19, 9:26 AM · efl
bu5hm4n added a comment to D9582: efl_ui_default_item: remove item parts.

I might have forgotten the child revision of this :( sorry.

Mon, Aug 19, 9:26 AM · efl
bu5hm4n added a child revision for D9629: introduce default item: D9582: efl_ui_default_item: remove item parts.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n added a parent revision for D9582: efl_ui_default_item: remove item parts: D9629: introduce default item.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n removed a parent revision for D9629: introduce default item: D9582: efl_ui_default_item: remove item parts.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n removed a child revision for D9582: efl_ui_default_item: remove item parts: D9629: introduce default item.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n added a parent revision for D9629: introduce default item: D9582: efl_ui_default_item: remove item parts.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n added a child revision for D9582: efl_ui_default_item: remove item parts: D9629: introduce default item.
Mon, Aug 19, 9:25 AM · efl
bu5hm4n requested review of D9629: introduce default item.
Mon, Aug 19, 9:24 AM · efl
bu5hm4n added a revision to T8115: Provide group feature to PositionManager: D9629: introduce default item.
Mon, Aug 19, 9:24 AM · efl (efl-1.23), efl: mvvm, efl: widgets
bu5hm4n updated the diff for D9582: efl_ui_default_item: remove item parts.

rebase

Mon, Aug 19, 9:23 AM · efl
lauromoura closed D9627: elm: avoid clash in Collection.Focus_Manager.
Mon, Aug 19, 9:21 AM · efl
bu5hm4n requested review of D9624: eio: fix poll backend.

Then we are talking about a simple boolean flag that is either true of false. Where exactly is the problem ? It doesnt matter that we access it from both threads, if we do not catch it due to memory stuff, and it is actaully set to true, then we are simply go one more round, jump into the the ecore_thread call again, and then jump out, there is *no* difference.

Mon, Aug 19, 9:12 AM · efl
zmike requested changes to D9624: eio: fix poll backend.

It's not about the pointer being valid; this struct member is changed in the main thread so you can't access it in a different thread while the main thread is unblocked.

Mon, Aug 19, 9:08 AM · efl
zmike accepted D9619: efl_ui_widget: optimize size / position setting.
Mon, Aug 19, 9:05 AM · efl
tasn renamed T8151: RFC: Text interfaces design proposal from Text interfaces design proposal to RFC: Text interfaces design proposal.
Mon, Aug 19, 9:01 AM · efl: api
a.srour updated the task description for T8110: Text Manipulation.
Mon, Aug 19, 8:57 AM
bu5hm4n requested review of D9624: eio: fix poll backend.

It is safe, backend is not freed if there is a worker thread.

Mon, Aug 19, 8:57 AM · efl
tasn added a comment to T8151: RFC: Text interfaces design proposal.

As it says, this is my current proposal. I'll update it in the next few days with more interfaces, but this is the base textblock part.
I included my own personal notes so you can comment on them too. Please let me know your thoughts about the general design, specific functions or anything else you have in mind.

Mon, Aug 19, 8:57 AM · efl: api
zmike accepted D9618: efl_ui_focus_manager_calc: use a mempool instead of calloc / free.
Mon, Aug 19, 8:56 AM · efl
bu5hm4n requested review of D9616: efl_ui_focus_manager_calc: optimize item deletion.

Not for such a small thing. Its now in the commit message.

Mon, Aug 19, 8:56 AM · efl
zmike requested changes to D9624: eio: fix poll backend.
Mon, Aug 19, 8:55 AM · efl
bu5hm4n updated the summary of D9616: efl_ui_focus_manager_calc: optimize item deletion.
Mon, Aug 19, 8:55 AM · efl
tasn created T8151: RFC: Text interfaces design proposal.
Mon, Aug 19, 8:55 AM · efl: api
zmike requested changes to D9616: efl_ui_focus_manager_calc: optimize item deletion.

Then that should be a separate patch.

Mon, Aug 19, 8:54 AM · efl
bu5hm4n accepted D9627: elm: avoid clash in Collection.Focus_Manager.

just kidding ... i wanted you to have a red email in your mail folder :P

Mon, Aug 19, 8:52 AM · efl
bu5hm4n requested changes to D9627: elm: avoid clash in Collection.Focus_Manager.

THIS SHOULD BE FIXED ELSEWHERE!!!1

Mon, Aug 19, 8:52 AM · efl
bu5hm4n updated the diff for D9619: efl_ui_widget: optimize size / position setting.

remove stupid API calls - what is wrong with me?

Mon, Aug 19, 8:51 AM · efl
bu5hm4n updated the diff for D9618: efl_ui_focus_manager_calc: use a mempool instead of calloc / free.

use mempool

Mon, Aug 19, 8:50 AM · efl
ali.alzyod updated the test plan for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 8:25 AM · efl
segfaultxavi added a comment to D9612: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.
In D9612#178401, @zmike wrote:

This seems like a good patch; my only issue is that conceptually "orientation" and "direction" are different. Do we care about this?

Mon, Aug 19, 8:09 AM · efl
ali.alzyod updated the summary of D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:45 AM · efl
ali.alzyod updated the test plan for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:44 AM · efl
ali.alzyod requested review of D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:42 AM · efl
YOhoho added a comment to D9612: efl_ui_scrollbar_direction: replace with efl_ui_layout_orientation.

This idea is from T7924#137454. I also agree that orientation can be used for scrollbar axis.

Mon, Aug 19, 7:26 AM · efl
lauromoura requested review of D9627: elm: avoid clash in Collection.Focus_Manager.
Mon, Aug 19, 7:23 AM · efl
lauromoura requested review of D9626: pyolian: Update after event and binbuf keywords.
Mon, Aug 19, 7:20 AM · efl
bu5hm4n added reviewers for D9625: efl_io_model: remove custom counting logic: cedric, felipealmeida.
Mon, Aug 19, 7:20 AM · efl
bu5hm4n added a comment to D9624: eio: fix poll backend.

Sorry i found out more here. i could remove the thread checks again, checking for deletion here is enough, but maybe ... with the right flag :(

Mon, Aug 19, 7:18 AM · efl
bu5hm4n requested review of D9625: efl_io_model: remove custom counting logic.
Mon, Aug 19, 7:17 AM · efl
bu5hm4n added a child revision for D9624: eio: fix poll backend: D9625: efl_io_model: remove custom counting logic.
Mon, Aug 19, 7:17 AM · efl
bu5hm4n updated the diff for D9624: eio: fix poll backend.

update after recent finding outs

Mon, Aug 19, 7:17 AM · efl
bu5hm4n added inline comments to D9616: efl_ui_focus_manager_calc: optimize item deletion.
Mon, Aug 19, 6:57 AM · efl
zmike created T8150: slider event inconsistency.
Mon, Aug 19, 6:57 AM · efl: widgets
zmike closed D9542: make mman.h private.
Mon, Aug 19, 6:55 AM · efl
zmike accepted D9624: eio: fix poll backend.
Mon, Aug 19, 6:47 AM · efl
zmike added inline comments to D9616: efl_ui_focus_manager_calc: optimize item deletion.
Mon, Aug 19, 6:46 AM · efl
bu5hm4n requested review of D9616: efl_ui_focus_manager_calc: optimize item deletion.
Mon, Aug 19, 6:45 AM · efl
zmike requested changes to D9623: elm_slider: remove dependency with efl_ui_slider.

This patch causes a number of unit test failures for slider. Can you fix them?

Mon, Aug 19, 6:44 AM · efl
zmike requested changes to D9619: efl_ui_widget: optimize size / position setting.
Mon, Aug 19, 6:33 AM · efl
zmike requested changes to D9618: efl_ui_focus_manager_calc: use a mempool instead of calloc / free.

This should just use the eina_trash API instead of allocating a separate array.

Mon, Aug 19, 6:27 AM · efl
zmike accepted D9617: efl_ui_focus_manager_calc: safe if this is root in a flag.
Mon, Aug 19, 6:19 AM · efl