Page MenuHomePhabricator
Feed All Stories

Today

bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@Jaehyun_Cho i agree with Xavi here. I will do the changes tomorrow.

Mon, Jun 17, 11:07 AM · efl
segfaultxavi added a comment to D9096: evas: add support for stretchable zone..

Weird indentation suggests you mixed tabs and spaces... there's a special circle in hell for people of your kind.

Mon, Jun 17, 10:47 AM · efl
bu5hm4n added a comment to T7847: efl.ui.clickable.

efl.input.clickable sounds reasonable, same for the new event names. @woohyun, also okay for you ?

Mon, Jun 17, 10:23 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike accepted D9027: autotools: REMOVAL!.

I want this landed and I want it landed yesterday.

Mon, Jun 17, 10:22 AM · efl
zmike added a comment to T7866: efl.ui.nstate.

Okay, so can we remove the code for this entirely or what?

Mon, Jun 17, 10:13 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7847: efl.ui.clickable.

Hm I suppose it makes sense to move it, but then why not have it be efl.input.clickable to go with efl.input.interface?

Mon, Jun 17, 10:12 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7858: efl.text_markup.

Same as efl.text, seems okay?

Mon, Jun 17, 10:11 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7854: efl.text.

Seems good?

Mon, Jun 17, 10:10 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7964: Efl.Input.Key.

Sorry, I am not familiar with X11 so I do not see the difference between a key name and a raw key name... example?

Mon, Jun 17, 10:08 AM · efl (efl-1.23), efl: api
zmike added a comment to T7900: efl.pack_table.

Looking at this again, it seems like this is somewhat similar to how on gfx.entity objects we have position, size, and geometry. It's nice to be able to set/access both axes in one call, so I think we should leave it.

Mon, Jun 17, 10:06 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested changes to D9105: evas: add a test for loading Android 9patch file..

Shouldn't this also verify that there is nothing rendered outside the content area?

Mon, Jun 17, 10:05 AM · efl
zmike requested changes to D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..

What problem does this solve? Is there a test case?

Mon, Jun 17, 10:05 AM · efl
zmike requested changes to D9096: evas: add support for stretchable zone..
Mon, Jun 17, 10:01 AM · efl
zmike added inline comments to D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Mon, Jun 17, 10:00 AM · efl
zmike requested changes to D9097: evas: take stretch zone into account when content zone is requested..
Mon, Jun 17, 9:58 AM · efl
zmike added a comment to D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..

minor readability concerns but nothing that looks like a blocker

Mon, Jun 17, 9:56 AM · efl
zmike requested changes to D9098: evas: improve test to evaluate stretch zone effect on content zone..
Mon, Jun 17, 9:55 AM · efl
zmike accepted D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Mon, Jun 17, 9:51 AM · efl
zmike added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

https://i.gifer.com/26ME.gif

I've read all image-related eo files and I cannot find any property named "area". What did you have in mind, @zmike?

@cedric: Is content_zone a common name in 9-patch terminology, or is it something you came up with?

Mon, Jun 17, 9:46 AM · efl
segfaultxavi added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

I've read all image-related eo files and I cannot find any property named "area". What did you have in mind, @zmike?

Mon, Jun 17, 7:52 AM · efl
zmike requested changes to D9095: evas: add test for the new efl_gfx_image_content_zone_get API..

Please use ck_assert_int_eq for these checks so that errors are more verbose when they occur.

Mon, Jun 17, 7:24 AM · efl
zmike updated subscribers of D9093: evas: add an API to know where inside an object content can be layout over..

Shouldn't this be fill_area or something like that since we use that terminology in image API? cc @segfaultxavi for doc cop action

Mon, Jun 17, 7:22 AM · efl
zmike requested changes to D9092: eina: add an error for incorrect parameter common error..
Mon, Jun 17, 7:22 AM · efl
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi this depends on the parameter, when delete_on_transition_end is true, then the user does not need to care about the value of the promise [...] When the user passes false as argument, then the user *needs* to handle the value of the promise.

OK, understood. I am OK with using an Eina_Future.

Mon, Jun 17, 7:15 AM · efl
vtorri updated the summary of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Mon, Jun 17, 5:47 AM · efl
zmike added a comment to D9091: tests: add functional unit tests for radio widgets.

I thought about that, but I'm not entirely sure how to approach it. Will need to debug the existing issue to see what's going on.

Mon, Jun 17, 5:43 AM · efl
segfaultxavi added a comment to D9091: tests: add functional unit tests for radio widgets.

This will need to adapt after D9058 lands.
Also, it could check that there's only one selected button in the group. That's an issue I am facing now.

Mon, Jun 17, 5:31 AM · efl
segfaultxavi added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

This still does not work for me (buttons are not mutually exclusive), I am currently debugging. I would appreciate if anybody else tested this patch and told me if it works for him.

Mon, Jun 17, 4:52 AM · efl
SanghyeonLee added a comment to T7905: efl.ui.item.

in MVVM case, as cedric pointed,
child of Efl.Model will be the invariable value for specific item,
but in view object, numeric index can be accessible.

Mon, Jun 17, 3:52 AM · efl: api, efl (efl-1.23), efl: language bindings
woohyun added a comment to T7866: efl.ui.nstate.

We don't need this one. There has been no requests for this widget.

Mon, Jun 17, 2:56 AM · efl: api, efl (efl-1.23), efl: language bindings
ApB added a comment to T8018: Notify on volume change does nothing.

Added the low option and still no go. Maybe it affects wayland only??

Mon, Jun 17, 1:20 AM · Restricted Project, enlightenment-git
raster closed T8018: Notify on volume change does nothing as Invalid.

yeah. what @jf_simon said - i get them as i have enabled all 3 levels of notification... :) so... works for me. :) this is perhaps something to address in future to make it possible for one module to modify config of another... or roll notification config and functionality into core E and out of a module? yes - small usability issue. I might actually say that the mixer should show its OWN popup when changing volume so u see the slider... and not use system notifications. but this is a polish/prettiness thing.

Mon, Jun 17, 1:14 AM · Restricted Project, enlightenment-git
jf_simon added a comment to T8018: Notify on volume change does nothing.

If i render correctly, you have to change the noification Level in the notification settings to get the popup.

Mon, Jun 17, 12:02 AM · Restricted Project, enlightenment-git

Yesterday

tomas131315 added a comment to T5799: Telegram desktop graphics glitch.

This is still relevant.
Telegram 1.7.7
E 0.22.3

Sun, Jun 16, 11:57 PM · enlightenment-git
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

@Jaehyun_Cho Can you answer if you are happy with pop / push ?

Sun, Jun 16, 11:17 PM · efl
vtorri added a comment to D9027: autotools: REMOVAL!.

i wasn't aware of this diff :-)

Sun, Jun 16, 10:44 PM · efl
bu5hm4n removed a project from D9027: autotools: REMOVAL!: DO NOT MERGE.

@stefan_schmidt @vtorri @zmike, sooo what is going on now. It seems like the mailing thread went silent. This means I am going to apply this tomorrow if no-one applied it until there or complained ?

Sun, Jun 16, 9:24 PM · efl
vtorri requested review of D9106: Ecore net dialer Windows example: fix undeclared symbols.
Sun, Jun 16, 9:15 PM · efl
ApB created T8018: Notify on volume change does nothing.
Sun, Jun 16, 8:05 AM · Restricted Project, enlightenment-git

Sat, Jun 15

bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi this depends on the parameter, when delete_on_transition_end is true, then the user does not need to care about the value of the promise, only the point of time. When the user passes false as argument, then the user *needs* to handle the value of the promise. However, you have to note here, that when the user does not *want* to take care of that returned value, the widget that got unpackt will just float arround on the UI, which is probebly not what a user wants ... :)

Sat, Jun 15, 8:05 AM · efl
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@bu5hm4n I'm not arguing against using a Promise, I'm just trying to see if there are alternatives :)

Sat, Jun 15, 6:46 AM · efl
bu5hm4n added a comment to T7905: efl.ui.item.

@SanghyeonLee Can you verify that all usages of the Efl.Ui.Item class do only require a numeric index as parent, never something like an object ?

Sat, Jun 15, 3:18 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7847: efl.ui.clickable.

It was also brought up that it is confusing to have this in the ui namespace, we should probebly move this to the gfx namespace ...

Sat, Jun 15, 3:16 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed parent tasks for T7866: efl.ui.nstate: T7510: evaluate stabilization potential of efl.ui classes and dependencies, T7865: efl.ui.check.
Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a subtask for T7865: efl.ui.check: T7866: efl.ui.nstate.
Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a subtask for T7510: evaluate stabilization potential of efl.ui classes and dependencies: T7866: efl.ui.nstate.
Sat, Jun 15, 3:15 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7866: efl.ui.nstate.

Undependend from this, we do not need this widget, lets remove it from the list.

Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi in all honesty, not returning the promise is not an option here, if we require that in future we need a new API, which basically does the same. It is perfectly possible right now to do that, bindings do lack this feature, but they should add that.

Sat, Jun 15, 3:09 AM · efl
bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@Jaehyun_Cho Can you answer if you are happy with pop / push ?

Sat, Jun 15, 2:59 AM · efl
bu5hm4n added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

@cedric @segfaultxavi @Jaehyun_Cho so my actions items here are:

Sat, Jun 15, 2:57 AM · efl
bu5hm4n added a comment to D9060: efl_ui_radio: cleanup API.

@cedric @segfaultxavi @Jaehyun_Cho so my actions items here are:

Sat, Jun 15, 2:56 AM · efl

Fri, Jun 14

bu5hm4n planned changes to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

@segfaultxavi i rebased now the whole thing and tested again, this seems to work for me.

Fri, Jun 14, 5:45 PM · efl
bu5hm4n updated the diff for D9060: efl_ui_radio: cleanup API.

remove asdf

Fri, Jun 14, 5:42 PM · efl
bu5hm4n added a comment to D9060: efl_ui_radio: cleanup API.
In D9060#167031, @zmike wrote:

One of the main points of the efl_add extended construction mechanics was to allow things like this, where you could set all the properties during construction. The only thing that perhaps was not clearly defined from here would be e.g., whether packing the widget into a box during construction is allowed, but probably we did want that functionality too so that every function can be called during construction.

Fri, Jun 14, 5:39 PM · efl
bu5hm4n updated the diff for D9060: efl_ui_radio: cleanup API.

rebase

Fri, Jun 14, 5:33 PM · efl
bu5hm4n updated the diff for D9059: efl_ui_radio: refactor for usage of efl_ui_check_selected.

rebase

Fri, Jun 14, 5:33 PM · efl
bu5hm4n updated the diff for D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

fix bug, remove printf

Fri, Jun 14, 5:33 PM · efl
cedric requested review of D9105: evas: add a test for loading Android 9patch file..
Fri, Jun 14, 5:17 PM · efl
cedric added a child revision for D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas.: D9105: evas: add a test for loading Android 9patch file..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:14 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:14 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:13 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:13 PM · efl
cedric requested review of D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:13 PM · efl
cedric added a child revision for D9103: evas: add support for .9.png file to PNG loader.: D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:13 PM · efl
cedric requested review of D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:13 PM · efl
cedric added a child revision for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object.: D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:10 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:10 PM · efl
cedric requested review of D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:09 PM · efl
cedric added a child revision for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image.: D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:08 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:06 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:06 PM · efl
cedric requested review of D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:06 PM · efl
cedric added a child revision for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader.: D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:05 PM · efl