Page MenuHomePhabricator

Showstopper Issues (15)

Today

cedric added a comment to D8661: ecore: properly handle CHILD_ADDED and CHILD_REMOVED from source for Efl.CompositeModel.

I have this patch and the previous one properly updated, but I can't get phab to update it without failing in the middle. Once the first patches of the series are accepted, I can land all of it.

Thu, Apr 25, 4:55 PM · efl
cedric updated the diff for D8660: ecore: use new infrastructure for Efl.CompositeModel to only have one Model object represent its data at any point in time..

Rebase.

Thu, Apr 25, 4:51 PM · efl
cedric updated the diff for D8659: ecore: protect efl_model_properties_get from accesing NULL pointer when Model parent is not a Efl.BooleanModel..

Rebase.

Thu, Apr 25, 4:51 PM · efl
cedric updated the diff for D8658: ecore: fix efl_model_property_ready_get to actually return the right future when the data is not ready..

Rebase.

Thu, Apr 25, 4:51 PM · efl
cedric updated the diff for D8657: ecore: allow multiple Efl.ViewModel of the same source thanks to new infrastructure..

Phab retry.

Thu, Apr 25, 4:51 PM · efl
cedric updated the diff for D8656: ecore: add infrastructure to create children Model once and avoid duplicated view of the same data..

Phab retry.

Thu, Apr 25, 4:50 PM · efl
cedric updated the diff for D8655: eina: allow copy of EINA_VALUE_EMPTY type..

Phab retry.

Thu, Apr 25, 4:50 PM · efl
cedric updated the diff for D8657: ecore: allow multiple Efl.ViewModel of the same source thanks to new infrastructure..

Rebase.

Thu, Apr 25, 4:49 PM · efl
cedric updated the diff for D8656: ecore: add infrastructure to create children Model once and avoid duplicated view of the same data..

Rebase and rename.

Thu, Apr 25, 4:49 PM · efl
cedric updated the diff for D8655: eina: allow copy of EINA_VALUE_EMPTY type..

Rebase and rename.

Thu, Apr 25, 4:49 PM · efl
cedric added a comment to D8566: ecore: make sure that ecore stay initialized during the full test..
In D8566#158289, @zmike wrote:

If a test needs to call ecore_shutdown then it should also call ecore_init after to restore the global state.

Rejected for being wrong and also for not having a commit log.

Thu, Apr 25, 4:22 PM · efl
cedric added inline comments to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..
Thu, Apr 25, 4:13 PM · efl
cedric updated the diff for D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..

Actually not.

Thu, Apr 25, 4:12 PM · efl
cedric updated the diff for D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..

Rebase and fixup iterator.

Thu, Apr 25, 4:10 PM · efl
billiob added a comment to T7828: Terminal created by splitting does not respond to keystrokes.

Last questions. Do you have Focus split under the mouse?
In that case, is the mouse cursor over the new split or not?

Thu, Apr 25, 2:34 PM · Terminology
billiob added a comment to T7828: Terminal created by splitting does not respond to keystrokes.

and which version of EFL are you using?

Thu, Apr 25, 2:32 PM · Terminology
billiob added a comment to T7828: Terminal created by splitting does not respond to keystrokes.

How do you split? with the key bindings or through the UI?

Thu, Apr 25, 2:32 PM · Terminology
cedric added a comment to T7829: efl_ui_list internal box usage.

Which parent are we talking about ?

Thu, Apr 25, 2:06 PM
bu5hm4n triaged T7829: efl_ui_list internal box usage as High priority.
Thu, Apr 25, 12:55 PM
bu5hm4n added a comment to D8699: efl_pack: split algin and padding property.

I would be really carefull with item. things in here are *not* items.

Thu, Apr 25, 11:46 AM · efl
zmike added a comment to T7786: Support ecore_win32.

This seems good, once the changes are submitted as a patch with authorship info then it can be merged.

Thu, Apr 25, 9:55 AM · Restricted Project, efl: meson
cedric planned changes to D8656: ecore: add infrastructure to create children Model once and avoid duplicated view of the same data..

Sure.

Thu, Apr 25, 8:57 AM · efl
cedric planned changes to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..
Thu, Apr 25, 8:57 AM · efl
segfaultxavi added a comment to D8699: efl_pack: split algin and padding property.

I like that, but how about item instead of child? In the docs we talk about items inside the containers.
So... interface Efl.Ui.Arrangement with methods item_align and item_padding.
This would generate efl_ui_arrangement_item_align_set() and Efl.Ui.Table.ItemAlign.

Thu, Apr 25, 8:35 AM · efl
vitor.sousa planned changes to D8678: eo: add events to track the ownership status of an Eo object.

Still needing a more in-depth analysis about the inpact of this patch in 'efl_part'.
Still working in some optimization aspects.

Thu, Apr 25, 8:31 AM · efl
vitor.sousa updated the diff for D8678: eo: add events to track the ownership status of an Eo object.

Avoid calling OWNERSHIP_UNIQUE while invalidating
Add a boolean flag for performance optmization reasons

Thu, Apr 25, 8:28 AM · efl
segfaultxavi accepted D8713: efl_ui_spec: lets add a README.
Thu, Apr 25, 8:23 AM · efl
vitor.sousa planned changes to D8678: eo: add events to track the ownership status of an Eo object.
Thu, Apr 25, 8:23 AM · efl
cwilliams updated the task description for T7828: Terminal created by splitting does not respond to keystrokes.
Thu, Apr 25, 7:46 AM · Terminology
cwilliams created T7828: Terminal created by splitting does not respond to keystrokes.
Thu, Apr 25, 7:43 AM · Terminology
shilpasingh updated subscribers of D8686: elm_scroller: make loop_set/get as generic API.
Thu, Apr 25, 5:59 AM · efl
shilpasingh added a comment to D8686: elm_scroller: make loop_set/get as generic API.

I am wondering a bit about this revision. This is a legacy API, shouldn't something like this be used in the new scroller class ? Otherwise this feature will be gone and or unable to be used on new widgets.

Additionally, the definition of the actual header API is missing.

Thu, Apr 25, 5:57 AM · efl
Jaehyun_Cho closed D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:24 AM · efl
Jaehyun_Cho accepted D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:23 AM · efl
CHAN updated the summary of D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:19 AM · efl
CHAN added reviewers for D8714: elm_theme: Check the ref count to delete or unref.: Jaehyun_Cho, woohyun, Hermet.
Thu, Apr 25, 5:18 AM · efl
CHAN requested review of D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:17 AM · efl
bu5hm4n added a comment to D8699: efl_pack: split algin and padding property.

For me this could also imply that those properties do change the way the widget, where you set them on, gets placed. The attribute "child" is missing somehow ...

Thu, Apr 25, 5:06 AM · efl
ali.alzyod closed D8610: evas: change way of searching for Escape strings/values in textblock.
Thu, Apr 25, 5:04 AM · efl
bu5hm4n added a comment to D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

Can you adjust the commit title here to say something like:

Thu, Apr 25, 5:02 AM · efl