Page MenuHomePhabricator

Showstopper Issues (15)

Today

netstar updated the summary of D7299: efl: fix misspelt focused in API and documents..
Sat, Nov 17, 6:30 AM · efl
netstar retitled D7299: efl: fix misspelt focused in API and documents. from elm_code: fix spelling of object members. to efl: fix misspelt focused in API and documents..
Sat, Nov 17, 6:29 AM · efl
netstar updated the diff for D7299: efl: fix misspelt focused in API and documents..

Add other misspelt occurrences outside elm_code

Sat, Nov 17, 6:29 AM · efl
ProhtMeyhet added a comment to D7299: efl: fix misspelt focused in API and documents..

there are some comments left with the same spelling error:

Sat, Nov 17, 6:04 AM · efl
netstar requested review of D7299: efl: fix misspelt focused in API and documents..
Sat, Nov 17, 5:08 AM · efl
netstar closed D7298: elm_code: Allow widget to be focused..
Sat, Nov 17, 5:05 AM · efl
raster accepted D7298: elm_code: Allow widget to be focused..

sounds right...

Sat, Nov 17, 5:04 AM · efl
netstar requested review of D7298: elm_code: Allow widget to be focused..
Sat, Nov 17, 4:59 AM · efl
netstar abandoned D7297: Revert "Elm_Code: check pointer nullity before using it".
Sat, Nov 17, 4:53 AM · efl
netstar requested review of D7297: Revert "Elm_Code: check pointer nullity before using it".
Sat, Nov 17, 4:51 AM · efl
raster added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

indeed startup time is a whole kettle of fish on its own - good you looked. what was the profile before you changes though?

Sat, Nov 17, 2:59 AM · Restricted Project, Restricted Project, efl: data types

Yesterday

woohyun added a comment to T7358: EO: Support ecore_event APIs.

@cedric welcome back :)
@Jaehyun_Cho

Fri, Nov 16, 5:25 PM · efl, Restricted Project
cedric added a comment to T7358: EO: Support ecore_event APIs.

@Jaehyun_Cho I think this event should either be on the window or on the application object. I don't think we want any of it to go through Ecore_Event.

Fri, Nov 16, 2:35 PM · efl, Restricted Project
vtorri edited the content of Windows.
Fri, Nov 16, 12:51 PM
cedric added a comment to T5365: Use efl.part for efl.ui.model.connect.

If we want that, should I take care of it ?

Fri, Nov 16, 11:51 AM · efl: widgets, Restricted Project
cedric triaged T7473: Add a create event on Efl.Ui.Factory as High priority.
Fri, Nov 16, 11:41 AM · Restricted Project, efl: data types, Restricted Project
cedric triaged T7472: Asynchronous create function in Efl.Ui.Factory as High priority.
Fri, Nov 16, 11:39 AM · efl: data types, Restricted Project
cedric triaged T7471: Add an efl.model.property_ready_get and efl.model.properties_ready_get. as TODO priority.
Fri, Nov 16, 11:36 AM · Restricted Project, efl: data types, Restricted Project
cedric added a subtask for T5333: Cleanup View interface aka finish MVVM: T7470: [MVVM] Create a ViewModel helper class.
Fri, Nov 16, 11:33 AM · efl: data types, Restricted Project
cedric added a parent task for T7470: [MVVM] Create a ViewModel helper class: T5333: Cleanup View interface aka finish MVVM.
Fri, Nov 16, 11:33 AM
cedric created T7470: [MVVM] Create a ViewModel helper class.
Fri, Nov 16, 11:27 AM
cedric added a comment to T7382: [MVVM] Efl.Ui.View_List Homogenous Support.

What is the status of this task ?

Fri, Nov 16, 11:24 AM
cedric added a comment to T7378: [MVVM] Model Composite Features.

What is efl.range ? I can only find efl.ui.range, and I don't think this is what you are talking about.

Fri, Nov 16, 11:24 AM
cedric added a comment to T7377: [MVVM] Model Insertion Features.

I agree with @SanghyeonLee no silent work around solution for users. This create trouble. What is the status of this task ?

Fri, Nov 16, 11:11 AM
cedric added a comment to T7379: [MVVM] Support disabled composite model.

Is this an enable/disable model ? If so, it can be implemented trivially by inheriting from the Boolean model. The main question being what kind of API do you want on top of it. Do we want a top level function that allow for example to define the state of an item to disable/enable without going through fetching the child object and setting its property ? Any other idea of what such a Model should provide ?

Fri, Nov 16, 11:08 AM
cedric added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

Yes, for non homogeneous case, we should have a callback that only update small portion at a time and doesn't over consume the main loop time. We can push an estimate of the scroll size by using an average of the currently calculated item. That is I think our best strategy there.

Fri, Nov 16, 11:06 AM
cedric added a comment to T7404: [MVVM] Factory text property handles.

There is no future to get property. You need to watch for an event if you want to manually get notified of value being changed, but you can always get a property synchronously by doing a property.get. In general, most user should not have to care about that as they just need to do an .connect and things would be taken care of for them by the widget.

Fri, Nov 16, 11:04 AM
cedric added a comment to T7376: [MVVM] Model Selection Support.

If I remember correctly, I think I was thinking of using a simple composite boolean for the multi selection case. As the Efl.Model_Composite_Selection inherit from it, if there are helper and API user-convenience function you are thinking of, it would indeed make sense to add the non exclusive mode to Composite_Selection and provide the helper there. Do you have a list of helper you are thinking of ?

Fri, Nov 16, 10:59 AM
cedric added a comment to T7405: [MVVM] Multistyle Factory.

Btw in the above example, I would do a ModelConnect on the multi factory for the property "icon" to be connected with the imgFac and due a simple connect("label", "another-property-in-the-model");

Fri, Nov 16, 10:54 AM
cedric added a comment to T7405: [MVVM] Multistyle Factory.

I don't understand in the example why you would have to write any code in a multi style factory at all. The idea would be to connect a property on the factory that would be used to decide which subfactory is called to instantiate that item. For example :

Fri, Nov 16, 10:52 AM
cedric added a comment to T7441: [MVVM] Changes to Efl Data Model.

Also observable are full size Eo object, this will result in a very heavy implementation in term of memory use.

Fri, Nov 16, 10:42 AM
cedric added a subtask for T5333: Cleanup View interface aka finish MVVM: T7469: Find a better name for Efl.Factory.model_connect.
Fri, Nov 16, 10:40 AM · efl: data types, Restricted Project
cedric added a parent task for T7469: Find a better name for Efl.Factory.model_connect: T5333: Cleanup View interface aka finish MVVM.
Fri, Nov 16, 10:40 AM · Restricted Project, efl
cedric triaged T7469: Find a better name for Efl.Factory.model_connect as TODO priority.
Fri, Nov 16, 10:35 AM · Restricted Project, efl
ManMower added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

I've been looking at eet's contributions, as it was doing a lot of extra work at startup. Now that I've landed some eet fixes, here's the top few results I get from the perf report for:
ELM_FIRST_FRAME=E ELM_ENGINE=buffer perf record -i elementary_test

Fri, Nov 16, 10:29 AM · Restricted Project, Restricted Project, efl: data types
cedric closed D7290: meson: fix VNC server build to not override the last module..
Fri, Nov 16, 10:20 AM · efl
ManMower closed D7283: eet: Remove unused code.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7282: eet: Remove pointer deduplication.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7281: eet: Demystify some typecasts.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7280: eet: Stop freeing allocated memory in descriptor_decode.
Fri, Nov 16, 10:18 AM · efl