Page MenuHomePhabricator

Showstopper Issues (15)

Yesterday

ali.alzyod updated the summary of D9309: evas_common: parse color in rgb() format.
Tue, Jul 16, 11:32 PM · efl
ali.alzyod added a comment to D9280: evas_textblock: content fit feature.

@cedric @raster
Are there way to pass int array in EDC file as a value for parameter.
Currently I am using string in EDC file (for example "1 2 3 4") then parse it in c to int array

Tue, Jul 16, 11:00 PM · efl
ali.alzyod added reviewers for D9280: evas_textblock: content fit feature: cedric, raster.
Tue, Jul 16, 10:58 PM · efl
ali.alzyod changed the visibility for D9280: evas_textblock: content fit feature.
Tue, Jul 16, 10:56 PM · efl
ali.alzyod added reviewers for D9280: evas_textblock: content fit feature: woohyun, bowonryu.
Tue, Jul 16, 10:53 PM · efl
jsuya requested review of D9338: vg_common_svg: Gradient stop color use premultiplied color..
Tue, Jul 16, 10:04 PM · efl
cedric requested review of D9337: ecore_evas_convert: add the ability to split large jpeg file..
Tue, Jul 16, 8:17 PM · efl
segfaultxavi added a comment to D9333: efl_ui_widget: add safety checks to verify parents aren't being added as children.
WARNING: ATTEMPTING TO SET CHILD OF PARENT AS PARENT OF ITS OWN PARENT.
Tue, Jul 16, 1:15 PM · efl
zmike requested review of D9336: evas/box: avoid triggering smart_move callback.
Tue, Jul 16, 12:37 PM · efl
zmike requested review of D9335: elm/scrollable: avoid unnecessary edje recalcs.
Tue, Jul 16, 12:37 PM · efl
zmike requested review of D9334: elm_test: add comparable "simple" scroller tests.
Tue, Jul 16, 10:43 AM · efl
zmike requested review of D9333: efl_ui_widget: add safety checks to verify parents aren't being added as children.
Tue, Jul 16, 10:43 AM · efl
zmike closed D9331: tests/elm: add test for elm_bubble "clicked" smart callback.
Tue, Jul 16, 10:39 AM · efl
zmike closed D9330: tests/elm: break out event callback function.
Tue, Jul 16, 10:39 AM · efl
bu5hm4n accepted D9330: tests/elm: break out event callback function.
Tue, Jul 16, 10:33 AM · efl
zmike updated the diff for D9331: tests/elm: add test for elm_bubble "clicked" smart callback.

rebase

Tue, Jul 16, 10:32 AM · efl
zmike updated the diff for D9330: tests/elm: break out event callback function.

rename function for increased clarity

Tue, Jul 16, 10:32 AM · efl
zmike added a comment to D9330: tests/elm: break out event callback function.

Alright, I have no clue what you're talking about here but I respect that you want to have increased clarity in the codebase. This is always something that we should strive for.

Tue, Jul 16, 10:32 AM · efl
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

the point is not to access the pointer. the point is to check the pointer for correctness in the testcase.

Tue, Jul 16, 9:36 AM · efl
zmike added a comment to D9330: tests/elm: break out event callback function.

You could also do:

void
event_callback_once(void *data, Evas_Object *obj EINA_UNUSED, void *event_info EINA_UNUSED)
{
   void **called = data;

   ck_assert_ptr_eq(**called, NULL);
  *called = event_info;
}

Which would have basically the same effect, but a different side effect. To differentiate that such a callback could also exist, please add "int" into the name.

Tue, Jul 16, 9:12 AM · efl
devilhorns triaged T8053: elementary crash when running under wayland as Normal priority.
Tue, Jul 16, 9:06 AM · efl: display system, Restricted Project
devilhorns added a comment to T8053: elementary crash when running under wayland.

I suspect this is due to a change in the xdg_wm protocol. I will look into this tomorrow

Tue, Jul 16, 9:06 AM · efl: display system, Restricted Project
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

You could also do:

Tue, Jul 16, 8:36 AM · efl
zmike added a comment to D9330: tests/elm: break out event callback function.

You can basically do the same with a void* (Which is would like to add after that, and refactor the tests of the last few weeks)

Tue, Jul 16, 8:34 AM · efl
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

once is more expressing that it is ensuring that the callback is called once, and puts that into a int flag. You can basically do the same with a void* (Which is would like to add after that, and refactor the tests of the last few weeks)

Tue, Jul 16, 8:33 AM · efl
zmike added a comment to D9330: tests/elm: break out event callback function.

That's why the name is once.

Tue, Jul 16, 8:29 AM · efl
bu5hm4n created T8053: elementary crash when running under wayland.
Tue, Jul 16, 8:24 AM · efl: display system, Restricted Project
bu5hm4n accepted D9331: tests/elm: add test for elm_bubble "clicked" smart callback.
Tue, Jul 16, 8:18 AM · efl
segfaultxavi closed D9329: efl_ui_slider: fix focus interaction.
Tue, Jul 16, 7:40 AM · efl
segfaultxavi closed D9328: efl_ui_text: fix focus breaking.
Tue, Jul 16, 7:39 AM · efl
segfaultxavi closed T4834: Efl.Ui.Slider step property is weird as Resolved by committing rEFL1bae8ec521f9: efl_ui_slider: change the semantical meaning of step property.
Tue, Jul 16, 7:39 AM · efl: api, efl: widgets
segfaultxavi closed D9327: efl_ui_slider: change the semantical meaning of step property.
Tue, Jul 16, 7:39 AM · efl
segfaultxavi accepted D9329: efl_ui_slider: fix focus interaction.

Well, this would be a design decision, but I also think this makes more sense.

Tue, Jul 16, 7:34 AM · efl
segfaultxavi accepted D9328: efl_ui_text: fix focus breaking.

Makes lots of sense.

Tue, Jul 16, 7:32 AM · efl
ali.alzyod updated the test plan for D9280: evas_textblock: content fit feature.
Tue, Jul 16, 7:23 AM · efl
ali.alzyod updated the summary of D9280: evas_textblock: content fit feature.
Tue, Jul 16, 7:21 AM · efl
segfaultxavi added a comment to T8025: efl.ui.radio_group_impl.

Regarding the renames:

  1. It is agreed then: Efl.Ui.Radio --> Efl.Ui.Radio_Button.
Tue, Jul 16, 7:21 AM · efl (efl-1.23), efl: language bindings
ali.alzyod updated the summary of D9280: evas_textblock: content fit feature.
Tue, Jul 16, 7:14 AM · efl
segfaultxavi added a comment to T7847: efl.ui.clickable.

We already have an Efl.Ui.Property_Bind. This should be something like Efl.Ui.Click_Event_Bind.
Or, we can try to be more generic and call it Efl.Ui.Event_Bind, so later we can add other "event binders" if we find any. If we do so, the methods have to be renamed to bind_clickable_to_theme and bind_clickable_to_object.

Tue, Jul 16, 7:10 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n requested changes to D9330: tests/elm: break out event callback function.

Looks good otherwise

Tue, Jul 16, 6:59 AM · efl