Showstopper Issues (15)

Today

zmike planned changes to D6594: build: avoid using platform-specific object file naming in eolian tests.

This still fails in some places...

Mon, Jul 16, 6:34 AM · Restricted Project
jsuya abandoned D6550: C-Gen : Support for part name changed to alias.
Mon, Jul 16, 6:33 AM
raster added a comment to T7144: Eina_Bool type.

until efl 2.0 ... can't happen. abi problems like @herdsman says. for then - sure. until then - can't.

Mon, Jul 16, 6:14 AM · Restricted Project, efl
herdsman added a comment to T7144: Eina_Bool type.

Okay, I feel less concerned now. I assumed the treatment is the same as it was to a signed char.
However, upon further testing, the bitfield bool value was converted from the stored 1 to 1 (or: true), as opposed to -1, (which I expected it to be).
Looks like C99 adds an implicit conversion for bool types.

Mon, Jul 16, 6:04 AM · Restricted Project, efl
herdsman added a comment to T7144: Eina_Bool type.

Fwiw, please consider that for bitfields of one bit (e.g. bool changed: 1;) the values will be 0 and -1 due to bool being an signed char. If we ensure consistency on usage it shouldn't be an issue.

Mon, Jul 16, 4:38 AM · Restricted Project, efl
netstar added a comment to T7144: Eina_Bool type.

completely agree on this one.

Mon, Jul 16, 4:05 AM · Restricted Project, efl
Jaehyun_Cho edited the content of Maintainers Reviewers.
Mon, Jul 16, 3:58 AM · efl
CHAN closed T5358: Refactoring multi button entry as Resolved.

efl_ui_tags has been created.

Mon, Jul 16, 3:53 AM · efl: widgets, Restricted Project
CHAN closed T5358: Refactoring multi button entry, a subtask of T5363: Cleanup elm_widget.eo, as Resolved.
Mon, Jul 16, 3:53 AM · efl: widgets, Restricted Project
CHAN closed T5358: Refactoring multi button entry, a subtask of T6360: EO: Item and Item_List API's, as Resolved.
Mon, Jul 16, 3:53 AM · efl: widgets, Restricted Project
CHAN closed T6540: New Date and Time classes and their APIs as Resolved.
Mon, Jul 16, 3:52 AM
CHAN added a comment to D6577: elm: bring back elm/uiclock.

@segfaultxavi Thank you for ur commit.

Mon, Jul 16, 3:44 AM · efl
netstar edited the content of Maintainers Reviewers.
Mon, Jul 16, 3:11 AM · efl
zmike closed D6592: Eina binbuf: add explicit null-check before magic-check.
Mon, Jul 16, 3:10 AM · efl
zmike added a commit to T6798: focus(spinner): text button is focused on spinner even if it is not editable. : rEFLa61786bd0e3a: elm_spinner: Do not focus to text button on non-editable mode.
Mon, Jul 16, 3:10 AM · Restricted Project
zmike closed D6581: elm_spinner: Do not focus to text button on non-editable mode.
Mon, Jul 16, 3:10 AM · efl
zmike added a comment to T7097: something broken with gl when lots of windows open with x11 engine.

Unsure whether this is driver bug (on Intel, so probably not), but when opening a lot of glview windows there's definitely something broken. Only tested with gles build, so could be local to that codepath.

Mon, Jul 16, 3:02 AM · efl (efl-1.21), efl: display system, efl: rendering
zmike added a comment to D6553: eo: Fix efl_new without initializing parameters.

I think until we get Windows builds running on CI (a priority during the 1.22 cycle) then ultimately any work we do will have to ignore untested platforms. It may be good to start a tracking ticket for things like this so that the items can start to be resolved once we are regularly building the tree?

Mon, Jul 16, 2:59 AM · efl
zmike accepted D6592: Eina binbuf: add explicit null-check before magic-check.

Okay great, thanks for doing the extra checking!

Mon, Jul 16, 2:57 AM · efl
akanad closed D6567: scroller: replace repeating code blocks by a function.

I guess D6585 is more proper to apply.

Mon, Jul 16, 2:49 AM · DO NOT MERGE, efl
raster triaged T7153: DND broken now on non elm objects. as High priority.
Mon, Jul 16, 2:40 AM · efl
raster closed T5678: image rendering fails with no feedback and then never renders as Invalid.

this has been lurking for a while and me, jpeg and cedric all said basically "it's invalid". pixel get cb is not called every render if the obj is visible. it's called evas thinks the obj needs rendering. it may not actually be rendered or be visible to the user/output of the canvas, but evas thinks it needs it.. then it'll call it, but it was never a "call always at every render if this obj is visible logically at all". as jpeg said a render pre/post could do this and iterate over all the obj's that need this but it's not what the pixel get cb is for. so finally doing what jpeg said.. closing as invalid. :)

Mon, Jul 16, 2:09 AM · efl (efl-1.21), efl: rendering
raster added a comment to T7113: DND broken and crashes elm_test.

also see a475b189618f99388e4b37e0f8be823d87102f62

Mon, Jul 16, 1:18 AM · efl: widgets, Restricted Project, efl (efl-1.21)
raster added a comment to T7097: something broken with gl when lots of windows open with x11 engine.

I can't reproduce it. opened 44 elementary_tests.... everything rendering ok for me... :/ amd radeon vega64 with mesa open drivers here and opengl (not gles) compiled for efl... :(

Mon, Jul 16, 1:13 AM · efl (efl-1.21), efl: display system, efl: rendering
herdsman added a comment to D6553: eo: Fix efl_new without initializing parameters.

Never said it was okay.
Anyway, if you believe this need to be fixed at some point, please open a ticket.
We can decide on the priority for win32 builds.

Mon, Jul 16, 1:02 AM · efl
herdsman added a comment to T7113: DND broken and crashes elm_test.

Got raster here to shoot down the bad bugs :)

Mon, Jul 16, 1:01 AM · efl: widgets, Restricted Project, efl (efl-1.21)
raster closed T7113: DND broken and crashes elm_test as Resolved by committing rEFL5e58e58d60e4: efl selection manager + elm dnd test fix with bad string handling.
Mon, Jul 16, 12:39 AM · efl: widgets, Restricted Project, efl (efl-1.21)

Yesterday

CHAN accepted D6581: elm_spinner: Do not focus to text button on non-editable mode.

Looks good.

Sun, Jul 15, 11:06 PM · efl
q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

That doesn't make it okay.

Sun, Jul 15, 9:59 PM · efl
herdsman added a comment to D6553: eo: Fix efl_new without initializing parameters.

I too was concerned about it. However, efl_add and efl_add_ref are both implemented in the same manner.

Sun, Jul 15, 9:52 PM · efl
q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

This will obviously cause issues when e.g. using an efl dll on Windows with visual studio toolchain

Sun, Jul 15, 9:51 PM · efl
q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

keep in mind that this is not portable, it's a GNU extension, so not sure if it's a good idea to use it in a public header

Sun, Jul 15, 9:47 PM · efl
akanad added a comment to D6567: scroller: replace repeating code blocks by a function.

this patch is related with D6585.
it is needed to select a proper patch between D6585 and this.

Sun, Jul 15, 6:56 PM · DO NOT MERGE, efl
herdsman added a comment to D6592: Eina binbuf: add explicit null-check before magic-check.

I thought about it, but ended up preferring the explicit solution. I briefly scanned and didn't see EINA_MAGIC_CHECK used as a null-check replacement.

Sun, Jul 15, 2:49 PM · efl
lauromoura added a comment to T7137: C# binding DllImport problems with Mono 4.

Looks like we found where the value changes:

Sun, Jul 15, 10:57 AM · efl: language bindings
YOhoho edited the content of Maintainers Reviewers.
Sun, Jul 15, 8:26 AM · efl
zmike added a comment to D6592: Eina binbuf: add explicit null-check before magic-check.

I wonder if the magic-disable code should be a null check? I imagine there's a lot of code which might do this, but maybe I'm wrong.

Sun, Jul 15, 7:51 AM · efl
herdsman added a reviewer for D6592: Eina binbuf: add explicit null-check before magic-check: zmike.
Sun, Jul 15, 6:35 AM · efl
maderios added a comment to T7115: efl-git alpha 1.21 : Enlightenment Wayland session, scrolling firefox bookmarks folders takes a long time.

Bug is still there with efl-git 1.21.0alpha1.59380.g655c5ee6e0-1 (Linux Arch Aur).
It disappears if I restart enlightenment then it reappears after half or one hour.

Sun, Jul 15, 4:34 AM · efl: display system, Restricted Project, efl (efl-1.21), enlightenment-git

Sat, Jul 14

zmike triaged T7152: create script to send phab weekly reports as TODO priority.
Sat, Jul 14, 9:49 AM