Page MenuHomePhabricator

Showstopper Issues (15)

Today

brunobelo edited projects for D9692: eolian-mono: Renaming suffix for event args., added: Restricted Project, efl (efl-1.23), efl: language bindings; removed efl.
Wed, Aug 21, 2:02 PM · efl: language bindings, efl (efl-1.23), Restricted Project
brunobelo added a task to D9692: eolian-mono: Renaming suffix for event args.: T8164: C#: Event args suffix.
Wed, Aug 21, 1:54 PM · efl: language bindings, efl (efl-1.23), Restricted Project
brunobelo added a revision to T8164: C#: Event args suffix: D9692: eolian-mono: Renaming suffix for event args..
Wed, Aug 21, 1:54 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo requested review of D9692: eolian-mono: Renaming suffix for event args..
Wed, Aug 21, 1:53 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura added a comment to T8163: C#: Event naming.

From C# guidelines in https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-type-members#names-of-events:

Wed, Aug 21, 1:01 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

Here is a list of generated events from the C# files. (without the prefix).

Wed, Aug 21, 12:59 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric closed D9682: evas/object: remove errors when user min/max size hints conflict.
Wed, Aug 21, 12:53 PM · efl
cedric closed D9659: efl_ui_spec_suite: that fixture is unneeded.
Wed, Aug 21, 12:52 PM · efl
ali.alzyod added a comment to T8136: harfbuzz 2.6 breaks text layout.

This is fixed from Harfbuzz Side.
https://github.com/harfbuzz/harfbuzz/issues/1910

Wed, Aug 21, 12:47 PM · efl
bu5hm4n added a comment to D9674: efl_ui: add scrollable_content mixin.

I actually think that this is an ok usage of key/data API. The call has to stay private. So implementing it as a constructor property require the addition of a private .h function and all the custom thingy to be done manually. A lot more code for something that two line of code solve here. As I am against writing unnecessary line as they bring more problem in the future usually, let's just go with a simple solution aka key/data.

Wed, Aug 21, 12:43 PM · efl: widgets
zmike added a task to D9691: efl/gfx: redo image scale_type enum: T7927: enum Efl.Gfx.Image_Scale_Type.
Wed, Aug 21, 12:38 PM · efl
zmike added a revision to T7927: enum Efl.Gfx.Image_Scale_Type: D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl
zmike added a child revision for D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop: D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl: widgets
cedric added a comment to D9674: efl_ui: add scrollable_content mixin.

I actually think that this is an ok usage of key/data API. The call has to stay private. So implementing it as a constructor property require the addition of a private .h function and all the custom thingy to be done manually. A lot more code for something that two line of code solve here. As I am against writing unnecessary line as they bring more problem in the future usually, let's just go with a simple solution aka key/data.

Wed, Aug 21, 12:35 PM · efl: widgets
zmike created T8169: how to reference events with commas in eo docs?.
Wed, Aug 21, 12:35 PM · Restricted Project
bu5hm4n added a comment to D9674: efl_ui: add scrollable_content mixin.

yes.

Wed, Aug 21, 12:24 PM · efl: widgets
bu5hm4n accepted D9676: efl_ui/scrollable_content: add scrollable_text property.

cool.

Wed, Aug 21, 12:24 PM · efl: widgets
zmike closed D9689: elm_test: fix background radio usage.
Wed, Aug 21, 12:23 PM · efl
zmike added inline comments to D9676: efl_ui/scrollable_content: add scrollable_text property.
Wed, Aug 21, 12:13 PM · efl: widgets
felipealmeida requested review of D9690: eolian-mono: Add support for partial classes.
Wed, Aug 21, 12:11 PM · efl
zmike requested review of D9689: elm_test: fix background radio usage.
Wed, Aug 21, 12:09 PM · efl
lauromoura assigned T8034: C#: Make C# classes partials to felipealmeida.
Wed, Aug 21, 12:07 PM · efl: language bindings
lauromoura moved T8034: C#: Make C# classes partials from Backlog to InProgress on the efl: language bindings board.
Wed, Aug 21, 12:07 PM · efl: language bindings
raster added a commit to T8135: cnp stopped respecting newlines when pasting into etnry: rEFL3716cfe1a2a3: elm entry - respect plain text newlines on paste again....
Wed, Aug 21, 12:02 PM · efl
bu5hm4n added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

Okay - then i do not see a reason for this patch...

Wed, Aug 21, 12:02 PM · efl: widgets
zmike added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

For the record, i am talking of:

static void
_anchor_del_cb(void *data, const Efl_Event *ev EINA_UNUSED)
{
   efl_ui_popup_anchor_set(data, NULL);
}
Wed, Aug 21, 11:57 AM · efl: widgets
lauromoura added a comment to T8165: C#: Hide unecessary API.

We could try hiding them but AFAIR they should be public so inherited classes can use them.

Wed, Aug 21, 11:54 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8164: C#: Event args suffix.

Evt today comes from the name of the event. Related to T8163

Wed, Aug 21, 11:53 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

This could be kinda tricky to do in a generic way. We may end up having to build a list of irregular verbs and their past tense in order to generate them.

Wed, Aug 21, 11:47 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
bu5hm4n accepted D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.

Okay.

Wed, Aug 21, 11:46 AM · efl: widgets
cedric accepted D9662: efl_ui_single_selectable: add a fallback element.
Wed, Aug 21, 11:46 AM · efl
cedric accepted D9663: efl_input_clickable: add a flag for showing user interaction.
Wed, Aug 21, 11:44 AM · efl
cedric accepted D9664: efl_ui_collection: honor desktop vs. touch setting of elm config.
Wed, Aug 21, 11:41 AM · efl
bu5hm4n added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

For the record, i am talking of:

static void
_anchor_del_cb(void *data, const Efl_Event *ev EINA_UNUSED)
{
   efl_ui_popup_anchor_set(data, NULL);
}

But it seems that the deletion of the anchor is different to what is happening if you are unsetting it (or i am just not seeing the equalness), anyways:
_anchor_calc already gets the private data of the widget, also getting the pd of the popup is not that much more.

Wed, Aug 21, 11:38 AM · efl: widgets
cedric accepted D9659: efl_ui_spec_suite: that fixture is unneeded.
Wed, Aug 21, 11:36 AM · efl
cedric accepted D9682: evas/object: remove errors when user min/max size hints conflict.
Wed, Aug 21, 11:35 AM · efl
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

We may encounter some difficulty generating the files in sub folders as a meson issue [1] limits the output of custom_target command to be placed in the same folder as it is called.

Wed, Aug 21, 11:35 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric accepted D9681: efl_ui/scroll_util: block scroll calc tsunamis caused by repeat signal emits.
Wed, Aug 21, 11:32 AM · efl: widgets
zmike added a comment to D9674: efl_ui: add scrollable_content mixin.

So you want to have efl.ui.widget.scrollable_content with a scroller_style property?

Wed, Aug 21, 11:31 AM · efl: widgets