Page MenuHomePhabricator

Showstopper Issues (15)

Today

lauromoura requested review of D9164: efl-mono: Add object type support for Eina.Value.
Mon, Jun 24, 1:59 PM · efl
vtorri requested changes to D7590: Exactness: code importation.

is it working on Windows ?

Mon, Jun 24, 10:49 AM · efl
JackDanielZ closed D9163: fix a build break caused by renaming a window type.
Mon, Jun 24, 9:54 AM
JackDanielZ accepted D9163: fix a build break caused by renaming a window type.
Mon, Jun 24, 9:53 AM
zmike closed D9152: tests/slider: verify emission of changed and delay,changed events.
Mon, Jun 24, 9:32 AM · efl: widgets
zmike closed D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.
Mon, Jun 24, 9:31 AM · efl: widgets
zmike updated the diff for D7591: Exactness: porting to Meson.
Mon, Jun 24, 9:13 AM · efl
zmike updated the diff for D7590: Exactness: code importation.

sync api

Mon, Jun 24, 9:13 AM · efl
stefan_schmidt added a comment to D9160: ci: travis: remove left over from autotools build.

Good point. There might actually be more of these around. Will have a look and re-spin tomorrow.

Mon, Jun 24, 7:47 AM · efl
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

that's what is done in configure.ac. I first trust what is in it.

Mon, Jun 24, 7:45 AM · Restricted Project
bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

Thank you for pointing out how to search the repository, i still don't get what you are talking about.

Mon, Jun 24, 7:31 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

do a git grep EINA_DEBUG_MALLOC

Mon, Jun 24, 7:22 AM · Restricted Project
bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

That would just turn off more debugging that we can actually provide without malloc_usable_size, i don't think this is what we want ?

Mon, Jun 24, 7:19 AM · Restricted Project
vtorri added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

in src/lib/eina/meson.build, instead of

Mon, Jun 24, 7:02 AM · Restricted Project
bu5hm4n accepted D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

User error - sorry.

Mon, Jun 24, 6:39 AM · efl: widgets
zmike requested review of D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.
Mon, Jun 24, 6:35 AM · efl: widgets
zmike added a comment to D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

It gets unset at the point of being swallowed:

Mon, Jun 24, 6:35 AM · efl: widgets
bu5hm4n accepted D9152: tests/slider: verify emission of changed and delay,changed events.

Macro later:

Mon, Jun 24, 6:32 AM · efl: widgets
bu5hm4n created Image Macro "later".
Mon, Jun 24, 6:32 AM
bu5hm4n requested changes to D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

Mhm - the theme does not specify this property ... and as far as breakpoints tell, this is not set to false after this call...

Mon, Jun 24, 6:30 AM · efl: widgets
zmike added a comment to D9152: tests/slider: verify emission of changed and delay,changed events.

It's planned, but I'm doing something else right now.

Mon, Jun 24, 6:29 AM · efl: widgets
bu5hm4n added a comment to D9152: tests/slider: verify emission of changed and delay,changed events.

Can you add the same for the unified widget ?

Mon, Jun 24, 6:28 AM · efl: widgets
q66 added a comment to T6890: Eolian error integration.

I added an initial syntax for this in the commit above. Please comment if you have any suggestions, objections etc.

Mon, Jun 24, 6:22 AM · efl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFL1bbf4380abce: eolian: add library support for declaring and using errors.
Mon, Jun 24, 6:14 AM · efl: language bindings, Restricted Project
zmike closed D9162: ci: travis: osx: switch to newer macos image and brew addon for packages.
Mon, Jun 24, 6:11 AM · efl
zmike accepted D9162: ci: travis: osx: switch to newer macos image and brew addon for packages.
Mon, Jun 24, 6:10 AM · efl
zmike requested changes to D9160: ci: travis: remove left over from autotools build.
Mon, Jun 24, 6:10 AM · efl
zmike closed D9161: ci: enforce ccache for macos meson run.
Mon, Jun 24, 6:10 AM · efl
zmike accepted D9161: ci: enforce ccache for macos meson run.

huge patch.

Mon, Jun 24, 6:09 AM · efl
zmike added a comment to T7902: efl.ui.popup.

I agree that it seems like align could be handled using align_hint.

Mon, Jun 24, 6:07 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

I think maybe I am not understanding this: what exactly are you proposing?

Mon, Jun 24, 6:05 AM · Restricted Project
zmike closed D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Mon, Jun 24, 6:01 AM · efl
zmike accepted D9154: remove last bits of Evil.h in tests and use evil_private.h instead.
Mon, Jun 24, 6:01 AM · efl
zmike added a comment to T7898: efl.ui.format.

I think if we are going with a priority system then the most bespoke one should be the highest priority. This would mean cb > values > string.

Mon, Jun 24, 6:00 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7947: Efl.Ui.Anchor_Popup.

align_priority is (iirc) a way to specify how you prefer the popup to do layout if it is constrained. We may want to copy/research xdg-popup semantics for this (which I also wrote) since they're a bit more robust.

Mon, Jun 24, 5:53 AM · efl (efl-1.23), efl: language bindings
zmike added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

@zmike

Thank you for the suggestion.
I want to fully understand your idea so I have some questions about the ownership steps.

  1. clickable duplicates mouse-up event
  2. activeview unsets ownership on pointer events for the unpressed pointer
  3. clickable receives mouse,up signal, checks cached mouse-up event for owner, sends 'click' event after checking for ownership

For now, Efl.Ui.Clickable_Util provides "bind_to_theme" and it adds signal callbacks to the given edj obejct for the clickable object.
So Efl.Ui.Clickable_Util only registers signal callback from the given edj object.

To do 7, do we need to register event callback for mouse up (POINTER_UP) for bind_to_theme case as well?
(as far as I can see, we cannot get mouse event in the signal callback.)

Mon, Jun 24, 5:47 AM
bu5hm4n added a comment to T7948: Efl.Ui.Alert_Popup.

I just wanted to ensure we have thought about button as part, so this is fine to me :)
So action items for this here are :

  • Change of Event type & Removal of struct type
  • Write Tests. / Verify event emission / Veryfy funcitonal icon / str parts.
Mon, Jun 24, 5:46 AM · efl (efl-1.23), efl: language bindings
akanad requested review of D9163: fix a build break caused by renaming a window type.
Mon, Jun 24, 5:15 AM
Jaehyun_Cho added a comment to T7948: Efl.Ui.Alert_Popup.

Yes, since Efl.Ui.Alert_Popup simply adds its buttons and button clicked event to Efl.Ui.Popup, extending Efl.Ui.Popup is enough for developer who needs a more flexible popup.

Mon, Jun 24, 4:26 AM · efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7948: Efl.Ui.Alert_Popup.

I also think using the enum in the event info is good enough, and that using parts would complicate things too much.
If anybody needs a more flexible popup, he can always extend from Efl.Ui.Popup, no?

Mon, Jun 24, 4:13 AM · efl (efl-1.23), efl: language bindings