is it working on Windows ?
Showstopper Issues (15)
Good point. There might actually be more of these around. Will have a look and re-spin tomorrow.
that's what is done in configure.ac. I first trust what is in it.
Thank you for pointing out how to search the repository, i still don't get what you are talking about.
do a git grep EINA_DEBUG_MALLOC
That would just turn off more debugging that we can actually provide without malloc_usable_size, i don't think this is what we want ?
in src/lib/eina/meson.build, instead of
User error - sorry.
It gets unset at the point of being swallowed:
Mhm - the theme does not specify this property ... and as far as breakpoints tell, this is not set to false after this call...
It's planned, but I'm doing something else right now.
Can you add the same for the unified widget ?
I added an initial syntax for this in the commit above. Please comment if you have any suggestions, objections etc.
I agree that it seems like align could be handled using align_hint.
I think maybe I am not understanding this: what exactly are you proposing?
I think if we are going with a priority system then the most bespoke one should be the highest priority. This would mean cb > values > string.
align_priority is (iirc) a way to specify how you prefer the popup to do layout if it is constrained. We may want to copy/research xdg-popup semantics for this (which I also wrote) since they're a bit more robust.
Thank you for the suggestion.
I want to fully understand your idea so I have some questions about the ownership steps.
- clickable duplicates mouse-up event
- activeview unsets ownership on pointer events for the unpressed pointer
- clickable receives mouse,up signal, checks cached mouse-up event for owner, sends 'click' event after checking for ownership
For now, Efl.Ui.Clickable_Util provides "bind_to_theme" and it adds signal callbacks to the given edj obejct for the clickable object.
So Efl.Ui.Clickable_Util only registers signal callback from the given edj object.
To do 7, do we need to register event callback for mouse up (POINTER_UP) for bind_to_theme case as well?
(as far as I can see, we cannot get mouse event in the signal callback.)
I just wanted to ensure we have thought about button as part, so this is fine to me :)
So action items for this here are :
- Change of Event type & Removal of struct type
- Write Tests. / Verify event emission / Veryfy funcitonal icon / str parts.
Yes, since Efl.Ui.Alert_Popup simply adds its buttons and button clicked event to Efl.Ui.Popup, extending Efl.Ui.Popup is enough for developer who needs a more flexible popup.
I also think using the enum in the event info is good enough, and that using parts would complicate things too much.
If anybody needs a more flexible popup, he can always extend from Efl.Ui.Popup, no?