Page MenuHomePhabricator

AbdullehGhujeh (Abdulleh Ghujeh)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:40 AM (61 w, 1 d)
Availability
Available

Recent Activity

Tue, Jan 14

AbdullehGhujeh triaged T8573: Efl Canvas Text : canvas textblock changed always fired in some cases as TODO priority.
Tue, Jan 14, 5:00 AM · efl

Mon, Jan 13

AbdullehGhujeh added reviewers for D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply): ali.alzyod, woohyun.
Mon, Jan 13, 7:52 AM · efl
AbdullehGhujeh requested review of D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).
Mon, Jan 13, 7:49 AM · efl

Tue, Jan 7

AbdullehGhujeh added reviewers for D11033: Evas Textblock: update obstacle test: ali.alzyod, woohyun.
Tue, Jan 7, 4:45 AM · efl
AbdullehGhujeh requested review of D11033: Evas Textblock: update obstacle test.
Tue, Jan 7, 4:43 AM · efl

Thu, Jan 2

AbdullehGhujeh added a comment to D10955: Example: Add efl_canvas_textblock_obstacles example.

This should be fixed after D11005

Thu, Jan 2, 6:33 AM · efl
AbdullehGhujeh added a reviewer for D11005: Evas Textblock : Fix obstacles & word overlap: segfaultxavi.
Thu, Jan 2, 6:26 AM · efl
AbdullehGhujeh added reviewers for D11005: Evas Textblock : Fix obstacles & word overlap: ali.alzyod, woohyun.
Thu, Jan 2, 6:23 AM · efl
AbdullehGhujeh requested review of D11005: Evas Textblock : Fix obstacles & word overlap.
Thu, Jan 2, 6:16 AM · efl

Tue, Dec 31

AbdullehGhujeh added a comment to D10955: Example: Add efl_canvas_textblock_obstacles example.

It needs more investigation but for now
It was working on Aug 21, 2017 f696cc88933bfa1ac6e5d6da26bc9ba7b2c3e2fa
and stopped working on Aug 24, 2017 af1f4157f244f84169dc9c18785041278476f116

Tue, Dec 31, 2:03 AM · efl

Dec 30 2019

AbdullehGhujeh added a comment to D10955: Example: Add efl_canvas_textblock_obstacles example.

Yes you are right

Dec 30 2019, 4:55 AM · efl

Dec 29 2019

AbdullehGhujeh added a comment to D10955: Example: Add efl_canvas_textblock_obstacles example.

Of course it need's to be fixed.
The example code here works same as the legacy one (which supposed to work fine in the past and never changed).
In my comment I said that this is the same as the legacy, to say it is an implementation issue not an example issue (agreed with what segfaultxavi has said).

Dec 29 2019, 12:38 AM · efl

Dec 23 2019

AbdullehGhujeh added a comment to D10955: Example: Add efl_canvas_textblock_obstacles example.

The example clearly does not work (the text lines are overlapped and illegible).
This is probably the implementation's fault, not this example's, but do we have any idea of where the problem is? I would like to be 100% sure the problem is not in the example.

Dec 23 2019, 5:37 AM · efl
AbdullehGhujeh updated the diff for D10955: Example: Add efl_canvas_textblock_obstacles example.

remove unneeded headers, fix warning and fixing spelling

Dec 23 2019, 5:36 AM · efl
AbdullehGhujeh updated the diff for D10955: Example: Add efl_canvas_textblock_obstacles example.
Dec 23 2019, 5:34 AM · efl
AbdullehGhujeh added a reviewer for D10955: Example: Add efl_canvas_textblock_obstacles example: ali.alzyod.
Dec 23 2019, 1:29 AM · efl
AbdullehGhujeh requested review of D10955: Example: Add efl_canvas_textblock_obstacles example.
Dec 23 2019, 1:24 AM · efl

Dec 18 2019

AbdullehGhujeh added inline comments to D10896: Fix textblock style when "lang=x" is presented.
Dec 18 2019, 12:10 AM · efl

Dec 17 2019

AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 17 2019, 7:08 AM · efl
AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 17 2019, 7:07 AM · efl
AbdullehGhujeh updated the task description for T8526: How to cache data.
Dec 17 2019, 7:04 AM · efl
AbdullehGhujeh updated the task description for T8528: Make It Immutable.
Dec 17 2019, 7:02 AM · efl
AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 17 2019, 6:53 AM · efl

Dec 16 2019

AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 16 2019, 1:47 AM · efl
AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 16 2019, 1:37 AM · efl
AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 16 2019, 1:36 AM · efl
AbdullehGhujeh updated the task description for T8528: Make It Immutable.
Dec 16 2019, 12:55 AM · efl
AbdullehGhujeh updated the task description for T8526: How to cache data.
Dec 16 2019, 12:46 AM · efl
AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 16 2019, 12:45 AM · efl
AbdullehGhujeh updated the task description for T8526: How to cache data.
Dec 16 2019, 12:37 AM · efl

Dec 15 2019

AbdullehGhujeh updated the task description for T8528: Make It Immutable.
Dec 15 2019, 6:53 AM · efl
AbdullehGhujeh updated the task description for T8527: Caching Text Metrices.
Dec 15 2019, 6:50 AM · efl
AbdullehGhujeh added a project to T8528: Make It Immutable: efl.
Dec 15 2019, 1:21 AM · efl
AbdullehGhujeh added a project to T8527: Caching Text Metrices: efl.
Dec 15 2019, 1:21 AM · efl
AbdullehGhujeh added a project to T8526: How to cache data: efl.
Dec 15 2019, 1:21 AM · efl
AbdullehGhujeh added a project to T8518: Pre-Computed Text: efl.
Dec 15 2019, 1:21 AM · efl
AbdullehGhujeh triaged T8528: Make It Immutable as TODO priority.
Dec 15 2019, 1:20 AM · efl
AbdullehGhujeh triaged T8527: Caching Text Metrices as TODO priority.
Dec 15 2019, 1:18 AM · efl
AbdullehGhujeh triaged T8526: How to cache data as TODO priority.
Dec 15 2019, 1:17 AM · efl
AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 15 2019, 12:49 AM · efl

Dec 12 2019

AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 12 2019, 6:47 AM · efl
AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 12 2019, 6:24 AM · efl

Dec 11 2019

AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 11 2019, 1:27 AM · efl

Dec 9 2019

AbdullehGhujeh reopened T8518: Pre-Computed Text as "Open".
Dec 9 2019, 5:02 AM · efl
AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Dec 9 2019, 5:01 AM · efl
Herald closed T8518: Pre-Computed Text as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Dec 9 2019, 4:29 AM · efl

Nov 27 2019

AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Nov 27 2019, 4:29 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Update Docs

Nov 27 2019, 4:28 AM · efl

Nov 26 2019

AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

@segfaultxavi @woohyun
what is the usage of const(string) ?
I used "string" type because it is evaluated to "const char *" (see old property in canvas text called bidi_delimiters also use "string" type for "const char*" , for "char *" usually "mstring" used, maybe I'm wrong ? )

Nov 26 2019, 11:23 PM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Nov 26 2019, 6:17 AM · efl

Nov 25 2019

AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Rebase

Nov 25 2019, 11:41 PM · efl
AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

@zmike
any other comments?

Nov 25 2019, 7:32 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.

Rename style_set to style_apply
Make all_styles_get read only property

Nov 25 2019, 7:31 AM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Nov 25 2019, 2:17 AM · efl

Nov 24 2019

AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

@woohyun
@bu5hm4n
We have closed all the requests.

Nov 24 2019, 1:16 AM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Nov 24 2019, 1:14 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Update function description
Fix code convention
add more tests

Nov 24 2019, 1:13 AM · efl

Nov 21 2019

AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Nov 21 2019, 6:27 AM · efl
AbdullehGhujeh retitled D10715: Efl Canvas Text : Update style parsing code from fix implicit casting int to a unsigned int added EINA_SAFETY_CHECK to Efl Canvas Text : Update style parsing code.
Nov 21 2019, 6:23 AM · efl
AbdullehGhujeh added reviewers for D10715: Efl Canvas Text : Update style parsing code: segfaultxavi, bu5hm4n, woohyun, ali.alzyod.
Nov 21 2019, 6:22 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Nov 21 2019, 6:21 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Nov 21 2019, 6:18 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Nov 21 2019, 6:17 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

rebase

Nov 21 2019, 6:12 AM · efl
AbdullehGhujeh requested review of D10715: Efl Canvas Text : Update style parsing code.
Nov 21 2019, 6:06 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
move strbuf to macros
Nov 21 2019, 6:04 AM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Nov 21 2019, 4:53 AM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Nov 21 2019, 4:08 AM · efl

Nov 20 2019

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • update docs
Nov 20 2019, 10:30 PM · efl

Nov 19 2019

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
  • added EINA_SAFETY_CHECK
  • updated docs
Nov 19 2019, 3:44 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
Nov 19 2019, 2:05 AM · efl
AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

can you check that all branches of the parsing function is checked and tested (also with asan enabled)?

I have tested only new code.

Nov 19 2019, 1:57 AM · efl

Nov 11 2019

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions + fix docs
Nov 11 2019, 10:56 PM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions + Fix docs
Nov 11 2019, 10:46 PM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Nov 11 2019, 3:37 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions
Nov 11 2019, 3:34 AM · efl

Nov 10 2019

AbdullehGhujeh added inline comments to D10635: Edje : textblock_styles strncmp improvement.
Nov 10 2019, 4:40 AM · efl
AbdullehGhujeh updated the diff for D10635: Edje : textblock_styles strncmp improvement.

update macro to avoid unexpected behaviour

Nov 10 2019, 4:38 AM · efl
AbdullehGhujeh added reviewers for D10635: Edje : textblock_styles strncmp improvement: cedric, ali.alzyod, woohyun.
Nov 10 2019, 12:24 AM · efl
AbdullehGhujeh requested review of D10635: Edje : textblock_styles strncmp improvement.
Nov 10 2019, 12:22 AM · efl

Nov 6 2019

AbdullehGhujeh requested review of D10607: Efl Canvas Text : Modify Style Property.
Nov 6 2019, 4:36 AM · efl

Aug 31 2019

AbdullehGhujeh edited reviewers for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called, added: tasn; removed: segfaultxavi.
Aug 31 2019, 11:30 PM · efl
AbdullehGhujeh added a comment to D9766: efl_ui_text : Clear selection after past on selected text.

@tasn
I didn't understand exactly what do you mean by "a new widget" ? do you mean all new interface stuff (ex : ui_text) or something else ? if so, no need to work on bugs related to the new interface ?

Aug 31 2019, 11:30 PM · efl

Aug 29 2019

AbdullehGhujeh added a reviewer for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: segfaultxavi.
Aug 29 2019, 6:05 AM · efl
AbdullehGhujeh added a reviewer for D9766: efl_ui_text : Clear selection after past on selected text: segfaultxavi.
Aug 29 2019, 6:05 AM · efl
AbdullehGhujeh added reviewers for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: cedric, woohyun.
Aug 29 2019, 12:26 AM · efl
AbdullehGhujeh added reviewers for D9766: efl_ui_text : Clear selection after past on selected text: cedric, woohyun.
Aug 29 2019, 12:25 AM · efl

Aug 28 2019

AbdullehGhujeh added a reviewer for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: ali.alzyod.
Aug 28 2019, 8:10 AM · efl
AbdullehGhujeh updated the test plan for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called.
Aug 28 2019, 8:09 AM · efl
AbdullehGhujeh requested review of D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called.
Aug 28 2019, 8:04 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:27 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:26 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:25 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 4:25 AM · efl
AbdullehGhujeh added a reviewer for D9766: efl_ui_text : Clear selection after past on selected text: ali.alzyod.
Aug 28 2019, 4:25 AM · efl
AbdullehGhujeh requested review of D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 4:22 AM · efl

Aug 26 2019

AbdullehGhujeh added a comment to T8160: Wrong Usage For Callback Forwarder.

@tasn
At least it is not working for EFL_UI_TEXT_EVENT_CHANGED_USER event for selection in ui_text (i think there is others).
This is the code used in ui_text :

Aug 26 2019, 5:43 AM

Aug 21 2019

AbdullehGhujeh renamed T8160: Wrong Usage For Callback Forwarder from Wrong Parameter For Callback Forwarder to Wrong Usage For Callback Forwarder.
Aug 21 2019, 7:49 AM
AbdullehGhujeh created T8160: Wrong Usage For Callback Forwarder.
Aug 21 2019, 7:48 AM

Aug 19 2019

AbdullehGhujeh updated the task description for T8111: Input.
Aug 19 2019, 1:01 AM