Page MenuHomePhabricator

AbdullehGhujeh (Abdulleh Ghujeh)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:40 AM (53 w, 6 d)
Availability
Available

Recent Activity

Today

AbdullehGhujeh reopened T8518: Pre-Computed Text as "Open".
Mon, Dec 9, 5:02 AM
AbdullehGhujeh updated the task description for T8518: Pre-Computed Text.
Mon, Dec 9, 5:01 AM
Herald closed T8518: Pre-Computed Text as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Mon, Dec 9, 4:29 AM

Wed, Nov 27

AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Wed, Nov 27, 4:29 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Update Docs

Wed, Nov 27, 4:28 AM · efl

Tue, Nov 26

AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

@segfaultxavi @woohyun
what is the usage of const(string) ?
I used "string" type because it is evaluated to "const char *" (see old property in canvas text called bidi_delimiters also use "string" type for "const char*" , for "char *" usually "mstring" used, maybe I'm wrong ? )

Tue, Nov 26, 11:23 PM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Tue, Nov 26, 6:17 AM · efl

Mon, Nov 25

AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Rebase

Mon, Nov 25, 11:41 PM · efl
AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

@zmike
any other comments?

Mon, Nov 25, 7:32 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.

Rename style_set to style_apply
Make all_styles_get read only property

Mon, Nov 25, 7:31 AM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Mon, Nov 25, 2:17 AM · efl

Sun, Nov 24

AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

We have closed all the requests.

Sun, Nov 24, 1:16 AM · efl
AbdullehGhujeh added inline comments to D10715: Efl Canvas Text : Update style parsing code.
Sun, Nov 24, 1:14 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

Update function description
Fix code convention
add more tests

Sun, Nov 24, 1:13 AM · efl

Thu, Nov 21

AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Thu, Nov 21, 6:27 AM · efl
AbdullehGhujeh retitled D10715: Efl Canvas Text : Update style parsing code from fix implicit casting int to a unsigned int added EINA_SAFETY_CHECK to Efl Canvas Text : Update style parsing code.
Thu, Nov 21, 6:23 AM · efl
AbdullehGhujeh added reviewers for D10715: Efl Canvas Text : Update style parsing code: segfaultxavi, bu5hm4n, woohyun, ali.alzyod.
Thu, Nov 21, 6:22 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Thu, Nov 21, 6:21 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Thu, Nov 21, 6:18 AM · efl
AbdullehGhujeh updated the summary of D10715: Efl Canvas Text : Update style parsing code.
Thu, Nov 21, 6:17 AM · efl
AbdullehGhujeh updated the diff for D10715: Efl Canvas Text : Update style parsing code.

rebase

Thu, Nov 21, 6:12 AM · efl
AbdullehGhujeh requested review of D10715: Efl Canvas Text : Update style parsing code.
Thu, Nov 21, 6:06 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
move strbuf to macros
Thu, Nov 21, 6:04 AM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Thu, Nov 21, 4:53 AM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Thu, Nov 21, 4:08 AM · efl

Wed, Nov 20

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned
  • int added EINA_SAFETY_CHECK
  • update docs
Wed, Nov 20, 10:30 PM · efl

Tue, Nov 19

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
  • added EINA_SAFETY_CHECK
  • updated docs
Tue, Nov 19, 3:44 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
Tue, Nov 19, 2:05 AM · efl
AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

can you check that all branches of the parsing function is checked and tested (also with asan enabled)?

I have tested only new code.

Tue, Nov 19, 1:57 AM · efl

Mon, Nov 11

AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions + fix docs
Mon, Nov 11, 10:56 PM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions + Fix docs
Mon, Nov 11, 10:46 PM · efl
AbdullehGhujeh added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Mon, Nov 11, 3:37 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • split style property to set/get functions
Mon, Nov 11, 3:34 AM · efl

Sun, Nov 10

AbdullehGhujeh added inline comments to D10635: Edje : textblock_styles strncmp improvement.
Sun, Nov 10, 4:40 AM · efl
AbdullehGhujeh updated the diff for D10635: Edje : textblock_styles strncmp improvement.

update macro to avoid unexpected behaviour

Sun, Nov 10, 4:38 AM · efl
AbdullehGhujeh added reviewers for D10635: Edje : textblock_styles strncmp improvement: cedric, ali.alzyod, woohyun.
Sun, Nov 10, 12:24 AM · efl
AbdullehGhujeh requested review of D10635: Edje : textblock_styles strncmp improvement.
Sun, Nov 10, 12:22 AM · efl

Nov 6 2019

AbdullehGhujeh requested review of D10607: Efl Canvas Text : Modify Style Property.
Nov 6 2019, 4:36 AM · efl

Aug 31 2019

AbdullehGhujeh edited reviewers for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called, added: tasn; removed: segfaultxavi.
Aug 31 2019, 11:30 PM · efl
AbdullehGhujeh added a comment to D9766: efl_ui_text : Clear selection after past on selected text.

@tasn
I didn't understand exactly what do you mean by "a new widget" ? do you mean all new interface stuff (ex : ui_text) or something else ? if so, no need to work on bugs related to the new interface ?

Aug 31 2019, 11:30 PM · efl

Aug 29 2019

AbdullehGhujeh added a reviewer for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: segfaultxavi.
Aug 29 2019, 6:05 AM · efl
AbdullehGhujeh added a reviewer for D9766: efl_ui_text : Clear selection after past on selected text: segfaultxavi.
Aug 29 2019, 6:05 AM · efl
AbdullehGhujeh added reviewers for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: cedric, woohyun.
Aug 29 2019, 12:26 AM · efl
AbdullehGhujeh added reviewers for D9766: efl_ui_text : Clear selection after past on selected text: cedric, woohyun.
Aug 29 2019, 12:25 AM · efl

Aug 28 2019

AbdullehGhujeh added a reviewer for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called: ali.alzyod.
Aug 28 2019, 8:10 AM · efl
AbdullehGhujeh updated the test plan for D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called.
Aug 28 2019, 8:09 AM · efl
AbdullehGhujeh requested review of D9771: efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called.
Aug 28 2019, 8:04 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:27 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:26 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 5:25 AM · efl
AbdullehGhujeh updated the test plan for D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 4:25 AM · efl
AbdullehGhujeh added a reviewer for D9766: efl_ui_text : Clear selection after past on selected text: ali.alzyod.
Aug 28 2019, 4:25 AM · efl
AbdullehGhujeh requested review of D9766: efl_ui_text : Clear selection after past on selected text.
Aug 28 2019, 4:22 AM · efl

Aug 26 2019

AbdullehGhujeh added a comment to T8160: Wrong Usage For Callback Forwarder.

@tasn
At least it is not working for EFL_UI_TEXT_EVENT_CHANGED_USER event for selection in ui_text (i think there is others).
This is the code used in ui_text :

Aug 26 2019, 5:43 AM

Aug 21 2019

AbdullehGhujeh renamed T8160: Wrong Usage For Callback Forwarder from Wrong Parameter For Callback Forwarder to Wrong Usage For Callback Forwarder.
Aug 21 2019, 7:49 AM
AbdullehGhujeh created T8160: Wrong Usage For Callback Forwarder.
Aug 21 2019, 7:48 AM

Aug 19 2019

AbdullehGhujeh updated the task description for T8111: Input.
Aug 19 2019, 1:01 AM
AbdullehGhujeh updated the task description for T8110: Text Manipulation.
Aug 19 2019, 1:00 AM

Aug 6 2019

AbdullehGhujeh updated the task description for T8060: Handling Text in Legacy and New Interface.
Aug 6 2019, 5:38 AM
AbdullehGhujeh updated the task description for T8114: Others.
Aug 6 2019, 5:29 AM
AbdullehGhujeh updated the task description for T8111: Input.
Aug 6 2019, 5:09 AM
AbdullehGhujeh updated the task description for T8109: User Actions.
Aug 6 2019, 5:08 AM
AbdullehGhujeh triaged T8114: Others as TODO priority.
Aug 6 2019, 5:07 AM
AbdullehGhujeh triaged T8113: Label Only as TODO priority.
Aug 6 2019, 5:06 AM
AbdullehGhujeh triaged T8112: Styles as TODO priority.
Aug 6 2019, 5:05 AM
AbdullehGhujeh triaged T8111: Input as TODO priority.
Aug 6 2019, 5:04 AM
AbdullehGhujeh triaged T8110: Text Manipulation as TODO priority.
Aug 6 2019, 4:28 AM
AbdullehGhujeh triaged T8109: User Actions as TODO priority.
Aug 6 2019, 4:14 AM
AbdullehGhujeh updated the task description for T8060: Handling Text in Legacy and New Interface.
Aug 6 2019, 4:11 AM
AbdullehGhujeh updated the task description for T8060: Handling Text in Legacy and New Interface.
Aug 6 2019, 4:10 AM
AbdullehGhujeh created T8108: Context Menu wrong size.
Aug 6 2019, 1:47 AM

Aug 1 2019

AbdullehGhujeh added a comment to D9454: efl_ui_clickable_util: remove efl_input_processed_set.

This patch will solve a bug I found in efl_ui_text.
efl_ui_text can't get the focus using mouse clicks when not focused.
mouse clicks will never move focus to efl_ui_text because efl_input_processed_set(pointer, EINA_TRUE) will make event flag = EVAS_EVENT_FLAG_ON_HOLD.

Aug 1 2019, 12:17 AM · efl

Jul 10 2019

AbdullehGhujeh added a comment to D8576: cursor word start position issue.

@cedric @zmike any comments?

Jul 10 2019, 4:36 AM · efl

Apr 21 2019

AbdullehGhujeh added a comment to D8576: cursor word start position issue.

@bu5hm4n
For example "_elm_entry_efl_access_text_string_get" function in elm_entry.c
call word end then call next character for "EFL_ACCESS_TEXT_GRANULARITY_WORD" case.

Apr 21 2019, 3:02 AM · efl

Apr 20 2019

AbdullehGhujeh added a comment to D8576: cursor word start position issue.

@bu5hm4n
This is what I thought also, but when I saw textblock test code i thought that this behavior are intended to be like this.
anyway in GTK word end for 'hello' is 5 not 4.
So I need to fix word end bug and remove all workarounds for it and commit it as a new patch

Apr 20 2019, 10:53 PM · efl

Apr 18 2019

AbdullehGhujeh added a comment to D8576: cursor word start position issue.

@bu5hm4n
It sounds a little bit wrong to me also but in "evas_test_textblock" they check word end to be 4 not 5 (not exact values but same case).
For elementary_test -to "Entry 4" i didn't see its code but it seems like it uses entry, entry does not export functionality for word end I think.
I already saw some code in entry for word selection or moving cursor by Ctrl+Arrow, it calls textblock word end then move to next character :)

Apr 18 2019, 12:49 AM · efl

Apr 17 2019

AbdullehGhujeh added a comment to D8576: cursor word start position issue.

@bu5hm4n
based on current behavior
If cursor at position zero or middle of the word and asked for word start and end , word start is 0 and word end is 4 (see case 3)
but if cursor is at position 5 (for the same word) and asked for word start and end, word start is 0 and word end is 5 (see case 1 & case 2)
based on this behavior I expected the word start to be 5 because we are on position after the word end which is 4, so word start & end needs to be 5.

Apr 17 2019, 11:17 PM · efl

Apr 15 2019

AbdullehGhujeh updated the diff for D8606: Unreachable code.

Removing unnecessary variable

Apr 15 2019, 4:45 AM · efl
AbdullehGhujeh added reviewers for D8606: Unreachable code: ali.alzyod, bowonryu, woohyun.
Apr 15 2019, 12:48 AM · efl
AbdullehGhujeh updated the summary of D8606: Unreachable code.
Apr 15 2019, 12:47 AM · efl
AbdullehGhujeh requested review of D8606: Unreachable code.
Apr 15 2019, 12:42 AM · efl

Apr 7 2019

AbdullehGhujeh added reviewers for D8576: cursor word start position issue: ali.alzyod, bowonryu, woohyun.
Apr 7 2019, 9:11 AM · efl
AbdullehGhujeh requested review of D8576: cursor word start position issue.
Apr 7 2019, 9:07 AM · efl