Page MenuHomePhabricator

CHAN (woochan lee)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 10:07 PM (277 w, 8 h)
Availability
Available

Recent Activity

Yesterday

CHAN added a reviewer for D11226: ecore_wl2: Fix doc(delete tags).: devilhorns.
Tue, Jan 28, 9:08 PM · efl
CHAN requested review of D11226: ecore_wl2: Fix doc(delete tags)..
Tue, Jan 28, 9:08 PM · efl
CHAN added a comment to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

@devilhorns Thanks you

Tue, Jan 28, 9:00 PM · efl
CHAN updated the diff for D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

Fix test case.

Tue, Jan 28, 8:59 PM · efl
CHAN added a comment to D11209: tests/gesture: add a 10-touch tap test.

@zmike is there any ticket for this TC work? if so, please let me know.

Tue, Jan 28, 4:36 AM · efl
CHAN accepted D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

Looks good to me.

Tue, Jan 28, 4:35 AM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

@zmike I will get some test on this patch. and update result. thank you.

Tue, Jan 28, 4:24 AM · efl
CHAN accepted D11167: efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch.

Looks good to me.

Tue, Jan 28, 4:20 AM · efl
CHAN requested changes to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Please check comment thank you.

Tue, Jan 28, 4:19 AM · efl
CHAN accepted D11164: efl/gesture: break out _direction_get() into helper function.

Looks good to me.

Tue, Jan 28, 4:00 AM · efl
CHAN accepted D11169: efl/gesture: discard non-press events for all touch points if unseen previously.

Um... i changed @smohanty 's first concept. so that code is kinda legacy...

Tue, Jan 28, 3:39 AM · efl
CHAN accepted D11168: efl/gesture: add 'pressed' state info for touch data.

Looks good to me.

Tue, Jan 28, 3:34 AM · efl
CHAN accepted D11174: efl/gesture: add an event to notify when a config value has been changed.

Looks good to me.

Tue, Jan 28, 3:32 AM · efl
CHAN accepted D11173: efl/gesture: move finger_size into private structs of recognizers.

I think it was the concept that the super class has a finger size and uses it in all inherited classes...

Tue, Jan 28, 3:32 AM · efl
CHAN accepted D11175: efl/gesture: expose 'continues' as a public property for recognizers.

Looks good to me.

Tue, Jan 28, 3:22 AM · efl
CHAN accepted D11178: efl/gesture: remove 'gesture' member from recognizer data struct.

Nice patch.

Tue, Jan 28, 3:20 AM · efl
CHAN accepted D11177: efl/gesture: remove 'manager' member from recognizer data struct.

Nice patch.

Tue, Jan 28, 3:18 AM · efl
CHAN accepted D11176: efl/gesture: remove 'config' property from recognizers.

Nice patch.

Tue, Jan 28, 3:18 AM · efl
CHAN accepted D11197: efl/gesture: reorder gesture private structs.

Nice commit.

Tue, Jan 28, 3:14 AM · efl
CHAN accepted D11198: efl/gesture: avoid direct double access in structs.

Looks good to me.

Tue, Jan 28, 3:13 AM · efl
CHAN accepted D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.

Looks good to me.

Tue, Jan 28, 3:10 AM · efl
CHAN accepted D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.

Reasonable commit. thank you.

Tue, Jan 28, 3:10 AM · efl
CHAN accepted D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.

looks good to me.

Tue, Jan 28, 3:07 AM · efl
CHAN added a comment to D11163: evas/events: fix multi-touch object targeting on touch down events.

I think I know what the intended commit is, though

Tue, Jan 28, 3:01 AM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you for the details.

Tue, Jan 28, 2:44 AM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Please check D11214

Tue, Jan 28, 12:25 AM · Restricted Project, efl
CHAN added a task to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.: T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 28, 12:21 AM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Tue, Jan 28, 12:21 AM · Restricted Project, efl
CHAN requested review of D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Tue, Jan 28, 12:16 AM · efl

Wed, Jan 22

CHAN added a reviewer for D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal": devilhorns.
Wed, Jan 22, 4:17 AM · efl
CHAN requested review of D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal".
Wed, Jan 22, 4:16 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..

Fix mistake

Wed, Jan 22, 4:15 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Wed, Jan 22, 4:12 AM · efl

Tue, Jan 21

CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 21, 11:35 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 21, 11:34 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 21, 11:33 PM · Restricted Project, efl
CHAN added a task to D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions.: T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 21, 11:32 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Tue, Jan 21, 11:32 PM · Restricted Project, efl
CHAN requested review of D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Tue, Jan 21, 11:31 PM · efl
CHAN requested changes to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you.

Tue, Jan 21, 10:34 PM · efl
CHAN accepted D11126: efl/gesture: add touch_count property for gesture event info.

@zmike Thank you. looks good to me.

Tue, Jan 21, 10:19 PM · efl
CHAN added a comment to D11052: efl/gesture: correctly handle pointer going off canvas during gestures.

@zmike Thanks you

Tue, Jan 21, 10:17 PM · efl
CHAN added a reviewer for D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal": devilhorns.
Tue, Jan 21, 8:57 PM · efl
CHAN added a task to D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal": T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 21, 8:55 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Tue, Jan 21, 8:55 PM · Restricted Project, efl
CHAN requested review of D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Tue, Jan 21, 8:55 PM · efl
CHAN updated the diff for D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..

Fix doc

Tue, Jan 21, 8:49 PM · efl
CHAN updated the diff for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

Fix Doc

Tue, Jan 21, 8:48 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

@devilhorns Oops Sorry, the ecore_wl2_input_cursor_from_name_set(input, cursor); API is using in tizen as public.

Tue, Jan 21, 8:46 PM · Restricted Project, efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

@devilhorns Thanks you for giving advise here.

Tue, Jan 21, 4:20 AM · efl
CHAN updated the test plan for D11140: evas_object_grid: Fix memory leak..
Tue, Jan 21, 2:30 AM · efl
CHAN added reviewers for D11140: evas_object_grid: Fix memory leak.: cedric, Hermet.
Tue, Jan 21, 2:29 AM · efl
CHAN requested review of D11140: evas_object_grid: Fix memory leak..
Tue, Jan 21, 2:28 AM · efl

Mon, Jan 20

CHAN added a comment to D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

If the ecore_wl2_input_keyboard_repeat_set () function called by the user
before _keyboard_cb_repeat_setup () called by the system listener.
the value assigned by the user may be overwritten with the system default value.
that's why the changed flag is using here.

Mon, Jan 20, 9:58 PM · efl
CHAN requested changes to D11126: efl/gesture: add touch_count property for gesture event info.

does it need to be public?

Mon, Jan 20, 1:10 AM · efl
CHAN added a comment to D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

@zmike thank you.

Mon, Jan 20, 1:05 AM · efl
CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Code clean up.

Mon, Jan 20, 12:44 AM · efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Failed
wl2_input_seat_capabilities : wl_seat registry timing is not same with weston.
wl2_display_dmabuf_get : enlightenment doesnt have "zwp_linux_dmabuf_v1" interface.
wl2_display_screen_size_get : enlightenment doesnt have "wl_output" interface.

Mon, Jan 20, 12:00 AM · efl

Sun, Jan 19

CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Fix TC fail in enlightenment.

Sun, Jan 19, 11:58 PM · efl
CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Fix TC

Sun, Jan 19, 10:39 PM · efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

@devilhorns Thank you.

Sun, Jan 19, 10:26 PM · efl
CHAN added a comment to D9215: ecore_wl2: add new APIs.

@devilhorns Hi.

Sun, Jan 19, 10:11 PM · Restricted Project, efl
CHAN added a reviewer for D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API.: devilhorns.
Sun, Jan 19, 10:07 PM · efl
CHAN requested review of D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..
Sun, Jan 19, 10:06 PM · efl
CHAN updated the diff for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

Add missing doc

Sun, Jan 19, 10:01 PM · efl
CHAN added a reviewer for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API.: devilhorns.
Sun, Jan 19, 9:59 PM · efl
CHAN requested review of D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..
Sun, Jan 19, 9:58 PM · efl

Thu, Jan 16

CHAN added a comment to D11087: efl/gesture: restrict flick and momentum gestures to original touch point.

Let's see it after D11086

Thu, Jan 16, 10:08 PM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

When double tapping with multiple fingers, gesture_layer triggered a double tap event with number of fingers info.

Thu, Jan 16, 10:01 PM · efl
CHAN accepted D11088: efl/gesture: fix zoom to ignore single press events and not crash.

looks good to me

Thu, Jan 16, 9:52 PM · efl
CHAN added a comment to D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

@zmike Thank you for the commit.

Thu, Jan 16, 9:47 PM · efl
CHAN accepted D11081: efl/gesture: unset timer pointers for tap recognizers.

Looks good to me. Thank you

Thu, Jan 16, 9:12 PM · efl
CHAN requested changes to D11052: efl/gesture: correctly handle pointer going off canvas during gestures.

@zmike Thank you for the commit.

Thu, Jan 16, 9:03 PM · efl
CHAN accepted D11027: efl/gesture: do not emit events for canceled gestures with no state.

Reasonable patch i think. Thank you

Thu, Jan 16, 8:50 PM · efl
CHAN added inline comments to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Thu, Jan 16, 7:50 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

ecore_wl2_display_terminate(display);
ecore_wl2_input_cursor_from_name_set(input, cursor);
ecore_wl2_session_recovery_disable();

  • Internal? what do you think? if you agree with that i will put on a patch for this.
Thu, Jan 16, 4:45 AM · Restricted Project, efl
CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Code clean up.

Thu, Jan 16, 4:34 AM · efl
CHAN added a task to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs.: T8016: Write test cases for Ecore_Wl2 API.
Thu, Jan 16, 4:28 AM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Thu, Jan 16, 4:28 AM · Restricted Project, efl
CHAN requested review of D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Thu, Jan 16, 4:26 AM · efl
CHAN added a comment to D9215: ecore_wl2: add new APIs.

@devilhorns Thank you so much.

Thu, Jan 16, 2:21 AM · Restricted Project, efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

I'm working for remain APIs.

Thu, Jan 16, 2:04 AM · Restricted Project, efl

Mon, Jan 13

CHAN added a comment to D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.

@devilhorns That sounds reasonable. i put on the patch for that suggestion. Thanks

Mon, Jan 13, 10:05 PM · efl
CHAN updated the diff for D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.

Some of APIs only working on enlightenment.

Mon, Jan 13, 10:04 PM · efl

Sun, Jan 12

CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

@devilhorns Thank you for caring this ticket.

Sun, Jan 12, 10:43 PM · Restricted Project, efl
CHAN added a comment to D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.

Yes in weston my sample app is not work.

Sun, Jan 12, 10:41 PM · efl

Wed, Jan 8

CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

You added above line in TC.
In my env the value is "seat0" instead of "default".
So it failed.

Wed, Jan 8, 10:21 PM · Restricted Project, efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Thanks for giving me an answer and adding a new TC.

Wed, Jan 8, 8:55 PM · Restricted Project, efl
CHAN added a comment to D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.

I'm working on ubuntu 18.04.

Wed, Jan 8, 5:04 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Now the ecore_wl2_output_find failed.

Wed, Jan 8, 12:06 AM · Restricted Project, efl

Tue, Jan 7

CHAN added a task to D11039: ecore_wl2: Move ecore_wl2_window_iconified, ecore_wl2_window_pending_get functions to be internal: T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 7, 11:21 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11039: ecore_wl2: Move ecore_wl2_window_iconified, ecore_wl2_window_pending_get functions to be internal.
Tue, Jan 7, 11:21 PM · Restricted Project, efl
CHAN added a reviewer for D11039: ecore_wl2: Move ecore_wl2_window_iconified, ecore_wl2_window_pending_get functions to be internal: devilhorns.
Tue, Jan 7, 11:16 PM · efl
CHAN requested review of D11039: ecore_wl2: Move ecore_wl2_window_iconified, ecore_wl2_window_pending_get functions to be internal.
Tue, Jan 7, 11:11 PM · efl
CHAN updated the diff for D11038: ecore_wl2: Add APIs to get window property..

Fix indentation

Tue, Jan 7, 11:06 PM · efl
CHAN added a task to D11038: ecore_wl2: Add APIs to get window property.: T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 7, 11:02 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11038: ecore_wl2: Add APIs to get window property..
Tue, Jan 7, 11:02 PM · Restricted Project, efl
CHAN added a reviewer for D11038: ecore_wl2: Add APIs to get window property.: devilhorns.
Tue, Jan 7, 11:02 PM · efl
CHAN requested review of D11038: ecore_wl2: Add APIs to get window property..
Tue, Jan 7, 11:00 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Derek said iconified is not work properly in this commit 50a9b49acca943754f603bd45aa4fa5b9f5020b6

Tue, Jan 7, 9:46 PM · Restricted Project, efl