Page MenuHomePhabricator
People CHAN

CHAN (woochan lee)
User

Projects

User does not belong to any projects.

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 10:07 PM (299 w, 6 d)
Availability
Available

Recent Activity
View All

Yesterday

CHAN added a comment to D11986: edje/optimization: Avoid string duplication when possible..

Plz review https://phab.enlightenment.org/D12045 instead of this patch.

Mon, Jul 6, 4:59 PM · efl
CHAN added reviewers for D12045: edje: Avoid string duplication when possible.: smohanty, cedric, Hermet, raster.
Mon, Jul 6, 4:58 PM · efl
CHAN requested review of D12045: edje: Avoid string duplication when possible..
Mon, Jul 6, 4:57 PM · efl

Tue, Jun 23

CHAN closed T8483: edje_calc: group type part calc failure. as Resolved.
Tue, Jun 23, 9:08 PM
CHAN added a comment to D11986: edje/optimization: Avoid string duplication when possible..

@smohanty nice catch.

Tue, Jun 23, 5:10 PM · efl

Tue, Jun 16

CHAN added a comment to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

Looks good to me.
may some other guy will accept it. :)

Tue, Jun 16, 10:51 PM · efl

Thu, Jun 11

CHAN requested changes to D11874: elementary calendar - generates marks for weekend days.

Im not sure we can remove _text_day_color_update...

Thu, Jun 11, 7:53 PM · efl

Wed, Jun 10

CHAN closed T7076: calendar widget: do not pass NULL to eo methods as Resolved.

@devilhorns Sorry i totally missed this ticket;;

Wed, Jun 10, 11:43 PM · efl: data types, Restricted Project
CHAN closed T7076: calendar widget: do not pass NULL to eo methods, a subtask of T7030: efl internals pass null objects to functions which should not be passed null, as Resolved.
Wed, Jun 10, 11:43 PM · Restricted Project, efl: data types, Restricted Project
CHAN added reviewers for D11966: elm_calendar: Do not pass NULL to function.: devilhorns, Hermet.
Wed, Jun 10, 11:42 PM · efl
CHAN requested review of D11966: elm_calendar: Do not pass NULL to function..
Wed, Jun 10, 11:39 PM · efl

Jun 4 2020

CHAN accepted D11927: ecore_ipc: Fix memory leak.

Looks good to me.

Jun 4 2020, 12:42 AM · efl

May 27 2020

CHAN created T8735: ECORE_WL2_EVENT_WINDOW_ROTATE Event never generated..
May 27 2020, 3:48 AM
CHAN added reviewers for D11889: ecore_wl2: Fix event type name.: Hermet, devilhorns.
May 27 2020, 1:19 AM · efl
CHAN requested review of D11889: ecore_wl2: Fix event type name..
May 27 2020, 1:19 AM · efl
CHAN added a comment to D9215: ecore_wl2: add new APIs.

@eagleeye Please revert this commit.

May 27 2020, 1:07 AM · Restricted Project, efl

May 26 2020

CHAN accepted D11886: edje: fix memory leak in edje part recalculation..

Looks good to me

May 26 2020, 10:57 PM · efl

May 25 2020

CHAN added a comment to D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

@bu5hm4n thank you for ur review.

May 25 2020, 11:37 PM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

Code fix to follow review

May 25 2020, 11:37 PM · efl
CHAN added reviewers for D11859: edje_load : clean up vector resource when edje file freed.: smohanty, bu5hm4n.
May 25 2020, 9:54 PM · efl
CHAN accepted D11879: edje: Fix memory leak by freeing the filter data..

looks good to me

May 25 2020, 9:52 PM · efl
CHAN updated the diff for D11878: ecore_wl2 : Organize window creation/deletion events..

Fix conflict

May 25 2020, 9:38 PM · efl
CHAN updated the diff for D11878: ecore_wl2 : Organize window creation/deletion events..

Use proper struct for new event.

May 25 2020, 9:36 PM · efl
CHAN added reviewers for D11878: ecore_wl2 : Organize window creation/deletion events.: devilhorns, Hermet, raster.
May 25 2020, 3:04 AM · efl
CHAN requested review of D11878: ecore_wl2 : Organize window creation/deletion events..
May 25 2020, 3:02 AM · efl

May 20 2020

CHAN added reviewers for D11859: edje_load : clean up vector resource when edje file freed.: cedric, Hermet.
May 20 2020, 12:12 AM · efl
CHAN requested review of D11859: edje_load : clean up vector resource when edje file freed..
May 20 2020, 12:11 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 20 2020, 12:09 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 20 2020, 12:07 AM · efl

May 15 2020

CHAN added reviewers for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb.: cedric, Hermet.
May 15 2020, 12:25 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

code indentation.

May 15 2020, 12:22 AM · efl
CHAN requested review of D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 15 2020, 12:19 AM · efl

May 7 2020

CHAN updated the task description for T8702: edje: edje object leak..
May 7 2020, 12:16 AM

May 6 2020

CHAN created T8702: edje: edje object leak..
May 6 2020, 11:35 PM

Mar 12 2020

CHAN added a comment to D11485: efl_gesture_manager: Fix incorrect override system config value..

@zmike Um... i don't see that case though, do you think it needs to handle that case?

Mar 12 2020, 4:56 AM · efl

Mar 11 2020

CHAN added a reviewer for D11485: efl_gesture_manager: Fix incorrect override system config value.: zmike.
Mar 11 2020, 12:14 AM · efl
CHAN requested review of D11485: efl_gesture_manager: Fix incorrect override system config value..
Mar 11 2020, 12:13 AM · efl

Feb 19 2020

CHAN added a reviewer for D11378: elm_spinner: Fixed to apply the %d format.: Jaehyun_Cho.
Feb 19 2020, 3:50 AM · efl
CHAN updated the diff for D11378: elm_spinner: Fixed to apply the %d format..

Code clean up.

Feb 19 2020, 3:48 AM · efl
CHAN requested review of D11378: elm_spinner: Fixed to apply the %d format..
Feb 19 2020, 3:44 AM · efl

Feb 11 2020

CHAN accepted D11319: efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11320: efl/gesture: remove bespoke recognizer properties for tap timeout.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11323: efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type.

looks good to me.

Feb 11 2020, 4:46 PM · efl
CHAN accepted D11322: efl/gesture: rework custom gesture recognizer methodology.

looks good to me.

Feb 11 2020, 4:46 PM · efl

Feb 4 2020

CHAN added a comment to T8502: Efl.Canvas.Gesture.

@zmike Great.

Feb 4 2020, 11:56 PM · efl: api, efl (efl-1.24)
CHAN accepted D11087: efl/gesture: restrict flick and momentum gestures to original touch point.

Looks good to me.

Feb 4 2020, 11:53 PM · efl
CHAN accepted D11086: efl/gesture: handle multi-touch press for tap gestures.
Feb 4 2020, 11:52 PM · efl
CHAN accepted D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Looks good to me.

Feb 4 2020, 11:51 PM · efl
CHAN accepted D11221: efl/gesture: remove manager's recognizer_get method.

Thank you

Feb 4 2020, 11:50 PM · efl

Jan 29 2020

CHAN requested changes to D11221: efl/gesture: remove manager's recognizer_get method.
Jan 29 2020, 11:30 PM · efl
CHAN added a comment to D11221: efl/gesture: remove manager's recognizer_get method.

It was possible for the user to get the recognizer and set the recognizer's properties.

Jan 29 2020, 11:30 PM · efl
CHAN accepted D11222: efl/gesture: break out gesture processing code into separate function.

Looks good to me.

Jan 29 2020, 11:24 PM · efl
CHAN accepted D11223: efl/gesture: implement custom gesture recognizer framework.

Looks good to me.

Jan 29 2020, 11:23 PM · efl
CHAN added a comment to T8502: Efl.Canvas.Gesture.

Shouldn't we add a property that can set / get touch count?
Or consider passing the touch count information as the data of the gesture event.

Jan 29 2020, 10:59 PM · efl: api, efl (efl-1.24)
CHAN added a comment to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

@zmike

Jan 29 2020, 10:52 PM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike do i have to see this commit more?

Jan 29 2020, 10:29 PM · efl
CHAN added a comment to D11140: evas_object_grid: Fix memory leak..

@bu5hm4n Thank you.

Jan 29 2020, 10:25 PM · efl
CHAN updated the diff for D11140: evas_object_grid: Fix memory leak..

Using legacy API.

Jan 29 2020, 10:25 PM · efl

Jan 28 2020

CHAN added a reviewer for D11226: ecore_wl2: Fix doc(delete tags).: devilhorns.
Jan 28 2020, 9:08 PM · efl
CHAN requested review of D11226: ecore_wl2: Fix doc(delete tags)..
Jan 28 2020, 9:08 PM · efl
CHAN added a comment to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

@devilhorns Thanks you

Jan 28 2020, 9:00 PM · efl
CHAN updated the diff for D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

Fix test case.

Jan 28 2020, 8:59 PM · efl
CHAN added a comment to D11209: tests/gesture: add a 10-touch tap test.

@zmike is there any ticket for this TC work? if so, please let me know.

Jan 28 2020, 4:36 AM · efl
CHAN accepted D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

Looks good to me.

Jan 28 2020, 4:35 AM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

@zmike I will get some test on this patch. and update result. thank you.

Jan 28 2020, 4:24 AM · efl
CHAN accepted D11167: efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch.

Looks good to me.

Jan 28 2020, 4:20 AM · efl
CHAN requested changes to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Please check comment thank you.

Jan 28 2020, 4:19 AM · efl
CHAN accepted D11164: efl/gesture: break out _direction_get() into helper function.

Looks good to me.

Jan 28 2020, 4:00 AM · efl
CHAN accepted D11169: efl/gesture: discard non-press events for all touch points if unseen previously.

Um... i changed @smohanty 's first concept. so that code is kinda legacy...

Jan 28 2020, 3:39 AM · efl
CHAN accepted D11168: efl/gesture: add 'pressed' state info for touch data.

Looks good to me.

Jan 28 2020, 3:34 AM · efl
CHAN accepted D11174: efl/gesture: add an event to notify when a config value has been changed.

Looks good to me.

Jan 28 2020, 3:32 AM · efl
CHAN accepted D11173: efl/gesture: move finger_size into private structs of recognizers.

I think it was the concept that the super class has a finger size and uses it in all inherited classes...

Jan 28 2020, 3:32 AM · efl
CHAN accepted D11175: efl/gesture: expose 'continues' as a public property for recognizers.

Looks good to me.

Jan 28 2020, 3:22 AM · efl
CHAN accepted D11178: efl/gesture: remove 'gesture' member from recognizer data struct.

Nice patch.

Jan 28 2020, 3:20 AM · efl
CHAN accepted D11177: efl/gesture: remove 'manager' member from recognizer data struct.

Nice patch.

Jan 28 2020, 3:18 AM · efl
CHAN accepted D11176: efl/gesture: remove 'config' property from recognizers.

Nice patch.

Jan 28 2020, 3:18 AM · efl
CHAN accepted D11197: efl/gesture: reorder gesture private structs.

Nice commit.

Jan 28 2020, 3:14 AM · efl
CHAN accepted D11198: efl/gesture: avoid direct double access in structs.

Looks good to me.

Jan 28 2020, 3:13 AM · efl
CHAN accepted D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.

Looks good to me.

Jan 28 2020, 3:10 AM · efl
CHAN accepted D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.

Reasonable commit. thank you.

Jan 28 2020, 3:10 AM · efl
CHAN accepted D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.

looks good to me.

Jan 28 2020, 3:07 AM · efl
CHAN added a comment to D11163: evas/events: fix multi-touch object targeting on touch down events.

I think I know what the intended commit is, though

Jan 28 2020, 3:01 AM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you for the details.

Jan 28 2020, 2:44 AM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Please check D11214

Jan 28 2020, 12:25 AM · Restricted Project, efl
CHAN added a task to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.: T8016: Write test cases for Ecore_Wl2 API.
Jan 28 2020, 12:21 AM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 28 2020, 12:21 AM · Restricted Project, efl
CHAN requested review of D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 28 2020, 12:16 AM · efl

Jan 22 2020

CHAN added a reviewer for D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal": devilhorns.
Jan 22 2020, 4:17 AM · efl
CHAN requested review of D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal".
Jan 22 2020, 4:16 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..

Fix mistake

Jan 22 2020, 4:15 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 22 2020, 4:12 AM · efl

Jan 21 2020

CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:35 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:34 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:33 PM · Restricted Project, efl
CHAN added a task to D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions.: T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:32 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 21 2020, 11:32 PM · Restricted Project, efl
CHAN requested review of D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 21 2020, 11:31 PM · efl
CHAN requested changes to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you.

Jan 21 2020, 10:34 PM · efl
CHAN accepted D11126: efl/gesture: add touch_count property for gesture event info.

@zmike Thank you. looks good to me.

Jan 21 2020, 10:19 PM · efl
CHAN added a comment to D11052: efl/gesture: correctly handle pointer going off canvas during gestures.

@zmike Thanks you

Jan 21 2020, 10:17 PM · efl