Page MenuHomePhabricator

CHAN (woochan lee)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 10:07 PM (320 w, 3 d)
Availability
Available

Recent Activity

Wed, Nov 25

CHAN added reviewers for D12195: elm_gesture_layer: fix config value type: Hermet, raster, zmike.
Wed, Nov 25, 12:00 AM · efl

Tue, Nov 24

CHAN requested review of D12195: elm_gesture_layer: fix config value type.
Tue, Nov 24, 11:58 PM · efl

Oct 13 2020

CHAN abandoned D12178: eina_value: Fix memory leak..

False alarm in macro.

Oct 13 2020, 1:40 AM · efl

Oct 12 2020

CHAN added reviewers for D12178: eina_value: Fix memory leak.: cedric, raster, Hermet.
Oct 12 2020, 10:26 PM · efl
CHAN requested review of D12178: eina_value: Fix memory leak..
Oct 12 2020, 10:26 PM · efl

Sep 17 2020

CHAN closed T8813: evas_outbuf memory leak as Resolved.
Sep 17 2020, 1:23 AM
CHAN updated the diff for D12147: evas_main: Fix memory leak..

Code change to follow review comment

Sep 17 2020, 1:21 AM · efl

Sep 16 2020

CHAN updated the summary of D12148: evas_outbuf: Fix memory leak..
Sep 16 2020, 11:31 PM · efl
CHAN added a task to D12148: evas_outbuf: Fix memory leak.: T8813: evas_outbuf memory leak.
Sep 16 2020, 11:31 PM · efl
CHAN added a revision to T8813: evas_outbuf memory leak: D12148: evas_outbuf: Fix memory leak..
Sep 16 2020, 11:30 PM
CHAN updated the task description for T8813: evas_outbuf memory leak.
Sep 16 2020, 11:30 PM
CHAN updated the summary of D12148: evas_outbuf: Fix memory leak..
Sep 16 2020, 11:30 PM · efl
CHAN created T8813: evas_outbuf memory leak.
Sep 16 2020, 11:29 PM
CHAN added reviewers for D12148: evas_outbuf: Fix memory leak.: raster, Hermet.
Sep 16 2020, 11:24 PM · efl
CHAN requested review of D12148: evas_outbuf: Fix memory leak..
Sep 16 2020, 11:22 PM · efl
CHAN added reviewers for D12147: evas_main: Fix memory leak.: Hermet, raster.
Sep 16 2020, 10:00 PM · efl
CHAN requested review of D12147: evas_main: Fix memory leak..
Sep 16 2020, 9:58 PM · efl

Aug 27 2020

CHAN added reviewers for D12120: edje_cc: Fix uninitialized scalar variable: Hermet, raster.
Aug 27 2020, 4:38 AM · efl
CHAN requested review of D12120: edje_cc: Fix uninitialized scalar variable.
Aug 27 2020, 4:37 AM · efl

Aug 4 2020

CHAN closed T8770: Exception handling for invalid eina_inlist use cases as Wontfix.
Aug 4 2020, 12:34 AM
CHAN added a comment to T8770: Exception handling for invalid eina_inlist use cases.

Yes i agree...

Aug 4 2020, 12:33 AM

Aug 3 2020

CHAN added a comment to D12055: edje: Avoid string duplication when possible..

@raster im not going to hate you :)

Aug 3 2020, 9:44 PM · efl

Jul 22 2020

CHAN added a comment to T8770: Exception handling for invalid eina_inlist use cases.
EAPI Eina_Inlist *
eina_inlist_append_relative(Eina_Inlist *list,
                            Eina_Inlist *new_l,
                            Eina_Inlist *relative)
{
   EINA_SAFETY_ON_NULL_RETURN_VAL(new_l, list);
Jul 22 2020, 12:22 AM

Jul 20 2020

CHAN added a comment to T8735: ECORE_WL2_EVENT_WINDOW_ROTATE Event never generated..

@devilhorns Sorry i missed it.

Jul 20 2020, 4:28 AM

Jul 16 2020

CHAN updated the task description for T8770: Exception handling for invalid eina_inlist use cases.
Jul 16 2020, 11:41 PM
CHAN updated the task description for T8770: Exception handling for invalid eina_inlist use cases.
Jul 16 2020, 11:39 PM
CHAN created T8770: Exception handling for invalid eina_inlist use cases.
Jul 16 2020, 11:39 PM
CHAN updated the test plan for D12055: edje: Avoid string duplication when possible..
Jul 16 2020, 1:15 AM · efl
CHAN added a comment to D12055: edje: Avoid string duplication when possible..

I missed group:group:part case before.

Jul 16 2020, 1:14 AM · efl
CHAN added reviewers for D12055: edje: Avoid string duplication when possible.: raster, smohanty, Hermet.
Jul 16 2020, 1:13 AM · efl
CHAN requested review of D12055: edje: Avoid string duplication when possible..
Jul 16 2020, 1:12 AM · efl

Jul 9 2020

CHAN added a comment to D11874: elementary calendar - generates marks for weekend days.

@rafspiny sorry im late.

Jul 9 2020, 5:07 PM · efl
CHAN abandoned D12045: edje: Avoid string duplication when possible..

@raster thank you for reviewing.

Jul 9 2020, 4:20 PM · efl

Jul 6 2020

CHAN added reviewers for D12045: edje: Avoid string duplication when possible.: smohanty, cedric, Hermet, raster.
Jul 6 2020, 4:58 PM · efl
CHAN requested review of D12045: edje: Avoid string duplication when possible..
Jul 6 2020, 4:57 PM · efl

Jun 23 2020

CHAN closed T8483: edje_calc: group type part calc failure. as Resolved.
Jun 23 2020, 9:08 PM

Jun 16 2020

CHAN added a comment to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

Looks good to me.
may some other guy will accept it. :)

Jun 16 2020, 10:51 PM · efl

Jun 11 2020

CHAN requested changes to D11874: elementary calendar - generates marks for weekend days.

Im not sure we can remove _text_day_color_update...

Jun 11 2020, 7:53 PM · efl

Jun 10 2020

CHAN closed T7076: calendar widget: do not pass NULL to eo methods as Resolved.

@devilhorns Sorry i totally missed this ticket;;

Jun 10 2020, 11:43 PM · efl: data types, Restricted Project
CHAN closed T7076: calendar widget: do not pass NULL to eo methods, a subtask of T7030: efl internals pass null objects to functions which should not be passed null, as Resolved.
Jun 10 2020, 11:43 PM · Restricted Project, efl: data types, Restricted Project
CHAN added reviewers for D11966: elm_calendar: Do not pass NULL to function.: devilhorns, Hermet.
Jun 10 2020, 11:42 PM · efl
CHAN requested review of D11966: elm_calendar: Do not pass NULL to function..
Jun 10 2020, 11:39 PM · efl

Jun 4 2020

CHAN accepted D11927: ecore_ipc: Fix memory leak.

Looks good to me.

Jun 4 2020, 12:42 AM · efl

May 27 2020

CHAN created T8735: ECORE_WL2_EVENT_WINDOW_ROTATE Event never generated..
May 27 2020, 3:48 AM
CHAN added reviewers for D11889: ecore_wl2: Fix event type name.: Hermet, devilhorns.
May 27 2020, 1:19 AM · efl
CHAN requested review of D11889: ecore_wl2: Fix event type name..
May 27 2020, 1:19 AM · efl
CHAN added a comment to D9215: ecore_wl2: add new APIs.

@eagleeye Please revert this commit.

May 27 2020, 1:07 AM · Restricted Project, efl

May 26 2020

CHAN accepted D11886: edje: fix memory leak in edje part recalculation..

Looks good to me

May 26 2020, 10:57 PM · efl

May 25 2020

CHAN added a comment to D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

@bu5hm4n thank you for ur review.

May 25 2020, 11:37 PM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

Code fix to follow review

May 25 2020, 11:37 PM · efl
CHAN added reviewers for D11859: edje_load : clean up vector resource when edje file freed.: smohanty, bu5hm4n.
May 25 2020, 9:54 PM · efl
CHAN accepted D11879: edje: Fix memory leak by freeing the filter data..

looks good to me

May 25 2020, 9:52 PM · efl
CHAN updated the diff for D11878: ecore_wl2 : Organize window creation/deletion events..

Fix conflict

May 25 2020, 9:38 PM · efl
CHAN updated the diff for D11878: ecore_wl2 : Organize window creation/deletion events..

Use proper struct for new event.

May 25 2020, 9:36 PM · efl
CHAN added reviewers for D11878: ecore_wl2 : Organize window creation/deletion events.: devilhorns, Hermet, raster.
May 25 2020, 3:04 AM · efl
CHAN requested review of D11878: ecore_wl2 : Organize window creation/deletion events..
May 25 2020, 3:02 AM · efl

May 20 2020

CHAN added reviewers for D11859: edje_load : clean up vector resource when edje file freed.: cedric, Hermet.
May 20 2020, 12:12 AM · efl
CHAN requested review of D11859: edje_load : clean up vector resource when edje file freed..
May 20 2020, 12:11 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 20 2020, 12:09 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 20 2020, 12:07 AM · efl

May 15 2020

CHAN added reviewers for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb.: cedric, Hermet.
May 15 2020, 12:25 AM · efl
CHAN updated the diff for D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..

code indentation.

May 15 2020, 12:22 AM · efl
CHAN requested review of D11838: elm_gesture_layer: Arrange the logic for delete the target object in gesture cb..
May 15 2020, 12:19 AM · efl

May 7 2020

CHAN updated the task description for T8702: edje: edje object leak..
May 7 2020, 12:16 AM

May 6 2020

CHAN created T8702: edje: edje object leak..
May 6 2020, 11:35 PM

Mar 12 2020

CHAN added a comment to D11485: efl_gesture_manager: Fix incorrect override system config value..

@zmike Um... i don't see that case though, do you think it needs to handle that case?

Mar 12 2020, 4:56 AM · efl

Mar 11 2020

CHAN added a reviewer for D11485: efl_gesture_manager: Fix incorrect override system config value.: zmike.
Mar 11 2020, 12:14 AM · efl
CHAN requested review of D11485: efl_gesture_manager: Fix incorrect override system config value..
Mar 11 2020, 12:13 AM · efl

Feb 19 2020

CHAN added a reviewer for D11378: elm_spinner: Fixed to apply the %d format.: Jaehyun_Cho.
Feb 19 2020, 3:50 AM · efl
CHAN updated the diff for D11378: elm_spinner: Fixed to apply the %d format..

Code clean up.

Feb 19 2020, 3:48 AM · efl
CHAN requested review of D11378: elm_spinner: Fixed to apply the %d format..
Feb 19 2020, 3:44 AM · efl

Feb 11 2020

CHAN accepted D11319: efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11320: efl/gesture: remove bespoke recognizer properties for tap timeout.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11323: efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type.

looks good to me.

Feb 11 2020, 4:46 PM · efl
CHAN accepted D11322: efl/gesture: rework custom gesture recognizer methodology.

looks good to me.

Feb 11 2020, 4:46 PM · efl

Feb 4 2020

CHAN added a comment to T8502: Efl.Canvas.Gesture.

@zmike Great.

Feb 4 2020, 11:56 PM · efl: api, efl (efl-1.24)
CHAN accepted D11087: efl/gesture: restrict flick and momentum gestures to original touch point.

Looks good to me.

Feb 4 2020, 11:53 PM · efl
CHAN accepted D11086: efl/gesture: handle multi-touch press for tap gestures.
Feb 4 2020, 11:52 PM · efl
CHAN accepted D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Looks good to me.

Feb 4 2020, 11:51 PM · efl
CHAN accepted D11221: efl/gesture: remove manager's recognizer_get method.

Thank you

Feb 4 2020, 11:50 PM · efl

Jan 29 2020

CHAN requested changes to D11221: efl/gesture: remove manager's recognizer_get method.
Jan 29 2020, 11:30 PM · efl
CHAN added a comment to D11221: efl/gesture: remove manager's recognizer_get method.

It was possible for the user to get the recognizer and set the recognizer's properties.

Jan 29 2020, 11:30 PM · efl
CHAN accepted D11222: efl/gesture: break out gesture processing code into separate function.

Looks good to me.

Jan 29 2020, 11:24 PM · efl
CHAN accepted D11223: efl/gesture: implement custom gesture recognizer framework.

Looks good to me.

Jan 29 2020, 11:23 PM · efl
CHAN added a comment to T8502: Efl.Canvas.Gesture.

Shouldn't we add a property that can set / get touch count?
Or consider passing the touch count information as the data of the gesture event.

Jan 29 2020, 10:59 PM · efl: api, efl (efl-1.24)
CHAN added a comment to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

@zmike

Jan 29 2020, 10:52 PM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike do i have to see this commit more?

Jan 29 2020, 10:29 PM · efl
CHAN added a comment to D11140: evas_object_grid: Fix memory leak..

@bu5hm4n Thank you.

Jan 29 2020, 10:25 PM · efl
CHAN updated the diff for D11140: evas_object_grid: Fix memory leak..

Using legacy API.

Jan 29 2020, 10:25 PM · efl

Jan 28 2020

CHAN added a reviewer for D11226: ecore_wl2: Fix doc(delete tags).: devilhorns.
Jan 28 2020, 9:08 PM · efl
CHAN requested review of D11226: ecore_wl2: Fix doc(delete tags)..
Jan 28 2020, 9:08 PM · efl
CHAN added a comment to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

@devilhorns Thanks you

Jan 28 2020, 9:00 PM · efl
CHAN updated the diff for D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

Fix test case.

Jan 28 2020, 8:59 PM · efl
CHAN added a comment to D11209: tests/gesture: add a 10-touch tap test.

@zmike is there any ticket for this TC work? if so, please let me know.

Jan 28 2020, 4:36 AM · efl
CHAN accepted D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

Looks good to me.

Jan 28 2020, 4:35 AM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

@zmike I will get some test on this patch. and update result. thank you.

Jan 28 2020, 4:24 AM · efl
CHAN accepted D11167: efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch.

Looks good to me.

Jan 28 2020, 4:20 AM · efl
CHAN requested changes to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Please check comment thank you.

Jan 28 2020, 4:19 AM · efl
CHAN accepted D11164: efl/gesture: break out _direction_get() into helper function.

Looks good to me.

Jan 28 2020, 4:00 AM · efl
CHAN accepted D11169: efl/gesture: discard non-press events for all touch points if unseen previously.

Um... i changed @smohanty 's first concept. so that code is kinda legacy...

Jan 28 2020, 3:39 AM · efl