Page MenuHomePhabricator

CHAN (woochan lee)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 7 2014, 10:07 PM (286 w, 6 d)
Availability
Available

Recent Activity

Thu, Mar 12

CHAN added a comment to D11485: efl_gesture_manager: Fix incorrect override system config value..

@zmike Um... i don't see that case though, do you think it need to handle that case?

Thu, Mar 12, 4:56 AM · efl

Wed, Mar 11

CHAN added a reviewer for D11485: efl_gesture_manager: Fix incorrect override system config value.: zmike.
Wed, Mar 11, 12:14 AM · efl
CHAN requested review of D11485: efl_gesture_manager: Fix incorrect override system config value..
Wed, Mar 11, 12:13 AM · efl

Feb 19 2020

CHAN added a reviewer for D11378: elm_spinner: Fixed to apply the %d format.: Jaehyun_Cho.
Feb 19 2020, 3:50 AM · efl
CHAN updated the diff for D11378: elm_spinner: Fixed to apply the %d format..

Code clean up.

Feb 19 2020, 3:48 AM · efl
CHAN requested review of D11378: elm_spinner: Fixed to apply the %d format..
Feb 19 2020, 3:44 AM · efl

Feb 11 2020

CHAN accepted D11319: efl/gesture: un-@protected efl.canvas.gesture_recognizer::continues.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11320: efl/gesture: remove bespoke recognizer properties for tap timeout.

looks good to me

Feb 11 2020, 4:48 PM · efl
CHAN accepted D11323: efl/gesture: remove Efl.Canvas.Gesture_Recognizer_Type.

looks good to me.

Feb 11 2020, 4:46 PM · efl
CHAN accepted D11322: efl/gesture: rework custom gesture recognizer methodology.

looks good to me.

Feb 11 2020, 4:46 PM · efl

Feb 4 2020

CHAN added a comment to T8502: Efl.Canvas.Gesture.

@zmike Great.

Feb 4 2020, 11:56 PM · efl: api, efl (efl-1.24)
CHAN accepted D11087: efl/gesture: restrict flick and momentum gestures to original touch point.

Looks good to me.

Feb 4 2020, 11:53 PM · efl
CHAN accepted D11086: efl/gesture: handle multi-touch press for tap gestures.
Feb 4 2020, 11:52 PM · efl
CHAN accepted D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Looks good to me.

Feb 4 2020, 11:51 PM · efl
CHAN accepted D11221: efl/gesture: remove manager's recognizer_get method.

Thank you

Feb 4 2020, 11:50 PM · efl

Jan 29 2020

CHAN requested changes to D11221: efl/gesture: remove manager's recognizer_get method.
Jan 29 2020, 11:30 PM · efl
CHAN added a comment to D11221: efl/gesture: remove manager's recognizer_get method.

It was possible for the user to get the recognizer and set the recognizer's properties.

Jan 29 2020, 11:30 PM · efl
CHAN accepted D11222: efl/gesture: break out gesture processing code into separate function.

Looks good to me.

Jan 29 2020, 11:24 PM · efl
CHAN accepted D11223: efl/gesture: implement custom gesture recognizer framework.

Looks good to me.

Jan 29 2020, 11:23 PM · efl
CHAN added a comment to T8502: Efl.Canvas.Gesture.

Shouldn't we add a property that can set / get touch count?
Or consider passing the touch count information as the data of the gesture event.

Jan 29 2020, 10:59 PM · efl: api, efl (efl-1.24)
CHAN added a comment to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

@zmike

Jan 29 2020, 10:52 PM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike do i have to see this commit more?

Jan 29 2020, 10:29 PM · efl
CHAN added a comment to D11140: evas_object_grid: Fix memory leak..

@bu5hm4n Thank you.

Jan 29 2020, 10:25 PM · efl
CHAN updated the diff for D11140: evas_object_grid: Fix memory leak..

Using legacy API.

Jan 29 2020, 10:25 PM · efl

Jan 28 2020

CHAN added a reviewer for D11226: ecore_wl2: Fix doc(delete tags).: devilhorns.
Jan 28 2020, 9:08 PM · efl
CHAN requested review of D11226: ecore_wl2: Fix doc(delete tags)..
Jan 28 2020, 9:08 PM · efl
CHAN added a comment to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

@devilhorns Thanks you

Jan 28 2020, 9:00 PM · efl
CHAN updated the diff for D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..

Fix test case.

Jan 28 2020, 8:59 PM · efl
CHAN added a comment to D11209: tests/gesture: add a 10-touch tap test.

@zmike is there any ticket for this TC work? if so, please let me know.

Jan 28 2020, 4:36 AM · efl
CHAN accepted D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

Looks good to me.

Jan 28 2020, 4:35 AM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

@zmike I will get some test on this patch. and update result. thank you.

Jan 28 2020, 4:24 AM · efl
CHAN accepted D11167: efl/gesture: correctly reset zoom gesture recognizer data on >2 finger touch.

Looks good to me.

Jan 28 2020, 4:20 AM · efl
CHAN requested changes to D11165: efl/gesture: more accurately handle flick/momentum recognition with multi-touch.

Please check comment thank you.

Jan 28 2020, 4:19 AM · efl
CHAN accepted D11164: efl/gesture: break out _direction_get() into helper function.

Looks good to me.

Jan 28 2020, 4:00 AM · efl
CHAN accepted D11169: efl/gesture: discard non-press events for all touch points if unseen previously.

Um... i changed @smohanty 's first concept. so that code is kinda legacy...

Jan 28 2020, 3:39 AM · efl
CHAN accepted D11168: efl/gesture: add 'pressed' state info for touch data.

Looks good to me.

Jan 28 2020, 3:34 AM · efl
CHAN accepted D11174: efl/gesture: add an event to notify when a config value has been changed.

Looks good to me.

Jan 28 2020, 3:32 AM · efl
CHAN accepted D11173: efl/gesture: move finger_size into private structs of recognizers.

I think it was the concept that the super class has a finger size and uses it in all inherited classes...

Jan 28 2020, 3:32 AM · efl
CHAN accepted D11175: efl/gesture: expose 'continues' as a public property for recognizers.

Looks good to me.

Jan 28 2020, 3:22 AM · efl
CHAN accepted D11178: efl/gesture: remove 'gesture' member from recognizer data struct.

Nice patch.

Jan 28 2020, 3:20 AM · efl
CHAN accepted D11177: efl/gesture: remove 'manager' member from recognizer data struct.

Nice patch.

Jan 28 2020, 3:18 AM · efl
CHAN accepted D11176: efl/gesture: remove 'config' property from recognizers.

Nice patch.

Jan 28 2020, 3:18 AM · efl
CHAN accepted D11197: efl/gesture: reorder gesture private structs.

Nice commit.

Jan 28 2020, 3:14 AM · efl
CHAN accepted D11198: efl/gesture: avoid direct double access in structs.

Looks good to me.

Jan 28 2020, 3:13 AM · efl
CHAN accepted D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.

Looks good to me.

Jan 28 2020, 3:10 AM · efl
CHAN accepted D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.

Reasonable commit. thank you.

Jan 28 2020, 3:10 AM · efl
CHAN accepted D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.

looks good to me.

Jan 28 2020, 3:07 AM · efl
CHAN added a comment to D11163: evas/events: fix multi-touch object targeting on touch down events.

I think I know what the intended commit is, though

Jan 28 2020, 3:01 AM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you for the details.

Jan 28 2020, 2:44 AM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Please check D11214

Jan 28 2020, 12:25 AM · Restricted Project, efl
CHAN added a task to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.: T8016: Write test cases for Ecore_Wl2 API.
Jan 28 2020, 12:21 AM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 28 2020, 12:21 AM · Restricted Project, efl
CHAN requested review of D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 28 2020, 12:16 AM · efl

Jan 22 2020

CHAN added a reviewer for D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal": devilhorns.
Jan 22 2020, 4:17 AM · efl
CHAN requested review of D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal".
Jan 22 2020, 4:16 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..

Fix mistake

Jan 22 2020, 4:15 AM · efl
CHAN updated the diff for D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 22 2020, 4:12 AM · efl

Jan 21 2020

CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:35 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:34 PM · Restricted Project, efl
CHAN updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:33 PM · Restricted Project, efl
CHAN added a task to D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions.: T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 11:32 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 21 2020, 11:32 PM · Restricted Project, efl
CHAN requested review of D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 21 2020, 11:31 PM · efl
CHAN requested changes to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you.

Jan 21 2020, 10:34 PM · efl
CHAN accepted D11126: efl/gesture: add touch_count property for gesture event info.

@zmike Thank you. looks good to me.

Jan 21 2020, 10:19 PM · efl
CHAN added a comment to D11052: efl/gesture: correctly handle pointer going off canvas during gestures.

@zmike Thanks you

Jan 21 2020, 10:17 PM · efl
CHAN added a reviewer for D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal": devilhorns.
Jan 21 2020, 8:57 PM · efl
CHAN added a task to D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal": T8016: Write test cases for Ecore_Wl2 API.
Jan 21 2020, 8:55 PM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Jan 21 2020, 8:55 PM · Restricted Project, efl
CHAN requested review of D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Jan 21 2020, 8:55 PM · efl
CHAN updated the diff for D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..

Fix doc

Jan 21 2020, 8:49 PM · efl
CHAN updated the diff for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

Fix Doc

Jan 21 2020, 8:48 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

@devilhorns Oops Sorry, the ecore_wl2_input_cursor_from_name_set(input, cursor); API is using in tizen as public.

Jan 21 2020, 8:46 PM · Restricted Project, efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

@devilhorns Thanks you for giving advise here.

Jan 21 2020, 4:20 AM · efl
CHAN updated the test plan for D11140: evas_object_grid: Fix memory leak..
Jan 21 2020, 2:30 AM · efl
CHAN added reviewers for D11140: evas_object_grid: Fix memory leak.: cedric, Hermet.
Jan 21 2020, 2:29 AM · efl
CHAN requested review of D11140: evas_object_grid: Fix memory leak..
Jan 21 2020, 2:28 AM · efl

Jan 20 2020

CHAN added a comment to D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

Um... If the ecore_wl2_input_keyboard_repeat_set () function called by the user
before _keyboard_cb_repeat_setup () called by the system listener.
the value assigned by the user may be overwritten with the system default value.
I gets this code from tizen. i think that's why the changed flag is using here.

Jan 20 2020, 9:58 PM · efl
CHAN requested changes to D11126: efl/gesture: add touch_count property for gesture event info.

does it need to be public?

Jan 20 2020, 1:10 AM · efl
CHAN added a comment to D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

@zmike thank you.

Jan 20 2020, 1:05 AM · efl
CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Code clean up.

Jan 20 2020, 12:44 AM · efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Failed
wl2_input_seat_capabilities : wl_seat registry timing is not same with weston.
wl2_display_dmabuf_get : enlightenment doesnt have "zwp_linux_dmabuf_v1" interface.
wl2_display_screen_size_get : enlightenment doesnt have "wl_output" interface.

Jan 20 2020, 12:00 AM · efl

Jan 19 2020

CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Fix TC fail in enlightenment.

Jan 19 2020, 11:58 PM · efl
CHAN updated the diff for D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Fix TC

Jan 19 2020, 10:39 PM · efl
CHAN added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

@devilhorns Thank you.

Jan 19 2020, 10:26 PM · efl
CHAN added a comment to D9215: ecore_wl2: add new APIs.

@devilhorns Hi.

Jan 19 2020, 10:11 PM · Restricted Project, efl
CHAN added a reviewer for D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API.: devilhorns.
Jan 19 2020, 10:07 PM · efl
CHAN requested review of D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..
Jan 19 2020, 10:06 PM · efl
CHAN updated the diff for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

Add missing doc

Jan 19 2020, 10:01 PM · efl
CHAN added a reviewer for D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API.: devilhorns.
Jan 19 2020, 9:59 PM · efl
CHAN requested review of D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..
Jan 19 2020, 9:58 PM · efl

Jan 16 2020

CHAN added a comment to D11087: efl/gesture: restrict flick and momentum gestures to original touch point.

Let's see it after D11086

Jan 16 2020, 10:08 PM · efl
CHAN added a comment to D11086: efl/gesture: handle multi-touch press for tap gestures.

When double tapping with multiple fingers, gesture_layer triggered a double tap event with number of fingers info.

Jan 16 2020, 10:01 PM · efl
CHAN accepted D11088: efl/gesture: fix zoom to ignore single press events and not crash.

looks good to me

Jan 16 2020, 9:52 PM · efl
CHAN added a comment to D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

@zmike Thank you for the commit.

Jan 16 2020, 9:47 PM · efl
CHAN accepted D11081: efl/gesture: unset timer pointers for tap recognizers.

Looks good to me. Thank you

Jan 16 2020, 9:12 PM · efl
CHAN requested changes to D11052: efl/gesture: correctly handle pointer going off canvas during gestures.

@zmike Thank you for the commit.

Jan 16 2020, 9:03 PM · efl
CHAN accepted D11027: efl/gesture: do not emit events for canceled gestures with no state.

Looks good to me.

Jan 16 2020, 8:50 PM · efl
CHAN added inline comments to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Jan 16 2020, 7:50 PM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

ecore_wl2_display_terminate(display);
ecore_wl2_input_cursor_from_name_set(input, cursor);
ecore_wl2_session_recovery_disable();

  • Internal? what do you think? if you agree with that i will put on a patch for this.
Jan 16 2020, 4:45 AM · Restricted Project, efl