Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (390 w, 1 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Mon, Aug 3

Hermet accepted D12082: edje_embryo: fix memory leak in ALLOC_COPY_DESC.
Mon, Aug 3, 11:09 PM · efl

Wed, Jul 29

Hermet requested changes to D11929: evas_vg_cache: Add sector_list_get.

This is not a common feature.

Wed, Jul 29, 2:41 AM · efl

Thu, Jul 16

Hermet closed D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Thu, Jul 16, 8:27 PM · efl
Hermet accepted D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Thu, Jul 16, 6:06 PM · efl

Jun 24 2020

Hermet closed D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 9:15 PM · efl
Hermet accepted D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 9:12 PM · efl

Jun 22 2020

Hermet closed D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 9:47 PM · efl
Hermet accepted D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 9:45 PM · efl

Jun 19 2020

Hermet closed D11996: elm_scroller: use region of proxy soruce for loop.
Jun 19 2020, 12:09 AM · efl
Hermet accepted D11996: elm_scroller: use region of proxy soruce for loop.
Jun 19 2020, 12:06 AM · efl

Jun 17 2020

Hermet closed D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 5:04 AM · efl
Hermet accepted D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 5:03 AM · efl
Hermet requested changes to D11987: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

how this patch helps to this scenario:

Jun 17 2020, 4:14 AM · efl

Jun 16 2020

Hermet accepted D11985: elementary/perf:remove unnecessary elm_widget_is() check.

good to me.

Jun 16 2020, 10:51 PM · efl
Hermet requested changes to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

Please keep code convention. We prefer simpler way.

Jun 16 2020, 10:45 PM · efl
Hermet added a comment to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

This looks good to me if agrresive optimization helps for better performance.

Jun 16 2020, 10:38 PM · efl
Hermet accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 10:36 PM · efl

Jun 15 2020

Hermet requested changes to D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

this looks wrong to me.
if user need the actual bound of the shape trees from the container, how they make it?

Jun 15 2020, 9:14 PM · efl
Hermet closed D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 9:10 PM · efl
Hermet accepted D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 9:09 PM · efl
Hermet requested changes to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 6:48 PM · efl
Hermet requested changes to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

what happens if r is not initialized at this condition? if (pd->viewbox.w != 0 && pd->viewbox.h !=0)

Jun 15 2020, 5:55 PM · efl

Jun 14 2020

Hermet added a comment to D11926: webp: add version check in configuration time.

do we really need 1.1.0? i have a debian installation my rockpro64 and it compiles and runs fine with 0.6.1. it can load webp images. no symbol errors, crashes or compile errors. i am thinking of dropping this down to 0.6.1 as at least empirically that is good enough (and it'd allow the CI build envs to re-enable webp again). upstream libwebp added WebPAnimDecoder in d39dc8f3cc07f0fffb73def2125ddcdf8073eafcwhich was back in september 2015. 0.6.1 came out nov 2017. so i think this is safe. possibly earlier versions might be fine too. 0.5.0 probably is the baseline for this actually (came out end of 2015 or so), but i can confirm 0.6.1 is seemingly fine. in fact i think i will drop it to 0.5.0 and then see if people complain because the anim api did come out in 0.5.0

Jun 14 2020, 8:35 PM · efl

Jun 12 2020

Hermet closed D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.
Jun 12 2020, 12:15 AM · efl
Hermet accepted D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.
Jun 12 2020, 12:14 AM · efl

Jun 11 2020

Hermet requested changes to D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.

Please check comments.

Jun 11 2020, 11:56 PM · efl
Hermet closed D11966: elm_calendar: Do not pass NULL to function..
Jun 11 2020, 12:34 AM · efl
Hermet accepted D11966: elm_calendar: Do not pass NULL to function..
Jun 11 2020, 12:33 AM · efl
Hermet requested changes to D11967: elc_popup: add null checks for scrollable set/get apis.

Unnecessary check. eo handles invalid objects (including nullptr) internally.

Jun 11 2020, 12:16 AM · efl

Jun 9 2020

Hermet closed D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:41 PM · efl
Hermet accepted D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:38 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

Last comment!

Jun 9 2020, 11:31 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:06 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

Please check comments.

Jun 9 2020, 9:19 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

I think we can only support Legacy API, not interface.

Jun 9 2020, 6:43 PM · efl

Jun 8 2020

Hermet closed D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..
Jun 8 2020, 6:57 PM · efl
Hermet accepted D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

great!

Jun 8 2020, 6:56 PM · efl
Hermet closed D11928: elementary/example: Fix memory leak in gengrid test.
Jun 8 2020, 4:29 AM · efl
Hermet closed D11930: gengrid: Fix memory leak.
Jun 8 2020, 4:29 AM · efl
Hermet closed D11927: ecore_ipc: Fix memory leak.
Jun 8 2020, 4:28 AM · efl
Hermet accepted D11928: elementary/example: Fix memory leak in gengrid test.
Jun 8 2020, 4:28 AM · efl
Hermet accepted D11927: ecore_ipc: Fix memory leak.
Jun 8 2020, 4:27 AM · efl

Jun 7 2020

Hermet requested changes to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Please check my comments.

Jun 7 2020, 7:10 PM · efl
Hermet closed D11926: webp: add version check in configuration time.
Jun 7 2020, 7:03 PM · efl
Hermet abandoned D11940: eldbus: fix the data size issue..
Jun 7 2020, 7:01 PM · efl
Hermet added a comment to D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.

holding review, I will check it later.

Jun 7 2020, 6:59 PM · efl

Jun 4 2020

Hermet added a reviewer for D11940: eldbus: fix the data size issue.: raster.
Jun 4 2020, 9:56 PM · efl
Hermet updated the summary of D11940: eldbus: fix the data size issue..
Jun 4 2020, 9:56 PM · efl
Hermet added reviewers for D11940: eldbus: fix the data size issue.: herb, kimcinoo, jsuya.
Jun 4 2020, 7:04 PM · efl
Hermet requested review of D11940: eldbus: fix the data size issue..
Jun 4 2020, 6:58 PM · efl
Hermet added a comment to D11932: evas: correctly declare filter_internal as public API.

@kimcinoo Could you please verify this?

Jun 4 2020, 4:18 AM · efl
Hermet added a reviewer for D11932: evas: correctly declare filter_internal as public API: kimcinoo.
Jun 4 2020, 4:18 AM · efl
Hermet added a comment to D11926: webp: add version check in configuration time.

Looks good to me. What is the reason we need version 1.1.0? A specific API we use or a bugfix we need? Would be good to record the reason for the version in the commit message.

Jun 4 2020, 1:19 AM · efl

Jun 3 2020

Hermet closed D11923: build: move static out of none_static.
Jun 3 2020, 6:30 PM · efl
Hermet accepted D11923: build: move static out of none_static.
Jun 3 2020, 6:30 PM · efl
Hermet closed D11925: Efl.Canvas.Vg.Object: Fix backup size.
Jun 3 2020, 6:29 PM · efl
Hermet accepted D11925: Efl.Canvas.Vg.Object: Fix backup size.
Jun 3 2020, 6:28 PM · efl
Hermet added a comment to D11926: webp: add version check in configuration time.

@bu5hm4n could you please verify this?

Jun 3 2020, 6:24 PM · efl
Hermet accepted D11917: Efl.Gfx.Path: Modify boundary calculation..
Jun 3 2020, 4:21 AM · efl

Jun 2 2020

Hermet accepted D11916: Build: Add json dependency to vg_common.

@bu5hm4n could you please verify this?

Jun 2 2020, 10:53 PM · efl
Hermet closed D11910: elementary_test: Added --autoclose option to elementary_test.
Jun 2 2020, 9:04 PM · efl
Hermet closed D11915: evas/engine: Fix memory leak in generic cache..
Jun 2 2020, 9:03 PM · efl
Hermet accepted D11915: evas/engine: Fix memory leak in generic cache..
Jun 2 2020, 9:03 PM · efl
Hermet added a comment to D11910: elementary_test: Added --autoclose option to elementary_test.

This looks just close the elementary_test after 2 sec.
Is it right?
It doesn't compatible with -to option ex) $elementary_test -to "Check" --autoclose
even 2 sec is fixed, I can't see any useful here...

Jun 2 2020, 8:25 PM · efl
Hermet closed D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
Jun 2 2020, 7:37 PM · efl
Hermet accepted D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
Jun 2 2020, 7:37 PM · efl
Hermet closed D11914: ecore: Fix Asan stack overflow warning.
Jun 2 2020, 7:17 PM · efl
Hermet accepted D11914: ecore: Fix Asan stack overflow warning.
Jun 2 2020, 7:13 PM · efl
Hermet requested changes to D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Please check comments.

Jun 2 2020, 1:19 AM · efl

Jun 1 2020

Hermet closed D11911: elm_hoversel: Add missing resize_job's free.
Jun 1 2020, 8:28 PM · efl
Hermet accepted D11911: elm_hoversel: Add missing resize_job's free.
Jun 1 2020, 8:26 PM · efl
Hermet requested changes to D11911: elm_hoversel: Add missing resize_job's free.

Please check comments.

Jun 1 2020, 8:03 PM · efl
Hermet closed D11909: elementary: Fix memory leak in elm_list.
Jun 1 2020, 3:01 AM · efl
Hermet closed D11908: svg/loader: Fix memory leak.
Jun 1 2020, 2:54 AM · efl
Hermet accepted D11908: svg/loader: Fix memory leak.
Jun 1 2020, 2:53 AM · efl

May 31 2020

Hermet closed D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..
May 31 2020, 9:21 PM · efl
Hermet accepted D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..
May 31 2020, 9:20 PM · efl
Hermet closed D11882: elm_gen****: free item_content map.
May 31 2020, 6:49 PM · efl
Hermet closed T8732: Memory Leak in efl_ui_focus_parent_provider_gen_content_item_map_set() api. as Resolved by committing rEFL0123c8b6fc7c: elm_gen****: free item_content map.
May 31 2020, 6:49 PM
Hermet accepted D11882: elm_gen****: free item_content map.
May 31 2020, 6:44 PM · efl
Hermet added a comment to D11888: eo: Fix memory leak in efl_key_wref_set() api..

@bu5hm4n Could you please review this?

May 31 2020, 6:43 PM · efl
Hermet added a reviewer for D11888: eo: Fix memory leak in efl_key_wref_set() api.: bu5hm4n.
May 31 2020, 6:43 PM · efl
Hermet requested changes to D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..

Please Check comments.
We can make it simper naming.

May 31 2020, 6:40 PM · efl

May 28 2020

Hermet closed D11876: Support WebP Animation Image Files.
May 28 2020, 7:42 PM · efl
Hermet accepted D11876: Support WebP Animation Image Files.
May 28 2020, 7:40 PM · efl
Hermet closed D11904: efl_ui_textpath: reduce unneeded matrix calculations.
May 28 2020, 7:39 PM · efl
Hermet accepted D11904: efl_ui_textpath: reduce unneeded matrix calculations.
May 28 2020, 7:37 PM · efl
Hermet requested changes to D11876: Support WebP Animation Image Files.

Please check one more comment.

May 28 2020, 6:57 PM · efl
Hermet added a comment to D11904: efl_ui_textpath: reduce unneeded matrix calculations.

Hmm... How about just manually write the constant values in the matrix without any matrix computation on runtime?

May 28 2020, 6:51 PM · efl
Hermet added a comment to D11876: Support WebP Animation Image Files.

@bu5hm4n any comments of the meson build?

May 28 2020, 3:44 AM · efl
Hermet added a reviewer for D11876: Support WebP Animation Image Files: bu5hm4n.
May 28 2020, 3:43 AM · efl
Hermet closed D11898: efl_ui_bg: disable preloading of the internal image.
May 28 2020, 12:18 AM · efl
Hermet accepted D11898: efl_ui_bg: disable preloading of the internal image.
May 28 2020, 12:17 AM · efl

May 27 2020

Hermet accepted D11876: Support WebP Animation Image Files.
May 27 2020, 10:09 PM · efl
Hermet added a comment to D11876: Support WebP Animation Image Files.

I think this module also consider to flush the stored frame images to retain the spare memory , Please check a gif loader - flush_older_frames(), how it does.

May 27 2020, 10:09 PM · efl
Hermet added a comment to D11876: Support WebP Animation Image Files.

Looks good to me.

May 27 2020, 10:07 PM · efl
Hermet closed D11870: evas_render: do not use mask of proxy source.
May 27 2020, 6:43 PM · efl
Hermet accepted D11870: evas_render: do not use mask of proxy source.
May 27 2020, 6:40 PM · efl
Hermet requested changes to D11876: Support WebP Animation Image Files.

Please check one more comment.

May 27 2020, 6:39 PM · efl

May 26 2020

Hermet closed D11859: edje_load : clean up vector resource when edje file freed..
May 26 2020, 8:34 PM · efl