Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (317 w, 5 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Wed, Mar 13

Hermet added a comment to D8106: canvas map: introduce a new texture mapping for better quality..

Here is a my performance comparison. Here number indicates the elapsed time(ms) for performing map drawing

Wed, Mar 13, 1:45 AM · efl

Sun, Mar 10

Hermet added a comment to D8106: canvas map: introduce a new texture mapping for better quality..

what's the performance difference on a range of devices/architectures?

Sun, Mar 10, 7:34 PM · efl

Thu, Mar 7

Hermet closed D7790: evas_canvas3d: add empty functions for missing APIs.
Thu, Mar 7, 9:47 PM · efl
Hermet added a commit to T5719: Force all apis to be implemented: rEFL23d0076346e6: evas_canvas3d: add empty functions for missing APIs.
Thu, Mar 7, 9:46 PM · Restricted Project, efl: language bindings, Restricted Project
Hermet closed D7842: edje_calc: make INTP use TO_INT_ROUND.
Thu, Mar 7, 8:33 PM · efl
Hermet accepted D7790: evas_canvas3d: add empty functions for missing APIs.
Thu, Mar 7, 8:30 PM · efl
Hermet accepted D7842: edje_calc: make INTP use TO_INT_ROUND.
Thu, Mar 7, 8:28 PM · efl
Hermet added a comment to D8217: elm_widget: fix correct parent when widget parent changed.

Originally, the unpack/unset objects have been just left as the dangling objects though the behavior is not correct.
We should make the behavior policy for those dangling objs to connect to a new parents and IMO, the most top object(window) is the right one .

Thu, Mar 7, 8:26 PM · efl
Hermet closed D8238: elm_gengrid: fix correct parent-child relation of item content.
Thu, Mar 7, 8:18 PM · efl
Hermet accepted D8238: elm_gengrid: fix correct parent-child relation of item content.
Thu, Mar 7, 8:17 PM · efl

Wed, Mar 6

Hermet added a reviewer for D8106: canvas map: introduce a new texture mapping for better quality.: committers.
Wed, Mar 6, 9:20 PM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code.

Wed, Mar 6, 9:11 PM · efl
Hermet removed a reviewer for D8106: canvas map: introduce a new texture mapping for better quality.: committers.

Neat. It would be great if that could become a flag on efl_gfx_mapping.eo (I can imagine, for example, that during animation we would be fine to drop precision and just turn it on at the end of an animation). Anyway, this patch can not land at this point in time, remind me to do a better review after the release.

Wed, Mar 6, 8:32 PM · efl
Hermet updated the summary of D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 8:25 PM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code.

Wed, Mar 6, 8:24 PM · efl
Hermet updated the diff for D8106: canvas map: introduce a new texture mapping for better quality..

clean up code.

Wed, Mar 6, 6:45 PM · efl
Hermet added a reviewer for D8106: canvas map: introduce a new texture mapping for better quality.: committers.
Wed, Mar 6, 5:23 PM · efl
Hermet planned changes to D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 4:41 AM · efl
Hermet updated the summary of D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 4:34 AM · efl
Hermet updated the summary of D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 4:33 AM · efl
Hermet updated the summary of D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 4:33 AM · efl
Hermet closed T7678: Enventor - ArchLinux - Compilation problem as Resolved.
Wed, Mar 6, 4:31 AM · Enventor
Hermet requested review of D8106: canvas map: introduce a new texture mapping for better quality..
Wed, Mar 6, 4:19 AM · efl

Sun, Feb 24

Hermet closed D7418: elm textpath: reduces differences between actual pos and modified pos.
Sun, Feb 24, 10:27 PM · efl
Hermet accepted D7418: elm textpath: reduces differences between actual pos and modified pos.

Hard to say which one is better, even hardly distinguish the differences.
But as far as I checked, as slices=maximum, the visual comes better with this patch.

Sun, Feb 24, 10:16 PM · efl
Hermet added a comment to D7842: edje_calc: make INTP use TO_INT_ROUND.

changing rounding stuff is ok to me but wondering why introduce additional condition (params->final.w/h > 0) there...

Sun, Feb 24, 10:04 PM · efl

Feb 20 2019

Hermet closed D7972: evas vg: fix correct increment for tflags.
Feb 20 2019, 9:18 PM · efl
Hermet accepted D7972: evas vg: fix correct increment for tflags.
Feb 20 2019, 9:15 PM · efl

Feb 12 2019

Hermet closed D7821: evas_image: fix pixels_dirty_set(False) makes wrong object-change-list..
Feb 12 2019, 6:16 PM · efl
Hermet accepted D7821: evas_image: fix pixels_dirty_set(False) makes wrong object-change-list..

Logically, it's fine to me, let's accept this one unless any side effect is detected.

Feb 12 2019, 6:15 PM · efl

Feb 11 2019

Hermet added a comment to D7821: evas_image: fix pixels_dirty_set(False) makes wrong object-change-list..

@jypark Is it possible to make a sample as a unit test to verify the error scenario?

Feb 11 2019, 6:23 PM · efl

Feb 10 2019

Hermet closed D7891: evas json: Load mask property from rlottie..
Feb 10 2019, 9:09 PM · efl
Hermet accepted D7891: evas json: Load mask property from rlottie..
Feb 10 2019, 9:05 PM · efl

Feb 7 2019

Hermet added a comment to D7891: evas json: Load mask property from rlottie..

one comment. please check.

Feb 7 2019, 2:26 AM · efl
Hermet closed D7890: Efl.Canvas.Vg.Object : Fix unnecessary resize function call..
Feb 7 2019, 2:04 AM · efl
Hermet accepted D7890: Efl.Canvas.Vg.Object : Fix unnecessary resize function call..
Feb 7 2019, 2:03 AM · efl
Hermet added a comment to T7678: Enventor - ArchLinux - Compilation problem.

Sorry, I couldn't check this report, I will check this issue soon.

Feb 7 2019, 12:00 AM · Enventor

Jan 31 2019

Hermet added a comment to D7842: edje_calc: make INTP use TO_INT_ROUND.

using round there looks fine but the modification of round function doesn't look right to me.
That is only valid for decrease case in negative values. increment in negative will be incorrect.
IMO, just leave round up as it does would be fine...

Jan 31 2019, 6:39 PM · efl
Hermet added a commit to T5719: Force all apis to be implemented: rEFLbd949111be8b: efl_ui_win_part: remove unused interface.
Jan 31 2019, 6:29 PM · Restricted Project, efl: language bindings, Restricted Project
Hermet closed D7844: efl_ui_win_part: remove unused interface.
Jan 31 2019, 6:29 PM · efl
Hermet accepted D7844: efl_ui_win_part: remove unused interface.
Jan 31 2019, 6:28 PM · efl
Hermet requested changes to D7844: efl_ui_win_part: remove unused interface.

Looks something wrong about color,
there is still an implemenation of _efl_ui_win_part_efl_gfx_color_color_set()/get(), _efl_ui_wi_efl_ui_win_part_efl_file_file_set()/get()
Guess they could be used or remove the bodies additionally.

Jan 31 2019, 6:16 PM · efl

Jan 29 2019

Hermet closed D7820: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 29 2019, 7:33 PM · efl
Hermet accepted D7820: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 29 2019, 7:27 PM · efl
Hermet closed D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 29 2019, 2:20 AM · efl
Hermet accepted D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 29 2019, 2:16 AM · efl
Hermet closed D7818: Efl.Ui.Animation_View: Implement Min/Max_Progress/Frame_Set/Get.
Jan 29 2019, 2:01 AM · efl
Hermet accepted D7818: Efl.Ui.Animation_View: Implement Min/Max_Progress/Frame_Set/Get.
Jan 29 2019, 2:01 AM · efl

Jan 28 2019

Hermet added a comment to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

I agree Image is not correct, but I think Frame is too generic. It is not clear what it is being controlled by this class.
I liked Efl.Gfx.Animation_Controller. Are there any other opinions?

Jan 28 2019, 11:03 PM · efl
Hermet requested changes to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

not yet confirmed

Jan 28 2019, 10:55 PM · efl
Hermet accepted D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 28 2019, 10:52 PM · efl
Hermet added a comment to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

Please check comments.
we need replace all image objects to animated object in the doc.

Jan 28 2019, 2:28 AM · efl
Hermet closed D7632: Elm_Animation_View : Change some EAPI to EOAPI.
Jan 28 2019, 2:23 AM · efl

Jan 27 2019

Hermet added a comment to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

I think we could remove animated prefix here,

Jan 27 2019, 9:56 PM · efl
Hermet closed D7767: evas_clip: do not set clip->changed to true.
Jan 27 2019, 9:49 PM · efl
Hermet accepted D7767: evas_clip: do not set clip->changed to true.
Jan 27 2019, 9:48 PM · efl
Hermet requested changes to D7790: evas_canvas3d: add empty functions for missing APIs.

It seems the callback_register/unregister shouldn't be in Evas_Canvas3D if they are only used in Canvas3D Node so far.
Yet we have no scenarios by derived classed, there is no reason to be interface nor pure virtual function.

Jan 27 2019, 9:31 PM · efl

Jan 25 2019

Hermet added a comment to T5719: Force all apis to be implemented.

I propose to change the name of efl_gfx_image_animation_controller to efl_gfx_frame_controller since "frame" could be commonly used then "image",
This interface must be designed to control sort of "scene", just normal "image" or something continous vector data...
Any feedback is welcome.

Jan 25 2019, 2:52 AM · Restricted Project, efl: language bindings, Restricted Project
Hermet added a comment to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

How about just efl_gfx_frame_controller ? (remove animation)

Jan 25 2019, 2:51 AM · efl
Hermet added a comment to T5719: Force all apis to be implemented.
Jan 25 2019, 2:51 AM · Restricted Project, efl: language bindings, Restricted Project
Hermet abandoned D7771: test patch test test test test.
Jan 25 2019, 1:32 AM · efl
Hermet abandoned D7772: test2 test2.
Jan 25 2019, 1:32 AM · efl
Hermet abandoned D7773: test 3.
Jan 25 2019, 1:31 AM · efl
Hermet abandoned D7774: test 5 Depends on D7772.
Jan 25 2019, 1:31 AM · efl
Hermet abandoned D7775: TEST TEST.
Jan 25 2019, 1:30 AM · efl
Hermet requested review of D7775: TEST TEST.
Jan 25 2019, 1:28 AM · efl
Hermet added a child revision for D7774: test 5 Depends on D7772: D7775: TEST TEST.
Jan 25 2019, 1:28 AM · efl
Hermet requested review of D7774: test 5 Depends on D7772.
Jan 25 2019, 1:27 AM · efl
Hermet requested review of D7773: test 3.
Jan 25 2019, 1:20 AM · efl
Hermet requested review of D7772: test2 test2.
Jan 25 2019, 1:17 AM · efl
Hermet requested review of D7771: test patch test test test test.
Jan 25 2019, 1:16 AM · efl

Jan 21 2019

Hermet closed D7716: Efl_Ui_Animation : Fix type errors for legacy APIs.
Jan 21 2019, 10:59 PM · efl
Hermet accepted D7716: Efl_Ui_Animation : Fix type errors for legacy APIs.
Jan 21 2019, 10:56 PM · efl

Jan 20 2019

Hermet closed D7668: Elm_Animation_View: Change Elm.Animation_View to Efl.Ui.Animation_View.
Jan 20 2019, 11:58 PM · efl
Hermet accepted D7668: Elm_Animation_View: Change Elm.Animation_View to Efl.Ui.Animation_View.
Jan 20 2019, 11:46 PM · efl

Jan 16 2019

Hermet accepted D7632: Elm_Animation_View : Change some EAPI to EOAPI.
Jan 16 2019, 1:50 AM · efl

Jan 15 2019

Hermet closed D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Jan 15 2019, 5:28 PM · efl
Hermet accepted D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Jan 15 2019, 5:28 PM · efl
Hermet requested changes to D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

Please see comments.

Jan 15 2019, 1:48 AM · efl
Hermet requested changes to D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

Added comments.

Jan 15 2019, 12:29 AM · efl

Jan 14 2019

Hermet closed D7616: Elm_Animation_View: Add elm_animation_view_frame_count_get api.
Jan 14 2019, 2:02 AM · efl
Hermet accepted D7616: Elm_Animation_View: Add elm_animation_view_frame_count_get api.
Jan 14 2019, 2:02 AM · efl

Jan 9 2019

Hermet abandoned D6979: evas json: new feature for lottie - extra.
Jan 9 2019, 10:04 PM · efl
Hermet abandoned D7031: edje: add json file support feature.
Jan 9 2019, 9:47 PM · efl
Hermet commandeered D7031: edje: add json file support feature.

This patch is managed in devs/hermet/lottie

Jan 9 2019, 9:47 PM · efl
Hermet abandoned D6687: edje/evas: init .json file support feature.
Jan 9 2019, 9:45 PM · efl
Hermet commandeered D6687: edje/evas: init .json file support feature.

This patch is managed in devs/hermet/lottie branch.

Jan 9 2019, 9:45 PM · efl
Hermet abandoned D6978: evas json: new feature for lottie - (8/8).
Jan 9 2019, 9:40 PM · efl
Hermet abandoned D6977: evas json: new feature for lottie - (7/8).
Jan 9 2019, 9:39 PM · efl
Hermet abandoned D6976: evas json: new feature for lottie - (6/8).
Jan 9 2019, 9:39 PM · efl
Hermet abandoned D6975: evas json: new feature for lottie - (5/8).
Jan 9 2019, 9:39 PM · efl
Hermet abandoned D6974: evas json: new feature for lottie - (4/8).
Jan 9 2019, 9:39 PM · efl
Hermet abandoned D6973: evas json: new feature for lottie - (3/8).
Jan 9 2019, 9:39 PM · efl
Hermet abandoned D6972: evas json: new feature for lottie - (2/8).
Jan 9 2019, 9:38 PM · efl
Hermet abandoned D6971: evas json: new feature for lottie - (1/8).
Jan 9 2019, 9:38 PM · efl

Jan 8 2019

Hermet closed D7557: elementary genlist: make it sure object type..
Jan 8 2019, 3:01 AM · efl
Hermet added reviewers for D7557: elementary genlist: make it sure object type.: committers, SanghyeonLee.
Jan 8 2019, 2:48 AM · efl
Hermet requested review of D7557: elementary genlist: make it sure object type..
Jan 8 2019, 2:48 AM · efl

Dec 27 2018

Hermet closed D7494: efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED.
Dec 27 2018, 8:22 PM · efl

Dec 26 2018

Hermet reopened D7494: efl gfx_path: remove EFL_GFX_PATH_EVENT_CHANGED.
Dec 26 2018, 2:35 AM · efl