Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (352 w, 20 h)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Sun, Nov 17

Hermet triaged T8476: efl_ui_animation_view as Normal priority.
Sun, Nov 17, 11:14 PM · efl (efl-1.24), efl: api
Hermet closed D10666: evas: migrate the vg json example.
Sun, Nov 17, 6:44 PM · efl
Hermet accepted D10666: evas: migrate the vg json example.
Sun, Nov 17, 6:44 PM · efl

Wed, Nov 13

Hermet accepted D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Wed, Nov 13, 5:52 PM · efl

Mon, Nov 11

Hermet requested changes to D10626: evas proxy: make it work for load_region.

Hmm does this work for smart objects source ?
Very simple solution to fix this issue, user can set the source object as scroller viewport object, not the origin content.

Mon, Nov 11, 4:41 PM · efl
Hermet requested changes to D10604: evas proxy: use part of source.

Please check comments.

Mon, Nov 11, 4:35 PM · efl
Hermet added a comment to D10629: evas proxy: make it work for File_Save.save.

Previously, was this feature was supported correctly?

Mon, Nov 11, 4:20 PM · efl
Hermet requested changes to D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Mon, Nov 11, 4:17 PM · efl
Hermet accepted D10595: evas_filter: remove shader compile error.
Mon, Nov 11, 4:13 PM · efl
Hermet accepted D10504: vg_loader: Get markers information form json data..
Mon, Nov 11, 4:11 PM · efl
Hermet accepted D10506: Efl.Gfx.Frame_Controller: Add sector property.
Mon, Nov 11, 4:10 PM · efl

Mon, Nov 4

Hermet accepted D10335: evas filter: Implement inverse color filter.
Mon, Nov 4, 8:17 AM · efl
Hermet accepted D10507: Efl.Ui.Animation_View: Implement sector playing feature.
Mon, Nov 4, 8:14 AM · efl
Hermet requested changes to D10506: Efl.Gfx.Frame_Controller: Add sector property.

This interface will be worthy when player supports this sector playing,

Mon, Nov 4, 8:06 AM · efl
Hermet accepted D10506: Efl.Gfx.Frame_Controller: Add sector property.
Mon, Nov 4, 7:56 AM · efl
Hermet accepted D10505: evas_cache_vg : Implements sector_get/set internal APIs.
Mon, Nov 4, 7:54 AM · efl
Hermet requested changes to D10504: vg_loader: Get markers information form json data..

Please check comments

Mon, Nov 4, 7:53 AM · efl

Thu, Oct 31

Hermet requested changes to D10435: Efl.Canvas.Group: implement Efl.Gfx.Filter.

Some comments

Thu, Oct 31, 3:50 PM · efl

Fri, Oct 25

Hermet accepted D10443: vg_common_svg: Free node tree for memory leak after eet write..
Fri, Oct 25, 3:36 AM · efl
Hermet requested changes to D10506: Efl.Gfx.Frame_Controller: Add sector property.

Please check a comment.

Fri, Oct 25, 3:35 AM · efl
Hermet requested changes to D10504: vg_loader: Get markers information form json data..

Please check comments.

Fri, Oct 25, 3:30 AM · efl
Hermet requested changes to D10505: evas_cache_vg : Implements sector_get/set internal APIs.

a simple comment.

Fri, Oct 25, 3:26 AM · efl
Hermet requested changes to D10507: Efl.Ui.Animation_View: Implement sector playing feature.

Please check comments.

Fri, Oct 25, 3:20 AM · efl

Thu, Oct 24

Hermet added a comment to V46: Will you attend the Enlightenment Developer Days 2019?.

it's shame that i couldn't make it to go to edd 19, at least i tried to send one rendering guy here for sharing working core tasks but it didn't work.

Thu, Oct 24, 4:54 AM

Oct 15 2019

Hermet added a comment to D10399: efl_canvas_vg : Propagates the alpha color of the parent.

Please carefully test and push it if no any compatibility breaks.

Oct 15 2019, 3:15 AM · efl
Hermet accepted D10399: efl_canvas_vg : Propagates the alpha color of the parent.
Oct 15 2019, 3:14 AM · efl

Oct 14 2019

Hermet closed D10371: vg_common_svg: Support opacity attribute of <g> element.
Oct 14 2019, 10:53 PM · efl
Hermet accepted D10371: vg_common_svg: Support opacity attribute of <g> element.
Oct 14 2019, 10:52 PM · efl
Hermet requested changes to D10399: efl_canvas_vg : Propagates the alpha color of the parent.

I think you can refer how we apply the matrix transform for the nodes...
Alpha needs exactly the same method.

Oct 14 2019, 10:50 PM · efl
Hermet requested changes to D10371: vg_common_svg: Support opacity attribute of <g> element.

Please check a comment.

Oct 14 2019, 6:31 PM · efl
Hermet closed D10368: vg_common_json: Apply image's alpha color.
Oct 14 2019, 1:45 AM · efl
Hermet accepted D10368: vg_common_json: Apply image's alpha color.
Oct 14 2019, 1:44 AM · efl

Oct 8 2019

Hermet added inline comments to D10303: evas_vg_cache: Hashkey of cache use value provider list.
Oct 8 2019, 3:12 AM · efl
Hermet requested changes to D10303: evas_vg_cache: Hashkey of cache use value provider list.

Considered the case, it's unnecessary cache it since it won't be shared with any others.
How about this ?
evas_cache_vg_entry_create(Evas *evas, const Eina_File *file, const char *key, int w, int h, Eina_Bool cacheable);

Oct 8 2019, 2:38 AM · efl

Oct 7 2019

Hermet closed D10281: ecore : fix incorrect size of expression for coverity.
Oct 7 2019, 12:02 AM · efl

Oct 6 2019

Hermet accepted D10281: ecore : fix incorrect size of expression for coverity.
Oct 6 2019, 11:58 PM · efl

Oct 2 2019

Hermet accepted D10268: efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State.
Oct 2 2019, 2:46 AM · efl

Oct 1 2019

Hermet requested changes to D10259: evas: enhance thread safety of sw rendering.

You argue the issue comes up with threading but there is no any thread synchronization methods for the thread safety. The fundamental problem must be still alive.

Oct 1 2019, 7:36 PM · efl

Sep 29 2019

Hermet accepted D10219: evas filter: Implement grayscale filter in SW.

good!

Sep 29 2019, 9:29 PM · efl

Sep 27 2019

Hermet requested changes to D10178: wayland_shm: do not drop surface data promptly.
Sep 27 2019, 12:40 AM · efl
Hermet requested changes to D10179: software_generic: use reference count on thread.

The thread work is supposed to draw with the previous context, (before engine set).
But this fix still ignores it but keep the thread to draw with new engine info.

Sep 27 2019, 12:32 AM · efl

Sep 26 2019

Hermet closed D10169: evas: fix memory leak with Efl.Canvas.Vg.
Sep 26 2019, 10:19 PM · efl
Hermet accepted D10169: evas: fix memory leak with Efl.Canvas.Vg.
Sep 26 2019, 10:19 PM · efl
Hermet resigned from D9858: evas filter: Implement grayscale filter in pure GL.
Sep 26 2019, 9:57 PM · efl
Hermet requested changes to D9858: evas filter: Implement grayscale filter in pure GL.
Sep 26 2019, 9:51 PM · efl
Hermet accepted D9897: vg_common_json: Override value_provider list.

Still we need a method to notice vg to update it if the value provider is changed, but we can improve this later.

Sep 26 2019, 4:10 AM · efl
Hermet accepted D10015: elementary_test: Add the value provider test for animation_view.

Please apply this after 1.23 release

Sep 26 2019, 3:56 AM · efl
Hermet requested changes to D9897: vg_common_json: Override value_provider list.

One more comment.

Sep 26 2019, 3:55 AM · efl
Hermet accepted D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

Looks fine to me please apply this after 1.23 release.

Sep 26 2019, 3:46 AM · efl
Hermet added a comment to D9858: evas filter: Implement grayscale filter in pure GL.

Don't just copy & paste.
If something wrong or unnecessary, you don't need to keep the consistency.

Sep 26 2019, 3:39 AM · efl
Hermet requested changes to D10169: evas: fix memory leak with Efl.Canvas.Vg.

I think we can apply some leak fixes but i don't agree on this removing parent set.
Please check my comment and give me your opinion.

Sep 26 2019, 3:37 AM · efl

Sep 23 2019

Hermet requested changes to D9897: vg_common_json: Override value_provider list.

Please check one comment.

Sep 23 2019, 10:10 PM · efl
Hermet requested changes to D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

Please check one more comments.

Sep 23 2019, 10:10 PM · efl
Hermet closed D10104: efl_gfx_path: Add optimized path command.
Sep 23 2019, 7:52 PM · efl
Hermet accepted D10104: efl_gfx_path: Add optimized path command.
Sep 23 2019, 7:52 PM · efl
Hermet accepted D10074: efl_gfx_path: Support 'l' command for optimized path..
Sep 23 2019, 12:56 AM · efl

Sep 19 2019

Hermet requested changes to D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

Please check comments.

Sep 19 2019, 12:24 AM · efl

Sep 18 2019

Hermet requested changes to D9858: evas filter: Implement grayscale filter in pure GL.

Overall assembled code looks fine to me some unnecessary debugging prints just bothers other developers to checking logging. (except it occurs performance drop);

Sep 18 2019, 11:57 PM · efl
Hermet closed D10002: doc: improves single line description of gesture class..
Sep 18 2019, 11:28 PM · efl
Hermet accepted D10002: doc: improves single line description of gesture class..
Sep 18 2019, 11:22 PM · efl
Hermet added a comment to T8119: Evas segfaults on recent builds of x86.

@raster oh, didn't noticed this ticket. firstly that logic must be only working when the object enables anti_alias + smooth.. did you intend this? because normally we don't enable anti_alias option for evas objects individually,

Sep 18 2019, 12:36 AM · efl (efl-1.24)

Sep 17 2019

Hermet closed D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Sep 17 2019, 5:19 AM · efl
Hermet accepted D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Sep 17 2019, 5:18 AM · efl

Sep 10 2019

Hermet accepted D9740: evas_vg_cache: Hashkey in cache uses evas.
Sep 10 2019, 4:04 AM · efl
Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check one more comment.

Sep 10 2019, 3:02 AM · efl

Sep 9 2019

Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check a comment.

Sep 9 2019, 10:46 PM · efl

Sep 5 2019

Hermet added a comment to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check a comment.

Sep 5 2019, 7:19 PM · efl

Sep 4 2019

Hermet closed D9834: use eina_strndup() instead of the GNU extension strndup(). Fix also a warning with CreateFile().
Sep 4 2019, 12:19 AM
Hermet accepted D9834: use eina_strndup() instead of the GNU extension strndup(). Fix also a warning with CreateFile().
Sep 4 2019, 12:06 AM

Sep 3 2019

Hermet closed D9833: vg_common_svg : Initialize "display" attribute.
Sep 3 2019, 8:09 PM · efl
Hermet accepted D9833: vg_common_svg : Initialize "display" attribute.
Sep 3 2019, 8:08 PM · efl
Hermet closed D9817: freetype: Prevent lose of data when fixed point divide calculation..
Sep 3 2019, 8:07 PM · efl
Hermet accepted D9817: freetype: Prevent lose of data when fixed point divide calculation..
Sep 3 2019, 8:06 PM · efl

Aug 30 2019

Hermet added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
In D9794#182033, @tasn wrote:

I don't get this change. Readability is subjective and this doesn't read any more readable to me, and it's 20 lines longer (not that it's the only parameter, but still).
It's also hard to follow when you changed a few unrelated things in one commit (or is it just phab being bad?).

Aug 30 2019, 3:11 AM · efl
Hermet accepted D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Aug 30 2019, 2:56 AM · efl
Hermet added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..

Overall looks fine to me but leave one question just in case.

Aug 30 2019, 1:33 AM · efl

Aug 28 2019

Hermet closed D9776: edje/style/optimization: Enable lazy computaion of styles..
Aug 28 2019, 10:32 PM · efl
Hermet accepted D9776: edje/style/optimization: Enable lazy computaion of styles..
Aug 28 2019, 10:32 PM · efl
Hermet requested changes to D9776: edje/style/optimization: Enable lazy computaion of styles..

Please check a comment.

Aug 28 2019, 8:05 PM · efl
Hermet closed D9764: edje: refactor _edje_object_file_set_internal() part 2..
Aug 28 2019, 12:24 AM · efl
Hermet accepted D9764: edje: refactor _edje_object_file_set_internal() part 2..
Aug 28 2019, 12:22 AM · efl

Aug 27 2019

Hermet closed D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..
Aug 27 2019, 10:42 PM · efl
Hermet accepted D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..
Aug 27 2019, 10:08 PM · efl
Hermet requested changes to D9724: efl_canvas_vg_object: Support property change feature.
Aug 27 2019, 10:08 PM · efl
Hermet closed D9763: edje/style: remove dead code..
Aug 27 2019, 10:07 PM · efl
Hermet accepted D9763: edje/style: remove dead code..
Aug 27 2019, 10:06 PM · efl
Hermet added a comment to D9724: efl_canvas_vg_object: Support property change feature.

Firstly,
we should not open these property apis.
These should be internal apis since there is no point to open them. Nobody could use this except efl_ui_animation_view.
So we could use some tricky method to communicate with efl_ui_animation_view.
I think we can efl_data_set()/get() to pass the data i.e.

Aug 27 2019, 9:42 PM · efl
Hermet added a comment to D9740: evas_vg_cache: Hashkey in cache uses evas.

As the current situation, separate vector objects could share a resource properly, there is not point to use vg object as the hash key.
Rather than this, current issue point is more like to canvases.

Aug 27 2019, 9:29 PM · efl
Hermet closed D9761: edje: refactor _edje_object_file_set_internal() function.
Aug 27 2019, 9:25 PM · efl
Hermet added a comment to D9719: edje/text_class: Add test case for text_class feature.

updated a comment.

Aug 27 2019, 9:21 PM · efl
Hermet accepted D9761: edje: refactor _edje_object_file_set_internal() function.
Aug 27 2019, 9:18 PM · efl
Hermet added a comment to D9743: efl_ui_animation_view: Support property change feature.

thought again with canvas vg altogether,

Aug 27 2019, 9:12 PM · efl
Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

I couldn't see any issue even though playing same resource 50 numbers.
Could you please attach sample code for this?

Aug 27 2019, 7:05 PM · efl
Hermet requested changes to D9743: efl_ui_animation_view: Support property change feature.

After considered to support property overriding,
I think we could add a separate interface i.e. efl_ui_animation_view_property
then extend per properties such as efl_ui_animation_view_property_color, efl_ui_animation_view_property_transform, efl_ui_animation_view_property_stroke, etc.
If so our efl_ui_animation_view could only suggest efl_ui_animation_view_property_override(Eo *anim_view, Efl_Ui_Animation_View_Property *prop);

Aug 27 2019, 6:58 PM · efl
Hermet closed D9748: eina_vpath: add null checking logic on vpath_resolve api.
Aug 27 2019, 4:25 AM · efl
Hermet accepted D9748: eina_vpath: add null checking logic on vpath_resolve api.
Aug 27 2019, 4:25 AM · efl
Hermet closed D9750: eina_list: fix to check a null argument.
Aug 27 2019, 4:24 AM · efl
Hermet accepted D9750: eina_list: fix to check a null argument.
Aug 27 2019, 4:22 AM · efl
Hermet accepted D9748: eina_vpath: add null checking logic on vpath_resolve api.
Aug 27 2019, 4:20 AM · efl
Hermet closed D9751: evas events: fix corrupted mouse events behavior on mapped object..
Aug 27 2019, 3:51 AM · efl