- User Since
- Feb 19 2013, 12:12 AM (286 w, 3 d)
Could u please check a comment?
Could you please check my review?
Destructor doesn't mean evas_object_free();
All will be freed after evas_object_free() and that would be called after delete_me == 2;
Mon, Aug 13
updated commit msg.
Sun, Aug 12
Thu, Aug 9
there is MAGIC_CHECK() already. adding this additional one is too much. I think we can remove MAGIC_CHECK there.
Wed, Aug 8
@raster let's forget preloading. Acutally, !tex shouldn't be happened, but let's assume the exception case. Developers will be more embarrassing If something solid color rectangle showed up. Because they more likely to think some obstacle objects(i,e rectangle eo) may be onto the image. Only few core developers who exactly know this exceptional handling in this backend engine could understand but not others. Even I firstly guess somewhere dangling white rectangle, clipper or image objects were there but not this (!tex) case. More than this visual, ERR message is more clear.
Let's assume Neon is stable, I think Neon in EFL has been used many years.
I could bet on this idea *IF* average performance of using Pixman is better than our pure efl rasterizer.
Tue, Aug 7
updated commit msg.
@raster, This situation is in the image preloading. Both are abnormal situation though but IMHO, engine should not do this unexpected visual result. If unexpected situation(no texture) comes, it's better to leave to users fill there with what color or what bg images (of the this texture content). Apps don't allow this embarrasing rectangle come out. For debuging, we can just print message there.
It doesn't affect anywhere though because preloading is prior to preloaded. If preloading is true, render_pre() just exits the rendering whatever preloaded is true or not,
Mon, Aug 6
beta but since 1.21?
Sun, Aug 5
it does _evas_image_load_post_update -> preloaded: TRUE, preloading: FALSE;
(2) _evas_object_image_preloading_set -> preloaded: TRUE, preloading: FALSE
True but preloaded is only available when preloading is false.
IMO above order need to be changed in 'preload*'s point of view.
i.e. whenever the 'preloaded' is set to TRUE, the 'preloading' should be set to FALSE.
Currently it does.
Thu, Aug 2
Please add proper reviewers; there is a genlist maintainer.
Wed, Aug 1
fix coding convention.
elementary image: don't calc size using empty ones.
Tue, Jul 31
We can't accept this situation. resize_obj must be valid if obj were still active. It a failure case of synchronousing both 2 objects. We must deep look and fix root cause.
Btw, color class description.... just curious which case we can utilize this functionality?? (except edje_edit)
This fix actually submitted by @raster
will review/push after 1.21,
If here efl_invalidation is neccesary, It' s really serious at efl. We can't add all this kind of stupid exceptional handling.
It's hard to expect when we need to check efl_invalidated_get() in function. Even right moment. Whatever this may fix some errors, we should not do this.
@SanghyeonLee Could u please review this patch?
@zmike Could u please more clear this sentence? "So I think the patch should be changed to just copy in the second part of the function."
Sun, Jul 29
Thu, Jul 26
let go of this after 1.21 release.
We can't apply this yet unless there is json load.
Just keep it here and see.
Tue, Jul 24
Mon, Jul 23
Sun, Jul 22
the regarded patch has been submitted.