Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (360 w, 5 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Thu, Jan 16

Hermet accepted D11113: Efl.Canvas.Vg.Object: Turn on changed flag when file loadded.
Thu, Jan 16, 5:52 PM · efl

Wed, Jan 15

Hermet accepted D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Wed, Jan 15, 11:27 PM · efl
Hermet added a comment to D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

update docs

Wed, Jan 15, 11:27 PM · efl

Mon, Jan 13

Hermet accepted D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Mon, Jan 13, 2:49 AM · efl

Wed, Jan 8

Hermet added a comment to T8476: efl_ui_animation_view.

@jsuya ping?

Wed, Jan 8, 4:58 AM · efl (efl-1.24), efl: api

Mon, Jan 6

Hermet closed D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.
Mon, Jan 6, 10:52 PM · efl
Hermet accepted D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.
Mon, Jan 6, 10:51 PM · efl
Hermet requested changes to D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.

Please check my comment.

Mon, Jan 6, 5:24 PM · efl

Fri, Jan 3

Hermet closed T8119: Evas segfaults on recent builds of x86 as Resolved.

commit dea448d40c2ab2480955a0b3776512355d68a70c (HEAD -> master, origin/master, origin/HEAD)
Author: Hermet Park <hermetpark@gmail.com>
Date: Fri Jan 3 20:51:21 2020 +0900

Fri, Jan 3, 3:54 AM · efl (efl-1.24)

Wed, Jan 1

Hermet closed D10995: elm_animation_view: Fix play/play_back behavior.
Wed, Jan 1, 11:58 PM · efl
Hermet accepted D10995: elm_animation_view: Fix play/play_back behavior.
Wed, Jan 1, 11:56 PM · efl

Mon, Dec 30

Hermet closed D10989: evas vg: add an new interface efl_canvas_vg_container_children_direct_get().
Mon, Dec 30, 9:49 PM · efl
Hermet added a reviewer for D10989: evas vg: add an new interface efl_canvas_vg_container_children_direct_get(): jsuya.
Mon, Dec 30, 9:19 PM · efl
Hermet requested review of D10989: evas vg: add an new interface efl_canvas_vg_container_children_direct_get().
Mon, Dec 30, 9:19 PM · efl

Mon, Dec 23

Hermet closed D10907: Elm_Transit: Fix wrong intervention progress value.
Mon, Dec 23, 12:40 AM · efl
Hermet accepted D10907: Elm_Transit: Fix wrong intervention progress value.
Mon, Dec 23, 12:39 AM · efl

Dec 19 2019

Hermet added a comment to D10918: eina_hash: Move hash_free_cb to avoid memory leak..

Looks reasonable. though it might occur the compatibility break since the logic sequence can be changed by this. We hope it's very rare.
@cedric ?

Dec 19 2019, 2:14 AM · efl
Hermet closed D10916: ector software: catch up losing tasks among the threads..
Dec 19 2019, 12:01 AM · efl

Dec 18 2019

Hermet requested changes to D10907: Elm_Transit: Fix wrong intervention progress value.

Looks in this case animation progress will be broken..??

Dec 18 2019, 11:29 PM · efl
Hermet updated the diff for D10916: ector software: catch up losing tasks among the threads..

remove unecessary code.

Dec 18 2019, 11:12 PM · efl
Hermet planned changes to D10916: ector software: catch up losing tasks among the threads..
Dec 18 2019, 10:55 PM · efl
Hermet added a reviewer for D10916: ector software: catch up losing tasks among the threads.: kimcinoo.
Dec 18 2019, 10:49 PM · efl
Hermet added reviewers for D10916: ector software: catch up losing tasks among the threads.: jsuya, cedric, smohanty.
Dec 18 2019, 10:47 PM · efl
Hermet requested review of D10916: ector software: catch up losing tasks among the threads..
Dec 18 2019, 10:46 PM · efl
Hermet added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.
Dec 18 2019, 3:17 AM · efl
Hermet added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.

@bu5hm4n using transit inside is out of this topic. Probably we can make an another task for this.

Dec 18 2019, 3:14 AM · efl
Hermet added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.

@jsuya @segfaultxavi @bu5hm4n Speed with direction is vector. Obviously. we don't think it speed. Maybe rate() is better than speed in this case. Plus rewind and negative playing is conceptually different. rewind is revert the playing for the amount which have been progressed from the beginning. Negative playing is regardless of the rewind. it's just playing to opposite way. Thus, rewind in animation view is necessary for user convenient who really want to rewind animation (i.e cancel effect it might started effect animation or not.)

Dec 18 2019, 3:13 AM · efl

Dec 16 2019

Hermet added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.

@bu5hm4n @segfaultxavi theoretically, speed is a scalar, there is no negative value in speed. it's not velocity, If you learned the physics. efl_player_playing_reverse_set() / efl_player_playing_rewind_set() is much clear, imo.

Dec 16 2019, 8:35 PM · efl

Dec 12 2019

Hermet added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.

@bu5hm4n Looks good to me, please review this.

Dec 12 2019, 5:50 PM · efl

Dec 10 2019

Hermet closed D10830: Example: enhance efl-canvas-vg-simple.
Dec 10 2019, 2:19 AM · efl

Dec 9 2019

Hermet accepted D10830: Example: enhance efl-canvas-vg-simple.
Dec 9 2019, 9:52 PM · efl

Dec 5 2019

Hermet accepted D10819: Example: Add efl-cavnas-vg-simple for unified API.
Dec 5 2019, 10:49 PM · efl
Hermet closed D10748: ector_software_rasterizer: use dynamic array by span size..
Dec 5 2019, 5:38 PM · efl
Hermet accepted D10748: ector_software_rasterizer: use dynamic array by span size..
Dec 5 2019, 5:37 PM · efl
Hermet closed D10803: elm_label: Emit click signal on acivate action on label.
Dec 5 2019, 5:34 PM · efl
Hermet accepted D10803: elm_label: Emit click signal on acivate action on label.
Dec 5 2019, 5:30 PM · efl
Hermet closed D10807: evas_events: fix wrong condition of proxy event behavior..
Dec 5 2019, 5:22 PM · efl
Hermet accepted D10807: evas_events: fix wrong condition of proxy event behavior..
Dec 5 2019, 5:21 PM · efl
Hermet closed D10804: Ector: Prevent access to NULL.
Dec 5 2019, 3:26 AM · efl
Hermet accepted D10804: Ector: Prevent access to NULL.
Dec 5 2019, 3:24 AM · efl

Dec 4 2019

Hermet closed D10794: fix the wrong method signature for evas_textgrid.
Dec 4 2019, 2:15 AM · efl
Hermet accepted D10794: fix the wrong method signature for evas_textgrid.
Dec 4 2019, 2:12 AM · efl

Nov 28 2019

Hermet requested changes to D10748: ector_software_rasterizer: use dynamic array by span size..
Nov 28 2019, 5:09 PM · efl

Nov 27 2019

Hermet requested changes to D10748: ector_software_rasterizer: use dynamic array by span size..

Please check a comment.

Nov 27 2019, 9:53 PM · efl

Nov 26 2019

Hermet closed D10437: gesture_manager: Changed function param to reduce internal function calls..
Nov 26 2019, 9:29 PM · efl
Hermet accepted D10437: gesture_manager: Changed function param to reduce internal function calls..
Nov 26 2019, 9:23 PM · efl
Hermet requested changes to D10437: gesture_manager: Changed function param to reduce internal function calls..

Please check a comment.

Nov 26 2019, 1:53 AM · efl
Hermet accepted D10437: gesture_manager: Changed function param to reduce internal function calls..
Nov 26 2019, 1:42 AM · efl

Nov 25 2019

Hermet closed D10724: edje_calc: Creation macro that perform edje calc, regardless of the edje size..
Nov 25 2019, 8:57 PM · efl
Hermet accepted D10724: edje_calc: Creation macro that perform edje calc, regardless of the edje size..
Nov 25 2019, 8:56 PM · efl
Hermet closed D10736: vg_common_json: Fix a missing of free after using.
Nov 25 2019, 8:50 PM · efl
Hermet accepted D10736: vg_common_json: Fix a missing of free after using.
Nov 25 2019, 8:49 PM · efl
Hermet closed D10721: theme: Delete max that seems not right..
Nov 25 2019, 2:16 AM · efl
Hermet accepted D10721: theme: Delete max that seems not right..
Nov 25 2019, 2:10 AM · efl
Hermet closed D10732: Efl.Canvas.Vg.Container : Initialize mask buffer for SUB, INS composition..
Nov 25 2019, 2:05 AM · efl
Hermet accepted D10732: Efl.Canvas.Vg.Container : Initialize mask buffer for SUB, INS composition..
Nov 25 2019, 2:04 AM · efl

Nov 24 2019

Hermet closed D10731: vector lottie: Set visibility vg node.
Nov 24 2019, 8:39 PM · efl
Hermet accepted D10731: vector lottie: Set visibility vg node.
Nov 24 2019, 8:38 PM · efl

Nov 21 2019

Hermet added a comment to D10718: Efl.Canvas.Image: Add skeleton code Efl.Gfx.Frame_Controller.sector.

@jsuya @bu5hm4n IMO sector_set/get() is a convenient utility function that just manages the sector list (name : range).
This doesn't need to be implemented by each derived classes.
framecontroller could provide the base function of these methods and derived class could override its functionality (if it's necessary)
We can consider this implementation way.

Nov 21 2019, 10:17 PM · efl
Hermet accepted D10718: Efl.Canvas.Image: Add skeleton code Efl.Gfx.Frame_Controller.sector.
Nov 21 2019, 10:09 PM · efl

Nov 17 2019

Hermet triaged T8476: efl_ui_animation_view as Normal priority.
Nov 17 2019, 11:14 PM · efl (efl-1.24), efl: api
Hermet closed D10666: evas: migrate the vg json example.
Nov 17 2019, 6:44 PM · efl
Hermet accepted D10666: evas: migrate the vg json example.
Nov 17 2019, 6:44 PM · efl

Nov 13 2019

Hermet accepted D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Nov 13 2019, 5:52 PM · efl

Nov 11 2019

Hermet requested changes to D10626: evas proxy: make it work for load_region.

Hmm does this work for smart objects source ?
Very simple solution to fix this issue, user can set the source object as scroller viewport object, not the origin content.

Nov 11 2019, 4:41 PM · efl
Hermet requested changes to D10604: evas proxy: use part of source.

Please check comments.

Nov 11 2019, 4:35 PM · efl
Hermet added a comment to D10629: evas proxy: make it work for File_Save.save.

Previously, was this feature was supported correctly?

Nov 11 2019, 4:20 PM · efl
Hermet requested changes to D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Nov 11 2019, 4:17 PM · efl
Hermet accepted D10595: evas_filter: remove shader compile error.
Nov 11 2019, 4:13 PM · efl
Hermet accepted D10504: vg_loader: Get markers information form json data..
Nov 11 2019, 4:11 PM · efl
Hermet accepted D10506: Efl.Gfx.Frame_Controller: Add sector property.
Nov 11 2019, 4:10 PM · efl

Nov 4 2019

Hermet accepted D10335: evas filter: Implement inverse color filter.
Nov 4 2019, 8:17 AM · efl
Hermet accepted D10507: Efl.Ui.Animation_View: Implement sector playing feature.
Nov 4 2019, 8:14 AM · efl
Hermet requested changes to D10506: Efl.Gfx.Frame_Controller: Add sector property.

This interface will be worthy when player supports this sector playing,

Nov 4 2019, 8:06 AM · efl
Hermet accepted D10506: Efl.Gfx.Frame_Controller: Add sector property.
Nov 4 2019, 7:56 AM · efl
Hermet accepted D10505: evas_cache_vg : Implements sector_get/set internal APIs.
Nov 4 2019, 7:54 AM · efl
Hermet requested changes to D10504: vg_loader: Get markers information form json data..

Please check comments

Nov 4 2019, 7:53 AM · efl

Oct 31 2019

Hermet requested changes to D10435: Efl.Canvas.Group: implement Efl.Gfx.Filter.

Some comments

Oct 31 2019, 3:50 PM · efl

Oct 25 2019

Hermet accepted D10443: vg_common_svg: Free node tree for memory leak after eet write..
Oct 25 2019, 3:36 AM · efl
Hermet requested changes to D10506: Efl.Gfx.Frame_Controller: Add sector property.

Please check a comment.

Oct 25 2019, 3:35 AM · efl
Hermet requested changes to D10504: vg_loader: Get markers information form json data..

Please check comments.

Oct 25 2019, 3:30 AM · efl
Hermet requested changes to D10505: evas_cache_vg : Implements sector_get/set internal APIs.

a simple comment.

Oct 25 2019, 3:26 AM · efl
Hermet requested changes to D10507: Efl.Ui.Animation_View: Implement sector playing feature.

Please check comments.

Oct 25 2019, 3:20 AM · efl

Oct 24 2019

Hermet added a comment to V46: Will you attend the Enlightenment Developer Days 2019?.

it's shame that i couldn't make it to go to edd 19, at least i tried to send one rendering guy here for sharing working core tasks but it didn't work.

Oct 24 2019, 4:54 AM

Oct 15 2019

Hermet added a comment to D10399: efl_canvas_vg : Propagates the alpha color of the parent.

Please carefully test and push it if no any compatibility breaks.

Oct 15 2019, 3:15 AM · efl
Hermet accepted D10399: efl_canvas_vg : Propagates the alpha color of the parent.
Oct 15 2019, 3:14 AM · efl

Oct 14 2019

Hermet closed D10371: vg_common_svg: Support opacity attribute of <g> element.
Oct 14 2019, 10:53 PM · efl
Hermet accepted D10371: vg_common_svg: Support opacity attribute of <g> element.
Oct 14 2019, 10:52 PM · efl
Hermet requested changes to D10399: efl_canvas_vg : Propagates the alpha color of the parent.

I think you can refer how we apply the matrix transform for the nodes...
Alpha needs exactly the same method.

Oct 14 2019, 10:50 PM · efl
Hermet requested changes to D10371: vg_common_svg: Support opacity attribute of <g> element.

Please check a comment.

Oct 14 2019, 6:31 PM · efl
Hermet closed D10368: vg_common_json: Apply image's alpha color.
Oct 14 2019, 1:45 AM · efl
Hermet accepted D10368: vg_common_json: Apply image's alpha color.
Oct 14 2019, 1:44 AM · efl

Oct 8 2019

Hermet added inline comments to D10303: evas_vg_cache: Hashkey of cache use value provider list.
Oct 8 2019, 3:12 AM · efl
Hermet requested changes to D10303: evas_vg_cache: Hashkey of cache use value provider list.

Considered the case, it's unnecessary cache it since it won't be shared with any others.
How about this ?
evas_cache_vg_entry_create(Evas *evas, const Eina_File *file, const char *key, int w, int h, Eina_Bool cacheable);

Oct 8 2019, 2:38 AM · efl

Oct 7 2019

Hermet closed D10281: ecore : fix incorrect size of expression for coverity.
Oct 7 2019, 12:02 AM · efl

Oct 6 2019

Hermet accepted D10281: ecore : fix incorrect size of expression for coverity.
Oct 6 2019, 11:58 PM · efl

Oct 2 2019

Hermet accepted D10268: efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State.
Oct 2 2019, 2:46 AM · efl

Oct 1 2019

Hermet requested changes to D10259: evas: enhance thread safety of sw rendering.

You argue the issue comes up with threading but there is no any thread synchronization methods for the thread safety. The fundamental problem must be still alive.

Oct 1 2019, 7:36 PM · efl

Sep 29 2019

Hermet accepted D10219: evas filter: Implement grayscale filter in SW.

good!

Sep 29 2019, 9:29 PM · efl

Sep 27 2019

Hermet requested changes to D10178: wayland_shm: do not drop surface data promptly.
Sep 27 2019, 12:40 AM · efl