Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (401 w, 3 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Wed, Oct 14

Hermet closed D12179: vg_load_svg: Implement ClipPath feature.
Wed, Oct 14, 3:18 AM · efl
Hermet accepted D12179: vg_load_svg: Implement ClipPath feature.
Wed, Oct 14, 2:20 AM · efl

Mon, Oct 12

Hermet closed D12174: vg_load_svg: Add points copy of missing polygon/polyline.
Mon, Oct 12, 2:38 AM · efl
Hermet accepted D12174: vg_load_svg: Add points copy of missing polygon/polyline.
Mon, Oct 12, 2:34 AM · efl

Sun, Oct 4

Hermet closed D12164: elementary image zoomable: fix non supported oversized image..
Sun, Oct 4, 8:56 PM · efl

Sep 24 2020

Hermet updated the diff for D12164: elementary image zoomable: fix non supported oversized image..

updated initialization variables.

Sep 24 2020, 7:32 PM · efl
Hermet added a reviewer for D12164: elementary image zoomable: fix non supported oversized image.: kimcinoo.
Sep 24 2020, 6:51 PM · efl
Hermet requested review of D12164: elementary image zoomable: fix non supported oversized image..
Sep 24 2020, 6:50 PM · efl

Sep 23 2020

Hermet closed D12152: evas vg: check vg changed.
Sep 23 2020, 8:17 PM · efl
Hermet accepted D12152: evas vg: check vg changed.
Sep 23 2020, 8:15 PM · efl

Sep 21 2020

Hermet closed D12158: efl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m).
Sep 21 2020, 10:53 PM · efl
Hermet accepted D12158: efl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m).
Sep 21 2020, 10:51 PM · efl

Sep 20 2020

Hermet requested changes to D12152: evas vg: check vg changed.

Please check a comment.

Sep 20 2020, 10:24 PM · efl

Sep 17 2020

Hermet closed D12148: evas_outbuf: Fix memory leak..
Sep 17 2020, 1:24 AM · efl
Hermet closed D12147: evas_main: Fix memory leak..
Sep 17 2020, 1:23 AM · efl
Hermet accepted D12147: evas_main: Fix memory leak..
Sep 17 2020, 1:22 AM · efl
Hermet added inline comments to D12147: evas_main: Fix memory leak..
Sep 17 2020, 12:17 AM · efl
Hermet added inline comments to D12147: evas_main: Fix memory leak..
Sep 17 2020, 12:16 AM · efl
Hermet accepted D12148: evas_outbuf: Fix memory leak..

looks fine to me, if there is any proper result of this, it would be nice.

Sep 17 2020, 12:15 AM · efl

Sep 16 2020

Hermet closed D12142: evas vg: check object changed as well 2.
Sep 16 2020, 6:41 PM · efl
Hermet accepted D12142: evas vg: check object changed as well 2.
Sep 16 2020, 6:39 PM · efl

Sep 15 2020

Hermet requested changes to D12142: evas vg: check object changed as well 2.

Please check a comment.

Sep 15 2020, 9:40 PM · efl

Sep 14 2020

Hermet requested changes to D12142: evas vg: check object changed as well 2.

Please check a comment.

Sep 14 2020, 8:17 PM · efl
Hermet closed D12146: vg_load_svg: Support dasharray attribute for stroke.
Sep 14 2020, 8:13 PM · efl
Hermet accepted D12146: vg_load_svg: Support dasharray attribute for stroke.
Sep 14 2020, 8:09 PM · efl

Sep 11 2020

Hermet closed D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Sep 11 2020, 1:06 AM · efl
Hermet accepted D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Sep 11 2020, 1:01 AM · efl

Sep 10 2020

Hermet requested changes to D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

Please check a comment.

Sep 10 2020, 7:53 PM · efl
Hermet closed D12139: vg_load_svg: Add Mask, ClipPath nodees as dummy..
Sep 10 2020, 7:50 PM · efl
Hermet closed D12138: vg_load_svg: Fix missing loader.gradients update.
Sep 10 2020, 7:49 PM · efl
Hermet accepted D12139: vg_load_svg: Add Mask, ClipPath nodees as dummy..
Sep 10 2020, 7:48 PM · efl
Hermet closed D12141: Efl.Canvas.Vg.Object: Fix typo.
Sep 10 2020, 7:48 PM · efl
Hermet accepted D12138: vg_load_svg: Fix missing loader.gradients update.
Sep 10 2020, 7:47 PM · efl
Hermet accepted D12141: Efl.Canvas.Vg.Object: Fix typo.
Sep 10 2020, 7:45 PM · efl

Sep 9 2020

Hermet closed D12137: vg_load_svg: Supports case when only rx or ry is declared.
Sep 9 2020, 11:20 PM · efl
Hermet accepted D12137: vg_load_svg: Supports case when only rx or ry is declared.
Sep 9 2020, 11:19 PM · efl

Sep 3 2020

Hermet closed D12129: vg_load_svg: Fix pointing to wrong parent.
Sep 3 2020, 7:15 PM · efl
Hermet accepted D12129: vg_load_svg: Fix pointing to wrong parent.
Sep 3 2020, 7:14 PM · efl

Sep 2 2020

Hermet closed D12127: SvgLoader: Defs type nodes are not saved in loader's node list..
Sep 2 2020, 2:35 AM · efl
Hermet accepted D12127: SvgLoader: Defs type nodes are not saved in loader's node list..
Sep 2 2020, 2:34 AM · efl

Sep 1 2020

Hermet closed D12120: edje_cc: Fix uninitialized scalar variable.
Sep 1 2020, 5:03 AM · efl
Hermet accepted D12120: edje_cc: Fix uninitialized scalar variable.
Sep 1 2020, 5:01 AM · efl

Aug 27 2020

Hermet closed D12114: efl_ui_image: update orientation immediately.
Aug 27 2020, 10:54 PM · efl

Aug 24 2020

Hermet accepted D12114: efl_ui_image: update orientation immediately.
Aug 24 2020, 3:40 AM · efl

Aug 3 2020

Hermet accepted D12082: edje_embryo: fix memory leak in ALLOC_COPY_DESC.
Aug 3 2020, 11:09 PM · efl

Jul 29 2020

Hermet requested changes to D11929: evas_vg_cache: Add sector_list_get.

This is not a common feature.

Jul 29 2020, 2:41 AM · efl

Jul 16 2020

Hermet closed D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Jul 16 2020, 8:27 PM · efl
Hermet accepted D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Jul 16 2020, 6:06 PM · efl

Jun 24 2020

Hermet closed D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 9:15 PM · efl
Hermet accepted D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 9:12 PM · efl

Jun 22 2020

Hermet closed D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 9:47 PM · efl
Hermet accepted D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 9:45 PM · efl

Jun 19 2020

Hermet closed D11996: elm_scroller: use region of proxy soruce for loop.
Jun 19 2020, 12:09 AM · efl
Hermet accepted D11996: elm_scroller: use region of proxy soruce for loop.
Jun 19 2020, 12:06 AM · efl

Jun 17 2020

Hermet closed D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 5:04 AM · efl
Hermet accepted D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 5:03 AM · efl
Hermet requested changes to D11987: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

how this patch helps to this scenario:

Jun 17 2020, 4:14 AM · efl

Jun 16 2020

Hermet accepted D11985: elementary/perf:remove unnecessary elm_widget_is() check.

good to me.

Jun 16 2020, 10:51 PM · efl
Hermet requested changes to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

Please keep code convention. We prefer simpler way.

Jun 16 2020, 10:45 PM · efl
Hermet added a comment to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

This looks good to me if agrresive optimization helps for better performance.

Jun 16 2020, 10:38 PM · efl
Hermet accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 10:36 PM · efl

Jun 15 2020

Hermet requested changes to D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

this looks wrong to me.
if user need the actual bound of the shape trees from the container, how they make it?

Jun 15 2020, 9:14 PM · efl
Hermet closed D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 9:10 PM · efl
Hermet accepted D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 9:09 PM · efl
Hermet requested changes to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 6:48 PM · efl
Hermet requested changes to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

what happens if r is not initialized at this condition? if (pd->viewbox.w != 0 && pd->viewbox.h !=0)

Jun 15 2020, 5:55 PM · efl

Jun 14 2020

Hermet added a comment to D11926: webp: add version check in configuration time.

do we really need 1.1.0? i have a debian installation my rockpro64 and it compiles and runs fine with 0.6.1. it can load webp images. no symbol errors, crashes or compile errors. i am thinking of dropping this down to 0.6.1 as at least empirically that is good enough (and it'd allow the CI build envs to re-enable webp again). upstream libwebp added WebPAnimDecoder in d39dc8f3cc07f0fffb73def2125ddcdf8073eafcwhich was back in september 2015. 0.6.1 came out nov 2017. so i think this is safe. possibly earlier versions might be fine too. 0.5.0 probably is the baseline for this actually (came out end of 2015 or so), but i can confirm 0.6.1 is seemingly fine. in fact i think i will drop it to 0.5.0 and then see if people complain because the anim api did come out in 0.5.0

Jun 14 2020, 8:35 PM · efl

Jun 12 2020

Hermet closed D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.
Jun 12 2020, 12:15 AM · efl
Hermet accepted D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.
Jun 12 2020, 12:14 AM · efl

Jun 11 2020

Hermet requested changes to D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.

Please check comments.

Jun 11 2020, 11:56 PM · efl
Hermet closed D11966: elm_calendar: Do not pass NULL to function..
Jun 11 2020, 12:34 AM · efl
Hermet accepted D11966: elm_calendar: Do not pass NULL to function..
Jun 11 2020, 12:33 AM · efl
Hermet requested changes to D11967: elc_popup: add null checks for scrollable set/get apis.

Unnecessary check. eo handles invalid objects (including nullptr) internally.

Jun 11 2020, 12:16 AM · efl

Jun 9 2020

Hermet closed D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:41 PM · efl
Hermet accepted D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:38 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

Last comment!

Jun 9 2020, 11:31 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:06 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

Please check comments.

Jun 9 2020, 9:19 PM · efl
Hermet requested changes to D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

I think we can only support Legacy API, not interface.

Jun 9 2020, 6:43 PM · efl

Jun 8 2020

Hermet closed D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..
Jun 8 2020, 6:57 PM · efl
Hermet accepted D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

great!

Jun 8 2020, 6:56 PM · efl
Hermet closed D11928: elementary/example: Fix memory leak in gengrid test.
Jun 8 2020, 4:29 AM · efl
Hermet closed D11930: gengrid: Fix memory leak.
Jun 8 2020, 4:29 AM · efl
Hermet closed D11927: ecore_ipc: Fix memory leak.
Jun 8 2020, 4:28 AM · efl
Hermet accepted D11928: elementary/example: Fix memory leak in gengrid test.
Jun 8 2020, 4:28 AM · efl
Hermet accepted D11927: ecore_ipc: Fix memory leak.
Jun 8 2020, 4:27 AM · efl

Jun 7 2020

Hermet requested changes to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Please check my comments.

Jun 7 2020, 7:10 PM · efl
Hermet closed D11926: webp: add version check in configuration time.
Jun 7 2020, 7:03 PM · efl
Hermet abandoned D11940: eldbus: fix the data size issue..
Jun 7 2020, 7:01 PM · efl
Hermet added a comment to D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.

holding review, I will check it later.

Jun 7 2020, 6:59 PM · efl

Jun 4 2020

Hermet added a reviewer for D11940: eldbus: fix the data size issue.: raster.
Jun 4 2020, 9:56 PM · efl
Hermet updated the summary of D11940: eldbus: fix the data size issue..
Jun 4 2020, 9:56 PM · efl
Hermet added reviewers for D11940: eldbus: fix the data size issue.: herb, kimcinoo, jsuya.
Jun 4 2020, 7:04 PM · efl
Hermet requested review of D11940: eldbus: fix the data size issue..
Jun 4 2020, 6:58 PM · efl
Hermet added a comment to D11932: evas: correctly declare filter_internal as public API.

@kimcinoo Could you please verify this?

Jun 4 2020, 4:18 AM · efl
Hermet added a reviewer for D11932: evas: correctly declare filter_internal as public API: kimcinoo.
Jun 4 2020, 4:18 AM · efl
Hermet added a comment to D11926: webp: add version check in configuration time.

Looks good to me. What is the reason we need version 1.1.0? A specific API we use or a bugfix we need? Would be good to record the reason for the version in the commit message.

Jun 4 2020, 1:19 AM · efl

Jun 3 2020

Hermet closed D11923: build: move static out of none_static.
Jun 3 2020, 6:30 PM · efl
Hermet accepted D11923: build: move static out of none_static.
Jun 3 2020, 6:30 PM · efl
Hermet closed D11925: Efl.Canvas.Vg.Object: Fix backup size.
Jun 3 2020, 6:29 PM · efl