Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (334 w, 5 h)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Yesterday

Hermet closed D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Mon, Jul 15, 5:25 AM · efl
Hermet accepted D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Mon, Jul 15, 5:24 AM · efl
Hermet closed D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Mon, Jul 15, 5:23 AM · efl
Hermet accepted D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Mon, Jul 15, 5:22 AM · efl
Hermet added a comment to D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface..

With its current functionality, I think this class should be named Efl.Ui.Text_Circle and the property should be radius.

Or is this widgwt capable of drawing other shapes? @Hermet? @zmike? @bu5hm4n?

Mon, Jul 15, 3:35 AM · efl
Hermet requested changes to D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

Could you please attach an actual issue example in the code?

Mon, Jul 15, 3:32 AM · efl
Hermet requested changes to D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

Please check a comment.

Mon, Jul 15, 3:01 AM · efl
Hermet accepted D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Mon, Jul 15, 2:40 AM · efl

Sun, Jul 14

Hermet added a reviewer for D9314: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Sun, Jul 14, 10:29 PM · efl
Hermet requested review of D9314: efl_ui_textpath: deprecate elm_textpath_circle_set().
Sun, Jul 14, 10:28 PM · efl
Hermet abandoned D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().
Sun, Jul 14, 10:27 PM · efl
Hermet updated the diff for D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().

added deprecated flag

Sun, Jul 14, 10:26 PM · efl
Hermet abandoned D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().

@kimcinoo Sorry, screwed up the patch by mistake, please see https://phab.enlightenment.org/D9313

Sun, Jul 14, 10:25 PM · efl
Hermet added a reviewer for D9313: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Sun, Jul 14, 10:24 PM · efl
Hermet requested review of D9313: efl_ui_textpath: deprecate elm_textpath_circle_set().
Sun, Jul 14, 10:24 PM · efl
Hermet updated the diff for D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().

moved deprecated api to elm_deprecated.
and added @deprecated tag.

Sun, Jul 14, 10:20 PM · efl
Hermet closed D9311: efl.h: avoid redefinition of typedef 'Efl_Gfx_Path_Command'.
Sun, Jul 14, 10:14 PM · efl
Hermet accepted D9311: efl.h: avoid redefinition of typedef 'Efl_Gfx_Path_Command'.
Sun, Jul 14, 10:09 PM · efl

Thu, Jul 11

Hermet accepted D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Thu, Jul 11, 7:55 PM · efl
Hermet accepted D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Thu, Jul 11, 7:54 PM · efl

Wed, Jul 10

Hermet requested changes to D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

Please check comments.

Wed, Jul 10, 9:44 PM · efl
Hermet requested changes to D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.

Please check comments.

Wed, Jul 10, 8:36 PM · efl
Hermet requested changes to D9220: vg_common_json : Support image data of node.

Please check comments.

Wed, Jul 10, 8:22 PM · efl
Hermet added a reviewer for D9261: efl_ui_textpath: deprecate elm_textpath_circle_set(): committers.
Wed, Jul 10, 4:32 AM · efl
Hermet requested review of D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().
Wed, Jul 10, 4:31 AM · efl
Hermet added reviewers for D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface.: kimcinoo, jsuya.
Wed, Jul 10, 4:30 AM · efl
Hermet added a reviewer for D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface.: committers.
Wed, Jul 10, 4:27 AM · efl
Hermet requested review of D9260: efl_ui_textpath: introduce efl_ui_textpath_circular_set() interface..
Wed, Jul 10, 4:23 AM · efl

Tue, Jul 9

Hermet requested changes to D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Tue, Jul 9, 12:56 AM · efl
Hermet accepted D9103: evas: add support for .9.png file to PNG loader..
Tue, Jul 9, 12:55 AM · efl

Mon, Jul 8

Hermet closed D9235: Ector.Renderer: Prevent too many unref..
Mon, Jul 8, 11:47 PM · efl
Hermet accepted D9235: Ector.Renderer: Prevent too many unref..

Though it's workaround, i think it's better than the current.

Mon, Jul 8, 11:46 PM · efl
Hermet accepted D9101: evas: break Image_Loader API to allow for getting property from the data field of an image..
Mon, Jul 8, 10:52 PM · efl
Hermet accepted D9096: evas: add support for stretchable region..

@cedric There were not any issues, Tizen has supported android 9 patch since 2012. (even we couldn't support margin area)

Mon, Jul 8, 10:48 PM · efl
Hermet closed D9216: vg_common_json: Always set the alpha color of the container..
Mon, Jul 8, 10:22 PM · efl
Hermet accepted D9216: vg_common_json: Always set the alpha color of the container..
Mon, Jul 8, 10:21 PM · efl
Hermet closed D9217: efl_gfx_shape: Stroke color use a premultiplied color..
Mon, Jul 8, 10:21 PM · efl
Hermet accepted D9217: efl_gfx_shape: Stroke color use a premultiplied color..
Mon, Jul 8, 10:20 PM · efl
Hermet requested changes to D9234: meson: Add an meson option 'elm' to enable/disable elementary in efl.

@smohanty any special purpose for this? efl is going to integrate one unified set.

Mon, Jul 8, 10:20 PM · efl
Hermet requested changes to D9235: Ector.Renderer: Prevent too many unref..

Maybe we can replace xref with just efl_ref()

Mon, Jul 8, 10:16 PM · efl
Hermet accepted D9235: Ector.Renderer: Prevent too many unref..
Mon, Jul 8, 10:12 PM · efl

Mon, Jul 1

Hermet requested changes to D9203: ector_software_rasterizer: Use a premultiplied color..

We'd rather put logs in api so that user know which api they misused.

Mon, Jul 1, 5:24 AM · efl

Thu, Jun 27

Hermet requested changes to D9183: evas_render: add restacked mapped obj to redraws rect.

Does it need to redraw children of mapped object? or below object of the map object?

Thu, Jun 27, 9:47 PM · efl

Wed, Jun 26

Hermet added a comment to D9096: evas: add support for stretchable region..

Do we really need to make it compatible with Android fully or just only for major usage?
Yet I've never seen practical images, that containing multiple stretchable regions, used.
And I'm worrying it just increase complexity in several points unnecessarily, maybe just 9 case is enough.

Wed, Jun 26, 3:33 AM · efl
Hermet accepted D9093: evas: add an API to know where inside an object content can be layout over..
Wed, Jun 26, 3:22 AM · efl

Tue, Jun 25

Hermet accepted D9097: evas: take stretch region into account when content region is requested..
Tue, Jun 25, 7:49 PM · efl
Hermet accepted D9098: evas: improve test to evaluate stretch region effect on content region..
Tue, Jun 25, 7:46 PM · efl
Hermet requested changes to D9101: evas: break Image_Loader API to allow for getting property from the data field of an image..

Please check my comment.

Tue, Jun 25, 7:45 PM · efl
Hermet added a comment to D9103: evas: add support for .9.png file to PNG loader..

Worring about how much this would decrease the loading performance than original one practically.
We cannot recommend use this 9 patch feature if it's worse than others...

Tue, Jun 25, 7:41 PM · efl
Hermet accepted D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Tue, Jun 25, 7:39 PM · efl
Hermet added a comment to D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..

As @zmike mentioned, It's hard to catch the point at this patch, what is exactly issue here why this handling is required....

Tue, Jun 25, 7:03 PM · efl
Hermet accepted D9105: evas: add a test for loading Android 9patch file..
Tue, Jun 25, 6:59 PM · efl
Hermet closed D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 5:49 AM · efl
Hermet accepted D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 5:47 AM · efl
Hermet requested changes to D9172: eina: remove unused function body.

There are a lot of calls, is it wrong?

Tue, Jun 25, 5:35 AM · efl
Hermet accepted D9095: evas: add test for the new efl_gfx_image_content_region_get API..
Tue, Jun 25, 12:40 AM · efl
Hermet requested changes to D9155: evas_common: use memcpy to copy pixel buffer.

this c implmentation could be compared with simd implementation.
So, hjust leave it as it does, even memcpy() is not better than current one.

Tue, Jun 25, 12:36 AM · efl

Fri, Jun 21

Hermet added a comment to D9093: evas: add an API to know where inside an object content can be layout over..

Fundamentally the behavior is nothing different with border_get()...
Later, will you return the actual pixel data region? or just geometry region?

Fri, Jun 21, 2:14 AM · efl
Hermet closed D8944: evas vector: add a lottie animation example..
Fri, Jun 21, 1:40 AM · efl
Hermet closed D8941: evas vector: support lottie animation as using json loader..
Fri, Jun 21, 1:36 AM · efl
Hermet closed D8940: evas vector: support json loader for rlottie integration..
Fri, Jun 21, 1:36 AM · efl

Thu, Jun 20

Hermet closed D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Thu, Jun 20, 12:07 AM · efl
Hermet accepted D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Thu, Jun 20, 12:06 AM · efl

Tue, Jun 18

Hermet closed D9085: evas filter: make curve work for every.
Tue, Jun 18, 6:29 PM · efl
Hermet added a comment to D9085: evas filter: make curve work for every.

Maybe I could change furthermore.

Tue, Jun 18, 6:28 PM · efl
Hermet accepted D9085: evas filter: make curve work for every.
Tue, Jun 18, 6:27 PM · efl

Mon, Jun 17

Hermet added a comment to D9085: evas filter: make curve work for every.

Honestly I do not get what "Currently growbuf == outbuf is out of date." is. Do you mean that the outbuf is out of date, because it is same with growbuf? And is that for the first case that the outbuf is not dirty?

(1) If the condition "(inbuf != outbuf) && out->dirty" is false, then " growbuf == outbuf" and it will work as below.

blur_add(inbuf, growbuf(outbuf)) -> curve_add(growbuf(outbuf), tmp) -> blend(tmp, outbuf)
(i.e.) inbuf -> [Blur] -> growbuf(outbuf) -> [Curve] -> tmp -> [Blend] -> outbuf

(2) If the condition "(inbuf != outbuf) && out->dirty" is true, then " growbuf == tmp" and it will work as below.

blur_add(inbuf, growbuf(tmp)) -> curve_add(growbuf(tmp), tmp2) -> blend(tmp2, outbuf)
(i.e.) inbuf -> [Blur] -> growbuf(tmp) -> [Curve] -> tmp2 -> [Blend] -> outbuf

Without this patch each step could be following.

inbuf -> [Blur] -> growbuf(outbuf) -> [Curve] -> growbuf(outbuf) -> [Blend] -> outbuf
inbuf -> [Blur] -> growbuf(tmp) -> [Curve] ->growbuf(tmp) -> [Blend] -> outbuf

Then can we use the outbuf in these cases?

Mon, Jun 17, 10:06 PM · efl

Jun 14 2019

Hermet requested changes to D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Please check a comment.

Jun 14 2019, 12:57 AM · efl

Jun 13 2019

Hermet requested changes to D9085: evas filter: make curve work for every.

Please check a comment.

Jun 13 2019, 11:38 PM · efl
Hermet requested changes to D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Please check a comment.

Jun 13 2019, 11:10 PM · efl

Jun 12 2019

Hermet closed D9083: efl_canvas_vg_container: Initialize alpha color.
Jun 12 2019, 9:55 PM · efl
Hermet accepted D9083: efl_canvas_vg_container: Initialize alpha color.

And this doesn't initialize alpha but default color.

Jun 12 2019, 9:55 PM · efl
Hermet added a comment to D9085: evas filter: make curve work for every.

And It's very suspicious at this condition.

Jun 12 2019, 9:37 PM · efl
Hermet requested changes to D9085: evas filter: make curve work for every.

Please check my comment.

Jun 12 2019, 9:34 PM · efl
Hermet added a comment to D9085: evas filter: make curve work for every.

While reading evas_filter_command_grow_add(), it could generate temporary buffer in a specific condition,

Jun 12 2019, 9:34 PM · efl
Hermet added a comment to D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Please check a comment and give me your opinion.

Jun 12 2019, 7:30 PM · efl
Hermet requested changes to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 12 2019, 7:30 PM · efl
Hermet requested changes to D9083: efl_canvas_vg_container: Initialize alpha color.

Please check a comment.

Jun 12 2019, 7:04 PM · efl

Jun 11 2019

Hermet requested changes to D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Please check comments.

Jun 11 2019, 3:24 AM · efl
Hermet closed D9081: vg_common_json: Set container's alpha color.
Jun 11 2019, 3:05 AM · efl
Hermet accepted D9081: vg_common_json: Set container's alpha color.
Jun 11 2019, 2:59 AM · efl
Hermet requested changes to D9081: vg_common_json: Set container's alpha color.

Please check comments.

Jun 11 2019, 1:38 AM · efl

Jun 2 2019

Hermet accepted D8918: gl_generic: directly copy existing image when changing orientation.
Jun 2 2019, 11:25 PM · efl: rendering

May 29 2019

Hermet closed D8852: evas: enable setting any object as a clipper.
May 29 2019, 9:00 PM · efl
Hermet accepted D8852: evas: enable setting any object as a clipper.
May 29 2019, 9:00 PM · efl

May 28 2019

Hermet updated the summary of D8940: evas vector: support json loader for rlottie integration..
May 28 2019, 3:51 AM · efl
Hermet updated the summary of D8940: evas vector: support json loader for rlottie integration..
May 28 2019, 3:51 AM · efl
Hermet updated the diff for D8940: evas vector: support json loader for rlottie integration..

updated as reviewers' comment.

May 28 2019, 3:48 AM · efl

May 26 2019

Hermet closed D9025: ecore_evas win32: fix warning reported by clang.
May 26 2019, 11:58 PM · efl
Hermet accepted D9025: ecore_evas win32: fix warning reported by clang.
May 26 2019, 11:57 PM · efl
Hermet closed D9024: Evas gesture: do not use abs when dealing with double, use fabs instead.
May 26 2019, 11:56 PM · efl
Hermet accepted D9024: Evas gesture: do not use abs when dealing with double, use fabs instead.
May 26 2019, 11:55 PM · efl

May 23 2019

Hermet updated the diff for D8944: evas vector: add a lottie animation example..

update code.

May 23 2019, 4:56 AM · efl
Hermet requested changes to D8918: gl_generic: directly copy existing image when changing orientation.

Please check a comment.

May 23 2019, 4:48 AM · efl: rendering
Hermet added a comment to D8918: gl_generic: directly copy existing image when changing orientation.

Actually, Evas_GL_Image could be shared among images as it's optimal, what makes texture loading fails?

May 23 2019, 4:47 AM · efl: rendering
Hermet closed D8939: Emotion gst1 module: fix "empty if statement" warning.
May 23 2019, 4:24 AM · efl
Hermet closed D8938: Emotion gst1 module: remove whitespaces.
May 23 2019, 4:24 AM · efl
Hermet accepted D8939: Emotion gst1 module: fix "empty if statement" warning.
May 23 2019, 4:16 AM · efl
Hermet accepted D8938: Emotion gst1 module: remove whitespaces.
May 23 2019, 4:14 AM · efl
Hermet closed D8930: Efl.Ui.Textpath: fix a size problem.
May 23 2019, 4:11 AM · efl