Hermet (Hermet Park)
Engineering

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (286 w, 3 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Yesterday

Hermet requested changes to D6787: efl/timer: correctly handle timer freeze during construction.

Could u please check a comment?

Thu, Aug 16, 10:27 PM · efl: main loop
Hermet requested changes to D6808: elm_bg : Remove duplicate color_set.

Could you please check my review?

Thu, Aug 16, 10:13 PM · efl
Hermet added a comment to D6830: efl/layout: check if object is finalized before internally triggering sizing_eval.

impossible this?

Thu, Aug 16, 10:01 PM · efl: widgets
Hermet added reviewers for D6856: ecore wayland: fix a regression bug of wayland_transparent_get().: ManMower, devilhorns.
Thu, Aug 16, 9:56 PM · efl
Hermet requested review of D6856: ecore wayland: fix a regression bug of wayland_transparent_get()..
Thu, Aug 16, 9:55 PM · efl
Hermet updated the diff for D6855: efl_ui_image: apply some image options as retained way..

update load_size_set;

Thu, Aug 16, 8:16 PM · efl
Hermet added a reviewer for D6855: efl_ui_image: apply some image options as retained way.: committers.
Thu, Aug 16, 8:09 PM · efl
Hermet requested review of D6855: efl_ui_image: apply some image options as retained way..
Thu, Aug 16, 8:08 PM · efl
Hermet added a comment to D6849: evas vg: prevent invalid access..

Destructor doesn't mean evas_object_free();
All will be freed after evas_object_free() and that would be called after delete_me == 2;

Thu, Aug 16, 7:21 PM · efl
Hermet added a reviewer for D6849: evas vg: prevent invalid access.: committers.
Thu, Aug 16, 12:34 AM · efl
Hermet requested review of D6849: evas vg: prevent invalid access..
Thu, Aug 16, 12:34 AM · efl

Mon, Aug 13

Hermet added a reviewer for D6818: evas gl: fix missing map texture target.: committers.
Mon, Aug 13, 12:45 AM · efl
Hermet updated the diff for D6818: evas gl: fix missing map texture target..

updated commit msg.

Mon, Aug 13, 12:45 AM · efl
Hermet requested review of D6818: evas gl: fix missing map texture target..
Mon, Aug 13, 12:34 AM · efl

Sun, Aug 12

Hermet claimed T7236: elm_naviframe_content_preserve_on_pop_set seems to not work.
Sun, Aug 12, 9:56 PM · efl (efl-1.21), efl: widgets, regression, Bug Report

Thu, Aug 9

Hermet added a reviewer for D6807: evas gl_common: code refactoring.: committers.
Thu, Aug 9, 9:59 PM · efl
Hermet requested review of D6807: evas gl_common: code refactoring..
Thu, Aug 9, 9:59 PM · efl
Hermet requested changes to D6796: elm_bg : Add color_set call to class chain internally for legacy color_set..
Thu, Aug 9, 7:07 PM · regression, efl: widgets
Hermet closed D6799: elm_image : Remove unnecessary test about image.
Thu, Aug 9, 7:03 PM · efl
Hermet accepted D6799: elm_image : Remove unnecessary test about image.
Thu, Aug 9, 7:01 PM · efl
Hermet added a comment to D6804: evas_object_line: avoid using NULL parent..

there is MAGIC_CHECK() already. adding this additional one is too much. I think we can remove MAGIC_CHECK there.

Thu, Aug 9, 7:00 PM · efl

Wed, Aug 8

Hermet added a comment to D6777: gl_common: do not draw rect without texture.

@raster let's forget preloading. Acutally, !tex shouldn't be happened, but let's assume the exception case. Developers will be more embarrassing If something solid color rectangle showed up. Because they more likely to think some obstacle objects(i,e rectangle eo) may be onto the image. Only few core developers who exactly know this exceptional handling in this backend engine could understand but not others. Even I firstly guess somewhere dangling white rectangle, clipper or image objects were there but not this (!tex) case. More than this visual, ERR message is more clear.

Wed, Aug 8, 5:58 AM · efl
Hermet added a member for reviewers: Hermet.
Wed, Aug 8, 1:01 AM
Hermet added a watcher for reviewers: Hermet.
Wed, Aug 8, 1:01 AM
Hermet added a comment to T7260: Porting Pixman Neon backend to EFL..

Let's assume Neon is stable, I think Neon in EFL has been used many years.
I could bet on this idea *IF* average performance of using Pixman is better than our pure efl rasterizer.

Wed, Aug 8, 12:33 AM
Hermet closed D6772: elm_map: remove unreasonable efl_super call.
Wed, Aug 8, 12:11 AM · efl
Hermet accepted D6772: elm_map: remove unreasonable efl_super call.
Wed, Aug 8, 12:10 AM · efl
Hermet closed D6771: elm_map: implement zoom_mode_get, zoom_level_get.
Wed, Aug 8, 12:05 AM · efl
Hermet accepted D6771: elm_map: implement zoom_mode_get, zoom_level_get.
Wed, Aug 8, 12:05 AM · efl
Hermet closed D6739: evas image: fix screen flickering issue at partial + image preloading.
Wed, Aug 8, 12:01 AM · efl
Hermet closed D6774: efl_ui/image_zoomable: fix internal eina file refcounting.
Wed, Aug 8, 12:01 AM · efl: widgets

Tue, Aug 7

Hermet added a reviewer for D6762: tests/naviframe: add test to verify preserve_on_pop functionality: Jaehyun_Cho.
Tue, Aug 7, 11:57 PM · Restricted Project, efl: widgets
Hermet accepted D6774: efl_ui/image_zoomable: fix internal eina file refcounting.
Tue, Aug 7, 11:55 PM · efl: widgets
Hermet closed D6725: elementary image: don't calc size using empty ones..
Tue, Aug 7, 11:52 PM · efl
Hermet updated the diff for D6725: elementary image: don't calc size using empty ones..

updated commit msg.

Tue, Aug 7, 11:51 PM · efl
Hermet updated the diff for D6725: elementary image: don't calc size using empty ones..

rebase

Tue, Aug 7, 10:00 PM · efl
Hermet closed D6776: eina: Add doxygen in/out tags for rectangle.
Tue, Aug 7, 9:53 PM · efl
Hermet closed D6778: evas_image: do not render while preloading.
Tue, Aug 7, 9:52 PM · efl
Hermet accepted D6776: eina: Add doxygen in/out tags for rectangle.
Tue, Aug 7, 9:52 PM · efl
Hermet accepted D6778: evas_image: do not render while preloading.
Tue, Aug 7, 9:47 PM · efl
Hermet added a comment to D6777: gl_common: do not draw rect without texture.

@raster, This situation is in the image preloading. Both are abnormal situation though but IMHO, engine should not do this unexpected visual result. If unexpected situation(no texture) comes, it's better to leave to users fill there with what color or what bg images (of the this texture content). Apps don't allow this embarrasing rectangle come out. For debuging, we can just print message there.

Tue, Aug 7, 9:46 PM · efl
Hermet added a comment to D6739: evas image: fix screen flickering issue at partial + image preloading.
In D6739#116442, @zmike wrote:

Hm I think @kimcinoo is saying that with this code it appears to be possible that both preloading and preloaded are true. This appears to be the case if an image is preloaded (evas_object_inform_call_image_preloaded) and then another preload is set (_evas_object_image_preloading_set) before pre-render is called. Can you verify this case?

It doesn't affect anywhere though because preloading is prior to preloaded. If preloading is true, render_pre() just exits the rendering whatever preloaded is true or not,

Tue, Aug 7, 3:16 AM · efl

Mon, Aug 6

Hermet closed D6752: elm_genlist: remove unused function.
Mon, Aug 6, 12:39 AM · efl
Hermet added a comment to D6751: eina_vpath: specilice the eina_vpath headers.

beta but since 1.21?

Mon, Aug 6, 12:39 AM · efl
Hermet accepted D6752: elm_genlist: remove unused function.
Mon, Aug 6, 12:37 AM · efl
Hermet closed D6753: elm_genlist: fix ghost objects from the genlist cache.
Mon, Aug 6, 12:36 AM · efl
Hermet accepted D6750: tests/genlist: add full test for expanding and contracting a genlist item.
Mon, Aug 6, 12:27 AM · efl: widgets, Restricted Project
Hermet closed D6749: tests/elm: when using buffer engine, clamp render and edje timing to 0.05s.
Mon, Aug 6, 12:27 AM · Restricted Project
Hermet accepted D6749: tests/elm: when using buffer engine, clamp render and edje timing to 0.05s.
Mon, Aug 6, 12:26 AM · Restricted Project
Hermet closed D6740: test/evas: add to check smart class overriding.
Mon, Aug 6, 12:22 AM · efl
Hermet accepted D6740: test/evas: add to check smart class overriding.
Mon, Aug 6, 12:22 AM · efl

Sun, Aug 5

Hermet added a comment to D6739: evas image: fix screen flickering issue at partial + image preloading.

Please see evas_object_inform_call_image_preloaded.

It calls
(1) _evas_image_load_post_update -> preloaded: TRUE, preloading: TRUE

it does _evas_image_load_post_update -> preloaded: TRUE, preloading: FALSE;

(2) _evas_object_image_preloading_set -> preloaded: TRUE, preloading: FALSE

True but preloaded is only available when preloading is false.

IMO above order need to be changed in 'preload*'s point of view.
i.e. whenever the 'preloaded' is set to TRUE, the 'preloading' should be set to FALSE.

Currently it does.

Sun, Aug 5, 8:22 PM · efl

Thu, Aug 2

Hermet added a reviewer for D6739: evas image: fix screen flickering issue at partial + image preloading: committers.
Thu, Aug 2, 11:00 PM · efl
Hermet added a reviewer for D6738: evas image: code refactoring.: committers.
Thu, Aug 2, 10:42 PM · efl
Hermet added a comment to D6737: elm_genlist: fix item registration by correct realization.

Please add proper reviewers; there is a genlist maintainer.

Thu, Aug 2, 10:24 PM · efl
Hermet added a comment to D6725: elementary image: don't calc size using empty ones..
In D6725#115817, @zmike wrote:

Do you have an example case for this or is it just when no file is set?

Thu, Aug 2, 10:21 PM · efl
Hermet added a reviewer for D6727: elementary bg: fix to guarantee compatibility.: committers.
Thu, Aug 2, 1:34 AM · efl
Hermet added a reviewer for D6726: elementary image: apply lazy calculation and guarantee retained method.: committers.
Thu, Aug 2, 1:22 AM · efl

Wed, Aug 1

Hermet updated the diff for D6725: elementary image: don't calc size using empty ones..

fix coding convention.

Wed, Aug 1, 9:06 PM · efl
Hermet updated the diff for D6725: elementary image: don't calc size using empty ones..

elementary image: don't calc size using empty ones.

Wed, Aug 1, 9:04 PM · efl
Hermet abandoned D6693: evas sdl: don't make confusing, we only use one-indexed egl handles..
Wed, Aug 1, 8:20 PM · efl
Hermet added a comment to D6693: evas sdl: don't make confusing, we only use one-indexed egl handles..
In D6693#115148, @zmike wrote:

Is this even used?

Wed, Aug 1, 8:19 PM · efl
Hermet edited the content of Maintainers Reviewers.
Wed, Aug 1, 8:11 PM · efl
Hermet added a reviewer for D6725: elementary image: don't calc size using empty ones.: committers.
Wed, Aug 1, 8:07 PM · efl

Tue, Jul 31

Hermet added a member for efl: release team: Hermet.
Tue, Jul 31, 10:25 PM
Hermet requested changes to D6638: elementary: Check for valid resize obj before calling size_hint_combined_min_get.

We can't accept this situation. resize_obj must be valid if obj were still active. It a failure case of synchronousing both 2 objects. We must deep look and fix root cause.

Tue, Jul 31, 9:02 PM · efl
Hermet added a comment to D6694: edje: add back function prototype for edje_object_color_class_description_get.

Btw, color class description.... just curious which case we can utilize this functionality?? (except edje_edit)

Tue, Jul 31, 8:50 PM · efl
Hermet accepted D6694: edje: add back function prototype for edje_object_color_class_description_get.
Tue, Jul 31, 8:45 PM · efl
Hermet added a reviewer for D6704: elementary: Check for valid focus manager before starting do loop: YOhoho.
Tue, Jul 31, 8:43 PM · Restricted Project
Hermet closed D6671: elm_test: fix -to arg parsing.

This fix actually submitted by @raster

Tue, Jul 31, 8:42 PM · efl: widgets
Hermet accepted D6671: elm_test: fix -to arg parsing.
Tue, Jul 31, 8:40 PM · efl: widgets
Hermet added a comment to D6643: scroller: refactory a momentum scroll animator.

will review/push after 1.21,

Tue, Jul 31, 8:37 PM · DO NOT MERGE, efl
Hermet requested changes to D6702: elementary: Check for valid object before calling efl internal functions.

If here efl_invalidation is neccesary, It' s really serious at efl. We can't add all this kind of stupid exceptional handling.
It's hard to expect when we need to check efl_invalidated_get() in function. Even right moment. Whatever this may fix some errors, we should not do this.

Tue, Jul 31, 8:34 PM · efl
Hermet added a comment to D6707: elementary: efl_ui_view_list cleanup.

@SanghyeonLee Could u please review this patch?

Tue, Jul 31, 8:29 PM · efl
Hermet added a reviewer for D6707: elementary: efl_ui_view_list cleanup: SanghyeonLee.
Tue, Jul 31, 8:28 PM · efl
Hermet added a comment to D6700: ecore: fix that timers are not called in the order they were registered..

@zmike Could u please more clear this sentence? "So I think the patch should be changed to just copy in the second part of the function."

Tue, Jul 31, 8:23 PM · Restricted Project

Sun, Jul 29

Hermet added a reviewer for D6693: evas sdl: don't make confusing, we only use one-indexed egl handles.: committers.
Sun, Jul 29, 10:24 PM · efl

Thu, Jul 26

Hermet closed T7026: evas_init does not handle all internal failures, a subtask of T7024: libraries do not handle all failure cases during init, as Resolved.
Thu, Jul 26, 5:45 AM · Testing, Restricted Project, Restricted Project
Hermet closed T7026: evas_init does not handle all internal failures as Resolved by committing rEFLbe33c835ac30: evas: handle all failure cases with error messages in evas_init.
Thu, Jul 26, 5:45 AM · efl: rendering, Restricted Project, Restricted Project
Hermet closed D6677: evas: handle all failure cases with error messages in evas_init.
Thu, Jul 26, 5:45 AM · efl
Hermet accepted D6677: evas: handle all failure cases with error messages in evas_init.
Thu, Jul 26, 5:43 AM · efl
Hermet closed T7025: edje_init does not handle all internal failures as Resolved by committing rEFL67f50eb5d6f3: edje: handle all failure cases with error messages in init.
Thu, Jul 26, 5:30 AM · efl: layout engine, Restricted Project, Restricted Project
Hermet closed T7025: edje_init does not handle all internal failures, a subtask of T7024: libraries do not handle all failure cases during init, as Resolved.
Thu, Jul 26, 5:30 AM · Testing, Restricted Project, Restricted Project
Hermet closed D6678: edje: handle all failure cases with error messages in init.
Thu, Jul 26, 5:30 AM · efl
Hermet accepted D6678: edje: handle all failure cases with error messages in init.
Thu, Jul 26, 5:28 AM · efl
Hermet closed T7021: elm_init does not handle internal failure as Resolved by committing rEFL69fdec545e52: elm: handle all failure cases with error messages in init.
Thu, Jul 26, 5:23 AM · Restricted Project, Restricted Project, Restricted Project, efl: widgets
Hermet closed T7021: elm_init does not handle internal failure, a subtask of T7024: libraries do not handle all failure cases during init, as Resolved.
Thu, Jul 26, 5:23 AM · Testing, Restricted Project, Restricted Project
Hermet closed D6679: elm: handle all failure cases with error messages in init.
Thu, Jul 26, 5:23 AM · efl
Hermet accepted D6679: elm: handle all failure cases with error messages in init.
Thu, Jul 26, 5:12 AM · efl
Hermet added a comment to D6680: efl_ui_spin_button: Addded direction feature..

let go of this after 1.21 release.

Thu, Jul 26, 5:09 AM · efl
Hermet requested changes to D6687: edje/evas: init .json file support feature.

We can't apply this yet unless there is json load.
Just keep it here and see.

Thu, Jul 26, 5:07 AM · efl
Hermet closed D6685: eina: Add doxygen in/out tags for hash.
Thu, Jul 26, 4:35 AM · efl
Hermet closed D6686: eina: Add doxygen in/out tags for inlist and iterator.
Thu, Jul 26, 4:05 AM · efl

Tue, Jul 24

Hermet added a reviewer for D6674: evas canvas: fix not to trigger unnecessary events.: committers.
Tue, Jul 24, 2:59 AM · efl

Mon, Jul 23

Hermet added a reviewer for D6647: efl_ui_win: reset first_draw flag if window is resized while hidden: eagleeye.
Mon, Jul 23, 7:07 PM · efl: widgets
Hermet added a reviewer for D6646: efl_ui_win: show internal objects again on show if first_draw flag is set: eagleeye.
Mon, Jul 23, 7:03 PM · efl: widgets
Hermet accepted D6669: elm/list: remove max size setting on item contents.
Mon, Jul 23, 7:02 PM · efl: widgets
Hermet added reviewers for D6650: evas clip: more strict comparison.: zmike, committers.
Mon, Jul 23, 3:57 AM · efl

Sun, Jul 22

Hermet abandoned D6598: efl_ui_calendar: Check for valid spin timer before setting interval.

the regarded patch has been submitted.

Sun, Jul 22, 11:53 PM · efl
Hermet commandeered D6598: efl_ui_calendar: Check for valid spin timer before setting interval.
Sun, Jul 22, 11:52 PM · efl