Page MenuHomePhabricator

Hermet (Hermet Park)
Engineering

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 19 2013, 12:12 AM (343 w, 1 d)
Availability
Available

Email: hermetpark@gmail.com
Blog: hermet.pe.kr

Recent Activity

Today

Hermet added a comment to T8119: Evas segfaults on recent builds of x86.

@raster oh, didn't noticed this ticket. firstly that logic must be only working when the object enables anti_alias + smooth.. did you intend this? because normally we don't enable anti_alias option for evas objects individually,

Wed, Sep 18, 12:36 AM · efl (efl-1.23)

Yesterday

Hermet closed D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Tue, Sep 17, 5:19 AM · efl
Hermet accepted D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Tue, Sep 17, 5:18 AM · efl

Tue, Sep 10

Hermet accepted D9740: evas_vg_cache: Hashkey in cache uses evas.
Tue, Sep 10, 4:04 AM · efl
Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check one more comment.

Tue, Sep 10, 3:02 AM · efl

Mon, Sep 9

Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check a comment.

Mon, Sep 9, 10:46 PM · efl

Thu, Sep 5

Hermet added a comment to D9740: evas_vg_cache: Hashkey in cache uses evas.

Please check a comment.

Thu, Sep 5, 7:19 PM · efl

Wed, Sep 4

Hermet closed D9834: use eina_strndup() instead of the GNU extension strndup(). Fix also a warning with CreateFile().
Wed, Sep 4, 12:19 AM
Hermet accepted D9834: use eina_strndup() instead of the GNU extension strndup(). Fix also a warning with CreateFile().
Wed, Sep 4, 12:06 AM

Tue, Sep 3

Hermet closed D9833: vg_common_svg : Initialize "display" attribute.
Tue, Sep 3, 8:09 PM · efl
Hermet accepted D9833: vg_common_svg : Initialize "display" attribute.
Tue, Sep 3, 8:08 PM · efl
Hermet closed D9817: freetype: Prevent lose of data when fixed point divide calculation..
Tue, Sep 3, 8:07 PM · efl
Hermet accepted D9817: freetype: Prevent lose of data when fixed point divide calculation..
Tue, Sep 3, 8:06 PM · efl

Fri, Aug 30

Hermet added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
In D9794#182033, @tasn wrote:

I don't get this change. Readability is subjective and this doesn't read any more readable to me, and it's 20 lines longer (not that it's the only parameter, but still).
It's also hard to follow when you changed a few unrelated things in one commit (or is it just phab being bad?).

Fri, Aug 30, 3:11 AM · efl
Hermet accepted D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..
Fri, Aug 30, 2:56 AM · efl
Hermet added a comment to D9794: eo/vtable: refactor vtable handling code for easy maintenance and readability..

Overall looks fine to me but leave one question just in case.

Fri, Aug 30, 1:33 AM · efl

Wed, Aug 28

Hermet closed D9776: edje/style/optimization: Enable lazy computaion of styles..
Wed, Aug 28, 10:32 PM · efl
Hermet accepted D9776: edje/style/optimization: Enable lazy computaion of styles..
Wed, Aug 28, 10:32 PM · efl
Hermet requested changes to D9776: edje/style/optimization: Enable lazy computaion of styles..

Please check a comment.

Wed, Aug 28, 8:05 PM · efl
Hermet closed D9764: edje: refactor _edje_object_file_set_internal() part 2..
Wed, Aug 28, 12:24 AM · efl
Hermet accepted D9764: edje: refactor _edje_object_file_set_internal() part 2..
Wed, Aug 28, 12:22 AM · efl

Tue, Aug 27

Hermet closed D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..
Tue, Aug 27, 10:42 PM · efl
Hermet accepted D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..
Tue, Aug 27, 10:08 PM · efl
Hermet requested changes to D9724: efl_canvas_vg_object: Support property change feature.
Tue, Aug 27, 10:08 PM · efl
Hermet closed D9763: edje/style: remove dead code..
Tue, Aug 27, 10:07 PM · efl
Hermet accepted D9763: edje/style: remove dead code..
Tue, Aug 27, 10:06 PM · efl
Hermet added a comment to D9724: efl_canvas_vg_object: Support property change feature.

Firstly,
we should not open these property apis.
These should be internal apis since there is no point to open them. Nobody could use this except efl_ui_animation_view.
So we could use some tricky method to communicate with efl_ui_animation_view.
I think we can efl_data_set()/get() to pass the data i.e.

Tue, Aug 27, 9:42 PM · efl
Hermet added a comment to D9740: evas_vg_cache: Hashkey in cache uses evas.

As the current situation, separate vector objects could share a resource properly, there is not point to use vg object as the hash key.
Rather than this, current issue point is more like to canvases.

Tue, Aug 27, 9:29 PM · efl
Hermet closed D9761: edje: refactor _edje_object_file_set_internal() function.
Tue, Aug 27, 9:25 PM · efl
Hermet added a comment to D9719: edje/text_class: Add test case for text_class feature.

updated a comment.

Tue, Aug 27, 9:21 PM · efl
Hermet accepted D9761: edje: refactor _edje_object_file_set_internal() function.
Tue, Aug 27, 9:18 PM · efl
Hermet added a comment to D9743: efl_ui_animation_view: Support property change feature.

interface Efl_Ui_Animation_View_Property;
class Efl_Ui_Animation_View_Lottie_Property implements Efl_Ui_Animation_View_Property;

Tue, Aug 27, 9:12 PM · efl
Hermet requested changes to D9740: evas_vg_cache: Hashkey in cache uses evas.

I couldn't see any issue even though playing same resource 50 numbers.
Could you please attach sample code for this?

Tue, Aug 27, 7:05 PM · efl
Hermet requested changes to D9743: efl_ui_animation_view: Support property change feature.

After considered to support property overriding,
I think we could add a separate interface i.e. efl_ui_animation_view_property
then extend per properties such as efl_ui_animation_view_property_color, efl_ui_animation_view_property_transform, efl_ui_animation_view_property_stroke, etc.
If so our efl_ui_animation_view could only suggest efl_ui_animation_view_property_override(Eo *anim_view, Efl_Ui_Animation_View_Property *prop);

Tue, Aug 27, 6:58 PM · efl
Hermet closed D9748: eina_vpath: add null checking logic on vpath_resolve api.
Tue, Aug 27, 4:25 AM · efl
Hermet accepted D9748: eina_vpath: add null checking logic on vpath_resolve api.
Tue, Aug 27, 4:25 AM · efl
Hermet closed D9750: eina_list: fix to check a null argument.
Tue, Aug 27, 4:24 AM · efl
Hermet accepted D9750: eina_list: fix to check a null argument.
Tue, Aug 27, 4:22 AM · efl
Hermet accepted D9748: eina_vpath: add null checking logic on vpath_resolve api.
Tue, Aug 27, 4:20 AM · efl
Hermet closed D9751: evas events: fix corrupted mouse events behavior on mapped object..
Tue, Aug 27, 3:51 AM · efl
Hermet added a reviewer for D9751: evas events: fix corrupted mouse events behavior on mapped object.: committers.
Tue, Aug 27, 1:29 AM · efl
Hermet requested review of D9751: evas events: fix corrupted mouse events behavior on mapped object..
Tue, Aug 27, 1:28 AM · efl

Sun, Aug 25

Hermet requested changes to D9734: eina/array: added eina_array_find() api to eina_array..

Please check typos.

Sun, Aug 25, 11:10 PM · efl
Hermet added a comment to D9719: edje/text_class: Add test case for text_class feature.

+ you might need to carefully check the overriding text class feature whether it's broken or not.
Launch elementary_config => Font
see API: elm_config_font_overlay_set()

Sun, Aug 25, 10:39 PM · efl
Hermet requested changes to D9719: edje/text_class: Add test case for text_class feature.

I think getting part objects to check properties is not proper case as the test case.

Sun, Aug 25, 10:36 PM · efl
Hermet closed D9641: edje/style: optimize style_update function..
Sun, Aug 25, 10:22 PM · efl
Hermet accepted D9641: edje/style: optimize style_update function..
Sun, Aug 25, 10:22 PM · efl
Hermet requested changes to D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..

It looks unnecessary, do we need to define one more naming => Evas_Object_Vg_Object ?

Sun, Aug 25, 9:29 PM · efl

Thu, Aug 22

Hermet closed D9697: edje/style: Enable lazy computaion of styles..
Thu, Aug 22, 7:11 PM · efl
Hermet closed D9716: ecore_con/memleak: due to checking refcount using postfix decrement operator.
Thu, Aug 22, 7:09 PM · efl
Hermet accepted D9716: ecore_con/memleak: due to checking refcount using postfix decrement operator.
Thu, Aug 22, 7:09 PM · efl

Wed, Aug 21

Hermet closed D9698: edje/style: fix memory leak because of typo..
Wed, Aug 21, 10:22 PM · efl
Hermet accepted D9698: edje/style: fix memory leak because of typo..
Wed, Aug 21, 10:22 PM · efl
Hermet closed D9665: efl_canvas_vg_shape/ector_software : Set and use stroke miterlimit.
Wed, Aug 21, 9:04 PM · efl
Hermet accepted D9665: efl_canvas_vg_shape/ector_software : Set and use stroke miterlimit.
Wed, Aug 21, 9:03 PM · efl
Hermet closed D9666: vg_common_json: Support stroke miterlimit.
Wed, Aug 21, 8:57 PM · efl
Hermet closed D9657: efl_gfx_shape: Add stroke_miterlimit property.
Wed, Aug 21, 8:51 PM · efl
Hermet accepted D9666: vg_common_json: Support stroke miterlimit.
Wed, Aug 21, 8:51 PM · efl
Hermet requested changes to D9665: efl_canvas_vg_shape/ector_software : Set and use stroke miterlimit.

Looks this patch contains D9657 code.

Wed, Aug 21, 8:48 PM · efl
Hermet accepted D9657: efl_gfx_shape: Add stroke_miterlimit property.
Wed, Aug 21, 8:44 PM · efl
Hermet closed D9656: ector_software_rasterizer: Change default value of stroke linejoin.
Wed, Aug 21, 8:39 PM · efl
Hermet accepted D9656: ector_software_rasterizer: Change default value of stroke linejoin.
Wed, Aug 21, 8:38 PM · efl
Hermet closed D9694: gesture_manager: Avoid dereferencing null pointer..
Wed, Aug 21, 7:11 PM · efl
Hermet accepted D9694: gesture_manager: Avoid dereferencing null pointer..
Wed, Aug 21, 7:11 PM · efl
Hermet closed D9693: edje/style: Avoid unnecessary evas_textblock_style computation..
Wed, Aug 21, 7:10 PM · efl
Hermet accepted D9693: edje/style: Avoid unnecessary evas_textblock_style computation..
Wed, Aug 21, 7:10 PM · efl
Hermet closed D9472: elementary_test: Add the animation view test.
Wed, Aug 21, 2:07 AM · efl
Hermet closed D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..
Wed, Aug 21, 1:47 AM · efl

Tue, Aug 20

Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

@bu5hm4n Im considering use player but currentl efl_player is not satisfied with this animation_view, it might need to some adjustment but moement it has a dependencies with other components,
I don't like to change all of them and it needs some time to proper review,
Since all were in beta, we could improve them step by step , So I think you could verify this, then I will improve them from this.

Tue, Aug 20, 5:02 AM · efl
Hermet closed D9640: evas_vg_load_svg: Support "display" attribute..
Tue, Aug 20, 4:35 AM · efl
Hermet accepted D9640: evas_vg_load_svg: Support "display" attribute..
Tue, Aug 20, 4:31 AM · efl

Mon, Aug 19

Hermet closed D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..
Mon, Aug 19, 10:36 PM · efl
Hermet accepted D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..
Mon, Aug 19, 10:35 PM · efl
Hermet closed D9620: vg_common_svg: Apply node opacity to stroke color.
Mon, Aug 19, 3:50 AM · efl
Hermet accepted D9620: vg_common_svg: Apply node opacity to stroke color.
Mon, Aug 19, 3:45 AM · efl
Hermet closed D9610: edje/style: refactor to avoid creating temporary strings..
Mon, Aug 19, 3:38 AM · efl
Hermet accepted D9610: edje/style: refactor to avoid creating temporary strings..
Mon, Aug 19, 3:38 AM · efl
Hermet closed D9613: edje/styles: avoid redundant style tag addition by providing extra checks..
Mon, Aug 19, 3:34 AM · efl
Hermet accepted D9613: edje/styles: avoid redundant style tag addition by providing extra checks..
Mon, Aug 19, 3:27 AM · efl
Hermet closed D9615: edje/styles: keep an escaped string of font_set. As eina_ecaped_string() creates a new string just make it once and use when needed..
Mon, Aug 19, 3:22 AM · efl
Hermet accepted D9615: edje/styles: keep an escaped string of font_set. As eina_ecaped_string() creates a new string just make it once and use when needed..
Mon, Aug 19, 3:21 AM · efl

Aug 19 2019

Hermet added a comment to T7811: Enventor fails to compile with latest EFL library.

All those fixed, now you could pull the enventor and enjoy it again.
This latest efl patch must be along with latest enventor.

Aug 19 2019, 2:09 AM · Restricted Project, Enventor

Aug 18 2019

Hermet added a comment to T7811: Enventor fails to compile with latest EFL library.

There more serious problems to be fixed that,

Aug 18 2019, 9:30 PM · Restricted Project, Enventor

Aug 17 2019

Hermet closed T7811: Enventor fails to compile with latest EFL library as Resolved.
Aug 17 2019, 11:04 AM · Restricted Project, Enventor
Hermet added a comment to T7811: Enventor fails to compile with latest EFL library.

@Hermet Thanks for looking into this.
I can use my machine as another testbed for it when you have started working on enventor.

Aug 17 2019, 10:59 AM · Restricted Project, Enventor

Aug 16 2019

Hermet closed D9580: evas: fix png regression issue.
Aug 16 2019, 12:55 AM · efl
Hermet accepted D9580: evas: fix png regression issue.
Aug 16 2019, 12:54 AM · efl

Aug 13 2019

Hermet closed D9476: evas_map: draw what map did not draw before..
Aug 13 2019, 8:40 PM · efl
Hermet accepted D9476: evas_map: draw what map did not draw before..
Aug 13 2019, 8:39 PM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated some doc syntax for c# generation.

Aug 13 2019, 1:49 AM · efl
Hermet updated the diff for D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

updated some doc syntax for c# generation.

Aug 13 2019, 1:37 AM · efl
Hermet resigned from D9533: evas/textblock: optimize layouting when textblock has empty text.
Aug 13 2019, 12:07 AM · efl
Hermet closed D9555: efl_ui_animation_view: change to Animation_View_State to resolve name conflict.
Aug 13 2019, 12:07 AM · efl

Aug 12 2019

Hermet added a comment to D9451: efl_ui_animation_view: introduce a new widget for controlling vector animation..

I think the overall widget looks fine beside the fact that elm_transit is used (which is IMO not good, but i might be able to life with it :P~). However, the other topic is Efl.Player: Volume and mute can just be generally ignored and return always 0 and true. The more important part here is, that we have a unified interface for playable entities. If they are splitted, what is the difference between this play here and the play in efl_player (same applies to all the other properties)? What are we going to do to not have colliding names ?
In general, if we do not have a common ground, we cannot build up specification tests for it - we cannot build up helper classes, we are super limited in future actions we can take.

Aug 12 2019, 10:14 PM · efl
Hermet accepted D9555: efl_ui_animation_view: change to Animation_View_State to resolve name conflict.
Aug 12 2019, 7:30 PM · efl
Hermet added a comment to D9476: evas_map: draw what map did not draw before..

if other properties has been changed such as texture uv, image, point color, smooth option, antialiasing, etc
Does here it needs to check out all the property diff?

Aug 12 2019, 7:29 PM · efl
Hermet closed D9543: edje/style: Remove redundant style tags from style text..
Aug 12 2019, 7:19 PM · efl
Hermet accepted D9543: edje/style: Remove redundant style tags from style text..

I tested the code history, it works fine with this patch as well.

Aug 12 2019, 7:16 PM · efl
Hermet requested changes to D9476: evas_map: draw what map did not draw before..

I guess this function won't be triggered if user just make it object visible again without any map update,

Aug 12 2019, 5:53 AM · efl

Aug 9 2019

Hermet closed D9534: evas/textblock: optmize textblock format parsing..
Aug 9 2019, 1:37 AM · efl