Page MenuHomePhabricator

JackDanielZ (Daniel Zaoui)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2013, 12:50 AM (305 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

JackDanielZ added inline comments to D7472: Player : Copy source exu's code to destination exu.
Tue, Dec 18, 12:17 AM

Yesterday

JackDanielZ closed D7464: Update code after EFL @0d2b624f.
Mon, Dec 17, 1:08 PM
JackDanielZ accepted D7464: Update code after EFL @0d2b624f.
Mon, Dec 17, 1:07 PM

Fri, Dec 14

JackDanielZ closed D7300: GUI: modify gui to manage 'db' files.
Fri, Dec 14, 2:34 AM
JackDanielZ accepted D7300: GUI: modify gui to manage 'db' files.
Fri, Dec 14, 2:33 AM
JackDanielZ added a comment to D7300: GUI: modify gui to manage 'db' files.

Will do soon. Phab was dead so I could not review

Fri, Dec 14, 12:43 AM
JackDanielZ closed D6950: db: introduce [de]serializing _DB as a file.
Fri, Dec 14, 12:08 AM

Thu, Dec 13

JackDanielZ accepted D6950: db: introduce [de]serializing _DB as a file.
Thu, Dec 13, 11:58 PM

Wed, Dec 5

JackDanielZ added a comment to T7483: Issues of ea_gen.

The 3 tests that were failing yesterday needed the shots to be updated. Btw, I pushed in Exactness the pause capability. When you press F2 during the scenario playing, it will pause it until you press F2 again.

Wed, Dec 5, 3:49 AM

Tue, Dec 4

JackDanielZ added a comment to T7483: Issues of ea_gen.

Hi Junsu,

Tue, Dec 4, 2:37 PM
JackDanielZ closed D7385: GUI: split tab of explorer.
Tue, Dec 4, 6:33 AM
JackDanielZ accepted D7385: GUI: split tab of explorer.
Tue, Dec 4, 6:33 AM
JackDanielZ closed D7387: DB-SCN: adapt code to Exactness events fix.
Tue, Dec 4, 6:13 AM
JackDanielZ closed D7386: Event: modify the way the events are triggered..
Tue, Dec 4, 6:12 AM

Mon, Dec 3

JackDanielZ updated the diff for D7387: DB-SCN: adapt code to Exactness events fix.

Bring back Efl Event

Mon, Dec 3, 12:26 PM
JackDanielZ updated the summary of D7386: Event: modify the way the events are triggered..
Mon, Dec 3, 11:45 AM
JackDanielZ updated the diff for D7386: Event: modify the way the events are triggered..

Bring back Efl Event

Mon, Dec 3, 11:44 AM
JackDanielZ closed D7388: Suite: fix scale issues.
Mon, Dec 3, 11:30 AM

Fri, Nov 30

JackDanielZ added a comment to D7387: DB-SCN: adapt code to Exactness events fix.

Hi guys,

Fri, Nov 30, 12:52 AM

Thu, Nov 29

JackDanielZ added a comment to T7483: Issues of ea_gen.

Tell me if D7388 solves the issue

Thu, Nov 29, 7:28 AM
JackDanielZ added reviewers for D7388: Suite: fix scale issues: jsuya, YOhoho.
Thu, Nov 29, 7:27 AM
JackDanielZ requested review of D7388: Suite: fix scale issues.
Thu, Nov 29, 7:27 AM
JackDanielZ added a comment to D7387: DB-SCN: adapt code to Exactness events fix.

Apply D7386 before this patch.

Thu, Nov 29, 5:28 AM
JackDanielZ requested review of D7387: DB-SCN: adapt code to Exactness events fix.
Thu, Nov 29, 5:27 AM
JackDanielZ requested review of D7386: Event: modify the way the events are triggered..
Thu, Nov 29, 5:22 AM
JackDanielZ closed D7384: GUI: Add language option(ml, c, ...) in preview.
Thu, Nov 29, 1:14 AM
JackDanielZ accepted D7384: GUI: Add language option(ml, c, ...) in preview.
Thu, Nov 29, 1:12 AM
JackDanielZ closed D7383: GUI: Add feature that only successful cases are created.
Thu, Nov 29, 12:45 AM
JackDanielZ accepted D7383: GUI: Add feature that only successful cases are created.
Thu, Nov 29, 12:45 AM

Wed, Nov 28

JackDanielZ added a comment to T7483: Issues of ea_gen.

4 - I will implement it in the next days
5 - There is a way to pack the source code inside the exu itself as well as the command to convert it to a binary. Can it fit? I don't think it would be a good idea to pack the binary directly
+ - I will check it after (4)

Wed, Nov 28, 11:49 AM
JackDanielZ closed D7376: GUI: Implement application run at preview.
Wed, Nov 28, 11:04 AM
JackDanielZ accepted D7376: GUI: Implement application run at preview.
Wed, Nov 28, 11:00 AM
JackDanielZ closed D7375: scn_gen : Must have take shot on first time..
Wed, Nov 28, 10:50 AM
JackDanielZ accepted D7375: scn_gen : Must have take shot on first time..
Wed, Nov 28, 10:50 AM
JackDanielZ closed D7374: GUI: Compare and display generated shot of scenario.
Wed, Nov 28, 10:29 AM
JackDanielZ accepted D7374: GUI: Compare and display generated shot of scenario.
Wed, Nov 28, 10:28 AM
JackDanielZ closed D7358: GUI: update app panel & ML view.
Wed, Nov 28, 1:49 AM
JackDanielZ accepted D7358: GUI: update app panel & ML view.

Sorry forgot about it

Wed, Nov 28, 1:49 AM

Tue, Nov 27

JackDanielZ closed D7258: db: Make functions referentially transparent.
Tue, Nov 27, 11:55 AM
JackDanielZ accepted D7258: db: Make functions referentially transparent.

I modified the patch according to my reviews

Tue, Nov 27, 11:54 AM
JackDanielZ added a comment to T7483: Issues of ea_gen.

Hi Junsu,

Tue, Nov 27, 10:20 AM
JackDanielZ closed D7365: DB: fix warnings.
Tue, Nov 27, 9:57 AM

Mon, Nov 26

JackDanielZ added a comment to D7365: DB: fix warnings.

How do you have warnings on it? I don't have anything!

Mon, Nov 26, 11:49 PM
JackDanielZ added a comment to T7483: Issues of ea_gen.

Hi Junsu,

Mon, Nov 26, 1:52 PM
JackDanielZ closed D7359: GUI : Shows the test results of exu..
Mon, Nov 26, 3:59 AM
JackDanielZ accepted D7359: GUI : Shows the test results of exu..
Mon, Nov 26, 3:58 AM
JackDanielZ added a comment to D7358: GUI: update app panel & ML view.

Fix the warnings please

Mon, Nov 26, 3:40 AM

Sun, Nov 25

JackDanielZ closed D7355: Inspect: create a full comparison output if exu is required and diffs are present.
Sun, Nov 25, 10:52 PM
JackDanielZ added a comment to T7483: Issues of ea_gen.

Thank you for the feedbacks. I didn't have too much time to work on the DB these last days. So now, I see some of the issues.

Sun, Nov 25, 3:27 PM

Sat, Nov 24

JackDanielZ added a reviewer for D7355: Inspect: create a full comparison output if exu is required and diffs are present: jsuya.
Sat, Nov 24, 11:49 AM
JackDanielZ added a comment to D7345: Inspect : Compare option make all diff image..

The problem with this patch is that it doesn't consider these cases:

  • png output: no output if no diff
  • no diffs at all are present, we don't have to create an output
Sat, Nov 24, 11:49 AM
JackDanielZ requested review of D7355: Inspect: create a full comparison output if exu is required and diffs are present.
Sat, Nov 24, 11:45 AM
JackDanielZ closed D7343: GUI: Add image path for various size of images..
Sat, Nov 24, 11:21 AM
JackDanielZ accepted D7343: GUI: Add image path for various size of images..
Sat, Nov 24, 11:21 AM
JackDanielZ closed D7329: GUI: add text setting.
Sat, Nov 24, 11:19 AM
JackDanielZ accepted D7329: GUI: add text setting.
Sat, Nov 24, 11:19 AM
JackDanielZ closed D7346: GUI: Implements test result export(HTML).
Sat, Nov 24, 11:04 AM
JackDanielZ accepted D7346: GUI: Implements test result export(HTML).
Sat, Nov 24, 11:04 AM
JackDanielZ closed D7222: GUI : Add 'TEST' tab and unit test implement.
Sat, Nov 24, 10:48 AM
JackDanielZ accepted D7222: GUI : Add 'TEST' tab and unit test implement.

I modified the code because it had issues on my side

Sat, Nov 24, 10:48 AM

Thu, Nov 22

JackDanielZ added a comment to D7329: GUI: add text setting.

Hi Bowon,

Thu, Nov 22, 11:23 AM
JackDanielZ added a comment to T7481: Upgrade GUI of ea_gen.

Hi Junsu,

Thu, Nov 22, 1:18 AM

Wed, Nov 21

JackDanielZ closed D7317: Update code after EFL @4b5304.
Wed, Nov 21, 12:39 AM
JackDanielZ accepted D7317: Update code after EFL @4b5304.

I updated it a little more

Wed, Nov 21, 12:38 AM
JackDanielZ closed D7316: update efl_01.patch file.
Wed, Nov 21, 12:16 AM
JackDanielZ accepted D7316: update efl_01.patch file.
Wed, Nov 21, 12:16 AM

Mon, Nov 19

JackDanielZ added inline comments to D7300: GUI: modify gui to manage 'db' files.
Mon, Nov 19, 11:56 PM
JackDanielZ added inline comments to D7300: GUI: modify gui to manage 'db' files.
Mon, Nov 19, 3:17 AM

Nov 14 2018

JackDanielZ added inline comments to D7258: db: Make functions referentially transparent.
Nov 14 2018, 2:38 PM
JackDanielZ closed D7259: update .gitignore for vscode.
Nov 14 2018, 1:47 PM
JackDanielZ accepted D7259: update .gitignore for vscode.
Nov 14 2018, 1:47 PM

Nov 13 2018

JackDanielZ added a comment to D6950: db: introduce [de]serializing _DB as a file.

I tried to make it work. It seems ok now, at least the DB display output is the same before and after load. I attached the patch here. Please update latest ea_gen and apply the patch.

Nov 13 2018, 3:10 PM

Nov 11 2018

JackDanielZ added a comment to D6950: db: introduce [de]serializing _DB as a file.

I will try to work on it this week and update you asap.

Nov 11 2018, 3:24 AM
JackDanielZ closed D7239: Inspect: support to print the exu diff result to standard output.
Nov 11 2018, 1:34 AM
JackDanielZ accepted D7239: Inspect: support to print the exu diff result to standard output.
Nov 11 2018, 1:32 AM
JackDanielZ closed D7250: db: fix _db_clear() to refer to proper variable.
Nov 11 2018, 1:31 AM
JackDanielZ accepted D7250: db: fix _db_clear() to refer to proper variable.
Nov 11 2018, 1:30 AM

Nov 8 2018

JackDanielZ added inline comments to D7239: Inspect: support to print the exu diff result to standard output.
Nov 8 2018, 2:34 AM
JackDanielZ added a comment to D7227: Spy: Prevent unexpected pointer dereference.

The problem with setting data to NULL is that it is internally used by elm_index. When the item is created, this data (no matter func) is set as the data of the item and is then used to find the item...

Nov 8 2018, 2:33 AM

Nov 7 2018

JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

What I meant:
For example, you need to run 100 tests together. You create some txt file with the tests name per line. You execute exactness with this file, -b the path to the exu files and other params that I don't remember. You attach to the Ecore_Exe some type "exactness_suite" or whatever you want. When you receive output in _output_exe_cb/_end_exe_cb, you parse to find some specific lines e.g STATUS test_20181107_1443_01 START... and other events such as COMPARE, OK, FAIL(3/7)... For each such event lines, you update your list item with the right status/color... That's why I don't understand why you need yohoho patch. His patch is usable only when the test is finished, but cannot help you to give live update. I just pushed the patch of the STATUS.
If the test failed, double-click can display the different images. To do this, you just need to open the exu output and show it.

Nov 7 2018, 5:04 AM
JackDanielZ added a comment to D7239: Inspect: support to print the exu diff result to standard output.

If it is with the goal to parse it, so don't use the colors. Less pretty but more practical. Go for it!

Nov 7 2018, 4:36 AM

Nov 5 2018

JackDanielZ added inline comments to D7239: Inspect: support to print the exu diff result to standard output.
Nov 5 2018, 3:08 AM

Nov 4 2018

JackDanielZ added a reviewer for D7237: Slider: fix callback invocation: eagleeye.
Nov 4 2018, 7:24 AM · efl
JackDanielZ requested review of D7237: Slider: fix callback invocation.
Nov 4 2018, 7:22 AM · efl

Nov 3 2018

JackDanielZ added a comment to D7227: Spy: Prevent unexpected pointer dereference.

Why setting data to NULL is needed? When I run the test, it is a success. I encountered this kind of problem and I fixed the issue with 28ab3df2.

Nov 3 2018, 11:33 AM
JackDanielZ closed D7229: gui: prevent potentional race-condition.
Nov 3 2018, 11:24 AM
JackDanielZ accepted D7229: gui: prevent potentional race-condition.

Well, theoretically, it shouldn't happen. Anyway, it seems nicer :-)

Nov 3 2018, 11:24 AM
JackDanielZ closed D7236: gui: turn fileselector expandable mode off.
Nov 3 2018, 11:12 AM
JackDanielZ accepted D7236: gui: turn fileselector expandable mode off.

Do you know if/when there will be a fix for this bug?

Nov 3 2018, 11:12 AM

Nov 2 2018

JackDanielZ added inline comments to D6950: db: introduce [de]serializing _DB as a file.
Nov 2 2018, 3:31 AM
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

Hi Junsu,

Nov 2 2018, 3:16 AM

Nov 1 2018

JackDanielZ added a comment to D7217: GUI: update db panel.

Bloody phab, I didn't finish my comments:

Nov 1 2018, 4:08 AM
JackDanielZ added a comment to D7217: GUI: update db panel.

Hi Bowon,

Nov 1 2018, 3:51 AM
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

I needed the threads to generate the ML files in parallel. I didn't want to do it externally because building the DB takes relatively a lot of time.

Nov 1 2018, 1:46 AM

Oct 31 2018

JackDanielZ abandoned D7223: Meson: add themes path to Elementary pc file.
Oct 31 2018, 1:48 PM · efl
JackDanielZ accepted D7224: meson: allow setting of custom pc variables.

Seems great here funny boy!

Oct 31 2018, 1:48 PM · efl
JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

I know that my question can seem dumb but... why do you need threads? There is no calculation at all there, only pass to the main loop, meaning the threads mechanism won't block anything.

Oct 31 2018, 1:45 PM
JackDanielZ added a reviewer for D7223: Meson: add themes path to Elementary pc file: bu5hm4n.
Oct 31 2018, 1:21 AM · efl
JackDanielZ requested review of D7223: Meson: add themes path to Elementary pc file.
Oct 31 2018, 1:21 AM · efl

Oct 30 2018

JackDanielZ added a comment to D7222: GUI : Add 'TEST' tab and unit test implement.

Hi Junsu,

Oct 30 2018, 11:51 PM