Page MenuHomePhabricator

JackDanielZ (Daniel Zaoui)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2013, 12:50 AM (296 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Sun, Sep 30

JackDanielZ added a comment to D7037: genlist: fix item show/bring in coordinate calculation with zero-sized pan..

Hi guys,

Sun, Sep 30, 9:09 AM · efl

Thu, Sep 20

JackDanielZ closed D7076: GUI: new menu implement.
Thu, Sep 20, 1:19 PM
JackDanielZ accepted D7076: GUI: new menu implement.
Thu, Sep 20, 1:19 PM
JackDanielZ added a comment to D7076: GUI: new menu implement.

Thank you, seems great! I fixed the warnings.

Thu, Sep 20, 1:19 PM
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

Hi Hermet,

Thu, Sep 20, 12:58 AM · efl

Mon, Sep 17

JackDanielZ closed D7034: Spy: Fix elm_toolbar_item_menu_get hooking function name.
Mon, Sep 17, 3:46 AM
JackDanielZ accepted D7034: Spy: Fix elm_toolbar_item_menu_get hooking function name.
Mon, Sep 17, 3:45 AM

Sep 15 2018

JackDanielZ closed D7032: GUI: Code clean up and bug fix for tab..
Sep 15 2018, 10:14 AM
JackDanielZ accepted D7032: GUI: Code clean up and bug fix for tab..
Sep 15 2018, 10:14 AM

Sep 13 2018

JackDanielZ closed D6993: GUI: Tab implement.
Sep 13 2018, 6:53 AM
JackDanielZ accepted D6993: GUI: Tab implement.
Sep 13 2018, 6:52 AM
JackDanielZ added a comment to D7025: C Gen: Modify to generate the class within the callback, if parent is genlist.item..

I pushed the fix for the configuration. Good catch! Now I think you should have Elm.Genlist.Item as kl. real_kl should not be used there as it may be confusing.

Sep 13 2018, 6:47 AM

Sep 12 2018

JackDanielZ added inline comments to D7025: C Gen: Modify to generate the class within the callback, if parent is genlist.item..
Sep 12 2018, 6:04 AM

Sep 11 2018

JackDanielZ added a comment to D6993: GUI: Tab implement.

And please fix the warnings! :-)

Sep 11 2018, 1:24 PM
JackDanielZ added a comment to D6993: GUI: Tab implement.

It seems really good now! Thank you!

Sep 11 2018, 1:21 PM
JackDanielZ reopened D6919: evas image: fix a bug in image preloading..

ping?

Sep 11 2018, 1:13 PM · efl
JackDanielZ closed D6994: Spy : Support EA_CREATE, EA_MODIFY function of item class.
Sep 11 2018, 1:11 PM
JackDanielZ accepted D6994: Spy : Support EA_CREATE, EA_MODIFY function of item class.
Sep 11 2018, 1:11 PM
JackDanielZ closed D7021: Spy : Set index widget as legacy.
Sep 11 2018, 12:55 PM
JackDanielZ accepted D7021: Spy : Set index widget as legacy.
Sep 11 2018, 12:54 PM
JackDanielZ closed D7020: Spy : Set notify widget as legacy.
Sep 11 2018, 12:53 PM
JackDanielZ accepted D7020: Spy : Set notify widget as legacy.
Sep 11 2018, 12:51 PM
JackDanielZ closed D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.
Sep 11 2018, 12:49 PM
JackDanielZ accepted D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.
Sep 11 2018, 12:49 PM

Sep 8 2018

JackDanielZ closed D7005: Spy : Set panel widget as legacy.
Sep 8 2018, 1:32 PM
JackDanielZ added a comment to D7006: Spy: Set progressbar widget as legacy and add some legacy APIs.

Hi Junsu,

Sep 8 2018, 1:30 PM
JackDanielZ accepted D7005: Spy : Set panel widget as legacy.
Sep 8 2018, 1:28 PM
JackDanielZ closed D7004: Spy : Using efl_part if part isn't default when using efl_content_set.
Sep 8 2018, 1:27 PM
JackDanielZ accepted D7004: Spy : Using efl_part if part isn't default when using efl_content_set.
Sep 8 2018, 1:27 PM
JackDanielZ closed D7003: Spy : Add elm_slider legacy APIs and set legacy widget.
Sep 8 2018, 1:23 PM
JackDanielZ accepted D7003: Spy : Add elm_slider legacy APIs and set legacy widget.
Sep 8 2018, 12:38 PM
JackDanielZ added a comment to D7003: Spy : Add elm_slider legacy APIs and set legacy widget.

Thank you for the patch! Did you investigate the size issue?

Sep 8 2018, 12:38 PM
JackDanielZ closed D6914: Using efl_add_ref when called efl_add if parent is null.
Sep 8 2018, 12:32 PM
JackDanielZ accepted D6914: Using efl_add_ref when called efl_add if parent is null.

Sorry for the delay, I just saw it now (Too much Phab mails)

Sep 8 2018, 12:32 PM

Sep 7 2018

JackDanielZ added a comment to D6993: GUI: Tab implement.

Hi Bowon,

Sep 7 2018, 12:21 AM

Sep 6 2018

JackDanielZ closed D7002: Add My.Grid eo and elm_grid_pack_set legacy API.
Sep 6 2018, 11:29 PM
JackDanielZ accepted D7002: Add My.Grid eo and elm_grid_pack_set legacy API.
Sep 6 2018, 11:28 PM
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

http://www.enlightenment.org/ss/e-5b9219b15fe6c3.46092975.jpg

Sep 6 2018, 11:25 PM · efl
JackDanielZ added a comment to D6919: evas image: fix a bug in image preloading..

Hi Hermet,

Sep 6 2018, 11:24 PM · efl
JackDanielZ added a comment to D6993: GUI: Tab implement.

Hi Bowon,

Sep 6 2018, 1:13 PM

Sep 5 2018

JackDanielZ closed D6990: Spy : Modify lagacy function name for elm_photo.
Sep 5 2018, 10:51 PM
JackDanielZ accepted D6990: Spy : Modify lagacy function name for elm_photo.
Sep 5 2018, 10:51 PM
JackDanielZ closed D6963: code_gen : add null check for itc.
Sep 5 2018, 1:41 PM
JackDanielZ accepted D6963: code_gen : add null check for itc.
Sep 5 2018, 1:40 PM
JackDanielZ closed D6989: Spy : Add elm_bg_color_set/get legacy APIs in My.Bg.
Sep 5 2018, 12:30 PM
JackDanielZ accepted D6989: Spy : Add elm_bg_color_set/get legacy APIs in My.Bg.
Sep 5 2018, 12:30 PM
JackDanielZ closed D6988: Spy : Update catchers.
Sep 5 2018, 12:27 PM
JackDanielZ accepted D6988: Spy : Update catchers.
Sep 5 2018, 12:26 PM

Aug 30 2018

JackDanielZ added a comment to D6950: Add a name onto anonymous union field.

Hi Wonki,

Aug 30 2018, 11:59 PM
JackDanielZ added a comment to D6950: Add a name onto anonymous union field.

Do we really need the DB to be stored in EET?

Aug 30 2018, 1:18 PM
JackDanielZ added a comment to D6951: Spy: Temporarily ignore Efl.Loop_Timer.

Hi Junsu,

Aug 30 2018, 1:16 PM
JackDanielZ closed D6949: c_gen : Add null check.
Aug 30 2018, 11:00 AM
JackDanielZ accepted D6949: c_gen : Add null check.
Aug 30 2018, 11:00 AM
JackDanielZ closed D6947: Set naviframe item creation function info.
Aug 30 2018, 10:58 AM
JackDanielZ accepted D6947: Set naviframe item creation function info.
Aug 30 2018, 10:58 AM
JackDanielZ closed D6946: Spy: Update catchers.
Aug 30 2018, 10:50 AM
JackDanielZ accepted D6946: Spy: Update catchers.
Aug 30 2018, 10:46 AM

Aug 27 2018

JackDanielZ added a comment to D6913: Set naviframe item creation function info and update catchers.

Please make two patches to update the catchers, one that updates the catchers after EFL update... and the second that updates the config.json and the catchers after this change.

Aug 27 2018, 11:17 PM

Aug 18 2018

JackDanielZ closed D6798: ea_spy_check : Add shared option for gcc compile.
Aug 18 2018, 12:57 PM · regression
JackDanielZ accepted D6798: ea_spy_check : Add shared option for gcc compile.
Aug 18 2018, 12:57 PM · regression
JackDanielZ closed D6854: Uncomment some tests(genlist_group, list, radio, spinner).
Aug 18 2018, 12:55 PM

Aug 16 2018

JackDanielZ added a comment to D6828: elm_image: create image object before call elm_image_object_get.

Thank you @YOhoho it works great with your patch

Aug 16 2018, 6:50 AM · efl
JackDanielZ added a comment to D6726: elementary image: apply lazy calculation and guarantee retained method..

Hi guys,

Aug 16 2018, 5:21 AM · efl

Aug 9 2018

JackDanielZ added a comment to D6797: spy : Add the empty condition of Efl.Canvas.Rectangle..

Did you check all the tests?

Aug 9 2018, 1:16 AM · regression
JackDanielZ added inline comments to D6798: ea_spy_check : Add shared option for gcc compile.
Aug 9 2018, 1:13 AM · regression

Aug 2 2018

JackDanielZ added a comment to T6949: Exactness: integration into EFL test process.

@stefan_schmidt ping?

Aug 2 2018, 1:05 AM · Restricted Project, Testing

Jul 23 2018

JackDanielZ added a comment to D6668: elm_test: fix arg parsing.

Sorry to disturb but it seems that this patch has not verified "corner" cases such as launching only a test e.g:
elementary_test -to table

Jul 23 2018, 1:54 PM · efl: widgets

Jul 12 2018

JackDanielZ added a comment to T7102: Clouseau does not even display the position / size of the debug object nor the minsizes.

Because EET... :-)

Jul 12 2018, 7:42 AM · Restricted Project
JackDanielZ closed T7102: Clouseau does not even display the position / size of the debug object nor the minsizes as Resolved by committing rCLSd81340030714: Support of structs parameters.
Jul 12 2018, 6:15 AM · Restricted Project
JackDanielZ added a comment to T7102: Clouseau does not even display the position / size of the debug object nor the minsizes.

I pushed the structs support. Hopefully, it will not make issues. It is a little hacky there because the structures can be extracted only by assuming that they are packed and not reordered. It works for the position, size and some other. But it could fail on other architectures.

Jul 12 2018, 5:57 AM · Restricted Project

Jul 11 2018

JackDanielZ added a comment to T7129: Win doesn't have the same alpha behavior if it is set as legacy or not.

Thanks guys

Jul 11 2018, 11:18 PM · efl
JackDanielZ closed T6984: Terminology splits get keyboard events together as Resolved.

Seems it doesn't happen anymore. So maybe I did something wrong last time.

Jul 11 2018, 10:38 PM · Terminology
Herald added a reviewer for D5908: efl_ui_slider: refactor slider widget.: devilhorns.

Hi guys,

Jul 11 2018, 5:55 AM · efl
JackDanielZ triaged T7129: Win doesn't have the same alpha behavior if it is set as legacy or not as Normal priority.
Jul 11 2018, 3:16 AM · efl

Jul 10 2018

JackDanielZ added a comment to T5876: Different application size depends on the location of the window visibility setting in the code relative to resize_object.

Well now, it seems that visibility doesn't impact on the size. However, the window size setting position impacts on it.

Jul 10 2018, 11:45 PM · efl (efl-1.21), efl: widgets, efl: display system
JackDanielZ added a comment to T6949: Exactness: integration into EFL test process.

@stefan_schmidt, how was your vacation/leave? When do you think you will have time to review my plans to integrate Exactness into EFL?

Jul 10 2018, 1:37 AM · Restricted Project, Testing

Jul 3 2018

JackDanielZ added a comment to T7102: Clouseau does not even display the position / size of the debug object nor the minsizes.

The thing is that it was not used when I implemented Clouseau. I noted it was not supported but my laziness won.

Jul 3 2018, 10:14 AM · Restricted Project

Jun 18 2018

JackDanielZ closed T7017: Clouseau Seems to Not Work and Needs Documentation As Well as Resolved by committing rCLS0ddf1692a597: ObjIntrospection: freeze only after the snapshot starts.
Jun 18 2018, 12:38 AM · Restricted Project

Jun 17 2018

JackDanielZ added a comment to T7022: Make clouseau ensure that efl_debugd is running.

Hi Marcel,

Jun 17 2018, 1:05 PM · Restricted Project, Restricted Project

Jun 16 2018

JackDanielZ closed T5856: Clouseau can't connect as Resolved by committing rCLS41ad14667630: Add clouseau script.
Jun 16 2018, 1:36 PM · Restricted Project

Jun 15 2018

JackDanielZ added a comment to T7022: Make clouseau ensure that efl_debugd is running.

For the local mode, you are right. But I think we should show some dialog window to be sure the user understands what it means.

Jun 15 2018, 5:41 AM · Restricted Project, Restricted Project
JackDanielZ added a comment to T7022: Make clouseau ensure that efl_debugd is running.

Because clouseau can run without a daemon running on the same machine. You have two additional modes: the remote mode and the offline mode. Both don't need the local daemon to run.

Jun 15 2018, 5:25 AM · Restricted Project, Restricted Project
JackDanielZ added a comment to T7022: Make clouseau ensure that efl_debugd is running.

Well we could make that clouseau tries to connect, fails and inform the user that the daemon should be launched. Clouseau can ask him if he wants Clouseau to launch the daemon, on the condition that it would die at the end of the debugging.

Jun 15 2018, 1:08 AM · Restricted Project, Restricted Project
JackDanielZ edited the content of Clouseau.
Jun 15 2018, 12:05 AM · Restricted Project
JackDanielZ edited the content of Clouseau.
Jun 15 2018, 12:03 AM · Restricted Project

Jun 14 2018

JackDanielZ claimed T7017: Clouseau Seems to Not Work and Needs Documentation As Well.

Hi Stephen,

Jun 14 2018, 11:20 AM · Restricted Project

Jun 9 2018

JackDanielZ added a parent task for T6928: Datetime test doesn't display the datetime widget: T6926: Legacy Breaks That Need to Be Fixed for Release.
Jun 9 2018, 10:47 AM · efl (efl-1.21), efl: widgets
JackDanielZ added a subtask for T6926: Legacy Breaks That Need to Be Fixed for Release: T6928: Datetime test doesn't display the datetime widget.
Jun 9 2018, 10:47 AM · efl (efl-1.21), regression

Jun 5 2018

JackDanielZ added a comment to T6984: Terminology splits get keyboard events together.

I don't remember having done something. Next time it happens, I will try this shortcut to disable it.

Jun 5 2018, 5:17 AM · Terminology
JackDanielZ created T6984: Terminology splits get keyboard events together.
Jun 5 2018, 12:55 AM · Terminology

Jun 4 2018

JackDanielZ closed D6242: Fix the battery status when some battery devices are not valid.

commit: https://phab.enlightenment.org/rE49459b6b725a0c9980bc60f05eceb215ac010bd8

Jun 4 2018, 11:52 PM · enlightenment-git
JackDanielZ added a comment to D6243: elm_dayselector : fix that bg color do not change..

Thank you very much, the patch works!

Jun 4 2018, 11:47 PM · regression, efl
JackDanielZ added a comment to T6949: Exactness: integration into EFL test process.
In T6949#115284, @zmike wrote:

I missed a couple replies to this in my inbox, so I'm coming in a bit late. Going to avoid quoting here in order to keep the comments from becoming too large and unreadable:

  • My idea was to not have a separate make check rule for exactness, and to instead just add it to the TESTS variable when exactness checking is enabled at configure time (a separate option from just enabling building the exactness binary). If someone enables it at configure then we should assume they'll want to run it, so this simplifies the makefile. I realize this is different from the original discussion, and I'm not strongly opposed to having a separate rule for it, but I think there is something to be said for potentially removing some complexity from the makefiles?

I am ok with that. make check runs all the tests, including exactness suite if enabled in configure. Additionnally, make check-exactness from the src directory runs only exactness suite. Both launch the same script that invokes exactness.

  • I think the best example that I have of submodules in use is probably from Servo, which at this time used custom makefiles to handle a LOT of submodules. We can probably at least get some ideas from this; the primary file to look at is 'configure' in the base directory. The submodule should be in data/exactness as has been proposed I think.

I will take a look

@JackDanielZ can you link to the changeset which adds the font handling? This could be useful for people to reference in the future. Nice work figuring it out! As for handling freetype/hb upgrades, do they have libraries to determine the runtime version? We may have to maintain separate data for when a breaking change occurs...

You mean the Exactness commit (https://phab.enlightenment.org/rTEXACT0e1f0cf1c5f7766f5228e74bbbc718a4e898660c) that handles the font handling?

Jun 4 2018, 2:13 PM · Restricted Project, Testing

Jun 3 2018

Herald added a project to D5499: Genlist: Test Cases for Genlist Item Show on Launch: efl.

Sorry to be late :-D

Jun 3 2018, 11:30 AM · efl
JackDanielZ triaged T6981: Dayselector selections are not displayed as before as Showstopper Issues priority.
Jun 3 2018, 11:04 AM · regression, efl
JackDanielZ added a comment to T6949: Exactness: integration into EFL test process.

Hi guys,

Jun 3 2018, 3:23 AM · Restricted Project, Testing

May 31 2018

JackDanielZ added a comment to T6970: Applications content disappears when switching desktops on E.

Sorry that this ticket disappointed you! I am sure you can find other tickets more interesting!

May 31 2018, 5:20 AM · efl, enlightenment-git
JackDanielZ added a comment to D6231: elm_hoversel: implement content set/unset.

IT WORKS!!! Thank you very much!

May 31 2018, 12:01 AM · efl

May 30 2018

JackDanielZ added a comment to D6231: elm_hoversel: implement content set/unset.

I just tried the patch but it fails while trying to find elm_hoversel_part.eo. Is it only in your code?

May 30 2018, 10:43 PM · efl
JackDanielZ added a comment to T6970: Applications content disappears when switching desktops on E.

I just tried - it is still broken in OpenGL.

May 30 2018, 3:39 AM · efl, enlightenment-git