Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (311 w, 5 d)
Availability
Available

Recent Activity

Today

Jaehyun_Cho added a comment to D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

Honestly, I think that developers don't know why they should not use efl_add for spotlight manager.
Although they read description of the manager_set() and @owned, they still don't know why efl_add is not allowed.

Mon, Jul 15, 1:32 AM · efl
Jaehyun_Cho added a comment to T7867: efl.ui.radio.

Related to radio, we need to support setting radio into other containers. (e.g. Efl.Ui.List)

Mon, Jul 15, 1:17 AM · efl: api, efl (efl-1.23), efl: language bindings

Yesterday

Jaehyun_Cho added a comment to D9306: efl_ui_spotlight_manager_*: cleanup canvas state on invalidate.

This patch looks good to me (without dependent patches D9304, D9305)

Sun, Jul 14, 7:59 PM · efl
Jaehyun_Cho requested changes to D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

It seems that developer should use efl_new for spotlight manager by this patch.
When efl_add is used for spotlight manager, then it becomes broken with this patch.

Sun, Jul 14, 7:54 PM · efl

Fri, Jul 12

Jaehyun_Cho added a comment to D9300: eo: fix to free unmanaged handle of language bindings manually in eo.

Okay, please, take a step back and reevaluate this. If you chain the unref with the unrefing of the previous ref (which this here is doing), then those two references are basically *one* reference. There is no way that the reference that was taken by C# can overlife the other reference taken by anyone else. Which effectively means, you can just remove the initial reference that C# took on this object. So this patch here makes the reftaking of C# completly useless, in the case that this here is resulting in correct behaviour for you in C#, then please remove the efl_ref that is in C#.

Fri, Jul 12, 7:27 AM · efl
Jaehyun_Cho added a comment to D9300: eo: fix to free unmanaged handle of language bindings manually in eo.

Can you tell me if i am understanding you currently:

  • When a eo object is created from C# or C and it is used in C#, the wrapper will get a reference on it?

yes, not to free eo before C# instance is destructed.

Fri, Jul 12, 5:22 AM · efl
Jaehyun_Cho added inline comments to D9300: eo: fix to free unmanaged handle of language bindings manually in eo.
Fri, Jul 12, 4:08 AM · efl
Jaehyun_Cho requested review of D9300: eo: fix to free unmanaged handle of language bindings manually in eo.
Fri, Jul 12, 1:26 AM · efl

Thu, Jul 11

Jaehyun_Cho added a comment to T7562: efl.input.interface.

I think I misunderstood the purpose and the meaning of the name.
Now I see the name would be ok :)
Thank you @segfaultxavi @bu5hm4n

Thu, Jul 11, 7:57 AM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T7562: efl.input.interface.

Actually I don't mind the name Efl.Input.Event. It's ok but the reason why I suggested is to change the name "Efl.Input.Interface".

Thu, Jul 11, 7:31 AM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T7562: efl.input.interface.

What do you think about changing the name of this interface as follows?

Thu, Jul 11, 5:56 AM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T7973: Efl.Input.Value.

@bu5hm4n
Can we leave this under beta for now? (if value and value_has in Efl.Input.Pointer remains under beta for now(T7963))

Thu, Jul 11, 5:03 AM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T7963: Efl.Input.Pointer.

@bu5hm4n
I totally agree with you about value and value_has..

Thu, Jul 11, 5:00 AM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T7969: Efl.Input.Device.

It seems that @property is_pointer_type supports get() only.
Then how about changing it to a method? is_pointer_type?

Thu, Jul 11, 4:55 AM · efl (efl-1.23), efl: api

Wed, Jul 10

Jaehyun_Cho added a comment to T7965: Efl.Input.Hold.

What is the difference between efl_input_processed_set/get and efl_input_hold_set/get?
Are they duplicated?

Wed, Jul 10, 10:16 PM · efl (efl-1.23), efl: api
Jaehyun_Cho added a comment to T8040: Efl.Ui.Active_View.View_Manager_Scroll: Support scroll functions.

Ok. Now I just know about those 2 functions. I will ask developers if there are more requirements related to scroll features for ManagerScroll.

Wed, Jul 10, 5:47 AM · efl: api
Jaehyun_Cho added a comment to T8040: Efl.Ui.Active_View.View_Manager_Scroll: Support scroll functions.

There are some demands to use scroll functions (e.g. scroll_hold, scroll_freeze) for Efl.Ui.Active_View.View_Manager_Scroll.
To do that, it seems that Efl.Ui.Active_View.View_Manager_Scroll uses or inherits/implements Efl.Ui.Scroller or Elm.Interface_Scrollable.

Wed, Jul 10, 5:33 AM · efl: api

Tue, Jul 9

Jaehyun_Cho closed D9204: efl_ui_clickable: fix not to be clicked if pointer is processed.
Tue, Jul 9, 1:34 AM · efl

Fri, Jun 28

Jaehyun_Cho requested review of D9204: efl_ui_clickable: fix not to be clicked if pointer is processed.
Fri, Jun 28, 3:35 AM · efl
Jaehyun_Cho closed D9173: view_manager_scroll: fix not to move view position by click.
Fri, Jun 28, 2:36 AM · efl
Jaehyun_Cho added a comment to D9173: view_manager_scroll: fix not to move view position by click.

Thank you :)

Fri, Jun 28, 2:36 AM · efl

Thu, Jun 27

Jaehyun_Cho created T8040: Efl.Ui.Active_View.View_Manager_Scroll: Support scroll functions.
Thu, Jun 27, 9:24 PM · efl: api

Wed, Jun 26

Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.
In T8019#137815, @zmike wrote:

I'm not sure I see how setting the event to be processed in the 'move' callback would affect the 'up' callback? Can you explain your thinking here?

Wed, Jun 26, 5:36 PM
Jaehyun_Cho accepted D9176: efl_ui: remove nstate widget.
Wed, Jun 26, 1:40 AM · efl: widgets
Jaehyun_Cho added inline comments to D9173: view_manager_scroll: fix not to move view position by click.
Wed, Jun 26, 1:11 AM · efl
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

@zmike

In the event where e.g., someone calls edje_object_message_signal_process from within the event callback, however, this method would not work.

Wed, Jun 26, 12:29 AM

Tue, Jun 25

Jaehyun_Cho updated the test plan for D9173: view_manager_scroll: fix not to move view position by click.
Tue, Jun 25, 5:18 AM · efl
Jaehyun_Cho requested review of D9173: view_manager_scroll: fix not to move view position by click.
Tue, Jun 25, 5:16 AM · efl
Jaehyun_Cho added a comment to D9159: eolian_mono: fix to support event info which is a type defined in eo.

Could you review this patch?

Tue, Jun 25, 3:28 AM · efl
Jaehyun_Cho closed D9164: efl-mono: Add object type support for Eina.Value.
Tue, Jun 25, 3:26 AM · efl
Jaehyun_Cho accepted D9164: efl-mono: Add object type support for Eina.Value.

@lauromoura
Thank you very much!! :)

Tue, Jun 25, 12:50 AM · efl

Mon, Jun 24

Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Do you mean something like this? (Instead of ownership, I used efl_input_processed)
https://git.enlightenment.org/core/efl.git/commit/?h=devs/jaehyun/efl_clickable_test3&id=699a1c2e705d1dccd8b8cfee1834a9280de929c5

Mon, Jun 24, 10:00 PM
Jaehyun_Cho added a comment to T7948: Efl.Ui.Alert_Popup.

Yes, since Efl.Ui.Alert_Popup simply adds its buttons and button clicked event to Efl.Ui.Popup, extending Efl.Ui.Popup is enough for developer who needs a more flexible popup.

Mon, Jun 24, 4:26 AM · efl (efl-1.23), efl: language bindings
Jaehyun_Cho closed D9128: eolian_mono: support eo access modifiers.
Mon, Jun 24, 3:22 AM · efl
Jaehyun_Cho added a commit to T7494: C#: Mark protected methods as protected: rEFL127209ce2b5e: eolian_mono: support eo access modifiers.
Mon, Jun 24, 3:22 AM · efl: language bindings
Jaehyun_Cho closed D9111: eolian_mono: fix to call mixin's method in inherited class.
Mon, Jun 24, 3:22 AM · efl
Jaehyun_Cho accepted D9128: eolian_mono: support eo access modifiers.
Mon, Jun 24, 3:18 AM · efl
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Thank you for the suggestion.
I want to fully understand your idea so I have some questions about the ownership steps.

Mon, Jun 24, 1:44 AM
Jaehyun_Cho added a comment to D9159: eolian_mono: fix to support event info which is a type defined in eo.

This patch is required to support enum type to event info. (related to comments on T7948)

Mon, Jun 24, 1:18 AM · efl
Jaehyun_Cho requested review of D9159: eolian_mono: fix to support event info which is a type defined in eo.
Mon, Jun 24, 1:17 AM · efl
Jaehyun_Cho added a comment to T7948: Efl.Ui.Alert_Popup.

Thank you for the opinion.
I agree with you about event info. Regardless of the original intention (why event info is structure), it seems that no new information is required for alert popup's button clicked event.

Mon, Jun 24, 12:16 AM · efl (efl-1.23), efl: language bindings

Thu, Jun 20

Jaehyun_Cho updated subscribers of T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

I discussed this topic with @woohyun and @Hermet

Thu, Jun 20, 5:33 AM

Wed, Jun 19

Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Thank you for suggesting an idea.
I think that your idea can resolve this issue but a solution which does not add new feature would be better.

Wed, Jun 19, 5:35 AM
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

This issue is related to widget which uses Efl.Ui.Clickable_Util.

Wed, Jun 19, 4:33 AM
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

Yes, the button should be pressed and unpressed but clicked event should not happen.

Wed, Jun 19, 3:39 AM
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

The reproduction case is as follows in the description.

Wed, Jun 19, 3:09 AM
Jaehyun_Cho added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

@bu5hm4n
Could you tell me where I need to add efl_input_processed_set for efl_ui_active_view_view_manager_scroll.c?

Wed, Jun 19, 3:05 AM
Jaehyun_Cho updated subscribers of T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

@eagleeye
Thank you for checking this issue!

Wed, Jun 19, 2:20 AM
Jaehyun_Cho created T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.
Wed, Jun 19, 2:19 AM
Jaehyun_Cho closed D9079: efl_mono: support multilevel inheritance of NativeClass.
Wed, Jun 19, 12:04 AM · efl

Tue, Jun 18

Jaehyun_Cho requested review of D9111: eolian_mono: fix to call mixin's method in inherited class.
Tue, Jun 18, 11:20 PM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

I am totally in favor of discussing that, and get feedback, but you are right now suggesting that i am going back to solution 1, which was considered *confusing*. Additionally, i feel like you do not have any example or usage for *not* having push or pop, this means every single time you want to know when the animation is finished you have to subscribe to the event, and unsubscribe from the event when it got called, which is an enormous code overhead, so if you showcase the solution of *do it yourself*, people will find it confusing as you do have to do two calls instead of pop, and a lot more in case of push.

I am strongly in favor of adding this *now* as beta API, if sample applications do like how this is API is done, then they will use it, and we can unbeta it. If not, we can still remove it again. And not include it at all. Does that sound like a plan ?

Tue, Jun 18, 9:29 PM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

Okay, we have had now 3 different approaches, and every single approach implemented 2 times.I seriously do not buy that this is confusing, where or why is it confusing? it is a dead simple push and pop that inserts things just like in a normal addressable stack data struct. What exactly is the reason ? where it is confusing ?

We are turning here in circles again and again and again. And each time the current implementation is confusing. Maybe we should reach a point where we say "get used to it" and continue with this ? I honestly have to say, every single time such a argument as "this is confusing" is done i am more and more loosing trust in the feedback i am getting here... Why should i now for example implement pack() like pack_end(), it may be considered confusing tomorrow ... and the progress is 0.

Tue, Jun 18, 7:55 AM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

One more thing here ;)

Tue, Jun 18, 5:39 AM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

I am sorry for saying this now.

Tue, Jun 18, 5:19 AM · efl

Mon, Jun 17

Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi @bu5hm4n
Thank you for the opinion :) It helped me to understand new developers better~ :)

Mon, Jun 17, 9:08 PM · efl

Sun, Jun 16

Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

@Jaehyun_Cho Can you answer if you are happy with pop / push ?

Sun, Jun 16, 11:17 PM · efl

Jun 13 2019

Jaehyun_Cho added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

@bu5hm4n
There are 2 things I want to comment related to the Radio_Group and Radio_Box.

Jun 13 2019, 4:15 AM · efl

Jun 12 2019

Jaehyun_Cho added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

After thinking about this patch and Radio widget for a while, I thought that
"how about providing Efl.Ui.Radio_Group class?" (not interface)

Jun 12 2019, 11:16 PM · efl
Jaehyun_Cho accepted D9079: efl_mono: support multilevel inheritance of NativeClass.

@felipealmeida @vitor.sousa
I think this patch is correct and should be submitted.
What do you think? Do you agree with this patch?

Jun 12 2019, 5:36 AM · efl
Jaehyun_Cho accepted D8920: efl_ui_stack: remove!.

@bu5hm4n
I see~ You are right we have time to change before release (although it might not be that long! :( ) Thank you :)
Just a rebase is needed to push this~

Jun 12 2019, 5:33 AM · efl
Jaehyun_Cho updated subscribers of D8920: efl_ui_stack: remove!.

@bu5hm4n
Basically, I agree with you. I think that the returned future is good.
However, I am concerning if it is available to use EINA_VALUE_TYPE_OBJECT in EFL C# before we release EFL C# bindings publicly.
If the future is returned by active_view_unpack(), then developers want to know what is the eina_value in their eina_future_then callback. (now the Eina_Value argument cannot be used as an object in C#)

Jun 12 2019, 1:12 AM · efl

Jun 11 2019

Jaehyun_Cho closed D7962: efl_ui_win: Added more gesture config values for gesture manager..
Jun 11 2019, 12:19 AM · efl

Jun 10 2019

Jaehyun_Cho accepted D7962: efl_ui_win: Added more gesture config values for gesture manager..

sorry, I missed the comments.. :(

Jun 10 2019, 10:58 PM · efl
Jaehyun_Cho updated the task description for T8012: Support default values @property's keys and method's params in eo.
Jun 10 2019, 9:38 PM · efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to T8012: Support default values @property's keys and method's params in eo.

From eolian side, there is already this syntax:

@property allow_parent_unref @beta {
         [[... ]]
         values {
            allow: bool(false); [[...]]
         }
      }

Which is copied from efl_object.eo

Jun 10 2019, 9:31 PM · efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

Thank you for the implementation! :)
I haven't used future on C# bindings so I think I need to check it on C# as well.

Jun 10 2019, 3:17 AM · efl
Jaehyun_Cho updated subscribers of T8012: Support default values @property's keys and method's params in eo.

Could you tell me your opinion on this task?

Jun 10 2019, 3:02 AM · efl: language bindings, Restricted Project
Jaehyun_Cho renamed T8012: Support default values @property's keys and method's params in eo from Support override functions for Language Bindings in eo to Support default values @property's keys and method's params in eo.
Jun 10 2019, 2:53 AM · efl: language bindings, Restricted Project
Jaehyun_Cho created T8012: Support default values @property's keys and method's params in eo.
Jun 10 2019, 2:51 AM · efl: language bindings, Restricted Project

Jun 7 2019

Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

I have thought about APIs for push/pop and I think that the following 3 methods are sufficient for our push/pop usecase.

Jun 7 2019, 2:52 AM · efl

Jun 6 2019

Jaehyun_Cho accepted D9074: efl_ui_active_view: fix view_manager_scroll.
Jun 6 2019, 10:52 PM · efl
Jaehyun_Cho accepted D9073: efl_ui_active_view: fix plain view_manager.
Jun 6 2019, 7:45 PM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

What is active_view_pack / active_view_unpack doing ?

Jun 6 2019, 7:11 PM · efl

Jun 5 2019

Jaehyun_Cho closed T7959: efl_canvas_gesture: remove or modify @property type as Resolved.

This is resolved by D9033

Jun 5 2019, 4:34 AM · Restricted Project
Jaehyun_Cho closed D9033: efl_gesture_manager: Delete type property..
Jun 5 2019, 4:33 AM · efl
Jaehyun_Cho accepted D9033: efl_gesture_manager: Delete type property..
Jun 5 2019, 4:30 AM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

To support push/pop, I write specification for push and pop.
(The names, push and pop, can be changed)

Jun 5 2019, 4:19 AM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

I tested it and I found a problem.
As you know, unpack does not delete the content so the content should be deleted by developer manually.
Therefore, it becomes the same as developer registers callback for transition finish and delete the content manually ;(

Jun 5 2019, 2:20 AM · efl

Jun 4 2019

Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

I thought more about your suggestion about fix.

Jun 4 2019, 11:31 PM · efl
Jaehyun_Cho added a comment to D8920: efl_ui_stack: remove!.

As you mentioned, we have animation issues on pop with only using gravity. Because the unpacked view cannot be in the pop animation.

Jun 4 2019, 11:12 PM · efl
Jaehyun_Cho closed D9067: efl_ui_layout_orientation: fix the bitwise condition logic.
Jun 4 2019, 4:15 AM · efl
Jaehyun_Cho accepted D9067: efl_ui_layout_orientation: fix the bitwise condition logic.
Jun 4 2019, 4:13 AM · efl

May 30 2019

Jaehyun_Cho accepted D8784: efl_ui_active_view: introduce a experimental new widget.

Good Catch,

With this done, i have submitted https://travis-ci.org/Enlightenment/efl/branches. When this build succeeded, i will land the 3 accepted revisions, okay ?

May 30 2019, 2:34 AM · efl
Jaehyun_Cho accepted D8907: efl.ui.pager: remove!.

Thank you :)

May 30 2019, 1:36 AM · efl
Jaehyun_Cho accepted D8906: efl_ui_tab_pager: migrate to active_view.

I see~ Thank you :)

May 30 2019, 1:21 AM · efl

May 29 2019

Jaehyun_Cho added a comment to D8906: efl_ui_tab_pager: migrate to active_view.

I've found out that the different scroll transition happens because efl_ui_active_view_active_index_set is called twice.
This causes efl_ui_active_view_active_index_set called with the same index value again.
e.g. if now active view: 0, new active view: 2, active view becomes from 0 to 2 and from 2 to 2.

May 29 2019, 11:45 PM · efl
Jaehyun_Cho added a comment to D8906: efl_ui_tab_pager: migrate to active_view.

Thank you! :)

May 29 2019, 10:59 PM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

Thank you! :)

May 29 2019, 10:44 PM · efl
Jaehyun_Cho requested changes to D8906: efl_ui_tab_pager: migrate to active_view.

I applied the latest D8784 and I tested again.

May 29 2019, 5:35 AM · efl
Jaehyun_Cho added inline comments to D8784: efl_ui_active_view: introduce a experimental new widget.
May 29 2019, 5:25 AM · efl
Jaehyun_Cho added inline comments to D8784: efl_ui_active_view: introduce a experimental new widget.
May 29 2019, 5:21 AM · efl
Jaehyun_Cho accepted D8906: efl_ui_tab_pager: migrate to active_view.
May 29 2019, 5:19 AM · efl
Jaehyun_Cho added inline comments to D8906: efl_ui_tab_pager: migrate to active_view.
May 29 2019, 5:18 AM · efl
Jaehyun_Cho added a comment to D8906: efl_ui_tab_pager: migrate to active_view.

It seems that the scroll transition issue happens because the same active index is set again.

May 29 2019, 5:16 AM · efl
Jaehyun_Cho requested changes to D8906: efl_ui_tab_pager: migrate to active_view.
May 29 2019, 5:07 AM · efl
Jaehyun_Cho added a comment to D8906: efl_ui_tab_pager: migrate to active_view.

I tested the tab pager example but I found some weird scroll transition when I drag the views.
(selecting tab is ok but if I drag view with scroll transition, then the scroll transition look weird)

May 29 2019, 3:58 AM · efl
Jaehyun_Cho requested changes to D8784: efl_ui_active_view: introduce a experimental new widget.

Please delete callbacks in invalidate.
(This can be tested on D8906)

May 29 2019, 3:32 AM · efl
Jaehyun_Cho closed D9032: efl_ui_relative_layout: prevent infinite loop in chain calculation.
May 29 2019, 1:31 AM · efl
Jaehyun_Cho closed D9029: efl_ui_relative_layout: allow to respect the min size of its child.
May 29 2019, 1:31 AM · efl