Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (264 w, 6 d)
Availability
Available

Recent Activity

Yesterday

Jaehyun_Cho closed D6779: efl_ui_tab_bar: implement select key bindings..
Mon, Aug 20, 11:52 PM · efl
Jaehyun_Cho accepted D6779: efl_ui_tab_bar: implement select key bindings..
Mon, Aug 20, 11:31 PM · efl
Jaehyun_Cho added a comment to T7241: Removing underline('_') in class name in C# bindings.

The underline is preserved in widget part name strings.
(e.g. parts back_button in efl/src/lib/elementary/efl_ui_navigation_bar.eo is converted to Back_button in efl/src/lib/elementary/efl_ui_navigation_bar.eo.cs)

Mon, Aug 20, 1:32 AM · efl: language bindings
Jaehyun_Cho updated the task description for T7241: Removing underline('_') in class name in C# bindings.
Mon, Aug 20, 1:31 AM · efl: language bindings

Mon, Aug 13

Jaehyun_Cho requested changes to D6779: efl_ui_tab_bar: implement select key bindings..
Mon, Aug 13, 9:35 PM · efl
Jaehyun_Cho added a comment to D6779: efl_ui_tab_bar: implement select key bindings..

Please update config_version as @YOhoho asked.

Mon, Aug 13, 9:25 PM · efl
Jaehyun_Cho added a comment to D6762: tests/naviframe: add test to verify preserve_on_pop functionality.

Thank you! As soon as D6823 is pushed into master, I will push this patch to master.

Mon, Aug 13, 8:09 PM · Restricted Project, efl: widgets
Jaehyun_Cho added a reviewer for D6823: theme: add programs for deferred naviframe push/pop signals: Hermet.
Mon, Aug 13, 8:07 PM · efl
Jaehyun_Cho updated the summary of D6823: theme: add programs for deferred naviframe push/pop signals.
Mon, Aug 13, 8:07 PM · efl
Jaehyun_Cho requested review of D6823: theme: add programs for deferred naviframe push/pop signals.
Mon, Aug 13, 7:47 PM · efl
Jaehyun_Cho added a comment to D6762: tests/naviframe: add test to verify preserve_on_pop functionality.

When I applied this patch and do "make check", then this test did not end.

Mon, Aug 13, 5:41 AM · Restricted Project, efl: widgets
Jaehyun_Cho requested changes to D6761: theme: add glob for deferred naviframe push/pop signals.

The purpose of normal push/pop signals and deferred push/pop signals are different.

Mon, Aug 13, 12:01 AM · Restricted Project, efl: widgets

Sun, Aug 12

Jaehyun_Cho closed T7236: elm_naviframe_content_preserve_on_pop_set seems to not work as Resolved by committing rEFLa8421fc0c002: elm/naviframe: implement invalidate method for naviframe items.
Sun, Aug 12, 11:09 PM · efl (efl-1.21), efl: widgets, regression, Bug Report
Jaehyun_Cho closed D6759: elm/naviframe: implement invalidate method for naviframe items.
Sun, Aug 12, 11:09 PM · efl: widgets
Jaehyun_Cho accepted D6759: elm/naviframe: implement invalidate method for naviframe items.
Sun, Aug 12, 11:07 PM · efl: widgets

Tue, Aug 7

Jaehyun_Cho closed D6770: efl_ui_tab_pager: clean up and remove unnecessary signals..
Tue, Aug 7, 11:21 PM · efl
Jaehyun_Cho accepted D6770: efl_ui_tab_pager: clean up and remove unnecessary signals..
Tue, Aug 7, 11:20 PM · efl
Jaehyun_Cho updated subscribers of T7240: Not allow multi class inheritance in eo.
Tue, Aug 7, 1:34 AM · efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to T7241: Removing underline('_') in class name in C# bindings.

Could you consider that C# bindings replace underline('_') with C# naming rule in cs file? (e.g. List_Default_Item -> ListDefaultItem)

Tue, Aug 7, 1:32 AM · efl: language bindings
Jaehyun_Cho added a comment to T7248: C# Bindings automated TC.

Could you consider that automated TC supports all implements or some implements manually in eo file?

Tue, Aug 7, 1:28 AM · efl: language bindings

Thu, Aug 2

Jaehyun_Cho added a comment to T7248: C# Bindings automated TC.

For now, all methods in eo file become automated TC.

Thu, Aug 2, 10:03 PM · efl: language bindings
Jaehyun_Cho updated subscribers of T7240: Not allow multi class inheritance in eo.
Thu, Aug 2, 9:25 PM · efl: language bindings, Restricted Project
Jaehyun_Cho updated subscribers of T7241: Removing underline('_') in class name in C# bindings.
Thu, Aug 2, 9:24 PM · efl: language bindings
Jaehyun_Cho created T7248: C# Bindings automated TC.
Thu, Aug 2, 9:23 PM · efl: language bindings
Jaehyun_Cho added a comment to T7204: Discussion about C# binding syntax.

Hello @felipealmeida and @lauromoura

Thu, Aug 2, 4:28 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
Jaehyun_Cho closed D6699: evas_events: Fix to set mouse_in state to all pointers in the seat..
Thu, Aug 2, 2:33 AM · efl
Jaehyun_Cho edited projects for T7240: Not allow multi class inheritance in eo, added: efl: language bindings; removed efl.
Thu, Aug 2, 12:21 AM · efl: language bindings, Restricted Project
Jaehyun_Cho created T7241: Removing underline('_') in class name in C# bindings.
Thu, Aug 2, 12:19 AM · efl: language bindings
Jaehyun_Cho added a comment to T7204: Discussion about C# binding syntax.

@felipealmeida Thank you for replying.

Thu, Aug 2, 12:12 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Wed, Aug 1

Jaehyun_Cho created T7240: Not allow multi class inheritance in eo.
Wed, Aug 1, 11:24 PM · efl: language bindings, Restricted Project
Jaehyun_Cho updated the diff for D6699: evas_events: Fix to set mouse_in state to all pointers in the seat..

Modified conditional expression and Moved the declaration of variables to the top of the function to follow coding convention.

Wed, Aug 1, 4:10 AM · efl

Mon, Jul 30

Jaehyun_Cho added a comment to T7204: Discussion about C# binding syntax.

I have some reports and questions about the current EFL C# bindings as follows.

Mon, Jul 30, 7:55 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Jul 16 2018

Jaehyun_Cho edited the content of Maintainers Reviewers.
Jul 16 2018, 3:58 AM · efl

Jun 28 2018

Jaehyun_Cho closed D6470: configure: check if realpath program exists.
Jun 28 2018, 10:43 PM · efl
Jaehyun_Cho updated the test plan for D6470: configure: check if realpath program exists.
Jun 28 2018, 1:24 AM · efl
Jaehyun_Cho updated the diff for D6470: configure: check if realpath program exists.

check if readlink program exists as well

Jun 28 2018, 1:21 AM · efl

Jun 27 2018

Herald added a reviewer for D6470: configure: check if realpath program exists: devilhorns.
Jun 27 2018, 10:31 PM · efl
Jaehyun_Cho abandoned D6469: configure: check if realpath program exists.
Jun 27 2018, 10:28 PM · efl
Herald added a reviewer for D6469: configure: check if realpath program exists: devilhorns.
Jun 27 2018, 10:26 PM · efl

Jun 25 2018

Jaehyun_Cho added a comment to T6903: eina_stringshare_nprintf() accesses uninitialised values.

About the commit e0f8e65d2044d49df4fd6355e7835a5f01d854e7, doesn't the commit break the backward compatibility? (The result of ina_stringshare_nprintf is changed from the past.)

Jun 25 2018, 3:05 AM · efl

Jun 13 2018

Jaehyun_Cho closed T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop as Resolved.

This has been resolved.

Jun 13 2018, 9:56 PM · efl: main loop
Jaehyun_Cho closed T5351: New Naviframe API as Resolved.

This has been resolved.

Jun 13 2018, 9:50 PM · efl (efl-1.21), efl: widgets, Restricted Project
Jaehyun_Cho closed T5351: New Naviframe API, a subtask of T5363: Cleanup elm_widget.eo, as Resolved.
Jun 13 2018, 9:50 PM · efl: widgets, Restricted Project
Jaehyun_Cho closed T5337: Animation framework API for EO as Resolved.

Thanks for letting me know.
This has been resolved. (you may check Efl.Canvas.Animation class)

Jun 13 2018, 9:46 PM · efl (efl-1.21), efl: main loop, Restricted Project
Jaehyun_Cho closed T5337: Animation framework API for EO, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Jun 13 2018, 9:46 PM · Restricted Project, efl, Restricted Project

Jun 4 2018

Jaehyun_Cho closed D6241: elementary: fix wrong signal emission.
Jun 4 2018, 1:48 AM · efl
Jaehyun_Cho accepted D6241: elementary: fix wrong signal emission.
Jun 4 2018, 1:47 AM · efl

Jun 3 2018

Jaehyun_Cho requested changes to D6241: elementary: fix wrong signal emission.

How about adding condition for elm_object_content_set(obj, NULL) case?

Jun 3 2018, 9:58 PM · efl

Jun 1 2018

Jaehyun_Cho added a comment to D6209: theme: attempt to fix failure to correctly namespace uiclock parts.

I think efl_ui_clock.c should support both "elm" namespace for legacy and "efl" namespace for ui interface.

Jun 1 2018, 12:29 AM · efl

May 31 2018

Jaehyun_Cho closed T6971: Hoversel doesn't show the icon anymore as Resolved by committing rEFL4ea4f0486e6a: elm_hoversel: inherit elm_button.
May 31 2018, 7:39 PM · efl, regression
Jaehyun_Cho closed D6240: elm_hoversel: inherit elm_button.
May 31 2018, 7:39 PM · efl
Jaehyun_Cho accepted D6240: elm_hoversel: inherit elm_button.
May 31 2018, 7:35 PM · efl
Jaehyun_Cho closed T6898: verify legacy names for all elm win types, a subtask of T6867: improve test code, as Resolved.
May 31 2018, 5:41 AM · Restricted Project, Restricted Project, Testing
Jaehyun_Cho closed T6898: verify legacy names for all elm win types as Resolved by committing rEFL61dc4899b5c2: elm_win: fix widget type name for backward compatibility.
May 31 2018, 5:41 AM · Testing, efl
Jaehyun_Cho closed T6899: elm_win legacy type names are broken, a subtask of T6898: verify legacy names for all elm win types, as Resolved.
May 31 2018, 5:41 AM · Testing, efl
Jaehyun_Cho closed T6899: elm_win legacy type names are broken as Resolved by committing rEFL61dc4899b5c2: elm_win: fix widget type name for backward compatibility.
May 31 2018, 5:41 AM · efl
Jaehyun_Cho closed D6233: elm_win: fix widget type name for backward compatibility.
May 31 2018, 5:41 AM · efl
Jaehyun_Cho accepted D6233: elm_win: fix widget type name for backward compatibility.
May 31 2018, 5:37 AM · efl
Jaehyun_Cho added a comment to D6231: elm_hoversel: implement content set/unset.

I think the best solution for this issue is to inherit Efl.Ui.Button_Legacy.
What do you think about this?

May 31 2018, 4:34 AM · efl

May 28 2018

Jaehyun_Cho closed D6218: efl_part: remove unnecessary default_xxx_part_get.
May 28 2018, 3:10 AM · efl
Jaehyun_Cho accepted D6218: efl_part: remove unnecessary default_xxx_part_get.
May 28 2018, 1:32 AM · efl

May 27 2018

Jaehyun_Cho closed D6192: efl_ui_popup: use "elm.swallow.content" name instead of "default" for scroller.
May 27 2018, 9:08 PM · efl
Jaehyun_Cho accepted D6192: efl_ui_popup: use "elm.swallow.content" name instead of "default" for scroller.
May 27 2018, 8:56 PM · efl

May 24 2018

Jaehyun_Cho added a comment to D6192: efl_ui_popup: use "elm.swallow.content" name instead of "default" for scroller.

How about calling content_set/unset without part?
i.e. efl_content_set(pd->scroller, pd->message);

May 24 2018, 2:10 AM · efl

May 23 2018

Jaehyun_Cho closed D6185: elm: fix backward compatibility for "default" name part.
May 23 2018, 3:37 AM · efl
Jaehyun_Cho accepted D6185: elm: fix backward compatibility for "default" name part.
May 23 2018, 3:32 AM · efl

May 19 2018

Jaehyun_Cho closed D6044: efl_ui_tags: Fixed bug when setting format string..
May 19 2018, 12:07 PM · efl
Jaehyun_Cho accepted D6044: efl_ui_tags: Fixed bug when setting format string..
May 19 2018, 11:54 AM · efl
Jaehyun_Cho closed D5969: efl_ui_spin: Added special value feature..
May 19 2018, 11:12 AM · efl
Jaehyun_Cho accepted D5969: efl_ui_spin: Added special value feature..
May 19 2018, 10:47 AM · efl
Jaehyun_Cho updated the diff for D5969: efl_ui_spin: Added special value feature..

Rebase code based on the latest master branch and Free array in test_ui_spin_button.c

May 19 2018, 10:34 AM · efl

May 17 2018

Jaehyun_Cho closed D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.
May 17 2018, 2:18 AM · efl
Jaehyun_Cho accepted D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.
May 17 2018, 2:17 AM · efl
Herald added a project to D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop: efl.

Please remove undefined properties and methods from Efl.Ui.Slider in test_ui_scroller.c (e.g. efl_ui_slider_part_indicator_visible_mode_set)

May 17 2018, 12:54 AM · efl

May 15 2018

Jaehyun_Cho closed D6162: elm_slider: fix test suite fail.
May 15 2018, 4:14 AM · efl
Jaehyun_Cho accepted D6162: elm_slider: fix test suite fail.
May 15 2018, 4:12 AM · efl
Jaehyun_Cho retitled D6162: elm_slider: fix test suite fail from slider: fix test suite fail to elm_slider: fix test suite fail.
May 15 2018, 4:11 AM · efl

May 14 2018

Jaehyun_Cho closed D5908: efl_ui_slider: refactor slider widget..
May 14 2018, 10:23 PM · efl
Jaehyun_Cho accepted D5908: efl_ui_slider: refactor slider widget..

The interval changes will be considered in other patch.

May 14 2018, 10:14 PM · efl
Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

In Efl.Ui.Slider_Interval, in herizontal mode, low value is moved by wheel and key but in vertical mode, high value is moved by wheel and key.
IMHO, the same values should be moved. (either low value or high value)

May 14 2018, 6:53 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Fix to install elm_slider.eo.h correctly.
Otherwise, build error occurs on efl application.
Please check the location of elm_slider.eo in Makefile_Elementary.am.

May 14 2018, 6:38 AM · efl

May 7 2018

Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

As I tested elementary_test, the vertical slider with mouse wheel works the opposite direction I think.

May 7 2018, 10:23 PM · efl
Jaehyun_Cho closed T6887: MultibuttonEntry legacy name tests are failing as Resolved.

This issue has been fixed. Thank you :)

May 7 2018, 9:35 PM · efl

May 3 2018

Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

Now this patch is rebased on the latest master.

May 3 2018, 1:00 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Update code to rebase on latest master and to fix errors and warnings.

May 3 2018, 12:47 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Update code to resolve conflict on master

May 3 2018, 12:10 AM · efl

May 2 2018

Jaehyun_Cho added a reviewer for D5908: efl_ui_slider: refactor slider widget.: Jaehyun_Cho.
May 2 2018, 5:22 AM · efl
Jaehyun_Cho closed D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.
May 2 2018, 5:19 AM
Jaehyun_Cho accepted D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.
May 2 2018, 5:09 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

test_efl_ui_tab_pager is changed to test_ui_tab_pager to synchronize with other cases.

May 2 2018, 4:54 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

The following diff is added to this patch to apply new theme naming rule.
Otherwise, page content set and transition do not work.

May 2 2018, 4:36 AM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
In D6008#102810, @zmike wrote:
In D6008#102804, @zmike wrote:

This patch should not have been accepted as it contains non-namespaced parts. T6911

@zmike

Sorry I checked your email from the mailing list after submitting this patch.

I've uploaded a patch to change the part names (b8de04d77f63f5f305b0ccd2670f1d908ba4bf7d)

Thanks!

Do you think it would be useful to have something which automatically checks the default theme for this during build to avoid future issues?

May 2 2018, 4:08 AM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
In D6008#102804, @zmike wrote:

This patch should not have been accepted as it contains non-namespaced parts. T6911

May 2 2018, 3:47 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

The following diffs are added to this patch to support unpack and to fix elementary_test errors (win ref error and unpack crash).

May 2 2018, 3:29 AM
Jaehyun_Cho closed D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
May 2 2018, 1:30 AM
Jaehyun_Cho accepted D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
May 2 2018, 1:22 AM
Jaehyun_Cho updated the summary of D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
May 2 2018, 1:09 AM

May 1 2018

Jaehyun_Cho requested changes to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please check the comments.

May 1 2018, 9:43 PM

Apr 26 2018

Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please change to "Efl.Ui.Tags" for the test case name.

Apr 26 2018, 11:45 PM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please remove unused variables to remove warnings.

Apr 26 2018, 11:43 PM