- User Since
- Jul 24 2013, 3:26 AM (320 w, 6 d)
As I mentioned in D10001, some words are used as verb in some method names and they are used as noun in other method names.
To resolve this problem, we may need to introduce a new eo syntax.
add ref T8225
Fixed not to keep array and rebased
Mon, Sep 16
fixing memory leak in efl_ui_widget_factory.c is included
rename the error name
Tue, Sep 10
I cannot find a proper way to install Efl.Csharp.1.23.0.nupkg on Visual Studio Code on Ubuntu.
But that .nupkg can be installed Visual Studio on Windows.
Thank you. This patch wisely removes the redundant event callbacks. I think it's nice :)
After applying this patch, it seems that efl_sharp.dll is not installed.
efl_sharp.dll is created in efl/core/efl/build/src/bindings/mono/efl_sharp.dll but it is not installed in /usr/local/...
The declarations of evas_object_callback_init() and evas_object_callback_shutdown() in evas_private.h are required to be removed.
Fri, Sep 6
One minor thing.
Thu, Sep 5
I've left some comments based on the test result of "Navigation stack" in elementary test.
Wed, Sep 4
It is confirmed that SA1402 is not mandatory but it is recommended.
I will ask the reporter who raised this issue in detail and I will let you know.
Honestly, I dont have enough knowledge about canvas object's event so I cannot judge your idea.. :(
As you said we should ask canvas people about it.
@YOhoho and I found an issue related to this patch.
Tue, Sep 3
This may be hard with meson. See my first comment on its limitations.
I totally understand. If it is hard on upstream with meson, then I consider that I run some script manually to generate directories and change the cs names only for Tizen.
Mon, Sep 2
The main issues of this task are as follows.
Thank you for this patch! :)
For now, I've removed the underscore of Evt_Args by ac99e2ac9410d5b2ef6225fa1aaaf9ffcd6578fb
As we discussed, this patch is basically additional manual binding specific for being able to associate native object to an eo object.
I don't know well about the original purpose of T7383 but the related tasks are mainly about how to support config set easily in EFL#.
Fri, Aug 30
Sorry about replying late.. ;)
Can we change this task name?
Fri, Aug 23
Could you please consider this task?
Wed, Aug 21
Tue, Aug 20
I have the same opinions with @SanghyeonLee for 1, 2, 3.
Mon, Aug 19
Aug 16 2019
Aug 14 2019
Aug 4 2019
It seems that this task is related to T8057.
Aug 2 2019
No, there is no information about the initial time interval.
So I think there is no problem of applying 0.25 second here :)
Aug 1 2019
@YOhoho Thank you very much for your comment! :) I did not know that. I also updated the commit message as well. When I modified time interval from 0.5 to 0.25, I think that repeated counter is calculated fine for double click and triple click.
Is there a use case that developers use the value "repeated"?
thank you :)
@bu5hm4n I haven't started yet. It's ok if you go with this :) Are you thinking of implementing all (Selectable for item + Selectable for container) ?
@bu5hm4n I agree with this patch~ If you also agree with this patch, then I will submit this patch~ :)
Jul 31 2019
I restored the code that initially creates and packs pages in stack example.
I also fixed the code of future_then_cb to check eina_value correctly in stack example.
@bu5hm4n Thank you very much for the comment! It corrects this patch clearly and easily :)
BTW, I return efl_loop_future_resolved although the content is deleted. It seems that other content deleted case returns future with NULL Eina_Value.
There is one thing related to this patch.
Jul 30 2019
@bu5hm4n Thank you for the comment :) I added the condition to check if mouse move is active.
Jul 29 2019
Added commit message related task T8040
Jul 24 2019
I totally agree with you creating a ticket to discuss general things and concepts.
Jul 23 2019
Like D9304, this patch is to keep @owned mark for Eo handle.
I think we need to discuss if it is appropriate that we allow @owned for Eo handle to pass ownership from caller to callee.
- Eo handle cannot be exclusively possessed
Jul 22 2019
I don't know how important of using integer values instead of continuous indices for Radio_Buttons.
I think that the use case you mentioned is so special and specific case.
IMO, most of the cases, it appears that user feels no difficulties when they use continuous numbers for Radio_Buttons.
I understand the convenience of state_value.
Jul 21 2019
About state_value of Efl.Ui.Radio_Button, I would like to let's think if we really need this property.
Jul 19 2019
If you say we need interface because SingleSelectable interface does not have (P) selected_object, then we can add it to Single_Selectable interface, right?
Since register() and unregister() is not required to be called by user with radio group container and all the selected methods are provided in SingleSelectable interface, it would be the same.
User calls select(), unselect(), and other selected methods which may not be written by me in the proposal.
Jul 18 2019
If Radio_Group becomes a class based on the proposal, your design to turn any container into radio group container works.
I created https://phab.enlightenment.org/T8057 for refactoring interface Efl.Ui.Selectable.
Jul 17 2019
I left a comment on efl_ownable in D9304.
I agree with you that we should avoid manipulation of user's object as far as possible
Jul 16 2019
After thinking about ownership a while, somehow I understand your opinion about ownership.
(If I understand you correctly, you think that user should understand ownership and user should do the right thing for ownership)
Related to the Radio_Button, what do you think about Efl.Ui.Check inherits from Efl.Ui.Button?
Thank you for suggestion! :)
The following is my initial comment in T7867 of this comment threads.. ;)
Jul 15 2019
Honestly, I think that developers don't know why they should not use efl_add for spotlight manager.
Although they read description of the manager_set() and @owned, they still don't know why efl_add is not allowed.