Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (286 w, 6 d)
Availability
Available

Recent Activity

Thu, Jan 17

Jaehyun_Cho closed D7667: elm_panel: fix visibility when switching scrollable mode.
Thu, Jan 17, 2:07 AM · efl

Wed, Jan 16

Jaehyun_Cho closed D7409: gfx: Add size hint fill (EO).
Wed, Jan 16, 12:18 AM · efl

Tue, Jan 15

Jaehyun_Cho accepted D7409: gfx: Add size hint fill (EO).

@YOhoho
Thank you for the patch and updates! It is nice :)

Tue, Jan 15, 11:44 PM · efl
Jaehyun_Cho added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

@bu5hm4n
I mean that your patch is good. There is no problem on that.
But I was not sure if it was sufficient to close this task.
(But now I think that this task is to evaluate the main task so it is ok this task is closed)

Tue, Jan 15, 4:38 AM · efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to T7506: efl-mono: Add support for global constants.

@segfaultxavi
Thank you for searching! :)

Tue, Jan 15, 4:20 AM · efl: language bindings
Jaehyun_Cho closed D7537: efl-mono: Only raise exception for managed errors..
Tue, Jan 15, 1:37 AM · efl
Jaehyun_Cho accepted D7537: efl-mono: Only raise exception for managed errors..

@lauromoura
Thank you for the patch :)

Tue, Jan 15, 12:50 AM · efl

Mon, Jan 14

Jaehyun_Cho added a comment to D7409: gfx: Add size hint fill (EO).

@YOhoho
Could you please check the comments?

Mon, Jan 14, 3:23 AM · efl

Sun, Jan 13

Jaehyun_Cho added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

@bu5hm4n
Regarding resolving this task with 3ddd577fb0c67b1867c6664af42a89652134c73a, I want to discuss about it.
I understand that the patch forbid a regular class to inherit from a new regular class from mixin.

Sun, Jan 13, 11:14 PM · efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to D7537: efl-mono: Only raise exception for managed errors..

@lauromoura
What do you think about @segfaultxavi 's opinion?

Sun, Jan 13, 10:48 PM · efl
Jaehyun_Cho added a reviewer for D7597: efl_mono: remove '_' from type for C# naming convention: segfaultxavi.
Sun, Jan 13, 8:44 PM · efl
Jaehyun_Cho added a comment to D7597: efl_mono: remove '_' from type for C# naming convention.

Thank you for your comment :)
I updated commit message.

Sun, Jan 13, 8:43 PM · efl
Jaehyun_Cho updated the summary of D7597: efl_mono: remove '_' from type for C# naming convention.
Sun, Jan 13, 8:41 PM · efl

Thu, Jan 10

Jaehyun_Cho requested review of D7597: efl_mono: remove '_' from type for C# naming convention.
Thu, Jan 10, 11:54 PM · efl

Fri, Jan 4

Jaehyun_Cho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Could you move the definition of struct Efl.Ui.Relative_Params to efl_ui_relative.eo file?

Fri, Jan 4, 3:18 AM · efl
Jaehyun_Cho accepted D7537: efl-mono: Only raise exception for managed errors..

Thank you for this patch :) It looks fine to me.

Fri, Jan 4, 12:18 AM · efl
Jaehyun_Cho updated the diff for D7537: efl-mono: Only raise exception for managed errors..

update examples to fix build error

Fri, Jan 4, 12:15 AM · efl

Tue, Jan 1

Jaehyun_Cho added a comment to T7512: efl.ui.layout.

Thank you for sharing the lua code :)

Tue, Jan 1, 10:11 PM · efl (efl-1.22), efl: language bindings

Dec 20 2018

Jaehyun_Cho added a comment to T7512: efl.ui.layout.

Could you share print_hierarchy.lua? :)

Dec 20 2018, 6:17 PM · efl (efl-1.22), efl: language bindings
Jaehyun_Cho accepted D7420: theme: hide next and prev buttons when title is hidden.

Thank you :)

Dec 20 2018, 4:29 AM · efl
Jaehyun_Cho added a comment to T7408: Fix consistency of the Interfaces Hierarchy.

If we only talk about namespaces under "Efl.", then it would be as follows.
(I only write namespaces except class, abstract, interface, mixin name itself)

Dec 20 2018, 4:13 AM · Restricted Project, efl, Restricted Project
Jaehyun_Cho added a comment to T7408: Fix consistency of the Interfaces Hierarchy.
Dec 20 2018, 3:49 AM · Restricted Project, efl, Restricted Project
Jaehyun_Cho closed D7455: elm_widget: remove defines that are not implemented.
Dec 20 2018, 2:56 AM · efl

Dec 19 2018

Jaehyun_Cho accepted D7455: elm_widget: remove defines that are not implemented.

Thank you for reply :)

Dec 19 2018, 11:21 PM · efl
Jaehyun_Cho added a comment to D7455: elm_widget: remove defines that are not implemented.

Thank you :) No one noticed the existence of these variables!

Dec 19 2018, 9:41 PM · efl
Jaehyun_Cho added a comment to D7420: theme: hide next and prev buttons when title is hidden.

Thank you for update :)

Dec 19 2018, 6:50 PM · efl
Jaehyun_Cho closed D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).
Dec 19 2018, 6:33 PM · efl
Jaehyun_Cho accepted D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).
Dec 19 2018, 6:31 PM · efl

Dec 18 2018

Jaehyun_Cho requested changes to D7420: theme: hide next and prev buttons when title is hidden.

I think that the added program signal is duplicated.

Dec 18 2018, 9:02 PM · efl
Jaehyun_Cho added a comment to D7420: theme: hide next and prev buttons when title is hidden.

The reason why I want to modify theme is because there is no rule prev_btn and next_btn should be inside the title area.

Dec 18 2018, 4:26 AM · efl
Jaehyun_Cho added a comment to D7420: theme: hide next and prev buttons when title is hidden.

How about changing the state of "elm.swallow.prev_btn" and "elm.swallow.next_btn" in naviframe.edc instead of code change?

Dec 18 2018, 4:17 AM · efl
Jaehyun_Cho requested changes to D7409: gfx: Add size hint fill (EO).

"EFL_GFX_SIZE_HINT_FILL" with "hint_align_set" still exists in code.

Dec 18 2018, 3:29 AM · efl
Jaehyun_Cho added a comment to T5319: Refactor scrollable mixin.

Could you let me know the progress of this task if it is done?

Dec 18 2018, 12:12 AM · efl: widgets, Restricted Project

Dec 17 2018

Jaehyun_Cho added a comment to T5735: loading status property in canvas/ui image.

As far as I see, the main purpose of this task is to implement Efl.Gfx.Image_Load_Controller.load_state { get; } in Efl.Canvas.Image.

Dec 17 2018, 9:49 PM · efl: rendering, Restricted Project
Jaehyun_Cho closed T6463: efl.text.properties should be removed as Resolved.

This task is done by the patch f85325d924d93e84ffee08b7bffd39d33347998f

Dec 17 2018, 9:21 PM · Restricted Project, efl (efl-1.22)
Jaehyun_Cho closed T6463: efl.text.properties should be removed, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Dec 17 2018, 9:21 PM · Restricted Project, efl, Restricted Project
Jaehyun_Cho closed D7411: efl_canvas_surface: change mixin to abstract.
Dec 17 2018, 6:26 PM · efl
Jaehyun_Cho added a comment to T5378: New filter APIs for copy and paste text hooking.

Could you tell us what the current status of this task is?

Dec 17 2018, 6:22 PM · efl: rendering, Restricted Project
Jaehyun_Cho added a comment to T5719: Force all apis to be implemented.

are you going to submit your patch to master branch?

Dec 17 2018, 6:12 PM · Restricted Project, efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to T5735: loading status property in canvas/ui image.
Dec 17 2018, 4:34 AM · efl: rendering, Restricted Project

Dec 16 2018

Jaehyun_Cho added a comment to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

This new class name is Efl.Access_Event_Handler.

Dec 16 2018, 10:24 PM · efl
Jaehyun_Cho added a comment to T7408: Fix consistency of the Interfaces Hierarchy.

We need to decide which name is categorized as a namespace and which is not.

Dec 16 2018, 10:03 PM · Restricted Project, efl, Restricted Project
Jaehyun_Cho added inline comments to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Dec 16 2018, 9:16 PM · efl
Jaehyun_Cho added a comment to D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).

please remove the typo

Dec 16 2018, 6:58 PM · efl

Dec 6 2018

Jaehyun_Cho requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

Class name cannot be used as a namespace.

Dec 6 2018, 3:51 AM · efl
Jaehyun_Cho added a comment to T7492: Support libpng16.

Oh! Really?
I got reported that edje_cc which is compiled on Ubuntu 16.04 does not work on Ubuntu 18.04 since Ubuntu 18.04 does not support libpng12.

Dec 6 2018, 1:54 AM · Restricted Project
Jaehyun_Cho added a comment to D7419: evas_box: fix calculation logic when item's weight is 0.0..

Could you give some comments on this patch? :)

Dec 6 2018, 12:36 AM · efl

Dec 5 2018

Jaehyun_Cho created T7492: Support libpng16.
Dec 5 2018, 5:29 PM · Restricted Project
Jaehyun_Cho closed D7407: efl_ui_tab_bar: fix error about double free.
Dec 5 2018, 3:28 AM · efl
Jaehyun_Cho accepted D7407: efl_ui_tab_bar: fix error about double free.
Dec 5 2018, 3:21 AM · efl

Dec 4 2018

Jaehyun_Cho closed D7302: efl_ui_win: enable bg color set although alpha is set.
Dec 4 2018, 5:58 PM · efl
Jaehyun_Cho requested review of D7411: efl_canvas_surface: change mixin to abstract.
Dec 4 2018, 4:56 AM · efl
Jaehyun_Cho added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

Thank you for clear summarize.

Dec 4 2018, 4:34 AM · Restricted Project

Dec 3 2018

Jaehyun_Cho added a comment to D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).

How about we use one group for scr_edje and panel_edje? (i.e. efl/panel)

Dec 3 2018, 4:27 AM · efl
Jaehyun_Cho updated the diff for D7238: Intruduce Efl.Ui.Panel (Create Efl Ui Widget from elm widget(elm_panel)).

rebase based on Efl.Ui.Layout class

Dec 3 2018, 3:18 AM · efl

Nov 29 2018

Jaehyun_Cho added a comment to D7373: efl_access: change Efl.Access.Object from mixin to interface.

Yes, you are right. It is not easy to apply composite object to all mixin cases automatically. So it is a problem..

Nov 29 2018, 4:37 AM · efl

Nov 28 2018

Jaehyun_Cho added a comment to D7373: efl_access: change Efl.Access.Object from mixin to interface.

I understand your point.
I think that you mean that Efl.Access.Object should be changed to a regular class and all elementary widget classes inherit from Efl.Access.Object to inherit from Efl.Object.

Nov 28 2018, 6:12 PM · efl
Jaehyun_Cho added a comment to D7373: efl_access: change Efl.Access.Object from mixin to interface.

Thank you for review :)

Nov 28 2018, 6:06 PM · efl

Nov 27 2018

Jaehyun_Cho requested review of D7373: efl_access: change Efl.Access.Object from mixin to interface.
Nov 27 2018, 9:46 PM · efl

Nov 26 2018

Jaehyun_Cho added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

I agree with you :)

Nov 26 2018, 11:11 PM · Restricted Project

Nov 25 2018

Jaehyun_Cho added a comment to T7375: Support widget styles in C# bindings.

could you share the current status of supporting widget style in constructor in C#?

Nov 25 2018, 9:09 PM · efl

Nov 22 2018

Jaehyun_Cho added a comment to T7356: EO: Support elm_config APIs.

Is there any suggestion to rename class "Config" which mainly supports Init() and Shutdown()?
(e.g. efl.ui.Config, eina.Config, ...)

Nov 22 2018, 11:38 PM · efl, Restricted Project
Jaehyun_Cho closed D7241: Remove duplicated interface inheritance in eo.
Nov 22 2018, 12:24 AM · efl
Jaehyun_Cho accepted D7241: Remove duplicated interface inheritance in eo.
Nov 22 2018, 12:20 AM · efl
Jaehyun_Cho updated the summary of D7241: Remove duplicated interface inheritance in eo.
Nov 22 2018, 12:19 AM · efl
Jaehyun_Cho updated the diff for D7241: Remove duplicated interface inheritance in eo.

rebase

Nov 22 2018, 12:18 AM · efl

Nov 21 2018

Jaehyun_Cho abandoned D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup.

d4526f44b8c20010061c42a87ac0496796311afb replaces this patch and it has been submitted to master.

Nov 21 2018, 11:30 PM · efl
Jaehyun_Cho commandeered D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup.
Nov 21 2018, 11:30 PM · efl
Herald added a project to D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup: efl.

d4526f44b8c20010061c42a87ac0496796311afb replaces this patch and it has been submitted to master.

Nov 21 2018, 11:30 PM · efl
Jaehyun_Cho abandoned D5846: efl_ui_text_alert_popup: rename from efl_ui_popup_alert_text to efl_ui_text_alert_popup.

d4526f44b8c20010061c42a87ac0496796311afb replaces this patch and it has been submitted to master.

Nov 21 2018, 11:29 PM · efl
Jaehyun_Cho commandeered D5846: efl_ui_text_alert_popup: rename from efl_ui_popup_alert_text to efl_ui_text_alert_popup.
Nov 21 2018, 11:28 PM · efl
Herald added a project to D5846: efl_ui_text_alert_popup: rename from efl_ui_popup_alert_text to efl_ui_text_alert_popup: efl.

d4526f44b8c20010061c42a87ac0496796311afb replaces this patch and it has been submitted to master.

Nov 21 2018, 11:28 PM · efl
Jaehyun_Cho abandoned D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

Based on @herb 's comment, this patch is abandoned.

Nov 21 2018, 11:24 PM · efl
Jaehyun_Cho commandeered D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.
Nov 21 2018, 11:24 PM · efl
Jaehyun_Cho abandoned D5726: efl_ui_popup: add efl_ui_bg interface to backwall part.

Instead of this patch, 743e0468e910a4f0928bcbf8f7547203108f0d78 has been submitted to master.

Nov 21 2018, 11:23 PM · efl
Jaehyun_Cho commandeered D5726: efl_ui_popup: add efl_ui_bg interface to backwall part.
Nov 21 2018, 11:22 PM · efl
Jaehyun_Cho added a comment to D5726: efl_ui_popup: add efl_ui_bg interface to backwall part.

Instead of this patch 743e0468e910a4f0928bcbf8f7547203108f0d78 has been submitted to master.

Nov 21 2018, 11:22 PM · efl

Nov 20 2018

Jaehyun_Cho added a comment to D7303: Efl.Ui.Box: Add box custom layout set method..

How is it possible that elementary_test already had a test for this functionality if you are adding it in this patch?

Nov 20 2018, 4:38 AM · efl

Nov 19 2018

Jaehyun_Cho closed T7357: EO: Support elm_theme APIs as Resolved by committing rEFL4f9c8d524c77: efl_ui_theme: Introduce Efl.Ui.Theme class.
Nov 19 2018, 8:58 PM · efl, Restricted Project
Jaehyun_Cho closed T7357: EO: Support elm_theme APIs, a subtask of T7142: efl 2.0 considerations, as Resolved.
Nov 19 2018, 8:58 PM · Restricted Project, efl
Jaehyun_Cho closed D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.
Nov 19 2018, 8:58 PM · efl
Jaehyun_Cho updated the diff for D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.

Modified the enum name from "failed" to "fail" to be a noun like "success".
(from EFL_UI_THEME_APPLY_RESULT_FAILED to EFL_UI_THEME_APPLY_RESULT_FAIL)

Nov 19 2018, 8:40 PM · efl
Jaehyun_Cho closed D7304: efl_ui_bg: remove Efl.Ui.Bg interface and rename Efl.Ui.Bg_Widget class.
Nov 19 2018, 5:33 PM · efl
Jaehyun_Cho added a comment to D7304: efl_ui_bg: remove Efl.Ui.Bg interface and rename Efl.Ui.Bg_Widget class.

Thank you for reviewing! :)

Nov 19 2018, 5:24 PM · efl
Jaehyun_Cho requested review of D7304: efl_ui_bg: remove Efl.Ui.Bg interface and rename Efl.Ui.Bg_Widget class.
Nov 19 2018, 4:37 AM · efl
Jaehyun_Cho added a reviewer for D7303: Efl.Ui.Box: Add box custom layout set method.: segfaultxavi.
Nov 19 2018, 4:36 AM · efl
Jaehyun_Cho requested changes to D7303: Efl.Ui.Box: Add box custom layout set method..

I left a trivial suggestion which changes the variable names of callback and data.

Nov 19 2018, 4:18 AM · efl
Jaehyun_Cho added reviewers for D7302: efl_ui_win: enable bg color set although alpha is set: zmike, devilhorns, woohyun.
Nov 19 2018, 3:19 AM · efl
Jaehyun_Cho updated the diff for D7302: efl_ui_win: enable bg color set although alpha is set.

update comments

Nov 19 2018, 3:14 AM · efl
Jaehyun_Cho requested review of D7302: efl_ui_win: enable bg color set although alpha is set.
Nov 19 2018, 3:09 AM · efl

Nov 18 2018

Jaehyun_Cho added a comment to D7249: C# bindings: Make efl_gesture_Manager.eo available to bindings.

@CHAN
I think we can make gesture cs files after we verify that gesture interface works on C#.

Nov 18 2018, 10:29 PM · efl
Jaehyun_Cho added a comment to D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.

Please give some comments or feedback on this patch :)

Nov 18 2018, 8:42 PM · efl
Jaehyun_Cho added a reviewer for D7244: efl_ui_theme: Introduce Efl.Ui.Theme class: zmike.
Nov 18 2018, 8:40 PM · efl
Jaehyun_Cho added a comment to T7358: EO: Support ecore_event APIs.

Thank you for the feedbacks :)
Then, let's think about handling events by "Efl.App" when it becomes necessary.

Nov 18 2018, 7:19 PM · efl, Restricted Project
Jaehyun_Cho added a comment to T7358: EO: Support ecore_event APIs.

@segfaultxavi

regarding your first point, do you want the app to be able to intercepting any event before it is processed by anybody else?

Yes. In android, "activity" handles events before "view" handles it.
The android's "activity" is similar to EFL's "Efl.App" so I wanted to provide a way to let "Efl.App" handles events like the android's "activity" does.

Nov 18 2018, 7:13 PM · efl, Restricted Project

Nov 16 2018

Jaehyun_Cho added a task to D7244: efl_ui_theme: Introduce Efl.Ui.Theme class: T7357: EO: Support elm_theme APIs.
Nov 16 2018, 2:50 AM · efl
Jaehyun_Cho added a revision to T7357: EO: Support elm_theme APIs: D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.
Nov 16 2018, 2:50 AM · efl, Restricted Project
Jaehyun_Cho updated the diff for D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.

updated as @segfaultxavi commented

Nov 16 2018, 2:49 AM · efl
Jaehyun_Cho added a comment to T7457: EO: Synchronize class naming rule.

Thank you :)

Nov 16 2018, 1:28 AM · efl: api
Jaehyun_Cho added reviewers for D7292: elementary: rename Efl.Ui.Popup classes: segfaultxavi, bu5hm4n, cedric.
Nov 16 2018, 1:20 AM · efl