Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (303 w, 6 d)
Availability
Available

Recent Activity

Fri, May 17

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I apologize. I've submitted a patch to fix it. 099eb2c315a277bda10f41709d7f936b0ae7fb20

Fri, May 17, 3:53 AM · DO NOT MERGE, efl

Tue, May 14

Jaehyun_Cho closed D8896: Makefile_Cxx: add include dependency with evas/gesture.
Tue, May 14, 11:14 PM · efl
Jaehyun_Cho accepted D8896: Makefile_Cxx: add include dependency with evas/gesture.
Tue, May 14, 11:13 PM · efl
Jaehyun_Cho added a comment to T7959: efl_canvas_gesture: remove or modify @property type.

That's right~
Thank you :)

Tue, May 14, 5:38 AM · Restricted Project
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I think we need to consider the lazy loading method or event callback.
This can be separated into the following 2 scenarios.

Tue, May 14, 5:34 AM · efl
Jaehyun_Cho added a comment to T7959: efl_canvas_gesture: remove or modify @property type.

I think that removing @property type is better.

Tue, May 14, 5:01 AM · Restricted Project
Jaehyun_Cho created T7959: efl_canvas_gesture: remove or modify @property type.
Tue, May 14, 4:01 AM · Restricted Project
Jaehyun_Cho closed D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Tue, May 14, 12:38 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Tue, May 14, 12:36 AM · DO NOT MERGE, efl
Jaehyun_Cho updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

rebase

Tue, May 14, 12:35 AM · DO NOT MERGE, efl

Mon, May 13

Jaehyun_Cho updated subscribers of D8784: efl_ui_active_view: introduce a experimental new widget.

I think you understand me that I do not want to make argument but I also want to make our widgets better than now like you :)
I asked @Hermet a piece of advice about this concept and I realized some of my assumption may not be right from other point of view.

Mon, May 13, 11:44 PM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

Beyond the name of Single_Display, I still think that we should separate Pager and Stack.

Mon, May 13, 4:48 AM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

About Single_Display, now I understand your point. However, at least I needed your explanation to understand the meaning of it.

Mon, May 13, 4:47 AM · efl

Fri, May 10

Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

@Jaehyun_Cho

@segfaultxavi and I have been brainstomring about a new name for this. We came up with the following scheme:

Efl.Ui.Single_Display.Container -> The container itself, what Efl.Ui.Smart_Container is right now
Efl.Ui.Single_Display.ViewManager -> manages the animation / user interaction / can manage additional stuff and settings.
Efl.Ui.Single_Display.Indicator -> What Indicator is right now

What do you think ? IMO this expresses better what it does, and a page_size on a ViewManager sounds more realistic then on a transition object.

Fri, May 10, 3:03 AM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.
class Efl.Ui.Smart_Container.Util:
   @class stack : Efl.Ui.Stack_Container : This functions returns you a ready configured object which can be used just like a created stack object.
   @class pager : Efl.Ui.Stack_Container : The same as above, just for pager.
Fri, May 10, 2:40 AM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I think the idea which attaches transition to container is great.

Fri, May 10, 1:44 AM · efl

Thu, May 9

Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I think there are some misunderstandings between us.

Thu, May 9, 2:05 AM · efl
Jaehyun_Cho closed D8868: navigation_layout: set efl.content y-axis align to 0.0.
Thu, May 9, 12:32 AM · efl

Wed, May 8

Jaehyun_Cho accepted D8868: navigation_layout: set efl.content y-axis align to 0.0.
Wed, May 8, 11:41 PM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

You commented that transition classes will cover unique features for each container class.
IMHO, it may not be right for some cases because it looks weird if "transition" class supports "container" features.
Although you mentioned why you added "indicator" and "page_size" to smart_container, but I don't think that those properties can move to "transition" class. (they look like "container" features)
I am afraid that there would be more properties like "indicator" and "page_size" which is perfectly required for some classes but not exactly for other classes.

Wed, May 8, 11:29 PM · efl
Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I totally understand your point.
If I understand your comment correctly, the main benefit of this patch is "reducing the maintenance efforts by integrating 2 classes into 1 class".

Wed, May 8, 1:24 AM · efl

Tue, May 7

Jaehyun_Cho added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

Sorry I am late to give you comment about this patch.

Tue, May 7, 9:57 PM · efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

When I tried to build with meson, build error happens because efl_gesture_events.eo is dependent on efl_canvas_gesture_xxx.eo

Tue, May 7, 4:31 AM · DO NOT MERGE, efl

Thu, May 2

Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

need to check meson build

Thu, May 2, 5:37 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Thu, May 2, 5:33 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Could you check and remove EINA_UNUSED which are not supposed to be used?

Thu, May 2, 4:10 AM · DO NOT MERGE, efl

Sun, Apr 28

Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@CHAN is updating this patch to support EFL C#.

Sun, Apr 28, 10:11 PM · DO NOT MERGE, efl

Thu, Apr 25

Jaehyun_Cho closed D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:24 AM · efl
Jaehyun_Cho accepted D8714: elm_theme: Check the ref count to delete or unref..
Thu, Apr 25, 5:23 AM · efl

Wed, Apr 24

Jaehyun_Cho closed D8695: ui.relative_layout: fix incorrect type casting.
Wed, Apr 24, 5:09 AM · efl
Jaehyun_Cho accepted D8695: ui.relative_layout: fix incorrect type casting.
Wed, Apr 24, 5:08 AM · efl
Jaehyun_Cho closed D8627: ui.relative_layout: enhance relation_xxx_set,get apis.
Wed, Apr 24, 5:03 AM · efl
Jaehyun_Cho closed D8626: ui.relative_layout: add callbacks to update layout.
Wed, Apr 24, 5:02 AM · efl
Jaehyun_Cho closed D8625: ui.relative_layout: add internal clipper.
Wed, Apr 24, 4:23 AM · efl
Jaehyun_Cho accepted D8627: ui.relative_layout: enhance relation_xxx_set,get apis.
Wed, Apr 24, 4:22 AM · efl
Jaehyun_Cho accepted D8625: ui.relative_layout: add internal clipper.
Wed, Apr 24, 4:21 AM · efl

Tue, Apr 23

Jaehyun_Cho accepted D8626: ui.relative_layout: add callbacks to update layout.
Tue, Apr 23, 1:42 AM · efl
Jaehyun_Cho added a comment to D8625: ui.relative_layout: add internal clipper.

is pd->base freed when relative layout is destructed?

Tue, Apr 23, 1:31 AM · efl
Jaehyun_Cho added a comment to D8625: ui.relative_layout: add internal clipper.

I think there is a typo in the commit description.

Tue, Apr 23, 1:26 AM · efl

Apr 17 2019

Jaehyun_Cho closed D8628: elm_notify: fix theme apply logic for new return value.
Apr 17 2019, 1:07 AM · efl
Jaehyun_Cho accepted D8628: elm_notify: fix theme apply logic for new return value.
Apr 17 2019, 12:58 AM · efl

Apr 15 2019

Jaehyun_Cho created T7808: Documentation of undefined group.
Apr 15 2019, 1:50 AM · documentation

Apr 11 2019

Jaehyun_Cho closed T7799: Backward compatibility broken. as Resolved.
Apr 11 2019, 11:47 PM
Jaehyun_Cho closed D8600: efl_ui_widget: Fix disabled set calling without meaning..
Apr 11 2019, 11:46 PM · efl
Jaehyun_Cho accepted D8600: efl_ui_widget: Fix disabled set calling without meaning..
Apr 11 2019, 11:44 PM · efl

Apr 7 2019

Jaehyun_Cho added a comment to D8577: configure: fix build error of efl_custom_exports_mono.c.

This fixes build error on efl_custom_exports_mono.c.

Apr 7 2019, 10:00 PM · efl
Jaehyun_Cho added a reviewer for D8577: configure: fix build error of efl_custom_exports_mono.c: akanad.
Apr 7 2019, 9:59 PM · efl
Jaehyun_Cho requested review of D8577: configure: fix build error of efl_custom_exports_mono.c.
Apr 7 2019, 9:56 PM · efl

Apr 4 2019

Jaehyun_Cho requested review of D8559: elementary: fix not to call duplicate theme set.
Apr 4 2019, 9:05 PM · efl
Jaehyun_Cho closed T7779: Efl.Ui.Stack pop cannot hide(visibility) and delete its content as Resolved.

It seems that this issue has been resolved by commit 55751f12044c5939b189d9ef149d82e8f331811a ..
Sorry to interrupt..

Apr 4 2019, 5:57 AM
Jaehyun_Cho created T7779: Efl.Ui.Stack pop cannot hide(visibility) and delete its content.
Apr 4 2019, 5:27 AM

Apr 2 2019

Jaehyun_Cho added a comment to D8529: elm_widget_item_eo.legacy: change @ingroup to Elm_General.

Up to now, elm_object_item APIs in elm_widget_item.eo are not in documentation because the group was not defined. (i.e. defgroup)

Apr 2 2019, 12:23 AM · efl
Jaehyun_Cho requested review of D8529: elm_widget_item_eo.legacy: change @ingroup to Elm_General.
Apr 2 2019, 12:02 AM · efl

Apr 1 2019

Jaehyun_Cho added a comment to T7774: Change parent object if content object is set to a new container.

What I am worrying is that there are 2 types of parents here, object parent and widget parent. ;(

Apr 1 2019, 8:40 PM · efl: widgets
Jaehyun_Cho updated the task description for T7774: Change parent object if content object is set to a new container.
Apr 1 2019, 5:47 AM · efl: widgets
Jaehyun_Cho created T7774: Change parent object if content object is set to a new container.
Apr 1 2019, 5:46 AM · efl: widgets

Mar 31 2019

Jaehyun_Cho added a comment to D8485: mono: fix space and brace warnings of StyleCop.

There is no indentation rule on StyleCop but normally indentation is automatically applied when I type inside the namespace bracket.
So I was not sure which way is better.

Mar 31 2019, 9:06 PM · efl
Jaehyun_Cho updated the diff for D8485: mono: fix space and brace warnings of StyleCop.

removed namespace indentation in efl_csharp_application.cs

Mar 31 2019, 9:01 PM · efl

Mar 29 2019

Jaehyun_Cho added a comment to D8476: efl_ui_widget: move from elm_widget_top_get to provider_find.

Thank you :)

Mar 29 2019, 6:05 AM · efl
Jaehyun_Cho requested changes to D8476: efl_ui_widget: move from elm_widget_top_get to provider_find.
Mar 29 2019, 1:39 AM · efl
Jaehyun_Cho added a comment to T7772: Fix calculation of widget's disabled property.

@bu5hm4n
Yes~ thank you :)

Mar 29 2019, 12:52 AM · efl (efl-1.22)
Jaehyun_Cho accepted D8459: efl_ui_widget: reintroduce legacy behaviour.

Thank you!! :))

Mar 29 2019, 12:21 AM · efl

Mar 28 2019

Jaehyun_Cho accepted D8475: efl_ui_widget: add implementation for finding the window.
Mar 28 2019, 11:29 PM · efl
Jaehyun_Cho added inline comments to D8459: efl_ui_widget: reintroduce legacy behaviour.
Mar 28 2019, 11:28 PM · efl
Jaehyun_Cho added a comment to D8475: efl_ui_widget: add implementation for finding the window.

You are right. My comment was out of this topic.

Mar 28 2019, 11:17 PM · efl
Jaehyun_Cho added a comment to D8459: efl_ui_widget: reintroduce legacy behaviour.

@bu5hm4n
Thank you!! It perfectly works :)
There is no backward compatibility issue as well!

Mar 28 2019, 9:33 PM · efl
Jaehyun_Cho added a comment to D8475: efl_ui_widget: add implementation for finding the window.

There is one thing we need to think about.

Mar 28 2019, 5:56 AM · efl
Jaehyun_Cho added a comment to T7772: Fix calculation of widget's disabled property.

Thank you! I think a new patch is required to change the current disabled calculation logic.

Mar 28 2019, 4:34 AM · efl (efl-1.22)
Jaehyun_Cho added a comment to T7772: Fix calculation of widget's disabled property.

I think we have 2 ways to resolve the counting problem.

Mar 28 2019, 4:07 AM · efl (efl-1.22)
Jaehyun_Cho added a comment to T7772: Fix calculation of widget's disabled property.

Although I may not fully understand your point, but I understand why counting way is adapted here.

Mar 28 2019, 4:01 AM · efl (efl-1.22)
Jaehyun_Cho updated subscribers of T7772: Fix calculation of widget's disabled property.
Mar 28 2019, 3:23 AM · efl (efl-1.22)
Jaehyun_Cho created T7772: Fix calculation of widget's disabled property.
Mar 28 2019, 3:22 AM · efl (efl-1.22)
Jaehyun_Cho closed D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.
Mar 28 2019, 2:59 AM · efl
Jaehyun_Cho accepted D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.
Mar 28 2019, 2:47 AM · efl
Jaehyun_Cho accepted D8457: efl_ui_test_widget: ensures tests do not error.
Mar 28 2019, 12:46 AM · efl
Jaehyun_Cho accepted D8458: efl_ui_widget: add tests for parent and disalbed property.
Mar 28 2019, 12:29 AM · efl
Jaehyun_Cho added inline comments to D8457: efl_ui_test_widget: ensures tests do not error.
Mar 28 2019, 12:23 AM · efl

Mar 27 2019

Jaehyun_Cho accepted D8455: efl_ui_slider: block scrolling when on slider.
Mar 27 2019, 10:42 PM · efl
Jaehyun_Cho updated subscribers of D8455: efl_ui_slider: block scrolling when on slider.
Mar 27 2019, 8:52 PM · efl
Jaehyun_Cho updated the summary of D8485: mono: fix space and brace warnings of StyleCop.
Mar 27 2019, 3:44 AM · efl
Jaehyun_Cho added a comment to D8485: mono: fix space and brace warnings of StyleCop.

I am not sure which is better either 1. apply 4 spaces indentation inside each namespace or 2. do not apply it (which is current patch).

Mar 27 2019, 3:09 AM · efl
Jaehyun_Cho requested review of D8485: mono: fix space and brace warnings of StyleCop.
Mar 27 2019, 3:05 AM · efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

This patch is going to be submitted after 1.22 release.

Mar 27 2019, 1:15 AM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic.: DO NOT MERGE.
Mar 27 2019, 1:15 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Mar 27 2019, 1:14 AM · DO NOT MERGE, efl

Mar 26 2019

Jaehyun_Cho added a comment to D7495: csharp: add a interface to start apps.

I see your worries about removing the namespace "Csharp".
I think your worry is basically the collision of the namespace.

Mar 26 2019, 1:39 AM · efl: language bindings

Mar 25 2019

Jaehyun_Cho closed D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.
Mar 25 2019, 10:23 PM · efl
Jaehyun_Cho accepted D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.
Mar 25 2019, 10:19 PM · efl
Jaehyun_Cho closed T7375: Support widget styles in C# bindings as Resolved.

Thank you for notice~
This task is done :)

Mar 25 2019, 7:11 PM · efl
Jaehyun_Cho added a project to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text: DO NOT MERGE.
Mar 25 2019, 4:58 AM · DO NOT MERGE, Restricted Project
Jaehyun_Cho renamed T7766: Separate Efl.Ui.Selectable into item selection events and text selection events from Separate Efl.Ui.Selectable into item selection events and cursor selection events to Separate Efl.Ui.Selectable into item selection events and text selection events.
Mar 25 2019, 4:55 AM · Restricted Project
Jaehyun_Cho added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

OK, I will make a patch to change the name of all "able" classes/interfaces/mixins later :)
BTW, since @bu5hm4n requested to wait for 1.22 release, I think I should not push this patch until 1.22 release.

Mar 25 2019, 4:54 AM · DO NOT MERGE, Restricted Project
Jaehyun_Cho updated the summary of D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.
Mar 25 2019, 4:51 AM · DO NOT MERGE, Restricted Project
Jaehyun_Cho added a comment to D7495: csharp: add a interface to start apps.

I made a patch D8463 which moves the enum Efl.Csharp.Components out of the namespace Csharp.
(i.e. Efl.Csharp.Components -> Efl.Components)

Mar 25 2019, 4:48 AM · efl: language bindings
Jaehyun_Cho added a comment to D7495: csharp: add a interface to start apps.

@bu5hm4n
I understand your point. Thank you :)
When I have some new brilliant ideas about the namespace Csharp, then I will share with you.

Mar 25 2019, 4:41 AM · efl: language bindings
Jaehyun_Cho requested review of D8463: efl_mono: move enum Components out of Csharp namespace.
Mar 25 2019, 2:30 AM · efl

Mar 24 2019

Jaehyun_Cho edited projects for T7766: Separate Efl.Ui.Selectable into item selection events and text selection events, added: Restricted Project; removed efl (efl-1.22).
Mar 24 2019, 11:35 PM · Restricted Project
Jaehyun_Cho updated the diff for D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

change Efl.Ui.Text_Cursor_Selectable to Efl.Ui.Text_Selectable

Mar 24 2019, 8:50 PM · DO NOT MERGE, Restricted Project
Jaehyun_Cho edited projects for D8442: efl_ui_selectable: separate efl_ui_selectable into item and text, added: Restricted Project; removed efl.
Mar 24 2019, 7:33 PM · DO NOT MERGE, Restricted Project
Jaehyun_Cho added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

@bu5hm4n
Thank you for the feedback :)
I wanted to apply this change before release but as you say let's wait until release because these interfaces are @beta ;)

Mar 24 2019, 7:32 PM · DO NOT MERGE, Restricted Project