Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (239 w, 18 h)
Availability
Available

Recent Activity

Tue, Feb 6

Jaehyun_Cho closed D5786: ecore_event: Fix a break of consistency of return data.
Tue, Feb 6, 8:54 PM
Jaehyun_Cho accepted D5786: ecore_event: Fix a break of consistency of return data.
Tue, Feb 6, 8:50 PM

Mon, Jan 29

Jaehyun_Cho closed D5767: elm_index: fix documentation of wrong param name.
Mon, Jan 29, 4:19 AM
Jaehyun_Cho accepted D5767: elm_index: fix documentation of wrong param name.
Mon, Jan 29, 4:16 AM
Jaehyun_Cho closed D5763: efl_ui_bg_widget_legacy: ignore ELM_SCALE.
Mon, Jan 29, 2:33 AM

Sun, Jan 28

Jaehyun_Cho accepted D5763: efl_ui_bg_widget_legacy: ignore ELM_SCALE.
Sun, Jan 28, 11:57 PM
Jaehyun_Cho accepted D4901: edc_editor: Fix the linenumber scrolling.
Sun, Jan 28, 6:37 PM

Thu, Jan 25

Jaehyun_Cho added a comment to D5763: efl_ui_bg_widget_legacy: ignore ELM_SCALE.

I think the "Center" option of "Bg Options" is the same case with "None" option of "Efl.Ui.Bg" in elementary_test.
If so, it would be strange that the "Center" option does not apply ELM_SCALE but "None" option applies ELM_SCALE.

Thu, Jan 25, 9:00 PM

Jan 22 2018

Jaehyun_Cho closed D5754: ecore_main: Check for null ptr deref.
Jan 22 2018, 4:31 AM
Jaehyun_Cho accepted D5754: ecore_main: Check for null ptr deref.
Jan 22 2018, 4:26 AM
Jaehyun_Cho added a comment to D5749: elementary: Add missed type for legacy..

Do we need to do typedef for the following classes as well?

Jan 22 2018, 1:43 AM
Jaehyun_Cho closed D5753: ecore_evas: Check for null ptr deref.
Jan 22 2018, 1:28 AM
Jaehyun_Cho accepted D5753: ecore_evas: Check for null ptr deref.
Jan 22 2018, 1:28 AM
Jaehyun_Cho retitled D5753: ecore_evas: Check for null ptr deref from ecore evas: Check for null ptr deref to ecore_evas: Check for null ptr deref.
Jan 22 2018, 1:27 AM
Jaehyun_Cho added inline comments to D5753: ecore_evas: Check for null ptr deref.
Jan 22 2018, 12:09 AM
Jaehyun_Cho closed D5752: ecore_anim: Check for null ptr deref.
Jan 22 2018, 12:09 AM
Jaehyun_Cho accepted D5752: ecore_anim: Check for null ptr deref.
Jan 22 2018, 12:07 AM
Jaehyun_Cho updated the summary of D5752: ecore_anim: Check for null ptr deref.
Jan 22 2018, 12:07 AM

Jan 21 2018

Jaehyun_Cho added inline comments to D5752: ecore_anim: Check for null ptr deref.
Jan 21 2018, 10:01 PM

Jan 17 2018

Jaehyun_Cho added a comment to T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

For now, I've submitted a patch to call all efl_add with parent in elementary_test. (119c41d7f2f13da0e27ee0d4d879301aa36f90c3)

Jan 17 2018, 2:01 AM · efl

Jan 16 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.
  1. thanks for insert case. for remove case, it would be remove_at(Eo *frame, int index) remove(Eo *frame)
Jan 16 2018, 10:41 PM · Restricted Project, efl
Jaehyun_Cho claimed T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

@raster
sorry I miss it. I will take care of it.

Jan 16 2018, 9:32 PM · efl
This revision was not accepted when it landed; it landed in state Draft.
Jan 16 2018, 8:29 PM
This revision was not accepted when it landed; it landed in state Draft.
Jan 16 2018, 7:52 PM
Jaehyun_Cho reassigned T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop from Jaehyun_Cho to taxi2se.

This task is done by the taxi2se's commit 588995da317520fc92660b89b0864bb1f25abc09
Thank you taxi2se :)

Jan 16 2018, 6:23 PM · efl

Jan 15 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.

Here, I need some opinions about the above class specs.

Jan 15 2018, 9:14 PM · Restricted Project, efl
Jaehyun_Cho added a comment to T5351: New Naviframe API.

Here are brief specs of stack and navigation classes.

Jan 15 2018, 8:17 PM · Restricted Project, efl
Jaehyun_Cho closed D5730: elc_popup: reorder the sub objects free sequence.
Jan 15 2018, 2:56 AM
Jaehyun_Cho accepted D5730: elc_popup: reorder the sub objects free sequence.
Jan 15 2018, 2:55 AM

Jan 14 2018

Jaehyun_Cho added inline comments to D5730: elc_popup: reorder the sub objects free sequence.
Jan 14 2018, 9:06 PM

Jan 8 2018

Jaehyun_Cho added a comment to T6540: New Date and Time classes and their APIs.

For now Efl.Ui.Clock contains both date and time information.
So if we use Efl.Ui.Clock, then we can provide same styles and structures of date and time. (e.g. date and time are displayed horizontally in sequence.)

Jan 8 2018, 3:44 AM

Jan 4 2018

Jaehyun_Cho closed D5722: efl_ui_popup_alert: change clicked event name.
Jan 4 2018, 8:37 PM
Jaehyun_Cho accepted D5722: efl_ui_popup_alert: change clicked event name.
Jan 4 2018, 8:35 PM
Jaehyun_Cho closed D5720: efl_ui_popup_alert_text_scroll: do not calc size when need size calc flag is FALSE.
Jan 4 2018, 4:12 AM
Jaehyun_Cho accepted D5720: efl_ui_popup_alert_text_scroll: do not calc size when need size calc flag is FALSE.
Jan 4 2018, 4:12 AM
Jaehyun_Cho retitled D5720: efl_ui_popup_alert_text_scroll: do not calc size when need size calc flag is FALSE from efl.ui.popup.alert.text,scroll: do not calc size when need size calc flag is FALSE to efl_ui_popup_alert_text_scroll: do not calc size when need size calc flag is FALSE.
Jan 4 2018, 4:11 AM
Jaehyun_Cho added a comment to T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

Thanks for your comment. I understand your point.
I have a question about your comment.
What if application does not set animation's parent in efl_add()? If so, should efl_animation set efl_main_loop_get() as its parent internally?

Jan 4 2018, 12:46 AM · efl
Jaehyun_Cho updated subscribers of T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.
Jan 4 2018, 12:38 AM · efl
Jaehyun_Cho updated subscribers of T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.
Jan 4 2018, 12:38 AM · efl

Dec 21 2017

Jaehyun_Cho created T6540: New Date and Time classes and their APIs.
Dec 21 2017, 7:52 PM

Dec 19 2017

Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

For now, very primitive things are implemented in Efl.Ui.Popup.Anchor.List. (i.e. Showing item list)
I think it would be better if we provide events and methods for item after Widget Item class is defined.
What do you think about that?

Dec 19 2017, 11:52 PM
Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

I mean DATA_GET_OR_RETURN actually returns the function if the data is not taken.
you can see EFL_UI_POPUP_DATA_GET_OR_RETURN macro.

Dec 19 2017, 6:07 PM
Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

@Blackmole
Please check the comment

Dec 19 2017, 4:14 AM
Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

@Blackmole
Please check the comments.

Dec 19 2017, 12:30 AM
Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

@jpeg
jpeg~ do you mean this patch should be pending until Efl.Ui.Item implementation is finished?
Or is this patch ok if just Elm.Widget.Item is not used?

Dec 19 2017, 12:29 AM

Dec 17 2017

Jaehyun_Cho added a comment to D5557: Efl.Ui.Popup.Scroll: add expandable feature.

@herb
Please abandon this patch.

Dec 17 2017, 9:10 PM
Jaehyun_Cho closed D5667: Efl.Ui.Popup.Anchor: remove event callback when popup is deleted.
Dec 17 2017, 9:08 PM
Jaehyun_Cho accepted D5667: Efl.Ui.Popup.Anchor: remove event callback when popup is deleted.
Dec 17 2017, 9:07 PM
Jaehyun_Cho closed D5580: efl_ui_spin_button: Fix can't input number in case of the min value is bigger than 1..
Dec 17 2017, 8:30 PM
Jaehyun_Cho accepted D5580: efl_ui_spin_button: Fix can't input number in case of the min value is bigger than 1..
Dec 17 2017, 6:55 PM

Dec 14 2017

Jaehyun_Cho added a comment to D5580: efl_ui_spin_button: Fix can't input number in case of the min value is bigger than 1..

@jpeg
I will submit this patch if you don't have any objection.

Dec 14 2017, 10:49 PM
Jaehyun_Cho closed D5655: Efl.Ui.Popup.Anchor: apply group calculate with size problem fix.
Dec 14 2017, 8:56 PM
Jaehyun_Cho accepted D5655: Efl.Ui.Popup.Anchor: apply group calculate with size problem fix.
Dec 14 2017, 8:55 PM
Jaehyun_Cho added a comment to D5655: Efl.Ui.Popup.Anchor: apply group calculate with size problem fix.

@Blackmole
Please check the comments

Dec 14 2017, 8:28 PM

Dec 13 2017

Jaehyun_Cho closed D5547: efl_ui_popup_alert_text: add expandable feature.
Dec 13 2017, 12:51 AM
Jaehyun_Cho accepted D5547: efl_ui_popup_alert_text: add expandable feature.
Dec 13 2017, 12:45 AM
Jaehyun_Cho retitled D5547: efl_ui_popup_alert_text: add expandable feature from Efl.Ui.Popup.Alert.Text: add expandable feature to efl_ui_popup_alert_text: add expandable feature.
Dec 13 2017, 12:45 AM

Dec 11 2017

Jaehyun_Cho added a comment to T5337: Animation framework API for EO.

@jpeg
I understand and agree with your point.
But I concern about one thing. If efl_gfx_map is manually applied to an object which was animated by Efl_Animation, then efl_gfx_map would not start from the last state of Efl_Animation.
Is it ok?

Dec 11 2017, 7:01 PM · Restricted Project, efl
Jaehyun_Cho closed D5640: efl_ui_popup_scroll: remove build warnings.
Dec 11 2017, 12:10 AM
Jaehyun_Cho accepted D5640: efl_ui_popup_scroll: remove build warnings.
Dec 11 2017, 12:09 AM

Dec 10 2017

Jaehyun_Cho closed D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.
Dec 10 2017, 11:13 PM
Jaehyun_Cho closed D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.
Dec 10 2017, 11:13 PM
Jaehyun_Cho accepted D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.
Dec 10 2017, 11:06 PM
Jaehyun_Cho accepted D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.
Dec 10 2017, 11:06 PM
Jaehyun_Cho closed D5630: efl_ui_popup_alert_scroll: Add expandable property.
Dec 10 2017, 9:01 PM
Jaehyun_Cho requested changes to D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.
Dec 10 2017, 8:59 PM
Jaehyun_Cho closed D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Dec 10 2017, 8:42 PM
Jaehyun_Cho closed D5600: Efl.Ui.Popup: add popup_size property.
Dec 10 2017, 8:42 PM

Dec 8 2017

Jaehyun_Cho added a comment to D5630: efl_ui_popup_alert_scroll: Add expandable property.

@herb
I separated patches and submitted those patches.
Please make 2 more patches onto this one.

  1. Please add edje_object_message_signal_process in alert_text_set() which you investigated and found out.
  2. Please add test cases for expandable
Dec 8 2017, 1:58 AM
Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.

make expandable property beta

Dec 8 2017, 1:55 AM
Jaehyun_Cho retitled D5630: efl_ui_popup_alert_scroll: Add expandable property from efl_ui_popup: Update size calculation logic to efl_ui_popup_alert_scroll: Add expandable property.
Dec 8 2017, 1:31 AM
Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.

Rebase

Dec 8 2017, 1:29 AM
Jaehyun_Cho reopened D5630: efl_ui_popup_alert_scroll: Add expandable property.
Dec 8 2017, 1:29 AM
Jaehyun_Cho closed D5630: efl_ui_popup_alert_scroll: Add expandable property.
Dec 8 2017, 1:13 AM
Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.

update code

Dec 8 2017, 1:05 AM
Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.
  • efl_ui_popup_alert: Remove unnecessary elm_layout_sizing_eval
Dec 8 2017, 12:57 AM
Jaehyun_Cho retitled D5630: efl_ui_popup_alert_scroll: Add expandable property from efl_ui_popup_alert_scroll: Add expandable property to efl_ui_popup: Update size calculation logic.
Dec 8 2017, 12:46 AM
Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.

Separate Efl.Ui.Popup patch

Dec 8 2017, 12:44 AM

Dec 7 2017

Jaehyun_Cho updated the diff for D5630: efl_ui_popup_alert_scroll: Add expandable property.

Fix typo and modify variable name correctly.

Dec 7 2017, 11:25 PM
Jaehyun_Cho created D5630: efl_ui_popup_alert_scroll: Add expandable property.
Dec 7 2017, 11:21 PM
Jaehyun_Cho added a comment to D5557: Efl.Ui.Popup.Scroll: add expandable feature.

Please check the comments on test code.

Dec 7 2017, 11:10 PM
Jaehyun_Cho reopened D5600: Efl.Ui.Popup: add popup_size property.

This patch has been submitted to feature/eo_theme.
not submitted to master yet

Dec 7 2017, 11:07 PM
Jaehyun_Cho closed D5600: Efl.Ui.Popup: add popup_size property.
Dec 7 2017, 11:06 PM
Jaehyun_Cho accepted D5600: Efl.Ui.Popup: add popup_size property.
Dec 7 2017, 11:04 PM
Jaehyun_Cho reopened D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

not submitted to master yet

Dec 7 2017, 11:04 PM
Jaehyun_Cho added a comment to D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

This patch has been submitted to feature/eo_theme branch.

Dec 7 2017, 11:03 PM
Jaehyun_Cho closed D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Dec 7 2017, 11:03 PM
Jaehyun_Cho accepted D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Dec 7 2017, 11:02 PM
Jaehyun_Cho requested changes to D5557: Efl.Ui.Popup.Scroll: add expandable feature.

If expandable_set is called again in buttons clicked event, then error happens.

Dec 7 2017, 5:15 PM

Dec 5 2017

Jaehyun_Cho added a comment to D5557: Efl.Ui.Popup.Scroll: add expandable feature.

Please close popup when button is clicked.

Dec 5 2017, 10:03 PM
Jaehyun_Cho requested changes to D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

Please write EINA_UNUSED to the correct place..

Dec 5 2017, 9:53 PM
Jaehyun_Cho added a comment to D5600: Efl.Ui.Popup: add popup_size property.

Please check the indentation

Dec 5 2017, 9:27 PM
Jaehyun_Cho requested changes to D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Dec 5 2017, 6:18 PM

Dec 4 2017

Jaehyun_Cho closed D5577: efl_ui_popup_alert: refactor popup_alert_part.
Dec 4 2017, 5:43 PM
Jaehyun_Cho added a comment to D5577: efl_ui_popup_alert: refactor popup_alert_part.

This patch has been submitted to feature/eo_theme branch.

Dec 4 2017, 5:43 PM
Jaehyun_Cho accepted D5577: efl_ui_popup_alert: refactor popup_alert_part.
Dec 4 2017, 5:40 PM

Dec 3 2017

Jaehyun_Cho added a comment to D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.

This patch has been submitted to feature/eo_theme branch.

Dec 3 2017, 11:02 PM
Jaehyun_Cho closed D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.
Dec 3 2017, 11:02 PM
Jaehyun_Cho accepted D5566: elm: introduce ELM_PART_OVERRIDE_PARTIAL.
Dec 3 2017, 11:01 PM

Nov 30 2017

Jaehyun_Cho closed D5569: efl_ui_spin_button: check focus state.
Nov 30 2017, 7:11 PM