User Details
- User Since
- Jul 24 2013, 3:26 AM (497 w, 6 d)
- Availability
- Available
Feb 24 2022
Feb 9 2022
May 24 2021
I am sorry I should've checked this first.. ;(
Feb 3 2021
Aug 3 2020
Jun 17 2020
Jun 16 2020
Jun 4 2020
May 26 2020
Nice catch! Thank you! :)
May 20 2020
Thank you for this patch! :)
Apr 13 2020
Apr 12 2020
Apr 1 2020
I think that if EDI's wizard registers pop_cb and does nothing in pop_cb and returns EINA_FALSE in the pop_cb, then the last item is not popped.
I think this patch breaks the backward compatibility.
Because users can register their own pop_cb by using elm_naviframe_item_pop_cb_set().
So if the popped item is the last item, then users' pop_cb is called and elm_win or something is deleted manually in the pop_cb.
However, this patch do not allow pop_cb is called if the popped item is the last item.
So I think this patch should not be accepted.
Mar 16 2020
Mar 15 2020
If the backwards animation logic is not important in this patch, then it would be fine to submit this patch now and later I will make a patch to remove backwards animation logic.
Thank you for adding parameters to push_setup and pop_setup.
Mar 11 2020
Mar 10 2020
I made a patch onto this patch on my dev branch (devs/jaehyun/animation_manager) as a test version.
https://git.enlightenment.org/core/efl.git/commit/?h=devs/jaehyun/animation_manager&id=72da9ec8c6ef9e6081979c1caae3e4749d0a9965
I am not sure I understood your comment correctly.
So I want to explain my previous comment with more precisely.
Sorry I missed this one.
Feb 24 2020
Feb 21 2020
@CHAN we need to think about the comments on D11378 from @bu5hm4n and @segfaultxavi
Feb 19 2020
Feb 4 2020
Feb 3 2020
You are right :) Thank you!
Jan 23 2020
Jan 22 2020
fix build error
Jan 21 2020
Is it OK if this patch is submitted?
thank you! :)
Jan 20 2020
Apply clipper not to cause tests fail with setting data "_elm_leaveme".
Oh! I missed plain;; thank you!
add code for spotlight manager plain, too
As this patch describes, now group_member_add() of efl_ui_widget set color_set() manually. This causes packed rectangle's color change.
Jan 19 2020
thank you for the update!
Jan 17 2020
How about using global variable static unsigned int ts ?
static unsigned int ts = 0; //global variable in suite_helpers.c
Because the timestamp of each function begins with 0 so timestamp 0 is used in the functions at the same time.
e.g.
//In test code drag_object(...); //timestamp 0 is used with evas_event_feed_mouse_move wheel_object_at(...); //timestamp 0 is used with evas_event_feed_mouse_move
Jan 16 2020
This patch is basically the same with D11108.
This patch suggests using "Animation" as a postfix of animation class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation
Jan 15 2020
update description about the value is_duration_set
Jan 14 2020
I agree with your opinion! Power_Interpolator :)
It seems that GetEoOps() can be called multiple times if inherited classes' instances are created.
It seems that it is required to consider that only specific part classes generate extension classes (not all part classes) as @woohyun mentioned. (e.g. Efl.Ui.Layout_Part_Text, ...)
Jan 13 2020
Thank you for your reply! Now I understand your point and I agree with you.
- NOW : radius_get { } for Efl.Canvas.Gesture_Zoom
- TODO : @property radius { get { } } for Efl.Canvas.Gesture_Zoom
Jan 12 2020
Based on the above discussion, how about the followings in efl_model.eo?
child,added : Efl.Model_Child_Event; child,removed : Efl.Model_Child_Event; children,added : Efl.Model_Children_Event; children,removed : Efl.Model_Children_Event;
This class was added based on ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, ECORE_POS_MAP_DIVISOR_INTERP and ECORE_POS_MAP_DIVISOR_INTERP.
Their fields should be read-only properties instead of methods. This is more natural for bindings.
Do you mean that EITHER Efl.Canvas.Gesture provides read-only properties OR Efl.Canvas.Gesture's setter methods / writable properties should not be public?