Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (251 w, 4 d)
Availability
Available

Recent Activity

Yesterday

Jaehyun_Cho closed D6044: efl_ui_tags: Fixed bug when setting format string..
Sat, May 19, 12:07 PM · efl
Jaehyun_Cho accepted D6044: efl_ui_tags: Fixed bug when setting format string..
Sat, May 19, 11:54 AM · efl
Jaehyun_Cho closed D5969: efl_ui_spin: Added special value feature..
Sat, May 19, 11:12 AM · efl
Jaehyun_Cho accepted D5969: efl_ui_spin: Added special value feature..
Sat, May 19, 10:47 AM · efl
Jaehyun_Cho updated the diff for D5969: efl_ui_spin: Added special value feature..

Rebase code based on the latest master branch and Free array in test_ui_spin_button.c

Sat, May 19, 10:34 AM · efl

Thu, May 17

This revision was not accepted when it landed; it landed in state Needs Review.
Thu, May 17, 2:18 AM · efl
Jaehyun_Cho accepted D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.
Thu, May 17, 2:17 AM · efl
Herald added a project to D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop: efl.

Please remove undefined properties and methods from Efl.Ui.Slider in test_ui_scroller.c (e.g. efl_ui_slider_part_indicator_visible_mode_set)

Thu, May 17, 12:54 AM · efl

Tue, May 15

Jaehyun_Cho closed D6162: elm_slider: fix test suite fail.
Tue, May 15, 4:14 AM · efl
Jaehyun_Cho accepted D6162: elm_slider: fix test suite fail.
Tue, May 15, 4:12 AM · efl
Jaehyun_Cho retitled D6162: elm_slider: fix test suite fail from slider: fix test suite fail to elm_slider: fix test suite fail.
Tue, May 15, 4:11 AM · efl

Mon, May 14

This revision was not accepted when it landed; it landed in state Needs Review.
Mon, May 14, 10:23 PM · efl
Jaehyun_Cho accepted D5908: efl_ui_slider: refactor slider widget..

The interval changes will be considered in other patch.

Mon, May 14, 10:14 PM · efl
Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

In Efl.Ui.Slider_Interval, in herizontal mode, low value is moved by wheel and key but in vertical mode, high value is moved by wheel and key.
IMHO, the same values should be moved. (either low value or high value)

Mon, May 14, 6:53 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Fix to install elm_slider.eo.h correctly.
Otherwise, build error occurs on efl application.

Mon, May 14, 6:38 AM · efl

Mon, May 7

Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

As I tested elementary_test, the vertical slider with mouse wheel works the opposite direction I think.

Mon, May 7, 10:23 PM · efl
Jaehyun_Cho closed T6887: MultibuttonEntry legacy name tests are failing as Resolved.

This issue has been fixed. Thank you :)

Mon, May 7, 9:35 PM · efl

Thu, May 3

Jaehyun_Cho added a comment to D5908: efl_ui_slider: refactor slider widget..

Now this patch is rebased on the latest master.

Thu, May 3, 1:00 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Update code to rebase on latest master and to fix errors and warnings.

Thu, May 3, 12:47 AM · efl
Jaehyun_Cho updated the diff for D5908: efl_ui_slider: refactor slider widget..

Update code to resolve conflict on master

Thu, May 3, 12:10 AM · efl

Wed, May 2

Jaehyun_Cho added a reviewer for D5908: efl_ui_slider: refactor slider widget.: Jaehyun_Cho.
Wed, May 2, 5:22 AM · efl
Jaehyun_Cho closed D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.
Wed, May 2, 5:19 AM
Jaehyun_Cho accepted D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.
Wed, May 2, 5:09 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

test_efl_ui_tab_pager is changed to test_ui_tab_pager to synchronize with other cases.

Wed, May 2, 4:54 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

The following diff is added to this patch to apply new theme naming rule.
Otherwise, page content set and transition do not work.

Wed, May 2, 4:36 AM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
In D6008#102810, @zmike wrote:
In D6008#102804, @zmike wrote:

This patch should not have been accepted as it contains non-namespaced parts. T6911

@zmike

Sorry I checked your email from the mailing list after submitting this patch.

I've uploaded a patch to change the part names (b8de04d77f63f5f305b0ccd2670f1d908ba4bf7d)

Thanks!

Do you think it would be useful to have something which automatically checks the default theme for this during build to avoid future issues?

Wed, May 2, 4:08 AM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
In D6008#102804, @zmike wrote:

This patch should not have been accepted as it contains non-namespaced parts. T6911

Wed, May 2, 3:47 AM
Jaehyun_Cho added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

The following diffs are added to this patch to support unpack and to fix elementary_test errors (win ref error and unpack crash).

Wed, May 2, 3:29 AM
Jaehyun_Cho closed D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
Wed, May 2, 1:30 AM
Jaehyun_Cho accepted D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
Wed, May 2, 1:22 AM
Jaehyun_Cho updated the summary of D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).
Wed, May 2, 1:09 AM

Tue, May 1

Jaehyun_Cho requested changes to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please check the comments.

Tue, May 1, 9:43 PM

Thu, Apr 26

Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please change to "Efl.Ui.Tags" for the test case name.

Thu, Apr 26, 11:45 PM
Jaehyun_Cho added a comment to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please remove unused variables to remove warnings.

Thu, Apr 26, 11:43 PM
Jaehyun_Cho requested changes to D6008: Introduce Efl.Ui.Tags(changed from elm_multibuttonentry).

Please check the comment for rebase and removing warnings.

Thu, Apr 26, 10:45 PM
Jaehyun_Cho closed D6007: efl_ui_win: fix the wrong bracket.
Thu, Apr 26, 5:01 AM
Jaehyun_Cho accepted D6007: efl_ui_win: fix the wrong bracket.
Thu, Apr 26, 5:00 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Thu, Apr 26, 3:41 AM
Jaehyun_Cho accepted D5934: efl theme: remove the elm legacy name of efl ui theme.
Thu, Apr 26, 3:26 AM
Jaehyun_Cho updated the test plan for D5934: efl theme: remove the elm legacy name of efl ui theme.
Thu, Apr 26, 3:26 AM

Wed, Apr 25

Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

I think there is something to modify on this patch.
Please check the patch in devs/jaehyun/efl_part_legacy_remove_final branch.

Wed, Apr 25, 8:22 AM
Jaehyun_Cho closed D5871: Intrudoce Efl Ui Date, Time interface and picker..
Wed, Apr 25, 12:49 AM
Jaehyun_Cho accepted D5871: Intrudoce Efl Ui Date, Time interface and picker..
Wed, Apr 25, 12:42 AM

Tue, Apr 24

Jaehyun_Cho added inline comments to D5871: Intrudoce Efl Ui Date, Time interface and picker..
Tue, Apr 24, 10:54 PM
Jaehyun_Cho added a comment to T6847: Rationalize class and namespace names.

There is a build error as follows.

Tue, Apr 24, 9:40 PM · Restricted Project, efl
Jaehyun_Cho requested changes to D5871: Intrudoce Efl Ui Date, Time interface and picker..

efl_ui_datetime.c, efl_ui_datetime.eo, and efl_ui_datetime_private.h files are missing in this revision.

Tue, Apr 24, 3:16 AM
Jaehyun_Cho closed D5983: evas_map: Fix a bug about wrong map point colors.
Tue, Apr 24, 12:26 AM
Jaehyun_Cho accepted D5983: evas_map: Fix a bug about wrong map point colors.
Tue, Apr 24, 12:25 AM
Jaehyun_Cho added a comment to D5969: efl_ui_spin: Added special value feature..

Just a question here, did you look at how it would look like with bindings ? I am thinking we might want an API that would be more a set/get with an array/hash of value+label. We could use either an Eina_Value, an Eina_Array or an Eina_Hash. The use could look like one of the following :

spin.special_values = { 1: "January",  2: "February", 3: "March", 4: "April", 5: "May", 6: "June", 7: "July", 8: "August", 9: "September", 10: "October", 11: "November", 12: "December"};
spin.special_values = { { value: 1, label: "January" },  { value: 2, label: "February" }, { value: 3, label: "March" }, { value: 4, label: "April" }, { value: 5, label: "May" }, { value: 6, label: "June" }, { value: 7, label: "July" }, { value: 8, label: "August" }, { value: 9, label: "September" }, { value: 10, label: "October" },  {value: 11, label: "November" }, { value: 12, label: "December"} };

I think that using Eina_List with Eina_Hash is good idea if special_values = { { 1: "January" } } is the only thing we need to write for C#.

However, I worry about the usage in C. Because the hash is consist of { double: string } and it is complicated to support double key for now. (eina_hash_new with key_length, key_compare, key_hash functions are required)

Hum, I missed that it was double. Indeed, not a great index for a hash. Not just in C, but everywhere.

BTW, I think that using Eina_List with Eina_Value is not a good idea because it requires many additional information to write (i.e. value, label).

Well, it is less to type than efl_ui_spin_special_value_add or special_value_add for namespaced language :-) In C, it should also become straight forward to go with an array inside an Eina_Value. You should be able to do something like :

// Provided by Efl_Ui.h somewhere
typedef struct _Efl_Ui_Spin_Special_Value {
  double value;
  const char *label;
} Efl_Ui_Spin_Special_Value;
EINA_VALUE_STRUCT_DESC_DEFINE(Efl_Ui_Spin_Special_Value_Desc, NULL, sizeof (Efl_Ui_Spin_Special_Value),
  EINA_VALUE_STRUCT_MEMBER(EINA_VALUE_TYPE_DOUBLE, Efl_Ui_Spin_Special_Value, value),
  EINA_VALUE_STRUCT_MEMBER(EINA_VALUE_TYPE_STRING, Efl_Ui_Spin_Special_Value, label));
 
Efl_Ui_Spin_Special_Value values[] = { { 1, "January" }, { 2, "February" } };

Eina_Value *v = eina_value_array_from(EINA_VALUE_TYPE_STRUCT, Efl_Ui_Spin_Special_Value_Desc, values);
 
efl_ui_spin_special_values_set(obj, v);

We are missing the eina_value_array_from() function, if I have time, I will write it tomorrow, but if you can cover it before me go ahead with that one.

@felipealmeida how would that look like in C# ?

Tue, Apr 24, 12:19 AM · efl

Mon, Apr 23

Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

raster, thank you for your feedback.

Mon, Apr 23, 2:56 AM
Jaehyun_Cho added a comment to D5969: efl_ui_spin: Added special value feature..

Just a question here, did you look at how it would look like with bindings ? I am thinking we might want an API that would be more a set/get with an array/hash of value+label. We could use either an Eina_Value, an Eina_Array or an Eina_Hash. The use could look like one of the following :

spin.special_values = { 1: "January",  2: "February", 3: "March", 4: "April", 5: "May", 6: "June", 7: "July", 8: "August", 9: "September", 10: "October", 11: "November", 12: "December"};
spin.special_values = { { value: 1, label: "January" },  { value: 2, label: "February" }, { value: 3, label: "March" }, { value: 4, label: "April" }, { value: 5, label: "May" }, { value: 6, label: "June" }, { value: 7, label: "July" }, { value: 8, label: "August" }, { value: 9, label: "September" }, { value: 10, label: "October" },  {value: 11, label: "November" }, { value: 12, label: "December"} };
Mon, Apr 23, 1:24 AM · efl

Sun, Apr 22

Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

In short, we have 4 options as follows.

Sun, Apr 22, 11:27 PM
Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

<Solution only for Efl Ui Interface Theme>

  1. In efl ui interface EDC, I want to send signals with part name itself as follows. Both "elm.swallow.content" and "content" parts exist, then "state,efl.content,set" "efl" and "state,content,set" "efl" are emitted.
  2. Keep "efl" only for source. So "state,efl.content,set" "efl" is emitted instead of "efl,state,efl.content,set" "efl".

    What do you think about the above?

What about "state,content,set" "efl" ?

Sun, Apr 22, 8:54 PM

Fri, Apr 20

Jaehyun_Cho added a comment to D5871: Intrudoce Efl Ui Date, Time interface and picker..

Please check the comments

Fri, Apr 20, 6:44 AM

Apr 20 2018

Jaehyun_Cho closed D5973: evas_engine: remove logically dead code.
Apr 20 2018, 3:07 AM
Jaehyun_Cho accepted D5973: evas_engine: remove logically dead code.
Apr 20 2018, 3:07 AM
Jaehyun_Cho closed D5975: ecore_con: remove unused code.
Apr 20 2018, 2:29 AM
Jaehyun_Cho accepted D5975: ecore_con: remove unused code.
Apr 20 2018, 2:28 AM
Jaehyun_Cho closed D5974: efl_ui_progressbar: add null check.
Apr 20 2018, 1:50 AM
Jaehyun_Cho accepted D5974: efl_ui_progressbar: add null check.
Apr 20 2018, 1:49 AM
Jaehyun_Cho retitled D5974: efl_ui_progressbar: add null check from efl.ui.progressbar: add null check to efl_ui_progressbar: add null check.
Apr 20 2018, 1:49 AM
Jaehyun_Cho added a comment to D5954: Revert Efl.Ui.Multibuttonentry to create new one..

@raster
I apologize it's my fault.
I will check carefully.

Apr 20 2018, 1:39 AM

Apr 19 2018

Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

Thank you for answering the questions. The answers for my 1st and 2nd questions are clear.

Apr 19 2018, 11:40 PM
Jaehyun_Cho added a comment to D5871: Intrudoce Efl Ui Date, Time interface and picker..

Please check the comments

Apr 19 2018, 7:12 AM
Jaehyun_Cho closed D5954: Revert Efl.Ui.Multibuttonentry to create new one..
Apr 19 2018, 6:29 AM
Jaehyun_Cho accepted D5954: Revert Efl.Ui.Multibuttonentry to create new one..
Apr 19 2018, 6:20 AM
Jaehyun_Cho added a comment to D5954: Revert Efl.Ui.Multibuttonentry to create new one..
Apr 19 2018, 6:09 AM
Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

I have questions about your comments as follows.

Apr 19 2018, 5:54 AM
Jaehyun_Cho added a comment to D5969: efl_ui_spin: Added special value feature..

I think another name is better than special_value_add().

Apr 19 2018, 4:51 AM · efl

Apr 17 2018

Jaehyun_Cho added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@cedric
I understand your point. But we think more about C# part interface here.
For the "background" part interface, background.color_set() would be used.
In this case, if the edc part name is "efl.background", then it would be confusing to application developer who customizes their own edc file.

Apr 17 2018, 11:42 PM
Jaehyun_Cho closed T6796: focus(slider): slider can't get key_actions. as Resolved by committing rEFL2c8c7807f1d6: config: fix Efl.Ui.Slider key binding.
Apr 17 2018, 11:35 PM · Bug Report, efl
Jaehyun_Cho closed D5962: config: fix Efl.Ui.Slider key binding.
Apr 17 2018, 11:35 PM
Jaehyun_Cho accepted D5962: config: fix Efl.Ui.Slider key binding.
Apr 17 2018, 11:34 PM

Apr 13 2018

Jaehyun_Cho requested changes to D5871: Intrudoce Efl Ui Date, Time interface and picker..

Now in efl_ui_widget, if there is a sub widget in a widget, then the sub widget's theme should be written in widget's theme.
e.g. efl_ui_popup_alert creates buttons and the button theme is written in popup.edc.
The button group name is "efl/popup_alert/button"). And elm_widget_element_update() is called to load the group.

Apr 13 2018, 12:38 AM

Apr 12 2018

Jaehyun_Cho added a comment to D5871: Intrudoce Efl Ui Date, Time interface and picker..

Please check the comments

Apr 12 2018, 10:31 PM
Jaehyun_Cho closed D5929: efl_ui_frame: remove dulicated _content_aliases.
Apr 12 2018, 6:12 AM
Jaehyun_Cho accepted D5929: efl_ui_frame: remove dulicated _content_aliases.
Apr 12 2018, 6:11 AM

Apr 8 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.

I am thinking of providing the following events in Efl.Ui.Frame_Stack.

Apr 8 2018, 9:40 PM · Restricted Project, efl
Jaehyun_Cho added a comment to T5351: New Naviframe API.

The Efl.Ui.Navigation_Bar eo is as follows to support back_button as its part object.

Apr 8 2018, 9:34 PM · Restricted Project, efl
Jaehyun_Cho added a comment to T5351: New Naviframe API.

The Efl.Ui.Navigation_Frame eo is as follows to support title_bar as a property.

Apr 8 2018, 9:33 PM · Restricted Project, efl

Apr 2 2018

Jaehyun_Cho requested changes to D5846: efl_ui_text_alert_popup: rename from efl_ui_popup_alert_text to efl_ui_text_alert_popup.

Please change the name to "Efl.Ui.Text_Alert_Popup".

Apr 2 2018, 10:07 PM
Jaehyun_Cho requested changes to D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup.

Please change the test case window name to "Efl.Ui.Scroll_Alert_Popup".

Apr 2 2018, 10:05 PM
Jaehyun_Cho reopened T6793: focus: focus is gone if a focused object is unfocused as "Open".

@bu5hm4n
After applying the patch "efl_ui_focus_manager: move cleanup into one place" (ca2461c28027ae1a64ec89893e459cf76bdc1269), infinite loop case happens.

Apr 2 2018, 9:15 PM · Efl.Ui.Focus, Bug Report, efl
Jaehyun_Cho reopened T6793: focus: focus is gone if a focused object is unfocused, a subtask of T3088: Elementary needs a complete focus overhaul, as Open.
Apr 2 2018, 9:15 PM · Efl.Ui.Focus, efl
Jaehyun_Cho added a comment to T5351: New Naviframe API.

OK, I will make "bar" as a property of frame for better customization :)

Apr 2 2018, 9:00 PM · Restricted Project, efl

Mar 20 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.

@cedric @woohyun

For the title area of navigation frame, I have not decided how to design or implement it.
However, for now I have an idea as follows.

  1. Introduce Efl.Ui.Navigation_Bar class.
  2. navigation bar instance is automatically created inside navigation frame instance.

    Here, there are many things to think about.
  3. is bar a property of navigation frame? or an efl_part of navigation frame? 2-1. if bar is a property, then is it ok to provide get/set to modify bar by application developer? 2-2. if bar is an efl_part, then how to modify bar's propery? and how to replace bar with other kind of bar? (e.g. replace Efl.Ui.Navigation_Bar class instance with Efl.Ui.Search_Bar or Efl.Ui.Tab_Bar class instance)

    @cedric @woohyun Please give me any feedback about this.
Mar 20 2018, 6:00 PM · Restricted Project, efl
Jaehyun_Cho added a comment to D5666: Efl.Ui.Popup.Anchor.List: add initial code.

Efl.Ui.Popup.Anchor.List class probably requires its own item class or interface.
Since this class instance can be created by adding Efl.Ui.Popup.Anchor with list, the priority of this class is not that high.
I think it would be better that this class implementation is finished after other item based class implementation is finished.

Mar 20 2018, 5:56 PM · efl
Jaehyun_Cho closed D5826: efl_ui_clock: Fix wrong target to compare with..
Mar 20 2018, 5:11 AM
Jaehyun_Cho accepted D5826: efl_ui_clock: Fix wrong target to compare with..
Mar 20 2018, 5:09 AM

Mar 13 2018

Jaehyun_Cho added a comment to T5358: Refactoring multi button entry.

@Jaehyun_Cho
I've refered the definition of pack_at in Efl.Ui.Pack interface.
(i.e. pack_at(obj, sobj, index)

If MBE case should be cared differently, you could be right - but, I do think keeping consistency would be better.
How do you think about this ?

Mar 13 2018, 7:07 PM · Restricted Project, efl
Jaehyun_Cho added a comment to T5358: Refactoring multi button entry.

@CHAN
I think below are correct. Please check whether I'm wrong.

efl_ui_multibuttonentry_item_append(mbe, 1, "test"); -> efl_ui_multibuttonentry_item_append(obj, text);
efl_ui_multibuttonetnry_item_text_set(mbe, 1, "change"); -> efl_ui_multibuttonetnry_item_text_set(obj, text, index);

Mar 13 2018, 4:17 AM · Restricted Project, efl

Mar 9 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.

For the title area of navigation frame, I have not decided how to design or implement it.
However, for now I have an idea as follows.

Mar 9 2018, 12:09 AM · Restricted Project, efl

Mar 8 2018

Jaehyun_Cho added a comment to T5351: New Naviframe API.

This is the on-going classes for navigation.
Basically application developer creates Efl.Ui.Navigation_Frame class instance and push it into Efl.Ui.Frame_Stack class instance.

Mar 8 2018, 11:58 PM · Restricted Project, efl

Feb 27 2018

Jaehyun_Cho requested changes to D5826: efl_ui_clock: Fix wrong target to compare with..

@CHAN
I am not sure if we need to handle field limit for DAY and AMPM.
What do you think?

Feb 27 2018, 3:25 AM
Jaehyun_Cho closed D5825: elm_datetime: Handle wrong param case for legacy..
Feb 27 2018, 3:05 AM
Jaehyun_Cho accepted D5825: elm_datetime: Handle wrong param case for legacy..
Feb 27 2018, 3:01 AM

Feb 26 2018

Jaehyun_Cho closed D5818: efl.ui.progressbar: change signal name for icon/text.
Feb 26 2018, 4:26 AM
Jaehyun_Cho closed D5819: elm_part: use TYPE _CLASS instead of MY_CLASS.
Feb 26 2018, 4:26 AM
Jaehyun_Cho accepted D5818: efl.ui.progressbar: change signal name for icon/text.
Feb 26 2018, 4:21 AM
Jaehyun_Cho accepted D5819: elm_part: use TYPE _CLASS instead of MY_CLASS.
Feb 26 2018, 4:21 AM