Nice catch! Thank you! :)

Thank you for this patch! :)

I think that if EDI's wizard registers pop_cb and does nothing in pop_cb and returns EINA_FALSE in the pop_cb, then the last item is not popped.

I think this patch breaks the backward compatibility.
Because users can register their own pop_cb by using elm_naviframe_item_pop_cb_set().
So if the popped item is the last item, then users' pop_cb is called and elm_win or something is deleted manually in the pop_cb.
However, this patch do not allow pop_cb is called if the popped item is the last item.
So I think this patch should not be accepted.

In D11358#219456, @bu5hm4n wrote:

Mhm, I would really like to keep the semantik that the out animation is played backwards, as that saves for the cases we have right now *a lot* of memory and duplication. What we could do, to support easier creation of the out animation, we could introduce a backward interpolator which maps [0..1] -> [1..0], would that be fine for you ?

If the backwards animation logic is not important in this patch, then it would be fine to submit this patch now and later I will make a patch to remove backwards animation logic.

Thank you for adding parameters to push_setup and pop_setup.

In D11358#218908, @bu5hm4n wrote:

Okay yeah, that is i think what i said in my first comment.

The idea here is that you can associate a animation with a operation, and when you push something in, the object that is currently active, is simply faded out. Is there really the demand that someone wants to have a different "move out" animation depending on if its a jump or a push?

I made a patch onto this patch on my dev branch (devs/jaehyun/animation_manager) as a test version.
https://git.enlightenment.org/core/efl.git/commit/?h=devs/jaehyun/animation_manager&id=72da9ec8c6ef9e6081979c1caae3e4749d0a9965

I am not sure I understood your comment correctly.
So I want to explain my previous comment with more precisely.

Sorry I missed this one.

Sorry, I made D11394 to revert this.
I will discuss this patch with @CHAN again.

@CHAN we need to think about the comments on D11378 from @bu5hm4n and @segfaultxavi

You are right :) Thank you!

fix build error

Is it OK if this patch is submitted?

thank you! :)

Apply clipper not to cause tests fail with setting data "_elm_leaveme".

Oh! I missed plain;; thank you!

add code for spotlight manager plain, too

As this patch describes, now group_member_add() of efl_ui_widget set color_set() manually. This causes packed rectangle's color change.

thank you for the update!

How about using global variable static unsigned int ts ?

static unsigned int ts = 0; //global variable in suite_helpers.c

Because the timestamp of each function begins with 0 so timestamp 0 is used in the functions at the same time.
e.g.

//In test code
drag_object(...); //timestamp 0 is used with evas_event_feed_mouse_move
wheel_object_at(...); //timestamp 0 is used with evas_event_feed_mouse_move

There are many patches related to gesture. (D11052, D11053, ...)
Therefore, to avoid conflict to the above patches, this patch should not be merged until either those patches are merged or abandoned.

This patch is basically the same with D11108.

This patch suggests using "Animation" as a postfix of animation class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation

update description about the value is_duration_set

I agree with your opinion! Power_Interpolator :)

It seems that GetEoOps() can be called multiple times if inherited classes' instances are created.

It seems that it is required to consider that only specific part classes generate extension classes (not all part classes) as @woohyun mentioned. (e.g. Efl.Ui.Layout_Part_Text, ...)

Thank you for your reply! Now I understand your point and I agree with you.

• NOW : radius_get { } for Efl.Canvas.Gesture_Zoom
• TODO : @property radius { get { } } for Efl.Canvas.Gesture_Zoom

Based on the above discussion, how about the followings in efl_model.eo?

child,added : Efl.Model_Child_Event;
child,removed : Efl.Model_Child_Event;
children,added : Efl.Model_Children_Event;
children,removed : Efl.Model_Children_Event;

This class was added based on ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, ECORE_POS_MAP_DIVISOR_INTERP and ECORE_POS_MAP_DIVISOR_INTERP.

Their fields should be read-only properties instead of methods. This is more natural for bindings.

Do you mean that EITHER Efl.Canvas.Gesture provides read-only properties OR Efl.Canvas.Gesture's setter methods / writable properties should not be public?

In D10929#205857, @YOhoho wrote:

Also, This patch will fix CA1052(T8398).