Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (339 w, 6 d)
Availability
Available

Recent Activity

Thu, Jan 23

Jaehyun_Cho abandoned D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Thu, Jan 23, 4:37 AM · efl

Wed, Jan 22

Jaehyun_Cho updated the summary of D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Wed, Jan 22, 10:14 PM · efl
Jaehyun_Cho updated the diff for D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.

fix build error

Wed, Jan 22, 10:14 PM · efl
Jaehyun_Cho requested review of D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Wed, Jan 22, 9:20 PM · efl
Jaehyun_Cho closed D11143: efl_ui_spotlight: rename Stack_Manager to Fade_Manager.
Wed, Jan 22, 8:01 PM · efl
Jaehyun_Cho closed D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.
Wed, Jan 22, 8:01 PM · efl
Jaehyun_Cho accepted D11152: eolian_mono: generate Efl.IPlayer.PlaybackPosition again.
Wed, Jan 22, 1:05 AM · efl

Tue, Jan 21

Jaehyun_Cho added a comment to D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.

Is it OK if this patch is submitted?

Tue, Jan 21, 9:48 PM · efl
Jaehyun_Cho requested review of D11143: efl_ui_spotlight: rename Stack_Manager to Fade_Manager.
Tue, Jan 21, 4:14 AM · efl
Jaehyun_Cho requested review of D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.
Tue, Jan 21, 3:43 AM · efl
Jaehyun_Cho accepted D11135: efl_ui_spotlight/pager/stack: remove @beta.

thank you! :)

Tue, Jan 21, 3:01 AM · efl
Jaehyun_Cho closed D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.
Tue, Jan 21, 2:33 AM · efl

Mon, Jan 20

Jaehyun_Cho updated the diff for D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

Apply clipper not to cause tests fail with setting data "_elm_leaveme".

Mon, Jan 20, 11:42 PM · efl
Jaehyun_Cho added a comment to D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

Oh! I missed plain;; thank you!

Mon, Jan 20, 4:41 AM · efl
Jaehyun_Cho updated the diff for D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

add code for spotlight manager plain, too

Mon, Jan 20, 4:40 AM · efl
Jaehyun_Cho added a comment to D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

As this patch describes, now group_member_add() of efl_ui_widget set color_set() manually. This causes packed rectangle's color change.

Mon, Jan 20, 4:38 AM · efl
Jaehyun_Cho requested review of D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.
Mon, Jan 20, 1:54 AM · efl

Sun, Jan 19

Jaehyun_Cho closed D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.
Sun, Jan 19, 8:04 PM · efl
Jaehyun_Cho accepted D11028: tests/elm: add basic timestamping for event helpers.

thank you for the update!

Sun, Jan 19, 7:51 PM · efl

Fri, Jan 17

Jaehyun_Cho added a comment to D11028: tests/elm: add basic timestamping for event helpers.

How about using global variable static unsigned int ts ?

static unsigned int ts = 0; //global variable in suite_helpers.c

Because the timestamp of each function begins with 0 so timestamp 0 is used in the functions at the same time.
e.g.

//In test code
drag_object(...); //timestamp 0 is used with evas_event_feed_mouse_move
wheel_object_at(...); //timestamp 0 is used with evas_event_feed_mouse_move
Fri, Jan 17, 12:31 AM · efl

Thu, Jan 16

Jaehyun_Cho accepted D11027: efl/gesture: do not emit events for canceled gestures with no state.
Thu, Jan 16, 10:19 PM · efl
Jaehyun_Cho added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

There are many patches related to gesture. (D11052, D11053, ...)
Therefore, to avoid conflict to the above patches, this patch should not be merged until either those patches are merged or abandoned.

Thu, Jan 16, 9:44 PM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture: DO NOT MERGE.
Thu, Jan 16, 9:40 PM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

This patch is basically the same with D11108.

Thu, Jan 16, 3:54 AM · DO NOT MERGE, efl
Jaehyun_Cho requested review of D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.
Thu, Jan 16, 3:51 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.

This patch suggests using "Animation" as a postfix of animation class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation

Thu, Jan 16, 12:02 AM · efl

Wed, Jan 15

Jaehyun_Cho requested review of D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.
Wed, Jan 15, 11:59 PM · efl
Jaehyun_Cho closed D11104: efl_canvas_animation_group: preserve each animation's duration.
Wed, Jan 15, 2:13 AM · efl
Jaehyun_Cho closed D11101: efl_mono: remove class ExtensionTag.
Wed, Jan 15, 1:49 AM · efl
Jaehyun_Cho updated the diff for D11104: efl_canvas_animation_group: preserve each animation's duration.

update description about the value is_duration_set

Wed, Jan 15, 1:44 AM · efl
Jaehyun_Cho requested review of D11104: efl_canvas_animation_group: preserve each animation's duration.
Wed, Jan 15, 1:43 AM · efl

Tue, Jan 14

Jaehyun_Cho requested review of D11101: efl_mono: remove class ExtensionTag.
Tue, Jan 14, 10:15 PM · efl
Jaehyun_Cho added a reviewer for D11094: evas_gesture: change getter methods to read-only properties: CHAN.
Tue, Jan 14, 6:25 PM · efl
Jaehyun_Cho requested review of D11094: evas_gesture: change getter methods to read-only properties.
Tue, Jan 14, 4:08 AM · efl
Jaehyun_Cho added a revision to T8557: Pending work on gesture event structs: D11094: evas_gesture: change getter methods to read-only properties.
Tue, Jan 14, 4:08 AM · efl: api, efl: docs, efl (efl-1.24)
Jaehyun_Cho added a comment to T8450: efl.divisor_interpolator.

I agree with your opinion! Power_Interpolator :)

Tue, Jan 14, 4:07 AM · efl: api, efl (efl-1.24)
Jaehyun_Cho created T8572: efl.canvas.rectangle.
Tue, Jan 14, 3:32 AM · efl: api
Jaehyun_Cho requested changes to D11071: eolian_mono: remove unnecessary variable declaration.

It seems that GetEoOps() can be called multiple times if inherited classes' instances are created.

Tue, Jan 14, 3:20 AM · efl
Jaehyun_Cho requested changes to D11091: c#: Remove extension methods for classes that can't use it.

It seems that it is required to consider that only specific part classes generate extension classes (not all part classes) as @woohyun mentioned. (e.g. Efl.Ui.Layout_Part_Text, ...)

Tue, Jan 14, 2:19 AM · efl
Jaehyun_Cho closed D10902: eina_mono: replace eina_list and eina_array with IList.
Tue, Jan 14, 12:19 AM · efl
Jaehyun_Cho added a commit to T8486: C#: Use System.Collection instead of Eina classes in C# API: rEFLae30d3c57bc2: eina_mono: replace eina_list and eina_array with IList.
Tue, Jan 14, 12:19 AM · efl: language bindings
Jaehyun_Cho accepted D10902: eina_mono: replace eina_list and eina_array with IList.
Tue, Jan 14, 12:16 AM · efl

Mon, Jan 13

Jaehyun_Cho accepted D11091: c#: Remove extension methods for classes that can't use it.
Mon, Jan 13, 10:17 PM · efl
Jaehyun_Cho added a comment to T8557: Pending work on gesture event structs.

Thank you for your reply! Now I understand your point and I agree with you.

  • NOW : radius_get { } for Efl.Canvas.Gesture_Zoom
  • TODO : @property radius { get { } } for Efl.Canvas.Gesture_Zoom
Mon, Jan 13, 6:27 PM · efl: api, efl: docs, efl (efl-1.24)
Jaehyun_Cho requested review of D11073: efl_gesture: rename Efl.Gesture.Events to Efl.Canvas.Gesture_Events.
Mon, Jan 13, 2:18 AM · efl

Sun, Jan 12

Jaehyun_Cho added a comment to D10935: efl_model: stablized child,added child,removed events..

Based on the above discussion, how about the followings in efl_model.eo?

child,added : Efl.Model_Child_Event;
child,removed : Efl.Model_Child_Event;
children,added : Efl.Model_Children_Event;
children,removed : Efl.Model_Children_Event;
Sun, Jan 12, 10:52 PM · efl
Jaehyun_Cho added a comment to T8450: efl.divisor_interpolator.

This class was added based on ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, ECORE_POS_MAP_DIVISOR_INTERP and ECORE_POS_MAP_DIVISOR_INTERP.

Sun, Jan 12, 10:38 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8557: Pending work on gesture event structs.

Their fields should be read-only properties instead of methods. This is more natural for bindings.

Do you mean that EITHER Efl.Canvas.Gesture provides read-only properties OR Efl.Canvas.Gesture's setter methods / writable properties should not be public?

Sun, Jan 12, 10:24 PM · efl: api, efl: docs, efl (efl-1.24)

Mon, Jan 6

Jaehyun_Cho closed D10913: csharp: rename ExtensionMethods.
Mon, Jan 6, 3:01 AM · efl
Jaehyun_Cho closed D10972: eolian_mono: add namespace to extension methods of ItemFactory.
Mon, Jan 6, 3:01 AM · efl
Jaehyun_Cho accepted D10913: csharp: rename ExtensionMethods.
Mon, Jan 6, 2:08 AM · efl

Dec 26 2019

Jaehyun_Cho requested review of D10972: eolian_mono: add namespace to extension methods of ItemFactory.
Dec 26 2019, 11:39 PM · efl

Dec 22 2019

Jaehyun_Cho closed D10952: eolian_mono : add verb unselect on naming helper..
Dec 22 2019, 11:21 PM · efl
Jaehyun_Cho accepted D10952: eolian_mono : add verb unselect on naming helper..
Dec 22 2019, 11:20 PM · efl

Dec 20 2019

Jaehyun_Cho requested review of D10940: efl_ui_widget: add description of widget parts.
Dec 20 2019, 4:26 AM · efl
Jaehyun_Cho abandoned D10932: efl_interface : add since version to stabilized Efl_Model_Children_Event.
Dec 20 2019, 12:38 AM · efl

Dec 19 2019

Jaehyun_Cho requested review of D10933: csharp: add documentation of class Efl.Eo.Config in iwrapper.
Dec 19 2019, 10:52 PM · efl
Jaehyun_Cho requested review of D10932: efl_interface : add since version to stabilized Efl_Model_Children_Event.
Dec 19 2019, 9:51 PM · efl
Jaehyun_Cho added a comment to D10929: eolian_mono: change Constants class to static class.

Also, This patch will fix CA1052(T8398).

Dec 19 2019, 9:33 PM · efl
Jaehyun_Cho added a commit to T8398: C#: CA1052: Static holder types should be Static or NotInheritable: rEFL8146728c7809: eolian_mono: change Constants class to static class.
Dec 19 2019, 9:31 PM · efl: language bindings
Jaehyun_Cho closed D10929: eolian_mono: change Constants class to static class.
Dec 19 2019, 9:31 PM · efl
Jaehyun_Cho requested review of D10929: eolian_mono: change Constants class to static class.
Dec 19 2019, 6:37 PM · efl

Dec 18 2019

Jaehyun_Cho closed D10914: csharp: remove unused code in workaround.
Dec 18 2019, 11:33 PM · efl
Jaehyun_Cho closed D10905: eolina_mono: prevent empty ExtensionMethods class.
Dec 18 2019, 11:32 PM · efl
Jaehyun_Cho accepted D10914: csharp: remove unused code in workaround.
Dec 18 2019, 11:29 PM · efl
Jaehyun_Cho accepted D10905: eolina_mono: prevent empty ExtensionMethods class.

It's nice! :) Thank you!

Dec 18 2019, 11:28 PM · efl

Dec 16 2019

Jaehyun_Cho added a comment to D10890: csharp: Translate class names..

Is it possible to apply this scheme to other data types? (e.g. enum in .eo)

Dec 16 2019, 11:26 PM · efl
Jaehyun_Cho requested changes to D10890: csharp: Translate class names..
Dec 16 2019, 11:02 PM · efl
Jaehyun_Cho added a comment to D10828: Introduce indicator API.

Thank you for the patch :)

Dec 16 2019, 10:24 PM · efl
Jaehyun_Cho accepted D10890: csharp: Translate class names..
Dec 16 2019, 10:11 PM · efl

Dec 11 2019

Jaehyun_Cho accepted D10840: efl_ui_scroller: free pan object correctly.

Thank you!

Dec 11 2019, 9:55 PM · efl
Jaehyun_Cho requested changes to D10840: efl_ui_scroller: free pan object correctly.
Dec 11 2019, 4:46 AM · efl
Jaehyun_Cho accepted D10837: efl_ui_popup: do not leak the backwall part.

Thank you for this patch!

Dec 11 2019, 4:26 AM · efl

Dec 10 2019

Jaehyun_Cho closed D10854: edje_entry: Fix resource leak..
Dec 10 2019, 10:51 PM · efl

Dec 8 2019

Jaehyun_Cho added a comment to T7991: efl.ui.spotlight.container.

@bu5hm4n
I also agree with @segfaultxavi and you. Let's keep push and pop in the place~ Thank you :)

Dec 8 2019, 6:48 PM · efl (efl-1.24), efl: language bindings

Dec 6 2019

Jaehyun_Cho added a commit to T8436: efl.canvas.animation: rEFLcb817caa808b: efl_canvas_object_animation: support duration 0.
Dec 6 2019, 9:14 AM · efl: api, efl (efl-1.24)
Jaehyun_Cho closed D10812: efl_canvas_object_animation: support duration 0.
Dec 6 2019, 9:14 AM · efl
Jaehyun_Cho added a commit to T8513: efl.canvas.object_animation: rEFLcb817caa808b: efl_canvas_object_animation: support duration 0.
Dec 6 2019, 9:14 AM · efl: api, efl (efl-1.24)
Jaehyun_Cho updated the diff for D10812: efl_canvas_object_animation: support duration 0.

Unit test is added. Thank you :)

Dec 6 2019, 8:27 AM · efl
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I understand your point that non-zero value would be more useful as default duration than 0.
So I restored the default duration of animation in D10812.

Dec 6 2019, 2:53 AM · efl: api, efl (efl-1.24)
Jaehyun_Cho updated the summary of D10812: efl_canvas_object_animation: support duration 0.
Dec 6 2019, 1:43 AM · efl
Jaehyun_Cho added inline comments to D10812: efl_canvas_object_animation: support duration 0.
Dec 6 2019, 1:43 AM · efl
Jaehyun_Cho updated the diff for D10812: efl_canvas_object_animation: support duration 0.

fixed vector if speed < 0.0.
modified duration check codes to support duration 0.

Dec 6 2019, 1:28 AM · efl
Jaehyun_Cho closed D10820: efl_ui_alert_popup: remove beta for efl_ui_alert_popup_title.
Dec 6 2019, 12:49 AM · efl
Jaehyun_Cho accepted D10820: efl_ui_alert_popup: remove beta for efl_ui_alert_popup_title.
Dec 6 2019, 12:48 AM · efl

Dec 5 2019

Jaehyun_Cho added tasks to D10812: efl_canvas_object_animation: support duration 0: T8513: efl.canvas.object_animation, T8436: efl.canvas.animation.
Dec 5 2019, 9:21 PM · efl
Jaehyun_Cho added a revision to T8436: efl.canvas.animation: D10812: efl_canvas_object_animation: support duration 0.
Dec 5 2019, 9:21 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho added a revision to T8513: efl.canvas.object_animation: D10812: efl_canvas_object_animation: support duration 0.
Dec 5 2019, 9:21 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho moved T8514: remove @move from get { } if ownership is not moved by getter from Backlog to Evaluating on the efl: api board.
Dec 5 2019, 9:20 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho created T8514: remove @move from get { } if ownership is not moved by getter.
Dec 5 2019, 9:19 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I don't mind the function setting default duration value :)
It may be useful to someone who wants to set the same duration multiple times~
I simply think that we need to let animation support duration 0 as well.

Dec 5 2019, 6:52 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho updated the diff for D10812: efl_canvas_object_animation: support duration 0.

updates task refs

Dec 5 2019, 6:34 PM · efl
Jaehyun_Cho moved T8513: efl.canvas.object_animation from Backlog to Evaluating on the efl: api board.
Dec 5 2019, 6:32 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho triaged T8513: efl.canvas.object_animation as Normal priority.
Dec 5 2019, 6:32 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho created T8513: efl.canvas.object_animation.
Dec 5 2019, 6:31 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho requested review of D10812: efl_canvas_object_animation: support duration 0.
Dec 5 2019, 6:26 PM · efl
Jaehyun_Cho added a comment to T8436: efl.canvas.animation.

I think if duration is 0, then the final state of animation is applied immediately. (It seems that current animation logic does not support duration 0)

Dec 5 2019, 3:46 AM · efl: api, efl (efl-1.24)

Dec 3 2019

Jaehyun_Cho added a comment to T7991: efl.ui.spotlight.container.

It is theoretically possible. However, the implementation in Efl.Ui.Spotlight.Container is *way* more performent, and does not need event subscriptions at all ..., its a matter or priority i guess. What if we call them "animated_insert" and "animated_remove", and move the name push and pop to Stack, where we can also ensure that @segfaultxavi's concerns are met ?

Thank you for your reply :)

Dec 3 2019, 3:18 AM · efl (efl-1.24), efl: language bindings
Jaehyun_Cho added a comment to T7991: efl.ui.spotlight.container.

@bu5hm4n @segfaultxavi
Thank you very much :)

Dec 3 2019, 1:48 AM · efl (efl-1.24), efl: language bindings

Dec 1 2019

Jaehyun_Cho moved T7864: efl.gfx.arrangement from Evaluating to Stabilized on the efl: api board.
Dec 1 2019, 10:04 PM · efl (efl-1.24), efl: api, efl: language bindings