Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (295 w, 4 d)
Availability
Available

Recent Activity

Today

Jaehyun_Cho updated the diff for D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor.

change Efl.Ui.Text_Cursor_Selectable to Efl.Ui.Text_Selectable

Sun, Mar 24, 8:50 PM · Restricted Project
Jaehyun_Cho edited projects for D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor, added: Restricted Project; removed efl.
Sun, Mar 24, 7:33 PM · Restricted Project
Jaehyun_Cho added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor.

@bu5hm4n
Thank you for the feedback :)
I wanted to apply this change before release but as you say let's wait until release because these interfaces are @beta ;)

Sun, Mar 24, 7:32 PM · Restricted Project

Fri, Mar 22

Jaehyun_Cho added a comment to D7495: csharp: add a interface to start apps.

What do you think about removing the namespace "Csharp"? (if so the file name is also changed to efl_application.cs)

Fri, Mar 22, 1:56 AM · efl: language bindings
Jaehyun_Cho added a commit to T7724: split out legacy from eo files: rEFL44d0cb926098: elm_atspi_bridge: remove all legacy usage from eo files.
Fri, Mar 22, 12:09 AM · Restricted Project
Jaehyun_Cho added a commit to T7724: split out legacy from eo files: rEFL0225db71c06c: elm_atspi_app_object: remove all legacy usage from eo files.
Fri, Mar 22, 12:09 AM · Restricted Project

Thu, Mar 21

Jaehyun_Cho closed D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Thu, Mar 21, 8:39 PM · efl
Jaehyun_Cho accepted D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Thu, Mar 21, 8:38 PM · efl
Jaehyun_Cho updated the summary of D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Thu, Mar 21, 8:37 PM · efl
Jaehyun_Cho added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor.

Please give some comments on this patch.

Thu, Mar 21, 7:16 PM · Restricted Project
Jaehyun_Cho updated the summary of D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor.
Thu, Mar 21, 7:14 PM · Restricted Project
Jaehyun_Cho requested review of D8442: efl_ui_selectable: separate efl_ui_selectable into item and text_cursor.
Thu, Mar 21, 7:14 PM · Restricted Project
Jaehyun_Cho updated subscribers of T7766: Separate Efl.Ui.Selectable into item selection events and cursor selection events.
Thu, Mar 21, 7:13 PM · efl (efl-1.22)
Jaehyun_Cho created T7766: Separate Efl.Ui.Selectable into item selection events and cursor selection events.
Thu, Mar 21, 6:53 PM · efl (efl-1.22)

Wed, Mar 20

Jaehyun_Cho added a comment to T7701: Rename Efl.Ui.Stack.

@zmike
ok~ then please suggest a new name :)

Wed, Mar 20, 7:26 PM · efl: api
Jaehyun_Cho accepted D8094: ui.box_stack: refactor layout_update.

rebase has been applied

Wed, Mar 20, 5:12 AM · efl
Jaehyun_Cho added inline comments to D8094: ui.box_stack: refactor layout_update.
Wed, Mar 20, 5:08 AM · efl
Jaehyun_Cho closed T7701: Rename Efl.Ui.Stack as Wontfix.

The original name Efl.Ui.Stack is preserved.

Wed, Mar 20, 5:00 AM · efl: api
Jaehyun_Cho added a comment to D8094: ui.box_stack: refactor layout_update.

Could you tell me why memory initialization is required only for debugging mode?

Wed, Mar 20, 4:56 AM · efl

Mon, Mar 18

Jaehyun_Cho closed D8399: Evas: Add type convert function for BIDI_Direction_Type..
Mon, Mar 18, 8:28 PM · efl
Jaehyun_Cho accepted D8399: Evas: Add type convert function for BIDI_Direction_Type..
Mon, Mar 18, 7:34 PM · efl

Wed, Mar 13

Jaehyun_Cho added a comment to T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text.

D7888 is reverted since it breaks the backward compatibility. So D7603 is also reverted since it is based on D7888.
Now a new proper patch is required instead of D7888 to fulfill D7603.

Wed, Mar 13, 3:31 AM · regression, efl (efl-1.22)
Jaehyun_Cho added a comment to D7603: tests: add test for elm_layout_text_set.

Since we should revert D7888, this patch is also required to be reverted just for now.
After a proper patch is applied instead of D7888, then I think that we can submit this patch again.

Wed, Mar 13, 3:24 AM · efl
Jaehyun_Cho added a comment to D7888: efl_ui_layout: check part existence in text_set.

I am afraid this patch breaks the backward compatibility.
Please check the Popup -> popup-center-text in elementary_test. (text is not displayed.)

Wed, Mar 13, 3:21 AM · efl: widgets

Sun, Mar 10

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Sun, Mar 10, 11:30 PM · efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

This is a minor suggestion of moving code inside the conditional expression.

Sun, Mar 10, 9:52 PM · efl
Jaehyun_Cho added inline comments to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
Sun, Mar 10, 7:40 PM · efl

Fri, Mar 8

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Regardless of this patch, what do you think about changing method name "create" in Efl.Canvas.Gesture.Recognizer to "gesture_create"?

Fri, Mar 8, 4:40 AM · efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I have checked the code and tested the functionality.
And I found out that win cannot add gesture event.
Is it originally intended?

Fri, Mar 8, 3:18 AM · efl

Thu, Mar 7

Jaehyun_Cho added a comment to D7962: efl_ui_win: Added more gesture config values for gesture manager..

Are the other glayer values not required for now?

Thu, Mar 7, 10:03 PM · efl
Jaehyun_Cho accepted D7249: C# bindings: Make efl_gesture_Manager.eo available to bindings.
Thu, Mar 7, 9:26 PM · efl
Jaehyun_Cho updated the diff for D7249: C# bindings: Make efl_gesture_Manager.eo available to bindings.

rebase

Thu, Mar 7, 9:24 PM · efl

Thu, Feb 28

Jaehyun_Cho updated subscribers of T7553: efl.ui.widget.

Could you please mark @beta for scroll methods?
As @bu5hm4n said, it may be not the right place for these methods..
I think that @eagleeye will check if it is possible to move these methods out of Efl.Ui.Widget. (T7714)

Thu, Feb 28, 4:02 AM · efl: api, efl (efl-1.22)
Jaehyun_Cho added a comment to T7511: efl.ui.win.

IMHO, I think the following properties/methods/events are essential for Efl.Ui.Win.

Thu, Feb 28, 3:54 AM · efl: api, efl (efl-1.22)
Jaehyun_Cho added a comment to T7511: efl.ui.win.

I don't mind if you remove the properties/methods/events which you mentioned that those are not used or are related to only X11.
It is fine if those are preserved in legacy at least :)

Thu, Feb 28, 2:48 AM · efl: api, efl (efl-1.22)
Jaehyun_Cho added a comment to T7512: efl.ui.layout.

It seems that all the properties and methods are required to be marked @beta for now :)
(P) theme may be required to change its values (style) based on @bu5hm4n and your opinion.
(P) automatic_theme_rotation and (M) theme_rotation_apply are submitted recently. So it seems that it requires some time to check them.

Thu, Feb 28, 2:38 AM · efl: api, efl (efl-1.22)

Wed, Feb 27

Jaehyun_Cho created T7714: Remove scroll push/pop methods from Efl.Ui.Widget.
Wed, Feb 27, 10:31 PM · efl

Tue, Feb 26

Jaehyun_Cho added a comment to D8015: efl_ui_widget: move orientation to the specific users of this widget.

2: This property is removed, so there is no point in renaming it to this ?

Sorry about this. I missed that the property is removed in this patch.

Tue, Feb 26, 4:33 AM · efl
Jaehyun_Cho added a comment to T7701: Rename Efl.Ui.Stack.

Thank you for your opinion :)
(I think that you vote for 1. Efl.Ui.Stack)

Tue, Feb 26, 3:13 AM · efl: api
Jaehyun_Cho added a comment to D8015: efl_ui_widget: move orientation to the specific users of this widget.

I replied your comments.

Tue, Feb 26, 2:51 AM · efl
Jaehyun_Cho added a comment to D8015: efl_ui_widget: move orientation to the specific users of this widget.

I think that the backward compatibility is not kept here.

Tue, Feb 26, 12:23 AM · efl
Jaehyun_Cho added a comment to D8015: efl_ui_widget: move orientation to the specific users of this widget.

Should we use the term 'orientation' in this case? (As you know, the term 'rotation' is specifically used for animation in many other platforms)

Tue, Feb 26, 12:13 AM · efl
Jaehyun_Cho added a comment to D8015: efl_ui_widget: move orientation to the specific users of this widget.

I think that the property 'rotation' is not that useful for Efl.Ui.Win.

Tue, Feb 26, 12:00 AM · efl

Mon, Feb 25

Jaehyun_Cho added a comment to D7892: ui.table: implement homogeneous mode.

I think this is a typo.

Mon, Feb 25, 8:32 PM · efl

Feb 22 2019

Jaehyun_Cho closed D7838: efl_ui_table: fix correct parameters of table_rows_get.
Feb 22 2019, 3:06 AM · efl
Jaehyun_Cho accepted D7838: efl_ui_table: fix correct parameters of table_rows_get.
Feb 22 2019, 3:05 AM · efl
Jaehyun_Cho added a commit to T5487: edje & elm sizing: respect hints & simplify layout api: rEFL3118bfc34bb9: efl_ui_relative_layout: introduce new relative container.
Feb 22 2019, 2:55 AM · efl: widgets, Restricted Project
Jaehyun_Cho closed D7524: efl_ui_relative_layout: introduce new relative container.
Feb 22 2019, 2:55 AM · efl
Jaehyun_Cho accepted D7524: efl_ui_relative_layout: introduce new relative container.
Feb 22 2019, 2:47 AM · efl
Jaehyun_Cho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

rebase

Feb 22 2019, 2:46 AM · efl
Jaehyun_Cho created T7702: Remove internally generated classes from EFL# doc.
Feb 22 2019, 1:56 AM · documentation, efl: language bindings
Jaehyun_Cho added a comment to T7568: efl.access.object.

Thank you for sharing your idea :)
I do not insist to separate those static methods from Efl.Access.Object.
I want to know your opinion.

Feb 22 2019, 1:17 AM · efl: api, efl (efl-1.22)
Jaehyun_Cho added a project to T7701: Rename Efl.Ui.Stack: efl: api.
Feb 22 2019, 12:59 AM · efl: api
Jaehyun_Cho created T7701: Rename Efl.Ui.Stack.
Feb 22 2019, 12:58 AM · efl: api

Feb 21 2019

Jaehyun_Cho updated subscribers of T7568: efl.access.object.

I think there is no problem on your original plan in T7653 (refactoring Efl.Access.Object to be a regular class) based on C# perspective.

Feb 21 2019, 10:03 PM · efl: api, efl (efl-1.22)
Jaehyun_Cho added a comment to D7974: Rename Efl.Gfx.Map -> Efl.Gfx.Mapping.

do we need to modify src/bin/elementary/test_efl_gfx_map.c to src/bin/elementary/test_efl_gfx_mapping.c as well?

Feb 21 2019, 3:56 AM · efl
Jaehyun_Cho added a comment to T7653: Efl.Access mixin removal.

Thank you for suggesting your new idea :)
However, I am afraid that the downsides are bigger than now I think..

Feb 21 2019, 3:39 AM

Feb 20 2019

Jaehyun_Cho added a comment to T7653: Efl.Access mixin removal.

Thank you for the link https://www.c-sharpcorner.com/UploadFile/b942f9/how-to-create-mixin-using-C-Sharp-4-0/ !!
It is brilliant! :)

Feb 20 2019, 10:42 PM

Feb 14 2019

Jaehyun_Cho requested changes to D7899: api: remove efl.ui.cursor interface.

efl_ui_cursor.eo still exists.

Feb 14 2019, 5:18 PM · efl: api
Jaehyun_Cho added a comment to T7590: efl.screen.

As I checked ecore_wl2_display_screen_size_get and ecore_wl2_output_dpi_get, currently the property "screen_size" is used as a resolution. (not physical millimeters or inches).
"screen_size" is received from width(width of the mode in hardware units) and height(height of the mode in hardware units) of mode in https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Client/structwl__output__listener.html

Feb 14 2019, 4:34 PM · efl: api, efl (efl-1.22)
Jaehyun_Cho added inline comments to D7524: efl_ui_relative_layout: introduce new relative container.
Feb 14 2019, 12:23 AM · efl

Feb 13 2019

Jaehyun_Cho closed D7906: efl_pack: move layout,updated event to Efl.Pack_Layout.
Feb 13 2019, 7:57 PM · efl
Jaehyun_Cho accepted D7906: efl_pack: move layout,updated event to Efl.Pack_Layout.
Feb 13 2019, 7:57 PM · efl

Feb 12 2019

Jaehyun_Cho requested review of D7922: eet_dictionary: remove dead code.
Feb 12 2019, 11:59 PM · efl

Feb 1 2019

Jaehyun_Cho updated the diff for D7856: efl_ui_format: fix to display %% and unknown format element.

fix to display value correctly

Feb 1 2019, 12:13 AM · efl

Jan 31 2019

Jaehyun_Cho added a comment to D7601: evas: make efl_canvas_animation abstract.

I've submitted the revert patch. (f23f3074daa3e9da5b37cc168df5d6b003e0ec62)
Thank you all~

Jan 31 2019, 10:56 PM · efl
Jaehyun_Cho requested review of D7856: efl_ui_format: fix to display %% and unknown format element.
Jan 31 2019, 10:40 PM · efl
Jaehyun_Cho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Is there any reason why relative layout itself becomes a child?

Jan 31 2019, 4:55 AM · efl
Jaehyun_Cho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Should we implement Efl.Pack or not to call layout,updated event?

Jan 31 2019, 4:42 AM · efl
Jaehyun_Cho added a comment to T7653: Efl.Access mixin removal.

@stanluk
As you know, currently EFL C# converts mixin in .eo to interface in .eo.cs.
This works well but as I told you, app developers may be confused when they investigate or debug the C# interface which is originally mixin in .eo.

Jan 31 2019, 3:29 AM
Jaehyun_Cho added a comment to D7601: evas: make efl_canvas_animation abstract.

@bu5hm4n
Thank you for the opinion.
If @segfaultxavi and @cedric do not disagree, then I will push a revert of this patch.

Jan 31 2019, 2:47 AM · efl
Jaehyun_Cho closed D7835: efl_ui_tab_bar: fix tab sizing issue.
Jan 31 2019, 1:56 AM · efl
Jaehyun_Cho accepted D7835: efl_ui_tab_bar: fix tab sizing issue.

Thank you :)

Jan 31 2019, 1:56 AM · efl
Jaehyun_Cho added a comment to T5719: Force all apis to be implemented.

It seems that many legacy eo files are considered in P265.
(e.g. elm_xxx, evas_xxx, edje_xxx, ecore_xxx)

Jan 31 2019, 1:53 AM · Restricted Project, efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to D7835: efl_ui_tab_bar: fix tab sizing issue.

as I understand, this patch is required because tab is packed to elm_box.
if so, could you add FIXME comment on here?

Jan 31 2019, 12:38 AM · efl

Jan 30 2019

Jaehyun_Cho added a comment to D7601: evas: make efl_canvas_animation abstract.

@segfaultxavi @cedric
Sorry, my example was incorrect as @cedric said.

Jan 30 2019, 11:55 PM · efl
Jaehyun_Cho closed D7810: eo: check memory allocation of table data.
Jan 30 2019, 4:49 AM · efl
Jaehyun_Cho added a comment to D7810: eo: check memory allocation of table data.

@bu5hm4n
I almost made a big mistake! Thank you very much! :)

Jan 30 2019, 4:04 AM · efl
Jaehyun_Cho updated the diff for D7810: eo: check memory allocation of table data.

fix incorrect variable name

Jan 30 2019, 4:03 AM · efl

Jan 29 2019

Jaehyun_Cho updated the diff for D7810: eo: check memory allocation of table data.

The declaration of "new_data" is moved to the top of the scope.

Jan 29 2019, 7:58 PM · efl
Jaehyun_Cho added a comment to D7601: evas: make efl_canvas_animation abstract.

As you said, Efl.Canvas.Animation does not have its own animation properties (e.g. scale, alpha, etc.)
However, with Efl.Canvas.Animation_Player, Efl.Canvas.Animation can be used as a custom animation.
e.g.

Jan 29 2019, 4:14 AM · efl
Jaehyun_Cho added a comment to D7817: Handling failed memory allocation.

Could you add prefix "efl_ui_list_view:" to the commit title?

Jan 29 2019, 2:40 AM · efl
Jaehyun_Cho added a comment to D7809: efl_ui_text: add null check.

I am not sure about some codes if they are correct.
Please check the comments.

Jan 29 2019, 2:36 AM · efl
Jaehyun_Cho closed D7808: ecore: check fcntl return..
Jan 29 2019, 2:31 AM · efl
Jaehyun_Cho accepted D7808: ecore: check fcntl return..
Jan 29 2019, 2:30 AM · efl
Jaehyun_Cho updated subscribers of T5719: Force all apis to be implemented.

I think we can separate the cause of this task into 3 cases.

Jan 29 2019, 2:12 AM · Restricted Project, efl: language bindings, Restricted Project
Jaehyun_Cho added a comment to D7419: evas_box: fix calculation logic when item's weight is 0.0..

@eagleeye
could you add unit test for this as @zmike mentioned?

Jan 29 2019, 1:44 AM · efl
Jaehyun_Cho updated subscribers of T7652: Evalulate interface properties that are not implemented in most usages..
Jan 29 2019, 12:23 AM · Restricted Project, efl: language bindings, Restricted Project

Jan 28 2019

Jaehyun_Cho accepted D7801: elm: prevent from accessing null pointer after memory allocation.

To me, this patch is acceptable.
Can I submit this patch? :)

Jan 28 2019, 10:51 PM · efl
Jaehyun_Cho updated the diff for D7810: eo: check memory allocation of table data.

update code

Jan 28 2019, 9:51 PM · efl
Jaehyun_Cho requested review of D7810: eo: check memory allocation of table data.
Jan 28 2019, 9:47 PM · efl
Jaehyun_Cho requested changes to D7801: elm: prevent from accessing null pointer after memory allocation.

I think my second comment is required to prevent memory leak.
I am not sure about my first and my third comments.

Jan 28 2019, 9:25 PM · efl
Jaehyun_Cho closed D7796: edje_cc: check return value of fseeks.
Jan 28 2019, 12:31 AM · efl
Jaehyun_Cho closed D7795: epp: fix correct parameters for cpp_error_with_line.
Jan 28 2019, 12:31 AM · efl
Jaehyun_Cho accepted D7796: edje_cc: check return value of fseeks.
Jan 28 2019, 12:25 AM · efl
Jaehyun_Cho accepted D7795: epp: fix correct parameters for cpp_error_with_line.
Jan 28 2019, 12:15 AM · efl
Jaehyun_Cho closed D7797: efl_ui_dnd: fix the wrong parameter passing.
Jan 28 2019, 12:10 AM · efl

Jan 27 2019

Jaehyun_Cho accepted D7797: efl_ui_dnd: fix the wrong parameter passing.
Jan 27 2019, 11:58 PM · efl

Jan 25 2019

Jaehyun_Cho added a comment to T5719: Force all apis to be implemented.

Thanks 211064113104702b2c6bd279e9e8a04ee0e8254a :)
But when I try to print all the unimplemented warnings by using the above commit, build error causes not to print all the unimplemented warnings.

Jan 25 2019, 4:07 AM · Restricted Project, efl: language bindings, Restricted Project

Jan 24 2019

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

comments for rebase

Jan 24 2019, 3:06 AM · efl