- User Since
- Jul 24 2013, 3:26 AM (295 w, 4 d)
change Efl.Ui.Text_Cursor_Selectable to Efl.Ui.Text_Selectable
Thank you for the feedback :)
I wanted to apply this change before release but as you say let's wait until release because these interfaces are @beta ;)
Fri, Mar 22
What do you think about removing the namespace "Csharp"? (if so the file name is also changed to efl_application.cs)
Thu, Mar 21
Please give some comments on this patch.
Wed, Mar 20
ok~ then please suggest a new name :)
rebase has been applied
The original name Efl.Ui.Stack is preserved.
Could you tell me why memory initialization is required only for debugging mode?
Mon, Mar 18
Wed, Mar 13
I am afraid this patch breaks the backward compatibility.
Please check the Popup -> popup-center-text in elementary_test. (text is not displayed.)
Sun, Mar 10
This is a minor suggestion of moving code inside the conditional expression.
Fri, Mar 8
Regardless of this patch, what do you think about changing method name "create" in Efl.Canvas.Gesture.Recognizer to "gesture_create"?
I have checked the code and tested the functionality.
And I found out that win cannot add gesture event.
Is it originally intended?
Thu, Mar 7
Are the other glayer values not required for now?
Thu, Feb 28
Could you please mark @beta for scroll methods?
As @bu5hm4n said, it may be not the right place for these methods..
I think that @eagleeye will check if it is possible to move these methods out of Efl.Ui.Widget. (T7714)
IMHO, I think the following properties/methods/events are essential for Efl.Ui.Win.
I don't mind if you remove the properties/methods/events which you mentioned that those are not used or are related to only X11.
It is fine if those are preserved in legacy at least :)
It seems that all the properties and methods are required to be marked @beta for now :)
(P) theme may be required to change its values (style) based on @bu5hm4n and your opinion.
(P) automatic_theme_rotation and (M) theme_rotation_apply are submitted recently. So it seems that it requires some time to check them.
Wed, Feb 27
Tue, Feb 26
2: This property is removed, so there is no point in renaming it to this ?
Sorry about this. I missed that the property is removed in this patch.
Thank you for your opinion :)
(I think that you vote for 1. Efl.Ui.Stack)
I replied your comments.
I think that the backward compatibility is not kept here.
Should we use the term 'orientation' in this case? (As you know, the term 'rotation' is specifically used for animation in many other platforms)
I think that the property 'rotation' is not that useful for Efl.Ui.Win.
Mon, Feb 25
I think this is a typo.
Feb 22 2019
Thank you for sharing your idea :)
I do not insist to separate those static methods from Efl.Access.Object.
I want to know your opinion.
Feb 21 2019
I think there is no problem on your original plan in T7653 (refactoring Efl.Access.Object to be a regular class) based on C# perspective.
do we need to modify src/bin/elementary/test_efl_gfx_map.c to src/bin/elementary/test_efl_gfx_mapping.c as well?
Thank you for suggesting your new idea :)
However, I am afraid that the downsides are bigger than now I think..
Feb 20 2019
Thank you for the link https://www.c-sharpcorner.com/UploadFile/b942f9/how-to-create-mixin-using-C-Sharp-4-0/ !!
It is brilliant! :)
Feb 14 2019
efl_ui_cursor.eo still exists.
As I checked ecore_wl2_display_screen_size_get and ecore_wl2_output_dpi_get, currently the property "screen_size" is used as a resolution. (not physical millimeters or inches).
"screen_size" is received from width(width of the mode in hardware units) and height(height of the mode in hardware units) of mode in https://people.freedesktop.org/~whot/wayland-doxygen/wayland/Client/structwl__output__listener.html
Feb 13 2019
Feb 12 2019
Feb 1 2019
fix to display value correctly
Jan 31 2019
I've submitted the revert patch. (f23f3074daa3e9da5b37cc168df5d6b003e0ec62)
Thank you all~
Is there any reason why relative layout itself becomes a child?
Should we implement Efl.Pack or not to call layout,updated event?
As you know, currently EFL C# converts mixin in .eo to interface in .eo.cs.
This works well but as I told you, app developers may be confused when they investigate or debug the C# interface which is originally mixin in .eo.
Thank you :)
It seems that many legacy eo files are considered in P265.
(e.g. elm_xxx, evas_xxx, edje_xxx, ecore_xxx)
as I understand, this patch is required because tab is packed to elm_box.
if so, could you add FIXME comment on here?
Jan 30 2019
I almost made a big mistake! Thank you very much! :)
fix incorrect variable name
Jan 29 2019
The declaration of "new_data" is moved to the top of the scope.
As you said, Efl.Canvas.Animation does not have its own animation properties (e.g. scale, alpha, etc.)
However, with Efl.Canvas.Animation_Player, Efl.Canvas.Animation can be used as a custom animation.
Could you add prefix "efl_ui_list_view:" to the commit title?
I am not sure about some codes if they are correct.
Please check the comments.
I think we can separate the cause of this task into 3 cases.
Jan 28 2019
To me, this patch is acceptable.
Can I submit this patch? :)
I think my second comment is required to prevent memory leak.
I am not sure about my first and my third comments.
Jan 27 2019
Jan 25 2019
Thanks 211064113104702b2c6bd279e9e8a04ee0e8254a :)
But when I try to print all the unimplemented warnings by using the above commit, build error causes not to print all the unimplemented warnings.
Jan 24 2019
comments for rebase