Page MenuHomePhabricator

Jaehyun_Cho (Jaehyun Cho)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 24 2013, 3:26 AM (374 w, 3 d)
Availability
Available

Recent Activity

Aug 3 2020

Jaehyun_Cho closed D12082: edje_embryo: fix memory leak in ALLOC_COPY_DESC.
Aug 3 2020, 11:12 PM · efl
Jaehyun_Cho requested review of D12082: edje_embryo: fix memory leak in ALLOC_COPY_DESC.
Aug 3 2020, 4:56 AM · efl

Jun 17 2020

Jaehyun_Cho closed D11988: elm_image: remove the spaces and keep the indentation for elm_image_file_set().
Jun 17 2020, 5:17 AM · efl
Jaehyun_Cho accepted D11988: elm_image: remove the spaces and keep the indentation for elm_image_file_set().
Jun 17 2020, 5:17 AM · efl

Jun 16 2020

Jaehyun_Cho closed D11982: evas_object_table: fix not to use hint_fill on elm_table.
Jun 16 2020, 4:41 AM · efl
Jaehyun_Cho requested review of D11982: evas_object_table: fix not to use hint_fill on elm_table.
Jun 16 2020, 4:37 AM · efl

Jun 4 2020

Jaehyun_Cho requested review of D11934: edje_cc_handlers: update documentation of "fixed" to be clearer.
Jun 4 2020, 4:12 AM · efl

May 26 2020

Jaehyun_Cho closed D11887: edje: fix memory leak by freeing the limits pointer..
May 26 2020, 10:56 PM · efl
Jaehyun_Cho accepted D11887: edje: fix memory leak by freeing the limits pointer..

Nice catch! Thank you! :)

May 26 2020, 10:55 PM · efl

May 20 2020

Jaehyun_Cho closed D11858: efl_ui_layout: remove group_calcualte to respect legacy min size.
May 20 2020, 12:40 AM · efl
Jaehyun_Cho added a comment to D11858: efl_ui_layout: remove group_calcualte to respect legacy min size.

Thank you for this patch! :)

May 20 2020, 12:36 AM · efl
Jaehyun_Cho accepted D11858: efl_ui_layout: remove group_calcualte to respect legacy min size.
May 20 2020, 12:34 AM · efl

Apr 13 2020

Jaehyun_Cho closed D11687: eo: null check for vtable allocation.
Apr 13 2020, 3:51 AM · efl
Jaehyun_Cho accepted D11687: eo: null check for vtable allocation.
Apr 13 2020, 3:50 AM · efl

Apr 12 2020

Jaehyun_Cho closed D11690: elm_cnp: fix memory leaks.
Apr 12 2020, 11:17 PM · efl
Jaehyun_Cho accepted D11690: elm_cnp: fix memory leaks.
Apr 12 2020, 10:45 PM · efl
Jaehyun_Cho updated the summary of D11690: elm_cnp: fix memory leaks.
Apr 12 2020, 10:40 PM · efl

Apr 1 2020

Jaehyun_Cho added a comment to D11635: elm_naviframe: Do not pop top item if top item..

I think that if EDI's wizard registers pop_cb and does nothing in pop_cb and returns EINA_FALSE in the pop_cb, then the last item is not popped.

Apr 1 2020, 3:47 AM · efl
Jaehyun_Cho requested changes to D11635: elm_naviframe: Do not pop top item if top item..

I think this patch breaks the backward compatibility.
Because users can register their own pop_cb by using elm_naviframe_item_pop_cb_set().
So if the popped item is the last item, then users' pop_cb is called and elm_win or something is deleted manually in the pop_cb.
However, this patch do not allow pop_cb is called if the popped item is the last item.
So I think this patch should not be accepted.

Apr 1 2020, 3:42 AM · efl

Mar 16 2020

Jaehyun_Cho accepted D11358: efl_ui_spotlight: Introduce animation manager.
Mar 16 2020, 3:39 AM · efl
Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

Mhm, I would really like to keep the semantik that the out animation is played backwards, as that saves for the cases we have right now *a lot* of memory and duplication. What we could do, to support easier creation of the out animation, we could introduce a backward interpolator which maps [0..1] -> [1..0], would that be fine for you ?

Mar 16 2020, 3:19 AM · efl

Mar 15 2020

Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

If the backwards animation logic is not important in this patch, then it would be fine to submit this patch now and later I will make a patch to remove backwards animation logic.

Mar 15 2020, 10:20 PM · efl
Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

Thank you for adding parameters to push_setup and pop_setup.

Mar 15 2020, 10:18 PM · efl

Mar 11 2020

Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

Okay yeah, that is i think what i said in my first comment.

The idea here is that you can associate a animation with a operation, and when you push something in, the object that is currently active, is simply faded out. Is there really the demand that someone wants to have a different "move out" animation depending on if its a jump or a push?

Mar 11 2020, 4:08 AM · efl

Mar 10 2020

Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

I made a patch onto this patch on my dev branch (devs/jaehyun/animation_manager) as a test version.
https://git.enlightenment.org/core/efl.git/commit/?h=devs/jaehyun/animation_manager&id=72da9ec8c6ef9e6081979c1caae3e4749d0a9965

Mar 10 2020, 9:34 PM · efl
Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

I am not sure I understood your comment correctly.
So I want to explain my previous comment with more precisely.

Mar 10 2020, 2:51 AM · efl
Jaehyun_Cho added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

Sorry I missed this one.

Mar 10 2020, 1:27 AM · efl

Feb 24 2020

Jaehyun_Cho requested review of D11400: database_expr: fix memory leak when type error happens.
Feb 24 2020, 1:44 AM · efl
Jaehyun_Cho closed D11394: Revert "elm_spinner: Fixed to apply the %d format.".
Feb 24 2020, 1:16 AM · efl

Feb 21 2020

Jaehyun_Cho added a comment to D11378: elm_spinner: Fixed to apply the %d format..

Sorry, I made D11394 to revert this.
I will discuss this patch with @CHAN again.

Feb 21 2020, 1:09 AM · efl
Jaehyun_Cho added a comment to D11394: Revert "elm_spinner: Fixed to apply the %d format.".

@CHAN we need to think about the comments on D11378 from @bu5hm4n and @segfaultxavi

Feb 21 2020, 1:08 AM · efl
Jaehyun_Cho requested review of D11394: Revert "elm_spinner: Fixed to apply the %d format.".
Feb 21 2020, 1:07 AM · efl

Feb 19 2020

Jaehyun_Cho closed D11378: elm_spinner: Fixed to apply the %d format..
Feb 19 2020, 4:10 AM · efl
Jaehyun_Cho accepted D11378: elm_spinner: Fixed to apply the %d format..
Feb 19 2020, 4:08 AM · efl

Feb 4 2020

Jaehyun_Cho closed D11269: csharp: implement GetChildrenIndex for GenericModel.
Feb 4 2020, 12:17 AM · efl

Feb 3 2020

Jaehyun_Cho accepted D11269: csharp: implement GetChildrenIndex for GenericModel.

You are right :) Thank you!

Feb 3 2020, 9:44 PM · efl
Jaehyun_Cho added inline comments to D11269: csharp: implement GetChildrenIndex for GenericModel.
Feb 3 2020, 2:56 AM · efl

Jan 23 2020

Jaehyun_Cho abandoned D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Jan 23 2020, 4:37 AM · efl

Jan 22 2020

Jaehyun_Cho updated the summary of D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Jan 22 2020, 10:14 PM · efl
Jaehyun_Cho updated the diff for D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.

fix build error

Jan 22 2020, 10:14 PM · efl
Jaehyun_Cho requested review of D11156: eolian_mono: rename ItemFactory<T> to LayoutFactory<T>.
Jan 22 2020, 9:20 PM · efl
Jaehyun_Cho closed D11143: efl_ui_spotlight: rename Stack_Manager to Fade_Manager.
Jan 22 2020, 8:01 PM · efl
Jaehyun_Cho closed D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.
Jan 22 2020, 8:01 PM · efl
Jaehyun_Cho accepted D11152: eolian_mono: generate Efl.IPlayer.PlaybackPosition again.
Jan 22 2020, 1:05 AM · efl

Jan 21 2020

Jaehyun_Cho added a comment to D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.

Is it OK if this patch is submitted?

Jan 21 2020, 9:48 PM · efl
Jaehyun_Cho requested review of D11143: efl_ui_spotlight: rename Stack_Manager to Fade_Manager.
Jan 21 2020, 4:14 AM · efl
Jaehyun_Cho requested review of D11142: efl_ui_spotlight: rename Manager_XXX and Indicator_XXX.
Jan 21 2020, 3:43 AM · efl
Jaehyun_Cho accepted D11135: efl_ui_spotlight/pager/stack: remove @beta.

thank you! :)

Jan 21 2020, 3:01 AM · efl
Jaehyun_Cho closed D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.
Jan 21 2020, 2:33 AM · efl

Jan 20 2020

Jaehyun_Cho updated the diff for D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

Apply clipper not to cause tests fail with setting data "_elm_leaveme".

Jan 20 2020, 11:42 PM · efl
Jaehyun_Cho added a comment to D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

Oh! I missed plain;; thank you!

Jan 20 2020, 4:41 AM · efl
Jaehyun_Cho updated the diff for D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

add code for spotlight manager plain, too

Jan 20 2020, 4:40 AM · efl
Jaehyun_Cho added a comment to D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.

As this patch describes, now group_member_add() of efl_ui_widget set color_set() manually. This causes packed rectangle's color change.

Jan 20 2020, 4:38 AM · efl
Jaehyun_Cho requested review of D11134: efl_ui_spotlight_manager: fix not to change sub objects' color.
Jan 20 2020, 1:54 AM · efl

Jan 19 2020

Jaehyun_Cho closed D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.
Jan 19 2020, 8:04 PM · efl
Jaehyun_Cho accepted D11028: tests/elm: add basic timestamping for event helpers.

thank you for the update!

Jan 19 2020, 7:51 PM · efl

Jan 17 2020

Jaehyun_Cho added a comment to D11028: tests/elm: add basic timestamping for event helpers.

How about using global variable static unsigned int ts ?

static unsigned int ts = 0; //global variable in suite_helpers.c

Because the timestamp of each function begins with 0 so timestamp 0 is used in the functions at the same time.
e.g.

//In test code
drag_object(...); //timestamp 0 is used with evas_event_feed_mouse_move
wheel_object_at(...); //timestamp 0 is used with evas_event_feed_mouse_move
Jan 17 2020, 12:31 AM · efl

Jan 16 2020

Jaehyun_Cho accepted D11027: efl/gesture: do not emit events for canceled gestures with no state.
Jan 16 2020, 10:19 PM · efl
Jaehyun_Cho added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

There are many patches related to gesture. (D11052, D11053, ...)
Therefore, to avoid conflict to the above patches, this patch should not be merged until either those patches are merged or abandoned.

Jan 16 2020, 9:44 PM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture: DO NOT MERGE.
Jan 16 2020, 9:40 PM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

This patch is basically the same with D11108.

Jan 16 2020, 3:54 AM · DO NOT MERGE, efl
Jaehyun_Cho requested review of D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.
Jan 16 2020, 3:51 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.

This patch suggests using "Animation" as a postfix of animation class names.
e.g. Efl.Canvas.Animation_Alpha -> Efl.Canvas.Alpha_Animation

Jan 16 2020, 12:02 AM · efl

Jan 15 2020

Jaehyun_Cho requested review of D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.
Jan 15 2020, 11:59 PM · efl
Jaehyun_Cho closed D11104: efl_canvas_animation_group: preserve each animation's duration.
Jan 15 2020, 2:13 AM · efl
Jaehyun_Cho closed D11101: efl_mono: remove class ExtensionTag.
Jan 15 2020, 1:49 AM · efl
Jaehyun_Cho updated the diff for D11104: efl_canvas_animation_group: preserve each animation's duration.

update description about the value is_duration_set

Jan 15 2020, 1:44 AM · efl
Jaehyun_Cho requested review of D11104: efl_canvas_animation_group: preserve each animation's duration.
Jan 15 2020, 1:43 AM · efl

Jan 14 2020

Jaehyun_Cho requested review of D11101: efl_mono: remove class ExtensionTag.
Jan 14 2020, 10:15 PM · efl
Jaehyun_Cho added a reviewer for D11094: evas_gesture: change getter methods to read-only properties: CHAN.
Jan 14 2020, 6:25 PM · efl
Jaehyun_Cho requested review of D11094: evas_gesture: change getter methods to read-only properties.
Jan 14 2020, 4:08 AM · efl
Jaehyun_Cho added a revision to T8557: Pending work on gesture event structs: D11094: evas_gesture: change getter methods to read-only properties.
Jan 14 2020, 4:08 AM · efl: api, efl: docs, efl (efl-1.24)
Jaehyun_Cho added a comment to T8450: efl.divisor_interpolator.

I agree with your opinion! Power_Interpolator :)

Jan 14 2020, 4:07 AM · efl: api, efl (efl-1.24)
Jaehyun_Cho created T8572: efl.canvas.rectangle.
Jan 14 2020, 3:32 AM · efl: api
Jaehyun_Cho requested changes to D11071: eolian_mono: remove unnecessary variable declaration.

It seems that GetEoOps() can be called multiple times if inherited classes' instances are created.

Jan 14 2020, 3:20 AM · efl
Jaehyun_Cho requested changes to D11091: c#: Remove extension methods for classes that can't use it.

It seems that it is required to consider that only specific part classes generate extension classes (not all part classes) as @woohyun mentioned. (e.g. Efl.Ui.Layout_Part_Text, ...)

Jan 14 2020, 2:19 AM · efl
Jaehyun_Cho closed D10902: eina_mono: replace eina_list and eina_array with IList.
Jan 14 2020, 12:19 AM · efl
Jaehyun_Cho added a commit to T8486: C#: Use System.Collection instead of Eina classes in C# API: rEFLae30d3c57bc2: eina_mono: replace eina_list and eina_array with IList.
Jan 14 2020, 12:19 AM · efl: language bindings
Jaehyun_Cho accepted D10902: eina_mono: replace eina_list and eina_array with IList.
Jan 14 2020, 12:16 AM · efl

Jan 13 2020

Jaehyun_Cho accepted D11091: c#: Remove extension methods for classes that can't use it.
Jan 13 2020, 10:17 PM · efl
Jaehyun_Cho added a comment to T8557: Pending work on gesture event structs.

Thank you for your reply! Now I understand your point and I agree with you.

  • NOW : radius_get { } for Efl.Canvas.Gesture_Zoom
  • TODO : @property radius { get { } } for Efl.Canvas.Gesture_Zoom
Jan 13 2020, 6:27 PM · efl: api, efl: docs, efl (efl-1.24)
Jaehyun_Cho requested review of D11073: efl_gesture: rename Efl.Gesture.Events to Efl.Canvas.Gesture_Events.
Jan 13 2020, 2:18 AM · efl

Jan 12 2020

Jaehyun_Cho added a comment to D10935: efl_model: stablized child,added child,removed events..

Based on the above discussion, how about the followings in efl_model.eo?

child,added : Efl.Model_Child_Event;
child,removed : Efl.Model_Child_Event;
children,added : Efl.Model_Children_Event;
children,removed : Efl.Model_Children_Event;
Jan 12 2020, 10:52 PM · efl
Jaehyun_Cho added a comment to T8450: efl.divisor_interpolator.

This class was added based on ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, ECORE_POS_MAP_DIVISOR_INTERP and ECORE_POS_MAP_DIVISOR_INTERP.

Jan 12 2020, 10:38 PM · efl: api, efl (efl-1.24)
Jaehyun_Cho added a comment to T8557: Pending work on gesture event structs.

Their fields should be read-only properties instead of methods. This is more natural for bindings.

Do you mean that EITHER Efl.Canvas.Gesture provides read-only properties OR Efl.Canvas.Gesture's setter methods / writable properties should not be public?

Jan 12 2020, 10:24 PM · efl: api, efl: docs, efl (efl-1.24)

Jan 6 2020

Jaehyun_Cho closed D10913: csharp: rename ExtensionMethods.
Jan 6 2020, 3:01 AM · efl
Jaehyun_Cho closed D10972: eolian_mono: add namespace to extension methods of ItemFactory.
Jan 6 2020, 3:01 AM · efl
Jaehyun_Cho accepted D10913: csharp: rename ExtensionMethods.
Jan 6 2020, 2:08 AM · efl

Dec 26 2019

Jaehyun_Cho requested review of D10972: eolian_mono: add namespace to extension methods of ItemFactory.
Dec 26 2019, 11:39 PM · efl

Dec 22 2019

Jaehyun_Cho closed D10952: eolian_mono : add verb unselect on naming helper..
Dec 22 2019, 11:21 PM · efl
Jaehyun_Cho accepted D10952: eolian_mono : add verb unselect on naming helper..
Dec 22 2019, 11:20 PM · efl

Dec 20 2019

Jaehyun_Cho requested review of D10940: efl_ui_widget: add description of widget parts.
Dec 20 2019, 4:26 AM · efl
Jaehyun_Cho abandoned D10932: efl_interface : add since version to stabilized Efl_Model_Children_Event.
Dec 20 2019, 12:38 AM · efl

Dec 19 2019

Jaehyun_Cho requested review of D10933: csharp: add documentation of class Efl.Eo.Config in iwrapper.
Dec 19 2019, 10:52 PM · efl
Jaehyun_Cho requested review of D10932: efl_interface : add since version to stabilized Efl_Model_Children_Event.
Dec 19 2019, 9:51 PM · efl
Jaehyun_Cho added a comment to D10929: eolian_mono: change Constants class to static class.

Also, This patch will fix CA1052(T8398).

Dec 19 2019, 9:33 PM · efl
Jaehyun_Cho added a commit to T8398: C#: CA1052: Static holder types should be Static or NotInheritable: rEFL8146728c7809: eolian_mono: change Constants class to static class.
Dec 19 2019, 9:31 PM · efl: language bindings
Jaehyun_Cho closed D10929: eolian_mono: change Constants class to static class.
Dec 19 2019, 9:31 PM · efl
Jaehyun_Cho requested review of D10929: eolian_mono: change Constants class to static class.
Dec 19 2019, 6:37 PM · efl

Dec 18 2019

Jaehyun_Cho closed D10914: csharp: remove unused code in workaround.
Dec 18 2019, 11:33 PM · efl