Page MenuHomePhabricator

ManMower (Derek Foreman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 8:45 AM (252 w, 4 d)
Availability
Available

Recent Activity

Feb 14 2019

ManMower placed T4287: Elementary label text sliding is jerky up for grabs.
Feb 14 2019, 12:18 PM · efl: rendering
ManMower placed T5258: Could not npen X11 socket connection. up for grabs.
Feb 14 2019, 12:18 PM · efl: display system, Restricted Project
ManMower placed T6592: implement wayland surface proxying up for grabs.
Feb 14 2019, 12:18 PM · efl: display system
ManMower placed T5477: No visible pointer on apps launched from TTY up for grabs.
Feb 14 2019, 12:18 PM · efl: display system
ManMower placed T5850: efl + weston and efl + framerate is really bad up for grabs.
Feb 14 2019, 12:17 PM · efl: display system
ManMower placed T7043: GLViewManyGears failure up for grabs.
Feb 14 2019, 12:17 PM · efl: display system
ManMower placed T7053: Enlightenment internal windows break up for grabs.
Feb 14 2019, 12:17 PM · efl: canvas
ManMower placed T7138: Wayland windows maximized before their first draw sometimes cause client disconnect up for grabs.
Feb 14 2019, 12:16 PM · efl: display system, Restricted Project
ManMower placed T6203: GLView GL ES 3.X test fails on Fedora 26 up for grabs.
Feb 14 2019, 12:14 PM · efl: rendering
ManMower placed T7277: Some egl clients fail in eglInitialize under enlightenment as a wayland compositor up for grabs.
Feb 14 2019, 12:14 PM · enlightenment-git, Restricted Project
ManMower placed T7410: enlightenment-git and efl-git eat huge memory up for grabs.
Feb 14 2019, 12:14 PM · Restricted Project, enlightenment-git
ManMower placed T6580: EFL perceived responsiveness is not as good as it used to be up for grabs.
Feb 14 2019, 12:13 PM · Restricted Project, Restricted Project, efl: data types
ManMower placed T7089: evas_vg_batman example doesn't run under weston up for grabs.
Feb 14 2019, 12:13 PM · efl (efl-1.23), Restricted Project, efl: rendering
ManMower placed T7350: Shadows on elm apps broken in 1.21.0/0.22.4 up for grabs.
Feb 14 2019, 12:13 PM · Restricted Project, efl: rendering, efl (efl-1.22)
ManMower placed T7097: something broken with gl when lots of windows open with x11 engine up for grabs.
Feb 14 2019, 12:13 PM · efl: display system, efl: rendering
ManMower placed T7171: Rename ecore_wl2 up for grabs.
Feb 14 2019, 12:13 PM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: display system, enlightenment-git, major change
ManMower placed T5147: E_WL and Virtualbox up for grabs.
Feb 14 2019, 12:12 PM · Restricted Project, enlightenment-git

Feb 13 2019

ManMower closed T7210: ecore_wl2 io processing isn't thread friendly as Resolved.

87cf5188b466d3fa1e8c8ff7ad6d5039b28e298a should sort this.

Feb 13 2019, 1:36 PM · efl: display system, efl (efl-1.22), Restricted Project
ManMower updated the diff for D7914: ecore_main: Add ECORE_FD_ALWAYS flag.

return true if we added a callback from an always handler

Feb 13 2019, 8:17 AM · efl
ManMower updated the diff for D7914: ecore_main: Add ECORE_FD_ALWAYS flag.

Make sure clean up is called after all the adds

Feb 13 2019, 7:45 AM · efl

Feb 12 2019

ManMower updated the diff for D7914: ecore_main: Add ECORE_FD_ALWAYS flag.

stronger comments

Feb 12 2019, 10:12 AM · efl
ManMower updated the diff for D7914: ecore_main: Add ECORE_FD_ALWAYS flag.

slightly better "documentation"

Feb 12 2019, 9:54 AM · efl
ManMower requested review of D7915: ecore_wl2: Make our wayland socket handling thread safe.
Feb 12 2019, 8:41 AM · efl
ManMower added a child revision for D7914: ecore_main: Add ECORE_FD_ALWAYS flag: D7915: ecore_wl2: Make our wayland socket handling thread safe.
Feb 12 2019, 8:41 AM · efl
ManMower requested review of D7914: ecore_main: Add ECORE_FD_ALWAYS flag.
Feb 12 2019, 8:41 AM · efl

Feb 11 2019

ManMower added a comment to T7590: efl.screen.

What is "size"? is that the physical size of the screen or the resolution of it?

Feb 11 2019, 10:46 AM · efl: api, efl (efl-1.22)

Feb 5 2019

ManMower added a reviewer for D7853: evas_object_smart: Speed up some cache invalidation calls: cedric.
Feb 5 2019, 11:32 AM · efl
ManMower added a comment to D7881: wayland: Rename ecore_wl2 to notstable.

Well, anything with ecore_wl2 in it should be considered right out, because the whole point of this is to surrender that namespace, and sort of continuing to use it with a prefix will be confusing...

Feb 5 2019, 9:27 AM · DO NOT MERGE, efl
ManMower added a reviewer for D7881: wayland: Rename ecore_wl2 to notstable: kimcinoo.
Feb 5 2019, 9:04 AM · DO NOT MERGE, efl
ManMower updated the diff for D7881: wayland: Rename ecore_wl2 to notstable.

fix typo in commit log

Feb 5 2019, 8:22 AM · DO NOT MERGE, efl
ManMower requested review of D7881: wayland: Rename ecore_wl2 to notstable.
Feb 5 2019, 8:20 AM · DO NOT MERGE, efl
ManMower added a revision to T7171: Rename ecore_wl2: D7881: wayland: Rename ecore_wl2 to notstable.
Feb 5 2019, 8:20 AM · efl (efl-1.24), Active Work Proposal, Restricted Project, efl: display system, enlightenment-git, major change

Feb 4 2019

ManMower closed D7874: tests: improve efl loop test (concentric).
Feb 4 2019, 12:12 PM · Restricted Project
ManMower accepted D7874: tests: improve efl loop test (concentric).
Feb 4 2019, 12:02 PM · Restricted Project

Feb 1 2019

ManMower closed D7868: tests: add explicit test for concentric loop usage.
Feb 1 2019, 1:13 PM · Restricted Project
ManMower accepted D7868: tests: add explicit test for concentric loop usage.
Feb 1 2019, 1:10 PM · Restricted Project
ManMower closed D6791: tests/elm: speed up all main loop timer execution.
Feb 1 2019, 12:11 PM · Restricted Project
ManMower accepted D6791: tests/elm: speed up all main loop timer execution.
Feb 1 2019, 12:08 PM · Restricted Project
ManMower added a comment to D7834: replace hton and ntoh family functions with ones defined in eina.

@vtorri, not for you, @raster commented that he changed the patch when landing.

Feb 1 2019, 11:13 AM · efl
ManMower added a comment to D7834: replace hton and ntoh family functions with ones defined in eina.

Just out of curiosity, did you try compiling after you made changes and before landing?

Feb 1 2019, 10:58 AM · efl

Jan 31 2019

ManMower requested review of D7854: evas_private: Fix typo.
Jan 31 2019, 11:44 AM · efl
ManMower requested review of D7853: evas_object_smart: Speed up some cache invalidation calls.
Jan 31 2019, 11:44 AM · efl
ManMower added a child revision for D7853: evas_object_smart: Speed up some cache invalidation calls: D7854: evas_private: Fix typo.
Jan 31 2019, 11:44 AM · efl
ManMower added a child revision for D7852: evas_object_smart: Consistently use MY_CLASS: D7853: evas_object_smart: Speed up some cache invalidation calls.
Jan 31 2019, 11:44 AM · efl
ManMower requested review of D7852: evas_object_smart: Consistently use MY_CLASS.
Jan 31 2019, 11:43 AM · efl

Jan 30 2019

ManMower added a comment to D7821: evas_image: fix pixels_dirty_set(False) makes wrong object-change-list..

I've tried to understand this but I get lost when trying to figure out what happens in evas_object_change() after this patch.

Jan 30 2019, 11:19 AM · efl

Jan 28 2019

ManMower accepted D7803: ecore-drm2: Support multiple gpus during vblank.
Jan 28 2019, 10:23 AM · efl
ManMower requested changes to D7803: ecore-drm2: Support multiple gpus during vblank.
Jan 28 2019, 9:05 AM · efl

Jan 25 2019

ManMower closed T7657: Remove Efl.Io.* interfaces from efl_task as Resolved.
Jan 25 2019, 12:44 PM · efl: api, efl (efl-1.22)
ManMower closed T7657: Remove Efl.Io.* interfaces from efl_task, a subtask of T7598: efl.task, as Resolved.
Jan 25 2019, 12:44 PM · efl: api, efl (efl-1.22)
ManMower added a commit to T7657: Remove Efl.Io.* interfaces from efl_task: rEFL0b0ff33f2f09: efl_task: remove efl.io.* interfaces.
Jan 25 2019, 11:47 AM · efl: api, efl (efl-1.22)
ManMower closed D7747: efl_task: remove efl.io.* interfaces.
Jan 25 2019, 11:47 AM · efl
ManMower accepted D7747: efl_task: remove efl.io.* interfaces.

Nice! Looks like a sizeable reduction in complexity at the cost of a feature that seems dubious at best - and as cedric says, can be provided manually when it's actually necessary. I feel sometimes like EFL carries too much technical debt for features that very few devs actually need, so it's nice to see this go before eo stabilizes. ?

Jan 25 2019, 11:46 AM · efl
ManMower closed D7764: gesture_manager: Filter events we add hooks for.
Jan 25 2019, 11:09 AM · efl
ManMower closed D7763: gesture_manager: Use private data getter to save some lookups.
Jan 25 2019, 11:08 AM · efl
ManMower closed D7762: gesture_manager: Add a call to get private data.
Jan 25 2019, 11:08 AM · efl
ManMower updated the diff for D7764: gesture_manager: Filter events we add hooks for.

Reorder the whitelist, add a couple of new events, and list where it's from

Jan 25 2019, 8:46 AM · efl

Jan 24 2019

ManMower closed D7761: evas: Defer object lookup until it's necessary.
Jan 24 2019, 12:31 PM · efl
ManMower requested review of D7764: gesture_manager: Filter events we add hooks for.
Jan 24 2019, 12:28 PM · efl
ManMower requested review of D7763: gesture_manager: Use private data getter to save some lookups.
Jan 24 2019, 12:28 PM · efl
ManMower added a child revision for D7763: gesture_manager: Use private data getter to save some lookups: D7764: gesture_manager: Filter events we add hooks for.
Jan 24 2019, 12:28 PM · efl
ManMower added a child revision for D7762: gesture_manager: Add a call to get private data: D7763: gesture_manager: Use private data getter to save some lookups.
Jan 24 2019, 12:28 PM · efl
ManMower requested review of D7762: gesture_manager: Add a call to get private data.
Jan 24 2019, 12:28 PM · efl
ManMower accepted D7744: eo: propagate knowledge of EFL_EVENT_NOREF callback registration to the event call generation..
Jan 24 2019, 12:18 PM · efl
ManMower requested review of D7761: evas: Defer object lookup until it's necessary.
Jan 24 2019, 12:06 PM · efl
ManMower requested changes to D7744: eo: propagate knowledge of EFL_EVENT_NOREF callback registration to the event call generation..
Jan 24 2019, 11:58 AM · efl
ManMower added a comment to D7744: eo: propagate knowledge of EFL_EVENT_NOREF callback registration to the event call generation..

Not hugely familiar with this code, have asked one question.

Jan 24 2019, 11:32 AM · efl
ManMower accepted D7743: eo: remove EFL_EVENT_SPECIAL_SKIP..

Cool - I recently stumbled across that define and wondered what it was all about.

Jan 24 2019, 11:16 AM · efl
ManMower accepted D7742: eo: remove function efl_noref that duplicate EFL_EVENT_NOREF..

I like this a lot. :)

Jan 24 2019, 11:15 AM · efl

Jan 22 2019

ManMower added inline comments to D6138: ecore-evas-drm: Add support for per-output ticking.
Jan 22 2019, 7:36 AM · efl

Jan 18 2019

ManMower closed D7697: edje: convert var timer list to inlist.
Jan 18 2019, 12:11 PM · efl
ManMower closed D7696: edje: Use EINA_LIST_FREE instead of hand coded variant.
Jan 18 2019, 12:11 PM · efl
ManMower closed D7698: efl_ui_widget: Save some pointer indirection.
Jan 18 2019, 11:59 AM · efl
ManMower updated the diff for D7697: edje: convert var timer list to inlist.

rebase after removing temp var

Jan 18 2019, 11:56 AM · efl
ManMower updated the diff for D7696: edje: Use EINA_LIST_FREE instead of hand coded variant.

Remove temp variable

Jan 18 2019, 11:56 AM · efl
ManMower requested review of D7698: efl_ui_widget: Save some pointer indirection.
Jan 18 2019, 11:45 AM · efl
ManMower requested review of D7697: edje: convert var timer list to inlist.
Jan 18 2019, 11:20 AM · efl
ManMower added a child revision for D7696: edje: Use EINA_LIST_FREE instead of hand coded variant: D7697: edje: convert var timer list to inlist.
Jan 18 2019, 11:20 AM · efl
ManMower requested review of D7696: edje: Use EINA_LIST_FREE instead of hand coded variant.
Jan 18 2019, 11:20 AM · efl
ManMower closed D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.
Jan 18 2019, 11:06 AM · efl
ManMower added a commit to T6209: elm_code severe lag when selecting text in some files: rEFL014705c74006: elm_code: Pass widget data to _elm_code_widget_fill_line.
Jan 18 2019, 11:06 AM · efl: widgets
ManMower added a comment to D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.

Just wanting to know if it's safe to assume pd is passed

Jan 18 2019, 10:29 AM · efl
ManMower added reviewers for D7694: elm_code: Pass widget data to _elm_code_widget_fill_line: cedric, zmike, devilhorns.

Dear reviewers, please pay close attention to the final hunk - I think this should be fine, but my EOAPI knowledge is thin on the ground.

Jan 18 2019, 8:50 AM · efl
ManMower added a comment to T6209: elm_code severe lag when selecting text in some files.

Should be orders of magnitude faster now, however, this mere 228k file is actually a pathologically nasty test case as it has 3 lines that are over 33000 chars long (check it with wc -L)

Jan 18 2019, 8:49 AM · efl: widgets
ManMower requested review of D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.
Jan 18 2019, 8:46 AM · efl
ManMower added a child revision for D7693: elm_code: Don't update selection if it didn't change: D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.
Jan 18 2019, 8:46 AM · efl
ManMower requested review of D7693: elm_code: Don't update selection if it didn't change.
Jan 18 2019, 8:46 AM · efl
ManMower added a revision to T6209: elm_code severe lag when selecting text in some files: D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.
Jan 18 2019, 8:46 AM · efl: widgets
ManMower added a child revision for D7692: elm_code: Pass data to status_type_get: D7693: elm_code: Don't update selection if it didn't change.
Jan 18 2019, 8:46 AM · efl
ManMower added a revision to T6209: elm_code severe lag when selecting text in some files: D7693: elm_code: Don't update selection if it didn't change.
Jan 18 2019, 8:46 AM · efl: widgets
ManMower requested review of D7692: elm_code: Pass data to status_type_get.
Jan 18 2019, 8:46 AM · efl
ManMower added a revision to T6209: elm_code severe lag when selecting text in some files: D7692: elm_code: Pass data to status_type_get.
Jan 18 2019, 8:46 AM · efl: widgets

Jan 17 2019

ManMower closed D7679: ecore-evas-drm: Refactor _ecore_evas_new_internal.
Jan 17 2019, 7:41 AM · efl
ManMower closed D7678: ecore-drm2: Pass output as data to drmModePageFlip and drmModeAtomicCommit.
Jan 17 2019, 7:41 AM · efl
ManMower accepted D7678: ecore-drm2: Pass output as data to drmModePageFlip and drmModeAtomicCommit.
Jan 17 2019, 7:28 AM · efl
ManMower accepted D7679: ecore-evas-drm: Refactor _ecore_evas_new_internal.
Jan 17 2019, 7:13 AM · efl

Jan 16 2019

ManMower added a comment to T7479: Firefox wayland misplaces menus, popups the adress bar drop down etc.

Thanks, that fflog2 is excellent.

Jan 16 2019, 11:54 AM · enlightenment-git, Restricted Project
ManMower lowered the priority of T7479: Firefox wayland misplaces menus, popups the adress bar drop down etc from Showstopper Issues to Pending on user input.

Can you do that with WAYLAND_DEBUG=1 so we can see what the client/compositor conversation looks like to get there?

Jan 16 2019, 11:10 AM · enlightenment-git, Restricted Project
ManMower reassigned T7392: Use after free in elementary_test animation tests from ManMower to devilhorns.
Jan 16 2019, 9:27 AM · efl (efl-1.22), efl: widgets
ManMower closed D7644: test_efl_anim_interpolator: delete animation event callback on window delete.
Jan 16 2019, 9:17 AM · efl