Page MenuHomePhabricator

ManMower (Derek Foreman)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 10 2015, 8:45 AM (200 w, 4 d)
Availability
Available

Recent Activity

Today

ManMower planned changes to D7437: ecore_wl2: Return proper geometry when maximized or fullscreened.

Something funny happening with this patch during enlightenment window resize animations, I need to investigate.

Sat, Dec 15, 7:38 AM · efl
ManMower planned changes to D7439: ee_wayland: Don't overide server set max/fs size.

This patch doesn't stand alone, and can't be landed without another patch in the series I'm reworking.

Sat, Dec 15, 7:37 AM · efl

Yesterday

ManMower closed D7438: efl_ui_win: Don't allow the frame object to change size before first draw.
Fri, Dec 14, 11:42 AM · efl
ManMower closed D7198: evas_render: Ignore objects on planes for rendering.
Fri, Dec 14, 11:30 AM · efl
ManMower closed D7436: ecore_wl2: Fix anchor for xdg pop-ups.
Fri, Dec 14, 8:31 AM · efl
ManMower closed D7435: ee_wayland: Use object geometry instead of window geometry.
Fri, Dec 14, 8:31 AM · efl
ManMower closed D7434: ecore_evas: Validate shadow geometry.
Fri, Dec 14, 8:31 AM · efl
ManMower closed D7433: gl_drm: use dlsym looked up symbol for extension check.
Fri, Dec 14, 8:30 AM · efl
ManMower closed D7432: ee_wayland: Replace set_config.geometry direct use with getters.
Fri, Dec 14, 8:30 AM · efl
ManMower closed D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters.
Fri, Dec 14, 8:30 AM · efl
ManMower closed D7430: ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set.
Fri, Dec 14, 8:30 AM · efl
ManMower closed D7196: evas_render: Ensure proper rendering when objects are on planes.
Fri, Dec 14, 7:53 AM · efl
ManMower closed D7195: evas_render: Render missing bits when plane state changes.
Fri, Dec 14, 7:53 AM · efl
ManMower closed D7194: evas_render: Move plane setup code.
Fri, Dec 14, 7:53 AM · efl
ManMower closed D7193: evas_render: Refactor plane code.
Fri, Dec 14, 7:52 AM · efl
ManMower closed D7192: evas_object: Add function to test if hardware plane status changed.
Fri, Dec 14, 7:52 AM · efl
ManMower closed D7190: evas_object: Add function to test if an object is on a hardware plane.
Fri, Dec 14, 7:52 AM · efl

Fri, Dec 7

ManMower requested review of D7439: ee_wayland: Don't overide server set max/fs size.
Fri, Dec 7, 11:49 AM · efl
ManMower added a child revision for D7438: efl_ui_win: Don't allow the frame object to change size before first draw: D7439: ee_wayland: Don't overide server set max/fs size.
Fri, Dec 7, 11:49 AM · efl
ManMower requested review of D7438: efl_ui_win: Don't allow the frame object to change size before first draw.
Fri, Dec 7, 11:48 AM · efl
ManMower added a child revision for D7437: ecore_wl2: Return proper geometry when maximized or fullscreened: D7438: efl_ui_win: Don't allow the frame object to change size before first draw.
Fri, Dec 7, 11:48 AM · efl
ManMower requested review of D7437: ecore_wl2: Return proper geometry when maximized or fullscreened.
Fri, Dec 7, 11:48 AM · efl
ManMower added a child revision for D7436: ecore_wl2: Fix anchor for xdg pop-ups: D7437: ecore_wl2: Return proper geometry when maximized or fullscreened.
Fri, Dec 7, 11:48 AM · efl
ManMower requested review of D7436: ecore_wl2: Fix anchor for xdg pop-ups.
Fri, Dec 7, 11:48 AM · efl
ManMower added a child revision for D7435: ee_wayland: Use object geometry instead of window geometry: D7436: ecore_wl2: Fix anchor for xdg pop-ups.
Fri, Dec 7, 11:48 AM · efl
ManMower requested review of D7435: ee_wayland: Use object geometry instead of window geometry.
Fri, Dec 7, 11:48 AM · efl
ManMower added a child revision for D7434: ecore_evas: Validate shadow geometry: D7435: ee_wayland: Use object geometry instead of window geometry.
Fri, Dec 7, 11:47 AM · efl
ManMower updated the diff for D7434: ecore_evas: Validate shadow geometry.

no change, something randomly broke during upload

Fri, Dec 7, 11:47 AM · efl
ManMower updated the diff for D7433: gl_drm: use dlsym looked up symbol for extension check.

no change, something randomly broke during upload

Fri, Dec 7, 11:47 AM · efl
ManMower updated the diff for D7432: ee_wayland: Replace set_config.geometry direct use with getters.

no change, something randomly broke during upload

Fri, Dec 7, 11:47 AM · efl
ManMower updated the diff for D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters.

no change, something randomly broke during upload

Fri, Dec 7, 11:47 AM · efl
ManMower updated the diff for D7430: ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set.

no change, something randomly broke during upload

Fri, Dec 7, 11:47 AM · efl
ManMower requested review of D7434: ecore_evas: Validate shadow geometry.
Fri, Dec 7, 11:46 AM · efl
ManMower added a child revision for D7433: gl_drm: use dlsym looked up symbol for extension check: D7434: ecore_evas: Validate shadow geometry.
Fri, Dec 7, 11:46 AM · efl
ManMower requested review of D7433: gl_drm: use dlsym looked up symbol for extension check.
Fri, Dec 7, 11:46 AM · efl
ManMower added a child revision for D7432: ee_wayland: Replace set_config.geometry direct use with getters: D7433: gl_drm: use dlsym looked up symbol for extension check.
Fri, Dec 7, 11:46 AM · efl
ManMower requested review of D7432: ee_wayland: Replace set_config.geometry direct use with getters.
Fri, Dec 7, 11:46 AM · efl
ManMower added a child revision for D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters: D7432: ee_wayland: Replace set_config.geometry direct use with getters.
Fri, Dec 7, 11:46 AM · efl
ManMower requested review of D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters.
Fri, Dec 7, 11:46 AM · efl
ManMower added a child revision for D7430: ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set: D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters.
Fri, Dec 7, 11:46 AM · efl
ManMower requested review of D7430: ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set.
Fri, Dec 7, 11:45 AM · efl
ManMower added inline comments to D7425: efl_ui_win: make win work for evas_norender.
Fri, Dec 7, 11:41 AM · efl

Thu, Nov 29

ManMower accepted D7305: elementary: Support using no frame object.

Seems to work, shaves about 50ms off elementary_test startup for me here, so if you don't need the frame this can be a big win.

Thu, Nov 29, 10:57 AM · efl

Wed, Nov 28

ManMower accepted D7328: evas gl: Remove single-line pipe code of gl commands..

Looks like a good clean up to me.

Wed, Nov 28, 8:12 AM · efl

Mon, Nov 26

ManMower closed T7049: focus manager is list lookup heavy, a subtask of T7132: Check EFL internal list usage for inefficiencies, as Resolved.
Mon, Nov 26, 12:42 PM · efl: widgets, Restricted Project, Restricted Project
ManMower closed T7049: focus manager is list lookup heavy as Resolved.

Yep, looks waaaay better. elementary's list activity is a drop in the bucket now, as far as I can tell.

Mon, Nov 26, 12:42 PM · Restricted Project, Restricted Project

Thu, Nov 22

ManMower closed D7315: elm: roll _tree_custom_chain_missing into main focus test function.
Thu, Nov 22, 7:12 AM · efl
ManMower closed D7314: elm: Compress more focus tests into the same list walk.
Thu, Nov 22, 7:11 AM · efl
ManMower closed D7313: elm: Re-order focus tests.
Thu, Nov 22, 7:11 AM · efl
ManMower closed D7312: elm: Walk parents instead of parent widget in focus test.
Thu, Nov 22, 7:11 AM · efl
ManMower closed D7308: elm: speed up _eval_registration_candidate.
Thu, Nov 22, 7:11 AM · efl

Wed, Nov 21

ManMower updated the diff for D7315: elm: roll _tree_custom_chain_missing into main focus test function.

Fix the parent test to use parent and child instead of parent and self

Wed, Nov 21, 9:14 AM · efl
ManMower added a comment to D7315: elm: roll _tree_custom_chain_missing into main focus test function.

What's broken? I seem to be able to navigate that test just fine?

Wed, Nov 21, 7:25 AM · efl

Tue, Nov 20

ManMower requested review of D7315: elm: roll _tree_custom_chain_missing into main focus test function.
Tue, Nov 20, 12:41 PM · efl
ManMower added a child revision for D7314: elm: Compress more focus tests into the same list walk: D7315: elm: roll _tree_custom_chain_missing into main focus test function.
Tue, Nov 20, 12:41 PM · efl
ManMower requested review of D7314: elm: Compress more focus tests into the same list walk.
Tue, Nov 20, 12:41 PM · efl
ManMower added a child revision for D7313: elm: Re-order focus tests: D7314: elm: Compress more focus tests into the same list walk.
Tue, Nov 20, 12:40 PM · efl
ManMower requested review of D7313: elm: Re-order focus tests.
Tue, Nov 20, 12:40 PM · efl
ManMower added a child revision for D7312: elm: Walk parents instead of parent widget in focus test: D7313: elm: Re-order focus tests.
Tue, Nov 20, 12:40 PM · efl
ManMower requested review of D7312: elm: Walk parents instead of parent widget in focus test.
Tue, Nov 20, 12:40 PM · efl
ManMower added a child revision for D7308: elm: speed up _eval_registration_candidate: D7312: elm: Walk parents instead of parent widget in focus test.
Tue, Nov 20, 12:40 PM · efl
ManMower updated the diff for D7308: elm: speed up _eval_registration_candidate.

Ooops, I think this one stayed the same and got rolled in with the new submissions

Tue, Nov 20, 12:40 PM · efl
ManMower planned changes to D7308: elm: speed up _eval_registration_candidate.

Just looking at elm_test startup, that list is *always* empty, so there would be a big payoff (probably another 2-3ms at elm_test start) moving that into the same list walk, nice catch.

Tue, Nov 20, 7:43 AM · efl
ManMower added a comment to D7308: elm: speed up _eval_registration_candidate.

Ah, cool, I didn't realize the list was usually NULL - I noticed there are fewer calls to _tree_custom_chain_missing(), so wondered if we frequently avoided non-NULL work there...

Tue, Nov 20, 7:33 AM · efl
ManMower added a reviewer for D7122: software_generic: Fix memory leak when resizing dmabuf native surfaces: cedric.

Adding cedric as a reviewer. If this is the wrong approach maybe he can give input on fixing it...

Tue, Nov 20, 6:00 AM · efl

Mon, Nov 19

ManMower added a comment to D7122: software_generic: Fix memory leak when resizing dmabuf native surfaces.

Tizen also doesn't frequently resize clients, as they're all full screen?

Mon, Nov 19, 2:52 PM · efl
ManMower added a comment to D7308: elm: speed up _eval_registration_candidate.

I thought about mashing _tree_custom_chain_missing() into this same loop, but it seems a little heavier, and I don't know if it would be a win 100% of the time.

Mon, Nov 19, 1:49 PM · efl
ManMower added a reviewer for D7308: elm: speed up _eval_registration_candidate: bu5hm4n.
Mon, Nov 19, 1:47 PM · efl
ManMower requested review of D7308: elm: speed up _eval_registration_candidate.
Mon, Nov 19, 1:46 PM · efl
ManMower closed D7248: ee_wayland: Set opaque region for alphaless surfaces.
Mon, Nov 19, 8:12 AM · efl
ManMower added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

Looking at before and after perf reports, I guess perf isn't actually the best way to show the benefit of that work - for elementary_test, eet wasn't prevalent in the report, and for a simple hello world eet is still the most prevalent thing in the report, just differently. :)

Mon, Nov 19, 7:39 AM · Restricted Project, Restricted Project, efl: data types

Fri, Nov 16

ManMower added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

I've been looking at eet's contributions, as it was doing a lot of extra work at startup. Now that I've landed some eet fixes, here's the top few results I get from the perf report for:
ELM_FIRST_FRAME=E ELM_ENGINE=buffer perf record -i elementary_test

Fri, Nov 16, 10:29 AM · Restricted Project, Restricted Project, efl: data types
ManMower closed D7283: eet: Remove unused code.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7282: eet: Remove pointer deduplication.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7281: eet: Demystify some typecasts.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7280: eet: Stop freeing allocated memory in descriptor_decode.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7279: eet: Don't add duplicate hashes to eet freelist.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7278: eet: Don't add duplicate lists to eet freelist.
Fri, Nov 16, 10:18 AM · efl
ManMower closed D7295: meson: fix build break.
Fri, Nov 16, 8:26 AM · efl
ManMower accepted D7295: meson: fix build break.

This makes sense to me.

Fri, Nov 16, 8:24 AM · efl
ManMower requested review of D7280: eet: Stop freeing allocated memory in descriptor_decode.
Fri, Nov 16, 8:08 AM · efl
ManMower updated the diff for D7280: eet: Stop freeing allocated memory in descriptor_decode.

Only add to freelist if allocation took place

Fri, Nov 16, 8:07 AM · efl

Thu, Nov 15

ManMower planned changes to D7280: eet: Stop freeing allocated memory in descriptor_decode.

This one breaks the test suite. revising.

Thu, Nov 15, 2:40 PM · efl
ManMower added a reviewer for D7282: eet: Remove pointer deduplication: cedric.
Thu, Nov 15, 2:20 PM · efl
ManMower added a reviewer for D7281: eet: Demystify some typecasts: cedric.
Thu, Nov 15, 2:19 PM · efl
ManMower added a reviewer for D7280: eet: Stop freeing allocated memory in descriptor_decode: cedric.
Thu, Nov 15, 2:19 PM · efl
ManMower added a reviewer for D7279: eet: Don't add duplicate hashes to eet freelist: cedric.
Thu, Nov 15, 2:19 PM · efl
ManMower added a reviewer for D7278: eet: Don't add duplicate lists to eet freelist: cedric.
Thu, Nov 15, 2:19 PM · efl
ManMower added a reviewer for D7283: eet: Remove unused code: cedric.
Thu, Nov 15, 2:19 PM · efl
ManMower requested review of D7283: eet: Remove unused code.
Thu, Nov 15, 2:07 PM · efl
ManMower added a child revision for D7282: eet: Remove pointer deduplication: D7283: eet: Remove unused code.
Thu, Nov 15, 2:07 PM · efl
ManMower requested review of D7282: eet: Remove pointer deduplication.
Thu, Nov 15, 2:06 PM · efl
ManMower requested review of D7281: eet: Demystify some typecasts.
Thu, Nov 15, 2:06 PM · efl
ManMower added a child revision for D7281: eet: Demystify some typecasts: D7282: eet: Remove pointer deduplication.
Thu, Nov 15, 2:06 PM · efl
ManMower added a child revision for D7280: eet: Stop freeing allocated memory in descriptor_decode: D7281: eet: Demystify some typecasts.
Thu, Nov 15, 2:06 PM · efl
ManMower requested review of D7280: eet: Stop freeing allocated memory in descriptor_decode.
Thu, Nov 15, 2:06 PM · efl
ManMower requested review of D7279: eet: Don't add duplicate hashes to eet freelist.
Thu, Nov 15, 2:06 PM · efl
ManMower added a child revision for D7279: eet: Don't add duplicate hashes to eet freelist: D7280: eet: Stop freeing allocated memory in descriptor_decode.
Thu, Nov 15, 2:06 PM · efl
ManMower added a child revision for D7278: eet: Don't add duplicate lists to eet freelist: D7279: eet: Don't add duplicate hashes to eet freelist.
Thu, Nov 15, 2:06 PM · efl
ManMower requested review of D7278: eet: Don't add duplicate lists to eet freelist.
Thu, Nov 15, 2:06 PM · efl