Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (339 w, 4 d)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Wed, Jan 15

SanghyeonLee added a comment to D11106: MonoModelInteral : Add missing model events..

Do not merge yet as this implement need to be discussed in right way.

Wed, Jan 15, 4:33 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D11106: MonoModelInteral : Add missing model events.: DO NOT MERGE.
Wed, Jan 15, 4:32 AM · DO NOT MERGE, efl
SanghyeonLee requested review of D11106: MonoModelInteral : Add missing model events..
Wed, Jan 15, 4:25 AM · DO NOT MERGE, efl

Sun, Jan 12

SanghyeonLee added a comment to D10935: efl_model : Stablized child,added child,removed events..

I think it would better to have only one way to get the event for user,
so they don't need to care about child or children,
so if it has to be changed,

Sun, Jan 12, 11:19 PM · efl

Mon, Dec 30

SanghyeonLee updated the diff for D10984: evas: fix legacy evas_object_clip_unset for group object..

remove smart check.

Mon, Dec 30, 3:11 PM · efl
SanghyeonLee requested review of D10984: evas: fix legacy evas_object_clip_unset for group object..
Mon, Dec 30, 4:41 AM · efl

Tue, Dec 24

SanghyeonLee accepted D10945: elementary: enforce container type check for efl_ui_item_index_get and improve documentation..
Tue, Dec 24, 3:01 AM · efl

Mon, Dec 23

SanghyeonLee added inline comments to D10945: elementary: enforce container type check for efl_ui_item_index_get and improve documentation..
Mon, Dec 23, 3:09 AM · efl

Sun, Dec 22

SanghyeonLee updated the diff for D10952: eolian_mono : add verb unselect on naming helper..

update comma

Sun, Dec 22, 11:20 PM · efl
SanghyeonLee added a reviewer for D10952: eolian_mono : add verb unselect on naming helper.: Jaehyun_Cho.
Sun, Dec 22, 10:44 PM · efl
SanghyeonLee requested review of D10952: eolian_mono : add verb unselect on naming helper..
Sun, Dec 22, 10:43 PM · efl

Dec 20 2019

SanghyeonLee added a comment to D10935: efl_model : Stablized child,added child,removed events..

@segfaultxavi,
One question about event stabilizing,
the class of efl_model is since 1.23
but these events beta and being stabilized in 1.24,
so do we have to put the @since tag on the event either?

Dec 20 2019, 12:43 AM · efl
SanghyeonLee requested review of D10935: efl_model : Stablized child,added child,removed events..
Dec 20 2019, 12:42 AM · efl
SanghyeonLee closed D10930: efl_interface: add @since tag for Efl_Model_Children_Event.
Dec 20 2019, 12:38 AM · efl

Dec 19 2019

SanghyeonLee added a comment to D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..

I'm not sure it can doable in app side level as _elm_widget_item_view_clear is elementary private function and all deletion process in genlist is also internal.
hmm need to think about the way of doing this again as application can intercept the deletion also...

Dec 19 2019, 7:15 PM · efl
SanghyeonLee accepted D10930: efl_interface: add @since tag for Efl_Model_Children_Event.
Dec 19 2019, 7:12 PM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

@cedric
I have one question regarding all composite model.

Dec 19 2019, 3:48 AM · efl
SanghyeonLee added a comment to D10856: efl_interface : stablized Efl_Model_Children_Event.

agreed.
now everywhere we can see the unit for model,
and to change this, we should change all of them and I don't think it is doable thing as most of them are already stabilized.

Dec 19 2019, 3:06 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

I think it can be out of beta as index_range is already stabilized.

Dec 19 2019, 3:04 AM · efl

Dec 18 2019

SanghyeonLee added reviewers for D10856: efl_interface : stablized Efl_Model_Children_Event: cedric, segfaultxavi, bu5hm4n.
Dec 18 2019, 6:24 PM · efl
SanghyeonLee accepted D10910: elementary: make sure Efl.Ui.Multi_Selectable_Index_Range use unsigned int for index too..

thanks for fast fix :)

Dec 18 2019, 6:21 PM · efl
SanghyeonLee added a comment to D10869: efl: make sure all index for Efl_Model are unsigned int..

@cedric
isn't multi_selectable_index_range also needed to changed uint64 ->unsigned int?

Dec 18 2019, 3:46 AM · efl
SanghyeonLee updated the diff for D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..

change item->eo_obj to eo_item.

Dec 18 2019, 2:43 AM · efl
SanghyeonLee updated the test plan for D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:42 AM · efl
SanghyeonLee updated subscribers of D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:35 AM · efl
SanghyeonLee requested review of D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:34 AM · efl

Dec 17 2019

SanghyeonLee added a comment to D10892: efl_ui_item: use signals from the theme and not object.

I have a question regarding this clickable part.

Dec 17 2019, 3:42 AM · efl

Dec 16 2019

SanghyeonLee accepted D10869: efl: make sure all index for Efl_Model are unsigned int..
Dec 16 2019, 12:02 AM · efl

Dec 15 2019

SanghyeonLee closed D10855: efl_ui : stablized factory classes..
Dec 15 2019, 11:58 PM · efl

Dec 11 2019

SanghyeonLee added a comment to D10855: efl_ui : stablized factory classes..

no, I don't want to :) I'm just asking any possibility cause I hope it would not.
I think we got an agreement that most of mvvm infrastructure is firmed,
so I want to move forward :)

Dec 11 2019, 11:27 PM · efl
SanghyeonLee added a comment to D10856: efl_interface : stablized Efl_Model_Children_Event.

I'm more prefer to have abstract way to indicate the item as index can be changed by inputs,
but it's time to decide whether we go with int or not...
still int index is widely used for indicate the item in gui frameworks,
I think user fully understand that they need to tracking input changes to get the right item.

Dec 11 2019, 11:23 PM · efl

Dec 10 2019

SanghyeonLee accepted D10687: elementary: reduce events triggered by Efl.Ui.PositionManager..
Dec 10 2019, 11:21 PM · efl
SanghyeonLee requested review of D10856: efl_interface : stablized Efl_Model_Children_Event.
Dec 10 2019, 11:05 PM · efl
SanghyeonLee added a child revision for D10855: efl_ui : stablized factory classes.: D10856: efl_interface : stablized Efl_Model_Children_Event.
Dec 10 2019, 11:05 PM · efl
SanghyeonLee added a comment to D10855: efl_ui : stablized factory classes..

are there any chance to change this class name or method?

Dec 10 2019, 10:56 PM · efl
SanghyeonLee requested review of D10855: efl_ui : stablized factory classes..
Dec 10 2019, 10:56 PM · efl

Dec 9 2019

SanghyeonLee edited the content of Enlightenment Developer Days 2019.
Dec 9 2019, 11:19 PM
SanghyeonLee edited the content of Enlightenment Developer Days 2019.
Dec 9 2019, 11:17 PM

Nov 24 2019

SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

@by_Ref ?

Nov 24 2019, 1:51 AM · efl

Nov 19 2019

SanghyeonLee added a comment to T8471: Header and Footer in Item Widget.

One big question regarding this header and footer is...
how we support horizontal header/footer.

Nov 19 2019, 4:37 AM

Nov 18 2019

SanghyeonLee added a comment to T8305: RFC: Items.

I'm thinking to adding more item styles,

Nov 18 2019, 7:55 PM · efl: api

Nov 17 2019

SanghyeonLee accepted D10685: elementary: reduce event generation during object creation by Efl.Ui.WidgetFactory..
Nov 17 2019, 8:55 PM · efl
SanghyeonLee accepted D10686: elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView..
Nov 17 2019, 8:55 PM · efl
SanghyeonLee accepted D10688: elementary: improve data layout for Efl.Ui.PositionManager*..
Nov 17 2019, 8:55 PM · efl

Nov 14 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

I like the names.
after few reviewing on the class method, I think those two either can be stabilized :)

Nov 14 2019, 5:00 PM · efl: api, efl: language bindings
SanghyeonLee added inline comments to D10675: efl_ui_multi_selectable: clean this up.
Nov 14 2019, 4:58 PM · efl
SanghyeonLee closed T8461: how to provide Efl.Ui.Layout part? as Resolved.

issue is resolved.

Nov 14 2019, 3:39 AM
SanghyeonLee added a comment to D10663: Revert "elm/genlist: remove calc jobs".

more right way of reverting it is revert elm/genlist: defer recalc when applying a name filter either

Nov 14 2019, 2:52 AM · efl
SanghyeonLee added reviewers for D10663: Revert "elm/genlist: remove calc jobs": cedric, bu5hm4n.
Nov 14 2019, 2:32 AM · efl
SanghyeonLee updated the task description for T8471: Header and Footer in Item Widget.
Nov 14 2019, 2:08 AM
SanghyeonLee added a comment to D10649: efl_ui_scrollbar: change scrollbar state when theme is reloaded..

As the documentation I proposed says, when MODE is AUTO, the user cannot know if the scrollbar is currently shown or not, right? This is what efl_ui_scrollbar_visible_get() does.

Nov 14 2019, 2:07 AM · efl
SanghyeonLee added a comment to T8305: RFC: Items.

let's guess user want to make an item with progressbar in the center.
or some complicated layout like 3 line text and 3 different check and icon and button.
there are tons of different demands of making their list by their own gui,
we cannot support all of them.

Nov 14 2019, 2:05 AM · efl: api
SanghyeonLee requested review of D10663: Revert "elm/genlist: remove calc jobs".
Nov 14 2019, 1:41 AM · efl

Nov 13 2019

SanghyeonLee added a comment to T8305: RFC: Items.

it only hold one swallow part which have the same size of item.
It is just single item container which make user customize their own item without using edc,
so yes, it could be default item if user make an horizontal box and pack the two icon and label. that is the example case I guess.
the idea is,
user may decide the size of item(or their content) by set the min size themselves,
and decorating item as it's own demands.

Nov 13 2019, 8:37 PM · efl: api
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

so the conclusion is we maintain current classes as what they are?
we spend too much time to find out best figure for this,
so I'm okay with current way as it is the conclusion of long discussion.

Nov 13 2019, 8:36 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10649: efl_ui_scrollbar: change scrollbar state when theme is reloaded..

@segfaultxavi
isn't it too overlapped with bar_mode set?
we already have EFL_UI_SCROLLBAR_MODE in both axis,
with a AUTO(means if content is bigger than viewport, scrollbar shows, if smaller then viewport, hidden), ON, and OFF.

Nov 13 2019, 8:33 PM · efl

Nov 12 2019

SanghyeonLee created T8471: Header and Footer in Item Widget.
Nov 12 2019, 1:09 AM

Nov 11 2019

SanghyeonLee added a comment to T8305: RFC: Items.
  • Default : I think Default is quite generally used in this case but standard also looks good.
  • Placeholder : I like the Decorator (or Decoratable) as a name, though placeholder is more intuitive.
  • Context : First of all we need to define what exactly this item will do. if it only works with flip(or slide) the item and give another options, Slidable or Hidden_Option can be used. I prefer to have more confirmed type of item not too general and can be understood in many ways.
Nov 11 2019, 11:03 PM · efl: api

Nov 6 2019

SanghyeonLee accepted D10594: csharp: Make GetPart public..
Nov 6 2019, 11:07 PM · efl
SanghyeonLee added a comment to D10306: efl_ui_item: add API that restricts a item from beeing unselected.

so is this some alternative way after removing select_always?
as I see the usage looks quite similar..

Nov 6 2019, 5:30 AM · efl
SanghyeonLee accepted D10590: elementary: fix end of fast scroll not showing up during Efl.Ui.CollectionView scroll..
Nov 6 2019, 1:13 AM · efl

Nov 5 2019

SanghyeonLee added a comment to D10594: csharp: Make GetPart public..

I'm not tested every cases,
but it seems works as what we expected.

Nov 5 2019, 10:49 PM · efl

Nov 1 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

about 3,
wasn't it better to allow select_range for integer only,
so user can call for collection

Nov 1 2019, 3:03 AM · efl: api, efl: language bindings
SanghyeonLee created T8464: EFL# : Crash in iterator foreach which generated by Eina_List.
Nov 1 2019, 2:40 AM
SanghyeonLee updated the task description for T8463: Boolean type fail to create UserModel.
Nov 1 2019, 12:29 AM
SanghyeonLee updated the task description for T8463: Boolean type fail to create UserModel.
Nov 1 2019, 12:29 AM
SanghyeonLee created T8463: Boolean type fail to create UserModel.
Nov 1 2019, 12:28 AM

Oct 31 2019

SanghyeonLee added a comment to T8462: Provide generic access to parts from C#.

I was thinking we cannot do this in c either,
but yes, I forgot the existence of efl_part.

Oct 31 2019, 11:18 PM · efl (efl-1.24), efl: language bindings
SanghyeonLee added a comment to T8461: how to provide Efl.Ui.Layout part? .
Oct 31 2019, 11:13 PM
SanghyeonLee created T8461: how to provide Efl.Ui.Layout part? .
Oct 31 2019, 1:26 AM

Oct 28 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

so, at this moment,

  1. multi_selectable & multi_selectable_async to be out of @beta
  2. range_select range_unselect to be @beta till we find another usage of range.
Oct 28 2019, 6:38 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10519: elm/genlist: only add calc job on theme apply if already finalized.

@cedric you accept it so fast.
I tested all the patches in dev/zmike/genlist and confirmed it works very well in desktop test cases.
most of code that removed for optimization is exist for some issue cases,
but as time passed and all core frameworks are updated,
it would be great opportunity to confirm we really need this code or not.
but for Tizen,
I'm little bit afraid of applying this patch as their are so many un-expected usage and issues which wasn't really considered as issue on desktop environment.
thankfully we are only using upstream genlist in one profile which doesn't have that much usage, so I can find out issue more easily so it can be doable thing.

Oct 28 2019, 3:43 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

to 1.: I dont see much value in having a shared interface there. I do not see a usecase where someone wants to set a select_mode without knowning if this is a async or sync.
to 2.: i guess so :p
to 3.: I must admit that i do not see much value in such a abstraction in eina. It would only be usefull for ids. And in this special case, it sounds just like a geometrical span element. Where we have eina_spans_intersect. So the only advantage would be a simple struct with 2 ID's. Does someone see more value in this ?

Oct 28 2019, 1:08 AM · efl: api, efl: language bindings

Oct 27 2019

SanghyeonLee added a comment to T8329: Need to be stabilized mono classes..

ping? any plan for this?

Oct 27 2019, 10:33 PM

Oct 25 2019

SanghyeonLee updated subscribers of T8432: efl_del_intercept cannot intercept invalidation.
Oct 25 2019, 3:50 AM
SanghyeonLee triaged T8432: efl_del_intercept cannot intercept invalidation as High priority.
Oct 25 2019, 3:49 AM

Oct 24 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

Let's re-start discussion about this task and remove @beta asap.

Oct 24 2019, 9:17 PM · efl: api, efl: language bindings

Oct 18 2019

SanghyeonLee closed T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly. as Resolved.
Oct 18 2019, 2:16 AM
SanghyeonLee added a comment to T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly..

seems we could add del intercept for animation cases but then del_pre cannot do what we expected...

Oct 18 2019, 1:47 AM
SanghyeonLee updated subscribers of T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly..
Oct 18 2019, 1:37 AM
SanghyeonLee updated the task description for T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly..
Oct 18 2019, 1:37 AM
SanghyeonLee updated the task description for T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly..
Oct 18 2019, 1:36 AM
SanghyeonLee created T8386: item_del_pre : replace to trigger deletion and hold the deletion process properly..
Oct 18 2019, 1:34 AM

Oct 15 2019

SanghyeonLee accepted D10300: csharp: Add Efl.Model implementations to internal model.

Thanks for updating

Oct 15 2019, 11:27 PM · efl

Oct 10 2019

SanghyeonLee triaged T8329: Need to be stabilized mono classes. as High priority.
Oct 10 2019, 4:58 AM
SanghyeonLee triaged T8327: Range Insfrastructures in Eina as Wishlist priority.
Oct 10 2019, 3:04 AM
SanghyeonLee added a comment to T8312: elm_list_select_mode_set -> ELM_OBJECT_SELECT_MODE_ALWAYS issue/question.

... ELM_OBJECT_SELECT_MODE_ALWAYS : This means that, even if selected, every click will make the selected callbacks be called. ...

Oct 10 2019, 2:29 AM · efl: widgets
SanghyeonLee added a comment to D10300: csharp: Add Efl.Model implementations to internal model.

code seems fine, but one question in inline.

Oct 10 2019, 1:20 AM · efl
SanghyeonLee closed D10332: elm: fix legacy callback names..
Oct 10 2019, 12:54 AM · efl

Oct 9 2019

SanghyeonLee requested review of D10332: elm: fix legacy callback names..
Oct 9 2019, 11:29 PM · efl

Sep 26 2019

SanghyeonLee removed a project from T7871: efl.ui.multi_selectable: efl (efl-1.23).
Sep 26 2019, 9:38 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10215: efl_ui : stabilized Efl.Ui.List_Placeholder_Item.

oops. i'm late on this.

Sep 26 2019, 9:07 PM · efl
SanghyeonLee requested review of D10215: efl_ui : stabilized Efl.Ui.List_Placeholder_Item.
Sep 26 2019, 7:31 PM · efl
SanghyeonLee updated subscribers of D10191: efl_ui : stabilized Efl.Ui.Select_Model.

and for the notice,
me and @bu5hm4n agreed to keep multi_selectable and multi_selectable in beta,
while the selectable and single_selectale is stabilized.

Sep 26 2019, 7:38 AM · efl
SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

hmm... I think boolean model is quite useful to userside, but still user can access boolean data by property get right?
if then it seems not serious problem in here,
at least we still have a moment to out of beta for this class in tizen side, only few weeks though.

Sep 26 2019, 7:36 AM · efl
SanghyeonLee added a comment to D10189: efl_core : stabilized Efl.Generic_Model.

can you land it before we release it?
if we not release door shutdown till tomorrow I can do that.

Sep 26 2019, 7:32 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

hmmm could be.
anyway we have change to make it public after released, so okay I agreed.

Sep 26 2019, 7:31 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

it has same problem iterator<ptr(uint64)> stable error.

Sep 26 2019, 4:54 AM · efl
SanghyeonLee requested review of D10191: efl_ui : stabilized Efl.Ui.Select_Model.
Sep 26 2019, 4:53 AM · efl
SanghyeonLee added a child revision for D10190: efl_core : stabilized Efl.Boolean_Model: D10191: efl_ui : stabilized Efl.Ui.Select_Model.
Sep 26 2019, 4:53 AM · efl