Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (308 w, 3 d)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Wed, May 29

SanghyeonLee closed D9019: Genlist: Fix for genlist item field update.
Wed, May 29, 11:46 PM · efl
SanghyeonLee accepted D9019: Genlist: Fix for genlist item field update.

I've tested few cases that I worried about,
but looks okay with it.
thanks for the work :)

Wed, May 29, 11:45 PM · efl
SanghyeonLee closed D9034: efl_ui: rename list empty item to list placeholder item..
Wed, May 29, 11:39 PM · efl
SanghyeonLee closed D8582: efl_ui : refactoring efl.part in item based classes..
Wed, May 29, 11:00 PM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

fix the example crash on text_set and icon content_set.

Wed, May 29, 10:57 PM · efl
SanghyeonLee requested review of D8582: efl_ui : refactoring efl.part in item based classes..

I think this patch is not ready to land yet,
as it get crashed on efl_ui_list_example_1.c.
please do not merge yet.

Wed, May 29, 9:42 PM · efl
SanghyeonLee added a comment to D9034: efl_ui: rename list empty item to list placeholder item..

I change the place_holder to placeholder so is there no problem in the name,
I think it is ready to land.

Wed, May 29, 9:17 PM · efl
SanghyeonLee updated the diff for D9034: efl_ui: rename list empty item to list placeholder item..

remove unnecessary spaces.

Wed, May 29, 5:27 AM · efl
SanghyeonLee updated the diff for D9034: efl_ui: rename list empty item to list placeholder item..

remove diff of depends patch

Wed, May 29, 5:25 AM · efl
SanghyeonLee updated the diff for D9034: efl_ui: rename list empty item to list placeholder item..

fix place_holder to placeholder

Wed, May 29, 5:24 AM · efl
SanghyeonLee added a comment to D9034: efl_ui: rename list empty item to list placeholder item..

yeah I was consider it as a single noun, "placeholder"... it is my mistake. I'll fix it :)

Wed, May 29, 5:16 AM · efl
SanghyeonLee requested review of D9034: efl_ui: rename list empty item to list placeholder item..
Wed, May 29, 4:08 AM · efl
SanghyeonLee added a child revision for D8582: efl_ui : refactoring efl.part in item based classes.: D9034: efl_ui: rename list empty item to list placeholder item..
Wed, May 29, 4:08 AM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

update example code.

Wed, May 29, 3:54 AM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

update missing theme part name changes.

Wed, May 29, 3:34 AM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

update patch with change part names,
Text_Default -> Text
Content_Icon -> Icon
Content_End -> Extra
Content_Placeholder -> Content.

Wed, May 29, 3:32 AM · efl

Tue, May 28

SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

@segfaultxavi @q66 thank you! I'll update the patch as commented way asap.

Tue, May 28, 7:12 PM · efl

Mon, May 27

SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

Currently the bindings add a Part suffix: a part named color generates a C# property named ColorPart.
This should only produce a conflict if you had a property named color_part, which would be very strange.
The same problem exists if you have a property named changed_evt for example...

I think the only way to be sure is building the bindings during tests.

Mon, May 27, 11:14 PM · efl
SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

the conflict is detected when validate the part name of class property hash.
I think this check is still valid thing, somehow, as property could use "part_" prefix though we have to avoid these prefix.
so instead of adding prefix in c# binding only,
what about adding prefix in eolian part->base.name directly, when it store the stringshare?

In C there is no clash, because properties and parts use completely separate APIs (class_name_property_get() and efl_part()).
In C# though, properties and parts can both be accessed through standard C# properties, and therefore there is collision (class.Property and class.Part).

For this reason, I think the collision should be fixed by the binding that cause them. Otherwise, we introduce artificial restrictions to the other languages.

Did I understand your concerns correctly?

Mon, May 27, 7:15 PM · efl
SanghyeonLee added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

I do still think View is a conflictual key word that is expected to mean something like View in MVC, MVVM and friends in any other language/framework.

Mon, May 27, 6:55 PM · efl

Sun, May 26

SanghyeonLee added a comment to D9019: Genlist: Fix for genlist item field update.

hmm I agreed basic idea of this patch....
one my concern is when item size need to be updated by text / content changes...
i'll do few test with this patch and review it again.

Sun, May 26, 9:45 PM · efl

Fri, May 24

SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

hmmm I have one suggestion,

Fri, May 24, 4:01 AM · efl

Tue, May 21

SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

The C# bindings now automatically add the Part suffix, so we do not need to use any prefix or suffix. label, icon and extra should be good enough names for parts now.

The problem is that Eolian is still enforcing that part names do not clash with property names. Can this restriction be removed, @q66?

Also, be careful, there's still commented-out code in efl_ui_grid_default_item.c

Tue, May 21, 10:09 PM · efl

Sun, May 19

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

can you update status of this diff?

Sun, May 19, 10:56 PM · DO NOT MERGE, efl
SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

is it okay we go Part_XXX ?

Sun, May 19, 10:55 PM · efl

May 12 2019

SanghyeonLee added a comment to D8755: ecore: add simple logic to generate synthetic string property assembling value of other properties..

the idea looks good but the document need to be checked by @segfaultxavi..
and I think property_string_add/del is better to avoid some confusion of text_set/get

May 12 2019, 10:58 PM · efl

May 10 2019

SanghyeonLee updated subscribers of D8582: efl_ui : refactoring efl.part in item based classes..
May 10 2019, 12:17 AM · efl
SanghyeonLee updated subscribers of D8582: efl_ui : refactoring efl.part in item based classes..
May 10 2019, 12:17 AM · efl
SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

@cedric @segfaultxavi thanks for nice idea.
@lauromoura thanks for testing.

May 10 2019, 12:17 AM · efl

May 9 2019

SanghyeonLee accepted D8799: elementary: move Fileselector to rely on Efl.FilterModel for filtering instead of custom logic..

yeah as I told, this is just readability and preference problem so author think this is right, let's push it.

May 9 2019, 11:48 PM · efl
SanghyeonLee accepted D8798: ecore: add a test for the new Efl.FilterModel..
May 9 2019, 11:47 PM · efl
SanghyeonLee accepted D8797: ecore: add Efl.Filter_Model.

okay then, I think its ready to accept.

May 9 2019, 11:44 PM · efl
SanghyeonLee accepted D8793: eio: correctly set reference count of cached child object..
May 9 2019, 1:03 AM · efl
SanghyeonLee requested changes to D8797: ecore: add Efl.Filter_Model.
May 9 2019, 1:02 AM · efl
SanghyeonLee accepted D8795: ecore: property handle allocation error in Efl.CompositeModel..
May 9 2019, 1:02 AM · efl
SanghyeonLee accepted D8796: ecore: refactor Efl.CompositeModel to provide child allocation to other internal Model..
May 9 2019, 1:01 AM · efl
SanghyeonLee requested changes to D8798: ecore: add a test for the new Efl.FilterModel..
May 9 2019, 12:54 AM · efl

May 8 2019

SanghyeonLee added a comment to D8799: elementary: move Fileselector to rely on Efl.FilterModel for filtering instead of custom logic..

I think code looks fine, but I found few preference coding styles,
I don't have strong opinion so if you thing current way is good then I'll be accept the patch.

May 8 2019, 11:58 PM · efl

May 2 2019

SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

ping?
any opinion about Efl.Part? or naming?

May 2 2019, 4:08 AM · efl
SanghyeonLee added inline comments to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..
May 2 2019, 4:07 AM · efl
SanghyeonLee added a comment to D8797: ecore: add Efl.Filter_Model.

code and idea looks good to me, but it is quite hugh code so it would be better to have some test or examples.
do have any plan for this?

May 2 2019, 4:03 AM · efl

Apr 26 2019

SanghyeonLee accepted D8701: efl_ui_spec_suite: support custom widgets.

test passed with dependencies skipped patch.

Apr 26 2019, 12:58 AM · efl
SanghyeonLee added a comment to D8701: efl_ui_spec_suite: support custom widgets.

okay let me try the build and other test. give me minutes.

Apr 26 2019, 12:45 AM · efl
SanghyeonLee updated subscribers of D8701: efl_ui_spec_suite: support custom widgets.

opps sorry I didn't see that.
should we wait the opinion of @segfaultxavi ?

Apr 26 2019, 12:43 AM · efl
SanghyeonLee added a comment to D8701: efl_ui_spec_suite: support custom widgets.

I like the idea of this patch,
but could be better to give simple explains about custom-mapping as comment for the test writers.

Apr 26 2019, 12:42 AM · efl
SanghyeonLee accepted D8707: efl_ui_suite_spec: add efl_ui_grid to test suite.

thank you.

Apr 26 2019, 12:38 AM · efl
SanghyeonLee accepted D8703: efl_ui_grid: implement index behaviour of efl_pack.

I got the point after reading the efl pack at document....
though it sound like....VERY WEIRD to me..
but it's @jpeg 's design.... and we should have to fallow the definition.
thanks for updating this feature.

Apr 26 2019, 12:37 AM · efl
SanghyeonLee added a comment to T7829: efl_ui_list existance.

code could be duplicated because they are almost same item-based widget, except the layouting... but I don't know what you mean second layout function.
our plan is support list and grid layout with pack-interface on simple case and MVVM interface on more complex or hugh data handling.
efl_ui_list was written before efl_ui_grid, and I planed to use efl.ui.box internally for simple implements, and it works as well for list layout, but
about grid requirement comes, I couldn't use box anymore so I have to make whole pack interface internally.

Apr 26 2019, 12:25 AM · efl: widgets

Apr 25 2019

SanghyeonLee closed D8717: edje_calc: replace eina_stringshare_ref with eina_stringshare_add.
Apr 25 2019, 11:33 PM · efl
SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

ping?

Apr 25 2019, 10:59 PM · DO NOT MERGE, efl
SanghyeonLee accepted D8717: edje_calc: replace eina_stringshare_ref with eina_stringshare_add.

stringshare_add also check hash and if it already hashed, not generated new stringshare.
this looks valid fix to me.

Apr 25 2019, 10:53 PM · efl
SanghyeonLee accepted D8704: efl_ui_grid: add an error to grid.

looks good to me.

Apr 25 2019, 12:34 AM · efl

Apr 24 2019

SanghyeonLee accepted D8706: efl_ui_grid: do not delete a item that is not part of this container.

looks valid fix. though it may user fault, I agree we should give error message and exception handling.

Apr 24 2019, 10:26 PM · efl
SanghyeonLee requested changes to D8703: efl_ui_grid: implement index behaviour of efl_pack.
Apr 24 2019, 10:23 PM · efl
SanghyeonLee added a comment to D8703: efl_ui_grid: implement index behaviour of efl_pack.

if user input is wrong... I think we should fail the request not rollover the index...

Apr 24 2019, 10:23 PM · efl
SanghyeonLee accepted D8702: efl_ui_grid: fixup pack APIs.

looks valid fix. thanks.

Apr 24 2019, 10:07 PM · efl
SanghyeonLee accepted D8705: efl_ui_grid: reparent deleted children.

Looks valid fix. thanks for fixing it.

Apr 24 2019, 10:04 PM · efl

Apr 23 2019

SanghyeonLee requested review of D8684: examples : update list_view examples to use item_class_set not layout_theme_config..
Apr 23 2019, 12:34 AM · efl

Apr 18 2019

SanghyeonLee accepted D8657: ecore: allow multiple Efl.ViewModel of the same source thanks to new infrastructure..

looks good and clean to me.

Apr 18 2019, 10:47 PM · efl
SanghyeonLee accepted D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

I'm little bit worry about 32 bit system needs in the future on tizen side,
but currently it seems we all uisng 64 bit system and it won't be a problem.
I've recently faced some signed-unsigned default datatype issue on char,
so using strict datatype could be nicer to avoid such problem.
lets to discuss again on this matter after all infrastructure is ready :)

Apr 18 2019, 10:45 PM · efl

Apr 17 2019

SanghyeonLee added a comment to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..

code looks good, only few question about uint64 and exclusive term.

Apr 17 2019, 8:58 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

code looks fine but as I remembered there are some question about uint64... do we really need to use uint64 not general integer?

Apr 17 2019, 8:54 PM · efl
SanghyeonLee accepted D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..

looks good to me,
@segfaultxavi do you have other opinion?

Apr 17 2019, 12:33 AM · efl
SanghyeonLee added inline comments to D8582: efl_ui : refactoring efl.part in item based classes..
Apr 17 2019, 12:11 AM · efl
SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I agree with the intention of this commit, which is putting together in the same class repeated parts from different classes.
However, I think we can go even further. Looking at the patch, it looks like the parts for Efl.Ui.List_Default_Item and Efl.Ui.Grid_Default_Item are identical. Could these parts be moved to Efl.Ui.Item, for example?

Apr 17 2019, 12:09 AM · efl

Apr 8 2019

SanghyeonLee closed T7458: Composite Model renaming as Resolved.
Apr 8 2019, 11:50 PM · efl (efl-1.22), efl: mvvm
SanghyeonLee closed T7458: Composite Model renaming, a subtask of T5354: Provide infrastructure for MVVM, as Resolved.
Apr 8 2019, 11:50 PM · efl (efl-1.23), efl: mvvm, efl: data types
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

so do you think we need to restrict factory input as Efl.Ui.Item_Factory only? or just change the property name as factory not item_factory?
I like the first idea, cause every code of list and grid will guess the object created from factory is Efl.Ui.Item not other class,
so if it comes something else, it is really hard to handle exceptions.

Apr 8 2019, 11:42 PM · efl
SanghyeonLee abandoned D7474: efl_ui : update item classes and apply efl_part..

this patch is abandoned after create new patch D8582.
rerfactoring on item default and renaming empty item will be continously updated.

Apr 8 2019, 11:38 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

I was told about D8568

Apr 8 2019, 11:32 PM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

fix typo and examples

Apr 8 2019, 9:43 PM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

remove unnecessary po changes.

Apr 8 2019, 9:35 PM · efl
SanghyeonLee requested review of D8582: efl_ui : refactoring efl.part in item based classes..
Apr 8 2019, 9:32 PM · efl

Apr 7 2019

SanghyeonLee added a comment to D8496: docs: Fill-in parts docs for Efl.Ui.Grid_Default_Item.

sorry I made it and I have a plan to update this to using Efl.Ui.Item_Part_Icon and End not generating same part repeatly, but in here I was thinking that doc need to be updated,

Apr 7 2019, 10:49 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

can you update depended patch?

Apr 7 2019, 10:31 PM · efl
SanghyeonLee added inline comments to D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..
Apr 7 2019, 10:30 PM · efl
SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.

Apr 7 2019, 10:28 PM · DO NOT MERGE, efl

Mar 25 2019

SanghyeonLee closed T7292: Elementary test genlist crash, freeze and other bugs as Resolved.
Mar 25 2019, 9:34 PM · efl (efl-1.22)

Mar 24 2019

SanghyeonLee added a comment to T7292: Elementary test genlist crash, freeze and other bugs.

sorry for late actions.

Mar 24 2019, 11:41 PM · efl (efl-1.22)
SanghyeonLee accepted D8367: elm_gengrid: speed up update order calls.

sorry for late review.
on the purpose of removing unnecessary order setup, this looks valid patch.

Mar 24 2019, 9:28 PM · efl

Mar 21 2019

SanghyeonLee closed D8436: elm : fix wrong layout class comparing in orientation mode disable.
Mar 21 2019, 2:34 AM · efl
SanghyeonLee closed D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Mar 21 2019, 2:34 AM · efl
SanghyeonLee requested review of D8436: elm : fix wrong layout class comparing in orientation mode disable.
Mar 21 2019, 2:12 AM · efl
SanghyeonLee added a comment to D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..

@zmike, we have some testsuite for this elm_object_orientation_mode_disabled_set and it fails after your refactoring of this method.
the code looks never change once it disabled in non-layout case, I think it need to be fixed like this.

Mar 21 2019, 1:25 AM · efl
SanghyeonLee added a reviewer for D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.: zmike.
Mar 21 2019, 1:23 AM · efl
SanghyeonLee requested review of D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Mar 21 2019, 1:21 AM · efl

Mar 10 2019

SanghyeonLee added a comment to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.

this is not a final version, only buildable one. need to figure it out which one we need and not in both of grid view and list view

Mar 10 2019, 10:54 PM · DO NOT MERGE, efl
SanghyeonLee added a project to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM: DO NOT MERGE.
Mar 10 2019, 10:53 PM · DO NOT MERGE, efl
SanghyeonLee requested review of D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.
Mar 10 2019, 10:53 PM · DO NOT MERGE, efl

Feb 26 2019

SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

ping?

Feb 26 2019, 11:35 PM · efl

Feb 25 2019

SanghyeonLee updated the diff for D8024: efl_ui : renaming list_view sub classes..

remove unwanted files

Feb 25 2019, 9:21 PM · efl
SanghyeonLee requested review of D8024: efl_ui : renaming list_view sub classes..
Feb 25 2019, 8:44 PM · efl
SanghyeonLee abandoned D7912: genlist: fix wrong returns in window tooltip set..

it looks zmike disagreed and I respect orignal authors opinion.

Feb 25 2019, 4:46 AM · efl
SanghyeonLee requested changes to D7940: efl: add an event to notify that the View property has changed..

I really not sure but if we goes the event name as properties,changed, it sound more natural to change the other event name as properties,bound?
I mostly prefer the singular name on the APIs and Events, but unity is also very important thing in my thought.
is this property bound only come with single property not a list?
then it sound correct.
I'll change my review status after you pointing what is right.

Feb 25 2019, 4:43 AM · efl

Feb 13 2019

SanghyeonLee accepted D7863: elementary: make sure Efl.Ui.Average_Model stay alive until the end of a property_set..

looks valid patch for me.

Feb 13 2019, 11:59 PM · efl
SanghyeonLee updated the diff for D7925: efl_ui : fix infinite loop in efl_ui_exact model.

rebasing and update while to for statement.

Feb 13 2019, 8:24 PM · efl
SanghyeonLee added a comment to D7925: efl_ui : fix infinite loop in efl_ui_exact model.

this bug is detected by our coverity and I think this is right fix.
also there are some warns about memory leak of cbuf, but it looks reallocation of tbuf, so it looks safe on my view, but I hope you double check it.

Feb 13 2019, 3:37 AM · efl
SanghyeonLee requested review of D7925: efl_ui : fix infinite loop in efl_ui_exact model.
Feb 13 2019, 3:35 AM · efl

Feb 12 2019

SanghyeonLee added a comment to D7912: genlist: fix wrong returns in window tooltip set..

but as you see the code,
in realize case,
it get the return from elm_widget_item_tooltip_window_mode_set which redirect elm_object_tooltip_window_mode_set,
and in elm_tooltip_window_mode_set,
it returns input disable.

Feb 12 2019, 10:04 PM · efl

Feb 11 2019

SanghyeonLee added reviewers for D7912: genlist: fix wrong returns in window tooltip set.: Hermet, woohyun, eagleeye, cedric.
Feb 11 2019, 11:57 PM · efl