Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (375 w, 3 d)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Aug 3 2020

SanghyeonLee closed D12081: embryo: fix a integer(cell) overflow problem.
Aug 3 2020, 10:48 PM · efl
SanghyeonLee accepted D12081: embryo: fix a integer(cell) overflow problem.
Aug 3 2020, 10:46 PM · efl
SanghyeonLee closed D12083: elm : fix return of gengrid item swap anim to prevent animation memory leak..
Aug 3 2020, 10:30 PM · efl
SanghyeonLee requested review of D12083: elm : fix return of gengrid item swap anim to prevent animation memory leak..
Aug 3 2020, 10:22 PM · efl

Jun 29 2020

SanghyeonLee closed D12035: elementary : fix key unselect unhighlighting issue.
Jun 29 2020, 12:39 AM · efl
SanghyeonLee requested review of D12035: elementary : fix key unselect unhighlighting issue.
Jun 29 2020, 12:36 AM · efl

Jun 4 2020

SanghyeonLee accepted D11928: elementary/example: Fix memory leak in gengrid test.
Jun 4 2020, 12:35 AM · efl
SanghyeonLee accepted D11930: gengrid: Fix memory leak.
Jun 4 2020, 12:35 AM · efl

May 21 2020

SanghyeonLee closed D11866: elm_genlist/elm_gengrid: fix memory leak caused by efl_wref_del..
May 21 2020, 2:37 AM · efl
SanghyeonLee accepted D11866: elm_genlist/elm_gengrid: fix memory leak caused by efl_wref_del..

Thank you very much!

May 21 2020, 2:36 AM · efl

Feb 24 2020

SanghyeonLee added a comment to D11227: efl_ui : re-introduce layout_factory.

sorry for late update,
we are so busy as the issues season comes again...

Feb 24 2020, 3:26 AM · efl
SanghyeonLee requested review of D11402: elm : move unrealize callback call before the content caching..
Feb 24 2020, 3:17 AM · efl

Feb 13 2020

SanghyeonLee closed D11348: elm : fix unintialized data set.
Feb 13 2020, 9:29 PM · efl
SanghyeonLee requested review of D11348: elm : fix unintialized data set.
Feb 13 2020, 9:25 PM · efl
SanghyeonLee closed D11333: evas_textblock : remove wrong condition check for size_t value.
Feb 13 2020, 3:15 AM · efl
SanghyeonLee added a comment to D11333: evas_textblock : remove wrong condition check for size_t value.

@ali.alzyod ,
this code is reported in code verifying tool,
and I do not know what exactly you intended here.
is it okay to remove this line? or should it be non-zero checking?

Feb 13 2020, 1:54 AM · efl
SanghyeonLee requested review of D11333: evas_textblock : remove wrong condition check for size_t value.
Feb 13 2020, 1:52 AM · efl

Jan 30 2020

SanghyeonLee added reviewers for D11211: C#: Create GenericFactory for non-layout objects: SanghyeonLee, cedric.
Jan 30 2020, 7:35 PM · efl
SanghyeonLee added a comment to D11160: efl_ui: rename Layout_Factory to Generic_Factory..

@cedric please re-check this patch with D11227

Jan 30 2020, 2:45 AM · efl

Jan 28 2020

SanghyeonLee added a comment to D11227: efl_ui : re-introduce layout_factory.

I think we could add more layout helper method such like
efl_ui_layout_signal_signal_emit.

Jan 28 2020, 10:51 PM · efl
SanghyeonLee added a parent revision for D11227: efl_ui : re-introduce layout_factory: D11160: efl_ui: rename Layout_Factory to Generic_Factory..
Jan 28 2020, 10:49 PM · efl
SanghyeonLee added a child revision for D11160: efl_ui: rename Layout_Factory to Generic_Factory.: D11227: efl_ui : re-introduce layout_factory.
Jan 28 2020, 10:49 PM · efl
SanghyeonLee requested review of D11227: efl_ui : re-introduce layout_factory.
Jan 28 2020, 10:48 PM · efl
SanghyeonLee updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

add I for interface GenericFactoryExtended and GenericFactoryPartExtended.

Jan 28 2020, 6:23 PM · efl

Jan 27 2020

SanghyeonLee updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

removing underline in GetPropBind and GetFactoryBind for complying mono naming rule.
virtual public to public virtual.
line indent fix.

Jan 27 2020, 10:12 PM · efl
SanghyeonLee abandoned D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>.

this patch will be replaced to D11211

Jan 27 2020, 8:49 PM · efl
SanghyeonLee added a comment to D11160: efl_ui: rename Layout_Factory to Generic_Factory..

I think we get agreement about this patch, so if I update new layoutFactory depends on this patch, it is ready for accept, am I right @cedric?

Jan 27 2020, 8:49 PM · efl
SanghyeonLee updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

update patch with removing layoutFactory, and generic for all.
fill the doc comments but it need to be updated later.

Jan 27 2020, 8:47 PM · efl

Jan 23 2020

SanghyeonLee removed a project from D11106: MonoModelInteral : Add missing model events.: DO NOT MERGE.
Jan 23 2020, 4:57 AM · efl
SanghyeonLee added a parent revision for D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>: D11160: efl_ui: rename Layout_Factory to Generic_Factory..
Jan 23 2020, 4:52 AM · efl
SanghyeonLee added a child revision for D11160: efl_ui: rename Layout_Factory to Generic_Factory.: D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>.
Jan 23 2020, 4:52 AM · efl
SanghyeonLee requested review of D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>.
Jan 23 2020, 4:51 AM · efl
SanghyeonLee updated the summary of D11160: efl_ui: rename Layout_Factory to Generic_Factory..
Jan 23 2020, 4:42 AM · efl
SanghyeonLee requested review of D11160: efl_ui: rename Layout_Factory to Generic_Factory..
Jan 23 2020, 4:36 AM · efl
SanghyeonLee added a comment to D11106: MonoModelInteral : Add missing model events..

@felipealmeida
please check this and give us your opinion how to go.

Jan 23 2020, 3:43 AM · efl
SanghyeonLee updated the diff for D11106: MonoModelInteral : Add missing model events..

fix typo

Jan 23 2020, 3:43 AM · efl

Jan 15 2020

SanghyeonLee added a comment to D11106: MonoModelInteral : Add missing model events..

Do not merge yet as this implement need to be discussed in right way.

Jan 15 2020, 4:33 AM · efl
SanghyeonLee added a project to D11106: MonoModelInteral : Add missing model events.: DO NOT MERGE.
Jan 15 2020, 4:32 AM · efl
SanghyeonLee requested review of D11106: MonoModelInteral : Add missing model events..
Jan 15 2020, 4:25 AM · efl

Jan 12 2020

SanghyeonLee added a comment to D10935: efl_model: stablized child,added child,removed events..

I think it would better to have only one way to get the event for user,
so they don't need to care about child or children,
so if it has to be changed,

Jan 12 2020, 11:19 PM · efl

Dec 30 2019

SanghyeonLee updated the diff for D10984: evas: fix legacy evas_object_clip_unset for group object..

remove smart check.

Dec 30 2019, 3:11 PM · efl
SanghyeonLee requested review of D10984: evas: fix legacy evas_object_clip_unset for group object..
Dec 30 2019, 4:41 AM · efl

Dec 24 2019

SanghyeonLee accepted D10945: elementary: enforce container type check for efl_ui_item_index_get and improve documentation..
Dec 24 2019, 3:01 AM · efl

Dec 23 2019

SanghyeonLee added inline comments to D10945: elementary: enforce container type check for efl_ui_item_index_get and improve documentation..
Dec 23 2019, 3:09 AM · efl

Dec 22 2019

SanghyeonLee updated the diff for D10952: eolian_mono : add verb unselect on naming helper..

update comma

Dec 22 2019, 11:20 PM · efl
SanghyeonLee added a reviewer for D10952: eolian_mono : add verb unselect on naming helper.: Jaehyun_Cho.
Dec 22 2019, 10:44 PM · efl
SanghyeonLee requested review of D10952: eolian_mono : add verb unselect on naming helper..
Dec 22 2019, 10:43 PM · efl

Dec 20 2019

SanghyeonLee added a comment to D10935: efl_model: stablized child,added child,removed events..

@segfaultxavi,
One question about event stabilizing,
the class of efl_model is since 1.23
but these events beta and being stabilized in 1.24,
so do we have to put the @since tag on the event either?

Dec 20 2019, 12:43 AM · efl
SanghyeonLee requested review of D10935: efl_model: stablized child,added child,removed events..
Dec 20 2019, 12:42 AM · efl
SanghyeonLee closed D10930: efl_interface: add @since tag for Efl_Model_Children_Event.
Dec 20 2019, 12:38 AM · efl

Dec 19 2019

SanghyeonLee added a comment to D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..

I'm not sure it can doable in app side level as _elm_widget_item_view_clear is elementary private function and all deletion process in genlist is also internal.
hmm need to think about the way of doing this again as application can intercept the deletion also...

Dec 19 2019, 7:15 PM · efl
SanghyeonLee accepted D10930: efl_interface: add @since tag for Efl_Model_Children_Event.
Dec 19 2019, 7:12 PM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

@cedric
I have one question regarding all composite model.

Dec 19 2019, 3:48 AM · efl
SanghyeonLee added a comment to D10856: efl_interface : stablized Efl_Model_Children_Event.

agreed.
now everywhere we can see the unit for model,
and to change this, we should change all of them and I don't think it is doable thing as most of them are already stabilized.

Dec 19 2019, 3:06 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

I think it can be out of beta as index_range is already stabilized.

Dec 19 2019, 3:04 AM · efl

Dec 18 2019

SanghyeonLee added reviewers for D10856: efl_interface : stablized Efl_Model_Children_Event: cedric, segfaultxavi, bu5hm4n.
Dec 18 2019, 6:24 PM · efl
SanghyeonLee accepted D10910: elementary: make sure Efl.Ui.Multi_Selectable_Index_Range use unsigned int for index too..

thanks for fast fix :)

Dec 18 2019, 6:21 PM · efl
SanghyeonLee added a comment to D10869: efl: make sure all index for Efl_Model are unsigned int..

@cedric
isn't multi_selectable_index_range also needed to changed uint64 ->unsigned int?

Dec 18 2019, 3:46 AM · efl
SanghyeonLee updated the diff for D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..

change item->eo_obj to eo_item.

Dec 18 2019, 2:43 AM · efl
SanghyeonLee updated the test plan for D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:42 AM · efl
SanghyeonLee updated subscribers of D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:35 AM · efl
SanghyeonLee requested review of D10904: elm : add del_intercept exception in elm_widget_item_invalidate to provide delete animation..
Dec 18 2019, 2:34 AM · efl

Dec 17 2019

SanghyeonLee added a comment to D10892: efl_ui_item: use signals from the theme and not object.

I have a question regarding this clickable part.

Dec 17 2019, 3:42 AM · efl

Dec 16 2019

SanghyeonLee accepted D10869: efl: make sure all index for Efl_Model are unsigned int..
Dec 16 2019, 12:02 AM · efl

Dec 15 2019

SanghyeonLee closed D10855: efl_ui : stablized factory classes..
Dec 15 2019, 11:58 PM · efl

Dec 11 2019

SanghyeonLee added a comment to D10855: efl_ui : stablized factory classes..

no, I don't want to :) I'm just asking any possibility cause I hope it would not.
I think we got an agreement that most of mvvm infrastructure is firmed,
so I want to move forward :)

Dec 11 2019, 11:27 PM · efl
SanghyeonLee added a comment to D10856: efl_interface : stablized Efl_Model_Children_Event.

I'm more prefer to have abstract way to indicate the item as index can be changed by inputs,
but it's time to decide whether we go with int or not...
still int index is widely used for indicate the item in gui frameworks,
I think user fully understand that they need to tracking input changes to get the right item.

Dec 11 2019, 11:23 PM · efl

Dec 10 2019

SanghyeonLee accepted D10687: elementary: reduce events triggered by Efl.Ui.PositionManager..
Dec 10 2019, 11:21 PM · efl
SanghyeonLee requested review of D10856: efl_interface : stablized Efl_Model_Children_Event.
Dec 10 2019, 11:05 PM · efl
SanghyeonLee added a child revision for D10855: efl_ui : stablized factory classes.: D10856: efl_interface : stablized Efl_Model_Children_Event.
Dec 10 2019, 11:05 PM · efl
SanghyeonLee added a comment to D10855: efl_ui : stablized factory classes..

are there any chance to change this class name or method?

Dec 10 2019, 10:56 PM · efl
SanghyeonLee requested review of D10855: efl_ui : stablized factory classes..
Dec 10 2019, 10:56 PM · efl

Dec 9 2019

SanghyeonLee edited the content of Enlightenment Developer Days 2019.
Dec 9 2019, 11:19 PM
SanghyeonLee edited the content of Enlightenment Developer Days 2019.
Dec 9 2019, 11:17 PM

Nov 24 2019

SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

@by_Ref ?

Nov 24 2019, 1:51 AM · efl

Nov 19 2019

SanghyeonLee added a comment to T8471: Header and Footer in Item Widget.

One big question regarding this header and footer is...
how we support horizontal header/footer.

Nov 19 2019, 4:37 AM

Nov 18 2019

SanghyeonLee added a comment to T8305: RFC: Items.

I'm thinking to adding more item styles,

Nov 18 2019, 7:55 PM · efl: api

Nov 17 2019

SanghyeonLee accepted D10685: elementary: reduce event generation during object creation by Efl.Ui.WidgetFactory..
Nov 17 2019, 8:55 PM · efl
SanghyeonLee accepted D10686: elementary: reduce event trigger during object creation stage in Efl.Ui.CollectionView..
Nov 17 2019, 8:55 PM · efl
SanghyeonLee accepted D10688: elementary: improve data layout for Efl.Ui.PositionManager*..
Nov 17 2019, 8:55 PM · efl

Nov 14 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

I like the names.
after few reviewing on the class method, I think those two either can be stabilized :)

Nov 14 2019, 5:00 PM · efl: api, efl: language bindings
SanghyeonLee added inline comments to D10675: efl_ui_multi_selectable: clean this up.
Nov 14 2019, 4:58 PM · efl
SanghyeonLee closed T8461: how to provide Efl.Ui.Layout part? as Resolved.

issue is resolved.

Nov 14 2019, 3:39 AM
SanghyeonLee added a comment to D10663: Revert "elm/genlist: remove calc jobs".

more right way of reverting it is revert elm/genlist: defer recalc when applying a name filter either

Nov 14 2019, 2:52 AM · efl
SanghyeonLee added reviewers for D10663: Revert "elm/genlist: remove calc jobs": cedric, bu5hm4n.
Nov 14 2019, 2:32 AM · efl
SanghyeonLee updated the task description for T8471: Header and Footer in Item Widget.
Nov 14 2019, 2:08 AM
SanghyeonLee added a comment to D10649: efl_ui_scrollbar: change scrollbar state when theme is reloaded..

As the documentation I proposed says, when MODE is AUTO, the user cannot know if the scrollbar is currently shown or not, right? This is what efl_ui_scrollbar_visible_get() does.

Nov 14 2019, 2:07 AM · efl
SanghyeonLee added a comment to T8305: RFC: Items.

let's guess user want to make an item with progressbar in the center.
or some complicated layout like 3 line text and 3 different check and icon and button.
there are tons of different demands of making their list by their own gui,
we cannot support all of them.

Nov 14 2019, 2:05 AM · efl: api
SanghyeonLee requested review of D10663: Revert "elm/genlist: remove calc jobs".
Nov 14 2019, 1:41 AM · efl

Nov 13 2019

SanghyeonLee added a comment to T8305: RFC: Items.

it only hold one swallow part which have the same size of item.
It is just single item container which make user customize their own item without using edc,
so yes, it could be default item if user make an horizontal box and pack the two icon and label. that is the example case I guess.
the idea is,
user may decide the size of item(or their content) by set the min size themselves,
and decorating item as it's own demands.

Nov 13 2019, 8:37 PM · efl: api
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

so the conclusion is we maintain current classes as what they are?
we spend too much time to find out best figure for this,
so I'm okay with current way as it is the conclusion of long discussion.

Nov 13 2019, 8:36 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10649: efl_ui_scrollbar: change scrollbar state when theme is reloaded..

@segfaultxavi
isn't it too overlapped with bar_mode set?
we already have EFL_UI_SCROLLBAR_MODE in both axis,
with a AUTO(means if content is bigger than viewport, scrollbar shows, if smaller then viewport, hidden), ON, and OFF.

Nov 13 2019, 8:33 PM · efl

Nov 12 2019

SanghyeonLee created T8471: Header and Footer in Item Widget.
Nov 12 2019, 1:09 AM

Nov 11 2019

SanghyeonLee added a comment to T8305: RFC: Items.
  • Default : I think Default is quite generally used in this case but standard also looks good.
  • Placeholder : I like the Decorator (or Decoratable) as a name, though placeholder is more intuitive.
  • Context : First of all we need to define what exactly this item will do. if it only works with flip(or slide) the item and give another options, Slidable or Hidden_Option can be used. I prefer to have more confirmed type of item not too general and can be understood in many ways.
Nov 11 2019, 11:03 PM · efl: api

Nov 6 2019

SanghyeonLee accepted D10594: csharp: Make GetPart public..
Nov 6 2019, 11:07 PM · efl
SanghyeonLee added a comment to D10306: efl_ui_item: add API that restricts a item from beeing unselected.

so is this some alternative way after removing select_always?
as I see the usage looks quite similar..

Nov 6 2019, 5:30 AM · efl
SanghyeonLee accepted D10590: elementary: fix end of fast scroll not showing up during Efl.Ui.CollectionView scroll..
Nov 6 2019, 1:13 AM · efl

Nov 5 2019

SanghyeonLee added a comment to D10594: csharp: Make GetPart public..

I'm not tested every cases,
but it seems works as what we expected.

Nov 5 2019, 10:49 PM · efl

Nov 1 2019

SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

about 3,
wasn't it better to allow select_range for integer only,
so user can call for collection

Nov 1 2019, 3:03 AM · efl: api, efl: language bindings
SanghyeonLee created T8464: EFL# : Crash in iterator foreach which generated by Eina_List.
Nov 1 2019, 2:40 AM