Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (300 w, 11 h)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Yesterday

SanghyeonLee added a comment to D8570: ecore: improve usability of Efl.Select_Model to provide helpers in manipulating selection information..

code looks good, only few question about uint64 and exclusive term.

Wed, Apr 17, 8:58 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

code looks fine but as I remembered there are some question about uint64... do we really need to use uint64 not general integer?

Wed, Apr 17, 8:54 PM · efl
SanghyeonLee accepted D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..

looks good to me,
@segfaultxavi do you have other opinion?

Wed, Apr 17, 12:33 AM · efl
SanghyeonLee added inline comments to D8582: efl_ui : refactoring efl.part in item based classes..
Wed, Apr 17, 12:11 AM · efl
SanghyeonLee added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I agree with the intention of this commit, which is putting together in the same class repeated parts from different classes.
However, I think we can go even further. Looking at the patch, it looks like the parts for Efl.Ui.List_Default_Item and Efl.Ui.Grid_Default_Item are identical. Could these parts be moved to Efl.Ui.Item, for example?

Wed, Apr 17, 12:09 AM · efl

Mon, Apr 8

SanghyeonLee closed T7458: Composite Model renaming as Resolved.
Mon, Apr 8, 11:50 PM · efl (efl-1.22), efl: mvvm
SanghyeonLee closed T7458: Composite Model renaming, a subtask of T5354: Provide infrastructure for MVVM, as Resolved.
Mon, Apr 8, 11:50 PM · efl (efl-1.23), efl: mvvm, efl: data types
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

so do you think we need to restrict factory input as Efl.Ui.Item_Factory only? or just change the property name as factory not item_factory?
I like the first idea, cause every code of list and grid will guess the object created from factory is Efl.Ui.Item not other class,
so if it comes something else, it is really hard to handle exceptions.

Mon, Apr 8, 11:42 PM · efl
SanghyeonLee abandoned D7474: efl_ui : update item classes and apply efl_part..

this patch is abandoned after create new patch D8582.
rerfactoring on item default and renaming empty item will be continously updated.

Mon, Apr 8, 11:38 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

I was told about D8568

Mon, Apr 8, 11:32 PM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

fix typo and examples

Mon, Apr 8, 9:43 PM · efl
SanghyeonLee updated the diff for D8582: efl_ui : refactoring efl.part in item based classes..

remove unnecessary po changes.

Mon, Apr 8, 9:35 PM · efl
SanghyeonLee requested review of D8582: efl_ui : refactoring efl.part in item based classes..
Mon, Apr 8, 9:32 PM · efl

Sun, Apr 7

SanghyeonLee added a comment to D8496: docs: Fill-in parts docs for Efl.Ui.Grid_Default_Item.

sorry I was design it and I have a plan to update this to using Efl.Ui.Item_Part_Icon and End not generating same part repeatly, but in here I was thinking that doc need to be updated,

Sun, Apr 7, 10:49 PM · efl
SanghyeonLee added a comment to D8569: ecore: add an helper for Efl.Boolean_Model to get all the index with a requested value..

can you update depended patch?

Sun, Apr 7, 10:31 PM · efl
SanghyeonLee added inline comments to D8568: ecore: move property string definition to shared headers for Efl.Composite_Model..
Sun, Apr 7, 10:30 PM · efl
SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.

Sun, Apr 7, 10:28 PM · DO NOT MERGE, efl

Mon, Mar 25

SanghyeonLee closed T7292: Elementary test genlist crash, freeze and other bugs as Resolved.
Mon, Mar 25, 9:34 PM · efl (efl-1.22)

Sun, Mar 24

SanghyeonLee added a comment to T7292: Elementary test genlist crash, freeze and other bugs.

sorry for late actions.

Sun, Mar 24, 11:41 PM · efl (efl-1.22)
SanghyeonLee accepted D8367: elm_gengrid: speed up update order calls.

sorry for late review.
on the purpose of removing unnecessary order setup, this looks valid patch.

Sun, Mar 24, 9:28 PM · efl

Thu, Mar 21

SanghyeonLee closed D8436: elm : fix wrong layout class comparing in orientation mode disable.
Thu, Mar 21, 2:34 AM · efl
SanghyeonLee closed D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Thu, Mar 21, 2:34 AM · efl
SanghyeonLee requested review of D8436: elm : fix wrong layout class comparing in orientation mode disable.
Thu, Mar 21, 2:12 AM · efl
SanghyeonLee added a comment to D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..

@zmike, we have some testsuite for this elm_object_orientation_mode_disabled_set and it fails after your refactoring of this method.
the code looks never change once it disabled in non-layout case, I think it need to be fixed like this.

Thu, Mar 21, 1:25 AM · efl
SanghyeonLee added a reviewer for D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set.: zmike.
Thu, Mar 21, 1:23 AM · efl
SanghyeonLee requested review of D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Thu, Mar 21, 1:21 AM · efl

Mar 10 2019

SanghyeonLee added a comment to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.

this is not a final version, only buildable one. need to figure it out which one we need and not in both of grid view and list view

Mar 10 2019, 10:54 PM · DO NOT MERGE, efl
SanghyeonLee added a project to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM: DO NOT MERGE.
Mar 10 2019, 10:53 PM · DO NOT MERGE, efl
SanghyeonLee requested review of D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.
Mar 10 2019, 10:53 PM · DO NOT MERGE, efl

Feb 26 2019

SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

ping?

Feb 26 2019, 11:35 PM · efl

Feb 25 2019

SanghyeonLee updated the diff for D8024: efl_ui : renaming list_view sub classes..

remove unwanted files

Feb 25 2019, 9:21 PM · efl
SanghyeonLee requested review of D8024: efl_ui : renaming list_view sub classes..
Feb 25 2019, 8:44 PM · efl
SanghyeonLee abandoned D7912: genlist: fix wrong returns in window tooltip set..

it looks zmike disagreed and I respect orignal authors opinion.

Feb 25 2019, 4:46 AM · efl
SanghyeonLee requested changes to D7940: efl: add an event to notify that the View property has changed..

I really not sure but if we goes the event name as properties,changed, it sound more natural to change the other event name as properties,bound?
I mostly prefer the singular name on the APIs and Events, but unity is also very important thing in my thought.
is this property bound only come with single property not a list?
then it sound correct.
I'll change my review status after you pointing what is right.

Feb 25 2019, 4:43 AM · efl

Feb 13 2019

SanghyeonLee accepted D7863: elementary: make sure Efl.Ui.Average_Model stay alive until the end of a property_set..

looks valid patch for me.

Feb 13 2019, 11:59 PM · efl
SanghyeonLee updated the diff for D7925: efl_ui : fix infinite loop in efl_ui_exact model.

rebasing and update while to for statement.

Feb 13 2019, 8:24 PM · efl
SanghyeonLee added a comment to D7925: efl_ui : fix infinite loop in efl_ui_exact model.

this bug is detected by our coverity and I think this is right fix.
also there are some warns about memory leak of cbuf, but it looks reallocation of tbuf, so it looks safe on my view, but I hope you double check it.

Feb 13 2019, 3:37 AM · efl
SanghyeonLee requested review of D7925: efl_ui : fix infinite loop in efl_ui_exact model.
Feb 13 2019, 3:35 AM · efl

Feb 12 2019

SanghyeonLee added a comment to D7912: genlist: fix wrong returns in window tooltip set..

but as you see the code,
in realize case,
it get the return from elm_widget_item_tooltip_window_mode_set which redirect elm_object_tooltip_window_mode_set,
and in elm_tooltip_window_mode_set,
it returns input disable.

Feb 12 2019, 10:04 PM · efl

Feb 11 2019

SanghyeonLee added reviewers for D7912: genlist: fix wrong returns in window tooltip set.: Hermet, woohyun, eagleeye, cedric.
Feb 11 2019, 11:57 PM · efl
SanghyeonLee requested review of D7912: genlist: fix wrong returns in window tooltip set..
Feb 11 2019, 11:57 PM · efl

Feb 1 2019

SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

typo

Feb 1 2019, 2:32 AM · efl
SanghyeonLee accepted D7860: eo: fix efl_isa to work propertly with interfaces.

It works very well. thank you so much :)

Feb 1 2019, 2:31 AM · efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

oh its wrong patch.

Feb 1 2019, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee accepted D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I tested and it fix the problem well :) thank you.

Feb 1 2019, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix the dependency file including bugs

Feb 1 2019, 2:10 AM · efl
SanghyeonLee abandoned D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Feb 1 2019, 2:07 AM · efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Feb 1 2019, 2:07 AM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

remove wrong file includes

Feb 1 2019, 2:04 AM · efl
SanghyeonLee abandoned D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Feb 1 2019, 2:01 AM · efl
SanghyeonLee requested review of D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Feb 1 2019, 2:01 AM · efl
SanghyeonLee added a child revision for D7529: efl_ui : rename model connect and factory connect to bind property and factory.: D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Feb 1 2019, 2:01 AM · efl
SanghyeonLee added a revision to T7627: Support Efl.Ui.Item_Factory: D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Feb 1 2019, 2:01 AM · efl: mvvm
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
  • eo: Fix efl_isa for class checking of recursively inherited types
Feb 1 2019, 1:57 AM · efl
SanghyeonLee edited reviewers for D7857: eo: Fix efl_isa for class checking of recursively inherited types, added: q66; removed: QA_Igor.
Feb 1 2019, 1:50 AM · DO NOT MERGE, efl
SanghyeonLee added a reviewer for D7857: eo: Fix efl_isa for class checking of recursively inherited types: QA_Igor.
Feb 1 2019, 1:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Do you have a old efl_ui_layout.eo.c arround somewhere in your tree ?

Feb 1 2019, 1:45 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I think I resolve the problem by recursive calls of efl_isa for mro

Feb 1 2019, 1:42 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

The issue case is easily found in example of efl_ui_list_view_example_1.c

Feb 1 2019, 12:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Feb 1 2019, 12:19 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

looks something wrong in the patch.

Feb 1 2019, 12:09 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D7857: eo: Fix efl_isa for class checking of recursively inherited types: DO NOT MERGE.
Feb 1 2019, 12:08 AM · DO NOT MERGE, efl

Jan 31 2019

SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix unnecessary changes

Jan 31 2019, 10:00 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix meson build and warnings

Jan 31 2019, 9:59 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix po file includes

Jan 31 2019, 9:55 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix meson build error

Jan 31 2019, 9:50 PM · efl
SanghyeonLee added a parent revision for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view.: D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Jan 31 2019, 8:15 PM · efl
SanghyeonLee added a child revision for D7529: efl_ui : rename model connect and factory connect to bind property and factory.: D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Jan 31 2019, 8:15 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

dependency update

Jan 31 2019, 8:14 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

depends on D7529
renew the patch with inherit layout factory.

Jan 31 2019, 8:12 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

renew the patches.
adding new two interfaces,

Jan 31 2019, 3:59 AM · efl
SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

Keep in mind that all the above are for Eina and Legacy methods, apparently we haven't introduced any insertion method in the Unified API yet, so this will be the first one and we can decide to change the rules :)

ALSO, don't forget to document how to insert easily, when you don't care about the insertion point. I am assuming you will use relative_to == NULL? The current diff does not specify this.

Jan 31 2019, 1:12 AM · efl
SanghyeonLee abandoned D4983: genlist: add reorder mode start/stop for key reordering action.
Jan 31 2019, 1:03 AM · efl
SanghyeonLee abandoned D6574: efl_ui_scroll : apply finalize and invalidate object..
Jan 31 2019, 1:02 AM · efl

Jan 30 2019

SanghyeonLee closed D7533: efl_model : rename all efl_model based classes..
Jan 30 2019, 9:59 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

fix few typo which was generated by conflict resolving

Jan 30 2019, 9:28 PM · DO NOT MERGE, efl
SanghyeonLee updated the summary of D7533: efl_model : rename all efl_model based classes..
Jan 30 2019, 9:16 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch and resolve conflict

Jan 30 2019, 9:14 PM · DO NOT MERGE, efl
SanghyeonLee closed D7665: elementary: add test for Efl.Ui.Model_Average..
Jan 30 2019, 6:09 PM · efl
SanghyeonLee accepted D7665: elementary: add test for Efl.Ui.Model_Average..

Looks good to me.

Jan 30 2019, 5:18 PM · efl
SanghyeonLee added a comment to D7665: elementary: add test for Efl.Ui.Model_Average..
  CC       tests/elementary/tests_elementary_efl_ui_suite-efl_ui_suite.o
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_suite.c:5:
../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Text is not available yet without Elementary.h
   ^~~~~~~
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_suite.c:5:
../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Multibutton is not available yet without Elementary.h
   ^~~~~~~
  CC       tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_model.c:5:
../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Text is not available yet without Elementary.h
   ^~~~~~~
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_model.c:5:
../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Multibutton is not available yet without Elementary.h
   ^~~~~~~
tests/elementary/efl_ui_model.c:13:4: error: initializer element is not constant
    base_ints[0] * 3 * 3,
    ^~~~~~~~~
tests/elementary/efl_ui_model.c:13:4: note: (near initialization for ‘expected_average[0]’)
tests/elementary/efl_ui_model.c:14:4: error: initializer element is not constant
    ((base_ints[0] * 3 + base_ints[1] * 3) * 3) / 2,
    ^
tests/elementary/efl_ui_model.c:14:4: note: (near initialization for ‘expected_average[1]’)
tests/elementary/efl_ui_model.c:15:4: error: initializer element is not constant
    base_ints[0] * 3 + base_ints[1] * 3 + base_ints[2] * 3
    ^~~~~~~~~
tests/elementary/efl_ui_model.c:15:4: note: (near initialization for ‘expected_average[2]’)
Makefile:47459: recipe for target 'tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o' failed
make[4]: *** [tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o] Error 1
Makefile:55008: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
Makefile:54316: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
Makefile:55012: recipe for target 'check' failed
make[1]: *** [check] Error 2
Makefile:3015: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
Jan 30 2019, 2:54 AM · efl

Jan 29 2019

SanghyeonLee updated subscribers of D7682: efl_ui_grid : apply relative size feature and row/column count..

one better idea that @smohanty suggested,

Jan 29 2019, 5:21 PM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

Thanks a lot for your patience, @SanghyeonLee, and for a very clear explanation. With pictures!
Unfortunately, I do not think we can add pictures to the EO docs yet :)

I understand now that both partition_rows and partition_columns are needed.
My only comment now is that maybe row_count could be renamed total_row_count to make it clear that it includes the rows outside the viewport. What do you think?

Jan 29 2019, 5:01 PM · efl
SanghyeonLee closed D7829: efl_ui_list_view: Handling failed memory allocation.
Jan 29 2019, 4:47 PM · efl
SanghyeonLee accepted D7829: efl_ui_list_view: Handling failed memory allocation.

looks good to me.

Jan 29 2019, 4:33 PM · efl
SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

yeah naming is really difficult thing always :p
though I like the Swallow_Item idea,
but if you two are voted Placeholder, so I'll go with it.

Jan 29 2019, 4:41 AM · efl
SanghyeonLee added a comment to T7659: Fix efl_part issues in C#.

@cedric, I don't remember exactly which case have some conflict problem regarding this,
so could you give some example to explain the problem?
this would very helpful to understand problem for @woohyun and @Jaehyun_Cho

Jan 29 2019, 4:30 AM · efl: mvvm
SanghyeonLee updated subscribers of T7659: Fix efl_part issues in C#.
Jan 29 2019, 4:19 AM · efl: mvvm
SanghyeonLee updated subscribers of T7659: Fix efl_part issues in C#.
Jan 29 2019, 4:18 AM · efl: mvvm
SanghyeonLee added a parent task for T7659: Fix efl_part issues in C#: T5354: Provide infrastructure for MVVM.
Jan 29 2019, 4:18 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7659: Fix efl_part issues in C#.
Jan 29 2019, 4:18 AM · efl (efl-1.23), efl: mvvm, efl: data types
SanghyeonLee added a comment to T6360: EO: Item and Item_List API's.

shouldn't we abandon or resolve this item?

Jan 29 2019, 4:14 AM · efl (efl-1.23), efl: mvvm, efl: widgets
SanghyeonLee added a comment to T7658: [MVVM] create Efl.Ui.Item_View and infrastructures for common item based view widgets..

we can hiding them in private class, but for making list and grid, tree view with generic interfaces,
making it as common class or interface will be much easier for implement them.
also about layouter,
I think currently it need to be private cause we do not decide which structure we will exposed for model handing on the view,
but the final goal in my thought, it would be better to publish them and user can customize this layouter as what they really want.

Jan 29 2019, 4:12 AM
SanghyeonLee updated subscribers of D7474: efl_ui : update item classes and apply efl_part..

OK, thanks @cedric for the explanation.

These are my two cents:

  • Regarding Empty_Item or Content_Item:
    • I do not like Empty because it looks like it has nothing inside.
    • I do not like Content because all other items have content too, this is not the only one.
    • How about Custom_Item, Customizable_Item or Placeholder_Item?

I like both Cutomizable_Item and Placeholder_Item with a slight preference for Placeholder_Item.

Jan 29 2019, 4:03 AM · efl
SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

about the grid... content_item can be useful, but default item, they might need different visualization in grid actaully.
the idea you told me can reduce the useless repeatation of item classes, so in some ways, I agreed.
we can go the common item styles,
Efl.Ui.Default_Item
Efl.Ui.Content_Item
Efl.Ui.Title_Item
(note: we cannot go with "View" term cause it still used in Efl.Ui.List and Efl.Ui.Grid)
but I think internally they might checking who is my parent class and find different edje styles based on parent class, like,
efl/list_item:default
efl/grid_item:default
efl/tree_item:default
in the edc styles.

I very much like the idea of relying on the parent class at creation time to define the edc style. Still it might be tricky to manage to do that as the style is provided by the model and the model doesn't see the parent class. We could have a dedicated model for each type of View that generate the proper style information. If you have an idea on how to implement this, I will love it as I really think having a limited amount of item class would be best.

after this dicussion,
i'll abandon this patch and recreate / split new patches with

Could you use git phab in the future? It is easier to work on bigger series of patch with it.

rename empty_item to content_item(is this name okay?)

This is one of the item that really look like it could be generic for all view. What about efl.ui.view.content_item? For @segfaultxavi, the style of this item is completely neutral, no decoration and can only contain one object inside it.

Jan 29 2019, 3:45 AM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

Thanks @SanghyeonLee ! Now I have it much more clear.
I now also understand that the direction in which the grid grows is controlled by Efl.Ui.Direction, and not by partition_columns or partition_rows. In fact, once you have set the direction, only one partition is needed, and the other is useless, correct?
Then, why don't we just use one partition value?

  • If the direction is horizontal, partition controls the number of rows and matches row_count (except for the rounding).
  • If the direction is vertical, partition controls the number of columns and matches column_count (except for the rounding). If you agree with this, make the changes in the code and I will then propose the docs.
Jan 29 2019, 3:36 AM · efl
SanghyeonLee accepted D7705: elementary: update Efl.Ui.Caching_Factory to rely on Efl.Ui.Widget_Factory for Efl.Ui.Widget..

looks good to me.

Jan 29 2019, 2:57 AM · efl
SanghyeonLee accepted D7704: elementary: add Efl.Ui.Widget_Factory..

Looks good to me.

Jan 29 2019, 2:46 AM · efl
SanghyeonLee requested changes to D7665: elementary: add test for Efl.Ui.Model_Average..

please check the test again.
base_ints breaks in make check.

Jan 29 2019, 2:43 AM · efl
SanghyeonLee accepted D7664: elementary: add a test for Efl.Ui.Model_Exact..

looks good to me.

Jan 29 2019, 2:40 AM · efl