Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (282 w, 2 d)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Thu, Dec 13

SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

@felipealmeida so you want the original way that we dicussed before in Aug? I think you agreed with @cedric 's opinion about dropping that..
I'm not sure i totally understand your opinion so it would be better to explain this with simple pseudo-code or c# examples.

Thu, Dec 13, 9:14 PM · efl: widgets, Restricted Project

Wed, Dec 5

SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

@felipealmeida yes we dropped it. the only one reason I brought it again is our basic agreement of using create event with Efl.Part is now being dropped again and I need any-idea to support item creation in factory with efl.part.
@cedric why can't we just say in the documentation that after setting the class on a generic factory, it will follow that class binding capability I'm not sure I understand correctly,
this line means, we don't expose the efl.part and user set it manually like this,

Wed, Dec 5, 11:55 PM · efl: widgets, Restricted Project

Mon, Dec 3

SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

well we can lock the object or only accept the setting in "Set" function calls.
Similar Concept is used in QT with name of ItemDeligate.

Mon, Dec 3, 12:10 AM · efl: widgets, Restricted Project

Thu, Nov 29

SanghyeonLee added a comment to T7473: Add a create event on Efl.Ui.Factory.

I... also not sure cause create() is asyncronous and this event should be emitted when create() is ready but it looks quite weird that factory event including some model-based information. if it's view side, it make sense that item holding an model information so may be it need to be emitted by view.

Thu, Nov 29, 3:40 AM · Restricted Project, efl: data types, Restricted Project
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

Oh... I missed this task, sorry for late answer.

Thu, Nov 29, 1:37 AM · efl: widgets, Restricted Project

Tue, Nov 27

SanghyeonLee added a comment to T7382: [MVVM] Efl.Ui.View_List Homogenous Support.

To support this, we need new factory which make in List or Grid Item not Layout, which may allow to set size manually without layout_sizing_eval.
factory could support homogeneous_size_set/get().

Tue, Nov 27, 10:32 PM
SanghyeonLee added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

yeah agreed. and we could apply new feature of extendable scroller... like, we read only small range of model and create scroller with this items,
when it reached end of the scroller, we request another bunch of items, like, extending scroller as it's edge.
android and ios and some web site like facebook or twitter already using this kind of scroller concept widely, so we could support this in MVVM level. what do you think about this?

Tue, Nov 27, 10:10 PM
SanghyeonLee added a comment to T7379: [MVVM] Support disabled composite model.

I think this task could be just moved our View Model Helper task. as you mentioned selection as a helper of ViewModel, enable disable is just one kind of pre-defined viewmodel property with some helpers.
for examples if widget is disabled, whole sub item need to be disabled. when the widget turns enabled, all sub item need to be enabled. and also when all sub item is disabled, widget could be disabled..
the helper API could be support this kind of simple works in my thought.

Tue, Nov 27, 10:06 PM
SanghyeonLee added a comment to T7378: [MVVM] Model Composite Features.

well I was think to make it as an proxy model which can user "sort" or "filter" their original model.

Tue, Nov 27, 9:51 PM
SanghyeonLee closed D7370: gengrid : remove elm_access_text_set for code consistancy..
Tue, Nov 27, 3:17 AM · efl
SanghyeonLee requested review of D7370: gengrid : remove elm_access_text_set for code consistancy..
Tue, Nov 27, 3:15 AM · efl

Mon, Nov 26

SanghyeonLee added a comment to T7472: Asynchronous create function in Efl.Ui.Factory.

about D7332,
mostly view will request some bunch of items in one request,
so it would be much nice to get series of them in single event or future, but I don't know how to do this.
maybe your current patch could be thing that we can do best.

Mon, Nov 26, 3:12 AM · efl: data types, Restricted Project
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

But as you mentioned, adding styles in eo is not high priority, then we must find some other way to using Item class easily with Efl.Part infomation.
also we are not a big fan of using styles property on this case,

Mon, Nov 26, 3:09 AM · efl: widgets, Restricted Project
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

Hmm
on the create(),
if we can support some kind of internal item caching by protected method, this will be very helpful for them. I think create() is too big function that might user need some helper APIs that can replace common actions in create() like send signals, pop_cache, evaluate size~.

Mon, Nov 26, 3:00 AM · efl: widgets, Restricted Project

Wed, Nov 21

SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

I'm sorry that I didn't see the details of samples,
but in that case, when create() called by view to list factory, it calls create() to their sub factories?
hmm... could be.
so the liFactory in your sample looks like.. kind of composition factory..
that is what I want to speak.

Wed, Nov 21, 1:28 AM · efl: widgets, Restricted Project
SanghyeonLee added a comment to T7470: [MVVM] Create a ViewModel helper class.

we can support changed event by interface like, Efl.Ui.Observable

Wed, Nov 21, 1:19 AM
SanghyeonLee added a comment to T7469: Find a better name for Efl.Factory.model_connect.

factory_link? or factory_property_link?
I'm also find with that.

Wed, Nov 21, 1:15 AM · Restricted Project, efl

Tue, Nov 20

SanghyeonLee added a comment to T7471: Add an efl.model.property_ready_get and efl.model.properties_ready_get..

looks valid usage for me.

Tue, Nov 20, 4:16 AM · Restricted Project, efl: data types, Restricted Project
SanghyeonLee added a comment to T7472: Asynchronous create function in Efl.Ui.Factory.

is it event or function?
fac.create() is function which will create an class instance directly,
Create_Event will be a event which will be called when factory create an class instace.
so the T7473 and this Task talking about same thing or different one?
I little bit confusing here :)

Tue, Nov 20, 4:16 AM · efl: data types, Restricted Project
SanghyeonLee added a comment to T7473: Add a create event on Efl.Ui.Factory.

so what kind of event information need to be given in this event you think?
I think below three is required..

Tue, Nov 20, 4:13 AM · Restricted Project, efl: data types, Restricted Project

Mon, Nov 19

SanghyeonLee closed D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.
Mon, Nov 19, 9:38 PM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing

Mon, Nov 19, 9:02 PM · efl
SanghyeonLee accepted D7244: efl_ui_theme: Introduce Efl.Ui.Theme class.

Looks good to me.

Mon, Nov 19, 8:53 PM · efl
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

So the problem is... actually we consider the option you suggested before,
but we drop it because,

Mon, Nov 19, 8:39 PM · efl: widgets, Restricted Project
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing commit

Mon, Nov 19, 8:23 PM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

remove view_grid in the theme.

Mon, Nov 19, 2:41 AM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

h://git.enlightenment.org/core/efl

Mon, Nov 19, 2:40 AM · efl
SanghyeonLee added reviewers for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget: cedric, felipealmeida, eagleeye, woohyun.
Mon, Nov 19, 2:38 AM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

update meson build

Mon, Nov 19, 2:11 AM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing with layout renaming and add meson build

Mon, Nov 19, 1:47 AM · efl

Sun, Nov 18

SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

@felipealmeida
though it is possible, it will need more time to implement this, so not a proper target for now. it should be later works i guess.
and also that would be more related with "style"s not "part" properties as I remembered, like user can easily find there styles by looking at pre-built theme classes such as,
Efl.Styles.List.Default;
Efl.Styles.ListItem.Full;

Sun, Nov 18, 10:45 PM · efl: widgets, Restricted Project

Nov 13 2018

SanghyeonLee added a comment to T7457: EO: Synchronize class naming rule.

TBH, I think it doesn't really big different to user side excepts they have to put some dot between the namespaces.
most IDE, if you find Efl.Ui.List, it will show every List* classes regardless of namespaces.
so I'm not strong opinion here, just the only thing I hate is... as @segfaultxavi mentioned, we need to put "Object" or "Widget" for widget class name at the end if we go with namespaces.

Nov 13 2018, 9:47 PM · efl

Nov 12 2018

SanghyeonLee added a comment to T7457: EO: Synchronize class naming rule.

@bu5hm4n @segfaultxavi ,
so you meant layout will be an namespace so every layout based widget will belong to this layout namespace?
like,

Nov 12 2018, 11:42 PM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing

Nov 12 2018, 4:05 AM · efl
SanghyeonLee created T7458: Composite Model renaming.
Nov 12 2018, 4:04 AM
SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.

Yes..actually deadline is now being more urgent, cause there are some plans to using this feature soon.
at least basic factory need to be ready till end of this month and multistyle factory and the other stuff also need to be ready before the end of the year.
I, also have to finish gridview and grid factory beyond this work,
and some Tizen specific class and visual effect need t be ready in deadline so that should be my work also.

Nov 12 2018, 3:58 AM

Nov 8 2018

SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.
  1. Okay.
  2. you meant item factory or image factory? or both of them? If in both case, I think we can remove setModel from factory fully.
  3. yes. so the our idea is basic one and.. if some other requirements comes, let's expand it more.
  4. Okay. not bad actually.
Nov 8 2018, 4:09 AM

Nov 5 2018

SanghyeonLee added a comment to D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

I think its now ready to land.
so remove do not merge tags, and wait for review.

Nov 5 2018, 3:20 AM · efl
SanghyeonLee removed a project from D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget: DO NOT MERGE.
Nov 5 2018, 3:19 AM · efl
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

fix conflicts and rebasing commits

Nov 5 2018, 3:12 AM · efl

Nov 4 2018

SanghyeonLee added a comment to T7405: [MVVM] Multistyle Factory.

We are discussing about new item based on Efl.Ui.List_Item which will have some Efl.Part informations.
I thought we've already had some agreements of using Efl.Part instead of string and connect(),
so I wonder why this subject is repeated again.

Nov 4 2018, 11:56 PM
SanghyeonLee closed T7380: [MVVM] Efl.Ui.Viewlist renaming. as Resolved.

this task was closed by D7234.

Nov 4 2018, 11:09 PM

Nov 2 2018

SanghyeonLee updated the diff for D7234: efl_ui : change efl_ui_view_list to efl_ui_list_view..

Update missing files.

Nov 2 2018, 3:08 AM · efl
SanghyeonLee added reviewers for D7234: efl_ui : change efl_ui_view_list to efl_ui_list_view.: felipealmeida, woohyun, cedric, Hermet.
Nov 2 2018, 3:07 AM · efl
SanghyeonLee requested review of D7234: efl_ui : change efl_ui_view_list to efl_ui_list_view..
Nov 2 2018, 3:05 AM · efl

Nov 1 2018

SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.

hmm... that was previous way and I'm talking about the way of using Efl.Part in Efl.Ui.List_Item with factory create().
this was discussed with @felipealmeida in the last meeting at August.... I'm worried about this conversation was not progressed or shared with you....

Nov 1 2018, 11:23 PM
SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing commit

Nov 1 2018, 10:53 PM · efl
SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.

Here I brought you some sample code of applying multi style factory in the view.

Nov 1 2018, 3:42 AM

Oct 30 2018

SanghyeonLee added a comment to T7405: [MVVM] Multistyle Factory.

One more thing, this task also include the way to get Efl.Class by some predefined class values as like liFac.ClassAdd(Efl.Ui.ListDefaultItem.GetClass(), "item_class", "default");
To make this task possible, it should be pre-implemented.

Oct 30 2018, 9:28 PM
SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.

I like this idea that makes more simple on the user side code. how much time do you think to make this features and apply the models?

Oct 30 2018, 9:24 PM
SanghyeonLee added a comment to T7376: [MVVM] Model Selection Support.

yes as far as I know. and only we need to verifying them. I think we could expose some API for user-convenience.

Oct 30 2018, 4:00 AM
SanghyeonLee added a comment to T7441: [MVVM] Changes to Efl Data Model.

so you meant this propertyGet returns observable value and label will detect the value changes and set the text internally?

Oct 30 2018, 3:57 AM

Oct 24 2018

SanghyeonLee added a comment to T7405: [MVVM] Multistyle Factory.

can you add this idea to the pseudo code or samples of T7441?

Oct 24 2018, 10:15 PM
SanghyeonLee added a comment to T7404: [MVVM] Factory text property handles.

I have to see the sample code about what you talk but, yes, I agree that we need some other interface for getting property values rather than events.

Oct 24 2018, 10:13 PM
SanghyeonLee added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

so the better solution for optimizing is applying homogeous size of items for most useless size calculations.
but though we need to calculate every items in the list,
we could give some trick for them to optimize calculations.

Oct 24 2018, 10:11 PM
SanghyeonLee added a comment to T7379: [MVVM] Support disabled composite model.

sure I agreed. that is why I assign this task more lower priority than selections.

Oct 24 2018, 10:06 PM
SanghyeonLee added a comment to T7377: [MVVM] Model Insertion Features.

I can't understand the issue cases. which case may not guarantee the ordering?
I think if we cannot guarantee the order that we requested,
we should let the user know the failure of inserting by returning errors and do nothing further.

Oct 24 2018, 10:03 PM

Oct 18 2018

SanghyeonLee accepted D7123: gengrid: unset last_focused pointer when focus moved away.

Looks good to me. @YOhoho if you have other opinion please let us know.

Oct 18 2018, 9:47 PM · efl

Oct 15 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

Update grid widget and test / examples

  • update wrong grid item position calculation
  • update grid test with scrolls
  • update grid example to test vertical case with text
Oct 15 2018, 5:28 AM · efl

Oct 12 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

update test cases and themes.

Oct 12 2018, 4:33 AM · efl

Oct 2 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

update efl_ui_grid pack test in the elm_suite and add grid.edc

Oct 2 2018, 1:08 AM · efl

Sep 28 2018

SanghyeonLee closed D6961: edje: call recalc in part_text_get if there is no available text data.
Sep 28 2018, 12:14 AM · efl

Sep 27 2018

SanghyeonLee closed D7114: elm_interface_scrollable: fix using wrong variable..
Sep 27 2018, 11:49 PM · efl
SanghyeonLee updated the test plan for D7114: elm_interface_scrollable: fix using wrong variable..
Sep 27 2018, 11:43 PM · efl

Sep 19 2018

SanghyeonLee closed D7067: efl_ui_tab_pager : Fix type mismatch for calloc.
Sep 19 2018, 12:45 AM · efl
SanghyeonLee accepted D7067: efl_ui_tab_pager : Fix type mismatch for calloc.
Sep 19 2018, 12:39 AM · efl

Sep 18 2018

SanghyeonLee updated the task description for T7405: [MVVM] Multistyle Factory.
Sep 18 2018, 12:19 AM
SanghyeonLee created T7405: [MVVM] Multistyle Factory.
Sep 18 2018, 12:17 AM
SanghyeonLee created T7404: [MVVM] Factory text property handles.
Sep 18 2018, 12:15 AM

Sep 17 2018

SanghyeonLee updated the test plan for D7037: genlist: fix item show/bring in coordinate calculation with zero-sized pan..
Sep 17 2018, 3:55 AM · efl
SanghyeonLee updated the diff for D7037: genlist: fix item show/bring in coordinate calculation with zero-sized pan..

fix typo

Sep 17 2018, 3:53 AM · efl
SanghyeonLee requested review of D7037: genlist: fix item show/bring in coordinate calculation with zero-sized pan..
Sep 17 2018, 3:34 AM · efl
SanghyeonLee updated the diff for D7035: genlist : missing scrollto_bottom condition in item_scroll is fixed..

fix typo

Sep 17 2018, 2:06 AM · efl
SanghyeonLee requested review of D7035: genlist : missing scrollto_bottom condition in item_scroll is fixed..
Sep 17 2018, 2:05 AM · efl
SanghyeonLee updated the diff for D7014: elm_gengrid: fix item_show / bring_in deferred call..

rebasing patch

Sep 17 2018, 1:59 AM · efl

Sep 10 2018

SanghyeonLee assigned T7382: [MVVM] Efl.Ui.View_List Homogenous Support to felipealmeida.
Sep 10 2018, 4:17 AM
SanghyeonLee created T7382: [MVVM] Efl.Ui.View_List Homogenous Support.
Sep 10 2018, 4:16 AM
SanghyeonLee updated the task description for T7381: [MVVM] Efl.Ui.View_List Performance Improvement.
Sep 10 2018, 1:46 AM
SanghyeonLee created T7381: [MVVM] Efl.Ui.View_List Performance Improvement.
Sep 10 2018, 1:38 AM
SanghyeonLee triaged T7380: [MVVM] Efl.Ui.Viewlist renaming. as Wishlist priority.
Sep 10 2018, 1:33 AM
SanghyeonLee created T7379: [MVVM] Support disabled composite model.
Sep 10 2018, 1:28 AM
SanghyeonLee updated the task description for T7378: [MVVM] Model Composite Features.
Sep 10 2018, 1:24 AM
SanghyeonLee updated subscribers of T7378: [MVVM] Model Composite Features.
Sep 10 2018, 1:23 AM
SanghyeonLee triaged T7378: [MVVM] Model Composite Features as Wishlist priority.
Sep 10 2018, 1:23 AM
SanghyeonLee updated subscribers of T7377: [MVVM] Model Insertion Features.
Sep 10 2018, 1:17 AM
SanghyeonLee triaged T7377: [MVVM] Model Insertion Features as TODO priority.
Sep 10 2018, 1:16 AM
SanghyeonLee triaged T7376: [MVVM] Model Selection Support as TODO priority.
Sep 10 2018, 1:11 AM

Sep 9 2018

SanghyeonLee added reviewers for D7014: elm_gengrid: fix item_show / bring_in deferred call.: eagleeye, Hermet.
Sep 9 2018, 11:27 PM · efl
SanghyeonLee added a task to D7014: elm_gengrid: fix item_show / bring_in deferred call.: T7367: Issue while elm_gengrid_item_show..
Sep 9 2018, 11:15 PM · efl
SanghyeonLee added a revision to T7367: Issue while elm_gengrid_item_show.: D7014: elm_gengrid: fix item_show / bring_in deferred call..
Sep 9 2018, 11:15 PM
SanghyeonLee updated the summary of D7014: elm_gengrid: fix item_show / bring_in deferred call..
Sep 9 2018, 11:14 PM · efl
SanghyeonLee updated the test plan for D7014: elm_gengrid: fix item_show / bring_in deferred call..
Sep 9 2018, 11:11 PM · efl
SanghyeonLee requested review of D7014: elm_gengrid: fix item_show / bring_in deferred call..
Sep 9 2018, 11:09 PM · efl

Sep 5 2018

SanghyeonLee added a project to D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget: DO NOT MERGE.
Sep 5 2018, 1:06 AM · efl
SanghyeonLee added a comment to D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

There is the project DO NOT MERGE :)

Sep 5 2018, 1:05 AM · efl
SanghyeonLee updated subscribers of D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.
Sep 5 2018, 1:04 AM · efl
SanghyeonLee added a comment to D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

THIS COMMIT IS ON DEVELOPING PLEASE WAIT UNTIL IT IS READY TO REVIEW

Sep 5 2018, 12:50 AM · efl
SanghyeonLee requested review of D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.
Sep 5 2018, 12:49 AM · efl

Aug 30 2018

SanghyeonLee accepted D6954: elm_interface_scrollable: add 1 space after if keyword.

looks good to me.
it would be better to keep the original author to tracing history but it too obvious fault and we can trace the history under lines.

Aug 30 2018, 10:32 PM · efl
SanghyeonLee added a reviewer for D6952: elm_genlist: item scroll show sould be processed after block calculation: reviewers.
Aug 30 2018, 4:28 AM · efl