Page MenuHomePhabricator

SanghyeonLee (SangHyeon Jade Lee)
#everLEEst

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jul 17 2013, 7:07 PM (292 w, 10 h)
Availability
Available

SangHyeon (Jade) Lee ( everLEEst )

  1. Activity Infomations

Recent Activity

Wed, Feb 13

SanghyeonLee accepted D7863: elementary: make sure Efl.Ui.Average_Model stay alive until the end of a property_set..

looks valid patch for me.

Wed, Feb 13, 11:59 PM · efl
SanghyeonLee updated the diff for D7925: efl_ui : fix infinite loop in efl_ui_exact model.

rebasing and update while to for statement.

Wed, Feb 13, 8:24 PM · efl
SanghyeonLee added a comment to D7925: efl_ui : fix infinite loop in efl_ui_exact model.

this bug is detected by our coverity and I think this is right fix.
also there are some warns about memory leak of cbuf, but it looks reallocation of tbuf, so it looks safe on my view, but I hope you double check it.

Wed, Feb 13, 3:37 AM · efl
SanghyeonLee requested review of D7925: efl_ui : fix infinite loop in efl_ui_exact model.
Wed, Feb 13, 3:35 AM · efl

Tue, Feb 12

SanghyeonLee added a comment to D7912: genlist: fix wrong returns in window tooltip set..

but as you see the code,
in realize case,
it get the return from elm_widget_item_tooltip_window_mode_set which redirect elm_object_tooltip_window_mode_set,
and in elm_tooltip_window_mode_set,
it returns input disable.

Tue, Feb 12, 10:04 PM · efl

Mon, Feb 11

SanghyeonLee added reviewers for D7912: genlist: fix wrong returns in window tooltip set.: Hermet, woohyun, eagleeye, cedric.
Mon, Feb 11, 11:57 PM · efl
SanghyeonLee requested review of D7912: genlist: fix wrong returns in window tooltip set..
Mon, Feb 11, 11:57 PM · efl

Fri, Feb 1

SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

typo

Fri, Feb 1, 2:32 AM · efl
SanghyeonLee accepted D7860: eo: fix efl_isa to work propertly with interfaces.

It works very well. thank you so much :)

Fri, Feb 1, 2:31 AM · efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

oh its wrong patch.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee accepted D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I tested and it fix the problem well :) thank you.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix the dependency file including bugs

Fri, Feb 1, 2:10 AM · efl
SanghyeonLee abandoned D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Fri, Feb 1, 2:07 AM · efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Fri, Feb 1, 2:07 AM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

remove wrong file includes

Fri, Feb 1, 2:04 AM · efl
SanghyeonLee abandoned D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Fri, Feb 1, 2:01 AM · efl
SanghyeonLee requested review of D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Fri, Feb 1, 2:01 AM · efl
SanghyeonLee added a child revision for D7529: efl_ui : rename model connect and factory connect to bind property and factory.: D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Fri, Feb 1, 2:01 AM · efl
SanghyeonLee added a revision to T7627: Support Efl.Ui.Item_Factory: D7859: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Fri, Feb 1, 2:01 AM · efl: mvvm
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
  • eo: Fix efl_isa for class checking of recursively inherited types
Fri, Feb 1, 1:57 AM · efl
SanghyeonLee edited reviewers for D7857: eo: Fix efl_isa for class checking of recursively inherited types, added: q66; removed: QA_Igor.
Fri, Feb 1, 1:50 AM · DO NOT MERGE, efl
SanghyeonLee added a reviewer for D7857: eo: Fix efl_isa for class checking of recursively inherited types: QA_Igor.
Fri, Feb 1, 1:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Do you have a old efl_ui_layout.eo.c arround somewhere in your tree ?

Fri, Feb 1, 1:45 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I think I resolve the problem by recursive calls of efl_isa for mro

Fri, Feb 1, 1:42 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

The issue case is easily found in example of efl_ui_list_view_example_1.c

Fri, Feb 1, 12:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Fri, Feb 1, 12:19 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

looks something wrong in the patch.

Fri, Feb 1, 12:09 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D7857: eo: Fix efl_isa for class checking of recursively inherited types: DO NOT MERGE.
Fri, Feb 1, 12:08 AM · DO NOT MERGE, efl

Thu, Jan 31

SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix unnecessary changes

Thu, Jan 31, 10:00 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix meson build and warnings

Thu, Jan 31, 9:59 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix po file includes

Thu, Jan 31, 9:55 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

fix meson build error

Thu, Jan 31, 9:50 PM · efl
SanghyeonLee added a parent revision for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view.: D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Thu, Jan 31, 8:15 PM · efl
SanghyeonLee added a child revision for D7529: efl_ui : rename model connect and factory connect to bind property and factory.: D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Thu, Jan 31, 8:15 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

dependency update

Thu, Jan 31, 8:14 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

depends on D7529
renew the patch with inherit layout factory.

Thu, Jan 31, 8:12 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

renew the patches.
adding new two interfaces,

Thu, Jan 31, 3:59 AM · efl
SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

Keep in mind that all the above are for Eina and Legacy methods, apparently we haven't introduced any insertion method in the Unified API yet, so this will be the first one and we can decide to change the rules :)

ALSO, don't forget to document how to insert easily, when you don't care about the insertion point. I am assuming you will use relative_to == NULL? The current diff does not specify this.

Thu, Jan 31, 1:12 AM · efl
SanghyeonLee abandoned D4983: genlist: add reorder mode start/stop for key reordering action.
Thu, Jan 31, 1:03 AM · efl
SanghyeonLee abandoned D6574: efl_ui_scroll : apply finalize and invalidate object..
Thu, Jan 31, 1:02 AM · efl

Wed, Jan 30

SanghyeonLee closed D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:59 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

fix few typo which was generated by conflict resolving

Wed, Jan 30, 9:28 PM · DO NOT MERGE, efl
SanghyeonLee updated the summary of D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:16 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch and resolve conflict

Wed, Jan 30, 9:14 PM · DO NOT MERGE, efl
SanghyeonLee closed D7665: elementary: add test for Efl.Ui.Model_Average..
Wed, Jan 30, 6:09 PM · efl
SanghyeonLee accepted D7665: elementary: add test for Efl.Ui.Model_Average..

Looks good to me.

Wed, Jan 30, 5:18 PM · efl
SanghyeonLee added a comment to D7665: elementary: add test for Efl.Ui.Model_Average..
  CC       tests/elementary/tests_elementary_efl_ui_suite-efl_ui_suite.o
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_suite.c:5:
../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Text is not available yet without Elementary.h
   ^~~~~~~
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_suite.c:5:
../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Multibutton is not available yet without Elementary.h
   ^~~~~~~
  CC       tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_model.c:5:
../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Text is not available yet without Elementary.h
   ^~~~~~~
In file included from tests/elementary/efl_ui_suite.h:6:0,
                 from tests/elementary/efl_ui_model.c:5:
../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp]
 # warning Efl.Ui.Multibutton is not available yet without Elementary.h
   ^~~~~~~
tests/elementary/efl_ui_model.c:13:4: error: initializer element is not constant
    base_ints[0] * 3 * 3,
    ^~~~~~~~~
tests/elementary/efl_ui_model.c:13:4: note: (near initialization for ‘expected_average[0]’)
tests/elementary/efl_ui_model.c:14:4: error: initializer element is not constant
    ((base_ints[0] * 3 + base_ints[1] * 3) * 3) / 2,
    ^
tests/elementary/efl_ui_model.c:14:4: note: (near initialization for ‘expected_average[1]’)
tests/elementary/efl_ui_model.c:15:4: error: initializer element is not constant
    base_ints[0] * 3 + base_ints[1] * 3 + base_ints[2] * 3
    ^~~~~~~~~
tests/elementary/efl_ui_model.c:15:4: note: (near initialization for ‘expected_average[2]’)
Makefile:47459: recipe for target 'tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o' failed
make[4]: *** [tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o] Error 1
Makefile:55008: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
Makefile:54316: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
Makefile:55012: recipe for target 'check' failed
make[1]: *** [check] Error 2
Makefile:3015: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1
Wed, Jan 30, 2:54 AM · efl

Tue, Jan 29

SanghyeonLee updated subscribers of D7682: efl_ui_grid : apply relative size feature and row/column count..

one better idea that @smohanty suggested,

Tue, Jan 29, 5:21 PM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

Thanks a lot for your patience, @SanghyeonLee, and for a very clear explanation. With pictures!
Unfortunately, I do not think we can add pictures to the EO docs yet :)

I understand now that both partition_rows and partition_columns are needed.
My only comment now is that maybe row_count could be renamed total_row_count to make it clear that it includes the rows outside the viewport. What do you think?

Tue, Jan 29, 5:01 PM · efl
SanghyeonLee closed D7829: efl_ui_list_view: Handling failed memory allocation.
Tue, Jan 29, 4:47 PM · efl
SanghyeonLee accepted D7829: efl_ui_list_view: Handling failed memory allocation.

looks good to me.

Tue, Jan 29, 4:33 PM · efl
SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

yeah naming is really difficult thing always :p
though I like the Swallow_Item idea,
but if you two are voted Placeholder, so I'll go with it.

Tue, Jan 29, 4:41 AM · efl
SanghyeonLee added a comment to T7659: Fix efl_part issues in C#.

@cedric, I don't remember exactly which case have some conflict problem regarding this,
so could you give some example to explain the problem?
this would very helpful to understand problem for @woohyun and @Jaehyun_Cho

Tue, Jan 29, 4:30 AM · efl: mvvm
SanghyeonLee updated subscribers of T7659: Fix efl_part issues in C#.
Tue, Jan 29, 4:19 AM · efl: mvvm
SanghyeonLee updated subscribers of T7659: Fix efl_part issues in C#.
Tue, Jan 29, 4:18 AM · efl: mvvm
SanghyeonLee added a parent task for T7659: Fix efl_part issues in C#: T5354: Provide infrastructure for MVVM.
Tue, Jan 29, 4:18 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7659: Fix efl_part issues in C#.
Tue, Jan 29, 4:18 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a comment to T6360: EO: Item and Item_List API's.

shouldn't we abandon or resolve this item?

Tue, Jan 29, 4:14 AM · efl (efl-1.22), efl: mvvm, efl: widgets
SanghyeonLee added a comment to T7658: [MVVM] create Efl.Ui.Item_View and infrastructures for common item based view widgets..

we can hiding them in private class, but for making list and grid, tree view with generic interfaces,
making it as common class or interface will be much easier for implement them.
also about layouter,
I think currently it need to be private cause we do not decide which structure we will exposed for model handing on the view,
but the final goal in my thought, it would be better to publish them and user can customize this layouter as what they really wanted.

Tue, Jan 29, 4:12 AM
SanghyeonLee updated subscribers of D7474: efl_ui : update item classes and apply efl_part..

OK, thanks @cedric for the explanation.

These are my two cents:

  • Regarding Empty_Item or Content_Item:
    • I do not like Empty because it looks like it has nothing inside.
    • I do not like Content because all other items have content too, this is not the only one.
    • How about Custom_Item, Customizable_Item or Placeholder_Item?

I like both Cutomizable_Item and Placeholder_Item with a slight preference for Placeholder_Item.

Tue, Jan 29, 4:03 AM · efl
SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

about the grid... content_item can be useful, but default item, they might need different visualization in grid actaully.
the idea you told me can reduce the useless repeatation of item classes, so in some ways, I agreed.
we can go the common item styles,
Efl.Ui.Default_Item
Efl.Ui.Content_Item
Efl.Ui.Title_Item
(note: we cannot go with "View" term cause it still used in Efl.Ui.List and Efl.Ui.Grid)
but I think internally they might checking who is my parent class and find different edje styles based on parent class, like,
efl/list_item:default
efl/grid_item:default
efl/tree_item:default
in the edc styles.

I very much like the idea of relying on the parent class at creation time to define the edc style. Still it might be tricky to manage to do that as the style is provided by the model and the model doesn't see the parent class. We could have a dedicated model for each type of View that generate the proper style information. If you have an idea on how to implement this, I will love it as I really think having a limited amount of item class would be best.

after this dicussion,
i'll abandon this patch and recreate / split new patches with

Could you use git phab in the future? It is easier to work on bigger series of patch with it.

rename empty_item to content_item(is this name okay?)

This is one of the item that really look like it could be generic for all view. What about efl.ui.view.content_item? For @segfaultxavi, the style of this item is completely neutral, no decoration and can only contain one object inside it.

Tue, Jan 29, 3:45 AM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

Thanks @SanghyeonLee ! Now I have it much more clear.
I now also understand that the direction in which the grid grows is controlled by Efl.Ui.Direction, and not by partition_columns or partition_rows. In fact, once you have set the direction, only one partition is needed, and the other is useless, correct?
Then, why don't we just use one partition value?

  • If the direction is horizontal, partition controls the number of rows and matches row_count (except for the rounding).
  • If the direction is vertical, partition controls the number of columns and matches column_count (except for the rounding). If you agree with this, make the changes in the code and I will then propose the docs.
Tue, Jan 29, 3:36 AM · efl
SanghyeonLee accepted D7705: elementary: update Efl.Ui.Caching_Factory to rely on Efl.Ui.Widget_Factory for Efl.Ui.Widget..

looks good to me.

Tue, Jan 29, 2:57 AM · efl
SanghyeonLee accepted D7704: elementary: add Efl.Ui.Widget_Factory..

Looks good to me.

Tue, Jan 29, 2:46 AM · efl
SanghyeonLee requested changes to D7665: elementary: add test for Efl.Ui.Model_Average..

please check the test again.
base_ints breaks in make check.

Tue, Jan 29, 2:43 AM · efl
SanghyeonLee accepted D7664: elementary: add a test for Efl.Ui.Model_Exact..

looks good to me.

Tue, Jan 29, 2:40 AM · efl
SanghyeonLee accepted D7663: elementary: add a test for Efl.Ui.Model_Homogeneous..

check tested.
looks good to me.

Tue, Jan 29, 2:35 AM · efl
SanghyeonLee accepted D7662: elementary: enable efl_ui_suite tests for meson build..

looks good.
some efl_ui related test need to be rearranged now.

Tue, Jan 29, 2:29 AM · efl
SanghyeonLee accepted D7661: elementary: add internal Efl_Ui_Model_Average..

looks good to me.

Tue, Jan 29, 2:18 AM · efl
SanghyeonLee accepted D7660: elementary: add internal Efl_Ui_Model_Exact..

looks good to me.

Tue, Jan 29, 2:11 AM · efl
SanghyeonLee requested changes to D7659: elementary: add internal Efl_Ui_Model_Homogeneous..

I think code looks good and build/check works well.
only the meson build may not proper to fix in this commit.

Tue, Jan 29, 2:05 AM · efl
SanghyeonLee accepted D7658: elementary: add internal Efl_Ui_Model_Size..

looks good to me.

Tue, Jan 29, 1:48 AM · efl
SanghyeonLee accepted D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..

It looks good to me. build, check all passed.
but one thing I have a question...
we remove boolean_child and select_child,
don't we need to remove container_item also?

Tue, Jan 29, 1:37 AM · efl

Mon, Jan 28

SanghyeonLee added a comment to D7812: efl_ui : fix minor defects from converity check..

I know this is already committed but, in the future, please do not commit commented code.

Mon, Jan 28, 11:29 PM · efl
SanghyeonLee closed D7812: efl_ui : fix minor defects from converity check..
Mon, Jan 28, 10:57 PM · efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebase patch

Mon, Jan 28, 10:51 PM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7811: efl_model: prevent NULL pointer access.
Mon, Jan 28, 10:45 PM · efl
SanghyeonLee requested review of D7812: efl_ui : fix minor defects from converity check..
Mon, Jan 28, 10:40 PM · efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

update patch. fix build errors

Mon, Jan 28, 10:13 PM · DO NOT MERGE, efl

Sat, Jan 26

SanghyeonLee added a project to D7533: efl_model : rename all efl_model based classes.: DO NOT MERGE.
Sat, Jan 26, 5:42 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7533: efl_model : rename all efl_model based classes..

Current diff may not buildable yet but i updated for the backup of my task.

Maybe add the "DO NOT MERGE" tag while it is not finished?

Sat, Jan 26, 5:41 AM · DO NOT MERGE, efl

Fri, Jan 25

SanghyeonLee added a comment to D7533: efl_model : rename all efl_model based classes..

Current diff may not buildable yet but i updated for the backup of my task.

Fri, Jan 25, 5:22 AM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch with depending on all cedric's patch on top of
D7705

Fri, Jan 25, 5:06 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..

It looks dependencies broken in arc patch, so it tried to cherry-pick D7649 which was already merged.
it may need to abandon some related patches I guess though still we can stack the patches with skipping dependencies.

Fri, Jan 25, 3:04 AM · efl
SanghyeonLee requested changes to D7657: ecore: correct Efl.Model_Composite_Selection test to use the new property name..

I think this patch need to be abandoned as it already merged in D7654

Fri, Jan 25, 2:58 AM · efl
SanghyeonLee requested changes to D7656: ecore: simplify Efl.Model_Composite_Selection by relying on parent class..

I think this patch need to be abandoned as it already merged in D7654

Fri, Jan 25, 2:54 AM · efl
SanghyeonLee requested changes to D7655: ecore: simplify Efl.Model_Composite_Boolean by relying on parent class..

I think this patch need to be abandoned as it already merged in D7654

Fri, Jan 25, 2:54 AM · efl
SanghyeonLee updated the summary of D7653: ecore: fix memory leak when shutding down the application..
Fri, Jan 25, 2:33 AM · efl
SanghyeonLee updated the summary of D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..
Fri, Jan 25, 2:33 AM · efl
SanghyeonLee updated the summary of D7651: eina: add tests for the new Eina_Value convert functions..
Fri, Jan 25, 2:32 AM · efl
SanghyeonLee updated the summary of D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..
Fri, Jan 25, 2:32 AM · efl
SanghyeonLee added a comment to D7654: ecore: add an index property on Efl.Model_Composite and handle children_slice_get..

We are now stepping over each other's diffs so I'll propose doc changes in a later commit :)

One last comment regarding capitalization of property names. You now have different notations: "Child.Index" but "child.selected", "self.selected"...
To aid you in the decision, part names and event names are lower case :D

Fri, Jan 25, 2:01 AM · efl

Thu, Jan 24

SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

I have a few comments:

  • partition seems a bit unclear to me, I would call it visible_rows and visible_columns.
Thu, Jan 24, 6:03 PM · efl
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7658: [MVVM] create Efl.Ui.Item_View and infrastructures for common item based view widgets..
Thu, Jan 24, 3:43 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7658: [MVVM] create Efl.Ui.Item_View and infrastructures for common item based view widgets.: T5354: Provide infrastructure for MVVM.
Thu, Jan 24, 3:43 AM
SanghyeonLee created T7658: [MVVM] create Efl.Ui.Item_View and infrastructures for common item based view widgets..
Thu, Jan 24, 3:42 AM
SanghyeonLee added a comment to D7724: efl_ui_list_view: Hide SegArray and PreciseLayouter.

one doubt about this...........
shouldn't we hide the extern struct Efl.Ui.Item_View_Seg_Array_Node also in efl_ui_list_view_types.eot?

Thu, Jan 24, 1:50 AM · efl
SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

hmm but still there are some doubt about idea...
what if we need different efl_part in different parent classes?
I think we still need list_item and grid_item for these cases,
and I'm agreed with combined item class for what we can provide.
same style name, same part properties..

Thu, Jan 24, 1:12 AM · efl

Wed, Jan 23

SanghyeonLee added a comment to D7474: efl_ui : update item classes and apply efl_part..

about the grid... content_item can be useful, but default item, they might need different visualization in grid actaully.
the idea you told me can reduce the useless repeatation of item classes, so in some ways, I agreed.
we can go the common item styles,
Efl.Ui.Default_Item
Efl.Ui.Content_Item
Efl.Ui.Title_Item
but I think internally they might checking who is my parent class and find different edje styles based on parent class, like,
efl/list_item:default
efl/grid_item:default
efl/tree_item:default
in the edc styles.

Wed, Jan 23, 9:34 PM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

yes I think it might need @segfaultxavi 's review about the documents.

Wed, Jan 23, 9:18 PM · efl