- User Since
- Jul 17 2013, 7:07 PM (300 w, 11 h)
code looks good, only few question about uint64 and exclusive term.
code looks fine but as I remembered there are some question about uint64... do we really need to use uint64 not general integer?
looks good to me,
@segfaultxavi do you have other opinion?
Mon, Apr 8
so do you think we need to restrict factory input as Efl.Ui.Item_Factory only? or just change the property name as factory not item_factory?
I like the first idea, cause every code of list and grid will guess the object created from factory is Efl.Ui.Item not other class,
so if it comes something else, it is really hard to handle exceptions.
this patch is abandoned after create new patch D8582.
rerfactoring on item default and renaming empty item will be continously updated.
I was told about D8568
fix typo and examples
remove unnecessary po changes.
Sun, Apr 7
sorry I was design it and I have a plan to update this to using Efl.Ui.Item_Part_Icon and End not generating same part repeatly, but in here I was thinking that doc need to be updated,
can you update depended patch?
is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.
Mon, Mar 25
Sun, Mar 24
sorry for late actions.
sorry for late review.
on the purpose of removing unnecessary order setup, this looks valid patch.
Thu, Mar 21
@zmike, we have some testsuite for this elm_object_orientation_mode_disabled_set and it fails after your refactoring of this method.
the code looks never change once it disabled in non-layout case, I think it need to be fixed like this.
Mar 10 2019
this is not a final version, only buildable one. need to figure it out which one we need and not in both of grid view and list view
Feb 26 2019
Feb 25 2019
remove unwanted files
it looks zmike disagreed and I respect orignal authors opinion.
I really not sure but if we goes the event name as properties,changed, it sound more natural to change the other event name as properties,bound?
I mostly prefer the singular name on the APIs and Events, but unity is also very important thing in my thought.
is this property bound only come with single property not a list?
then it sound correct.
I'll change my review status after you pointing what is right.
Feb 13 2019
looks valid patch for me.
rebasing and update while to for statement.
this bug is detected by our coverity and I think this is right fix.
also there are some warns about memory leak of cbuf, but it looks reallocation of tbuf, so it looks safe on my view, but I hope you double check it.
Feb 12 2019
but as you see the code,
in realize case,
it get the return from elm_widget_item_tooltip_window_mode_set which redirect elm_object_tooltip_window_mode_set,
and in elm_tooltip_window_mode_set,
it returns input disable.
Feb 11 2019
Feb 1 2019
It works very well. thank you so much :)
oh its wrong patch.
I tested and it fix the problem well :) thank you.
fix the dependency file including bugs
remove wrong file includes
- eo: Fix efl_isa for class checking of recursively inherited types
Do you have a old efl_ui_layout.eo.c arround somewhere in your tree ?
I think I resolve the problem by recursive calls of efl_isa for mro
The issue case is easily found in example of efl_ui_list_view_example_1.c
looks something wrong in the patch.
Jan 31 2019
fix unnecessary changes
fix meson build and warnings
fix po file includes
fix meson build error
depends on D7529
renew the patch with inherit layout factory.
renew the patches.
adding new two interfaces,
Keep in mind that all the above are for Eina and Legacy methods, apparently we haven't introduced any insertion method in the Unified API yet, so this will be the first one and we can decide to change the rules :)
ALSO, don't forget to document how to insert easily, when you don't care about the insertion point. I am assuming you will use relative_to == NULL? The current diff does not specify this.
Jan 30 2019
fix few typo which was generated by conflict resolving
rebasing patch and resolve conflict
Looks good to me.
CC tests/elementary/tests_elementary_efl_ui_suite-efl_ui_suite.o In file included from tests/elementary/efl_ui_suite.h:6:0, from tests/elementary/efl_ui_suite.c:5: ../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp] # warning Efl.Ui.Text is not available yet without Elementary.h ^~~~~~~ In file included from tests/elementary/efl_ui_suite.h:6:0, from tests/elementary/efl_ui_suite.c:5: ../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp] # warning Efl.Ui.Multibutton is not available yet without Elementary.h ^~~~~~~ CC tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o In file included from tests/elementary/efl_ui_suite.h:6:0, from tests/elementary/efl_ui_model.c:5: ../src/lib/elementary/Efl_Ui.h:195:3: warning: #warning Efl.Ui.Text is not available yet without Elementary.h [-Wcpp] # warning Efl.Ui.Text is not available yet without Elementary.h ^~~~~~~ In file included from tests/elementary/efl_ui_suite.h:6:0, from tests/elementary/efl_ui_model.c:5: ../src/lib/elementary/Efl_Ui.h:213:3: warning: #warning Efl.Ui.Multibutton is not available yet without Elementary.h [-Wcpp] # warning Efl.Ui.Multibutton is not available yet without Elementary.h ^~~~~~~ tests/elementary/efl_ui_model.c:13:4: error: initializer element is not constant base_ints * 3 * 3, ^~~~~~~~~ tests/elementary/efl_ui_model.c:13:4: note: (near initialization for ‘expected_average’) tests/elementary/efl_ui_model.c:14:4: error: initializer element is not constant ((base_ints * 3 + base_ints * 3) * 3) / 2, ^ tests/elementary/efl_ui_model.c:14:4: note: (near initialization for ‘expected_average’) tests/elementary/efl_ui_model.c:15:4: error: initializer element is not constant base_ints * 3 + base_ints * 3 + base_ints * 3 ^~~~~~~~~ tests/elementary/efl_ui_model.c:15:4: note: (near initialization for ‘expected_average’) Makefile:47459: recipe for target 'tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o' failed make: *** [tests/elementary/tests_elementary_efl_ui_suite-efl_ui_model.o] Error 1 Makefile:55008: recipe for target 'check-am' failed make: *** [check-am] Error 2 Makefile:54316: recipe for target 'check-recursive' failed make: *** [check-recursive] Error 1 Makefile:55012: recipe for target 'check' failed make: *** [check] Error 2 Makefile:3015: recipe for target 'check-recursive' failed make: *** [check-recursive] Error 1
Jan 29 2019
one better idea that @smohanty suggested,
looks good to me.
yeah naming is really difficult thing always :p
though I like the Swallow_Item idea,
but if you two are voted Placeholder, so I'll go with it.
@cedric, I don't remember exactly which case have some conflict problem regarding this,
so could you give some example to explain the problem?
this would very helpful to understand problem for @woohyun and @Jaehyun_Cho
shouldn't we abandon or resolve this item?
we can hiding them in private class, but for making list and grid, tree view with generic interfaces,
making it as common class or interface will be much easier for implement them.
also about layouter,
I think currently it need to be private cause we do not decide which structure we will exposed for model handing on the view,
but the final goal in my thought, it would be better to publish them and user can customize this layouter as what they really want.
looks good to me.
Looks good to me.
please check the test again.
base_ints breaks in make check.
looks good to me.