Page MenuHomePhabricator

segfaultxavi (Xavi Artigas)Administrator
Research

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 11 2017, 3:04 AM (118 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

segfaultxavi added a comment to T8577: Rich Text Editor Example.

Yeah, we should take a look at ecrire, for sure. Unfortunately it uses legacy API (and does not seem to work very well right now).

Fri, Jan 17, 1:35 AM
segfaultxavi added a comment to T8567: Efl.Text.Cursor_Move_Type.

๐Ÿ‘

Fri, Jan 17, 1:10 AM ยท efl: language bindings, efl: api
segfaultxavi added a comment to D11114: Revert "csharp: Property Indexer implementation".

After reading that guideline, I see that indexers are only discouraged in some cases.
Index through a tuple to fit multiple keys indeed looks very convoluted and should be avoided.
However, I think indexers are still useful in simple cases (like when there is only one key, and it's a string). Can we consider keeping them for these cases?

Fri, Jan 17, 1:09 AM ยท efl

Yesterday

segfaultxavi added a comment to D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.

So let's proceed with the rename and keep the c_prefix.

Thu, Jan 16, 8:32 AM ยท efl
segfaultxavi closed D11112: docs: Give some love to progress bar docs..
Thu, Jan 16, 7:37 AM ยท efl
segfaultxavi added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

Yeah, we have to be consistent with whatever we decide in D11108.

Thu, Jan 16, 7:15 AM ยท DO NOT MERGE, efl
segfaultxavi requested review of D11112: docs: Give some love to progress bar docs..
Thu, Jan 16, 7:05 AM ยท efl
segfaultxavi added a comment to T8501: Efl.Ui.Progressbar.

API-wise, there's not much more to discuss. Look right.

Thu, Jan 16, 3:00 AM ยท efl: api, efl (efl-1.24)
segfaultxavi added a comment to T8570: Efl.Text_Range.

If we turn this into a generic int range struct, its proper place would probably be Eina.
I also want to hear @cedric's opinion since he knows more Eina.

Thu, Jan 16, 2:56 AM ยท efl: language bindings, efl: api
segfaultxavi accepted D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

Yes, this looks OK.

Thu, Jan 16, 2:52 AM ยท efl
segfaultxavi added a comment to D11108: efl_canvas_animation: rename Animation_XXX to XXX_Animation.

I agree with the rename. This makes these classes consistent with Efl.Accelerate_Interpolator, for example.

Thu, Jan 16, 2:50 AM ยท efl
segfaultxavi added a comment to T8572: efl.canvas.rectangle.

There's not much to stabilize here, the API is empty.
I think this is good to go :)

Thu, Jan 16, 2:37 AM ยท efl: api

Wed, Jan 15

segfaultxavi closed D11094: evas_gesture: change getter methods to read-only properties.
Wed, Jan 15, 5:40 AM ยท efl
segfaultxavi added a commit to T8557: Pending work on gesture event structs: rEFL090df4331b9c: evas_gesture: change getter methods to read-only properties.
Wed, Jan 15, 5:40 AM ยท efl: api, efl: docs, efl (efl-1.24)
segfaultxavi accepted D11094: evas_gesture: change getter methods to read-only properties.

Builds and passes tests. Thanks for updating the docs too!

Wed, Jan 15, 5:40 AM ยท efl
segfaultxavi added a comment to T8577: Rich Text Editor Example.

This looks like a fun thing to implement! I suggest we use the Text Editor example as a base.
In this way, we can create a cumulative tutorial in the future (that builds on top of the Text Editor tutorial, when we have one).

Wed, Jan 15, 5:27 AM
segfaultxavi closed D11105: efl_text_cursor: update doc for Efl.Text.Cursor_Type.
Wed, Jan 15, 5:19 AM ยท efl
segfaultxavi added a commit to T8566: Efl.Text.Cursor_Type: rEFLe1a329a3e90e: efl_text_cursor: update doc for Efl.Text.Cursor_Type.
Wed, Jan 15, 5:19 AM ยท efl: language bindings, efl: api
segfaultxavi accepted D11105: efl_text_cursor: update doc for Efl.Text.Cursor_Type.

I just did some tweaks :)

Wed, Jan 15, 5:19 AM ยท efl
segfaultxavi added a comment to D11102: efl.ui.textbox: part implementation comments clean up!.

I think so too.

Wed, Jan 15, 5:13 AM ยท efl

Tue, Jan 14

segfaultxavi accepted D11095: efl.text.cursor: movement types rename.

Looks good to me!
Builds and passes tests.

Tue, Jan 14, 6:13 AM ยท efl
segfaultxavi added a comment to T8566: Efl.Text.Cursor_Type.

These names look clear enough to me. The docs need improvement.
For example, what @ali.alzyod wrote in the task description could be used directly as docs.

Tue, Jan 14, 2:45 AM ยท efl: language bindings, efl: api
segfaultxavi added a comment to T8522: Efl.Ui.Textbox class.

I still don't know how factories work, I cannot help much here.
If you say it is not urgent, we can keep it beta, sure.

Tue, Jan 14, 2:36 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8570: Efl.Text_Range.

Yeah, Efl.Ui.Range_Display is totally unrelated, and I don't think we have any other class that serves this purpose.

Tue, Jan 14, 2:33 AM ยท efl: language bindings, efl: api
segfaultxavi added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

GOLDEN**

Your comment does not help the project in any way.
Please bear in mind that very few of us are native English speakers and we all have to make an effort to understand each other.
Typos in code or documentation should be mercilessly pointed out and corrected. There's no point in bringing up typos in phabricator discussions, though. We're all bound to make them!

Tue, Jan 14, 12:55 AM ยท efl
segfaultxavi added a comment to T8567: Efl.Text.Cursor_Move_Type.

This enum has already been reviewed but I think it is still not consistent with the rest of the API.
We should not use shortened words: char->character, prev->previous, etc.

Tue, Jan 14, 12:39 AM ยท efl: language bindings, efl: api

Mon, Jan 13

segfaultxavi added a comment to D11010: efl_ui_spin_button: add tests for direct input feature.

Still failing for me, same place :(

../src/tests/elementary/efl_ui_test_spin_button.c:222:E:efl_ui_spin_button:spin_direct_text_input:0: (after this point) Received signal 11 (Segmentation fault)
../src/tests/elementary/efl_ui_test_spin_button.c:222:E:efl_ui_spin_button:spin_direct_text_input_comma_value:0: (after this point) Received signal 11 (Segmentation fault)
Mon, Jan 13, 11:34 AM ยท efl
segfaultxavi added a comment to D11080: efl/player: merge in and rework events from vg_animation.

Docs and new events look OK to me.

Mon, Jan 13, 10:08 AM ยท efl
segfaultxavi added a comment to T8476: efl_ui_animation_view.

I'm OK with stating in the video docs that autorepeat is ignored. Then again, it does not look very hard to implement either...

Mon, Jan 13, 10:05 AM ยท efl (efl-1.24), efl: api
segfaultxavi accepted D11066: efl.input.text: add variation enums + remove @since word.

Looks good to me.
Builds and passes tests.

Mon, Jan 13, 7:33 AM ยท efl
segfaultxavi added a comment to T8557: Pending work on gesture event structs.

I'm not talking about Efl.Canvas.Gesture. This one is OK. I'm talking about the derived classes: Efl.Canvas.Gesture_Flick, Efl.Canvas.Gesture_Zoom, etc.
Some of these derived classes have methods called *_get, which look to me like they should be readonly properties.

Mon, Jan 13, 5:44 AM ยท efl: api, efl: docs, efl (efl-1.24)
segfaultxavi closed D11073: efl_gesture: rename Efl.Gesture.Events to Efl.Canvas.Gesture_Events.
Mon, Jan 13, 5:31 AM ยท efl
segfaultxavi accepted D11073: efl_gesture: rename Efl.Gesture.Events to Efl.Canvas.Gesture_Events.

Makes a lot of sense to me.
Builds and passes tests.

Mon, Jan 13, 5:30 AM ยท efl
segfaultxavi added a comment to D11067: efl.ui.textbox: legacy cleanup.

For the future, "legacy cleanup" sounds like you are cleaning legacy stuff (like removing methods, for example). A more fitting title would be "Use Unified API instead of Legacy".
It's just a minor detail, but it helps when browsing lots of commits and you only have time to read the summary :)

Mon, Jan 13, 5:12 AM ยท efl
segfaultxavi accepted D11074: eina_types: declare unicode type stable.

Can't see anything wrong with this, right?

Mon, Jan 13, 5:02 AM ยท efl
segfaultxavi requested changes to D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

We're still discussing if some of these properties (like looping) belong here or to the Player interface, right?

Mon, Jan 13, 2:52 AM ยท efl
segfaultxavi added a comment to T8533: Text Interfaces methods & properties renaming.

I would close this task and create new ones if we need more renames (I DO think we need more renames, but that's being discussed somewhere else).

Mon, Jan 13, 2:48 AM ยท efl: api
segfaultxavi added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

efl_canvas_textblock_style_apply(obj, "strikethrough=single") is not valid.
(strikethrough only works with "on" or "off")
efl_canvas_textblock_style_apply(obj, "strikethrough_type=single") is available.

We should fix this!
We can discuss if the properties and the attributes should have the same name, but the values they accept should be absolutely the same!
I think the correct ones are the ones in the enums, and we should modify the ones in the attributes (and the style_apply docs).

Mon, Jan 13, 2:41 AM ยท efl
segfaultxavi added a comment to T8450: efl.divisor_interpolator.

Thanks for pointing this out, @Jaehyun_Cho!

Mon, Jan 13, 2:18 AM ยท efl: api, efl (efl-1.24)

Sun, Jan 12

segfaultxavi requested changes to D11066: efl.input.text: add variation enums + remove @since word.
Sun, Jan 12, 3:14 AM ยท efl

Sat, Jan 11

segfaultxavi added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

I am not sure what are you trying to accomplish here.
Almost all EO properties related to text style are available as format strings:
For example, you have efl_text_strikethrough_type_set(obj, EFL_TEXT_STYLE_STRIKETHROUGH_TYPE_SINGLE) and also efl_canvas_textblock_style_apply(obj, "strikethrough=single").
I agree the names are sometimes slightly different. But I like it this way, because the C API is meant to be concise (In the above example, "this is the type of the strikethrough decoration") whereas the format string is meant to be short ("strikethrough=single" is short and clear).
Adding both options to the formatting string I think will be confusing... We would need to document both!
If you think the slightly different names is a problem, then I would prefer we use the exact same names in both APIs.

Sat, Jan 11, 4:02 AM ยท efl

Fri, Jan 10

segfaultxavi requested review of D11063: docs: A bit more info and formatting for Eina_Process_Cb.
Fri, Jan 10, 8:35 AM ยท efl
segfaultxavi added a child revision for D11062: eina: introduce eina_iterator_process: D11063: docs: A bit more info and formatting for Eina_Process_Cb.
Fri, Jan 10, 8:35 AM ยท efl
segfaultxavi added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

Just for the record, I think that feature is in use in Ecrire, Edi and Enlightenment.
These apps will have to work a bit more to be ported to the Unified interface if we drop this feature.
But OK, we can do it later.

Fri, Jan 10, 12:54 AM ยท efl
segfaultxavi added a comment to T8476: efl_ui_animation_view.

Regarding possible autoplay - autorepeat confusions:
I think autoplay is clear enough, and a common way of referring to this feature.
We can rename autorepeat to looping or repeating. This does not clash with anything else in our current API.

Fri, Jan 10, 12:44 AM ยท efl (efl-1.24), efl: api

Thu, Jan 9

segfaultxavi added a commit to T7855: Efl.Text_Font_Properties: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7934: type Efl.Font.Size: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7935: enum Efl.Text_Font_Weight: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7936: enum Efl.Text_Font_Bitmap_Scalable: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7937: enum Efl.Text_Font_Width: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7938: enum Efl.Text_Font_Slant: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7941: enum Efl.Text_Style_Strikethrough_Type: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7942: enum Efl.Text_Style_Background_Type: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7943: enum Efl.Text_Style_Effect_Type: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7944: enum Efl.Text_Style_Shadow_Direction: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a commit to T7945: enum Efl.Text_Style_Underline_Type: rEFL93c7e7dc8f2a: docs: Improvements to Text API documentation.
Thu, Jan 9, 9:18 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi raised the priority of T8523: Text style quirks from Normal to Showstopper Issues.

The backing inconsistency is important... raising priority again :)

Thu, Jan 9, 8:00 AM ยท efl: api
segfaultxavi updated the task description for T8523: Text style quirks.
Thu, Jan 9, 7:59 AM ยท efl: api
segfaultxavi added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

I still don't know why you're removing the File interface from Textbox.
I never liked this feature very much, but it was already there, so I guess somebody liked it.
Did anybody ask for this removal?

Thu, Jan 9, 6:51 AM ยท efl
segfaultxavi triaged T8557: Pending work on gesture event structs as High priority.
Thu, Jan 9, 6:34 AM ยท efl: api, efl: docs, efl (efl-1.24)
segfaultxavi added a comment to T8541: Efl.Input.Text.

Not a method, but a property, yeah.
I don't like but I can't think of anything else I like more :/

Thu, Jan 9, 4:09 AM ยท efl: language bindings, efl: api
segfaultxavi updated the task description for T8523: Text style quirks.
Thu, Jan 9, 3:21 AM ยท efl: api
segfaultxavi added a comment to T8523: Text style quirks.
According to the initial all_styles_get, wrap seems to default to word, but that's not true.

This should be fixed too

True!

Thu, Jan 9, 3:21 AM ยท efl: api
segfaultxavi lowered the priority of T8523: Text style quirks from Showstopper Issues to Normal.

I think the remaining issues do not affect the API (they are implementation or documentation issues, or the API can be extended later). Therefore I am lowering the priority of this.

Thu, Jan 9, 3:19 AM ยท efl: api
segfaultxavi updated the task description for T8523: Text style quirks.
Thu, Jan 9, 3:17 AM ยท efl: api
segfaultxavi closed D11043: efl.canvas.textblock: rename style strings to have underscore between words.
Thu, Jan 9, 3:17 AM ยท efl
segfaultxavi accepted D11043: efl.canvas.textblock: rename style strings to have underscore between words.

Cool, thanks!

Thu, Jan 9, 3:16 AM ยท efl
segfaultxavi added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

@woohyun, out of curiosity, what are the plans for Access? Is there anybody working on it?

Thu, Jan 9, 3:13 AM ยท efl
segfaultxavi added a comment to T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type.

Good for me!

Thu, Jan 9, 3:10 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi updated the task description for T8523: Text style quirks.
Thu, Jan 9, 3:09 AM ยท efl: api
segfaultxavi accepted D11053: efl/gesture: formatting.

Macro feels_good:

Thu, Jan 9, 3:04 AM ยท efl
segfaultxavi created Image Macro "feels_good".
Thu, Jan 9, 3:02 AM
segfaultxavi added a comment to T8541: Efl.Input.Text.

Hmmmm... adding all variations to Efl.Input_Text.Panel_Layout_Type is an option, but it has some problems.

  • Its size will increase, as you say.
  • It will be harder to detect the "base" type of a layout, since it will involve a lot of if's.
  • We could alleviate the above problem using the lower bits of the enum to store the "base" type (same as it is now), and use the higher bits to store the variation:
Thu, Jan 9, 2:48 AM ยท efl: language bindings, efl: api
segfaultxavi requested changes to D11043: efl.canvas.textblock: rename style strings to have underscore between words.

This commit also changes the way _format_string_get works, and this should be explained in the commit message.
This makes ninja test fail in src/tests/evas/evas_test_textblock.c:4899.
Please always run ninja test before submitting patches.

Thu, Jan 9, 2:39 AM ยท efl
segfaultxavi closed D11058: TEXT_FORMAT_HORIZONTAL_ALIGNMENT_AUTO_TYPE: rename end enum into opposite.
Thu, Jan 9, 2:00 AM ยท efl
segfaultxavi accepted D11058: TEXT_FORMAT_HORIZONTAL_ALIGNMENT_AUTO_TYPE: rename end enum into opposite.
Thu, Jan 9, 2:00 AM ยท efl

Wed, Jan 8

segfaultxavi added a comment to T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type.

Hmmm... yeah, I think I like opposite.

Wed, Jan 8, 10:39 PM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8541: Efl.Input.Text.

It feels weird tu remove functionality that was in legacy. I would keep input_hint as Beta and rename it to input_content_type, but not remove it.

Wed, Jan 8, 10:36 PM ยท efl: language bindings, efl: api
segfaultxavi added a comment to D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..

We better create a task to rename this struct before we forget again and stabilize it :)

Wed, Jan 8, 11:20 AM ยท efl
segfaultxavi added a comment to D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..

This struct is the only thing in the Efl.Gfx.Event namespace... looks weird.

Wed, Jan 8, 10:53 AM ยท efl
segfaultxavi added a comment to T8522: Efl.Ui.Textbox class.

One last comment: I would rename selection_handler_enabled to selection_handles_enabled. I think we should be talking about selection handles (a graphical gadget that helps you select text) and not selection handlers (an abstract "handler" that nobody knows what it does).

Wed, Jan 8, 8:06 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi raised the priority of T8523: Text style quirks from Normal to Showstopper Issues.

There are still some open issues here. Are there any plans to work on them?
I don't think we can stabilize style_apply() if we don't fix some of these issues.
At least I would like to have the multi-word properties separated with underscores.

Wed, Jan 8, 8:02 AM ยท efl: api
segfaultxavi closed D10993: Text_Format_Horizontal_Alignment_Auto_Type: rename enums, and Doc details.
Wed, Jan 8, 7:11 AM ยท efl
segfaultxavi added a comment to T7858: efl.text_markup.

I think so.

Wed, Jan 8, 2:17 AM ยท efl: api, efl: language bindings
segfaultxavi added a comment to T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type.

My only concern should we rename end enum to more relative name

Hmmm... good point. On one hand, I want to have the option to add "end locale" later on, but on the other hand, the most common options are probably auto and end, so they should be kept short and simple.
It's hard for me to decide, since I never used LTR/RTL settings. Do we have anybody with more knowledge on this?
I am tempted to keep end and use locale_end in the future if we need the "inverted locale" option.

Wed, Jan 8, 2:15 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added inline comments to D11034: efl.text.cursor: change to abstract class.
Wed, Jan 8, 1:48 AM ยท efl
segfaultxavi added a comment to T8541: Efl.Input.Text.

Why are these flags? They look like they can be combined, however, most combinations do not make sense.

I guess that "none", "auto_complete", and "sensitive_data" can be combined with the rest. So, the numbers are set with current definition.

According to the EO docs, sensitive_data means that "Typed text should not be stored". Therefore I don't think it makes sense to combine with any autofill option, no? Because, to populate the autofill database you need to store something.
And auto_complete is implied by any of the autofill_* options, no?
This is why I don't understand why this enum is made of combinable flags. I think a regular enum with none, credit_card_expiration_date, etc... is enough.

Wed, Jan 8, 1:44 AM ยท efl: language bindings, efl: api

Tue, Jan 7

segfaultxavi added a comment to T8192: C#: Deprecate EventArgs classes.

So what do we decide?
I already said that providing the event info directly as parameters was nice, but it is true that this breaks ABI. Therefore, I am OK with leaving things as they are now, with EventArgs.

Tue, Jan 7, 7:29 AM ยท efl: language bindings
segfaultxavi added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

Why are these interfaces being removed? I see a lot of code there... @woohyun, is Access not needed anymore?

Tue, Jan 7, 7:07 AM ยท efl
segfaultxavi added a comment to D11034: efl.text.cursor: change to abstract class.

This patch comes from the discussion in D10973#208299. The commit message should explain WHY this patch is needed, besides WHAT it does.

Tue, Jan 7, 7:03 AM ยท efl
segfaultxavi added a comment to D11006: efl_ui/spin_button: fix step clamping.

This is how I always expected step to work.
Would it be a lot of work to make the sliders behave like this?

Tue, Jan 7, 6:38 AM ยท efl
segfaultxavi added a comment to T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type.

Removing a feature does not feel right. I would prefer we added the missing "inverted locale" setting.
But if that's too much work, we can wait until somebody actually requests it, as @ali.alzyod suggested.

Tue, Jan 7, 6:33 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T7939: enum Efl.Text_Format_Horizontal_Alignment_Auto_Type.

D10993 renames normal to auto and adds some more docs (that patch still needs review, btw).
It does not remove end.

Tue, Jan 7, 5:31 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi closed D11017: Fix worning and tests for edje text_class.
Tue, Jan 7, 5:29 AM ยท efl
segfaultxavi accepted D11017: Fix worning and tests for edje text_class.

Works as advertised, warnings are fixed. Thanks!

Tue, Jan 7, 5:28 AM ยท efl
segfaultxavi added a comment to T7938: enum Efl.Text_Font_Slant.

Cool thanks!
I'll update the docs later on.

Tue, Jan 7, 5:17 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T7940: enum Efl.Text_Format_Wrap.

API and names look good to me. I'll take care of the docs later on.

Tue, Jan 7, 5:16 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T7936: enum Efl.Text_Font_Bitmap_Scalable.

OK, so, if in the future we want to support scaling of monochrome fonts, we add another enum value monochrome, for example.

Tue, Jan 7, 5:14 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T7934: type Efl.Font.Size.

Oh, the EO file already explained that. This task description was outdated :/

Tue, Jan 7, 4:19 AM ยท efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8502: Efl.Canvas.Gesture.

It is true that this sentence was missing from the docs. I hope the above commit fixes that.

Tue, Jan 7, 3:29 AM ยท efl: api, efl (efl-1.24)