Page MenuHomePhabricator

YOhoho (YeongJong Lee)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 4 2016, 7:39 AM (172 w, 1 d)
Availability
Available

Recent Activity

Wed, Jul 10

YOhoho added a comment to T7899: efl.ui.table.

It looks okay to me.

Wed, Jul 10, 9:38 PM · efl: api, efl (efl-1.23), efl: language bindings
YOhoho added a comment to T7864: efl.gfx.arrangement.

Try as I might, I see no effect when I change Efl.Gfx.Arrangement.content_align on an Efl.Ui.Box. Looking at the code, content_align is unused by box.

I am updating the docs for the Box widget and I'd like to know the purpose of content_align.

EDIT: OK, I had to set the weight hint to -1, but still it only worked for the Y axis. And the relationship between Efl.Gfx.Arrangement.content_align and Efl.Gfx.Hint.align is not clear at all...

Wed, Jul 10, 9:27 PM · efl: api, efl (efl-1.23), efl: language bindings

Mon, Jul 8

YOhoho added a comment to T7900: efl.pack_table.

I think pack_table is okay. _table is postfix of pack like _at, _begin, _after.

Mon, Jul 8, 3:30 AM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Jun 28

YOhoho accepted D9071: csharp: make inherited C# classes constructible from native C.

It makes sense to me. thank you for detailed reply.

Fri, Jun 28, 2:08 AM · efl

Thu, Jun 27

YOhoho accepted D9191: evas_events: fix wrong event listening.

It works well. thank you!

Thu, Jun 27, 7:18 PM · efl

Wed, Jun 26

YOhoho reopened D9137: evas: emit the corrent event here,.

@bu5hm4n This patch break legacy APIs.
Could you check test this test case?

evas_focus_in(evas);
ck_assert_int_eq(evas_focus_state_get(evas), EINA_TRUE);
evas_focus_out(evas);
ck_assert_int_eq(evas_focus_state_get(evas), EINA_FALSE);
evas_focus_out(evas);
ck_assert_int_eq(evas_focus_state_get(evas), EINA_FALSE);
Wed, Jun 26, 10:20 PM · efl

Jun 21 2019

YOhoho updated the diff for D9128: eolian_mono: support eo access modifiers.

Implement property scope

Jun 21 2019, 2:53 AM · efl

Jun 20 2019

YOhoho planned changes to D9128: eolian_mono: support eo access modifiers.

I forgot property scope.

Jun 20 2019, 5:09 AM · efl

Jun 19 2019

YOhoho requested review of D9128: eolian_mono: support eo access modifiers.
Jun 19 2019, 7:07 PM · efl
YOhoho added a revision to T7494: C#: Mark protected methods as protected: D9128: eolian_mono: support eo access modifiers.
Jun 19 2019, 7:07 PM · efl: language bindings
YOhoho added a comment to T7494: C#: Mark protected methods as protected.

Note that current state is option 1. eolian_mono ignore @protected tags and make interface method public. Ah, you mean it is only interface case.
I also prefer option 2. end user shouldn't use @protected methods directly.

Jun 19 2019, 2:20 AM · efl: language bindings
YOhoho added a comment to T7494: C#: Mark protected methods as protected.

I tried to write patch to support eo access modifiers(like @protected) on EFL#. however there is a problem.
Method of C# interface have to be public.

Jun 19 2019, 1:23 AM · efl: language bindings
YOhoho added a comment to D9111: eolian_mono: fix to call mixin's method in inherited class.

@YOhoho can you verify that calling the super function in ´Press´ also does work ?

Jun 19 2019, 12:38 AM · efl
YOhoho accepted D9111: eolian_mono: fix to call mixin's method in inherited class.

Press method of my clickable custom slider works fine with this patch.

public class MySlider : Efl.Ui.Slider, Efl.Ui.IClickable
{
    public MySlider(Efl.Object parent, string style = null) : base(parent, style)
    {
        ClickableUtil.BindToObject(this, this);
    }
    public void Press(uint button)
    {   
        Eina.Log.Error("My slider Press!");
    }
Jun 19 2019, 12:27 AM · efl

Jun 12 2019

YOhoho accepted D9087: tests/efl_ui: remove unnecessary shutdown fixture code.

Looks good to me.

Jun 12 2019, 5:40 AM · efl
YOhoho requested review of D9084: efl_mono: update docs of CreateWrapperFor.
Jun 12 2019, 12:33 AM · efl

Jun 11 2019

YOhoho added a comment to D9071: csharp: make inherited C# classes constructible from native C.

One more question,

Jun 11 2019, 11:49 PM · efl
YOhoho requested changes to D9071: csharp: make inherited C# classes constructible from native C.

There is infinite loop when i create a class inherited Efl.Ui.Widget.
Please test the sample code with this patch{F3724530}.


When i get instance from native C code, its inherited value is false.

Jun 11 2019, 11:43 PM · efl
YOhoho added inline comments to D9071: csharp: make inherited C# classes constructible from native C.
Jun 11 2019, 2:26 AM · efl

Jun 10 2019

YOhoho requested review of D9079: efl_mono: support multilevel inheritance of NativeClass.
Jun 10 2019, 2:43 AM · efl

May 29 2019

YOhoho updated the diff for D9029: efl_ui_relative_layout: allow to respect the min size of its child.
  1. Fix type mismatch in conditional expression.
  2. Fix a bug in single object case.
  3. More inline comments to calculate layout min size.
May 29 2019, 12:19 AM · efl

May 28 2019

YOhoho updated the diff for D9029: efl_ui_relative_layout: allow to respect the min size of its child.

Remove needless initialization

May 28 2019, 4:42 AM · efl
YOhoho requested review of D9032: efl_ui_relative_layout: prevent infinite loop in chain calculation.
May 28 2019, 1:17 AM · efl

May 26 2019

YOhoho requested review of D9029: efl_ui_relative_layout: allow to respect the min size of its child.
May 26 2019, 8:48 PM · efl

May 20 2019

YOhoho accepted D8902: Efl.Pack_Table: remove table_direction.

Thank you for the patch. looks good to me.

May 20 2019, 1:32 AM · efl

May 15 2019

YOhoho added inline comments to D8887: evas: add 'has_fixed_size' property for canvas objects.
May 15 2019, 9:25 PM · efl: rendering
YOhoho added a comment to T7962: Remove table_direction from Efl.Pack_Table.

Sounds good to me, too.

May 15 2019, 7:05 PM · efl (efl-1.23), efl: api

May 8 2019

YOhoho added a comment to D8868: navigation_layout: set efl.content y-axis align to 0.0.

May 8 2019, 10:27 PM · efl
YOhoho requested review of D8868: navigation_layout: set efl.content y-axis align to 0.0.
May 8 2019, 10:25 PM · efl

May 3 2019

YOhoho updated the diff for D8631: ui.relative_layout: implement Efl.Pack.

fix build warning

May 3 2019, 2:20 AM · efl

Apr 29 2019

YOhoho added a comment to D8737: efl_ui_pager: mark box internal.

sub_object_add will be helpful to synchronize some widget properties such as mirrored, scale, etc.

Apr 29 2019, 6:19 AM · efl
YOhoho updated the diff for D8631: ui.relative_layout: implement Efl.Pack.

implement Efl.Pack

Apr 29 2019, 4:38 AM · efl
YOhoho added a comment to D8737: efl_ui_pager: mark box internal.

Why don't you call sub_object_add?

Apr 29 2019, 3:45 AM · efl

Apr 25 2019

YOhoho updated the diff for D8717: edje_calc: replace eina_stringshare_ref with eina_stringshare_add.

update commit message

Apr 25 2019, 10:47 PM · efl
YOhoho requested review of D8717: edje_calc: replace eina_stringshare_ref with eina_stringshare_add.
Apr 25 2019, 10:41 PM · efl

Apr 23 2019

YOhoho updated the diff for D8627: ui.relative_layout: enhance relation_xxx_set,get apis.

more unit test

Apr 23 2019, 10:28 PM · efl
YOhoho requested review of D8695: ui.relative_layout: fix incorrect type casting.
Apr 23 2019, 10:06 PM · efl
YOhoho updated the diff for D8631: ui.relative_layout: implement Efl.Pack.

rebase

Apr 23 2019, 9:49 PM · efl
YOhoho updated the diff for D8625: ui.relative_layout: add internal clipper.

Fix memory leak and add missing code.

Apr 23 2019, 9:44 PM · efl
YOhoho added a comment to D8625: ui.relative_layout: add internal clipper.

is pd->base freed when relative layout is destructed?

Apr 23 2019, 9:01 PM · efl
YOhoho updated the diff for D8627: ui.relative_layout: enhance relation_xxx_set,get apis.

replace with EINA_DBL_EQ.

Apr 23 2019, 5:41 AM · efl
YOhoho added a comment to D8631: ui.relative_layout: implement Efl.Pack.

I already tried that when i designed relative_layout. but i couldn't because of some properties that are hard to implement(pack_align, pack_padding). i don't want to make not implemented method.

There are also other widgets not implementing pack_align and pack_padding (Efl.Ui.Pager, Efl.Ui.List). Maybe we should refactor those two properties into its own interface ?

Apr 23 2019, 5:32 AM · efl
YOhoho added a comment to D8631: ui.relative_layout: implement Efl.Pack.

This has nothing really to do with this revision, but do you think implementing Efl.Pack is feasible here ? Pack could do just some default, but unpack, unpack_all, or pack_clear does sound useful for this Widget.

Apr 23 2019, 12:04 AM · efl

Apr 21 2019

YOhoho updated the diff for D8625: ui.relative_layout: add internal clipper.

rebase

Apr 21 2019, 4:56 PM · efl
YOhoho closed D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.
Apr 21 2019, 3:13 AM · efl

Apr 18 2019

YOhoho abandoned D8053: eio: cancel remaining threads without waiting on invalidate.
Apr 18 2019, 1:27 AM · efl
YOhoho abandoned D7970: eio: cancel registered future before it's freed.
Apr 18 2019, 1:27 AM · efl
YOhoho removed a parent revision for D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table: D8556: efl_ui_table: remove callbacks when item is removed.
Apr 18 2019, 1:23 AM · efl
YOhoho removed a child revision for D8556: efl_ui_table: remove callbacks when item is removed: D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.
Apr 18 2019, 1:23 AM · efl
YOhoho updated the diff for D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.

Nice test!

Apr 18 2019, 1:22 AM · efl

Apr 17 2019

YOhoho added a comment to D8629: efl/elm_scroller: apply color_set correctly.

Lets forget this case, if this ever causes issues then we will come back. I just have one more question, as far as i can see, "_elm_leaveme" disables everything that the widget class performse on its sub_objects, woudln't it be easier to just *not* sub_object_add it to the object ?

Only group_members(smart member) are affected by "_elm_leaveme".

Btw. is there a example where i can play with this ?

Please check Test Plan. you can easily test that.

Apr 17 2019, 11:28 PM · efl
YOhoho updated the diff for D8631: ui.relative_layout: implement Efl.Pack.

Fix some bugs and add unit test

Apr 17 2019, 10:36 PM · efl
YOhoho added a child revision for D8626: ui.relative_layout: add callbacks to update layout: D8631: ui.relative_layout: implement Efl.Pack.
Apr 17 2019, 10:36 PM · efl
YOhoho updated the diff for D8626: ui.relative_layout: add callbacks to update layout.

rebase

Apr 17 2019, 9:18 PM · efl
YOhoho updated the diff for D8625: ui.relative_layout: add internal clipper.

remove relative_layout from children hash.

Apr 17 2019, 9:16 PM · efl
YOhoho added a comment to D8629: efl/elm_scroller: apply color_set correctly.

Mhm the only nit here, you are once using evas_object_data_set and once efl_key_data_set, can this maybe cause harm when we refactor evas data stuff to be undependend from efl object data stuff.

Apr 17 2019, 7:46 AM · efl
YOhoho added a comment to D8631: ui.relative_layout: implement Efl.Pack.

When I tried to write test case for this, I realized that iterator_data is not Eo pointer(child) and efl_content_count doesn't return 0 after efl_ui_relative_layout_unregister_all.
I need to fix them before this path.

Apr 17 2019, 7:24 AM · efl
YOhoho planned changes to D8631: ui.relative_layout: implement Efl.Pack.

I found some bugs with testcase..

Apr 17 2019, 5:16 AM · efl
YOhoho requested review of D8631: ui.relative_layout: implement Efl.Pack.
Apr 17 2019, 3:23 AM · efl
YOhoho updated the diff for D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.

rebase

Apr 17 2019, 3:06 AM · efl
YOhoho added a child revision for D8556: efl_ui_table: remove callbacks when item is removed: D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.
Apr 17 2019, 3:05 AM · efl
YOhoho requested review of D8630: ui.relative_layout: replace evas_object_event_callback_xxx with efl_event_callback_xxx.
Apr 17 2019, 1:24 AM · efl
YOhoho requested review of D8629: efl/elm_scroller: apply color_set correctly.
Apr 17 2019, 1:15 AM · efl
YOhoho updated the diff for D8626: ui.relative_layout: add callbacks to update layout.

indentation fix

Apr 17 2019, 12:51 AM · efl
YOhoho updated the diff for D8626: ui.relative_layout: add callbacks to update layout.

remove needless efl_pack_layout_request

Apr 17 2019, 12:48 AM · efl
YOhoho requested review of D8627: ui.relative_layout: enhance relation_xxx_set,get apis.
Apr 17 2019, 12:46 AM · efl
YOhoho accepted D8555: efl_ui_table: correctly delete all items when clearing / unpacking.
Apr 17 2019, 12:09 AM · efl

Apr 16 2019

YOhoho requested review of D8626: ui.relative_layout: add callbacks to update layout.
Apr 16 2019, 11:35 PM · efl
YOhoho added a child revision for D8625: ui.relative_layout: add internal clipper: D8626: ui.relative_layout: add callbacks to update layout.
Apr 16 2019, 11:35 PM · efl
YOhoho requested review of D8625: ui.relative_layout: add internal clipper.
Apr 16 2019, 11:20 PM · efl

Apr 15 2019

YOhoho accepted D8554: efl_ui_table: hardening of pack_at function.

Oh, i agree with you in terms of consistency.
Note that, that behavior is different with evas_table, elm_table.

Apr 15 2019, 11:17 PM · efl
YOhoho added inline comments to D8555: efl_ui_table: correctly delete all items when clearing / unpacking.
Apr 15 2019, 10:21 PM · efl
YOhoho accepted D8556: efl_ui_table: remove callbacks when item is removed.
Apr 15 2019, 10:08 PM · efl
YOhoho requested changes to D8554: efl_ui_table: hardening of pack_at function.

You can adjust col, row, colspan and rowspan using pack_table api, therefore you don't need to adjust test case.
And, efl_canvas_object_render_parent_get is better for checking an existing child (like in box)

Apr 15 2019, 10:06 PM · efl
YOhoho added a comment to D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.

Hi, there have been 3 revisions for table, where the last one is at https://phab.enlightenment.org/D8556 would you be so kind and base this work on top of them? :)

Apr 15 2019, 9:40 PM · efl
YOhoho requested review of D8615: ui.table: remove leagcy evas_table from Efl.Ui.Table.
Apr 15 2019, 9:25 PM · efl
YOhoho requested review of D8605: gitignore: add elm_default_config.x.
Apr 15 2019, 12:21 AM · efl

Apr 12 2019

YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

rebase

Apr 12 2019, 3:18 AM · efl
YOhoho accepted D8433: efl.pack_linear: Clarify behavior and docs.

Thank you.

Apr 12 2019, 12:07 AM · efl

Apr 11 2019

YOhoho added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Apr 11 2019, 11:41 PM · efl
YOhoho requested changes to D8433: efl.pack_linear: Clarify behavior and docs.

It's wrong copy/paste.

Apr 11 2019, 10:50 PM · efl
YOhoho removed a project from D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets: DO NOT MERGE.
Apr 11 2019, 10:38 PM · efl
YOhoho updated the diff for D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets.

rebase

Apr 11 2019, 10:38 PM · efl
YOhoho requested review of D8599: efl_ui_widget: avoid calling null parent.
Apr 11 2019, 9:15 PM · efl
YOhoho added a revision to T7796: D8283 followup: D8599: efl_ui_widget: avoid calling null parent.
Apr 11 2019, 9:15 PM

Apr 3 2019

YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

Thank you to point out that.

Apr 3 2019, 3:48 AM · efl

Apr 2 2019

YOhoho added a comment to T7773: Unhandled Exception with custom widget class.
WRN<29394>:mono /home/yohoho/efl/core/efl/src/lib/evas/canvas/efl_canvas_object.eo.cs:4180 visible_set() Callback error: System.InvalidOperationException: Could not find the C# binding class for the EFL class: Efl.Ui.Focus.IParentProvider
  at Efl.Eo.ClassRegister.GetManagedType (System.IntPtr klass) [0x0011f] in <3209824ed5cc4357ba317101d56f9de8>:0
  at Efl.Eo.MarshalEflClass.MarshalNativeToManaged (System.IntPtr pNativeData) [0x0002b] in <3209824ed5cc4357ba317101d56f9de8>:0
  at (wrapper native-to-managed) Efl.ObjectNativeInherit.provider_find(intptr,intptr,System.Type)
  at (wrapper managed-to-native) System.Object.wrapper_native_0x7ff325e9a2c2(intptr,bool)
  at Efl.Canvas.Object.SetVisible (System.Boolean v) [0x00036] in <3209824ed5cc4357ba317101d56f9de8>:0
  at Efl.Canvas.ObjectNativeInherit.visible_set (System.IntPtr obj, System.IntPtr pd, System.Boolean v) [0x00026] in <3209824ed5cc4357ba317101d56f9de8>:0

The log said sample app is touching Efl.Ui.Focus.IParentProvider during Efl.ObjectNativeInherit.provider_find. however, Efl.Ui.Focus.IParentProvider class is not generated, becuase efl_ui_focus_parent_provider.eo is in elm_private_eolian_files. when i move some private eo files to public, that issue is fixed. but i guess it isn't proper solution.

Apr 2 2019, 7:08 PM
YOhoho updated the task description for T7773: Unhandled Exception with custom widget class.
Apr 2 2019, 6:54 PM
YOhoho added inline comments to D8521: efl_pack_linear: make pack_content_get consistent with pack_at.
Apr 2 2019, 7:36 AM · efl
YOhoho requested changes to D8524: efl_ui_box: implement the behavior that is documented.

My intention of D8433 about pack_at is

if efl_content_count(box) == 2
efl_pack_at(box, btn, -2);
efl_pack_content_get(box, -2) have to return btn.

index=-2 should insert at the middle.
If there is an ambiguous expression of the documentation, we need to correct that.

Apr 2 2019, 5:26 AM · efl

Apr 1 2019

YOhoho added a comment to T7774: Change parent object if content object is set to a new container.

@cedric

What I am worrying is that there are 2 types of parents here, object parent and widget parent. ;(

Apr 1 2019, 8:52 PM · efl: widgets
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

I forgot git add

Apr 1 2019, 8:31 PM · efl
YOhoho added a comment to D8522: efl_ui_box: print more errors,.

What do you think of printing subobj, obj address?

Apr 1 2019, 7:01 AM · efl
YOhoho added inline comments to D8524: efl_ui_box: implement the behavior that is documented.
Apr 1 2019, 6:58 AM · efl

Mar 30 2019

YOhoho updated the diff for D8484: efl_ui_table_layout: calculate cell size with colspan, rowspan property.

There are only horizontal, vertical cell arrays named cell_calc[0], cell_calc[1]

Mar 30 2019, 1:49 AM · efl

Mar 29 2019

YOhoho accepted D8506: build: improve autotools generation of elm config.

Look good to me.

Mar 29 2019, 11:20 PM · Restricted Project
YOhoho triaged T7773: Unhandled Exception with custom widget class as High priority.
Mar 29 2019, 1:52 AM
YOhoho added a comment to D8489: build: add autotools for elm config embedding.

PHONIES of elm_default_config.x causes repetitive elementary build.

yohoho@yohoho-pc:~/efl/core/efl$ sudo make -j24 install
Making install in src
lib/elementary/config_embed /home/yohoho/efl/core/efl/data/elementary/config/standard/base.src.in lib/elementary/elm_default_config.x
make  install-recursive
lib/elementary/config_embed /home/yohoho/efl/core/efl/data/elementary/config/standard/base.src.in lib/elementary/elm_default_config.x
  CC       lib/elementary/lib_elementary_libelementary_la-elm_config.lo
  CCLD     lib/elementary/libelementary.la
  CCLD     modules/elementary/access_output/module.la
  CCLD     modules/elementary/clock_input_ctxpopup/module.la
  CCLD     edje_external/elementary/module.la
  CCLD     modules/elementary/test_entry/module.la
  CCLD     modules/elementary/test_map/module.la
  CCLD     modules/elementary/web/none/module.la
...

The build message before this patch is

yohoho@yohoho-pc:~/efl/core/efl$ sudo make -j24 install
Making install in src
make  install-recursive
 /bin/mkdir -p '/usr/lib'
 /bin/mkdir -p '/usr/bin'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   lib/eina/libeina.la lib/eo/libeo.la lib/eo/libeo_dbg.la lib/efl/libefl.la lib/emile/libemile.la lib/eet/libeet.la lib/eolian/libeolian.la lib/ector/libector.la lib/ecore/libecore.la lib/evas/libevas.la lib/eldbus/libeldbus.la lib/ecore_con/libecore_con.la lib/ecore_ipc/libecore_ipc.la lib/ecore_file/libecore_file.la lib/eeze/libeeze.la lib/ecore_input/libecore_input.la lib/ecore_input_evas/libecore_input_evas.la lib/ecore_x/libecore_x.la lib/ecore_imf/libecore_imf.la lib/ecore_imf_evas/libecore_imf_evas.la lib/ecore_evas/libecore_evas.la lib/ecore_audio/libecore_audio.la lib/ecore_avahi/libecore_avahi.la lib/embryo/libembryo.la lib/efreet/libefreet.la lib/efreet/libefreet_mime.la lib/efreet/libefreet_trash.la lib/eio/libeio.la lib/ecore_buffer/libecore_buffer.la lib/ephysics/libephysics.la lib/edje/libedje.la lib/emotion/libemotion.la lib/ethumb/libethumb.la lib/ethumb_client/libethumb_client.la lib/elocation/libelocation.la lib/elementary/libelementary.la lib/efl_mono/libeflcustomexportsmono.la lib/elua/libelua.la '/usr/lib'
 /bin/mkdir -p '/usr/lib/ecore_buffer/bin/v-1.22'
 /usr/bin/install -c scripts/eo/eo_debug bin/eet/vieet bin/eet/diffeet bin/edje/edje_recc '/usr/bin'
  /bin/bash ../libtool   --mode=install /usr/bin/install -c bin/ecore_buffer/bq_mgr '/usr/lib/ecore_buffer/bin/v-1.22'
 /bin/mkdir -p '/usr/include/ecore-audio-1'
...
...

Furthermore, make install is failed with -j 24 option. (make -j24 install)
I'm not sure that PHONIES += lib/elementary/elm_default_config.x can be removed.

Mar 29 2019, 1:29 AM · Restricted Project

Mar 28 2019

YOhoho added a comment to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
In D8417#153395, @zmike wrote:

I am thinking that maybe we land this patch after the 1.22 release?

Mar 28 2019, 3:48 AM · efl

Mar 27 2019

YOhoho requested review of D8484: efl_ui_table_layout: calculate cell size with colspan, rowspan property.
Mar 27 2019, 1:38 AM · efl