Page MenuHomePhabricator

YOhoho (YeongJong Lee)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 4 2016, 7:39 AM (136 w, 5 d)
Availability
Available

Recent Activity

Wed, Nov 14

YOhoho added a comment to T7391: gengrid: gengrid item is not unfocused when gengrid unfocused.

apologies, i don't remember whether we have been talking about focus and realization. you means D6737?

Wed, Nov 14, 10:16 PM · Restricted Project
YOhoho accepted D7266: elm_gen****: correctly return the focus parent.
Wed, Nov 14, 9:50 PM · efl
YOhoho added a comment to D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.
Wed, Nov 14, 9:43 PM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

Because this test is written in the environment where all of top_win_focused related legacy focus API backward compatibility is broken, it is hard to say that meaningful test. if you fix that, this test will be failed.

Wed, Nov 14, 9:34 PM · efl

Tue, Nov 13

YOhoho reopened T7391: gengrid: gengrid item is not unfocused when gengrid unfocused as "Open".

This problem still occurs.

  1. Click Unfocus gegrid button.
  2. Click Print focused_item button.
  3. I got focused item : 0x40000004b2d4 output.
Tue, Nov 13, 10:35 PM · Restricted Project
YOhoho requested review of D7268: elm_gengrid: remove all_items_deselect call in _gengrid_element_focused.
Tue, Nov 13, 10:30 PM · efl
YOhoho added a comment to D7266: elm_gen****: correctly return the focus parent.

I'm sorry. i don't understand this patch. can you provide the details what issue is fixed with this patch?

Tue, Nov 13, 9:28 PM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

You just test legacy focus with focus manager. in order to check backward compatibility, it should work on legacy focus before being implemented focus manager . isn't it?

Tue, Nov 13, 8:52 PM · efl
YOhoho added a comment to D7267: elm_legacy: use the new api.

I'm sorry. my test wasn't enough.
Please check again enhanced test. P243

Tue, Nov 13, 7:20 PM · efl
YOhoho requested review of D7265: ecore_wl2_dnd: initialize source to NULL when it destroy.
Tue, Nov 13, 2:18 AM · efl

Mon, Nov 12

YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

Here is example. P243

Mon, Nov 12, 9:33 PM · efl
YOhoho added a comment to D7263: efl_ui_focus_object: add new event.

Ah, that is new feature :)

Mon, Nov 12, 10:07 AM · efl
YOhoho added a comment to D7263: efl_ui_focus_object: add new event.

You mean elementary user need check focus type for focus callback?

Mon, Nov 12, 10:00 AM · efl
YOhoho added a comment to D7263: efl_ui_focus_object: add new event.

small code convention violation :)

Mon, Nov 12, 9:56 AM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

Yes, it make focus test difficult. i think API should ensure consistent behavior regardless of environment.
btw, you can test compositor environment with export ELM_ENGINE=x11.

Mon, Nov 12, 9:47 AM · efl
YOhoho added a comment to D7263: efl_ui_focus_object: add new event.

I'm sorry T7438 still happen with this patch. could you share your test code? EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED not works for me.
i tested with D7233, D7232, D7231, D7230, D7179, D7103, D7124, D7123, D7102, D7100.

Mon, Nov 12, 9:40 AM · efl
YOhoho accepted D7233: elm-test: add a test for checking the event handling.

Actually, this test doesn't working on legacy focus system(before focus manager). because all legacy focus API worked when elm_win got window manager(compositor) focus(it means _elm_win_focus_in is called). this is the reason why top_win_focused property exist(now this property is not being used). i think it is also breaking backward compatibility.

Mon, Nov 12, 9:24 AM · efl
YOhoho accepted D7232: elm_list: fix focus without items.

This patch have dependency from D7100.

Mon, Nov 12, 9:20 AM · efl
YOhoho added a reviewer for D7231: elm_gen****: ensure that no focus item is handled correctly: ManMower.
Mon, Nov 12, 9:20 AM · efl
YOhoho added a comment to D7231: elm_gen****: ensure that no focus item is handled correctly.

I'm sorry i don't have any context about T7203.

Mon, Nov 12, 9:19 AM · efl
YOhoho accepted D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.
Mon, Nov 12, 9:18 AM · efl
YOhoho added a comment to D7230: efl_ui_focus_manager: make active getter work correctly.

a focus lost when window show on P233. i think gengrid can't get focus in _elm_win_focus_in. Is this unrelated issue?

Mon, Nov 12, 9:17 AM · efl
YOhoho accepted D7103: elm: update widgets that have documented focus and unfocused events.

I checked with the command grep -rIn '"focused"' --include=*.h
glview, photocam(efl_ui_image_zoomable), progressbar, web, hover, colorselector, slideshow, index, map.
I guess those widgets also need legacy_xxx_focus_handle. i want to make patch for that but sadly, i still didn't understand which widget need proper legacy_xxx_focus_handle function call.

Mon, Nov 12, 9:17 AM · efl
YOhoho accepted D7124: elm_widget_item_static_focus: prepare the gengrid before preparing items.
Mon, Nov 12, 9:16 AM · efl
YOhoho accepted D7102: efl_ui_focus: add flag to indicate if a child has the focus.
Mon, Nov 12, 9:15 AM · efl
YOhoho accepted D7123: gengrid: unset last_focused pointer when focus moved away.

I test with D7233, D7232, D7231, D7230, D7179, D7103, D7124, D7123, D7102, D7100. the test wroks after gengrid get focus because gengrid can't get focus when window show on P233. but It seems that this issue is not related to this revision.

Mon, Nov 12, 9:15 AM · efl

Thu, Nov 8

YOhoho updated the diff for D7239: Inspect: support to print the exu diff result to standard output.

initialize to 0

Thu, Nov 8, 8:41 PM
YOhoho abandoned D7227: Spy: Prevent unexpected pointer dereference.

It work well. Thank you to fix that :)

Thu, Nov 8, 8:38 PM

Wed, Nov 7

YOhoho added a comment to D7227: Spy: Prevent unexpected pointer dereference.

It is still failed. ea_spy_check.sh --shared --no_cpp --no_cs --orig -t index
Failure function is elm_index_item_insert_after in catcher.c
Please check again.

Wed, Nov 7, 10:13 PM
YOhoho updated the diff for D7239: Inspect: support to print the exu diff result to standard output.

apply new format

Wed, Nov 7, 8:07 PM

Tue, Nov 6

YOhoho updated the diff for D7241: Remove duplicated interface inheritance in eo.

rebase

Tue, Nov 6, 7:21 PM · efl
YOhoho requested review of D7241: Remove duplicated interface inheritance in eo.
Tue, Nov 6, 3:42 AM · efl

Mon, Nov 5

YOhoho added inline comments to D7239: Inspect: support to print the exu diff result to standard output.
Mon, Nov 5, 3:47 AM
YOhoho updated subscribers of D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.

Could you describe more information in the commit message?
@zmike said

In D6812#119055, @zmike wrote:

The commit log for this patch needs more info, e.g., "what is the purpose of this patch" "why is this patch needed". Tickets may not always be able to be accessed, so providing only a ticket reference will not be as valuable in the future.

@segfaultxavi said

Please put more information on your commit messages. The fix is obvious, but does this fix any known bug? Was there any observable problem before the fix?

Mon, Nov 5, 3:05 AM · efl
YOhoho updated the diff for D7239: Inspect: support to print the exu diff result to standard output.

Remove needless stdout string comparison

Mon, Nov 5, 2:40 AM
YOhoho updated the diff for D7239: Inspect: support to print the exu diff result to standard output.

Wrong deleted line..

Mon, Nov 5, 1:51 AM
YOhoho requested review of D7239: Inspect: support to print the exu diff result to standard output.
Mon, Nov 5, 1:49 AM

Thu, Nov 1

YOhoho requested review of D7227: Spy: Prevent unexpected pointer dereference.
Thu, Nov 1, 5:06 AM

Wed, Oct 24

YOhoho requested review of D7209: Data: update efl_01.patch file.
Wed, Oct 24, 9:45 PM
YOhoho requested review of D7208: elm_conformant: fix wrong variable assignment.
Wed, Oct 24, 9:33 PM · efl

Mon, Oct 22

YOhoho added a comment to D7103: elm: update widgets that have documented focus and unfocused events.

Do i need to check all widgets for "focused", "unfocused" signals?

Mon, Oct 22, 4:16 PM · efl
YOhoho accepted D7100: elm: add unfocus / focus signals to gen* and toolbar.

I'd like to make the code more flexible and extensible. however this patch is acceptable if we don't need to consider that seriously for legacy widgets.

Mon, Oct 22, 4:14 PM · efl
YOhoho triaged T7438: Efl.Ui.Spin_Button can't get EFL_UI_FOCUS_OBJECT_EVENT_FOCUS_CHANGED signal. as High priority.
Mon, Oct 22, 3:41 PM · Restricted Project
YOhoho added a comment to D7103: elm: update widgets that have documented focus and unfocused events.
Mon, Oct 22, 8:29 AM · efl
YOhoho added a comment to D7100: elm: add unfocus / focus signals to gen* and toolbar.

I'm wondering why we need duplicated code if the classification can cover all of widgets.

What do you mean with this ?

Oh, i guessed that the purpose of overall goal of classification in three thing is for extensibility, flexibility.
When i make new widget, if the widget belongs among three thing, i will be able to easily implement focus.

Mon, Oct 22, 8:16 AM · efl
YOhoho added a comment to D7100: elm: add unfocus / focus signals to gen* and toolbar.

Sorry about my annoying questions. i want to make sure this solution can be applied to other widgets.

Mon, Oct 22, 7:50 AM · efl
YOhoho added a comment to T6806: focus(toolbar): focus tree of toolbar is broken.
  1. Focus is still gone after toolbar is resized(elementary_test -to toolbar (set focus to 'Elementary' item and reduce window size, then focus lost)

Works here.

  1. elementary_test -to toolbar
  2. Click 'Elementay' text item.
  3. reduce widow size until 'More' text item is shown.
  4. Press any arrow key. ( focus lost )
  1. Menu can't get focus using arrow key in Toolbar test (elementary_test -to toolbar)

Yes. Menu does not implement anything in regard of focus. Which was always the case. (T6892)

Oh, I mean 'Menu' text item.

  1. Focus can't escape in toolbar(elementary_test -to focus)

Works here. Are you up to date ?

Yes.

1. elementary_test
2. click 'focus' text button for focus test window.

This works well. But elementary_test -to focus has focus movement issue.
Please check again.

Mon, Oct 22, 4:56 AM · efl (efl-1.21), Restricted Project
YOhoho added a comment to D7103: elm: update widgets that have documented focus and unfocused events.

I tested with D7099, D7100, D7102, D7123, D7124, D7103. Is there any mistake..?

Mon, Oct 22, 4:44 AM · efl
YOhoho added a comment to D7100: elm: add unfocus / focus signals to gen* and toolbar.

hmm,,
Logical node can't get focus from focus manager, so they don't set canvas focus. then, they can't get focus when they don't have focusable content. is it proper understand..?

No - because if there is no focusable content a dummy element is injected. (Efl.Ui.Focus.Manager_Root_Focus).

<Edit> Sorry there was something in the top of the comment that was wrong :)

Mon, Oct 22, 4:43 AM · efl
YOhoho added a comment to D7100: elm: add unfocus / focus signals to gen* and toolbar.

genlist emit "focused" "unfocused" signals twice.

You said..
Q. Which widgets need to call legacy_efl_ui_focus_manager_widget_legacy_signals?
A. Those where the canvas focus is not set to the resize_object, and that are a manager object.

But toolbar, genlist, gengrid are SET canvas focus to the resize_object. because they inherit Efl.Ui.Layout.Object. see, _efl_ui_layout_object_efl_ui_focus_object_on_focus_update
(canvas focus means evas_object_focus_set. isn't it?)

No. This function has a check which checks if they can have focus, if not they don't set canvas focus to it. Also - isn't the _content_ of those windows getting focus ? :)

Mon, Oct 22, 4:36 AM · efl
YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I guess problem is that scroller have focusable dummy element when it doesn't have focusable content. but it is not included in pd->iterator_list in _efl_ui_focus_manager_root_focus_efl_ui_focus_manager_border_elements_get. so, scroller can't find focusable element.

Mon, Oct 22, 4:22 AM · DO NOT MERGE, efl
YOhoho requested changes to D7103: elm: update widgets that have documented focus and unfocused events.

Some widgets doesn't emit "focused" "unfocused" signals with this patch. I just tested with button, naviframe, check and radio.
I think you can remove duplecated call of legacy_efl_ui_focus_object_child_focus_handle of constructor of spinner, naviframe and multibutton entry.

Mon, Oct 22, 3:27 AM · efl
YOhoho added a comment to D7100: elm: add unfocus / focus signals to gen* and toolbar.

hmm,,
Logical node can't get focus from focus manager, so they don't set canvas focus. then, they can't get focus when they don't have focusable content. is it proper understand..?

Mon, Oct 22, 1:31 AM · efl
YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I meant focus move policy when scroller have focusable content.
The interaction problem between scroller and other widget is focus manager side issue.

Mon, Oct 22, 1:19 AM · DO NOT MERGE, efl

Sun, Oct 21

YOhoho added a comment to D7103: elm: update widgets that have documented focus and unfocused events.

One more question.
Which widgets should be manager object?

Sun, Oct 21, 10:46 PM · efl
YOhoho reopened T6806: focus(toolbar): focus tree of toolbar is broken, a subtask of T3088: Elementary needs a complete focus overhaul, as Open.
Sun, Oct 21, 9:22 PM · Restricted Project
YOhoho reopened T6806: focus(toolbar): focus tree of toolbar is broken as "Open".
  1. Focus is still gone after toolbar is resized(elementary_test -to toolbar (set focus to 'Elementary' item and reduce window size, then focus lost)
  2. Menu can't get focus using arrow key in Toolbar test (elementary_test -to toolbar)
  3. Focus can't escape in toolbar(elementary_test -to focus)
Sun, Oct 21, 9:22 PM · efl (efl-1.21), Restricted Project
YOhoho added a comment to T6806: focus(toolbar): focus tree of toolbar is broken.

It seems that c14ea532eb74 break toolbar visibility
Please check elementary_test -to toolbar8

Sun, Oct 21, 9:14 PM · efl (efl-1.21), Restricted Project
YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

@bu5hm4n
ping, scroller which have no content still can't get focus

Sun, Oct 21, 8:16 PM · DO NOT MERGE, efl
YOhoho added a comment to D7103: elm: update widgets that have documented focus and unfocused events.

I think fileselector, multibuttonentry, naviframe, spinner are SET canvas focus to the resize_object. because they inherit Efl.Ui.Layout.Object. see, _efl_ui_layout_object_efl_ui_focus_object_on_focus_update

Sun, Oct 21, 8:08 PM · efl
YOhoho requested changes to D7100: elm: add unfocus / focus signals to gen* and toolbar.

genlist emit "focused" "unfocused" signals twice.

Sun, Oct 21, 7:54 PM · efl
YOhoho accepted D7099: efl_ui_focus_manager: rename a event.
Sun, Oct 21, 7:27 PM · efl
YOhoho updated the summary of D7182: eina_lock: add empty do-while in macro.
Sun, Oct 21, 5:41 AM · efl
YOhoho updated the diff for D7182: eina_lock: add empty do-while in macro.

Update commit message

Sun, Oct 21, 5:39 AM · efl

Sat, Oct 20

YOhoho updated subscribers of D7109: efl_selection: add return value check for fwrite.

@herb
What do you think about @bu5hm4n's comment? this log print seems dangerous.

Sat, Oct 20, 9:49 PM · efl
YOhoho abandoned D7115: ecore_evas: add braces to avoid compiler warning which is empty body in an if statement.

I agree with @segfaultxavi

Sat, Oct 20, 9:38 PM · efl
YOhoho requested review of D7183: ecore: remove duplicated conditions.
Sat, Oct 20, 9:34 PM · efl
YOhoho requested review of D7182: eina_lock: add empty do-while in macro.
Sat, Oct 20, 9:26 PM · efl
YOhoho added a comment to D7115: ecore_evas: add braces to avoid compiler warning which is empty body in an if statement.
Sat, Oct 20, 8:57 PM · efl
YOhoho added a comment to D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.

We can check that if a node has relations, none of the dirty nodes is intercepting the relation between those two - and the relations that are part of that are not dirty. This would require further testing if it would not be too performance heavy (as this would include walking the dirty list in here - which is probebly not what we want)

I think this operation also need exhaustive search. because you don't know which relations are affected a dirty node, you have to check all relations so that the dirty node can be removed in dirty list.

However - I was told to have a fast solution, here it is :) Performance optimizations still can be added :)

You mean that dirty check is exhaustive search for fast solution in this patch and you have another plan to optimize performance? if then, could explain more details about optimizations?

Sat, Oct 20, 8:40 PM · efl
YOhoho added a reviewer for D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state: woohyun.
Sat, Oct 20, 10:23 AM · efl
YOhoho added a comment to D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.

Do we need exhaustive search for every coordinate based focus moving?

Sat, Oct 20, 10:22 AM · efl

Sep 27 2018

YOhoho updated subscribers of D7100: elm: add unfocus / focus signals to gen* and toolbar.

@bowonryu for toolbar

Sep 27 2018, 4:47 AM · efl
YOhoho updated subscribers of D7103: elm: update widgets that have documented focus and unfocused events.

If widget maintainer doesn't have comprehension of focus manager, They can have questions.

  • Why these widgets need focus special code?
  • Which widgets need to call legacy_efl_ui_focus_object_child_focus_handle?
  • Which widgets need to call legacy_efl_ui_focus_manager_widget_legacy_signals?
  • There is focus callback for legacy signal in efl_ui_widget.c. Why these widgets can't use that callback?
Sep 27 2018, 4:46 AM · efl
YOhoho requested review of D7116: efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value".
Sep 27 2018, 12:33 AM · efl

Sep 26 2018

YOhoho updated subscribers of D7101: efreet_menu: remove unused and unreachable code..

@Jaehyun_Cho ping

Sep 26 2018, 11:03 PM · efl
YOhoho requested review of D7115: ecore_evas: add braces to avoid compiler warning which is empty body in an if statement.
Sep 26 2018, 10:57 PM · efl
YOhoho updated the diff for D7109: efl_selection: add return value check for fwrite.

Print error message intead of return

Sep 26 2018, 10:46 PM · efl
YOhoho abandoned D7111: evas: check malloc/calloc return.

We do not require or encourage allocation failure checks of allocations of small (open to interpretation) chunks of memory.
https://phab.enlightenment.org/w/commit_check_point/

Sep 26 2018, 6:07 PM · efl
YOhoho requested review of D7113: efl_ui_list: fix wrong variable usage.
Sep 26 2018, 6:06 PM · efl
YOhoho updated the diff for D7112: efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value.

more remove

Sep 26 2018, 6:02 PM · efl
YOhoho requested review of D7112: efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value.
Sep 26 2018, 5:56 PM · efl
YOhoho requested review of D7111: evas: check malloc/calloc return.
Sep 26 2018, 5:45 PM · efl
YOhoho requested review of D7110: efl_exe: check fcntl return.
Sep 26 2018, 5:23 PM · efl
YOhoho requested review of D7109: efl_selection: add return value check for fwrite.
Sep 26 2018, 4:57 PM · efl
YOhoho requested review of D7108: elm_genlist: prevent null pointer access.
Sep 26 2018, 4:46 PM · efl
YOhoho requested review of D7107: eina_value: return null when eina_value_pget failed.
Sep 26 2018, 4:39 PM · efl

Sep 19 2018

YOhoho triaged T7391: gengrid: gengrid item is not unfocused when gengrid unfocused as High priority.
Sep 19 2018, 12:21 AM · Restricted Project
YOhoho added a project to T7390: gengrid: gengrid can't get focus if there is no focusable content in item.: Restricted Project.
Sep 19 2018, 12:21 AM · Restricted Project
YOhoho added a project to T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager: Restricted Project.
Sep 19 2018, 12:21 AM · Restricted Project
YOhoho added a project to T7386: Elm_Spinner does not emit "focused" "unfocused" signal when focused: Restricted Project.
Sep 19 2018, 12:20 AM · Restricted Project
YOhoho added a project to T7385: Elm_Gengrid does not emit "focused" "unfocused" signal when focused: Restricted Project.
Sep 19 2018, 12:20 AM · Restricted Project

Sep 13 2018

YOhoho triaged T7397: focus coordinate movement issue as High priority.
Sep 13 2018, 4:34 AM · Restricted Project
YOhoho removed a reviewer for D7028: evas_object_callbacks: do not error on NULL on del: YOhoho.
Sep 13 2018, 2:25 AM · efl
YOhoho added a comment to D7028: evas_object_callbacks: do not error on NULL on del.

And otherwise the programmer will end up with a shitload of error messages in the console, where basically none of them is telling him something useful.

This is basically the same thing as efl_del accepting a NULL as parameter. If you have wasted thing pointer, then it is your fault, API cannot handle every error. It is way more common to have deletion APIs accepting NULL than have them erroring.

Then Can we remove safety macro for func?

Sep 13 2018, 2:25 AM · efl
YOhoho added inline comments to D6781: elm_genlist: unfocus item when genlist is unfocused.
Sep 13 2018, 1:29 AM · efl

Sep 12 2018

YOhoho requested changes to D7028: evas_object_callbacks: do not error on NULL on del.

How the api know callback is deleting?

Sep 12 2018, 4:27 PM · efl

Sep 11 2018

YOhoho created T7391: gengrid: gengrid item is not unfocused when gengrid unfocused.
Sep 11 2018, 4:08 AM · Restricted Project
YOhoho triaged T7390: gengrid: gengrid can't get focus if there is no focusable content in item. as High priority.
Sep 11 2018, 3:57 AM · Restricted Project
YOhoho triaged T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager as High priority.
Sep 11 2018, 3:33 AM · Restricted Project