Page MenuHomePhabricator

YOhoho (YeongJong Lee)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 4 2016, 7:39 AM (146 w, 1 d)
Availability
Available

Recent Activity

Yesterday

YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

I think its now ready to land.
I'm waiting for review.
Please check updated class diagram and testcases in my previous comment.

Mon, Jan 21, 1:58 PM · efl

Sun, Jan 20

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Fix margin calculation

Sun, Jan 20, 7:19 PM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rename Calc_Params to Calc.
Optimize chain weight calculation ( O(n^2) -> O(nlog n) )
Add testcase for chain relation.

Sun, Jan 20, 5:49 PM · efl

Thu, Jan 17

YOhoho requested review of D7667: elm_panel: fix visibility when switching scrollable mode.
Thu, Jan 17, 12:18 AM · efl

Wed, Jan 16

YOhoho removed a project from D7524: efl_ui_relative_layout: introduce new relative container: DO NOT MERGE.
Wed, Jan 16, 12:47 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object again. :(

Wed, Jan 16, 12:46 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

optimize chain_calc

Wed, Jan 16, 12:39 AM · efl

Tue, Jan 15

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object. it is unnecessary.

Tue, Jan 15, 12:47 AM · efl
YOhoho added a comment to D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

optimization point :)

Tue, Jan 15, 12:28 AM · efl
YOhoho updated the diff for D7409: gfx: Add size hint fill (EO).

Remove needless condition and handle -1 value.

Tue, Jan 15, 12:12 AM · efl
YOhoho added inline comments to D7409: gfx: Add size hint fill (EO).
Tue, Jan 15, 12:09 AM · efl

Mon, Jan 14

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Add documentations.

Mon, Jan 14, 3:50 AM · efl

Sun, Jan 13

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. rebase
  2. refactoring
  3. add more tests
  4. implement chain relation (efl_ui_relative_layout_example_02)
Sun, Jan 13, 10:13 PM · efl

Wed, Jan 9

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rebase and remove relation_dir_to_set, relation_dir_relative_set apis.

Wed, Jan 9, 8:24 PM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

@cedric
Agreed.

relation_left_set(Eo *obj, Eo *child, Eo *target, double relative);

Would cover all cases passing NULL.

Wed, Jan 9, 8:21 PM · efl
YOhoho updated the test plan for D7524: efl_ui_relative_layout: introduce new relative container.
Wed, Jan 9, 4:33 AM · efl
YOhoho updated subscribers of D7554: efl: remove warning due to unused variable/parameters..

some patches are already applied by @Hermet except tests.

Wed, Jan 9, 4:32 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

update a meson builf file

Wed, Jan 9, 4:05 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. add elementary_test example.
  2. rename to left, right, top, bottom.
  3. remove register api. (when a child have relation, it is registered)
Wed, Jan 9, 4:03 AM · efl

Tue, Jan 8

YOhoho added a comment to D7561: efl_ui_text: remove duplicated empty string initialization.

@segfaultxavi
You can check a text in elementary_test -to 'efl.ui.slider'with this patch.

Tue, Jan 8, 3:05 PM · efl
YOhoho requested review of D7561: efl_ui_text: remove duplicated empty string initialization.
Tue, Jan 8, 8:08 AM · efl

Mon, Jan 7

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

implement margin

Mon, Jan 7, 5:57 PM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

I am not to sure of the name of this new class as it doesn't express in the name the fact that it is a container. Also, and it is something that I am sure @segfaultxavi will point out, it is lacking a lot of documentation :-)

Mon, Jan 7, 2:40 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rename to Efl.Ui.Relative_Layout

Mon, Jan 7, 2:02 AM · efl

Sun, Jan 6

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. Rename Efl_Ui_Relative_Param -> Efl_Ui_Relative_Relation and integrate rel1 and rel2.
  2. (API) Rename rel1 -> left, rel2 -> right for intuitive names.
  3. Add Get method for properies.
  4. Update Class Diagram (check above comment)
Sun, Jan 6, 11:54 PM · efl
YOhoho updated the diff for D7409: gfx: Add size hint fill (EO).

Fix typo.

Sun, Jan 6, 8:27 PM · efl
YOhoho updated the diff for D7409: gfx: Add size hint fill (EO).

Fix wrong usecase.

Sun, Jan 6, 8:21 PM · efl

Fri, Dec 28

YOhoho added a project to D7524: efl_ui_relative_layout: introduce new relative container: DO NOT MERGE.
Fri, Dec 28, 12:27 AM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

TODO

  1. implement margin.
  2. add more examples.
  3. add more tests.
  4. enhance documentations.
  5. implement a circular dependency check.(efl_ui_relative_example02)
  6. implement scale.
Fri, Dec 28, 12:26 AM · efl
YOhoho requested review of D7524: efl_ui_relative_layout: introduce new relative container.
Fri, Dec 28, 12:11 AM · efl
YOhoho added a child revision for D7409: gfx: Add size hint fill (EO): D7524: efl_ui_relative_layout: introduce new relative container.
Fri, Dec 28, 12:11 AM · efl
YOhoho added a revision to T5487: edje & elm sizing: respect hints & simplify layout api: D7524: efl_ui_relative_layout: introduce new relative container.
Fri, Dec 28, 12:11 AM · efl: widgets, Restricted Project

Dec 17 2018

YOhoho closed D7310: elm-test: add a test for checking the focus_next_object_set.
Dec 17 2018, 12:46 AM · efl
YOhoho added a commit to T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager: rEFLd840a645506d: elm-test: add a test for checking the focus_next_object_set.
Dec 17 2018, 12:46 AM · Restricted Project

Dec 16 2018

YOhoho added a comment to T5487: edje & elm sizing: respect hints & simplify layout api.

If you use aspect, max and min hints together in Efl.Ui.Box, there is wired behavior. furthermore, there is no way to use max, align(SIZE_HINT_FILL) hints together. so, i want to suggest a little idea to solve this problem.
The first is fill hint. if a widget use both hint_align(HINT_FILL) and hint_max together, there is no way to set to hint_align. (D7409)
Here is new priority with fill hint and the test cases. (D7463)

priorityproperty
1HintMin
2HintMin + HintAspect
3HintMargin
4HintMax
5HintAspect
6HintWeight, HintFill
7HintAlign

Dec 16 2018, 5:49 PM · efl: widgets, Restricted Project
YOhoho requested review of D7463: test/ui_box: add test for Efl.Ui.Box.
Dec 16 2018, 5:47 PM · efl
YOhoho added a child revision for D7409: gfx: Add size hint fill (EO): D7463: test/ui_box: add test for Efl.Ui.Box.
Dec 16 2018, 5:47 PM · efl
YOhoho added a revision to T5487: edje & elm sizing: respect hints & simplify layout api: D7463: test/ui_box: add test for Efl.Ui.Box.
Dec 16 2018, 5:47 PM · efl: widgets, Restricted Project
YOhoho closed T6804: focus(scroller): backward compatibility for scroller focus move, a subtask of T3088: Elementary needs a complete focus overhaul, as Resolved.
Dec 16 2018, 4:10 PM · Restricted Project
YOhoho closed T6804: focus(scroller): backward compatibility for scroller focus move as Resolved.
Dec 16 2018, 4:10 PM · Restricted Project
YOhoho edited the content of Maintainers Reviewers.
Dec 16 2018, 4:02 PM · efl
YOhoho abandoned D6815: efl_ui_focus_manager_calc: prevent focus lost.
Dec 16 2018, 3:58 PM · efl
YOhoho abandoned D6781: elm_genlist: unfocus item when genlist is unfocused.
Dec 16 2018, 3:58 PM · efl
YOhoho abandoned D5936: ctxpopup: prevent focus escape from ctxpopup..
Dec 16 2018, 3:57 PM · efl
YOhoho accepted D7454: elm_gengrid: improve genlist behaviour.
Dec 16 2018, 3:57 PM · efl
YOhoho accepted D7453: elm_widget_item_static_focus: fix ERR prints.
Dec 16 2018, 3:57 PM · efl
YOhoho accepted D7452: elm_genlist: behaviour fixes for genlist.
Dec 16 2018, 3:56 PM · efl
YOhoho accepted D7451: elm_gen****: fix focus restoring on window focus changes.
Dec 16 2018, 3:56 PM · efl
YOhoho accepted D7450: efl_ui_focus_manager: performance optimize order setting.
Dec 16 2018, 3:55 PM · efl
YOhoho accepted D7408: elm_focus: implement elm_object_focus_next_item_set / get.
Dec 16 2018, 3:55 PM · efl

Dec 3 2018

YOhoho updated the diff for D7409: gfx: Add size hint fill (EO).

update docs.

Dec 3 2018, 11:53 PM · efl
YOhoho requested review of D7409: gfx: Add size hint fill (EO).
Dec 3 2018, 11:51 PM · efl
YOhoho accepted D7404: elm_focus: implement legacy targets for logical widgets.

need rebase

Dec 3 2018, 6:01 PM · efl
YOhoho accepted D7382: elm_scroller: update behaviour to match legacy behaviour more closely.
Dec 3 2018, 5:44 PM · efl
YOhoho requested review of D7406: examples: update gitignore.
Dec 3 2018, 5:31 PM · efl

Nov 28 2018

YOhoho requested changes to D7382: elm_scroller: update behaviour to match legacy behaviour more closely.

it is weird behavior in scroller 2 elm_test.

Nov 28 2018, 6:32 PM · efl
YOhoho accepted D7364: efl_ui_focus_manager_root_focus: ensure that adapter is part of viewport.
Nov 28 2018, 5:39 PM · efl
YOhoho accepted D7360: elm_interface_scrollable: add support for *jumping* into a scroller.
Nov 28 2018, 5:29 PM · efl

Nov 26 2018

YOhoho accepted D7350: efl_ui_focus_manager_sub: freeze manager when parent manager is frozen.
Nov 26 2018, 2:05 AM · efl
YOhoho accepted D7349: elm_interface_scrollable: freeze the manager object when content moves.
Nov 26 2018, 2:05 AM · efl
YOhoho accepted D7353: efl_ui_focus_manager_calc: ensure that the coords are marked dirty.
Nov 26 2018, 2:05 AM · efl
YOhoho accepted D7348: efl_ui_focus_manager: introduce a new API.
Nov 26 2018, 2:04 AM · efl
YOhoho accepted D7347: efl_ui_focus_object: introduce a new event for focus geometry changes.
Nov 26 2018, 2:04 AM · efl
YOhoho accepted D7331: elm_focus: implement missing functions.
Nov 26 2018, 2:04 AM · efl
YOhoho accepted D7330: efl_ui_focus_manager_calc: reduce the amount of list operations.
Nov 26 2018, 2:03 AM · efl

Nov 25 2018

YOhoho added a reviewer for D7350: efl_ui_focus_manager_sub: freeze manager when parent manager is frozen: YOhoho.
Nov 25 2018, 10:48 PM · efl
YOhoho removed a reviewer for D7350: efl_ui_focus_manager_sub: freeze manager when parent manager is frozen: YOhoho.

It seems that this patch has no reviewers specified. If you are unsure who can review your patch, please check this wiki page and see if anyone can be added: https://phab.enlightenment.org/w/maintainers_reviewers/

Nov 25 2018, 10:48 PM · efl
YOhoho added a comment to D7350: efl_ui_focus_manager_sub: freeze manager when parent manager is frozen.

Oh, this bug has happened before :(

Nov 25 2018, 10:48 PM · efl
YOhoho requested review of D7357: eldbus: add brackets.
Nov 25 2018, 10:40 PM · efl
YOhoho requested changes to D7350: efl_ui_focus_manager_sub: freeze manager when parent manager is frozen.

There is strange behavior with D7300, D7311, D7347, D7348, D7353, D7349, D7350.
Test code : https://github.com/dasg34/focus_test/blob/b233a8e491fbcde1da78b5b0a4c02c8fcd078c99/test_focus.c
command: ELM_TC=1 ./test_focus
Test Plan

  1. Click 'Test button 1'
  2. Press Down arrow key
  3. Press Up arrow key.
Nov 25 2018, 10:23 PM · efl

Nov 20 2018

YOhoho added a reviewer for D7316: update efl_01.patch file: JackDanielZ.
Nov 20 2018, 7:16 PM
YOhoho requested review of D7316: update efl_01.patch file.
Nov 20 2018, 7:16 PM
YOhoho accepted D7311: elm-test: simulate focus on the window.
Nov 20 2018, 7:05 PM · efl
YOhoho accepted D7267: elm_legacy: use the new api.
Nov 20 2018, 8:48 AM · efl
YOhoho updated the diff for D7310: elm-test: add a test for checking the focus_next_object_set.

remove unused variable

Nov 20 2018, 7:44 AM · efl
YOhoho added a reviewer for D7310: elm-test: add a test for checking the focus_next_object_set: bu5hm4n.
Nov 20 2018, 7:39 AM · efl
YOhoho requested review of D7310: elm-test: add a test for checking the focus_next_object_set.
Nov 20 2018, 7:39 AM · efl
YOhoho added a revision to T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager: D7310: elm-test: add a test for checking the focus_next_object_set.
Nov 20 2018, 7:39 AM · Restricted Project
YOhoho closed T7391: gengrid: gengrid item is not unfocused when gengrid unfocused as Resolved.
Nov 20 2018, 7:09 AM · Restricted Project
YOhoho closed T6806: focus(toolbar): focus tree of toolbar is broken as Resolved.
Nov 20 2018, 7:09 AM · efl (efl-1.21), Restricted Project
YOhoho closed T6806: focus(toolbar): focus tree of toolbar is broken, a subtask of T3088: Elementary needs a complete focus overhaul, as Resolved.
Nov 20 2018, 7:09 AM · Restricted Project
YOhoho added a comment to T7290: Elementary test Focus 3 - wrong focus with key up.

Can you check again?
I can't reproduce that.

Nov 20 2018, 7:06 AM · efl (efl-1.22), Restricted Project
YOhoho added a comment to D7267: elm_legacy: use the new api.

Please check my last comment.

Nov 20 2018, 6:56 AM · efl
YOhoho accepted D7272: elm_gengrid: transform P233 into a testcase.
Nov 20 2018, 5:49 AM · efl
YOhoho added inline comments to D7272: elm_gengrid: transform P233 into a testcase.
Nov 20 2018, 4:48 AM · efl
YOhoho added inline comments to D7233: elm-test: add a test for checking the event handling.
Nov 20 2018, 4:46 AM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

There are some compiler warnings

Nov 20 2018, 4:40 AM · efl
YOhoho accepted D7263: efl_ui_focus_object: add new event.
Nov 20 2018, 4:13 AM · efl
YOhoho accepted D7231: elm_gen****: ensure that no focus item is handled correctly.
Nov 20 2018, 4:07 AM · efl
YOhoho accepted D7230: efl_ui_focus_manager: make active getter work correctly.
Nov 20 2018, 4:06 AM · efl
YOhoho accepted D7271: elm_gengrid: enable focus api for none realized items.

P233 works well. Thank you :)

Nov 20 2018, 4:05 AM · efl
YOhoho accepted D7233: elm-test: add a test for checking the event handling.

Because this test is related to legacy signals("focused", "unfocused"), I thought it might work on old code in order to keep backward compatibility. but there is issue to check composition focus, It is hard to ensure to consistency.
This test works well with focus manager. Thank you for the test.

Nov 20 2018, 4:03 AM · efl

Nov 14 2018

YOhoho added a comment to T7391: gengrid: gengrid item is not unfocused when gengrid unfocused.

apologies, i don't remember whether we have been talking about focus and realization. you means D6737?

Nov 14 2018, 10:16 PM · Restricted Project
YOhoho accepted D7266: elm_gen****: correctly return the focus parent.
Nov 14 2018, 9:50 PM · efl
YOhoho added a comment to D7179: efl_ui_focus_manager: calculate new widgets undependend from dirty state.
Nov 14 2018, 9:43 PM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

Because this test is written in the environment where all of top_win_focused related legacy focus API backward compatibility is broken, it is hard to say that meaningful test. if you fix that, this test will be failed.

Nov 14 2018, 9:34 PM · efl

Nov 13 2018

YOhoho reopened T7391: gengrid: gengrid item is not unfocused when gengrid unfocused as "Open".

This problem still occurs.

  1. Click Unfocus gegrid button.
  2. Click Print focused_item button.
  3. I got focused item : 0x40000004b2d4 output.
Nov 13 2018, 10:35 PM · Restricted Project
YOhoho requested review of D7268: elm_gengrid: remove all_items_deselect call in _gengrid_element_focused.
Nov 13 2018, 10:30 PM · efl
YOhoho added a comment to D7266: elm_gen****: correctly return the focus parent.

I'm sorry. i don't understand this patch. can you provide the details what issue is fixed with this patch?

Nov 13 2018, 9:28 PM · efl
YOhoho added a comment to D7233: elm-test: add a test for checking the event handling.

You just test legacy focus with focus manager. in order to check backward compatibility, it should work on legacy focus before being implemented focus manager . isn't it?

Nov 13 2018, 8:52 PM · efl