Page MenuHomePhabricator

YOhoho (YeongJong Lee)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 4 2016, 7:39 AM (154 w, 6 d)
Availability
Available

Recent Activity

Today

YOhoho claimed T7753: efl.ui.panel example in elementary_test hangs infinitely.
Sun, Mar 24, 9:05 PM · efl (efl-1.22), efl: widgets
YOhoho requested review of D8461: efl_ui_container_layout: use correct property.
Sun, Mar 24, 9:04 PM · efl
YOhoho added a revision to T7756: 'part background' in elementary_test spews lots of errors and doesn't display correctly: D8461: efl_ui_container_layout: use correct property.
Sun, Mar 24, 9:04 PM · efl (efl-1.22), efl: widgets
YOhoho claimed T7756: 'part background' in elementary_test spews lots of errors and doesn't display correctly.
Sun, Mar 24, 3:56 PM · efl (efl-1.22), efl: widgets

Fri, Mar 22

YOhoho updated the diff for D8433: efl.pack_linear: enhance documentation.

update docs

Fri, Mar 22, 1:23 PM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

add efl_pack_unpack_at unit test

Fri, Mar 22, 2:32 AM · efl
YOhoho added inline comments to D8433: efl.pack_linear: enhance documentation.
Fri, Mar 22, 2:16 AM · efl
YOhoho updated the diff for D8433: efl.pack_linear: enhance documentation.

Thank you for suggestion

Fri, Mar 22, 2:08 AM · efl
YOhoho added inline comments to D8433: efl.pack_linear: enhance documentation.
Fri, Mar 22, 2:07 AM · efl

Thu, Mar 21

bu5hm4n awarded D8433: efl.pack_linear: enhance documentation a Orange Medal token.
Thu, Mar 21, 2:24 AM · efl

Wed, Mar 20

YOhoho removed a parent revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8094: ui.box_stack: refactor layout_update.
Wed, Mar 20, 9:53 PM · efl
YOhoho removed a child revision for D8094: ui.box_stack: refactor layout_update: D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Wed, Mar 20, 9:53 PM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

split documentation patch

Wed, Mar 20, 9:52 PM · efl
YOhoho added a child revision for D8433: efl.pack_linear: enhance documentation: D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Wed, Mar 20, 9:52 PM · efl
YOhoho requested review of D8433: efl.pack_linear: enhance documentation.
Wed, Mar 20, 9:48 PM · efl
YOhoho added inline comments to D8094: ui.box_stack: refactor layout_update.
Wed, Mar 20, 5:04 AM · efl
YOhoho requested review of D8420: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 3:21 AM · efl
YOhoho added a revision to T5328: Refactor/rename container, pack, ... interface: D8420: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 3:21 AM · efl, Restricted Project
YOhoho added a revision to T5719: Force all apis to be implemented: D8420: efl.pack_table: inherit efl.pack instead of efl.pack_linear.
Wed, Mar 20, 3:21 AM · Restricted Project, efl: language bindings, Restricted Project
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

use efl_key_data_set

Wed, Mar 20, 1:36 AM · efl
YOhoho accepted D8419: efl_con: fixup copy'n paste error.

Thanks

Wed, Mar 20, 12:41 AM · efl
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

Oh, sorry. my bad. i didn't install latest EFL. ignore my comment above :(

Wed, Mar 20, 12:21 AM · Restricted Project, efl (efl-1.22), efl: api
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

simple usecase:

Wed, Mar 20, 12:07 AM · Restricted Project, efl (efl-1.22), efl: api

Tue, Mar 19

YOhoho requested changes to D8411: efl_net: resolve cases where we passed something as event_info.

EFL_NET_DIALER_EVENT_DIALER_CONNECTED is duplicated.

Tue, Mar 19, 11:25 PM · efl
YOhoho reopened D8411: efl_net: resolve cases where we passed something as event_info.

It seems that this patch occurs test failure of ecore_con_suite

Tue, Mar 19, 11:11 PM · efl
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

Do not use local variable address as event_info. you can't access that outside the function.

Tue, Mar 19, 11:06 PM · Restricted Project, efl (efl-1.22), efl: api
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

add direction, homogeneous unit test

Tue, Mar 19, 10:33 PM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

.

Tue, Mar 19, 10:04 PM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

edit commit message

Tue, Mar 19, 10:01 PM · efl
YOhoho requested review of D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Tue, Mar 19, 9:54 PM · efl
YOhoho added a child revision for D8094: ui.box_stack: refactor layout_update: D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Tue, Mar 19, 9:54 PM · efl

Mon, Mar 18

YOhoho updated the diff for D8094: ui.box_stack: refactor layout_update.

Rebase and use restricted_min_set

Mon, Mar 18, 6:22 PM · efl
Herald removed a project from T7499: solve compiler (gcc) warnings between __attribute__ ((__malloc__)) and __attribute__ ((__pure__)): Restricted Project.
Mon, Mar 18, 6:22 PM · efl (efl-1.22)
YOhoho abandoned D8385: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist.

Oh, i didn't notice that patches.

Mon, Mar 18, 12:11 AM · efl

Sun, Mar 17

YOhoho updated the diff for D8385: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist.

.

Sun, Mar 17, 10:23 PM · efl
YOhoho requested review of D8385: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist.
Sun, Mar 17, 10:20 PM · efl
YOhoho accepted D8383: elm_focus: document that focus_region_show_mode more.
Sun, Mar 17, 1:58 PM · efl
YOhoho abandoned D8286: elm_main: fix backward compatibility of elm_object_focus_region_show_mode_set/get.

There is a unit test failure reported by tizen unit test.

Evas_Object *list = elm_list_add(p);
elm_object_focus_region_show_mode_set(list, ELM_FOCUS_REGION_SHOW_ITEM);
if (elm_object_focus_region_show_mode_get(list) != ELM_FOCUS_REGION_SHOW_ITEM)
  test fail
Sun, Mar 17, 7:17 AM · efl
YOhoho accepted D8371: eio: work around the lack of integration between Ecore_Thread and Eina_Future..

Because i don't have enough understanding of eio, I just checked that eio deadlock issues are resolved with this series of patches.

Sun, Mar 17, 7:03 AM · efl
YOhoho added a comment to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

Why don't you use EINA_LOG_ABORT and EINA_LOG_ABORT_LEVEL?

Sun, Mar 17, 6:22 AM · efl

Fri, Mar 15

YOhoho requested review of D8364: efl_ui_text_alert_popup: use correct theme klass name.
Fri, Mar 15, 3:52 AM · efl

Wed, Mar 13

YOhoho updated the diff for D8326: efl_ui_layout: fix elm_layout_text_set behavior.

agreed

Wed, Mar 13, 3:10 PM · efl
YOhoho closed D8283: ui.widget: fix theme_apply working in sub_object_add.
Wed, Mar 13, 9:02 AM · efl
YOhoho updated the diff for D8326: efl_ui_layout: fix elm_layout_text_set behavior.

It can return content type(swallow).

Wed, Mar 13, 8:29 AM · efl
YOhoho updated the diff for D8326: efl_ui_layout: fix elm_layout_text_set behavior.

call efl_ref

Wed, Mar 13, 7:44 AM · efl
YOhoho updated the diff for D8326: efl_ui_layout: fix elm_layout_text_set behavior.

remove efl_canvas_layout_part_invalid.eo.h

Wed, Mar 13, 3:32 AM · efl
YOhoho requested review of D8326: efl_ui_layout: fix elm_layout_text_set behavior.
Wed, Mar 13, 12:48 AM · efl

Tue, Mar 12

YOhoho abandoned D8278: ui.widget: refactor widget_parent_set.

The issues are fixed.

Tue, Mar 12, 7:08 PM · efl
YOhoho abandoned D8302: evas_events: fix correct event_freeze_count comparison.

A special case is like

evas_object_freeze_events_set(obj, EINA_TRUE);
evas_object_freeze_events_set(obj, EINA_TRUE);
evas_object_freeze_events_set(obj, EINA_FALSE);
ret = evas_object_freeze_events_get(obj);

The result of evas_object_freeze_events_get(obj) should return EINA_FALSE, but now it return EINA_TRUE.
I found another solution to resolve this issue. Please check D8325 instead.

Tue, Mar 12, 7:04 PM · efl
YOhoho requested review of D8325: evas_events: prevent double event_freeze in evas_object_freeze_events_set.
Tue, Mar 12, 7:04 PM · efl
YOhoho added a comment to D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets.

I love this commit, as it reduces the amount of spagethi code in elm. However, i am super scared to land this before the release, are you okay with delaying it once the release is out ?

Tue, Mar 12, 5:23 AM · DO NOT MERGE, efl
YOhoho requested review of D8303: elm_conform: remove duplicated constructor call.
Tue, Mar 12, 12:14 AM · efl

Mon, Mar 11

YOhoho added a comment to D8302: evas_events: fix correct event_freeze_count comparison.

see also, line 3751

Mon, Mar 11, 11:47 PM · efl
YOhoho requested review of D8302: evas_events: fix correct event_freeze_count comparison.
Mon, Mar 11, 11:46 PM · efl
YOhoho updated the diff for D8283: ui.widget: fix theme_apply working in sub_object_add.

use ck_assert instead of ck_assert_double_eq

Mon, Mar 11, 2:21 PM · efl
YOhoho requested review of D8286: elm_main: fix backward compatibility of elm_object_focus_region_show_mode_set/get.
Mon, Mar 11, 5:03 AM · efl
YOhoho updated the diff for D8094: ui.box_stack: refactor layout_update.

rebase

Mon, Mar 11, 3:51 AM · efl
YOhoho updated the diff for D8281: ui.widget: enhance documentation of sub_object_add.

update docs.

Mon, Mar 11, 3:41 AM · efl
YOhoho added a comment to D8281: ui.widget: enhance documentation of sub_object_add.

And a proposal for sub_object_del:

Virtual function customizing sub objects being removed.

When a widget is removed as a sub-object from another widget, some of its
properties are automatically adjusted.

+ (like focus, access, tree dump)

Mon, Mar 11, 3:16 AM · efl
YOhoho updated the diff for D8281: ui.widget: enhance documentation of sub_object_add.

remove name find, orientation set and deletion

Mon, Mar 11, 2:51 AM · efl
YOhoho updated the diff for D8283: ui.widget: fix theme_apply working in sub_object_add.

split unit test

Mon, Mar 11, 2:44 AM · efl
YOhoho added inline comments to D8283: ui.widget: fix theme_apply working in sub_object_add.
Mon, Mar 11, 2:33 AM · efl

Sun, Mar 10

YOhoho updated the diff for D8283: ui.widget: fix theme_apply working in sub_object_add.

Depends on D8282

Sun, Mar 10, 8:58 PM · efl
YOhoho added a child revision for D8282: ui.widget: add exception handling code and unit test of sub_object_add/del function: D8283: ui.widget: fix theme_apply working in sub_object_add.
Sun, Mar 10, 8:58 PM · efl
YOhoho requested review of D8283: ui.widget: fix theme_apply working in sub_object_add.
Sun, Mar 10, 8:56 PM · efl
YOhoho requested review of D8282: ui.widget: add exception handling code and unit test of sub_object_add/del function.
Sun, Mar 10, 5:59 PM · efl
YOhoho requested review of D8281: ui.widget: enhance documentation of sub_object_add.
Sun, Mar 10, 4:46 PM · efl
YOhoho requested review of D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets.
Sun, Mar 10, 4:38 PM · DO NOT MERGE, efl
YOhoho added a comment to D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.

What is the difference between unpack and clear ? It looks to me a bit dangerous that one function unsets the widget parent, the other is not.

Sun, Mar 10, 4:10 PM · efl
YOhoho planned changes to D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.

I need to verify redirect_to_top function.

Sun, Mar 10, 8:33 AM · efl
YOhoho added a comment to D8278: ui.widget: refactor widget_parent_set.

I think you got my intention wrong. My intention with the commit that you reverted is, that in any case the setter of parent_widget_set is going to be called. and actually *sets* the parent, there is no changing to this field outside of the setter function.

I understand what do you want do. internal variable(parent_obj) have to be changed by only setter function(widget_parent_set).

Sun, Mar 10, 8:22 AM · efl

Sat, Mar 9

YOhoho updated the diff for D8278: ui.widget: refactor widget_parent_set.

empty line

Sat, Mar 9, 9:46 PM · efl
YOhoho requested review of D8278: ui.widget: refactor widget_parent_set.
Sat, Mar 9, 9:43 PM · efl
YOhoho updated the diff for D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.

fix unpack_all of ui.table

Sat, Mar 9, 2:03 AM · efl
YOhoho updated the diff for D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.

remove btn3 that is a duplicate of btn2

Sat, Mar 9, 1:24 AM · efl

Fri, Mar 8

YOhoho planned changes to D8217: elm_widget: fix correct parent when widget parent changed.
Fri, Mar 8, 1:37 AM · efl

Thu, Mar 7

YOhoho updated the diff for D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.

Just add unit test related to this patch

Thu, Mar 7, 9:19 PM · efl
YOhoho updated the diff for D8238: elm_gengrid: fix correct parent-child relation of item content.

add unit test

Thu, Mar 7, 6:39 PM · efl
YOhoho added a comment to D8217: elm_widget: fix correct parent when widget parent changed.

What i mean is: Not every widget redirects a widget to the top widget when its unpacked, which means, only box (and a handfull of others) will do that. Which is kind of weird and unexpected to the user. (As an example: gengrid does not do this, efl_ui_table does not do this)

So for me there are two possible solutions here:

  • Accept that a widget needs to be recreated when the widget-parent dies.
  • Redirect every sobj in elm_widget_sub_object_del to the top level widget, so we have a consistency over *every* widget, and not just box.
Thu, Mar 7, 10:01 AM · efl
YOhoho abandoned D8215: evas,ecore legacy: add missing legacy header.

build issue will be fixed by D8222

Thu, Mar 7, 9:54 AM · efl
YOhoho requested review of D8238: elm_gengrid: fix correct parent-child relation of item content.
Thu, Mar 7, 9:47 AM · efl
segfaultxavi awarded D8094: ui.box_stack: refactor layout_update a Yellow Medal token.
Thu, Mar 7, 9:35 AM · efl
YOhoho requested review of D8237: ui.widget: set the parent-child relation again, when the widget is unpacked.
Thu, Mar 7, 9:28 AM · efl
YOhoho added a comment to D8217: elm_widget: fix correct parent when widget parent changed.

Mhm, the so parent should never change, its basically settled and used by the user, I am not sure if we should manipulate this here. EFL_parent is never adjusted in elm APIs at all ...

Thu, Mar 7, 8:11 AM · efl
YOhoho updated the diff for D8219: ui.box_flow: refactor layout_update.

use efl_event_callback_call instead of legacy_call

Thu, Mar 7, 3:33 AM · efl
YOhoho added a comment to D8216: ui.box,table: update layout when homogeneous mode is changed..

elementary_test -to efl.ui.box does not work for me with or without this patch. I get this error when I tick the Homogeneous checkbox:

src/lib/elementary/efl_ui_box_flow.eo.c:20 efl_ui_box_flow_homogenous_set() Unable to resolve op for api func 0x7fcb1c01eb42 for obj=0x400000d89abe (Efl.Ui.Box)

And nothing changes on the screen.

homogeneous checkbox will work with D8219

Thu, Mar 7, 3:22 AM · efl
YOhoho added a comment to D8219: ui.box_flow: refactor layout_update.

Test Plan 2. will work with D8217

Thu, Mar 7, 3:19 AM · efl
YOhoho added a comment to D8216: ui.box,table: update layout when homogeneous mode is changed..
Thu, Mar 7, 3:18 AM · efl
YOhoho updated the diff for D8094: ui.box_stack: refactor layout_update.

Depends on D8214

Thu, Mar 7, 3:07 AM · efl
YOhoho added a child revision for D8214: ui.box, ui.table: respect user min: D8094: ui.box_stack: refactor layout_update.
Thu, Mar 7, 3:07 AM · efl
YOhoho updated the diff for D8094: ui.box_stack: refactor layout_update.

more unit test

Thu, Mar 7, 3:06 AM · efl
YOhoho requested review of D8219: ui.box_flow: refactor layout_update.
Thu, Mar 7, 2:52 AM · efl
YOhoho added a child revision for D8214: ui.box, ui.table: respect user min: D8219: ui.box_flow: refactor layout_update.
Thu, Mar 7, 2:52 AM · efl
YOhoho requested review of D8218: test/elm_box: clean up elm_box_disabled_test.
Thu, Mar 7, 2:44 AM · efl
YOhoho requested review of D8217: elm_widget: fix correct parent when widget parent changed.
Thu, Mar 7, 2:35 AM · efl
YOhoho requested review of D8216: ui.box,table: update layout when homogeneous mode is changed..
Thu, Mar 7, 2:13 AM · efl
YOhoho added a reviewer for D8215: evas,ecore legacy: add missing legacy header: segfaultxavi.
Thu, Mar 7, 2:01 AM · efl

Wed, Mar 6

YOhoho requested review of D8215: evas,ecore legacy: add missing legacy header.
Wed, Mar 6, 6:26 PM · efl
YOhoho updated the diff for D8214: ui.box, ui.table: respect user min.

Depends on D8170

Wed, Mar 6, 5:40 PM · efl
YOhoho updated the diff for D8214: ui.box, ui.table: respect user min.

Depends on D8170

Wed, Mar 6, 5:39 PM · efl