Page MenuHomePhabricator

YOhoho (YeongJong Lee)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 4 2016, 7:39 AM (129 w, 11 h)
Availability
Available

Recent Activity

Wed, Sep 19

YOhoho triaged T7391: gengrid: gengrid item is not unfocused when gengrid unfocused as High priority.
Wed, Sep 19, 12:21 AM · Restricted Project
YOhoho added a project to T7390: gengrid: gengrid can't get focus if there is no focusable content in item.: Restricted Project.
Wed, Sep 19, 12:21 AM · Restricted Project
YOhoho added a project to T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager: Restricted Project.
Wed, Sep 19, 12:21 AM · Restricted Project
YOhoho added a project to T7386: Elm_Spinner does not emit "focused" "unfocused" signal when focused: Restricted Project.
Wed, Sep 19, 12:20 AM · Restricted Project
YOhoho added a project to T7385: Elm_Gengrid does not emit "focused" "unfocused" signal when focused: Restricted Project.
Wed, Sep 19, 12:20 AM · Restricted Project

Thu, Sep 13

YOhoho triaged T7397: focus coordinate movement issue as High priority.
Thu, Sep 13, 4:34 AM · Restricted Project
YOhoho removed a reviewer for D7028: evas_object_callbacks: do not error on NULL on del: YOhoho.
Thu, Sep 13, 2:25 AM · efl
YOhoho added a comment to D7028: evas_object_callbacks: do not error on NULL on del.

And otherwise the programmer will end up with a shitload of error messages in the console, where basically none of them is telling him something useful.

This is basically the same thing as efl_del accepting a NULL as parameter. If you have wasted thing pointer, then it is your fault, API cannot handle every error. It is way more common to have deletion APIs accepting NULL than have them erroring.

Then Can we remove safety macro for func?

Thu, Sep 13, 2:25 AM · efl
YOhoho added inline comments to D6781: elm_genlist: unfocus item when genlist is unfocused.
Thu, Sep 13, 1:29 AM · efl

Wed, Sep 12

YOhoho requested changes to D7028: evas_object_callbacks: do not error on NULL on del.

How the api know callback is deleting?

Wed, Sep 12, 4:27 PM · efl

Tue, Sep 11

YOhoho created T7391: gengrid: gengrid item is not unfocused when gengrid unfocused.
Tue, Sep 11, 4:08 AM · Restricted Project
YOhoho triaged T7390: gengrid: gengrid can't get focus if there is no focusable content in item. as High priority.
Tue, Sep 11, 3:57 AM · Restricted Project
YOhoho triaged T7389: elm_object_focus_next_object_set does not work for a widget that is logical node on focus manager as High priority.
Tue, Sep 11, 3:33 AM · Restricted Project
YOhoho updated subscribers of T7385: Elm_Gengrid does not emit "focused" "unfocused" signal when focused.
Tue, Sep 11, 12:40 AM · Restricted Project
YOhoho triaged T7386: Elm_Spinner does not emit "focused" "unfocused" signal when focused as High priority.
Tue, Sep 11, 12:40 AM · Restricted Project
YOhoho requested review of D7019: spinner_example: add focused, unfocused callback to test focus signal.
Tue, Sep 11, 12:37 AM · efl
YOhoho updated the diff for D7018: test_gengrid: add focused, unfocused callback to test focus signal.

fix wrong variable usage

Tue, Sep 11, 12:22 AM · efl
YOhoho triaged T7385: Elm_Gengrid does not emit "focused" "unfocused" signal when focused as High priority.
Tue, Sep 11, 12:02 AM · Restricted Project
YOhoho requested review of D7018: test_gengrid: add focused, unfocused callback to test focus signal.
Tue, Sep 11, 12:01 AM · efl

Mon, Sep 10

YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

ping @bu5hm4n
Any other idea?

Mon, Sep 10, 9:42 PM · DO NOT MERGE, efl
YOhoho accepted D7009: efl_ui_focus_util: refactor the util for focusing objects.
Mon, Sep 10, 8:17 AM · efl
YOhoho added inline comments to D7009: efl_ui_focus_util: refactor the util for focusing objects.
Mon, Sep 10, 6:02 AM · efl
YOhoho requested review of D7015: elm: add missing efl_ui_popup_part_backwall header.
Mon, Sep 10, 1:51 AM · efl
YOhoho added inline comments to D7009: efl_ui_focus_util: refactor the util for focusing objects.
Mon, Sep 10, 1:36 AM · efl
YOhoho updated the diff for D6961: edje: call recalc in part_text_get if there is no available text data.
  1. Add brackets.
  2. Add condition for check dirty or invalidate.
Mon, Sep 10, 12:21 AM · efl

Thu, Sep 6

YOhoho accepted D6903: efl_ui_focus_manager: do not adjust values on a inactive manager.
Thu, Sep 6, 9:20 AM · efl
YOhoho added inline comments to D6903: efl_ui_focus_manager: do not adjust values on a inactive manager.
Thu, Sep 6, 8:56 AM · efl
YOhoho abandoned D6987: elm_scroller: do not auto-scroll when scroller get focus first.

There is still issue :(

Thu, Sep 6, 5:57 AM · efl

Wed, Sep 5

YOhoho abandoned D6812: elm_scroller: remove unnecessary code.

see D6987 instead

Wed, Sep 5, 4:14 AM · efl
YOhoho requested review of D6987: elm_scroller: do not auto-scroll when scroller get focus first.
Wed, Sep 5, 4:13 AM · efl
YOhoho added a revision to T7274: popup with items: D6987: elm_scroller: do not auto-scroll when scroller get focus first.
Wed, Sep 5, 4:13 AM · efl
YOhoho added a comment to T7362: elm_panes: contact resizing issue.

hmm, i spent a day to find reason for this issue but i can't.
Just one point i found is this is not panes issue. when filepanel scroll bar is visible, the empty space is shown. the empty space doesn't show when i insert elm_scroller_policy_set(list, ELM_SCROLLER_POLICY_OFF, ELM_SCROLLER_POLICY_OFF); on edi_filepanel.c:1209. (this is not solution. just test)
I guess it is scroller issue.

Wed, Sep 5, 12:19 AM · efl: widgets

Mon, Sep 3

YOhoho requested review of D6968: edje_calc: remove unused variable.
Mon, Sep 3, 7:35 PM · efl
YOhoho updated the task description for T7362: elm_panes: contact resizing issue.
Mon, Sep 3, 3:23 PM · efl: widgets
YOhoho closed T7349: efl_app_suite failing as Resolved by committing rEFL3f306491a32a: ecore_event: fix ecore event handler iterator range.
Mon, Sep 3, 9:31 AM · regression, Testing, efl (efl-1.22)
YOhoho closed D6966: ecore_event: fix ecore event handler iterator range.
Mon, Sep 3, 9:31 AM · efl
YOhoho updated the diff for D6966: ecore_event: fix ecore event handler iterator range.

fix range..

Mon, Sep 3, 8:55 AM · efl
YOhoho added a comment to D6964: Revert "ecore: fix built-in event types generation".

Please check D6966 before revert it.

Mon, Sep 3, 8:41 AM · efl
YOhoho requested review of D6966: ecore_event: fix ecore event handler iterator range.
Mon, Sep 3, 8:39 AM · efl
YOhoho added a revision to T7349: efl_app_suite failing: D6966: ecore_event: fix ecore event handler iterator range.
Mon, Sep 3, 8:39 AM · regression, Testing, efl (efl-1.22)
YOhoho added inline comments to D6903: efl_ui_focus_manager: do not adjust values on a inactive manager.
Mon, Sep 3, 4:15 AM · efl
YOhoho added inline comments to D6903: efl_ui_focus_manager: do not adjust values on a inactive manager.
Mon, Sep 3, 4:02 AM · efl
YOhoho requested review of D6961: edje: call recalc in part_text_get if there is no available text data.
Mon, Sep 3, 1:12 AM · efl

Sun, Sep 2

YOhoho requested review of D6960: docs: Fix typos in API reference doc.
Sun, Sep 2, 5:45 PM · efl

Thu, Aug 30

YOhoho requested review of D6955: elm_interface_scrollable: fix wrong pointer reference.
Thu, Aug 30, 6:29 PM · efl
YOhoho requested review of D6954: elm_interface_scrollable: add 1 space after if keyword.
Thu, Aug 30, 6:15 PM · efl
YOhoho requested changes to D6903: efl_ui_focus_manager: do not adjust values on a inactive manager.

I found issue you said when i close hoversel list. It works correctly with this path.

Thu, Aug 30, 9:58 AM · efl
YOhoho updated the diff for D6781: elm_genlist: unfocus item when genlist is unfocused.

unset focus_on_realization.

Thu, Aug 30, 8:41 AM · efl
YOhoho added a comment to D6704: elementary: Check for valid focus manager before starting do loop.

Okay, deeply checked this. There seems to be a bug when focusing gengrid manually.

https://phab.enlightenment.org/P230

That function body works for me, does that also work for you ?

(Sorry for pinging arround on this one)

Thu, Aug 30, 8:06 AM · Restricted Project
YOhoho updated the diff for D6948: docs: Fix typos in API reference doc and comments..

Fixed :)

Thu, Aug 30, 4:18 AM · efl
YOhoho requested review of D6948: docs: Fix typos in API reference doc and comments..
Thu, Aug 30, 1:21 AM · efl

Wed, Aug 29

YOhoho requested review of D6944: elm_panel: fix mirrored_set work correctly.
Wed, Aug 29, 9:50 PM · efl

Sun, Aug 26

YOhoho requested review of D6909: evas: call evas_find before safety check.
Sun, Aug 26, 6:40 PM · efl

Aug 22 2018

YOhoho requested review of D6898: ecore_buffer: move include to out side of extern "C".
Aug 22 2018, 8:09 PM · efl

Aug 20 2018

YOhoho added a comment to D6781: elm_genlist: unfocus item when genlist is unfocused.

This patch has a bug. I will update after fix it.

Aug 20 2018, 8:24 PM · efl
YOhoho planned changes to D6781: elm_genlist: unfocus item when genlist is unfocused.
Aug 20 2018, 4:42 PM · efl
YOhoho requested review of D6872: efl_ui_focus_composition: remove unused variable.
Aug 20 2018, 4:36 AM · efl
YOhoho accepted D6755: efl_ui_composition: remove all children in invalidate.

Oh, I didn't notice that. this patch will prevent memory leaks.
Thank you to answer my questions :D

Aug 20 2018, 2:43 AM · efl
YOhoho added a comment to D6755: efl_ui_composition: remove all children in invalidate.

All of widget that inherit Efl.Ui.Focus.Composition inherit Efl.Ui.Widget Class which inherits Efl.Canvan.Object. it means we don't need to care whether children is removed because it is already removed.

Sorry, my last explain is wrong. i wanted to say

Aug 20 2018, 1:04 AM · efl
YOhoho accepted D6868: elm/win: check object class before using it.

Looks good to me.
Could you push this patch?
I don't have land permission :|

Aug 20 2018, 12:15 AM · efl

Aug 19 2018

YOhoho added a comment to D6755: efl_ui_composition: remove all children in invalidate.

Yes, every case. As the children are invalidating after the function call to invalidate.

Aug 19 2018, 6:24 PM · efl
YOhoho requested changes to D6868: elm/win: check object class before using it.

Please use EINA_SAFETY_ON_FALSE_RETURN_VAL macro. we can detect in log if non-Efl.Ui.Win object is used.

Aug 19 2018, 4:14 PM · efl

Aug 16 2018

YOhoho updated the summary of D6816: evas: check evas class before evas_find.
Aug 16 2018, 9:01 AM · efl
YOhoho updated the diff for D6816: evas: check evas class before evas_find.

Check evas class before evas_find

Aug 16 2018, 8:59 AM · efl
YOhoho updated the diff for D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

Use ecore_main_loop_begin/quit

Aug 16 2018, 8:15 AM · efl
YOhoho added a comment to D6755: efl_ui_composition: remove all children in invalidate.

Is there any case that registered_targets exists on _efl_ui_focus_composition_efl_object_invalidate?

Aug 16 2018, 8:10 AM · efl
YOhoho added a comment to D6726: elementary image: apply lazy calculation and guarantee retained method..

Hi guys,

I have some issue with that patch. What I do in my code is that:

Evas_Object *image = elm_image_add(obj);
Eo *evas_img = elm_image_object_get(image);
evas_object_image_size_set(evas_img, ad->icon.w, ad->icon.h);
evas_object_image_data_set(evas_img, ad->icon.pixels);
evas_object_show(image);
return image;

This is done in the content get of a gengrid. My problem is that evas_img is now NULL. Before, I had access to that.
Is there something wrong with my code?

Thanks

Aug 16 2018, 5:50 AM · efl
YOhoho assigned T6804: focus(scroller): backward compatibility for scroller focus move to eagleeye.
Aug 16 2018, 1:36 AM · Restricted Project

Aug 15 2018

YOhoho added a comment to D6815: efl_ui_focus_manager_calc: prevent focus lost.

But I see what you want to do. There is the event in the focus manager FOCUS_CHECKED, it has the old focused element as event information. If you subscribe there on the active manager, then do this recovery when it FOCUS_CHANGED to something where the current focus is NULL. Then you can do the recovery i guess. Does that sound good to you ?

Aug 15 2018, 10:51 PM · efl
YOhoho added a comment to D6815: efl_ui_focus_manager_calc: prevent focus lost.

You should rebase this patch probebly on its depending patches, so the diff here gets displayed correctly.

From time to time this patch still has a issue. enter something in the elm test entry and try to get into the buttons with tab, get back to the entry, change the text, continue this, at some point you cannot get back into the buttons.

Can i get more information about this? i can't reproduce..

Also, theoretically: Lets say we have a genlist with items, that had focus at some point. focus is now on a button, you click it, the genlist gets its items destroyed. And even if you now have the focus on the button at some point the evas focus will end up on the genlist, since all buttons are destroyed, including the one that was focused at last.

I think the evas focus won't end up on the genlist. because button and genlist use same evas. it means evas_focus_get(evas_object_evas_get(pd->root->focusable)) return true even if pd->root->focusable is genlist.

Aug 15 2018, 10:47 PM · efl
YOhoho updated subscribers of D6587: elm_scroller: fix arrow key interaction.

@bu5hm4n
What do you think that scroller maintainer(@eagleeye) grab T6804?
I think he has background about legacy focus policy of scoller so that he can deal with scroller focus policy issue.

Aug 15 2018, 9:49 PM · efl
YOhoho requested changes to D6587: elm_scroller: fix arrow key interaction.

There are still issue. a object which is outside of scroller viewport can get focus. the object should not get focus because the Scroller user don't know what happen outside of scroller.

Aug 15 2018, 9:43 PM · efl
YOhoho added a comment to D6812: elm_scroller: remove unnecessary code.

@akanad ping

Aug 15 2018, 8:18 PM · efl
YOhoho requested changes to D6755: efl_ui_composition: remove all children in invalidate.

It seems that all children are removed during focus_manager_eval after d3f8ca29025a.

Aug 15 2018, 8:02 PM · efl
YOhoho requested review of D6844: elm_image: add EINA_UNUSED to avoid build warning.
Aug 15 2018, 9:48 AM · efl
YOhoho requested review of D6843: tests/image: remove unused variable.
Aug 15 2018, 9:44 AM · efl
YOhoho updated the diff for D6828: elm_image: create image object before call elm_image_object_get.

Add unit test

Aug 15 2018, 9:36 AM · efl
YOhoho updated the diff for D6781: elm_genlist: unfocus item when genlist is unfocused.

rebase

Aug 15 2018, 9:19 AM · efl

Aug 14 2018

YOhoho abandoned D6780: efl_ui_focus_manager_calc: unfocus object if the node unregister from focus tree.
Aug 14 2018, 7:05 PM · efl
YOhoho requested review of D6834: efl_ui_image: avoid a call to NULL.
Aug 14 2018, 6:18 PM · efl
YOhoho updated the summary of D6828: elm_image: create image object before call elm_image_object_get.
Aug 14 2018, 6:11 PM · efl
YOhoho updated the diff for D6828: elm_image: create image object before call elm_image_object_get.

see also D6834

Aug 14 2018, 6:10 PM · efl
YOhoho added a comment to D6828: elm_image: create image object before call elm_image_object_get.
In D6828#118010, @zmike wrote:

This seems reasonable overall, though it seems to me like the load_controller_load_size_set change could just return since the sizing eval will be guaranteed to happen later anyway and this will be an unnecessary operation.

Aug 14 2018, 5:59 PM · efl
YOhoho updated the diff for D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

Use Eina_Bool instead of String

Aug 14 2018, 4:24 PM · efl
YOhoho updated the diff for D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

Add unit test

Aug 14 2018, 9:30 AM · efl
YOhoho requested review of D6828: elm_image: create image object before call elm_image_object_get.
Aug 14 2018, 8:47 AM · efl
YOhoho added a comment to D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.

is there a unit test about this problem ?

Aug 14 2018, 7:19 AM · efl
YOhoho added a comment to D6815: efl_ui_focus_manager_calc: prevent focus lost.

Can we somehow at first proceed with the other patchset, and then continue with this new problem ? I don't want to pile up patches :)

Aug 14 2018, 5:56 AM · efl
YOhoho removed a parent revision for D6815: efl_ui_focus_manager_calc: prevent focus lost: D6802: efl_ui_focus_manager_calc: fix unregistering the root of a redirect.
Aug 14 2018, 5:54 AM · efl
YOhoho removed a child revision for D6802: efl_ui_focus_manager_calc: fix unregistering the root of a redirect: D6815: efl_ui_focus_manager_calc: prevent focus lost.
Aug 14 2018, 5:54 AM · efl
YOhoho updated subscribers of D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.
Aug 14 2018, 5:19 AM · efl
YOhoho requested review of D6824: ecore_pipe: remove null check condition and fix segfualt on Windows.
Aug 14 2018, 5:16 AM · efl
YOhoho updated the diff for D6816: evas: check evas class before evas_find.

replace with 'efl_isa(obj, EVAS_CANVAS_CLASS)'

Aug 14 2018, 3:10 AM · efl

Aug 12 2018

YOhoho abandoned D6804: evas_object_line: avoid using NULL parent..

I create other patch.
Please check D6816.

Aug 12 2018, 7:54 PM · efl
YOhoho updated the summary of D6816: evas: check evas class before evas_find.
Aug 12 2018, 7:52 PM · efl
YOhoho requested review of D6816: evas: check evas class before evas_find.
Aug 12 2018, 7:51 PM · efl
YOhoho added a comment to D6802: efl_ui_focus_manager_calc: fix unregistering the root of a redirect.

@YOhoho can you review again ? I removed the lines that have been causing the problems.

Aug 12 2018, 5:28 PM · efl
YOhoho requested review of D6815: efl_ui_focus_manager_calc: prevent focus lost.
Aug 12 2018, 5:24 PM · efl
YOhoho added a child revision for D6802: efl_ui_focus_manager_calc: fix unregistering the root of a redirect: D6815: efl_ui_focus_manager_calc: prevent focus lost.
Aug 12 2018, 5:24 PM · efl

Aug 10 2018

YOhoho added a comment to D6812: elm_scroller: remove unnecessary code.

@bu5hm4n
Why we need to call elm_widget_show_region_set?

Aug 10 2018, 9:48 AM · efl