Page MenuHomePhabricator

a.srour (Abdalrahman Srour)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 14 2019, 11:33 PM (42 w, 1 d)
Availability
Available

Recent Activity

Jan 20 2020

a.srour edited the content of Windows.
Jan 20 2020, 1:21 AM · efl

Jan 15 2020

a.srour reclaimed D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.
Jan 15 2020, 5:23 AM · efl
a.srour closed D11068: efl.ui.textbox: paste in mouse button 2.
Jan 15 2020, 5:22 AM · efl
a.srour reopened D11068: efl.ui.textbox: paste in mouse button 2.
Jan 15 2020, 5:22 AM · efl
a.srour edited the content of Windows.
Jan 15 2020, 5:16 AM · efl
a.srour edited the content of Windows.
Jan 15 2020, 5:15 AM · efl

Jan 14 2020

a.srour added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Thank you for not respecting my extra time fixing critical bugs to improve EFL, let's leave the showstopper issue unfixed!

Wow, I honestly don't know why this provoked such a over the top reaction. I merely asked you to respect the feedback you got. Marcel was explained it and you kept going that that is all unimportant.
We do code review in this project and expect from everyone to respect it, discuss it and improve the code.

This could have been landed already, but instead you kept discussing.

Jan 14 2020, 3:54 AM · efl
a.srour reassigned T8479: Edje: Fix TEXTBLOCK part properties from a.srour to AbdullehGhujeh.
Jan 14 2020, 3:36 AM
a.srour reassigned T8478: Edje: Issue with Edc text_class in Styles from a.srour to AbdullehGhujeh.
Jan 14 2020, 3:35 AM
a.srour reassigned T8110: Text Manipulation from a.srour to AbdullehGhujeh.
Jan 14 2020, 3:35 AM
a.srour updated the task description for T8571: Efl.Ui.Textbox: Ctrl+Backspace & Ctrl+Delete wrong behaviour.
Jan 14 2020, 3:30 AM · Bug Report, efl
a.srour abandoned D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Thank you for not respecting my extra time fixing critical bugs to improve EFL, let's leave the showstopper issue unfixed!

Jan 14 2020, 3:16 AM · efl
a.srour added a comment to T8571: Efl.Ui.Textbox: Ctrl+Backspace & Ctrl+Delete wrong behaviour.

@bu5hm4n & @segfaultxavi kindly check the above showstopper issue! Thanks

Jan 14 2020, 1:58 AM · Bug Report, efl
a.srour triaged T8571: Efl.Ui.Textbox: Ctrl+Backspace & Ctrl+Delete wrong behaviour as Showstopper Issues priority.
Jan 14 2020, 1:57 AM · Bug Report, efl
a.srour added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

GOLDEN**

Your comment does not help the project in any way.
Please bear in mind that very few of us are native English speakers and we all have to make an effort to understand each other.
Typos in code or documentation should be mercilessly pointed out and corrected. There's no point in bringing up typos in phabricator discussions, though. We're all bound to make them!

Jan 14 2020, 1:08 AM · efl
a.srour added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

@bu5hm4n i think this resolve your requested changes
i would like to mention that this patch is meant to fix a critical bug!

Jan 14 2020, 12:55 AM · efl
a.srour updated the diff for D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Rebase + move tests to different test case

Jan 14 2020, 12:53 AM · efl
a.srour added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

GOLDEN**

Jan 14 2020, 12:08 AM · efl

Jan 13 2020

a.srour added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Could you be more helpful and tell me what it should be? we need to fire key_down event for Efl.Ui.Textbox object to test what will be changed?
We couldn't find an example or another test that use key_down event or modifier_on

Jan 13 2020, 3:39 AM · efl

Jan 11 2020

a.srour updated the diff for D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Rebase

Jan 11 2020, 11:56 PM · efl

Jan 8 2020

a.srour requested review of D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.
Jan 8 2020, 1:16 AM · efl

Jan 7 2020

a.srour updated subscribers of D11036: Efl.Ui: Update Efl.Ui.Textbox tests.
Jan 7 2020, 8:09 AM · efl
a.srour requested review of D11036: Efl.Ui: Update Efl.Ui.Textbox tests.
Jan 7 2020, 8:08 AM · efl

Jan 5 2020

a.srour requested review of D11017: Fix worning and tests for edje text_class.
Jan 5 2020, 1:40 AM · efl

Jan 2 2020

a.srour created T8547: Efl.Ui.Selection: efl_ui_selection_get type clipboard not fired.
Jan 2 2020, 6:28 AM
a.srour updated the diff for D10598: edje: implement text_class override at object level.

Rebase & resolve changes request

Jan 2 2020, 1:11 AM · efl

Dec 26 2019

a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.
  • Update
Dec 26 2019, 12:30 AM · efl

Dec 24 2019

a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.

Rebase

Dec 24 2019, 2:05 AM · efl

Dec 23 2019

a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

This patch looks great, and I think I understand the issue described, but the changes made here must be described in the actual patch log since the cited issue ticket may not be reachable for as long as this code persists.

In short: please describe either the change that is being made or the problem being solved (ideally both) directly in the commit log.

Dec 23 2019, 7:07 AM · efl
a.srour updated the summary of D10692: Edje: edc text_class applied without font or font_size in style.
Dec 23 2019, 7:06 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Add tests for fix

Dec 23 2019, 3:04 AM · efl
a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.

Fix wrong checks

Dec 23 2019, 1:06 AM · efl

Dec 22 2019

a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.

Fix requested changes

Dec 22 2019, 11:51 PM · efl
a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.

Remove Fail comments, fix requested changes

Dec 22 2019, 11:47 PM · efl
a.srour updated the diff for D10950: Efl.Text.Cursor: Add tests for evas_suite.

Remove white spaces, remove printfs

Dec 22 2019, 8:27 AM · efl
a.srour requested review of D10950: Efl.Text.Cursor: Add tests for evas_suite.
Dec 22 2019, 8:21 AM · efl
a.srour updated the diff for D10946: Efl.Text.Cursor: Fix line_jump_by return logic.

use ck_assert_int_eq

Dec 22 2019, 3:42 AM · efl
a.srour updated the diff for D10946: Efl.Text.Cursor: Fix line_jump_by return logic.

Using ck_assert instead of ck_assert_int_eq

Dec 22 2019, 3:21 AM · efl
a.srour updated the diff for D10946: Efl.Text.Cursor: Fix line_jump_by return logic.

Add tests

Dec 22 2019, 1:58 AM · efl
a.srour updated subscribers of D10946: Efl.Text.Cursor: Fix line_jump_by return logic.
Dec 22 2019, 1:47 AM · efl
a.srour requested review of D10946: Efl.Text.Cursor: Fix line_jump_by return logic.
Dec 22 2019, 1:46 AM · efl

Dec 18 2019

a.srour updated the diff for D10896: Fix textblock style when "lang=x" is presented.

Use eina_stringshare_replace in font_lang_set
Move font normalization to format_push to affect all paths

Dec 18 2019, 12:33 AM · efl

Dec 17 2019

a.srour triaged T8536: Efl.Ui.Textbox: Segerror on scrollable as Showstopper Issues priority.
Dec 17 2019, 8:20 AM
a.srour updated subscribers of D10896: Fix textblock style when "lang=x" is presented.
Dec 17 2019, 4:48 AM · efl
a.srour requested review of D10896: Fix textblock style when "lang=x" is presented.
Dec 17 2019, 4:29 AM · efl

Dec 16 2019

a.srour added inline comments to D9719: edje/text_class: Add test case for text_class feature.
Dec 16 2019, 3:55 AM · efl
a.srour added a comment to D9719: edje/text_class: Add test case for text_class feature.

Also there is a patch with a fix to object_level overriding issue here D10598

Dec 16 2019, 3:41 AM · efl

Dec 3 2019

a.srour added a task to D10598: edje: implement text_class override at object level: T8481: Edje: Text_class Old API Object level override.
Dec 3 2019, 1:15 AM · efl
a.srour added a revision to T8481: Edje: Text_class Old API Object level override: D10598: edje: implement text_class override at object level.
Dec 3 2019, 1:15 AM
a.srour added a task to D10598: edje: implement text_class override at object level: T8480: Edje: Text_class New API file level override.
Dec 3 2019, 1:15 AM · efl
a.srour added a revision to T8480: Edje: Text_class New API file level override: D10598: edje: implement text_class override at object level.
Dec 3 2019, 1:15 AM
a.srour added a revision to T8478: Edje: Issue with Edc text_class in Styles : D10692: Edje: edc text_class applied without font or font_size in style.
Dec 3 2019, 1:14 AM
a.srour added a task to D10692: Edje: edc text_class applied without font or font_size in style: T8478: Edje: Issue with Edc text_class in Styles .
Dec 3 2019, 1:14 AM · efl
a.srour added revisions to T8477: Edje: Fix Textblock's text_class: D10598: edje: implement text_class override at object level, D10692: Edje: edc text_class applied without font or font_size in style.
Dec 3 2019, 1:13 AM
a.srour added a task to D10692: Edje: edc text_class applied without font or font_size in style: T8477: Edje: Fix Textblock's text_class.
Dec 3 2019, 1:13 AM · efl
a.srour added a task to D10598: edje: implement text_class override at object level: T8477: Edje: Fix Textblock's text_class.
Dec 3 2019, 1:13 AM · efl

Nov 27 2019

a.srour added a comment to D10716: Polish text interface methods.

Done

Nov 27 2019, 5:53 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Add Eina_Safety check

Nov 27 2019, 5:52 AM · efl

Nov 26 2019

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Add edje_file_text_class_get().
Update edje_file_text_class_del() to return bool.

Nov 26 2019, 5:41 AM · efl
a.srour updated the task description for T8480: Edje: Text_class New API file level override.
Nov 26 2019, 5:38 AM
a.srour added a comment to D10716: Polish text interface methods.

Done

Nov 26 2019, 3:37 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Resolve requests

Nov 26 2019, 3:36 AM · efl

Nov 25 2019

a.srour added a comment to D10716: Polish text interface methods.

Done

Nov 25 2019, 9:16 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Add eina_streq to font check

Nov 25 2019, 9:15 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Fix warning

Nov 25 2019, 7:27 AM · efl
a.srour added a comment to D10716: Polish text interface methods.

Done

Nov 25 2019, 7:26 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Using EINA_SAFETY macro

Nov 25 2019, 7:21 AM · efl
a.srour added a comment to D10598: edje: implement text_class override at object level.

These changes should resolve T8480 & T8481

Nov 25 2019, 3:36 AM · efl
a.srour updated the diff for D10598: edje: implement text_class override at object level.

Add edje file text_class functions
New API added:

  • edje_file_text_class_set(filepath, text_class, font, size)
    • Overrides text_class on file level, affect all Edje_Objects created from filepath
  • edje_file_text_class_del(filepath, text_class)
    • Remove text_class from file (at runtime only), affect all Edje_Objects created from filepath
Nov 25 2019, 3:32 AM · efl
a.srour added a comment to D10716: Polish text interface methods.

@woohyun @segfaultxavi @bu5hm4n
Do you have any feedback regarding this patch?

Nov 25 2019, 12:50 AM · efl

Nov 24 2019

a.srour added a comment to D10716: Polish text interface methods.

Done

Nov 24 2019, 5:01 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Resolve requests, revert _evas_text_efl_text_font_font_set() changes

Nov 24 2019, 5:00 AM · efl
a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Any update regarding this Diff?

Nov 24 2019, 1:23 AM · efl
a.srour added inline comments to D10716: Polish text interface methods.
Nov 24 2019, 1:10 AM · efl
a.srour added inline comments to D10716: Polish text interface methods.
Nov 24 2019, 12:36 AM · efl

Nov 21 2019

a.srour requested review of D10716: Polish text interface methods.
Nov 21 2019, 8:12 AM · efl

Nov 18 2019

a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Nov 18 2019, 8:02 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Remove whitespace

Nov 18 2019, 8:01 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Nov 18 2019, 8:00 AM · efl
a.srour updated the test plan for D10692: Edje: edc text_class applied without font or font_size in style.
Nov 18 2019, 7:35 AM · efl
a.srour requested review of D10692: Edje: edc text_class applied without font or font_size in style.
Nov 18 2019, 7:27 AM · efl
a.srour triaged T8482: Edje: Edc Style Font Property Parsing as TODO priority.
Nov 18 2019, 6:45 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Nov 18 2019, 6:19 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Nov 18 2019, 6:19 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Nov 18 2019, 6:18 AM
a.srour triaged T8481: Edje: Text_class Old API Object level override as TODO priority.
Nov 18 2019, 6:11 AM
a.srour triaged T8480: Edje: Text_class New API file level override as TODO priority.
Nov 18 2019, 5:31 AM
a.srour edited parent tasks for T8479: Edje: Fix TEXTBLOCK part properties, added: T8477: Edje: Fix Textblock's text_class; removed: T8478: Edje: Issue with Edc text_class in Styles .
Nov 18 2019, 5:13 AM
a.srour added a subtask for T8477: Edje: Fix Textblock's text_class: T8479: Edje: Fix TEXTBLOCK part properties.
Nov 18 2019, 5:13 AM
a.srour removed a subtask for T8478: Edje: Issue with Edc text_class in Styles : T8479: Edje: Fix TEXTBLOCK part properties.
Nov 18 2019, 5:13 AM
a.srour triaged T8479: Edje: Fix TEXTBLOCK part properties as TODO priority.
Nov 18 2019, 5:01 AM
a.srour triaged T8478: Edje: Issue with Edc text_class in Styles as TODO priority.
Nov 18 2019, 4:46 AM
a.srour triaged T8477: Edje: Fix Textblock's text_class as TODO priority.
Nov 18 2019, 3:50 AM

Nov 10 2019

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Resolve changes request

Nov 10 2019, 6:15 AM · efl
a.srour added inline comments to D10598: edje: implement text_class override at object level.
Nov 10 2019, 5:31 AM · efl
a.srour updated the diff for D10598: edje: implement text_class override at object level.

Fix naming & Resolve changes request

Nov 10 2019, 5:27 AM · efl
a.srour added a comment to D10598: edje: implement text_class override at object level.

This patch is a good idea, I think, but it is most likely breaking some existing application as before when you applied a style it would propagate everywhere the same file was loaded. If an application does rely on this it would be broken I would think. I am not expert on this part of the code, so I might be wrong, but if I am right, I think that we should most likely continue to update the edf->styles hash on every call to edje_object_text_class_set and handle the fallback case when a style is not found on the object to look on the file.

Nov 10 2019, 5:25 AM · efl

Nov 7 2019

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Resolve changes request

Nov 7 2019, 7:49 AM · efl

Nov 6 2019

a.srour added a comment to D9280: evas_textblock: content fit feature.

Sorry, I have forgot about this review. You could have just stored them in a C int array with an additional field named _count. This would have been way better than an Eina_List. There is a lot of example in edje_cc_handlers.c that already use this technic (After a quick scan of the file you can look at line 2356 I think).

Nov 6 2019, 2:03 AM · efl

Nov 5 2019

a.srour requested review of D10598: edje: implement text_class override at object level.
Nov 5 2019, 1:59 AM · efl