Page MenuHomePhabricator

a.srour (Abdalrahman Srour)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Aug 14 2019, 11:33 PM (17 w, 2 d)
Availability
Available

Recent Activity

Tue, Dec 3

a.srour added a task to D10598: edje: implement text_class override at object level: T8481: Edje: Text_class Old API Object level override.
Tue, Dec 3, 1:15 AM · efl
a.srour added a revision to T8481: Edje: Text_class Old API Object level override: D10598: edje: implement text_class override at object level.
Tue, Dec 3, 1:15 AM
a.srour added a task to D10598: edje: implement text_class override at object level: T8480: Edje: Text_class New API file level override.
Tue, Dec 3, 1:15 AM · efl
a.srour added a revision to T8480: Edje: Text_class New API file level override: D10598: edje: implement text_class override at object level.
Tue, Dec 3, 1:15 AM
a.srour added a revision to T8478: Edje: Issue with Edc text_class in Styles : D10692: Edje: edc text_class applied without font or font_size in style.
Tue, Dec 3, 1:14 AM
a.srour added a task to D10692: Edje: edc text_class applied without font or font_size in style: T8478: Edje: Issue with Edc text_class in Styles .
Tue, Dec 3, 1:14 AM · efl
a.srour added revisions to T8477: Edje: Fix Textblock's text_class: D10598: edje: implement text_class override at object level, D10692: Edje: edc text_class applied without font or font_size in style.
Tue, Dec 3, 1:13 AM
a.srour added a task to D10692: Edje: edc text_class applied without font or font_size in style: T8477: Edje: Fix Textblock's text_class.
Tue, Dec 3, 1:13 AM · efl
a.srour added a task to D10598: edje: implement text_class override at object level: T8477: Edje: Fix Textblock's text_class.
Tue, Dec 3, 1:13 AM · efl

Wed, Nov 27

a.srour added a comment to D10716: Polish text interface methods.

Done

Wed, Nov 27, 5:53 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Add Eina_Safety check

Wed, Nov 27, 5:52 AM · efl

Tue, Nov 26

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Add edje_file_text_class_get().
Update edje_file_text_class_del() to return bool.

Tue, Nov 26, 5:41 AM · efl
a.srour updated the task description for T8480: Edje: Text_class New API file level override.
Tue, Nov 26, 5:38 AM
a.srour added a comment to D10716: Polish text interface methods.

Done

Tue, Nov 26, 3:37 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Resolve requests

Tue, Nov 26, 3:36 AM · efl

Mon, Nov 25

a.srour added a comment to D10716: Polish text interface methods.

Done

Mon, Nov 25, 9:16 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Add eina_streq to font check

Mon, Nov 25, 9:15 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Fix warning

Mon, Nov 25, 7:27 AM · efl
a.srour added a comment to D10716: Polish text interface methods.

Done

Mon, Nov 25, 7:26 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Using EINA_SAFETY macro

Mon, Nov 25, 7:21 AM · efl
a.srour added a comment to D10598: edje: implement text_class override at object level.

These changes should resolve T8480 & T8481

Mon, Nov 25, 3:36 AM · efl
a.srour updated the diff for D10598: edje: implement text_class override at object level.

Add edje file text_class functions
New API added:

  • edje_file_text_class_set(filepath, text_class, font, size)
    • Overrides text_class on file level, affect all Edje_Objects created from filepath
  • edje_file_text_class_del(filepath, text_class)
    • Remove text_class from file (at runtime only), affect all Edje_Objects created from filepath
Mon, Nov 25, 3:32 AM · efl
a.srour added a comment to D10716: Polish text interface methods.

@woohyun @segfaultxavi @bu5hm4n
Do you have any feedback regarding this patch?

Mon, Nov 25, 12:50 AM · efl

Sun, Nov 24

a.srour added a comment to D10716: Polish text interface methods.

Done

Sun, Nov 24, 5:01 AM · efl
a.srour updated the diff for D10716: Polish text interface methods.

Resolve requests, revert _evas_text_efl_text_font_font_set() changes

Sun, Nov 24, 5:00 AM · efl
a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Any update regarding this Diff?

Sun, Nov 24, 1:23 AM · efl
a.srour added inline comments to D10716: Polish text interface methods.
Sun, Nov 24, 1:10 AM · efl
a.srour added inline comments to D10716: Polish text interface methods.
Sun, Nov 24, 12:36 AM · efl

Thu, Nov 21

a.srour requested review of D10716: Polish text interface methods.
Thu, Nov 21, 8:12 AM · efl

Mon, Nov 18

a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Mon, Nov 18, 8:02 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Remove whitespace

Mon, Nov 18, 8:01 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Mon, Nov 18, 8:00 AM · efl
a.srour updated the test plan for D10692: Edje: edc text_class applied without font or font_size in style.
Mon, Nov 18, 7:35 AM · efl
a.srour requested review of D10692: Edje: edc text_class applied without font or font_size in style.
Mon, Nov 18, 7:27 AM · efl
a.srour triaged T8482: Edje: Edc Style Font Property Parsing as TODO priority.
Mon, Nov 18, 6:45 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Mon, Nov 18, 6:19 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Mon, Nov 18, 6:19 AM
a.srour updated the task description for T8477: Edje: Fix Textblock's text_class.
Mon, Nov 18, 6:18 AM
a.srour triaged T8481: Edje: Text_class Old API Object level override as TODO priority.
Mon, Nov 18, 6:11 AM
a.srour triaged T8480: Edje: Text_class New API file level override as TODO priority.
Mon, Nov 18, 5:31 AM
a.srour edited parent tasks for T8479: Edje: Fix TEXTBLOCK part properties, added: T8477: Edje: Fix Textblock's text_class; removed: T8478: Edje: Issue with Edc text_class in Styles .
Mon, Nov 18, 5:13 AM
a.srour added a subtask for T8477: Edje: Fix Textblock's text_class: T8479: Edje: Fix TEXTBLOCK part properties.
Mon, Nov 18, 5:13 AM
a.srour removed a subtask for T8478: Edje: Issue with Edc text_class in Styles : T8479: Edje: Fix TEXTBLOCK part properties.
Mon, Nov 18, 5:13 AM
a.srour triaged T8479: Edje: Fix TEXTBLOCK part properties as TODO priority.
Mon, Nov 18, 5:01 AM
a.srour triaged T8478: Edje: Issue with Edc text_class in Styles as TODO priority.
Mon, Nov 18, 4:46 AM
a.srour triaged T8477: Edje: Fix Textblock's text_class as TODO priority.
Mon, Nov 18, 3:50 AM

Nov 10 2019

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Resolve changes request

Nov 10 2019, 6:15 AM · efl
a.srour added inline comments to D10598: edje: implement text_class override at object level.
Nov 10 2019, 5:31 AM · efl
a.srour updated the diff for D10598: edje: implement text_class override at object level.

Fix naming & Resolve changes request

Nov 10 2019, 5:27 AM · efl
a.srour added a comment to D10598: edje: implement text_class override at object level.

This patch is a good idea, I think, but it is most likely breaking some existing application as before when you applied a style it would propagate everywhere the same file was loaded. If an application does rely on this it would be broken I would think. I am not expert on this part of the code, so I might be wrong, but if I am right, I think that we should most likely continue to update the edf->styles hash on every call to edje_object_text_class_set and handle the fallback case when a style is not found on the object to look on the file.

Nov 10 2019, 5:25 AM · efl

Nov 7 2019

a.srour updated the diff for D10598: edje: implement text_class override at object level.

Resolve changes request

Nov 7 2019, 7:49 AM · efl

Nov 6 2019

a.srour added a comment to D9280: evas_textblock: content fit feature.

Sorry, I have forgot about this review. You could have just stored them in a C int array with an additional field named _count. This would have been way better than an Eina_List. There is a lot of example in edje_cc_handlers.c that already use this technic (After a quick scan of the file you can look at line 2356 I think).

Nov 6 2019, 2:03 AM · efl

Nov 5 2019

a.srour requested review of D10598: edje: implement text_class override at object level.
Nov 5 2019, 1:59 AM · efl

Sep 3 2019

a.srour updated the task description for T8110: Text Manipulation.
Sep 3 2019, 1:14 AM

Aug 19 2019

a.srour updated the task description for T8110: Text Manipulation.
Aug 19 2019, 8:57 AM
a.srour claimed T8110: Text Manipulation.
Aug 19 2019, 3:55 AM