Page MenuHomePhabricator

ajwillia.ms (Andrew Williams)Administrator
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Sep 27 2013, 1:37 AM (268 w, 1 d)
Roles
Administrator
Availability
Available

Recent Activity

Sep 10 2018

ajwillia.ms accepted D7000: elm_code: Make sure we handle python3 mime type..
Sep 10 2018, 1:31 PM · efl

Sep 9 2018

ajwillia.ms closed D7008: elm_code_file: preserve file permissions on save..
Sep 9 2018, 1:26 PM · efl

Sep 7 2018

ajwillia.ms accepted D7001: elm_code_file: preserve permissions when saving..

As long as this works for the windows build (I cannot test here)

Sep 7 2018, 9:31 AM · efl
ajwillia.ms added a comment to D7000: elm_code: Make sure we handle python3 mime type..

I cannot find documentation of this mimetype - and I cannot replicate.
What system has set this?

Sep 7 2018, 9:15 AM · efl

Sep 6 2018

ajwillia.ms removed a project from T6108: Automatic code indenting / formatting: Restricted Project.
Sep 6 2018, 1:26 AM · Restricted Project
ajwillia.ms removed a project from T6106: Code folding: Restricted Project.
Sep 6 2018, 1:25 AM · Restricted Project
ajwillia.ms reopened T6106: Code folding, a subtask of T6178: elm_code: Add scope awareness to parser, as Open.
Sep 6 2018, 1:25 AM · efl: widgets: code, Restricted Project
ajwillia.ms reopened T6106: Code folding as "Open".

Not invalid

Sep 6 2018, 1:25 AM · Restricted Project
ajwillia.ms updated the task description for T6106: Code folding.
Sep 6 2018, 1:25 AM · Restricted Project
ajwillia.ms reopened T6108: Automatic code indenting / formatting as "Open".

Not invalid

Sep 6 2018, 1:24 AM · Restricted Project
ajwillia.ms reopened T6108: Automatic code indenting / formatting, a subtask of T6178: elm_code: Add scope awareness to parser, as Open.
Sep 6 2018, 1:24 AM · efl: widgets: code, Restricted Project
ajwillia.ms updated the task description for T6108: Automatic code indenting / formatting.
Sep 6 2018, 1:24 AM · Restricted Project
ajwillia.ms moved T6472: Edi: Select text and drag down. from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:56 AM · Restricted Project
ajwillia.ms moved T6281: Edi. Multiple panels, multiple tabs auto resize issue from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:56 AM · Restricted Project
ajwillia.ms moved T6033: ELM: Genlist SEGV from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:56 AM · efl (efl-1.21), efl: widgets, Restricted Project
ajwillia.ms moved T6426: Split panes are not saved in project config from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:55 AM · Restricted Project
ajwillia.ms moved T6249: elm_code_widget: EFL focus changes (multiple cursors). from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:55 AM · Restricted Project, efl
ajwillia.ms moved T6068: EDI: input and file escaping. from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:55 AM · Restricted Project
ajwillia.ms moved T6107: Split pane view from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 6 2018, 12:55 AM · Restricted Project
ajwillia.ms added a project to T6083: EDI multiline comment: add syntax refresh method to elm_code.: Restricted Project.
Sep 6 2018, 12:55 AM · efl: widgets, Restricted Project
ajwillia.ms edited projects for T6230: Add markdown preview when editing markdown documents , added: Restricted Project; removed Restricted Project.
Sep 6 2018, 12:55 AM · Restricted Project
Herald closed T6109: Add key bindings as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Sep 6 2018, 12:55 AM · Restricted Project, Restricted Project
Herald closed T6106: Code folding as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Sep 6 2018, 12:54 AM · Restricted Project
Herald closed T6108: Automatic code indenting / formatting as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Sep 6 2018, 12:54 AM · Restricted Project
ajwillia.ms closed T6178: elm_code: Add scope awareness to parser as Resolved.

First pass is done, we can revisit to see what needs to be added for 0.8 if anything

Sep 6 2018, 12:54 AM · efl: widgets: code, Restricted Project
ajwillia.ms edited projects for T6135: wrap mode for editor widgets, added: Restricted Project; removed Restricted Project.
Sep 6 2018, 12:52 AM · Restricted Project

Sep 5 2018

ajwillia.ms closed D6986: elm_code: make the hoversel not focusable..
Sep 5 2018, 2:07 PM · efl
ajwillia.ms accepted D6986: elm_code: make the hoversel not focusable..
Sep 5 2018, 2:07 PM · efl

Aug 31 2018

ajwillia.ms closed D6957: elm_code: fix DEL at end of line..
Aug 31 2018, 9:58 AM · efl
ajwillia.ms accepted D6957: elm_code: fix DEL at end of line..
Aug 31 2018, 9:58 AM · efl

Aug 28 2018

ajwillia.ms added a comment to T7353: Elm_code crash with ecrire on close.

Looking at this again I think @netstar is right - an elm_code should not close the file if there is an active instance... By destroying the container you close the file correctly.

Aug 28 2018, 9:09 AM

Aug 17 2018

ajwillia.ms added a comment to D6835: elm_code: fix crash on backspace and selection delete..

looks good to me, thanks for landing @stefan_schmidt

Aug 17 2018, 3:01 PM · efl

Aug 16 2018

ajwillia.ms requested changes to D6835: elm_code: fix crash on backspace and selection delete..
Aug 16 2018, 3:11 PM · efl
ajwillia.ms added a project to T6178: elm_code: Add scope awareness to parser: efl: widgets: code.
Aug 16 2018, 8:13 AM · efl: widgets: code, Restricted Project
ajwillia.ms edited projects for T5497: Elm code crash on large files, added: efl: widgets: code; removed efl: widgets.
Aug 16 2018, 8:11 AM · efl: widgets: code, Restricted Project
ajwillia.ms edited projects for T7208: elm_code: Make the widget 100% reliable and ready for Eo API implementation, added: efl: widgets: code; removed efl: widgets.
Aug 16 2018, 8:10 AM · Active Work Proposal, efl: widgets: code, Restricted Project, efl (efl-1.22)
ajwillia.ms requested changes to D6835: elm_code: fix crash on backspace and selection delete..

Sorry, pressed the wrong button

Aug 16 2018, 8:03 AM · efl
ajwillia.ms added a comment to D6835: elm_code: fix crash on backspace and selection delete..

The first half was fine but there's some questions about the latter part

Aug 16 2018, 7:58 AM · efl

Aug 14 2018

ajwillia.ms merged T7288: elementary_test Code editor crash into T7259: Elm_code crash when deleting .
Aug 14 2018, 1:40 AM · efl (efl-1.21), efl: widgets
ajwillia.ms merged task T7288: elementary_test Code editor crash into T7259: Elm_code crash when deleting .
Aug 14 2018, 1:40 AM · efl (efl-1.21)

Aug 5 2018

ajwillia.ms closed D6719: elm_code_widget: match bg color with widget color..
Aug 5 2018, 1:15 PM · efl
ajwillia.ms accepted D6719: elm_code_widget: match bg color with widget color..

This is too complex and the provided patch seems to work fine. Can be revisited later if required

Aug 5 2018, 1:14 PM · efl

Aug 1 2018

ajwillia.ms added a comment to D6719: elm_code_widget: match bg color with widget color..

I kinda wonder why this fixes it really. Part of me wonders if we've got an issue in the "elm" setup in elm_code_widget...

Aug 1 2018, 2:00 PM · efl

Jul 31 2018

ajwillia.ms added a comment to D6696: region_add: Fix copying wrong rect during smart merge.

As per the email chain recently please be aware that moving code into Eina is also changing it's license. Be careful!

Jul 31 2018, 1:20 AM · efl

Jul 27 2018

ajwillia.ms closed D6676: elm_code_widget: fix keyboard and scrolling with active selection..
Jul 27 2018, 9:08 AM · efl
ajwillia.ms accepted D6676: elm_code_widget: fix keyboard and scrolling with active selection..
Jul 27 2018, 9:08 AM · efl

Jul 24 2018

ajwillia.ms closed T6472: Edi: Select text and drag down. as Resolved.

That's merged into efl master now

Jul 24 2018, 2:12 AM · Restricted Project
ajwillia.ms closed T6470: Blinking cursor size in elm_code as Resolved by committing rEFLab7d2ebb552c: elm_code_widget: resize cursor at time of font change..
Jul 24 2018, 2:10 AM · Restricted Project, efl: widgets
ajwillia.ms closed D6596: elm_code_widget: resize cursor at time of font change..
Jul 24 2018, 2:10 AM · efl
ajwillia.ms closed D6632: elm_code_widget: fix select and drag (scrolling)..
Jul 24 2018, 2:04 AM · efl

Jul 22 2018

ajwillia.ms accepted D6596: elm_code_widget: resize cursor at time of font change..

Quite right, that check is needed

Jul 22 2018, 12:50 PM · efl
ajwillia.ms added a comment to D6596: elm_code_widget: resize cursor at time of font change..

The move issue is no longer visible - perhaps that was due to be basing it off the 1.20 branch?
Other than the one comment inline this looks good.

Jul 22 2018, 11:25 AM · efl
ajwillia.ms accepted D6632: elm_code_widget: fix select and drag (scrolling)..

Looks good to me :)

Jul 22 2018, 11:17 AM · efl

Jul 20 2018

ajwillia.ms added a comment to T7156: e22 beta screenshot displays black rectangle.

You're right the freeze is fixed, just the black rectangle remains

Jul 20 2018, 6:20 AM · efl: rendering, efl (efl-1.21)
ajwillia.ms updated subscribers of T7170: ecore_main_loop_iterate blocks when resizing a macOS window.

@zmike pointed to a workaround in src/lib/ecore_cocoa/ecore_cocoa_window.m (line 121) whereby an additional timer makes direct calls to ecore_main_loop_iterate due to the NSRunLoop having blocked.

Jul 20 2018, 1:12 AM · efl: rendering, efl: widgets

Jul 19 2018

ajwillia.ms added a comment to T7170: ecore_main_loop_iterate blocks when resizing a macOS window.

I get the same behaviour if I call ecore_main_loop_iterate_may_block(EINA_FALSE) which is even stranger...

Jul 19 2018, 2:33 PM · efl: rendering, efl: widgets
ajwillia.ms created T7170: ecore_main_loop_iterate blocks when resizing a macOS window.
Jul 19 2018, 2:29 PM · efl: rendering, efl: widgets
ajwillia.ms added a comment to T6470: Blinking cursor size in elm_code.

It's very close :)

Jul 19 2018, 1:29 PM · Restricted Project, efl: widgets
ajwillia.ms added a comment to D6596: elm_code_widget: resize cursor at time of font change..

As for a single method it looks like the geom_get, resize, move and show are almost identically grouped in widget_fill_cursor.
I'd say it should be possible to factor that and this patch into a single method.

Jul 19 2018, 1:29 PM · efl
ajwillia.ms added a comment to D6596: elm_code_widget: resize cursor at time of font change..

Sorry, this is not quite there.
The cursor does not move to the correct location.
It seems to size correctly - but if you are not on the top line of the file it will hover in the wrong place (where the topleft was before).

Jul 19 2018, 1:26 PM · efl
ajwillia.ms added a comment to D6632: elm_code_widget: fix select and drag (scrolling)..

Very close! Thank you for that.

Jul 19 2018, 1:18 PM · efl

Jul 18 2018

ajwillia.ms added a comment to D6599: macos: allow text to be selected..

Works nicely here :)

Jul 18 2018, 2:17 PM · efl

Jul 17 2018

ajwillia.ms added a comment to T7156: e22 beta screenshot displays black rectangle.

This also occurs on the current stable release.
Of particular note is that if you try again after seeing the black rectangle E can freeze :(

Jul 17 2018, 3:16 AM · efl: rendering, efl (efl-1.21)

Jul 16 2018

ajwillia.ms added a comment to D6596: elm_code_widget: resize cursor at time of font change..

I have not looked into the details but I think this must have created a little duplicate code.
Can we use the same code for when it's set up in the first place and when it's resized through this method?

Jul 16 2018, 11:49 AM · efl

Jul 6 2018

ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

Cool, setting it to 5 or 10 works well, thanks. I tried 3 and it did the same deadlock

Jul 6 2018, 2:08 PM · efl: display system
ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

Happy to debug further but I don’t know what would be useful

Jul 6 2018, 1:20 PM · efl: display system
ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

Yes a good point. I switched to master and have the same issue.
In addition to not being able to switch away I noticed that cpu goes high and fans start spinning - I wonder if that is useful too?

Jul 6 2018, 1:20 PM · efl: display system

Jul 5 2018

ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

There are no errors on the command line when I force the application to exit remotely.

Jul 5 2018, 12:31 AM · efl: display system
ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

These lines refer to efl 1.20 not master

Jul 5 2018, 12:29 AM · efl: display system
ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

The relevant threads appear to be:

Jul 5 2018, 12:24 AM · efl: display system
ajwillia.ms added a comment to T7099: Deadlock after a few frames in DRM.

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
_outbuf_fb_wait (ob=ob@entry=0xd589c0) at modules/evas/engines/drm/evas_outbuf.c:213

Jul 5 2018, 12:22 AM · efl: display system

Jul 4 2018

ajwillia.ms added a comment to T6940: ecore-cocoa window issue.

Ah I misunderstood sorry.
I had thought it was something else from the description.
If it's not visible then I agree it's not a 1.21 problem.

Jul 4 2018, 1:26 AM · efl: display system, macOS

Jul 3 2018

ajwillia.ms added a comment to T6940: ecore-cocoa window issue.

I actually can't replicate this here - is there a small code snippet that I can use?

Jul 3 2018, 8:02 AM · efl: display system, macOS

Jun 30 2018

ajwillia.ms added a comment to T7056: ELM text selection regression MacOS.

Testing on my end suggests that D6483 does fix this issue.

Jun 30 2018, 3:09 PM · efl: widgets, regression, efl (efl-1.21)

Jun 29 2018

ajwillia.ms created T7099: Deadlock after a few frames in DRM.
Jun 29 2018, 2:10 PM · efl: display system
ajwillia.ms closed T7084: Many DRM errors when running app as Resolved.

Apologies, it would appear this is now resolved.

Jun 29 2018, 2:02 PM · efl

Jun 28 2018

ajwillia.ms raised the priority of T7084: Many DRM errors when running app from Pending on user input to High.

It appears to still be the case with that patch applied

Jun 28 2018, 3:10 PM · efl
ajwillia.ms added a comment to T6940: ecore-cocoa window issue.

Hi @netstar if you're not succeeding I will look - this should really get fixed for 1.21

Jun 28 2018, 2:32 PM · efl: display system, macOS

Jun 26 2018

ajwillia.ms added a comment to T7084: Many DRM errors when running app.

As an update this does not appear when ECORE_DRM2_ATOMIC_DISABLE is set.
There is a deadlock situation that also does not occur when this is set - may or may not be related.

Jun 26 2018, 7:44 AM · efl
ajwillia.ms added a comment to T7084: Many DRM errors when running app.

Oops, sorry - the error is:

Jun 26 2018, 7:12 AM · efl
ajwillia.ms created T7084: Many DRM errors when running app.
Jun 26 2018, 6:34 AM · efl

Jun 22 2018

ajwillia.ms added a comment to T7031: elm_code internals pass null to functions.

Could someone see if this patch fixes it? I cannot currently test master...
I can't see the cause of the second issue - the null seems to be within layout code somehow...

Jun 22 2018, 4:00 PM · efl: widgets, Restricted Project, efl (efl-1.21)
ajwillia.ms placed T7031: elm_code internals pass null to functions up for grabs.

Pretty sure it's not - perhaps @zmike can verify?

Jun 22 2018, 2:00 PM · efl: widgets, Restricted Project, efl (efl-1.21)

Jun 21 2018

ajwillia.ms added a comment to T6471: Text rendering when changing size in elm_code.

The black line changes size in Edi using efl 1.20.9 - is this a regression or is it specific to Ecrire?
I can't imagine how it does not change as it's all part of the underlying text grid.

Jun 21 2018, 3:31 PM · efl: widgets

Jun 20 2018

ajwillia.ms added a comment to T5497: Elm code crash on large files.

No

Jun 20 2018, 3:43 AM · efl: widgets: code, Restricted Project

Jun 19 2018

ajwillia.ms reopened T5497: Elm code crash on large files as "Open".

I mentioned before but not on this ticket, so I'll add it for the record.

Jun 19 2018, 3:05 PM · efl: widgets: code, Restricted Project
ajwillia.ms triaged T6774: Rclick menu (paste etc) don't work outside the numbered lines. as Normal priority.

I'm not sure I agree with not moving the cursor but pasting somewhere that the cursor is not...
The cursor remains where the input is occurring and I'd like to maintain that.

Jun 19 2018, 6:47 AM · efl: widgets, Restricted Project
ajwillia.ms lowered the priority of T6471: Text rendering when changing size in elm_code from Normal to Pending on user input.

I cannot replicate this in Edi.
Is there a particular font that has been set? Does it happen with all fonts in Ecrire?

Jun 19 2018, 2:50 AM · efl: widgets
ajwillia.ms edited projects for T6470: Blinking cursor size in elm_code, added: Restricted Project; removed Restricted Project.

This should get fixed

Jun 19 2018, 2:48 AM · Restricted Project, efl: widgets
ajwillia.ms triaged T6773: Text selection doesn't happen if you click outside the text lines as Normal priority.

Setting this to normal priority and removing goal as we can't fix this without a major refactor of the widget layout.

Jun 19 2018, 2:47 AM · efl: widgets

May 30 2018

ajwillia.ms added a comment to T6889: Evas_Vg legacy API is not exposed by default in efl master.

Yeah, @zmike is right about that. @segfaultxavi I thought I had a simple example but it turned out the compiler flag had been turned on by an unrelated piece of code that later turned it off...

May 30 2018, 4:27 AM · efl

May 16 2018

ajwillia.ms created T6944: Ecore KeyDown missing window id on OS X.
May 16 2018, 12:54 PM · efl (efl-1.21), efl: display system, macOS

May 11 2018

ajwillia.ms added a comment to T6889: Evas_Vg legacy API is not exposed by default in efl master.

I'm not sure the cause but the result is that there is documentation outside of the normal guards that hold back those beta APIs.

May 11 2018, 10:58 AM · efl
ajwillia.ms added a comment to T6889: Evas_Vg legacy API is not exposed by default in efl master.

Can we please change the documentation then? Evas_Object_Vg Is public documentation marked as @since 1.14...

May 11 2018, 4:00 AM · efl

Apr 22 2018

ajwillia.ms triaged T6889: Evas_Vg legacy API is not exposed by default in efl master as Showstopper Issues priority.
Apr 22 2018, 5:18 AM · efl

Mar 30 2018

ajwillia.ms added a comment to T6773: Text selection doesn't happen if you click outside the text lines.

With the current widget setup I cannot find a way to make this work.
The mouse move event is not triggered on the text as the mouse is somehow tied to the background where the drag started.

Mar 30 2018, 4:49 AM · efl: widgets

Mar 29 2018

ajwillia.ms closed T6827: elm_code tests use private symbols as Resolved.
Mar 29 2018, 2:08 PM · efl

Mar 22 2018

ajwillia.ms added a comment to T6774: Rclick menu (paste etc) don't work outside the numbered lines..

Looking at some editors (on OS X):

Mar 22 2018, 4:30 AM · efl: widgets, Restricted Project
ajwillia.ms added a comment to T6774: Rclick menu (paste etc) don't work outside the numbered lines..

When you right click the cursor jumps to the location so that the operation will happen where expected.
If you are outside the area and there is a long line of text on the last line it does not make sense to paste at the end of it - the content will not appear in the expected position.

Mar 22 2018, 4:28 AM · efl: widgets, Restricted Project
ajwillia.ms added a comment to T6774: Rclick menu (paste etc) don't work outside the numbered lines..

Where in the last line? The pointer position may not be after the end of the last line...

Mar 22 2018, 1:48 AM · efl: widgets, Restricted Project