Page MenuHomePhabricator

akanad (Wonki Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2016, 12:48 AM (190 w, 5 d)
Availability
Available

Recent Activity

Today

akanad updated the diff for D10821: docs: fix to make docs contain proper images.
  • rebasing
  • removing image links by using htmlonly tag
Mon, Dec 9, 11:45 PM · efl

Yesterday

akanad updated the diff for D10821: docs: fix to make docs contain proper images.
  • removing efl_copy.sh
  • reasoning for this patch
  • doxygen documetation image broken
Sun, Dec 8, 6:07 PM · efl

Fri, Dec 6

akanad updated the diff for D10723: collection_view: fix a potentional error.
  • rebasing
  • ping
Fri, Dec 6, 12:30 AM · efl
akanad updated the diff for D10745: focus: modify a formula to calculate focus region to show.
  • rebasing
  • ping
Fri, Dec 6, 12:29 AM · efl
akanad requested review of D10821: docs: fix to make docs contain proper images.
Fri, Dec 6, 12:28 AM · efl

Wed, Nov 27

akanad added a comment to D10723: collection_view: fix a potentional error.
  1. assigning negative int value into bigger unsigned int variable makes loss of meaning of sign bit.
Wed, Nov 27, 1:23 AM · efl
akanad requested review of D10745: focus: modify a formula to calculate focus region to show.
Wed, Nov 27, 1:12 AM · efl

Fri, Nov 22

akanad requested review of D10723: collection_view: fix a potentional error.
Fri, Nov 22, 2:05 AM · efl
akanad requested review of D10722: efl_ui_table: modify comparing logic.
Fri, Nov 22, 2:05 AM · efl

Wed, Nov 20

akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

@cedric
ping~!
would you please let me know your opinion about this?

Wed, Nov 20, 6:06 PM · efl
akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

I see, I misunderstood.
I thought that you suggested to use cos rather than cosf because Eina_Matrix{N} has double type structure variables.

Wed, Nov 20, 6:04 PM · efl

Tue, Nov 19

akanad added a reviewer for D10695: eina_matrix: replace cosf by cos to gain more accuracy: vtorri.
Tue, Nov 19, 6:14 PM · efl
akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

Yes. I think it's needed. Because

Tue, Nov 19, 6:13 PM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.

restore everything, just remove a 'f' characters

Tue, Nov 19, 3:42 AM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.
  • keep meaning of removed comment.
  • modify a corresponding testcase.
Tue, Nov 19, 3:25 AM · efl
akanad requested review of D10695: eina_matrix: replace cosf by cos to gain more accuracy.
Tue, Nov 19, 2:05 AM · efl

Nov 5 2019

akanad added a comment to T7717: docs todo.

@segfaultxavi
I tried to improve descriptions for efl_loop_message_future.eo and efl_loop_message_future_handler.eo.
They look like actually unused, though.
I mean they are created and assigned but there isn't a place that accesses or call some apis to those things.
Am I wrong?

Nov 5 2019, 11:50 PM · efl (efl-1.24), efl: docs, efl: api
akanad updated the diff for D10591: check: reset flags that used for legacy 'changed' cb.
  1. add a new testcase for elm_check
  2. rebase
Nov 5 2019, 6:06 PM · efl

Nov 3 2019

akanad requested review of D10591: check: reset flags that used for legacy 'changed' cb.
Nov 3 2019, 5:53 PM · efl
akanad updated the diff for D10578: elm_config: replace ecore_file_cp with ecore_file_mv.

rebase onto the lastest.
and ping.

Nov 3 2019, 5:43 PM · efl

Oct 30 2019

akanad requested review of D10578: elm_config: replace ecore_file_cp with ecore_file_mv.
Oct 30 2019, 9:56 PM · efl

Sep 24 2019

akanad added a comment to D10105: test: add a new testcase for paging of scroller.

This testcase is what I described before at T5151.
there could be necessary more than 1 loop to complete what I intended.
ecore_main_loop_begin(get_me_to_those_events) seems required.
if I change it to ecore_main_loop_iterate(), test passes.

Sep 24 2019, 9:29 PM · DO NOT MERGE, efl
akanad updated the diff for D10105: test: add a new testcase for paging of scroller.
  • adding EINA_UNUSED marks
  • aligning a type of page_num variables
Sep 24 2019, 9:19 PM · DO NOT MERGE, efl

Sep 23 2019

akanad closed T7450: fileselector couldn't traverse properly once expandable mode is on as Resolved.
Sep 23 2019, 10:09 PM
akanad requested review of D10105: test: add a new testcase for paging of scroller.
Sep 23 2019, 10:08 PM · DO NOT MERGE, efl
akanad updated the diff for D10103: doc: update ecore_filter_model description.

change the commit body

Sep 23 2019, 6:50 PM · efl
akanad updated the diff for D10103: doc: update ecore_filter_model description.

update little more

Sep 23 2019, 6:49 PM · efl
akanad added a comment to T7717: docs todo.

src/lib/ecore/efl_exe.eo (@akanad) seems done with your(@segfaultxavi) comit (f78b4861af140bd5b333fb530556e81915acbaab).

Sep 23 2019, 6:47 PM · efl (efl-1.24), efl: docs, efl: api
akanad requested review of D10103: doc: update ecore_filter_model description.
Sep 23 2019, 6:46 PM · efl

Sep 20 2019

akanad updated the diff for D10038: test: Add a logic to check a size of Check.

*removing timer for testing on elementary_test
*improving convension style of the testcase

Sep 20 2019, 9:28 PM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

another diff

Sep 20 2019, 1:52 AM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

modifying the commit title

Sep 20 2019, 1:48 AM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

appending a new test for sizing

Sep 20 2019, 1:36 AM · efl
akanad added a comment to D10038: test: Add a logic to check a size of Check.

you can see a check that has no size if you just pack it without calling any api to it after creating.
Actually this is a story about Efl.Ui.Layout not only check.
because efl_canvas_group_change api are not able to effect any in construction time.

Sep 20 2019, 12:22 AM · efl

Sep 19 2019

akanad requested review of D10039: gesture: fix it not to lose information by dividing.
Sep 19 2019, 10:26 PM · efl
akanad requested review of D10038: test: Add a logic to check a size of Check.
Sep 19 2019, 7:08 PM · efl

Sep 17 2019

akanad updated the diff for D9987: elm_config: fix to check if eet_open fails.

fix to print error and return nullptr

Sep 17 2019, 5:50 PM · efl
akanad requested review of D9987: elm_config: fix to check if eet_open fails.
Sep 17 2019, 4:50 AM · efl

Sep 16 2019

akanad requested review of D9966: elm_config: fix a missing of free after using.
Sep 16 2019, 1:04 AM · efl

Sep 9 2019

akanad requested review of D9889: efl_exe: Enhance class description.
Sep 9 2019, 10:37 PM · efl

Sep 4 2019

akanad abandoned D8694: entry: revert a single line.
Sep 4 2019, 10:32 PM · efl
akanad abandoned D9179: build: Add a option to generate debuginfo.
Sep 4 2019, 10:31 PM · efl

Aug 27 2019

akanad updated the diff for D9748: eina_vpath: add null checking logic on vpath_resolve api.

fix a build error

Aug 27 2019, 4:24 AM · efl
akanad added a reviewer for D9750: eina_list: fix to check a null argument: Hermet.
Aug 27 2019, 4:04 AM · efl
akanad added a reviewer for D9748: eina_vpath: add null checking logic on vpath_resolve api: Hermet.
Aug 27 2019, 4:04 AM · efl

Aug 26 2019

akanad requested review of D9750: eina_list: fix to check a null argument.
Aug 26 2019, 9:28 PM · efl
akanad requested review of D9748: eina_vpath: add null checking logic on vpath_resolve api.
Aug 26 2019, 8:56 PM · efl

Jul 22 2019

akanad updated the summary of D9368: efl_ui_layout: set needs_size_calc flag at constructor.
Jul 22 2019, 3:06 AM · efl

Jul 21 2019

akanad added a comment to D9356: [elm] Add missing sizing eval hook at radio.

I guess that this issue is caused by same reason that D9368 is caused by.

Jul 21 2019, 9:38 PM · efl

Jul 19 2019

akanad requested review of D9368: efl_ui_layout: set needs_size_calc flag at constructor.
Jul 19 2019, 9:21 PM · efl

Jun 27 2019

akanad updated the diff for D8708: meson: fix installation paths for evas/modules.

rebase

Jun 27 2019, 6:55 PM · efl
akanad requested review of D9198: meson: remove autotools checking stuffs.
Jun 27 2019, 6:45 PM · efl

Jun 26 2019

akanad added a comment to D9179: build: Add a option to generate debuginfo.

Im' against that. CFLAGS exists for such purpose

Jun 26 2019, 11:19 PM · efl

Jun 25 2019

akanad requested review of D9179: build: Add a option to generate debuginfo.
Jun 25 2019, 11:40 PM · efl
akanad updated the diff for D9165: enhance help description for command with arguments.

do same thing on exactness_player

Jun 25 2019, 1:04 AM

Jun 24 2019

akanad requested review of D9165: enhance help description for command with arguments.
Jun 24 2019, 10:22 PM
akanad requested review of D9163: fix a build break caused by renaming a window type.
Jun 24 2019, 5:15 AM

Apr 29 2019

akanad requested review of D8787: wl2_input: fix a problem that occurs in case of using both pointer/touch input devices.
Apr 29 2019, 10:38 PM · efl
akanad requested review of D8786: ecore_wl2_input: modify to increase grab count while touching.
Apr 29 2019, 10:15 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

I built this patch over 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl option, and I named them as 'mesongl' / 'mesonnongl'.
and also I built 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl, and named them as 'mesonoldgl' / 'mesonoldnongl',
then compared them.

Apr 29 2019, 9:47 PM · efl
akanad added a reviewer for D8708: meson: fix installation paths for evas/modules: zmike.
Apr 29 2019, 5:59 PM · efl

Apr 28 2019

akanad added a comment to D8708: meson: fix installation paths for evas/modules.

ping~!

Apr 28 2019, 6:14 PM · efl

Apr 25 2019

akanad updated the diff for D8708: meson: fix installation paths for evas/modules.

changes buildsystem_meson.c to refer to evas/modules properly in tree running

Apr 25 2019, 8:33 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

this ticket has 2 commits like below anyway I will post another diff soon.

Apr 25 2019, 8:29 PM · efl

Apr 24 2019

akanad requested review of D8708: meson: fix installation paths for evas/modules.
Apr 24 2019, 10:06 PM · efl

Apr 23 2019

akanad requested review of D8694: entry: revert a single line.
Apr 23 2019, 9:34 PM · efl

Apr 21 2019

akanad requested review of D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Apr 21 2019, 5:17 PM · efl

Apr 15 2019

akanad requested review of D8604: scroll_mgr: fix a type for some vars to be portable.
Apr 15 2019, 12:19 AM · efl

Apr 3 2019

akanad requested review of D8551: efreetd: remove a tentative global variable definition.
Apr 3 2019, 7:24 PM · efl

Mar 26 2019

akanad updated the diff for D8483: test: add a test case for elm_entry.

changing a name of tc

Mar 26 2019, 10:37 PM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

right, this patch looks more simple.

Mar 26 2019, 10:16 PM · efl
akanad requested review of D8483: test: add a test case for elm_entry.
Mar 26 2019, 9:02 PM · efl
akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

Hi. I got things confused after having a look of your comment.

Mar 26 2019, 7:33 PM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

this is a missed file for testing

Mar 26 2019, 12:01 AM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

I got a point of yours. then how about this?

Mar 26 2019, 12:00 AM · efl

Mar 15 2019

akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

juat add entry under window and pass a existing file to efl entry file set and you will get a problem.

Mar 15 2019, 8:16 AM · efl
akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

I am not sure you have checked previous code, have you?
previously, save do was called before setting file path.
and that is the reason why save do would not be called.

Mar 15 2019, 8:14 AM · efl

Mar 14 2019

akanad requested review of D8363: elm_entry: fix to keep api backward compatability.
Mar 14 2019, 10:01 PM · efl
akanad requested review of D8362: entry: move a point to do 'auto_save' to another place.
Mar 14 2019, 9:46 PM · efl
akanad updated the diff for D8337: elm_entry: fix to return a error code if a argument is not valid.

As you wish.

Mar 14 2019, 6:32 PM · efl

Mar 13 2019

akanad requested review of D8337: elm_entry: fix to return a error code if a argument is not valid.
Mar 13 2019, 10:43 PM · efl

Feb 21 2019

akanad updated the diff for D7837: meson: modify install pathes for modules of ecore_buffer.

change to make them as 'module.so' not 'libmodule.so.so'

Feb 21 2019, 1:50 AM · efl

Feb 20 2019

akanad updated the diff for D7919: eio: fix a potentional BOF problem.

rebase

Feb 20 2019, 9:25 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

remove duplicated one

Feb 20 2019, 8:05 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

little fix

Feb 20 2019, 6:07 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

@cedric did you mean a way like this?

Feb 20 2019, 5:38 PM · efl

Feb 14 2019

akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

I hope it's fine.

Feb 14 2019, 2:25 AM · efl

Feb 13 2019

akanad added a comment to D7354: elm_config: fix elm_config_save not to wake idle processes up.

then woud you please revert this? I will write another one as you said.

Feb 13 2019, 3:09 AM · efl

Feb 12 2019

akanad requested review of D7921: ecore_wl2: fix a non-thread safe call..
Feb 12 2019, 11:01 PM · efl
akanad requested review of D7920: ecore_wl2: replace strcpy with strncpy.
Feb 12 2019, 10:56 PM · efl
akanad requested review of D7919: eio: fix a potentional BOF problem.
Feb 12 2019, 10:39 PM · efl
akanad requested review of D7918: ecore_evas: fix a potentional deref after null problem.
Feb 12 2019, 8:45 PM · efl
akanad requested review of D7917: ecore_con: Fix potentional problems around ecore_con.
Feb 12 2019, 8:06 PM · efl

Feb 10 2019

akanad added a comment to D7354: elm_config: fix elm_config_save not to wake idle processes up.

Okay, stop.

This commit breaks my config ... for the second time now ?

Whenever there is a call to _config_profile_change_delay_cb, when no .base.flush.cfg file does exist, then the empty value from the .base.flush.cfg is loaded and stuffed into the real config, which basically erases the config of a user ... ...

Feb 10 2019, 5:45 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

yup, you are right.

Feb 10 2019, 5:09 PM · efl

Jan 31 2019

akanad added a comment to D7842: edje_calc: make INTP use TO_INT_ROUND.

I just found that rounding rules has already defined on IEEE standard.
I think the round implementation as before this patch looks wrong as the standard rule.
(please have a glance at https://en.wikipedia.org/wiki/IEEE_754#Rounding_rules)

Jan 31 2019, 9:32 PM · efl

Jan 30 2019

akanad requested review of D7837: meson: modify install pathes for modules of ecore_buffer.
Jan 30 2019, 10:17 PM · efl
akanad added reviewers for D7836: meson: modify install path of bqmgr binary: bu5hm4n, reviewers.
Jan 30 2019, 10:05 PM · efl
akanad requested review of D7836: meson: modify install path of bqmgr binary.
Jan 30 2019, 10:04 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

That is my version

Lua 5.3.5 Copyright (C) 1994-2018 Lua.org, PUC-Rio

meson configures just fine.

And the corresponding 'lua has been found: "Message: lua(version :>=5.1.0) for lua intepreter has been found"'

To me it seems that we aren't able to run with lua5.3/5.2 at all, since we use api which is only available in lua5.1...

Have you checked "ENABLE_LUA_OLD" and what it does ?

Jan 30 2019, 6:21 PM · efl