Page MenuHomePhabricator

akanad (Wonki Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2016, 12:48 AM (207 w, 2 h)
Availability
Available

Recent Activity

Tue, Mar 17

akanad requested review of D11534: ecore: fix a potentional null dereferencing.
Tue, Mar 17, 9:34 PM · efl
akanad added a comment to D11276: elm: add a logic to load modules for ui inspection.

Still:

  1. why not just use clouseau, and write a extension for it ?
  2. Loading modules means, you have to add them to the config, means, whenever you want to debug your application you need to know which modules are running right now in order to overwrite the modules string correctly.
Tue, Mar 17, 6:20 PM · efl
akanad updated the diff for D11276: elm: add a logic to load modules for ui inspection.
  • rebasing
  • add the module name into config (I forget to add this cause I was using ELM_MODULES env)
Tue, Mar 17, 2:39 AM · efl

Mon, Mar 16

akanad updated the diff for D11368: emile: fix a potentional resource leaking..

rebasing

Mon, Mar 16, 9:51 PM · efl
akanad requested review of D11510: eina_file: fix a typo error.
Mon, Mar 16, 12:24 AM · efl

Mar 1 2020

akanad requested review of D11437: ecore_wl: removes unreachable statements.
Mar 1 2020, 9:26 PM · efl

Feb 26 2020

akanad requested review of D11427: scroller: modify to verify bar position variables.
Feb 26 2020, 9:44 PM · efl

Feb 19 2020

akanad added a comment to D11368: emile: fix a potentional resource leaking..

in the github link, a patch looks like below.

Feb 19 2020, 6:20 PM · efl
akanad updated the diff for D11368: emile: fix a potentional resource leaking..
  • branch by openssl version
  • rebase
Feb 19 2020, 6:12 PM · efl

Feb 18 2020

akanad updated the diff for D11276: elm: add a logic to load modules for ui inspection.
  • rebase onto the latest
Feb 18 2020, 6:24 PM · efl
akanad abandoned D11365: Revert "edje: add fixed automatically for optimizing edje calc speed.".
Feb 18 2020, 2:05 AM · efl

Feb 17 2020

akanad updated the diff for D11370: efl_con: add a default condition to switch statement.
  • edit commit message
  • modify conditions again.
Feb 17 2020, 5:07 PM · efl
akanad updated the diff for D11371: ecore_con: fix to check a return value of functions.
  • fix a wrong condition
Feb 17 2020, 4:58 PM · efl
akanad added a comment to D11372: elementary: fix data los by dividing by integer.

I don't have a specific case (from a point of geometry value view) to convince this patch.
In general point of view, there is a difference between results of /2 and /2.0.
printf("%d %d", (int)(5/2 + 5/2), (int)(5/2.0 + 5/2.0));

Feb 17 2020, 7:33 AM · efl
akanad added inline comments to D11371: ecore_con: fix to check a return value of functions.
Feb 17 2020, 7:26 AM · efl
akanad requested review of D11372: elementary: fix data los by dividing by integer.
Feb 17 2020, 4:47 AM · efl
akanad requested review of D11371: ecore_con: fix to check a return value of functions.
Feb 17 2020, 4:46 AM · efl
akanad requested review of D11370: efl_con: add a default condition to switch statement.
Feb 17 2020, 4:45 AM · efl
akanad requested review of D11369: ecore: fix a memory leak.
Feb 17 2020, 4:41 AM · efl
akanad requested review of D11368: emile: fix a potentional resource leaking..
Feb 17 2020, 4:38 AM · efl
akanad requested review of D11367: emile: remove a improper free logic.
Feb 17 2020, 4:37 AM · efl
akanad abandoned D11359: elementary: fix data los by dividing by integer.

abandoned for splitting commits.

Feb 17 2020, 4:36 AM · efl
akanad requested review of D11366: edje: modify to respect user set fixed property.
Feb 17 2020, 4:09 AM · efl
akanad requested review of D11365: Revert "edje: add fixed automatically for optimizing edje calc speed.".
Feb 17 2020, 3:00 AM · efl

Feb 16 2020

akanad requested review of D11359: elementary: fix data los by dividing by integer.
Feb 16 2020, 5:31 PM · efl
akanad updated the diff for D11276: elm: add a logic to load modules for ui inspection.
  • rebasing
  • ping
Feb 16 2020, 5:21 PM · efl

Feb 11 2020

akanad requested review of D11326: edje_cc : remove potential NULL dereferencing.
Feb 11 2020, 9:51 PM · efl
akanad requested review of D11325: eo: remove potentional NULL dereferencing.
Feb 11 2020, 9:51 PM · efl
akanad requested review of D11324: evas: remove redundant conditions..
Feb 11 2020, 8:30 PM · efl

Feb 10 2020

akanad updated the diff for D11276: elm: add a logic to load modules for ui inspection.
  • modify parameters
  • fix a leak stuff
  • add phab comments
Feb 10 2020, 10:55 PM · efl
akanad added inline comments to D11276: elm: add a logic to load modules for ui inspection.
Feb 10 2020, 10:54 PM · efl

Feb 7 2020

akanad added a reviewer for D11276: elm: add a logic to load modules for ui inspection: Hermet.
Feb 7 2020, 1:34 AM · efl

Feb 3 2020

akanad requested review of D11276: elm: add a logic to load modules for ui inspection.
Feb 3 2020, 6:18 PM · efl

Dec 9 2019

akanad updated the diff for D10821: docs: fix to make docs contain proper images.
  • rebasing
  • removing image links by using htmlonly tag
Dec 9 2019, 11:45 PM · efl

Dec 8 2019

akanad updated the diff for D10821: docs: fix to make docs contain proper images.
  • removing efl_copy.sh
  • reasoning for this patch
Dec 8 2019, 6:07 PM · efl

Dec 6 2019

akanad updated the diff for D10723: collection_view: fix a potentional error.
  • rebasing
  • ping
Dec 6 2019, 12:30 AM · efl
akanad updated the diff for D10745: focus: modify a formula to calculate focus region to show.
  • rebasing
  • ping
Dec 6 2019, 12:29 AM · efl
akanad requested review of D10821: docs: fix to make docs contain proper images.
Dec 6 2019, 12:28 AM · efl

Nov 27 2019

akanad added a comment to D10723: collection_view: fix a potentional error.
  1. assigning negative int value into bigger unsigned int variable makes loss of meaning of sign bit.
Nov 27 2019, 1:23 AM · efl
akanad requested review of D10745: focus: modify a formula to calculate focus region to show.
Nov 27 2019, 1:12 AM · efl

Nov 22 2019

akanad requested review of D10723: collection_view: fix a potentional error.
Nov 22 2019, 2:05 AM · efl
akanad requested review of D10722: efl_ui_table: modify comparing logic.
Nov 22 2019, 2:05 AM · efl

Nov 20 2019

akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

@cedric
ping~!
would you please let me know your opinion about this?

Nov 20 2019, 6:06 PM · efl
akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

I see, I misunderstood.
I thought that you suggested to use cos rather than cosf because Eina_Matrix{N} has double type structure variables.

Nov 20 2019, 6:04 PM · efl

Nov 19 2019

akanad added a reviewer for D10695: eina_matrix: replace cosf by cos to gain more accuracy: vtorri.
Nov 19 2019, 6:14 PM · efl
akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

Yes. I think it's needed. Because

Nov 19 2019, 6:13 PM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.

restore everything, just remove a 'f' characters

Nov 19 2019, 3:42 AM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.
  • keep meaning of removed comment.
  • modify a corresponding testcase.
Nov 19 2019, 3:25 AM · efl
akanad requested review of D10695: eina_matrix: replace cosf by cos to gain more accuracy.
Nov 19 2019, 2:05 AM · efl

Nov 5 2019

akanad added a comment to T7717: docs todo.

@segfaultxavi
I tried to improve descriptions for efl_loop_message_future.eo and efl_loop_message_future_handler.eo.
They look like actually unused, though.
I mean they are created and assigned but there isn't a place that accesses or call some apis to those things.
Am I wrong?

Nov 5 2019, 11:50 PM · efl (efl-1.24), efl: docs, efl: api
akanad updated the diff for D10591: check: reset flags that used for legacy 'changed' cb.
  1. add a new testcase for elm_check
  2. rebase
Nov 5 2019, 6:06 PM · efl

Nov 3 2019

akanad requested review of D10591: check: reset flags that used for legacy 'changed' cb.
Nov 3 2019, 5:53 PM · efl
akanad updated the diff for D10578: elm_config: replace ecore_file_cp with ecore_file_mv.

rebase onto the lastest.
and ping.

Nov 3 2019, 5:43 PM · efl

Oct 30 2019

akanad requested review of D10578: elm_config: replace ecore_file_cp with ecore_file_mv.
Oct 30 2019, 9:56 PM · efl

Sep 24 2019

akanad added a comment to D10105: test: add a new testcase for paging of scroller.

This testcase is what I described before at T5151.
there could be necessary more than 1 loop to complete what I intended.
ecore_main_loop_begin(get_me_to_those_events) seems required.
if I change it to ecore_main_loop_iterate(), test passes.

Sep 24 2019, 9:29 PM · DO NOT MERGE, efl
akanad updated the diff for D10105: test: add a new testcase for paging of scroller.
  • adding EINA_UNUSED marks
  • aligning a type of page_num variables
Sep 24 2019, 9:19 PM · DO NOT MERGE, efl

Sep 23 2019

akanad closed T7450: fileselector couldn't traverse properly once expandable mode is on as Resolved.
Sep 23 2019, 10:09 PM
akanad requested review of D10105: test: add a new testcase for paging of scroller.
Sep 23 2019, 10:08 PM · DO NOT MERGE, efl
akanad updated the diff for D10103: doc: update ecore_filter_model description.

change the commit body

Sep 23 2019, 6:50 PM · efl
akanad updated the diff for D10103: doc: update ecore_filter_model description.

update little more

Sep 23 2019, 6:49 PM · efl
akanad added a comment to T7717: docs todo.

src/lib/ecore/efl_exe.eo (@akanad) seems done with your(@segfaultxavi) comit (f78b4861af140bd5b333fb530556e81915acbaab).

Sep 23 2019, 6:47 PM · efl (efl-1.24), efl: docs, efl: api
akanad requested review of D10103: doc: update ecore_filter_model description.
Sep 23 2019, 6:46 PM · efl

Sep 20 2019

akanad updated the diff for D10038: test: Add a logic to check a size of Check.

*removing timer for testing on elementary_test
*improving convension style of the testcase

Sep 20 2019, 9:28 PM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

another diff

Sep 20 2019, 1:52 AM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

modifying the commit title

Sep 20 2019, 1:48 AM · efl
akanad updated the diff for D10038: test: Add a logic to check a size of Check.

appending a new test for sizing

Sep 20 2019, 1:36 AM · efl
akanad added a comment to D10038: test: Add a logic to check a size of Check.

you can see a check that has no size if you just pack it without calling any api to it after creating.
Actually this is a story about Efl.Ui.Layout not only check.
because efl_canvas_group_change api are not able to effect any in construction time.

Sep 20 2019, 12:22 AM · efl

Sep 19 2019

akanad requested review of D10039: gesture: fix it not to lose information by dividing.
Sep 19 2019, 10:26 PM · efl
akanad requested review of D10038: test: Add a logic to check a size of Check.
Sep 19 2019, 7:08 PM · efl

Sep 17 2019

akanad updated the diff for D9987: elm_config: fix to check if eet_open fails.

fix to print error and return nullptr

Sep 17 2019, 5:50 PM · efl
akanad requested review of D9987: elm_config: fix to check if eet_open fails.
Sep 17 2019, 4:50 AM · efl

Sep 16 2019

akanad requested review of D9966: elm_config: fix a missing of free after using.
Sep 16 2019, 1:04 AM · efl

Sep 9 2019

akanad requested review of D9889: efl_exe: Enhance class description.
Sep 9 2019, 10:37 PM · efl

Sep 4 2019

akanad abandoned D8694: entry: revert a single line.
Sep 4 2019, 10:32 PM · efl
akanad abandoned D9179: build: Add a option to generate debuginfo.
Sep 4 2019, 10:31 PM · efl

Aug 27 2019

akanad updated the diff for D9748: eina_vpath: add null checking logic on vpath_resolve api.

fix a build error

Aug 27 2019, 4:24 AM · efl
akanad added a reviewer for D9750: eina_list: fix to check a null argument: Hermet.
Aug 27 2019, 4:04 AM · efl
akanad added a reviewer for D9748: eina_vpath: add null checking logic on vpath_resolve api: Hermet.
Aug 27 2019, 4:04 AM · efl

Aug 26 2019

akanad requested review of D9750: eina_list: fix to check a null argument.
Aug 26 2019, 9:28 PM · efl
akanad requested review of D9748: eina_vpath: add null checking logic on vpath_resolve api.
Aug 26 2019, 8:56 PM · efl

Jul 22 2019

akanad updated the summary of D9368: efl_ui_layout: set needs_size_calc flag at constructor.
Jul 22 2019, 3:06 AM · efl

Jul 21 2019

akanad added a comment to D9356: [elm] Add missing sizing eval hook at radio.

I guess that this issue is caused by same reason that D9368 is caused by.

Jul 21 2019, 9:38 PM · efl

Jul 19 2019

akanad requested review of D9368: efl_ui_layout: set needs_size_calc flag at constructor.
Jul 19 2019, 9:21 PM · efl

Jun 27 2019

akanad updated the diff for D8708: meson: fix installation paths for evas/modules.

rebase

Jun 27 2019, 6:55 PM · efl
akanad requested review of D9198: meson: remove autotools checking stuffs.
Jun 27 2019, 6:45 PM · efl

Jun 26 2019

akanad added a comment to D9179: build: Add a option to generate debuginfo.

Im' against that. CFLAGS exists for such purpose

Jun 26 2019, 11:19 PM · efl

Jun 25 2019

akanad requested review of D9179: build: Add a option to generate debuginfo.
Jun 25 2019, 11:40 PM · efl
akanad updated the diff for D9165: enhance help description for command with arguments.

do same thing on exactness_player

Jun 25 2019, 1:04 AM

Jun 24 2019

akanad requested review of D9165: enhance help description for command with arguments.
Jun 24 2019, 10:22 PM
akanad requested review of D9163: fix a build break caused by renaming a window type.
Jun 24 2019, 5:15 AM

Apr 29 2019

akanad requested review of D8787: wl2_input: fix a problem that occurs in case of using both pointer/touch input devices.
Apr 29 2019, 10:38 PM · efl
akanad requested review of D8786: ecore_wl2_input: modify to increase grab count while touching.
Apr 29 2019, 10:15 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

I built this patch over 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl option, and I named them as 'mesongl' / 'mesonnongl'.
and also I built 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl, and named them as 'mesonoldgl' / 'mesonoldnongl',
then compared them.

Apr 29 2019, 9:47 PM · efl
akanad added a reviewer for D8708: meson: fix installation paths for evas/modules: zmike.
Apr 29 2019, 5:59 PM · efl

Apr 28 2019

akanad added a comment to D8708: meson: fix installation paths for evas/modules.

ping~!

Apr 28 2019, 6:14 PM · efl

Apr 25 2019

akanad updated the diff for D8708: meson: fix installation paths for evas/modules.

changes buildsystem_meson.c to refer to evas/modules properly in tree running

Apr 25 2019, 8:33 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

this ticket has 2 commits like below anyway I will post another diff soon.

Apr 25 2019, 8:29 PM · efl

Apr 24 2019

akanad requested review of D8708: meson: fix installation paths for evas/modules.
Apr 24 2019, 10:06 PM · efl

Apr 23 2019

akanad requested review of D8694: entry: revert a single line.
Apr 23 2019, 9:34 PM · efl

Apr 21 2019

akanad requested review of D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Apr 21 2019, 5:17 PM · efl