Page MenuHomePhabricator

akanad (Wonki Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2016, 12:48 AM (161 w, 3 d)
Availability
Available

Recent Activity

Mon, Apr 29

akanad requested review of D8787: wl2_input: fix a problem that occurs in case of using both pointer/touch input devices.
Mon, Apr 29, 10:38 PM · efl
akanad requested review of D8786: ecore_wl2_input: modify to increase grab count while touching.
Mon, Apr 29, 10:15 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

I built this patch over 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl option, and I named them as 'mesongl' / 'mesonnongl'.
and also I built 3bd57c2c66af09b40aa60f17c09b07fadc78befb with/without opengl, and named them as 'mesonoldgl' / 'mesonoldnongl',
then compared them.

Mon, Apr 29, 9:47 PM · efl
akanad added a reviewer for D8708: meson: fix installation paths for evas/modules: zmike.
Mon, Apr 29, 5:59 PM · efl

Sun, Apr 28

akanad added a comment to D8708: meson: fix installation paths for evas/modules.

ping~!

Sun, Apr 28, 6:14 PM · efl

Thu, Apr 25

akanad updated the diff for D8708: meson: fix installation paths for evas/modules.

changes buildsystem_meson.c to refer to evas/modules properly in tree running

Thu, Apr 25, 8:33 PM · efl
akanad added a comment to D8708: meson: fix installation paths for evas/modules.

this ticket has 2 patches like below anyway I will post another diff soon.

Thu, Apr 25, 8:29 PM · efl

Wed, Apr 24

akanad requested review of D8708: meson: fix installation paths for evas/modules.
Wed, Apr 24, 10:06 PM · efl

Tue, Apr 23

akanad requested review of D8694: entry: revert a single line.
Tue, Apr 23, 9:34 PM · efl

Sun, Apr 21

akanad requested review of D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Sun, Apr 21, 5:17 PM · efl

Apr 15 2019

akanad requested review of D8604: scroll_mgr: fix a type for some vars to be portable.
Apr 15 2019, 12:19 AM · efl

Apr 3 2019

akanad requested review of D8551: efreetd: remove a tentative global variable definition.
Apr 3 2019, 7:24 PM · efl

Mar 26 2019

akanad updated the diff for D8483: test: add a test case for elm_entry.

changing a name of tc

Mar 26 2019, 10:37 PM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

right, this patch looks more simple.

Mar 26 2019, 10:16 PM · efl
akanad requested review of D8483: test: add a test case for elm_entry.
Mar 26 2019, 9:02 PM · efl
akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

Hi. I got things confused after having a look of your comment.

Mar 26 2019, 7:33 PM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

this is a missed file for testing

Mar 26 2019, 12:01 AM · efl
akanad updated the diff for D8362: entry: move a point to do 'auto_save' to another place.

I got a point of yours. then how about this?

Mar 26 2019, 12:00 AM · efl

Mar 15 2019

akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

juat add entry under window and pass a existing file to efl entry file set and you will get a problem.

Mar 15 2019, 8:16 AM · efl
akanad added a comment to D8362: entry: move a point to do 'auto_save' to another place.

I am not sure you have checked previous code, have you?
previously, save do was called before setting file path.
and that is the reason why save do would not be called.

Mar 15 2019, 8:14 AM · efl

Mar 14 2019

akanad requested review of D8363: elm_entry: fix to keep api backward compatability.
Mar 14 2019, 10:01 PM · efl
akanad requested review of D8362: entry: move a point to do 'auto_save' to another place.
Mar 14 2019, 9:46 PM · efl
akanad updated the diff for D8337: elm_entry: fix to return a error code if a argument is not valid.

As you wish.

Mar 14 2019, 6:32 PM · efl

Mar 13 2019

akanad requested review of D8337: elm_entry: fix to return a error code if a argument is not valid.
Mar 13 2019, 10:43 PM · efl

Feb 21 2019

akanad updated the diff for D7837: meson: modify install pathes for modules of ecore_buffer.

change to make them as 'module.so' not 'libmodule.so.so'

Feb 21 2019, 1:50 AM · efl

Feb 20 2019

akanad updated the diff for D7919: eio: fix a potentional BOF problem.

rebase

Feb 20 2019, 9:25 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

remove duplicated one

Feb 20 2019, 8:05 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

little fix

Feb 20 2019, 6:07 PM · efl
akanad updated the diff for D7919: eio: fix a potentional BOF problem.

@cedric did you mean a way like this?

Feb 20 2019, 5:38 PM · efl

Feb 14 2019

akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

I hope it's fine.

Feb 14 2019, 2:25 AM · efl

Feb 13 2019

akanad added a comment to D7354: elm_config: fix elm_config_save not to wake idle processes up.

then woud you please revert this? I will write another one as you said.

Feb 13 2019, 3:09 AM · efl

Feb 12 2019

akanad requested review of D7921: ecore_wl2: fix a non-thread safe call..
Feb 12 2019, 11:01 PM · efl
akanad requested review of D7920: ecore_wl2: replace strcpy with strncpy.
Feb 12 2019, 10:56 PM · efl
akanad requested review of D7919: eio: fix a potentional BOF problem.
Feb 12 2019, 10:39 PM · efl
akanad requested review of D7918: ecore_evas: fix a potentional deref after null problem.
Feb 12 2019, 8:45 PM · efl
akanad requested review of D7917: ecore_con: Fix potentional problems around ecore_con.
Feb 12 2019, 8:06 PM · efl

Feb 10 2019

akanad added a comment to D7354: elm_config: fix elm_config_save not to wake idle processes up.

Okay, stop.

This commit breaks my config ... for the second time now ?

Whenever there is a call to _config_profile_change_delay_cb, when no .base.flush.cfg file does exist, then the empty value from the .base.flush.cfg is loaded and stuffed into the real config, which basically erases the config of a user ... ...

Feb 10 2019, 5:45 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

yup, you are right.

Feb 10 2019, 5:09 PM · efl

Jan 31 2019

akanad added a comment to D7842: edje_calc: make INTP use TO_INT_ROUND.

I just found that rounding rules has already defined on IEEE standard.
I think the round implementation as before this patch looks wrong as the standard rule.
(please have a glance at https://en.wikipedia.org/wiki/IEEE_754#Rounding_rules)

Jan 31 2019, 9:32 PM · efl

Jan 30 2019

akanad requested review of D7837: meson: modify install pathes for modules of ecore_buffer.
Jan 30 2019, 10:17 PM · efl
akanad added reviewers for D7836: meson: modify install path of bqmgr binary: bu5hm4n, reviewers.
Jan 30 2019, 10:05 PM · efl
akanad requested review of D7836: meson: modify install path of bqmgr binary.
Jan 30 2019, 10:04 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

That is my version

Lua 5.3.5 Copyright (C) 1994-2018 Lua.org, PUC-Rio

meson configures just fine.

And the corresponding 'lua has been found: "Message: lua(version :>=5.1.0) for lua intepreter has been found"'

To me it seems that we aren't able to run with lua5.3/5.2 at all, since we use api which is only available in lua5.1...

Have you checked "ENABLE_LUA_OLD" and what it does ?

Jan 30 2019, 6:21 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

modify to find lua libraries under version 5.3.0

Jan 30 2019, 6:15 PM · efl
akanad updated the diff for D7819: meson: fix to make results same as a way it does in autotools.

oops again, sorry!

Jan 30 2019, 12:43 AM · efl
akanad updated the diff for D7819: meson: fix to make results same as a way it does in autotools.

that's my fault. :-O

Jan 30 2019, 12:23 AM · efl

Jan 29 2019

akanad added a comment to D7828: build: remove eina-bench-cmp from DIST list.

Wouldn't it be better to make python an optional dependencies and only enable that script in that case?

Jan 29 2019, 7:37 PM · efl
akanad requested review of D7828: build: remove eina-bench-cmp from DIST list.
Jan 29 2019, 2:40 PM · efl
akanad requested review of D7819: meson: fix to make results same as a way it does in autotools.
Jan 29 2019, 2:54 AM · efl

Jan 28 2019

akanad updated the diff for D7766: ecore_wl2_input: update a timestamp whenever possible.

update the patch body.

Jan 28 2019, 6:24 PM · efl

Jan 27 2019

akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

I would like to know the exact reason why a error comes up in your environment cause I don't encounter the error.
woud you please make sure lua(not luajit) is installed on your system?
and then the error comes again while configuring, please attach a log file located on ${builddir}/meson-logs/meson-log.txt.

Jan 27 2019, 7:39 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

fix a little error

Jan 27 2019, 5:36 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

modify to print info messages

Jan 27 2019, 5:34 PM · efl

Jan 24 2019

akanad added reviewers for D7766: ecore_wl2_input: update a timestamp whenever possible: reviewers, cedric.
Jan 24 2019, 7:23 PM · efl
akanad abandoned D4427: edje_entry: Support multibyte on result of retrieve_surrounding_cb.
Jan 24 2019, 5:56 PM · efl
akanad abandoned D4657: interface_scrollable: modify interface callback logics to work asynchronously.
Jan 24 2019, 5:56 PM · efl
akanad abandoned D4671: interface_scrollable: Optimize calculations and remove redundant.
Jan 24 2019, 5:56 PM · efl
akanad abandoned D5160: scroll_manager: new scoller scratch.
Jan 24 2019, 5:56 PM · efl
akanad abandoned D5199: interface_scrollable: Fix scroller to keep its page when changing lang.
Jan 24 2019, 5:55 PM · efl
akanad requested review of D7766: ecore_wl2_input: update a timestamp whenever possible.
Jan 24 2019, 5:54 PM · efl

Jan 17 2019

akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

rebase and fix a osx case.

Jan 17 2019, 5:59 PM · efl
akanad added a comment to D7351: elm_config: remove profile name reading logic from data dir.

my bad, I though that nothing touch profile.cfg on datadir.
I guess this patch should be reverted.

Jan 17 2019, 5:52 PM · efl
akanad added a comment to T7620: Elm hard coded defaults don't match system defaults and enable broken features, system defaults are no longer used.

how about removing hard-coded default and throwing a error, if elm_config fails to get system fallback finally.

Jan 17 2019, 5:51 PM · efl (efl-1.22)

Jan 10 2019

akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

modify the default as luajit

Jan 10 2019, 6:31 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.
In D7564#133360, @q66 wrote:

Yes, have those two values for now, and if "lua" is selected, disable elua entirely. I will update it as necessary when luajit is removed.

Jan 10 2019, 6:26 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

would you please have a look this : )

Jan 10 2019, 6:20 PM · efl
akanad requested review of D7582: meson: define HAVE_TSLIB once tslib option is set.
Jan 10 2019, 4:13 AM · efl
akanad requested review of D7581: meson: Add a option for hyphen dictionaries directory.
Jan 10 2019, 4:07 AM · efl
akanad requested review of D7580: meson: add a option to config the base directory name for elm data.
Jan 10 2019, 4:01 AM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

good~! I will write another changes soon : )

Jan 10 2019, 3:34 AM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

I remembered that I saw something like 'lua51' while using autogen.sh.
and I just found it on m4/efl_lua_old.m4. (regarding to --enable-lua-old)

Jan 10 2019, 3:06 AM · efl
akanad added a comment to D7567: meson: fix a potentionally unexpected behavior.

Thx :)

Jan 10 2019, 1:33 AM · efl

Jan 9 2019

akanad updated the diff for D7567: meson: fix a potentionally unexpected behavior.

'libdrm' variable is overwritten by assigning in different places.
because the var has been already declared in static_libs/libdrm.
and also it seems like if-statements have some reduntdant points.

Jan 9 2019, 11:55 PM · efl
akanad added a comment to D7567: meson: fix a potentionally unexpected behavior.

Mhmm i would rather prefer assigning those variables in the root meson.build dir, so the location of the variable is at a shared root node.

Jan 9 2019, 11:54 PM · efl
akanad abandoned D5925: Remove a unreachable code block.
Jan 9 2019, 7:05 PM · efl
akanad abandoned D6741: bin: add a option for ea_gen binary.
Jan 9 2019, 7:04 PM
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

Yeah, I got it.
and I have another question about edje.
as you know, edje also has a lua dependency, so I can say that which means it only works in luajit environment too?

Jan 9 2019, 6:53 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

IMO, what you said is not the kind of a problem. because the things that we are doing on meson.build are the kind of dependencies.
we don't say that it's a problem to leak a name of window systems such as 'wayland', 'x', don't we?
also luajit has a compatibility on both ABI/API level for lua5.1.
that is the reason why I thought that this kind of configuration could be adapted.

Jan 9 2019, 6:25 PM · efl
akanad updated the diff for D7565: meson: refactor meson.build for ecore_wl2.

fix the error.
my bad ;(

Jan 9 2019, 6:05 PM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

update the commit message

Jan 9 2019, 6:36 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

modify a script for ci service

Jan 9 2019, 6:28 AM · efl
akanad added a comment to D7563: meson: modify options for enabling the bindings.

You are changing the way meson is configured. Please provide a description of what has changed so people unfamiliar with meson does not have to read the file and learn what it all means.
For example:
Instead of meson -Dmono=true -Dcxx=true you now have to use meson -Dbindings=mono,cxx

Jan 9 2019, 6:23 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

disable 'mono' as default

Jan 9 2019, 1:31 AM · efl
akanad requested review of D7567: meson: fix a potentionally unexpected behavior.
Jan 9 2019, 1:21 AM · efl
akanad requested review of D7566: meson: excludes stuffs related with gst if gst is disabled.
Jan 9 2019, 1:05 AM · efl
akanad added inline comments to D7520: GUI: Introduce a feature to selectively generate applications.
Jan 9 2019, 12:58 AM
akanad requested review of D7565: meson: refactor meson.build for ecore_wl2.
Jan 9 2019, 12:44 AM · efl
akanad requested review of D7564: meson: add a option for selecting lua interpreter.
Jan 9 2019, 12:26 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

removes code which is not related with this patch.

Jan 9 2019, 12:17 AM · efl
akanad requested review of D7563: meson: modify options for enabling the bindings.
Jan 9 2019, 12:03 AM · efl

Jan 3 2019

akanad updated the diff for D7520: GUI: Introduce a feature to selectively generate applications.

changes the name of a property for config.json
changes the name of a function for db
changes misc for gui

Jan 3 2019, 9:54 PM
akanad added a comment to D7520: GUI: Introduce a feature to selectively generate applications.

I thought that I should abstract classes so that user don't need to know about a detail of the classes.
I mean I guess that some user doesn't really need to know about what kind of actual classes for "Box" are there.
if they select "Box" then ea_gen would provide a kind of boxes such as elm.box or efl.ui.box.
I agree that "alias" is not perfectly suitable here. so that how about changing it to something like "actual_classes"?

Jan 3 2019, 9:51 PM

Dec 27 2018

akanad added inline comments to D7495: csharp: add a interface to start apps.
Dec 27 2018, 2:30 AM · efl: language bindings
akanad requested review of D7520: GUI: Introduce a feature to selectively generate applications.
Dec 27 2018, 12:06 AM

Dec 26 2018

akanad added inline comments to D7495: csharp: add a interface to start apps.
Dec 26 2018, 8:10 PM · efl: language bindings
akanad requested review of D7513: Add a flag for enable debug mode of ea_spy_check.sh.
Dec 26 2018, 2:16 AM

Dec 13 2018

akanad added a comment to D7300: GUI: modify gui to manage 'db' files.

@JackDanielZ ping~ would you please review this ?

Dec 13 2018, 8:54 PM

Dec 6 2018

akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.

changed variables name

Dec 6 2018, 9:48 PM

Dec 5 2018

akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.

another building blocks of this commit have been implemented.

Dec 5 2018, 11:57 PM

Nov 26 2018

akanad accepted D7365: DB: fix warnings.
Nov 26 2018, 11:45 PM