Page MenuHomePhabricator

akanad (Wonki Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 14 2016, 12:48 AM (143 w, 5 d)
Availability
Available

Recent Activity

Thu, Jan 10

akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

modify the default as luajit

Thu, Jan 10, 6:31 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.
In D7564#133360, @q66 wrote:

Yes, have those two values for now, and if "lua" is selected, disable elua entirely. I will update it as necessary when luajit is removed.

Thu, Jan 10, 6:26 PM · efl
akanad updated the diff for D7564: meson: add a option for selecting lua interpreter.

would you please have a look this : )

Thu, Jan 10, 6:20 PM · efl
akanad requested review of D7582: meson: define HAVE_TSLIB once tslib option is set.
Thu, Jan 10, 4:13 AM · efl
akanad requested review of D7581: meson: Add a option for hyphen dictionaries directory.
Thu, Jan 10, 4:07 AM · efl
akanad requested review of D7580: meson: add a option to config the base directory name for elm data.
Thu, Jan 10, 4:01 AM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

good~! I will write another changes soon : )

Thu, Jan 10, 3:34 AM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

I remembered that I saw something like 'lua51' while using autogen.sh.
and you just found it on m4/efl_lua_old.m4. (regarding to --enable-lua-old)

Thu, Jan 10, 3:06 AM · efl
akanad added a comment to D7567: meson: fix a potentionally unexpected behavior.

Thx :)

Thu, Jan 10, 1:33 AM · efl

Wed, Jan 9

akanad updated the diff for D7567: meson: fix a potentionally unexpected behavior.

'libdrm' variable is overwritten by assigning in different places.
because the var has been already declared in static_libs/libdrm.
and also it seems like if-statements have some reduntdant points.

Wed, Jan 9, 11:55 PM · efl
akanad added a comment to D7567: meson: fix a potentionally unexpected behavior.

Mhmm i would rather prefer assigning those variables in the root meson.build dir, so the location of the variable is at a shared root node.

Wed, Jan 9, 11:54 PM · efl
akanad abandoned D5925: Remove a unreachable code block.
Wed, Jan 9, 7:05 PM · efl
akanad abandoned D6741: bin: add a option for ea_gen binary.
Wed, Jan 9, 7:04 PM
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

Yeah, I got it.
and I have another question about edje.
as you know, edje also has a lua dependency, so I can say that which means it only works in luajit environment too?

Wed, Jan 9, 6:53 PM · efl
akanad added a comment to D7564: meson: add a option for selecting lua interpreter.

IMO, what you said is not the kind of a problem. because the things that we are doing on meson.build are the kind of dependencies.
we don't say that it's a problem to leak a name of window systems such as 'wayland', 'x', don't we?
also luajit has a compatibility on both ABI/API level for lua5.1.
that is the reason why I thought that this kind of configuration could be adapted.

Wed, Jan 9, 6:25 PM · efl
akanad updated the diff for D7565: meson: refactor meson.build for ecore_wl2.

fix the error.
my bad ;(

Wed, Jan 9, 6:05 PM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

update the commit message

Wed, Jan 9, 6:36 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

modify a script for ci service

Wed, Jan 9, 6:28 AM · efl
akanad added a comment to D7563: meson: modify options for enabling the bindings.

You are changing the way meson is configured. Please provide a description of what has changed so people unfamiliar with meson does not have to read the file and learn what it all means.
For example:
Instead of meson -Dmono=true -Dcxx=true you now have to use meson -Dbindings=mono,cxx

Wed, Jan 9, 6:23 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

disable 'mono' as default

Wed, Jan 9, 1:31 AM · efl
akanad requested review of D7567: meson: fix a potentionally unexpected behavior.
Wed, Jan 9, 1:21 AM · efl
akanad requested review of D7566: meson: excludes stuffs related with gst if gst is disabled.
Wed, Jan 9, 1:05 AM · efl
akanad added inline comments to D7520: GUI: Introduce a feature to selectively generate applications.
Wed, Jan 9, 12:58 AM
akanad requested review of D7565: meson: refactor meson.build for ecore_wl2.
Wed, Jan 9, 12:44 AM · efl
akanad requested review of D7564: meson: add a option for selecting lua interpreter.
Wed, Jan 9, 12:26 AM · efl
akanad updated the diff for D7563: meson: modify options for enabling the bindings.

removes code which is not related with this patch.

Wed, Jan 9, 12:17 AM · efl
akanad requested review of D7563: meson: modify options for enabling the bindings.
Wed, Jan 9, 12:03 AM · efl

Thu, Jan 3

akanad updated the diff for D7520: GUI: Introduce a feature to selectively generate applications.

changes the name of a property for config.json
changes the name of a function for db
changes misc for gui

Thu, Jan 3, 9:54 PM
akanad added a comment to D7520: GUI: Introduce a feature to selectively generate applications.

I thought that I should abstract classes so that user don't need to know about a detail of the classes.
I mean I guess that some user doesn't really need to know about what kind of actual classes for "Box" are there.
if they select "Box" then ea_gen would provide a kind of boxes such as elm.box or efl.ui.box.
I agree that "alias" is not perfectly suitable here. so that how about changing it to something like "actual_classes"?

Thu, Jan 3, 9:51 PM

Thu, Dec 27

akanad added inline comments to D7495: csharp: add a interface to start apps.
Thu, Dec 27, 2:30 AM · efl: language bindings
akanad requested review of D7520: GUI: Introduce a feature to selectively generate applications.
Thu, Dec 27, 12:06 AM

Wed, Dec 26

akanad added inline comments to D7495: csharp: add a interface to start apps.
Wed, Dec 26, 8:10 PM · efl: language bindings
akanad requested review of D7513: Add a flag for enable debug mode of ea_spy_check.sh.
Wed, Dec 26, 2:16 AM

Dec 13 2018

akanad added a comment to D7300: GUI: modify gui to manage 'db' files.

@JackDanielZ ping~ would you please review this ?

Dec 13 2018, 8:54 PM

Dec 6 2018

akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.

changed variables name

Dec 6 2018, 9:48 PM

Dec 5 2018

akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.

another building blocks of this commit have been implemented.

Dec 5 2018, 11:57 PM

Nov 26 2018

akanad accepted D7365: DB: fix warnings.
Nov 26 2018, 11:45 PM
akanad added a comment to D7354: elm_config: fix elm_config_save not to wake idle processes up.

@cedric
if you don't mind, would you please review this patch?

Nov 26 2018, 10:47 PM · efl
akanad added a comment to D7352: elm_config: replace ecore_file_mv with ecore_file_cp.

Hello @cedric
I've fix a mistake of mine.
would you please review again?

Nov 26 2018, 10:47 PM · efl
akanad added a comment to D7351: elm_config: remove profile name reading logic from data dir.

IMHO, this patch is obviously good to land, isn't it?
nowhere writes profile.cfg located on a data dir.

Nov 26 2018, 10:44 PM · efl
akanad updated the diff for D7354: elm_config: fix elm_config_save not to wake idle processes up.

Makes empty .cfg files in advance to make eio_monitor be able to track them.

Nov 26 2018, 8:49 PM · efl

Nov 23 2018

akanad updated the diff for D7354: elm_config: fix elm_config_save not to wake idle processes up.

removes a tmp file after copying

Nov 23 2018, 7:47 PM · efl
akanad updated the diff for D7352: elm_config: replace ecore_file_mv with ecore_file_cp.

removes a tmp file after copying

Nov 23 2018, 7:25 PM · efl
akanad requested review of D7354: elm_config: fix elm_config_save not to wake idle processes up.
Nov 23 2018, 3:51 AM · efl
akanad requested review of D7352: elm_config: replace ecore_file_mv with ecore_file_cp.
Nov 23 2018, 3:21 AM · efl
akanad updated the diff for D7351: elm_config: remove profile name reading logic from data dir.

rebase

Nov 23 2018, 3:12 AM · efl
akanad requested review of D7351: elm_config: remove profile name reading logic from data dir.
Nov 23 2018, 3:09 AM · efl

Nov 21 2018

akanad added inline comments to D7300: GUI: modify gui to manage 'db' files.
Nov 21 2018, 11:30 PM

Nov 19 2018

akanad added inline comments to D7300: GUI: modify gui to manage 'db' files.
Nov 19 2018, 6:56 PM

Nov 18 2018

akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.
  • gui: Add database list on the explorer panel
Nov 18 2018, 7:00 PM
akanad updated the summary of D7300: GUI: modify gui to manage 'db' files.
Nov 18 2018, 6:12 PM
akanad updated the diff for D7300: GUI: modify gui to manage 'db' files.
  • config: Add database path list to config
Nov 18 2018, 6:11 PM
akanad requested review of D7300: GUI: modify gui to manage 'db' files.
Nov 18 2018, 6:08 PM

Nov 12 2018

akanad requested review of D7259: update .gitignore for vscode.
Nov 12 2018, 12:09 AM
akanad updated the diff for D7258: db: Make functions referentially transparent.

another minor update

Nov 12 2018, 12:05 AM

Nov 11 2018

akanad updated the diff for D7258: db: Make functions referentially transparent.

minor updates

Nov 11 2018, 11:52 PM
akanad requested review of D7258: db: Make functions referentially transparent.
Nov 11 2018, 11:46 PM

Nov 8 2018

akanad requested review of D7250: db: fix _db_clear() to refer to proper variable.
Nov 8 2018, 11:47 PM
akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.

I added hints for some members which are needed to be restored in run-time.
And I removed a union field to reduce implementation complexity while gaining space complexity.

Nov 8 2018, 11:41 PM

Nov 3 2018

akanad requested review of D7236: gui: turn fileselector expandable mode off.
Nov 3 2018, 8:01 AM
akanad created T7450: fileselector couldn't traverse properly once expandable mode is on.
Nov 3 2018, 7:48 AM

Nov 1 2018

akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.

working in progress

Nov 1 2018, 11:55 PM
akanad added inline comments to D6950: db: introduce [de]serializing _DB as a file.
Nov 1 2018, 6:52 PM
akanad requested review of D7229: gui: prevent potentional race-condition.
Nov 1 2018, 5:54 PM

Oct 31 2018

akanad requested review of D7225: ecore: modify documentation for ecore_thread_wait.
Oct 31 2018, 7:27 PM · efl

Oct 26 2018

This is a test notification, sent at Fri, Oct 26, 4:56 PM.
Oct 26 2018, 12:56 AM

Oct 25 2018

akanad updated the summary of D7210: Add shared option to make a binary as a shared object.
Oct 25 2018, 5:56 PM
akanad updated the diff for D7210: Add shared option to make a binary as a shared object.

my bad.

Oct 25 2018, 1:12 AM
akanad updated the diff for D7210: Add shared option to make a binary as a shared object.

enable pie option

Oct 25 2018, 1:11 AM
akanad added a comment to D7210: Add shared option to make a binary as a shared object.

pie option has been enabled as default for security reason. and shared option will be enabled once pie option is enabled.
that's the reason why this patch is needed.

Oct 25 2018, 12:47 AM

Oct 24 2018

akanad added a comment to D7210: Add shared option to make a binary as a shared object.

you can find configure option of your gcc by executing gcc -Q -v

Oct 24 2018, 11:09 PM
akanad updated the diff for D7210: Add shared option to make a binary as a shared object.

typo on option

Oct 24 2018, 11:08 PM
akanad requested review of D7210: Add shared option to make a binary as a shared object.
Oct 24 2018, 11:03 PM
akanad updated the summary of D6950: db: introduce [de]serializing _DB as a file.
Oct 24 2018, 6:00 PM
akanad added a comment to D6950: db: introduce [de]serializing _DB as a file.

Hello @JackDanielZ
would you please help me to implement saving feature of _DB ?
It's much more complicated than I expected to save "Eolian_Data_Structures" as a differenct form then restore while load eet file.

Oct 24 2018, 5:52 PM
akanad abandoned D6728: db_ml_add: remove redundant code blocks.
Oct 24 2018, 5:50 PM

Oct 23 2018

akanad requested review of D7202: Overwrite eet config file once env var is passed.
Oct 23 2018, 5:37 AM

Oct 16 2018

akanad requested review of D7167: ecore_wl2: Fix a memory leaking case.
Oct 16 2018, 5:23 PM · efl

Oct 9 2018

akanad requested review of D7151: elementary: fix a typo on override func of signal_callback_del.
Oct 9 2018, 11:27 PM · efl

Sep 27 2018

akanad accepted D7114: elm_interface_scrollable: fix using wrong variable..
Sep 27 2018, 11:47 PM · efl

Sep 26 2018

akanad added a comment to D7114: elm_interface_scrollable: fix using wrong variable..

this function is for finding out a current animating speed of momentum scrolling.
and a caller of this function calls this function by reference(vx, vy)
so that if progress ratio is not between 0 and 1, vx, vy must be zero.

Sep 26 2018, 11:35 PM · efl

Sep 21 2018

akanad added a comment to D6950: db: introduce [de]serializing _DB as a file.

dependency descriptions

Sep 21 2018, 4:53 AM
akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.

squash two patches by a patch.

Sep 21 2018, 4:09 AM
akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.
  • DB: Save db as eet file
Sep 21 2018, 4:06 AM
akanad requested review of D7096: evas: Modify configure to branch by architectures for neon.
Sep 21 2018, 3:48 AM · efl

Aug 30 2018

akanad added a comment to D6955: elm_interface_scrollable: fix wrong pointer reference.

definitely.
+1

Aug 30 2018, 8:18 PM · efl
akanad added a comment to D6950: db: introduce [de]serializing _DB as a file.

It has much more complicated than I expected : )
though I couldn't finished things such as union field, I'd like to share it first to hear your opinion.

Aug 30 2018, 8:07 PM
akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.
  • DB: Save db as eet file
Aug 30 2018, 7:55 PM
akanad added a comment to D6922: evas: replace a current copy color function for neon.

I will find out how many neon code without maintaining for drawing over efl
then I'll get back to this thread after checking those things are able to replaced by the pixman.

Aug 30 2018, 5:30 PM · efl
akanad added a comment to D6950: db: introduce [de]serializing _DB as a file.

I think that those features(saving _DB & loading eet) make ea_gen more useful.
for example, we are able to make a new db set easily by mixing existing db sets.

Aug 30 2018, 5:20 PM
akanad updated the diff for D6950: db: introduce [de]serializing _DB as a file.

Add a name for another field.

Aug 30 2018, 2:37 AM
akanad requested review of D6950: db: introduce [de]serializing _DB as a file.
Aug 30 2018, 2:32 AM

Aug 29 2018

akanad added a reviewer for D6741: bin: add a option for ea_gen binary: JackDanielZ.
Aug 29 2018, 7:07 PM
akanad updated the diff for D6741: bin: add a option for ea_gen binary.

modify to use existing logic

Aug 29 2018, 7:06 PM
akanad added a comment to D6922: evas: replace a current copy color function for neon.

I am not sure this is good enough to go.
It seems that it has been long time no maintaining on current neon related code.
and I heard that very few people are using arm profile(exclude samsung) and able to maintain it.
if it is true that I'm saying, how about replacing all neon code with pixman's one ?

Aug 29 2018, 5:31 AM · efl
akanad requested review of D6922: evas: replace a current copy color function for neon.
Aug 29 2018, 5:28 AM · efl

Aug 28 2018

akanad added a comment to D6920: ci: run tests up to 5 times before failing.

how about extracting those numbers as variable like below ?

Aug 28 2018, 6:25 PM · efl
akanad abandoned D6219: elementary: Fix key_action logic for image_zoomable.
Aug 28 2018, 6:20 PM · efl
akanad updated the diff for D6593: scroller: removes unused variables.

rebased onto origin/master

Aug 28 2018, 6:19 PM · efl: widgets
akanad updated the diff for D6643: scroller: refactory a momentum scroll animator.

edit commit message

Aug 28 2018, 4:10 AM · DO NOT MERGE, efl