♟ ali.alzyod

D12145 should fix this issue

This is an old issue:

How can we produce this issue ?

remove unneeded events from legacy object

This patch already update unibreak D11743, It also update some internal stuff in EFL to not break compatibility

Things seems better with this change.

In D12117#231640, @devilhorns wrote:

I Agree With the Idea of this patch ... BUT when you're variables are spelled wrong, then I cannot trust it...Please fix the spelling issues....

From what I understand from the source code, the user can not specify padding directly, it is calculated automatically depending on Style Effects (shadow, Glow, ... etc).
These effects will change text size, so I think it should be counted when calculating text size in both native and formatted size.

/**
 * @brief The formatted width and height.
 *
 * This calculates the actual size after restricting the textblock to the
 * current size of the object.
 *
 * The main difference between this and
 * @ref evas_object_textblock_size_native_get is that the "native" function
 * does not wrapping into account it just calculates the real width of the
 * object if it was placed on an infinite canvas, while this function gives the
 * size after wrapping according to the size restrictions of the object.
 *
 * For example for a textblock containing the text: "You shall not pass!" with
 * no margins or padding and assuming a monospace font and a size of 7x10 char
 * widths (for simplicity) has a native size of 19x1 and a formatted size of
 * 5x4.
 *
 * @param[in] obj The object.
 * @param[out] width The width of the object.
 * @param[out] height The height of the object.
 *
 * @since 1.18
 *
 * @ingroup Evas_Object_Textblock_Group
 */
EAPI void evas_object_textblock_size_formatted_get(const Efl_Canvas_Textblock *obj, int *width, int *height);

Sure there are issue here, but what is the right behaviour to resolve it.

Ninja test is failing

add missing condition

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position

Can you please check comments

since EDC does not respect Multiline property in TEXTBLOCK object, this will break compatibility

I updated testing sample code with -O3 optimization to show the speed up.

In D12066#230432, @stefan_schmidt wrote:

Your commit message is really sparse.

When looking into this I found that this symbol is defined in a enum as well as the define (which you use).
So we are not loosing the symbol, but simply removing a duplicate of it. Is that correct?

@raster Changes are done

Seems fine to me. thank you

set enum first in function parameters

In T8737#152897, @ali.alzyod wrote:

In T8737#152896, @raster wrote:

can we not cal it texture_cache? as this also applies to software also not long but int will do like the other caches. if people need > 2gb of cache for this... they have problems :) so maybe evas_font_data_cache_set/get(). ?

these function does not effect SW render, only gl renderer

Update global functions by : Add options, general function names, use bigger variables types

clean white spaces, unused vars

move implementation inside the Engine

ali.alzyod (Ali Alzyod)
User

Projects

Calendar

Today

Tomorrow

Monday

User Details

Recent Activity
View All

Wed, Sep 23

Mon, Sep 14

Thu, Sep 10

Sun, Sep 6

Fri, Sep 4

Tue, Sep 1

Sun, Aug 30

Aug 26 2020

Aug 25 2020

Aug 24 2020

Aug 17 2020

Aug 16 2020

Aug 10 2020

Aug 9 2020

Aug 5 2020

Aug 4 2020

Jul 29 2020

Jul 28 2020

Jul 27 2020

Jul 26 2020

Jul 22 2020

Jul 21 2020

Jul 20 2020

Jul 19 2020

Jul 17 2020

Jul 16 2020

Jul 15 2020

Jul 13 2020

Jul 8 2020

Jul 6 2020

ali.alzyod (Ali Alzyod)User