Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (20 w, 2 d)
Availability
Available

Recent Activity

Today

ali.alzyod added a comment to D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

@raster if I understand your comment well, I think the (sd->text) does not always have the entry text, specially if you append text in-front or back, so condition will be on "elm.text" part to ensure this is entry latest text

Thu, Apr 18, 6:24 AM · efl
ali.alzyod added a comment to D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

developer should not do case 1 it is invalid, but it case he did it, we will help him :)

Thu, Apr 18, 6:08 AM · efl
ali.alzyod updated the diff for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

use goto label

Thu, Apr 18, 6:06 AM · efl
ali.alzyod updated the diff for D8603: Change Single Line Mode behaviour in Entry.

move logic to edje_entry

Thu, Apr 18, 5:49 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

@raster again I am not against caching, caching is great.

Thu, Apr 18, 3:38 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

Normally inside destructor you will check all data members for your object. (so you will not forget them), but for global maybe you did not know that you have global ones.

Thu, Apr 18, 12:36 AM · efl
ali.alzyod updated the test plan for D8578: Freeing Global Memory list on destructor.
Thu, Apr 18, 12:17 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

@bu5hm4n It is bad Idea because it lead to :
1- Hard to follow memory leaks,
2- With any updating to the code,There is high probability to accidentally forget about global vars ,(This case shows my point) (like this memory leak)

Thu, Apr 18, 12:10 AM · efl
ali.alzyod added a comment to D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

It work if we are going to set text in "elm.text", else we do not care inside this function

Thu, Apr 18, 12:07 AM · efl
ali.alzyod updated the diff for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

add event thaw

Thu, Apr 18, 12:05 AM · efl

Yesterday

ali.alzyod updated the diff for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

move code, and align with code convention

Wed, Apr 17, 11:45 PM · efl
ali.alzyod closed D8578: Freeing Global Memory list on destructor.
Wed, Apr 17, 11:33 PM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.

code convention

Wed, Apr 17, 5:57 AM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.

follow EFL code convention for while/if statments

Wed, Apr 17, 5:54 AM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Wed, Apr 17, 5:51 AM · efl
ali.alzyod added inline comments to D8610: Change Way of searching for Escape strings/values.
Wed, Apr 17, 3:34 AM · efl
ali.alzyod added inline comments to D8610: Change Way of searching for Escape strings/values.
Wed, Apr 17, 3:30 AM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
  • fix typo in the comments
Wed, Apr 17, 1:47 AM · efl
ali.alzyod added a comment to D8610: Change Way of searching for Escape strings/values.

@segfaultxavi I already update them Test Plan

Wed, Apr 17, 1:32 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.

Thanks for all the information

Wed, Apr 17, 12:44 AM · enlightenment-git
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Wed, Apr 17, 12:05 AM · efl

Tue, Apr 16

ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 11:58 PM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 11:57 PM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 11:48 PM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 11:47 PM · efl
ali.alzyod updated the test plan for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 11:41 PM · efl
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.

-search common escapes first
-EFL coding conventions

Tue, Apr 16, 11:40 PM · efl
ali.alzyod added a comment to D8610: Change Way of searching for Escape strings/values.

@segfaultxavi I will update the code to get better results that old one for pure common escapes.

Tue, Apr 16, 11:55 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.

I think it is make sense to reuse memory, instead of realloc

Tue, Apr 16, 11:48 AM · enlightenment-git
ali.alzyod updated the diff for D8610: Change Way of searching for Escape strings/values.
  • fix typo in the comments
Tue, Apr 16, 10:02 AM · efl
ali.alzyod added a comment to D8610: Change Way of searching for Escape strings/values.

Old Code
total time for escape_string is 2.370570
total time for common escape_string is 0.100057
total time for string_escape is 2.430365

Tue, Apr 16, 9:53 AM · efl
ali.alzyod updated the test plan for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 9:31 AM · efl
ali.alzyod added inline comments to D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 5:54 AM · efl
ali.alzyod added a comment to D8610: Change Way of searching for Escape strings/values.

@segfaultxavi Yes I think we can skip first '&' and last ';' from checking, this will enhance performance more

Tue, Apr 16, 5:16 AM · efl
ali.alzyod updated the test plan for D8610: Change Way of searching for Escape strings/values.
Tue, Apr 16, 5:13 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include<Eina.h>
#include<Efl.h>
#include <Elementary.h>
Tue, Apr 16, 3:56 AM · enlightenment-git

Mon, Apr 15

ali.alzyod updated the summary of D8610: Change Way of searching for Escape strings/values.
Mon, Apr 15, 10:46 AM · efl
ali.alzyod added reviewers for D8610: Change Way of searching for Escape strings/values: woohyun, bowonryu.
Mon, Apr 15, 10:43 AM · efl
ali.alzyod updated the summary of D8610: Change Way of searching for Escape strings/values.
Mon, Apr 15, 10:42 AM · efl
ali.alzyod updated the summary of D8610: Change Way of searching for Escape strings/values.
Mon, Apr 15, 10:38 AM · efl
ali.alzyod requested review of D8610: Change Way of searching for Escape strings/values.
Mon, Apr 15, 10:32 AM · efl

Sun, Apr 14

ali.alzyod updated the summary of D8603: Change Single Line Mode behaviour in Entry.
Sun, Apr 14, 7:09 AM · efl
ali.alzyod added reviewers for D8603: Change Single Line Mode behaviour in Entry: bowonryu, woohyun.
Sun, Apr 14, 6:41 AM · efl
ali.alzyod updated the summary of D8603: Change Single Line Mode behaviour in Entry.
Sun, Apr 14, 6:40 AM · efl
ali.alzyod requested review of D8603: Change Single Line Mode behaviour in Entry.
Sun, Apr 14, 6:36 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include<Eina.h>
#include<Efl.h>
#include <Elementary.h>
Sun, Apr 14, 5:42 AM · enlightenment-git
ali.alzyod added a comment to T7788: Memory Leak efl_add.

@raster Thank you for clear it out.

Sun, Apr 14, 5:19 AM · enlightenment-git
ali.alzyod updated subscribers of T7788: Memory Leak efl_add.

@raster Can you please take look at this?

Sun, Apr 14, 12:01 AM · enlightenment-git

Thu, Apr 11

ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

99% of the time, it is a bad idea to use global variables inside library

Thu, Apr 11, 9:32 AM · efl

Tue, Apr 9

ali.alzyod updated the test plan for D8578: Freeing Global Memory list on destructor.
Tue, Apr 9, 8:22 AM · efl
ali.alzyod updated the diff for D8578: Freeing Global Memory list on destructor.

remove merged changes

Tue, Apr 9, 8:17 AM · efl

Mon, Apr 8

ali.alzyod added reviewers for D8578: Freeing Global Memory list on destructor: woohyun, bowonryu.
Mon, Apr 8, 9:54 AM · efl
ali.alzyod updated the summary of D8578: Freeing Global Memory list on destructor.
Mon, Apr 8, 9:53 AM · efl
ali.alzyod retitled D8578: Freeing Global Memory list on destructor from Speed up setting text (check if same text is already set), fix setting same text pointer to Freeing Global Memory list on destructor.
Mon, Apr 8, 9:52 AM · efl
ali.alzyod requested review of D8578: Freeing Global Memory list on destructor.
Mon, Apr 8, 9:50 AM · efl
ali.alzyod updated the task description for T7788: Memory Leak efl_add.
Mon, Apr 8, 9:45 AM · enlightenment-git
Herald added a project to T7788: Memory Leak efl_add: enlightenment-git.
Mon, Apr 8, 9:44 AM · enlightenment-git

Sun, Apr 7

ali.alzyod updated the test plan for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.
Sun, Apr 7, 6:26 AM · efl
ali.alzyod added reviewers for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer: bu5hm4n, zmike.
Sun, Apr 7, 6:25 AM · efl
ali.alzyod added reviewers for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer: woohyun, bowonryu.
Sun, Apr 7, 6:24 AM · efl
ali.alzyod updated the summary of D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.
Sun, Apr 7, 6:23 AM · efl
ali.alzyod updated the diff for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.

update

Sun, Apr 7, 6:17 AM · efl
ali.alzyod updated the summary of D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.
Sun, Apr 7, 6:13 AM · efl
ali.alzyod updated the test plan for D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.
Sun, Apr 7, 6:06 AM · efl
ali.alzyod requested review of D8572: Speed up setting text (check if same text is already set), fix setting same text pointer.
Sun, Apr 7, 5:59 AM · efl

Sat, Mar 30

ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.

@vtorri I will check if it will effect performance.

Sat, Mar 30, 5:14 AM · efl

Fri, Mar 29

ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.

Hi, i can see that this giantly impoves the time spent in this function. So this is fine from my side. However, lease note that if you want to fix performance problems in EFL that such tiny functions will not matter that much in total. As @zmike pointed out, there is a other function which is a bit more wastefull in this regard.

Further more, running entry examples with perf for roughly a second does not even bring this function up for me. So yes this is a performance improvement of this function, but no, it will not matter much for the overall performance of EFL. I don't know if the overall performance of EFL was your goal.

Fri, Mar 29, 5:05 AM · efl

Thu, Mar 28

ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.
In D8497#153974, @zmike wrote:

Your test case should probably use a string that has some real <br> and <ps/> tags?

Thu, Mar 28, 9:41 AM · efl
ali.alzyod updated the test plan for D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 9:40 AM · efl
ali.alzyod added inline comments to D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 7:47 AM · efl
ali.alzyod added reviewers for D8497: Speedup finding new line, prevent readind invalid memory: woohyun, bowonryu.
Thu, Mar 28, 7:46 AM · efl
ali.alzyod updated the test plan for D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 7:46 AM · efl
ali.alzyod updated the diff for D8497: Speedup finding new line, prevent readind invalid memory.

update code to use strchr

Thu, Mar 28, 7:44 AM · efl
ali.alzyod updated the test plan for D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 7:21 AM · efl
ali.alzyod updated the test plan for D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 7:19 AM · efl
ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.

Also, any performance-improving patch should be accompanied of numbers (and how to obtain them). Otherwise, how do you know if you're actually speeding up anything?

Thu, Mar 28, 6:59 AM · efl
ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.
In D8497#153941, @zmike wrote:

Seems like this could be simplified a bit? And if you're looking to optimize this kind of thing then probably you'd also want to improve performance of _entry_remove_new_line since this function does a full copy of the string and then 4 full iterations over it?

Thu, Mar 28, 6:56 AM · efl
ali.alzyod updated the summary of D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 5:58 AM · efl
ali.alzyod added a comment to D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 5:57 AM · efl
ali.alzyod requested review of D8497: Speedup finding new line, prevent readind invalid memory.
Thu, Mar 28, 5:45 AM · efl

Wed, Mar 20

ali.alzyod added a comment to D8387: efl_access_text_selections_count_get implementation for Entry.

this function return count of selection regions, not the length of selected string

Wed, Mar 20, 2:19 AM · efl
ali.alzyod abandoned D8387: efl_access_text_selections_count_get implementation for Entry.
Wed, Mar 20, 2:19 AM · efl

Mar 18 2019

ali.alzyod updated the diff for D8387: efl_access_text_selections_count_get implementation for Entry.
Mar 18 2019, 10:11 AM · efl
ali.alzyod added reviewers for D8387: efl_access_text_selections_count_get implementation for Entry: woohyun, bowonryu, ManMower, cedric, raster, segfaultxavi.
Mar 18 2019, 10:04 AM · efl
ali.alzyod requested review of D8387: efl_access_text_selections_count_get implementation for Entry.
Mar 18 2019, 9:56 AM · efl
ali.alzyod updated the diff for D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.

undo some old commits

Mar 18 2019, 9:52 AM · efl
ali.alzyod added a reviewer for D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string: segfaultxavi.
Mar 18 2019, 9:41 AM · efl
ali.alzyod added a comment to D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mar 18 2019, 9:37 AM · efl
ali.alzyod updated the diff for D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mar 18 2019, 7:02 AM · efl
ali.alzyod updated the diff for D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mar 18 2019, 6:51 AM · efl

Mar 12 2019

ali.alzyod updated the summary of D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mar 12 2019, 10:07 AM · efl
ali.alzyod added a comment to D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.

Before Fix

Mar 12 2019, 10:01 AM · efl
ali.alzyod added reviewers for D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string: woohyun, bowonryu, ManMower, cedric, raster.
Mar 12 2019, 10:00 AM · efl
ali.alzyod requested review of D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.
Mar 12 2019, 9:55 AM · efl

Dec 24 2018

ali.alzyod added a comment to D7461: optimize glyph images data copy into 4 byte aligned images.

I set font size just to show the effect without writing a lot of text (instead of many glyphes we have huge one ),
and effect of copy will increase when image size increase.

Dec 24 2018, 12:44 AM · efl

Dec 20 2018

ali.alzyod added a comment to D7461: optimize glyph images data copy into 4 byte aligned images.

On my Machine i7-2600 Ubuntu 16.04 LTS

Dec 20 2018, 5:19 AM · efl

Dec 17 2018

ali.alzyod retitled D7461: optimize glyph images data copy into 4 byte aligned images from optimize image data copy 1-copy all data at once if possible 2-copy image data row by row to optimize glyph images data copy into 4 byte aligned images.
Dec 17 2018, 4:58 AM · efl
ali.alzyod added reviewers for D7461: optimize glyph images data copy into 4 byte aligned images: woohyun, bowonryu.
Dec 17 2018, 4:19 AM · efl
ali.alzyod added a comment to D7461: optimize glyph images data copy into 4 byte aligned images.

This will have small increase effect in performance (still may be it is good to have )

Dec 17 2018, 3:54 AM · efl
ali.alzyod removed a reviewer for D7461: optimize glyph images data copy into 4 byte aligned images: woonggishin.
Dec 17 2018, 1:26 AM · efl