- User Since
- Nov 27 2018, 12:22 AM (83 w, 6 d)
Mon, Jun 22
@bowonryu I think safest way is to search for the last
"font=" and "font_size="
Then replace the string in front of it (until you reach white space), with new value.
Wed, Jun 17
Can you take a look at D11990 ? I think it is good Idea to have this new function.
@raster multiplication is normally faster than division, So this should enhance the speed
Tue, Jun 16
I think this makes sense in term of division vs multiplication
exclude sin/cos changes
Mon, Jun 15
add FIXME comment
Thu, Jun 11
default behaviour is unlimited texture size
free cache on evas_font_texture_cache_set call (if needed), and change unlimited cache to be negative value instead of 0
change long to int for public APIs
this seems fine to me, as long it pass test for others (I think it will pass since it is not dependent on emoji font anymore)
This seems fine to me
Wed, Jun 10
I think changing this line to replace last occurrence instead of first will resolve the issue
Does this mean passing struct of rect instead of 4 int values ?
What if the font style contains more than one font or font_size with same value ?
I know it seems strange but it is valid (could be done with pushed user styles or user made more than one tag).
Tue, Jun 9
First : this is very small impact.
Second : you are talking only about specific compiler(s) , or maybe most of them, but this is not general thing everywhere.
@raster lets look at the following code:
#include<math.h> #include<time.h> #include<stdio.h> #include<stdlib.h>
If we are talking about GCC and its optimization, then the whole thing does not give much enhancement.
@bu5hm4n I am not sure I fully understand your comment, I use M_SQRT1_2 as its faster and readable (IMO).
use sincos instead of two calls for sin and cos
Mon, Jun 8
change 1/M_PI_2 to M_2_PI
@zmike can you please confirm if latest update fix the test failing
Can we close this patch please, (unless there are some comments)
I think we should change the part that set visually_deleted to FALSE will remove from line items
This is an issue, D11945 should fix it, and release leaked data
I think this is leak in the demo it self, where it does not free style that was created.