Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (60 w, 3 d)
Availability
Available

Recent Activity

Yesterday

ali.alzyod added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

I see and agree with it,
We do not purposely want to support legacy string strings, but it is just a side effect when update shared code between legacy and unified (it is not a bad side effect).
I am afraid this will complex the code a bit especially in future if we want to maintain two parts for parsing styles or adding new tags. right now this is just rename for the same tags nothing is new,
Are you still feel it is important to separate the tags names for legacy and unified, which effect code simplicity and backward compatibility?

Thu, Jan 23, 12:47 PM · efl
ali.alzyod added a comment to T8570: Eina_Range.

Lots of EFL classes do not have an "owner" (because the original writer left, for example). Who would check those?

I think if any beta class is going to stabilize, we can recommend using this new structure. for released classes it is too late unless we want do not care about compatibility support.

Thu, Jan 23, 8:21 AM · efl: language bindings, efl: api
ali.alzyod added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

Legacy style tags must be used only with legacy objects, and unified tags must be used only with unified objects.

I think this is a matter of updating legacy documentation to support new tag names.
but I do not see why the must is used in here, what if unified already understand legacy deprecated tags, what is the problem with that?

Thu, Jan 23, 8:19 AM · efl
ali.alzyod added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

To clear things up, this patch talks about: how we parse style string only

Thu, Jan 23, 7:25 AM · efl
ali.alzyod added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

My opinion this approach is fine since it already:
Keep legacy work as expected.
New api work as expected + support old deprecated legacy attributes

Thu, Jan 23, 6:55 AM · efl
ali.alzyod added a comment to D11136: efl.canvas.textblock: annotate obstacle methods as beta.

@woohyun @segfaultxavi
Can you close this one?

Thu, Jan 23, 3:15 AM · efl
ali.alzyod added a comment to T8570: Eina_Range.

I thought everyone likes the Idea for using more generic type for range. even If one type using it, the other option is that this type will have its own unique type (which is against the first assumption for using generic type).

Thu, Jan 23, 3:14 AM · efl: language bindings, efl: api
ali.alzyod closed D11153: efl.ui.textbox: move file implementation in to internal class.
Thu, Jan 23, 1:04 AM · efl
ali.alzyod updated the diff for D11153: efl.ui.textbox: move file implementation in to internal class.

rebase

Thu, Jan 23, 12:54 AM · efl
ali.alzyod closed D10968: efl_text_interactive: selection enhancment.
Thu, Jan 23, 12:05 AM · efl

Wed, Jan 22

ali.alzyod closed T8542: evas_object_textblock variation sequence issues as Resolved.
Wed, Jan 22, 11:34 PM
ali.alzyod added a comment to T8570: Eina_Range.

Can we move this into stabilization ? I think everybody already likes the idea

Wed, Jan 22, 11:22 PM · efl: language bindings, efl: api
ali.alzyod updated the diff for D11128: efl.text.interactive: use Eina_Int_Range for selection range event.

update

Wed, Jan 22, 11:00 PM · efl
ali.alzyod updated the diff for D11128: efl.text.interactive: use Eina_Int_Range for selection range event.

update

Wed, Jan 22, 8:49 PM · efl
ali.alzyod updated the summary of D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Wed, Jan 22, 8:43 PM · efl
ali.alzyod removed a parent revision for D11128: efl.text.interactive: use Eina_Int_Range for selection range event: D11133: eina: add new range Data type.
Wed, Jan 22, 8:43 PM · efl
ali.alzyod removed a child revision for D11133: eina: add new range Data type: D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Wed, Jan 22, 8:43 PM · efl
ali.alzyod added a parent revision for D11128: efl.text.interactive: use Eina_Int_Range for selection range event: D11133: eina: add new range Data type.
Wed, Jan 22, 6:33 AM · efl
ali.alzyod added a child revision for D11133: eina: add new range Data type: D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Wed, Jan 22, 6:33 AM · efl
ali.alzyod updated the summary of D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Wed, Jan 22, 6:32 AM · efl
ali.alzyod updated the diff for D11128: efl.text.interactive: use Eina_Int_Range for selection range event.

update

Wed, Jan 22, 6:32 AM · efl
ali.alzyod updated the diff for D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
  • update
Wed, Jan 22, 6:31 AM · efl
ali.alzyod added reviewers for D11153: efl.ui.textbox: move file implementation in to internal class: woohyun, bu5hm4n.
Wed, Jan 22, 1:46 AM · efl
ali.alzyod updated the summary of D11153: efl.ui.textbox: move file implementation in to internal class.
Wed, Jan 22, 1:46 AM · efl
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

@bu5hm4n @segfaultxavi done at D11153

Wed, Jan 22, 1:43 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a task to D11153: efl.ui.textbox: move file implementation in to internal class: T8522: Efl.Ui.Textbox class.
Wed, Jan 22, 1:43 AM · efl
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11153: efl.ui.textbox: move file implementation in to internal class.
Wed, Jan 22, 1:43 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod updated the diff for D11153: efl.ui.textbox: move file implementation in to internal class.

update

Wed, Jan 22, 1:43 AM · efl
ali.alzyod requested review of D11153: efl.ui.textbox: move file implementation in to internal class.
Wed, Jan 22, 1:42 AM · efl

Tue, Jan 21

ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

init watch sel value

Tue, Jan 21, 11:34 PM · efl
ali.alzyod added a comment to D11133: eina: add new range Data type.

@cedric any more requests ?

Tue, Jan 21, 12:40 PM · efl
ali.alzyod updated subscribers of D10968: efl_text_interactive: selection enhancment.

@bu5hm4n @segfaultxavi @stefan_schmidt
If anyone one of you can run on this test on this patch with many many thanks :)

Tue, Jan 21, 9:27 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

remove empty lines

Tue, Jan 21, 9:26 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

clean up + update

Tue, Jan 21, 9:24 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

update

Tue, Jan 21, 8:43 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

update selection

Tue, Jan 21, 8:40 AM · efl

Mon, Jan 20

ali.alzyod updated the diff for D11133: eina: add new range Data type.
  • fic typo
Mon, Jan 20, 6:29 PM · efl
ali.alzyod added a comment to D11133: eina: add new range Data type.

done

Mon, Jan 20, 2:10 PM · efl
ali.alzyod updated the diff for D11133: eina: add new range Data type.
  • update
Mon, Jan 20, 2:10 PM · efl
ali.alzyod updated the diff for D11133: eina: add new range Data type.
  • use inline functions
Mon, Jan 20, 12:57 PM · efl
ali.alzyod added a comment to D11133: eina: add new range Data type.

The compiler can only inline function in files it sees directly when compiling a unit. That is why wine has so many eina_inline*.x files.

Mon, Jan 20, 10:13 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

remove all freeze events

Mon, Jan 20, 10:12 AM · efl
ali.alzyod added a comment to D11133: eina: add new range Data type.

Maybe we might want all this function to be inline, other than that it looks good to me.

Mon, Jan 20, 9:14 AM · efl
ali.alzyod added reviewers for D11136: efl.canvas.textblock: annotate obstacle methods as beta: woohyun, segfaultxavi.
Mon, Jan 20, 4:51 AM · efl
ali.alzyod added a task to D11136: efl.canvas.textblock: annotate obstacle methods as beta: T8460: Efl_Canvas_Textblock.
Mon, Jan 20, 4:48 AM · efl
ali.alzyod added a revision to T8460: Efl_Canvas_Textblock: D11136: efl.canvas.textblock: annotate obstacle methods as beta.
Mon, Jan 20, 4:48 AM · efl (efl-1.24), efl: api
ali.alzyod requested review of D11136: efl.canvas.textblock: annotate obstacle methods as beta.
Mon, Jan 20, 4:48 AM · efl
ali.alzyod updated the diff for D11133: eina: add new range Data type.

rename eina_range_max_get into eina_range_end

Mon, Jan 20, 4:16 AM · efl
ali.alzyod renamed T8570: Eina_Range from Efl.Text_Range to Eina_Range.
Mon, Jan 20, 3:45 AM · efl: language bindings, efl: api
ali.alzyod updated the diff for D11130: efl.input.text.hints_type: rename into content_type.
  • update
Mon, Jan 20, 3:42 AM · efl
ali.alzyod updated the diff for D11133: eina: add new range Data type.

update document

Mon, Jan 20, 1:59 AM · efl
ali.alzyod updated the summary of D11133: eina: add new range Data type.
Mon, Jan 20, 1:53 AM · efl
ali.alzyod requested review of D11133: eina: add new range Data type.
Mon, Jan 20, 1:51 AM · efl
ali.alzyod added a revision to T8570: Eina_Range: D11133: eina: add new range Data type.
Mon, Jan 20, 1:51 AM · efl: language bindings, efl: api

Sun, Jan 19

ali.alzyod added a comment to T8570: Eina_Range.

I think we should call this new type Efl.Range which is the default range (and I agree with what @cedric says, there should not be more ranges other than this one)

Sun, Jan 19, 11:41 PM · efl: language bindings, efl: api
ali.alzyod updated the diff for D11127: efl.ui.textbox: using efl_provider_find.
  • update to remove if(top) check
Sun, Jan 19, 11:25 PM · efl
ali.alzyod updated the task description for T8541: Efl.Input.Text.
Sun, Jan 19, 8:52 PM · efl: language bindings, efl: api
ali.alzyod added a comment to T8541: Efl.Input.Text.

It feels weird tu remove functionality that was in legacy. I would keep input_hint as Beta and rename it to input_content_type, but not remove it.

D11130

Sun, Jan 19, 8:51 PM · efl: language bindings, efl: api
ali.alzyod added a task to D11130: efl.input.text.hints_type: rename into content_type: T8541: Efl.Input.Text.
Sun, Jan 19, 8:51 PM · efl
ali.alzyod added a revision to T8541: Efl.Input.Text: D11130: efl.input.text.hints_type: rename into content_type.
Sun, Jan 19, 8:51 PM · efl: language bindings, efl: api
ali.alzyod added reviewers for D11130: efl.input.text.hints_type: rename into content_type: woohyun, segfaultxavi.
Sun, Jan 19, 8:50 PM · efl
ali.alzyod requested review of D11130: efl.input.text.hints_type: rename into content_type.
Sun, Jan 19, 8:50 PM · efl
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

Is it possible to annotate interface implemnetaiton as @beta ? (this is for file interface)

Sun, Jan 19, 8:43 PM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

rebase

Sun, Jan 19, 8:19 PM · efl
ali.alzyod added a project to T8580: Efl.Text.Interactive: add support for Undo/Redo Methods: efl: api.
Sun, Jan 19, 8:40 AM · efl: api, efl: language bindings
ali.alzyod triaged T8580: Efl.Text.Interactive: add support for Undo/Redo Methods as TODO priority.
Sun, Jan 19, 8:38 AM · efl: api, efl: language bindings
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

add more test cases

Sun, Jan 19, 8:25 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

update have_selection changed when reduce selection area

Sun, Jan 19, 8:01 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

rebase

Sun, Jan 19, 6:59 AM · efl
ali.alzyod updated the diff for D10968: efl_text_interactive: selection enhancment.

rebase

Sun, Jan 19, 6:54 AM · efl
ali.alzyod added reviewers for D11128: efl.text.interactive: use Eina_Int_Range for selection range event: cedric, woohyun, bu5hm4n, segfaultxavi, zmike.
Sun, Jan 19, 5:55 AM · efl
ali.alzyod added a comment to T8570: Eina_Range.

add Eina_Int_Range

Sun, Jan 19, 5:54 AM · efl: language bindings, efl: api
ali.alzyod added a task to D11128: efl.text.interactive: use Eina_Int_Range for selection range event: T8570: Eina_Range.
Sun, Jan 19, 5:54 AM · efl
ali.alzyod added a revision to T8570: Eina_Range: D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Sun, Jan 19, 5:54 AM · efl: language bindings, efl: api
ali.alzyod updated the summary of D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Sun, Jan 19, 5:54 AM · efl
ali.alzyod requested review of D11128: efl.text.interactive: use Eina_Int_Range for selection range event.
Sun, Jan 19, 5:52 AM · efl
ali.alzyod reassigned T8577: Rich Text Editor Example from ali.alzyod to AbdullehGhujeh.
Sun, Jan 19, 4:09 AM

Fri, Jan 17

ali.alzyod updated the task description for T8577: Rich Text Editor Example.
Fri, Jan 17, 10:58 AM
ali.alzyod updated the task description for T8577: Rich Text Editor Example.
Fri, Jan 17, 10:14 AM
ali.alzyod added a comment to T8455: Efl.Text.Formatter.

@segfaultxavi I suggest we create TASK for future work related to this class, It will need more APIs and design

Fri, Jan 17, 10:09 AM · efl (efl-1.24), efl: api
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D10968: efl_text_interactive: selection enhancment.
Fri, Jan 17, 10:06 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a task to D10968: efl_text_interactive: selection enhancment: T8522: Efl.Ui.Textbox class.
Fri, Jan 17, 10:06 AM · efl
ali.alzyod added reviewers for D11127: efl.ui.textbox: using efl_provider_find: woohyun, bu5hm4n.
Fri, Jan 17, 10:06 AM · efl
ali.alzyod added a revision to T8522: Efl.Ui.Textbox class: D11127: efl.ui.textbox: using efl_provider_find.
Fri, Jan 17, 10:05 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a task to D11127: efl.ui.textbox: using efl_provider_find: T8522: Efl.Ui.Textbox class.
Fri, Jan 17, 10:05 AM · efl
ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

I am okay with the API side, only one thing impacts the API right now:

  • _efl_ui_textbox_efl_layout_signal_signal_callback_add still has a problem, the object of the function callback will be wrong

what do you suggest? I look at other parts of the toolkit, and they use it the same way as in efl.ui.textbox (like efl_ui_image_zoomable and efl_ui_layout_base)

Fri, Jan 17, 10:05 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod requested review of D11127: efl.ui.textbox: using efl_provider_find.
Fri, Jan 17, 10:04 AM · efl
ali.alzyod closed D11117: efl: correct class description name of simple class.
Fri, Jan 17, 5:04 AM · efl
ali.alzyod added a comment to D11095: efl.text.cursor: movement types rename.

@ali.alzyod Please check my inline comment :)

Fri, Jan 17, 1:36 AM · efl
ali.alzyod updated the diff for D11095: efl.text.cursor: movement types rename.

update

Fri, Jan 17, 1:36 AM · efl
ali.alzyod added a reviewer for D11117: efl: correct class description name of simple class: bu5hm4n.
Fri, Jan 17, 12:22 AM · efl
ali.alzyod added reviewers for D11117: efl: correct class description name of simple class: woohyun, YOhoho.
Fri, Jan 17, 12:21 AM · efl
ali.alzyod requested review of D11117: efl: correct class description name of simple class.
Fri, Jan 17, 12:20 AM · efl
ali.alzyod added a comment to D11115: efl_text_cursor: correct class description name of simple class.

@YOhoho Thank you very much :)

@ali.alzyod
Could you remember this thing while doing text interface work ? :)
Thanks in advance.

Fri, Jan 17, 12:16 AM · efl
ali.alzyod updated the diff for D11095: efl.text.cursor: movement types rename.
  • update
Fri, Jan 17, 12:13 AM · efl
ali.alzyod updated the diff for D11095: efl.text.cursor: movement types rename.

rebase

Fri, Jan 17, 12:11 AM · efl

Thu, Jan 16

ali.alzyod added a comment to T8522: Efl.Ui.Textbox class.

This should be ready for stabilization , any more comments?

Thu, Jan 16, 8:26 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod closed D11109: efl.ui.textbox: update _part_is_efl_ui_textbox_part.
Thu, Jan 16, 7:37 AM · efl
ali.alzyod closed D11103: efl.ui.textbox: theme code cleanup.
Thu, Jan 16, 7:37 AM · efl
ali.alzyod updated the diff for D11103: efl.ui.textbox: theme code cleanup.

move create_text_cursors and content_set into efl_ui_widget_theme_apply

Thu, Jan 16, 3:56 AM · efl