Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (30 w, 2 h)
Availability
Available

Recent Activity

Today

ali.alzyod reclaimed D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 3:35 AM · efl
ali.alzyod changed the visibility for D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 3:34 AM · efl
ali.alzyod changed the visibility for D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 3:31 AM · efl
ali.alzyod abandoned D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 3:10 AM · efl
ali.alzyod requested review of D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 1:29 AM · efl
ali.alzyod added a comment to D9155: evas_common: use memcpy to copy pixel buffer.

@Hermet Please run test code, you can see will notice the speedup.

Tue, Jun 25, 1:29 AM · efl
ali.alzyod updated the test plan for D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 1:26 AM · efl
ali.alzyod updated the test plan for D9155: evas_common: use memcpy to copy pixel buffer.
Tue, Jun 25, 12:56 AM · efl

Yesterday

ali.alzyod added a comment to D9153: evas_common_format_color_parse: support color names.

@segfaultxavi @vtorri Do you have any issues left ?

Mon, Jun 24, 11:47 PM · efl
ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.
  • use c standard functions
Mon, Jun 24, 11:42 PM · efl

Sun, Jun 23

ali.alzyod updated the summary of D9158: evas_textblock: change font size only using EFL.Text.Font Interface.
Sun, Jun 23, 7:20 AM · efl
ali.alzyod added reviewers for D9158: evas_textblock: change font size only using EFL.Text.Font Interface: woohyun, bowonryu, segfaultxavi, bu5hm4n, zmike.
Sun, Jun 23, 6:58 AM · efl
ali.alzyod updated the summary of D9158: evas_textblock: change font size only using EFL.Text.Font Interface.
Sun, Jun 23, 6:57 AM · efl
ali.alzyod requested review of D9158: evas_textblock: change font size only using EFL.Text.Font Interface.
Sun, Jun 23, 6:55 AM · efl

Sat, Jun 22

ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.

remove tolower

Sat, Jun 22, 11:52 AM · efl
ali.alzyod added inline comments to D9153: evas_common_format_color_parse: support color names.
Sat, Jun 22, 11:46 AM · efl
ali.alzyod added inline comments to D9153: evas_common_format_color_parse: support color names.
Sat, Jun 22, 11:22 AM · efl
ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.

add search array function to header

Sat, Jun 22, 11:05 AM · efl
ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.

add comment for search function

Sat, Jun 22, 10:50 AM · efl
ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.

use common function for search array

Sat, Jun 22, 10:45 AM · efl
ali.alzyod added a comment to D9153: evas_common_format_color_parse: support color names.

@segfaultxavi thanks a lot for the information, The Idea of this patch is adding important feature to EFL color style using color name

Sat, Jun 22, 5:56 AM · efl
ali.alzyod added a comment to D9155: evas_common: use memcpy to copy pixel buffer.

what about making this function inline ?

Sat, Jun 22, 4:43 AM · efl
ali.alzyod added a comment to D9140: Eina: more macros and Types.

should EAPI_INTERNAL EAPI really be part of the API ?

Sat, Jun 22, 4:40 AM · efl
ali.alzyod updated the task description for T8030: evas_common copy reverse pixel buffer.
Sat, Jun 22, 1:37 AM
ali.alzyod created T8030: evas_common copy reverse pixel buffer.
Sat, Jun 22, 1:35 AM
ali.alzyod added reviewers for D9155: evas_common: use memcpy to copy pixel buffer: raster, ManMower, woohyun.
Sat, Jun 22, 1:19 AM · efl
ali.alzyod requested review of D9155: evas_common: use memcpy to copy pixel buffer.
Sat, Jun 22, 1:18 AM · efl
ali.alzyod updated the diff for D9153: evas_common_format_color_parse: support color names.

update some data types

Sat, Jun 22, 12:05 AM · efl

Fri, Jun 21

ali.alzyod added inline comments to D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 11:40 PM · efl
ali.alzyod added a reviewer for D9140: Eina: more macros and Types: vtorri.
Fri, Jun 21, 11:34 PM · efl
ali.alzyod added inline comments to D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 11:32 PM · efl
ali.alzyod updated the summary of D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 5:57 PM · efl
ali.alzyod updated the summary of D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 5:56 PM · efl
ali.alzyod added reviewers for D9153: evas_common_format_color_parse: support color names: woohyun, bowonryu, segfaultxavi.
Fri, Jun 21, 5:55 PM · efl
ali.alzyod updated the test plan for D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 5:53 PM · efl
ali.alzyod requested review of D9153: evas_common_format_color_parse: support color names.
Fri, Jun 21, 5:48 PM · efl

Thu, Jun 20

ali.alzyod updated the summary of D9140: Eina: more macros and Types.
Thu, Jun 20, 5:26 AM · efl
ali.alzyod retitled D9140: Eina: more macros and Types from Eina: more macros to Eina: more macros and Types.
Thu, Jun 20, 5:25 AM · efl
ali.alzyod added reviewers for D9140: Eina: more macros and Types: zmike, bu5hm4n.
Thu, Jun 20, 5:24 AM · efl
ali.alzyod added a comment to D9140: Eina: more macros and Types.

I am updating part of text-block and instead of define byte internally we can use it from Eina.

Thu, Jun 20, 5:22 AM · efl
ali.alzyod added reviewers for D9140: Eina: more macros and Types: segfaultxavi, woohyun.
Thu, Jun 20, 5:20 AM · efl
ali.alzyod requested review of D9140: Eina: more macros and Types.
Thu, Jun 20, 5:19 AM · efl
ali.alzyod added reviewers for D9131: evas_textblock: more descriptive parameter names: segfaultxavi, woohyun, bowonryu.
Thu, Jun 20, 4:52 AM · efl
ali.alzyod requested review of D9131: evas_textblock: more descriptive parameter names.
Thu, Jun 20, 4:49 AM · efl

Tue, Jun 18

ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

-because variation sequences can vary from ( 0xFE00-0xFE0F , 0xE0100-0xE01EF, 0x180B-0x180D), So I think create hashing tables for these values for each character (or characters that could have variation sequences) will consume more memory, and logic will become more complicated where one Unicode value could have many variation sequences.

-So I thought of binary search as good solution where we will keep old logic as it is, and if character has variation sequence it will be added to variation sequence sorted list, and accessing will be fast specially list will be small for each unicode value.

Making myself clear,
Memory will not be issue here, only issue I can see is that single Unicode can have multiple variation sequence. So if same unicode with different variation sequence belonging to different font file will fetch you the incorrect font in some cases, if current logic is used.
Am I correct?
If so, then it looks good to me.

Tue, Jun 18, 5:48 AM · efl
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

Tue, Jun 18, 5:23 AM · efl

Mon, Jun 17

ali.alzyod added a reviewer for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: bowonryu.
Mon, Jun 17, 9:36 PM · efl

Thu, Jun 13

ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.

fix binary insertion

Thu, Jun 13, 12:44 AM · efl

Wed, Jun 12

ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.

evas_textblock: add support for caching variation sequence

Wed, Jun 12, 6:59 AM · efl

Tue, Jun 4

ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

@zmike please try now

Tue, Jun 4, 7:32 AM · efl
ali.alzyod reclaimed D9064: evas_textblock: <ps> tag respects multiline propertie.
Tue, Jun 4, 7:31 AM · efl
ali.alzyod changed the visibility for D9064: evas_textblock: <ps> tag respects multiline propertie.
Tue, Jun 4, 7:31 AM · efl

Sun, Jun 2

ali.alzyod abandoned D9064: evas_textblock: <ps> tag respects multiline propertie.
Sun, Jun 2, 9:25 PM · efl
ali.alzyod changed the visibility for D9064: evas_textblock: <ps> tag respects multiline propertie.
Sun, Jun 2, 9:23 PM · efl
ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.
  • Add function comment decleration,Fix caching Issue, Fix searching fonts issue
Sun, Jun 2, 5:31 AM · efl

Sat, Jun 1

ali.alzyod added a comment to T7849: efl.ui.text.

@bu5hm4n Thank you for your fast feedback
These are my comments on some points

Sat, Jun 1, 8:16 AM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T7849: efl.ui.text.

I am thinking of making all text interface APIs return error codes, where it make life of efl developers more easy, to know exactly what is happening if function success or failed.

Sat, Jun 1, 3:06 AM · efl: api, efl (efl-1.23), efl: language bindings

Fri, May 31

ali.alzyod updated the summary of D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 6:38 PM · efl
ali.alzyod updated the summary of D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 6:37 PM · efl
ali.alzyod updated the summary of D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 6:36 PM · efl
ali.alzyod updated the diff for D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 4:34 PM · efl
ali.alzyod updated the summary of D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 4:33 PM · efl
ali.alzyod added reviewers for D9064: evas_textblock: <ps> tag respects multiline propertie: woohyun, bowonryu.
Fri, May 31, 4:32 PM · efl
ali.alzyod updated the test plan for D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 4:31 PM · efl
ali.alzyod requested review of D9064: evas_textblock: <ps> tag respects multiline propertie.
Fri, May 31, 4:25 PM · efl
ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.

update test suite with variation sequences

Fri, May 31, 6:21 AM · efl

Thu, May 30

ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.
  • fix compilation error if harfbuzz was not enabled
Thu, May 30, 6:53 PM · efl
ali.alzyod requested review of D9053: evas_object_textblock: add support for variation sequences.
Thu, May 30, 2:36 AM · efl
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

You are right, it is confusing to use same signature,
Internal API should have there own signatures to avoid confusing

Thu, May 30, 1:54 AM · efl
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

@segfaultxavi are not these internal APIs ?

Thu, May 30, 1:43 AM · efl
ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.

fix spaces

Thu, May 30, 12:58 AM · efl

Wed, May 29

ali.alzyod added a reviewer for D9053: evas_object_textblock: add support for variation sequences: bowonryu.
Wed, May 29, 11:57 PM · efl
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

This Compare Old Vs New Vs Android

Wed, May 29, 11:57 PM · efl
ali.alzyod updated the test plan for D9053: evas_object_textblock: add support for variation sequences.
Wed, May 29, 11:55 PM · efl
ali.alzyod requested review of D9053: evas_object_textblock: add support for variation sequences.
Wed, May 29, 11:42 PM · efl

May 14 2019

ali.alzyod updated the test plan for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
May 14 2019, 11:09 PM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

@bu5hm4n
update test cases, and Fix searching UTF8 instead on unicode

May 14 2019, 11:04 PM · efl

May 9 2019

ali.alzyod added a comment to T7849: efl.ui.text.

I always prefer general functions with Enums/flags for specific option
1- understanding SDK much simpler (specially from documentation)
2- adding features will never break comparability in future

May 9 2019, 5:41 AM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T7849: efl.ui.text.

I still think this property should be removed from Efl.Ui.Text, which should then only override the one in Efl.Text. Do you agree?
Yes I agree

May 9 2019, 4:01 AM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T7849: efl.ui.text.

@segfaultxavi I think Efl.Ui.Text.password_mode should be removed

May 9 2019, 12:21 AM · efl: api, efl (efl-1.23), efl: language bindings

May 8 2019

ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@segfaultxavi sorry I was away from computer, I think you already added the comment.
Thank you

May 8 2019, 6:16 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@bu5hm4n sure, should I add it directly there or inside sub task

May 8 2019, 4:00 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@woohyun @segfaultxavi
This is not related directly to this patch, but you can detect the issue here.

May 8 2019, 3:35 AM · efl
ali.alzyod accepted D8856: efl_ui_text: make password mode work properly.
May 8 2019, 2:50 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

patch seems fine to me

May 8 2019, 2:32 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.
May 8 2019, 2:20 AM · efl
ali.alzyod added inline comments to D8856: efl_ui_text: make password mode work properly.
May 8 2019, 1:04 AM · efl
ali.alzyod added inline comments to D8856: efl_ui_text: make password mode work properly.
May 8 2019, 12:23 AM · efl

May 7 2019

ali.alzyod added a reviewer for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: bu5hm4n.
May 7 2019, 3:54 AM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

update

May 7 2019, 3:52 AM · efl
ali.alzyod added reviewers for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: lauromoura, CHAN, woohyun.
May 7 2019, 3:50 AM · efl
ali.alzyod requested review of D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
May 7 2019, 3:47 AM · efl
ali.alzyod added inline comments to D8803: evas_object_textblock: Fix binary search fail..
May 7 2019, 1:55 AM · efl

May 6 2019

This is a test notification, sent at Tue, May 7, 9:30 AM.
May 6 2019, 11:30 PM
ali.alzyod added a comment to D8833: efl_ui_text: clear selection after cut.

@segfaultxavi
with keyboard there are additional processing for keydown (_key_down_cb), and maybe it some point it handle updating selection

May 6 2019, 10:09 PM · efl
ali.alzyod closed D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.
May 6 2019, 8:08 AM · efl

May 5 2019

ali.alzyod added reviewers for D8833: efl_ui_text: clear selection after cut: woohyun, bowonryu.
May 5 2019, 11:33 PM · efl
ali.alzyod added a comment to D8833: efl_ui_text: clear selection after cut.

Before

May 5 2019, 11:32 PM · efl
ali.alzyod updated the test plan for D8833: efl_ui_text: clear selection after cut.
May 5 2019, 11:31 PM · efl
ali.alzyod requested review of D8833: efl_ui_text: clear selection after cut.
May 5 2019, 11:31 PM · efl