Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (83 w, 6 d)
Availability
Available

Recent Activity

Today

ali.alzyod updated the diff for D11861: evas_text: lazy loading color glyph images in RAM.

rearrange code

Mon, Jul 6, 1:35 AM · efl
ali.alzyod updated the diff for D11861: evas_text: lazy loading color glyph images in RAM.

rebase

Mon, Jul 6, 1:19 AM · efl

Mon, Jun 22

ali.alzyod added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

@bowonryu I think safest way is to search for the last
"font=" and "font_size="
Then replace the string in front of it (until you reach white space), with new value.

Mon, Jun 22, 11:43 PM · efl
ali.alzyod closed T8757: Eina_Strbuf: issues / features as Resolved.
Mon, Jun 22, 1:54 AM · efl
ali.alzyod updated the diff for D11990: eina_strbuf: introduce change last occurrence function.

rebase

Mon, Jun 22, 1:31 AM · efl
ali.alzyod updated the diff for D11990: eina_strbuf: introduce change last occurrence function.

rebase

Mon, Jun 22, 1:18 AM · efl

Wed, Jun 17

ali.alzyod added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

Can you take a look at D11990 ? I think it is good Idea to have this new function.

Wed, Jun 17, 8:38 AM · efl
ali.alzyod added reviewers for D11990: eina_strbuf: introduce change last occurrence function: woohyun, bowonryu.
Wed, Jun 17, 8:35 AM · efl
ali.alzyod retitled D11948: efl: reduce sqrt(2) calculations (division vs multiplication) from efl: reduce sqrt(2) calculations to efl: reduce sqrt(2) calculations (division vs multiplication).
Wed, Jun 17, 7:20 AM · efl
ali.alzyod added reviewers for D11948: efl: reduce sqrt(2) calculations (division vs multiplication): woohyun, Hermet.
Wed, Jun 17, 7:19 AM · efl
ali.alzyod added reviewers for D11949: efl_ui_textpath: mathmatical calculations: woohyun, Hermet.
Wed, Jun 17, 7:19 AM · efl
ali.alzyod requested review of D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

@raster multiplication is normally faster than division, So this should enhance the speed

Wed, Jun 17, 7:18 AM · efl
ali.alzyod updated subscribers of T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 7:07 AM · efl
ali.alzyod added a revision to T8757: Eina_Strbuf: issues / features: D11992: eina_strbuf: if readonly strbuf is malloc, then it will stop being readonly.
Wed, Jun 17, 7:07 AM · efl
ali.alzyod added a task to D11992: eina_strbuf: if readonly strbuf is malloc, then it will stop being readonly: T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 7:07 AM · efl
ali.alzyod requested review of D11992: eina_strbuf: if readonly strbuf is malloc, then it will stop being readonly.
Wed, Jun 17, 7:06 AM · efl
ali.alzyod added a task to D11991: eina_strbuf_manage_new: update documentation: T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 7:03 AM · efl
ali.alzyod added a revision to T8757: Eina_Strbuf: issues / features: D11991: eina_strbuf_manage_new: update documentation.
Wed, Jun 17, 7:03 AM · efl
ali.alzyod requested review of D11991: eina_strbuf_manage_new: update documentation.
Wed, Jun 17, 7:02 AM · efl
ali.alzyod added revisions to T8757: Eina_Strbuf: issues / features: D11990: eina_strbuf: introduce change last occurrence function, D11989: eina_strbuf: resolve segfault when replace used with read_only buffer.
Wed, Jun 17, 6:54 AM · efl
ali.alzyod added a task to D11989: eina_strbuf: resolve segfault when replace used with read_only buffer: T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 6:54 AM · efl
ali.alzyod added a task to D11990: eina_strbuf: introduce change last occurrence function: T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 6:54 AM · efl
ali.alzyod claimed T8757: Eina_Strbuf: issues / features.
Wed, Jun 17, 6:53 AM · efl
ali.alzyod triaged T8757: Eina_Strbuf: issues / features as Normal priority.
Wed, Jun 17, 6:53 AM · efl
ali.alzyod added a reviewer for D11990: eina_strbuf: introduce change last occurrence function: cedric.
Wed, Jun 17, 6:42 AM · efl
ali.alzyod requested review of D11990: eina_strbuf: introduce change last occurrence function.
Wed, Jun 17, 6:42 AM · efl
ali.alzyod added a reviewer for D11989: eina_strbuf: resolve segfault when replace used with read_only buffer: cedric.
Wed, Jun 17, 5:46 AM · efl
ali.alzyod requested review of D11989: eina_strbuf: resolve segfault when replace used with read_only buffer.
Wed, Jun 17, 5:46 AM · efl

Tue, Jun 16

ali.alzyod added a reviewer for D11949: efl_ui_textpath: mathmatical calculations: vtorri.
Tue, Jun 16, 1:09 AM · efl
ali.alzyod updated the diff for D11949: efl_ui_textpath: mathmatical calculations.

remove len_2

Tue, Jun 16, 1:08 AM · efl
ali.alzyod added reviewers for D11948: efl: reduce sqrt(2) calculations (division vs multiplication): bu5hm4n, vtorri.
Tue, Jun 16, 1:04 AM · efl
ali.alzyod reclaimed D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

I think this makes sense in term of division vs multiplication

Tue, Jun 16, 1:04 AM · efl
ali.alzyod added reviewers for D11949: efl_ui_textpath: mathmatical calculations: raster, bu5hm4n.
Tue, Jun 16, 12:25 AM · efl
ali.alzyod updated the summary of D11949: efl_ui_textpath: mathmatical calculations.
Tue, Jun 16, 12:24 AM · efl
ali.alzyod updated the diff for D11949: efl_ui_textpath: mathmatical calculations.

exclude sin/cos changes

Tue, Jun 16, 12:21 AM · efl
ali.alzyod abandoned D11948: efl: reduce sqrt(2) calculations (division vs multiplication).
Tue, Jun 16, 12:11 AM · efl

Mon, Jun 15

ali.alzyod abandoned D11842: evas_text: add ref_counter feature to glyphs.
Mon, Jun 15, 11:32 PM · efl
ali.alzyod abandoned D11847: evas_text: global release for all glyphs cache.
Mon, Jun 15, 11:32 PM · efl
ali.alzyod closed T8724: Text Glyph Texture Release as Invalid.
Mon, Jun 15, 11:32 PM · efl
ali.alzyod closed T8724: Text Glyph Texture Release, a subtask of T8710: Memory Optimization for Text in EFL, as Invalid.
Mon, Jun 15, 11:32 PM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

add FIXME comment

Mon, Jun 15, 11:28 PM · efl

Thu, Jun 11

ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

default behaviour is unlimited texture size

Thu, Jun 11, 3:49 AM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

free cache on evas_font_texture_cache_set call (if needed), and change unlimited cache to be negative value instead of 0

Thu, Jun 11, 3:42 AM · efl
ali.alzyod updated the summary of D11943: evas: font glyphs texture garbage collector.
Thu, Jun 11, 1:14 AM · efl
ali.alzyod updated the task description for T8737: Glyph cache garbage collector which collect during rendering.
Thu, Jun 11, 1:04 AM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

change long to int for public APIs

Thu, Jun 11, 1:02 AM · efl
ali.alzyod accepted D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

this seems fine to me, as long it pass test for others (I think it will pass since it is not dependent on emoji font anymore)

Thu, Jun 11, 12:24 AM · efl
ali.alzyod accepted D11757: evas textblock : update font source when it set using font_source_set.

This seems fine to me

Thu, Jun 11, 12:20 AM · efl

Wed, Jun 10

ali.alzyod added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

I think changing this line to replace last occurrence instead of first will resolve the issue

Wed, Jun 10, 11:29 PM · efl
ali.alzyod added a comment to T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.

Does this mean passing struct of rect instead of 4 int values ?

Wed, Jun 10, 10:57 PM · efl
ali.alzyod added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

If there is more than one font or font_size in the textblock style, the last tag is replaced.
Because if there are multiple tags, then tag->font, tag->font_size in code is the last tag.
As you say, textblock style may have multiple font or font_size, however only the last tag is valid.

Wed, Jun 10, 6:29 AM · efl
ali.alzyod closed T8743: Memory leak in evas_common_font_int_cache_glyph_render as Resolved.
Wed, Jun 10, 5:28 AM
ali.alzyod updated the summary of D11757: evas textblock : update font source when it set using font_source_set.
Wed, Jun 10, 5:07 AM · efl
ali.alzyod added reviewers for D11757: evas textblock : update font source when it set using font_source_set: woohyun, bowonryu, cedric.
Wed, Jun 10, 5:06 AM · efl
ali.alzyod added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

What if the font style contains more than one font or font_size with same value ?
I know it seems strange but it is valid (could be done with pushed user styles or user made more than one tag).

Wed, Jun 10, 3:40 AM · efl

Tue, Jun 9

ali.alzyod added a comment to D11949: efl_ui_textpath: mathmatical calculations.

The code *is* the same, Add -O3 and you will just see that the code lines are not mapped to anything in asm. Even on the wegpage. The next example also gets eliminated the cos and sin calls.

Tue, Jun 9, 5:59 AM · efl
ali.alzyod added a comment to D11949: efl_ui_textpath: mathmatical calculations.

Don't look at the times, take a look at objdump -S a.out the outputted asm is equivalent. Also take a look where the calls to clock are located. The time advantage you see is *not* coming from the different call. infact, the sin and cos calls are stripped out completly. As a mixture of inlining, dead code removal, and const folding removed it.

Tue, Jun 9, 4:11 AM · efl
ali.alzyod added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

@raster
First : this is very small impact.
Second : you are talking only about specific compiler(s) , or maybe most of them, but this is not general thing everywhere.

Tue, Jun 9, 3:50 AM · efl
ali.alzyod added a comment to D11949: efl_ui_textpath: mathmatical calculations.

@raster lets look at the following code:

#include<math.h>
#include<time.h>
#include<stdio.h>
#include<stdlib.h>
Tue, Jun 9, 3:39 AM · efl
ali.alzyod added a comment to T8737: Glyph cache garbage collector which collect during rendering.

can we not cal it texture_cache? as this also applies to software also not long but int will do like the other caches. if people need > 2gb of cache for this... they have problems :) so maybe evas_font_data_cache_set/get(). ?

Tue, Jun 9, 3:21 AM · efl
ali.alzyod added a comment to D11947: efl: reduce PI calculations.

If we are talking about GCC and its optimization, then the whole thing does not give much enhancement.

Tue, Jun 9, 3:19 AM · efl
ali.alzyod added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

@bu5hm4n I am not sure I fully understand your comment, I use M_SQRT1_2 as its faster and readable (IMO).

Tue, Jun 9, 12:27 AM · efl
ali.alzyod added inline comments to D11949: efl_ui_textpath: mathmatical calculations.
Tue, Jun 9, 12:24 AM · efl
ali.alzyod updated the diff for D11949: efl_ui_textpath: mathmatical calculations.

use sincos instead of two calls for sin and cos

Tue, Jun 9, 12:24 AM · efl
ali.alzyod updated the test plan for D11947: efl: reduce PI calculations.
Tue, Jun 9, 12:00 AM · efl

Mon, Jun 8

ali.alzyod updated the test plan for D11947: efl: reduce PI calculations.
Mon, Jun 8, 11:44 PM · efl
ali.alzyod updated the diff for D11947: efl: reduce PI calculations.

change 1/M_PI_2 to M_2_PI

Mon, Jun 8, 11:41 PM · efl
ali.alzyod updated the test plan for D11947: efl: reduce PI calculations.
Mon, Jun 8, 11:25 PM · efl
ali.alzyod added inline comments to D11947: efl: reduce PI calculations.
Mon, Jun 8, 11:11 PM · efl
ali.alzyod added a comment to D11947: efl: reduce PI calculations.

I dont mind if we land this or not. But this is not really impacting anything, const folding covered the cases i checked, and if not, then the static double assignment will fail...

Mon, Jun 8, 11:04 PM · efl
smohanty awarded D11944: elementary_test: remove leaked style a Like token.
Mon, Jun 8, 10:42 PM · efl
ali.alzyod added a comment to T8742: Memory leak in evas_object_textblock_style_set().

@ali ,
I didn't know evas_object_textblock_style_set() only keeps the reference to the raw pointer.

Could you please change the testapp to fix the issue .

thanks

Mon, Jun 8, 8:07 PM
ali.alzyod added a comment to D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

@zmike can you please confirm if latest update fix the test failing

Mon, Jun 8, 10:02 AM · efl
ali.alzyod added reviewers for D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak): woohyun, bowonryu, zmike, segfaultxavi, bu5hm4n.
Mon, Jun 8, 9:59 AM · efl
ali.alzyod added a comment to D11732: Textblock : Fix cursor cluster movement when emoji at the line start.

Can we close this patch please, (unless there are some comments)

Mon, Jun 8, 9:57 AM · efl
ali.alzyod added a comment to D11844: evas_object_textblock: remove visaully deleted item from line items.

I think we should change the part that set visually_deleted to FALSE will remove from line items

Mon, Jun 8, 9:49 AM · efl
ali.alzyod added a task to D11949: efl_ui_textpath: mathmatical calculations: T8747: Reduce math calculations.
Mon, Jun 8, 9:47 AM · efl
ali.alzyod added a revision to T8747: Reduce math calculations: D11949: efl_ui_textpath: mathmatical calculations.
Mon, Jun 8, 9:47 AM
ali.alzyod requested review of D11949: efl_ui_textpath: mathmatical calculations.
Mon, Jun 8, 9:46 AM · efl
ali.alzyod added a task to D11948: efl: reduce sqrt(2) calculations (division vs multiplication): T8747: Reduce math calculations.
Mon, Jun 8, 9:33 AM · efl
ali.alzyod added a revision to T8747: Reduce math calculations: D11948: efl: reduce sqrt(2) calculations (division vs multiplication).
Mon, Jun 8, 9:33 AM
ali.alzyod requested review of D11948: efl: reduce sqrt(2) calculations (division vs multiplication).
Mon, Jun 8, 9:33 AM · efl
ali.alzyod added a revision to T8747: Reduce math calculations: D11947: efl: reduce PI calculations.
Mon, Jun 8, 9:27 AM
ali.alzyod added a task to D11947: efl: reduce PI calculations: T8747: Reduce math calculations.
Mon, Jun 8, 9:26 AM · efl
ali.alzyod added a revision to T8747: Reduce math calculations: D11904: efl_ui_textpath: reduce unneeded matrix calculations.
Mon, Jun 8, 9:26 AM
ali.alzyod added a task to D11904: efl_ui_textpath: reduce unneeded matrix calculations: T8747: Reduce math calculations.
Mon, Jun 8, 9:26 AM · efl
ali.alzyod triaged T8747: Reduce math calculations as Normal priority.
Mon, Jun 8, 9:25 AM
ali.alzyod requested review of D11947: efl: reduce PI calculations.
Mon, Jun 8, 9:22 AM · efl
ali.alzyod updated the summary of D11943: evas: font glyphs texture garbage collector.
Mon, Jun 8, 7:10 AM · efl
ali.alzyod updated the test plan for D11943: evas: font glyphs texture garbage collector.
Mon, Jun 8, 7:08 AM · efl
ali.alzyod added a reviewer for D11943: evas: font glyphs texture garbage collector: Hermet.
Mon, Jun 8, 6:45 AM · efl
ali.alzyod added a comment to T8743: Memory leak in evas_common_font_int_cache_glyph_render.

This is an issue, D11945 should fix it, and release leaked data

Mon, Jun 8, 3:15 AM
ali.alzyod added reviewers for D11945: evas_common_font: release reallocated glyphs bitmaps data: woohyun, smohanty.
Mon, Jun 8, 3:14 AM · efl
ali.alzyod added a task to D11945: evas_common_font: release reallocated glyphs bitmaps data: T8743: Memory leak in evas_common_font_int_cache_glyph_render.
Mon, Jun 8, 3:14 AM · efl
ali.alzyod added a revision to T8743: Memory leak in evas_common_font_int_cache_glyph_render: D11945: evas_common_font: release reallocated glyphs bitmaps data.
Mon, Jun 8, 3:14 AM
ali.alzyod requested review of D11945: evas_common_font: release reallocated glyphs bitmaps data.
Mon, Jun 8, 3:13 AM · efl
ali.alzyod added a comment to T8742: Memory leak in evas_object_textblock_style_set().

I think this is leak in the demo it self, where it does not free style that was created.

Mon, Jun 8, 1:50 AM
ali.alzyod added a task to D11944: elementary_test: remove leaked style: T8742: Memory leak in evas_object_textblock_style_set().
Mon, Jun 8, 1:49 AM · efl
ali.alzyod added a revision to T8742: Memory leak in evas_object_textblock_style_set(): D11944: elementary_test: remove leaked style.
Mon, Jun 8, 1:49 AM
ali.alzyod added reviewers for D11944: elementary_test: remove leaked style: woohyun, smohanty.
Mon, Jun 8, 1:49 AM · efl