Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (53 w, 6 d)
Availability
Available

Recent Activity

Today

ali.alzyod added reviewers for D10836: efl.ui.text: add placeholder property: woohyun, segfaultxavi.
Mon, Dec 9, 10:19 AM · efl
ali.alzyod requested review of D10836: efl.ui.text: add placeholder property.
Mon, Dec 9, 10:18 AM · efl
ali.alzyod added reviewers for D10835: efl.ui.text: rename to efl.ui.textbox: woohyun, segfaultxavi, bu5hm4n, zmike, YOhoho.
Mon, Dec 9, 10:15 AM · efl
ali.alzyod updated the summary of D10835: efl.ui.text: rename to efl.ui.textbox.
Mon, Dec 9, 9:49 AM · efl
ali.alzyod added inline comments to D10835: efl.ui.text: rename to efl.ui.textbox.
Mon, Dec 9, 9:42 AM · efl
ali.alzyod requested review of D10835: efl.ui.text: rename to efl.ui.textbox.
Mon, Dec 9, 9:39 AM · efl
ali.alzyod removed a child revision for D10711: Efl.Ui.Text : all related interfaces: D10776: efl_ui_text: unit test.
Mon, Dec 9, 6:46 AM · efl
ali.alzyod removed a parent revision for D10776: efl_ui_text: unit test: D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 9, 6:46 AM · efl
ali.alzyod updated the summary of D10776: efl_ui_text: unit test.
Mon, Dec 9, 6:45 AM · efl
ali.alzyod added inline comments to D10776: efl_ui_text: unit test.
Mon, Dec 9, 6:45 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

replace fail_if with ck_assert_ptr_ne

Mon, Dec 9, 6:44 AM · efl
ali.alzyod updated the diff for D10834: efl_canvas_text: event emitting.

add tests, efl_text_set will emit single Efl.Canvas.Text.Changed event

Mon, Dec 9, 6:38 AM · efl
ali.alzyod added reviewers for D10834: efl_canvas_text: event emitting: woohyun, segfaultxavi.
Mon, Dec 9, 6:12 AM · efl
ali.alzyod added a comment to D10711: Efl.Ui.Text : all related interfaces.

The Calculator example still does not work fine.
I do not need to move the cursor to the end of the line before inserting, that's fixed.
However, I still do not get the CHANGED events when I press a number button, and I get two at the same time sometimes.

After some investigation, find out adding text using cursor will not force the efl_canvas_text_event_changed

Also, efl_text_get() on the widgets seems to always return "0".

I could not reproduce this one, it seems to work fine.

Mon, Dec 9, 6:11 AM · efl
ali.alzyod requested review of D10834: efl_canvas_text: event emitting.
Mon, Dec 9, 6:09 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

rebase

Mon, Dec 9, 4:07 AM · efl
ali.alzyod added a reviewer for D10831: efl_ui_text_editable: remove class: woohyun.
Mon, Dec 9, 1:15 AM · efl
ali.alzyod requested review of D10831: efl_ui_text_editable: remove class.
Mon, Dec 9, 1:14 AM · efl
ali.alzyod updated the diff for D9053: evas_object_textblock: add support for variation sequences.

rebase

Mon, Dec 9, 12:09 AM · efl

Fri, Dec 6

ali.alzyod updated the summary of D10826: evas_text: retain legacy behaviour.
Fri, Dec 6, 12:36 PM · efl
ali.alzyod retitled D10826: evas_text: retain legacy behaviour from evas_textblock: retain legacy behaviour to evas_text: retain legacy behaviour.
Fri, Dec 6, 12:22 PM · efl
ali.alzyod updated the summary of D10826: evas_text: retain legacy behaviour.
Fri, Dec 6, 12:20 PM · efl
ali.alzyod added a comment to D10716: Polish text interface methods.

Seems like this is indeed incorrect.

Fri, Dec 6, 12:18 PM · efl
ali.alzyod added a reviewer for D10826: evas_text: retain legacy behaviour: cedric.
Fri, Dec 6, 12:15 PM · efl
ali.alzyod requested review of D10826: evas_text: retain legacy behaviour.
Fri, Dec 6, 12:14 PM · efl
ali.alzyod added a comment to D10716: Polish text interface methods.

After the double-check, I correct my statement Nobody requested to change legacy code, So this is the caused by this patch.
I will submit new patch to fix this part

Fri, Dec 6, 12:11 PM · efl
ali.alzyod added a comment to D10716: Polish text interface methods.

I am getting a tons of: ERR<1489125>:eina_safety ../src/lib/evas/canvas/evas_object_text.c:2355 evas_object_text_font_set() safety check failed: font == NULL

Fri, Dec 6, 12:02 PM · efl
ali.alzyod added a comment to T8477: Edje: Fix Textblock's text_class.

I think you may want to check efl_gfx_text_class.eo if it needs updates too (to have the option to override this property at the file and object level)

Fri, Dec 6, 11:16 AM
ali.alzyod added inline comments to D10776: efl_ui_text: unit test.
Fri, Dec 6, 10:48 AM · efl
ali.alzyod added a comment to D10716: Polish text interface methods.

Just execute "elementary_test -to genlist".

Fri, Dec 6, 10:33 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

update

Fri, Dec 6, 10:30 AM · efl
ali.alzyod added inline comments to D10776: efl_ui_text: unit test.
Fri, Dec 6, 10:29 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

rebase

Fri, Dec 6, 9:34 AM · efl

Thu, Dec 5

ali.alzyod added a comment to D10716: Polish text interface methods.

This patch add a bunch of warning when trying genlist elementary test due to some unexpected legacy usage. Would be nice to get that fixed too.

Thu, Dec 5, 11:49 PM · efl
ali.alzyod updated the summary of D10810: efl_text_cursor: rename enums.
Thu, Dec 5, 12:09 PM · efl
ali.alzyod updated the summary of D10810: efl_text_cursor: rename enums.
Thu, Dec 5, 12:05 PM · efl
ali.alzyod added reviewers for D10810: efl_text_cursor: rename enums: woohyun, segfaultxavi.
Thu, Dec 5, 12:02 PM · efl
ali.alzyod requested review of D10810: efl_text_cursor: rename enums.
Thu, Dec 5, 11:58 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

rebase

Thu, Dec 5, 11:42 AM · efl
ali.alzyod added a comment to D10711: Efl.Ui.Text : all related interfaces.

@segfaultxavi Thanks a lot for sharing the demo.

I have this example calculator application which I am adapting to these changes in a branch:
https://git.enlightenment.org/tools/examples.git/tree/apps/c/calculator/src/calculator.c?h=devs/xartigas/adapting-to-text-changes

  • After this patch, I have to manually move the cursor to the end of the line before inserting anything (previously I didn't have to). Is this intended?

This was bug and I fix it, the problem was that efl_text_set was not modify main cursor position, now we move main cursor to the end if we use efl_text_set or efl_text_markup_set.

  • I add characters to the Efl.Ui.Textwidget using a cursor and efl_text_cursor_text_insert. However, my _screen_changed_cb is never called, no matter if I connect to EFL_TEXT_INTERACTIVE_EVENT_CHANGED_USER or to EFL_UI_TEXT_EVENT_CHANGED. Is this intended?

This was a bug, Now EFL_UI_TEXT_EVENT_CHANGED will be called for any change in the content.
EFL_TEXT_INTERACTIVE_EVENT_CHANGED_USER will be called only when user change the text (using keyboard or clipboard)

Thu, Dec 5, 11:36 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.
  • Fixes
Thu, Dec 5, 11:32 AM · efl
ali.alzyod added inline comments to D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.
Thu, Dec 5, 8:18 AM · efl
ali.alzyod added inline comments to D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.
Thu, Dec 5, 8:17 AM · efl
ali.alzyod added a comment to D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.

Wait a minute. Is this changing the LEGACY API too?

Thu, Dec 5, 7:53 AM · efl
ali.alzyod updated the summary of D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.
Thu, Dec 5, 3:19 AM · efl
ali.alzyod added a reviewer for D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock: YOhoho.
Thu, Dec 5, 3:17 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

rebase

Thu, Dec 5, 3:14 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

rebase

Thu, Dec 5, 3:12 AM · efl
ali.alzyod added a comment to T8093: Name conflict between class and property.

@segfaultxavi

By the way, how does your plan relate to @tasn's ? I admit I didn't thoroughly read his RFC.

@tasn plan does not include future widget design, and also it was effected a lot where a composite class in EFL is not working anymore.

Thu, Dec 5, 3:09 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added a comment to T8093: Name conflict between class and property.

Rename Efl.Canvas.Text into Efl.Canvas.Textblock D10808

Thu, Dec 5, 3:07 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added reviewers for D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock: woohyun, segfaultxavi, zmike, bu5hm4n.
Thu, Dec 5, 3:06 AM · efl
ali.alzyod updated the summary of D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.
Thu, Dec 5, 3:06 AM · efl
ali.alzyod retitled D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock from efl_text_attribute_factory: update documention to efl_canvas_Text rename into efl_canvas_textblock.
Thu, Dec 5, 3:05 AM · efl
ali.alzyod requested review of D10808: Efl.Canvas.Text rename into Efl.Canvas.Textblock.
Thu, Dec 5, 3:04 AM · efl
ali.alzyod updated the summary of D10711: Efl.Ui.Text : all related interfaces.
Thu, Dec 5, 1:26 AM · efl
ali.alzyod added a reviewer for D10806: efl_text_attribute_factory: update documention: segfaultxavi.
Thu, Dec 5, 1:24 AM · efl
ali.alzyod requested review of D10806: efl_text_attribute_factory: update documention.
Thu, Dec 5, 1:22 AM · efl

Wed, Dec 4

ali.alzyod added a comment to T8093: Name conflict between class and property.

@woohyun @zmike @bu5hm4n @segfaultxavi
If there are no further concerns I will soon update :

Wed, Dec 4, 11:25 PM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

add Efl.Ui.Text into efl_text_basics

Wed, Dec 4, 11:20 PM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

rebase

Wed, Dec 4, 3:07 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.
Wed, Dec 4, 1:46 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

rebase

Wed, Dec 4, 1:42 AM · efl
ali.alzyod added a comment to D10711: Efl.Ui.Text : all related interfaces.

@segfaultxavi @bu5hm4n @zmike @woohyun
Please let me know for any more concerns related to this patch. (Test founded in D10776)

Wed, Dec 4, 1:41 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

rebase + fix cut event

Wed, Dec 4, 1:38 AM · efl
ali.alzyod added a child revision for D10646: Efl.Text.Attribute_Factory: D10711: Efl.Ui.Text : all related interfaces.
Wed, Dec 4, 1:38 AM · efl

Tue, Dec 3

ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

update

Tue, Dec 3, 10:44 PM · efl
ali.alzyod removed a project from D10776: efl_ui_text: unit test: DO NOT MERGE.
Tue, Dec 3, 9:18 AM · efl
ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

add tests

Tue, Dec 3, 9:16 AM · efl
ali.alzyod added inline comments to D10776: efl_ui_text: unit test.
Tue, Dec 3, 4:03 AM · efl
ali.alzyod added a comment to T8093: Name conflict between class and property.

Efl.Canvas.Text -> Efl.Canvas.Textblock I am fine with this
Efl.Ui.Text -> Efl.Ui.TextField I prefer using name other than textfiled text field gives impression it is single line.

Tue, Dec 3, 3:50 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod removed a child revision for D10646: Efl.Text.Attribute_Factory: D10711: Efl.Ui.Text : all related interfaces.
Tue, Dec 3, 1:30 AM · efl
ali.alzyod removed a parent revision for D10711: Efl.Ui.Text : all related interfaces: D10646: Efl.Text.Attribute_Factory.
Tue, Dec 3, 1:30 AM · efl
ali.alzyod added a child revision for D10646: Efl.Text.Attribute_Factory: D10711: Efl.Ui.Text : all related interfaces.
Tue, Dec 3, 1:16 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

replace selection_start,selection_clear with have_selection event
selection_changed will contain range of selected text index
have_selection_changed will contains boolean indicate if it has selectio(start) or not (clear)

Tue, Dec 3, 1:16 AM · efl

Mon, Dec 2

ali.alzyod updated the summary of D10776: efl_ui_text: unit test.
Mon, Dec 2, 10:57 PM · efl
ali.alzyod added a parent revision for D10776: efl_ui_text: unit test: D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 10:52 PM · efl
ali.alzyod added a child revision for D10711: Efl.Ui.Text : all related interfaces: D10776: efl_ui_text: unit test.
Mon, Dec 2, 10:52 PM · efl
ali.alzyod requested review of D10776: efl_ui_text: unit test.
Mon, Dec 2, 10:52 PM · efl
ali.alzyod added a comment to D10711: Efl.Ui.Text : all related interfaces.

@segfaultxavi @bu5hm4n @zmike
I will add more tests in other patch tomorrow is that ok? or add it to this patch (I do not want to increase the large of this patch anymore)

Mon, Dec 2, 10:03 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 9:48 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 8:51 AM · efl
ali.alzyod removed a parent revision for D10711: Efl.Ui.Text : all related interfaces: D10646: Efl.Text.Attribute_Factory.
Mon, Dec 2, 7:40 AM · efl
ali.alzyod removed a child revision for D10646: Efl.Text.Attribute_Factory: D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 7:40 AM · efl
ali.alzyod added a comment to D10711: Efl.Ui.Text : all related interfaces.

@bu5hm4n other than SELECTION events for you have other requested changes.

Mon, Dec 2, 7:31 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 7:30 AM · efl
ali.alzyod requested review of D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 7:17 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 7:17 AM · efl
ali.alzyod added a comment to D10729: efl_canvas_text: documentation for style set.

@segfaultxavi Please let me know if any-more changes are required

Mon, Dec 2, 6:13 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 6:09 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

updates

Mon, Dec 2, 6:09 AM · efl
ali.alzyod updated the diff for D10729: efl_canvas_text: documentation for style set.

update

Mon, Dec 2, 4:40 AM · efl
ali.alzyod added a child revision for D10607: Efl Canvas Text : Modify Style Property: D10729: efl_canvas_text: documentation for style set.
Mon, Dec 2, 4:40 AM · efl
ali.alzyod added inline comments to D10729: efl_canvas_text: documentation for style set.
Mon, Dec 2, 4:07 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 12:50 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 12:47 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

rebase

Mon, Dec 2, 12:18 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

fix

Mon, Dec 2, 12:12 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 12:12 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 12:07 AM · efl

Sun, Dec 1

ali.alzyod added a comment to D10729: efl_canvas_text: documentation for style set.

close my comments

Sun, Dec 1, 10:52 AM · efl