Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (95 w, 4 d)
Availability
Available

Recent Activity

Wed, Sep 23

ali.alzyod reopened D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Wed, Sep 23, 6:26 AM · efl
ali.alzyod closed D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Wed, Sep 23, 3:30 AM · efl

Mon, Sep 14

ali.alzyod added reviewers for D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node: raster, woohyun, netstar.
Mon, Sep 14, 9:31 AM · efl
ali.alzyod updated the diff for D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.

add test case

Mon, Sep 14, 9:30 AM · efl
ali.alzyod added a comment to T8809: evas_object_textblock / elm_entry - line merge up junk characters..

D12145 should fix this issue

Mon, Sep 14, 7:48 AM · efl
ali.alzyod added a task to D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node: T8809: evas_object_textblock / elm_entry - line merge up junk characters..
Mon, Sep 14, 7:48 AM · efl
ali.alzyod added a revision to T8809: evas_object_textblock / elm_entry - line merge up junk characters.: D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Mon, Sep 14, 7:48 AM · efl
ali.alzyod requested review of D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Mon, Sep 14, 7:47 AM · efl
ali.alzyod added a comment to T8809: evas_object_textblock / elm_entry - line merge up junk characters..

This is an old issue:

Mon, Sep 14, 12:14 AM · efl

Thu, Sep 10

ali.alzyod added inline comments to D12133: evas_textblock : Handle cursor correctly when inserting ps.
Thu, Sep 10, 2:13 AM · efl
ali.alzyod accepted D12130: evas_textblock: Add check for NULL pointers after malloc.

seems fine to me

Thu, Sep 10, 1:27 AM · efl
ali.alzyod added reviewers for D12130: evas_textblock: Add check for NULL pointers after malloc: AbdullehGhujeh, woohyun, bowonryu.
Thu, Sep 10, 1:27 AM · efl

Sun, Sep 6

ali.alzyod added inline comments to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.
Sun, Sep 6, 9:43 AM · efl
ali.alzyod added a comment to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.

How can we produce this issue ?

Sun, Sep 6, 9:42 AM · efl
ali.alzyod added inline comments to D12133: evas_textblock : Handle cursor correctly when inserting ps.
Sun, Sep 6, 9:42 AM · efl
ali.alzyod added inline comments to D12130: evas_textblock: Add check for NULL pointers after malloc.
Sun, Sep 6, 8:24 AM · efl

Fri, Sep 4

ali.alzyod added inline comments to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.
Fri, Sep 4, 9:13 AM · efl

Tue, Sep 1

ali.alzyod updated the diff for D12126: elm_entry: legacy smart selection[start,cleared] callback fix.

remove unneeded events from legacy object

Tue, Sep 1, 9:42 AM · efl
ali.alzyod added reviewers for D12126: elm_entry: legacy smart selection[start,cleared] callback fix: woohyun, bowonryu.
Tue, Sep 1, 9:31 AM · efl
ali.alzyod requested review of D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Tue, Sep 1, 9:30 AM · efl
ali.alzyod accepted D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).
Tue, Sep 1, 3:25 AM · efl
ali.alzyod retitled D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2) from evas_textblock: rainbow flag emoji treated as two clusters(update unibreak) to evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).
Tue, Sep 1, 3:17 AM · efl
ali.alzyod added a comment to D12124: update libunibreak to 4.3.

This patch already update unibreak D11743, It also update some internal stuff in EFL to not break compatibility

Tue, Sep 1, 1:12 AM · efl
ali.alzyod accepted D12110: evas_textblock: remove style padding from native width and formatted height.

Things seems better with this change.

Tue, Sep 1, 1:09 AM · efl
ali.alzyod requested changes to D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).

Needs Rebase

Tue, Sep 1, 12:51 AM · efl

Sun, Aug 30

ali.alzyod closed T8737: Glyph cache garbage collector which collect during rendering as Resolved.
Sun, Aug 30, 3:48 AM · efl
ali.alzyod closed T8737: Glyph cache garbage collector which collect during rendering, a subtask of T8710: Memory Optimization for Text in EFL, as Resolved.
Sun, Aug 30, 3:48 AM · efl

Aug 26 2020

ali.alzyod added a comment to D12117: elm_config: rescale is needed when font or font size is changed.

I Agree With the Idea of this patch ... BUT when you're variables are spelled wrong, then I cannot trust it...Please fix the spelling issues....

Aug 26 2020, 11:28 PM · efl
ali.alzyod raised the priority of T8792: textblock : Handle cursors correctly when inserting ps from TODO to Normal.
Aug 26 2020, 4:39 AM · efl

Aug 25 2020

ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.

From what I understand from the source code, the user can not specify padding directly, it is calculated automatically depending on Style Effects (shadow, Glow, ... etc).
These effects will change text size, so I think it should be counted when calculating text size in both native and formatted size.

Aug 25 2020, 4:18 AM · efl
ali.alzyod closed D12116: evas_font_query: add Use parentheses within macros.
Aug 25 2020, 3:40 AM · efl
ali.alzyod added a reviewer for D12116: evas_font_query: add Use parentheses within macros: bu5hm4n.
Aug 25 2020, 3:15 AM · efl
ali.alzyod requested review of D12116: evas_font_query: add Use parentheses within macros.
Aug 25 2020, 3:15 AM · efl

Aug 24 2020

ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.
/**
 * @brief The formatted width and height.
 *
 * This calculates the actual size after restricting the textblock to the
 * current size of the object.
 *
 * The main difference between this and
 * @ref evas_object_textblock_size_native_get is that the "native" function
 * does not wrapping into account it just calculates the real width of the
 * object if it was placed on an infinite canvas, while this function gives the
 * size after wrapping according to the size restrictions of the object.
 *
 * For example for a textblock containing the text: "You shall not pass!" with
 * no margins or padding and assuming a monospace font and a size of 7x10 char
 * widths (for simplicity) has a native size of 19x1 and a formatted size of
 * 5x4.
 *
 * @param[in] obj The object.
 * @param[out] width The width of the object.
 * @param[out] height The height of the object.
 *
 * @since 1.18
 *
 * @ingroup Evas_Object_Textblock_Group
 */
EAPI void evas_object_textblock_size_formatted_get(const Efl_Canvas_Textblock *obj, int *width, int *height);
Aug 24 2020, 3:21 AM · efl
ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.

Sure there are issue here, but what is the right behaviour to resolve it.

Aug 24 2020, 12:51 AM · efl

Aug 17 2020

ali.alzyod accepted D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).
Aug 17 2020, 10:55 PM · efl

Aug 16 2020

ali.alzyod requested changes to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

Ninja test is failing

Aug 16 2020, 11:10 PM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

add missing condition

Aug 16 2020, 6:23 AM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
  • rebase
Aug 16 2020, 3:40 AM · efl

Aug 10 2020

ali.alzyod added reviewers for D12102: evas_textblock: myanmar script rendering with e vowel.: woohyun, bowonryu.
Aug 10 2020, 6:52 AM · efl
ali.alzyod requested review of D12102: evas_textblock: myanmar script rendering with e vowel..
Aug 10 2020, 6:52 AM · efl
ali.alzyod updated subscribers of T8787: Segmentation Fault by ecore_main_loop_iterate.
Aug 10 2020, 12:57 AM · efl (efl-1.24)
ali.alzyod requested changes to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

needs rebase

Aug 10 2020, 12:16 AM · efl

Aug 9 2020

ali.alzyod added a comment to D12099: evas_textblock : Enhance new line as paragraph separator functionality.

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position

Aug 9 2020, 11:50 PM · efl
ali.alzyod requested changes to D12099: evas_textblock : Enhance new line as paragraph separator functionality.
Aug 9 2020, 11:50 PM · efl
ali.alzyod triaged T8787: Segmentation Fault by ecore_main_loop_iterate as Normal priority.
Aug 9 2020, 11:47 PM · efl (efl-1.24)
ali.alzyod added a comment to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

Can you please check comments

Aug 9 2020, 10:59 PM · efl
ali.alzyod added inline comments to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).
Aug 9 2020, 10:59 PM · efl
ali.alzyod added reviewers for D12100: evas: support garbage collector for glyphs bitmap in RAM: raster, woohyun, cedric.
Aug 9 2020, 10:54 PM · efl
ali.alzyod updated the summary of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:33 AM · efl
ali.alzyod updated the summary of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:32 AM · efl
ali.alzyod updated the test plan for D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:31 AM · efl
ali.alzyod requested review of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:19 AM · efl

Aug 5 2020

ali.alzyod added inline comments to D12087: edje_entry: fix a potentional error of null deref.
Aug 5 2020, 11:00 PM · efl

Aug 4 2020

ali.alzyod abandoned D8603: Change Single Line Mode behaviour in Entry.

since EDC does not respect Multiline property in TEXTBLOCK object, this will break compatibility

Aug 4 2020, 5:28 AM · efl
ali.alzyod added reviewers for D11947: efl: reduce PI calculations: vtorri, bu5hm4n.
Aug 4 2020, 2:04 AM · efl
ali.alzyod updated the diff for D11947: efl: reduce PI calculations.

update

Aug 4 2020, 2:03 AM · efl
ali.alzyod updated the diff for D11775: evas_textblock: enhance cursor event submitting during markup_set/text_set.

rebase

Aug 4 2020, 1:34 AM · efl
ali.alzyod added inline comments to D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 1:25 AM · efl
ali.alzyod added a comment to D11947: efl: reduce PI calculations.

I updated testing sample code with -O3 optimization to show the speed up.

Aug 4 2020, 1:23 AM · efl
ali.alzyod requested review of D11947: efl: reduce PI calculations.
Aug 4 2020, 1:22 AM · efl
ali.alzyod updated the test plan for D11947: efl: reduce PI calculations.
Aug 4 2020, 1:22 AM · efl
ali.alzyod updated the diff for D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator.

rebase

Aug 4 2020, 1:06 AM · efl
ali.alzyod updated the diff for D11942: efl_ui_textbox: preserve changing user color set.

rebase

Aug 4 2020, 12:56 AM · efl
ali.alzyod updated the diff for D11695: elm_entry/efl.ui.textbox: use common key shortcuts.

rebase

Aug 4 2020, 12:22 AM · efl
ali.alzyod updated the diff for D9370: evas_textblock: enhance escape character handling.

rebase

Aug 4 2020, 12:17 AM · efl

Jul 29 2020

ali.alzyod claimed T8772: Issues in Ellipsis.
Jul 29 2020, 3:43 AM · Restricted Project
ali.alzyod claimed T8776: Middle Ellipsis (value = 0.5) in RTL Arabic does not work as expected.
Jul 29 2020, 3:43 AM · Restricted Project

Jul 28 2020

ali.alzyod accepted D12070: evas_textblock : Remove unneeded code.
Jul 28 2020, 7:05 AM · efl
ali.alzyod added reviewers for D12070: evas_textblock : Remove unneeded code: woohyun, stefan_schmidt, bowonryu.
Jul 28 2020, 7:05 AM · efl
ali.alzyod added reviewers for D12071: evas_textblock : return correct value for gfx_filter_get: woohyun, stefan_schmidt, bowonryu.
Jul 28 2020, 7:03 AM · efl
ali.alzyod accepted D12071: evas_textblock : return correct value for gfx_filter_get.
Jul 28 2020, 7:03 AM · efl

Jul 27 2020

ali.alzyod added a comment to D12066: evas: remove unused define.

Your commit message is really sparse.

When looking into this I found that this symbol is defined in a enum as well as the define (which you use).
So we are not loosing the symbol, but simply removing a duplicate of it. Is that correct?

Jul 27 2020, 6:46 AM · efl
ali.alzyod requested review of D12066: evas: remove unused define.
Jul 27 2020, 12:40 AM · efl
ali.alzyod updated the summary of D11943: evas: font glyphs texture garbage collector.
Jul 27 2020, 12:33 AM · efl

Jul 26 2020

ali.alzyod added a reviewer for D12065: elementry_test: fix allocation size: stefan_schmidt.
Jul 26 2020, 7:42 AM · efl
ali.alzyod requested review of D12065: elementry_test: fix allocation size.
Jul 26 2020, 1:51 AM · efl

Jul 22 2020

ali.alzyod reopened T8772: Issues in Ellipsis as "Open".
Jul 22 2020, 8:01 AM · Restricted Project
ali.alzyod added a comment to D11943: evas: font glyphs texture garbage collector.

@raster Changes are done

Jul 22 2020, 3:59 AM · efl
ali.alzyod updated the task description for T8772: Issues in Ellipsis.
Jul 22 2020, 3:09 AM · Restricted Project

Jul 21 2020

ali.alzyod accepted D11962: edje_textblock: remove duplicated textblock style properties.

Seems fine to me. thank you

Jul 21 2020, 8:30 AM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

set enum first in function parameters

Jul 21 2020, 3:51 AM · efl

Jul 20 2020

ali.alzyod added inline comments to D11962: edje_textblock: remove duplicated textblock style properties.
Jul 20 2020, 4:44 AM · efl

Jul 19 2020

ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

update code

Jul 19 2020, 1:37 AM · efl

Jul 17 2020

ali.alzyod added inline comments to D11962: edje_textblock: remove duplicated textblock style properties.
Jul 17 2020, 12:36 PM · efl

Jul 16 2020

ali.alzyod added inline comments to D11943: evas: font glyphs texture garbage collector.
Jul 16 2020, 11:22 AM · efl
ali.alzyod updated the test plan for D11943: evas: font glyphs texture garbage collector.
Jul 16 2020, 12:47 AM · efl
ali.alzyod requested review of D12054: edje_cc : resolve build warning.
Jul 16 2020, 12:24 AM · efl

Jul 15 2020

ali.alzyod updated the task description for T8737: Glyph cache garbage collector which collect during rendering.
Jul 15 2020, 10:57 PM · efl
ali.alzyod updated the summary of D11943: evas: font glyphs texture garbage collector.
Jul 15 2020, 10:46 PM · efl
ali.alzyod updated the task description for T8737: Glyph cache garbage collector which collect during rendering.
Jul 15 2020, 10:45 PM · efl
ali.alzyod added a comment to T8737: Glyph cache garbage collector which collect during rendering.

can we not cal it texture_cache? as this also applies to software also not long but int will do like the other caches. if people need > 2gb of cache for this... they have problems :) so maybe evas_font_data_cache_set/get(). ?

these function does not effect SW render, only gl renderer

Jul 15 2020, 10:44 PM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

Update global functions by : Add options, general function names, use bigger variables types

Jul 15 2020, 10:36 PM · efl

Jul 13 2020

ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

clean white spaces, unused vars

Jul 13 2020, 9:24 AM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

move implementation inside the Engine

Jul 13 2020, 9:20 AM · efl

Jul 8 2020

ali.alzyod updated the test plan for D11943: evas: font glyphs texture garbage collector.
Jul 8 2020, 11:34 PM · efl
ali.alzyod updated the test plan for D11943: evas: font glyphs texture garbage collector.
Jul 8 2020, 11:34 PM · efl
ali.alzyod updated the diff for D11943: evas: font glyphs texture garbage collector.

Add elementry test

Jul 8 2020, 11:29 PM · efl

Jul 6 2020

ali.alzyod closed T8727: text objects: Lazy loading for color glyphs (emoji's) as Resolved.
Jul 6 2020, 11:07 PM · efl
ali.alzyod closed T8727: text objects: Lazy loading for color glyphs (emoji's), a subtask of T8710: Memory Optimization for Text in EFL, as Resolved.
Jul 6 2020, 11:07 PM · efl