@Hermet Please run test code, you can see will notice the speedup.

@segfaultxavi @vtorri Do you have any issues left ?

• use c standard functions

remove tolower

add search array function to header

add comment for search function

use common function for search array

@segfaultxavi thanks a lot for the information, The Idea of this patch is adding important feature to EFL color style using color name

In D9155#168423, @vtorri wrote:

what about making this function inline ?

In D9140#168425, @vtorri wrote:

should EAPI_INTERNAL EAPI really be part of the API ?

update some data types

I am updating part of text-block and instead of define byte internally we can use it from Eina.

In D9053#167474, @subodh6129 wrote:

In D9053#167470, @ali.alzyod wrote:

In D9053#167456, @subodh6129 wrote:

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

-because variation sequences can vary from ( 0xFE00-0xFE0F , 0xE0100-0xE01EF, 0x180B-0x180D), So I think create hashing tables for these values for each character (or characters that could have variation sequences) will consume more memory, and logic will become more complicated where one Unicode value could have many variation sequences.

-So I thought of binary search as good solution where we will keep old logic as it is, and if character has variation sequence it will be added to variation sequence sorted list, and accessing will be fast specially list will be small for each unicode value.

Making myself clear,
Memory will not be issue here, only issue I can see is that single Unicode can have multiple variation sequence. So if same unicode with different variation sequence belonging to different font file will fetch you the incorrect font in some cases, if current logic is used.
Am I correct?
If so, then it looks good to me.

In D9053#167456, @subodh6129 wrote:

@ali.alzyod
Small query here,
why do you need separate caching logic for variation sequence? Can't it be accommodated in the current logic?

fix binary insertion

evas_textblock: add support for caching variation sequence

@zmike please try now

• Add function comment decleration,Fix caching Issue, Fix searching fonts issue

@bu5hm4n Thank you for your fast feedback
These are my comments on some points

I am thinking of making all text interface APIs return error codes, where it make life of efl developers more easy, to know exactly what is happening if function success or failed.

update test suite with variation sequences

• fix compilation error if harfbuzz was not enabled

You are right, it is confusing to use same signature,
Internal API should have there own signatures to avoid confusing

@segfaultxavi are not these internal APIs ?

fix spaces

This Compare Old Vs New Vs Android

@bu5hm4n
update test cases, and Fix searching UTF8 instead on unicode

I always prefer general functions with Enums/flags for specific option
1- understanding SDK much simpler (specially from documentation)
2- adding features will never break comparability in future

I still think this property should be removed from Efl.Ui.Text, which should then only override the one in Efl.Text. Do you agree?
Yes I agree

@segfaultxavi I think Efl.Ui.Text.password_mode should be removed

@segfaultxavi sorry I was away from computer, I think you already added the comment.
Thank you

@bu5hm4n sure, should I add it directly there or inside sub task

@woohyun @segfaultxavi
This is not related directly to this patch, but you can detect the issue here.

patch seems fine to me

update

@segfaultxavi
with keyboard there are additional processing for keydown (_key_down_cb), and maybe it some point it handle updating selection

Before