Testing is failing because text nodes don't recreated on efl_multiline_set.
in simple words

• add test case

Can everyone check this from your side?

Currently we have following error printed

ERR<10727>:eina_safety ../src/modules/ecore_evas/engines/x/ecore_evas_x.c:3928 _ecore_evas_x_selection_notify() safety check failed: !edata->selection_data[selection].later_conversion is false

@bu5hm4n, Will this issue resolved with new clipboard implementation

Can we close this one please (If there are no objection )

This patch is setting here for long time, Anyone of the reviewers can you please let me know what you think ??

In D11508#221191, @bu5hm4n wrote:

I am not sure the removal of the is_v is a good idea, (@zmike isnt it possible that the call to render is somehow changing the visible state of the textblock ?)

In D11508#221166, @tasn wrote:

It was added recently (ish) by Daniel Hirt in this commit rEFLb63c3620dff8930f4ad029351c6d455414062c02
It's apparently there to support async layout. I have no idea, I don't know the async layout code at all. Take a look at the commit message though.

fix depends

change the logic at evas_textblock level

update test case to produce the issue

• fix test case

• delete vowel + ZWNJ in single operation

Fix combine vowel with multible consonant

• add harfbuzz workaround again

update

This patch has been there for very long time, can someone provide any kind of feedback ?

This patch has been there for very long time, can someone provide any kind of feedback ?

In D11479#219200, @segfaultxavi wrote:

In D11479#219186, @bu5hm4n wrote:

@segfaultxavi can you add a remark to the docs of Textbox that you need to enable scrolling to be able to call these new APIs ?

Done in e8100fa8.

• remove workaround

@bu5hm4n @segfaultxavi @zmike
Can we close this one, I think this is very important for textbox class

In D11488#219025, @smohanty wrote:

In D11488#219006, @ali.alzyod wrote:

@smohanty @woohyun
Is the purpose of this patch speed ? or is there another issue?

The main issue is functionality broken in the tizen product size .. I didn't investigate all the reasons but one thing is clear as we keep a copy of the style per edje . when text_class changes in file level or global level we just make the file level styles cache dirty (not the edje level cache ). thats why some cases changing the text_classes and color_classes in global level doesn't update the view .

do not pass NULL to strrstr

@smohanty @woohyun
Is the purpose of this patch speed ? or is there another issue?

This patch will be affected too by D11479
wither we will compose scroller object, or make the text-block a doubt the scrollable interface

In D11482#218888, @segfaultxavi wrote:

Can you align the lines properly?
https://www.enlightenment.org/contrib/devs/coding-conventions.md

In D11479#218812, @bu5hm4n wrote:

Mhm, i think it would be better to use composition here. We also should have a "wider" solution for something like this "state depended" composition.

@segfaultxavi Efl.Ui.Textbox internally it uses scroller object, and implementation for this feature is very simple to pass these properties to internal scroller object.

update

I think there are alot of similar cases in the source code

add support for MEDIALs handling

add space

move workaround out of evas_font_query