- User Since
- Nov 27 2018, 12:22 AM (53 w, 6 d)
replace fail_if with ck_assert_ptr_ne
add tests, efl_text_set will emit single Efl.Canvas.Text.Changed event
After some investigation, find out adding text using cursor will not force the efl_canvas_text_event_changed
Also, efl_text_get() on the widgets seems to always return "0".
I could not reproduce this one, it seems to work fine.
Fri, Dec 6
After the double-check, I correct my statement Nobody requested to change legacy code, So this is the caused by this patch.
I will submit new patch to fix this part
I think you may want to check efl_gfx_text_class.eo if it needs updates too (to have the option to override this property at the file and object level)
Thu, Dec 5
@segfaultxavi Thanks a lot for sharing the demo.
I have this example calculator application which I am adapting to these changes in a branch:
- After this patch, I have to manually move the cursor to the end of the line before inserting anything (previously I didn't have to). Is this intended?
This was bug and I fix it, the problem was that efl_text_set was not modify main cursor position, now we move main cursor to the end if we use efl_text_set or efl_text_markup_set.
- I add characters to the Efl.Ui.Textwidget using a cursor and efl_text_cursor_text_insert. However, my _screen_changed_cb is never called, no matter if I connect to EFL_TEXT_INTERACTIVE_EVENT_CHANGED_USER or to EFL_UI_TEXT_EVENT_CHANGED. Is this intended?
This was a bug, Now EFL_UI_TEXT_EVENT_CHANGED will be called for any change in the content.
EFL_TEXT_INTERACTIVE_EVENT_CHANGED_USER will be called only when user change the text (using keyboard or clipboard)
By the way, how does your plan relate to @tasn's ? I admit I didn't thoroughly read his RFC.
@tasn plan does not include future widget design, and also it was effected a lot where a composite class in EFL is not working anymore.
Rename Efl.Canvas.Text into Efl.Canvas.Textblock D10808
Wed, Dec 4
add Efl.Ui.Text into efl_text_basics
rebase + fix cut event
Tue, Dec 3
Efl.Canvas.Text -> Efl.Canvas.Textblock I am fine with this
Efl.Ui.Text -> Efl.Ui.TextField I prefer using name other than textfiled text field gives impression it is single line.
replace selection_start,selection_clear with have_selection event
selection_changed will contain range of selected text index
have_selection_changed will contains boolean indicate if it has selectio(start) or not (clear)
Mon, Dec 2
@bu5hm4n other than SELECTION events for you have other requested changes.
@segfaultxavi Please let me know if any-more changes are required
Sun, Dec 1
close my comments