Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (38 w, 4 d)
Availability
Available

Recent Activity

Thu, Aug 22

ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.
Font f = new Font("Arial",25);
TextBlock t;
Button b;
Label c;
Thu, Aug 22, 3:37 AM · efl: api
ali.alzyod updated subscribers of T8151: RFC: Text interfaces design proposal.
Thu, Aug 22, 3:28 AM · efl: api
ali.alzyod updated subscribers of T8151: RFC: Text interfaces design proposal.
Thu, Aug 22, 3:26 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

I will send you email regard Spans.

Thu, Aug 22, 3:26 AM · efl: api

Wed, Aug 21

ali.alzyod closed T8136: harfbuzz 2.6 breaks text layout as Resolved.
Wed, Aug 21, 11:31 PM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

@tasn How about Break discussion of each task to its own subtask.

Wed, Aug 21, 10:51 PM · efl: api
ali.alzyod added a comment to T8136: harfbuzz 2.6 breaks text layout.

This is fixed from Harfbuzz Side.
https://github.com/harfbuzz/harfbuzz/issues/1910

Wed, Aug 21, 12:47 PM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

This is clear things up, to know that we are based on current existing stuff

Wed, Aug 21, 8:34 AM · efl: api
ali.alzyod added a comment to T8160: Wrong Usage For Callback Forwarder.

This behavior produces incorrect issues on the widget

Wed, Aug 21, 8:11 AM
ali.alzyod updated subscribers of T8160: Wrong Usage For Callback Forwarder.
Wed, Aug 21, 8:08 AM
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

Lets discuss this one first :

interface Efl.Text.Font
Can also be applied to annotations
functions and properties:
@property font

Wed, Aug 21, 7:56 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

@tasn
Again Font should not be interface, Are there font-able objects other than font object?
If my class use font object then he composite inside, not adopt new interface, do you have any example from other platforms ?

Wed, Aug 21, 7:28 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

It's already explained with examples in the original post.

What post ?

Wed, Aug 21, 7:06 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

I think it is best to discuss other parts too, current discussion could be discussed in better way.

Wed, Aug 21, 6:38 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

@tasn This is the example:

Wed, Aug 21, 3:52 AM · efl: api

Tue, Aug 20

ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

@cedric just small thing, If you build without this patch, do you still get error ?

Tue, Aug 20, 10:52 AM · efl
ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

@cedric I think you will get same error, even if you get latest.
the reason is you build latest harfbuzz library, and with it you will get error on evas.
We already raise an issue on Harfbuzz side https://github.com/harfbuzz/harfbuzz/issues/1910

Tue, Aug 20, 8:41 AM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

I mean why we need to attach this funcinality (Create and manipulate markups ) to be part of canvas, why cannot to expose it, and everyone can use it canvas and other objects and users (everyone), Why do we need to hide it in TextBlock

Tue, Aug 20, 7:15 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

+GTK
https://developer.gnome.org/gtk3/stable/GtkTextBuffer.html
(Iterators and Markup are implemented on Markup Object(GtkTextBuffer) level )

Tue, Aug 20, 7:13 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

In my example, why did you assume data is in HTML format, it could be anything andmaybe building it without annoatation could be very hard (you need to do it from scratch).

Tue, Aug 20, 6:33 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

So each user want to create Markuptext should create his own Markup builder ?! I do not think this is not good for user

Tue, Aug 20, 6:14 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

I understand use case as something user can do.

Tue, Aug 20, 5:59 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

simple use case:
I want to create multible markup text in runtime. (for example I got input form user or service) and I want to cache these markup to be used in future.
And I got these values in backthread and create markup text in the backthread

Tue, Aug 20, 4:37 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

Now things are more clear.

Tue, Aug 20, 4:06 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

I do not get the difference between Annotations and Markup Object.
Why do not we make annoations work on Markup Object, instead of working on TextBlock.

Tue, Aug 20, 3:31 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

Yes and no. I'm not going to create it, but it could be created and it would use exactly the same interfaces (so functions) for both the MarkupText object and the Textblock object.

Tue, Aug 20, 1:52 AM · efl: api
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

First lets forget about Documnet and Manager, I think it will complicate things on this stage.

Tue, Aug 20, 1:04 AM · efl: api
ali.alzyod added a comment to D9641: edje/style: optimize style_update function..

This is seems fine to me.
Just simple note if you think it is right (else forget about it), move the if (stl && !stl->readonly) inside the function _edje_textblock_style_member_add

Tue, Aug 20, 12:39 AM · efl
ali.alzyod added inline comments to D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..
Tue, Aug 20, 12:35 AM · efl
ali.alzyod added a comment to D9641: edje/style: optimize style_update function..

If the style is readonly then we know for sure it dosen't have any text_class/color_class.
In edje_textblock_styles.c I do not see check for color_class (only text class)

Tue, Aug 20, 12:11 AM · efl
ali.alzyod added a comment to D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..

and if you are concern about those 2 allocation you can put a patch to check at start of the function to see if styles is empty and return.

Tue, Aug 20, 12:02 AM · efl

Mon, Aug 19

ali.alzyod added a comment to D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..

for example of there are no (edf->styles) then we are doing useless allocation, which is against the Idea of this patch

Mon, Aug 19, 11:10 PM · efl
ali.alzyod added inline comments to D9636: edje/style: refactor style parsing to remove temporary dynamic string creation..
Mon, Aug 19, 11:09 PM · efl
ali.alzyod added a comment to D9053: evas_object_textblock: add support for variation sequences.

@zmike can you please close this one

Mon, Aug 19, 1:54 PM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

The main Idea for efldocument and layoutmanager, is to break textblock into multiple objects, and expose functionality (for future purposes like extending functionality or optimizations)
EflDocument
By Document I mean something similar to :
https://doc.qt.io/qt-5/qtextdocument.html (or like https://developer.apple.com/documentation/appkit/nsdocument if we want to extend it more)
Where this class is responsible for store and parse formatted text, build text-nodes and format-nodes, cursor works on efldocument.

TextBlock internally contains efldocument, and text formatting and cursor functionality are processed by efldocument 
- Suppose user want edit text in background thread, then he does not need textblock, he can work directly on efldocument
- multiple textblock  object can share same efldocument
- efldocument will contains extended functionality to save and load files from Disk and Memory.
Mon, Aug 19, 1:08 PM · efl: api
ali.alzyod added reviewers for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs: woohyun, bowonryu.
Mon, Aug 19, 11:19 AM · efl
ali.alzyod added a comment to T8151: RFC: Text interfaces design proposal.

Hello @tasn, these are most comment I think of right now :

Mon, Aug 19, 9:49 AM · efl: api
ali.alzyod updated the test plan for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 8:25 AM · efl
ali.alzyod updated the summary of D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:45 AM · efl
ali.alzyod updated the test plan for D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:44 AM · efl
ali.alzyod requested review of D9628: elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs.
Mon, Aug 19, 7:42 AM · efl

Sun, Aug 18

ali.alzyod added a comment to T8136: harfbuzz 2.6 breaks text layout.

We create Issue on Harfbuzz:
https://github.com/harfbuzz/harfbuzz/issues/1910

Sun, Aug 18, 6:40 AM · efl

Fri, Aug 16

ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

I still did not get the error, and both harfbuzz and fontconfig are enabled, so I try to rebase

Fri, Aug 16, 2:24 PM · efl
ali.alzyod updated the diff for D9536: evas_textblock: optimize calculate main format form style.

rebase

Fri, Aug 16, 2:22 PM · efl
ali.alzyod added a comment to D9597: efl_ui/text: implement efl.text_format::wrap.

I think single_line and password should be processed same way as textWrap, where these properties founded in both efl_text and efl_ui_text

Fri, Aug 16, 12:47 PM · efl

Thu, Aug 15

ali.alzyod triaged T8117: EFL Document Feature as TODO priority.
Thu, Aug 15, 1:37 AM
ali.alzyod closed T8091: CI test failure as Resolved.
Thu, Aug 15, 1:31 AM · efl

Wed, Aug 14

ali.alzyod added a comment to D9548: evas_object_textblock: add update for missing font_source.

@bowonryu Does the test depends on local environment ? like ("/images/DejaVuSerif.ttf", "/images/NanumGothic.ttf" )

Wed, Aug 14, 8:22 AM · efl
ali.alzyod added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.

Will we rename all canvas objects inside efl.Canvas namespace to have canvas word at the end like (text_canvas, image_canvas, rectangle_canvas, ... etc) ?

Wed, Aug 14, 7:08 AM · efl

Mon, Aug 12

ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

this is weird I did not get any errors in test suite !

Mon, Aug 12, 2:11 PM · efl
ali.alzyod added inline comments to D9547: edje/optimization: keep a style hash for fast retrival of styles.
Mon, Aug 12, 1:08 AM · efl
ali.alzyod added inline comments to D9547: edje/optimization: keep a style hash for fast retrival of styles.
Mon, Aug 12, 12:04 AM · efl

Sat, Aug 10

ali.alzyod updated the test plan for D9536: evas_textblock: optimize calculate main format form style.
Sat, Aug 10, 4:37 AM · efl
ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

I would really appreciate a new test in expedite.

Sat, Aug 10, 4:36 AM · efl
ali.alzyod updated the summary of D9541: evas_textblock: add test for parsing styles time (fill_format).
Sat, Aug 10, 4:35 AM
ali.alzyod added reviewers for D9541: evas_textblock: add test for parsing styles time (fill_format): cedric, woohyun, Hermet, smohanty.
Sat, Aug 10, 4:34 AM
ali.alzyod requested review of D9541: evas_textblock: add test for parsing styles time (fill_format).
Sat, Aug 10, 4:33 AM

Fri, Aug 9

ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

update test plan code

Fri, Aug 9, 3:41 PM · efl
ali.alzyod updated the test plan for D9536: evas_textblock: optimize calculate main format form style.
Fri, Aug 9, 3:38 PM · efl
ali.alzyod added a comment to D9536: evas_textblock: optimize calculate main format form style.

@cedric I did not get exactly what you mean, can you please be clear how to add example in tree(what tree :) )

Fri, Aug 9, 10:27 AM · efl
ali.alzyod added a comment to D9533: evas/textblock: optimize layouting when textblock has empty text.

@smohanty ,
I will take a look at edje parts, but the main issue with edje it has its own logic where it keep set markup_set evas_object_textblock_text_markup_set and for some reason it will force textblock to relayout and create text items. I suspect that the reason set inside Edje logic not the TextBlock, but anyway lets discuss them next week :)

Fri, Aug 9, 6:09 AM · efl
ali.alzyod added reviewers for D9536: evas_textblock: optimize calculate main format form style: smohanty, woohyun, Hermet, bowonryu.
Fri, Aug 9, 5:13 AM · efl
ali.alzyod requested review of D9536: evas_textblock: optimize calculate main format form style.
Fri, Aug 9, 5:08 AM · efl
ali.alzyod added a comment to D9533: evas/textblock: optimize layouting when textblock has empty text.

@smohanty thanks for the example, For me now it is more clear where is the problem.

Fri, Aug 9, 3:41 AM · efl
ali.alzyod added a comment to D9534: evas/textblock: optmize textblock format parsing..

I think we should have some information, and sample code about optimization (time reduction) value.

Well I ran the Vtune Profiler to collect the memory allocation and this one was one of the hotspot.

Test Env: Tizen Mobile
just create a empty window with one button(hello world ). this reformat_line calls 23 times (which means we are parsing the style text 23 times and half of the time the button dosen't have even text).
If you add a genlist to the window the number goes above 2000 and depending on what style text you are using the number of allocation was 16000 (32000 malloc/free).

Fri, Aug 9, 1:25 AM · efl
ali.alzyod added a comment to D9533: evas/textblock: optimize layouting when textblock has empty text.

@ali.alzyod

I think its a issue in Textblock . If the text style hasn't changed then it shouldn't do reformatting the style text. If you need a proof i can create a test case and send it to you which does reformatting although style hasn't changed.
I printed the style text most of the time it was same. and i didn't found any code that checks if style test has changed .. if anything triggers relayouting it just blindly parse the text without checking if the style has changed.
Fri, Aug 9, 1:17 AM · efl

Thu, Aug 8

ali.alzyod added inline comments to D9534: evas/textblock: optmize textblock format parsing..
Thu, Aug 8, 11:30 PM · efl
ali.alzyod added inline comments to D9534: evas/textblock: optmize textblock format parsing..
Thu, Aug 8, 11:16 PM · efl
ali.alzyod added a comment to D9534: evas/textblock: optmize textblock format parsing..

I think we should have some information, and sample code about optimization (time reduction) value.

Thu, Aug 8, 10:56 PM · efl
ali.alzyod added a comment to D9533: evas/textblock: optimize layouting when textblock has empty text.

@ali.alzyod ,

The use case am talking about happens a lot when textblock part is created from edje.  to reproduce the issue create a empty window application and add a button and put some logs in the _format_fill() to see how many times we do reformatting.
Thu, Aug 8, 10:51 PM · efl
ali.alzyod added a comment to D9533: evas/textblock: optimize layouting when textblock has empty text.

Hello @smohanty how are you ?

Thu, Aug 8, 10:25 PM · efl

Wed, Aug 7

ali.alzyod updated the task description for T8117: EFL Document Feature.
Wed, Aug 7, 5:26 AM
ali.alzyod updated the task description for T8117: EFL Document Feature.
Wed, Aug 7, 5:24 AM
ali.alzyod created T8117: EFL Document Feature.
Wed, Aug 7, 5:24 AM
ali.alzyod updated subscribers of T8067: Markup Enrichment/Enhancement.
Wed, Aug 7, 5:21 AM
ali.alzyod updated the diff for D9519: evas_text: backward compatibility for setting text size.

update for legacy only

Wed, Aug 7, 4:29 AM · efl
ali.alzyod added a reviewer for D9519: evas_text: backward compatibility for setting text size: woohyun.
Wed, Aug 7, 3:35 AM · efl
ali.alzyod updated the summary of D9519: evas_text: backward compatibility for setting text size.
Wed, Aug 7, 3:35 AM · efl
ali.alzyod requested review of D9519: evas_text: backward compatibility for setting text size.
Wed, Aug 7, 3:34 AM · efl

Tue, Aug 6

ali.alzyod renamed T8060: Handling Text in Legacy and New Interface from elm_entry Vs efl_ui_text to Handling Text in Legacy and New Interface.
Tue, Aug 6, 3:59 AM

Mon, Aug 5

ali.alzyod added a comment to D9491: evas_convert: implement convert to binary image (1bpp).

@segfaultxavi Why do you think r * 76 causes overflow ?

Because r is a char, or what am, I missing?

Mon, Aug 5, 12:23 PM · efl
ali.alzyod updated the diff for D9491: evas_convert: implement convert to binary image (1bpp).

remove UNUSED for used variables

Mon, Aug 5, 12:34 AM · efl
ali.alzyod added a comment to D9491: evas_convert: implement convert to binary image (1bpp).

Auto testing is hard to implement for this function since no path lead to this function, but we may need to use it in future.

Mon, Aug 5, 12:31 AM · efl
ali.alzyod added a comment to D9491: evas_convert: implement convert to binary image (1bpp).

@segfaultxavi Why do you think r * 76 causes overflow ?

Mon, Aug 5, 12:27 AM · efl

Sun, Aug 4

ali.alzyod added reviewers for D9491: evas_convert: implement convert to binary image (1bpp): cedric, vtorri.
Sun, Aug 4, 10:51 AM · efl
ali.alzyod updated the test plan for D9491: evas_convert: implement convert to binary image (1bpp).
Sun, Aug 4, 10:49 AM · efl
ali.alzyod updated the test plan for D9491: evas_convert: implement convert to binary image (1bpp).
Sun, Aug 4, 10:49 AM · efl
ali.alzyod requested review of D9491: evas_convert: implement convert to binary image (1bpp).
Sun, Aug 4, 10:47 AM · efl
ali.alzyod updated the test plan for D9490: evas_common: rgba32 to Y8.
Sun, Aug 4, 12:53 AM · efl
ali.alzyod updated the summary of D9490: evas_common: rgba32 to Y8.
Sun, Aug 4, 12:50 AM · efl
ali.alzyod added a reviewer for D9490: evas_common: rgba32 to Y8: cedric.
Sun, Aug 4, 12:40 AM · efl
ali.alzyod requested review of D9490: evas_common: rgba32 to Y8.
Sun, Aug 4, 12:40 AM · efl

Sat, Aug 3

ali.alzyod added a comment to D9376: evas_textblock: reduce _evas_textblock_changed calls with markup_text_append.

@cedric this is other hard to add for auto test

Sat, Aug 3, 4:11 AM · efl
ali.alzyod added reviewers for D9489: evas_textblock: markup text: improve handling invalide escape characters: woohyun, segfaultxavi, cedric.
Sat, Aug 3, 2:28 AM · efl
ali.alzyod updated the summary of D9489: evas_textblock: markup text: improve handling invalide escape characters.
Sat, Aug 3, 2:25 AM · efl
ali.alzyod updated the test plan for D9489: evas_textblock: markup text: improve handling invalide escape characters.
Sat, Aug 3, 2:24 AM · efl
ali.alzyod requested review of D9489: evas_textblock: markup text: improve handling invalide escape characters.
Sat, Aug 3, 2:19 AM · efl

Fri, Aug 2

ali.alzyod added a comment to T7873: efl.ui.image.

@cedric Thank you for your comments :) and explanations. And I am sorry if it bother you

Fri, Aug 2, 1:36 PM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T8086: Efl_Color Object/Struct.

@raster I saw the filters, and they are very strong feature, but as name suggest they are filters.
But If user is looking at deeper control for manipulate or process raster image level, the he want to manipulate pixels directly in C.

Fri, Aug 2, 12:11 PM
ali.alzyod added a comment to T7873: efl.ui.image.

@zmike I mean, I can not see abstract class to present Image class, canvas is related to view image. but I think there should be Image class to manipulate and interact directly with image object.

Fri, Aug 2, 12:05 PM · efl: api, efl (efl-1.23), efl: language bindings