♟ ali.alzyod

remove unused if condition

change camel case to underscore

In D12275#234690, @raster wrote:

do you want to add a test in this commit and update it or submit another one after this?

I should close this patch.

@netstar After looking into elementry_test and go to Entry4
It seems working fine with Selection and Scroll.

In D12248#234281, @devilhorns wrote:

Reject right now because I Believe this to be Approved by Spam ....

Until further discussion, this....needs to sit....

@netstar Do you have a simple demo to show the issue?

I am not an expert but this seems to be right

Is it ok to close this one ?

This seems fine to me

Enhance solution, by preventing text fitting all together if there are no text (even in initial state)

update to use text_nodes instead of paragraphs

D12145 should fix this issue

This is an old issue:

How can we produce this issue ?

remove unneeded events from legacy object

This patch already update unibreak D11743, It also update some internal stuff in EFL to not break compatibility

Things seems better with this change.

In D12117#231640, @devilhorns wrote:

I Agree With the Idea of this patch ... BUT when you're variables are spelled wrong, then I cannot trust it...Please fix the spelling issues....

From what I understand from the source code, the user can not specify padding directly, it is calculated automatically depending on Style Effects (shadow, Glow, ... etc).
These effects will change text size, so I think it should be counted when calculating text size in both native and formatted size.

/**
 * @brief The formatted width and height.
 *
 * This calculates the actual size after restricting the textblock to the
 * current size of the object.
 *
 * The main difference between this and
 * @ref evas_object_textblock_size_native_get is that the "native" function
 * does not wrapping into account it just calculates the real width of the
 * object if it was placed on an infinite canvas, while this function gives the
 * size after wrapping according to the size restrictions of the object.
 *
 * For example for a textblock containing the text: "You shall not pass!" with
 * no margins or padding and assuming a monospace font and a size of 7x10 char
 * widths (for simplicity) has a native size of 19x1 and a formatted size of
 * 5x4.
 *
 * @param[in] obj The object.
 * @param[out] width The width of the object.
 * @param[out] height The height of the object.
 *
 * @since 1.18
 *
 * @ingroup Evas_Object_Textblock_Group
 */
EAPI void evas_object_textblock_size_formatted_get(const Efl_Canvas_Textblock *obj, int *width, int *height);

Sure there are issue here, but what is the right behaviour to resolve it.

Ninja test is failing

add missing condition

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position

Can you please check comments

ali.alzyod (Ali Alzyod)User

Projects

Calendar

Today

Tomorrow

Monday

User Details

Recent ActivityView All

Sun, Sep 26

Aug 30 2021

Aug 21 2021

Aug 14 2021

May 21 2021

May 20 2021

Apr 9 2021

Apr 7 2021

Mar 13 2021

Mar 12 2021

Mar 11 2021

Mar 7 2021

Feb 16 2021

Feb 15 2021

Feb 13 2021

Jan 29 2021

Jan 28 2021

Dec 14 2020

Dec 13 2020

Nov 25 2020

Nov 19 2020

Nov 18 2020

Nov 11 2020

Oct 21 2020

Oct 20 2020

Sep 23 2020

Sep 14 2020

Sep 10 2020

Sep 6 2020

Sep 4 2020

Sep 1 2020

Aug 30 2020

Aug 26 2020

Aug 25 2020

Aug 24 2020

Aug 17 2020

Aug 16 2020

Aug 10 2020

Aug 9 2020

Aug 5 2020

ali.alzyod (Ali Alzyod)
User

Recent Activity
View All