Page MenuHomePhabricator

ali.alzyod (Ali Alzyod)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Nov 27 2018, 12:22 AM (138 w, 5 d)
Availability
Available

Recent Activity

May 21 2021

ali.alzyod updated the diff for D12275: TextBlock: Fix content Fit with Markup-font-size.

Add test

May 21 2021, 2:29 PM · efl
ali.alzyod added a comment to D12275: TextBlock: Fix content Fit with Markup-font-size.

do you want to add a test in this commit and update it or submit another one after this?

May 21 2021, 5:44 AM · efl

May 20 2021

ali.alzyod updated the summary of D12275: TextBlock: Fix content Fit with Markup-font-size.
May 20 2021, 3:43 PM · efl
ali.alzyod requested review of D12275: TextBlock: Fix content Fit with Markup-font-size.
May 20 2021, 3:42 PM · efl

Apr 9 2021

ali.alzyod added reviewers for D12256: Update HOWTO Build section: raster, netstar.
Apr 9 2021, 10:11 AM
ali.alzyod requested review of D12256: Update HOWTO Build section.
Apr 9 2021, 10:10 AM

Apr 7 2021

ali.alzyod added a comment to D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS..

I should close this patch.

Apr 7 2021, 11:38 AM · efl

Mar 13 2021

ali.alzyod added a comment to T8906: entry: selection issue.

@netstar After looking into elementry_test and go to Entry4
It seems working fine with Selection and Scroll.

Mar 13 2021, 10:51 AM · efl

Mar 12 2021

ali.alzyod closed T8907: iPad Repair Screen Chicago-Skip Repairs as Invalid.
Mar 12 2021, 12:31 AM

Mar 11 2021

ali.alzyod added a comment to D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS..

Reject right now because I Believe this to be Approved by Spam ....

Until further discussion, this....needs to sit....

Mar 11 2021, 7:07 PM · efl
ali.alzyod requested review of D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS..
Mar 11 2021, 7:04 PM · efl
devilhorns awarded D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS. a Dislike token.
Mar 11 2021, 6:34 PM · efl

Mar 7 2021

ali.alzyod added a comment to T8906: entry: selection issue.

@netstar Do you have a simple demo to show the issue?

Mar 7 2021, 12:59 AM · efl

Feb 16 2021

ali.alzyod accepted D12249: eeze: fix a potention memory leak.

I am not an expert but this seems to be right

Feb 16 2021, 2:51 AM · efl

Feb 15 2021

ali.alzyod added reviewers for D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS.: woohyun, bowonryu, id213sin, AbdullehGhujeh.
Feb 15 2021, 2:00 PM · efl

Feb 13 2021

ali.alzyod requested review of D12248: evas_textblock: update color text parsingUpdate text color parsing for rgba(r, g, b, a) for alpha to be value between 0.0 - 1.0 same as CSS..
Feb 13 2021, 5:30 AM · efl

Jan 29 2021

ali.alzyod closed D11949: efl_ui_textpath: mathmatical calculations.
Jan 29 2021, 2:18 AM · efl

Jan 28 2021

ali.alzyod closed D12211: evas_textblock: allow default font size to be set without fontname.
Jan 28 2021, 11:19 PM · efl

Dec 14 2020

ali.alzyod added a comment to D11949: efl_ui_textpath: mathmatical calculations.

Is it ok to close this one ?

Dec 14 2020, 8:46 PM · efl
ali.alzyod added reviewers for D12211: evas_textblock: allow default font size to be set without fontname: woohyun, bowonryu, id213sin.
Dec 14 2020, 8:41 PM · efl

Dec 13 2020

ali.alzyod updated the diff for D12211: evas_textblock: allow default font size to be set without fontname.

update test

Dec 13 2020, 11:23 PM · efl
ali.alzyod requested review of D12211: evas_textblock: allow default font size to be set without fontname.
Dec 13 2020, 11:21 PM · efl

Nov 25 2020

ali.alzyod updated the diff for D12198: test_suite: efl_ui_test_text replace ecore_main_loop_iterate with timers.

clean some lines

Nov 25 2020, 10:58 PM · efl
ali.alzyod added reviewers for D12198: test_suite: efl_ui_test_text replace ecore_main_loop_iterate with timers: raster, bu5hm4n, woohyun.
Nov 25 2020, 10:56 PM · efl
ali.alzyod requested review of D12198: test_suite: efl_ui_test_text replace ecore_main_loop_iterate with timers.
Nov 25 2020, 10:55 PM · efl
ali.alzyod added reviewers for D12099: evas_textblock : Enhance new line as paragraph separator functionality: woohyun, bowonryu, id213sin.
Nov 25 2020, 9:02 AM · efl
ali.alzyod added inline comments to D12099: evas_textblock : Enhance new line as paragraph separator functionality.
Nov 25 2020, 9:02 AM · efl
ali.alzyod accepted D12133: evas_textblock : Handle cursor correctly when inserting ps.

This seems fine to me

Nov 25 2020, 8:56 AM · efl
ali.alzyod added reviewers for D12133: evas_textblock : Handle cursor correctly when inserting ps: woohyun, bowonryu, id213sin.
Nov 25 2020, 8:41 AM · efl

Nov 19 2020

ali.alzyod closed D12187: evas_textblock: reduce content fit calculations.
Nov 19 2020, 12:51 AM · efl

Nov 18 2020

ali.alzyod closed D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Nov 18 2020, 6:04 AM · efl

Nov 11 2020

ali.alzyod updated the diff for D12187: evas_textblock: reduce content fit calculations.

Enhance solution, by preventing text fitting all together if there are no text (even in initial state)

Nov 11 2020, 11:29 AM · efl
ali.alzyod updated the diff for D12187: evas_textblock: reduce content fit calculations.

update to use text_nodes instead of paragraphs

Nov 11 2020, 2:25 AM · efl
ali.alzyod added reviewers for D12187: evas_textblock: reduce content fit calculations: woohyun, id213sin.
Nov 11 2020, 1:22 AM · efl
ali.alzyod requested review of D12187: evas_textblock: reduce content fit calculations.
Nov 11 2020, 1:21 AM · efl

Oct 21 2020

ali.alzyod accepted D12183: evas/textblock: apply style paddings in fit calculation.

This is right

Oct 21 2020, 8:47 PM · efl

Oct 20 2020

ali.alzyod closed T8663: Entry & UI Text : Fixing Cursor movement with Emoji for text as Resolved.
Oct 20 2020, 3:46 AM · efl
ali.alzyod updated the diff for D11745: efl.ui.text : Fixing cursor movement using keyboard arrows/mouse click.

rebase

Oct 20 2020, 3:18 AM · efl

Sep 23 2020

ali.alzyod reopened D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Sep 23 2020, 6:26 AM · efl
ali.alzyod closed D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Sep 23 2020, 3:30 AM · efl

Sep 14 2020

ali.alzyod added reviewers for D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node: raster, woohyun, netstar.
Sep 14 2020, 9:31 AM · efl
ali.alzyod updated the diff for D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.

add test case

Sep 14 2020, 9:30 AM · efl
ali.alzyod added a comment to T8809: evas_object_textblock / elm_entry - line merge up junk characters..

D12145 should fix this issue

Sep 14 2020, 7:48 AM · efl
ali.alzyod added a task to D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node: T8809: evas_object_textblock / elm_entry - line merge up junk characters..
Sep 14 2020, 7:48 AM · efl
ali.alzyod added a revision to T8809: evas_object_textblock / elm_entry - line merge up junk characters.: D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Sep 14 2020, 7:48 AM · efl
ali.alzyod requested review of D12145: evas_textblock: prevent textnodes with <ps>/<br> without format node.
Sep 14 2020, 7:47 AM · efl
ali.alzyod added a comment to T8809: evas_object_textblock / elm_entry - line merge up junk characters..

This is an old issue:

Sep 14 2020, 12:14 AM · efl

Sep 10 2020

ali.alzyod added inline comments to D12133: evas_textblock : Handle cursor correctly when inserting ps.
Sep 10 2020, 2:13 AM · efl
ali.alzyod accepted D12130: evas_textblock: Add check for NULL pointers after malloc.

seems fine to me

Sep 10 2020, 1:27 AM · efl
ali.alzyod added reviewers for D12130: evas_textblock: Add check for NULL pointers after malloc: AbdullehGhujeh, woohyun, bowonryu.
Sep 10 2020, 1:27 AM · efl

Sep 6 2020

ali.alzyod added inline comments to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.
Sep 6 2020, 9:43 AM · efl
ali.alzyod added a comment to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.

How can we produce this issue ?

Sep 6 2020, 9:42 AM · efl
ali.alzyod added inline comments to D12133: evas_textblock : Handle cursor correctly when inserting ps.
Sep 6 2020, 9:42 AM · efl
ali.alzyod added inline comments to D12130: evas_textblock: Add check for NULL pointers after malloc.
Sep 6 2020, 8:24 AM · efl

Sep 4 2020

ali.alzyod added inline comments to D12131: evas/textblock: fix a memory issue caused by a freed ellipsis item.
Sep 4 2020, 9:13 AM · efl

Sep 1 2020

ali.alzyod updated the diff for D12126: elm_entry: legacy smart selection[start,cleared] callback fix.

remove unneeded events from legacy object

Sep 1 2020, 9:42 AM · efl
ali.alzyod added reviewers for D12126: elm_entry: legacy smart selection[start,cleared] callback fix: woohyun, bowonryu.
Sep 1 2020, 9:31 AM · efl
ali.alzyod requested review of D12126: elm_entry: legacy smart selection[start,cleared] callback fix.
Sep 1 2020, 9:30 AM · efl
ali.alzyod accepted D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).
Sep 1 2020, 3:25 AM · efl
ali.alzyod retitled D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2) from evas_textblock: rainbow flag emoji treated as two clusters(update unibreak) to evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).
Sep 1 2020, 3:17 AM · efl
ali.alzyod added a comment to D12124: update libunibreak to 4.3.

This patch already update unibreak D11743, It also update some internal stuff in EFL to not break compatibility

Sep 1 2020, 1:12 AM · efl
ali.alzyod accepted D12110: evas_textblock: remove style padding from native width and formatted height.

Things seems better with this change.

Sep 1 2020, 1:09 AM · efl
ali.alzyod requested changes to D11743: evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2).

Needs Rebase

Sep 1 2020, 12:51 AM · efl

Aug 30 2020

ali.alzyod closed T8737: Glyph cache garbage collector which collect during rendering as Resolved.
Aug 30 2020, 3:48 AM · efl
ali.alzyod closed T8737: Glyph cache garbage collector which collect during rendering, a subtask of T8710: Memory Optimization for Text in EFL, as Resolved.
Aug 30 2020, 3:48 AM · efl

Aug 26 2020

ali.alzyod added a comment to D12117: elm_config: rescale is needed when font or font size is changed.

I Agree With the Idea of this patch ... BUT when you're variables are spelled wrong, then I cannot trust it...Please fix the spelling issues....

Aug 26 2020, 11:28 PM · efl
ali.alzyod raised the priority of T8792: textblock : Handle cursors correctly when inserting ps from TODO to Normal.
Aug 26 2020, 4:39 AM · efl

Aug 25 2020

ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.

From what I understand from the source code, the user can not specify padding directly, it is calculated automatically depending on Style Effects (shadow, Glow, ... etc).
These effects will change text size, so I think it should be counted when calculating text size in both native and formatted size.

Aug 25 2020, 4:18 AM · efl
ali.alzyod closed D12116: evas_font_query: add Use parentheses within macros.
Aug 25 2020, 3:40 AM · efl
ali.alzyod added a reviewer for D12116: evas_font_query: add Use parentheses within macros: bu5hm4n.
Aug 25 2020, 3:15 AM · efl
ali.alzyod requested review of D12116: evas_font_query: add Use parentheses within macros.
Aug 25 2020, 3:15 AM · efl

Aug 24 2020

ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.
/**
 * @brief The formatted width and height.
 *
 * This calculates the actual size after restricting the textblock to the
 * current size of the object.
 *
 * The main difference between this and
 * @ref evas_object_textblock_size_native_get is that the "native" function
 * does not wrapping into account it just calculates the real width of the
 * object if it was placed on an infinite canvas, while this function gives the
 * size after wrapping according to the size restrictions of the object.
 *
 * For example for a textblock containing the text: "You shall not pass!" with
 * no margins or padding and assuming a monospace font and a size of 7x10 char
 * widths (for simplicity) has a native size of 19x1 and a formatted size of
 * 5x4.
 *
 * @param[in] obj The object.
 * @param[out] width The width of the object.
 * @param[out] height The height of the object.
 *
 * @since 1.18
 *
 * @ingroup Evas_Object_Textblock_Group
 */
EAPI void evas_object_textblock_size_formatted_get(const Efl_Canvas_Textblock *obj, int *width, int *height);
Aug 24 2020, 3:21 AM · efl
ali.alzyod added a comment to D12110: evas_textblock: remove style padding from native width and formatted height.

Sure there are issue here, but what is the right behaviour to resolve it.

Aug 24 2020, 12:51 AM · efl

Aug 17 2020

ali.alzyod accepted D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).
Aug 17 2020, 10:55 PM · efl

Aug 16 2020

ali.alzyod requested changes to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

Ninja test is failing

Aug 16 2020, 11:10 PM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

add missing condition

Aug 16 2020, 6:23 AM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
  • rebase
Aug 16 2020, 3:40 AM · efl

Aug 10 2020

ali.alzyod added reviewers for D12102: evas_textblock: myanmar script rendering with e vowel.: woohyun, bowonryu.
Aug 10 2020, 6:52 AM · efl
ali.alzyod requested review of D12102: evas_textblock: myanmar script rendering with e vowel..
Aug 10 2020, 6:52 AM · efl
ali.alzyod updated subscribers of T8787: Segmentation Fault by ecore_main_loop_iterate.
Aug 10 2020, 12:57 AM · efl (efl-1.24)
ali.alzyod requested changes to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

needs rebase

Aug 10 2020, 12:16 AM · efl

Aug 9 2020

ali.alzyod added a comment to D12099: evas_textblock : Enhance new line as paragraph separator functionality.

Should we update all cursors in textblock? I just try to use this with TextBox and notice the cursor is not in the right position

Aug 9 2020, 11:50 PM · efl
ali.alzyod requested changes to D12099: evas_textblock : Enhance new line as paragraph separator functionality.
Aug 9 2020, 11:50 PM · efl
ali.alzyod triaged T8787: Segmentation Fault by ecore_main_loop_iterate as Normal priority.
Aug 9 2020, 11:47 PM · efl (efl-1.24)
ali.alzyod added a comment to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).

Can you please check comments

Aug 9 2020, 10:59 PM · efl
ali.alzyod added inline comments to D11078: Efl Canvas Text : canvas textblock changed not fired for shadow format (style_apply).
Aug 9 2020, 10:59 PM · efl
ali.alzyod added reviewers for D12100: evas: support garbage collector for glyphs bitmap in RAM: raster, woohyun, cedric.
Aug 9 2020, 10:54 PM · efl
ali.alzyod updated the summary of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:33 AM · efl
ali.alzyod updated the summary of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:32 AM · efl
ali.alzyod updated the test plan for D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:31 AM · efl
ali.alzyod requested review of D12100: evas: support garbage collector for glyphs bitmap in RAM.
Aug 9 2020, 8:19 AM · efl

Aug 5 2020

ali.alzyod added inline comments to D12087: edje_entry: fix a potentional error of null deref.
Aug 5 2020, 11:00 PM · efl

Aug 4 2020

ali.alzyod abandoned D8603: Change Single Line Mode behaviour in Entry.

since EDC does not respect Multiline property in TEXTBLOCK object, this will break compatibility

Aug 4 2020, 5:28 AM · efl
ali.alzyod added reviewers for D11947: efl: reduce PI calculations: vtorri, bu5hm4n.
Aug 4 2020, 2:04 AM · efl
ali.alzyod updated the diff for D11947: efl: reduce PI calculations.

update

Aug 4 2020, 2:03 AM · efl
ali.alzyod updated the diff for D11775: evas_textblock: enhance cursor event submitting during markup_set/text_set.

rebase

Aug 4 2020, 1:34 AM · efl
ali.alzyod added inline comments to D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 1:25 AM · efl
ali.alzyod added a comment to D11947: efl: reduce PI calculations.

I updated testing sample code with -O3 optimization to show the speed up.

Aug 4 2020, 1:23 AM · efl
ali.alzyod requested review of D11947: efl: reduce PI calculations.
Aug 4 2020, 1:22 AM · efl
ali.alzyod updated the test plan for D11947: efl: reduce PI calculations.
Aug 4 2020, 1:22 AM · efl