barbieri (Gustavo Sverzut Barbieri)Administrator
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2013, 11:44 AM (277 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

barbieri added inline comments to D6168: ecore_con : Fix class check to check inner_socket class.
Sat, May 19, 8:29 AM · efl

Thu, Apr 26

barbieri added a comment to T6875: potential resource leak..

so it's indeed a false positive, line 70:

Thu, Apr 26, 6:34 AM · efl

Apr 9 2018

barbieri added a comment to T6875: potential resource leak..

to me looks like a false positive, paste the coverity error or link to the report?

Apr 9 2018, 6:49 AM · efl

Mar 11 2018

barbieri added a comment to T6738: Resolved future can not be converted to Eina_Value.

ohh... then it makes more sense.

Mar 11 2018, 3:39 PM · efl

Mar 9 2018

barbieri added a comment to T6738: Resolved future can not be converted to Eina_Value.

Cedric, could you confirm that eina_future_as_value() IS returning something valid (ie: non-EINA_VALUE_EMPTY?

Mar 9 2018, 3:28 PM · efl
barbieri added a comment to T6738: Resolved future can not be converted to Eina_Value.

Hi Cedric,

Mar 9 2018, 4:02 AM · efl

Mar 5 2018

barbieri added a comment to T6738: Resolved future can not be converted to Eina_Value.

could you provide a .c and a call log so I can try to see what's happening? To me I don't see how "it's too late", _eina_promise_unlink(p) just isolates it, but you get the scheduler as the first parameter of _value_steal_and_link(), alongside with the value (which contains the other/child promise) and the future... so all the information should be there.

Mar 5 2018, 11:52 AM · efl
barbieri added a comment to T6738: Resolved future can not be converted to Eina_Value.

Hi Cedric,

Mar 5 2018, 6:19 AM · efl

Jan 22 2018

barbieri added a comment to T6514: fix eolian function redefine errors.

why not demote efl_name, since it's mostly for debug/tracking purposes.

Jan 22 2018, 4:25 AM · Restricted Project, efl

Jan 19 2018

barbieri added a comment to T6514: fix eolian function redefine errors.

interesting, what's the expectation about name?

Jan 19 2018, 5:12 AM · Restricted Project, efl

Jan 6 2018

barbieri added a comment to T5522: EO: Ecore API.

as said in IRC, I disagree but as I'm not doing any work on this... I'm shut up and stop bugging about this, IMO, messy design.

Jan 6 2018, 6:18 AM · Restricted Project, efl

Jan 5 2018

barbieri added a comment to T5522: EO: Ecore API.

my takes on this:

Jan 5 2018, 5:42 AM · Restricted Project, efl

Nov 21 2017

barbieri added a comment to T6394: Refactor Ecore.Exe to EFL.Exe.

whenever doing this, *PLEASE* use Efl.Io interfaces, so it's similar everywhere (ie: API will be mostly the same as the one for Efl.Net), namely Efl.Io.Reader, Efl.Io.Closer and the likes. For UNIX, you can benefit from Efl.Io.Reader.Fd and similar, not sure how is that on Windows.

Nov 21 2017, 9:41 AM · efl

Nov 17 2017

barbieri added a comment to T6204: format function cb overhaul .

I agree with jpeg. The mixin is a nice place to scan the format string and validate it against the given value type. While printf format are not that simple nowadays, it's something doable in short time.

Nov 17 2017, 7:52 AM · Restricted Project, efl

Nov 6 2017

barbieri added a comment to T6330: ecore-con now leaks fds.

do you know if the objects get deleted?

Nov 6 2017, 4:28 PM · efl

Oct 28 2017

barbieri added a comment to T6262: Refactor EFL_MAIN* and efl_exit* from elm into efl.

i really dislike this kind of approach... IMO efl_main should be in the core lib and headers.

Oct 28 2017, 11:53 AM · Restricted Project, efl

Oct 25 2017

barbieri added a comment to T6204: format function cb overhaul .

hi... the last commit rEFL8661fe234c7e doesn't seem to address my comments... still not passing the format_string to the callback and not handling other types of eina value, just assumes it's a double. Add the runtime type check to avoid bugs to pass unnoticed.

Oct 25 2017, 6:11 AM · Restricted Project, efl
barbieri added a comment to T6262: Refactor EFL_MAIN* and efl_exit* from elm into efl.

either use efl.loop or efl.core... but efl.ui is not an option.

Oct 25 2017, 6:06 AM · Restricted Project, efl

Oct 19 2017

barbieri added a comment to V30: Should the --enable-i-really-know-what-i-am-doing-and.... be removed from efl configure?.

https://git.enlightenment.org/core/enlightenment.git/tree/src/bin/e_main.c#n1214 defines -i-really-know-what-i-am-doing-and-accept-full-responsibility-for-it to set really_know = 1:

Oct 19 2017, 10:38 AM · efl
barbieri added a comment to V30: Should the --enable-i-really-know-what-i-am-doing-and.... be removed from efl configure?.

for the record, the one in Enlightenment to disable some stupid checks could be removed as well.

Oct 19 2017, 10:29 AM · efl

Oct 16 2017

barbieri added a comment to T6204: format function cb overhaul .

ah, last but not least, the implementation of the default format_func should be something like:

Oct 16 2017, 5:58 AM · Restricted Project, efl
barbieri added a comment to T6204: format function cb overhaul .

just did a review on the ML about this patch, my suggestions:

  • naming: use format_cb (or format_func) and format_template for properties names;
  • pass format_template to format_cb function.
  • for format_cb implementation, always check eina_value_type_get() for the expected type! Don't assume it's what you want and blindly eina_value_get()... in case of mistakes/errors, it will likely lead to stack corruption which is a PAIN to find and solve... so it's a simple if to help debugging.
Oct 16 2017, 5:52 AM · Restricted Project, efl

Oct 10 2017

barbieri edited the content of Future & Promise.
Oct 10 2017, 11:04 AM · efl

Sep 11 2017

barbieri closed T5149: Promise problem as Resolved.

promise/future was rewritten and this bug is gone.

Sep 11 2017, 12:27 PM · efl

Sep 4 2017

barbieri added a comment to T5966: eina_mempool_from invalid memory read..

as reported by T5981

Sep 4 2017, 2:56 PM · efl
barbieri closed T5310: Fix efl_futur as Resolved.

New implementation by @iscaro landed with 5bd8c9a78d7bc21a956b775fb250e8e14711d5b9

Sep 4 2017, 9:13 AM · Restricted Project, efl
barbieri added a comment to T5119: efl-net valgrind errors.

Hi, the reworked future/promise landed today and looks like it fix this issue. Could you take a look with recent GIT (post de4825a274e81dc3035c70b38c3086b6446cba19)

Sep 4 2017, 9:12 AM · efl
barbieri accepted D5131: Add new Future/Promise API..

merged in master after cedric fixed the mempool from...

Sep 4 2017, 9:08 AM
barbieri awarded D5131: Add new Future/Promise API. a Love token.
Sep 4 2017, 9:08 AM

Sep 1 2017

barbieri triaged T5966: eina_mempool_from invalid memory read. as High priority.
Sep 1 2017, 4:29 AM · efl
barbieri added a comment to T5966: eina_mempool_from invalid memory read..

blocking the merge of new eina future branch (D5131), since @iscaro already converted Efl.Io.Copier and Efl.Net to use it and that's when we noticed the problem :-/

Sep 1 2017, 4:28 AM · efl

Aug 30 2017

barbieri added a comment to D5134: Coroutines.

@raster, it's not what you thought... it's much more like what's done with ecore_main_loop_thread_safe_call_sync(), however it's simpler as you can see below:

Aug 30 2017, 5:34 AM · efl

Aug 29 2017

barbieri added a comment to D5134: Coroutines.

as for "await" in other languages, if they are all based on a future (as in JavaScript), then yes. The logic is pretty, pretty simple:

Aug 29 2017, 5:55 PM · efl
barbieri added a comment to D5134: Coroutines.

@cedric maybe you overlooked it based on the _await() which is very minimalist. Take the complex_chain from Future & Promise, it would look much simpler as you can see:

Aug 29 2017, 5:43 PM · efl

Aug 27 2017

barbieri added a comment to D5134: Coroutines.

also note that eina_thread_create() doesn't allow us to provide a stack size, so on Linux it's 2MB per thread -- quite a lot. If we create a new eina primitive, even if an internal primitive to set attributes then we could easily reduce the overhead... most coroutines should run under 16-32kb.

Aug 27 2017, 8:57 AM · efl
barbieri added a comment to D5134: Coroutines.

This could help T5301

Aug 27 2017, 8:50 AM · efl
barbieri added a comment to T5583: [Experiment] Function pointers in EO.

And we could generate the code using structs, details at https://sourceforge.net/p/enlightenment/mailman/enlightenment-devel/thread/CANkykrD_hC5vw3n6QRfzWNmu8OEiwhAZ05Wpj4UNYMAXCuS4jw%40mail.gmail.com/#msg36013936

Aug 27 2017, 8:47 AM · efl
barbieri added a comment to T5583: [Experiment] Function pointers in EO.

The current implementation in GIT expects the documentation at an unusual place. While I'd expect this to work:

Aug 27 2017, 8:45 AM · efl
barbieri created D5134: Coroutines.
Aug 27 2017, 8:40 AM · efl
barbieri requested changes to D5131: Add new Future/Promise API..

found some issues, fixes at https://git.enlightenment.org/core/efl.git/log/?h=devs/barbieri/future

Aug 27 2017, 8:22 AM

Aug 26 2017

barbieri edited the content of Future & Promise.
Aug 26 2017, 5:45 AM · efl
barbieri edited the content of Future & Promise.
Aug 26 2017, 5:42 AM · efl

Aug 25 2017

barbieri accepted D5131: Add new Future/Promise API..

I've reviewed this PR with @iscaro, looks very good to me after more than 10 interactions we reached a point we're very satisfied with safety, simplicity and overall implementation.

Aug 25 2017, 6:44 PM
barbieri edited the content of Future & Promise.
Aug 25 2017, 6:43 PM · efl

Aug 23 2017

barbieri edited the content of Future & Promise.
Aug 23 2017, 3:12 PM · efl

Aug 17 2017

barbieri edited the content of Future & Promise.
Aug 17 2017, 10:21 AM · efl
barbieri created Future & Promise.
Aug 17 2017, 10:07 AM · efl

Aug 14 2017

barbieri added a comment to D4357: ecore_con: fix compilation on Windows.

i guess it's not needed anymore

Aug 14 2017, 12:10 PM

Aug 2 2017

barbieri accepted D5064: Fixes for T5234..

looks good to me

Aug 2 2017, 1:48 PM

Jul 27 2017

barbieri added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

thanks @iscaro and @stefan_schmidt

Jul 27 2017, 8:31 AM · efl

Jul 25 2017

barbieri added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

many thanks, I was looking into ecore_con_server_add() from ecore_con_legacy.c... from your bt it shows ecore_ipc_server_add() which does no close_on_exec... clearly a bug. Prior to efl_net_server_serve() we must have a block like in ecore_con_legacy.c:

Jul 25 2017, 5:20 PM · efl
barbieri added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

still no time to test/debug, but an inspection of the source says the logic should be correct. Could you check the logs for ERR messages? What about DBG messages in ecore-con?

Jul 25 2017, 4:00 PM · efl
barbieri added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

I had some minutes to check and the legacy API had no such flag, so indeed the legacy API must set close_on_exec to true regardless of the default.

Jul 25 2017, 3:45 PM · efl

Jul 21 2017

barbieri added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

I can't check right now, but AFAIR the ecore con/ipc had a flag to set cloexec and would reflect to efl_net

Jul 21 2017, 4:30 AM · efl

Jul 10 2017

barbieri added a comment to T5583: [Experiment] Function pointers in EO.

@felipealmeida void *data is what? how to automatically notify it's not used and can be destroyed, what's in it? etc.

Jul 10 2017, 6:15 PM · efl
barbieri added a comment to T5119: efl-net valgrind errors.

@cedric, how is the rewrite/rework of the promise/future? I'm not following git that closely, but seems no work to make it usable and race free... if we want to push users to this new pattern, it must work reliably AND must be easy to work with (like in JS, where it's almost transparent...)

Jul 10 2017, 7:00 AM · efl

Jun 16 2017

barbieri added a comment to T5567: Simple factories (with or without model).
In T5567#89097, @cedric wrote:
In T5567#89083, @cedric wrote:

Felipe, I believe that this is good, just make it a standard format and usable in general not just for menus, but any structure. Example:

Efl_Model *model = efl_model_from_json("[{'label': 'File', 'icon': 'file'}, ....]");

Efl_Model *model = efl_model_from_xml("<item label='File' icon='file'/>....");

Efl_Model *model = efl_model_from_yaml(
" - label: File\n"
"   icon: file\n"
"...");

IOW all that matters is the structure, they have children, each with some properties. All of these helpers could take schemas to further validade and use proper types, otherwise just fallback to strings and use eina_value conversions when something else is desired.

I am not a fan of this solution either as it has no type checking

read the part I said about schema, all of these guys have associated schemas that provide type and structue checking... and these will be used anyway, at least if we want models, those are already the most common formats as well as from SQL... recall REST uses XML or JSON, GraphQL uses JSON...

We are talking about menu and toolbar here, right ? Is it a real normal use case to get this populated from a GraphQL, XML or whatever ? If we are talking about MVVM in general, I do agree, but that is a different discussion. Here the discussion is how to make data model easy to use in the scenario of toolbar and menu becoming a view of it.

Jun 16 2017, 12:03 PM · Restricted Project, efl
barbieri added a comment to T5567: Simple factories (with or without model).
In T5567#89086, @cedric wrote:

I don't think we can do va_args, but we can do arrays I guess. In C, we could have some helpers for that. With the eo function being :

menu = efl_model_array_properties_new(container, EFL_MODEL_ARRAY("label", EFL_MODEL_STRING("File"), "icon", EFL_MODEL_STRING("file"));

And the helper macro being :

menu = efl_model_properties_new(container, "label", EFL_MODEL_STRING("File"), "icon", EFL_MODEL_STRING("file"));
Jun 16 2017, 11:53 AM · Restricted Project, efl
barbieri added a comment to T5567: Simple factories (with or without model).
In T5567#89083, @cedric wrote:

Felipe, I believe that this is good, just make it a standard format and usable in general not just for menus, but any structure. Example:

Efl_Model *model = efl_model_from_json("[{'label': 'File', 'icon': 'file'}, ....]");

Efl_Model *model = efl_model_from_xml("<item label='File' icon='file'/>....");

Efl_Model *model = efl_model_from_yaml(
" - label: File\n"
"   icon: file\n"
"...");

IOW all that matters is the structure, they have children, each with some properties. All of these helpers could take schemas to further validade and use proper types, otherwise just fallback to strings and use eina_value conversions when something else is desired.

I am not a fan of this solution either as it has no type checking

Jun 16 2017, 11:00 AM · Restricted Project, efl
barbieri added a comment to T5567: Simple factories (with or without model).

dude, this is a problem with helpers, not with model. Of course you can create a function that does that, like specifically for menus/toolbars:

Jun 16 2017, 10:52 AM · Restricted Project, efl
barbieri added a comment to T5577: Support easy object instantiation with Edje External.

Raster, your security concerns are really valid and worth enforcing.

Jun 16 2017, 7:37 AM · efl, Restricted Project
barbieri added a comment to T5567: Simple factories (with or without model).

Felipe, I believe that this is good, just make it a standard format and usable in general not just for menus, but any structure. Example:

Jun 16 2017, 7:12 AM · Restricted Project, efl

Jun 15 2017

barbieri added a comment to T5567: Simple factories (with or without model).

In my mind toolbar, menu or list should be the same like this:

Jun 15 2017, 9:26 PM · Restricted Project, efl
barbieri added a comment to T5567: Simple factories (with or without model).

Function pointers will work. There's absolutely no problem at all with lifetime in the developed version. The method gets three parameters in the place of a function pointer: The function pointer itself, a void* private data, a function pointer to free the void* private data. That is all that is needed.

Jun 15 2017, 3:07 PM · Restricted Project, efl
barbieri added a comment to T5577: Support easy object instantiation with Edje External.

Cedric, the extra cost I dare to bet it's not extra, it's less as it's central and basically walk an array doing strcpy() x explicitly declared chain of strcpy(). Everything else is the same, you must parse the arguments and convert them to the data type, then call. Also, read it right, currently what I'm proposing is already being done at edje-external layer... which is edje-specific, just move that out of edje and make it automatically (and dynamically) generated.

Jun 15 2017, 2:18 PM · efl, Restricted Project
barbieri added a comment to T5567: Simple factories (with or without model).

Why using data model for this is not a good idea? In theory it is simple, light and easy to use... or it should, if not we're doing it wrongly... actually given the number of items, only "ease of use" matters...

Jun 15 2017, 1:47 PM · Restricted Project, efl
barbieri added a comment to T5577: Support easy object instantiation with Edje External.

My point is that you have all the information and the binary format in ram, it's the Eolian database. It's just a matter of dumping it in the generated code.

Jun 15 2017, 8:47 AM · efl, Restricted Project
barbieri added a comment to T5577: Support easy object instantiation with Edje External.
In T5577#89003, @q66 wrote:

what I wonder (actually I should know, but I never remember) and maybe @q66 can clarify is if we have that information available in runtime and how/where?

We don't have any structural information about eo objects available directly via runtime api. What you *can* do however is check the class of an object, get its name, parse the respective .eo file, and retrieve the information via libeolian if that's what you mean. But obviously that involves on-demand parsing.

Jun 15 2017, 8:19 AM · efl, Restricted Project
barbieri added a comment to T5301: Make EFL easier to use by improving its interface.
In T5301#88816, @jpeg wrote:

I also think that EXPAND should be the default - it's more intuitive and it forces the user to adjust sizing to better balance what's visible (I.e. Button bar not expand vertical, buttons not expand horizontal).
Currently folk have to struggle with why things are all small and for things like text entries, scrollers or images they may not even be visible by default...

This is a good question. We can easily change the default value for visibility, align and weight when we are using efl_add vs. a legacy _add API. It's just a bit of work marking all legacy objects as such and changing the default value inside the finalizer. It can be done.
The problem is only which values really are the best?

Jun 15 2017, 8:04 AM · Restricted Project, efl
barbieri added a comment to T5567: Simple factories (with or without model).

Guys, maybe I got the wrong message, but the Model kind of factory for menu and toolbars fit perfectly.

Jun 15 2017, 7:51 AM · Restricted Project, efl
barbieri added a comment to T5580: eo: Make efl_object_override more dynamic.

+1 on those.

Jun 15 2017, 7:39 AM · Restricted Project, efl
barbieri updated subscribers of T5577: Support easy object instantiation with Edje External.

Last but not least, with this infrastructure in place we could implement not only edje_external, but also Glade-like "widget tree description" (for those that don't recall glade, it was a XML that declares GTK widgets).

Jun 15 2017, 7:31 AM · efl, Restricted Project
barbieri added a comment to T5577: Support easy object instantiation with Edje External.

One more.

About this task, we also need to decide what params would be supported for this edje-external.
All properties ? or Some of them ?

Jun 15 2017, 7:11 AM · efl, Restricted Project
barbieri updated subscribers of T5577: Support easy object instantiation with Edje External.
In T5577#88932, @cedric wrote:

I am not a fine of runtime introspection as you pay the cost of compilation time... at run time.

Jun 15 2017, 7:06 AM · efl, Restricted Project

Jun 14 2017

barbieri added a comment to T5337: Animation framework API for EO.

@jpeg, what if we expose both termination states and link animations using these explicitly...

Jun 14 2017, 7:53 PM · Restricted Project, efl
barbieri added a comment to T5577: Support easy object instantiation with Edje External.

indeed, I believe when he said "eolian" is already the generation of the edje-external modules from each object.

Jun 14 2017, 7:48 PM · efl, Restricted Project
barbieri edited the content of Menu Design Ideas.
Jun 14 2017, 9:59 AM

Jun 8 2017

barbieri added a comment to D4357: ecore_con: fix compilation on Windows.

what's wrong with doing the define if the symbol wasn't defined?

Jun 8 2017, 10:49 AM

Jun 5 2017

barbieri added a comment to T5307: Add style description in .eo.

you better reach @q66 for details.

Jun 5 2017, 11:59 AM · Restricted Project, Restricted Project, efl
barbieri added a comment to T5307: Add style description in .eo.

For the moment I'm not a fan of the idea: 1 style = 1 class

What about when an app define it's own new style for a widget?
in this case there cannot be a new class generated of course...

Jun 5 2017, 11:41 AM · Restricted Project, Restricted Project, efl

May 16 2017

barbieri added a comment to T5479: efl: segv: emile_image_close -> memory mapped file -> eina_file_clean_close.

sorry but these are not of use... you need a valgrind suppression to hide dlopen() from eina_module_load() as these are from optimizations. Maybe it's provided with valgrind, otherwise you need to create one.

May 16 2017, 6:25 PM · efl
barbieri added a comment to F1120808: test.c.

this may not be enough for couple of reasons:

  • no main loop is executed, from your bug report it seems like the main loop is cleaning up the file at a future point, which can be the problem;
  • image is not shown, not sure if this would impact this test or not, but evas is usually optimized enough to only use pixels of images that are visible, then you may be skipping those code paths that can trigger your bug
May 16 2017, 8:04 AM

Apr 18 2017

barbieri added a comment to D4797: Experiments with EO super & cast.

lgtm

Apr 18 2017, 7:44 AM

Apr 13 2017

barbieri claimed T5383: ecore_ipc_server_clients_get() returns dead clients.

ok, will look into it, basically remove from clients list when eos happens. right?

Apr 13 2017, 9:23 AM · efl

Apr 12 2017

barbieri accepted D4785: ecore_con_legacy: Send server_upgrade event *after* clearing pending saves.

+1

Apr 12 2017, 2:25 PM

Apr 11 2017

barbieri added a comment to T5306: Add a efl_part information to .eo files .

@bu5hm4n read what you wrote and you'll notice how hackish it reads:

Apr 11 2017, 1:09 PM · Restricted Project, efl
barbieri added a comment to T5306: Add a efl_part information to .eo files .

I don't get this... effectively we deal with the internal objects, thus why not return them? If they may be of different types, return the base type, or an interface/mixin (in ".eo", for usage it's always an Eo*).

Apr 11 2017, 12:00 PM · Restricted Project, efl

Apr 10 2017

barbieri added a comment to T5310: Fix efl_futur.

yes, efl_promise_fulfill(Promise, Eina_Value) and variants like efl_promise_fulfill_bool(Promise, Bool)

Apr 10 2017, 7:51 PM · Restricted Project, efl
barbieri added a comment to T5306: Add a efl_part information to .eo files .

well, calling a "single class" but then pointing users to N styles, all with their own API is the same... "N" api to look at the end. But at least one is Eo, the classes users know how to work with, they learn once and replicate. It's also saner if you think of external providers... you can download a "MyCompany.Combobox" that extends in a different way... I doubt "MyCompany" could extend the styles of a widget... but a subclass is always that, can come from external libraries and the application own code.

Apr 10 2017, 7:17 PM · Restricted Project, efl
barbieri added a comment to T5307: Add style description in .eo.

You're keeping "part" as "part" just because of legacy :-) That's what I mean.

Apr 10 2017, 7:13 PM · Restricted Project, Restricted Project, efl
barbieri added a comment to T5306: Add a efl_part information to .eo files .

In your example it's just properties... seriously:

Apr 10 2017, 7:08 PM · Restricted Project, efl
barbieri added a comment to T5310: Fix efl_futur.

SafePointer

You don't need safepointer... actually given the amount of usage of promise/future in Efl once it's deployed (jobs, timers, idlers...) we should be using mempool, then we can use a mempool property to safety-check based on that. Like you always allocate multiple of pagesize() blocks, keep a list of blocks. Upon API entry, check if the pointer is inside one block. If so, check if the slot is alive.

Apr 10 2017, 7:03 PM · Restricted Project, efl
barbieri added a comment to T5337: Animation framework API for EO.

I'd like to see two things here:

Apr 10 2017, 6:53 PM · Restricted Project, efl
barbieri added a comment to T5306: Add a efl_part information to .eo files .

Like my comment T5307#85241 i think we're screwing up in order to cope with legacy. If we say a style is actually a subclass of our class, then it can define more properties, which are the parts you're mentioning. The class.constructor could then walk the properties and check their backing store (edje parts, eet fields, dbus interfaces...)

Apr 10 2017, 6:43 PM · Restricted Project, efl
barbieri added a comment to T5307: Add style description in .eo.

my take on this is we'll stick some bad design just to cope with legacy... Eo on its own is good enough without extensions to do that. What is different from a new button class per style (ie: 1 style = 1 subclass)? The base class can then use introspection to automatically provide methods that convert to message or part_text_set or swallow.

Apr 10 2017, 6:32 PM · Restricted Project, Restricted Project, efl

Apr 8 2017

barbieri added a comment to T5339: ecore-con no longer allows buffered sending during connect.

see if it solved your problem, I'll check out maelstorm later.

Apr 8 2017, 4:43 PM · efl
barbieri closed T5339: ecore-con no longer allows buffered sending during connect as Resolved by committing rEFLc90865ca485a: ecore_con_legacy: fix legacy compatibility for ecore_con_server_send().
Apr 8 2017, 4:38 PM · efl
barbieri added a comment to T5339: ecore-con no longer allows buffered sending during connect.

looking into this in my spare time, where is azy nowadays? checked git.enlightenment.org and couldn't find it.

Apr 8 2017, 10:06 AM · efl

Apr 7 2017

barbieri added a comment to D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.
In D4775#80502, @zmike wrote:

I like this idea, and I think it would be great to have something like this in EDC. Some comments:

  • There are no docs for any of the enum properties (fill, anchor_line). If I understand, fill is for sizing and anchor_line is the place on the "anchor" part to which the current part will be aligned?
  • I think that using anchors in an edc description should probably trigger errors if any of the internal properties (relative, align, fixed, ...) are set in the same description and vice versa, just to avoid confusion?
  • Probably this should have corresponding embryo script programs
  • While I think this could be an improvement for some developers over the current layout system, I think it's still a bit confusing. I read through the Qt docs but it seems like in the context of EDC some of these terms are a little out of place somehow. I'll think on whether I can give a better description for my thoughts here...
Apr 7 2017, 11:55 AM

Apr 6 2017

barbieri added a comment to T5339: ecore-con no longer allows buffered sending during connect.

Not yet, my daughter was born yesterday so it will take me few days to do it.

Apr 6 2017, 8:27 AM · efl