Page MenuHomePhabricator

bdilly (Bruno Dilly)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 25 2013, 1:50 AM (365 w, 23 h)
Availability
Available

Recent Activity

Jun 6 2017

bdilly created D4941: ephysics: set proper geometry when setting an object to a face.
Jun 6 2017, 1:36 PM
bdilly added a revision to T5547: Warning in ephysics: D4941: ephysics: set proper geometry when setting an object to a face.
Jun 6 2017, 1:36 PM · efl
bdilly abandoned D4940: ephysics: set proper geometry when setting an object to a face.

ooops... fixing the wrong ticket

Jun 6 2017, 1:36 PM
bdilly created D4940: ephysics: set proper geometry when setting an object to a face.
Jun 6 2017, 1:32 PM
bdilly added a revision to T5146: [evas_events] key down is not called if modifier mask is set: D4940: ephysics: set proper geometry when setting an object to a face.
Jun 6 2017, 1:32 PM · efl
bdilly added a revision to T5547: Warning in ephysics: D4940: ephysics: set proper geometry when setting an object to a face.
Jun 6 2017, 1:32 PM · efl
bdilly added a comment to T5547: Warning in ephysics.

It seems wrong. It shouldn't set the body geometry twice.
I'll provide a patch. My apologies.

Jun 6 2017, 1:27 PM · efl

Mar 24 2017

bdilly closed T5146: [evas_events] key down is not called if modifier mask is set as Resolved by committing rEFLe0170c2b0dba: evas_events: look for seats on hash instead of input devices.
Mar 24 2017, 10:15 AM · efl
bdilly closed D4738: evas_events: look for seats on hash instead of input devices by committing rEFLe0170c2b0dba: evas_events: look for seats on hash instead of input devices.
Mar 24 2017, 10:15 AM

Mar 23 2017

bdilly created D4738: evas_events: look for seats on hash instead of input devices.
Mar 23 2017, 3:09 PM
bdilly added a revision to T5146: [evas_events] key down is not called if modifier mask is set: D4738: evas_events: look for seats on hash instead of input devices.
Mar 23 2017, 3:09 PM · efl

Feb 2 2017

bdilly added a comment to T5146: [evas_events] key down is not called if modifier mask is set.

Thanks for reporting it, @Jaehyun_Cho
I'll take a look on that soon

Feb 2 2017, 5:46 AM · efl

Dec 22 2016

bdilly closed D4499: edje: support filtering allowed seats per part.

Closed by commit 8a42514d71195ca28028346a338e4db2b2f4faf9

Dec 22 2016, 9:58 AM

Dec 21 2016

bdilly updated the diff for D4499: edje: support filtering allowed seats per part.

Make changes suggested by @iscaro

Dec 21 2016, 1:08 PM
bdilly added a comment to D4499: edje: support filtering allowed seats per part.

answering missed inline question

Dec 21 2016, 1:01 PM

Dec 20 2016

bdilly added a comment to D4499: edje: support filtering allowed seats per part.

Inline comments replied

Dec 20 2016, 1:30 PM
bdilly closed D4450: Ecore Evas - New APIs for pointer devices. by committing rEFLe254e50ae556: Merge branch 'devs/iscaro/ecore_evas_cursor'.
Dec 20 2016, 1:06 PM · Restricted Project, efl

Dec 19 2016

bdilly retitled D4499: edje: support filtering allowed seats per part from to edje: support filtering allowed seats per part.
Dec 19 2016, 12:20 PM
bdilly accepted D4450: Ecore Evas - New APIs for pointer devices..
Dec 19 2016, 11:45 AM · Restricted Project, efl
bdilly closed D4498: evas: a couple fixes regarding events filter by committing rEFLecdf56de47d5: evas: improve logic regarding events filtering enablement.
Dec 19 2016, 10:49 AM · efl
bdilly added a project to D4498: evas: a couple fixes regarding events filter: efl.
Dec 19 2016, 9:34 AM · efl
bdilly added a comment to D4451: edje: add getter for devices by name.

OK, name changed to 'custom' instead of 'system' and note added to documentation.

Dec 19 2016, 9:28 AM
bdilly retitled D4498: evas: a couple fixes regarding events filter from to evas: a couple fixes regarding events filter.
Dec 19 2016, 8:09 AM · efl

Dec 15 2016

bdilly added a comment to T5011: EFL Focus w/E Broken.

Just tried to reproduce it here, and no success.
It's working as expected.

Dec 15 2016, 12:10 PM · efl

Dec 14 2016

bdilly added a comment to D4451: edje: add getter for devices by name.
In D4451#75261, @jpeg wrote:

Urgh such a massive patch...

There is no test & no example for evas_seat_names in EDC. And I don't like the name so much, I thought the feature was something quite different...

Also missing is a test case for FOCUS_SET/FOCUS_OBJECT without any argument.

Dec 14 2016, 12:33 PM
bdilly added a comment to D4451: edje: add getter for devices by name.
In D4451#75357, @cedric wrote:

Also could you start using efl_event_callback_array_add/dell ?

Dec 14 2016, 12:28 PM
bdilly updated the diff for D4451: edje: add getter for devices by name.

Pretty much all required changes were done.
(see inline replies)

Dec 14 2016, 12:20 PM

Dec 13 2016

bdilly closed D4459: Ecore Evas VNC: Properly shutdown server during cleanup. by committing rEFLc1518043e3b4: Ecore Evas VNC: Properly shutdown server during cleanup. (authored by iscaro).
Dec 13 2016, 8:51 AM
bdilly accepted D4459: Ecore Evas VNC: Properly shutdown server during cleanup..
Dec 13 2016, 8:49 AM

Dec 12 2016

bdilly closed D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get() by committing rEFL5361cc9e4c75: Merge branch 'devs/iscaro/memory'.
Dec 12 2016, 9:31 PM
bdilly accepted D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get().
Dec 12 2016, 9:30 PM
bdilly added a comment to D4451: edje: add getter for devices by name.
In D4451#75351, @cedric wrote:

Instead of use_evas_seat_names, I would prefer use_system_seat as they are defined by the system in that case, no ?

Dec 12 2016, 5:38 PM
bdilly closed D4468: Evas: Add API to block input events in Efl.Canvas.Object. by committing rEFLddf3558628a7: Merge branch 'devs/iscaro/event-filter'.
Dec 12 2016, 10:05 AM
bdilly accepted D4468: Evas: Add API to block input events in Efl.Canvas.Object..

I'm using it on Edje and it works fine

Dec 12 2016, 7:30 AM
bdilly added inline comments to D4451: edje: add getter for devices by name.
Dec 12 2016, 6:42 AM
bdilly added a comment to D4451: edje: add getter for devices by name.
In D4451#75261, @jpeg wrote:

Urgh such a massive patch...

Dec 12 2016, 6:29 AM

Dec 6 2016

bdilly updated the diff for D4451: edje: add getter for devices by name.

Include changes discussed on RFC and review

Dec 6 2016, 12:45 PM

Dec 5 2016

bdilly added inline comments to D4451: edje: add getter for devices by name.
Dec 5 2016, 12:23 PM
bdilly added inline comments to D4450: Ecore Evas - New APIs for pointer devices..
Dec 5 2016, 10:44 AM · Restricted Project, efl

Dec 2 2016

bdilly retitled D4451: edje: add getter for devices by name from to edje: add getter for devices by name.
Dec 2 2016, 12:51 PM
bdilly closed D4445: Efl.Input.Devices ref/unref fixes. by committing rEFL81a25bc83f1a: Merge branch 'devs/iscaro/devices'.
Dec 2 2016, 9:35 AM
bdilly accepted D4445: Efl.Input.Devices ref/unref fixes..
Dec 2 2016, 9:31 AM
bdilly closed D4415: Evas: Add support for per seat locks and modifiers..

Closed by commit 5fdc93c02e0743c8750cd1a03d2f3a6b4df61278

Dec 2 2016, 4:44 AM
bdilly accepted D4415: Evas: Add support for per seat locks and modifiers..
Dec 2 2016, 4:43 AM

Nov 30 2016

bdilly added a comment to D4415: Evas: Add support for per seat locks and modifiers..

We're getting closer =D
But there is still an issue that you can easily reproduce using evas_multiseat_events example.

Nov 30 2016, 2:41 PM
bdilly closed D4442: eina: remove tests, examples and docs for eina_model by committing rEFLadb95630ef47: eina: remove tests, examples and docs for eina_model.
Nov 30 2016, 12:38 PM
bdilly retitled D4442: eina: remove tests, examples and docs for eina_model from to eina: remove tests, examples and docs for eina_model.
Nov 30 2016, 12:04 PM
bdilly added a comment to D4406: Add new multi-seat events..

This PR was merged already,
on commit fc5cc218095dfc3cc772c7ab664358a66ef64379

Nov 30 2016, 12:02 PM
bdilly added a comment to D4415: Evas: Add support for per seat locks and modifiers..
In D4415#74637, @bdilly wrote:

pointer,in and pointer,out logic seems to be wrong.
Please test the following scenario with the recently added evas_multiseat_events example (using two seats with pointers):

Only use one pointer, move over the blue rectangle, click (it'll be focused), and move out.

You see he sends a pointer,in for the second seats (not used) when you click over this object - line 192.
And when you move out, pointer,out will be emitted for both seats - line 212.

[[ http://pastebin.com/KddutvUv

| log ]]
Nov 30 2016, 11:18 AM
bdilly added a comment to D4415: Evas: Add support for per seat locks and modifiers..

pointer,in and pointer,out logic seems to be wrong.
Please test the following scenario with the recently added evas_multiseat_events example (using two seats with pointers):

Nov 30 2016, 11:14 AM

Nov 28 2016

bdilly added a comment to D4415: Evas: Add support for per seat locks and modifiers..

Not sure if related to the inline comment, but the pointer in / out logic seems buggy at the moment.
I've done a few tests here with two seats with mouses going over a few different evas objects and changing focus between them on click.
At some points when clicking on other object with a seat generates a pointer,out for the other seat.
I'll try to post a comprehensible log later.

Nov 28 2016, 4:12 PM
bdilly accepted D4406: Add new multi-seat events..
Nov 28 2016, 8:36 AM

Nov 24 2016

bdilly closed D4412: Evas: Use events to set canvas focus in/out. by committing rEFL6d530356b0be: Merge branch 'devs/iscaro/focus-event'.
Nov 24 2016, 1:19 PM
bdilly closed D4428: ecore_wl2: avoid adding repeated devices by committing rEFL1e62cd562ee2: ecore_wl2: avoid adding repeated devices.
Nov 24 2016, 12:39 PM
bdilly retitled D4428: ecore_wl2: avoid adding repeated devices from to ecore_wl2: avoid adding repeated devices.
Nov 24 2016, 12:31 PM

Nov 18 2016

bdilly added a comment to T4907: EFL: Animation Freeze.

No reasons for apologies.
Even if it wasn't caused by recent changes on focus, we as community need to fix the issue you're facing anyway.
Not being able to reproduce the issue makes it a bit harder to debug, but with your help we can do it =)

Nov 18 2016, 8:15 AM · efl
bdilly added a comment to T4907: EFL: Animation Freeze.

I tried to reproduce it running it on X11 on Ubuntu.

Nov 18 2016, 6:30 AM · efl

Nov 16 2016

bdilly closed D4408: Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT. by committing rEFL9f8e2e0d9c9b: Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT. (authored by iscaro).
Nov 16 2016, 11:52 AM
bdilly accepted D4408: Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT..

Code seems better now.
Thanks

Nov 16 2016, 11:03 AM
bdilly closed D4407: ecore_wl2: ref / unref evas devices on ecore events by committing rEFL6f66c6e67696: ecore_wl2: ref / unref evas devices on ecore events.
Nov 16 2016, 11:01 AM
bdilly updated the diff for D4407: ecore_wl2: ref / unref evas devices on ecore events.

Handle all unref in a single callback

Nov 16 2016, 10:53 AM
bdilly retitled D4407: ecore_wl2: ref / unref evas devices on ecore events from to ecore_wl2: ref / unref evas devices on ecore events.
Nov 16 2016, 10:13 AM
bdilly added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..
In D4390#73706, @jpeg wrote:

Do we really need the distinction between NO_SEAT and NONE for capabilities? It looks confusing to me as cap != 0 does not mean the device is useful. If the device has only NONE capabilities, it's pretty damn useless (even if it's a 'valid' device). I would say merge NO_SEAT and NONE and the patch is good to go.

This fixes the issue indeed.

Nov 16 2016, 4:08 AM
bdilly added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..
In D4390#73851, @jpeg wrote:

So I uh... pushed the patch. Including NO_SEAT and NONE.

Nov 16 2016, 4:01 AM
bdilly added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..

It seems good overall. Just a few inline comments.
Indeed I failed to preview such a scenario.

Nov 16 2016, 4:01 AM

Nov 9 2016

bdilly closed D4387: Evas: Change evas_canvas_default_device_get() to property. by committing rEFL17af933ae750: Evas: Change evas_canvas_default_device_get() to property. (authored by iscaro).
Nov 9 2016, 5:25 AM
bdilly accepted D4387: Evas: Change evas_canvas_default_device_get() to property..
Nov 9 2016, 5:21 AM
bdilly added a comment to D4385: efl: add getter for input device's seat.

Thanks @iscaro , @jpeg .
I've made all documentation fixes and merged it.

Nov 9 2016, 5:15 AM
bdilly closed D4385: efl: add getter for input device's seat by committing rEFLed48b8d93ee2: efl: add getter for input device's seat.
Nov 9 2016, 5:03 AM

Nov 8 2016

bdilly retitled D4385: efl: add getter for input device's seat from to efl: add getter for input device's seat.
Nov 8 2016, 2:13 PM
bdilly closed D4374: Evas: Add support for mulitple focused objects..

Closed by commit 2a96097a658e0817c95f72b56d37879720886fa5

Nov 8 2016, 12:31 PM
bdilly accepted D4374: Evas: Add support for mulitple focused objects..
Nov 8 2016, 12:02 PM

Nov 7 2016

bdilly added a comment to D4374: Evas: Add support for mulitple focused objects..

Hey Iscaro, I've got a few questions / comments related to this series that eventually would require more changes.
ptal

Nov 7 2016, 9:23 AM

Nov 4 2016

bdilly closed D4373: Ecore Evas VNC: Add Framebuffer support. by committing rEFLf869cd580e47: Merge branch 'devs/iscaro/vnc-fb'.
Nov 4 2016, 2:08 PM
bdilly accepted D4373: Ecore Evas VNC: Add Framebuffer support..
Nov 4 2016, 1:26 PM

Nov 1 2016

bdilly closed D4370: evas: Fix doxygen and normalize function signature.

Closed by commit rEFL3ac1812a1f99

Nov 1 2016, 11:17 AM
bdilly closed D4369: Evas Device: Avoid invalid ptr indirection. by committing rEFL402abcaefca0: Evas Device: Avoid invalid ptr indirection. (authored by iscaro).
Nov 1 2016, 11:04 AM
bdilly added a reviewer for D4369: Evas Device: Avoid invalid ptr indirection.: barbieri.
Nov 1 2016, 7:23 AM

Oct 31 2016

bdilly added a comment to D4370: evas: Fix doxygen and normalize function signature.

Ok, nvm. After a little more thought...since they are event structures we probably should expose them... nevermind my previous rejection :)

Oct 31 2016, 12:57 PM
bdilly added a comment to D4370: evas: Fix doxygen and normalize function signature.

Hey guys,

Oct 31 2016, 11:58 AM
bdilly retitled D4370: evas: Fix doxygen and normalize function signature from to evas: Fix doxygen and normalize function signature.
Oct 31 2016, 11:55 AM
bdilly accepted D4369: Evas Device: Avoid invalid ptr indirection..

Seems ok to me.
Also it fixes issues I've been facing on multi seat wayland support branch.
+1

Oct 31 2016, 10:14 AM

Oct 10 2016

bdilly closed D4339: Some fixes for OS X. This series fixes two problems pointed by jayji and some other compiler warnings. by committing rEFLc8af4e498ede: Merge branch 'devs/iscaro/osx'.
Oct 10 2016, 12:04 PM

Sep 30 2016

bdilly requested changes to D4323: This series fixes two problems in the VNC implementation. One deadlock and one segfault. Patch 1: Software X11 Evas Engine: Fix deadlock.

Actually we found some issues with the second patch, that shouldn't be creating new buffers everytime w / h diverges from ee->w, ee->h.
@iscaro is going to push a new version soon.

Sep 30 2016, 4:14 PM

Sep 29 2016

bdilly added a comment to D4325: Evas_Device: Fix API name..

Applied on commit 50f5704cc6b95ed30b25c668e2fc1679a4131279
Thanks

Sep 29 2016, 1:52 PM
bdilly closed D4325: Evas_Device: Fix API name..
Sep 29 2016, 1:51 PM
bdilly accepted D4325: Evas_Device: Fix API name..
Sep 29 2016, 10:53 AM
bdilly added a reviewer for D4325: Evas_Device: Fix API name.: DaveMDS.

It seems correct.
Just adding Dave since he spotted the issue initially.
Thanks

Sep 29 2016, 10:52 AM

Sep 28 2016

bdilly accepted D4323: This series fixes two problems in the VNC implementation. One deadlock and one segfault. Patch 1: Software X11 Evas Engine: Fix deadlock.

This approach sounds right to me.
I've tested it using E, terminology, ephoto. No more deadlocks.
Ref/unref seems to be the way to avoid memory duplication.
So +1

Sep 28 2016, 1:28 PM

Sep 26 2016

bdilly closed D4295: This series of patches adds VNC support for EFL..

Merged on commit 0566abeee85f899dffd1b58260ada696d8a86af7

Sep 26 2016, 6:19 PM
bdilly accepted D4295: This series of patches adds VNC support for EFL..
Sep 26 2016, 6:18 PM

Sep 20 2016

bdilly added a comment to D4308: fix warnings.
In D4308#72038, @cedric wrote:

@devilhorn: can you accept and close this revision ?

Sep 20 2016, 4:24 PM
bdilly updated the diff for D4308: fix warnings.

Made all required changes on previous revision

Sep 20 2016, 3:38 PM
bdilly retitled D4308: fix warnings from to fix warnings.
Sep 20 2016, 1:30 PM

Sep 16 2016

bdilly added a comment to D4296: [RFC] efl_net_control and efl_net_session..

Long time I don't code something on top of ConnMan API (last time was a connman module about 3 years ago? =) ), but it seems really good overall.
+1

Sep 16 2016, 8:01 AM

Sep 9 2016

bdilly abandoned D4289: ecore_evas_drm: Fix ifdefs on code refactoring.
Sep 9 2016, 5:14 AM
bdilly added a comment to D4289: ecore_evas_drm: Fix ifdefs on code refactoring.

I believe raster merged something fixing it already.
So disregard.
Thanks

Sep 9 2016, 5:09 AM

Sep 8 2016

bdilly retitled D4289: ecore_evas_drm: Fix ifdefs on code refactoring from to ecore_evas_drm: Fix ifdefs on code refactoring.
Sep 8 2016, 8:54 PM
bdilly added a comment to T4529: efl: installation fails without root permissions.

I believe you're missing an environment variable, USER_SESSION_DIR
Have you tried to do something like that?

Sep 8 2016, 7:39 AM · efl