Page MenuHomePhabricator

bowonryu (Bowon Ryu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Feb 14 2016, 9:57 PM (240 w, 1 d)
Availability
Available

Recent Activity

Thu, Sep 3

bowonryu accepted D12126: elm_entry: legacy smart selection[start,cleared] callback fix.

This patch fixes a compatibility issue. I think this is absolutely necessary.

Thu, Sep 3, 8:13 PM · efl

Aug 17 2020

bowonryu accepted D12102: evas_textblock: myanmar script rendering with e vowel..

Looks good to me.
This patch completely fixes rendering issues in Myanmar e vowel + ZWNJ.

Aug 17 2020, 10:01 PM · efl

Aug 10 2020

bowonryu abandoned D12104: edje: prevent to error of null deref.
Aug 10 2020, 9:33 PM · efl
bowonryu requested review of D12104: edje: prevent to error of null deref.
Aug 10 2020, 9:30 PM · efl

Aug 4 2020

bowonryu requested review of D12094: edje_edit: add null check for return of eina_hash_find.
Aug 4 2020, 4:41 AM · efl

Jul 21 2020

bowonryu updated the diff for D11962: edje_textblock: remove duplicated textblock style properties.

fix for ninja test

Jul 21 2020, 12:49 AM · efl

Jul 20 2020

bowonryu updated the diff for D11962: edje_textblock: remove duplicated textblock style properties.

fix build warning

Jul 20 2020, 11:16 PM · efl

Jul 19 2020

bowonryu added inline comments to D11962: edje_textblock: remove duplicated textblock style properties.
Jul 19 2020, 10:45 PM · efl

Jul 16 2020

bowonryu updated the diff for D11962: edje_textblock: remove duplicated textblock style properties.

this can handle all kinds of whitespace

Jul 16 2020, 2:55 AM · efl

Jun 30 2020

bowonryu updated the diff for D11962: edje_textblock: remove duplicated textblock style properties.

it is not very different from previous version of this patch.
but, I cut the string generation in half.

Jun 30 2020, 4:23 AM · efl

Jun 28 2020

bowonryu abandoned D9548: evas_object_textblock: add update for missing font_source.
Jun 28 2020, 7:10 PM · efl

Jun 22 2020

bowonryu added a comment to D11962: edje_textblock: remove duplicated textblock style properties.
Example 1)
Jun 22 2020, 11:36 PM · efl

Jun 18 2020

bowonryu added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

Good news : )
If use D11990, it will be simpler logic. I wiil try it. Thanks.

Jun 18 2020, 12:53 AM · efl

Jun 11 2020

bowonryu updated the diff for D11962: edje_textblock: remove duplicated textblock style properties.

ensure to replace the last tag

Jun 11 2020, 11:31 PM · efl

Jun 10 2020

bowonryu added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

Finally I understood.
In general, if properties are duplicated, the last property in the textblock style is valid.
However, if the values ​​of duplicate properties are same, the properties located in front are valid. (The property in front is replaced by eina_strbuf_replace)
I will find a way to solve this problem.
Thanks.

Jun 10 2020, 9:05 PM · efl
bowonryu added a comment to D11962: edje_textblock: remove duplicated textblock style properties.

If there is more than one font or font_size in the textblock style, the last tag is replaced.
Because if there are multiple tags, then tag->font, tag->font_size in code is the last tag.
As you say, textblock style may have multiple font or font_size, however only the last tag is valid.

Jun 10 2020, 5:35 AM · efl
bowonryu requested review of D11962: edje_textblock: remove duplicated textblock style properties.
Jun 10 2020, 2:56 AM · efl

May 24 2020

bowonryu updated the diff for D11868: edje: markup flag should be TRUE in legacy edje_object_part_text_set.

unit test updated

May 24 2020, 10:22 PM · efl

May 21 2020

bowonryu requested review of D11868: edje: markup flag should be TRUE in legacy edje_object_part_text_set.
May 21 2020, 11:30 PM · efl

Apr 5 2020

bowonryu requested review of D11649: edje: fix cursor scrolling.
Apr 5 2020, 11:40 PM · efl

Feb 28 2020

bowonryu requested review of D11435: elm_label: sizing eval is called _on_label_resize to ensure label size..
Feb 28 2020, 12:24 AM · efl

Feb 24 2020

bowonryu requested review of D11401: edje/style: Fix a problem where embedded font does not load in edj.
Feb 24 2020, 2:26 AM · efl

Jan 30 2020

bowonryu added a comment to T8556: Fash issue with digit unicode after emoji unicode..

Thanks for your effort :)

Jan 30 2020, 4:22 AM

Jan 15 2020

bowonryu added a comment to D11096: evas_object_textblock: treat variation sequence as single run.

This patch works fine.

Jan 15 2020, 1:08 AM · efl

Jan 7 2020

bowonryu triaged T8556: Fash issue with digit unicode after emoji unicode. as Showstopper Issues priority.
Jan 7 2020, 10:36 PM

Dec 24 2019

bowonryu accepted D10956: elm_entry: remove variation sequences as part of glyph when delete clusters.

This problem is related to whether the font contains a glyph representation.
However, this patch guarantees clustered remove of 'Char' + 'U+FE0E' regardless of the font glyph.
So I think this patch is necessary.

Dec 24 2019, 12:22 AM · efl

Dec 23 2019

bowonryu retitled D10961: evas_object_textblock: remove unreachable code from evas_object_textblock: remove unreached code to evas_object_textblock: remove unreachable code.
Dec 23 2019, 6:33 PM · efl
bowonryu requested review of D10961: evas_object_textblock: remove unreachable code.
Dec 23 2019, 6:23 PM · efl
bowonryu added a comment to T8542: evas_object_textblock variation sequence issues.

Thanks to reply :)
I agree with you.
There are some case of limitations on user font fallback priority and efl font cache logic.
(I think some are related to performance, trade off)

Dec 23 2019, 1:42 AM

Dec 22 2019

bowonryu triaged T8542: evas_object_textblock variation sequence issues as Showstopper Issues priority.
Dec 22 2019, 10:50 PM

Dec 3 2019

bowonryu updated the summary of D10792: edje_entry: converting plain_text to '*' using unicode units..
Dec 3 2019, 9:40 PM · efl
bowonryu updated the summary of D10792: edje_entry: converting plain_text to '*' using unicode units..
Dec 3 2019, 9:38 PM · efl
bowonryu requested review of D10792: edje_entry: converting plain_text to '*' using unicode units..
Dec 3 2019, 9:22 PM · efl

Nov 18 2019

bowonryu requested review of D10693: slider: fix behavior of slider when mirrored.
Nov 18 2019, 6:53 PM · efl

Nov 17 2019

bowonryu updated the diff for D10662: slider: fix value error from step.

refactored into a single function for reduce duplicate code.

Nov 17 2019, 8:51 PM · efl

Nov 15 2019

bowonryu updated the diff for D10662: slider: fix value error from step.

using CLAMP macro to reduce duplicate code.

Nov 15 2019, 1:48 AM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

update example

Nov 15 2019, 1:01 AM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

logic reordering

Nov 15 2019, 12:08 AM · efl

Nov 14 2019

bowonryu updated the diff for D10662: slider: fix value error from step.

update missing code

Nov 14 2019, 11:34 PM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

remove white space

Nov 14 2019, 9:44 PM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

add missing conditions.

Nov 14 2019, 9:04 PM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

remove white spaces.

Nov 14 2019, 1:14 AM · efl
bowonryu updated the diff for D10662: slider: fix value error from step.

remove white space

Nov 14 2019, 1:11 AM · efl
bowonryu requested review of D10662: slider: fix value error from step.
Nov 14 2019, 1:04 AM · efl

Aug 29 2019

bowonryu updated the diff for D9780: elm_entry: add null check logic on elm_entry_text_set API.

changed entire conditions to eina_streq

Aug 29 2019, 11:12 PM · efl
bowonryu added reviewers for D9780: elm_entry: add null check logic on elm_entry_text_set API: cedric, Hermet, Jaehyun_Cho.
Aug 29 2019, 1:04 AM · efl
bowonryu requested review of D9780: elm_entry: add null check logic on elm_entry_text_set API.
Aug 29 2019, 12:16 AM · efl

Aug 27 2019

bowonryu added a comment to D9536: evas_textblock: optimize calculate main format once in layout setup stage.

I have no problem running the evas suite. (Before Patch & After Patch)

Aug 27 2019, 1:28 AM · efl

Aug 19 2019

bowonryu added a comment to D9548: evas_object_textblock: add update for missing font_source.

@ali.alzyod
This is a demo that can simple check the change of font (with font source applied)
but the font files(DejaVuSerif.ttf, NanumGothic.ttf) are missing by mistake.

Aug 19 2019, 3:54 AM · efl

Aug 12 2019

bowonryu requested review of D9548: evas_object_textblock: add update for missing font_source.
Aug 12 2019, 2:42 AM · efl

May 20 2019

bowonryu updated the diff for D8923: elm_entry: prevents invalid cursor position updates.

The else part was my mistake. I removed it.

May 20 2019, 9:28 PM · efl
bowonryu requested review of D8923: elm_entry: prevents invalid cursor position updates.
May 20 2019, 4:25 AM · efl

Apr 23 2019

bowonryu added a comment to D8694: entry: revert a single line.

This is a necessary patch.

Apr 23 2019, 9:52 PM · efl

Mar 27 2019

bowonryu accepted D8455: efl_ui_slider: block scrolling when on slider.

looks good, this is a feature that should be supported.

Mar 27 2019, 10:16 PM · efl

Mar 25 2019

bowonryu updated the summary of D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.
Mar 25 2019, 9:58 PM · efl
bowonryu updated the diff for D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.

fix commit msg

Mar 25 2019, 9:56 PM · efl
bowonryu updated the diff for D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.

modified in better way.

Mar 25 2019, 9:53 PM · efl
bowonryu requested review of D8471: efl_ui_tab_pager: fixed issue where tab_pager does not work.
Mar 25 2019, 7:32 PM · efl

Mar 13 2019

bowonryu accepted D8323: Fix _entry_has_new_line on detecting new lines when it finds <br> <ps> in passed string.

This patch fixes the wrong indexing.
This seems necessary.

Mar 13 2019, 2:43 AM · efl

Feb 14 2019

bowonryu abandoned D7961: textblock: use snprintf to avoid potential buffer overflow..

The correct buffer size has already been calculated.

Feb 14 2019, 11:30 PM · efl
bowonryu requested review of D7961: textblock: use snprintf to avoid potential buffer overflow..
Feb 14 2019, 11:24 PM · efl

Jan 31 2019

bowonryu updated the diff for D7835: efl_ui_tab_bar: fix tab sizing issue.

add FIXME

Jan 31 2019, 1:44 AM · efl

Jan 30 2019

bowonryu requested review of D7835: efl_ui_tab_bar: fix tab sizing issue.
Jan 30 2019, 9:55 PM · efl

Jan 29 2019

bowonryu abandoned D7809: efl_ui_text: add null check.
Jan 29 2019, 4:07 AM · efl

Jan 28 2019

bowonryu requested review of D7809: efl_ui_text: add null check.
Jan 28 2019, 9:46 PM · efl

Dec 18 2018

bowonryu edited the content of Maintainers Reviewers.
Dec 18 2018, 6:29 PM · efl

Dec 16 2018

bowonryu abandoned D3917: ecore_win32: need EAPI function to set icon by file path on Windows..
Dec 16 2018, 7:13 PM · efl
bowonryu abandoned D3998: edc_parser: set uninitialized value.
Dec 16 2018, 7:13 PM
bowonryu abandoned D5875: ecore_con: remove logically dead code..
Dec 16 2018, 7:11 PM · efl

Dec 3 2018

bowonryu requested review of D7407: efl_ui_tab_bar: fix error about double free.
Dec 3 2018, 9:37 PM · efl
bowonryu updated the task description for T7481: Upgrade GUI of ea_gen.
Dec 3 2018, 7:13 PM

Nov 29 2018

bowonryu updated the diff for D7385: GUI: split tab of explorer.

add missing file

Nov 29 2018, 7:08 PM
bowonryu requested review of D7385: GUI: split tab of explorer.
Nov 29 2018, 4:20 AM

Nov 28 2018

bowonryu added a comment to D7358: GUI: update app panel & ML view.

@JackDanielZ
Hi Daniel
Why is the landing of this patch delayed?
As a result, other patches related to this are also being delayed.

Nov 28 2018, 1:26 AM

Nov 27 2018

bowonryu added a comment to D7365: DB: fix warnings.

This is my log

Nov 27 2018, 12:37 AM
bowonryu updated the diff for D7358: GUI: update app panel & ML view.

Hi Daniel, I fixed typo.
And I fixed warnings. D7365

Nov 27 2018, 12:05 AM

Nov 26 2018

bowonryu requested review of D7365: DB: fix warnings.
Nov 26 2018, 11:33 PM
bowonryu added a comment to D7358: GUI: update app panel & ML view.

Hello Daniel Zaoui

Nov 26 2018, 3:52 AM
bowonryu updated the task description for T7481: Upgrade GUI of ea_gen.
Nov 26 2018, 2:19 AM
bowonryu updated the summary of D7358: GUI: update app panel & ML view.
Nov 26 2018, 1:44 AM
bowonryu updated the summary of D7358: GUI: update app panel & ML view.
Nov 26 2018, 1:43 AM
bowonryu requested review of D7358: GUI: update app panel & ML view.
Nov 26 2018, 1:41 AM

Nov 22 2018

bowonryu updated the diff for D7329: GUI: add text setting.

fix some detail of theme

Nov 22 2018, 8:54 PM
bowonryu updated the diff for D7329: GUI: add text setting.

Hi, thanks to your comment,
I modified the code to fit the comments.

Nov 22 2018, 7:02 PM
bowonryu abandoned D7217: GUI: update db panel.

This patch wiil be replaced by another patch

Nov 22 2018, 5:42 PM
bowonryu updated the task description for T7481: Upgrade GUI of ea_gen.
Nov 22 2018, 3:55 AM
bowonryu requested review of D7329: GUI: add text setting.
Nov 22 2018, 3:47 AM

Oct 31 2018

bowonryu added a comment to D7217: GUI: update db panel.

@JackDanielZ ping?

Oct 31 2018, 7:56 PM

Oct 28 2018

bowonryu accepted D7185: elm_toolbar: fix prio.visible.

Good. This helps prevent the toolbar from moving like crazy in some SHRINK_EXPAND. (For example, elementary_test toolbar8)

Oct 28 2018, 8:07 PM · efl

Oct 26 2018

bowonryu requested review of D7217: GUI: update db panel.
Oct 26 2018, 12:44 AM

Oct 10 2018

bowonryu updated the diff for D7154: efl_ui_tab_pager: modified test for regression test.

remove unused code.

Oct 10 2018, 1:46 AM · efl
bowonryu requested review of D7154: efl_ui_tab_pager: modified test for regression test.
Oct 10 2018, 1:33 AM · efl

Oct 2 2018

bowonryu requested review of D7127: efl_page_transition_scroll: fix warning the dereference before null check.
Oct 2 2018, 3:39 AM · efl

Oct 1 2018

bowonryu requested review of D7125: docs: fix the incorrect group name of segment control.
Oct 1 2018, 9:53 PM · efl

Sep 21 2018

bowonryu updated the diff for D7087: docs: correct group name of segmentcontrol for API docs..

add missing file.

Sep 21 2018, 1:04 AM · efl
bowonryu requested review of D7087: docs: correct group name of segmentcontrol for API docs..
Sep 21 2018, 1:01 AM · efl

Sep 20 2018

bowonryu requested review of D7076: GUI: new menu implement.
Sep 20 2018, 5:28 AM

Sep 19 2018

bowonryu accepted D7067: efl_ui_tab_pager : Fix type mismatch for calloc.

This seems necessary.

Sep 19 2018, 12:14 AM · efl

Sep 14 2018

bowonryu requested review of D7032: GUI: Code clean up and bug fix for tab..
Sep 14 2018, 1:19 AM

Sep 12 2018

bowonryu updated the diff for D6993: GUI: Tab implement.

From now, the directory is not visible on tab.
and fix build warning.

Sep 12 2018, 5:19 AM