Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (319 w, 3 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n accepted D11117: efl: correct class description name of simple class.

Thanks.

Fri, Jan 17, 4:36 AM · efl
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

I am okay with the API side, only one thing impacts the API right now:

  • _efl_ui_textbox_efl_layout_signal_signal_callback_add still has a problem, the object of the function callback will be wrong
Fri, Jan 17, 4:23 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a project to T8578: Refactoring of org.a11y.atspi.Value interface realization: efl: api.

That sounds indeed like a very good idea, and a lot of deduplication.

Fri, Jan 17, 3:50 AM · efl: api

Yesterday

bu5hm4n added a comment to D11112: docs: Give some love to progress bar docs..

...

Thu, Jan 16, 7:28 AM · efl
bu5hm4n added a comment to D11112: docs: Give some love to progress bar docs..

Why am i unable to accept this ?

Thu, Jan 16, 7:28 AM · efl
bu5hm4n added a comment to D11112: docs: Give some love to progress bar docs..

Thank you

Thu, Jan 16, 7:27 AM · efl
bu5hm4n accepted D11103: efl.ui.textbox: theme code cleanup.
Thu, Jan 16, 7:26 AM · efl
bu5hm4n accepted D11109: efl.ui.textbox: update _part_is_efl_ui_textbox_part.
Thu, Jan 16, 7:17 AM · efl
bu5hm4n added a comment to T8565: Windows: undefined references for some evas loaders and savers.

Mhm, i do not have a real impact on the order of libs there ... that is the result of some internal windows libs.

Thu, Jan 16, 1:18 AM · Restricted Project
bu5hm4n added a comment to T8576: edje_object_message_signal_process cause lifetime issues.

So starting the textbox widget and rightclicking on the widget will bring up a popup with a list list and a few items (one of them has the label "cut"). The cut item has a CLICKED handler that will delete the entire popup.

Thu, Jan 16, 1:11 AM · efl: api
bu5hm4n accepted D11063: docs: A bit more info and formatting for Eina_Process_Cb.

That's cool :)

Thu, Jan 16, 12:51 AM · efl
bu5hm4n accepted D11107: efl_ui_textbox: rename efl_ui_text_part to efl_ui_textbox_part.
Thu, Jan 16, 12:49 AM · efl
bu5hm4n accepted D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

Cool, thank you.

Thu, Jan 16, 12:42 AM · efl
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

Something else discovered due to reviewing D11107. _part_is_efl_ui_textbox_part returns valid parts for each and every part name. However, _efl_ui_textbox_text_set and _efl_ui_textbox_text_get do only work for "efl.text_guide" or "efl.text". I think we should change _part_is_efl_ui_textbox_part that it only works for "efl.text_guide" and "efl.text", for the rest EINA_FALSE should be returned.

Thu, Jan 16, 12:39 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n accepted D11044: ecore_con: remove use of list<> from Efl.Net..

Well, you can see if the list of failed examples gets bigger or smaller ... :)

Thu, Jan 16, 12:32 AM · efl
bu5hm4n added inline comments to D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Thu, Jan 16, 12:30 AM · efl
bu5hm4n accepted D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Thu, Jan 16, 12:29 AM · efl
bu5hm4n added a comment to D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

yeah, probably true.

Thu, Jan 16, 12:29 AM · efl
bu5hm4n added a comment to D11103: efl.ui.textbox: theme code cleanup.

Have you moved it *after* the super call to theme_apply?

Thu, Jan 16, 12:27 AM · efl

Wed, Jan 15

bu5hm4n added inline comments to D11068: efl.ui.textbox: paste in mouse button 2.
Wed, Jan 15, 4:08 AM · efl
bu5hm4n accepted D11097: c#: Remove warning about unused variable.

Thank you

Wed, Jan 15, 2:16 AM · efl
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

what is text_table, and why is it used ?

it is a container for guided text and internal interactive text

Wed, Jan 15, 2:10 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n accepted D11104: efl_canvas_animation_group: preserve each animation's duration.

Yeah, good catch.

Wed, Jan 15, 2:06 AM · efl
bu5hm4n accepted D11068: efl.ui.textbox: paste in mouse button 2.

Does what it should do

Wed, Jan 15, 2:04 AM · efl
bu5hm4n requested changes to D11103: efl.ui.textbox: theme code cleanup.

When those changes are applied, the theme will be applied automatically during construction.

Wed, Jan 15, 1:59 AM · efl

Tue, Jan 14

bu5hm4n updated subscribers of D11102: efl.ui.textbox: part implementation comments clean up!.

@segfaultxavi Naaaaaaaame discussion, should be the part Efl.Ui.Text_Part be renamed to Efl.Ui.Textbox_Part ?

Tue, Jan 14, 11:59 PM · efl
bu5hm4n added a comment to D11102: efl.ui.textbox: part implementation comments clean up!.

Mhm - is there a reason the part class is not called Text *box* _Part ?

Tue, Jan 14, 11:55 PM · efl
bu5hm4n accepted D11072: efl.ui.textbox: replace hoversel with popup.

I think we can go ahead and land it the way it is, the fix for the error will be outside this here i guess.

Tue, Jan 14, 10:36 PM · efl
bu5hm4n added a comment to T8501: Efl.Ui.Progressbar.

Yeah i think keeping it is better. The API does not look wrong, i would implement it exactly the way it is now when ding the double progressbar. Additionally, removing it, means we have to refactor quite a lot of code, which will be simply duplicated by the time we introduce the double progressbar :)

Tue, Jan 14, 10:34 PM · efl: api, efl (efl-1.24)
bu5hm4n requested changes to D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

But the rest looks good.

Tue, Jan 14, 10:31 PM · efl
bu5hm4n triaged T8576: edje_object_message_signal_process cause lifetime issues as High priority.
Tue, Jan 14, 10:28 PM · efl: api
bu5hm4n updated the task description for T8328: edocgen: Remaining issues.
Tue, Jan 14, 8:40 AM · efl: docs
bu5hm4n added inline comments to D11072: efl.ui.textbox: replace hoversel with popup.
Tue, Jan 14, 8:39 AM · efl
bu5hm4n added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

But then better create some placeholder API that just does that (maybe not on efl.ui.textbox). I really have a bad feeling just removing a feature, better stick it in a other place where we can refactor it later on.

Tue, Jan 14, 7:57 AM · efl
bu5hm4n added a comment to D11072: efl.ui.textbox: replace hoversel with popup.

I am not sure if the backwall should emit clicked when rightclicked, it normally is just meant to react on left click.

Tue, Jan 14, 7:11 AM · efl
bu5hm4n accepted D11093: efl_ui_textbox: mark @beta to cnp_mode and item_factory.
Tue, Jan 14, 6:59 AM · efl
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

I agree, lets keep these @beta.

Tue, Jan 14, 6:57 AM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8568: Efl.Canvas.Textblock_Factory.

I am also wondering of we can just reuse Efl.Ui.Factory, where the model has a single key...

Tue, Jan 14, 6:56 AM · efl: language bindings, efl: api
bu5hm4n added a comment to T8570: Efl.Text_Range.

@cedric there was some plan for a range because of MVVM, this looks simular, does that match ?

Tue, Jan 14, 6:36 AM · efl: language bindings, efl: api
bu5hm4n updated subscribers of T8328: edocgen: Remaining issues.

Just from the top of my head:

  • Right now there is this short version of "Inheritance" that starts with the parent class. I think it would be nice to have there as well the list of interfaces and mixins that are directly inherited, just with a link so you can click on it.
  • Maybe we can join the Inherited section with the event section, it feels akward to me to have them doubled.
  • The Members are kind of very "short" if this list gets shorter due to bullet point 2, we could make something that is a little bit more "verbose" telling what the members are etc.
  • The Titles in the property view could get links to jump back to the widget they are on.
  • The idea from k-s http://i.imgur.com/EINws0S.png to have something like "C usage" also looks very very nice, maybe something to consider ?
  • I get the navigation bar on every site, is it possibleto turn it off, its a little bit out of place here.
  • And a bug, taking https://www.enlightenment.org/develop/api/efl/ui/collection and clicking on Efl.Ui.Multi_Selectable.select_mode will not redirect you to a valid page.
Tue, Jan 14, 4:19 AM · efl: docs
bu5hm4n accepted D11059: edje_entry: fix some preediting bugs.

Cool - yeah you catched everything :)

Tue, Jan 14, 1:52 AM · efl

Mon, Jan 13

bu5hm4n added a comment to D11010: efl_ui_spin_button: add tests for direct input feature.

Can you now get a backtrace ? One thing is the crash with all details, but at a minimum thing the symbol names would be very good.

Mon, Jan 13, 11:41 AM · efl
bu5hm4n added reviewers for D11010: efl_ui_spin_button: add tests for direct input feature: zmike, segfaultxavi, cedric.
Mon, Jan 13, 11:21 AM · efl
bu5hm4n updated subscribers of D11010: efl_ui_spin_button: add tests for direct input feature.

This is still failing on travis in a Segfault that i cannot reproduce here locally.

Mon, Jan 13, 11:20 AM · efl
bu5hm4n updated the diff for D11010: efl_ui_spin_button: add tests for direct input feature.

more work on this

Mon, Jan 13, 11:19 AM · efl
bu5hm4n added a child revision for D11079: efl_ui_selection: return ERRORS when setting the selection failed: D11010: efl_ui_spin_button: add tests for direct input feature.
Mon, Jan 13, 11:19 AM · efl
bu5hm4n reopened D11010: efl_ui_spin_button: add tests for direct input feature.
Mon, Jan 13, 11:18 AM · efl
bu5hm4n requested review of D11079: efl_ui_selection: return ERRORS when setting the selection failed.
Mon, Jan 13, 7:53 AM · efl
bu5hm4n added a comment to D11075: efl_ui_progressbar: do not allow parts on unified widgets.

Mhm, whats our default policy for that ? I think normally our part_get methods do silently return ...

Mon, Jan 13, 6:46 AM · efl
bu5hm4n requested review of D11077: theme: remove not yet used groups.
Mon, Jan 13, 6:11 AM · efl
bu5hm4n added a child revision for D11076: efl_ui_progressbar: fix theming of progressbar: D11077: theme: remove not yet used groups.
Mon, Jan 13, 6:11 AM · efl
bu5hm4n added a revision to T8501: Efl.Ui.Progressbar: D11077: theme: remove not yet used groups.
Mon, Jan 13, 6:11 AM · efl: api, efl (efl-1.24)
bu5hm4n requested review of D11076: efl_ui_progressbar: fix theming of progressbar.
Mon, Jan 13, 6:11 AM · efl
bu5hm4n added a child revision for D11075: efl_ui_progressbar: do not allow parts on unified widgets: D11076: efl_ui_progressbar: fix theming of progressbar.
Mon, Jan 13, 6:11 AM · efl
bu5hm4n added a revision to T8501: Efl.Ui.Progressbar: D11076: efl_ui_progressbar: fix theming of progressbar.
Mon, Jan 13, 6:11 AM · efl: api, efl (efl-1.24)
bu5hm4n requested review of D11075: efl_ui_progressbar: do not allow parts on unified widgets.
Mon, Jan 13, 6:11 AM · efl
bu5hm4n added a revision to T8501: Efl.Ui.Progressbar: D11075: efl_ui_progressbar: do not allow parts on unified widgets.
Mon, Jan 13, 6:11 AM · efl: api, efl (efl-1.24)
bu5hm4n added a comment to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

I am not talking out of fun about line 170. This is pretty much related to this patch, as this makes this test case buggy.
For future patches: GOLEN RULE: do not just add test code to random tests. add new tests. Otherwise we are left with un-debuggable test code, and that is something no one really wants to have.

Mon, Jan 13, 5:30 AM · efl
bu5hm4n added inline comments to D11072: efl.ui.textbox: replace hoversel with popup.
Mon, Jan 13, 4:50 AM · efl
bu5hm4n requested review of D11074: eina_types: declare unicode type stable.
Mon, Jan 13, 4:41 AM · efl
bu5hm4n requested changes to D11072: efl.ui.textbox: replace hoversel with popup.

That's a good start, a few things should be fixed however.

Mon, Jan 13, 4:07 AM · efl
bu5hm4n added a comment to T8501: Efl.Ui.Progressbar.

Oh sorry - i somehow missed your reply.

Mon, Jan 13, 3:52 AM · efl: api, efl (efl-1.24)
bu5hm4n accepted D11069: efl.ui.textbox: use efl_del with efl_duplicate.
Mon, Jan 13, 3:39 AM · efl
bu5hm4n requested changes to D11069: efl.ui.textbox: use efl_del with efl_duplicate.
Mon, Jan 13, 3:39 AM · efl
bu5hm4n accepted D11069: efl.ui.textbox: use efl_del with efl_duplicate.
Mon, Jan 13, 3:39 AM · efl
bu5hm4n requested changes to D11068: efl.ui.textbox: paste in mouse button 2.

Does not apply

Mon, Jan 13, 3:35 AM · efl
bu5hm4n accepted D11067: efl.ui.textbox: legacy cleanup.
Mon, Jan 13, 3:26 AM · efl
bu5hm4n requested changes to D11059: edje_entry: fix some preediting bugs.
Mon, Jan 13, 3:16 AM · efl
bu5hm4n requested changes to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Wait. This test here is buggy for me. line 170 in efl_ui_test_text.c feeds a down key that is not removed.

Mon, Jan 13, 2:58 AM · efl
bu5hm4n accepted D11020: evas_textblock: emit change event on markup_set.

Thank you :)

Mon, Jan 13, 2:16 AM · efl
bu5hm4n added inline comments to D11065: Backlight Gadget slider fixes.
Mon, Jan 13, 2:16 AM · enlightenment-git
bu5hm4n added a comment to D10968: efl_text_interactive: selection enhancment.

One thing is the rebase, the other thing are these freeze and thaws arround the copy. You say they are not needed, but they are still there, so they are planned to be removed ?

As you know there are no copy method in cursor, so we are setting position and we need to freeze the events

Mon, Jan 13, 2:13 AM · efl
bu5hm4n added a comment to D11064: evas_object_textblock: add format strings for new efl_text_style.

@woohyun shouldn't we split this somehow between the unified API and the legacy API ? so the legacy API only works with the attributes equal to the function name, and the same for the unified API ?

Mon, Jan 13, 1:49 AM · efl

Fri, Jan 10

bu5hm4n added inline comments to D11062: eina: introduce eina_iterator_process.
Fri, Jan 10, 10:57 AM · efl
bu5hm4n updated the diff for D11062: eina: introduce eina_iterator_process.

fix checks

Fri, Jan 10, 10:43 AM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

forgotten changes

Fri, Jan 10, 8:02 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11062: eina: introduce eina_iterator_process.

forgotten changes

Fri, Jan 10, 8:01 AM · efl
bu5hm4n added a child revision for D11062: eina: introduce eina_iterator_process: D11018: eina: introduce Eina_Abstract_Content.
Fri, Jan 10, 7:38 AM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

update

Fri, Jan 10, 7:38 AM · DO NOT MERGE, efl
bu5hm4n requested review of D11062: eina: introduce eina_iterator_process.
Fri, Jan 10, 7:37 AM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

more changes

Fri, Jan 10, 6:26 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D10968: efl_text_interactive: selection enhancment.

One thing is the rebase, the other thing are these freeze and thaws arround the copy. You say they are not needed, but they are still there, so they are planned to be removed ?

Fri, Jan 10, 2:25 AM · efl
bu5hm4n planned changes to D11018: eina: introduce Eina_Abstract_Content.
Fri, Jan 10, 2:22 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D11044: ecore_con: remove use of list<> from Efl.Net..

Note, you can run *all* examples after a refactor with ./examples_checks.py in the root directory.

Fri, Jan 10, 2:18 AM · efl
bu5hm4n requested changes to D11044: ecore_con: remove use of list<> from Efl.Net..

I might be a bit stuborn on this. But isn't array just the same problem as list ? Why not just entering a iterator ?

Fri, Jan 10, 2:18 AM · efl
bu5hm4n added a comment to D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

Mhm the only user of that was clouseau ... But that one does not even compile after renames and eolian changes, what should we do ?

Fri, Jan 10, 2:15 AM · efl
bu5hm4n requested changes to D11040: Efl.Ui.Textbox: Fix Ctrl+Backspace & Ctrl+Delete keys.

Please rebase this patch on latest master

Fri, Jan 10, 2:09 AM · efl
bu5hm4n added a comment to D11035: efl.ui.textbox: clean text box from unused interfaces implementation (FILE interface).

To be honest, i would either like to see something replacing this feature. But never just removing it ... The listing of Apps that use this stuff is showing quite a bit that we have a rather big community interest for this.

Fri, Jan 10, 1:09 AM · efl

Thu, Jan 9

bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

Apply planned changes.

Thu, Jan 9, 1:07 PM · DO NOT MERGE, efl
bu5hm4n added a comment to D10968: efl_text_interactive: selection enhancment.

I am still missing a answer to the question why things here have been freezed ?

Thu, Jan 9, 1:04 AM · efl

Wed, Jan 8

bu5hm4n planned changes to D11018: eina: introduce Eina_Abstract_Content.
Wed, Jan 8, 11:57 PM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

add eina_value implementation

Wed, Jan 8, 1:01 PM · DO NOT MERGE, efl
bu5hm4n accepted D11006: efl_ui/spin_button: fix step clamping.

slider seems to work like this.

Wed, Jan 8, 12:58 PM · efl
bu5hm4n accepted D11034: efl.text.cursor: change to abstract class.

Thank you!

Wed, Jan 8, 8:51 AM · efl
bu5hm4n accepted D11041: ci: travis: enable ptrace capabilities to our docker runs.
Wed, Jan 8, 5:19 AM · efl
bu5hm4n accepted D11025: efl_ui_textbox: replace elm_obj stuff and focuse stuff.

Looks good to me, @woohyun any last complains ? :)

Wed, Jan 8, 3:56 AM · efl
bu5hm4n added a comment to D11025: efl_ui_textbox: replace elm_obj stuff and focuse stuff.

I would remove it.

Wed, Jan 8, 3:39 AM · efl
bu5hm4n added a comment to T8547: Efl.Ui.Selection: efl_ui_selection_get type clipboard not fired.

To be honest, you keep acting like you know it better. It was not me that tried to talk about off topic things here, and my patience for dealing with this kind of communication is at 0.

Wed, Jan 8, 2:21 AM
bu5hm4n added a comment to T8541: Efl.Input.Text.

Forget my comment, i was maybe not fully awake when i wrote that :-D

Wed, Jan 8, 1:43 AM · efl: language bindings, efl: api
bu5hm4n requested changes to D11034: efl.text.cursor: change to abstract class.

@YOhoho @lauromoura Can anyone check that we do not accidentally break something here with the C# bindings ?

Wed, Jan 8, 1:29 AM · efl