Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (330 w, 2 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n added a comment to D11634: exactness: protect against forked calls.

That does also not work, because a eventual execp would overwrite anything in there, that is not in a environmemt variable .

Wed, Apr 1, 8:46 AM · efl
bu5hm4n added a comment to D11634: exactness: protect against forked calls.

@zmike mhm it cannot fix the issue here, as the same might happen theoretically due to evas forking, or efl_net or eio or eeze ... we have a lot places where we do that ...

Wed, Apr 1, 8:39 AM · efl
bu5hm4n added reviewers for D11634: exactness: protect against forked calls: stefan_schmidt, segfaultxavi, zmike.
Wed, Apr 1, 8:24 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

this time a working possibility

Wed, Apr 1, 8:24 AM · efl
bu5hm4n added a comment to D11635: elm_naviframe: Do not pop top item if top item..

While i agree with @Jaehyun_Cho what do you think of adding a flag to enable that feature ? The feature itself sounds usefull to me :)

Wed, Apr 1, 3:44 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

git add -p mistake

Wed, Apr 1, 3:15 AM · efl
bu5hm4n requested review of D11634: exactness: protect against forked calls.
Wed, Apr 1, 3:02 AM · efl

Yesterday

bu5hm4n updated the diff for D11610: exactness_recorder: move to preload.

add mingw stubs

Tue, Mar 31, 2:45 AM · efl
bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

add windows stubs

Tue, Mar 31, 2:43 AM · efl
bu5hm4n requested review of D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 1:33 AM · efl
bu5hm4n added a child revision for D11624: exactness: equip with ERR and CRIT: D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 1:33 AM · efl

Mon, Mar 30

bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

typo

Mon, Mar 30, 10:46 AM · efl
bu5hm4n updated the diff for D11616: exactness_play: introduce runner script.

typo

Mon, Mar 30, 10:45 AM · efl
bu5hm4n added inline comments to D11615: exactness_play: transform to LD_PRELOAD library.
Mon, Mar 30, 10:43 AM · efl
bu5hm4n added a comment to D11615: exactness_play: transform to LD_PRELOAD library.

(Sorry forgot to click on Submit before)

Mon, Mar 30, 10:38 AM · efl
bu5hm4n updated the diff for D11624: exactness: equip with ERR and CRIT.

*too much find&replace

Mon, Mar 30, 9:30 AM · efl
bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

remove doubled line

Mon, Mar 30, 9:28 AM · efl
bu5hm4n updated the diff for D11610: exactness_recorder: move to preload.

remove doubled line

Mon, Mar 30, 9:28 AM · efl
bu5hm4n updated the diff for D11624: exactness: equip with ERR and CRIT.

CRIT -> CRI

Mon, Mar 30, 9:24 AM · efl
bu5hm4n planned changes to D11624: exactness: equip with ERR and CRIT.
Mon, Mar 30, 9:17 AM · efl
bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

Resolve fixme

Mon, Mar 30, 8:38 AM · efl
bu5hm4n updated the diff for D11610: exactness_recorder: move to preload.

resolve FIXME

Mon, Mar 30, 8:37 AM · efl
bu5hm4n added a child revision for D11623: exactness_recorder: refactor main method: D11610: exactness_recorder: move to preload.
Mon, Mar 30, 8:37 AM · efl
bu5hm4n requested review of D11624: exactness: equip with ERR and CRIT.
Mon, Mar 30, 8:36 AM · efl
bu5hm4n added a child revision for D11618: exactness: correctly call mkdir: D11624: exactness: equip with ERR and CRIT.
Mon, Mar 30, 8:36 AM · efl
bu5hm4n requested review of D11623: exactness_recorder: refactor main method.
Mon, Mar 30, 8:35 AM · efl
bu5hm4n requested review of D11622: efl_ui_textbox: pass in correct seat.
Mon, Mar 30, 7:31 AM · efl
bu5hm4n added a revision to T8639: Efl.Ui.Textbox Copy and Paste: D11622: efl_ui_textbox: pass in correct seat.
Mon, Mar 30, 7:31 AM · efl (efl-1.24)
bu5hm4n added a comment to D11620: Replace strncmp code.

yeah - but it did not, one of the review comments on my cnp revisions was that this is bad to read, and i should replace them with eina_has_prefix, i did that here, and a single one more, i did not intend to search every spot in EFL and replace every single instance.

Mon, Mar 30, 7:28 AM · efl
bu5hm4n added a comment to D11620: Replace strncmp code.

Because only these where caught by my sed replacement :)

Mon, Mar 30, 7:23 AM · efl
bu5hm4n updated the diff for D11610: exactness_recorder: move to preload.

rebase

Mon, Mar 30, 5:15 AM · efl
bu5hm4n closed T8547: Efl.Ui.Selection: efl_ui_selection_get type clipboard not fired as Resolved.

Right now your testcode has a little bug, you need to listen to the resolving of the promise *and* the rejection.

#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include <Efl_Ui.h>
#include <Elementary.h>
Mon, Mar 30, 4:38 AM
bu5hm4n closed T7221: efl_selection_manager: implement full clipboard support as Resolved.

Hey hey hey! nice find! yeah that is now implemented :)

Mon, Mar 30, 3:03 AM · efl (efl-1.24), Active Work Proposal, efl: widgets, Restricted Project
bu5hm4n requested review of D11620: Replace strncmp code.
Mon, Mar 30, 2:28 AM · efl
bu5hm4n accepted D11619: elm_atspi_bridge: initialize variables.

Thank you!

Mon, Mar 30, 1:01 AM · efl

Fri, Mar 27

bu5hm4n requested review of D11618: exactness: correctly call mkdir.
Fri, Mar 27, 10:56 AM · efl
bu5hm4n added a child revision for D11617: exactness: do not efl_del the evas: D11618: exactness: correctly call mkdir.
Fri, Mar 27, 10:56 AM · efl
bu5hm4n requested review of D11617: exactness: do not efl_del the evas.
Fri, Mar 27, 10:56 AM · efl
bu5hm4n added a child revision for D11616: exactness_play: introduce runner script: D11617: exactness: do not efl_del the evas.
Fri, Mar 27, 10:56 AM · efl
bu5hm4n requested review of D11616: exactness_play: introduce runner script.
Fri, Mar 27, 10:55 AM · efl
bu5hm4n added a child revision for D11615: exactness_play: transform to LD_PRELOAD library: D11616: exactness_play: introduce runner script.
Fri, Mar 27, 10:55 AM · efl
bu5hm4n requested review of D11615: exactness_play: transform to LD_PRELOAD library.
Fri, Mar 27, 10:55 AM · efl
bu5hm4n added a child revision for D11614: exactness_player: refactor main method: D11615: exactness_play: transform to LD_PRELOAD library.
Fri, Mar 27, 10:54 AM · efl
bu5hm4n requested review of D11614: exactness_player: refactor main method.
Fri, Mar 27, 10:54 AM · efl
bu5hm4n added a child revision for D11613: exactness: remove code for compiling: D11614: exactness_player: refactor main method.
Fri, Mar 27, 10:54 AM · efl
bu5hm4n requested review of D11613: exactness: remove code for compiling.
Fri, Mar 27, 10:54 AM · efl
bu5hm4n added a child revision for D11611: exactness_record: introduce runner script: D11613: exactness: remove code for compiling.
Fri, Mar 27, 10:54 AM · efl
bu5hm4n added inline comments to D11610: exactness_recorder: move to preload.
Fri, Mar 27, 6:44 AM · efl
bu5hm4n accepted D11601: ci: travis: enable s390x build on daily cron.
Fri, Mar 27, 6:37 AM · efl
bu5hm4n accepted D11586: travis: enable more archs during cron build.
Fri, Mar 27, 6:36 AM · efl
bu5hm4n accepted D11585: ci: install needed packages for ppc64le builds.
Fri, Mar 27, 6:36 AM · efl
bu5hm4n requested review of D11611: exactness_record: introduce runner script.
Fri, Mar 27, 3:28 AM · efl
bu5hm4n added a child revision for D11610: exactness_recorder: move to preload: D11611: exactness_record: introduce runner script.
Fri, Mar 27, 3:28 AM · efl
bu5hm4n requested review of D11610: exactness_recorder: move to preload.
Fri, Mar 27, 3:27 AM · efl
bu5hm4n added a child revision for D11609: exactness_recorder: cleanup code a bit: D11610: exactness_recorder: move to preload.
Fri, Mar 27, 3:27 AM · efl
bu5hm4n requested review of D11609: exactness_recorder: cleanup code a bit.
Fri, Mar 27, 3:27 AM · efl
bu5hm4n added a comment to D11508: evas_object_textblock: reduce layout calculations.

I am not sure the removal of the is_v is a good idea, (@zmike isnt it possible that the call to render is somehow changing the visible state of the textblock ?)

Fri, Mar 27, 1:17 AM · efl

Thu, Mar 26

bu5hm4n added a comment to D11592: eo: move all call assignment.

@stefan_schmidt, these numbers are messured with perf stat -e cache-misses elementary_perf.

Thu, Mar 26, 5:55 AM · efl
bu5hm4n added inline comments to D11603: eina: prefetch for _eo_obj_pointer_get.
Thu, Mar 26, 5:51 AM · efl
bu5hm4n requested review of D11603: eina: prefetch for _eo_obj_pointer_get.
Thu, Mar 26, 3:45 AM · efl

Wed, Mar 25

bu5hm4n abandoned D11566: eo: do not allocate too much memory.

I dont know what happened there ... git phab crashed when i was proposing them ... i dont know ...

Wed, Mar 25, 1:52 PM · efl
bu5hm4n abandoned D11567: edje_cc: free ecore_evas.
Wed, Mar 25, 1:51 PM · efl
bu5hm4n abandoned D11568: eo: do not null out the vtable chain of your own classes.
Wed, Mar 25, 1:51 PM · efl
bu5hm4n abandoned D11569: eo: do not NULL out the object itself.
Wed, Mar 25, 1:50 PM · efl
bu5hm4n abandoned D11570: eo: do no allocate a 0 sized segment.
Wed, Mar 25, 1:50 PM · efl
bu5hm4n updated the diff for D11600: exactness: handbuild a new argv array instead of reassemling the new one.

add correct field

Wed, Mar 25, 9:11 AM · efl
bu5hm4n updated the diff for D11600: exactness: handbuild a new argv array instead of reassemling the new one.

add exactness_player

Wed, Mar 25, 9:07 AM · efl
bu5hm4n updated the diff for D11600: exactness: handbuild a new argv array instead of reassemling the new one.

better commit message, git add -p accident

Wed, Mar 25, 7:41 AM · efl
bu5hm4n requested review of D11600: exactness: handbuild a new argv array instead of reassemling the new one.
Wed, Mar 25, 7:31 AM · efl
bu5hm4n abandoned D11535: eo: rework vtable allocation scheme.

This is merged.

Wed, Mar 25, 4:00 AM · efl
bu5hm4n added a comment to D11010: efl_ui_spin_button: add tests for direct input feature.

works with the commits related to that: https://travis-ci.org/github/Enlightenment/efl/builds/666696748

Wed, Mar 25, 2:47 AM · efl
bu5hm4n updated the diff for D11010: efl_ui_spin_button: add tests for direct input feature.

rebase

Wed, Mar 25, 2:46 AM · efl
bu5hm4n added a child revision for D11009: efl_ui_spin_button: add test for sequential inc: D11010: efl_ui_spin_button: add tests for direct input feature.
Wed, Mar 25, 2:46 AM · efl
bu5hm4n added a child revision for D11597: suite_helper: do not use stacked values here: D11010: efl_ui_spin_button: add tests for direct input feature.
Wed, Mar 25, 2:46 AM · efl
bu5hm4n requested review of D11597: suite_helper: do not use stacked values here.
Wed, Mar 25, 2:42 AM · efl
bu5hm4n added a child revision for D11596: evas_textblock_tests: do not free a text cursor here: D11597: suite_helper: do not use stacked values here.
Wed, Mar 25, 2:41 AM · efl
bu5hm4n requested review of D11596: evas_textblock_tests: do not free a text cursor here.
Wed, Mar 25, 2:41 AM · efl
bu5hm4n added a child revision for D11595: efl_check: unset the callback here: D11596: evas_textblock_tests: do not free a text cursor here.
Wed, Mar 25, 2:41 AM · efl
bu5hm4n requested review of D11595: efl_check: unset the callback here.
Wed, Mar 25, 2:40 AM · efl
bu5hm4n added a child revision for D11594: evas: free font lists correctly: D11595: efl_check: unset the callback here.
Wed, Mar 25, 2:40 AM · efl
bu5hm4n requested review of D11594: evas: free font lists correctly.
Wed, Mar 25, 2:40 AM · efl
bu5hm4n added a child revision for D11533: edje/multisense: track and destroy multisense inputs on shutdown: D11594: evas: free font lists correctly.
Wed, Mar 25, 2:40 AM · efl
bu5hm4n requested review of D11593: eo: use eina_prefetch.
Wed, Mar 25, 2:20 AM · efl
bu5hm4n added a child revision for D11592: eo: move all call assignment: D11593: eo: use eina_prefetch.
Wed, Mar 25, 2:20 AM · efl
bu5hm4n requested review of D11592: eo: move all call assignment.
Wed, Mar 25, 2:20 AM · efl
bu5hm4n requested review of D11591: eo: there is no reason to equip for calls to classes.
Wed, Mar 25, 2:19 AM · efl

Tue, Mar 24

bu5hm4n accepted D11584: evas/render: minor cleanups for norender functions.
Tue, Mar 24, 12:44 PM · efl
bu5hm4n accepted D11582: evas: add function for norendering with updates.

After speaking on irc, this will be done in another revision

Tue, Mar 24, 10:20 AM · efl
bu5hm4n accepted D11581: evas/render: produce update regions when do_draw isn't set but make_updates is.
Tue, Mar 24, 10:16 AM · efl
bu5hm4n added inline comments to D11582: evas: add function for norendering with updates.
Tue, Mar 24, 10:16 AM · efl
bu5hm4n accepted D11583: tests/elm: use norender_with_updates.
Tue, Mar 24, 10:15 AM · efl
bu5hm4n added a comment to D11572: edje_cc: free ecore_evas.

https://i.pinimg.com/originals/28/5b/d8/285bd859271e26b94c3ce54881d0bddb.jpg

Tue, Mar 24, 7:54 AM · efl
bu5hm4n requested review of D11580: eo: free vtable when erroring out.
Tue, Mar 24, 7:52 AM · efl
bu5hm4n added a child revision for D11579: eo: do not check this here: D11580: eo: free vtable when erroring out.
Tue, Mar 24, 7:52 AM · efl
bu5hm4n requested review of D11579: eo: do not check this here.
Tue, Mar 24, 7:52 AM · efl
bu5hm4n requested review of D11578: eo: fix wrong formatting.
Tue, Mar 24, 7:45 AM · efl
bu5hm4n added a child revision for D11577: eo: only really copy when there is content: D11578: eo: fix wrong formatting.
Tue, Mar 24, 7:45 AM · efl
bu5hm4n requested review of D11577: eo: only really copy when there is content.
Tue, Mar 24, 7:45 AM · efl
bu5hm4n added a child revision for D11576: eo: correctly flag allocated memory: D11577: eo: only really copy when there is content.
Tue, Mar 24, 7:45 AM · efl
bu5hm4n requested review of D11576: eo: correctly flag allocated memory.
Tue, Mar 24, 7:44 AM · efl