Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (254 w, 1 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n requested review of D7164: eina_cxx: use efl_new instead of efl_add.
Tue, Oct 16, 1:12 AM · efl
bu5hm4n added a child revision for D7163: eolian_cxx: PACKAGE_DATA_DIR is completly wrong here: D7164: eina_cxx: use efl_new instead of efl_add.
Tue, Oct 16, 1:12 AM · efl
bu5hm4n requested review of D7163: eolian_cxx: PACKAGE_DATA_DIR is completly wrong here.
Tue, Oct 16, 12:12 AM · efl

Yesterday

bu5hm4n requested review of D7161: meson: another build break fix.
Mon, Oct 15, 11:19 AM · efl
bu5hm4n added a child revision for D7159: meson: fix build files size explosion: D7161: meson: another build break fix.
Mon, Oct 15, 11:19 AM · efl
bu5hm4n added a comment to D7109: efl_selection: add return value check for fwrite.

@Hermet my take on this is that line 175-178 should be removed and replaced with a DBG, and the content (seldata->content.mem) should NEVER ever be printed. It could contain a image or binary data just indicated with a mimetype in the beginning - that is nothing we want to print out on the terminal. (It could contain escape codes or things like this, which could lead to weird behaviour in a terminal emulator.)

Mon, Oct 15, 8:49 AM · efl

Sat, Oct 13

bu5hm4n removed a child revision for D7157: evas image: fix non-rendered preload image.: D7159: meson: fix build files size explosion.
Sat, Oct 13, 3:27 AM · efl
bu5hm4n removed a parent revision for D7159: meson: fix build files size explosion: D7157: evas image: fix non-rendered preload image..
Sat, Oct 13, 3:27 AM · efl
bu5hm4n requested review of D7159: meson: fix build files size explosion.
Sat, Oct 13, 3:27 AM · efl
bu5hm4n added a child revision for D7157: evas image: fix non-rendered preload image.: D7159: meson: fix build files size explosion.
Sat, Oct 13, 3:27 AM · efl

Fri, Oct 12

bu5hm4n added 1 commit(s) for D7130: elementary: shutdown cocoa currently: rEFLa82b24aaa8df: elementary: shutdown cocoa currently.
Fri, Oct 12, 7:03 AM · efl

Thu, Oct 11

bu5hm4n added a comment to D7109: efl_selection: add return value check for fwrite.

@Hermet all this is debugging output, this should actually never been in the function IMO. And errors in return values don't matter at all there. But those are just my two cents :)

Thu, Oct 11, 11:46 PM · efl
bu5hm4n added a comment to T7426: Cross compile efl.

eolian_gen is just the binary variable that is used to call eolian_gen in the build process.

Thu, Oct 11, 9:38 AM · efl: meson
bu5hm4n added a comment to T7426: Cross compile efl.

The approach yes. However your goal can be achived a lot easier :)

Thu, Oct 11, 7:49 AM · efl: meson

Wed, Oct 10

bu5hm4n updated the diff for D7150: build: e_gadget_loader is using dlsym.
Wed, Oct 10, 5:43 AM · enlightenment-git
bu5hm4n requested review of D7155: meson: do not build deprecated wl & drm.
Wed, Oct 10, 4:31 AM · efl
bu5hm4n added a comment to T7426: Cross compile efl.

I never really tried it myself, but its probebly enough to have something like

[binaries]
eolian_gen = ['path-to-eolian-gen']

In the cross file.
(http://mesonbuild.com/Cross-compilation.html#defining-the-environment)

Wed, Oct 10, 4:04 AM · efl: meson
bu5hm4n accepted D7153: evas: remove redundant internal functions..

Looks good to me.
Is the struct in our API or not ?

Wed, Oct 10, 3:47 AM · efl
bu5hm4n accepted D7151: elementary: fix a typo on override func of signal_callback_del.
Wed, Oct 10, 2:43 AM · efl
bu5hm4n accepted D7152: ecore_wl2: fix coverity issue. (Resource Leak).
Wed, Oct 10, 1:23 AM · efl
bu5hm4n requested changes to D7152: ecore_wl2: fix coverity issue. (Resource Leak).
Wed, Oct 10, 1:13 AM · efl

Tue, Oct 9

bu5hm4n added a comment to D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.

... This ... breaks ... eolian_suite ... even CI reported it!

Tue, Oct 9, 12:42 PM · efl
bu5hm4n requested review of D7150: build: e_gadget_loader is using dlsym.
Tue, Oct 9, 12:22 PM · enlightenment-git
bu5hm4n requested review of D7149: meson: add dl to eina.
Tue, Oct 9, 12:18 PM · efl
bu5hm4n added a comment to T7426: Cross compile efl.

Yes this is not done yet. I just landed the first bunch so it is ready for more, this is deinfintly something that needs to be done - however, i don't have time yet.

Tue, Oct 9, 4:45 AM · efl: meson

Sat, Oct 6

bu5hm4n requested review of D7147: eo: add log domain to the testsuite.
Sat, Oct 6, 2:25 AM · efl
bu5hm4n added a child revision for D7145: meson: support older udev systems: D7147: eo: add log domain to the testsuite.
Sat, Oct 6, 2:25 AM · efl

Thu, Oct 4

bu5hm4n requested review of D7145: meson: support older udev systems.
Thu, Oct 4, 10:38 AM · efl
bu5hm4n added a child revision for D7144: meson: unify system properties: D7145: meson: support older udev systems.
Thu, Oct 4, 10:38 AM · efl
bu5hm4n requested review of D7144: meson: unify system properties.
Thu, Oct 4, 9:34 AM · efl
bu5hm4n added a child revision for D7143: meson: add sizeof checks for meson: D7144: meson: unify system properties.
Thu, Oct 4, 9:34 AM · efl
bu5hm4n updated the diff for D7143: meson: add sizeof checks for meson.
Thu, Oct 4, 9:34 AM · efl
bu5hm4n added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

Okay - but if you aren't happy with the current situation, then things are likely to be changed anyways. With this we have a solution for the constructor things for now. If things change this will get reimplemented in a different way. But in the meantime we have a solution ... :)

Thu, Oct 4, 6:32 AM · efl: language bindings
bu5hm4n added a comment to D7143: meson: add sizeof checks for meson.

funfact of the day:

Thu, Oct 4, 5:30 AM · efl
bu5hm4n added reviewers for D7143: meson: add sizeof checks for meson: netstar, raster, stefan_schmidt.
Thu, Oct 4, 5:29 AM · efl
bu5hm4n added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

@segfaultxavi @bu5hm4n
Thank you for your explanation. It helps my understanding about Eolian clearly.

@segfaultxavi

  1. Mixins
    1. Mixins inherit from their primary ancestor, which must be another mixin or an interface.

Do you mean abstract class as an interface? (i.e. mixin can inherit from abstract class as primary ancestor)

Thu, Oct 4, 5:28 AM · efl: language bindings, Restricted Project
bu5hm4n accepted D7139: ecore_con_legacy: fix coverity issues (use after free).

That is correct thx! :)

Thu, Oct 4, 5:25 AM · efl
bu5hm4n requested review of D7143: meson: add sizeof checks for meson.
Thu, Oct 4, 5:22 AM · efl
bu5hm4n accepted D7142: eeze: Add buildsystem to list of dependencies..
Thu, Oct 4, 4:37 AM · efl
bu5hm4n requested changes to D7139: ecore_con_legacy: fix coverity issues (use after free).

Mhmm this appears to not be usefull :(

Thu, Oct 4, 3:25 AM · efl

Wed, Oct 3

bu5hm4n added reviewers for D7132: meson: install compat ethumb_client.pc file: billiob, netstar, raster.
Wed, Oct 3, 9:17 AM · efl
bu5hm4n requested review of D7132: meson: install compat ethumb_client.pc file.
Wed, Oct 3, 9:07 AM · efl
bu5hm4n accepted D7131: meson : fix eina/meson.build.

THX :) will Land soon, I am not at a laptop right now.

Wed, Oct 3, 3:40 AM · efl
bu5hm4n added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I'm not sure removing Mixin from inheritance tree helps in anyway.

Let's say we create class A (everything in Eolian) and it inherits from Mixin M and regular class B.

Now, Mixin M inherits from regular class C too. If we remove Mixin, we still need to inherit
form both B and C in A, which is still a multi-inheritance problem.

Regards,

Indeed, the diamond problem is already in our hierarchy, no matter how we implement it in C# (look at the picture linked above).

I think mixins have been abused inadvertently: There are 40 EFL mixins (I am not counting legacy), of which, at least:

  • 6 inherit from Efl.Object
  • 3 inherit from Efl.Ui.Widget (OMG! look at the diagram for efl_ui_view_list.eo)

    All these have to be fixed. Remember that this task is about "Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract", so the parent task can continue ("Not allow multi class inheritance in eo").
Wed, Oct 3, 12:19 AM · efl: language bindings, Restricted Project

Tue, Oct 2

bu5hm4n added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I actaully don't know right now what this is abount resolving what exactly ?

Tue, Oct 2, 11:14 PM · efl: language bindings, Restricted Project
bu5hm4n closed T7299: disabling components is broken, a subtask of T6609: Port efl to meson, as Resolved.
Tue, Oct 2, 8:27 AM · efl: meson, Restricted Project
bu5hm4n closed T7299: disabling components is broken as Resolved.
Tue, Oct 2, 8:27 AM · efl: meson, Restricted Project
bu5hm4n requested review of D7130: elementary: shutdown cocoa currently.
Tue, Oct 2, 7:59 AM · efl
bu5hm4n added a child revision for D7012: here comes meson: D7130: elementary: shutdown cocoa currently.
Tue, Oct 2, 7:59 AM · efl
bu5hm4n added a comment to D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

I will check it once i am back at home on the mac and then merge it :)

Tue, Oct 2, 4:34 AM · efl
bu5hm4n accepted D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Okay, now i understand what you are doing :)

Tue, Oct 2, 4:33 AM · efl
bu5hm4n added a comment to D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Uuuuhm, how can strlen return a same value of the string does not terminate with /0? O.o

Tue, Oct 2, 4:14 AM · efl

Mon, Oct 1

bu5hm4n requested review of D7124: elm_widget_item_static_focus: prepare the gengrid before preparing items.
Mon, Oct 1, 1:53 AM · efl
bu5hm4n requested review of D7123: gengrid: unset last_focused pointer when focus moved away.
Mon, Oct 1, 1:53 AM · efl
bu5hm4n added a child revision for D7123: gengrid: unset last_focused pointer when focus moved away: D7124: elm_widget_item_static_focus: prepare the gengrid before preparing items.
Mon, Oct 1, 1:53 AM · efl
bu5hm4n updated the diff for D7102: efl_ui_focus: add flag to indicate if a child has the focus.

...

Mon, Oct 1, 1:53 AM · efl
bu5hm4n added a child revision for D7102: efl_ui_focus: add flag to indicate if a child has the focus: D7123: gengrid: unset last_focused pointer when focus moved away.
Mon, Oct 1, 1:53 AM · efl
bu5hm4n added a revision to T7391: gengrid: gengrid item is not unfocused when gengrid unfocused: D7124: elm_widget_item_static_focus: prepare the gengrid before preparing items.
Mon, Oct 1, 1:53 AM · Restricted Project
bu5hm4n added a revision to T7391: gengrid: gengrid item is not unfocused when gengrid unfocused: D7123: gengrid: unset last_focused pointer when focus moved away.
Mon, Oct 1, 1:53 AM · Restricted Project
bu5hm4n updated the diff for D7100: elm: add unfocus / focus signals to gen* and toolbar.

...

Mon, Oct 1, 1:52 AM · efl
bu5hm4n updated the diff for D7099: efl_ui_focus_manager: rename a event.

...

Mon, Oct 1, 1:52 AM · efl

Fri, Sep 28

bu5hm4n added a reviewer for D7105: efl_ui_dnd: fixup leaking inits and code duplication: herb.
Fri, Sep 28, 12:30 AM · efl

Thu, Sep 27

bu5hm4n added a comment to D7103: elm: update widgets that have documented focus and unfocused events.

the focus, unfocus legacy events are a bit weird, focus or unfocus usally means that this element has focus, this is the entry point where key events are emitted. However, this is not the case for composition. The focus is on one of the internal elements of the widget, not the composition widget.

Thu, Sep 27, 4:57 AM · efl
bu5hm4n accepted D7116: efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value".
Thu, Sep 27, 12:40 AM · efl
bu5hm4n added a comment to D7112: efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value.

In case cd->stack is NULL then top_cd can be NULL I guess ... :) @YOhoho

Thu, Sep 27, 12:06 AM · efl

Tue, Sep 25

bu5hm4n updated the diff for D7012: here comes meson.

....

Tue, Sep 25, 8:56 AM · efl
bu5hm4n added a reviewer for D7105: efl_ui_dnd: fixup leaking inits and code duplication: devilhorns.
Tue, Sep 25, 6:35 AM · efl
bu5hm4n added a reviewer for D7104: eina: move definition of EFL64: devilhorns.
Tue, Sep 25, 6:35 AM · efl
bu5hm4n added a comment to D7012: here comes meson.

Its not perfect yes, but its the meson default, i don't like to change that :)

Tue, Sep 25, 6:32 AM · efl
bu5hm4n closed T7333: EFL meson branch crash in elementary suite. as Resolved.

Seems to be resolved. Cannot be reproduced anymore

Tue, Sep 25, 6:21 AM · efl: meson, efl (efl-1.22)
bu5hm4n requested review of D7105: efl_ui_dnd: fixup leaking inits and code duplication.
Tue, Sep 25, 6:18 AM · efl
bu5hm4n added a child revision for D7104: eina: move definition of EFL64: D7105: efl_ui_dnd: fixup leaking inits and code duplication.
Tue, Sep 25, 6:18 AM · efl
bu5hm4n requested review of D7104: eina: move definition of EFL64.
Tue, Sep 25, 6:18 AM · efl
bu5hm4n added a child revision for D7012: here comes meson: D7104: eina: move definition of EFL64.
Tue, Sep 25, 6:18 AM · efl

Mon, Sep 24

bu5hm4n triaged T7412: Software rendering freezes in xdebug.sh as High priority.
Mon, Sep 24, 7:27 AM · efl: rendering
bu5hm4n added a revision to T7391: gengrid: gengrid item is not unfocused when gengrid unfocused: D7100: elm: add unfocus / focus signals to gen* and toolbar.
Mon, Sep 24, 3:32 AM · Restricted Project
bu5hm4n added a task to D7100: elm: add unfocus / focus signals to gen* and toolbar: T7391: gengrid: gengrid item is not unfocused when gengrid unfocused.
Mon, Sep 24, 3:32 AM · efl
bu5hm4n requested review of D7103: elm: update widgets that have documented focus and unfocused events.
Mon, Sep 24, 3:27 AM · efl
bu5hm4n requested review of D7102: efl_ui_focus: add flag to indicate if a child has the focus.
Mon, Sep 24, 3:27 AM · efl
bu5hm4n added a child revision for D7102: efl_ui_focus: add flag to indicate if a child has the focus: D7103: elm: update widgets that have documented focus and unfocused events.
Mon, Sep 24, 3:27 AM · efl
bu5hm4n added a revision to T7386: Elm_Spinner does not emit "focused" "unfocused" signal when focused: D7103: elm: update widgets that have documented focus and unfocused events.
Mon, Sep 24, 3:26 AM · Restricted Project
bu5hm4n added a child revision for D7100: elm: add unfocus / focus signals to gen* and toolbar: D7102: efl_ui_focus: add flag to indicate if a child has the focus.
Mon, Sep 24, 3:26 AM · efl
bu5hm4n updated the diff for D7100: elm: add unfocus / focus signals to gen* and toolbar.
Mon, Sep 24, 3:26 AM · efl
bu5hm4n updated the diff for D7099: efl_ui_focus_manager: rename a event.
Mon, Sep 24, 3:26 AM · efl

Sun, Sep 23

bu5hm4n requested review of D7100: elm: add unfocus / focus signals to gen* and toolbar.
Sun, Sep 23, 8:10 AM · efl
bu5hm4n added a child revision for D7099: efl_ui_focus_manager: rename a event: D7100: elm: add unfocus / focus signals to gen* and toolbar.
Sun, Sep 23, 8:10 AM · efl
bu5hm4n requested review of D7099: efl_ui_focus_manager: rename a event.
Sun, Sep 23, 8:10 AM · efl

Fri, Sep 21

bu5hm4n accepted D7097: efl_vg: calculate center point with double type.

Ignore my comment :)

Fri, Sep 21, 6:02 AM · efl
bu5hm4n requested changes to D7097: efl_vg: calculate center point with double type.

Wait,

Fri, Sep 21, 6:01 AM · efl
bu5hm4n accepted D7071: docs: Fix Efl.Ui.Focus.Object.Focus() docs.
Fri, Sep 21, 2:34 AM · efl
bu5hm4n added a comment to D7028: evas_object_callbacks: do not error on NULL on del.

@ManMower it's not really about beeing lazy and not fixing all the cases, it just does not make sense. Where is the difference of you knowing that the callback is already dead, because it was already removed, the object beeing dead, so the callback is never called, or the callback is dead, because it was never registered? Its not that there is some heavy sideeffect if you call callback_del_* twice or so.

Fri, Sep 21, 12:30 AM · efl
bu5hm4n accepted D7066: eina_vpath_vdg: free locally allocated memory before return.
Fri, Sep 21, 12:27 AM · efl
bu5hm4n accepted D7086: elementary: remove meaningless memory allocation and leaking.
Fri, Sep 21, 12:26 AM · efl

Thu, Sep 20

bu5hm4n added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

No, I am talking about using "eina_vpath_resolve_snprintf" in line 21, so no free() is required :)

Thu, Sep 20, 4:21 AM · efl

Wed, Sep 19

bu5hm4n added a comment to T7351: efl-1.21.0 fails to build with '--enable-vnc-server'.

This Option only works for Android afair :)

Wed, Sep 19, 8:50 AM · efl (efl-1.21)
bu5hm4n added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

Maybe its better to use the vpath resolve variante which takes a static buffer, instead of the allocated string :)

Wed, Sep 19, 12:44 AM · efl

Tue, Sep 18

bu5hm4n added a comment to T7407: efl-mono: Crash on focus callback when quitting focus example.

To me this looks like a problem with the get text call :)

Tue, Sep 18, 9:47 AM · Restricted Project, efl: language bindings

Sep 13 2018

bu5hm4n added a comment to D6766: tests/elm: use custom tick source for animator events.

Okay, this is accepted but not landed. I am just yolo'ing it in. On @ManMowers resposibility :)

Sep 13 2018, 12:53 AM · Restricted Project
bu5hm4n requested changes to D6781: elm_genlist: unfocus item when genlist is unfocused.
Sep 13 2018, 12:51 AM · efl
bu5hm4n accepted D7018: test_gengrid: add focused, unfocused callback to test focus signal.
Sep 13 2018, 12:50 AM · efl