Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (293 w, 4 d)
Roles
Administrator
Availability
Available

Recent Activity

Thu, Jul 18

bu5hm4n accepted D9344: efl_ui/table: avoid exploding stack with lots of subobjects.

Thank you, should the same be done with the box revision from yesterday ?

Thu, Jul 18, 7:12 AM · efl
bu5hm4n requested changes to D9344: efl_ui/table: avoid exploding stack with lots of subobjects.

But we decrease count in the inlist foreach ... (Just saw it now sorry)

Thu, Jul 18, 6:58 AM · efl
bu5hm4n added a comment to T8025: efl.ui.radio_group_impl.

Radio_Group right now:
(P) selected_object
(P) selected_value
(m) register
(m) unregister
(E) value,changed

Thu, Jul 18, 5:58 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Thu, Jul 18, 4:43 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D9352: meson build: update evas search for harfbuzz.

But since it works now for you, can you abond this revision?

Thu, Jul 18, 4:21 AM · efl
bu5hm4n added inline comments to D9352: meson build: update evas search for harfbuzz.
Thu, Jul 18, 3:29 AM · efl
bu5hm4n added inline comments to D9352: meson build: update evas search for harfbuzz.
Thu, Jul 18, 3:19 AM · efl
bu5hm4n requested changes to D9352: meson build: update evas search for harfbuzz.

The pkg-config file in harfbuzz is part of the upstream project (https://github.com/harfbuzz/harfbuzz/blob/master/src/harfbuzz.pc.in).
Undependend from the rest of this patch. This should never happen, if you do not have the .pc file arround, then you only installed half of harfbuzz.

Thu, Jul 18, 2:29 AM · efl
bu5hm4n added a comment to T8025: efl.ui.radio_group_impl.

I am tired of repeating myself, and i am not going to discuss it again: https://phab.enlightenment.org/T7867#138325

Thu, Jul 18, 1:46 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T8057: RFC: Efl.Ui.Selectable.

I am also in favor of this rfc, there is just one thing that i do not like:
toggle is a API which is not in the style of the rest of EFL, we usally only have the property, flipping this bit should be fairly easy. Additionally, (from a user pov) in most cases you do not want to flip the bit, but rather set a explicit value.

Thu, Jul 18, 1:42 AM · efl: api
bu5hm4n added a comment to T7893: efl.ui.slider.
  • Using internal hidden supper weird api, that gets randomly wrong values passed.

Can I know the name of that weird API ? I also want to check together.

efl_ui_slider_move_knob
efl_ui_slider_down_knob
efl_ui_slider_val_set
efl_ui_slider_val_fetch

Thu, Jul 18, 1:34 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n accepted D9345: elm_test: rename efl.ui.scroller simple test function name.

It is impressive that such a high quality name passed review.

Thu, Jul 18, 1:17 AM · efl
bu5hm4n requested changes to D9344: efl_ui/table: avoid exploding stack with lots of subobjects.

Maybe i am a bit too anxiously, but i think we want to have some boolean flag if its on the stack or heap. In some event callback to EFL_PACK_EVENT_LAYOUT_UPDATED or change event, a user *might* add another item or removes a item, which *might* change count to something below 500 or above 500 where it was not before, which means we either call free(items); when its on the stack, or we do not free it and leak the memory.

Thu, Jul 18, 1:14 AM · efl
bu5hm4n requested changes to D9333: efl_ui_widget: add safety checks to verify parents aren't being added as children.
Thu, Jul 18, 1:11 AM · efl
bu5hm4n added a comment to D9351: evas_vg_json: Add image embedded example.

Just a site note: You can just build efl with meson and enabled examples, the example will be compiled as ./src/examples/evas-vg-json :)

Thu, Jul 18, 1:03 AM · efl
bu5hm4n moved T8024: efl.ui.radio_group from Trivial to Evaluating on the efl: api board.
Thu, Jul 18, 12:38 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n moved T8025: efl.ui.radio_group_impl from Trivial to Evaluating on the efl: api board.
Thu, Jul 18, 12:38 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n moved T8024: efl.ui.radio_group from Backlog to Trivial on the efl: api board.
Thu, Jul 18, 12:37 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n moved T8025: efl.ui.radio_group_impl from Backlog to Trivial on the efl: api board.
Thu, Jul 18, 12:37 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a project to T8025: efl.ui.radio_group_impl: efl: api.
Thu, Jul 18, 12:37 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a project to T8024: efl.ui.radio_group: efl: api.
Thu, Jul 18, 12:37 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T8025: efl.ui.radio_group_impl.

I like the proposal. However, Radio_Group is a interface and needs to stay a interface, but it can inherit from Efl.Ui.Single_Selectable. My only fear here is that the single / multi_selectable interface bring again the same problem of types that we have in the pack_linear interface. We need some sort of template in order to express the types correctly. But the overall concept does look nice. Can you create a separate "RFC: ..." ticket in the "efl: api" project?

Thu, Jul 18, 12:28 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, Jul 17

bu5hm4n accepted D9339: Eina vpath: remove support of ~username vpath on Windows.

HAVE_GETPWENT is used as a gatekeeper for functions that return passwd structs. (also in the rest of EFL).

Wed, Jul 17, 11:38 PM · efl
bu5hm4n accepted D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.
Wed, Jul 17, 11:25 PM · efl
bu5hm4n added a comment to T7897: efl.ui.spin.

I am talking about mouse-wheel event :)

Wed, Jul 17, 11:15 PM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.

Test looks fine, i will wait on @segfaultxavi for checking out the docs.

Wed, Jul 17, 11:12 PM · efl
bu5hm4n added a comment to T8056: Improve/Fix _add_internal_start_bindings function docs and behavior.

I think i should clarify the 3ed point: The API itself is not taking any reference there, it is essentially just erroring based on this flag. Who *is* taking this ref is _efl_add_end. so this is kind of missleading.

Wed, Jul 17, 1:08 PM
bu5hm4n accepted D9290: efl: add a Efl.Model_Provider that every widget will look up for in their parent tree..
Wed, Jul 17, 12:13 PM · efl
bu5hm4n accepted D9308: elementary: add a test for Efl.Ui.View interface..
Wed, Jul 17, 12:12 PM · efl
bu5hm4n accepted D9289: elementary: Efl.Ui.Image now rely on event to update model binding..

And then he said "lets do it later"

Wed, Jul 17, 12:11 PM · efl
bu5hm4n added a comment to T8055: focus is slow on startup.

The method that so so long here is the calculation of the focus graph, which takes insanely long in this case. However, it is questionable to me how we are going to improve that, (to be fair here, i know not a single reallife application that creates 2K buttons, and stuffs them in a box), we could create some sort of data structure like a BVB, or a quad tree, with some umbrella metric. The speedup for such an structure is however questionable since they most of the time only pay off if you query your whole set multiple times, and are most of the time more expensive for the first time than the actual calculation.

Wed, Jul 17, 12:09 PM · Restricted Project
bu5hm4n added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

If you are eager to remove a for loop + strncpy, feel free. However, there is no reason to make that for windows only, you could also change line 198&237 to #ifdef HAVE_GETPWENT and error directly there. This will enable the optimization for any other non getpwent platform.

Wed, Jul 17, 10:30 AM · efl
bu5hm4n added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

Wait - windows never tried before to access names, getpwnam is not available there, and it just tells the user that this is not available and returns 0. What exactly is the purpose of this patch?

Wed, Jul 17, 10:16 AM · efl
bu5hm4n added a comment to D9336: evas/box: avoid triggering smart_move callback.

@cedric but if we optimize our code with something like a module, which makes super calls direct calls, not passed through vtable. Then this results in a different behaviour. Right now i would claim that doing such a optimization is the biggest speedup vector we have, such a code would break that possibility.

Wed, Jul 17, 10:11 AM · efl
bu5hm4n added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

@vtorri i would prefer to remove the added lines from A-B, this will then just handle the platform issue in _fetch_user_homedir and the API user is informed that the platform does not support user fetching.

Wed, Jul 17, 10:10 AM · efl
bu5hm4n added a comment to D9339: Eina vpath: remove support of ~username vpath on Windows.

No - if a user is not found, a error will be raised, and 0 is returned.

Wed, Jul 17, 10:02 AM · efl
bu5hm4n added a comment to D9336: evas/box: avoid triggering smart_move callback.

eeeehm, can we solve that outside eo ? and set a flag somewhere to skip that ? That is like killing any assertion of making optimizations later on.

Wed, Jul 17, 10:00 AM · efl
bu5hm4n requested changes to D9339: Eina vpath: remove support of ~username vpath on Windows.

I think this should probebly raise a error, and not just silently return 0.

Wed, Jul 17, 9:59 AM · efl
bu5hm4n updated subscribers of D9285: Introduce Efl.Ui.Item_Container.

I would like to merge this widget at the latest on the 27.07.

Wed, Jul 17, 9:47 AM · DO NOT MERGE, efl
bu5hm4n updated the task description for T7865: efl.ui.check.
Wed, Jul 17, 9:02 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7865: efl.ui.check.
Wed, Jul 17, 8:47 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add multiselect radio

Wed, Jul 17, 8:23 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

fix scroller bouncing

Wed, Jul 17, 8:01 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D9306: efl_ui_spotlight_manager_*: cleanup canvas state on invalidate.

... git add accident

Wed, Jul 17, 6:46 AM · efl
bu5hm4n updated the diff for D9305: efl_ui_spotlight_container: mirror the behavior of view_manager.

... git add accident

Wed, Jul 17, 6:46 AM · efl
bu5hm4n updated the diff for D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

... git add accident

Wed, Jul 17, 6:46 AM · efl
bu5hm4n updated the diff for D9332: eo: add helper for checking the ownable state.

... git add accident

Wed, Jul 17, 6:46 AM · efl
bu5hm4n updated the diff for D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

git add -p accident

Wed, Jul 17, 6:44 AM · efl
bu5hm4n updated the diff for D9332: eo: add helper for checking the ownable state.

git add -p accident

Wed, Jul 17, 6:44 AM · efl
bu5hm4n added a comment to T8053: elementary crash when running under wayland.

i think you can also just take a normal elm_test window, and set the hint_min_size to something bigger than your screen.

Wed, Jul 17, 6:41 AM · efl: display system, Restricted Project
bu5hm4n added a comment to T8053: elementary crash when running under wayland.

elm_test, my screen on my raspberry pi is quite small.

Wed, Jul 17, 6:39 AM · efl: display system, Restricted Project
bu5hm4n updated the diff for D9306: efl_ui_spotlight_manager_*: cleanup canvas state on invalidate.

rebase

Wed, Jul 17, 6:28 AM · efl
bu5hm4n updated the diff for D9305: efl_ui_spotlight_container: mirror the behavior of view_manager.

return on false

Wed, Jul 17, 6:27 AM · efl
bu5hm4n updated the diff for D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

return on false

Wed, Jul 17, 6:26 AM · efl
bu5hm4n updated the diff for D9332: eo: add helper for checking the ownable state.

add return

Wed, Jul 17, 6:26 AM · efl
bu5hm4n added a comment to D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

Definition of ownable: A object is ownable, if we know, that the references that are taken, are not taken by someone else. A reference is taken by someone else, if parent is set. (parent always has 1 ref).
We surely cannot assert that the free references are really belonging to the user (because we do not have explicit reference handlers). Its not perfect, but its the best we can do i guess.

Wed, Jul 17, 6:14 AM · efl
bu5hm4n planned changes to D9332: eo: add helper for checking the ownable state.

Sure.

Wed, Jul 17, 6:08 AM · efl
bu5hm4n added a comment to T8025: efl.ui.radio_group_impl.

I totally agree with adding Clickable to check (that will also bring it to radio). (Not sure right now why we are discussing this here, and not in T7865)

Wed, Jul 17, 6:08 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T8053: elementary crash when running under wayland.

Get a window with a minsize bigger than your screen, -> maximize.

Wed, Jul 17, 6:02 AM · efl: display system, Restricted Project
bu5hm4n added a comment to T7847: efl.ui.clickable.

Mhm, a second thought about clickable until:
The class only really connects objects and and themes to the implementation, saying that such a util is bound to clickable is not really true, scrollable_util is also doing the same thing.
How about we create a class "Action_Connector", which contains such methods for clickable, scrollable, and whatever comes next? We would have a central place for such "connectors" ?

Wed, Jul 17, 2:11 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Jul 16

bu5hm4n accepted D9330: tests/elm: break out event callback function.
Tue, Jul 16, 10:33 AM · efl
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

the point is not to access the pointer. the point is to check the pointer for correctness in the testcase.

Tue, Jul 16, 9:36 AM · efl
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

You could also do:

Tue, Jul 16, 8:36 AM · efl
bu5hm4n added a comment to D9330: tests/elm: break out event callback function.

once is more expressing that it is ensuring that the callback is called once, and puts that into a int flag. You can basically do the same with a void* (Which is would like to add after that, and refactor the tests of the last few weeks)

Tue, Jul 16, 8:33 AM · efl
bu5hm4n created T8053: elementary crash when running under wayland.
Tue, Jul 16, 8:24 AM · efl: display system, Restricted Project
bu5hm4n accepted D9331: tests/elm: add test for elm_bubble "clicked" smart callback.
Tue, Jul 16, 8:18 AM · efl
bu5hm4n requested changes to D9330: tests/elm: break out event callback function.

Looks good otherwise

Tue, Jul 16, 6:59 AM · efl
bu5hm4n updated the diff for D9306: efl_ui_spotlight_manager_*: cleanup canvas state on invalidate.

rebase

Tue, Jul 16, 6:57 AM · efl
bu5hm4n updated the diff for D9305: efl_ui_spotlight_container: mirror the behavior of view_manager.

error on mistake

Tue, Jul 16, 6:57 AM · efl
bu5hm4n updated the diff for D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

error on mistake

Tue, Jul 16, 6:57 AM · efl
bu5hm4n added a child revision for D9332: eo: add helper for checking the ownable state: D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.
Tue, Jul 16, 6:57 AM · efl
bu5hm4n requested review of D9332: eo: add helper for checking the ownable state.
Tue, Jul 16, 6:56 AM · efl
bu5hm4n added a comment to D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

I agree that there should be a error preventing you from doing something that is not good. I will add a helper to eo, which makes it easy to use, (or maybe can be added completly by eolian). However, such a helper will only contain a error, and never change the state or reference things of a object. Its IMO bad if we have code that just alters the references and parents to *prepare* something for you, there is one case where it might be right, others where it might be wrong. But overall the API user should have the overview (and a error if he does wrong things).

Tue, Jul 16, 5:55 AM · efl
bu5hm4n added a comment to T7847: efl.ui.clickable.

I totally agree. #2 sounds good. Some names with Bridge, Bind & Theme/Object sound good ?

Tue, Jul 16, 5:47 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n accepted D9317: efl_ui_widget_part: implement some expected methods.
Tue, Jul 16, 5:46 AM · efl
bu5hm4n added a comment to D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager.

Ping?

Tue, Jul 16, 5:35 AM · efl
bu5hm4n added a comment to T7893: efl.ui.slider.

Just as a quick heads up of that widget:

  • Using internal hidden supper weird api, that gets randomly wrong values passed.
  • moving the key events for changing the slider does not change the value
  • events are only emitted after user did interaction, not via api
Tue, Jul 16, 5:16 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to D9317: efl_ui_widget_part: implement some expected methods.

Yes. Not doing this will also cut out all bindings.

Tue, Jul 16, 5:04 AM · efl
bu5hm4n requested review of D9329: efl_ui_slider: fix focus interaction.
Tue, Jul 16, 4:57 AM · efl
bu5hm4n requested review of D9328: efl_ui_text: fix focus breaking.
Tue, Jul 16, 4:57 AM · efl
bu5hm4n added a child revision for D9328: efl_ui_text: fix focus breaking: D9329: efl_ui_slider: fix focus interaction.
Tue, Jul 16, 4:57 AM · efl
bu5hm4n added a child revision for D9327: efl_ui_slider: change the semantical meaning of step property: D9328: efl_ui_text: fix focus breaking.
Tue, Jul 16, 4:56 AM · efl
bu5hm4n updated the diff for D9327: efl_ui_slider: change the semantical meaning of step property.

rebase

Tue, Jul 16, 4:56 AM · efl
bu5hm4n updated the diff for D9327: efl_ui_slider: change the semantical meaning of step property.

forgot a single change, sorry.

Tue, Jul 16, 3:58 AM · efl
bu5hm4n added a comment to T7882: efl.ui.scrollable_interactive.

scroll right now has a rect and a boolean flag for toggling the animation. With this you can say that the specified rectangle needs to be moved into the viewport. However, a user also might want to give a hint where the rectangle in the viewport wants to be (top-left ? center? top-right ?) A Position_2D with relative coordinates could be useful for that.

Tue, Jul 16, 3:49 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n requested review of D9327: efl_ui_slider: change the semantical meaning of step property.
Tue, Jul 16, 3:45 AM · efl
bu5hm4n added a revision to T4834: Efl.Ui.Slider step property is weird: D9327: efl_ui_slider: change the semantical meaning of step property.
Tue, Jul 16, 3:45 AM · efl: api, efl: widgets
bu5hm4n added a comment to T4834: Efl.Ui.Slider step property is weird.

the mouse drags never used the step variable, slider can get values that are outside the n*step and i think that is normal ?
Like scaling something, you might want to have a step of 0.1 but still want to reach 0.95.

Tue, Jul 16, 3:43 AM · efl: api, efl: widgets
bu5hm4n requested changes to D9317: efl_ui_widget_part: implement some expected methods.
Tue, Jul 16, 2:57 AM · efl
bu5hm4n accepted D9322: tests/actionslider: add more actionslider unit tests.

looks good.

Tue, Jul 16, 2:49 AM · efl
bu5hm4n accepted D9321: tests/elm: improve click_part() further to guess part locations.
Tue, Jul 16, 2:48 AM · efl
bu5hm4n accepted D9320: tests/elm: improve click_part() to handle non-swallow parts.
Tue, Jul 16, 2:48 AM · efl
bu5hm4n accepted D9319: elm_actionslider: fix internal state when programmatically changing value.
Tue, Jul 16, 2:46 AM · efl
bu5hm4n accepted D9318: elm_actionslider: fix signal emission for left selection.

Fixes back from '16 ... lovely ...

Tue, Jul 16, 2:46 AM · efl
bu5hm4n added a comment to D9317: efl_ui_widget_part: implement some expected methods.

I think you want to use eolian to specify that you overwrote those methods. ?

Tue, Jul 16, 2:45 AM · efl
bu5hm4n added a comment to T8025: efl.ui.radio_group_impl.

I like the 3ed the most, it would cleanup our toplevel Efl.Ui. domain a lot.

Tue, Jul 16, 2:22 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a subtask for T7845: Unstructured stabilization items: T7562: efl.input.interface.
Tue, Jul 16, 2:20 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a parent task for T7562: efl.input.interface: T7845: Unstructured stabilization items.
Tue, Jul 16, 2:20 AM · efl (efl-1.23), efl: api
bu5hm4n removed parent tasks for T7562: efl.input.interface: T7901: efl.ui.timepicker, T7849: efl.ui.text, T7899: efl.ui.table, T7897: efl.ui.spin, T7893: efl.ui.slider, T7891: efl.ui.scroller, T7885: efl.ui.list_view, T7881: efl.ui.list, T7880: efl.ui.bg, T7873: efl.ui.image, T7870: efl.ui.grid, T7869: efl.ui.datepicker, T7859: efl.ui.box.
Tue, Jul 16, 2:20 AM · efl (efl-1.23), efl: api
bu5hm4n removed a subtask for T7859: efl.ui.box: T7562: efl.input.interface.
Tue, Jul 16, 2:20 AM · efl: api, efl (efl-1.23), efl: language bindings