Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (302 w, 7 h)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n added a comment to T6815: split legacy/interfaces tests into separate suites.

What is left here ?

Mon, Sep 16, 10:12 AM · Restricted Project, Testing
bu5hm4n added a comment to T7784: Efl.Pack / Efl.Pack_Linear usage.

Part cannot be added to the interfaces with Efl.Pack_Linear, so i think that does not matter here ?

Mon, Sep 16, 9:36 AM · efl (efl-1.23), efl: widgets
bu5hm4n closed T8212: efl.1.23-alpha1 can't be compiled with meson -Deeze=false as Wontfix.

Okay, then there is not point fixing that.

Mon, Sep 16, 9:33 AM · Restricted Project
bu5hm4n closed T8170: Memory leak in efl_ui_focus_manager. as Resolved.

57c7e59850cedc496800390ce022a32b428d7154

Mon, Sep 16, 9:29 AM
bu5hm4n added inline comments to D9969: efl_ui_collection_view: support focus.
Mon, Sep 16, 7:24 AM · efl
bu5hm4n added a comment to D9969: efl_ui_collection_view: support focus.

The question is, where do we store the property focus ?

Mon, Sep 16, 5:42 AM · efl
bu5hm4n added a comment to D9959: elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View..

More testing:

  • ./src/examples/elementary/efl_ui_list_view_example_2 does not work anymore
  • ./src/examples/elementary/efl_ui_list_view_example_3 segfaults after pressing Add Item
Mon, Sep 16, 5:30 AM · efl
bu5hm4n requested review of D9970: efl_ui_position_manager_list: emit events correctly.
Mon, Sep 16, 5:20 AM · efl
bu5hm4n requested review of D9969: efl_ui_collection_view: support focus.
Mon, Sep 16, 5:20 AM · efl
bu5hm4n added a child revision for D9969: efl_ui_collection_view: support focus: D9970: efl_ui_position_manager_list: emit events correctly.
Mon, Sep 16, 5:20 AM · efl
bu5hm4n added a child revision for D9960: elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure.: D9969: efl_ui_collection_view: support focus.
Mon, Sep 16, 5:19 AM · efl
bu5hm4n moved T8096: efl.ui.collection from Backlog to Evaluating on the efl: api board.
Mon, Sep 16, 2:05 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a project to T8096: efl.ui.collection: efl: api.
Mon, Sep 16, 2:05 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n moved T7881: efl.ui.list from Backlog to Evaluating on the efl: api board.
Mon, Sep 16, 2:04 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n moved T7870: efl.ui.grid from Backlog to Evaluating on the efl: api board.
Mon, Sep 16, 2:04 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7704: verify @since tags for stabilized apis.

Ping ?

Mon, Sep 16, 2:04 AM · efl (efl-1.23), efl: docs, efl: api
bu5hm4n requested changes to D9958: elementary: introduce Efl.Ui.CollectionView a generic listing View..

Other than that this looks quite okay.

Mon, Sep 16, 1:27 AM · efl
bu5hm4n accepted D9959: elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View..

I am super happy with this one.

Mon, Sep 16, 1:23 AM · efl
bu5hm4n added a comment to D9960: elementary: add Efl.Ui.Grid_View by leveraging MVVM and Collection/Position_Manager infrastructure..

Can we get a test case in elm_test ?

Mon, Sep 16, 1:22 AM · efl
bu5hm4n requested changes to D9959: elementary: migrate Efl.Ui.List_View to use Efl.Ui.Collection_View..
Mon, Sep 16, 1:22 AM · efl
bu5hm4n added a comment to D9957: elementary: add an interface for asynchronous multi selection..

@SanghyeonLee can you take a look at this one ?

Mon, Sep 16, 1:12 AM · efl
bu5hm4n requested changes to D9956: elementary: factorize all events emitted by a Efl.Ui.Collection into their own interface..
Mon, Sep 16, 1:11 AM · efl
bu5hm4n accepted D9955: efl: make Efl.Ui.Factory.release work in batches..
Mon, Sep 16, 1:09 AM · efl
bu5hm4n requested review of D9965: efl_ui_slider: improve docs.
Mon, Sep 16, 1:03 AM · efl
bu5hm4n added a child revision for D9964: efl_ui_check: improve docs: D9965: efl_ui_slider: improve docs.
Mon, Sep 16, 1:03 AM · efl
bu5hm4n requested review of D9964: efl_ui_check: improve docs.
Mon, Sep 16, 1:02 AM · efl
bu5hm4n added a child revision for D9963: efl_ui_button: improve docs: D9964: efl_ui_check: improve docs.
Mon, Sep 16, 1:02 AM · efl
bu5hm4n requested review of D9963: efl_ui_button: improve docs.
Mon, Sep 16, 1:02 AM · efl
bu5hm4n requested changes to D9954: elementary: rework factory to have another additional stage during releasing of items..
Mon, Sep 16, 1:02 AM · efl
bu5hm4n requested changes to D9953: efl: simplify logic for widget created by factory..
Mon, Sep 16, 12:58 AM · efl
bu5hm4n added a comment to D9952: efl: split Efl.Ui.Factory.create stage into constructing and building.

I am the author ... dont want to accept this one.

Mon, Sep 16, 12:41 AM · efl
bu5hm4n accepted D9951: elementary: Efl.Ui.Layout_Factory bind property during widget creation..
Mon, Sep 16, 12:41 AM · efl
bu5hm4n added inline comments to D9950: elementary: Efl.Ui.Image_Factory bind property also during widget creation..
Mon, Sep 16, 12:40 AM · efl
bu5hm4n accepted D9949: elementary: Efl.Ui.Widget_Factory bind widget property before finalizing the widget..
Mon, Sep 16, 12:38 AM · efl
bu5hm4n added inline comments to D9948: elementary: leverage sizing information from model if available to avoid unecessary calc..
Mon, Sep 16, 12:36 AM · efl
bu5hm4n added a comment to D9947: efl_ui_position_manager: a way to announce new entities.

I would say this looks fine ... but i am the author :-D

Mon, Sep 16, 12:30 AM · efl
bu5hm4n accepted D9946: elementary: properly shutdown and cleanup Efl.Ui.Position_Manager..
Mon, Sep 16, 12:30 AM · efl
bu5hm4n accepted D9945: elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set.
Mon, Sep 16, 12:29 AM · efl
bu5hm4n accepted D9944: ecore: remove unused variable after code migration. Fix warning..
Mon, Sep 16, 12:21 AM · efl

Yesterday

bu5hm4n updated the diff for D9935: efl_ui_widget: improve docs.

!@*#*!@

Sun, Sep 15, 3:49 AM · efl
bu5hm4n updated the diff for D9935: efl_ui_widget: improve docs.

... docs

Sun, Sep 15, 3:43 AM · efl
bu5hm4n updated the task description for T7881: efl.ui.list.
Sun, Sep 15, 3:24 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7881: efl.ui.list.

This looks fine ?

Sun, Sep 15, 3:24 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T8096: efl.ui.collection.

This looks fine ?

Sun, Sep 15, 3:24 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7870: efl.ui.grid.

This looks fine ?

Sun, Sep 15, 3:24 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n requested review of D9937: efl_ui_widget: remove misleading comments.
Sun, Sep 15, 3:23 AM · efl
bu5hm4n requested review of D9936: efl_ui_widget: remove wrong docs.
Sun, Sep 15, 3:22 AM · efl
bu5hm4n added a child revision for D9936: efl_ui_widget: remove wrong docs: D9937: efl_ui_widget: remove misleading comments.
Sun, Sep 15, 3:22 AM · efl
bu5hm4n added a child revision for D9935: efl_ui_widget: improve docs: D9936: efl_ui_widget: remove wrong docs.
Sun, Sep 15, 3:22 AM · efl
bu5hm4n requested review of D9935: efl_ui_widget: improve docs.
Sun, Sep 15, 3:22 AM · efl

Fri, Sep 13

bu5hm4n added a comment to T7852: efl.ui.selectable.

Theoretically yes, we got into a name discussion in T7871

Fri, Sep 13, 12:05 PM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n closed T8187: slider Step is not correctly honored when dragging with the mouse. as Resolved.

This is now resolved.

Fri, Sep 13, 11:57 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n closed T8187: slider Step is not correctly honored when dragging with the mouse., a subtask of T7893: efl.ui.slider, as Resolved.
Fri, Sep 13, 11:57 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n requested review of D9928: efl_ui_slider: correct to a multiple of step when drag is finished.
Fri, Sep 13, 4:09 AM · efl
bu5hm4n added a revision to T8187: slider Step is not correctly honored when dragging with the mouse.: D9928: efl_ui_slider: correct to a multiple of step when drag is finished.
Fri, Sep 13, 4:09 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7717: docs todo.
Fri, Sep 13, 3:34 AM · efl (efl-1.23), efl: docs, efl: api

Thu, Sep 12

bu5hm4n updated the diff for D9918: meson: make sure evas buffer engine is built before edje_cc.

this way seems to work

Thu, Sep 12, 4:21 AM · efl
bu5hm4n planned changes to D9924: efl_ui_calendar_item: document this class a little bit more.
Thu, Sep 12, 4:12 AM · efl
bu5hm4n requested review of D9924: efl_ui_calendar_item: document this class a little bit more.
Thu, Sep 12, 4:09 AM · efl
bu5hm4n added a child revision for D9923: efl_ui_image: insert @ to link docs proberly: D9924: efl_ui_calendar_item: document this class a little bit more.
Thu, Sep 12, 4:09 AM · efl
bu5hm4n updated the diff for D9921: efl_ui_scrollable: insert @ to link docs proberly.

see comes back

Thu, Sep 12, 4:08 AM · efl
bu5hm4n requested review of D9923: efl_ui_image: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n added a child revision for D9922: efl_gfx_path: insert @ to link docs proberly: D9923: efl_ui_image: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n requested review of D9922: efl_gfx_path: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n added a child revision for D9921: efl_ui_scrollable: insert @ to link docs proberly: D9922: efl_gfx_path: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n requested review of D9921: efl_ui_scrollable: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n added a child revision for D9920: efl_object: insert @ to link docs proberly: D9921: efl_ui_scrollable: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n requested review of D9920: efl_object: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n added a child revision for D9919: efl_part: insert @ to link docs proberly: D9920: efl_object: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n requested review of D9919: efl_part: insert @ to link docs proberly.
Thu, Sep 12, 3:35 AM · efl
bu5hm4n planned changes to D9918: meson: make sure evas buffer engine is built before edje_cc.

This breaks on osx, as we cannot link modules there. I think this is not as easy at is seemed :|

Thu, Sep 12, 3:09 AM · efl
bu5hm4n requested review of D9918: meson: make sure evas buffer engine is built before edje_cc.
Thu, Sep 12, 12:53 AM · efl
bu5hm4n added a revision to T8220: meson build ordering: D9918: meson: make sure evas buffer engine is built before edje_cc.
Thu, Sep 12, 12:53 AM · Restricted Project
bu5hm4n requested review of D9917: elm_interface_scrollable: correctly honor looping over.
Thu, Sep 12, 12:44 AM · efl
bu5hm4n updated the diff for D9908: elm_interface_scrollable: correctly emit the signals always.

...

Thu, Sep 12, 12:43 AM · efl
bu5hm4n updated the diff for D9907: elm_interface_scrollable: correctly handle bouncing.

...

Thu, Sep 12, 12:43 AM · efl
bu5hm4n updated the diff for D9906: theme: redo scroller theme of elm.

add filters

Thu, Sep 12, 12:43 AM · efl
bu5hm4n added a comment to D9906: theme: redo scroller theme of elm.

I could fix the elm.loop_x stuff with a patch to elm_interface_scrollable.c. However, the clicking on a inactive scroller arrow is a little bit more tricky, i have added filters to every program that deals with this, and the result is no difference to before, i also think that we are hitting here some bug in edje, as chaning the position of the scrollbar once, and bringing it back to disabling one arrow will leave you without this bug.

Thu, Sep 12, 12:40 AM · efl

Wed, Sep 11

bu5hm4n added a comment to T7784: Efl.Pack / Efl.Pack_Linear usage.

Efl.Ui.Item is inheriting from layout ...

Wed, Sep 11, 7:46 AM · efl (efl-1.23), efl: widgets
bu5hm4n updated subscribers of T7784: Efl.Pack / Efl.Pack_Linear usage.

Right now it is a runtime check in the containers, and that check is also kind-of-tested with the spec test suite.

Wed, Sep 11, 3:05 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

Ping ?

Wed, Sep 11, 3:04 AM · efl (efl-1.23), Restricted Project
bu5hm4n requested review of D9908: elm_interface_scrollable: correctly emit the signals always.
Wed, Sep 11, 3:00 AM · efl
bu5hm4n added a child revision for D9907: elm_interface_scrollable: correctly handle bouncing: D9908: elm_interface_scrollable: correctly emit the signals always.
Wed, Sep 11, 3:00 AM · efl
bu5hm4n requested review of D9907: elm_interface_scrollable: correctly handle bouncing.
Wed, Sep 11, 3:00 AM · efl
bu5hm4n added a revision to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?: D9908: elm_interface_scrollable: correctly emit the signals always.
Wed, Sep 11, 3:00 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a child revision for D9906: theme: redo scroller theme of elm: D9907: elm_interface_scrollable: correctly handle bouncing.
Wed, Sep 11, 3:00 AM · efl
bu5hm4n added a revision to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?: D9907: elm_interface_scrollable: correctly handle bouncing.
Wed, Sep 11, 2:59 AM · efl (efl-1.23), efl: widgets
bu5hm4n requested review of D9906: theme: redo scroller theme of elm.
Wed, Sep 11, 2:59 AM · efl
bu5hm4n added a revision to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?: D9906: theme: redo scroller theme of elm.
Wed, Sep 11, 2:59 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a comment to D9841: evas_callbacks: make the callback protection a little bit safer.

@cedric i would say 'no' for several reasons, its also questionable performance wise.

Wed, Sep 11, 1:33 AM · efl

Tue, Sep 10

bu5hm4n added a comment to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?.

in regards of 2) -> oh, the theme is not handing the signals that are coming from efl, but rather does some of its own magic ? Maybe i can find some madness there...

Tue, Sep 10, 6:53 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a comment to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?.
  1. this seems fixed
  2. Yes, but i can see that _elm_direction_arrows_eval is called correctly, i can also see the call to edje_object_signal_emit, it seems to me that edje is eating that signal somehow ?
  3. this is after git so i think we are fine ?
Tue, Sep 10, 6:49 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a comment to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?.

This revision is required to have at least the scrollbar visible.

Tue, Sep 10, 6:35 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a revision to T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?: D9841: evas_callbacks: make the callback protection a little bit safer.
Tue, Sep 10, 6:35 AM · efl (efl-1.23), efl: widgets
bu5hm4n added a task to D9841: evas_callbacks: make the callback protection a little bit safer: T4918: Scrollbar arrows are not updated when the scroller size has changed. + thumb scroll conflict?.
Tue, Sep 10, 6:35 AM · efl
bu5hm4n requested review of D9898: efl_ui_suite: resolve focus errors.
Tue, Sep 10, 6:21 AM · efl
bu5hm4n added a comment to D9841: evas_callbacks: make the callback protection a little bit safer.

The finalized stuff is needed due to the fact that very early on the object is not placed, so there is no evas available, so i cannot attach the TICK event.

Tue, Sep 10, 6:04 AM · efl
bu5hm4n updated the diff for D9841: evas_callbacks: make the callback protection a little bit safer.

remove not needed declaration

Tue, Sep 10, 6:02 AM · efl
bu5hm4n added a comment to T7871: efl.ui.multi_selectable.

I prefer Object over Item, not only Items can be selectable.

Tue, Sep 10, 4:02 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to D9841: evas_callbacks: make the callback protection a little bit safer.

Ping ?

Tue, Sep 10, 12:10 AM · efl