Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (284 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

Yesterday

bu5hm4n added a comment to T7865: efl.ui.check.

IMO this should not inherit from nstate. Check is not made for displaying n-states, everything else then 2 states is going to break the displaying (same for efl.ui.check).

Sun, May 19, 6:30 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added reviewers for D8906: efl_ui_tab_pager: migrate to active_view: zmike, stefan_schmidt, Jaehyun_Cho, woohyun, segfaultxavi.
Sun, May 19, 4:08 AM · efl
bu5hm4n added reviewers for D8919: efl_ui_navigation_bar: migrate to active_view: woohyun, Jaehyun_Cho.
Sun, May 19, 4:07 AM · efl
bu5hm4n added a reviewer for D8920: efl_ui_stack: remove!: woohyun.
Sun, May 19, 4:07 AM · efl
bu5hm4n added a reviewer for D8920: efl_ui_stack: remove!: Jaehyun_Cho.
Sun, May 19, 4:07 AM · efl
bu5hm4n added reviewers for D8907: efl.ui.pager: remove!: Jaehyun_Cho, woohyun, stefan_schmidt, zmike, segfaultxavi.
Sun, May 19, 4:07 AM · efl
bu5hm4n added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

Sooo, with this latest update, this is in the final state. Is there anything i have missed?
The following commits do replace the existing widgets with this widget. I ported over the test codes, i was not totally sure about the stack test how it is supposed to work. There is also one bug in the stack widget test that i am currently trying to hunt down, it has to do with DEL events not beeing fired.

Sun, May 19, 4:06 AM · efl
bu5hm4n requested review of D8920: efl_ui_stack: remove!.
Sun, May 19, 4:00 AM · efl
bu5hm4n added a child revision for D8919: efl_ui_navigation_bar: migrate to active_view: D8920: efl_ui_stack: remove!.
Sun, May 19, 4:00 AM · efl
bu5hm4n requested review of D8919: efl_ui_navigation_bar: migrate to active_view.
Sun, May 19, 4:00 AM · efl
bu5hm4n added a child revision for D8907: efl.ui.pager: remove!: D8919: efl_ui_navigation_bar: migrate to active_view.
Sun, May 19, 4:00 AM · efl
bu5hm4n updated the diff for D8907: efl.ui.pager: remove!.

general update

Sun, May 19, 4:00 AM · efl
bu5hm4n updated the diff for D8906: efl_ui_tab_pager: migrate to active_view.

general update

Sun, May 19, 4:00 AM · efl
bu5hm4n updated the diff for D8784: efl_ui_active_view: introduce a experimental new widget.

general update

Sun, May 19, 4:00 AM · efl

Sat, May 18

bu5hm4n updated the task description for T7976: Efl.Ui.Clickable_Clicked.
Sat, May 18, 12:39 PM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n triaged T7976: Efl.Ui.Clickable_Clicked as TODO priority.
Sat, May 18, 12:39 PM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Sat, May 18, 12:39 PM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7963: Efl.Input.Pointer.

Okay, after a while of searching and reading it appears the the integer "tool" is telling the number of the pointer down event, in case we have multiple down touches on the window. Should we rename tool to multi_counter?

Sat, May 18, 12:35 PM · efl (efl-1.23), efl: api

Fri, May 17

bu5hm4n removed a subtask for T7966: Efl.Input.Focus: T7967: Efl.Input.Event.
Fri, May 17, 11:12 AM · efl (efl-1.23), efl: api
bu5hm4n removed a parent task for T7967: Efl.Input.Event: T7966: Efl.Input.Focus.
Fri, May 17, 11:12 AM · efl (efl-1.23), efl: api
bu5hm4n removed a parent task for T7966: Efl.Input.Focus: T7562: efl.input.interface.
Fri, May 17, 11:12 AM · efl (efl-1.23), efl: api
bu5hm4n removed a subtask for T7562: efl.input.interface: T7966: Efl.Input.Focus.
Fri, May 17, 11:12 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7966: Efl.Input.Focus as Invalid.

This is already stable.

Fri, May 17, 11:11 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7966: Efl.Input.Focus, a subtask of T7562: efl.input.interface, as Invalid.
Fri, May 17, 11:11 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7965: Efl.Input.Hold.

Mhm, I am really not sure when this is used or useful.

Fri, May 17, 10:58 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7966: Efl.Input.Focus.

Looks fine to me.

Fri, May 17, 10:56 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7970: Efl.Input.Device_Type.

Looks fine i guess?

Fri, May 17, 10:56 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7963: Efl.Input.Pointer.

Okay, i think we should drop tool here. There is device_type on the Efl.Input.Device which is accessable via Efl.Input.Event.device. This would resolve this issue.

Fri, May 17, 10:51 AM · efl (efl-1.23), efl: api
bu5hm4n accepted D8913: elm_color_class: use legacy event for genlist selection.
Fri, May 17, 9:54 AM · efl: widgets
bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Thank you :)

Fri, May 17, 4:01 AM · DO NOT MERGE, efl
bu5hm4n requested review of D8910: meson: fix installed .eo files and fix cross compile.
Fri, May 17, 2:21 AM · efl
bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@Jaehyun_Cho Can you *please* *please* *please* be more carefull reviewing these meson changes. The eo files here are just plainly not installed anymore. because line 26 was removed. Additionally, its pure luck that this still works in meson, because you actually pass now a array with a array in array element nr. 0 followed by strings. This is not supported by meson and really only works by luck.

Fri, May 17, 2:18 AM · DO NOT MERGE, efl
bu5hm4n added a comment to T7969: Efl.Input.Device.

I really dislike the name has_pointer_caps, maybe "@property pointer_style" ?

Fri, May 17, 1:48 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7967: Efl.Input.Event.

I really dislike the name has_pointer_caps, maybe "@property pointer_style" ?

Fri, May 17, 1:18 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7967: Efl.Input.Event.

Seems reasonable ?

Fri, May 17, 1:15 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7963: Efl.Input.Pointer.

Overall: this seems like the object which is used to represent any kind of pointer-event, undepended from pointer,move click or wheel changes.

Fri, May 17, 1:14 AM · efl (efl-1.23), efl: api
bu5hm4n updated subscribers of D8906: efl_ui_tab_pager: migrate to active_view.

@zmike Can you build this branch Patch, open "elementary_test -to "Efl.Ui.Tab_Pager" click to transition, click on stack, then click a little bit around on the icons, see the wonderful animation, then click on scroll, click around on the icons, see the wonderful animation. Now if you click on efl again, do you also see some artifacts where the font "efl" is flashing around on the same position in the window ? I printed the geometry of the content, and the content is moved totally linear, there is no such jumping around geometry wise. Any ideas what could cause this ?

Fri, May 17, 12:14 AM · efl

Thu, May 16

bu5hm4n requested review of D8907: efl.ui.pager: remove!.
Thu, May 16, 12:17 PM · efl
bu5hm4n added a child revision for D8906: efl_ui_tab_pager: migrate to active_view: D8907: efl.ui.pager: remove!.
Thu, May 16, 12:17 PM · efl
bu5hm4n requested review of D8906: efl_ui_tab_pager: migrate to active_view.
Thu, May 16, 12:17 PM · efl
bu5hm4n added a child revision for D8784: efl_ui_active_view: introduce a experimental new widget: D8906: efl_ui_tab_pager: migrate to active_view.
Thu, May 16, 12:17 PM · efl
bu5hm4n updated the diff for D8784: efl_ui_active_view: introduce a experimental new widget.

add a few fixes

Thu, May 16, 12:17 PM · efl
bu5hm4n added a comment to T7860: efl.pack_linear.

Totally agreed. Doc's are also ready polished.

Thu, May 16, 8:04 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7562: efl.input.interface.

Thank you :)

Thu, May 16, 6:37 AM · efl (efl-1.23), efl: api

Wed, May 15

bu5hm4n updated the diff for D8784: efl_ui_active_view: introduce a experimental new widget.

correctly namespace everything

Wed, May 15, 12:05 PM · efl
bu5hm4n added a comment to T7562: efl.input.interface.

This misses all the types of the events.

Wed, May 15, 10:21 AM · efl (efl-1.23), efl: api
bu5hm4n accepted D8894: meson: enforce 61s timeout for tests, remove explicit timeouts from build files.
Wed, May 15, 9:48 AM · efl
bu5hm4n updated the diff for D8899: theme: add a macro file for making themes easier.

docs docs docs docs

Wed, May 15, 9:42 AM · efl
bu5hm4n added a comment to D8894: meson: enforce 61s timeout for tests, remove explicit timeouts from build files.

Seems good, however, do you think we could run into issues where 61 sec. on CI will kill the effective process before the usefull output (the testcases still running) is printed ?

Wed, May 15, 9:33 AM · efl
bu5hm4n added a comment to D8899: theme: add a macro file for making themes easier.

In efl we have this weird semantics when it comes to signals:
Lets say we have a constant stream of press & unpress onto a edje part, the stream of edje signals is then:

  • mouse,down,1
  • mouse,up,1
  • mouse,down,1,double
  • mouse,up,1
  • mouse,down,1,triple
  • mouse,up,1
  • mouse,down,1
  • mouse,up,1

[and repeating like this]

Wed, May 15, 9:31 AM · efl
bu5hm4n updated the diff for D8784: efl_ui_active_view: introduce a experimental new widget.

update docs

Wed, May 15, 9:07 AM · efl
bu5hm4n requested review of D8899: theme: add a macro file for making themes easier.
Wed, May 15, 8:51 AM · efl
bu5hm4n updated the diff for D8784: efl_ui_active_view: introduce a experimental new widget.
  • rename the widget
Wed, May 15, 8:15 AM · efl
bu5hm4n abandoned D8830: efl_ui_item: migrate to Efl.Ui.Clickable.

Lets ignore this and actually test the real items.

Wed, May 15, 6:38 AM · efl
bu5hm4n abandoned D8829: efl_ui_item: protect against NULL access.

Lets solve this in some other way.

Wed, May 15, 6:36 AM · efl
bu5hm4n added a comment to D8671: Revert "remove vpath test for user dir the test was broken and fixing is insane".

getuid must be on a platform that supports getpwuid, otherwise there is no way of getting the id...

Wed, May 15, 6:33 AM · efl

Tue, May 14

bu5hm4n requested review of D8826: efl_ui_frame: migrate to efl.ui.clickable.

Then you have to specify what you meant, before this directly emitted the clicked event. This is now not anymore the case, press and unpress is done from here, and according to that the clicked event is emitted (if there was no moving out). So right now, this works correctly afaics.

Tue, May 14, 1:04 PM · efl
bu5hm4n updated the diff for D8830: efl_ui_item: migrate to Efl.Ui.Clickable.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8829: efl_ui_item: protect against NULL access.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8828: efl_ui: remove Efl.Ui.Clickable from containers.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8827: efl_ui_tab_bar: remove Efl.Ui.Clickable.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8826: efl_ui_frame: migrate to efl.ui.clickable.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8825: efl_ui_panes: migrate to efl_ui_clickable.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8824: efl_ui_text: migrate to efl_ui_clickable.

update to new API names, redo

Tue, May 14, 11:22 AM · efl
bu5hm4n updated the diff for D8823: efl_ui_image: migrate to efl.ui.clickable.

update to new API names, redo

Tue, May 14, 11:21 AM · efl
bu5hm4n updated the diff for D8822: efl_test_clickable: introduce new tests.

update to new API names, redo

Tue, May 14, 11:21 AM · efl
bu5hm4n updated the diff for D8821: efl_ui_button: port to efl.ui.clickable.

update to new API names, redo

Tue, May 14, 11:21 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.

update to new API names, redo

Tue, May 14, 11:21 AM · efl
bu5hm4n updated the diff for D8830: efl_ui_item: migrate to Efl.Ui.Clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8829: efl_ui_item: protect against NULL access.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8828: efl_ui: remove Efl.Ui.Clickable from containers.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8827: efl_ui_tab_bar: remove Efl.Ui.Clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8826: efl_ui_frame: migrate to efl.ui.clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8825: efl_ui_panes: migrate to efl_ui_clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8824: efl_ui_text: migrate to efl_ui_clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8823: efl_ui_image: migrate to efl.ui.clickable.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8822: efl_test_clickable: introduce new tests.

update to new API names

Tue, May 14, 10:54 AM · efl
bu5hm4n updated the diff for D8821: efl_ui_button: port to efl.ui.clickable.

update to new API names

Tue, May 14, 10:53 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.

update to new API names

Tue, May 14, 10:53 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.
Tue, May 14, 10:53 AM · efl
bu5hm4n added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

@Jaehyun_Cho I really like this idea! JP started a concept for this a while back: https://phab.enlightenment.org/T6265 I think this does make a lot of sense. And should be applied, as this can be beneficial for other widgets as well. I will add this as a task once the main widget has hit master. We still can extend it. I want to focus on the mainfeatures for now. So we can merge this sooner than later :)

Tue, May 14, 9:00 AM · efl
bu5hm4n requested changes to D8894: meson: enforce 61s timeout for tests, remove explicit timeouts from build files.

This misses a lot of testsuites. elementary for example.

Tue, May 14, 8:40 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.

add doc

Tue, May 14, 8:37 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.

enhance docs, and update util

Tue, May 14, 8:00 AM · efl
bu5hm4n added a comment to T7959: efl_canvas_gesture: remove or modify @property type.

I think you can pass the class directly, this removes the string compare, that safes us the strcmp.

Tue, May 14, 5:33 AM · Restricted Project
bu5hm4n added a comment to D8784: efl_ui_active_view: introduce a experimental new widget.

No problem :)

Tue, May 14, 3:34 AM · efl
bu5hm4n added a comment to D8820: efl_ui: move clickable from efl to efl_ui.

So, with the latest update, most widgets do work again correctly.
So when a mouse down is followed by the mouse going out of the element, then press and unpress will be emitted (from edje) but no clicked event is emitted from the implementation. Which seems correct.

Tue, May 14, 2:00 AM · efl
bu5hm4n updated the diff for D8830: efl_ui_item: migrate to Efl.Ui.Clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8829: efl_ui_item: protect against NULL access.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8828: efl_ui: remove Efl.Ui.Clickable from containers.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8826: efl_ui_frame: migrate to efl.ui.clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8827: efl_ui_tab_bar: remove Efl.Ui.Clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8825: efl_ui_panes: migrate to efl_ui_clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8824: efl_ui_text: migrate to efl_ui_clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8823: efl_ui_image: migrate to efl.ui.clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8822: efl_test_clickable: introduce new tests.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8821: efl_ui_button: port to efl.ui.clickable.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8820: efl_ui: move clickable from efl to efl_ui.

Make press,move-out-of-widget,unpress scenarios work take 2

Tue, May 14, 1:55 AM · efl
bu5hm4n updated the diff for D8823: efl_ui_image: migrate to efl.ui.clickable.

Make press,move-out-of-widget,unpress scenarios work

Tue, May 14, 1:54 AM · efl
bu5hm4n updated the diff for D8822: efl_test_clickable: introduce new tests.

Make press,move-out-of-widget,unpress scenarios work

Tue, May 14, 1:54 AM · efl