Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (343 w, 3 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n added a comment to D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Thank you!

Fri, Jul 3, 9:17 AM · efl
bu5hm4n resigned from D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Fri, Jul 3, 12:11 AM · efl
bu5hm4n requested changes to D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Patch does not apply ...

Fri, Jul 3, 12:10 AM · efl
bu5hm4n accepted D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Fri, Jul 3, 12:08 AM · efl

Wed, Jul 1

bu5hm4n accepted D11994: Meson.build cleanup..

thx.

Wed, Jul 1, 1:13 AM · efl
bu5hm4n added a comment to D11994: Meson.build cleanup..

Note to myself, dont comment before awake: https://travis-ci.org/github/Enlightenment/efl/builds/703813078

Wed, Jul 1, 12:30 AM · efl
bu5hm4n added a comment to D11994: Meson.build cleanup..

https://travis-ci.org/github/Enlightenment/efl

Wed, Jul 1, 12:28 AM · efl

Tue, Jun 30

bu5hm4n added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

I don't want to install an application to be able to compile or download dependencies. This makes no sense at all IMO. If we're not going to have wrap dependencies, we still need to be able to tell where dependencies are without pkg-config. We have neither, and wrap dependencies is a meson feature which, IMO, helps a lot. Lots of other libraries use it (gstreamer for example). And this doesn't need to be on by default. I wouldn't need subprojects in Linux (though I've used subprojects for gstreamer when developing for it, and was much easier when using git versions).

Tue, Jun 30, 12:38 PM · efl
bu5hm4n added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Hi bu5hm4n.

Tue, Jun 30, 7:12 AM · efl

Sat, Jun 27

bu5hm4n updated subscribers of D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

I am not really a fan of using subprojects here either, not because subprojects per se are bad, but they dont fit the scheme of efl and how distros work. Just from the top of my head a idea on why i dont think its a good idea:

  • In case we are having subprojects, we are defining the version of a dependency, not the min version of anything, the version itself is then defined, in case there is a CVE or some major bug, we need to proactivly reroll another release of efl bump versions etc.. Not sure we have the capacity in the release department for that CC @stefan_schmidt )
  • Not all meson projects can be used as subprojects, some require external dependencies, in case some code compiler is compiled, cross compilation will fail.
  • Sometimes wraps do disappear (example stb, there is still the entry in the wrapdb, but the wrap in gone) in case we ever rely on wrap, we also need to take a share on maintaining the wraps, or we might loose them
  • Subprojects bring the harm of 2 providers, so in case zlib-wrap is now sucked in as a dependency instead of a libzlib.so on the system, then the subproject wlll be compiled, and with the next ninja install it will be installed. In case you use any other project doing the same thing, or the distro shipping zlib as standalone, you will end up in a ugly conflict...
Sat, Jun 27, 1:51 PM · efl

Thu, Jun 25

bu5hm4n added a comment to D11994: Meson.build cleanup..

With these two comments, then: should I split 6 and 8 into two other patches? For 6 because we can track this in an isolated patch, and for 8 because of possible opinion divergence.

Sounds good :) (If getting out 8 is too much work, i dont have a issue with first merging that if the rest of the stuff is coming in a next patch :))

Thu, Jun 25, 2:33 AM · efl
bu5hm4n added a comment to T8761: Standardize external dependency handling.

First Half of the issue

I think you can just remove the _dep prefix from these 4 vars ... no big deal, there is really no thought behind that scheme, just make sure the names do not collide :)
Thu, Jun 25, 2:32 AM · efl

Fri, Jun 19

bu5hm4n added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

Independend from if this is a good idea or not, things that are not clear to me:

  • How to do that in eolian ? Every eolian API is defined with EOAPI, which is defined to be EAPI & EAPI_WEAK with this approach you either need to patch eolian to take the correct preprocessor directives (then eolian needs to guess in which lib it is), or you need to redefine EOAPI which is then reintroducing the thing you are trying to solve
  • How to handle EAPI's in modules ?
Fri, Jun 19, 2:08 AM · efl
bu5hm4n requested changes to D11994: Meson.build cleanup..

1 / 2 / 3 / 4: fine for me.
We recently bumped min version to 0.50 so 5 & 7 Should hopefully work without issues.

Fri, Jun 19, 1:51 AM · efl
bu5hm4n requested review of D11998: evas_common_privat: improve tiler merge flag.
Fri, Jun 19, 12:05 AM · efl
bu5hm4n added a child revision for D11997: eina_array: micro optimize eina_array_push: D11998: evas_common_privat: improve tiler merge flag.
Fri, Jun 19, 12:05 AM · efl
bu5hm4n requested review of D11997: eina_array: micro optimize eina_array_push.
Fri, Jun 19, 12:05 AM · efl

Wed, Jun 17

bu5hm4n accepted D11956: benchmarks: eina: make sure we do not divide by zero.

This looks fine, however, this is a ecore hash implementation that hasn't been running for > 10 years ... should we just remove it ?

Wed, Jun 17, 3:51 AM · efl
bu5hm4n accepted D11963: tests: eio: make sure we check return value.
Wed, Jun 17, 3:50 AM · efl

Tue, Jun 16

bu5hm4n added a comment to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

THats good.

Tue, Jun 16, 11:56 PM · efl
bu5hm4n accepted D11985: elementary/perf:remove unnecessary elm_widget_is() check.

Thank you. I checked upstream that we do not assigned parent_obj *ever* by hand. And we don't. Can you ensure the same in tizen ?

Tue, Jun 16, 11:43 PM · efl
bu5hm4n accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

Yep, that now looks even better. Thank you :)

Tue, Jun 16, 11:32 PM · efl
bu5hm4n accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

Looks good to me, thx.

Tue, Jun 16, 11:24 PM · efl
bu5hm4n requested changes to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

I think you can go ahead and simply remove these efl_isa calls.

Tue, Jun 16, 11:11 PM · efl
bu5hm4n requested changes to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Tue, Jun 16, 11:06 PM · efl
bu5hm4n added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

I cannot comment how it was with regards to backwards comp. but shoundn't this also check if the group is the same ?

Tue, Jun 16, 8:00 AM · efl
bu5hm4n requested changes to D11973: meson: add Solaris support.

Beside that little nitpick it seems fine to me.

Tue, Jun 16, 3:05 AM · efl

Mon, Jun 15

bu5hm4n updated the task description for T8755: Compiler-Plugin for eo optimization.
Mon, Jun 15, 4:37 AM · efl
bu5hm4n created T8755: Compiler-Plugin for eo optimization.
Mon, Jun 15, 4:33 AM · efl

Sun, Jun 14

bu5hm4n requested changes to D11973: meson: add Solaris support.
Sun, Jun 14, 11:13 PM · efl

Wed, Jun 10

bu5hm4n added a comment to T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.

@ali.alzyod since you have asked yesterday if there is anything. Does that ^ look like something you would be interested in ?

Wed, Jun 10, 3:47 AM · efl
bu5hm4n updated subscribers of T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.
Wed, Jun 10, 3:47 AM · efl
bu5hm4n triaged T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect as Normal priority.
Wed, Jun 10, 3:46 AM · efl

Tue, Jun 9

bu5hm4n added a comment to D11949: efl_ui_textpath: mathmatical calculations.

The code *is* the same, Add -O3 and you will just see that the code lines are not mapped to anything in asm. Even on the wegpage. The next example also gets eliminated the cos and sin calls.

Tue, Jun 9, 4:38 AM · efl
bu5hm4n added a comment to D11949: efl_ui_textpath: mathmatical calculations.

Don't look at the times, take a look at objdump -S a.out the outputted asm is equivalent. Also take a look where the calls to clock are located. The time advantage you see is *not* coming from the different call. infact, the sin and cos calls are stripped out completly. As a mixture of inlining, dead code removal, and const folding removed it.

Tue, Jun 9, 3:49 AM · efl
bu5hm4n added a comment to T8748: Performance Issue in ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS class.

Well, you can transform the realize callbacks to real eo calls, and simply call them from gengrid / genlist, which will eliminate the need for the callback. However, this is not a priority for me, so feel free to do that.

Tue, Jun 9, 3:38 AM
bu5hm4n requested review of D11954: mono: update window construction.
Tue, Jun 9, 3:11 AM · efl
bu5hm4n added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

@raster the problem with sqrt calls is that they do not get replaced in *all* compilers, clang on macos is not capable of doing that (i have no idea why). gcc on my raspi is also not doing it here ...

Tue, Jun 9, 2:49 AM · efl
bu5hm4n added a comment to D11947: efl: reduce PI calculations.

Additionally to what @raster said. Take objdump -a and check out the produced assembler when compiling something with -O3 you will see, that the two loops boil down to absolutely the same asm. Anyways, additionally, even with -O0 the speedup is so little that the bias is higher than the save up, which is more showing that this might save *something* but surely not enough to have an impact.

Tue, Jun 9, 2:45 AM · efl
bu5hm4n added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

What i mean is: sqrt(a²+b²) / sqrt(2) can be written as sqrt(a²/2+b²/2).
Additionally if you cast a² and b² to a int, the compiler can reduce this to a shift, eliminating floating point division or mul operations totally, making this even lightweighter than before.
Even more micro optimizing you could write the whole thing as: sqrt((a*a)/2 + (b*b)/2) leaving out a func call, or instruction to floating point pow. This way things stay within none-floating-point op's making it less calc intensive.

Tue, Jun 9, 2:22 AM · efl
bu5hm4n requested review of D11734: eo: make the parent a optional constructor.
Tue, Jun 9, 1:29 AM · efl
bu5hm4n requested review of D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf.
Tue, Jun 9, 1:28 AM · efl
bu5hm4n accepted D11951: dotnet: Ignore Efl.Object.parent as constructor.

Thx!

Tue, Jun 9, 1:01 AM · efl
bu5hm4n accepted D11950: cxx: Fix uses of intrinsic eolian binbuf type.

Thx!

Tue, Jun 9, 1:00 AM · efl

Mon, Jun 8

bu5hm4n added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

Maybe even dragging it deeper into the formula, resulting in a int operation instead of float operation, maybe resulting in the compiler replacing it with a shift.

Mon, Jun 8, 11:06 AM · efl
bu5hm4n added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

I think you can go ahead and drag the division by 2 into the first sqrt, keeping the 2, which is kind of more readable IMO.

Mon, Jun 8, 11:04 AM · efl
bu5hm4n added a comment to D11947: efl: reduce PI calculations.

I dont mind if we land this or not. But this is not really impacting anything, const folding covered the cases i checked, and if not, then the static double assignment will fail...

Mon, Jun 8, 10:57 AM · efl
bu5hm4n accepted D11935: exactness: record and print test time on success.

Did we ever encounter hanging of a test ?

Mon, Jun 8, 12:41 AM · efl
bu5hm4n accepted D11937: ci: simplify ccache setup handling.
Mon, Jun 8, 12:40 AM · efl
bu5hm4n accepted D11938: ci: travis: add more fold and timing markers in some forgotten places.
Mon, Jun 8, 12:39 AM · efl

Fri, Jun 5

bu5hm4n removed a child revision for D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf: D11734: eo: make the parent a optional constructor.
Fri, Jun 5, 1:30 AM · efl
bu5hm4n removed a parent revision for D11734: eo: make the parent a optional constructor: D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf.
Fri, Jun 5, 1:30 AM · efl
bu5hm4n added a child revision for D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf: D11734: eo: make the parent a optional constructor.
Fri, Jun 5, 1:30 AM · efl
bu5hm4n added a parent revision for D11734: eo: make the parent a optional constructor: D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf.
Fri, Jun 5, 1:30 AM · efl
bu5hm4n removed a parent revision for D11741: efl_ui_win: declare constructors not optional: D11734: eo: make the parent a optional constructor.
Fri, Jun 5, 1:30 AM · efl
bu5hm4n removed a child revision for D11734: eo: make the parent a optional constructor: D11741: efl_ui_win: declare constructors not optional.
Fri, Jun 5, 1:29 AM · efl
bu5hm4n removed a child revision for D11741: efl_ui_win: declare constructors not optional: D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf.
Fri, Jun 5, 1:29 AM · efl
bu5hm4n removed a parent revision for D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf: D11741: efl_ui_win: declare constructors not optional.
Fri, Jun 5, 1:28 AM · efl
bu5hm4n updated subscribers of D11742: eo-files: convert all Eina.Strbuf & Eina.Binbuf.

@felipealmeida Can you take a look here

Fri, Jun 5, 1:06 AM · efl
bu5hm4n updated subscribers of D11734: eo: make the parent a optional constructor.

@felipealmeida Can you take a look here?

Fri, Jun 5, 1:05 AM · efl
bu5hm4n requested review of D11741: efl_ui_win: declare constructors not optional.

Seems to have been another commit that actually breaks it.

Fri, Jun 5, 1:04 AM · efl

Thu, Jun 4

bu5hm4n added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

I have to say that i do not like eina_api.h. Why not just altering the current EAPI defitionions ?

Thu, Jun 4, 11:46 PM · efl
bu5hm4n added reviewers for D11933: build: do not publish surface .eo files: stefan_schmidt, Hermet.
Thu, Jun 4, 3:47 AM · efl
bu5hm4n added reviewers for D11932: evas: correctly declare filter_internal as public API: stefan_schmidt, Hermet.
Thu, Jun 4, 3:47 AM · efl
bu5hm4n requested review of D11933: build: do not publish surface .eo files.
Thu, Jun 4, 3:47 AM · efl
bu5hm4n added a child revision for D11932: evas: correctly declare filter_internal as public API: D11933: build: do not publish surface .eo files.
Thu, Jun 4, 3:46 AM · efl
bu5hm4n requested review of D11932: evas: correctly declare filter_internal as public API.
Thu, Jun 4, 3:46 AM · efl

Jun 3 2020

bu5hm4n accepted D11913: ci: log time in every fold start and end.
Jun 3 2020, 6:18 AM · efl
bu5hm4n accepted D11922: ci: remove no longer used address sanitizer leak suppression file.
Jun 3 2020, 6:17 AM · efl
bu5hm4n accepted D11921: ci: remove outdated README file.
Jun 3 2020, 6:14 AM · efl
bu5hm4n added reviewers for D11923: build: move static out of none_static: stefan_schmidt, jsuya.

https://travis-ci.org/github/Enlightenment/efl/builds/694222893

Jun 3 2020, 5:07 AM · efl
bu5hm4n accepted D11920: ci: remove not in use script.

Oh right, i forgot about that ... sorry :/

Jun 3 2020, 5:00 AM · efl
bu5hm4n added a comment to D11916: Build: Add json dependency to vg_common.

https://phab.enlightenment.org/D11923 Can you check if this fixes the issue for you?

Jun 3 2020, 4:58 AM · efl
bu5hm4n requested review of D11923: build: move static out of none_static.
Jun 3 2020, 4:57 AM · efl
bu5hm4n added a comment to D11916: Build: Add json dependency to vg_common.

ooooooooh, do we use vgcommon directly in tests ?

Jun 3 2020, 4:26 AM · efl
bu5hm4n added a comment to D11920: ci: remove not in use script.

Uuuuuuuuh we dont ? i think we should ?

Jun 3 2020, 4:18 AM · efl
bu5hm4n accepted D11919: Revert "elementary: build elementary_test additionally as shared object".
Jun 3 2020, 1:57 AM · efl
bu5hm4n added a comment to D11916: Build: Add json dependency to vg_common.

While i agree on the meson-level, i am kind of wondering why this is needed, rlottie is already added as a dep by the vg loader, why is this additionally needed ?

Jun 3 2020, 1:53 AM · efl

Jun 2 2020

bu5hm4n accepted D11906: ci: travis: enable efl-one in our all enabled build.

Damn, i thought this is already landed... sorry :)

Jun 2 2020, 4:59 AM · efl

Jun 1 2020

bu5hm4n accepted D11888: eo: Fix memory leak in efl_key_wref_set() api..

Seems to look fine. Lets see if it breaks for someone else ... (Its also kind of weird that there is a free func where you can tell to *not* free the node)

Jun 1 2020, 11:06 PM · efl
bu5hm4n accepted D11907: efl_access_text: remove ptr usage in eo files.

Thx.

Jun 1 2020, 11:05 PM · efl
bu5hm4n added a comment to D11888: eo: Fix memory leak in efl_key_wref_set() api..

I'll give it a look tomorrow :)

Jun 1 2020, 3:04 AM · efl

May 29 2020

bu5hm4n accepted D11903: ci: get rid of all extra asan handling.
May 29 2020, 3:32 AM · efl
bu5hm4n added a comment to D11906: ci: travis: enable efl-one in our all enabled build.

Okay cool, thank you :)

May 29 2020, 3:17 AM · efl
bu5hm4n accepted D11902: build: ensure we set all needed asan option for check run as well.

Yep, I did not see it until now :)

May 29 2020, 3:17 AM · efl
bu5hm4n added a comment to D11906: ci: travis: enable efl-one in our all enabled build.

I really like this, just two things:

  • Do you think this is a good idea right now ? i don't know what changes, should we have it already on CI ?
  • Can we execute test-efl-one.py build at the end ? That will verify that nothing accidently drags in libeina or smth. like that when there was a build update.
May 29 2020, 12:43 AM · efl

May 28 2020

bu5hm4n added a comment to D11876: Support WebP Animation Image Files.

Only this one thing :)

May 28 2020, 3:47 AM · efl
bu5hm4n added a comment to D11901: build: add efl-canvasl-wl to efl-one.

https://phab.enlightenment.org/D11892

May 28 2020, 3:23 AM · efl
bu5hm4n added a comment to D11892: build: rely on automatic pkg file generation for eina.
May 28 2020, 3:22 AM · efl
bu5hm4n requested review of D11901: build: add efl-canvasl-wl to efl-one.
May 28 2020, 3:09 AM · efl
bu5hm4n added a child revision for D11900: Introduce a test to verify efl-one only links to the correct libs: D11901: build: add efl-canvasl-wl to efl-one.
May 28 2020, 3:09 AM · efl
bu5hm4n requested review of D11900: Introduce a test to verify efl-one only links to the correct libs.
May 28 2020, 2:50 AM · efl
bu5hm4n added a child revision for D11899: build: vg_common depends on evas internals: D11900: Introduce a test to verify efl-one only links to the correct libs.
May 28 2020, 2:50 AM · efl
bu5hm4n added a comment to D11892: build: rely on automatic pkg file generation for eina.

Just checked, there is no header in efl/ that is required from eina ... maybe there was at some point and we got rid of it ?

May 28 2020, 1:13 AM · efl
bu5hm4n requested review of D11899: build: vg_common depends on evas internals.
May 28 2020, 1:00 AM · efl
bu5hm4n added a child revision for D11897: build: split off static parts from external parts in evas: D11899: build: vg_common depends on evas internals.
May 28 2020, 1:00 AM · efl
bu5hm4n updated the diff for D11897: build: split off static parts from external parts in evas.

update

May 28 2020, 1:00 AM · efl
bu5hm4n added a comment to D11897: build: split off static parts from external parts in evas.

https://travis-ci.org/github/Enlightenment/efl/builds/692050736

May 28 2020, 12:34 AM · efl
bu5hm4n updated the diff for D11897: build: split off static parts from external parts in evas.

add a bit more eet

May 28 2020, 12:11 AM · efl

May 27 2020

bu5hm4n requested review of D11897: build: split off static parts from external parts in evas.
May 27 2020, 11:32 PM · efl