Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (323 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n added a comment to D11358: efl_ui_spotlight: Introduce animation manager.

The result can be seen here: https://phab.enlightenment.org/F3847090

Sun, Feb 16, 4:38 AM · efl
bu5hm4n requested review of D11358: efl_ui_spotlight: Introduce animation manager.
Sun, Feb 16, 4:37 AM · efl
bu5hm4n requested review of D11357: efl_ui_spotlight_manager: introduce a reason for switch_to.
Sun, Feb 16, 4:37 AM · efl

Yesterday

bu5hm4n updated the diff for D11351: ecore_evas: Introduce cnp support for cocoa.

fixes & rebase

Sat, Feb 15, 12:53 PM · efl
bu5hm4n updated the diff for D11350: ecore_cocoa: change clipboard API.

fixes & rebase

Sat, Feb 15, 12:53 PM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

fixes & rebase

Sat, Feb 15, 12:53 PM · efl
bu5hm4n updated the diff for D11329: ecore_evas: introduce wayland support for cnp & dnd.

fixes & rebase

Sat, Feb 15, 12:53 PM · efl
bu5hm4n updated the diff for D11195: ecore_evas: introduce initial selection & dnd support for x..

fixes & rebase

Sat, Feb 15, 12:53 PM · efl
bu5hm4n updated the diff for D11194: ecore_x_selection: do not skip any any atoms.

fixes & rebase

Sat, Feb 15, 12:52 PM · efl
bu5hm4n updated the diff for D11193: ecore_x: add API to request selection changed events for diff. wins.

fixes & rebase

Sat, Feb 15, 12:52 PM · efl
bu5hm4n updated the diff for D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.

fixes & rebase

Sat, Feb 15, 12:52 PM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

fixes & rebase

Sat, Feb 15, 12:52 PM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11062: eina: introduce eina_iterator_process.

fixes & rebase

Sat, Feb 15, 12:51 PM · efl
bu5hm4n updated the diff for D11196: efl_ui_draggable: move these events back to legacy.

fixes & rebase

Sat, Feb 15, 12:51 PM · efl
bu5hm4n removed parent revisions for D11196: efl_ui_draggable: move these events back to legacy: D11203: ecore_input_evas: move in multi when in multi config, D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.
Sat, Feb 15, 12:45 PM · efl
bu5hm4n removed a child revision for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types: D11196: efl_ui_draggable: move these events back to legacy.
Sat, Feb 15, 12:45 PM · efl
bu5hm4n removed a child revision for D11203: ecore_input_evas: move in multi when in multi config: D11196: efl_ui_draggable: move these events back to legacy.
Sat, Feb 15, 12:45 PM · efl
bu5hm4n requested review of D11193: ecore_x: add API to request selection changed events for diff. wins.
Sat, Feb 15, 12:40 PM · efl

Fri, Feb 14

bu5hm4n abandoned D10825: eo: do not free these values here.

this is wrong.

Fri, Feb 14, 8:23 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11356: evas: stop handdefining eo types.

even more of is.

Fri, Feb 14, 8:20 AM · efl
bu5hm4n requested review of D11356: evas: stop handdefining eo types.
Fri, Feb 14, 8:14 AM · efl
bu5hm4n added a child revision for D11355: efl_ui_spotlight_fade_manager: fix wrong typedef: D11356: evas: stop handdefining eo types.
Fri, Feb 14, 8:14 AM · efl
bu5hm4n requested review of D11355: efl_ui_spotlight_fade_manager: fix wrong typedef.
Fri, Feb 14, 8:13 AM · efl
bu5hm4n requested review of D11351: ecore_evas: Introduce cnp support for cocoa.
Fri, Feb 14, 5:13 AM · efl
bu5hm4n added a child revision for D11350: ecore_cocoa: change clipboard API: D11351: ecore_evas: Introduce cnp support for cocoa.
Fri, Feb 14, 5:13 AM · efl
bu5hm4n requested review of D11350: ecore_cocoa: change clipboard API.
Fri, Feb 14, 5:13 AM · efl
bu5hm4n added a child revision for D11190: rewrite efl cnp and dnd handling: D11350: ecore_cocoa: change clipboard API.
Fri, Feb 14, 5:13 AM · efl
bu5hm4n accepted D11330: elm_test: add zoom recognizer handling to gesture test.
Fri, Feb 14, 12:07 AM · efl
bu5hm4n accepted D11299: efl/gesture: fix long tap timeout errors.
Fri, Feb 14, 12:07 AM · efl
bu5hm4n accepted D11292: tests/gesture: add another tap test to check finger size works.
Fri, Feb 14, 12:07 AM · efl
bu5hm4n accepted D11291: efl/gesture: fix touch state tracking.
Fri, Feb 14, 12:06 AM · efl

Thu, Feb 13

bu5hm4n requested changes to D11304: Summary: code refactoring - get rid of unneccessary Efl.Access.Value interface..

This looks overall like a very good idea. We just have to remember that we still need to support atspi for legacy widgets (and thus also in the bridge).

Thu, Feb 13, 1:03 AM · efl
bu5hm4n updated the summary of D11296: eina-suite: do not print that many errors.
Thu, Feb 13, 12:16 AM · efl

Wed, Feb 12

bu5hm4n added a comment to D11116: efl_ui_panes: remove duplicated press/unpress event.

Ok! Thank you!

Wed, Feb 12, 11:47 PM · efl
bu5hm4n added a comment to T8610: Crash in filters.

Seems fixed! Thank you!

Wed, Feb 12, 11:47 PM · efl: canvas
bu5hm4n updated the diff for D11193: ecore_x: add API to request selection changed events for diff. wins.

add since

Wed, Feb 12, 11:51 AM · efl
bu5hm4n updated the diff for D11329: ecore_evas: introduce wayland support for cnp & dnd.

fixes

Wed, Feb 12, 11:44 AM · efl
bu5hm4n removed a parent revision for D11190: rewrite efl cnp and dnd handling: D11195: ecore_evas: introduce initial selection & dnd support for x..
Wed, Feb 12, 11:43 AM · efl
bu5hm4n removed a child revision for D11195: ecore_evas: introduce initial selection & dnd support for x.: D11190: rewrite efl cnp and dnd handling.
Wed, Feb 12, 11:43 AM · efl
bu5hm4n abandoned D11332: ecore_evas: introduce wayland support for cnp & dnd.

WTF

Wed, Feb 12, 11:43 AM · efl
bu5hm4n removed a parent revision for D11332: ecore_evas: introduce wayland support for cnp & dnd: D11195: ecore_evas: introduce initial selection & dnd support for x..
Wed, Feb 12, 11:42 AM · efl
bu5hm4n removed a child revision for D11195: ecore_evas: introduce initial selection & dnd support for x.: D11332: ecore_evas: introduce wayland support for cnp & dnd.
Wed, Feb 12, 11:42 AM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

naming fixes

Wed, Feb 12, 11:41 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11195: ecore_evas: introduce initial selection & dnd support for x..

fixes

Wed, Feb 12, 11:38 AM · efl
bu5hm4n requested review of D11332: ecore_evas: introduce wayland support for cnp & dnd.
Wed, Feb 12, 11:36 AM · efl
bu5hm4n added a child revision for D11195: ecore_evas: introduce initial selection & dnd support for x.: D11332: ecore_evas: introduce wayland support for cnp & dnd.
Wed, Feb 12, 11:36 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

fixes for efl.ui.textbox

Wed, Feb 12, 11:30 AM · efl
bu5hm4n updated the diff for D11297: efl-check: do not print expected errors.

add a comment.

Wed, Feb 12, 7:41 AM · efl
bu5hm4n accepted D11294: elm/config: fix thumbscroll config.
Wed, Feb 12, 6:12 AM · efl
bu5hm4n accepted D11250: efl/config: add missing gesture config value handlers.
Wed, Feb 12, 6:10 AM · efl
bu5hm4n accepted D11251: efl/config: merge all gesture manager config code into efl.config.

Sounds good i think.

Wed, Feb 12, 6:09 AM · efl
bu5hm4n planned changes to D11203: ecore_input_evas: move in multi when in multi config.

bugs.

Wed, Feb 12, 6:03 AM · efl
bu5hm4n accepted D11162: tests/layout: modify api ordering test to verify theme signal emission.
Wed, Feb 12, 6:01 AM · efl
bu5hm4n accepted D11116: efl_ui_panes: remove duplicated press/unpress event.

This seems fine. We never looked at this widget for stablization. Should we look at it now ?

Wed, Feb 12, 6:00 AM · efl
bu5hm4n requested changes to D11036: Efl.Ui: Update Efl.Ui.Textbox tests.
  • This should use fixtures, for the part that is in the macro. There will be no fail (hopefully) in the fixture, as init should work anyways.
Wed, Feb 12, 5:59 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

More fixes and progress

Wed, Feb 12, 5:57 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

More fixes and progress

Wed, Feb 12, 5:52 AM · efl
bu5hm4n added a child revision for D11329: ecore_evas: introduce wayland support for cnp & dnd: D11190: rewrite efl cnp and dnd handling.
Wed, Feb 12, 5:52 AM · efl
bu5hm4n requested review of D11329: ecore_evas: introduce wayland support for cnp & dnd.
Wed, Feb 12, 5:52 AM · efl
bu5hm4n added a child revision for D11195: ecore_evas: introduce initial selection & dnd support for x.: D11329: ecore_evas: introduce wayland support for cnp & dnd.
Wed, Feb 12, 5:52 AM · efl
bu5hm4n updated the diff for D11195: ecore_evas: introduce initial selection & dnd support for x..

More fixes and progress

Wed, Feb 12, 5:52 AM · efl
bu5hm4n updated the diff for D11194: ecore_x_selection: do not skip any any atoms.

More fixes and progress

Wed, Feb 12, 5:51 AM · efl
bu5hm4n updated the diff for D11193: ecore_x: add API to request selection changed events for diff. wins.

More fixes and progress

Wed, Feb 12, 5:51 AM · efl
bu5hm4n updated the diff for D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.

More fixes and progress

Wed, Feb 12, 5:51 AM · efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

More fixes and progress

Wed, Feb 12, 5:51 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11062: eina: introduce eina_iterator_process.

More fixes and progress

Wed, Feb 12, 5:51 AM · efl
bu5hm4n updated the diff for D11196: efl_ui_draggable: move these events back to legacy.

More fixes and progress

Wed, Feb 12, 5:50 AM · efl
bu5hm4n added a child revision for D11203: ecore_input_evas: move in multi when in multi config: D11196: efl_ui_draggable: move these events back to legacy.
Wed, Feb 12, 5:50 AM · efl
bu5hm4n updated the diff for D11203: ecore_input_evas: move in multi when in multi config.

More fixes and progress

Wed, Feb 12, 5:50 AM · efl

Mon, Feb 10

bu5hm4n added a comment to D11303: efl.canvas.textblock: allow all white spaces in style string not just space.

I think you misunderstood a bit what @segfaultxavi is pointing out. There should not be the "same" list of characters twice. It would be way better from a quality POV that both functions either use the same list of characters that are considered a whitespace, or simply iterate over the str and call _is_char_white on every character in the string. So we deduplicate this. And only have a single point of "we consider this whitespace".

Mon, Feb 10, 1:20 AM · efl
bu5hm4n added a comment to T8503: Efl.Canvas.Gesture_Recognizer.

Beside the name discussion: The API looks fine.

Mon, Feb 10, 12:10 AM · efl: api, efl (efl-1.24)
bu5hm4n added a comment to T8554: efl.canvas.gesture_touch.

With the patches applied, this looks very fine.

Mon, Feb 10, 12:07 AM · efl (efl-1.24), efl: api

Fri, Feb 7

bu5hm4n requested changes to D11276: elm: add a logic to load modules for ui inspection.
Fri, Feb 7, 6:55 AM · efl
bu5hm4n triaged T8610: Crash in filters as Showstopper Issues priority.
Fri, Feb 7, 5:46 AM · efl: canvas
bu5hm4n created T8610: Crash in filters.
Fri, Feb 7, 5:46 AM · efl: canvas
bu5hm4n accepted D11295: efl.ui.textbox: prevent longpress + right click from working on scrollbars.
Fri, Feb 7, 5:19 AM · efl
bu5hm4n accepted D11284: elementary: build elementary_test additionally as shared object.

Sounds good.

Fri, Feb 7, 1:40 AM · efl

Thu, Feb 6

Herald closed T8608: test as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Thu, Feb 6, 7:50 AM · Restricted Project
bu5hm4n updated subscribers of D11297: efl-check: do not print expected errors.

@segfaultxavi what would you propose as a good place for that ?

Thu, Feb 6, 7:31 AM · efl
bu5hm4n added inline comments to D11296: eina-suite: do not print that many errors.
Thu, Feb 6, 7:31 AM · efl
bu5hm4n added a comment to D11297: efl-check: do not print expected errors.

Correct :)

Thu, Feb 6, 4:02 AM · efl
bu5hm4n requested review of D11297: efl-check: do not print expected errors.
Thu, Feb 6, 2:08 AM · efl
bu5hm4n added a child revision for D11296: eina-suite: do not print that many errors: D11297: efl-check: do not print expected errors.
Thu, Feb 6, 2:08 AM · efl
bu5hm4n requested review of D11296: eina-suite: do not print that many errors.
Thu, Feb 6, 2:08 AM · efl
bu5hm4n requested changes to D11295: efl.ui.textbox: prevent longpress + right click from working on scrollbars.

Looks good otherwise.

Thu, Feb 6, 12:15 AM · efl

Wed, Feb 5

bu5hm4n accepted D11293: evas_object_textbox: deal with <br> <tab> without closing '/'.
Wed, Feb 5, 8:28 AM · efl
bu5hm4n accepted D11265: bindings-cxx: fix missing @since tags.
Wed, Feb 5, 7:32 AM · efl
bu5hm4n removed a parent revision for D11265: bindings-cxx: fix missing @since tags: D11264: move stabelized items out of @beta.
Wed, Feb 5, 6:20 AM · efl
bu5hm4n removed a child revision for D11264: move stabelized items out of @beta: D11265: bindings-cxx: fix missing @since tags.
Wed, Feb 5, 6:20 AM · efl
bu5hm4n removed a parent revision for D11245: efl/gesture: move manager's recognizer cleanup function to eo: D11244: efl/gesture: remove unused manager function.
Wed, Feb 5, 3:29 AM · efl
bu5hm4n removed a child revision for D11244: efl/gesture: remove unused manager function: D11245: efl/gesture: move manager's recognizer cleanup function to eo.
Wed, Feb 5, 3:29 AM · efl
bu5hm4n added a comment to T8290: replace legacy text widget usage in eo-based widgets.

I just checked to replace the elm_entry usage in Efl.Ui.Spin_Button. Not possible right now, i cannot find the ef.ui equivalent of elm_entry_markup_filter_append.

Wed, Feb 5, 12:11 AM · efl: api
bu5hm4n moved T8572: efl.canvas.rectangle from Backlog to Stabilized on the efl: api board.
Wed, Feb 5, 12:02 AM · efl: api
bu5hm4n added a comment to T8572: efl.canvas.rectangle.

I also think this looks fine.

Wed, Feb 5, 12:02 AM · efl: api
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

They do not really care for the C&P stuff, they are just doing the operation which uses C&P in the background. But they look fine.

Wed, Feb 5, 12:01 AM · efl (efl-1.24), efl: api, efl: language bindings

Tue, Feb 4

bu5hm4n accepted D11283: evas: prevent calling api with NULL filter image.

Thank you.

Tue, Feb 4, 11:53 PM · efl
bu5hm4n added a comment to T8599: Efl.Text_Change_Type.

Looks easy enough

Tue, Feb 4, 11:30 PM · efl: api, efl (efl-1.24)
bu5hm4n added a comment to T8522: Efl.Ui.Textbox class.

I dont feel comfy doing any final call on that @woohyun @zmike @segfaultxavi any last comments ?

Tue, Feb 4, 11:29 PM · efl (efl-1.24), efl: api, efl: language bindings
bu5hm4n added a comment to T8541: Efl.Input.Text.

I think we are speaking about the 6 enums in the top of this ticket.

Tue, Feb 4, 2:32 AM · efl: language bindings, efl: api
bu5hm4n added a comment to T8541: Efl.Input.Text.

@segfaultxavi the content of this ticket has changed. There are now more enums.

Tue, Feb 4, 2:20 AM · efl: language bindings, efl: api