Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (276 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

Today

bu5hm4n added a comment to D7495: csharp: add a interface to start apps.

As far i understood the situation, Efl.All is going to be internal, and this interface is the thing that should be used. So all in all the components declaration can stay here.

Mon, Mar 25, 10:35 AM · efl: language bindings
bu5hm4n updated the diff for D8456: efl_scroll: do not eat wheel events.

here comes a test

Mon, Mar 25, 9:38 AM · efl
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.

yes.

Mon, Mar 25, 9:21 AM · efl
bu5hm4n updated the diff for D8455: efl_ui_slider: block scrolling when on slider.

added testcase

Mon, Mar 25, 9:15 AM · efl
bu5hm4n accepted D8439: tests: add function to do "real" timers.
Mon, Mar 25, 7:26 AM · Restricted Project
bu5hm4n accepted D8440: tests: add test for elm_entry magnifier.
Mon, Mar 25, 6:29 AM · Restricted Project
bu5hm4n added a comment to D8439: tests: add function to do "real" timers.

Why is this api explicitly needed, and not just ecore_timer_add in the test itself ?

Mon, Mar 25, 6:27 AM · Restricted Project
bu5hm4n accepted D8438: tests: make elm_win visible during tests.
Mon, Mar 25, 6:26 AM · Restricted Project
bu5hm4n added reviewers for D8455: efl_ui_slider: block scrolling when on slider: zmike, cedric, segfaultxavi.
Mon, Mar 25, 6:04 AM · efl
bu5hm4n added reviewers for D8456: efl_scroll: do not eat wheel events: zmike, cedric, stefan_schmidt.
Mon, Mar 25, 6:03 AM · efl
bu5hm4n added a comment to D8455: efl_ui_slider: block scrolling when on slider.

Its hard to impossible to test this commit. It just holds the scrollers while the mouse is over a slider. there is no example to particulary verify this single commit.

Mon, Mar 25, 3:39 AM · efl
bu5hm4n accepted D8464: elm_win: fix correct rot variable in elm_win_rotation_get.

Nice catch!

Mon, Mar 25, 3:35 AM · efl
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.

And its actaully a bug fix ... :)

Mon, Mar 25, 3:32 AM · efl
bu5hm4n added a comment to D8456: efl_scroll: do not eat wheel events.

Just take a look into the referenced task

Mon, Mar 25, 3:32 AM · efl
bu5hm4n requested changes to D8450: elementary: make sure that the model parent being used is always the fileselector..

Okay, i don't know whatever commit in this stack caused this, but now my testsuite fails with: ../src/tests/elementary/elm_test_fileselector.c:135:F:elm_fileselector:elm_fileselector_selected:0: Assertion 'elm_fileselector_selected_get(fileselector) == exist' failed: elm_fileselector_selected_get(fileselector) == "/tmp/elm_test-bQ9btE", exist == "/tmp/elm_test-bQ9btE/exist"

Mon, Mar 25, 3:30 AM · efl
bu5hm4n accepted D8450: elementary: make sure that the model parent being used is always the fileselector..
Mon, Mar 25, 3:25 AM · efl
bu5hm4n accepted D8449: elementary: prevent asynchronous properties change to believe target is ready when it is not in fileselector..
Mon, Mar 25, 3:25 AM · efl
bu5hm4n accepted D8448: elementary: fix fileselector entry support to define path manually..
Mon, Mar 25, 3:24 AM · efl
bu5hm4n accepted D8447: eio: guarantee that we will at least process one request per loop iteration for very slow system..
Mon, Mar 25, 3:24 AM · efl
bu5hm4n accepted D8375: elementary: destroy fileselector children when they are not itemized yet..
Mon, Mar 25, 3:23 AM · efl
bu5hm4n accepted D8336: elementary: improve lifecycle of model object in the fileselector widget..
Mon, Mar 25, 3:23 AM · efl
bu5hm4n added a comment to D8336: elementary: improve lifecycle of model object in the fileselector widget..

Given that we are heading from one *deepshit* issue into the next, i will just closed eye approve this, given that the appearance before the commits is the same just with a lots more errors.

Mon, Mar 25, 3:23 AM · efl
bu5hm4n accepted D8461: efl_ui_container_layout: use correct property.

Thanks a lot! :)

Mon, Mar 25, 2:58 AM · efl
bu5hm4n closed T7755: infinite loop in focus manager on destroy as Resolved.
Mon, Mar 25, 2:55 AM · Restricted Project, efl (efl-1.22)
bu5hm4n removed a child revision for D8365: meson: do not set max log level: D8366: elm_gengrid: rework focus registration.
Mon, Mar 25, 2:50 AM · efl
bu5hm4n removed a parent revision for D8366: elm_gengrid: rework focus registration: D8365: meson: do not set max log level.
Mon, Mar 25, 2:50 AM · efl
bu5hm4n added inline comments to D8461: efl_ui_container_layout: use correct property.
Mon, Mar 25, 2:42 AM · efl
bu5hm4n added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

The reason i did not review this earlier was, that there was a open question from you to jsuyu, can you next time clarify that his concerns have been met or they have been invalid, I did not want to land this before this questions have been addressed / clarified. Thank you :)

Mon, Mar 25, 2:41 AM · efl
bu5hm4n accepted D8427: efl_access: add test cases for reading_info_type_set/get API.

Thank you!

Mon, Mar 25, 2:39 AM · efl

Yesterday

bu5hm4n added a reviewer for D8459: efl_ui_widget: reintroduce legacy behaviour: YOhoho.
Sun, Mar 24, 11:28 AM · efl
bu5hm4n requested review of D8459: efl_ui_widget: reintroduce legacy behaviour.
Sun, Mar 24, 11:27 AM · efl
bu5hm4n added a child revision for D8458: efl_ui_widget: add tests for parent and disalbed property: D8459: efl_ui_widget: reintroduce legacy behaviour.
Sun, Mar 24, 11:27 AM · efl
bu5hm4n requested review of D8458: efl_ui_widget: add tests for parent and disalbed property.
Sun, Mar 24, 11:27 AM · efl
bu5hm4n added a child revision for D8457: efl_ui_test_widget: ensures tests do not error: D8458: efl_ui_widget: add tests for parent and disalbed property.
Sun, Mar 24, 11:27 AM · efl
bu5hm4n requested review of D8457: efl_ui_test_widget: ensures tests do not error.
Sun, Mar 24, 11:27 AM · efl
bu5hm4n requested review of D8456: efl_scroll: do not eat wheel events.
Sun, Mar 24, 5:53 AM · efl
bu5hm4n added a child revision for D8455: efl_ui_slider: block scrolling when on slider: D8456: efl_scroll: do not eat wheel events.
Sun, Mar 24, 5:53 AM · efl
bu5hm4n added a revision to T2529: Scrolling past a slider will activate a slider during scroll: D8456: efl_scroll: do not eat wheel events.
Sun, Mar 24, 5:53 AM · efl (efl-1.22), efl: widgets
bu5hm4n requested review of D8455: efl_ui_slider: block scrolling when on slider.
Sun, Mar 24, 5:53 AM · efl
bu5hm4n added a revision to T2529: Scrolling past a slider will activate a slider during scroll: D8455: efl_ui_slider: block scrolling when on slider.
Sun, Mar 24, 5:53 AM · efl (efl-1.22), efl: widgets
bu5hm4n added a comment to T6247: Please install engine headers again.

So this is a won't fix ?

Sun, Mar 24, 5:00 AM · efl
bu5hm4n updated subscribers of T7753: efl.ui.panel example in elementary_test hangs infinitely.

@YOhoho you fixed something simular, can you take a look at this ?

Sun, Mar 24, 4:55 AM · efl (efl-1.22), efl: widgets
bu5hm4n updated subscribers of T7756: 'part background' in elementary_test spews lots of errors and doesn't display correctly.

@YOhoho D7841 caused this error, it appears that efl_ui_container_layout cannot handle a few objects there. Can you take a look ? :)

Sun, Mar 24, 4:53 AM · efl (efl-1.22), efl: widgets

Sat, Mar 23

bu5hm4n added a comment to T5567: Simple factories (with or without model).

I have not read the whole discussion, only the task description, but isn't this does with Efl.Ui.Widget_Factory ?

Sat, Mar 23, 1:18 PM · efl (efl-1.22), efl: mvvm, efl: widgets
bu5hm4n closed T7250: Safety checks triggered when the app closes as Resolved.

I cannot see those errors on elementary_config anymore.

Sat, Mar 23, 9:50 AM · efl (efl-1.22), efl: widgets
bu5hm4n closed T7499: solve compiler (gcc) warnings between __attribute__ ((__malloc__)) and __attribute__ ((__pure__)) as Resolved.

I think this was resolved a while ago, feel free to reopen if you see it again :)

Sat, Mar 23, 9:48 AM · efl (efl-1.22)
bu5hm4n closed T7499: solve compiler (gcc) warnings between __attribute__ ((__malloc__)) and __attribute__ ((__pure__)), a subtask of T7142: efl 2.0 considerations, as Resolved.
Sat, Mar 23, 9:48 AM · Restricted Project, efl
bu5hm4n added a comment to D6726: elementary image: apply lazy calculation and guarantee retained method..

This is causing T7360. Can you take a look at why this is happening ?

Sat, Mar 23, 7:02 AM · efl
bu5hm4n updated subscribers of T7360: Evas/Edje animations not in sync .

Okay, cause found!

Sat, Mar 23, 7:01 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
bu5hm4n added a comment to T7360: Evas/Edje animations not in sync .

A little bit more debugging information: this is related to elm_image, if you replace the elm_icon part in the test_icon.c with a direct evas_image, then everything is fine, no lacking, by the time you make it a elm_image, the lacking starts to happen.

Sat, Mar 23, 6:48 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Fri, Mar 22

bu5hm4n added a comment to D8336: elementary: improve lifecycle of model object in the fileselector widget..

Okay, if i am now using the most upperst revision then the items do not get mixed up anymore. However, the first population run finishes before the new path is populated. This is something that I would not expect as a user.

Fri, Mar 22, 1:40 PM · efl
Herald closed T6893: weird animation when focusing the config menu as Resolved.

Ho Ho Ho! This issue was fixed by Santa!

/o\

Fri, Mar 22, 9:16 AM · santa, Restricted Project
bu5hm4n closed T7762: warning in meson output : 'break' keyword as Wontfix.

Yeah ... and this is just fine, meson later on brings this keyword in...

Fri, Mar 22, 9:14 AM · Restricted Project
bu5hm4n lowered the priority of T7763: Windows : meson build fails with undef ref from Showstopper Issues to Normal.

This has nothing to do with windows, evas and meson do not play well together, hence evas is build with leaving internal API outside linking. You can -Db_lundef=true in order to workarround this.

Fri, Mar 22, 9:13 AM · Restricted Project
bu5hm4n accepted D8446: docs: Add @since 1.22 to all stable classes' EO docs.
Fri, Mar 22, 8:55 AM · efl
bu5hm4n added a project to D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets: DO NOT MERGE.
Fri, Mar 22, 8:45 AM · DO NOT MERGE, efl
bu5hm4n accepted D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

I 100% agree with this change. However, can we wait with this change until we are open for the next release ?

Fri, Mar 22, 8:40 AM · DO NOT MERGE, Restricted Project
bu5hm4n added a comment to T7360: Evas/Edje animations not in sync .

A little bit of debugging information: this is fully related to images. You can replace the icons in the genlist with a button or label, and there is no lacking.

Fri, Mar 22, 8:36 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
bu5hm4n added a comment to D7495: csharp: add a interface to start apps.

@Jaehyun_Cho the reason i have added this under the csharp namespace is that it *cannot* be confused with autogenerated EFL applications, and we prevent later collisions in case we want to name a class efl.application.

Fri, Mar 22, 6:17 AM · efl: language bindings

Thu, Mar 21

bu5hm4n added a comment to T7725: master ticket for 1.22 api stabilization.

With the script given in [1] you can check how many problem cases we have. We have 0 *direct* problem cases, but ~8 cases that cannot be checked by the script. However, they are looking fine to me.

Thu, Mar 21, 4:09 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n updated the task description for T7725: master ticket for 1.22 api stabilization.
Thu, Mar 21, 4:08 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested changes to D8375: elementary: destroy fileselector children when they are not itemized yet..

Does not apply here ...

Thu, Mar 21, 3:24 AM · efl
bu5hm4n added a comment to T7760: Document event info calling convention.

Looks fine to add them to Eo.h efl_event_callback_call is the only one accepting event_info afair.

Thu, Mar 21, 3:20 AM · efl: docs, Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested changes to D8336: elementary: improve lifecycle of model object in the fileselector widget..

#1 Open a large directory in fileselector, close the window -> SEGV
#2 Open a large directory in fileselector, click on home -> things get added to the view that are not in the directory that is least recently opened
#3 Open a fileselector, click arround -> observe a giant amount of errors in the console

Thu, Mar 21, 3:17 AM · efl
bu5hm4n accepted D8336: elementary: improve lifecycle of model object in the fileselector widget..
Thu, Mar 21, 3:09 AM · efl
bu5hm4n accepted D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist".
Thu, Mar 21, 2:37 AM · efl
bu5hm4n accepted D8359: elementary: only apply text when the object is not invalidated and dying..

I wait for the day we get a bug report "But i wanted to set text while the object was beeing deleted! I used that to safe a string Plz fix!"

Thu, Mar 21, 2:37 AM · efl
bu5hm4n closed T7476: efl: Rename duplicated event names as Resolved.

ab30ff3f9bd8b82c5df9c97e0092d18221f0b7dc

Thu, Mar 21, 2:36 AM · efl: language bindings
bu5hm4n accepted D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..
Thu, Mar 21, 2:32 AM · efl
bu5hm4n accepted D8335: eio: path and filename property should always remind accessible even in case of error..

_eio_build_st is protecting itself from doing what I wrote above, it just feels a little bit fragile, since changing this would leave the world in parts, maybe make pd->st = NULL and pd->info = NULL; in case of an error ?

Thu, Mar 21, 2:31 AM · efl
bu5hm4n awarded D8433: efl.pack_linear: enhance documentation a Orange Medal token.
Thu, Mar 21, 2:24 AM · efl
bu5hm4n accepted D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Thu, Mar 21, 2:20 AM · efl
bu5hm4n accepted D8436: elm : fix wrong layout class comparing in orientation mode disable.
Thu, Mar 21, 2:17 AM · efl
bu5hm4n added a comment to T7701: Rename Efl.Ui.Stack.

Let's just keep this here open until the release is out, then we can still decide on a name :)

Thu, Mar 21, 1:48 AM · efl: api

Wed, Mar 20

bu5hm4n updated the diff for D8425: eolian: enable event redef checking by default.

use less stupid API in eolian.

Wed, Mar 20, 12:26 PM · efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.

Maybe just try to use inline comments for once, it might be usefull...

Wed, Mar 20, 12:19 PM · efl
bu5hm4n updated the diff for D8425: eolian: enable event redef checking by default.

update

Wed, Mar 20, 12:03 PM · efl
bu5hm4n claimed T7758: Resolving all problem event calls in efl.
Wed, Mar 20, 10:51 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7476: efl: Rename duplicated event names: D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 10:45 AM · efl: language bindings
bu5hm4n added a task to D8425: eolian: enable event redef checking by default: T7476: efl: Rename duplicated event names.
Wed, Mar 20, 10:45 AM · efl
bu5hm4n added reviewers for D8425: eolian: enable event redef checking by default: q66, lauromoura, zmike, cedric, stefan_schmidt, devilhorns.
Wed, Mar 20, 10:44 AM · efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.

This can now be reviewed!

Wed, Mar 20, 10:44 AM · efl
bu5hm4n removed a project from D8425: eolian: enable event redef checking by default: DO NOT MERGE.
Wed, Mar 20, 10:44 AM · efl
bu5hm4n accepted D8426: csharp: Remove test about conflicting events..
Wed, Mar 20, 10:43 AM · efl
bu5hm4n added a comment to D8350: efl_canvas_vg_object: Fix dereference after null check.

If one, either pname or fileis NULL then the pl / cl is different, and the block is executed. Hence, if the strcmp is executed either both are NULL or both are not NULL. Thus This commit seems fine.

Wed, Mar 20, 10:06 AM · efl
bu5hm4n accepted D8350: efl_canvas_vg_object: Fix dereference after null check.
Wed, Mar 20, 9:48 AM · efl
bu5hm4n added a comment to D6895: eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig.

I cannot find -S in a .pc file ...

Wed, Mar 20, 9:25 AM · efl
bu5hm4n requested changes to D7242: Efl.Ui.Tree_View: added new MVVM asynchronous widget.

Segarray is still in the API so cedrics wish was not fullfilled.

Wed, Mar 20, 9:06 AM · efl
bu5hm4n added reviewers for D8324: csharp: Export correct headers and files: bu5hm4n, segfaultxavi, cedric, devilhorns.
Wed, Mar 20, 9:01 AM · efl
bu5hm4n accepted D8416: ci: disable exit-on-error during configure and also grab stderr.
Wed, Mar 20, 8:55 AM · efl
bu5hm4n requested changes to D8426: csharp: Remove test about conflicting events..

Autotools support (marking is as RC so its out of the pipeline)

Wed, Mar 20, 8:55 AM · efl
bu5hm4n requested changes to D8427: efl_access: add test cases for reading_info_type_set/get API.

Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?

Wed, Mar 20, 8:53 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This revision actaully fixes that and makes it shutting down in a few seconds.

Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a revision to T7755: infinite loop in focus manager on destroy: D8367: elm_gengrid: speed up update order calls.
Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a task to D8367: elm_gengrid: speed up update order calls: T7755: infinite loop in focus manager on destroy.
Wed, Mar 20, 8:38 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Are you sure its a infinite loop, or just terribly slow? It takes here ~ 3 min. until the window is closed. It is faster with my recent gengrid patches ... :)

Wed, Mar 20, 8:28 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaan :(

Wed, Mar 20, 8:24 AM · Restricted Project, efl (efl-1.22)
bu5hm4n requested review of D8428: build: codegen generation should depend on elementary_codegen.
Wed, Mar 20, 8:24 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This is usally a indicator that the widget tree builds a cycle in the shutdown. I can open here a lot of windows and nothing happens, it might be depending on what kind of widgets are there. Do you remember which windows you opened ?

Wed, Mar 20, 8:13 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to D8426: csharp: Remove test about conflicting events..

Is there a reason why this does not change Makefiles ?

Wed, Mar 20, 8:01 AM · efl