Page MenuHomePhabricator

bu5hm4n (Marcel Hollerbach)Administrator
spacecowboy

Projects (8)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2013, 11:58 AM (355 w, 6 d)
Roles
Administrator
Availability
Available

Recent Activity

Mon, Sep 21

bu5hm4n added a comment to D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.

What you describe is definitly a bug which should be fixed yes.

Mon, Sep 21, 2:26 AM · efl

Fri, Sep 18

bu5hm4n added a comment to D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.

Making the unregister in line 231 conditionally for not widgets should fix that.

Fri, Sep 18, 7:51 AM · efl

Thu, Sep 17

bu5hm4n added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

Oh okay sorry - my brain fully worked in phabricator terminology there :(

Thu, Sep 17, 4:29 AM · efl
bu5hm4n added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

@n3rdopolis can we just use your mail address nerdopolis <bluescreen_avenger@verizon.net> for landing this ?

Thu, Sep 17, 2:13 AM · efl
bu5hm4n added a comment to D12143: call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0.

You can get the raw diff just here by clicking above "download raw diff".

Thu, Sep 17, 2:06 AM · efl

Mon, Sep 14

bu5hm4n requested changes to D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.
  1. This breaks legacy drop targets on none efl.ui.dnd elements.
  2. This breaks registering 2 events, unregistering 1 -> no event will be delivered anymore.
Mon, Sep 14, 4:48 AM · efl

Thu, Sep 10

bu5hm4n added a comment to D12130: evas_textblock: Add check for NULL pointers after malloc.

_layout_get_hyphenationwrap also needs to protect against wordbreaks beeing NULL (as its now checked before).

Thu, Sep 10, 2:44 AM · efl
bu5hm4n added a comment to D12132: eo: fix gdb install dir.

Mhm, there are a few things that are not right in the way it is done right now:

  1. false as argument to install_dir is deprecated, the entire configure file blog should be moved to the first if clause.
  2. the prefix of efl can be different to the prefix of gdb, (for me efl goes to /usr/local/ and gdb goes to /usr/, gdb loads /usr/local as well as /usr/), so dir_lib actaully needs to be gdb prefix here, not the one of efl.
Thu, Sep 10, 2:36 AM · efl

Aug 29 2020

bu5hm4n updated subscribers of T8692: Edje failed with evas render-engine buffer missing.

Thank you for your reply, i think the question here is if we want to cover our buildsystem for this usecase or not as this could get quite messy. @stefan_schmidt What would you say ?

Aug 29 2020, 12:20 AM · efl

Aug 19 2020

bu5hm4n added a comment to D12105: eolian_gen: Add support to response files..

Just my two cents: I think the tests should unconditionally run with the respones files, and not only if PATH_MAX is too small, this way we can ensure that the respone file is tested on any maschine that runs the tests.

Aug 19 2020, 11:47 PM · efl

Aug 14 2020

bu5hm4n added a comment to D12107: ecore_exe_posix: add timeout exception to avoid deadlock..

Maybe as a quickfix it would be good to *not* call eina_file_close_from at all for now we only have that since 8 months. (And additionally, add a ok into the for loop)

Aug 14 2020, 12:59 AM · efl

Aug 13 2020

bu5hm4n added a comment to D12107: ecore_exe_posix: add timeout exception to avoid deadlock..

Mhm, there is more: if a application has 2 threads running, and the other thread is in a critical section in malloc when we are calling fork, eina_file_close_from will never come to call realloc, which ultimatly deadlocks the child process, deadlocking the parent process on the read call. (That is also something the links given by @eagleeye are suggesting)

Aug 13 2020, 3:15 AM · efl
bu5hm4n added a comment to D12107: ecore_exe_posix: add timeout exception to avoid deadlock..

Undependend from whatever the reason for this deadlock is:

Aug 13 2020, 2:46 AM · efl

Aug 10 2020

bu5hm4n requested review of D12101: eo: set idx on exit to 1 not to 0.
Aug 10 2020, 5:38 AM · efl
bu5hm4n added a revision to T8787: Segmentation Fault by ecore_main_loop_iterate: D12101: eo: set idx on exit to 1 not to 0.
Aug 10 2020, 5:38 AM · efl (efl-1.24)
bu5hm4n added a comment to T8787: Segmentation Fault by ecore_main_loop_iterate.

Mistake found, give me a few hours to run tests.

Aug 10 2020, 1:28 AM · efl (efl-1.24)

Aug 8 2020

bu5hm4n added a comment to T8692: Edje failed with evas render-engine buffer missing.

mhm, this issue is a quite weird, libbuffer.so should be renamed by a post installation script.
Would you mind answering / doing the following:

  1. Share the log of your "ninja install" invocation ?
  2. Which distro are you on?
  3. Which meson version are you on ?
  4. Whats your process of building efl ?
Aug 8 2020, 12:28 AM · efl

Aug 6 2020

bu5hm4n accepted D12087: edje_entry: fix a potentional error of null deref.

Seems good. Thx.

Aug 6 2020, 1:33 AM · efl

Aug 5 2020

bu5hm4n updated the diff for D12097: eo: event callback call optimization.

add comments and a nicer for loop

Aug 5 2020, 9:56 AM · efl
bu5hm4n added a comment to D12097: eo: event callback call optimization.

But yeah, i will write more comments for the code there.

Aug 5 2020, 9:36 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

@kimcinoo should we adjust that behaviour in cycle ? (Same argument applies there)

Aug 5 2020, 2:07 AM · efl
bu5hm4n requested review of D12097: eo: event callback call optimization.
Aug 5 2020, 2:05 AM · efl
bu5hm4n added a child revision for D12079: eo: evalulate special counts earlier: D12097: eo: event callback call optimization.
Aug 5 2020, 2:05 AM · efl
bu5hm4n updated the diff for D12079: eo: evalulate special counts earlier.

rebase

Aug 5 2020, 2:05 AM · efl
bu5hm4n updated the diff for D12078: eo: make callback_add faster.

rebase & commit message update

Aug 5 2020, 2:04 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

Okay, i will wait with landing.

Aug 5 2020, 12:47 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

I guess this diff is not about the concept, i will just load the old version of it.

Aug 5 2020, 12:41 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

Mhm yeah, that is true. But on a conceptual level i am not sure if it is a good idea to do this, as there is no assertion the correct audio & visual are done, and thats kind of the point of the extension...

Aug 5 2020, 12:40 AM · efl
bu5hm4n accepted D12093: efl_canvas: fix a potentional error of null deref.

thx.

Aug 5 2020, 12:14 AM · efl
bu5hm4n updated subscribers of D12087: edje_entry: fix a potentional error of null deref.
Aug 5 2020, 12:12 AM · efl
bu5hm4n accepted D12091: evas/engine: fix a potentional error of null deref.

Yeah sorry, i missed the assignment, look good to me. (I wont land, waiting for @jsuya.

Aug 5 2020, 12:04 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

If there is no target (info's next or prev), elm_access finds the target once again in the focus_relation (539 line).

Aug 5 2020, 12:03 AM · efl

Aug 4 2020

bu5hm4n added a comment to D12086: edje: fix a potentional error of null deref.

jup :)

Aug 4 2020, 5:53 AM · efl
bu5hm4n accepted D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 5:35 AM · efl
bu5hm4n requested changes to D12093: efl_canvas: fix a potentional error of null deref.

I think this is also a case for a eina_safety_on_null_return, as this should simply never happen.

Aug 4 2020, 5:35 AM · efl
bu5hm4n added a comment to D12092: elm_access: fix a potentional error of null deref.

can you make a safety check out of that ? I dont think we should continue there if access data is missing.

Aug 4 2020, 5:34 AM · efl
bu5hm4n requested changes to D12091: evas/engine: fix a potentional error of null deref.

im is already checked in this function, and ensured to be none NULL.

Aug 4 2020, 5:29 AM · efl
bu5hm4n accepted D12089: evas: fix a potentional error of null deref.
Aug 4 2020, 5:21 AM · efl
bu5hm4n added a comment to D12088: evas_bidi: fix a potentional error of null deref.

eina_unicode_utf8_to_unicode can only return NULL on memory allocation, i think its better to have have a early return of NULL when udelim is NULL.

Aug 4 2020, 5:21 AM · efl
bu5hm4n requested changes to D12087: edje_entry: fix a potentional error of null deref.

I dont think this is really what you want.

Aug 4 2020, 5:20 AM · efl
bu5hm4n added a comment to D12085: efl_ui_timepicker: Add null check for efl_text_get.

you can also just use eina_streq, which does NULL checking.

Aug 4 2020, 3:20 AM · efl

Aug 2 2020

bu5hm4n added a comment to D12078: eo: make callback_add faster.

Mhm :( yeah, now the times are not great anymore ... :|
Old:

       471.34 msec task-clock:u              #    0.964 CPUs utilized
            0      context-switches:u        #    0.000 K/sec
            0      cpu-migrations:u          #    0.000 K/sec
        7,327      page-faults:u             #    0.016 M/sec
1,513,816,860      cycles:u                  #    3.212 GHz
2,246,871,347      instructions:u            #    1.48  insn per cycle
  375,434,454      branches:u                #  796.526 M/sec
    4,104,794      branch-misses:u           #    1.09% of all branches
Aug 2 2020, 2:48 AM · efl
bu5hm4n added a comment to D12080: fix warning in elm test slider (maybe uninitialized).

mhm, there is *no* chance that fslider can be uninitializied ?

Aug 2 2020, 12:23 AM · efl

Jul 31 2020

bu5hm4n accepted D12060: elm_config: add slider to configure tooltip_delay.

Nice, thx!

Jul 31 2020, 3:46 AM · efl
bu5hm4n requested review of D12079: eo: evalulate special counts earlier.
Jul 31 2020, 1:57 AM · efl
bu5hm4n added a child revision for D12078: eo: make callback_add faster: D12079: eo: evalulate special counts earlier.
Jul 31 2020, 1:57 AM · efl
bu5hm4n requested review of D12078: eo: make callback_add faster.
Jul 31 2020, 1:57 AM · efl
bu5hm4n requested changes to D12060: elm_config: add slider to configure tooltip_delay.

This looks really nice otherwise :)

Jul 31 2020, 1:16 AM · efl
bu5hm4n accepted D12076: evas_textblock: remove logically dead code.

For the record:

Jul 31 2020, 1:12 AM · efl

Jul 29 2020

bu5hm4n updated the diff for D12072: efl_ui_focus_manager: reduce the amount of relying on events.

address review comments

Jul 29 2020, 8:58 AM · efl
bu5hm4n added a comment to D12072: efl_ui_focus_manager: reduce the amount of relying on events.

Will update later or tomorrow :)

Jul 29 2020, 8:25 AM · efl
bu5hm4n requested review of D12072: efl_ui_focus_manager: reduce the amount of relying on events.
Jul 29 2020, 3:08 AM · efl

Jul 28 2020

bu5hm4n added a comment to D12069: tests: fix eio tests.

https://travis-ci.org/github/Enlightenment/efl/builds/712468414

Jul 28 2020, 12:46 AM · efl
bu5hm4n requested review of D12069: tests: fix eio tests.
Jul 28 2020, 12:32 AM · efl

Jul 27 2020

bu5hm4n added a comment to D12068: ci: do not build tests on ci.

https://travis-ci.org/github/Enlightenment/efl/builds/712166565

Jul 27 2020, 5:25 AM · efl
bu5hm4n requested review of D12068: ci: do not build tests on ci.
Jul 27 2020, 4:53 AM · efl
bu5hm4n added a child revision for D12067: build: warn of faulty check version: D12068: ci: do not build tests on ci.
Jul 27 2020, 4:53 AM · efl
bu5hm4n requested review of D12067: build: warn of faulty check version.
Jul 27 2020, 4:53 AM · efl

Jul 17 2020

bu5hm4n added a comment to D12057: efl: make all _class_get() functions const.

I can do that if that helps anyone reviewing it. But its all the same ... :)

Jul 17 2020, 12:51 AM · efl

Jul 16 2020

bu5hm4n requested review of D12057: efl: make all _class_get() functions const.
Jul 16 2020, 3:57 AM · efl

Jul 6 2020

bu5hm4n requested changes to D11995: efl-one: Get c_args from library to include in compilation.

Mhm, can you elaborate why this is needed ?
As of right now, the package_c_args from the lib will be in package_c_args in meson.build:449, so i think this is currently unnessesary ? Where exactly was or is the missing symbol ?

Jul 6 2020, 8:06 AM · efl
bu5hm4n accepted D12042: benchmark: eina: remove outdated ecore_hash.

Yeah time to remove it. https://i.pinimg.com/originals/28/5b/d8/285bd859271e26b94c3ce54881d0bddb.jpg

Jul 6 2020, 7:59 AM · efl

Jul 3 2020

bu5hm4n added a comment to D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Thank you!

Jul 3 2020, 9:17 AM · efl
bu5hm4n resigned from D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Jul 3 2020, 12:11 AM · efl
bu5hm4n requested changes to D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.

Patch does not apply ...

Jul 3 2020, 12:10 AM · efl
bu5hm4n accepted D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Jul 3 2020, 12:08 AM · efl

Jul 1 2020

bu5hm4n accepted D11994: Meson.build cleanup..

thx.

Jul 1 2020, 1:13 AM · efl
bu5hm4n added a comment to D11994: Meson.build cleanup..

Note to myself, dont comment before awake: https://travis-ci.org/github/Enlightenment/efl/builds/703813078

Jul 1 2020, 12:30 AM · efl
bu5hm4n added a comment to D11994: Meson.build cleanup..

https://travis-ci.org/github/Enlightenment/efl

Jul 1 2020, 12:28 AM · efl

Jun 30 2020

bu5hm4n added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

I don't want to install an application to be able to compile or download dependencies. This makes no sense at all IMO. If we're not going to have wrap dependencies, we still need to be able to tell where dependencies are without pkg-config. We have neither, and wrap dependencies is a meson feature which, IMO, helps a lot. Lots of other libraries use it (gstreamer for example). And this doesn't need to be on by default. I wouldn't need subprojects in Linux (though I've used subprojects for gstreamer when developing for it, and was much easier when using git versions).

Jun 30 2020, 12:38 PM · efl
bu5hm4n added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Hi bu5hm4n.

Jun 30 2020, 7:12 AM · efl

Jun 27 2020

bu5hm4n updated subscribers of D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

I am not really a fan of using subprojects here either, not because subprojects per se are bad, but they dont fit the scheme of efl and how distros work. Just from the top of my head a idea on why i dont think its a good idea:

  • In case we are having subprojects, we are defining the version of a dependency, not the min version of anything, the version itself is then defined, in case there is a CVE or some major bug, we need to proactivly reroll another release of efl bump versions etc.. Not sure we have the capacity in the release department for that CC @stefan_schmidt )
  • Not all meson projects can be used as subprojects, some require external dependencies, in case some code compiler is compiled, cross compilation will fail.
  • Sometimes wraps do disappear (example stb, there is still the entry in the wrapdb, but the wrap in gone) in case we ever rely on wrap, we also need to take a share on maintaining the wraps, or we might loose them
  • Subprojects bring the harm of 2 providers, so in case zlib-wrap is now sucked in as a dependency instead of a libzlib.so on the system, then the subproject wlll be compiled, and with the next ninja install it will be installed. In case you use any other project doing the same thing, or the distro shipping zlib as standalone, you will end up in a ugly conflict...
Jun 27 2020, 1:51 PM · efl

Jun 25 2020

bu5hm4n added a comment to D11994: Meson.build cleanup..

With these two comments, then: should I split 6 and 8 into two other patches? For 6 because we can track this in an isolated patch, and for 8 because of possible opinion divergence.

Sounds good :) (If getting out 8 is too much work, i dont have a issue with first merging that if the rest of the stuff is coming in a next patch :))

Jun 25 2020, 2:33 AM · efl
bu5hm4n added a comment to T8761: Standardize external dependency handling.

First Half of the issue

I think you can just remove the _dep prefix from these 4 vars ... no big deal, there is really no thought behind that scheme, just make sure the names do not collide :)
Jun 25 2020, 2:32 AM · efl

Jun 19 2020

bu5hm4n added a comment to D11993: eina: Change EAPI to EINA_API in Eina Library.

Independend from if this is a good idea or not, things that are not clear to me:

  • How to do that in eolian ? Every eolian API is defined with EOAPI, which is defined to be EAPI & EAPI_WEAK with this approach you either need to patch eolian to take the correct preprocessor directives (then eolian needs to guess in which lib it is), or you need to redefine EOAPI which is then reintroducing the thing you are trying to solve
  • How to handle EAPI's in modules ?
Jun 19 2020, 2:08 AM · efl
bu5hm4n requested changes to D11994: Meson.build cleanup..

1 / 2 / 3 / 4: fine for me.
We recently bumped min version to 0.50 so 5 & 7 Should hopefully work without issues.

Jun 19 2020, 1:51 AM · efl
bu5hm4n requested review of D11998: evas_common_privat: improve tiler merge flag.
Jun 19 2020, 12:05 AM · efl
bu5hm4n added a child revision for D11997: eina_array: micro optimize eina_array_push: D11998: evas_common_privat: improve tiler merge flag.
Jun 19 2020, 12:05 AM · efl
bu5hm4n requested review of D11997: eina_array: micro optimize eina_array_push.
Jun 19 2020, 12:05 AM · efl

Jun 17 2020

bu5hm4n accepted D11956: benchmarks: eina: make sure we do not divide by zero.

This looks fine, however, this is a ecore hash implementation that hasn't been running for > 10 years ... should we just remove it ?

Jun 17 2020, 3:51 AM · efl
bu5hm4n accepted D11963: tests: eio: make sure we check return value.
Jun 17 2020, 3:50 AM · efl

Jun 16 2020

bu5hm4n added a comment to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

THats good.

Jun 16 2020, 11:56 PM · efl
bu5hm4n accepted D11985: elementary/perf:remove unnecessary elm_widget_is() check.

Thank you. I checked upstream that we do not assigned parent_obj *ever* by hand. And we don't. Can you ensure the same in tizen ?

Jun 16 2020, 11:43 PM · efl
bu5hm4n accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

Yep, that now looks even better. Thank you :)

Jun 16 2020, 11:32 PM · efl
bu5hm4n accepted D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..

Looks good to me, thx.

Jun 16 2020, 11:24 PM · efl
bu5hm4n requested changes to D11985: elementary/perf:remove unnecessary elm_widget_is() check.

I think you can go ahead and simply remove these efl_isa calls.

Jun 16 2020, 11:11 PM · efl
bu5hm4n requested changes to D11984: elementary/perf: reduce number of efl_isa() call. in elementary test application efl_isa() shows up as hotsport during profiling so refactored the code to reduce redundant efl_isa() calls..
Jun 16 2020, 11:06 PM · efl
bu5hm4n added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

I cannot comment how it was with regards to backwards comp. but shoundn't this also check if the group is the same ?

Jun 16 2020, 8:00 AM · efl
bu5hm4n requested changes to D11973: meson: add Solaris support.

Beside that little nitpick it seems fine to me.

Jun 16 2020, 3:05 AM · efl

Jun 15 2020

bu5hm4n updated the task description for T8755: Compiler-Plugin for eo optimization.
Jun 15 2020, 4:37 AM · efl
bu5hm4n created T8755: Compiler-Plugin for eo optimization.
Jun 15 2020, 4:33 AM · efl

Jun 14 2020

bu5hm4n requested changes to D11973: meson: add Solaris support.
Jun 14 2020, 11:13 PM · efl

Jun 10 2020

bu5hm4n added a comment to T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.

@ali.alzyod since you have asked yesterday if there is anything. Does that ^ look like something you would be interested in ?

Jun 10 2020, 3:47 AM · efl
bu5hm4n updated subscribers of T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect.
Jun 10 2020, 3:47 AM · efl
bu5hm4n triaged T8750: [Optimization] Replacement of x,y,w,h with Eina_Rect as Normal priority.
Jun 10 2020, 3:46 AM · efl

Jun 9 2020

bu5hm4n added a comment to D11949: efl_ui_textpath: mathmatical calculations.

The code *is* the same, Add -O3 and you will just see that the code lines are not mapped to anything in asm. Even on the wegpage. The next example also gets eliminated the cos and sin calls.

Jun 9 2020, 4:38 AM · efl
bu5hm4n added a comment to D11949: efl_ui_textpath: mathmatical calculations.

Don't look at the times, take a look at objdump -S a.out the outputted asm is equivalent. Also take a look where the calls to clock are located. The time advantage you see is *not* coming from the different call. infact, the sin and cos calls are stripped out completly. As a mixture of inlining, dead code removal, and const folding removed it.

Jun 9 2020, 3:49 AM · efl
bu5hm4n added a comment to T8748: Performance Issue in ELM_WIDGET_ITEM_STATIC_FOCUS_CLASS class.

Well, you can transform the realize callbacks to real eo calls, and simply call them from gengrid / genlist, which will eliminate the need for the callback. However, this is not a priority for me, so feel free to do that.

Jun 9 2020, 3:38 AM
bu5hm4n requested review of D11954: mono: update window construction.
Jun 9 2020, 3:11 AM · efl
bu5hm4n added a comment to D11948: efl: reduce sqrt(2) calculations (division vs multiplication).

@raster the problem with sqrt calls is that they do not get replaced in *all* compilers, clang on macos is not capable of doing that (i have no idea why). gcc on my raspi is also not doing it here ...

Jun 9 2020, 2:49 AM · efl