- User Since
- Jul 25 2016, 12:43 AM (211 w, 1 d)
Feb 19 2017
the leak was not limited to OuiWindow. problem came down to object loosing eo reference whilst js reference was still there. case of running example as global only is sort of malformed. garbage collector will assess whether objects present in global scope are required for any scopes referring directly to it and dispose of everything that's not required. which in essense means disposal of root OuiWindow.
Oct 31 2016
it does build :)
Oct 25 2016
fix candidate, registrations in efl_js.cc may still be incomplete.
Oct 11 2016
it sure does. thnx :)
Sep 28 2016
also you might consider removing efl::eina::js::make_leak() form efl::eo::js::construct_from_eo(). this call is redundant because all returned values eitherway go through efl::eina::js::get_value_from_c() and proper clean ups are set there. this is required after all for eo based events
Sep 8 2016
seems I fixed it, for your review
Aug 31 2016
following change fixes that problem:
nodejs object wrap includes v8::Persistent::MakeIndependent() call to alongside SetWeak(). node::ObjectWrap::MakeWeak(). seems like after that callbacks are being called as expected.
Aug 29 2016
Aug 26 2016
and I need to correct myself, did some more tests on the matter and it seems ptr's for the Persistents are the same which lead me to believe they are overrun but apparently Persistent is destroyed and callback for it simply not called.
hola @lauromoura , I did some debugging and think the problem is more general and comes down to v8 having a single entry for v8::Persistent::SetWeak() notification callback. called for the same v8 object that would cause a leak at efl::js level.
Aug 23 2016
Aug 17 2016
delete_me test seems to be missing and debugs are left on
Jul 29 2016
Jul 28 2016
following patchseems to fix the problem.