Page MenuHomePhabricator

buniofh (Bunio Fh)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 25 2016, 12:43 AM (211 w, 1 d)
Availability
Available

Recent Activity

Feb 19 2017

buniofh added a comment to T4354: NodeJS/EFL: Created objects get garbage collected while they are still in use from JS side.

the leak was not limited to OuiWindow. problem came down to object loosing eo reference whilst js reference was still there. case of running example as global only is sort of malformed. garbage collector will assess whether objects present in global scope are required for any scopes referring directly to it and dispose of everything that's not required. which in essense means disposal of root OuiWindow.

Feb 19 2017, 12:23 AM · Restricted Project, efl

Oct 31 2016

buniofh added a comment to T4759: EFL 1.18 doesn't build against nodejs.

it does build :)

Oct 31 2016, 6:12 AM · efl
buniofh updated the task description for T4759: EFL 1.18 doesn't build against nodejs.
Oct 31 2016, 5:44 AM · efl
buniofh updated the task description for T4759: EFL 1.18 doesn't build against nodejs.
Oct 31 2016, 5:42 AM · efl

Oct 25 2016

buniofh added a comment to T4759: EFL 1.18 doesn't build against nodejs.

fix candidate

, registrations in efl_js.cc may still be incomplete.

Oct 25 2016, 4:20 AM · efl
buniofh updated subscribers of T4759: EFL 1.18 doesn't build against nodejs.
Oct 25 2016, 4:20 AM · efl
buniofh created T4759: EFL 1.18 doesn't build against nodejs.
Oct 25 2016, 4:16 AM · efl

Oct 11 2016

buniofh added a comment to T4226: clipper is not being set on smart object.

it sure does. thnx :)

Oct 11 2016, 7:14 AM · Restricted Project, efl

Sep 28 2016

buniofh updated the task description for T4675: eo js leak.
Sep 28 2016, 8:19 AM · efl: language bindings
buniofh added a comment to T4675: eo js leak.

also you might consider removing efl::eina::js::make_leak() form efl::eo::js::construct_from_eo(). this call is redundant because all returned values eitherway go through efl::eina::js::get_value_from_c() and proper clean ups are set there. this is required after all for eo based events

Sep 28 2016, 8:18 AM · efl: language bindings
buniofh created T4675: eo js leak.
Sep 28 2016, 8:13 AM · efl: language bindings

Sep 8 2016

buniofh added a comment to T4422: eina list javascript leak.

this one covers different make_persistent for globals. however... nice solution would involve a double reffed class which is weak only when not reffed from C++. this way globals would be always kept as persistents with ref>=1 and all others would simply have 0. similar solution is used in aforementioned node wrapper class.

Sep 8 2016, 7:54 AM · efl: language bindings
buniofh added a comment to T4422: eina list javascript leak.

seems I fixed it, for your review

Sep 8 2016, 12:58 AM · efl: language bindings

Aug 31 2016

buniofh added a comment to T4354: NodeJS/EFL: Created objects get garbage collected while they are still in use from JS side.

following change fixes that problem:

Aug 31 2016, 8:19 AM · Restricted Project, efl
buniofh added a comment to T4422: eina list javascript leak.

nodejs object wrap includes v8::Persistent::MakeIndependent() call to alongside SetWeak(). node::ObjectWrap::MakeWeak(). seems like after that callbacks are being called as expected.

Aug 31 2016, 3:39 AM · efl: language bindings

Aug 29 2016

buniofh updated subscribers of T4422: eina list javascript leak.
Aug 29 2016, 12:06 AM · efl: language bindings

Aug 26 2016

buniofh added a comment to T4422: eina list javascript leak.

and I need to correct myself, did some more tests on the matter and it seems ptr's for the Persistents are the same which lead me to believe they are overrun but apparently Persistent is destroyed and callback for it simply not called.

Aug 26 2016, 6:44 AM · efl: language bindings
buniofh added a comment to T4422: eina list javascript leak.

hola @lauromoura , I did some debugging and think the problem is more general and comes down to v8 having a single entry for v8::Persistent::SetWeak() notification callback. called for the same v8 object that would cause a leak at efl::js level.

Aug 26 2016, 5:14 AM · efl: language bindings

Aug 23 2016

buniofh assigned T4422: eina list javascript leak to vitor.sousa.
Aug 23 2016, 5:21 AM · efl: language bindings
buniofh updated the task description for T4422: eina list javascript leak.
Aug 23 2016, 5:20 AM · efl: language bindings
buniofh created T4422: eina list javascript leak.
Aug 23 2016, 5:18 AM · efl: language bindings

Aug 17 2016

buniofh added a comment to T4226: clipper is not being set on smart object.

delete_me test seems to be missing and debugs are left on

Aug 17 2016, 3:33 AM · Restricted Project, efl

Jul 29 2016

buniofh updated the task description for T4245: textblock crashes on undefined style.
Jul 29 2016, 6:49 AM · efl
buniofh created T4245: textblock crashes on undefined style.
Jul 29 2016, 6:36 AM · efl

Jul 28 2016

buniofh assigned T4226: clipper is not being set on smart object to zmike.
Jul 28 2016, 4:40 AM · Restricted Project, efl
buniofh added a comment to T4226: clipper is not being set on smart object.

following patch

seems to fix the problem.

Jul 28 2016, 4:39 AM · Restricted Project, efl

Jul 26 2016

buniofh updated the task description for T4226: clipper is not being set on smart object.
Jul 26 2016, 12:34 PM · Restricted Project, efl
buniofh created T4226: clipper is not being set on smart object.
Jul 26 2016, 12:28 PM · Restricted Project, efl