Page MenuHomePhabricator

cedric (Cedric BAIL)Administrator
Senior Black Sorcerer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 3:13 AM (364 w, 6 d)
Roles
Administrator
Availability
Available

I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !

Recent Activity

Today

cedric requested changes to D11160: efl_ui: rename Layout_Factory to Generic_Factory..

I am not convinced by this change as we loose the ability to set the theme during widget creation.

Thu, Jan 23, 8:25 AM · efl

Mon, Jan 20

cedric added inline comments to D11133: eina: add new range Data type.
Mon, Jan 20, 3:13 PM · efl
cedric requested changes to D11133: eina: add new range Data type.
Mon, Jan 20, 1:17 PM · efl
cedric added a comment to D11133: eina: add new range Data type.

In the h files and the c files become the x file basically.

Mon, Jan 20, 10:22 AM · efl
cedric added a comment to D11133: eina: add new range Data type.

The compiler can only inline function in files it sees directly when compiling a unit. That is why wine has so many eina_inline*.x files.

Mon, Jan 20, 9:58 AM · efl
cedric accepted D11133: eina: add new range Data type.

Maybe we might want all this function to be inline, other than that it looks good to me.

Mon, Jan 20, 8:14 AM · efl

Sun, Jan 19

cedric added a comment to T8570: Eina_Range.

I am not convinced of the need for double, otherwise yes.

Sun, Jan 19, 9:48 PM · efl: language bindings, efl: api
cedric added a comment to D11128: efl.text.interactive: use Eina_Int_Range for selection range event.

Please split the patch. One that had eina range and one that use it. Also I am not sure of the type. Unsigned int would seems better for our use case. Also there is no point into adding the type in the name of the data structure.

Sun, Jan 19, 9:46 PM · efl

Fri, Jan 17

cedric added inline comments to D11062: eina: introduce eina_iterator_process.
Fri, Jan 17, 11:06 AM · efl
cedric requested changes to D11119: edje: add getenv for turning on edje nosave.
Fri, Jan 17, 10:54 AM · efl
cedric accepted D11127: efl.ui.textbox: using efl_provider_find.
Fri, Jan 17, 10:52 AM · efl
cedric added a comment to T8570: Eina_Range.

I am unlikely to have the time to take care of that, but I should be able to review the patch in the next 2 weeks.

Fri, Jan 17, 10:45 AM · efl: language bindings, efl: api
cedric added a comment to T8570: Eina_Range.

Hum, it seems we are getting to a logical point where indeed range is a useful structure to add to Eina.

Fri, Jan 17, 10:44 AM · efl: language bindings, efl: api

Thu, Jan 16

cedric added inline comments to D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Thu, Jan 16, 8:06 AM · efl

Wed, Jan 15

cedric added a comment to D11044: ecore_con: remove use of list<> from Efl.Net..

Note, you can run *all* examples after a refactor with ./examples_checks.py in the root directory.

Wed, Jan 15, 11:13 AM · efl
cedric updated the diff for D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

rebase

Wed, Jan 15, 11:09 AM · efl
cedric updated the diff for D11050: eolian: enforce that list<> can only be used with @beta API..

rebase

Wed, Jan 15, 11:09 AM · efl
cedric updated the diff for D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..

rebase

Wed, Jan 15, 11:09 AM · efl
cedric updated the diff for D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..

rebase

Wed, Jan 15, 11:09 AM · efl
cedric updated the diff for D11047: eolian_cxx: move tests of list<> to be protected by @beta..

rebase

Wed, Jan 15, 11:09 AM · efl
cedric updated the diff for D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta..

rebase

Wed, Jan 15, 11:04 AM · efl
cedric updated the diff for D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..

rebase

Wed, Jan 15, 11:03 AM · efl
cedric updated the diff for D11044: ecore_con: remove use of list<> from Efl.Net..

rebase and address comments.

Wed, Jan 15, 11:03 AM · efl
cedric planned changes to D11044: ecore_con: remove use of list<> from Efl.Net..

I might be a bit stuborn on this. But isn't array just the same problem as list ? Why not just entering a iterator ?

Wed, Jan 15, 9:57 AM · efl
cedric added a comment to D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

Mhm the only user of that was clouseau ... But that one does not even compile after renames and eolian changes, what should we do ?

Wed, Jan 15, 9:55 AM · efl

Mon, Jan 13

cedric added a comment to D10935: efl_model : Stablized child,added child,removed events..

I will work on this this week then.

Mon, Jan 13, 7:20 AM · efl

Fri, Jan 10

cedric added inline comments to D11062: eina: introduce eina_iterator_process.
Fri, Jan 10, 9:59 AM · efl
cedric requested changes to D11062: eina: introduce eina_iterator_process.
Fri, Jan 10, 9:58 AM · efl
cedric added a comment to D11062: eina: introduce eina_iterator_process.

Can you update the commit message also to remove the last ) that goes automatically in the url?

Fri, Jan 10, 9:58 AM · efl

Thu, Jan 9

cedric requested changes to D11018: eina: introduce Eina_Abstract_Content.

Some more review.

Thu, Jan 9, 1:59 PM · DO NOT MERGE, efl
cedric added a reviewer for D11052: efl/gesture: correctly handle pointer going off canvas during gestures: woohyun.

I am not sure we want this behavior, maybe @woohyun or someone else in Korea would have an opinion on this.

Thu, Jan 9, 11:17 AM · efl
cedric accepted D11054: tests/elm: add util function for dragging the pointer in an arc.
Thu, Jan 9, 11:14 AM · efl
cedric added a comment to D10988: Revert "efl_message: add pending queue for filtering message.".

Ping?

Thu, Jan 9, 11:12 AM · efl
cedric updated the diff for D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

rebase

Thu, Jan 9, 11:05 AM · efl
cedric updated the diff for D11050: eolian: enforce that list<> can only be used with @beta API..

rebase and add a placeholder.

Thu, Jan 9, 11:05 AM · efl
cedric updated the diff for D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..

rebase

Thu, Jan 9, 11:04 AM · efl
cedric updated the diff for D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..

rebase

Thu, Jan 9, 11:04 AM · efl
cedric updated the diff for D11047: eolian_cxx: move tests of list<> to be protected by @beta..

rebase

Thu, Jan 9, 11:04 AM · efl
cedric updated the diff for D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta..

rebase

Thu, Jan 9, 11:04 AM · efl
cedric updated the diff for D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..

rebase and add focus to commit message.

Thu, Jan 9, 11:04 AM · efl
cedric updated the diff for D11044: ecore_con: remove use of list<> from Efl.Net..

rebase and free info.

Thu, Jan 9, 11:03 AM · efl
cedric closed D11015: elementary: enable collection view test to wait for "child.selected" event..
Thu, Jan 9, 10:28 AM · efl
cedric closed D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:28 AM · efl
cedric closed D11014: elementary: add proper test for "child.selected" propagation..
Thu, Jan 9, 10:28 AM · efl
cedric closed D11013: elementary: properly propagate "child.selected" change..
Thu, Jan 9, 10:28 AM · efl
cedric accepted D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:10 AM · efl
cedric updated the diff for D11015: elementary: enable collection view test to wait for "child.selected" event..

retrying

Thu, Jan 9, 10:09 AM · efl
cedric updated the diff for D11012: tests: start some collectionview tests.

retrying

Thu, Jan 9, 10:09 AM · efl
cedric updated the diff for D11014: elementary: add proper test for "child.selected" propagation..

retrying

Thu, Jan 9, 10:09 AM · efl
cedric updated the diff for D11013: elementary: properly propagate "child.selected" change..

retrying

Thu, Jan 9, 10:09 AM · efl
cedric removed a parent revision for D11015: elementary: enable collection view test to wait for "child.selected" event.: D11014: elementary: add proper test for "child.selected" propagation..
Thu, Jan 9, 10:08 AM · efl
cedric removed a child revision for D11014: elementary: add proper test for "child.selected" propagation.: D11015: elementary: enable collection view test to wait for "child.selected" event..
Thu, Jan 9, 10:08 AM · efl
cedric added a parent revision for D11012: tests: start some collectionview tests: D11014: elementary: add proper test for "child.selected" propagation..
Thu, Jan 9, 10:06 AM · efl
cedric added a child revision for D11014: elementary: add proper test for "child.selected" propagation.: D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:06 AM · efl
cedric added a parent revision for D11015: elementary: enable collection view test to wait for "child.selected" event.: D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:06 AM · efl
cedric edited child revisions for D11012: tests: start some collectionview tests, added: 1; removed: 1.
Thu, Jan 9, 10:06 AM · efl
cedric edited child revisions for D11012: tests: start some collectionview tests, added: 1; removed: 1.
Thu, Jan 9, 10:05 AM · efl
cedric removed a parent revision for D11013: elementary: properly propagate "child.selected" change.: D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:05 AM · efl
cedric added a parent revision for D11014: elementary: add proper test for "child.selected" propagation.: D11012: tests: start some collectionview tests.
Thu, Jan 9, 10:05 AM · efl
cedric updated the diff for D11014: elementary: add proper test for "child.selected" propagation..

rebase and reorder maybe

Thu, Jan 9, 10:02 AM · efl
cedric updated the diff for D11013: elementary: properly propagate "child.selected" change..

rebase and reorder maybe.

Thu, Jan 9, 10:01 AM · efl

Wed, Jan 8

cedric closed T8509: Opportunistic event forwarding as Resolved.

This was resolved by 115a9a22b1d25d8d3b2d433994cc6756174b11b9

Wed, Jan 8, 3:56 PM · efl: mvvm
cedric closed T8509: Opportunistic event forwarding, a subtask of T8177: Collection_View Tracking ticket, as Resolved.
Wed, Jan 8, 3:56 PM · efl: mvvm
cedric requested changes to D11018: eina: introduce Eina_Abstract_Content.
Wed, Jan 8, 3:38 PM · DO NOT MERGE, efl
cedric added a comment to D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..

This struct is the only thing in the Efl.Gfx.Event namespace... looks weird.

Wed, Jan 8, 11:10 AM · efl
cedric requested review of D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Wed, Jan 8, 10:43 AM · efl
cedric added a child revision for D11050: eolian: enforce that list<> can only be used with @beta API.: D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Wed, Jan 8, 10:42 AM · efl
cedric requested review of D11050: eolian: enforce that list<> can only be used with @beta API..
Wed, Jan 8, 10:42 AM · efl
cedric added a child revision for D11049: efl: mark @beta Efl.Gfx.Event.Render_Post.: D11050: eolian: enforce that list<> can only be used with @beta API..
Wed, Jan 8, 10:42 AM · efl
cedric requested review of D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..
Wed, Jan 8, 10:42 AM · efl
cedric added a child revision for D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time.: D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..
Wed, Jan 8, 10:42 AM · efl
cedric requested review of D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..
Wed, Jan 8, 10:42 AM · efl
cedric added a child revision for D11047: eolian_cxx: move tests of list<> to be protected by @beta.: D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..
Wed, Jan 8, 10:42 AM · efl
cedric requested review of D11047: eolian_cxx: move tests of list<> to be protected by @beta..
Wed, Jan 8, 10:41 AM · efl
cedric added a child revision for D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta.: D11047: eolian_cxx: move tests of list<> to be protected by @beta..
Wed, Jan 8, 10:41 AM · efl
cedric requested review of D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta..
Wed, Jan 8, 10:41 AM · efl
cedric added a child revision for D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>.: D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta..
Wed, Jan 8, 10:41 AM · efl
cedric requested review of D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..
Wed, Jan 8, 10:41 AM · efl
cedric added a child revision for D11044: ecore_con: remove use of list<> from Efl.Net.: D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..
Wed, Jan 8, 10:41 AM · efl
cedric requested review of D11044: ecore_con: remove use of list<> from Efl.Net..
Wed, Jan 8, 10:41 AM · efl
cedric updated the diff for D11015: elementary: enable collection view test to wait for "child.selected" event..

rebase and address comment.

Wed, Jan 8, 10:18 AM · efl
cedric updated the diff for D11014: elementary: add proper test for "child.selected" propagation..

rebase

Wed, Jan 8, 10:18 AM · efl
cedric updated the diff for D11013: elementary: properly propagate "child.selected" change..

rebase

Wed, Jan 8, 10:18 AM · efl
cedric updated the diff for D11012: tests: start some collectionview tests.

rebase

Wed, Jan 8, 10:17 AM · efl

Tue, Jan 7

cedric added a comment to T7858: efl.text_markup.

I am also happy with the plan to add a markup_generator later on to support multiple markup language.

Tue, Jan 7, 9:53 AM · efl: api, efl: language bindings

Mon, Jan 6

cedric added a comment to T7858: efl.text_markup.

@cedric
I am not catching exactly your comments, Are you referring to internal implementation or API exposed to users ?

API exposed to users

Can you please show me what you expect to expose to the user?

Mon, Jan 6, 10:22 AM · efl: api, efl: language bindings

Sun, Jan 5

cedric added a comment to T8550: RFC: Copy and Paste in EFL.

As you noted there is a two level type. One is indicating that it is an Eina_Value_Type_Content to Eina_Value and the other one says what is inside the Eina_Slice. This means you have two level of operation and is the current justification for the existence of Eina_Content, but there is nothing that prevent having:

Sun, Jan 5, 1:19 PM · efl: api
cedric added a comment to T8550: RFC: Copy and Paste in EFL.

I saw your patch, but I am worried that overtime we are going to add more and more stuff in Eina_Content and it is going to spread and duplicate a lot of the logic that is in Eina_Value and you will have to write the Eina_Value part anyway so that it can be propagated with Eina_Future... The sanity checks can still be there when you instantiate an Eina_Value_Type_Content and any conversion to it, will be sane as it will be done internally by Eina_Value.

Sun, Jan 5, 12:51 PM · efl: api
cedric added a comment to T7858: efl.text_markup.

@cedric
I am not catching exactly your comments, Are you referring to internal implementation or API exposed to users ?

Sun, Jan 5, 11:27 AM · efl: api, efl: language bindings
cedric added a comment to T8550: RFC: Copy and Paste in EFL.

I am not sure we really need Eina_Content. An addition to Eina_Value to support a tupple {Eina_Slice, IANA types} seems like it would work. Default conversion would be toward UTF-8 for text and there could be an additional API on Eina_Value_Type_Content that would allow the conversion of an Eina_Value to a new Eina_Value_Type_Content of a specific IANA type. With this I would think you have all you need and will have a lot of conversion operation available right away (Plus all existing infrastructure around Eina_Value).

Sun, Jan 5, 11:18 AM · efl: api

Fri, Jan 3

cedric added a comment to T7858: efl.text_markup.

@cedric
Thanks for sharing your idea.
Is it something different from "efl_text_markup_util" class ?

Fri, Jan 3, 5:59 PM · efl: api, efl: language bindings
cedric requested review of D11015: elementary: enable collection view test to wait for "child.selected" event..
Fri, Jan 3, 3:37 PM · efl
cedric added a child revision for D11014: elementary: add proper test for "child.selected" propagation.: D11015: elementary: enable collection view test to wait for "child.selected" event..
Fri, Jan 3, 3:37 PM · efl
cedric requested review of D11014: elementary: add proper test for "child.selected" propagation..
Fri, Jan 3, 3:37 PM · efl
cedric added a child revision for D11013: elementary: properly propagate "child.selected" change.: D11014: elementary: add proper test for "child.selected" propagation..
Fri, Jan 3, 3:37 PM · efl
cedric requested review of D11013: elementary: properly propagate "child.selected" change..
Fri, Jan 3, 3:37 PM · efl
cedric added a child revision for D11012: tests: start some collectionview tests: D11013: elementary: properly propagate "child.selected" change..
Fri, Jan 3, 3:37 PM · efl
cedric updated the diff for D11012: tests: start some collectionview tests.
Fri, Jan 3, 3:37 PM · efl
cedric added a comment to T7858: efl.text_markup.

I am not a fan of the current Efl.Text_Markup logic as it is pretty much impossible for the application to leverage it for a custom type. I would really prefer a logic where we can set a class/object that is in charge of interpreting the markup language string and convert it back and forth to native text API when a user call markup set on an object. This way all the markup language of the world can be easily supported and efl doesn't need to do it itself. Currently, it is not the direction we are taking. The reason why having a converter class/object is nicer than to require the creation of complete new class for an application, is that it divide intent clearly and reduce application work needed in just providing that conversion logic.

Fri, Jan 3, 10:09 AM · efl: api, efl: language bindings

Thu, Jan 2

cedric closed T8481: Edje: Text_class Old API Object level override as Resolved.
Thu, Jan 2, 11:02 AM