Page MenuHomePhabricator

cedric (Cedric BAIL)Administrator
Senior Black Sorcerer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 3:13 AM (393 w, 5 d)
Roles
Administrator
Availability
Available

I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !

Recent Activity

Wed, Aug 5

cedric accepted D12097: eo: event callback call optimization.
Wed, Aug 5, 10:11 AM · efl
cedric added inline comments to D12097: eo: event callback call optimization.
Wed, Aug 5, 9:27 AM · efl

Fri, Jul 31

cedric accepted D12079: eo: evalulate special counts earlier.
Fri, Jul 31, 10:32 AM · efl
cedric added a comment to D12078: eo: make callback_add faster.

Your benchmark seems to indicate that the new version result in more work and just the CPU clock got run at higher frequency which made it faster. Could you do your benchmark by running your CPU at full fixed speed just to be sure?

Fri, Jul 31, 10:30 AM · efl

Jul 2 2020

cedric accepted D12041: Protect EINA_(UN)LIKELY with parenthesis around the expr.
Jul 2 2020, 3:04 PM · efl

Jun 29 2020

cedric added inline comments to D12037: Implement eina_thread for native windows.
Jun 29 2020, 10:24 AM · efl
cedric added inline comments to D12037: Implement eina_thread for native windows.
Jun 29 2020, 9:25 AM · efl

Jun 17 2020

cedric accepted D11992: eina_strbuf: if readonly strbuf is malloc, then it will stop being readonly.

As said in a previous PR, would be nice to refactor this.

Jun 17 2020, 10:17 AM · efl
cedric accepted D11991: eina_strbuf_manage_new: update documentation.
Jun 17 2020, 10:16 AM · efl
cedric accepted D11990: eina_strbuf: introduce change last occurrence function.
Jun 17 2020, 10:14 AM · efl
cedric accepted D11989: eina_strbuf: resolve segfault when replace used with read_only buffer.
Jun 17 2020, 10:11 AM · efl

Jun 8 2020

cedric requested changes to D11949: efl_ui_textpath: mathmatical calculations.
Jun 8 2020, 10:11 AM · efl

May 26 2020

cedric accepted D11884: Eina file test: on Windows, open cmd, not a shell.
May 26 2020, 3:35 PM · efl
cedric accepted D11885: Eina file test: use the correct Eina file object.
May 26 2020, 3:35 PM · efl

May 15 2020

cedric added a comment to T8722: Terminology crash on keyboard shortcut switch between console.

Indeed, I always hide my tab.

May 15 2020, 2:12 PM
cedric created T8722: Terminology crash on keyboard shortcut switch between console.
May 15 2020, 1:41 PM

Jan 31 2020

cedric triaged T8597: Making C# Efl.GenericModel<T> more future proof as Normal priority.
Jan 31 2020, 10:56 AM
cedric added a comment to D11171: edje: Add null check.

Try under valgrind with --trace-children=yes and EFL_RUN_IN_TREE=1.

Jan 31 2020, 10:25 AM · efl
cedric added a reviewer for D11215: edje_entry: Fix to have event over item object.: zmike.
Jan 31 2020, 10:24 AM · efl
cedric closed D11186: efl: add test for efl_model_children_index_get..
Jan 31 2020, 10:12 AM · efl
cedric closed D11185: efl: add Efl.Model.Children_Index_Get..
Jan 31 2020, 10:12 AM · efl
cedric closed D11184: ecore: refactor unpacking/packing code used in conjonction with eina_future_all*..
Jan 31 2020, 10:12 AM · efl
cedric closed D11253: eina: do not warn when calling eina_inarray_pop on empty inarray to match eina_array_pop..
Jan 31 2020, 10:12 AM · efl
cedric closed D11181: eina: add test for eina_future_all_iterator..
Jan 31 2020, 10:12 AM · efl
cedric closed D11180: eina: add eina_future_all_iterator and eina_promise_all_iterator..
Jan 31 2020, 10:12 AM · efl
cedric accepted D11018: eina: introduce Eina_Abstract_Content.

Except for the minor cosmetic of the .h file name not matching the function name, I am good with this. You might want to add a _unregister function as some of the register could be done in a module and disappear at any point.

Jan 31 2020, 10:05 AM · DO NOT MERGE, efl
cedric accepted D11062: eina: introduce eina_iterator_process.
Jan 31 2020, 9:59 AM · efl
cedric added a comment to D11119: edje: add getenv for turning on edje nosave.

@cedric "turnoff the ability to update theme files" What do you mean by it?

Jan 31 2020, 9:29 AM · efl

Jan 30 2020

cedric requested changes to D11227: efl_ui : re-introduce layout_factory.

This is kind of a weird series of patch, removing LayoutFactory and then readding it. I guess it allow for less code to write. Anyway, seeing the code like this now, it looks like we can do slightly better.

Jan 30 2020, 8:59 PM · efl
cedric abandoned D11183: eina: add test for eina_inarray_direct_accessor_new..
Jan 30 2020, 4:30 PM · efl
cedric abandoned D11182: eina: add eina_inarray_direct_accessor_new to directly access inarray member data without pointer indirection..
Jan 30 2020, 4:29 PM · efl
cedric updated the diff for D10935: efl_model: stablized child,added child,removed events..

rebase

Jan 30 2020, 3:37 PM · efl
cedric updated the diff for D11187: efl: move Efl.Model.children,removed/children,added to use an accessor..

rebase and expose a pointer from the accessor.

Jan 30 2020, 3:37 PM · efl
cedric updated the diff for D11186: efl: add test for efl_model_children_index_get..

rebase

Jan 30 2020, 3:36 PM · efl
cedric updated the diff for D11185: efl: add Efl.Model.Children_Index_Get..

rebase

Jan 30 2020, 3:36 PM · efl
cedric updated the diff for D11184: ecore: refactor unpacking/packing code used in conjonction with eina_future_all*..

rebase

Jan 30 2020, 3:36 PM · efl
cedric added a child revision for D11253: eina: do not warn when calling eina_inarray_pop on empty inarray to match eina_array_pop.: D11184: ecore: refactor unpacking/packing code used in conjonction with eina_future_all*..
Jan 30 2020, 3:36 PM · efl
cedric requested review of D11253: eina: do not warn when calling eina_inarray_pop on empty inarray to match eina_array_pop..
Jan 30 2020, 3:36 PM · efl
cedric added a child revision for D11181: eina: add test for eina_future_all_iterator.: D11253: eina: do not warn when calling eina_inarray_pop on empty inarray to match eina_array_pop..
Jan 30 2020, 3:36 PM · efl
cedric updated the diff for D11181: eina: add test for eina_future_all_iterator..

rebase

Jan 30 2020, 3:36 PM · efl
cedric updated the diff for D11180: eina: add eina_future_all_iterator and eina_promise_all_iterator..

rebase

Jan 30 2020, 3:35 PM · efl
cedric added a comment to D11182: eina: add eina_inarray_direct_accessor_new to directly access inarray member data without pointer indirection..

Ok, in that case, then I don't think this is a correct patch set. Is there documentation somewhere for this?

Jan 30 2020, 1:25 PM · efl
cedric added a comment to D11182: eina: add eina_inarray_direct_accessor_new to directly access inarray member data without pointer indirection..

This is I think the other way around or I miss understood eo. What do we expect from accessor<structure>?

Jan 30 2020, 9:57 AM · efl
cedric accepted D10870: Efl.Ui.Vg_Animation: Remove @beta mark.
Jan 30 2020, 8:59 AM · efl
cedric closed D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..
Jan 30 2020, 8:11 AM · efl
cedric closed D11044: ecore_con: remove use of list<> from Efl.Net..
Jan 30 2020, 8:10 AM · efl

Jan 29 2020

cedric accepted D11163: evas/events: fix multi-touch object targeting on touch down events.
Jan 29 2020, 2:36 PM · efl
cedric updated the diff for D10935: efl_model: stablized child,added child,removed events..

rebase

Jan 29 2020, 10:34 AM · efl
cedric updated the diff for D11187: efl: move Efl.Model.children,removed/children,added to use an accessor..

rebase

Jan 29 2020, 10:34 AM · efl
cedric updated the diff for D11186: efl: add test for efl_model_children_index_get..

rebase

Jan 29 2020, 10:34 AM · efl
cedric updated the diff for D11185: efl: add Efl.Model.Children_Index_Get..

rebase and address comment

Jan 29 2020, 10:34 AM · efl
cedric updated the diff for D11184: ecore: refactor unpacking/packing code used in conjonction with eina_future_all*..

rebase

Jan 29 2020, 10:33 AM · efl
cedric updated the diff for D11183: eina: add test for eina_inarray_direct_accessor_new..

rebase and address comment

Jan 29 2020, 10:33 AM · efl
cedric updated the diff for D11182: eina: add eina_inarray_direct_accessor_new to directly access inarray member data without pointer indirection..

rebase and address comment

Jan 29 2020, 10:33 AM · efl
cedric updated the diff for D11181: eina: add test for eina_future_all_iterator..

rebase and address comment

Jan 29 2020, 10:32 AM · efl
cedric updated the diff for D11180: eina: add eina_future_all_iterator and eina_promise_all_iterator..

rebase and address comment

Jan 29 2020, 10:32 AM · efl
cedric closed T8592: Terminilogy is forcing display of tab as Resolved.

Yes, it is resolved. Twitter bug report is the future :-)

Jan 29 2020, 10:11 AM
cedric closed D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..
Jan 29 2020, 12:53 AM · efl
cedric closed D11050: eolian: enforce that list<> can only be used with @beta API..
Jan 29 2020, 12:52 AM · efl
cedric closed D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..
Jan 29 2020, 12:52 AM · efl
cedric closed D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..
Jan 29 2020, 12:52 AM · efl

Jan 28 2020

cedric created T8592: Terminilogy is forcing display of tab.
Jan 28 2020, 11:09 PM
cedric added a comment to D11160: efl_ui: rename Layout_Factory to Generic_Factory..

As long as you do not replace layout factory, but add a new generic factory which layout inherit from, yes.

Jan 28 2020, 10:11 AM · efl

Jan 24 2020

cedric added a comment to T7377: [MVVM] Model Insertion Features.

So during the initial stage of Efl.Io.Model, it does start by listing all the files in a directory. This could then be batch notified to a composite Efl.SortedModel that would then sort them out and insert them relatively to each other and to the content of the SortedModel.

Jan 24 2020, 4:55 PM · efl (efl-1.24), efl: mvvm
cedric placed T8511: Reintroduce viewport support on Efl.Ui.CollectionView up for grabs.
Jan 24 2020, 4:40 PM · efl: mvvm
cedric placed T8510: Introducing yield in Efl.Ui.CollectionView use of Efl.Model up for grabs.
Jan 24 2020, 4:39 PM · efl: mvvm
cedric placed T8508: Add automated infrastructure for testing model up for grabs.
Jan 24 2020, 4:39 PM · efl: mvvm
cedric added a subtask for T8354: Introduce view port support: T7531: Improve scrolling performance.
Jan 24 2020, 4:37 PM · efl: mvvm
cedric added a parent task for T7531: Improve scrolling performance: T8354: Introduce view port support.
Jan 24 2020, 4:37 PM
cedric placed T8512: Use map/proxy for speeding up of Efl.Ui.CollectionView up for grabs.
Jan 24 2020, 4:34 PM · efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

Basically that would be a batch insert at one position. This is doable, but I doubt it would be very useful.

Jan 24 2020, 4:26 PM · efl (efl-1.24), efl: mvvm
cedric placed T8353: Reintroduce grouped items storage up for grabs.
Jan 24 2020, 4:24 PM · efl: mvvm
cedric placed T8352: Speed improvement up for grabs.
Jan 24 2020, 4:24 PM · efl: mvvm
cedric added a comment to T8349: Add an Efl.Ui.Sorted_Model.

I think that this model can have two strategy for the sorting. On the first notification of a child being added or if the count > 0 when the compositing is done, the model batch fetch all the child of the composited model and sort them using a merge sort. The idea would be to keep just an index mapping of which child of the sorted model map to which child in the composited model.

Jan 24 2020, 4:24 PM · efl: mvvm
cedric placed T8349: Add an Efl.Ui.Sorted_Model up for grabs.
Jan 24 2020, 4:17 PM · efl: mvvm
cedric placed T8350: Expose size calc mode up for grabs.
Jan 24 2020, 4:15 PM · efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

I am also not saying this is mandatory, but would be good to take this into account.

Jan 24 2020, 4:15 PM · efl (efl-1.24), efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

It really depends :-) For the moment, we do not have much example of Model. Efl.Io shows that in the same code, their is place for batch insertion and solo insertion. Not sure how our code base is going to look once we have some network Model and so on.

Jan 24 2020, 4:14 PM · efl (efl-1.24), efl: mvvm
cedric added a subtask for T7377: [MVVM] Model Insertion Features: T8348: Add support for batching children creation in Efl.Model.
Jan 24 2020, 4:12 PM · efl (efl-1.24), efl: mvvm
cedric added a parent task for T8348: Add support for batching children creation in Efl.Model: T7377: [MVVM] Model Insertion Features.
Jan 24 2020, 4:12 PM · efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

Not necessarily, it depends on the internal of the code that is doing the insertion. Very often we do have Model temporary in memory that would be near where we insert. This is especially true if we are doing sorted insertion, as this require to compare models all the way to the point where we want to insert them.

Jan 24 2020, 4:12 PM · efl (efl-1.24), efl: mvvm
cedric placed T8348: Add support for batching children creation in Efl.Model up for grabs.
Jan 24 2020, 4:10 PM · efl: mvvm
cedric placed T8347: Add Efl.Ui.Group_Model. up for grabs.
Jan 24 2020, 4:10 PM · efl: mvvm
cedric placed T8346: Add support for Group up for grabs.
Jan 24 2020, 4:10 PM · efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

Ideally we would want the ability to insert multiple items, but that seems only possible if Model are provided and not index (As index change every time an object is inserted).

Jan 24 2020, 4:09 PM · efl (efl-1.24), efl: mvvm
cedric added a comment to T7377: [MVVM] Model Insertion Features.

This will be necessary to provide an Efl.SortedModel.

Jan 24 2020, 4:08 PM · efl (efl-1.24), efl: mvvm
cedric edited parent tasks for T7377: [MVVM] Model Insertion Features, added: T8349: Add an Efl.Ui.Sorted_Model; removed: T5354: Provide infrastructure for MVVM.
Jan 24 2020, 4:08 PM · efl (efl-1.24), efl: mvvm
cedric removed a subtask for T5354: Provide infrastructure for MVVM: T7377: [MVVM] Model Insertion Features.
Jan 24 2020, 4:08 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric added a subtask for T8349: Add an Efl.Ui.Sorted_Model: T7377: [MVVM] Model Insertion Features.
Jan 24 2020, 4:08 PM · efl: mvvm
cedric moved T7833: Add composite factory from Cedric to Backlog on the efl: mvvm board.
Jan 24 2020, 4:06 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric moved T7605: Model-ViewModel Test Case Implementation from Cedric to Backlog on the efl: mvvm board.
Jan 24 2020, 4:05 PM · efl (efl-1.24), efl: mvvm
cedric moved T7377: [MVVM] Model Insertion Features from Felipe to Backlog on the efl: mvvm board.
Jan 24 2020, 4:05 PM · efl (efl-1.24), efl: mvvm
cedric closed T7379: [MVVM] Support disabled composite model as Resolved.

So Efl.BooleanModel does actually provide the ability to efficiently store this information and I consider this done.

Jan 24 2020, 4:04 PM · efl: mvvm
cedric closed T7379: [MVVM] Support disabled composite model, a subtask of T5354: Provide infrastructure for MVVM, as Resolved.
Jan 24 2020, 4:04 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric placed T7531: Improve scrolling performance up for grabs.

This is going to get pushed to forever, but the idea today would be to restore support for viewport inside Efl.Ui.CollectionView, then use a map or a proxy per viewport and move them around. Next step would be try to use HW acceleration as described using hardware plane and wayland ability to use subsurface.

Jan 24 2020, 4:01 PM
cedric closed T8146: Enforce canvas hierarchy on Efl.Ui.Factory as Resolved.

This is actually done with an efl_provider_find done during the finalize of Efl.Ui.WidgetFactory.

Jan 24 2020, 3:51 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric closed T8146: Enforce canvas hierarchy on Efl.Ui.Factory, a subtask of T5354: Provide infrastructure for MVVM, as Resolved.
Jan 24 2020, 3:51 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric closed T7831: Improve image support in MVVM as Resolved.

I think the state of this is good enough and could be improved forever. So let settle with what we have and if anyone get time to improve in the future, we can reopen this task.

Jan 24 2020, 3:29 PM · efl (efl-1.24), efl: mvvm, efl: data types
cedric closed T7831: Improve image support in MVVM, a subtask of T5333: Cleanup View interface aka finish MVVM, as Resolved.
Jan 24 2020, 3:29 PM · efl (efl-1.23), efl: mvvm, efl: data types
cedric accepted D11172: edje_entry: Add matching tag..
Jan 24 2020, 3:19 PM · efl