I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !
- User Since
- Jan 25 2013, 3:13 AM (290 w, 4 d)
May 28 2018
So I put this in place as it was not possible to know if the parent was invalidating or not as efl_parent_get will return a valid parent chain during invalidation when is_invalidating is true. Basically you could know with efl_parent_get != NULL and efl_invalidated_get == true that the parent was currently invalidating itself. With this patch, we don't know anymore. Checking my usual pattern with E, Terminology and Elementary_Test doesn't yield any issue, so it might be ok actually. So I will land this serie, but if this trigger other issue, we might want to revert to the current behavior and change the caller to check this information correctly.
I agree with @Hermet ! Good to see you back !
May 25 2018
Should be fixed by 2a5dc744083e2b227bbdfdcaf2c834298d72fa5f
No, I have tryed to figure out how that could be happening, but couldn't. Basically they are zombie object still present in the canvas when it is getting destroyed. It is a weird kind of zombie. Some where surviving as they were overriding efl_parent_set, but this is not the case for those. I haven't been able to understand what is happening. The good side is that it doesn't trigger a crash nor a use after free, the bad side is that it give little information of what is going on.
I haven't landed this one as this is still pending investigation with T6879, but I am giving up the only laptop where I see this crash today and don't have much time digging in. So there will be a call to be made if nobody understand why there is a crash to revert this patch or keep it @stefan_schmidt .
Hum, this might be related to the use of a static variable with no fork and parallel use, it might get to zero while it shouldn't. Maybe making that a general variable and doing a reset to 5 every time we do a test would solve this issue.
I also actually agree with you that it would be best to not call pack_at in the legacy case.
Yes, as everything is asynchronous and under load, you are more likely to not have started listing a directory than no. Anyway, this landed in a slightly different form and I will abandon this.
And with a test case, great ! \o/
Seems we are good with this.
This is an important patch to land before the release, please answer @Jaehyun_Cho
It would be I think better if you refactor the snprintf inside fake_server_start and just pass FILE as a parameter to fake_server_start.
Oh, good catch.
Yeah, until we have a local http server, this is likely the best solution.
Oh, this is the same problem I reported with enlightenment connection manager with T6593.
Sounds like it to me. @bu5hm4n what do you think of this one ?
I have fixed the first item as far as I know. For the rest, I really can't reproduce, but I agree with the idea of being able to set the poll interval.