Page MenuHomePhabricator

cedric (Cedric BAIL)Administrator
Senior Black Sorcerer

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 3:13 AM (303 w, 1 d)
Roles
Administrator
Availability
Available

I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !

Recent Activity

Yesterday

cedric added a comment to T7358: EO: Support ecore_event APIs.

@Jaehyun_Cho I think this event should either be on the window or on the application object. I don't think we want any of it to go through Ecore_Event.

Fri, Nov 16, 2:35 PM · efl, Restricted Project
cedric added a comment to T5365: Use efl.part for efl.ui.model.connect.

If we want that, should I take care of it ?

Fri, Nov 16, 11:51 AM · efl: widgets, Restricted Project
cedric triaged T7473: Add a create event on Efl.Ui.Factory as High priority.
Fri, Nov 16, 11:41 AM · Restricted Project, efl: data types, Restricted Project
cedric triaged T7472: Asynchronous create function in Efl.Ui.Factory as High priority.
Fri, Nov 16, 11:39 AM · efl: data types, Restricted Project
cedric triaged T7471: Add an efl.model.property_ready_get and efl.model.properties_ready_get. as TODO priority.
Fri, Nov 16, 11:36 AM · Restricted Project, efl: data types, Restricted Project
cedric added a subtask for T5333: Cleanup View interface aka finish MVVM: T7470: [MVVM] Create a ViewModel helper class.
Fri, Nov 16, 11:33 AM · efl: data types, Restricted Project
cedric added a parent task for T7470: [MVVM] Create a ViewModel helper class: T5333: Cleanup View interface aka finish MVVM.
Fri, Nov 16, 11:33 AM
cedric created T7470: [MVVM] Create a ViewModel helper class.
Fri, Nov 16, 11:27 AM
cedric added a comment to T7382: [MVVM] Efl.Ui.View_List Homogenous Support.

What is the status of this task ?

Fri, Nov 16, 11:24 AM
cedric added a comment to T7378: [MVVM] Model Composite Features.

What is efl.range ? I can only find efl.ui.range, and I don't think this is what you are talking about.

Fri, Nov 16, 11:24 AM
cedric added a comment to T7377: [MVVM] Model Insertion Features.

I agree with @SanghyeonLee no silent work around solution for users. This create trouble. What is the status of this task ?

Fri, Nov 16, 11:11 AM
cedric added a comment to T7379: [MVVM] Support disabled composite model.

Is this an enable/disable model ? If so, it can be implemented trivially by inheriting from the Boolean model. The main question being what kind of API do you want on top of it. Do we want a top level function that allow for example to define the state of an item to disable/enable without going through fetching the child object and setting its property ? Any other idea of what such a Model should provide ?

Fri, Nov 16, 11:08 AM
cedric added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

Yes, for non homogeneous case, we should have a callback that only update small portion at a time and doesn't over consume the main loop time. We can push an estimate of the scroll size by using an average of the currently calculated item. That is I think our best strategy there.

Fri, Nov 16, 11:06 AM
cedric added a comment to T7404: [MVVM] Factory text property handles.

There is no future to get property. You need to watch for an event if you want to manually get notified of value being changed, but you can always get a property synchronously by doing a property.get. In general, most user should not have to care about that as they just need to do an .connect and things would be taken care of for them by the widget.

Fri, Nov 16, 11:04 AM
cedric added a comment to T7376: [MVVM] Model Selection Support.

If I remember correctly, I think I was thinking of using a simple composite boolean for the multi selection case. As the Efl.Model_Composite_Selection inherit from it, if there are helper and API user-convenience function you are thinking of, it would indeed make sense to add the non exclusive mode to Composite_Selection and provide the helper there. Do you have a list of helper you are thinking of ?

Fri, Nov 16, 10:59 AM
cedric added a comment to T7405: [MVVM] Multistyle Factory.

Btw in the above example, I would do a ModelConnect on the multi factory for the property "icon" to be connected with the imgFac and due a simple connect("label", "another-property-in-the-model");

Fri, Nov 16, 10:54 AM
cedric added a comment to T7405: [MVVM] Multistyle Factory.

I don't understand in the example why you would have to write any code in a multi style factory at all. The idea would be to connect a property on the factory that would be used to decide which subfactory is called to instantiate that item. For example :

Fri, Nov 16, 10:52 AM
cedric added a comment to T7441: [MVVM] Changes to Efl Data Model.

Also observable are full size Eo object, this will result in a very heavy implementation in term of memory use.

Fri, Nov 16, 10:42 AM
cedric added a subtask for T5333: Cleanup View interface aka finish MVVM: T7469: Find a better name for Efl.Factory.model_connect.
Fri, Nov 16, 10:40 AM · efl: data types, Restricted Project
cedric added a parent task for T7469: Find a better name for Efl.Factory.model_connect: T5333: Cleanup View interface aka finish MVVM.
Fri, Nov 16, 10:40 AM · Restricted Project, efl
cedric triaged T7469: Find a better name for Efl.Factory.model_connect as TODO priority.
Fri, Nov 16, 10:35 AM · Restricted Project, efl
cedric closed D7290: meson: fix VNC server build to not override the last module..
Fri, Nov 16, 10:20 AM · efl
cedric accepted D7280: eet: Stop freeing allocated memory in descriptor_decode.
Fri, Nov 16, 10:12 AM · efl
cedric added inline comments to D7290: meson: fix VNC server build to not override the last module..
Fri, Nov 16, 9:33 AM · efl

Thu, Nov 15

cedric added inline comments to D7273: ector: use efl_replace to make sure that no dangling pointer is left being..
Thu, Nov 15, 9:18 PM · efl
cedric requested review of D7290: meson: fix VNC server build to not override the last module..
Thu, Nov 15, 7:23 PM · efl
cedric requested review of D7289: efl: make Efl.Model.properties_get return an Iterator<string>..
Thu, Nov 15, 7:19 PM · efl
cedric added a child revision for D7287: eina: add tests for eina_multiple_iterator_new.: D7289: efl: make Efl.Model.properties_get return an Iterator<string>..
Thu, Nov 15, 7:19 PM · efl
cedric added a revision to T7464: efl_model_properties_get has usability issue: D7289: efl: make Efl.Model.properties_get return an Iterator<string>..
Thu, Nov 15, 7:19 PM
cedric updated the diff for D7287: eina: add tests for eina_multiple_iterator_new..
Thu, Nov 15, 7:19 PM · efl
cedric updated the diff for D7286: eina: add eina_multi_iterator_new..
Thu, Nov 15, 7:19 PM · efl
cedric updated the diff for D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 15, 7:19 PM · efl
cedric updated the diff for D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..
Thu, Nov 15, 7:19 PM · efl
cedric added a child revision for D7286: eina: add eina_multi_iterator_new.: D7287: eina: add tests for eina_multiple_iterator_new..
Thu, Nov 15, 7:12 PM · efl
cedric requested review of D7287: eina: add tests for eina_multiple_iterator_new..
Thu, Nov 15, 7:08 PM · efl
cedric added a revision to T7464: efl_model_properties_get has usability issue: D7287: eina: add tests for eina_multiple_iterator_new..
Thu, Nov 15, 7:07 PM
cedric updated the diff for D7286: eina: add eina_multi_iterator_new..
Thu, Nov 15, 7:07 PM · efl
cedric updated the diff for D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 15, 7:07 PM · efl
cedric updated the diff for D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..
Thu, Nov 15, 7:06 PM · efl
cedric updated the diff for D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..
Thu, Nov 15, 7:01 PM · efl
cedric requested review of D7286: eina: add eina_multi_iterator_new..
Thu, Nov 15, 6:56 PM · efl
cedric requested review of D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 15, 6:56 PM · efl
cedric added a child revision for D7285: eina: add test for Eina_Iterator over pure C array.: D7286: eina: add eina_multi_iterator_new..
Thu, Nov 15, 6:56 PM · efl
cedric added a child revision for D7284: eina: add a way to iterate over a pure C array with no NUL terminating element.: D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 15, 6:56 PM · efl
cedric added a revision to T7464: efl_model_properties_get has usability issue: D7286: eina: add eina_multi_iterator_new..
Thu, Nov 15, 6:56 PM
cedric added a revision to T7464: efl_model_properties_get has usability issue: D7285: eina: add test for Eina_Iterator over pure C array..
Thu, Nov 15, 6:56 PM
cedric requested review of D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..
Thu, Nov 15, 6:55 PM · efl
cedric added a revision to T7464: efl_model_properties_get has usability issue: D7284: eina: add a way to iterate over a pure C array with no NUL terminating element..
Thu, Nov 15, 6:55 PM
cedric accepted D7282: eet: Remove pointer deduplication.
Thu, Nov 15, 2:34 PM · efl
cedric accepted D7281: eet: Demystify some typecasts.

I have no idea why it was done this way in the first place.

Thu, Nov 15, 2:31 PM · efl
cedric accepted D7280: eet: Stop freeing allocated memory in descriptor_decode.

Uh, this one is tricky. I think it is ok.

Thu, Nov 15, 2:27 PM · efl
cedric accepted D7279: eet: Don't add duplicate hashes to eet freelist.
Thu, Nov 15, 2:23 PM · efl
cedric accepted D7278: eet: Don't add duplicate lists to eet freelist.
Thu, Nov 15, 2:22 PM · efl
cedric accepted D7283: eet: Remove unused code.
Thu, Nov 15, 2:21 PM · efl
cedric added a comment to T5365: Use efl.part for efl.ui.model.connect.

@felipealmeida wouldn't that also solve the connect problem of not knowing what are the available property on an object ?

Thu, Nov 15, 1:51 PM · efl: widgets, Restricted Project
cedric requested review of D7277: ector: reorder destructor code to make sure that freed pointer are not possibly accessed during destruction..
Thu, Nov 15, 1:00 PM · efl
cedric added a child revision for D7276: ector: remove deprecated _efl_refplace and _efl_xrefplace.: D7277: ector: reorder destructor code to make sure that freed pointer are not possibly accessed during destruction..
Thu, Nov 15, 1:00 PM · efl
cedric requested review of D7276: ector: remove deprecated _efl_refplace and _efl_xrefplace..
Thu, Nov 15, 1:00 PM · efl
cedric added a child revision for D7275: ector: replace custom _efl_refplace by generic efl_replace.: D7276: ector: remove deprecated _efl_refplace and _efl_xrefplace..
Thu, Nov 15, 1:00 PM · efl
cedric requested review of D7275: ector: replace custom _efl_refplace by generic efl_replace..
Thu, Nov 15, 1:00 PM · efl
cedric added a child revision for D7274: eo: make efl_replace work with a const pointer like efl_ref/unref do.: D7275: ector: replace custom _efl_refplace by generic efl_replace..
Thu, Nov 15, 1:00 PM · efl
cedric requested review of D7274: eo: make efl_replace work with a const pointer like efl_ref/unref do..
Thu, Nov 15, 1:00 PM · efl
cedric requested review of D7273: ector: use efl_replace to make sure that no dangling pointer is left being..
Thu, Nov 15, 12:53 PM · efl
cedric added a comment to T6840: Generate event wrapper for C.

@bu5hm4n Hum, that would indeed be an idea.

Thu, Nov 15, 12:44 PM · efl: language bindings, Restricted Project, Restricted Project
cedric added a comment to T6840: Generate event wrapper for C.

The arguments is that we have multiple example of bugs created in our code base due to the lack of type checking on the data type which will lead to crash in bindings. As relying on the user to always be right on calling event emit with the right data, seems badly placed faith, it seems we need a fix. As we need a different type checking for each event, it will result in a number of C function being added. I think this is fine. If you have other idea or proposal to avoid having the wrong data being send down the event emit path to end up crashing bindings, I am open to alternate solution also.

Thu, Nov 15, 12:11 PM · efl: language bindings, Restricted Project, Restricted Project
cedric triaged T7466: Evas test is broken with hyphen enabled as Normal priority.
Thu, Nov 15, 10:28 AM · efl: canvas, efl (efl-1.21)
cedric added a comment to T6840: Generate event wrapper for C.

What is the state of this task @q66 ? I think I still see some potential bugs here that this would address.

Thu, Nov 15, 10:21 AM · efl: language bindings, Restricted Project, Restricted Project
cedric added a comment to T7358: EO: Support ecore_event APIs.

Ah, yes, this event are special and you need an early way to register on the main loop.

Thu, Nov 15, 9:21 AM · efl, Restricted Project

Wed, Nov 14

cedric closed T7354: Evas-preload segfaults as Resolved.

This was fixed in master with 0c1eab0cf999db94164b70a80cc3941561a26844 . I will backport that to efl-1.20 branch. The commit log doesn't seems to know why this is happening, which means there might still be a deeper problem. @stefan_schmidt you might want to keep an eye opened for this problem.

Wed, Nov 14, 4:45 PM · enlightenment-git, efl (efl-1.21)
cedric added a comment to T7441: [MVVM] Changes to Efl Data Model.

This seems to be a work around MVVM pattern. The idea of MVVM is that all the decision logic is put into a ViewModel that act as a proxy for the View. This ViewModel would be were you make the choice for the style for example. If you move the decision making out of the MVVM pattern, you are breaking the automatic chain that was there and you can't build automatic test that do not rely on UI for example as the proper information is not exposed inside a VM property.

Wed, Nov 14, 4:34 PM
cedric added a comment to D6870: evas cache image: compare with cached image file.

Is this still a problem ? Is there a reason this has not landed ?

Wed, Nov 14, 4:28 PM · efl
cedric added a comment to D6971: evas json: new feature for lottie - (1/8).

This sounds interesting, where can I find the lottie-player library ?

Wed, Nov 14, 4:26 PM · efl
cedric requested changes to D7247: ecore: fix composite models in order to properly model Ui.View selection.

This kind of trigger a fresh read for me on properties_get. I see a problem in general with the way it is used. A class can create new property on the fly (which is exactly what the boolean composite model does). I have created a task T7464 to track and discuss this specific issue. Until that one is addressed I am not sure we can land this patch even with correction I point out here.

Wed, Nov 14, 4:18 PM · efl
cedric triaged T7464: efl_model_properties_get has usability issue as High priority.
Wed, Nov 14, 4:12 PM
cedric requested changes to D7242: Efl.Ui.Tree_View: added new MVVM asynchronous widget.

Please get rid of seg_array. This is not something that make sense in term of public API at all. Don't forget that Eo object are public API meant to be used by bindings and others developers outside of EFL tree.

Wed, Nov 14, 3:38 PM · efl
cedric added a comment to T7358: EO: Support ecore_event APIs.

Why would we need Ecore_Event in Eo ? Do you have use case for it ? Duplicating legacy in Eo API is not a good enough justification in my opinion.

Wed, Nov 14, 2:42 PM · efl, Restricted Project
cedric added a comment to T7457: EO: Synchronize class naming rule.

Seems everyone is agreeing here and that we are following practice of other toolkit/environment with this idea, so I do also support @Jaehyun_Cho proposal.

Wed, Nov 14, 2:01 PM · efl
cedric added a comment to D7270: evas ector: fix memory leaks..

Could you do some more improvement on this ?

Wed, Nov 14, 11:30 AM · efl

Thu, Nov 1

cedric added a comment to D7226: efl_mono: Add Efl.Ui.Theme to support elm_theme APIs on C# binding.

Not saying that a singleton is the right answer here, but there is multiple way to provide it with Eo. A simple way is to have a @class function that will return the same object all the time, that is very close to what @lauromoura is proposing. The other way are to implement a constructor or a finalize function, check if it is not the first time they get called and if not, return the first object created. I personally prefer the @class function as it is easier to read and doesn't have strange expectation.

Thu, Nov 1, 11:21 AM · efl

Thu, Oct 25

cedric added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

This is interesting. I would like to see what is the call trace for most of this step_set. One of my guess is that this is happening in evas render while building the various object array. A long time ago, there was a cache to avoid rebuilding them during each loop as this array really don't change, but because Evas_Map was hard to handle and make sure it wasn't impacting the array content, I didn't bother at the time as it was not a very common use case. So when an Evas_Map is present, the cache are disabled. That was ok, 10 years ago. It might not be ok anymore today.

Thu, Oct 25, 9:30 AM · Restricted Project, Restricted Project, efl: data types

Sep 17 2018

cedric added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

@cedric I would like to share the issue.
An application which is works on evas gl engine calls evas_object_image_memfile_set in a timer callback.
The evas_object_image_memfile_set is using eina_file_virtualize with copy == TRUE.
This newly allocated memory is kept by the cache and never released only after the cache deletes related Image_Entry.
So memory usage becomes bigger and bigger whenever the timer callback is called.

Sep 17 2018, 9:44 AM · efl

Sep 16 2018

cedric requested changes to D7030: evas_image_main: make the cache->usage count eina_file size.

I don't think this is a good idea. The image is read only mapped by the kernel in memory and can be dropped by the kernel at any point in time. It is also shared with all other process. It is basically "free" for the process. I don't think there is a good reason to account for this.

Sep 16 2018, 11:47 PM · efl

May 28 2018

cedric requested changes to D6213: elm_colorselector: fix improperly named API theme parts.
May 28 2018, 10:09 PM · efl
cedric accepted D6212: theme: rename non-API actionslider part to avoid confusion when reading.
May 28 2018, 10:01 PM · efl
cedric accepted D6211: elm_dayselector: fix improperly named API theme parts.
May 28 2018, 10:01 PM · efl
cedric accepted D6210: theme: fix part namespacing in multibuttonentry theme.
May 28 2018, 9:57 PM · efl
cedric closed D6224: edje: a new testcase for what was happening before.
May 28 2018, 9:54 PM · efl
cedric closed D6223: eo: do not return efl_invalidated true when its not true.
May 28 2018, 9:54 PM · efl
cedric closed D6222: edje: fix lifecycle of swallowed children.
May 28 2018, 9:54 PM · efl
cedric accepted D6223: eo: do not return efl_invalidated true when its not true.

So I put this in place as it was not possible to know if the parent was invalidating or not as efl_parent_get will return a valid parent chain during invalidation when is_invalidating is true. Basically you could know with efl_parent_get != NULL and efl_invalidated_get == true that the parent was currently invalidating itself. With this patch, we don't know anymore. Checking my usual pattern with E, Terminology and Elementary_Test doesn't yield any issue, so it might be ok actually. So I will land this serie, but if this trigger other issue, we might want to revert to the current behavior and change the caller to check this information correctly.

May 28 2018, 9:53 PM · efl
cedric requested changes to D6217: elementary textpath: reverse autofit behavior according to its meaning.

I agree with @Hermet ! Good to see you back !

May 28 2018, 9:16 PM · efl

May 25 2018

cedric closed T6939: ELM_FILESELECTOR: file,chosen directories only as Resolved.

Should be fixed by 2a5dc744083e2b227bbdfdcaf2c834298d72fa5f

May 25 2018, 2:07 PM · efl, regression
cedric updated subscribers of T6964: object life-cycle issue..

No, I have tryed to figure out how that could be happening, but couldn't. Basically they are zombie object still present in the canvas when it is getting destroyed. It is a weird kind of zombie. Some where surviving as they were overriding efl_parent_set, but this is not the case for those. I haven't been able to understand what is happening. The good side is that it doesn't trigger a crash nor a use after free, the bad side is that it give little information of what is going on.

May 25 2018, 2:06 PM · efl (efl-1.21), regression, efl: widgets
cedric added a project to D6207: termio: make sure that reference to gesture layer are cleaned at the right time.: Terminology.
May 25 2018, 1:12 PM · Terminology
cedric updated subscribers of D6060: Revert "elm config - dont leak config if re-loading it again later on".

I haven't landed this one as this is still pending investigation with T6879, but I am giving up the only laptop where I see this crash today and don't have much time digging in. So there will be a call to be made if nobody understand why there is a crash to revert this patch or keep it @stefan_schmidt .

May 25 2018, 11:10 AM · DO NOT MERGE, efl
cedric added inline comments to D6041: edje_cc: fixup edje_collections_lookup hash ids during collection pruning.
May 25 2018, 11:08 AM · efl
cedric added a comment to T6878: ecore timer tests fail to pass tolerance threshold in some cases.

Hum, this might be related to the use of a static variable with no fork and parallel use, it might get to zero while it shouldn't. Maybe making that a general variable and doing a reset to 5 every time we do a test would solve this issue.

May 25 2018, 10:51 AM · efl: main loop, Testing
cedric closed D5843: elm_spinner: Spinner value adjust when round enabled..
May 25 2018, 10:42 AM · efl
cedric closed D6043: eina: Improve eina_array function documentation.
May 25 2018, 10:42 AM · efl
cedric closed D6019: ecore-evas-x: set draw_block until the window receives a configure event.
May 25 2018, 10:42 AM · efl