cedric (Cedric BAIL)Administrator
Senior Black Sorcerer

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 3:13 AM (277 w, 1 d)
Roles
Administrator
Availability
Available

I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !

Recent Activity

Fri, May 18

cedric accepted D6169: Add missing event types.
Fri, May 18, 4:35 PM · efl

Thu, May 17

cedric requested changes to D6169: Add missing event types.
Thu, May 17, 10:18 AM · efl
cedric requested changes to D6168: ecore_con : Fix class check to check inner_socket class.
Thu, May 17, 8:53 AM · efl
cedric added a reviewer for D6168: ecore_con : Fix class check to check inner_socket class: barbieri.
Thu, May 17, 8:48 AM · efl

Wed, May 16

cedric accepted D6109: efl_ui_win: hand-ref-count the provider object.
Wed, May 16, 10:00 AM · efl
cedric added a comment to T6889: Evas_Vg legacy API is not exposed by default in efl master.

Actually the legacy API could go out of beta and be considered released. The API as it is exposed is used by samsung and third party developers with no problem for some time now.

Wed, May 16, 8:56 AM · efl

Tue, May 15

cedric added a comment to D6108: Introduce efl_ui_widget_focus_manager.

Can you rebase your patch on my branch devs/cedric/lifecycle. They do seems to work and I have make check pass after them being applied. Still I do see a lot of :

Tue, May 15, 3:53 PM · efl
cedric added a comment to T6939: ELM_FILESELECTOR: file,chosen directories only.

Oh, I see. Will look at it. Thanks for the report.

Tue, May 15, 9:48 AM · efl, regression
cedric added a comment to T6939: ELM_FILESELECTOR: file,chosen directories only.

Sorry I am a bit confused by the ticket. What is the git behavior that is a problem ? What was the old behavior ?

Tue, May 15, 9:40 AM · efl, regression
cedric accepted D6164: edje: Fix to support translation for textblock part.

Look ok to me.

Tue, May 15, 9:39 AM · efl

Fri, May 11

cedric added a comment to D6109: efl_ui_win: hand-ref-count the provider object.

I am not sure this is going to be enough as during destructor, provider_find will not find anything (because you are disconnected from your parent during invalidate). Also, I am thinking that efl_composite_attach/detach should result in the ref counting of the composite object which would simpliufy some of your code.

Fri, May 11, 8:51 AM · efl
cedric requested changes to D6158: evas: error out when there appeared a object while a new one is focused.

Are you trying to do what eina_hash_set does ?

Fri, May 11, 8:42 AM · efl

Mon, May 7

cedric added a dependent revision for D6106: elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense.: D6107: eio: properly handle Eio.Model lifecycle inside Elm.Fileselector..
Mon, May 7, 11:31 AM · efl
cedric added a dependent revision for D6105: elementary: no need to check for part during destruction.: D6106: elementary: dayselector use efl_add to create the object, calling efl_del during destructor make no sense..
Mon, May 7, 11:31 AM · efl
cedric added a dependent revision for D6104: elementary: no need for resize an object during destruction.: D6105: elementary: no need to check for part during destruction..
Mon, May 7, 11:31 AM · efl
cedric added a dependent revision for D6103: elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor.: D6104: elementary: no need for resize an object during destruction..
Mon, May 7, 11:31 AM · efl
cedric added a dependent revision for D6102: elementary: small correction in the API of Efl.Access.Object to have proper lifecycle.: D6103: elementary: colorselector item are created with efl_add, so they are dead when they reach the destructor..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6101: evas: refactor efl_input_event and remove some of the lifecycle hack.: D6102: elementary: small correction in the API of Efl.Access.Object to have proper lifecycle..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6100: eo: actually during invalidating we already have an invalidated object.: D6101: evas: refactor efl_input_event and remove some of the lifecycle hack..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6099: eo: move EFL internal function ___efl_ref2 also to eo_internal.h: D6100: eo: actually during invalidating we already have an invalidated object..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6098: efl: major rewrite of efl_part.: D6099: eo: move EFL internal function ___efl_ref2 also to eo_internal.h.
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6097: eo: check for allow_parent_unref during efl_unref and silence warning.: D6098: efl: major rewrite of efl_part..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6096: eo: make sure efl_noref is always called at the proper time.: D6097: eo: check for allow_parent_unref during efl_unref and silence warning..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6095: eo: add an automatic fallback at the moment when efl_unref instead of efl_del is called.: D6096: eo: make sure efl_noref is always called at the proper time..
Mon, May 7, 11:30 AM · efl
cedric added a dependent revision for D6094: elementary: object created with efl_add should be destroyed with efl_del.: D6095: eo: add an automatic fallback at the moment when efl_unref instead of efl_del is called..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6093: elementary: object allocated with efl_add should be destroyed with efl_del.: D6094: elementary: object created with efl_add should be destroyed with efl_del..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6092: eldbus: fix unref of eldbus to not throw warning all over the place.: D6093: elementary: object allocated with efl_add should be destroyed with efl_del..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6091: eldbus: manage death of children during invalidate.: D6092: eldbus: fix unref of eldbus to not throw warning all over the place..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6090: eldbus: object created with efl_add should be destroyed with efl_del.: D6091: eldbus: manage death of children during invalidate..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6089: ecore: first invalidate the loop and its children, then destroy all the object capability.: D6090: eldbus: object created with efl_add should be destroyed with efl_del..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6088: eo: optimize efl object reuse by limiting the amount of call to pointer translation.: D6089: ecore: first invalidate the loop and its children, then destroy all the object capability..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6087: edje: properly handle lifecycle of edje global object.x: D6088: eo: optimize efl object reuse by limiting the amount of call to pointer translation..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6086: eo: prevent parenting to an already invalidated parent.: D6087: edje: properly handle lifecycle of edje global object.x.
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6085: eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating.: D6086: eo: prevent parenting to an already invalidated parent..
Mon, May 7, 11:29 AM · efl
cedric added a dependent revision for D6084: ecore_con: correct lifecycle of object used by Efl.Net.Dialer.Ssl.: D6085: eo: only call efl_parent_set(NULL) at the end of invalidate if the object is not invalidating..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6083: ecore_con: trigger teardown during invalidate.: D6084: ecore_con: correct lifecycle of object used by Efl.Net.Dialer.Ssl..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6082: ecore_con: it is best to call the super destructor and not touch the object anymore after.: D6083: ecore_con: trigger teardown during invalidate..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6081: ecore_con: correct a typo wrongly calling super destructor instead of super invalidate.: D6082: ecore_con: it is best to call the super destructor and not touch the object anymore after..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6080: ecore: correct lifecycle of object used by Ecore_Con legacy.: D6081: ecore_con: correct a typo wrongly calling super destructor instead of super invalidate..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6079: eo: improve error message by pointing to the class that is creating trouble.: D6080: ecore: correct lifecycle of object used by Ecore_Con legacy..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6078: eo: preventing infinite loop by safely iterating over children during destructor.: D6079: eo: improve error message by pointing to the class that is creating trouble..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6077: ecore: properly handle shutdown of Efl.Loop children by using invalidate.: D6078: eo: preventing infinite loop by safely iterating over children during destructor..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6076: ecore: disable signal during shutdown.: D6077: ecore: properly handle shutdown of Efl.Loop children by using invalidate..
Mon, May 7, 11:28 AM · efl
cedric added a dependent revision for D6075: eo: invalidate at the end of efl_invalidate only and prevent infinite recursion with an invalidating phase.: D6076: ecore: disable signal during shutdown..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6074: ecore: force close during invalidate of Efl.Io.Buffered_Stream.: D6075: eo: invalidate at the end of efl_invalidate only and prevent infinite recursion with an invalidating phase..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6073: elementary: use invalidate instead of overriding del for widget items.: D6074: ecore: force close during invalidate of Efl.Io.Buffered_Stream..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6072: elementary: rely on inheritance instead of faking efl_del behavior.: D6073: elementary: use invalidate instead of overriding del for widget items..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6071: elementary: make del_pre not return a bool and force rely on Eo ref counting.: D6072: elementary: rely on inheritance instead of faking efl_del behavior..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6070: elementary: prevent death of list item using Eo ref counting.: D6071: elementary: make del_pre not return a bool and force rely on Eo ref counting..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6069: elementary: remove now useless walking in item.: D6070: elementary: prevent death of list item using Eo ref counting..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6068: elementary: use Eo ref counting to prevent death of genlist items.: D6069: elementary: remove now useless walking in item..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6067: elementary: use Eo ref counting to prevent death of gengrid items.: D6068: elementary: use Eo ref counting to prevent death of genlist items..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6066: elm_list: prevent list item operations during item deletion: D6067: elementary: use Eo ref counting to prevent death of gengrid items..
Mon, May 7, 11:27 AM · efl
cedric added a dependent revision for D6065: elm_list: fix crash in item deletion: D6066: elm_list: prevent list item operations during item deletion.
Mon, May 7, 11:26 AM · efl
cedric added a revision to T6880: elm list calls _items_fix() during canvas deletion: D6066: elm_list: prevent list item operations during item deletion.
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6064: evas: handle pointer device deletion after invalidate: D6065: elm_list: fix crash in item deletion.
Mon, May 7, 11:26 AM · efl
cedric added a revision to T6881: elm list items need to use widget item inheritance and not have crazy object deletion: D6065: elm_list: fix crash in item deletion.
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6063: elm_genlist/gengrid: remove clear in destructor: D6064: evas: handle pointer device deletion after invalidate.
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6062: Revert "efl_add_ref - fis to use efl_add properly with a parent.": D6063: elm_genlist/gengrid: remove clear in destructor.
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6061: eo: to avoid mistake in timing, efl_invalidate should always be triggered before any destructor code.: D6062: Revert "efl_add_ref - fis to use efl_add properly with a parent.".
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6060: Revert "elm config - dont leak config if re-loading it again later on": D6061: eo: to avoid mistake in timing, efl_invalidate should always be triggered before any destructor code..
Mon, May 7, 11:26 AM · efl
cedric added a dependent revision for D6059: eio: delay tests until we have started listing some files.: D6060: Revert "elm config - dont leak config if re-loading it again later on".
Mon, May 7, 11:26 AM · efl
cedric updated the diff for D6059: eio: delay tests until we have started listing some files..
Mon, May 7, 11:26 AM · efl
cedric added a comment to D6057: Introduce efl_ui_widget_focus_manager.

Will integrate this patch into my lifecycle branch.

Mon, May 7, 10:03 AM · efl
cedric accepted D6024: Eo: introduce convenience macro efl_new().

I like that it simplify the introduction to Eo object lifecycle.

Mon, May 7, 9:21 AM · efl

Fri, May 4

cedric added reviewers for D6045: edje: Remove hack code: zmike, herdsman.
Fri, May 4, 12:58 PM · efl

Thu, May 3

cedric accepted D6047: tests: optimize eio tests.

Great !

Thu, May 3, 1:36 PM · efl
cedric added a comment to D6047: tests: optimize eio tests.

I remember that there was a potential race condition between when a file is created and when a monitor is added and that is why we had this usleep. Basically, the file could some time popup in the monitor even if it was clearly created before. Did you see that problem or is it gone ? I would blame the kernel for such a behavior, but well, it impacts our tests.

Thu, May 3, 1:04 PM · efl

Wed, May 2

cedric added a comment to T6879: Random frequent crash of E.

Sorry didn't had time to turn it back on my laptop. 100% reproductible here.

Wed, May 2, 10:45 AM
cedric added a comment to T6879: Random frequent crash of E.

Sorry didn't had time to turn it back on my laptop. 100% reproductible here.

Wed, May 2, 10:45 AM
cedric accepted D6023: Update docs for efl_add() and efl_add_ref().
Wed, May 2, 9:42 AM
cedric added a project to D6025: edje: Expose loading APIs to be referenced by edje_cc: efl.
Wed, May 2, 9:41 AM · efl
cedric added a project to D6026: edje_cc: Add import statement: efl.
Wed, May 2, 9:41 AM · efl
cedric added a project to D6027: edje_cc: Add support for inheriting group from imported edj: efl.
Wed, May 2, 9:40 AM · efl
cedric added a project to D6028: edje_cc: Copy color/size classes from imported group: efl.
Wed, May 2, 9:40 AM · efl
cedric added a project to D6029: edje_cc: Copy text classes and styles from imported group: efl.
Wed, May 2, 9:39 AM · efl
cedric added a project to D6030: edje_cc: Use macro to get rid of repeated section: efl.
Wed, May 2, 9:39 AM · efl
cedric added reviewers for D6031: edje_cc: Copy text classes used in style: cedric, zmike.
Wed, May 2, 9:38 AM · efl
cedric added reviewers for D6032: edje_cc: Handle image resources when importing edj: zmike, cedric.
Wed, May 2, 9:38 AM · efl
cedric added a project to D6032: edje_cc: Handle image resources when importing edj: efl.
Wed, May 2, 9:38 AM · efl
cedric accepted D6035: eio: fix windows build.
Wed, May 2, 9:13 AM

Tue, May 1

cedric closed D6018: efl_cxx: Remove eolized promises from the CXX bindings.
Tue, May 1, 10:40 AM
cedric accepted D6018: efl_cxx: Remove eolized promises from the CXX bindings.

Thanks

Tue, May 1, 9:37 AM

Mon, Apr 30

cedric added a comment to T6891: Ghost focus in elementary_config.

Isn't that button hidden ? Or shouldn't it be ?

Mon, Apr 30, 9:59 AM · Efl.Ui.Focus, efl

Fri, Apr 27

cedric accepted D5843: elm_spinner: Spinner value adjust when round enabled..

Sorry forgot about this. Looks good.

Fri, Apr 27, 10:12 AM
cedric accepted D5861: efl_ui_list : introduce new list widget for simple usage.

Looks good to me.

Fri, Apr 27, 10:00 AM

Tue, Apr 24

cedric added a comment to T6847: Rationalize class and namespace names.

As people may have noticed, I have landed this. I am just thinking that maybe efl.gfx.entity could actually use an eo_prefix: efl_gfx. Opinion ?

Tue, Apr 24, 5:41 PM · Restricted Project, efl
cedric updated subscribers of T6885: A backward compatibility for color_class's default color is broken..

@an.kroitor do you have an updated opinion on this ?

Tue, Apr 24, 5:40 PM
cedric added a comment to D5861: efl_ui_list : introduce new list widget for simple usage.

@cedric I know we cannot push new class or interface in the class hierarchy, so that is why i'm asking this question.
we cannot create Efl.Ui.Item later, so if we need it, we have to make it in this time.
my question is,
do we really need this class or not.
as far as I know, we decided to not create Item classes, so I'm not sure the class Efl.Ui.Item is what we really want.

Tue, Apr 24, 5:38 PM
cedric added a comment to D5969: efl_ui_spin: Added special value feature..

Just a question here, did you look at how it would look like with bindings ? I am thinking we might want an API that would be more a set/get with an array/hash of value+label. We could use either an Eina_Value, an Eina_Array or an Eina_Hash. The use could look like one of the following :

spin.special_values = { 1: "January",  2: "February", 3: "March", 4: "April", 5: "May", 6: "June", 7: "July", 8: "August", 9: "September", 10: "October", 11: "November", 12: "December"};
spin.special_values = { { value: 1, label: "January" },  { value: 2, label: "February" }, { value: 3, label: "March" }, { value: 4, label: "April" }, { value: 5, label: "May" }, { value: 6, label: "June" }, { value: 7, label: "July" }, { value: 8, label: "August" }, { value: 9, label: "September" }, { value: 10, label: "October" },  {value: 11, label: "November" }, { value: 12, label: "December"} };

I think that using Eina_List with Eina_Hash is good idea if special_values = { { 1: "January" } } is the only thing we need to write for C#.

However, I worry about the usage in C. Because the hash is consist of { double: string } and it is complicated to support double key for now. (eina_hash_new with key_length, key_compare, key_hash functions are required)

Hum, I missed that it was double. Indeed, not a great index for a hash. Not just in C, but everywhere.

BTW, I think that using Eina_List with Eina_Value is not a good idea because it requires many additional information to write (i.e. value, label).

Well, it is less to type than efl_ui_spin_special_value_add or special_value_add for namespaced language :-) In C, it should also become straight forward to go with an array inside an Eina_Value. You should be able to do something like :

// Provided by Efl_Ui.h somewhere
typedef struct _Efl_Ui_Spin_Special_Value {
  double value;
  const char *label;
} Efl_Ui_Spin_Special_Value;
EINA_VALUE_STRUCT_DESC_DEFINE(Efl_Ui_Spin_Special_Value_Desc, NULL, sizeof (Efl_Ui_Spin_Special_Value),
  EINA_VALUE_STRUCT_MEMBER(EINA_VALUE_TYPE_DOUBLE, Efl_Ui_Spin_Special_Value, value),
  EINA_VALUE_STRUCT_MEMBER(EINA_VALUE_TYPE_STRING, Efl_Ui_Spin_Special_Value, label));
 
Efl_Ui_Spin_Special_Value values[] = { { 1, "January" }, { 2, "February" } };

Eina_Value *v = eina_value_array_from(EINA_VALUE_TYPE_STRUCT, Efl_Ui_Spin_Special_Value_Desc, values);
 
efl_ui_spin_special_values_set(obj, v);

We are missing the eina_value_array_from() function, if I have time, I will write it tomorrow, but if you can cover it before me go ahead with that one.

@felipealmeida how would that look like in C# ?

@cedric

I think that special_value_set(value, label); is better than special_values = ...;

Because to use special_values = ...;, app developer should know how to create Eina_Value from special_value structure array.
app developer has no idea how to generate Eina_Value related to special value when they simply see the function parameters.

Tue, Apr 24, 5:34 PM · efl
cedric added a comment to D5980: elemenatry layout: don't allow negative position.

@cedric
Sorry, but I think [(int) pos < 0] and [pos > INT_MAX] are same in this case.

Tue, Apr 24, 5:31 PM
cedric added a comment to D5988: efl_ui_tab_pager: add Efl.Ui.Tab_Pager and related classes.

Overall this seems almost ready to me, pretty good. Let me know what you think of my comment. Also there is a few TODO/FIXME, what are your plan regarding those ?

Tue, Apr 24, 5:27 PM
cedric accepted D5987: evas_main: Add null exception handling.
Tue, Apr 24, 5:13 PM
cedric reopened T6894: terminology font config focus issue as "Open".
Tue, Apr 24, 3:39 PM · efl
cedric assigned T6894: terminology font config focus issue to bu5hm4n.
Tue, Apr 24, 3:39 PM · efl
Herald closed T6894: terminology font config focus issue as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks both a project and an assignee. If this ticket is not spam, please reopen it after adding these items.

Tue, Apr 24, 3:37 PM · efl
cedric triaged T6893: weird animation when focusing the config menu as Normal priority.
Tue, Apr 24, 3:35 PM
cedric triaged T6892: menu does not implement focus as Normal priority.
Tue, Apr 24, 3:18 PM · Efl.Ui.Focus, efl
cedric triaged T6891: Ghost focus in elementary_config as Normal priority.
Tue, Apr 24, 3:16 PM · Efl.Ui.Focus, efl
cedric triaged T6890: Eolian error integration as TODO priority.
Tue, Apr 24, 8:24 AM · Restricted Project, efl