Page MenuHomePhabricator

cedric (Cedric BAIL)Administrator
Senior Black Sorcerer

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 25 2013, 3:13 AM (321 w, 2 d)
Roles
Administrator
Availability
Available

I am French so I love cheese, baguette and croissant, but not quite wine. I have been kidnapped a year or so by Samsung ninja team in Korea. I am also know as The borker will see if that survive our move to git !

Recent Activity

Fri, Mar 22

cedric requested review of D8452: elementary: fix ATSPI reflection API warning..
Fri, Mar 22, 4:36 PM · efl
cedric added a child revision for D8451: eina: always initialize i.: D8452: elementary: fix ATSPI reflection API warning..
Fri, Mar 22, 4:36 PM · efl
cedric requested review of D8451: eina: always initialize i..
Fri, Mar 22, 4:35 PM · efl
cedric closed T4904: evas_map change results in full redraw as Resolved by committing rEFLe6d8ac512d21: evas_clip: check for object validity before adding fallback damage rect.
Fri, Mar 22, 2:11 PM · efl (efl-1.22), efl: rendering
cedric closed T7100: Performance issue when closing the menu as Resolved by committing rEFLe6d8ac512d21: evas_clip: check for object validity before adding fallback damage rect.
Fri, Mar 22, 2:11 PM · efl (efl-1.22), regression, efl: display system
cedric closed T7100: Performance issue when closing the menu, a subtask of T4904: evas_map change results in full redraw, as Resolved.
Fri, Mar 22, 2:11 PM · efl (efl-1.22), efl: rendering
cedric closed T7421: Something is adding ridiculous damage rectangles as Resolved by committing rEFLe6d8ac512d21: evas_clip: check for object validity before adding fallback damage rect.
Fri, Mar 22, 2:11 PM · efl (efl-1.22), regression, efl: canvas
cedric closed T7421: Something is adding ridiculous damage rectangles, a subtask of T7100: Performance issue when closing the menu, as Resolved.
Fri, Mar 22, 2:11 PM · efl (efl-1.22), regression, efl: display system
cedric closed D8445: evas_clip: check for object validity before adding fallback damage rect.
Fri, Mar 22, 2:11 PM · efl: rendering
cedric accepted D8445: evas_clip: check for object validity before adding fallback damage rect.

This is an interesting one. I was wondering if it didn't impact our performance, but nop. That is another problem.

Fri, Mar 22, 2:10 PM · efl: rendering
cedric added a comment to D8336: elementary: improve lifecycle of model object in the fileselector widget..

Okay, if i am now using the most upperst revision then the items do not get mixed up anymore. However, the first population run finishes before the new path is populated. This is something that I would not expect as a user.

Fri, Mar 22, 2:09 PM · efl
cedric requested review of D8450: elementary: make sure that the model parent being used is always the fileselector..
Fri, Mar 22, 11:29 AM · efl
cedric added a child revision for D8449: elementary: prevent asynchronous properties change to believe target is ready when it is not in fileselector.: D8450: elementary: make sure that the model parent being used is always the fileselector..
Fri, Mar 22, 11:28 AM · efl
cedric requested review of D8449: elementary: prevent asynchronous properties change to believe target is ready when it is not in fileselector..
Fri, Mar 22, 11:28 AM · efl
cedric added a child revision for D8448: elementary: fix fileselector entry support to define path manually.: D8449: elementary: prevent asynchronous properties change to believe target is ready when it is not in fileselector..
Fri, Mar 22, 11:28 AM · efl
cedric requested review of D8448: elementary: fix fileselector entry support to define path manually..
Fri, Mar 22, 11:28 AM · efl
cedric added a child revision for D8447: eio: guarantee that we will at least process one request per loop iteration for very slow system.: D8448: elementary: fix fileselector entry support to define path manually..
Fri, Mar 22, 11:28 AM · efl
cedric requested review of D8447: eio: guarantee that we will at least process one request per loop iteration for very slow system..
Fri, Mar 22, 11:28 AM · efl
cedric added a child revision for D8375: elementary: destroy fileselector children when they are not itemized yet.: D8447: eio: guarantee that we will at least process one request per loop iteration for very slow system..
Fri, Mar 22, 11:28 AM · efl
cedric updated the diff for D8375: elementary: destroy fileselector children when they are not itemized yet..

Rebase.

Fri, Mar 22, 11:28 AM · efl
cedric updated the diff for D8374: eio: remove unecessary use of weak reference..

Rebase.

Fri, Mar 22, 11:28 AM · efl
cedric updated the diff for D8373: eio: Efl.Io.Model should not make request when the object is invalidating itself..

Rebase.

Fri, Mar 22, 11:28 AM · efl
cedric updated the diff for D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

Rebase.

Fri, Mar 22, 11:27 AM · efl
cedric updated the diff for D8371: eio: work around the lack of integration between Ecore_Thread and Eina_Future..

Rebase.

Fri, Mar 22, 11:27 AM · efl
cedric updated the diff for D8359: elementary: only apply text when the object is not invalidated and dying..

Rebase.

Fri, Mar 22, 11:27 AM · efl
cedric updated the diff for D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist".

Rebase.

Fri, Mar 22, 11:27 AM · efl
cedric updated the diff for D8358: eo: enforce auto_unref logic at the end of efl_unref execution..

Rebase.

Fri, Mar 22, 11:26 AM · efl
cedric updated the diff for D8357: eo: refactor auto_unref logic used by efl_part..

Rebase.

Fri, Mar 22, 11:26 AM · efl
cedric updated the diff for D8336: elementary: improve lifecycle of model object in the fileselector widget..

Rebase.

Fri, Mar 22, 11:26 AM · efl
cedric updated the diff for D8335: eio: path and filename property should always remind accessible even in case of error..

Rebase.

Fri, Mar 22, 11:26 AM · efl
cedric updated the diff for D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

Rebase.

Fri, Mar 22, 11:26 AM · efl
cedric updated the diff for D8333: eina: prevent double cancel of ongoing dispatched future..

Rebase.

Fri, Mar 22, 11:25 AM · efl
cedric updated the diff for D8332: elementary: split the smart callback event name from the Eo name when needed..

Rebase.

Fri, Mar 22, 11:25 AM · efl

Thu, Mar 21

cedric added a comment to D8335: eio: path and filename property should always remind accessible even in case of error..

_eio_build_st is protecting itself from doing what I wrote above, it just feels a little bit fragile, since changing this would leave the world in parts, maybe make pd->st = NULL and pd->info = NULL; in case of an error ?

Thu, Mar 21, 9:02 AM · efl

Wed, Mar 20

cedric closed D8401: efl_ui_win: avoid triggering legacy forbidden path during window finalize.
Wed, Mar 20, 12:37 PM · efl: widgets
cedric closed D8392: elm_test: set accel for all glview tests.
Wed, Mar 20, 12:37 PM · efl: widgets
cedric closed D8400: efl_ui_win: mark legacy forbidden during bg part load always.
Wed, Mar 20, 12:37 PM · efl: widgets
cedric closed T7713: some elementary_test cases no longer run as Resolved.
Wed, Mar 20, 12:37 PM · efl (efl-1.22), efl: widgets
cedric added a commit to T7713: some elementary_test cases no longer run: rEFL5930c5f86ed5: efl_ui_win: avoid triggering legacy forbidden path during window finalize.
Wed, Mar 20, 12:37 PM · efl (efl-1.22), efl: widgets
cedric closed D8390: elm_test: move gl api creation to glview init function.
Wed, Mar 20, 12:36 PM · efl: widgets
cedric closed D8389: efl_ui_win: fix hw accel detection.
Wed, Mar 20, 12:36 PM · efl: widgets
cedric added a commit to T7713: some elementary_test cases no longer run: rEFLbc03654caf09: elm_test: use legacy api for glview gears test.
Wed, Mar 20, 12:36 PM · efl (efl-1.22), efl: widgets
cedric closed D8388: elm_test: use legacy api for glview gears test.
Wed, Mar 20, 12:36 PM · efl: widgets
cedric accepted D8392: elm_test: set accel for all glview tests.
Wed, Mar 20, 12:35 PM · efl: widgets
cedric accepted D8401: efl_ui_win: avoid triggering legacy forbidden path during window finalize.
Wed, Mar 20, 12:32 PM · efl: widgets
cedric accepted D8430: docs: Remove obsolete @since tags from EO files.

Seems to remove only what it says it was removing. Good to land.

Wed, Mar 20, 12:02 PM · efl
cedric accepted D8389: efl_ui_win: fix hw accel detection.
Wed, Mar 20, 11:49 AM · efl: widgets
cedric accepted D8388: elm_test: use legacy api for glview gears test.
Wed, Mar 20, 11:48 AM · efl: widgets
cedric updated the diff for D8375: elementary: destroy fileselector children when they are not itemized yet..

Rebase and correct.

Wed, Mar 20, 11:37 AM · efl
cedric updated the diff for D8374: eio: remove unecessary use of weak reference..

Rebase and correct.

Wed, Mar 20, 11:37 AM · efl
cedric updated the diff for D8373: eio: Efl.Io.Model should not make request when the object is invalidating itself..

Rebase and correct.

Wed, Mar 20, 11:37 AM · efl
cedric updated the diff for D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

Rebase and correct.

Wed, Mar 20, 11:37 AM · efl
cedric updated the diff for D8371: eio: work around the lack of integration between Ecore_Thread and Eina_Future..

Rebase and correct.

Wed, Mar 20, 11:36 AM · efl
cedric updated the diff for D8359: elementary: only apply text when the object is not invalidated and dying..

Rebase and correct.

Wed, Mar 20, 11:36 AM · efl
cedric added a child revision for D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist": D8359: elementary: only apply text when the object is not invalidated and dying..
Wed, Mar 20, 11:36 AM · efl
cedric requested review of D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist".
Wed, Mar 20, 11:36 AM · efl
cedric added a child revision for D8358: eo: enforce auto_unref logic at the end of efl_unref execution.: D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist".
Wed, Mar 20, 11:36 AM · efl
cedric updated the diff for D8358: eo: enforce auto_unref logic at the end of efl_unref execution..

Rebase.

Wed, Mar 20, 11:36 AM · efl
cedric updated the diff for D8357: eo: refactor auto_unref logic used by efl_part..

Rebase.

Wed, Mar 20, 11:36 AM · efl
cedric updated the diff for D8336: elementary: improve lifecycle of model object in the fileselector widget..

Rebase and correct.

Wed, Mar 20, 11:35 AM · efl
cedric updated the diff for D8335: eio: path and filename property should always remind accessible even in case of error..

Rebase.

Wed, Mar 20, 11:35 AM · efl
cedric updated the diff for D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

Rebase.

Wed, Mar 20, 11:35 AM · efl
cedric updated the diff for D8333: eina: prevent double cancel of ongoing dispatched future..

Rebase and correct.

Wed, Mar 20, 11:34 AM · efl
cedric updated the diff for D8332: elementary: split the smart callback event name from the Eo name when needed..

Rebase and correct.

Wed, Mar 20, 11:34 AM · efl
cedric planned changes to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..
Wed, Mar 20, 10:58 AM · efl
cedric planned changes to D8359: elementary: only apply text when the object is not invalidated and dying..
Wed, Mar 20, 10:58 AM · efl
cedric added a comment to D8359: elementary: only apply text when the object is not invalidated and dying..

I think you are right. It seems that for legacy we should be able to apply text before finalize. Going to be fun! Will adjust patch to be only for invalidating and after.

Wed, Mar 20, 10:48 AM · efl
cedric accepted D8418: efl_ui_tab_bar: the type of this event is annotated as object.
Wed, Mar 20, 9:51 AM · efl

Tue, Mar 19

cedric added a comment to T7761: eina: eina_future_as_value needs improved docs.

Main reasoning is that someone that is looking on how to return an Eina_Value from an Eina_Future would find this function very quickly and wouldn't have to understand much of what it does to use it.

Tue, Mar 19, 11:26 AM · efl: docs
cedric added a comment to T7761: eina: eina_future_as_value needs improved docs.

I would think that the main misleading things is that the returned Eina_Value is of type EINA_VALUE_TYPE_PROMISE and that there is no EINA_VALUE_TYPE_PROMISE. That might require more documentation. Otherwise I feel the name does match what the function does, it takes an Eina_Future and return an Eina_Value.

Tue, Mar 19, 11:26 AM · efl: docs

Mon, Mar 18

cedric accepted D8390: elm_test: move gl api creation to glview init function.

How did that ever work???

Mon, Mar 18, 10:36 AM · efl: widgets
cedric added a comment to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

First off, thank you both for giving my brain the opportunity to hurt so much.

Mon, Mar 18, 10:00 AM · efl
cedric accepted D8353: elm_focus_legacy: Fix resource leaks.
Mon, Mar 18, 9:57 AM · efl
cedric accepted D8352: eldbus: Fix resource leak.
Mon, Mar 18, 9:57 AM · efl
cedric added a comment to D8375: elementary: destroy fileselector children when they are not itemized yet..
In D8375#151127, @zmike wrote:

I tested this series locally and it still doesn't fix the fileselector unit test deadlocks. Also there's still quite a few errors.

Mon, Mar 18, 9:53 AM · efl
cedric added a comment to T7738: Calling convention for events in eolian.

Hum, there is a side effect to being passed by values vs references. In one case events can not alter the value as it pass there handler. In the other, they can. Maybe we should have a "const" marker to specify explicitly this intent. I think this also make a stronger case to mark efl_event_callback_call a protected function and generate function that will have the proper type checking in their prototype.

Mon, Mar 18, 9:40 AM · Restricted Project, efl (efl-1.22), efl: api

Sun, Mar 17

cedric requested changes to D8385: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist.

D8358 is actually fixing the issue by enforcing efl_unref to actually execture the auto unref logic. I didn't make efl_isa and all the other direct call to eo.c function enforce the auto unref, but maybe I should. My logic was that it would be necessary to always use efl_ref/unref to do something with a part with those function, but maybe that is incorrect. I don't know why someone would do :

efl_isa(efl_part(obj, part), SOME_CLASS)

But I guess it should work. Maybe you can add a patch that does the samething as D8358, but for efl_isa?

Sun, Mar 17, 10:40 PM · efl

Sat, Mar 16

cedric added a comment to D8359: elementary: only apply text when the object is not invalidated and dying..

Tbh. i am confused *when* its legal and *when* its not. Because right now, this function is always executed at a time where the layout object is *not* finalized. (Check _efl_ui_progressbar_efl_ui_widget_theme_apply for example) So this would break that right now AFAICS.

Sat, Mar 16, 1:50 PM · efl
cedric added a comment to D8359: elementary: only apply text when the object is not invalidated and dying..

I am nearly 100% sure that this breaks behavior. We use elm_layout_text_set before finalize is called, but the theme is maybe already set, so we want to call elm_layout_text_set on it...

Sat, Mar 16, 1:20 PM · efl
cedric added a comment to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

The macro ensures that the test case fails when there is a ERR.

Sat, Mar 16, 12:29 PM · efl
cedric added a comment to D8335: eio: path and filename property should always remind accessible even in case of error..

This commit does a little bit more than it describes. It also makes all the properties "direct_info", "mtime", "atime", "ctime", "is_dir", "is_lnk", "size", "stat" accessable. So as long as they have a value, this value is returned. Which also means when _eio_build_st is called twice, and the first one succeeds, and the second does not. Then the old value is returned i think ? All in all, should we make pd->st = NULL and pd->info = NULL; in case of an error ?

Sat, Mar 16, 12:29 PM · efl
cedric added a comment to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

Hum, this test should really not generate error. Like if it print a message, there is a problem that need fixing. I am not sure what the point of those macro would be in this context.

Sat, Mar 16, 12:17 PM · efl
cedric added a comment to D8358: eo: enforce auto_unref logic at the end of efl_unref execution..

Forgot to say, but change where made as requested.

Sat, Mar 16, 12:15 PM · efl
cedric added a comment to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..

We might want to consider renaming eina_future_as_value to something that does *not* suggest that the eina_value is a future :D

Sat, Mar 16, 11:38 AM · efl
cedric added inline comments to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..
Sat, Mar 16, 11:20 AM · efl
cedric added inline comments to D8374: eio: remove unecessary use of weak reference..
Sat, Mar 16, 11:03 AM · efl
cedric added a comment to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

I was more talking about adding DISABLE_ABORT_ON_CRITICAL_START; DISABLE_ABORT_ON_CRITICAL_END; to the test, so we ensure this test is not starting to print error messages.

Sat, Mar 16, 11:02 AM · efl
cedric added inline comments to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..
Sat, Mar 16, 11:01 AM · efl
cedric added inline comments to D8374: eio: remove unecessary use of weak reference..
Sat, Mar 16, 10:38 AM · efl
cedric added a comment to D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..

Well, this is a nice test. However, could we check that this prints no error ? :)

Sat, Mar 16, 10:37 AM · efl
cedric added inline comments to D8334: eio: rely on efl_future_then to properly protect Eo object during the lifecycle of the future callback..
Sat, Mar 16, 10:31 AM · efl
cedric added inline comments to D8333: eina: prevent double cancel of ongoing dispatched future..
Sat, Mar 16, 10:29 AM · efl

Fri, Mar 15

cedric requested review of D8375: elementary: destroy fileselector children when they are not itemized yet..
Fri, Mar 15, 5:02 PM · efl
cedric added a child revision for D8374: eio: remove unecessary use of weak reference.: D8375: elementary: destroy fileselector children when they are not itemized yet..
Fri, Mar 15, 5:02 PM · efl
cedric requested review of D8374: eio: remove unecessary use of weak reference..
Fri, Mar 15, 5:02 PM · efl
cedric added a child revision for D8373: eio: Efl.Io.Model should not make request when the object is invalidating itself.: D8374: eio: remove unecessary use of weak reference..
Fri, Mar 15, 5:02 PM · efl
cedric requested review of D8373: eio: Efl.Io.Model should not make request when the object is invalidating itself..
Fri, Mar 15, 5:02 PM · efl
cedric added a child revision for D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures.: D8373: eio: Efl.Io.Model should not make request when the object is invalidating itself..
Fri, Mar 15, 5:02 PM · efl
cedric requested review of D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..
Fri, Mar 15, 5:01 PM · efl
cedric added a child revision for D8371: eio: work around the lack of integration between Ecore_Thread and Eina_Future.: D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..
Fri, Mar 15, 5:01 PM · efl