Page MenuHomePhabricator

conr2d (Jeeyong Um)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2014, 10:19 AM (217 w, 4 d)
Availability
Available

Recent Activity

May 21 2018

conr2d added a comment to D6025: edje: Expose loading APIs to be referenced by edje_cc.

I understand that the feature provided by these patches can be done inherit_only too, but in that case, parent EDJ should have only inherit_only groups. Otherwise, redundant groups would be included to new EDJ.
If we want provide an easier way to customize theme by modifying "default" theme, EDJ only with inherit_only groups should be written first. And both "default" and user theme could inherit from it.
However, managing image resources wouldn't be easy ... image files should be provided separately and users who want to use inherit_only EDJ also have to keep image resources in accessible path.

May 21 2018, 4:43 AM · Restricted Project, efl

May 15 2018

conr2d updated subscribers of D6025: edje: Expose loading APIs to be referenced by edje_cc.
May 15 2018, 8:25 PM · Restricted Project, efl

May 13 2018

conr2d added a comment to D6025: edje: Expose loading APIs to be referenced by edje_cc.

Yes, you are right. If we only look into the usage you describe, 'import' and 'inherit_only' work similarly.
However, if multiple inheritance occurs, it becomes harder to manage all related resources like images etc. User should be able to access every image listed in all included EDC. I thought that this way is not portable.
The main benefit of this patch set is that it allows user to inherit some groups from single EDJ file and inherit from any group not marked as 'inherit_only'.
(By your way, parent EDJ should be written to have only inherit_only groups from the first not to include redundant groups in new EDJ)

May 13 2018, 10:42 PM · Restricted Project, efl

May 10 2018

conr2d added a comment to D6025: edje: Expose loading APIs to be referenced by edje_cc.

No, this 'import' doesn't work like #include syntax. By 'include', new EDJ will contain whole data from included one, but by 'import', only newly defined - inherited from imported EDJ but modified - group belong to generated EDJ. (EDJ will be compact and No duplication)
If user customized his theme based on specific version, of course, there can be someone who want his theme to be updated automatically based on the theme of new version (shared image id you mentioned can work here), but others might want to keep their original theme based on the theme of previous version.

May 10 2018, 4:46 AM · Restricted Project, efl

May 2 2018

conr2d updated subscribers of D6025: edje: Expose loading APIs to be referenced by edje_cc.
May 2 2018, 9:59 PM · Restricted Project, efl
conr2d added a comment to D6025: edje: Expose loading APIs to be referenced by edje_cc.

This feature has been demanded on Tizen side since the year before last, however I think this also can be helpful on upstream.
You're right. The main usage of this feature is reusing default theme but changing it a little. For example, if an app developer wants to use default "button", but the only concern is that background image doesn't fit his design. Currently, he should copy & paste raw edc source in his edc. Not all properties are changeable by classes (color/text/size), modifying edc cannot be avoidable.
Moreover, if that developer isn't used to writing edc, changing very small part or reading concise source (inherited groups only contain changed parts) will help managing his own edc.
By applying this feature, developers can inherit edje group from compiled one (Why edj not edc? Because edj already contains resources like images, so it can be obtained from edj directly. Or, developers will need to access image resource related to the group they wants to inherit every time)

May 2 2018, 9:59 PM · Restricted Project, efl
conr2d abandoned D6017: Edje: Add support for importing EDJ.

Thanks, I've done it. :)

May 2 2018, 4:34 AM
conr2d added a child revision for D6031: edje_cc: Copy text classes used in style: D6032: edje_cc: Handle image resources when importing edj.
May 2 2018, 4:29 AM · efl
conr2d added a child revision for D6030: edje_cc: Use macro to get rid of repeated section: D6031: edje_cc: Copy text classes used in style.
May 2 2018, 4:29 AM · efl
conr2d added a child revision for D6029: edje_cc: Copy text classes and styles from imported group: D6030: edje_cc: Use macro to get rid of repeated section.
May 2 2018, 4:29 AM · efl
conr2d added a child revision for D6028: edje_cc: Copy color/size classes from imported group: D6029: edje_cc: Copy text classes and styles from imported group.
May 2 2018, 4:29 AM · efl
conr2d added a child revision for D6027: edje_cc: Add support for inheriting group from imported edj: D6028: edje_cc: Copy color/size classes from imported group.
May 2 2018, 4:28 AM · efl
conr2d added a child revision for D6026: edje_cc: Add import statement: D6027: edje_cc: Add support for inheriting group from imported edj.
May 2 2018, 4:28 AM · efl
conr2d added a child revision for D6025: edje: Expose loading APIs to be referenced by edje_cc: D6026: edje_cc: Add import statement.
May 2 2018, 4:28 AM · Restricted Project, efl

Apr 9 2018

conr2d abandoned D4926: elm_widget: Add getter method for resize object.
Apr 9 2018, 2:05 AM

Apr 6 2018

conr2d added a comment to T6847: Fix class and namespace name collisions.

I also suffer from this namespace conflicting issue when writing Vala bindings.
I paused that task, but hope to continue it if this problem is resolved.
I like the solution of @herdsman or @DaveMDS, because exposing type like abstract class, interface or mixin in their name can help developers to get some hints without looking up documents every time.
Personally, I prefer short prefix like I in IEnumerable for interface Enumerable, because it will shorten C APIs.

Apr 6 2018, 11:55 PM · efl: language bindings, Restricted Project

Feb 19 2018

conr2d added a comment to T6708: Theming REALLY needs to happen more than Development. And it doesn't need to be a dark based theme..

IMHO, that the light theme is preferred commonly to the dark one is controversial, but more fundamental reason here is TOO DIFFICULT theme customization.

Feb 19 2018, 4:36 PM · Restricted Project

Nov 21 2017

conr2d added a comment to D5451: edje_cc: Add user defined aliases for GROUP or EXTERNAL part.

@taxi2se
Following code is an example by applying this syntax.

externals {
  external: "elm";
}
aliases {
  external: "elm/button" "button";
}
collections {
  group { "main";
    parts {
      button { "OK";
        desc {
          anchors {
            left: GROUP;
            right: GROUP HORIZONTAL_CENTER;
            fill: VERTICAL;
          }
          params.label: "OK";
        }
      }
      button { "Cancel";
          anchors {
            left: "OK";
            right: GROUP;
            fill: VERTICAL;
          }
          params.label: "Cancel";
      }
    }
  }
}
Nov 21 2017, 6:58 PM · efl

Nov 12 2017

conr2d added a comment to D5451: edje_cc: Add user defined aliases for GROUP or EXTERNAL part.

Do you think that sharing same slot with group alias is better idea? Then I will merge them.
However, group alias data is saved into compiled EDJ, but my ones are applied during compile time only. (They don't belong to compiled one)

Nov 12 2017, 10:15 PM · efl
conr2d added a comment to D5451: edje_cc: Add user defined aliases for GROUP or EXTERNAL part.

Ah, You're right, but this "alias" is different. With that "alias" in group, you cannot use alias name as part type.

Nov 12 2017, 8:44 PM · efl

Nov 10 2017

conr2d added a comment to D5451: edje_cc: Add user defined aliases for GROUP or EXTERNAL part.

@jpeg
'alias' in collections.group.parts.alias has different usage from this. It exposes internal group's part in parent group scope.
For example,

group { "main";
  parts {
    alias: "some_part" "aaa:other_part";
    swallow { "some_part"; }
    group { "aaa";
       source: "sub";
    }
  }
}
group { "sub";
  parts {
    swallow { "other_part"; }
  }
}
Nov 10 2017, 12:32 AM · efl

Nov 9 2017

conr2d created D5451: edje_cc: Add user defined aliases for GROUP or EXTERNAL part.
Nov 9 2017, 10:18 PM · efl

Nov 8 2017

conr2d closed D4403: Efl: add class interfaces (color/text/size).
Nov 8 2017, 3:10 AM

Nov 3 2017

conr2d closed D5423: edje_cc_script: remove build warning.
Nov 3 2017, 10:46 PM
conr2d accepted D5423: edje_cc_script: remove build warning.

Thank you for fixing my mistake.

Nov 3 2017, 10:45 PM

Oct 27 2017

conr2d closed D5062: edje_cc: Support script inheritance.
Oct 27 2017, 1:48 PM

Aug 16 2017

conr2d added a comment to D5062: edje_cc: Support script inheritance.

@taxi2se
In case of "case" with null statement, EINA_FALLTHROUGH (actually, __attribute__ ((fallthrough))) isn't necessary.
For example,

switch (var) {
  case 0: // unnecessary here, because "case 0" doesn't have any statements for it.
  case 1:
    break;
  case 2:
     some_func(); // EINA_FALLTHROUGH is necessary here, or comiler warns about implicit fallthrough. (when -Wimplicit-fallthrough option is turned on)
  case3:
     other_func();
     break;
}
Aug 16 2017, 7:58 PM

Aug 8 2017

conr2d added a comment to T5363: Cleanup elm_widget.eo.

Won't we support 'style' for widgets not Efl.Ui.Layout? If theme_apply() is moved under layout, it would be difficult to add style feature to widgets not layout.

Aug 8 2017, 3:08 AM · efl: widgets, Restricted Project

Aug 2 2017

conr2d updated the diff for D5062: edje_cc: Support script inheritance.

Remove duplicated lines by fallthrough

Aug 2 2017, 11:05 PM

Aug 1 2017

conr2d abandoned D4197: elementary: implement eo_finalize to set theme.
Aug 1 2017, 6:56 AM
conr2d created D5062: edje_cc: Support script inheritance.
Aug 1 2017, 6:46 AM

Jul 12 2017

conr2d added a comment to D4197: elementary: implement eo_finalize to set theme.

@jpeg Some widgets set text or contents in their constructor, so theme should be loaded before then. (efl_costructor -> efl_canvas_group_add -> efl_finalize)
Or, edje object should have the ability to queue setting text or contents before theme load.
I planned to update this revision with new patch which changes edje rather than elementary or I would create a new revision so that you can abandon this.

Jul 12 2017, 12:28 AM

Jul 11 2017

conr2d added a comment to D3625: elm_object.h: Add 'elm_object_part_image_set()' API..

In most cases, visual element in widgets will be one of rectangle, rounded rectangle or image. Internally, they aren't interchangeable (because they belong to different classes. eg. Efl.Canvas.Rectangle / Efl.Vg.Shape / Efl.Canvas.Image), but it would be very convenient, if there is an abstract class over them. For example, if there's no call for setting corner radius, this abstract object is instantiated with plain rectangle, but if it has set for corner radius, with vector graphic. If file_set exists, it would be image. This can be applied to interfaces for part bg, too.

Jul 11 2017, 11:16 PM
conr2d added a comment to D4283: edje: Apply color_class to TEXTBLOCK part's style.

The color set by tag is ignored when changing the color with color class, but this patch will consider the color by tag with higher priority than that by color class.
I think this change makes sense - local and manual change (tag) could overwrite global change (color class) - but it would change current behavior.

Jul 11 2017, 11:01 PM · efl

Jun 29 2017

conr2d closed D4994: efl_observer: free iterator after use in _efl_observable_observers_update by committing rEFL1ae77d0925ee: Efl.Observable: Free an iterator after use in observers_update() (authored by taxi2se).
Jun 29 2017, 9:36 PM
conr2d requested changes to D4994: efl_observer: free iterator after use in _efl_observable_observers_update.
Jun 29 2017, 6:26 AM

Jun 18 2017

conr2d closed T5586: evas-vg-simple does not compile as Resolved.
Jun 18 2017, 9:24 PM · efl
conr2d added a commit to T5586: evas-vg-simple does not compile: rEFL864e854fa943: example: Add missing definition to invoke EO API.
Jun 18 2017, 9:24 PM · efl
conr2d claimed T5586: evas-vg-simple does not compile.
Jun 18 2017, 9:23 PM · efl

Jun 14 2017

conr2d created T5577: Support easy object instantiation with Edje External.
Jun 14 2017, 5:57 AM · efl: layout engine, Restricted Project
conr2d created T5575: Use sub GROUP part for common properties.
Jun 14 2017, 1:11 AM · efl: layout engine, Restricted Project

Jun 8 2017

conr2d closed D4705: Genlist: Calculate the min size of content before item realize by committing rEFL02893c39ba56: Genlist: Calculate the min size of content before item realize (authored by conr2d).
Jun 8 2017, 11:10 PM

Jun 7 2017

conr2d added a comment to D4926: elm_widget: Add getter method for resize object.

@jpeg
The scope of this method is prorected. (I didn't mark it yet) I think this method is necessary when writing new widget, isn't it?

Jun 7 2017, 11:32 PM

Jun 2 2017

conr2d closed D4900: popup: fix object_mirrored_set didn't work by committing rEFLbcb7eb99b3c0: popup: fix object_mirrored_set didn't work (authored by Blackmole).
Jun 2 2017, 12:35 AM
conr2d accepted D4900: popup: fix object_mirrored_set didn't work.
Jun 2 2017, 12:24 AM
conr2d updated the diff for D4926: elm_widget: Add getter method for resize object.

Rename flag indicating whether resize_object_set have object reload its theme

Jun 2 2017, 12:05 AM

Jun 1 2017

conr2d edited reviewers for D4926: elm_widget: Add getter method for resize object, added: Jaehyun_Cho; removed: Jaehyun.
Jun 1 2017, 9:13 PM
conr2d requested changes to D4900: popup: fix object_mirrored_set didn't work.

I added inline comments.

Jun 1 2017, 7:05 PM

May 30 2017

conr2d created D4926: elm_widget: Add getter method for resize object.
May 30 2017, 10:37 PM
conr2d closed D4885: popup: remove previous object when content set NULL by committing rEFL2086530d0798: popup: remove previous object when setting new content (authored by Blackmole).
May 30 2017, 9:30 PM
conr2d accepted D4885: popup: remove previous object when content set NULL.

Popup's all other internal content_set functions (like "_title_icon_set", "_action_button_set") remove previous content object. Moreover, default fallback function (_elm_layout_content_set) also has same behavior. Consistency seems to be more important than backward compatibility in this case.

May 30 2017, 9:12 PM

May 16 2017

conr2d updated the diff for D4705: Genlist: Calculate the min size of content before item realize.

Using private function instead of introducing new widget method

May 16 2017, 10:30 PM

May 7 2017

conr2d updated the diff for D4739: Efl.Observable: Improve observable class.

Fix wrong coding style

May 7 2017, 6:22 PM · efl
conr2d updated the diff for D4739: Efl.Observable: Improve observable class.

Use Rbtree instead of List, change hash to stringshared one and fix minor issues

May 7 2017, 6:16 PM · efl

May 1 2017

conr2d added a comment to T5315: Refactoring Edje/Elm_Layout.

@cedric
Does "Efl.Ui.Layout should compose with Efl.Canvas.Layout." mean efl_composite_attach()? When I wrote patch for that, subclasses inheriting from Elm.Layout cannot override Edje.Object methods.

May 1 2017, 11:23 PM · efl: widgets, Restricted Project

Apr 20 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Keep code style and fix issues

Apr 20 2017, 12:10 AM

Apr 19 2017

conr2d closed D4758: Evas.Table: Apply mirrored correctly when align is set by committing rEFL7ba0707851f7: Evas.Table: Apply mirrored correctly when align is set (authored by conr2d).
Apr 19 2017, 1:13 AM

Apr 18 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Have anchors.margin scaled by default, but not relative offsets

Apr 18 2017, 7:54 AM
conr2d created D4799: Elm.Hoversel: Highlight selected item when auto update is enabled.
Apr 18 2017, 7:28 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Update example with changed syntax

Apr 18 2017, 6:52 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Check edje file version not to break theme ABI by offset scaling

Apr 18 2017, 6:43 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Have relative offsets scaled instead of using separated margins

Apr 18 2017, 6:27 AM
conr2d closed D4769: edje_cc: Clean up repeated code in color setter by committing rEFLe8711baec320: edje_cc: Clean up repeated code in color setter (authored by conr2d).
Apr 18 2017, 3:11 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Using GROUP instead of "" to indicate edje group

Apr 18 2017, 1:01 AM
conr2d closed D4789: edje_cc: add short state handler for part.description.clip_to by committing rEFLaaefd66d0c64: edje_cc: add short state handler for part.description.clip_to (authored by taxi2se).
Apr 18 2017, 12:49 AM
conr2d accepted D4789: edje_cc: add short state handler for part.description.clip_to.

Looks good to me.

Apr 18 2017, 12:47 AM

Apr 17 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Have SWALLOW part work correctly with margins

Apr 17 2017, 5:46 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Apply margins to final geometry only when given edje part is recalculated
(or already applied in previous calculation)

Apr 17 2017, 1:04 AM

Apr 16 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Rebase master and optimize memory allocation

Apr 16 2017, 11:42 PM

Apr 15 2017

conr2d added a comment to D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

I thought that anchors get two arguments, part's name and enum for position, and the second one is omissible. (Because default enum value is given for each anchor)
Your syntax is acceptable, but in the point of which argument can be omitted, can confuse developers in some cases. If "" seems awkward, I think add special reserved word to indicate group like:

anchors.top: GROUP TOP;
anchors.top: GROUP;
Apr 15 2017, 8:51 AM

Apr 14 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Fix transition of part with anchors

Apr 14 2017, 2:44 AM

Apr 13 2017

conr2d closed T5291: Efl.Gfx.Path is broken as Resolved.
Apr 13 2017, 7:09 PM · efl
conr2d added a reviewer for D4787: Efl.Gfx.Path: Fix wrong condition check in _find_ellipsis_coords: Jaehyun_Cho.
Apr 13 2017, 6:11 PM
conr2d added a comment to D4787: Efl.Gfx.Path: Fix wrong condition check in _find_ellipsis_coords.

Apr 13 2017, 2:03 AM
conr2d created D4787: Efl.Gfx.Path: Fix wrong condition check in _find_ellipsis_coords.
Apr 13 2017, 1:54 AM
conr2d claimed T5291: Efl.Gfx.Path is broken.
Apr 13 2017, 1:53 AM · efl

Apr 12 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Position TEXT part with margins correctly after recalc

Apr 12 2017, 6:33 PM
conr2d abandoned D3583: edje: add scale attribute for offset scaling.
Apr 12 2017, 5:49 PM
conr2d added a comment to D3583: edje: add scale attribute for offset scaling.

This feature is merged to D4775.

Apr 12 2017, 5:47 PM
conr2d updated the diff for D4769: edje_cc: Clean up repeated code in color setter.

Recover spacer check before setting description.color2 (removed by mistake)

Apr 12 2017, 8:30 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Remove duplicate code to get scaled margins

Apr 12 2017, 4:17 AM
conr2d added a comment to D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

"Margins" are added in anchors syntax. It works like relative offset, but is scaled by edje scaling factor.
Many spacers can be removed from the theme in general cases. Simple theme for button only requires two parts, swallow (for icon) and text/textblock (for label).

Apr 12 2017, 2:08 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Added "anchors.margins" attribute - scalable offset

Apr 12 2017, 2:04 AM

Apr 10 2017

conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Reset has_relatives correctly when description block is popped from the stack

Apr 10 2017, 3:48 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Add check for usage of relatives before using anchors

Apr 10 2017, 3:17 AM
conr2d added a comment to D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

@zmike
Anchors in embryo will be supported in separated patch.

Apr 10 2017, 2:00 AM
conr2d updated the diff for D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.

Clean up code, update docs and banning from using anchors and relatives at the same time

Apr 10 2017, 1:52 AM

Apr 7 2017

conr2d created D4775: edje_cc: Introduce "Anchors" - easy way to set parts relationship.
Apr 7 2017, 1:29 AM

Apr 6 2017

conr2d added a comment to D4758: Evas.Table: Apply mirrored correctly when align is set.

Replied inline comment.

Apr 6 2017, 1:19 AM
conr2d added a comment to D4751: Elm.Hoversel: Adjust alignment correctly in mirror mode.

Basically hoversel's popup will be expanded right side, but when remaning area in the left side is wider than right, it will be expanded to the left.
However, in mirrored mode, evas geometry is not changed but the direction that edje handles is changed opposedly, this should be considered when changing the direction to where hoversel will be expanded.

Apr 6 2017, 12:52 AM
conr2d closed D4741: Colorclass: Add fixed attribute to remove error message by committing rEFL7383710f345f: Colorclass: Add fixed attribute to remove error message (authored by conr2d).
Apr 6 2017, 12:32 AM

Apr 5 2017

conr2d created D4769: edje_cc: Clean up repeated code in color setter.
Apr 5 2017, 1:17 AM

Apr 3 2017

conr2d added a comment to D4758: Evas.Table: Apply mirrored correctly when align is set.

Apr 3 2017, 1:35 AM
conr2d created D4758: Evas.Table: Apply mirrored correctly when align is set.
Apr 3 2017, 1:34 AM

Mar 27 2017

conr2d created D4751: Elm.Hoversel: Adjust alignment correctly in mirror mode.
Mar 27 2017, 3:55 AM

Mar 26 2017

conr2d updated the diff for D4739: Efl.Observable: Improve observable class.

Check iteration when cleaning observer from observable

Mar 26 2017, 8:51 PM · efl

Mar 24 2017

conr2d created T5291: Efl.Gfx.Path is broken.
Mar 24 2017, 8:09 AM · efl
conr2d closed T4937: hoversel: cannot scroll to proper position as Resolved.

Resolved by D4491.

Mar 24 2017, 8:05 AM · Bug Report, efl
conr2d created D4741: Colorclass: Add fixed attribute to remove error message.
Mar 24 2017, 5:05 AM
conr2d created D4739: Efl.Observable: Improve observable class.
Mar 24 2017, 12:42 AM · efl