Page MenuHomePhabricator

devilhorns (Chris Michael)
Spy

Projects (10)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 1:48 AM (309 w, 4 d)
Availability
Available

Recent Activity

Today

devilhorns requested changes to D7681: ecore-evas/extn: use evas from events when updating key masks.
Tue, Jan 22, 6:15 AM · efl
devilhorns added inline comments to D6138: ecore-evas-drm: Add support for per-output ticking.
Tue, Jan 22, 5:52 AM · efl

Fri, Jan 18

devilhorns added a commit to T6209: elm_code severe lag when selecting text in some files: rEFLec910c5bb9dd: elm_code: Don't update selection if it didn't change.
Fri, Jan 18, 9:35 AM · efl: widgets
devilhorns closed D7693: elm_code: Don't update selection if it didn't change.
Fri, Jan 18, 9:35 AM · efl
devilhorns added a commit to T6209: elm_code severe lag when selecting text in some files: rEFL965cb9d28d18: elm_code: Pass data to status_type_get.
Fri, Jan 18, 9:21 AM · efl: widgets
devilhorns closed D7692: elm_code: Pass data to status_type_get.
Fri, Jan 18, 9:21 AM · efl
devilhorns accepted D7694: elm_code: Pass widget data to _elm_code_widget_fill_line.

This looks ok to me, but my EOAPI knowledge is under the ground lol ;) So I will mark this as accepted by me, but will wait for another reviewer to verify & land

Fri, Jan 18, 9:19 AM · efl
devilhorns accepted D7693: elm_code: Don't update selection if it didn't change.
Fri, Jan 18, 9:15 AM · efl
devilhorns accepted D7692: elm_code: Pass data to status_type_get.
Fri, Jan 18, 9:15 AM · efl

Thu, Jan 17

devilhorns added inline comments to D6139: ecore-drm2: Add API function to clone an output.
Thu, Jan 17, 8:32 AM · efl
devilhorns added inline comments to D6138: ecore-evas-drm: Add support for per-output ticking.
Thu, Jan 17, 7:32 AM · efl
devilhorns added inline comments to D6138: ecore-evas-drm: Add support for per-output ticking.
Thu, Jan 17, 7:02 AM · efl
Herald updated subscribers of D6138: ecore-evas-drm: Add support for per-output ticking.
Thu, Jan 17, 6:30 AM · efl
devilhorns requested review of D7679: ecore-evas-drm: Refactor _ecore_evas_new_internal.
Thu, Jan 17, 6:30 AM · efl
devilhorns added a commit to T7030: efl internals pass null objects to functions which should not be passed null: rEFLc98288c20eba: efl_ui_focus_object: Don't pass NULL to child_focus_set.
Thu, Jan 17, 5:46 AM · efl (efl-1.22), efl: data types, Restricted Project
devilhorns closed D7677: efl_ui_focus_object: Don't pass NULL to child_focus_set.
Thu, Jan 17, 5:46 AM · efl
devilhorns abandoned D6137: ecore-drm2: Pass 'output' as data during atomic commits.

Abandon in favor of D7678

Thu, Jan 17, 5:45 AM · efl
devilhorns abandoned D6135: ecore-drm2: Pass actual output as data to drmModePageFlip and drmModeAtomicCommit functions.

Abandon in favor of D7678

Thu, Jan 17, 5:45 AM · efl
devilhorns requested review of D7678: ecore-drm2: Pass output as data to drmModePageFlip and drmModeAtomicCommit.
Thu, Jan 17, 5:44 AM · efl
devilhorns requested review of D7677: efl_ui_focus_object: Don't pass NULL to child_focus_set.
Thu, Jan 17, 4:57 AM · efl
devilhorns added a revision to T7030: efl internals pass null objects to functions which should not be passed null: D7677: efl_ui_focus_object: Don't pass NULL to child_focus_set.
Thu, Jan 17, 4:57 AM · efl (efl-1.22), efl: data types, Restricted Project

Wed, Jan 16

devilhorns closed D7646: elm_config: Free data returned from eet_read.
Wed, Jan 16, 8:06 AM · efl
devilhorns requested review of D7646: elm_config: Free data returned from eet_read.
Wed, Jan 16, 7:59 AM · efl
devilhorns requested review of D7644: test_efl_anim_interpolator: delete animation event callback on window delete.
Wed, Jan 16, 7:21 AM · efl
devilhorns added a child revision for D7643: test_efl_anim_interpolator: Minor formatting fixes: D7644: test_efl_anim_interpolator: delete animation event callback on window delete.
Wed, Jan 16, 7:21 AM · efl
devilhorns added a revision to T7392: Use after free in elementary_test animation tests: D7644: test_efl_anim_interpolator: delete animation event callback on window delete.
Wed, Jan 16, 7:21 AM · efl (efl-1.22), efl: widgets
devilhorns updated the diff for D7643: test_efl_anim_interpolator: Minor formatting fixes.

no changes

Wed, Jan 16, 7:21 AM · efl
devilhorns updated the diff for D7643: test_efl_anim_interpolator: Minor formatting fixes.
Wed, Jan 16, 7:19 AM · efl
devilhorns updated the diff for D7643: test_efl_anim_interpolator: Minor formatting fixes.

no changes

Wed, Jan 16, 7:18 AM · efl
devilhorns abandoned D7642: test_efl_anim_interpolator: Minor formatting fixes.

Abandon. Going to use git phab instead

Wed, Jan 16, 7:17 AM · efl
devilhorns requested review of D7643: test_efl_anim_interpolator: Minor formatting fixes.
Wed, Jan 16, 7:15 AM · efl
devilhorns requested review of D7642: test_efl_anim_interpolator: Minor formatting fixes.
Wed, Jan 16, 7:10 AM · efl
devilhorns added a revision to T7392: Use after free in elementary_test animation tests: D7642: test_efl_anim_interpolator: Minor formatting fixes.
Wed, Jan 16, 7:10 AM · efl (efl-1.22), efl: widgets

Tue, Jan 15

devilhorns added a comment to T7392: Use after free in elementary_test animation tests.

Ok, I'll try again tomorrow under Weston. Thanks

Tue, Jan 15, 4:18 PM · efl (efl-1.22), efl: widgets

Mon, Jan 14

devilhorns accepted D7621: edje: Remove _edje_animators list.
Mon, Jan 14, 5:13 PM · efl
devilhorns added a comment to T7421: Something is adding ridiculous damage rectangles.

Can anyone confirm that this is still happening ?? I ran some tests here today with some printfs added, and I am not seeing any odd damage rectangles from evas_clip.c anymore...

Mon, Jan 14, 12:41 PM · efl (efl-1.22), regression, efl: canvas
devilhorns updated subscribers of T7076: calendar widget: do not pass NULL to eo methods.

Sadly, it is. I tried to resolve it here: https://phab.enlightenment.org/D6598 but my resolution meet with resistance and someone else ( @CHAN I believe ) sent some patches (which got pushed upstream) to fix the auto-repeat feature ... however, this issue still occurs (just tested it again today)

Mon, Jan 14, 11:50 AM · efl (efl-1.22), efl: data types, Restricted Project
devilhorns added a comment to T7392: Use after free in elementary_test animation tests.

Just for reference, I tested this with git master from today (1/14/2019), and I cannot reproduce this in either X11 or Wayland.

Mon, Jan 14, 11:39 AM · efl (efl-1.22), efl: widgets

Fri, Jan 11

devilhorns accepted D7611: evas_render: Remove some list walks.
Fri, Jan 11, 11:32 AM · efl
devilhorns accepted D7610: ecore_wl2: Convert frame callbacks to inlist.
Fri, Jan 11, 11:31 AM · efl
devilhorns placed T7417: elm: EFL_UI_TEXT_EVENT_CHANGED for the BACKSPACE key emitted too early up for grabs.
Fri, Jan 11, 8:24 AM · efl: widgets
devilhorns closed D7457: elm_map: Add new overlay content to the list of smart members of wigdget.
Fri, Jan 11, 7:14 AM · efl
devilhorns accepted D7457: elm_map: Add new overlay content to the list of smart members of wigdget.

ok yea, I was able to finally get this working and the patch does work as expected :)

Fri, Jan 11, 7:14 AM · efl
devilhorns added a comment to D7457: elm_map: Add new overlay content to the list of smart members of wigdget.

Yes indeed, you could test this with my weather gadget (devs/yoz/e_gadget_weather)
Launch e_gadget_weather_map.
In elm_test none of the overlay are customized with a call to content_set, so we don't see any issue.

Fri, Jan 11, 6:00 AM · efl
devilhorns added a comment to D7457: elm_map: Add new overlay content to the list of smart members of wigdget.

In reviewing this, the code looks ok ... but is there a way to test this specific change ? Within elementary_test Map, I can already add Overlay items to the map and they do show up .... so I am just wondering how to test this specific change.

Fri, Jan 11, 5:14 AM · efl
devilhorns accepted D7592: evas: fix big endian pixman image rendering.

This looks ok to me, but I would await a second opinion before landing

Fri, Jan 11, 5:05 AM · efl

Wed, Jan 9

devilhorns added a member for reviewers: devilhorns.
Wed, Jan 9, 7:30 AM
devilhorns added a comment to T7595: Shadowing internal windows (efm etc.) crashes E on wayland.
Wed, Jan 9, 7:19 AM · Restricted Project, enlightenment-git

Wed, Jan 2

devilhorns added a commit to T7534: Mouse acceleration cannot be disabled on Wayland: rEa0e394b1a55a: conf_interaction: Support mouse acceleration under Wayland.
Wed, Jan 2, 12:17 PM · efl: input, enlightenment_settings, Restricted Project
devilhorns closed T7534: Mouse acceleration cannot be disabled on Wayland as Resolved.

If you update both EFL and E from git, then this issue is fixed now

Wed, Jan 2, 11:58 AM · efl: input, enlightenment_settings, Restricted Project
devilhorns closed D7530: ecore-drm2: Add support for specifying a particular drm card.
Wed, Jan 2, 7:33 AM · efl
devilhorns requested review of D7530: ecore-drm2: Add support for specifying a particular drm card.
Wed, Jan 2, 7:25 AM · efl
devilhorns abandoned D6136: ecore-drm2: Fix drmModeSetCrtc call during fb flip.

Abandon this one as the changes have been pushed into master now

Wed, Jan 2, 7:05 AM · efl
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

Support for elogind has been merged into master now. Please test and if everything is ok, then close this ticket

Wed, Jan 2, 6:05 AM · Restricted Project, enlightenment20

Dec 7 2018

devilhorns accepted D7430: ecore_wl2: remove uniconify path from ecore_wl2_window_iconified_set.
Dec 7 2018, 12:15 PM · efl
devilhorns accepted D7435: ee_wayland: Use object geometry instead of window geometry.
Dec 7 2018, 12:09 PM · efl
devilhorns accepted D7439: ee_wayland: Don't overide server set max/fs size.
Dec 7 2018, 12:08 PM · efl
devilhorns accepted D7438: efl_ui_win: Don't allow the frame object to change size before first draw.
Dec 7 2018, 12:08 PM · efl
devilhorns accepted D7437: ecore_wl2: Return proper geometry when maximized or fullscreened.
Dec 7 2018, 12:07 PM · efl
devilhorns accepted D7436: ecore_wl2: Fix anchor for xdg pop-ups.
Dec 7 2018, 12:06 PM · efl
devilhorns accepted D7434: ecore_evas: Validate shadow geometry.
Dec 7 2018, 12:05 PM · efl
devilhorns accepted D7433: gl_drm: use dlsym looked up symbol for extension check.
Dec 7 2018, 12:05 PM · efl
devilhorns accepted D7432: ee_wayland: Replace set_config.geometry direct use with getters.
Dec 7 2018, 12:04 PM · efl
devilhorns accepted D7431: ecore_wl2: Replace direct usage of set_config.geometry with getters.
Dec 7 2018, 12:03 PM · efl

Dec 6 2018

devilhorns closed T7272: Merge support for elogind as Resolved.
Dec 6 2018, 9:37 AM · Active Work Proposal, major change, efl (efl-1.22)
devilhorns added a commit to T7495: eolian build issue: rEFLb8f96109082e: canvas: disable an eolian-style api reference.
Dec 6 2018, 9:10 AM · Restricted Project, efl (efl-1.22)
devilhorns added a commit to T6804: focus(scroller): backward compatibility for scroller focus move: rEFL68462553d104: elm_scroller: update behaviour to match legacy behaviour more closely.
Dec 6 2018, 9:10 AM · Restricted Project
devilhorns added a commit to T6804: focus(scroller): backward compatibility for scroller focus move: rEFLd24ed5f1d3e7: efl_ui_focus_manager_root_focus: ensure that adapter is part of viewport.
Dec 6 2018, 9:10 AM · Restricted Project
devilhorns added a commit to T7365: eolian: Warn if a regular class appears anywhere other than the first place in an inheritance list: rEFL03001ceaca2a: eolian: add optional warning for regular classes in ext list.
Dec 6 2018, 9:09 AM · Restricted Project, efl
devilhorns added a commit to T7336: Ecore csharp examples are not part of the build: rEFLd90bb5d28cef: csharp: Change to new class API..
Dec 6 2018, 9:09 AM
devilhorns added a commit to T7451: efl-mono: Only expose API methods relevant to the user: rEFLd90bb5d28cef: csharp: Change to new class API..
Dec 6 2018, 9:09 AM · efl: language bindings, efl: docs

Dec 5 2018

devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

I was hoping to merge the elogind support this week as the branch is completed ... but I've not gotten much feedback from testers :(

Dec 5 2018, 9:51 AM · Restricted Project, enlightenment20
devilhorns added a comment to T7409: Terminology does not start on xwayland.

I've seen this before and (iirc) if you "unset DISPLAY" it works .. not sure why tho, could be something in elementary's detection at startup (ie: it sees DISPLAY as being set and tries to run in X11)

Dec 5 2018, 9:49 AM · regression, efl, Terminology

Dec 1 2018

devilhorns accepted D7398: ecore_con: fix multi shutdown excessive warning by initializing ecore independently..
Dec 1 2018, 6:20 AM · efl

Nov 29 2018

devilhorns closed D7305: elementary: Support using no frame object.
Nov 29 2018, 11:35 AM · efl
devilhorns updated the diff for D7305: elementary: Support using no frame object.

Updated patch to re-add back CRI warning

Nov 29 2018, 11:11 AM · efl
devilhorns closed D7357: eldbus: add brackets.
Nov 29 2018, 4:05 AM · efl

Nov 26 2018

devilhorns accepted D7361: ecore_evas_buffer: register it in ecore_evas_input.
Nov 26 2018, 8:29 AM · efl
devilhorns accepted D7357: eldbus: add brackets.
Nov 26 2018, 4:28 AM · efl

Nov 21 2018

devilhorns added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

I just dropped about 27 commits into EFL which changes the evas_object_move & resize calls into One evas_object_geometry_set call (where applicable). I did Not go through Apps and do it tho.

Nov 21 2018, 8:36 AM · Restricted Project, Restricted Project, efl: data types

Nov 20 2018

devilhorns updated the diff for D7305: elementary: Support using no frame object.

fix typo

Nov 20 2018, 3:43 AM · efl
devilhorns updated the diff for D7305: elementary: Support using no frame object.

Update patch to use _elm_config value

Nov 20 2018, 3:41 AM · efl

Nov 19 2018

devilhorns updated the diff for D7305: elementary: Support using no frame object.

Squash commits into one

Nov 19 2018, 5:23 AM · efl
devilhorns added a comment to D7305: elementary: Support using no frame object.

These were supposed to be 2 different commits, but arc bundled them into one ... I don't know why.

Nov 19 2018, 5:21 AM · efl
devilhorns requested review of D7305: elementary: Support using no frame object.
Nov 19 2018, 5:19 AM · efl

Nov 15 2018

devilhorns accepted D7283: eet: Remove unused code.
Nov 15 2018, 2:21 PM · efl
devilhorns closed D7265: ecore_wl2_dnd: initialize source to NULL when it destroy.
Nov 15 2018, 6:11 AM · efl
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

@MAH69K I have updated the above branch (rebased on master), so it is now available for testing. You need to pass --enable-elogind as an option when building

Nov 15 2018, 6:08 AM · Restricted Project, enlightenment20
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

There is also a Phab task already opened for this: https://phab.enlightenment.org/T7272

Nov 15 2018, 5:56 AM · Restricted Project, enlightenment20
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

@MAH69K hello. Yes, current EFL and Enlightenment from git will not work without systemd. There is no support for ELogind yet ... but i have a branch which adds support for it. The branch is here: https://git.enlightenment.org/core/efl.git/log/?h=devs/devilhorns/elput. I need to rebase it against current git (which I will do today). When it is updated, I will post back here and if you would like to test the branch, please let me know your results.

Nov 15 2018, 5:55 AM · Restricted Project, enlightenment20

Nov 14 2018

devilhorns added a comment to T7465: setting "Default Applications" -> "File" to anything messes opening files through mime detection up.

IIRC, main e.cfg stores mime associations. Likely, the problem is that a generic mime type was set for Geany, causing Everything to be opened by it. Agree what that the interface could be improved.

Nov 14 2018, 5:29 PM · enlightenment-git, enlightenment20
devilhorns added a comment to D6870: evas cache image: compare with cached image file.

Cache2 has been removed. Unmaintained and not functional at the time.

Nov 14 2018, 4:49 PM · efl

Nov 13 2018

devilhorns accepted D7265: ecore_wl2_dnd: initialize source to NULL when it destroy.
Nov 13 2018, 3:40 AM · efl

Nov 8 2018

devilhorns accepted D7248: ee_wayland: Set opaque region for alphaless surfaces.
Nov 8 2018, 1:49 PM · efl

Oct 30 2018

devilhorns accepted D7220: ecore_wl2_window: use client window dimension.
Oct 30 2018, 3:59 AM · efl

Oct 24 2018

devilhorns added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

Agreed, which is why I'd be curious where it's getting called from ... smells like a hotpath that could likely be optimized to (at the least) reduce calls to that function

Oct 24 2018, 1:24 PM · Restricted Project, Restricted Project, efl: data types
devilhorns added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

@ManMower does this happen every render cycle ?? I'm curious where & (more importantly) Why eina_array_step_set is constantly being called....

Oct 24 2018, 12:14 PM · Restricted Project, Restricted Project, efl: data types
devilhorns accepted D7205: elementary transit: allow duration change on animatining..
Oct 24 2018, 4:50 AM · efl

Oct 23 2018

devilhorns accepted D7200: elementary transit: add a convenient API..
Oct 23 2018, 4:00 AM · efl

Oct 17 2018

devilhorns accepted D7172: Remove engine check script for direct3d..
Oct 17 2018, 11:14 AM · efl