- User Since
- Feb 15 2013, 1:48 AM (361 w, 2 d)
Fri, Jan 17
Ahhh ok, that makes sense. Thanks.
Thu, Jan 16
Wed, Jan 15
@CHAN I moved the ecore_wl2_window_aux_hint functions to be internal now as they are not used anywhere outside of EFL itself. I also removed the test case for the one function that was there.
This issue is now fixed in Enlightenment git head
Tue, Jan 14
Mon, Jan 13
Thu, Jan 9
@CHAN Ok, I went through the list of API functions here and have found which ones are not done yet. The list of these functions is below. I would suggest making new patches for these because this current patch will certainly not apply cleanly any more. Another suggestion I have is to separate it into a patch for ecore_wl2_window functions, and another patch for ecore_wl2_input functions. An even Better suggestion would be a separate patch for Each Function. This will allow easier review and be easier to follow any comments, suggestions, or discussions that will take place.
Wed, Jan 8
@CHAN I had to revert these tests because they can cause the Ecore_Wl2 test suite to timeout/stall. I executed them here and they would timeout/stall 75% of the time.
Tue, Jan 7
@CHAN The other thing I would like to get your opinion on is: What do you think about using Ecore_Evas inside the Ecore_Wl2 test suite ?? It would allow us to make tests that require user input, and also allow us to check that the window functions are working correctly because it would let us create an actual window, without having to specifically need EGL/GL.
@CHAN The buffer API functions where moved to be internal because they were not being used anywhere else other than inside EFL itself.
Mon, Jan 6
@CHAN This looks good to me now, thanks for the changes :)
Fri, Jan 3
One little minor fix needed.
Wed, Jan 1
Dec 20 2019
@CHAN The issue with this is because Ecore_Wl2 does not actually handle any drawing. If we used Ecore_Evas in this test suite, then it would be a simple thing to do. However, Ecore_Wl2 window does not handle any actual rendering so in order to get it to "draw" a window, we would need to manually create a wl_buffer and attach it to an Ecore_Wl2 window. After doing that, it is still problematic because there is no rendering loop in Ecore_Wl2, so getting any changes to draw in the Ecore_Wl2 window would require a lot of code...
Dec 16 2019
Dec 11 2019
Dec 10 2019
This looks fine, go ahead and push it
This looks ok to me ... but I honestly did not read Every line to double check the email addresses
Dec 9 2019
I hate to be a pain here, but our usual convention is to put the EINA_UNUSED after the parameter ...
@CHAN To be honest, I am unsure. Aux Hints support was something that mike added. I will take a look through the code and see if I can find out how it is meant to be used.
Dec 6 2019
Dec 3 2019
Looks good to me, but lets get one more sign-off to be sure
This patch is no longer needed as I have moved the buffer_transform function to be internal. It is unused outside of EFL internals
This patch is no longer needed as I moved the buffer_attach function to be internal
Dec 2 2019
@CHAN Sadly I do not have any better idea to test the window_free function :( It does not return a boolean or anything that we can compare