Page MenuHomePhabricator

devilhorns (Christopher Michael)
Spy

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 1:48 AM (371 w, 4 d)
Availability
Available

Recent Activity

Tue, Mar 24

devilhorns accepted D11572: edje_cc: free ecore_evas.
Tue, Mar 24, 8:11 AM · efl
devilhorns accepted D11567: edje_cc: free ecore_evas.
Tue, Mar 24, 8:10 AM · efl
devilhorns resigned from D11561: Wallpaper/Theme Selector - add button for online themes/wallpapers using extra (extra.e.org).
Tue, Mar 24, 5:58 AM · enlightenment-git

Fri, Mar 13

devilhorns accepted D11503: efl/gesture: remove duplicated line.
Fri, Mar 13, 5:32 AM · efl

Thu, Mar 12

devilhorns added inline comments to D11494: efl/gesture: add fallback for glayer_tap_finger_size not being found.
Thu, Mar 12, 11:26 AM · efl

Tue, Mar 10

devilhorns added a comment to D11482: evas_textblock: replace evil tabs with spaces.

I can't land this without losing author information (don't have arc installed on this box), but feel free to push this.

Tue, Mar 10, 10:11 AM · efl
devilhorns accepted D11482: evas_textblock: replace evil tabs with spaces.
Tue, Mar 10, 10:11 AM · efl

Mon, Mar 9

devilhorns accepted D11477: add EFL_VERSION_1_24 define.
Mon, Mar 9, 10:39 AM · efl

Fri, Mar 6

devilhorns awarded D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used a Like token.
Fri, Mar 6, 1:27 PM · efl
devilhorns accepted D11471: edje_legacy: Remove EINA_UNUSED when obj is actually used.

Looked through the code, and you are correct :) .. Patch approved however I cannot push it because I don't have arc installed on this box. @bu5hm4n - Can you push this please when you have a chance ? Thanks :)

Fri, Mar 6, 1:25 PM · efl
devilhorns closed D11450: evas_object_intercept: Use efl_data_scope_safe_get.
Fri, Mar 6, 4:32 AM · efl
devilhorns closed D11449: evas_object_intercept: Reduce calls to efl_data_scope_get.
Fri, Mar 6, 4:32 AM · efl

Thu, Mar 5

devilhorns accepted D11452: elm: undef EAPI_WEAK in header before defining.
Thu, Mar 5, 12:11 PM · efl
devilhorns accepted D11453: efl-wl: properly send surface enter event in smart show.
Thu, Mar 5, 12:10 PM · efl
devilhorns requested review of D11450: evas_object_intercept: Use efl_data_scope_safe_get.
Thu, Mar 5, 5:56 AM · efl
devilhorns added a child revision for D11449: evas_object_intercept: Reduce calls to efl_data_scope_get: D11450: evas_object_intercept: Use efl_data_scope_safe_get.
Thu, Mar 5, 5:56 AM · efl
devilhorns requested review of D11449: evas_object_intercept: Reduce calls to efl_data_scope_get.
Thu, Mar 5, 5:56 AM · efl

Tue, Mar 3

devilhorns accepted D11444: efl-wl: add toplevel_added event for adding a new toplevel surface.
Tue, Mar 3, 10:23 AM · efl
devilhorns accepted D11443: efl-wl: ensure that child_added event is called only when a parent is set.
Tue, Mar 3, 10:11 AM · efl
devilhorns accepted D11329: ecore_evas: introduce wayland support for cnp & dnd.
Tue, Mar 3, 10:10 AM · efl
devilhorns accepted D11438: efl-wl: add function to get pid of a surface.
Tue, Mar 3, 8:46 AM · efl

Feb 27 2020

devilhorns added inline comments to D11429: exactness: check success of mkdir.
Feb 27 2020, 8:30 AM · efl
devilhorns requested changes to D11429: exactness: check success of mkdir.

This function returns 0 on success, not failure.

Feb 27 2020, 6:52 AM · efl
devilhorns accepted D11429: exactness: check success of mkdir.
Feb 27 2020, 5:34 AM · efl

Feb 16 2020

devilhorns accepted D11193: ecore_x: add API to request selection changed events for diff. wins.

Well, if we don't care about doxygen for newly added APIs, then this looks ok to me

Feb 16 2020, 6:22 AM · efl

Feb 14 2020

devilhorns requested changes to D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.
Feb 14 2020, 7:34 AM · efl

Feb 12 2020

devilhorns requested changes to D11193: ecore_x: add API to request selection changed events for diff. wins.
Feb 12 2020, 12:49 PM · efl
devilhorns requested changes to D11329: ecore_evas: introduce wayland support for cnp & dnd.
Feb 12 2020, 12:46 PM · efl

Feb 7 2020

devilhorns placed T8053: elementary crash when running under wayland up for grabs.
Feb 7 2020, 5:29 AM · efl: display system, Restricted Project
devilhorns abandoned D7881: wayland: Rename ecore_wl2 to notstable.
Feb 7 2020, 5:27 AM · DO NOT MERGE, efl
devilhorns commandeered D7881: wayland: Rename ecore_wl2 to notstable.
Feb 7 2020, 5:26 AM · DO NOT MERGE, efl

Jan 29 2020

devilhorns added a comment to T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)?.

From a compiler stand point, I do not think that it actually makes a difference ... tho that Could depend on the compiler. It's been EFL preference that they come After so if you would like to make some patches to fix those, that would be great.

Jan 29 2020, 7:33 AM · efl
devilhorns closed D11226: ecore_wl2: Fix doc(delete tags)..
Jan 29 2020, 6:01 AM · efl
devilhorns closed D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 29 2020, 6:01 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL0bf3fd386613: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 29 2020, 6:01 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLba3fbb566760: tests/ecore_wl2: Fix check for Enlightenment compositor.
Jan 29 2020, 6:00 AM · Restricted Project, efl
devilhorns accepted D11226: ecore_wl2: Fix doc(delete tags)..
Jan 29 2020, 6:00 AM · efl
devilhorns accepted D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 29 2020, 6:00 AM · efl
devilhorns added a comment to T8591: What is the correct/wanted way to use EINA_UNUSED? Before or after var declaration (function arguments)?.

Normally, we use it After the variable

Jan 29 2020, 5:54 AM · efl

Jan 28 2020

devilhorns requested changes to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Jan 28 2020, 4:42 AM · efl

Jan 27 2020

devilhorns requested changes to D11203: ecore_input_evas: move in multi when in multi config.
Jan 27 2020, 9:00 AM · efl
devilhorns closed D11200: ecore_wl2: do not silently return.
Jan 27 2020, 8:22 AM · efl
devilhorns closed D11199: ecore_wl2: only ungrab/grab on last/first down/up event.
Jan 27 2020, 8:22 AM · efl
devilhorns accepted D11200: ecore_wl2: do not silently return.
Jan 27 2020, 8:18 AM · efl
devilhorns accepted D11199: ecore_wl2: only ungrab/grab on last/first down/up event.
Jan 27 2020, 8:17 AM · efl

Jan 22 2020

devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL55118cac119d: tests/ecore_wl2: Add test for ecore_wl2_input_keyboard_repeat functions.
Jan 22 2020, 5:36 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 22 2020, 5:36 AM · Restricted Project, efl
devilhorns closed D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal".
Jan 22 2020, 4:43 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL0bf03036b7c3: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 22 2020, 4:43 AM · Restricted Project, efl
devilhorns closed D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 22 2020, 4:43 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLe23dc58e200e: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Jan 22 2020, 4:43 AM · Restricted Project, efl
devilhorns closed D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Jan 22 2020, 4:43 AM · efl
devilhorns closed D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..
Jan 22 2020, 4:42 AM · efl
devilhorns closed D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..
Jan 22 2020, 4:42 AM · efl
devilhorns accepted D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..
Jan 22 2020, 4:41 AM · efl
devilhorns accepted D11154: Revert "ecore-wl2: Move ecore_wl2_window_output_find function to be internal".
Jan 22 2020, 4:40 AM · efl
devilhorns accepted D11150: tests/ecore_wl2: Add tests for move, resize, resizing_get functions..
Jan 22 2020, 4:40 AM · efl
devilhorns accepted D11147: Revert "ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal".
Jan 22 2020, 4:38 AM · efl
devilhorns accepted D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..
Jan 22 2020, 4:35 AM · efl

Jan 21 2020

devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLaeb2b506fdd6: tests/ecore_wl2: Fix issue of tests running without a Wayland display.
Jan 21 2020, 10:05 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL6a1d6b670591: ecore-wl2: Move ecore_wl2_input_cursor_from_name_set to be internal.
Jan 21 2020, 7:09 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLe34b338f719e: ecore-wl2: Move ecore_wl2_display_terminate to be internal.
Jan 21 2020, 7:09 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.
In T8016#149704, @CHAN wrote:

ecore_wl2_display_terminate(display);
ecore_wl2_input_cursor_from_name_set(input, cursor);
ecore_wl2_session_recovery_disable();

  • Internal? what do you think? if you agree with that i will put on a patch for this.
Jan 21 2020, 7:06 AM · Restricted Project, efl
devilhorns closed D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Jan 21 2020, 5:21 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL87be474bb542: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Jan 21 2020, 5:21 AM · Restricted Project, efl
devilhorns accepted D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Jan 21 2020, 5:20 AM · efl
devilhorns requested changes to D11132: ecore_wl2: Add ecore_wl2_input_default_input_get() API..
Jan 21 2020, 5:11 AM · efl
devilhorns added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
In D11111#210978, @CHAN wrote:

@devilhorns Thanks you for giving advise here.

Yes i agree with that.
But the some of APIs are has been designed only for Enlightenment (Some of interface missing.)
It was difficult to handle APIs with different input ids or difficult to verify operation because the registry was not supported.
therefore, i meant that TC should be written based on Enlightenment first anyways...

Jan 21 2020, 5:10 AM · efl
devilhorns added a comment to D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

@CHAN Ok, that makes sense then. Thank you for explaining. There is one small change that is needed tho ... the API should be @since 1.24

Jan 21 2020, 5:09 AM · efl

Jan 20 2020

devilhorns added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
In D11111#210703, @CHAN wrote:

@devilhorns Thank you.

Um... in my env it passes all.

(ERR<1169>:ecore_wl2 ../src/lib/ecore_wl2/ecore_wl2_input.c:1612 _ecore_wl2_input_add() id = 10)

100%: Checks: 7, Failures: 0, Errors: 0
100%: Checks: 10, Failures: 0, Errors: 0
100%: Checks: 22, Failures: 0, Errors: 0

It seems to have different values for different versions and environments.
It's better to make it meaningful only in the enlightenment environment.

Jan 20 2020, 11:49 AM · efl
devilhorns requested changes to D11131: ecore_wl2: Add ecore_wl2_input_keyboard_repeat_set() API..

@CHAN I don't really see the need for "input->repeat.changed". We can just set the input repeat rate & delay regardless of changed or not

Jan 20 2020, 11:41 AM · efl

Jan 17 2020

devilhorns added a comment to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..

Ahhh ok, that makes sense. Thanks.

Jan 17 2020, 5:47 AM · efl

Jan 16 2020

devilhorns requested changes to D11111: tests/ecore_wl2: Code clean up and Add, Modify TCs..
Jan 16 2020, 7:05 AM · efl

Jan 15 2020

devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 15 2020, 8:05 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLe2ba3328666c: tests/ecore_wl2: Add test for ecore_wl2_input_pointer_xy_get function.
Jan 15 2020, 8:04 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 15 2020, 8:04 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.

@CHAN I moved the ecore_wl2_window_aux_hint functions to be internal now as they are not used anywhere outside of EFL itself. I also removed the test case for the one function that was there.

Jan 15 2020, 7:23 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL4c232f12d718: tests/ecore_wl2: Remove test of ecore_wl2_window_hint_aux functions.
Jan 15 2020, 7:19 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLae8673628d47: ecore-wl2: Move ecore_wl2_window_aux hint functions to be internal.
Jan 15 2020, 7:19 AM · Restricted Project, efl
devilhorns added a commit to T8553: VSynced checkbox allows toggle to "enabled" when in" software mode": rEad68b074042b: e_int_config_comp: Disable OpenGL options when selecting Software engine.
Jan 15 2020, 6:36 AM · enlightenment-git
devilhorns added a commit to T8553: VSynced checkbox allows toggle to "enabled" when in" software mode": rE16040d449219: e_int_config_comp: Disable VSync checkbox if we are using Software engine.
Jan 15 2020, 6:36 AM · enlightenment-git
devilhorns closed T8553: VSynced checkbox allows toggle to "enabled" when in" software mode" as Resolved.

This issue is now fixed in Enlightenment git head

Jan 15 2020, 6:36 AM · enlightenment-git
devilhorns added a commit to T8553: VSynced checkbox allows toggle to "enabled" when in" software mode": rE754a2d4f9326: e_int_config_comp: Don't enable VSync checkbox if we are using software engine.
Jan 15 2020, 6:36 AM · enlightenment-git
devilhorns added a commit to T8553: VSynced checkbox allows toggle to "enabled" when in" software mode": rE468c46d850f1: e_int_config_comp: Don't display vsync checkbox if opengl is not supported..
Jan 15 2020, 6:36 AM · enlightenment-git

Jan 14 2020

devilhorns closed D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.
Jan 14 2020, 5:35 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL2010c2ce132a: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.
Jan 14 2020, 5:35 AM · Restricted Project, efl
devilhorns accepted D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.
Jan 14 2020, 5:32 AM · efl

Jan 13 2020

devilhorns added a comment to D11007: tests/ecore_wl2: Add test for ecore_wl2_window_xxx functions.
In D11007#209238, @CHAN wrote:

@devilhorns

Yes in weston my sample app is not work.

When i tried to launch sample app the log said.

"zxdg_surfacc_v6@16: error 3: xdg_surface has never been configured. "
"_begin_recovery_maybe() Wayland Socket Error: Protocol error "

in enlightenement there is a "xdg_wm_base" value in global interface.
but weston there is no "xdg_wm_base" value in global interface.

Any idea about it?
i will try to figure out what is going on here.
Um... but i think the ecore_wl2 is not works well on weston.
weston doesn't have efl only protocols...
i dont have many experience about it though...
anyway i will look around more.

Please give me any advise for this.

I just run enlightenment_start and build efl on enlightenment then run the TC and sample test apps.

Thanks.

Jan 13 2020, 8:43 AM · efl

Jan 9 2020

devilhorns added a comment to D9215: ecore_wl2: add new APIs.

@CHAN Ok, I went through the list of API functions here and have found which ones are not done yet. The list of these functions is below. I would suggest making new patches for these because this current patch will certainly not apply cleanly any more. Another suggestion I have is to separate it into a patch for ecore_wl2_window functions, and another patch for ecore_wl2_input functions. An even Better suggestion would be a separate patch for Each Function. This will allow easier review and be easier to follow any comments, suggestions, or discussions that will take place.

Jan 9 2020, 8:14 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL83a291604399: tests/ecore_wl2: Remove test the ecore_wl2_window_output_find.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL64dacb3d07f6: ecore-wl2: Move ecore_wl2_window_output_find function to be internal.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLd0845de6b36c: tests/ecore_wl2: Simplify test infrastructure.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLeafed87ffd70: ecore-wl2: Move ecore_wl2_subsurface functions to be internal.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLe3a28ecd1e74: ecore-wl2: Move ecore_wl2_offer functions to be internal.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLb3114e2484d8: ecore-wl2: Move ecore_wl2_dnd functions to be internal.
Jan 9 2020, 7:57 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.
In T8016#149233, @CHAN wrote:

@devilhorns

Now the ecore_wl2_output_find failed.

output list gets a value when _surface_enter() being called.

According to wl doc
(This is emitted whenever a surface's creation, movement, or resizing results in some part of it being within the scan out region of an output.
Note that a surface may be overlapping with zero or more outputs. )

It should be called if i create a win and move it. but its not called...

any idea about it?

I took a look into this ... and from what I can see going on, the issue is that we never get the _surface_enter event. This could be due to the surface Not Actually being shown on screen ... but I am not 100% sure yet and will keep digging into it

Jan 9 2020, 7:55 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Jan 9 2020, 7:17 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.
In T8016#149293, @CHAN wrote:

@devilhorns

Thanks for giving me an answer and adding a new TC.

I have a question about other APIs.

ecore_wl2_dnd and ecore_wl2_offer APIs looks that support Copy & Paste between or within windows using wl protocol.
If then, I wonder if these APIs will be usable when open to the public. Tizen also uses only internal modules.

ecore_wl2_subsurface APIs...
These APIs are hard to determine for what usability.
Could you please tell me more about what these APIs are used for? In Tizen there is no case used.

I will have to take a look at where the dnd, offer, and subsurface functions are used in our codebase. It is possible that some of these can be moved to Internal functions.

Jan 9 2020, 7:05 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.
In T8016#149295, @CHAN wrote:

@devilhorns

input = ecore_wl2_display_input_find_by_name(disp, "default);

You added above line in TC.
In my env the value is "seat0" instead of "default".
So it failed.

Do we work on different env?

I can change it to be "seat0", that's no problem

Jan 9 2020, 6:49 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.
In T8016#149293, @CHAN wrote:

@devilhorns

Thanks for giving me an answer and adding a new TC.

I have a question about other APIs.

ecore_wl2_dnd and ecore_wl2_offer APIs looks that support Copy & Paste between or within windows using wl protocol.
If then, I wonder if these APIs will be usable when open to the public. Tizen also uses only internal modules.

ecore_wl2_subsurface APIs...
These APIs are hard to determine for what usability.
Could you please tell me more about what these APIs are used for? In Tizen there is no case used.

Jan 9 2020, 6:09 AM · Restricted Project, efl