Page MenuHomePhabricator

devilhorns (Chris Michael)
Spy

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 1:48 AM (352 w, 5 d)
Availability
Available

Recent Activity

Yesterday

devilhorns added a comment to D9215: ecore_wl2: add new APIs.

I have merged some of these API functions today, so this patch will most certainly not apply cleanly anymore. There are still a few APIs on this that are not in upstream yet (mostly cursor APIs, and the input rectangle one).

Tue, Nov 19, 7:00 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL8195368929be: tests/ecore_wl2: Add test for ecore_wl2_window_type functions.
Tue, Nov 19, 6:45 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 19, 6:44 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLdd74c6ed35e2: tests/ecore_wl2: Add test for ecore_wl2_window_geometry functions.
Tue, Nov 19, 5:52 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 19, 5:45 AM · Restricted Project, efl

Fri, Nov 15

devilhorns closed D10683: gl_drm: remove dead return statement.
Fri, Nov 15, 8:56 AM · efl
devilhorns closed D10682: examples: efl_exe: fix out of bounds write.
Fri, Nov 15, 8:55 AM · efl
devilhorns accepted D10682: examples: efl_exe: fix out of bounds write.
Fri, Nov 15, 8:53 AM · efl
devilhorns accepted D10683: gl_drm: remove dead return statement.
Fri, Nov 15, 8:52 AM · efl

Tue, Nov 12

devilhorns added a comment to D9215: ecore_wl2: add new APIs.

@eagleeye @CHAN This patch will need to be rebased before anything can be done with it due to the Ecore_Wl2.h changes

Tue, Nov 12, 7:12 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 7:09 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL5b588c3c39a4: tests/ecore_wl2: Add test for ecore_wl2_window_wm_rotation_supported functions.
Tue, Nov 12, 7:09 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 7:06 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 7:04 AM · Restricted Project, efl
devilhorns added a comment to T8016: Write test cases for Ecore_Wl2 API.

@CHAN I added some more tests today and marked them off the list, However there is an issue with some of these functions (ones I marked with ?? at the end). Basically, I don't see how we can write tests for these functions because they only support a 'set'. As an example, ecore_wl2_window_class_set function ... We can make a test which executes that function, but we have no way to verify that the class actually gets set...

Tue, Nov 12, 7:03 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 7:01 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL96e148b2310e: tests/ecore_wl2: Modify ecore_wl2_window_rotation test.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL821352458395: tests/ecore_wl2: Add test for ecore_wl2_window_rotation_app functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLeb7816c72792: tests/ecore_wl2: Add test for ecore_wl2_window_preferred_rotation functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL67995823fd28: tests/ecore_wl2: Add test for ecore_wl2_window_maximized functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL52299bffa0e5: tests/ecore_wl2: Add test for ecore_wl2_window_focus_skip_get/set functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL239549deec2a: tests/ecore_wl2: Add test for ecore_wl2_window_fullscreen functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL17919040b6d9: tests/ecore_wl2: Add test for ecore_wl2_window_floating_mode_get/set functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL1357171d569a: tests/ecore_wl2: Add test for ecore_wl2_window_alpha_get/set functions.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLfb718059256e: tests/ecore_wl2: Add test for ecore_wl2_display_compositor_version_get.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 6:59 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 6:24 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 6:21 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 12, 6:20 AM · Restricted Project, efl

Tue, Nov 5

devilhorns added a comment to D9215: ecore_wl2: add new APIs.

This will likely need to be rebased against EFL master due to the Ecore_Wl2.h file changes

Tue, Nov 5, 6:23 PM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL4068d1c5be2f: tests/ecore-wl2: Remove surface test.
Tue, Nov 5, 6:50 AM · Restricted Project, efl
devilhorns added a comment to T8014: Document Ecore_Wl2 API.

I believe this task is now finished. All of the API functions inside Ecore_Wl2.h are now documented upstream. I will leave this ticket open for now in case more API gets added shortly.

Tue, Nov 5, 6:49 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL40f10e204ac1: ecore-wl2: Move ecore_wl2_surface_alpha_get function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLca3d6f0e7fe9: ecore-wl2: Move ecore_wl2_surface_window_get function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL2069181bae26: ecore-wl2: Move ecore_wl2_surface_manager_del function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL132851bc4ee2: ecore-wl2: Move ecore_wl2_surface_buffer_create function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL8d6b40969940: ecore-wl2: Move ecore_wl2_surface_manager_add function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL58e06a4740b1: ecore-wl2: Move ecore_wl2_surface_flush function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL307837d1991d: ecore-wl2: Move ecore_wl2_window_surface_flush function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLc333022f0bdf: ecore-wl2: Move ecore_wl2_surface_post function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL49498f798bb6: ecore-wl2: Move ecore_wl2_surface_assign function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLe451a9127019: ecore-wl2: Move ecore_wl2_surface_data_get function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL25691ce647eb: ecore-wl2: Move ecore_wl2_surface_reconfigure function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL752b541e6c34: ecore-wl2: Move ecore_wl2_surface_destroy function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL262598773a95: ecore-wl2: Move ecore_wl2_surface_create function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLa40dabd9e028: ecore-wl2: Move ecore_wl2_buffer_age_inc function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL97dca40f6a69: ecore-wl2: Move ecore_wl2_buffer_age_set function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLecd7a2c3c651: ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL2dc751eb09ee: ecore-wl2: Move ecore_wl2_buffer_age_get function to be internal.
Tue, Nov 5, 6:38 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL431a5578daab: ecore-wl2: Move ecore_wl2_buffer_busy_get function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLe1208ca31fac: ecore-wl2: Move ecore_wl2_buffer_destroy function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL400ed3f3c400: ecore-wl2: Move ecore_wl2_buffer_lock function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLf22e8b4270ae: ecore-wl2: Move ecore_wl2_buffer_unlock function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLad692d2cbd38: ecore-wl2: Move ecore_wl2_buffer_discard function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL694df8f823cc: ecore-wl2: Move ecore_wl2_buffer_unmap function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL480390d8626c: ecore-wl2: Move ecore_wl2_buffer_map function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLdf15c774b86a: ecore-wl2: Move ecore_wl2_buffer_destroy function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL5f3a67945e5e: ecore-wl2: Move ecore_wl2_buffer_wl_buffer_get function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFLffab0f77a47c: ecore-wl2: Move ecore_wl2_buffer_create function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL848743f70db4: ecore-wl2: Move ecore_wl2_buffer_init function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl
devilhorns added a commit to T8013: Stabilize Ecore_Wl2 API: rEFL8ffd0b766145: ecore-wl2: Move ecore_wl2_window_damage function to be internal.
Tue, Nov 5, 6:37 AM · Restricted Project, efl

Wed, Oct 30

devilhorns closed D10563: elm/widget: error on null params for tree_unfocusable functions.
Wed, Oct 30, 6:29 AM · efl
devilhorns accepted D10563: elm/widget: error on null params for tree_unfocusable functions.
Wed, Oct 30, 6:27 AM · efl
devilhorns closed D10561: edje_calc: Remove unused flag..
Wed, Oct 30, 5:09 AM · efl
devilhorns accepted D10561: edje_calc: Remove unused flag..
Wed, Oct 30, 5:03 AM · efl

Tue, Oct 29

devilhorns closed D10557: eina: add comparison macros for Eina_Size2D and Eina_Position2D.
Tue, Oct 29, 11:51 AM · efl
devilhorns accepted D10557: eina: add comparison macros for Eina_Size2D and Eina_Position2D.

Looks fine here

Tue, Oct 29, 11:49 AM · efl
devilhorns added a comment to D9215: ecore_wl2: add new APIs.
In D9215#193877, @CHAN wrote:

ecore_wl2_window_input_rect_set(Ecore_Wl2_Window *win, Eina_Rectangle *input_rect)
ecore_wl2_window_input_rect_add(Ecore_Wl2_Window *win, Eina_Rectangle *input_rect)
ecore_wl2_window_input_rect_subtract(Ecore_Wl2_Window *win, Eina_Rectangle *input_rect)

Those APIs created for two or more input areas.

Anyways, In contrast to ecore_wl2_window_input_rect_set(), the ecore_wl2_window_input_region_set() has additional features. (pending update.)
So now those two APIs has a bit different behavior.

We can use ecore_wl2_window_input_region_set() instead of ecore_wl2_window_input_rect_set(),
if there is no pending update feature in the ecore_wl2_window_input_region_set() API or if we support it.

@devilhorns Do we need to update it asynchronously(pending)? if so, we need a ecore_wl2_window_input_rect_set() API. and any opinion about it?

Tue, Oct 29, 5:28 AM · Restricted Project, efl

Oct 15 2019

devilhorns accepted D10397: benchmarks/eina: fix possible div by zero in ecore_hash.
Oct 15 2019, 9:29 PM · efl
devilhorns accepted D10414: tests/ecore: replace all bespoke strcats with snprintf.
Oct 15 2019, 9:26 PM · efl
devilhorns accepted D10389: evas/language: #ifdef guard variable which is only used inside #ifdef.
Oct 15 2019, 9:24 PM · efl
devilhorns accepted D10390: tests/eldbus: add va_end for va_args usage in message test.

I would have preferred a more descriptive error message, but since this is just in a test it's fine.

Oct 15 2019, 9:23 PM · efl
devilhorns accepted D10393: ecore/getopt: handle negative return in arg parsing.
Oct 15 2019, 9:22 PM · efl
devilhorns accepted D10394: ecore/main: avoid calling FD_SET with invalid fd value.
Oct 15 2019, 9:21 PM · efl
devilhorns accepted D10405: tests: fix minor string leaks.
Oct 15 2019, 9:21 PM · efl

Oct 1 2019

devilhorns closed T7089: evas_vg_batman example doesn't run under weston as Resolved.

This is working now. Fixed by commit https://git.enlightenment.org/core/efl.git/commit/?id=13ecc4898c23aa58421a847efbe5392d2b18cef8

Oct 1 2019, 8:18 AM · efl (efl-1.23), Restricted Project, efl: rendering

Sep 27 2019

devilhorns closed D10229: elm_test: undef logging macros before redefining them in header.
Sep 27 2019, 11:33 AM · efl
devilhorns accepted D10229: elm_test: undef logging macros before redefining them in header.
Sep 27 2019, 11:21 AM · efl

Sep 26 2019

devilhorns closed D10013: ecore-x: add internal function for selecting just properties of root window.
Sep 26 2019, 8:23 AM · efl
devilhorns closed D10014: ecore-x: protect against accidentally "un-managing" the root window.
Sep 26 2019, 8:23 AM · efl
devilhorns added a commit to T7838: Regression display application without window manager.: rEFLfddc27ed4041: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Sep 26 2019, 8:23 AM · regression, efl, Bug Report
devilhorns closed D9900: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Sep 26 2019, 8:23 AM · efl
devilhorns closed D10012: ecore-x: track whether ecore-x is internally "managing" the root window.
Sep 26 2019, 8:23 AM · efl
devilhorns closed D9899: ecore-x: fix null derefs in window prop code.
Sep 26 2019, 8:22 AM · efl
devilhorns accepted D10012: ecore-x: track whether ecore-x is internally "managing" the root window.
Sep 26 2019, 8:20 AM · efl

Sep 25 2019

devilhorns requested changes to D10012: ecore-x: track whether ecore-x is internally "managing" the root window.

I would think these should use EINA_TRUE, EINA_FALSE for consistency, yes ??

Sep 25 2019, 1:21 PM · efl
devilhorns accepted D9900: ecore-evas/x: detect and track wm existence, apply visibility correctly.

Ah ok, no worries then

Sep 25 2019, 1:20 PM · efl
devilhorns requested changes to D9900: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Sep 25 2019, 12:48 PM · efl
devilhorns accepted D10014: ecore-x: protect against accidentally "un-managing" the root window.
Sep 25 2019, 12:43 PM · efl
devilhorns accepted D10013: ecore-x: add internal function for selecting just properties of root window.
Sep 25 2019, 12:42 PM · efl
devilhorns requested changes to D10012: ecore-x: track whether ecore-x is internally "managing" the root window.

Seems to me this could just use a bool rather than an int...

Sep 25 2019, 12:41 PM · efl
devilhorns accepted D9899: ecore-x: fix null derefs in window prop code.
Sep 25 2019, 11:37 AM · efl

Sep 23 2019

devilhorns lowered the priority of T7089: evas_vg_batman example doesn't run under weston from Showstopper Issues to Normal.
Sep 23 2019, 5:53 AM · efl (efl-1.23), Restricted Project, efl: rendering
devilhorns added a comment to T7089: evas_vg_batman example doesn't run under weston.

@stefan_schmidt I tested this with everything updated this morning. It works just fine when using software rendering, however when I try to test with gl rendering, nothing works .... not even elementary_test :( so I am unsure what to do here.

Sep 23 2019, 5:47 AM · efl (efl-1.23), Restricted Project, efl: rendering

Sep 19 2019

devilhorns added a comment to T7089: evas_vg_batman example doesn't run under weston.

@stefan_schmidt Yes, I am actively looking into this. Apologies for missing your message on the 13th, but for some odd reason, I did not get a Phab email about it :(

Sep 19 2019, 7:45 AM · efl (efl-1.23), Restricted Project, efl: rendering

Sep 17 2019

devilhorns accepted D9215: ecore_wl2: add new APIs.

Great work !! :) We cannot push this upstream yet tho because of the freeze for 1.23 release. After the freeze is over, I will push these changes.

Sep 17 2019, 6:11 AM · Restricted Project, efl

Sep 16 2019

devilhorns added a comment to T8212: efl.1.23-alpha1 can't be compiled with meson -Deeze=false.

eeze is Required for ecore_drm2 so the answer is No, it was never supported to build drm without eeze

Sep 16 2019, 9:32 AM · Restricted Project

Sep 11 2019

devilhorns closed D9868: Updating Meson build Wayland conditional to match Makefile.
Sep 11 2019, 5:30 AM · enlightenment-git
devilhorns accepted D9868: Updating Meson build Wayland conditional to match Makefile.
Sep 11 2019, 5:30 AM · enlightenment-git

Sep 5 2019

devilhorns added a commit to T8014: Document Ecore_Wl2 API: rEFLee0023055f76: ecore-wl2: Update doxygen for various functions.
Sep 5 2019, 5:22 AM · Restricted Project, efl