Page MenuHomePhabricator

devilhorns (Chris Michael)
Spy

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 1:48 AM (300 w, 1 d)
Availability
Available

Recent Activity

Thu, Nov 15

devilhorns accepted D7283: eet: Remove unused code.
Thu, Nov 15, 2:21 PM · efl
devilhorns closed D7265: ecore_wl2_dnd: initialize source to NULL when it destroy.
Thu, Nov 15, 6:11 AM · efl
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

@MAH69K I have updated the above branch (rebased on master), so it is now available for testing. You need to pass --enable-elogind as an option when building

Thu, Nov 15, 6:08 AM · Restricted Project, enlightenment20
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

There is also a Phab task already opened for this: https://phab.enlightenment.org/T7272

Thu, Nov 15, 5:56 AM · Restricted Project, enlightenment20
devilhorns added a comment to T6947: Can't run enlightenment with wayland as user.

@MAH69K hello. Yes, current EFL and Enlightenment from git will not work without systemd. There is no support for ELogind yet ... but i have a branch which adds support for it. The branch is here: https://git.enlightenment.org/core/efl.git/log/?h=devs/devilhorns/elput. I need to rebase it against current git (which I will do today). When it is updated, I will post back here and if you would like to test the branch, please let me know your results.

Thu, Nov 15, 5:55 AM · Restricted Project, enlightenment20

Wed, Nov 14

devilhorns added a comment to T7465: setting "Default Applications" -> "File" to anything messes opening files through mime detection up.

IIRC, main e.cfg stores mime associations. Likely, the problem is that a generic mime type was set for Geany, causing Everything to be opened by it. Agree what that the interface could be improved.

Wed, Nov 14, 5:29 PM · enlightenment-git, enlightenment20
devilhorns added a comment to D6870: evas cache image: compare with cached image file.

Cache2 has been removed. Unmaintained and not functional at the time.

Wed, Nov 14, 4:49 PM · efl

Tue, Nov 13

devilhorns accepted D7265: ecore_wl2_dnd: initialize source to NULL when it destroy.
Tue, Nov 13, 3:40 AM · efl

Thu, Nov 8

devilhorns accepted D7248: ee_wayland: Set opaque region for alphaless surfaces.
Thu, Nov 8, 1:49 PM · efl

Tue, Oct 30

devilhorns accepted D7220: ecore_wl2_window: use client window dimension.
Tue, Oct 30, 3:59 AM · efl

Wed, Oct 24

devilhorns added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

Agreed, which is why I'd be curious where it's getting called from ... smells like a hotpath that could likely be optimized to (at the least) reduce calls to that function

Wed, Oct 24, 1:24 PM · Restricted Project, Restricted Project, efl: data types
devilhorns added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

@ManMower does this happen every render cycle ?? I'm curious where & (more importantly) Why eina_array_step_set is constantly being called....

Wed, Oct 24, 12:14 PM · Restricted Project, Restricted Project, efl: data types
devilhorns accepted D7205: elementary transit: allow duration change on animatining..
Wed, Oct 24, 4:50 AM · efl

Tue, Oct 23

devilhorns accepted D7200: elementary transit: add a convenient API..
Tue, Oct 23, 4:00 AM · efl

Oct 17 2018

devilhorns accepted D7172: Remove engine check script for direct3d..
Oct 17 2018, 11:14 AM · efl

Oct 16 2018

devilhorns accepted D7165: evas vg: fix memory leak at gradient..
Oct 16 2018, 6:13 AM · efl

Oct 15 2018

devilhorns accepted D7160: evas vg: fix memory leak..
Oct 15 2018, 4:50 AM · efl

Oct 2 2018

devilhorns added a comment to T7421: Something is adding ridiculous damage rectangles.

Oh wait, nvm. I see the values now in the backtrace

Oct 2 2018, 11:09 AM · efl: canvas
devilhorns added a comment to T7421: Something is adding ridiculous damage rectangles.

Can you add a trap here and see what clip->cur->geometry is ??

Oct 2 2018, 11:08 AM · efl: canvas

Oct 1 2018

devilhorns added a comment to D7122: software_generic: Fix memory leak when resizing dmabuf native surfaces.

This looks ok to me ... but I don't know a lot about the native surface stuff

Oct 1 2018, 10:03 AM · efl

Sep 28 2018

devilhorns accepted D7120: eldbus: remove unreachable code..
Sep 28 2018, 4:49 AM · efl

Sep 27 2018

devilhorns added a comment to T7360: Evas/Edje animations not in sync .

@DaveMDS Ok, good to know :) It was just a thought

Sep 27 2018, 4:05 AM · Bug Report, regression, efl (efl-1.21)

Sep 26 2018

devilhorns updated subscribers of T7360: Evas/Edje animations not in sync .

@ManMower could this be related to your recent animator changes ?

Sep 26 2018, 12:51 PM · Bug Report, regression, efl (efl-1.21)

Sep 25 2018

devilhorns accepted D7071: docs: Fix Efl.Ui.Focus.Object.Focus() docs.
Sep 25 2018, 7:58 AM · efl
devilhorns accepted D7104: eina: move definition of EFL64.
Sep 25 2018, 6:36 AM · efl

Sep 24 2018

devilhorns added a comment to T7413: Enlightenment burns cpu when running elementary_test on wayland.

Actually should be the opposite ... CSD should always have frame object...Server side I think is the one that does not have frame_obj...As CSD (client side decoration) is what happens when run under Weston, etc

Sep 24 2018, 3:45 PM · enlightenment-git
devilhorns added a comment to D7101: efreet_menu: remove unused and unreachable code..

Looks good to me. I will wait for another reviewer to agree before pushing tho

Sep 24 2018, 4:25 AM · efl
devilhorns accepted D7101: efreet_menu: remove unused and unreachable code..
Sep 24 2018, 4:24 AM · efl

Sep 21 2018

devilhorns closed D7098: eina: Improve doxygen formatting for eina_debug.h.
Sep 21 2018, 11:34 AM · efl
devilhorns accepted D7098: eina: Improve doxygen formatting for eina_debug.h.
Sep 21 2018, 11:33 AM · efl
devilhorns accepted D7097: efl_vg: calculate center point with double type.
Sep 21 2018, 5:57 AM · efl

Sep 19 2018

devilhorns closed D7065: ecore_wl2_window: Fix incorrectly implemented null check..
Sep 19 2018, 4:01 AM · efl
devilhorns accepted D7065: ecore_wl2_window: Fix incorrectly implemented null check..
Sep 19 2018, 3:57 AM · efl

Sep 18 2018

devilhorns accepted D7048: elm_transit: Convert to new animators.
Sep 18 2018, 7:19 AM · efl
devilhorns accepted D7041: ecore: Add new way to register animators.
Sep 18 2018, 7:18 AM · efl
devilhorns requested changes to D7041: ecore: Add new way to register animators.
Sep 18 2018, 6:20 AM · efl
devilhorns accepted D7052: emotion: Convert to new animators.
Sep 18 2018, 6:15 AM · efl
devilhorns accepted D7051: efl_canvas_animation_player: Convert to new animators.
Sep 18 2018, 6:14 AM · efl
devilhorns accepted D7050: emotion: Convert to new animators.
Sep 18 2018, 6:14 AM · efl
devilhorns accepted D7049: elu_ews_wm: Convert to new animators.
Sep 18 2018, 6:14 AM · efl
devilhorns accepted D7047: elm_genlist: Convert to new animators.
Sep 18 2018, 6:13 AM · efl
devilhorns accepted D7046: elm_gengrid: Convert to new animators.
Sep 18 2018, 6:12 AM · efl
devilhorns accepted D7045: elm_box: Convert to new animators.
Sep 18 2018, 6:12 AM · efl
devilhorns accepted D7044: elm_actionslider: Convert to new animators.
Sep 18 2018, 6:12 AM · efl
devilhorns accepted D7043: efl_ui_flip: Convert to new animators.
Sep 18 2018, 6:11 AM · efl
devilhorns accepted D7042: selection_manager: Convert to new animators.
Sep 18 2018, 6:11 AM · efl
devilhorns accepted D7040: ecore_anim: Move struct Ecore_Animator to private header.
Sep 18 2018, 6:02 AM · efl
devilhorns accepted D7039: ecore_evas: Refactor out ticking start/stop as functions.
Sep 18 2018, 6:01 AM · efl

Sep 12 2018

devilhorns added a comment to T7396: elementary_test's box transition test is broken under wayland.

Very strange that a commit from 2 years ago has a side effect that we've never seen until now....

Sep 12 2018, 11:11 AM · Restricted Project, efl
devilhorns closed D7023: ecore_wl2: add support for intree loading of the module.
Sep 12 2018, 5:39 AM · efl
devilhorns accepted D7023: ecore_wl2: add support for intree loading of the module.

Ahh ok, then this would be safe to push. I wasn't sure if it was compile-time or runtime, that's why I was asking

Sep 12 2018, 4:32 AM · efl
devilhorns requested changes to D7023: ecore_wl2: add support for intree loading of the module.

is NEED_RUN_IN_TREE set at compile time or runtime ?

Sep 12 2018, 4:13 AM · efl

Sep 11 2018

devilhorns accepted D7023: ecore_wl2: add support for intree loading of the module.
Sep 11 2018, 1:33 PM · efl
devilhorns added inline comments to D7023: ecore_wl2: add support for intree loading of the module.
Sep 11 2018, 1:03 PM · efl
devilhorns closed D7022: wayland_egl: Fix drop shadows on radeon.
Sep 11 2018, 9:22 AM · efl
devilhorns added a comment to D7022: wayland_egl: Fix drop shadows on radeon.

That sounds like a good idea. I'll go ahead and land this .. in the meantime, maybe a TODO ticket for the egl refactor ??

Sep 11 2018, 9:18 AM · efl
devilhorns accepted D7022: wayland_egl: Fix drop shadows on radeon.

Makes sense. How did this go soo long without being detected ? :( My guess is other gl engines are doing the same.... Wondering if we should land this patch ? or wait for other engines to be fixed ??

Sep 11 2018, 8:40 AM · efl

Sep 10 2018

devilhorns accepted D7016: ecore_wl2: Move surface module file to modules directory.

Ah ok, well that makes some sense then

Sep 10 2018, 5:48 PM · efl
devilhorns requested changes to D7016: ecore_wl2: Move surface module file to modules directory.

Are we planning on having more than one module for ecore_wl2 ?? If not, then I don't see the point of this ... If we Are planning on more than one module, then ok

Sep 10 2018, 1:12 PM · efl

Sep 8 2018

devilhorns closed D7007: eina: Add doxygen in/out tags for remaining APIs.
Sep 8 2018, 4:23 AM · efl
devilhorns accepted D7007: eina: Add doxygen in/out tags for remaining APIs.
Sep 8 2018, 4:18 AM · efl

Sep 6 2018

devilhorns closed D6704: elementary: Check for valid focus manager before starting do loop.
Sep 6 2018, 9:29 AM · Restricted Project
devilhorns added a commit to T7030: efl internals pass null objects to functions which should not be passed null: rEFL84423a465ca2: elementary: Check for valid focus manager before starting do loop.
Sep 6 2018, 9:29 AM · efl: data types, Restricted Project, efl (efl-1.21)
devilhorns added a comment to D6704: elementary: Check for valid focus manager before starting do loop.

@bu5hm4n Patch updated. Needs review again

Sep 6 2018, 6:22 AM · Restricted Project
devilhorns updated the diff for D6704: elementary: Check for valid focus manager before starting do loop.

Update patch according to reviewed comments

Sep 6 2018, 6:21 AM · Restricted Project

Aug 31 2018

devilhorns closed T7226: Remove Cserve2 support as Resolved.
Aug 31 2018, 4:58 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas

Aug 30 2018

devilhorns added a comment to D6704: elementary: Check for valid focus manager before starting do loop.

Sure, I can change the patch to do that

Aug 30 2018, 8:55 AM · Restricted Project

Aug 29 2018

devilhorns requested review of D6942: efl: Remove cserve2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns added a child revision for D6941: evas: Remove cache2 support: D6942: efl: Remove cserve2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6942: efl: Remove cserve2 support.
Aug 29 2018, 11:27 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns requested review of D6941: evas: Remove cache2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns added a child revision for D6940: evas: Remove binary cserve2: D6941: evas: Remove cache2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns requested review of D6940: evas: Remove binary cserve2.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6941: evas: Remove cache2 support.
Aug 29 2018, 11:27 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns added a child revision for D6939: efl: Remove cserve2 support from Makefile_Evas.am: D6940: evas: Remove binary cserve2.
Aug 29 2018, 11:27 AM · efl
devilhorns requested review of D6939: efl: Remove cserve2 support from Makefile_Evas.am.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6940: evas: Remove binary cserve2.
Aug 29 2018, 11:27 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns added a child revision for D6938: efl: Remove cserve2 from comfigure.ac: D6939: efl: Remove cserve2 support from Makefile_Evas.am.
Aug 29 2018, 11:27 AM · efl
devilhorns requested review of D6938: efl: Remove cserve2 from comfigure.ac.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6939: efl: Remove cserve2 support from Makefile_Evas.am.
Aug 29 2018, 11:27 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns added a child revision for D6937: evas-file: Remove cserve2 support: D6938: efl: Remove cserve2 from comfigure.ac.
Aug 29 2018, 11:27 AM · efl
devilhorns requested review of D6937: evas-file: Remove cserve2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6938: efl: Remove cserve2 from comfigure.ac.
Aug 29 2018, 11:27 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns added a child revision for D6935: evas-common: Remove cserve2 support: D6937: evas-file: Remove cserve2 support.
Aug 29 2018, 11:27 AM · efl
devilhorns added a revision to T7226: Remove Cserve2 support: D6937: evas-file: Remove cserve2 support.
Aug 29 2018, 11:26 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns updated the diff for D6935: evas-common: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6934: evas-canvas: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6933: evas-eglfs: Remove cserve2 support.

No changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6932: evas-gl-drm: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6931: evas-gl-x11: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6930: evas-software-genereric: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6929: evas-software-x11: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6928: evas-gl-common: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6927: evas-buffer: Remove cserve2 support.

No Changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6926: evas-gl-generic: Remove cserve2 support.

No changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6925: evas-wayland-egl: Remove cserve2 support.

No changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6924: evas-wayland-shm: Remove cserve2 support.

No changes

Aug 29 2018, 11:26 AM · efl
devilhorns updated the diff for D6923: evas_drm: Remove cserve2 support.

Git phab failed proposing some of these patches, reattempting

Aug 29 2018, 11:25 AM · efl
devilhorns raised the priority of T7226: Remove Cserve2 support from TODO to Normal.
Aug 29 2018, 11:24 AM · Active Work Proposal, major change, efl (efl-1.22), efl: canvas
devilhorns added a child revision for D6935: evas-common: Remove cserve2 support: D6936: evas-file: Remove cserve2 support.
Aug 29 2018, 11:23 AM · efl