I can't land this without losing author information (don't have arc installed on this box), but feel free to push this.

Looked through the code, and you are correct :) .. Patch approved however I cannot push it because I don't have arc installed on this box. @bu5hm4n - Can you push this please when you have a chance ? Thanks :)

In D11429#217730, @zmike wrote:

This function returns 0 on success, not failure.

Well, if we don't care about doxygen for newly added APIs, then this looks ok to me

From a compiler stand point, I do not think that it actually makes a difference ... tho that Could depend on the compiler. It's been EFL preference that they come After so if you would like to make some patches to fix those, that would be great.

Normally, we use it After the variable

In T8016#149704, @CHAN wrote:

ecore_wl2_display_terminate(display);
ecore_wl2_input_cursor_from_name_set(input, cursor);
ecore_wl2_session_recovery_disable();

• Internal? what do you think? if you agree with that i will put on a patch for this.

In D11111#210978, @CHAN wrote:

@devilhorns Thanks you for giving advise here.

Yes i agree with that.
But the some of APIs are has been designed only for Enlightenment (Some of interface missing.)
It was difficult to handle APIs with different input ids or difficult to verify operation because the registry was not supported.
therefore, i meant that TC should be written based on Enlightenment first anyways...

@CHAN Ok, that makes sense then. Thank you for explaining. There is one small change that is needed tho ... the API should be @since 1.24

In D11111#210703, @CHAN wrote:

@devilhorns Thank you.

Um... in my env it passes all.

(ERR<1169>:ecore_wl2 ../src/lib/ecore_wl2/ecore_wl2_input.c:1612 _ecore_wl2_input_add() id = 10)

100%: Checks: 7, Failures: 0, Errors: 0
100%: Checks: 10, Failures: 0, Errors: 0
100%: Checks: 22, Failures: 0, Errors: 0

It seems to have different values for different versions and environments.
It's better to make it meaningful only in the enlightenment environment.

@CHAN I don't really see the need for "input->repeat.changed". We can just set the input repeat rate & delay regardless of changed or not

Ahhh ok, that makes sense. Thanks.

@CHAN I moved the ecore_wl2_window_aux_hint functions to be internal now as they are not used anywhere outside of EFL itself. I also removed the test case for the one function that was there.

This issue is now fixed in Enlightenment git head

In D11007#209238, @CHAN wrote:

@devilhorns

Yes in weston my sample app is not work.

When i tried to launch sample app the log said.

"zxdg_surfacc_v6@16: error 3: xdg_surface has never been configured. "
"_begin_recovery_maybe() Wayland Socket Error: Protocol error "

in enlightenement there is a "xdg_wm_base" value in global interface.
but weston there is no "xdg_wm_base" value in global interface.

Any idea about it?
i will try to figure out what is going on here.
Um... but i think the ecore_wl2 is not works well on weston.
weston doesn't have efl only protocols...
i dont have many experience about it though...
anyway i will look around more.

Please give me any advise for this.

I just run enlightenment_start and build efl on enlightenment then run the TC and sample test apps.

Thanks.

@CHAN Ok, I went through the list of API functions here and have found which ones are not done yet. The list of these functions is below. I would suggest making new patches for these because this current patch will certainly not apply cleanly any more. Another suggestion I have is to separate it into a patch for ecore_wl2_window functions, and another patch for ecore_wl2_input functions. An even Better suggestion would be a separate patch for Each Function. This will allow easier review and be easier to follow any comments, suggestions, or discussions that will take place.

In T8016#149260, @devilhorns wrote:

In T8016#149233, @CHAN wrote:

@devilhorns

Now the ecore_wl2_output_find failed.

output list gets a value when _surface_enter() being called.

According to wl doc
(This is emitted whenever a surface's creation, movement, or resizing results in some part of it being within the scan out region of an output.
Note that a surface may be overlapping with zero or more outputs. )

It should be called if i create a win and move it. but its not called...

any idea about it?

I took a look into this ... and from what I can see going on, the issue is that we never get the _surface_enter event. This could be due to the surface Not Actually being shown on screen ... but I am not 100% sure yet and will keep digging into it

In T8016#149323, @devilhorns wrote:

In T8016#149293, @CHAN wrote:

@devilhorns

Thanks for giving me an answer and adding a new TC.

I have a question about other APIs.

ecore_wl2_dnd and ecore_wl2_offer APIs looks that support Copy & Paste between or within windows using wl protocol.
If then, I wonder if these APIs will be usable when open to the public. Tizen also uses only internal modules.

ecore_wl2_subsurface APIs...
These APIs are hard to determine for what usability.
Could you please tell me more about what these APIs are used for? In Tizen there is no case used.

I will have to take a look at where the dnd, offer, and subsurface functions are used in our codebase. It is possible that some of these can be moved to Internal functions.

In T8016#149322, @devilhorns wrote:

In T8016#149295, @CHAN wrote:

@devilhorns

input = ecore_wl2_display_input_find_by_name(disp, "default);

You added above line in TC.
In my env the value is "seat0" instead of "default".
So it failed.

Do we work on different env?

I can change it to be "seat0", that's no problem

In T8016#149293, @CHAN wrote:

@devilhorns

Thanks for giving me an answer and adding a new TC.

I have a question about other APIs.

ecore_wl2_dnd and ecore_wl2_offer APIs looks that support Copy & Paste between or within windows using wl protocol.
If then, I wonder if these APIs will be usable when open to the public. Tizen also uses only internal modules.

ecore_wl2_subsurface APIs...
These APIs are hard to determine for what usability.
Could you please tell me more about what these APIs are used for? In Tizen there is no case used.