Page MenuHomePhabricator

devilhorns (Chris Michael)
Spy

Projects (9)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 15 2013, 1:48 AM (326 w, 4 d)
Availability
Available

Recent Activity

Fri, May 17

devilhorns accepted D8914: elm_test: fix some bugs in elm_image tests.

Changes look ok to me (nb: did not actually run the test tho)

Fri, May 17, 10:16 AM · efl

Wed, May 15

devilhorns requested changes to D8900: efl-wl: add missing docs for efl_wl_global_add().
Wed, May 15, 10:09 AM · efl
devilhorns resigned from D8897: enlightenment_remote: bg-add break.
Wed, May 15, 2:42 AM · enlightenment-git

Tue, May 14

devilhorns claimed T7479: Firefox wayland misplaces menus, popups the adress bar drop down etc.
Tue, May 14, 4:03 AM · enlightenment-git, Restricted Project

Wed, May 8

devilhorns added a comment to D8861: Revert "eldbus_test_eldbus_message: Fix resource leak".

@segfaultxavi I think @bu5hm4n may be mistaken here ... this Coverity issue is about the 'msg' itself, not about the iterator. eldbus_message_iter_del does not delete the 'msg' itself, just the iterator (as far as I can tell). I don't see where eldbus_message_iter_del is removing the message itself....

Wed, May 8, 8:12 AM · efl

Thu, May 2

devilhorns closed D8804: Lost Windows removal from wayland.
Thu, May 2, 9:13 AM · enlightenment-git
devilhorns accepted D8804: Lost Windows removal from wayland.
Thu, May 2, 9:13 AM · enlightenment-git
devilhorns updated the diff for D8770: eina_test_strbuf: Fix resource leak.

Use eina_strbuf_reset

Thu, May 2, 5:00 AM · efl
devilhorns updated the diff for D8769: eo_test_manager_xattr: Fix resource leak.

Free buf inside for loop

Thu, May 2, 5:00 AM · efl
devilhorns added a child revision for D8762: eina_test_tiler: Fix resource leak: D8769: eo_test_manager_xattr: Fix resource leak.
Thu, May 2, 5:00 AM · efl
devilhorns updated the diff for D8762: eina_test_tiler: Fix resource leak.

Avoid creating tiler until needed

Thu, May 2, 4:59 AM · efl
devilhorns added inline comments to D8769: eo_test_manager_xattr: Fix resource leak.
Thu, May 2, 3:57 AM · efl

Tue, Apr 30

devilhorns closed D8787: wl2_input: fix a problem that occurs in case of using both pointer/touch input devices.
Tue, Apr 30, 8:26 AM · efl
devilhorns closed D8786: ecore_wl2_input: modify to increase grab count while touching.
Tue, Apr 30, 8:24 AM · efl
devilhorns accepted D8787: wl2_input: fix a problem that occurs in case of using both pointer/touch input devices.

This looks good, but I cannot push this yet. Please feel free to land this

Tue, Apr 30, 4:20 AM · efl
devilhorns accepted D8786: ecore_wl2_input: modify to increase grab count while touching.

This looks good, but I cannot push this yet. Please feel free to land this

Tue, Apr 30, 4:18 AM · efl

Mon, Apr 29

devilhorns requested review of D8782: eina_test_ustr: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8781: emile_test_base64: Fix memory leak: D8782: eina_test_ustr: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns requested review of D8781: emile_test_base64: Fix memory leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns requested review of D8780: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8780: emile_test_base64: Fix resource leak: D8781: emile_test_base64: Fix memory leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8779: efl_ui_test_widget: Fix resource leak: D8780: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns requested review of D8779: efl_ui_test_widget: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8778: ecore_test_ecore_file: Fix resource leak: D8779: efl_ui_test_widget: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns requested review of D8778: ecore_test_ecore_file: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8777: emile_test_base64: Fix resource leak: D8778: ecore_test_ecore_file: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns requested review of D8777: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:25 AM · efl
devilhorns added a child revision for D8776: efl_ui_test_widget: Fix resource leak: D8777: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8776: efl_ui_test_widget: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8775: emile_test_base64: Fix resource leak: D8776: efl_ui_test_widget: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8775: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8774: efl_ui_test_widget: Fix memory leak: D8775: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8774: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8773: eldbus_test_eldbus_message: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8773: eldbus_test_eldbus_message: Fix resource leak: D8774: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8772: eina_test_file: Fix resource leak: D8773: eldbus_test_eldbus_message: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8772: eina_test_file: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8771: evas_test_image: Fix resource leak: D8772: eina_test_file: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns requested review of D8771: evas_test_image: Fix resource leak.
Mon, Apr 29, 8:24 AM · efl
devilhorns added a child revision for D8770: eina_test_strbuf: Fix resource leak: D8771: evas_test_image: Fix resource leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8770: eina_test_strbuf: Fix resource leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns added a child revision for D8769: eo_test_manager_xattr: Fix resource leak: D8770: eina_test_strbuf: Fix resource leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8769: eo_test_manager_xattr: Fix resource leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns added a child revision for D8768: eina_bench_stringshare: Fix resourcce leak: D8769: eo_test_manager_xattr: Fix resource leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8768: eina_bench_stringshare: Fix resourcce leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns added a child revision for D8767: efl_ui_test_widget: Fix memory leak: D8768: eina_bench_stringshare: Fix resourcce leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8767: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns added a child revision for D8766: efl_ui_test_widget: Fix memory leak: D8767: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8766: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns added a child revision for D8765: eina_test_binbuf: Fix memory leak: D8766: efl_ui_test_widget: Fix memory leak.
Mon, Apr 29, 8:23 AM · efl
devilhorns requested review of D8765: eina_test_binbuf: Fix memory leak.
Mon, Apr 29, 8:22 AM · efl
devilhorns added a child revision for D8764: evas_test_mesh: Fix memory leak: D8765: eina_test_binbuf: Fix memory leak.
Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8764: evas_test_mesh: Fix memory leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8763: emile_test_base64: Fix resource leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8762: eina_test_tiler: Fix resource leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8761: elm_test_widget_focus: Fix memory leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8760: efl_check: Fix memory leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns updated the diff for D8759: eina_test_file: Fix memory leak.

no changes

Mon, Apr 29, 8:22 AM · efl
devilhorns requested review of D8764: evas_test_mesh: Fix memory leak.
Mon, Apr 29, 8:21 AM · efl
devilhorns added a child revision for D8763: emile_test_base64: Fix resource leak: D8764: evas_test_mesh: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns requested review of D8763: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns added a child revision for D8762: eina_test_tiler: Fix resource leak: D8763: emile_test_base64: Fix resource leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns requested review of D8762: eina_test_tiler: Fix resource leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns added a child revision for D8761: elm_test_widget_focus: Fix memory leak: D8762: eina_test_tiler: Fix resource leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns requested review of D8761: elm_test_widget_focus: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns added a child revision for D8760: efl_check: Fix memory leak: D8761: elm_test_widget_focus: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns requested review of D8760: efl_check: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns added a child revision for D8759: eina_test_file: Fix memory leak: D8760: efl_check: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl
devilhorns requested review of D8759: eina_test_file: Fix memory leak.
Mon, Apr 29, 8:20 AM · efl

Tue, Apr 23

devilhorns closed D8688: efl_core_command_line: Fix resource leak.
Tue, Apr 23, 12:09 PM · efl
devilhorns added reviewers for D8688: efl_core_command_line: Fix resource leak: bu5hm4n, zmike.
Tue, Apr 23, 7:35 AM · efl
devilhorns requested review of D8688: efl_core_command_line: Fix resource leak.
Tue, Apr 23, 6:26 AM · efl

Mon, Apr 22

devilhorns closed D8676: autotools: add lib/evas/common/evas_map_image_internal_high.c to dist.
Mon, Apr 22, 4:21 AM · Restricted Project
devilhorns accepted D8676: autotools: add lib/evas/common/evas_map_image_internal_high.c to dist.
Mon, Apr 22, 4:20 AM · Restricted Project
devilhorns closed D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Mon, Apr 22, 4:06 AM · efl
devilhorns closed D8672: efl_ui_widget: remove unused function.
Mon, Apr 22, 4:05 AM · efl
devilhorns accepted D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Mon, Apr 22, 3:59 AM · efl

Sun, Apr 21

devilhorns accepted D8672: efl_ui_widget: remove unused function.
Sun, Apr 21, 2:53 PM · efl

Apr 16 2019

devilhorns closed D8617: efl_ui_image: fix warning about calling smooth_scale_set on non-image.
Apr 16 2019, 5:54 AM · efl
devilhorns accepted D8617: efl_ui_image: fix warning about calling smooth_scale_set on non-image.
Apr 16 2019, 5:52 AM · efl

Apr 1 2019

devilhorns triaged T7739: Support primary selection on wayland as TODO priority.
Apr 1 2019, 7:55 AM · Restricted Project, efl
devilhorns claimed T7739: Support primary selection on wayland.
Apr 1 2019, 7:55 AM · Restricted Project, efl
devilhorns closed D8523: efl_ui_selection_manager: Don't leak malloc'd data.
Apr 1 2019, 7:02 AM · efl
devilhorns updated the diff for D8523: efl_ui_selection_manager: Don't leak malloc'd data.

Update based on review comments

Apr 1 2019, 6:58 AM · efl
devilhorns added a reviewer for D8523: efl_ui_selection_manager: Don't leak malloc'd data: zmike.
Apr 1 2019, 6:15 AM · efl
devilhorns requested review of D8523: efl_ui_selection_manager: Don't leak malloc'd data.
Apr 1 2019, 6:02 AM · efl

Mar 29 2019

devilhorns added a comment to D8512: efl_ui_layout: ensure that resize_obj is present before emitting signals.

I did not land this as it says that it depends on others which are not reviewed and/or accepted yet

Mar 29 2019, 5:56 AM · efl
devilhorns accepted D8512: efl_ui_layout: ensure that resize_obj is present before emitting signals.
Mar 29 2019, 5:43 AM · efl

Mar 27 2019

devilhorns added a comment to D8476: efl_ui_widget: move from elm_widget_top_get to provider_find.

True, i picked this as an example because it also (like my commit) does not give a explicit usecase on how to verify this. But i could also have picked basically every other commit, it was basically taken because it was merged recently, and was under my mouse cursor ^^

Mar 27 2019, 4:22 AM · efl
devilhorns added a comment to D8476: efl_ui_widget: move from elm_widget_top_get to provider_find.

this resolves a lot of cases where focus_highlight API was called on a object, which is not a efl_ui_win object`

It does not explicitly tell you that it is a error, but I think it is quite clear that calling API on a object that is not implementing this API causes a error. Additionally, i think it is a little bit of a waste of time to write a tutorial to run our testsuite capture the error output, and grep for focus_highlight, i really fail to see the reason for this.

Further more, we have lovely commits like 828984393e82fe30b1d2a29a47e806cc827070a4 or 5c1ea543bb9d4e3b36721994563bff0152429d97 where the commit message does not link the issue it tries to fix nor a tells what kind of error it tries to fix. I am not against improving commit messages at all, but i pretty much fail to see the reason for beating up people using review, while silently nodding away people who are to ignorant to use review.

Mar 27 2019, 3:47 AM · efl

Mar 26 2019

devilhorns added inline comments to D8481: elementary: embed standard config as fallback.
Mar 26 2019, 11:05 AM · efl
devilhorns requested changes to D8481: elementary: embed standard config as fallback.
Mar 26 2019, 10:34 AM · efl
devilhorns closed D8452: elementary: fix ATSPI reflection API warning..
Mar 26 2019, 9:05 AM · efl
devilhorns closed D8451: eina: always initialize i..
Mar 26 2019, 9:05 AM · efl

Mar 23 2019

devilhorns accepted D8452: elementary: fix ATSPI reflection API warning..
Mar 23 2019, 4:57 AM · efl
devilhorns accepted D8451: eina: always initialize i..
Mar 23 2019, 4:57 AM · efl

Mar 22 2019

devilhorns closed D8117: wl-drm: Refactor _drm2_randr_apply function.
Mar 22 2019, 10:01 AM · enlightenment-git, DO NOT MERGE, efl
devilhorns added a commit to T7690: drm (both gl and sw) are broken with rotation: rE9798e901f943: wl-drm: Refactor _drm2_randr_apply function.
Mar 22 2019, 10:01 AM · efl
devilhorns closed T7690: drm (both gl and sw) are broken with rotation as Resolved.

This ticket should be fixed now. If there are still issues, please re-open

Mar 22 2019, 9:49 AM · efl
devilhorns closed D8404: evas drm: Implement support for damage_region_set.
Mar 22 2019, 9:42 AM · efl