Page MenuHomePhabricator

divyesh (divyesh purohit)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 1 2015, 10:54 PM (265 w, 13 h)
Availability
Available

Recent Activity

Mar 8 2016

divyesh requested review of D3570: Combobox: Added Multiple selection feature.
Mar 8 2016, 10:13 PM · Restricted Project
divyesh added inline comments to D3570: Combobox: Added Multiple selection feature.
Mar 8 2016, 1:19 AM · Restricted Project

Feb 29 2016

divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Fixed according to review comments

Feb 29 2016, 2:29 AM · Restricted Project

Feb 8 2016

divyesh abandoned D3650: Multibuttonentry: coding convention.

i'll abandon the commit as no comments have arrived after my own.

Feb 8 2016, 9:50 PM
divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Fixed according to review comments.
But after browsing through Ecoding page, I couldn't find any such line
stating that variables should be declared at the top of the function.

Feb 8 2016, 9:47 PM · Restricted Project
divyesh added a comment to D3570: Combobox: Added Multiple selection feature.

@cedric, @divyesh: why call this feature as multiple selection? the name should be different I think, we are not actually doing multiple selection here are we?

Feb 8 2016, 5:30 AM · Restricted Project
divyesh added inline comments to D3570: Combobox: Added Multiple selection feature.
Feb 8 2016, 5:10 AM · Restricted Project
divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Yes, creating the MBE in the constructor is bad idea. I had already decided to do rectify
that in the next patch (when i would add a scrollable interface to app/combobox).
Currently I am stuck in adding scroller to MBE and resolve some focus issues with genlist,
so i didn't paid much attention to the creation of MBE. maybe i should had written that in
the comments my bad :)

Feb 8 2016, 4:42 AM · Restricted Project

Feb 5 2016

divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Fixed according to review comments

Feb 5 2016, 4:56 AM · Restricted Project
divyesh added a comment to D3650: Multibuttonentry: coding convention.

some lines over-scrolls outside outside of the window , which is difficult to read, what about them??
i tried to follow 80 columns length(according to Ecoding guidelines) wherever possible.

Feb 5 2016, 3:40 AM

Feb 4 2016

divyesh updated the diff for D3650: Multibuttonentry: coding convention.

fixed space at line 2029.

Feb 4 2016, 2:50 AM
divyesh retitled D3650: Multibuttonentry: coding convention from to Multibuttonentry: coding convention.
Feb 4 2016, 2:45 AM
divyesh updated the diff for D3635: MultibuttonEntry: Fix Segfault on pressing Delete Key.

Fixed according to review comments

Feb 4 2016, 1:46 AM

Feb 3 2016

divyesh closed D3623: Combobox : Added Eolian-Javascript/C++ Bindings.
Feb 3 2016, 8:41 PM
divyesh requested review of D3623: Combobox : Added Eolian-Javascript/C++ Bindings.
Feb 3 2016, 5:42 AM

Feb 2 2016

divyesh updated the diff for D3635: MultibuttonEntry: Fix Segfault on pressing Delete Key.

Forgot to remove the commented line

Feb 2 2016, 5:57 AM
divyesh updated the diff for D3635: MultibuttonEntry: Fix Segfault on pressing Delete Key.

Fixed according to review comments

Feb 2 2016, 5:54 AM

Feb 1 2016

divyesh retitled D3635: MultibuttonEntry: Fix Segfault on pressing Delete Key from to MultibuttonEntry: Fix Segfault on pressing Delete Key and some typo.
Feb 1 2016, 11:27 PM
divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Sync code with upstream

Feb 1 2016, 11:02 PM · Restricted Project
divyesh accepted D3627: elm_hoversel: add "escape" key action to dismiss.
Feb 1 2016, 8:56 PM
divyesh updated the diff for D3630: Combobox : Prevent empty swallow to be shown on hover_dismiss animation.

Fix hover show animation on reopening hover after hover dismiss animation.

Feb 1 2016, 6:06 AM
divyesh retitled D3630: Combobox : Prevent empty swallow to be shown on hover_dismiss animation from to Combobox : Prevent empty swallow to be shown on hover_dismiss animation.
Feb 1 2016, 4:42 AM
divyesh added a revision to T3124: Combobox Empty content : D3630: Combobox : Prevent empty swallow to be shown on hover_dismiss animation.
Feb 1 2016, 4:42 AM · Restricted Project
divyesh updated the task description for T3124: Combobox Empty content .
Feb 1 2016, 4:20 AM · Restricted Project
divyesh updated subscribers of T3124: Combobox Empty content .
Feb 1 2016, 3:01 AM · Restricted Project
divyesh created T3124: Combobox Empty content .
Feb 1 2016, 3:01 AM · Restricted Project
divyesh requested changes to D3627: elm_hoversel: add "escape" key action to dismiss.
Feb 1 2016, 1:05 AM

Jan 29 2016

divyesh retitled D3623: Combobox : Added Eolian-Javascript/C++ Bindings from to Combobox : Added Eolian-Javascript/C++ Bindings.
Jan 29 2016, 1:23 AM
divyesh added a comment to T3112: change the behavior of horizontal hoversel.

(Imho). using elm_menu would be sufficient to achieve this requirement. see the pic below

.

Jan 29 2016, 1:02 AM · Restricted Project

Jan 25 2016

divyesh updated D3605: Combobox add disabled state.
Jan 25 2016, 1:27 AM
divyesh added a revision to T3075: Elm Combobox problems: D3605: Combobox add disabled state.
Jan 25 2016, 1:27 AM · Restricted Project
divyesh retitled D3605: Combobox add disabled state from to Combobox add disabled state.
Jan 25 2016, 1:26 AM

Jan 23 2016

divyesh added inline comments to D3601: Combobox, fix continuous clicks on hover..
Jan 23 2016, 9:23 AM
divyesh retitled D3603: Combobox avoid calling item_selected and dismissed signal on show from to Combobox avoid calling item_selected and dismissed signal on show.
Jan 23 2016, 9:21 AM
divyesh updated the diff for D3601: Combobox, fix continuous clicks on hover..

oops.. forgot to checkout different branch

Jan 23 2016, 4:25 AM
divyesh retitled D3601: Combobox, fix continuous clicks on hover. from to Combobox, fix continuous clicks on hover..
Jan 23 2016, 4:20 AM
divyesh added a comment to T3075: Elm Combobox problems.

I think two of them are resolved now, i am working on disable state in combobox(4th point).

Jan 23 2016, 1:04 AM · Restricted Project

Jan 22 2016

divyesh retitled D3599: Combobox return key handling, removed unreachable code. from to Combobox return key handling, removed unreachable code..
Jan 22 2016, 3:27 AM
divyesh added a revision to T3075: Elm Combobox problems: D3599: Combobox return key handling, removed unreachable code..
Jan 22 2016, 3:26 AM · Restricted Project
divyesh added inline comments to D3596: Combobox apply proper style.
Jan 22 2016, 12:31 AM

Jan 21 2016

divyesh added a task to D3596: Combobox apply proper style: T3075: Elm Combobox problems.
Jan 21 2016, 11:24 PM
divyesh added a revision to T3075: Elm Combobox problems: D3596: Combobox apply proper style.
Jan 21 2016, 11:24 PM · Restricted Project

Jan 20 2016

divyesh updated subscribers of T3075: Elm Combobox problems.
Jan 20 2016, 10:19 PM · Restricted Project

Jan 15 2016

divyesh added inline comments to D3570: Combobox: Added Multiple selection feature.
Jan 15 2016, 6:20 AM · Restricted Project
divyesh updated the diff for D3570: Combobox: Added Multiple selection feature.

Fixed according to review comments

Jan 15 2016, 5:29 AM · Restricted Project

Jan 14 2016

divyesh edited the content of Efl Todo.
Jan 14 2016, 3:02 AM
divyesh edited the content of Efl Todo.
Jan 14 2016, 3:01 AM
divyesh updated D3570: Combobox: Added Multiple selection feature.
Jan 14 2016, 2:53 AM · Restricted Project
divyesh updated D3570: Combobox: Added Multiple selection feature.
Jan 14 2016, 1:50 AM · Restricted Project
divyesh retitled D3570: Combobox: Added Multiple selection feature from to Combobox: Added Multiple selection feature.
Jan 14 2016, 1:43 AM · Restricted Project

Jan 7 2016

divyesh requested review of D3544: Fix combobox's recalc and hover's best_location error.
Jan 7 2016, 10:45 PM

Jan 6 2016

divyesh updated the diff for D3544: Fix combobox's recalc and hover's best_location error.

Fixed according to review comments

Jan 6 2016, 10:46 PM
divyesh updated D3544: Fix combobox's recalc and hover's best_location error.
Jan 6 2016, 10:41 PM
divyesh retitled D3544: Fix combobox's recalc and hover's best_location error from to Fix combobox's recalc and hover's best_location error.
Jan 6 2016, 10:39 PM
divyesh retitled D3539: Added Docs for Combobox from to Added Docs for Combobox.
Jan 6 2016, 12:59 AM

Jan 5 2016

divyesh updated subscribers of D3526: [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks.
Jan 5 2016, 12:39 AM

Jan 4 2016

divyesh created T3006: Hover dismiss delay on continuous mouse clicks.
Jan 4 2016, 11:30 PM · Restricted Project
divyesh retitled D3524: Fixed Segfault when smart direction is used in content_set in hover from to Fixed Segfault when smart direction is used in content_set in hover.
Jan 4 2016, 5:19 AM
divyesh added a revision to T3004: Segfault when using "smart" direction in content_set with hover widget: D3524: Fixed Segfault when smart direction is used in content_set in hover.
Jan 4 2016, 5:19 AM · Restricted Project
divyesh updated the task description for T2965: Copypaste hoversel object is cut when we right click on corner text.
Jan 4 2016, 5:04 AM · Restricted Project
divyesh updated subscribers of T3004: Segfault when using "smart" direction in content_set with hover widget.
Jan 4 2016, 4:50 AM · Restricted Project
divyesh created T3004: Segfault when using "smart" direction in content_set with hover widget.
Jan 4 2016, 4:48 AM · Restricted Project
divyesh added reviewers for D3513: Fix hover position in hoversel, when it goes out of the viewport: cedric, Hermet.
Jan 4 2016, 3:38 AM · Restricted Project
divyesh updated the diff for D3513: Fix hover position in hoversel, when it goes out of the viewport.

Fixed Top-left and bottom-right positions in hover

Jan 4 2016, 3:21 AM · Restricted Project

Jan 3 2016

divyesh updated the diff for D3513: Fix hover position in hoversel, when it goes out of the viewport.

Removed unused functions

Jan 3 2016, 10:01 PM · Restricted Project

Dec 30 2015

divyesh updated D3513: Fix hover position in hoversel, when it goes out of the viewport.
Dec 30 2015, 10:33 PM · Restricted Project
divyesh added a revision to T2965: Copypaste hoversel object is cut when we right click on corner text: D3513: Fix hover position in hoversel, when it goes out of the viewport.
Dec 30 2015, 10:33 PM · Restricted Project
divyesh updated D3513: Fix hover position in hoversel, when it goes out of the viewport.
Dec 30 2015, 10:20 PM · Restricted Project
divyesh added inline comments to D3513: Fix hover position in hoversel, when it goes out of the viewport.
Dec 30 2015, 10:19 PM · Restricted Project
divyesh retitled D3513: Fix hover position in hoversel, when it goes out of the viewport from to Fix hover position in hoversel, when it goes out of the viewport.
Dec 30 2015, 10:15 PM · Restricted Project