Page MenuHomePhabricator

eagleeye (김호상)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2013, 12:29 AM (296 w, 1 h)
Availability
Available

Recent Activity

Wed, Dec 5

eagleeye added a reviewer for D7419: evas_box: fix calculation logic when item's weight is 0.0.: jpeg.
Wed, Dec 5, 4:05 AM · efl
eagleeye added a reviewer for D7419: evas_box: fix calculation logic when item's weight is 0.0.: Jaehyun.
Wed, Dec 5, 2:40 AM · efl
eagleeye requested review of D7419: evas_box: fix calculation logic when item's weight is 0.0..
Wed, Dec 5, 2:39 AM · efl

Mon, Nov 19

eagleeye accepted D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

SCROLL_MANAGER_CLASS is correctly applied.

Mon, Nov 19, 3:12 AM · efl

Sun, Nov 18

eagleeye updated the diff for D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..

fix indentation.

Sun, Nov 18, 9:31 PM · efl
eagleeye updated the diff for D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..

apply efl_composite_attach.

Sun, Nov 18, 9:25 PM · efl

Nov 9 2018

eagleeye requested review of D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..
Nov 9 2018, 12:43 AM · efl

Oct 26 2018

eagleeye updated the test plan for D7216: evas: fix backward compatibility issue..
Oct 26 2018, 12:22 AM · efl
eagleeye requested review of D7216: evas: fix backward compatibility issue..
Oct 26 2018, 12:13 AM · efl

Oct 16 2018

eagleeye added a comment to D7168: evas_events: Fix wrong condtion..

Thank you for your interest :)

Oct 16 2018, 11:29 PM · efl
eagleeye added a comment to D7168: evas_events: Fix wrong condtion..

This commit also looks suspicies to me.
if mouse_grabbed is 0 but pointer mode is not AUTOGRAB nor UPDOWN. then grabbed can now get negative ... :(

Oct 16 2018, 11:25 PM · efl
eagleeye updated the summary of D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:10 PM · efl
eagleeye requested review of D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:09 PM · efl

Oct 10 2018

eagleeye updated the diff for D7152: ecore_wl2: fix coverity issue. (Resource Leak).

add error message

Oct 10 2018, 1:22 AM · efl
eagleeye added a reviewer for D7152: ecore_wl2: fix coverity issue. (Resource Leak): marcelhollerbach.
Oct 10 2018, 12:55 AM · efl
eagleeye requested review of D7152: ecore_wl2: fix coverity issue. (Resource Leak).
Oct 10 2018, 12:54 AM · efl

Oct 3 2018

eagleeye accepted D7140: elementary entry: apply scale to all edje objects.
Oct 3 2018, 11:50 PM · efl
eagleeye accepted D7137: eina debug: fix a double unlock issue.
Oct 3 2018, 11:49 PM · efl

Sep 28 2018

eagleeye added a comment to D7120: eldbus: remove unreachable code..

Thanks. I missed reviewer out:)

Sep 28 2018, 4:50 AM · efl
eagleeye requested review of D7120: eldbus: remove unreachable code..
Sep 28 2018, 4:39 AM · efl

Sep 27 2018

eagleeye added a reviewer for D7114: elm_interface_scrollable: fix using wrong variable.: SanghyeonLee.
Sep 27 2018, 12:05 AM · efl

Sep 26 2018

eagleeye added a reviewer for D7114: elm_interface_scrollable: fix using wrong variable.: Hermet.
Sep 26 2018, 11:47 PM · efl
eagleeye requested review of D7114: elm_interface_scrollable: fix using wrong variable..
Sep 26 2018, 10:08 PM · efl

Aug 27 2018

eagleeye updated the diff for D6882: efl_input: fix problem that ref count does not become 0..

separate efl_add() and callbacks.

Aug 27 2018, 12:17 AM · efl

Aug 21 2018

eagleeye added a comment to D6882: efl_input: fix problem that ref count does not become 0..

problem occurs when mouse up callback is called.
_canvas_event_feed_mouse_updown - make a instance A
_canvas_event_feed_mouse_up_internal
_post_up_handle - copy instance A to B
_evas_canvas_event_pointer_move_event_dispatch - make a instance C

Aug 21 2018, 6:17 PM · efl
eagleeye added reviewers for D6882: efl_input: fix problem that ref count does not become 0.: Jaehyun, Jaehyun_Cho.
Aug 21 2018, 5:06 AM · efl
eagleeye requested review of D6882: efl_input: fix problem that ref count does not become 0..
Aug 21 2018, 5:05 AM · efl

Aug 1 2018

eagleeye added inline comments to D6700: ecore: fix that timers are not called in the order they were registered..
Aug 1 2018, 10:42 PM · Restricted Project
eagleeye updated the diff for D6700: ecore: fix that timers are not called in the order they were registered..

fix test case.

Aug 1 2018, 4:04 AM · Restricted Project
eagleeye updated the diff for D6700: ecore: fix that timers are not called in the order they were registered..

fix patch and make test case.

Aug 1 2018, 4:00 AM · Restricted Project

Jul 31 2018

eagleeye added a reviewer for D6700: ecore: fix that timers are not called in the order they were registered.: SanghyeonLee.
Jul 31 2018, 2:34 AM · Restricted Project
eagleeye accepted D6699: evas_events: Fix to set mouse_in state to all pointers in the seat..
Jul 31 2018, 1:20 AM · efl
eagleeye added a reviewer for D6700: ecore: fix that timers are not called in the order they were registered.: zmike.
Jul 31 2018, 12:28 AM · Restricted Project

Jul 30 2018

eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:29 PM · Restricted Project
eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:26 PM · Restricted Project
eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:25 PM · Restricted Project
eagleeye added reviewers for D6700: ecore: fix that timers are not called in the order they were registered.: Hermet, Jaehyun_Cho.
Jul 30 2018, 11:24 PM · Restricted Project

Jul 16 2018

eagleeye edited the content of Maintainers Reviewers.
Jul 16 2018, 8:36 PM · efl

Jul 11 2018

eagleeye added a comment to D5908: efl_ui_slider: refactor slider widget..

@JackDanielZ I'll check it out:)

Jul 11 2018, 6:28 PM · efl

Jul 10 2018

eagleeye accepted D6520: ecore_wl2&elput: correctly fill the key structure.

My issue is fixed by this patch:)
I think it is correct to delete 'xkb_keysym_to_utf8'

Jul 10 2018, 3:46 AM · efl

Jul 5 2018

eagleeye updated the summary of D6518: ecore_wl2/elput: fix range of symbol for getting key name..
Jul 5 2018, 10:22 PM · efl
eagleeye updated the test plan for D6518: ecore_wl2/elput: fix range of symbol for getting key name..
Jul 5 2018, 10:19 PM · efl
eagleeye added a reviewer for D6518: ecore_wl2/elput: fix range of symbol for getting key name.: bu5hm4n.
Jul 5 2018, 10:18 PM · efl
Herald added a reviewer for D6518: ecore_wl2/elput: fix range of symbol for getting key name.: devilhorns.
Jul 5 2018, 10:17 PM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:39 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:31 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:28 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:28 AM · efl

Jul 4 2018

Herald added a reviewer for D6504: ecore_evas: skip rendering evas and making animator tick: devilhorns.
Jul 4 2018, 3:25 AM · efl

Jun 27 2018

eagleeye updated the diff for D6346: evas: move clearing cows to right place..

add new test case for not using evas_free() explicitly.

Jun 27 2018, 12:37 AM · efl

Jun 22 2018

eagleeye accepted D6362: elm_slider: add null check to avoid seg fault..
Jun 22 2018, 1:33 AM · efl

Jun 21 2018

eagleeye added a comment to D6346: evas: move clearing cows to right place..
In D6346#108708, @zmike wrote:

I'd like to see a unit test added to the evas suite for this case. I think that should be possible?

Jun 21 2018, 7:56 PM · efl
eagleeye updated the diff for D6346: evas: move clearing cows to right place..

call ecore_shutdown first.

Jun 21 2018, 4:25 AM · efl
eagleeye added reviewers for D6346: evas: move clearing cows to right place.: cedric, jpeg, id213sin, woohyun.
Jun 21 2018, 1:05 AM · efl

Jun 20 2018

Herald added a reviewer for D6346: evas: move clearing cows to right place.: devilhorns.
Jun 20 2018, 11:56 PM · efl

Jun 1 2018

eagleeye triaged T6974: Application crashes when evas_object_smart_data_set is called. as Showstopper Issues priority.
Jun 1 2018, 5:14 AM · efl: rendering
eagleeye added projects to T6974: Application crashes when evas_object_smart_data_set is called.: efl, Restricted Project.
Jun 1 2018, 5:11 AM · efl: rendering

May 30 2018

eagleeye updated subscribers of T6974: Application crashes when evas_object_smart_data_set is called..
May 30 2018, 5:12 AM · efl: rendering
eagleeye reopened T6974: Application crashes when evas_object_smart_data_set is called. as "Open".
May 30 2018, 5:11 AM · efl: rendering
eagleeye updated subscribers of T6974: Application crashes when evas_object_smart_data_set is called..
May 30 2018, 3:56 AM · efl: rendering
Herald closed T6974: Application crashes when evas_object_smart_data_set is called. as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks both a project and an assignee. If this ticket is not spam, please reopen it after adding these items.

May 30 2018, 1:40 AM · efl: rendering

May 23 2018

eagleeye updated the summary of D6187: elm_interface_scrollable: change return value for post events..
May 23 2018, 10:54 PM · efl
eagleeye updated the summary of D6187: elm_interface_scrollable: change return value for post events..
May 23 2018, 10:51 PM · efl
eagleeye updated the diff for D6187: elm_interface_scrollable: change return value for post events..

fix condition for unlocking scroll.

May 23 2018, 10:46 PM · efl
eagleeye updated the summary of D6187: elm_interface_scrollable: change return value for post events..
May 23 2018, 6:14 AM · efl
eagleeye added reviewers for D6187: elm_interface_scrollable: change return value for post events.: zmike, singh.amitesh.
May 23 2018, 2:25 AM · efl

May 17 2018

eagleeye updated the diff for D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.

rebase commit

May 17 2018, 1:27 AM · efl

May 15 2018

eagleeye added a reviewer for D6162: elm_slider: fix test suite fail: stefan_schmidt.
May 15 2018, 4:07 AM · efl

May 14 2018

eagleeye updated the diff for D5908: efl_ui_slider: refactor slider widget..

change direction for vertical slider.
vertical slider's default direction is upwards now.

May 14 2018, 3:59 AM · efl

May 13 2018

eagleeye updated the diff for D5908: efl_ui_slider: refactor slider widget..

fix working with mouse wheel correctly.

May 13 2018, 10:50 PM · efl

May 2 2018

eagleeye updated the diff for D5908: efl_ui_slider: refactor slider widget..

deleted unused edc part

May 2 2018, 5:11 AM · efl

Apr 16 2018

eagleeye added a comment to D5940: ecore_event: fix backword compatibility bug.

type 0 is ECORE_EVENT_NONE, it is not used event type.

Apr 16 2018, 7:35 PM
eagleeye updated the summary of D5940: ecore_event: fix backword compatibility bug.
Apr 16 2018, 7:34 PM
eagleeye updated the summary of D5940: ecore_event: fix backword compatibility bug.
Apr 16 2018, 7:26 PM
eagleeye updated the summary of D5940: ecore_event: fix backword compatibility bug.
Apr 16 2018, 4:50 AM
eagleeye added reviewers for D5940: ecore_event: fix backword compatibility bug: woohyun, raster.
Apr 16 2018, 4:47 AM

Apr 2 2018

eagleeye added a comment to D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.

@cedric Please check my comment. After that, I will proceed next step. Thanks :)

Apr 2 2018, 4:41 AM · efl

Mar 20 2018

eagleeye added reviewers for D5844: ecore_evas: don't set in_async_render flag if not in use async render.: jypark, raster, cedric.
Mar 20 2018, 10:43 PM

Mar 15 2018

eagleeye added a comment to D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop.

I don't know if there is difference between my code and code with internal function.
Also 'efl_ui_scrollable' and 'elm_interface_scrollable' exist separately.(elm_interface_scrollable.c and efl_ui_scroll_manager.c) Therefore legacy scrollable widgets use 'elm_interface_scrollable' and new efl widgets use 'efl_ui_scrollable'.
So I think to deprecating 'elm_interface_scrollable' is too much effort. (A lot of codes will be modified)

Mar 15 2018, 5:18 AM · efl

Feb 7 2018

eagleeye added a comment to T5319: Refactor scrollable mixin.

scroll_hold_push/pop and scroll_freeze_push/pop are necessary. because slider and entry widget use these APIs.
When slider is dragging by user and slider's parent is scroller, scroller will not be moved. so scroll_freeze_push/pop is used.

Feb 7 2018, 4:07 AM · efl: widgets, Restricted Project
eagleeye added a reviewer for D5796: efl_ui_scrollable: apply scroll_hold_push/pop and scroll_freeze_push/pop: akanad.
Feb 7 2018, 4:03 AM · efl

Feb 5 2018

eagleeye added reviewers for D5790: ecore/evas: add NULL checks to handle argument is NULL.: woohyun, Jaehyun, Jaehyun_Cho, jpeg.
Feb 5 2018, 11:54 PM
eagleeye updated the diff for D5790: ecore/evas: add NULL checks to handle argument is NULL..

add NULL checks to evas_engine set/get API

Feb 5 2018, 11:52 PM

Dec 19 2017

eagleeye accepted D5690: elm: apply new scroll interface in efl_ui_list.

Looks good to me.

Dec 19 2017, 10:21 PM

Dec 17 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

add group calculate for scrolling.

Dec 17 2017, 11:01 PM

Dec 14 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

fix bug and doc.

Dec 14 2017, 11:39 PM

Dec 13 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

Change eo property name.

Dec 13 2017, 9:55 PM

Dec 12 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

fix build warning with clang.
add scroll,start and scroll,stop signal.
fix wheel event bug.

Dec 12 2017, 4:59 AM

Dec 11 2017

eagleeye updated the diff for D5418: win: apply conformant features..

Moving data values to legacy data.

Dec 11 2017, 3:45 AM
eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

Removing hidden_bar, because it is platform-dependant feature.

Dec 11 2017, 1:54 AM

Dec 6 2017

eagleeye updated the diff for D5418: win: apply conformant features..

fix edje embryo error.

Dec 6 2017, 11:32 PM

Nov 30 2017

eagleeye updated the diff for D5418: win: apply conformant features..

rebase code

Nov 30 2017, 5:26 AM
eagleeye updated the diff for D5418: win: apply conformant features..

border.edc: when indicator is bg_transparent, background is behind indicator.

hidden mode is working when CSD mode is on.
Nov 30 2017, 5:25 AM

Nov 28 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

fix build warning.

Nov 28 2017, 3:51 AM

Nov 27 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

add better example for Efl.Ui.Scroller

Nov 27 2017, 11:17 PM

Nov 14 2017

eagleeye added a comment to D5222: scroll_manager: new scoller scratch.
Nov 14 2017, 3:20 AM
eagleeye added a comment to D5222: scroll_manager: new scoller scratch.

Changes:
revert scroller base theme - It is designed for desktop use now :)
add hidden_bar style theme and EFL_UI_SCROLLBAR_MODE_HIDDEN - It is designed for mobile or tablet use.
change name efl_ui_scroll_bar to efl_ui_scrollbar and efl_ui_scroll_interactive to efl_ui_scrollable_interactive.
add test efl ui scroller 1 & 2 - first one is default scroller and second one is applied hidden_bar style.
move property related bar to Efl.Ui.Scrollbar interface.
separate EFL_UI_PAN_EVENT_CHANGED event.

Nov 14 2017, 3:19 AM
eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

Rebase commit

Nov 14 2017, 2:44 AM
eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

Update code

Nov 14 2017, 2:36 AM

Nov 9 2017

eagleeye updated the diff for D5222: scroll_manager: new scoller scratch.

Rebase and fix build warning.

Nov 9 2017, 9:05 PM