Page MenuHomePhabricator

eagleeye (김호상)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 15 2013, 12:29 AM (331 w, 2 d)
Availability
Available

Recent Activity

Jul 11 2019

eagleeye added a comment to T7923: enum Efl.Ui.Scrollbar_Mode.

I think we can't use Efl.Ui.Layout_Orientation in this case. Because this enum is related to mode of scrollbar not direction.

Jul 11 2019, 11:57 PM · efl: api, efl (efl-1.23), efl: language bindings
eagleeye added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

I add patch, https://phab.enlightenment.org/D9299 :)

Jul 11 2019, 9:51 PM · efl: api, efl (efl-1.23), efl: language bindings
eagleeye added a reviewer for D9299: Rename orientation -> image_orientation.: segfaultxavi.
Jul 11 2019, 9:47 PM · efl
eagleeye requested review of D9299: Rename orientation -> image_orientation..
Jul 11 2019, 9:43 PM · efl

Jul 3 2019

eagleeye requested review of D9215: ecore_wl2: add new APIs.
Jul 3 2019, 11:49 PM · Restricted Project, efl

Jun 26 2019

eagleeye moved T7924: enum Efl.Ui.Scrollbar_Direction from Backlog to Evaluating on the efl: api board.
Jun 26 2019, 11:08 PM · efl: api, efl (efl-1.23), efl: language bindings
eagleeye added a comment to T7924: enum Efl.Ui.Scrollbar_Direction.

If Efl.Ui.Scrollbar implements Efl.Ui.Layout_Orientable, it makes conflict on efl_ui_image_zoomable.eo.
Because efl_ui_image_zoomable.eo implements Efl.Gfx.Image_Orientable also, there are two orientation method with same name.
Do you have some ideas of avoiding conflict?

Jun 26 2019, 9:49 PM · efl: api, efl (efl-1.23), efl: language bindings

Jun 9 2019

eagleeye abandoned D9076: efl_ui_text: delete resolve ERR message..
Jun 9 2019, 9:53 PM · efl
eagleeye added a comment to D9076: efl_ui_text: delete resolve ERR message..

@eagleeye. So you think the composite attach of scroll manager can happen earlier ? I am a little bit scared that this could break other APIs as well, due to thing beeing called between constructor / finalizer

Jun 9 2019, 9:52 PM · efl

Jun 7 2019

eagleeye added a reviewer for D9076: efl_ui_text: delete resolve ERR message.: marcelhollerbach.
Jun 7 2019, 12:01 AM · efl

Jun 6 2019

eagleeye requested review of D9076: efl_ui_text: delete resolve ERR message..
Jun 6 2019, 11:52 PM · efl

May 29 2019

eagleeye accepted D9034: efl_ui: rename list empty item to list placeholder item..
May 29 2019, 11:05 PM · efl
eagleeye accepted D8582: efl_ui : refactoring efl.part in item based classes..
May 29 2019, 10:59 PM · efl

May 21 2019

eagleeye added a comment to D8922: ecore_ipc: close dialer io closer when dialer is deleted..
In D8922#163464, @zmike wrote:

I am a bit confused by this patch. At ecore_ipc.c:748 the close_on_invalidate flag is clearly set to true. Can you explain more about this or provide a case in which this behavior is different?

May 21 2019, 8:36 PM · efl

May 20 2019

eagleeye added reviewers for D8922: ecore_ipc: close dialer io closer when dialer is deleted.: barbieri, raster, Hermet.
May 20 2019, 2:26 AM · efl
eagleeye requested review of D8922: ecore_ipc: close dialer io closer when dialer is deleted..
May 20 2019, 2:25 AM · efl

Apr 25 2019

eagleeye updated the diff for D8698: evas_events: fix grab count does not become 0 with proxy object..

delete unused function.

Apr 25 2019, 12:00 AM · efl

Apr 24 2019

eagleeye updated the summary of D8698: evas_events: fix grab count does not become 0 with proxy object..
Apr 24 2019, 10:55 PM · efl
eagleeye updated the diff for D8698: evas_events: fix grab count does not become 0 with proxy object..

I'm missing eina_list_clone:)

Apr 24 2019, 10:06 PM · efl
eagleeye requested review of D8698: evas_events: fix grab count does not become 0 with proxy object..
Apr 24 2019, 4:10 AM · efl

Apr 15 2019

eagleeye accepted D8604: scroll_mgr: fix a type for some vars to be portable.
Apr 15 2019, 12:21 AM · efl

Apr 2 2019

eagleeye updated the diff for D8528: evas_callbacks: fix emission of EFL_GFX_ENTITY_EVENT_VISIBILITY_CHANGED.

fix unit test

Apr 2 2019, 9:57 PM · efl

Apr 1 2019

eagleeye added a comment to D8028: evas_object_main: use eina_list_append instead of eina_list_prepend..

To create unit test for this commit, https://phab.enlightenment.org/D8528 is necessary.

Apr 1 2019, 11:30 PM · efl
eagleeye requested review of D8528: evas_callbacks: fix emission of EFL_GFX_ENTITY_EVENT_VISIBILITY_CHANGED.
Apr 1 2019, 11:11 PM · efl

Mar 29 2019

eagleeye added a comment to D8028: evas_object_main: use eina_list_append instead of eina_list_prepend..

Now "make check" is not working. This is my test result.
Do you know why unit test is not working now?

Mar 29 2019, 4:23 AM · efl

Feb 26 2019

eagleeye requested review of D8028: evas_object_main: use eina_list_append instead of eina_list_prepend..
Feb 26 2019, 4:37 AM · efl

Feb 25 2019

eagleeye updated the diff for D7776: efl_ui_scroller: apply handling focus..

fix build error

Feb 25 2019, 6:41 PM · efl
eagleeye updated the diff for D7776: efl_ui_scroller: apply handling focus..

rebase and update config version

Feb 25 2019, 6:10 PM · efl

Feb 15 2019

eagleeye updated the diff for D7916: efl_ui_scrollable: add step size property.

Apply scale value when step size is changed.
Default value is already multiplied at 2403, 2404 line.

Feb 15 2019, 12:29 AM · efl

Feb 12 2019

eagleeye updated the diff for D7776: efl_ui_scroller: apply handling focus..

delete code.

Feb 12 2019, 8:34 PM · efl
eagleeye updated the diff for D7776: efl_ui_scroller: apply handling focus..

apply step_size_get method

Feb 12 2019, 8:28 PM · efl
eagleeye requested review of D7916: efl_ui_scrollable: add step size property.
Feb 12 2019, 6:11 PM · efl

Jan 30 2019

eagleeye updated the diff for D7776: efl_ui_scroller: apply handling focus..
  1. add Efl.Ui.Scroller key bindings
  2. We don't have a property about step. It determines scroll amount when arrow up/down is clicked. (I think step is not good naming.)
Jan 30 2019, 11:13 PM · efl

Jan 28 2019

eagleeye accepted D7812: efl_ui : fix minor defects from converity check..
Jan 28 2019, 10:50 PM · efl
eagleeye abandoned D7811: efl_model: prevent NULL pointer access.
Jan 28 2019, 10:46 PM · efl
eagleeye retitled D7811: efl_model: prevent NULL pointer access from efl_model_loop: prevent NULL pointer access to efl_model: prevent NULL pointer access.
Jan 28 2019, 10:42 PM · efl
eagleeye updated the diff for D7811: efl_model: prevent NULL pointer access.

Prevent NULL pointer access in efl_model_composite_selection

Jan 28 2019, 10:42 PM · efl
eagleeye added reviewers for D7811: efl_model: prevent NULL pointer access: Jaehyun_Cho, cedric, SanghyeonLee, woohyun.
Jan 28 2019, 10:18 PM · efl
eagleeye requested review of D7811: efl_model: prevent NULL pointer access.
Jan 28 2019, 10:15 PM · efl
eagleeye added reviewers for D7808: ecore: check fcntl return.: Jaehyun_Cho, woohyun, Hermet.
Jan 28 2019, 8:02 PM · efl
eagleeye requested review of D7808: ecore: check fcntl return..
Jan 28 2019, 8:00 PM · efl

Jan 25 2019

eagleeye added reviewers for D7776: efl_ui_scroller: apply handling focus.: SanghyeonLee, YOhoho, marcelhollerbach.
Jan 25 2019, 1:56 AM · efl
eagleeye requested review of D7776: efl_ui_scroller: apply handling focus..
Jan 25 2019, 1:54 AM · efl

Dec 19 2018

eagleeye added a comment to T5319: Refactor scrollable mixin.

@eagleeye

Could you let me know the progress of this task if it is done?

Dec 19 2018, 9:36 PM · efl: widgets, Restricted Project

Dec 5 2018

eagleeye added a reviewer for D7419: evas_box: fix calculation logic when item's weight is 0.0.: jpeg.
Dec 5 2018, 4:05 AM · efl
eagleeye added a reviewer for D7419: evas_box: fix calculation logic when item's weight is 0.0.: Jaehyun.
Dec 5 2018, 2:40 AM · efl
eagleeye requested review of D7419: evas_box: fix calculation logic when item's weight is 0.0..
Dec 5 2018, 2:39 AM · efl

Nov 19 2018

eagleeye accepted D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

SCROLL_MANAGER_CLASS is correctly applied.

Nov 19 2018, 3:12 AM · efl

Nov 18 2018

eagleeye updated the diff for D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..

fix indentation.

Nov 18 2018, 9:31 PM · efl
eagleeye updated the diff for D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..

apply efl_composite_attach.

Nov 18 2018, 9:25 PM · efl

Nov 9 2018

eagleeye requested review of D7251: efl_ui_scrollable: implement efl_ui_scrollable_content_pos_get method..
Nov 9 2018, 12:43 AM · efl

Oct 26 2018

eagleeye updated the test plan for D7216: evas: fix backward compatibility issue..
Oct 26 2018, 12:22 AM · efl
eagleeye requested review of D7216: evas: fix backward compatibility issue..
Oct 26 2018, 12:13 AM · efl

Oct 16 2018

eagleeye added a comment to D7168: evas_events: Fix wrong condtion..

Thank you for your interest :)

Oct 16 2018, 11:29 PM · efl
eagleeye added a comment to D7168: evas_events: Fix wrong condtion..

This commit also looks suspicies to me.
if mouse_grabbed is 0 but pointer mode is not AUTOGRAB nor UPDOWN. then grabbed can now get negative ... :(

Oct 16 2018, 11:25 PM · efl
eagleeye updated the summary of D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:10 PM · efl
eagleeye requested review of D7168: evas_events: Fix wrong condtion..
Oct 16 2018, 10:09 PM · efl

Oct 10 2018

eagleeye updated the diff for D7152: ecore_wl2: fix coverity issue. (Resource Leak).

add error message

Oct 10 2018, 1:22 AM · efl
eagleeye added a reviewer for D7152: ecore_wl2: fix coverity issue. (Resource Leak): marcelhollerbach.
Oct 10 2018, 12:55 AM · efl
eagleeye requested review of D7152: ecore_wl2: fix coverity issue. (Resource Leak).
Oct 10 2018, 12:54 AM · efl

Oct 3 2018

eagleeye accepted D7140: elementary entry: apply scale to all edje objects.
Oct 3 2018, 11:50 PM · efl
eagleeye accepted D7137: eina debug: fix a double unlock issue.
Oct 3 2018, 11:49 PM · efl

Sep 28 2018

eagleeye added a comment to D7120: eldbus: remove unreachable code..

Thanks. I missed reviewer out:)

Sep 28 2018, 4:50 AM · efl
eagleeye requested review of D7120: eldbus: remove unreachable code..
Sep 28 2018, 4:39 AM · efl

Sep 27 2018

eagleeye added a reviewer for D7114: elm_interface_scrollable: fix using wrong variable.: SanghyeonLee.
Sep 27 2018, 12:05 AM · efl

Sep 26 2018

eagleeye added a reviewer for D7114: elm_interface_scrollable: fix using wrong variable.: Hermet.
Sep 26 2018, 11:47 PM · efl
eagleeye requested review of D7114: elm_interface_scrollable: fix using wrong variable..
Sep 26 2018, 10:08 PM · efl

Aug 27 2018

eagleeye updated the diff for D6882: efl_input: fix problem that ref count does not become 0..

separate efl_add() and callbacks.

Aug 27 2018, 12:17 AM · efl

Aug 21 2018

eagleeye added a comment to D6882: efl_input: fix problem that ref count does not become 0..

problem occurs when mouse up callback is called.
_canvas_event_feed_mouse_updown - make a instance A
_canvas_event_feed_mouse_up_internal
_post_up_handle - copy instance A to B
_evas_canvas_event_pointer_move_event_dispatch - make a instance C

Aug 21 2018, 6:17 PM · efl
eagleeye added reviewers for D6882: efl_input: fix problem that ref count does not become 0.: Jaehyun, Jaehyun_Cho.
Aug 21 2018, 5:06 AM · efl
eagleeye requested review of D6882: efl_input: fix problem that ref count does not become 0..
Aug 21 2018, 5:05 AM · efl

Aug 1 2018

eagleeye added inline comments to D6700: ecore: fix that timers are not called in the order they were registered..
Aug 1 2018, 10:42 PM · Restricted Project
eagleeye updated the diff for D6700: ecore: fix that timers are not called in the order they were registered..

fix test case.

Aug 1 2018, 4:04 AM · Restricted Project
eagleeye updated the diff for D6700: ecore: fix that timers are not called in the order they were registered..

fix patch and make test case.

Aug 1 2018, 4:00 AM · Restricted Project

Jul 31 2018

eagleeye added a reviewer for D6700: ecore: fix that timers are not called in the order they were registered.: SanghyeonLee.
Jul 31 2018, 2:34 AM · Restricted Project
eagleeye accepted D6699: evas_events: Fix to set mouse_in state to all pointers in the seat..
Jul 31 2018, 1:20 AM · efl
eagleeye added a reviewer for D6700: ecore: fix that timers are not called in the order they were registered.: zmike.
Jul 31 2018, 12:28 AM · Restricted Project

Jul 30 2018

eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:29 PM · Restricted Project
eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:26 PM · Restricted Project
eagleeye updated the test plan for D6700: ecore: fix that timers are not called in the order they were registered..
Jul 30 2018, 11:25 PM · Restricted Project
eagleeye added reviewers for D6700: ecore: fix that timers are not called in the order they were registered.: Hermet, Jaehyun_Cho.
Jul 30 2018, 11:24 PM · Restricted Project

Jul 16 2018

eagleeye edited the content of Maintainers Reviewers.
Jul 16 2018, 8:36 PM · efl

Jul 11 2018

eagleeye added a comment to D5908: efl_ui_slider: refactor slider widget..

@JackDanielZ I'll check it out:)

Jul 11 2018, 6:28 PM · efl

Jul 10 2018

eagleeye accepted D6520: ecore_wl2&elput: correctly fill the key structure.

My issue is fixed by this patch:)
I think it is correct to delete 'xkb_keysym_to_utf8'

Jul 10 2018, 3:46 AM · efl

Jul 5 2018

eagleeye updated the summary of D6518: ecore_wl2/elput: fix range of symbol for getting key name..
Jul 5 2018, 10:22 PM · efl
eagleeye updated the test plan for D6518: ecore_wl2/elput: fix range of symbol for getting key name..
Jul 5 2018, 10:19 PM · efl
eagleeye added a reviewer for D6518: ecore_wl2/elput: fix range of symbol for getting key name.: bu5hm4n.
Jul 5 2018, 10:18 PM · efl
Herald added a reviewer for D6518: ecore_wl2/elput: fix range of symbol for getting key name.: devilhorns.
Jul 5 2018, 10:17 PM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:39 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:31 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:28 AM · efl
eagleeye updated the summary of D6504: ecore_evas: skip rendering evas and making animator tick.
Jul 5 2018, 4:28 AM · efl

Jul 4 2018

Herald added a reviewer for D6504: ecore_evas: skip rendering evas and making animator tick: devilhorns.
Jul 4 2018, 3:25 AM · efl

Jun 27 2018

eagleeye updated the diff for D6346: evas: move clearing cows to right place..

add new test case for not using evas_free() explicitly.

Jun 27 2018, 12:37 AM · efl

Jun 22 2018

eagleeye accepted D6362: elm_slider: add null check to avoid seg fault..
Jun 22 2018, 1:33 AM · efl

Jun 21 2018

eagleeye added a comment to D6346: evas: move clearing cows to right place..
In D6346#108708, @zmike wrote:

I'd like to see a unit test added to the evas suite for this case. I think that should be possible?

Jun 21 2018, 7:56 PM · efl
eagleeye updated the diff for D6346: evas: move clearing cows to right place..

call ecore_shutdown first.

Jun 21 2018, 4:25 AM · efl
eagleeye added reviewers for D6346: evas: move clearing cows to right place.: cedric, jpeg, id213sin, woohyun.
Jun 21 2018, 1:05 AM · efl

Jun 20 2018

Herald added a reviewer for D6346: evas: move clearing cows to right place.: devilhorns.
Jun 20 2018, 11:56 PM · efl

Jun 1 2018

eagleeye triaged T6974: Application crashes when evas_object_smart_data_set is called. as Showstopper Issues priority.
Jun 1 2018, 5:14 AM · efl: rendering