Page MenuHomePhabricator

felipealmeida (Felipe Magno de Almeida)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2013, 1:07 PM (323 w, 2 d)
Availability
Available

Recent Activity

Today

felipealmeida closed D9638: csharp: add legacy eo in mono blacklist.
Fri, Aug 23, 10:34 AM · efl
felipealmeida closed D9690: eolian-mono: Add support for partial classes.
Fri, Aug 23, 10:28 AM · efl
felipealmeida closed D9714: csharp: Only build extension methods for beta.
Fri, Aug 23, 10:27 AM · efl
felipealmeida closed T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono as Resolved by committing rEFLf3d9238e15ce: csharp: Add bindable factory parts support.
Fri, Aug 23, 10:18 AM · efl: mvvm
felipealmeida closed T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono, a subtask of T7627: Support Efl.Ui.Item_Factory, as Resolved.
Fri, Aug 23, 10:18 AM · efl: mvvm
felipealmeida closed D9653: csharp: Add bindable factory parts support.
Fri, Aug 23, 10:18 AM · efl
felipealmeida accepted D9653: csharp: Add bindable factory parts support.
Fri, Aug 23, 10:17 AM · efl
felipealmeida closed D9577: eolian-mono: Add support for multi-value properties with tuples.
Fri, Aug 23, 10:08 AM · efl
felipealmeida accepted D9577: eolian-mono: Add support for multi-value properties with tuples.
Fri, Aug 23, 10:07 AM · efl

Wed, Aug 21

felipealmeida requested review of D9690: eolian-mono: Add support for partial classes.
Wed, Aug 21, 12:11 PM · efl

Mon, Aug 19

felipealmeida added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

I'd really like @segfaultxavi opinion about the idea.

Mon, Aug 19, 6:29 PM · efl
felipealmeida closed D9564: csharp: MVVM parts support.
Mon, Aug 19, 6:07 PM · efl
felipealmeida added a comment to D9564: csharp: MVVM parts support.

arc patch didn't retrieve a different commit message

Mon, Aug 19, 1:40 PM · efl

Fri, Aug 16

felipealmeida requested review of D9588: eo-cxx: Add second NULL sentinel to avoid buffer overrun by efl_check.h.
Fri, Aug 16, 11:16 AM · efl
felipealmeida added a comment to T8137: Heap use after free detected from ASAN in cxx bindings generator.

The D9576 also fixes one problem with ASAN when building. For me when both patches are applied no issues appear in ASAN. Can you check that D9576 fixes the building ASAN issue? I"ll check the test one, I forgot to test it when fixing the normal build.

Fri, Aug 16, 6:17 AM

Thu, Aug 15

felipealmeida added a comment to T8093: Name conflict between class and property.

Env class has an env property. It is multi-valued, so it is not generating a problem for C# yet. But it may in the future.

Thu, Aug 15, 5:08 PM · efl: api, efl (efl-1.23), efl: language bindings
felipealmeida requested review of D9577: eolian-mono: Add support for multi-value properties with tuples.
Thu, Aug 15, 5:04 PM · efl
felipealmeida requested review of D9576: eolian-mono: Use correct allocator to free with free, and not delete.
Thu, Aug 15, 1:48 PM · efl
felipealmeida requested review of D9575: eolian-cxx: Fix use after free for base variable.
Thu, Aug 15, 1:47 PM · efl
felipealmeida claimed T8137: Heap use after free detected from ASAN in cxx bindings generator.
Thu, Aug 15, 1:19 PM

Wed, Aug 14

felipealmeida added a comment to T8048: eolian_mono: setters returning values should not be mapped to properties.

The property could still be generated, but only with get;

Wed, Aug 14, 10:15 AM · Restricted Project, efl: language bindings
felipealmeida added a comment to T8133: C#: Support multi-value properties.

Also, we can use property names in tuples, so users can set by property name instead of using ordering.

Wed, Aug 14, 10:11 AM
felipealmeida claimed T8048: eolian_mono: setters returning values should not be mapped to properties.
Wed, Aug 14, 9:59 AM · Restricted Project, efl: language bindings

Tue, Aug 13

felipealmeida added a comment to D9510: eolian: Add @static to classes.

@bu5hm4n indeed.

Tue, Aug 13, 6:52 PM · efl

Sun, Aug 11

felipealmeida accepted D9529: elementary: add tests for the efl_part support of efl_ui_property_bind..
Sun, Aug 11, 5:51 PM · efl
felipealmeida accepted D9527: elementary: add support for widget part property bind..
Sun, Aug 11, 5:51 PM · efl
felipealmeida accepted D9528: elementary: add support for efl_ui_property_bind to all efl_part inheriting from widget using reflection..

OK. This is what we needed to modify factories.

Sun, Aug 11, 5:51 PM · efl

Thu, Aug 8

felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

I'll let other people chime in. If nobody else opposes, then IMO you can go ahead and reinclude it. If that happens, then we need a solution for T8118 first, IMO.

Thu, Aug 8, 2:47 PM · BBQ, efl: data types, Restricted Project
felipealmeida updated subscribers of T7675: Do not allow static-function polymorphism.

By size I mean typing more. I'm not against it per se, but for static use it doesn't look like a good tradeoff to me. This is going to uglify bindings and I don't really see much of a difference in change the name of the method or pass a different type. It actually creates one more point for error, where people can pass wrong classes, they can't when the class is embed in the function name.

Thu, Aug 8, 2:26 PM · BBQ, efl: data types, Restricted Project
felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

About factories: what is the difference between:

Thu, Aug 8, 12:35 PM · BBQ, efl: data types, Restricted Project
felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

Do we have a use case? Features are nice, but I think they must be justifiable.

Thu, Aug 8, 12:32 PM · BBQ, efl: data types, Restricted Project

Wed, Aug 7

felipealmeida closed D9524: cxx: Fix funcptr c_args declaration..
Wed, Aug 7, 12:16 PM · efl
felipealmeida accepted D9524: cxx: Fix funcptr c_args declaration..
Wed, Aug 7, 10:51 AM · efl

Mon, Aug 5

felipealmeida closed D9457: csharp: fix ownership of value types in arrays and lists.
Mon, Aug 5, 3:30 PM · efl
felipealmeida accepted D9457: csharp: fix ownership of value types in arrays and lists.
Mon, Aug 5, 3:29 PM · efl
felipealmeida closed D9467: csharp: re-enable binbuf tests with -Dmono-beta=false.
Mon, Aug 5, 3:10 PM · efl
felipealmeida requested review of D9510: eolian: Add @static to classes.
Mon, Aug 5, 1:23 PM · efl

Wed, Jul 31

felipealmeida added a comment to D9445: efl_ui_position_manager: move from accessor to function callback.

C++ patches are pushed

Wed, Jul 31, 3:13 PM · efl
felipealmeida closed D9469: eolian-cxx: Add special type tags to make function_wrapper specializations unique.
Wed, Jul 31, 3:12 PM · efl
felipealmeida closed D9468: eolian-cxx: Generate eot files.
Wed, Jul 31, 3:12 PM · efl
felipealmeida added a comment to D9445: efl_ui_position_manager: move from accessor to function callback.

D9469 e D9468 are needed to fix the C++ binding bugs which this patch reproduces

Wed, Jul 31, 12:41 PM · efl
felipealmeida requested review of D9469: eolian-cxx: Add special type tags to make function_wrapper specializations unique.
Wed, Jul 31, 12:39 PM · efl
felipealmeida requested review of D9468: eolian-cxx: Generate eot files.
Wed, Jul 31, 12:39 PM · efl

Thu, Jul 25

felipealmeida requested review of D9412: eolian-cxx: Add binbuf and event keywords handling n.
Thu, Jul 25, 1:40 PM · efl

Jul 23 2019

felipealmeida added a comment to D9369: eolian: start to express ownership transfere.

Well, a clang frontend plugin could guarantee that EFL_TRANSFER_OWNERSHIP is written in all EFL where it should.

Jul 23 2019, 7:32 AM · efl
felipealmeida added a comment to D9369: eolian: start to express ownership transfere.

Without typing checking, how useful it really is? Can't we make it type-checked? Even if by use of extension for a single compiler?

Jul 23 2019, 7:30 AM · efl

Jul 22 2019

felipealmeida requested review of D9377: efl-js: Remove private keys for Twitter API from example.
Jul 22 2019, 6:17 PM · efl

Jul 17 2019

felipealmeida added inline comments to D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.
Jul 17 2019, 11:20 PM · efl
felipealmeida requested review of D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.
Jul 17 2019, 6:27 PM · efl
felipealmeida added a comment to T8056: Improve/Fix _add_internal_start_bindings function docs and behavior.

and https://phab.enlightenment.org/D9071

Jul 17 2019, 1:30 PM
felipealmeida added a comment to T8056: Improve/Fix _add_internal_start_bindings function docs and behavior.

This task is related to https://phab.enlightenment.org/D9070

Jul 17 2019, 1:21 PM

Apr 23 2019

felipealmeida added a comment to D8678: eo: add events to track the ownership status of an Eo object.

We can avoid the performance problems by creating a boolean if someone is registered in the event. The event won't get called most of the time because most objects have a parent anyway and the event gets called just for objects with C# wrappers.

Apr 23 2019, 5:01 PM · efl

Apr 15 2019

felipealmeida added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

So we looked into the problems of finalizers and dispose and we found out that using that is not possible. It is possible the GC collects members of a class that we decide later to ressucitate. That surely wouldn't work, because the members would not have the same state when the class is revived.

Apr 15 2019, 3:03 PM · efl: language bindings

Apr 9 2019

felipealmeida accepted D8588: csharp: Fix GetUserMethods and NativeClass.
Apr 9 2019, 5:13 PM · efl
felipealmeida closed D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 9 2019, 7:24 AM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Remove test that is not working

Apr 9 2019, 7:14 AM · efl
felipealmeida closed D8573: efl-mono: Fix --enable-mono-beta for tests.
Apr 9 2019, 7:09 AM · efl

Apr 8 2019

felipealmeida requested review of D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 8 2019, 3:49 PM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Do not register Efl.Object again and again

Apr 8 2019, 12:48 PM · efl
felipealmeida updated the diff for D8573: efl-mono: Fix --enable-mono-beta for tests.

Fix to use += instead of = in ifdef

Apr 8 2019, 12:47 PM · efl

Apr 7 2019

felipealmeida added a comment to T7773: Unhandled Exception with custom widget class.

D8574

Apr 7 2019, 8:22 AM
felipealmeida requested review of D8575: efl-mono: Fix example for new Application API for C#.
Apr 7 2019, 8:22 AM · efl
felipealmeida requested review of D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 7 2019, 8:21 AM · efl
felipealmeida added a revision to T7783: improve CI usage: D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 7 2019, 8:21 AM · Restricted Project, efl: meson
felipealmeida requested review of D8573: efl-mono: Fix --enable-mono-beta for tests.
Apr 7 2019, 8:21 AM · efl
felipealmeida added a comment to T7773: Unhandled Exception with custom widget class.

I agree with @segfaultxavi and @bu5hm4n .

Apr 7 2019, 6:49 AM

Mar 22 2019

felipealmeida accepted D8441: efl-csharp: Remove spaces from type strings in generator..
Mar 22 2019, 2:32 PM · efl

Mar 18 2019

felipealmeida added a comment to T7659: Fix efl_part issues in C#.

@segfaultxavi You're right on both questions.

Mar 18 2019, 2:36 PM · efl: mvvm

Mar 17 2019

felipealmeida requested review of D8384: efl-mono: Add Remove method to list, arrays and eina_value containers. T7401.
Mar 17 2019, 5:00 PM · efl

Mar 6 2019

felipealmeida abandoned D7857: eo: Fix efl_isa for class checking of recursively inherited types.
Mar 6 2019, 12:42 PM · DO NOT MERGE, efl

Feb 28 2019

felipealmeida added a reviewer for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: SanghyeonLee.
Feb 28 2019, 5:28 PM · efl: language bindings, Restricted Project
felipealmeida added a project to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: DO NOT MERGE.
Feb 28 2019, 5:27 PM · efl: language bindings, Restricted Project
felipealmeida added reviewers for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: cedric, lauromoura, bu5hm4n, zmike.
Feb 28 2019, 5:27 PM · efl: language bindings, Restricted Project
felipealmeida requested review of D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Feb 28 2019, 5:24 PM · efl: language bindings, Restricted Project

Feb 1 2019

felipealmeida added a comment to D7860: eo: fix efl_isa to work propertly with interfaces.

I'd never think that the class vtable contains the object's vtable. I thought the klass vtable would contain only the vtable for Efl_Class and Efl_Object methods.

Feb 1 2019, 3:45 AM · efl
felipealmeida requested review of D7858: efl-cxx: Fix compilation error when using a ptr to const any_value.
Feb 1 2019, 12:15 AM · efl

Jan 31 2019

felipealmeida requested review of D7857: eo: Fix efl_isa for class checking of recursively inherited types.
Jan 31 2019, 11:23 PM · DO NOT MERGE, efl
felipealmeida added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

Going to add _append, _prepend (for cases without an anchoring child, so beggining and end) and _insert_at for index. Going to do that after I come back to Brazil next week.

Jan 31 2019, 1:31 AM · efl

Jan 27 2019

felipealmeida closed D7794: eolian-cxx: Add constructor_def.
Jan 27 2019, 11:23 PM · efl
felipealmeida closed D7793: elementary: Declare style as a Widget constructor.
Jan 27 2019, 11:19 PM · efl
felipealmeida accepted D7793: elementary: Declare style as a Widget constructor.
Jan 27 2019, 11:19 PM · efl
felipealmeida closed D7792: eo: Replace ptr(Eina.Strbuf) with plain strbuf..
Jan 27 2019, 11:15 PM · efl
felipealmeida accepted D7794: eolian-cxx: Add constructor_def.
Jan 27 2019, 11:10 PM · efl
felipealmeida accepted D7792: eo: Replace ptr(Eina.Strbuf) with plain strbuf..
Jan 27 2019, 11:08 PM · efl
felipealmeida added a comment to D7789: eolian-mono: Provide constructor parameters based on the constructors section of the Eo files..

I've updated examples.git with new syntax from this diff.

Jan 27 2019, 11:05 PM · efl
felipealmeida closed D7780: efl_ui_list_view_seg_array: remove seg_array from Elementary.h.
Jan 27 2019, 10:45 PM · efl
felipealmeida accepted D7780: efl_ui_list_view_seg_array: remove seg_array from Elementary.h.
Jan 27 2019, 10:39 PM · efl
felipealmeida requested review of D7789: eolian-mono: Provide constructor parameters based on the constructors section of the Eo files..
Jan 27 2019, 7:47 AM · efl

Jan 25 2019

felipealmeida requested review of D7770: efl-mono: Add new dependencies to autotools.
Jan 25 2019, 12:38 AM · efl

Jan 24 2019

felipealmeida closed D7724: efl_ui_list_view: Hide SegArray and PreciseLayouter.
Jan 24 2019, 5:30 AM · efl
felipealmeida accepted D7724: efl_ui_list_view: Hide SegArray and PreciseLayouter.
Jan 24 2019, 5:29 AM · efl

Jan 21 2019

felipealmeida added a comment to T7523: eolian inlist-inarray.

inlists should allow any value-type, not just structs.

Jan 21 2019, 5:13 AM · efl: language bindings, Restricted Project

Jan 18 2019

felipealmeida closed D7683: efl-mono: Fix calling non-static methods with garbage collectable NativeInherits.
Jan 18 2019, 5:06 AM · efl
felipealmeida requested review of D7683: efl-mono: Fix calling non-static methods with garbage collectable NativeInherits.
Jan 18 2019, 1:37 AM · efl

Jan 17 2019

felipealmeida closed D7675: efl-mono: Fix lots of warnings in tests.
Jan 17 2019, 5:46 AM · efl
felipealmeida closed D7633: eolian-cxx: Fix order of initialization.
Jan 17 2019, 5:45 AM · efl
felipealmeida added a commit to T7240: Not allow multi class inheritance in eo: rEFL8e487069c970: eolian: add api to access the requires field.
Jan 17 2019, 5:23 AM · efl: language bindings, Restricted Project
felipealmeida closed D7674: eolian: add api to access the requires field.
Jan 17 2019, 5:23 AM · efl
felipealmeida accepted D7674: eolian: add api to access the requires field.
Jan 17 2019, 5:22 AM · efl
felipealmeida closed D7637: efl-mono: Enable selecting to build @beta items.
Jan 17 2019, 4:52 AM · efl