Page MenuHomePhabricator

felipealmeida (Felipe Magno de Almeida)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jun 12 2013, 1:07 PM (287 w, 2 d)
Availability
Available

Recent Activity

Sat, Dec 8

felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

The MVVM-way would be to set these properties in the ProxyModel instead of the item itself. And let Factory or Create event bind the ProxyModel properties to item.

Sat, Dec 8, 2:56 AM · efl: widgets, Restricted Project
felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

Between cloning and just using Create event I vote for the second. I think both approaches run from MVVM in the end.

Sat, Dec 8, 2:53 AM · efl: widgets, Restricted Project

Wed, Dec 5

felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

w.r.t using Efl_Part, I find it OK. But I don't really see much improvement in C, syntax-wise and makes for a confusing lifetime of references. For C# it does give better syntax IMO.

Wed, Dec 5, 9:40 AM · efl: widgets, Restricted Project
felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

I think we had dropped the proxy idea in Korea. I do not like it very much because it requires the factory to know too much about the item's internals.

Wed, Dec 5, 9:37 AM · efl: widgets, Restricted Project

Thu, Nov 29

felipealmeida accepted D7332: elementary: make Efl.Ui.Factory.create asynchronous..
Thu, Nov 29, 9:49 AM · efl

Thu, Nov 22

felipealmeida added a comment to T7480: Add multi factory class.

Should this be specific to one property?

Thu, Nov 22, 2:25 PM · efl: data types, Restricted Project
felipealmeida added a comment to T7470: [MVVM] Create a ViewModel helper class.

I think we should probably leave for bindings to do the kind of magic that eases coding.

Thu, Nov 22, 2:25 PM

Sun, Nov 18

felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

The idea, at first, would be to create the class dynamically in C# when loading a edje compiled file. Using "dynamic" keyword. I haven't tried to see if it is really possible.

Sun, Nov 18, 9:24 AM · efl: widgets, Restricted Project
felipealmeida added a comment to T5365: Use efl.part for efl.ui.model.connect.

I discussed with SangHyeon the idea of generating classes from edje files with parts information, what do you think?

Sun, Nov 18, 5:46 AM · efl: widgets, Restricted Project
felipealmeida added a comment to T7470: [MVVM] Create a ViewModel helper class.

Maybe we want ViewModel to handle UI configuration in imperative paradigm, or should it stay as Eina_Value's only?

Sun, Nov 18, 4:32 AM
felipealmeida added a comment to T7469: Find a better name for Efl.Factory.model_connect.

property_link ?

Sun, Nov 18, 4:01 AM · Restricted Project, efl
felipealmeida added a comment to T7469: Find a better name for Efl.Factory.model_connect.

Maybe use linking instead of connect. And drop model altogether?

Sun, Nov 18, 4:01 AM · Restricted Project, efl

Nov 8 2018

felipealmeida added a comment to T6128: Generate C# reference API documentation.

@segfaultxavi yeah. That's a problem. I think manually documenting it for the site would be necessary.

Nov 8 2018, 8:37 AM · efl: language bindings, efl: docs
felipealmeida added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Maybe autotools could be left out since nothing needs it yet. Do we have a plan to deprecate and drop autotools support?

Nov 8 2018, 8:34 AM · efl
felipealmeida added a comment to T7441: [MVVM] Changes to Efl Data Model.

Yes, I think it is all good. We just would need to modify a little bit the parts generation for C#, allow it to use overload on the property set so it can call SetContent/SetText.

Nov 8 2018, 8:32 AM

Nov 6 2018

felipealmeida added a comment to T7405: [MVVM] Multistyle Factory.

Hello, you can ignore Larry's comment. He was not aware the discussion is about modifying the current code. I think we can keep ourselves to T441.

Nov 6 2018, 5:03 PM
felipealmeida added a comment to T7441: [MVVM] Changes to Efl Data Model.
  1. The role of parent is just for lifetime, you don't need it in C#.
Nov 6 2018, 5:02 PM

Oct 30 2018

felipealmeida added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

https://phab.enlightenment.org/D7221

Oct 30 2018, 1:14 PM · efl: language bindings
felipealmeida requested review of D7221: eolian: Add @ctor_param parameter to constructors.
Oct 30 2018, 1:13 PM · efl
felipealmeida added a comment to T7441: [MVVM] Changes to Efl Data Model.

Exactly.

Oct 30 2018, 5:31 AM

Oct 26 2018

felipealmeida added a comment to T7441: [MVVM] Changes to Efl Data Model.
liFac.CreateEvent += (object, model, parent, style) {
if (style == "default") {
  var item = (Efl.Ui.ListDefaultItem) object;
  item.icon = imgFac.Create(model, object);
  item.label. model.PropertyGet("label");
}
else if (style == "title") {
  var item = (Efl.Ui.ListTitleItem) object;
  item.icon = imgFac.Create(model, object);
  item.label = model.PropertyGet("label");
}}
Oct 26 2018, 7:09 AM

Oct 24 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Hello @segfaultxavi . It is not restricted to Widgets. People may want to inherit Thread objects, or some other kind of Objects. I don't think we can run away from inheritance in a OO-language/world.

Oct 24 2018, 1:48 PM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7405: [MVVM] Multistyle Factory.

We could connect item.label by passing a Observable_Value like defined in https://phab.enlightenment.org/T7441

Oct 24 2018, 1:46 PM
felipealmeida created T7441: [MVVM] Changes to Efl Data Model.
Oct 24 2018, 10:07 AM

Oct 23 2018

felipealmeida accepted D7181: meson: here comes cxx bindings.
Oct 23 2018, 11:58 AM · efl
felipealmeida added a comment to T7404: [MVVM] Factory text property handles.

I'm thinking we should probably change Model interface. Instead of using "properties,changed" event, we should have a property_get which returns a Observable_Value. This value would have an event for when its value changes, but we could, too, set this Observable_Value to parts. This way, parts could refresh the changes whenever the Observable_Value changes too.

Oct 23 2018, 11:57 AM
felipealmeida added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

I'm not sure it is possible to optimize that much, maybe we should run a profiler and see where the CPU usage is. But, we can't slice it less because calculation needs to be done for all items for perfect scroll size.

Oct 23 2018, 11:54 AM
felipealmeida added a comment to T7379: [MVVM] Support disabled composite model.

I think when we finish selection, this should be trivial. The merge that cedric did, did change model's interface and it broke quite a few model implementations. So, we are working on that as well.

Oct 23 2018, 11:52 AM
felipealmeida added a comment to T7377: [MVVM] Model Insertion Features.

We're in agreement here. Need to add that to model and implement it in all models.

Oct 23 2018, 11:51 AM
felipealmeida added a comment to T7376: [MVVM] Model Selection Support.

We agree with that. If I'm not mistaken some of this API is already in master, right?

Oct 23 2018, 11:37 AM
felipealmeida added a comment to D7181: meson: here comes cxx bindings.

@segfaultxavi The C++ tests fail?

Oct 23 2018, 11:12 AM · efl

Sep 27 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I'm not sure removing Mixin from inheritance tree helps in anyway.

Sep 27 2018, 12:14 PM · efl: language bindings, Restricted Project

Sep 26 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Well, maybe I'm missing something. How a C# user would inherit from a mixin directly. If the user inherits from a class that inherits from a mixin it works OK, because the class has the method. But then it couldn't inherit from a mixin and get called from C or call in C.

Sep 26 2018, 7:43 AM · efl: language bindings, Restricted Project
felipealmeida updated subscribers of T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

@Jaehyun Wouldn't it be the same as calling the parent method? Remember that the parent class still has implementations for all methods you would override.

Sep 26 2018, 7:35 AM · efl: language bindings, Restricted Project

Sep 25 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Couldn't we just not generate mixin classes at all and just include the methods in the class definition?

Sep 25 2018, 10:55 AM · efl: language bindings, Restricted Project

Sep 20 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

So, one problem is that if a mixin is allowed to inherit from regular classes, then it can't be generated as an interface.

Sep 20 2018, 6:52 PM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7248: C# Bindings automated TC.

@woohyun Since the TCT for Tizen is higher priority, we're working on that specifically. Which is doing just "implements" and methods defined in the actual class. by default.

Sep 20 2018, 3:17 PM · efl: language bindings

Sep 13 2018

felipealmeida added a comment to T6128: Generate C# reference API documentation.

@lauromoura Kolesa will probably rewrite the generator, we can then later fix anything that comes by. This has the advantage that the C generator will already generate DokuWiki-syntax and do whatever beautification that may be needed.

Sep 13 2018, 12:37 PM · efl: language bindings, efl: docs
felipealmeida added a comment to T6128: Generate C# reference API documentation.

@lauromoura We already do that with src/scripts/elua generator for C#.

Sep 13 2018, 12:36 PM · efl: language bindings, efl: docs
felipealmeida added a comment to T7375: Support widget styles in C# bindings.

I'm OK with @segfaultxavi proposal.

Sep 13 2018, 8:36 AM · efl

Sep 12 2018

felipealmeida added a comment to T7356: EO: Support elm_config APIs.

Maybe we could have a string enum in Eolian?

enum config_common_keys
{
  finger_size = "finger_size",
  scale = "scale",
 ...
}
Sep 12 2018, 3:10 PM · efl, Restricted Project

Sep 11 2018

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Hello @Jaehyun_Cho : We discussed in Korea that abstract classes should _NOT_ inherit from regular classes for our changes in C# to work correctly, is that still possible?

Sep 11 2018, 1:02 PM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7375: Support widget styles in C# bindings.

@segfaultxavi I'm not sure it does yet. But it should. Otherwise how is the user suppose to know it must call the method in the passing lambda or inside efl_add, instead of just setting that after instantiation? Documentation must be explicit about it, IMO.

Sep 11 2018, 12:10 PM · efl
felipealmeida added a comment to T7375: Support widget styles in C# bindings.

@segfaultxavi @Jaehyun_Cho So you want a way to transform some very very special constructors into parameters to classes's constructors, in this case for style. There could be a way, but using constructors {} should be kept as-is IMO because it must be available for documentation purposes.

Sep 11 2018, 6:50 AM · efl

Sep 10 2018

felipealmeida added a comment to T7375: Support widget styles in C# bindings.
class ButtonAnchor : Button
{
  ButtonAnchor () : base((efl.ui.Button b) => { b.SetStyle("anchor"); })
  {}
}
Sep 10 2018, 1:08 PM · efl
felipealmeida added a comment to T7375: Support widget styles in C# bindings.

We did use "constructors" {} before for C++ and it wasn't great.

Sep 10 2018, 12:03 PM · efl

Sep 4 2018

felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

@Jaehyun_Cho is already working on part of the inheritance problem, so maybe @Jaehyun_Cho could work on this new parts as well? If not, could you let us know @Jaehyun_Cho ?
Regards,

Sep 4 2018, 8:49 AM · efl: language bindings, Restricted Project

Aug 31 2018

felipealmeida requested review of D6959: eolian-cxx: Fix parallel compilation for eolian_cxx_test_wrapper.cc.
Aug 31 2018, 6:13 PM · efl

Aug 23 2018

felipealmeida added a comment to D6895: eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig.

pkgconfig sets parameters for eolian_gen which include -S parameters. But if the same variable is passed as parameters to eolian_cxx they fail because eolian_cxx doesn't understand -S parameter. Which it doesn't need to understand, but it shouldn't fail.

Aug 23 2018, 5:00 PM · efl

Aug 22 2018

felipealmeida requested review of D6897: eolian-cxx: Remove test that can't be implemented.
Aug 22 2018, 7:47 PM · efl
felipealmeida abandoned D6896: eolian-cxx: Remove test that can't be implemented.

patch is wrong

Aug 22 2018, 7:44 PM · efl
felipealmeida requested review of D6896: eolian-cxx: Remove test that can't be implemented.
Aug 22 2018, 7:43 PM · efl
felipealmeida requested review of D6895: eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig.
Aug 22 2018, 7:39 PM · efl
felipealmeida added a comment to T7341: Eolian_cxx inherit example not part of the build.

Being able to inherit from other classes in C++ was removed, but I have a branch which adds this feature back. So, the example can be removed and I can readd the example fixed with the new syntax for the new feature.

Aug 22 2018, 11:32 AM

Aug 21 2018

Herald closed T7334: Create C# syntax to allow using registering and emiting events defined in other classes as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Aug 21 2018, 11:58 PM · efl (efl-1.22)
Herald closed T7334: Create C# syntax to allow using registering and emiting events defined in other classes as Invalid.

The Enlightenment ticket system is currently receiving high amounts of spam tickets. This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Aug 21 2018, 11:57 PM · efl (efl-1.22)

Aug 20 2018

felipealmeida accepted D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 20 2018, 9:03 PM · efl

Aug 18 2018

felipealmeida updated subscribers of T7248: C# Bindings automated TC.
Aug 18 2018, 6:30 PM · efl: language bindings
felipealmeida claimed T7248: C# Bindings automated TC.
Aug 18 2018, 6:30 PM · efl: language bindings
felipealmeida added a comment to T7248: C# Bindings automated TC.

Shouldn't every single method for a class be generated? Including from all interfaces and bases?
That should include implements and not implements as well.

Aug 18 2018, 6:29 PM · efl: language bindings
felipealmeida added a comment to T7241: Removing underline('_') in class name in C# bindings.

@Jaehyun_Cho Yes. It will be done for C#.

Aug 18 2018, 6:26 PM · efl: language bindings
felipealmeida added a comment to T7273: eolian_cxx Makefile.examples broken.

You can leave it open for now. I'll fix eina-cxx and mono soon.

Aug 18 2018, 6:22 PM · Restricted Project, efl: language bindings

Aug 14 2018

felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

I could use extension methods to add methods, but the problem is not methods, I must generate the same inheritance tree as well. So, for example, E must be convertible to A, B, C and D and be used as-if we had an A, B, C and D.
But since A, B, C and D are classes, and not interfaces or mixins, I can't create this inheritance-ship.

Aug 14 2018, 5:00 PM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7204: Discussion about C# binding syntax.

It was seen at the time that Evas_Core was not supposed (only Evas Canvas) to be used by bindings and be an implementation detail only. I think this was true because elementary was to be seen as the high-level API. Since implementers will be using Evas directly, then this may need to change. Shouldn't Evas be Eolized then?

Aug 14 2018, 4:48 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Aug 13 2018

felipealmeida added a comment to T7283: Which feature proposals are you opposed to during the next development cycle?.

How do I add items to the voting?

Aug 13 2018, 10:40 AM · major change, efl: release team, efl (efl-1.22)
felipealmeida requested review of D6821: efl-cxx: Add -Wno-shadow to disable huge warnings in C++.
Aug 13 2018, 8:10 AM · efl
felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

I'll create another diff then.

Aug 13 2018, 8:04 AM · Restricted Project
felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

Yes you did say. But did you test it? I've test it and it worked for me on clang 6.0.1.

Aug 13 2018, 7:59 AM · Restricted Project

Aug 12 2018

felipealmeida updated the diff for D6811: cxx: suppress -Wshadow warnings for all cxx build files.

Updating D6811: cxx: suppress -Wshadow warnings for all cxx build files

Aug 12 2018, 5:41 PM · Restricted Project

Aug 10 2018

felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

It should be. But i think we may need to explicitly add a no shadow. Because some other -W directive may enable it too. Putting it at the end should be enough to disable it

Aug 10 2018, 9:43 AM · Restricted Project
felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

I'm not opposed to filtering or adding explicitly a -Wno-shadow in configure.ac. i can test it today. CPPFLAGS should include include directives for both C and C++ while warnings should be set in CFLAGS.

Aug 10 2018, 9:38 AM · Restricted Project
felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

I'm not opposed to filtering or adding explicitly a -Wno-shadow in configure.ac. i can test it later today.

Aug 10 2018, 9:36 AM · Restricted Project
felipealmeida added a comment to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

Why does it have to be set as CFLAGS? It doesn't make sense to set CXXFLAGS as CFLAGS.

Aug 10 2018, 9:30 AM · Restricted Project
felipealmeida requested changes to D6811: cxx: suppress -Wshadow warnings for all cxx build files.

This patch is ridiculous. Do not use -Wshadow on CXX_FLAGS!

Aug 10 2018, 9:23 AM · Restricted Project

Aug 1 2018

felipealmeida added a comment to T7204: Discussion about C# binding syntax.
Aug 1 2018, 5:40 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
felipealmeida closed D6707: elementary: efl_ui_view_list cleanup.
Aug 1 2018, 3:53 PM · efl
felipealmeida accepted D6707: elementary: efl_ui_view_list cleanup.
Aug 1 2018, 3:40 PM · efl
felipealmeida closed D6667: Efl.Ui.Layout.Factory: added missing factory_model_connect.
Aug 1 2018, 3:37 PM · efl

Jul 29 2018

felipealmeida added a comment to T7204: Discussion about C# binding syntax.

So, actually there is quite a few multiple inheritance:

Jul 29 2018, 6:52 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
felipealmeida updated subscribers of T7204: Discussion about C# binding syntax.
Jul 29 2018, 6:48 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Jul 24 2018

felipealmeida updated subscribers of T7204: Discussion about C# binding syntax.
Jul 24 2018, 7:33 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
felipealmeida updated subscribers of T7204: Discussion about C# binding syntax.
Jul 24 2018, 7:30 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
felipealmeida triaged T7204: Discussion about C# binding syntax as High priority.
Jul 24 2018, 7:30 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Jul 23 2018

felipealmeida reassigned T7181: Life tutorial C# cannot be paused / resumed from lauromoura to vitor.sousa.
Jul 23 2018, 6:13 AM · efl: language bindings, efl: docs, examples

Jul 20 2018

felipealmeida edited the content of Maintainers Reviewers.
Jul 20 2018, 8:27 AM · efl

Jul 18 2018

felipealmeida added a comment to T7161: C# bindings: EFL classes cannot be inherited from.

@segfaultxavi We can't use the same classes for inheritance and normal use because the calls made through Eo do not arrive at the C# side. They are bound dynamically directly by Eo and calls the C function that corresponds to the correct method in Eo inheritance tree. The *Inherit suffixed classes actually create a new Eo class dynamically and that's why they work for inheritance.

Jul 18 2018, 9:48 AM · efl (efl-1.22), efl: language bindings

Jun 28 2018

felipealmeida reassigned T6131: Introduction on how to get started with EFL C# from felipealmeida to segfaultxavi.
Jun 28 2018, 2:47 PM · efl: language bindings, efl: docs
felipealmeida reassigned T6129: Write tutorials, guides and examples in C# from felipealmeida to segfaultxavi.

The examples that make sense in C# are already converted in tools/examples.git. Lacking converting tutorials and guides based on those examples.

Jun 28 2018, 2:46 PM · efl: language bindings, efl: docs

May 17 2018

felipealmeida accepted D6175: efl_mono: Start generating eina future in eolian_mono..
May 17 2018, 11:38 AM · efl
felipealmeida accepted D6174: efl_mono: Initial support for Futures/Promises.
May 17 2018, 11:37 AM · efl
felipealmeida accepted D6173: efl_mono: Fix eldbus warnings and typo..
May 17 2018, 11:37 AM · efl
felipealmeida accepted D6172: efl_mono: Add support for Eina.Error/Empty in eina.Value.
May 17 2018, 11:36 AM · efl
felipealmeida accepted D6171: efl_mono: Add documentation tag in part decl.
May 17 2018, 11:36 AM · efl
felipealmeida accepted D6170: efl_mono: Fix generation of event arguments.
May 17 2018, 11:35 AM · efl

May 12 2018

felipealmeida abandoned D4986: elm: efl_ui_list partial implementation.

A updated version of this patch was pushed to master already.

May 12 2018, 8:13 AM · efl

Apr 25 2018

felipealmeida abandoned D4036: eolian: eina: Add _then suffixed functions as convenience for promise functions.
Apr 25 2018, 12:51 PM
felipealmeida accepted D5998: efl_mono: Names fixes after the big rename.
Apr 25 2018, 12:49 PM
felipealmeida accepted D5997: efl_mono: Fix support for event arguments..
Apr 25 2018, 12:48 PM
felipealmeida accepted D5996: efl_mono: Actually test events by passing things by value and structs.
Apr 25 2018, 12:45 PM
felipealmeida accepted D5995: efl_mono: Move event generators to its own header..
Apr 25 2018, 12:44 PM