Page MenuHomePhabricator

godlytalias (Godly T Alias)
Software Engineer

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
May 17 2015, 10:51 PM (230 w, 5 d)
Availability
Available

Coding Mania

Recent Activity

Thu, Oct 17

godlytalias added a comment to D10439: Elm_Widget: Del pre hook should be able to return bool value.

@zmike please let me know which elm unit test is failing and on how to execute and test

Thu, Oct 17, 11:29 PM · efl
godlytalias requested review of D10439: Elm_Widget: Del pre hook should be able to return bool value.
Thu, Oct 17, 6:49 AM · efl

Jul 12 2019

godlytalias added a reviewer for D9214: Evas Events: Decrement grab count on freeze state: Hermet.
Jul 12 2019, 1:37 AM · efl

Jul 11 2019

godlytalias updated the diff for D9214: Evas Events: Decrement grab count on freeze state.

Rebasing

Jul 11 2019, 7:02 AM · efl
godlytalias updated the diff for D9214: Evas Events: Decrement grab count on freeze state.

Optimized usage of list iterator

Jul 11 2019, 5:06 AM · efl

Jul 10 2019

godlytalias added a comment to D9214: Evas Events: Decrement grab count on freeze state.

Please find my comments

Jul 10 2019, 6:07 AM · efl
godlytalias added a comment to D9214: Evas Events: Decrement grab count on freeze state.
In D9214#170003, @zmike wrote:

This needs some work and more testing. I've created an example unit test for this functionality; please add another test to verify the exact issue that you are trying to resolve.

Jul 10 2019, 3:00 AM · efl
godlytalias updated the diff for D9214: Evas Events: Decrement grab count on freeze state.

Updating with the content of duplicate diff D9248, some code review changes also included

Jul 10 2019, 2:58 AM · efl

Jul 9 2019

godlytalias added reviewers for D9248: Evas Events: Decrement grab count on freeze state: zmike, Hermet.
Jul 9 2019, 1:35 AM · efl
godlytalias requested review of D9248: Evas Events: Decrement grab count on freeze state.
Jul 9 2019, 1:33 AM · efl

Jul 3 2019

godlytalias requested review of D9214: Evas Events: Decrement grab count on freeze state.
Jul 3 2019, 7:42 AM · efl

May 28 2019

godlytalias added a comment to D9019: Genlist: Fix for genlist item field update.

@SanghyeonLee Any changes needed for this patch? Should we mark item for update even in text update? Only in case of multiline text items we may have to do item update on a text update

May 28 2019, 4:30 AM · efl

May 24 2019

godlytalias requested review of D9019: Genlist: Fix for genlist item field update.
May 24 2019, 4:44 AM · efl

Nov 22 2017

godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
In D5428#94545, @raster wrote:

well i see it as a bug. what you might do is come up with a way of having "empty blocks" that have not been filled in/realized yet and padthese between start and "item show" point.

@raster
With empty blocks also, as we won't be able to know the block size before processing items in block, we may end up with pan object size changes during processing of items in queue.
One working solution which I found is pausing processing of items in queue when a user scroll happens so that pan object size and position will not be disturbed and then resume processing when user stops scrolling. But I am not sure whether it is acceptable.

Nov 22 2017, 6:40 AM · efl

Nov 21 2017

godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

@raster
Yes. This is a known limitation with this approach and I was trying some solutions to handle this. As we are not processing items in proper top to down order, and items are getting filled to both top & bottom directions of list from the show item position, So when user is scrolling, the anchor item logic cannot hold and as pan object height is changing, scroll position jumps are happening. I will update patch once some good solution on this is done.

Nov 21 2017, 11:31 PM · efl
godlytalias updated the diff for D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

Block processing improved

Nov 21 2017, 7:52 AM · efl
godlytalias updated the diff for D5499: Genlist: Test Cases for Genlist Item Show on Launch.

Adding test case to prepend items while genlist queue is processing

Nov 21 2017, 7:49 AM · efl

Nov 20 2017

godlytalias added a parent revision for D5499: Genlist: Test Cases for Genlist Item Show on Launch: D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
Nov 20 2017, 5:13 AM · efl
godlytalias added a child revision for D5428: Elementary: Performance Optimization for Genlist Item Show on launch: D5499: Genlist: Test Cases for Genlist Item Show on Launch.
Nov 20 2017, 5:13 AM · efl
godlytalias created D5499: Genlist: Test Cases for Genlist Item Show on Launch.
Nov 20 2017, 2:40 AM · efl
godlytalias updated the diff for D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

Improving the scroll deferring logics and scrolling when item cannot be scrolled to scroll_to position

Nov 20 2017, 2:08 AM · efl

Nov 15 2017

godlytalias closed D5474: CtxPopup: Add implementation for getting focused item.
Nov 15 2017, 2:30 AM
godlytalias updated the diff for D5474: CtxPopup: Add implementation for getting focused item.

Focused item get API will be valid only when ctxpopup holds items,
If there is no items then this API don't have to handle anything.

Nov 15 2017, 2:03 AM

Nov 14 2017

godlytalias added reviewers for D5474: CtxPopup: Add implementation for getting focused item: shilpasingh, jpeg.
Nov 14 2017, 6:24 AM
godlytalias created D5474: CtxPopup: Add implementation for getting focused item.
Nov 14 2017, 6:16 AM

Nov 10 2017

godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

@raster Yes, I'm making test cases for all scenarios and that is how I was able to find those issues, Was not sure whether to push all the scenarios to elementary test, However I will try to cover all the scenarios with the changes and will update elementary test too. Thanks for the review.

Nov 10 2017, 9:59 PM · efl
godlytalias updated the diff for D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

Fixes for processing items with relatives

Nov 10 2017, 4:36 AM · efl

Nov 9 2017

godlytalias updated the diff for D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

Removing unwanted changes

Nov 9 2017, 4:57 AM · efl
godlytalias updated the diff for D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

Deffering scroll till genlist takes a height to support ELM_GENLIST_SCROLLTO_MIDDLE

Nov 9 2017, 4:52 AM · efl

Nov 8 2017

godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.

The idea is actually I have been discussed with hyuksoon choi, but when I applied it in our tizen,
It gave lots of bugs so I abandoned it. I guess there were some mistake of mine, so I hope this one working well.let me check about it.
Thanks to apply this feature :)

Nov 8 2017, 6:24 AM · efl
godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
In D5428#92926, @raster wrote:

how do you ensure the item stays in the viewport? do you keep moving the scroller viewport/position around as you calculate items before.after the show item?

Nov 8 2017, 12:19 AM · efl

Nov 7 2017

godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
In D5428#92922, @raster wrote:

but how do you know WHERE the "show item" is without knowing the size od all items before it? imagine a list of 10,000 items. and you want to show item 9,900. you dont know where to jump to because you need all the 9899 before it to be calculated ... ? you dont know where the block is because you dont knwo the size of prior blocks.... :/

Nov 7 2017, 11:31 PM · efl
godlytalias added a comment to T6263: Genlist Reorder Restriction Feature.
In T6263#104087, @jpeg wrote:

Do we really want that many new features in genlist? Genlist is so damn complex and full of bugs already :(
Not saying the feature isn't good, or the patch either, just saying that the maintenance cost needs to not grow too much :)

Nov 7 2017, 6:14 AM · efl: widgets, Restricted Project
godlytalias updated subscribers of T6263: Genlist Reorder Restriction Feature.
Nov 7 2017, 6:12 AM · efl: widgets, Restricted Project

Nov 6 2017

godlytalias retitled D5428: Elementary: Performance Optimization for Genlist Item Show on launch from Elementary: Genlist Show Performance Optimization to Elementary: Performance Optimization for Genlist Item Show on launch.
Nov 6 2017, 6:18 PM · efl
godlytalias added a comment to D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
In D5428#92578, @raster wrote:

only if the list is homogenous does genlist know the size of a block... in the case it is not... what is the point of assigning items to blocks when size is still unknown?

Nov 6 2017, 6:16 PM · efl
godlytalias updated the summary of D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
Nov 6 2017, 7:48 AM · efl
godlytalias created D5428: Elementary: Performance Optimization for Genlist Item Show on launch.
Nov 6 2017, 7:38 AM · efl

Nov 1 2017

godlytalias closed T6241: Genlist Item Pin Feature as Resolved.
Nov 1 2017, 2:25 AM · efl

Oct 30 2017

godlytalias added a comment to D5340: Genlist Item Pin Feature.

Yeah but just for make sure about it,
could you please re-commit with changing commit msg or few line gaps?
then we could check jenkins build result once again. I think there should be no-problem..

Oct 30 2017, 11:12 PM · efl
godlytalias updated the diff for D5340: Genlist Item Pin Feature.

Re-commit for jenkins build check

Oct 30 2017, 11:04 PM · efl

Oct 27 2017

godlytalias added a comment to D5340: Genlist Item Pin Feature.

Is it finished all?
I don't know why jenkins got build failed message, but its working well in my local.

Oct 27 2017, 12:41 AM · efl

Oct 24 2017

godlytalias created D5367: Genlist Reorder Restriction Feature.
Oct 24 2017, 8:46 AM · efl
godlytalias created T6263: Genlist Reorder Restriction Feature.
Oct 24 2017, 8:45 AM · efl: widgets, Restricted Project

Oct 23 2017

godlytalias added a comment to D5340: Genlist Item Pin Feature.

@jpeg In a list with group items, There will be no stacking above in Z direction, always it will be placed below (Y Direction).
if the group item (parent) of pinned item is realized, the pin item will stay below its group item.
Other group items (non parent of the pinned item) when reaches above the screen, pin item will remain on top of the list and group items will stay below the pin item (Y Direction)

Oct 23 2017, 12:56 AM · efl

Oct 22 2017

godlytalias updated the diff for D5340: Genlist Item Pin Feature.

Handling pin item deletion

Oct 22 2017, 11:20 PM · efl

Oct 18 2017

godlytalias added a comment to D5340: Genlist Item Pin Feature.

@SanghyeonLee This concept works with cases which have group index items too in the list,
You can check elementary_test->Genlist Group -> Double click item

Oct 18 2017, 11:27 PM · efl
godlytalias updated subscribers of D5340: Genlist Item Pin Feature.
Oct 18 2017, 11:16 PM · efl
godlytalias updated the summary of D5340: Genlist Item Pin Feature.
Oct 18 2017, 7:52 AM · efl
godlytalias created T6241: Genlist Item Pin Feature.
Oct 18 2017, 7:51 AM · efl
godlytalias retitled D5340: Genlist Item Pin Feature from Genlist Item Pin Feature @feature This feature enables genlist to pin an item to viewport which will be available always for user to view/select. Use Case: In a big list of music, most times when user finds a song which they like, before... to Genlist Item Pin Feature.
Oct 18 2017, 7:49 AM · efl
godlytalias created D5340: Genlist Item Pin Feature.
Oct 18 2017, 7:48 AM · efl

Oct 14 2017

godlytalias updated subscribers of D5288: Removing unwanted operation in interface create.
Oct 14 2017, 6:06 AM
godlytalias updated subscribers of D5286: Buffer is not used in the case where destination and source dimension is different.
Oct 14 2017, 5:58 AM

Oct 13 2017

godlytalias closed D5288: Removing unwanted operation in interface create.
Oct 13 2017, 1:05 PM
godlytalias closed D5286: Buffer is not used in the case where destination and source dimension is different.
Oct 13 2017, 1:05 PM

Oct 10 2017

godlytalias created D5288: Removing unwanted operation in interface create.
Oct 10 2017, 7:52 AM
godlytalias created D5286: Buffer is not used in the case where destination and source dimension is different.
Oct 10 2017, 7:07 AM

Oct 6 2017

godlytalias created D5266: Fix for sscanf operations.
Oct 6 2017, 2:40 AM

Apr 3 2017

godlytalias added reviewers for D4759: Genlist: Performance optimization for genlist in non-filter cases: cedric, raster, SanghyeonLee.
Apr 3 2017, 2:54 AM
godlytalias created D4759: Genlist: Performance optimization for genlist in non-filter cases.
Apr 3 2017, 2:51 AM

Feb 14 2017

godlytalias updated subscribers of D4660: Fixed memory leak.
Feb 14 2017, 3:21 AM
godlytalias created D4660: Fixed memory leak.
Feb 14 2017, 3:20 AM

Jul 26 2016

godlytalias added a comment to T3162: Genlist reorder allow callbacks.

Yes, This feature was implemented in patch through item class callbacks,
https://phab.enlightenment.org/D3669?id=8397
Later as item class callbacks could not be changed, updated the patch only for emitting signals.

Jul 26 2016, 1:18 AM · efl

Jul 18 2016

godlytalias created T4131: Window Rotation not working for 270 degree.
Jul 18 2016, 2:02 AM · Unknown Object (Project)

May 25 2016

godlytalias added a comment to D3977: Added feature to bring focused item to viewport on click.

@SanghyeonLee
Yes, There can be cases as below (top left item is focused but not fully in viewport),
So if I click that item it won't be scrolled in which I felt as not normal from a user point of view.

May 25 2016, 6:34 AM

May 24 2016

godlytalias retitled D3977: Added feature to bring focused item to viewport on click from to Added feature to bring focused item to viewport on click.
May 24 2016, 6:36 AM

Apr 4 2016

godlytalias updated the diff for D3729: Genlist: Fix for an item width calculation issue on item show / scrolling.

Updated patch, In any list mode item width should not be less than
viewport width.

Apr 4 2016, 11:07 PM

Mar 16 2016

godlytalias updated the diff for D3669: [Genlist] Reordering restriction feature.

Removed item class callbacks and implemented only events for now

Mar 16 2016, 12:31 AM
godlytalias updated the diff for D3669: [Genlist] Reordering restriction feature.

Removed item class callbacks and implemented only events for now

Mar 16 2016, 12:26 AM

Mar 14 2016

godlytalias added inline comments to D3729: Genlist: Fix for an item width calculation issue on item show / scrolling.
Mar 14 2016, 2:09 AM

Mar 13 2016

godlytalias added a comment to D3729: Genlist: Fix for an item width calculation issue on item show / scrolling.

This patch is already commited with the commit 6785fa01252f0b789d6c93ee6f52afcda4a3aa7a
How to close this?!

Mar 13 2016, 9:20 AM

Feb 24 2016

godlytalias retitled D3729: Genlist: Fix for an item width calculation issue on item show / scrolling from to Genlist: Fix for an item width calculation issue on item show / scrolling.
Feb 24 2016, 2:35 AM

Feb 11 2016

godlytalias updated the diff for D3669: [Genlist] Reordering restriction feature.
  • Fixed comment
Feb 11 2016, 6:13 AM

Feb 10 2016

godlytalias updated the diff for D3669: [Genlist] Reordering restriction feature.
  • Removed unwanted changes
Feb 10 2016, 10:10 AM
godlytalias updated the diff for D3669: [Genlist] Reordering restriction feature.
  • Removed unwanted changes
Feb 10 2016, 9:57 AM
godlytalias updated D3669: [Genlist] Reordering restriction feature.
Feb 10 2016, 6:11 AM
godlytalias retitled D3669: [Genlist] Reordering restriction feature from to [Genlist] Reordering restriction feature.
Feb 10 2016, 6:10 AM
godlytalias renamed T3162: Genlist reorder allow callbacks from Genlist reordering item passed callbacks to Genlist reorder allow callbacks.
Feb 10 2016, 1:36 AM · efl
godlytalias updated the task description for T3162: Genlist reorder allow callbacks.
Feb 10 2016, 1:35 AM · efl
godlytalias created T3162: Genlist reorder allow callbacks.
Feb 10 2016, 1:33 AM · efl

Feb 5 2016

godlytalias closed T3019: Transit feature to rewind a transition during a transit play. as Resolved.

D3567

Feb 5 2016, 2:05 AM · Unknown Object (Project)

Feb 4 2016

godlytalias updated D3656: [Genlist Tree] Fix for a bug in tree expansion, T3132.
Feb 4 2016, 7:58 PM
godlytalias added a revision to T3132: Genlist Tree autoscroll feature is broken: D3656: [Genlist Tree] Fix for a bug in tree expansion, T3132.
Feb 4 2016, 7:58 PM · Unknown Object (Project)
godlytalias retitled D3656: [Genlist Tree] Fix for a bug in tree expansion, T3132 from to [Genlist Tree] Fix for a bug in tree expansion, T3132.
Feb 4 2016, 7:48 PM

Feb 3 2016

godlytalias created T3132: Genlist Tree autoscroll feature is broken.
Feb 3 2016, 1:16 AM · Unknown Object (Project)

Jan 28 2016

godlytalias added a comment to T3112: change the behavior of horizontal hoversel.

Rather than changing horizontal hoversel like this, it will be better to add feature
to set direction priority in vertical hoversel if we want to have a hoversel like this right?
Similiar to the behaviour of direction priority set of ctxpopup.

Jan 28 2016, 9:39 PM · Restricted Project

Jan 27 2016

godlytalias updated the diff for D3567: [Transit] Feature to revert an ongoing transition during transit play.
  • Added @since tag
Jan 27 2016, 6:57 PM
godlytalias updated the diff for D3567: [Transit] Feature to revert an ongoing transition during transit play.
  • Added @since tag
Jan 27 2016, 6:54 PM

Jan 16 2016

godlytalias added reviewers for D3567: [Transit] Feature to revert an ongoing transition during transit play: Hermet, seoz.
Jan 16 2016, 12:52 AM

Jan 13 2016

godlytalias updated D3567: [Transit] Feature to revert an ongoing transition during transit play.
Jan 13 2016, 11:26 PM
godlytalias retitled D3567: [Transit] Feature to revert an ongoing transition during transit play from to [Transit] Feature to revert an ongoing transition during transit play.
Jan 13 2016, 11:05 PM

Jan 8 2016

godlytalias updated the task description for T3019: Transit feature to rewind a transition during a transit play..
Jan 8 2016, 2:38 AM · Unknown Object (Project)
godlytalias requested review of D3526: [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks.
Jan 8 2016, 2:05 AM
godlytalias created T3019: Transit feature to rewind a transition during a transit play..
Jan 8 2016, 1:43 AM · Unknown Object (Project)

Jan 7 2016

godlytalias added a comment to D3526: [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks.

That is a different issue, In hover only the swallow part is animated and the button_image part which is not animated remains on screen till the hover object is hidden. It will be hidden once the hide,finished signal is received. If required I will raise another patch to handle that issue.

Jan 7 2016, 5:18 AM

Jan 4 2016

godlytalias retitled D3526: [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks from to [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks.
Jan 4 2016, 11:42 PM
godlytalias added a revision to T3006: Hover dismiss delay on continuous mouse clicks: D3526: [Hover] Fixed the delaying of hover dismiss on continuous mouse clicks.
Jan 4 2016, 11:42 PM · Unknown Object (Project)