Page MenuHomePhabricator

herb (Taehyub Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 8 2014, 7:56 PM (350 w, 4 d)
Availability
Available

Recent Activity

Dec 22 2020

herb added inline comments to D12220: drag and drop accepted callback test.
Dec 22 2020, 7:11 PM · efl
herb commandeered D12220: drag and drop accepted callback test.
Dec 22 2020, 7:04 PM · efl

Dec 21 2020

herb updated subscribers of D12220: drag and drop accepted callback test.
Dec 21 2020, 7:16 PM · efl
herb accepted D12220: drag and drop accepted callback test.

oops, I changed the title and summary again.

Dec 21 2020, 7:13 PM · efl
herb updated the test plan for D12220: drag and drop accepted callback test.
Dec 21 2020, 7:07 PM · efl
herb added a comment to T8869: drag and drop accept value is always zero.

I also tested on X, and you can test with this patch https://phab.enlightenment.org/D12220.

Dec 21 2020, 2:32 AM
herb requested review of D12220: drag and drop accepted callback test.
Dec 21 2020, 2:18 AM · efl

Dec 20 2020

herb created T8869: drag and drop accept value is always zero.
Dec 20 2020, 10:56 PM

Oct 12 2020

herb added a comment to D12175: [WIP/Temp] Support Apng format.

why is it abandoned ?

Oct 12 2020, 3:33 AM · efl
herb abandoned D12175: [WIP/Temp] Support Apng format.
Oct 12 2020, 2:51 AM · efl
herb requested review of D12175: [WIP/Temp] Support Apng format.
Oct 12 2020, 2:39 AM · efl

Sep 20 2020

herb added a comment to D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.

Making the unregister in line 231 conditionally for not widgets should fix that.

Sep 20 2020, 7:42 PM · efl

Sep 18 2020

herb added a comment to D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.
  1. This breaks legacy drop targets on none efl.ui.dnd elements.
  2. This breaks registering 2 events, unregistering 1 -> no event will be delivered anymore.
Sep 18 2020, 4:02 AM · efl

Sep 14 2020

herb requested review of D12144: elm_dnd: clean up the registered target object when elm_drop_target_del API is called.
Sep 14 2020, 4:09 AM · efl

Aug 14 2020

herb updated the diff for D12073: Add wrap mode feature for vector object.

update source codes

Aug 14 2020, 3:03 AM · efl

Jul 29 2020

herb requested review of D12073: Add wrap mode feature for vector object.
Jul 29 2020, 9:25 PM · efl
herb added a child revision for D11931: Efl.Gfx.Frame_Contoller: Add sector_list property: D12073: Add wrap mode feature for vector object.
Jul 29 2020, 9:25 PM · efl
herb updated the diff for D11929: evas_vg_cache: Add sector_list_get.

upload codes

Jul 29 2020, 1:20 AM · efl

Jul 16 2020

herb updated the summary of D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Jul 16 2020, 4:52 AM · efl
herb updated the diff for D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.

update patches

Jul 16 2020, 4:47 AM · efl
herb added reviewers for D12056: efl_ui_image: remove the unnecessary code in efl_file_unload: Hermet, jsuya, kimcinoo.
Jul 16 2020, 2:50 AM · efl
herb requested review of D12056: efl_ui_image: remove the unnecessary code in efl_file_unload.
Jul 16 2020, 2:49 AM · efl

Jun 17 2020

herb updated the diff for D11988: elm_image: remove the spaces and keep the indentation for elm_image_file_set().

update source

Jun 17 2020, 5:15 AM · efl
herb requested review of D11988: elm_image: remove the spaces and keep the indentation for elm_image_file_set().
Jun 17 2020, 5:10 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

update codes

Jun 17 2020, 5:03 AM · efl
herb abandoned D11987: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

This patch will be replaced with D11979

Jun 17 2020, 4:28 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

clean up the codes

Jun 17 2020, 3:24 AM · efl
herb requested review of D11987: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 3:20 AM · efl
herb added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

In my opinion, if Efl.Ui.Image needs to do the same, I think I can handle this on line 939. Is it only necessary to support legacy?

Jun 17 2020, 3:01 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

update condition

Jun 17 2020, 2:58 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

update condition

Jun 17 2020, 2:45 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

modify condition

Jun 17 2020, 2:38 AM · efl
herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

consider group

Jun 17 2020, 2:37 AM · efl

Jun 15 2020

herb updated the diff for D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

update source codes

Jun 15 2020, 11:23 PM · efl
herb requested review of D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 15 2020, 11:22 PM · efl

Jun 12 2020

herb updated the diff for D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.

update codes

Jun 12 2020, 12:11 AM · efl
herb updated the diff for D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.

update source code

Jun 12 2020, 12:01 AM · efl

Jun 11 2020

herb updated the diff for D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.

update source code

Jun 11 2020, 11:57 PM · efl
herb requested review of D11969: efl_ui_image: fixed elm_image_preload_disabled_set api is not working when it is called before file set.
Jun 11 2020, 9:01 PM · efl
herb abandoned D11967: elc_popup: add null checks for scrollable set/get apis.
Jun 11 2020, 1:07 AM · efl
herb requested review of D11967: elc_popup: add null checks for scrollable set/get apis.
Jun 11 2020, 12:07 AM · efl

Jun 9 2020

herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

clean up

Jun 9 2020, 11:37 PM · efl
herb updated the summary of D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 11:18 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

update codes

Jun 9 2020, 11:14 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

update version

Jun 9 2020, 10:51 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

update comments

Jun 9 2020, 10:50 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

update codes based on comments

Jun 9 2020, 10:49 PM · efl
herb retitled D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style from efl_ui_textpath: add the efl_ui_textpath_text_user_style_push API for applying the user text style to efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 9:12 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

change the API name

Jun 9 2020, 9:10 PM · efl
herb updated the diff for D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.

remove interface and support legacy API

Jun 9 2020, 7:44 PM · efl
herb requested review of D11953: efl_ui_textpath: add the efl_ui_textpath_text_user_style_set API for applying the user text style.
Jun 9 2020, 2:13 AM · efl

May 28 2020

herb updated the diff for D11876: Support WebP Animation Image Files.

remove libweb dependency for libwebpdemux

May 28 2020, 7:32 PM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update codes

May 28 2020, 12:45 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

Add checking return value for getting next frame

May 28 2020, 12:25 AM · efl

May 27 2020

herb updated the diff for D11876: Support WebP Animation Image Files.

update codes

May 27 2020, 9:53 PM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update codes

May 27 2020, 5:56 AM · efl

May 25 2020

herb updated the diff for D11876: Support WebP Animation Image Files.

modified code for comments

May 25 2020, 7:04 PM · efl
herb closed D11846: ecore_evas_wayland_common: keep the backword compatibility for wayland dnd handler.
May 25 2020, 2:17 AM · efl
herb added a comment to D11877: elm_dnd: do not register widgets twice.

This is tested by my environments and removed the duplicated register cases.

May 25 2020, 1:48 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

clean up the codes

May 25 2020, 1:38 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update codes

May 25 2020, 1:34 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update files

May 25 2020, 1:26 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update sample codes

May 25 2020, 12:33 AM · efl
herb updated the diff for D11876: Support WebP Animation Image Files.

update codes

May 25 2020, 12:09 AM · efl
herb requested review of D11876: Support WebP Animation Image Files.
May 25 2020, 12:06 AM · efl

May 21 2020

herb requested review of D11867: evas_vg_container: return NULL in evas_vg_container_add when the parent of container is NULL.
May 21 2020, 8:12 PM · efl

May 19 2020

herb added a comment to T8706: CnP and Dnd Compatibility.

for DnD-4(1): I think the event enter and left in _motion_cb, the event enter and left in _enter_state_change_cb are different. the events in motion_cb are triggered by motion.
but the events in _enter_state_change_cb are triggered by wayland enter and left events.
I have a doubt to serve same events about both cases.
for DnD-4(2): when the drag object moved to the target object and the drag is finished, the target->currently_inside flag should be false. but _enter_state_changed_cb dose not change the target->currently_inside flag to false when drag is done.

May 19 2020, 5:23 AM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

hello, @bu5hm4n
for CnP-2 (new case)
I have a question about elm_cnp_loss_callback_set() function.
I think the loss_callback behavior is changed compared to before.

May 19 2020, 12:37 AM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

hello, @bu5hm4n
for CnP-1
The serial is updated by only input codes, so when we try to copy and paste using button(the serial is updated and copy and paste work well)
ex)
src/lib/ecore_wl2/ecore_wl2_input.c:697: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:721: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:768: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:942: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:969: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1062: input->display->serial = serial;
src/lib/ecore_wl2/ecore_wl2_input.c:1241: input->display->serial = serial;

May 19 2020, 12:18 AM · efl

May 18 2020

herb added a comment to T8706: CnP and Dnd Compatibility.

hello, @bu5hm4n
for Dnd-4
before EFL_UI_DND_EVENT_DROP_ENTERED and EFL_UI_DND_EVENT_DROP_LEFT event are triggered by only motion events.
but the events in _enter_state_change_cb() will emit additional event to the application.

May 18 2020, 10:50 PM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

hello, @bu5hm4n
for DnD-1: drop event register twice is not reproduced with the patch in my environment.

May 18 2020, 10:00 PM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

I have question about _enter_state_change_cb(), I think in _motion_cb() we emit EFL_UI_DND_EVENT_DROP_LEFT, EFL_UI_DND_EVENT_DROP_ENTER already.
should we emit the event in _enter_state_change_cb()?
(before the drag enter and leave event are triggered by the drag object moves)

May 18 2020, 5:53 AM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

I think this seems to be bug, there is a case that drop_target is added twice.
how about remove _drop_event_register() in elm_drop_target_add()?

May 18 2020, 5:19 AM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

Case: DnD-1
I think the drop left and drop entered event order are important.

May 18 2020, 2:00 AM · efl
herb added a comment to T8706: CnP and Dnd Compatibility.

@ bu5hm4n
I created the patch for resolving DnD-2 problem.
please review this :)
https://phab.enlightenment.org/D11846

May 18 2020, 12:56 AM · efl
herb requested review of D11846: ecore_evas_wayland_common: keep the backword compatibility for wayland dnd handler.
May 18 2020, 12:56 AM · efl

May 15 2020

herb requested review of D11839: evas_vg_shape: return NULL in evas_vg_shape_add when the parent of shape is NULL.
May 15 2020, 12:59 AM · efl

May 11 2020

herb created T8706: CnP and Dnd Compatibility.
May 11 2020, 4:43 AM · efl
herb updated the diff for D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).

update codes

May 11 2020, 1:26 AM · efl
herb updated the diff for D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).

update codes

May 11 2020, 1:22 AM · efl
herb updated the diff for D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).

update code

May 11 2020, 1:09 AM · efl

May 6 2020

herb requested review of D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).
May 6 2020, 5:24 AM · efl

Apr 12 2020

herb updated the diff for D11690: elm_cnp: fix memory leaks.

fix warning

Apr 12 2020, 10:55 PM · efl
herb updated the diff for D11690: elm_cnp: fix memory leaks.

update comments

Apr 12 2020, 10:40 PM · efl
herb requested review of D11690: elm_cnp: fix memory leaks.
Apr 12 2020, 10:17 PM · efl

Mar 17 2020

herb closed D11446: ecore_cocoa: fix wrong word in documentation.
Mar 17 2020, 2:32 AM · efl

Mar 16 2020

herb requested review of D11521: evas_vg: modified the join enum documentation.
Mar 16 2020, 9:03 PM · efl
herb added a child revision for D11519: evas_vg: add since tags for evas vector APIs: D11521: evas_vg: modified the join enum documentation.
Mar 16 2020, 9:02 PM · efl
herb abandoned D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.

This revision is divided into D11517, D11518, D11519

Mar 16 2020, 7:54 PM · efl
herb added a parent revision for D11518: evas_vg: refined the documentation for evas vector APIs: D11517: evas_vg: refined the evas vector APIs set.
Mar 16 2020, 7:45 PM · efl
herb added a child revision for D11517: evas_vg: refined the evas vector APIs set: D11518: evas_vg: refined the documentation for evas vector APIs.
Mar 16 2020, 7:45 PM · efl
herb requested review of D11519: evas_vg: add since tags for evas vector APIs.
Mar 16 2020, 7:44 PM · efl
herb added a child revision for D11518: evas_vg: refined the documentation for evas vector APIs: D11519: evas_vg: add since tags for evas vector APIs.
Mar 16 2020, 7:44 PM · efl
herb requested review of D11518: evas_vg: refined the documentation for evas vector APIs.
Mar 16 2020, 6:05 AM · efl
herb requested review of D11517: evas_vg: refined the evas vector APIs set.
Mar 16 2020, 6:04 AM · efl
herb abandoned D11514: evas_vg: refined the documentation for evas vector APIs.
Mar 16 2020, 5:59 AM · efl
herb abandoned D11513: evas_vg: refined the evas vector APIs set.

This patch looks very similar to D11511. Can you take into account the comments I made there?

Mar 16 2020, 5:59 AM · efl
herb updated the diff for D11514: evas_vg: refined the documentation for evas vector APIs.

Updating D11514: evas_vg: refined the documentation for evas vector APIs

Mar 16 2020, 5:55 AM · efl
herb requested review of D11514: evas_vg: refined the documentation for evas vector APIs.
Mar 16 2020, 5:51 AM · efl
herb updated the diff for D11513: evas_vg: refined the evas vector APIs set.

evas_vg: refined the evas vector APIs set

Mar 16 2020, 5:42 AM · efl