Page MenuHomePhabricator

herb (Taehyub Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 8 2014, 7:56 PM (279 w, 5 d)
Availability
Available

Recent Activity

Wed, Sep 4

herb requested review of D9835: prevent using the efl_gfx_hint_size_combined_min_get function from the legacy widgets.
Wed, Sep 4, 5:34 AM · efl

Tue, Sep 3

herb requested review of D9818: elm_popup: calculate the label min size of popup before the popup group calculation.
Tue, Sep 3, 3:30 AM · efl

Thu, Aug 29

herb added a comment to T7946: enum Efl.Ui.Popup_Align.

After zmike's refactoring the popup, the enum will be removed

Thu, Aug 29, 1:04 AM · efl: api, efl (efl-1.23), efl: language bindings

Tue, Aug 27

herb added a comment to T7902: efl.ui.popup.

In fact, I don't have enough time to handle this since I have to migrate upstream code to tizen until next wednesday.
and I should make the entire EflSharp UnitTest set until end of september. I think the amount of TC set that I have to make quite large.
so I'm not sure to answer :(

Tue, Aug 27, 5:30 AM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7902: efl.ui.popup.

@zmike
You mean that making the parts class for the buttons, right?
I also agree with your opinion and I think the parts should implement content and text interfaces for the setting text and icon of buttons

Tue, Aug 27, 5:17 AM · efl: api, efl (efl-1.23), efl: language bindings

Sun, Aug 25

herb requested review of D9735: efl_ui_format: add null checking codes for eina_strftime in _do_format_string function.
Sun, Aug 25, 10:17 PM · efl

Tue, Aug 20

herb added a comment to T7902: efl.ui.popup.

@zmike
I talked with woohyun about this refactoring for popup,
we have to finish this task until early september since we will start the release for EflSharp after the middle of september.
please take care of this schedule.

Tue, Aug 20, 9:50 PM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7902: efl.ui.popup.

@zmike
The application developers in tizen need two types of popup such as context style and alert style
In case of the context style like elm_ctxpopup of efl needs priority align feature because the context popup should be shown depending on mouse position and in the screen boundary.
when the context popup is created near the screen boundary, the priority is used to find the optimal position of the context popup which the user wants.
In case of the alert style like elm_popup of efl needs align feature because some developer want the popup to be aligned whenever the screen is resized.
However If there are some ways to set the priority using algin hints or find optimal position, I think we can remove the priority set API :)

Tue, Aug 20, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings

Aug 12 2019

herb added a comment to T7902: efl.ui.popup.

@zmike
Hi, I agree to your opinion, the usage of the anchor popup align is different from base popup.
so I think the align feature in anchor popup should be separated from Efl.Ui.Popup.Align
and make the anchor popup has its own priority align features.

Aug 12 2019, 9:27 PM · efl: api, efl (efl-1.23), efl: language bindings

Jul 25 2019

herb requested review of D9413: Efl.Gfx.Hint_Align: add define values for Efl.Gfx.Hint_Align.
Jul 25 2019, 11:51 PM · efl

Jul 2 2019

herb abandoned D9199: efl_ui_layout: fix the case that item list is not deleted when trying to insert the contents to the same part..

I agreed with you :)
abandon this patch

Jul 2 2019, 9:25 PM · efl

Jun 27 2019

herb requested review of D9199: efl_ui_layout: fix the case that item list is not deleted when trying to insert the contents to the same part..
Jun 27 2019, 10:33 PM · efl

Jun 26 2019

herb added a comment to T7946: enum Efl.Ui.Popup_Align.

I agree to bu5hm4n's opinion and I think segfaultxavi's idea can be good alternatives.
It looks good for me :)

Jun 26 2019, 6:37 PM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7946: enum Efl.Ui.Popup_Align.

The enum values support the alignment setting for the very high frequent alignment.
I think this is the important factor from the user perspective.
Also there need to add left_top, right_top, left_bottom, right_bottom enum values.

Jun 26 2019, 2:12 AM · efl: api, efl (efl-1.23), efl: language bindings

Jun 24 2019

herb added a comment to T7902: efl.ui.popup.

@bu5hm4n
I think the max_size_hint is different with popup_size.
the max_size in efl_ui_popup means the maximum size that the popup can expand.
If the max_size_hint is used to change the popup size, the popup will not be expandable.
Therefore, I think it's not good to change popup_size to max_size_hint.
In case of the alignment API of popup, It is designed to notify the options to the users.
To use this API makes the code simple and easy.

Jun 24 2019, 12:08 AM · efl: api, efl (efl-1.23), efl: language bindings

Jun 5 2019

herb abandoned D9068: evas_out: add condition for efl_canvas_output_view_set.
Jun 5 2019, 4:21 AM · efl

Jun 4 2019

herb requested review of D9068: evas_out: add condition for efl_canvas_output_view_set.
Jun 4 2019, 4:26 AM · efl
herb requested review of D9067: efl_ui_layout_orientation: fix the bitwise condition logic.
Jun 4 2019, 4:08 AM · efl

Apr 24 2019

herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158431, @q66 wrote:

No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.

Apr 24 2019, 2:43 AM · efl
herb updated the diff for D8696: eo_parser: fix unreachable code.

update code

Apr 24 2019, 2:41 AM · efl
herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158404, @q66 wrote:

The goto is unnecessary, syntax error means a long jump

@q66
Hi, you mean these codes are intended?
but actually the following codes are not reachable.
2198: if (is_enum)
2199: eo_lexer_syntax_error(ls, "enums cannot have @free");

Apr 24 2019, 1:02 AM · efl

Apr 23 2019

herb requested review of D8696: eo_parser: fix unreachable code.
Apr 23 2019, 10:14 PM · efl

Apr 22 2019

herb closed D8683: elc_hoversel: fix selected event compatibility issue.
Apr 22 2019, 11:59 PM · efl
herb updated the diff for D8683: elc_hoversel: fix selected event compatibility issue.

update code

Apr 22 2019, 11:49 PM · efl
herb requested review of D8683: elc_hoversel: fix selected event compatibility issue.
Apr 22 2019, 11:38 PM · efl

Apr 17 2019

herb requested review of D8628: elm_notify: fix theme apply logic for new return value.
Apr 17 2019, 12:53 AM · efl

Mar 28 2019

herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 2:35 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 1:18 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

update the codes

Mar 28 2019, 12:52 AM · efl

Mar 27 2019

herb requested review of D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.
Mar 27 2019, 9:38 PM · efl

Mar 21 2019

herb requested review of D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Mar 21 2019, 7:15 PM · efl

Jan 27 2019

herb requested review of D7798: efl_ui_selection_manager: change strcat to strncat for safety.
Jan 27 2019, 11:11 PM · efl
herb requested review of D7797: efl_ui_dnd: fix the wrong parameter passing.
Jan 27 2019, 11:07 PM · efl

Sep 21 2018

herb requested review of D7089: elm_entry: update documentation for elm_entnry_textonly_mode_set/get.
Sep 21 2018, 2:01 AM · efl

Sep 20 2018

herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:48 PM · efl
herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:44 PM · efl
herb updated the summary of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:40 PM · efl
herb requested review of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:24 PM · efl
herb requested review of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:21 PM · efl
herb requested review of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:15 PM · efl
herb retitled D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup from Efl.Ui.Popup.Alert: add icon parameter for icon button to Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:10 PM · efl
herb requested review of D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:09 PM · efl

Aug 8 2018

herb added a member for reviewers: herb.
Aug 8 2018, 1:04 AM

May 1 2018

herb added a comment to D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

currently, this patch is not available. I will abandon this :)

May 1 2018, 6:30 PM · efl

Apr 26 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update interface scrollable code

Apr 26 2018, 1:49 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply indentation

Apr 26 2018, 12:55 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 26 2018, 12:21 AM

Apr 25 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 25 2018, 11:40 PM

Apr 24 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

remove the unnecessary function

Apr 24 2018, 1:14 AM
herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@raster, @cedric
applying 'efl. 'prefix for parts is finished I think. could you verify this patch?
and then I will make the new patch for new signal policy as you and jaehyun mentioned :)

Apr 24 2018, 1:01 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply efl_part name policy more

Apr 24 2018, 12:29 AM

Apr 20 2018

herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@cedric, @raster
I just finished removing the legacy part name and added "efl." prefix to all parts used in source code in edc/efl :)

Apr 20 2018, 6:03 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 20 2018, 5:40 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 5:06 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 4:20 AM

Apr 16 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 16 2018, 4:50 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

modified more parts

Apr 16 2018, 4:34 AM

Apr 13 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 13 2018, 1:43 AM

Apr 3 2018

herb updated the diff for D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

update the code

Apr 3 2018, 11:35 PM · efl

Mar 23 2018

herb updated the diff for D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup.

update the code

Mar 23 2018, 12:50 AM · efl

Dec 12 2017

herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:38 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:25 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:08 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 9:30 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

Efl.Ui.Popup.Alert.Text: add expandable property with group calculation

Dec 12 2017, 9:28 PM

Dec 10 2017

herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:21 PM
herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:11 PM
herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:08 PM
herb added a comment to D5630: efl_ui_popup_alert_scroll: Add expandable property.

@Jaehyun_Cho
I uploaded two patches you mentioned.

Dec 10 2017, 5:47 PM
herb updated the diff for D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.

update the code

Dec 10 2017, 5:42 PM

Dec 8 2017

herb created D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.
Dec 8 2017, 12:03 AM

Dec 7 2017

herb added a comment to D5630: efl_ui_popup_alert_scroll: Add expandable property.

@Jaehyun_Cho

  1. could you separate the efl.ui.popup.alert patch from this path?
  2. could you add comment for group size calculation logic how it works?
Dec 7 2017, 11:45 PM
herb created D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.
Dec 7 2017, 2:35 AM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 7 2017, 2:31 AM

Dec 5 2017

herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 9:59 PM
herb updated the diff for D5600: Efl.Ui.Popup: add popup_size property.

update the code

Dec 5 2017, 9:48 PM
herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 9:24 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 5 2017, 4:22 AM
herb abandoned D5498: Efl.Ui.Popup: add resize callback to update align.
Dec 5 2017, 3:48 AM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 5 2017, 3:42 AM
herb created D5600: Efl.Ui.Popup: add popup_size property.
Dec 5 2017, 2:55 AM
herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 1:38 AM

Dec 4 2017

herb abandoned D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.
Dec 4 2017, 8:29 PM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 4 2017, 12:01 AM

Nov 29 2017

herb created D5557: Efl.Ui.Popup.Scroll: add expandable feature.
Nov 29 2017, 12:56 AM

Nov 28 2017

herb created D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Nov 28 2017, 8:37 PM
herb created D5547: efl_ui_popup_alert_text: add expandable feature.
Nov 28 2017, 3:52 AM

Nov 20 2017

herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 20 2017, 12:31 AM
herb created D5498: Efl.Ui.Popup: add resize callback to update align.
Nov 20 2017, 12:29 AM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 20 2017, 12:25 AM

Nov 14 2017

herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 14 2017, 6:23 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 14 2017, 12:21 AM

Nov 13 2017

herb added a comment to D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

@jpeg I modified the code as you commented :)

Nov 13 2017, 11:16 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 13 2017, 11:13 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

add more test cases and update the code

Nov 13 2017, 11:06 PM
herb created D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.
Nov 13 2017, 3:29 AM

Oct 27 2017

herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

update the code

Oct 27 2017, 1:57 AM

Oct 26 2017

herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

update the code

Oct 26 2017, 7:44 PM