Page MenuHomePhabricator

herb (Taehyub Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 8 2014, 7:56 PM (307 w, 6 d)
Availability
Available

Recent Activity

Tue, Mar 17

herb closed D11446: ecore_cocoa: fix wrong word in documentation.
Tue, Mar 17, 2:32 AM · efl

Mon, Mar 16

herb requested review of D11521: evas_vg: modified the join enum documentation.
Mon, Mar 16, 9:03 PM · efl
herb added a child revision for D11519: evas_vg: add since tags for evas vector APIs: D11521: evas_vg: modified the join enum documentation.
Mon, Mar 16, 9:02 PM · efl
herb abandoned D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.

This revision is divided into D11517, D11518, D11519

Mon, Mar 16, 7:54 PM · efl
herb added a parent revision for D11518: evas_vg: refined the documentation for evas vector APIs: D11517: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 7:45 PM · efl
herb added a child revision for D11517: evas_vg: refined the evas vector APIs set: D11518: evas_vg: refined the documentation for evas vector APIs.
Mon, Mar 16, 7:45 PM · efl
herb requested review of D11519: evas_vg: add since tags for evas vector APIs.
Mon, Mar 16, 7:44 PM · efl
herb added a child revision for D11518: evas_vg: refined the documentation for evas vector APIs: D11519: evas_vg: add since tags for evas vector APIs.
Mon, Mar 16, 7:44 PM · efl
herb requested review of D11518: evas_vg: refined the documentation for evas vector APIs.
Mon, Mar 16, 6:05 AM · efl
herb requested review of D11517: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 6:04 AM · efl
herb abandoned D11514: evas_vg: refined the documentation for evas vector APIs.
Mon, Mar 16, 5:59 AM · efl
herb abandoned D11513: evas_vg: refined the evas vector APIs set.

This patch looks very similar to D11511. Can you take into account the comments I made there?

Mon, Mar 16, 5:59 AM · efl
herb updated the diff for D11514: evas_vg: refined the documentation for evas vector APIs.

Updating D11514: evas_vg: refined the documentation for evas vector APIs

Mon, Mar 16, 5:55 AM · efl
herb requested review of D11514: evas_vg: refined the documentation for evas vector APIs.
Mon, Mar 16, 5:51 AM · efl
herb updated the diff for D11513: evas_vg: refined the evas vector APIs set.

evas_vg: refined the evas vector APIs set

Mon, Mar 16, 5:42 AM · efl
herb updated the diff for D11513: evas_vg: refined the evas vector APIs set.

update source

Mon, Mar 16, 5:37 AM · efl
herb added a comment to D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.

@segfaultxvai
hello, thanks for the comment, I will divide this path for readability(D11513 is the first path of this)
and in case of other comments, I will change to follow your comments.

Looks like you are defining new enums here that are already present in Eo files. Can you explain why?

=> because I think legacy APIs should use legacy eo files, so I defined evas enum types

ex) for using evas_vg_shape_path_set.

I think @zmike worked on the move of this stuff from Legacy to Eo some time ago, it might be worth asking his opinion.

Mon, Mar 16, 4:37 AM · efl
herb updated the diff for D11513: evas_vg: refined the evas vector APIs set.

update cdes

Mon, Mar 16, 4:14 AM · efl
herb requested review of D11513: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 4:11 AM · efl
herb abandoned D11512: evas_vg: refined the evas vector APIs set.

abandon this revision

Mon, Mar 16, 3:53 AM · efl
herb updated the diff for D11512: evas_vg: refined the evas vector APIs set.

evas_vg: refined the documentation for evas vector APIs

Mon, Mar 16, 3:51 AM · efl
herb requested review of D11512: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 3:49 AM · efl
herb updated the diff for D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.

update tags

Mon, Mar 16, 1:16 AM · efl
herb updated the diff for D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.

updated version for new evas enums

Mon, Mar 16, 1:09 AM · efl
herb abandoned D11492: evas_canvas_vg: modified the documentation for the evas vector APIs.

I will update as other patch

Mon, Mar 16, 1:02 AM · efl
herb requested review of D11511: evas_vg: modified the documentation and parameter names for the evas vector APIs.
Mon, Mar 16, 1:00 AM · efl

Wed, Mar 11

herb requested review of D11492: evas_canvas_vg: modified the documentation for the evas vector APIs.
Wed, Mar 11, 11:54 PM · efl
herb requested review of D11491: efl_canvas_vg_shape: fix the wrong parameter order in the wrapper of evas_vg_shape_append_cubic_to().
Wed, Mar 11, 11:38 PM · efl

Wed, Mar 4

herb updated the diff for D11446: ecore_cocoa: fix wrong word in documentation.

updated codes for adding documentation

Wed, Mar 4, 6:54 PM · efl
herb requested review of D11446: ecore_cocoa: fix wrong word in documentation.
Wed, Mar 4, 4:13 AM · efl

Jan 8 2020

herb added a comment to T8547: Efl.Ui.Selection: efl_ui_selection_get type clipboard not fired.

I checked this codes on my desktop and it is reproduced with x11 environment.
In case of pasting twice, it is blocked by below codes.

Jan 8 2020, 2:49 AM

Dec 5 2019

herb requested review of D10820: efl_ui_alert_popup: remove beta for efl_ui_alert_popup_title.
Dec 5 2019, 11:45 PM · efl

Dec 4 2019

herb requested review of D10794: fix the wrong method signature for evas_textgrid.
Dec 4 2019, 1:55 AM · efl

Nov 6 2019

herb abandoned D9835: prevent using the efl_gfx_hint_size_combined_min_get function from the legacy widgets.
Nov 6 2019, 8:02 PM · efl

Nov 5 2019

herb added a reviewer for D10596: efl_ui_alert_popup: add title part in parts block: zmike.
Nov 5 2019, 6:28 PM · efl
herb updated the diff for D10596: efl_ui_alert_popup: add title part in parts block.

update the codes

Nov 5 2019, 6:26 PM · efl
herb updated the diff for D10596: efl_ui_alert_popup: add title part in parts block.

add @beta tag

Nov 5 2019, 4:11 AM · efl
herb updated the diff for D10596: efl_ui_alert_popup: add title part in parts block.

modified the codes

Nov 5 2019, 4:04 AM · efl

Nov 4 2019

herb requested review of D10596: efl_ui_alert_popup: add title part in parts block.
Nov 4 2019, 11:06 PM · efl

Oct 14 2019

herb added a comment to D10386: testgen: sync the latest eolian grammar.

Hi, lauromoura,
I made a patch that synchronizes with the upstream code.
Actually the upstream eolian grammar has been changed from 2019.Oct
so I added more verbs and modifyed the event and function names.
You can apply this patch after rebasing.

Oct 14 2019, 12:09 AM · efl

Oct 13 2019

herb requested review of D10386: testgen: sync the latest eolian grammar.
Oct 13 2019, 11:51 PM · efl

Sep 4 2019

herb requested review of D9835: prevent using the efl_gfx_hint_size_combined_min_get function from the legacy widgets.
Sep 4 2019, 5:34 AM · efl

Sep 3 2019

herb requested review of D9818: elm_popup: calculate the label min size of popup before the popup group calculation.
Sep 3 2019, 3:30 AM · efl

Aug 29 2019

herb added a comment to T7946: enum Efl.Ui.Popup_Align.

After zmike's refactoring the popup, the enum will be removed

Aug 29 2019, 1:04 AM · efl: api, efl (efl-1.23), efl: language bindings

Aug 27 2019

herb added a comment to T7902: efl.ui.popup.

In fact, I don't have enough time to handle this since I have to migrate upstream code to tizen until next wednesday.
and I should make the entire EflSharp UnitTest set until end of september. I think the amount of TC set that I have to make quite large.
so I'm not sure to answer :(

Aug 27 2019, 5:30 AM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7902: efl.ui.popup.

@zmike
You mean that making the parts class for the buttons, right?
I also agree with your opinion and I think the parts should implement content and text interfaces for the setting text and icon of buttons

Aug 27 2019, 5:17 AM · efl: api, efl (efl-1.23), efl: language bindings

Aug 25 2019

herb requested review of D9735: efl_ui_format: add null checking codes for eina_strftime in _do_format_string function.
Aug 25 2019, 10:17 PM · efl

Aug 20 2019

herb added a comment to T7902: efl.ui.popup.

@zmike
I talked with woohyun about this refactoring for popup,
we have to finish this task until early september since we will start the release for EflSharp after the middle of september.
please take care of this schedule.

Aug 20 2019, 9:50 PM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7902: efl.ui.popup.

@zmike
The application developers in tizen need two types of popup such as context style and alert style
In case of the context style like elm_ctxpopup of efl needs priority align feature because the context popup should be shown depending on mouse position and in the screen boundary.
when the context popup is created near the screen boundary, the priority is used to find the optimal position of the context popup which the user wants.
In case of the alert style like elm_popup of efl needs align feature because some developer want the popup to be aligned whenever the screen is resized.
However If there are some ways to set the priority using algin hints or find optimal position, I think we can remove the priority set API :)

Aug 20 2019, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings

Aug 12 2019

herb added a comment to T7902: efl.ui.popup.

@zmike
Hi, I agree to your opinion, the usage of the anchor popup align is different from base popup.
so I think the align feature in anchor popup should be separated from Efl.Ui.Popup.Align
and make the anchor popup has its own priority align features.

Aug 12 2019, 9:27 PM · efl: api, efl (efl-1.23), efl: language bindings

Jul 25 2019

herb requested review of D9413: Efl.Gfx.Hint_Align: add define values for Efl.Gfx.Hint_Align.
Jul 25 2019, 11:51 PM · efl

Jul 2 2019

herb abandoned D9199: efl_ui_layout: fix the case that item list is not deleted when trying to insert the contents to the same part..

I agreed with you :)
abandon this patch

Jul 2 2019, 9:25 PM · efl

Jun 27 2019

herb requested review of D9199: efl_ui_layout: fix the case that item list is not deleted when trying to insert the contents to the same part..
Jun 27 2019, 10:33 PM · efl

Jun 26 2019

herb added a comment to T7946: enum Efl.Ui.Popup_Align.

I agree to bu5hm4n's opinion and I think segfaultxavi's idea can be good alternatives.
It looks good for me :)

Jun 26 2019, 6:37 PM · efl: api, efl (efl-1.23), efl: language bindings
herb added a comment to T7946: enum Efl.Ui.Popup_Align.

The enum values support the alignment setting for the very high frequent alignment.
I think this is the important factor from the user perspective.
Also there need to add left_top, right_top, left_bottom, right_bottom enum values.

Jun 26 2019, 2:12 AM · efl: api, efl (efl-1.23), efl: language bindings

Jun 24 2019

herb added a comment to T7902: efl.ui.popup.

@bu5hm4n
I think the max_size_hint is different with popup_size.
the max_size in efl_ui_popup means the maximum size that the popup can expand.
If the max_size_hint is used to change the popup size, the popup will not be expandable.
Therefore, I think it's not good to change popup_size to max_size_hint.
In case of the alignment API of popup, It is designed to notify the options to the users.
To use this API makes the code simple and easy.

Jun 24 2019, 12:08 AM · efl: api, efl (efl-1.23), efl: language bindings

Jun 5 2019

herb abandoned D9068: evas_out: add condition for efl_canvas_output_view_set.
Jun 5 2019, 4:21 AM · efl

Jun 4 2019

herb requested review of D9068: evas_out: add condition for efl_canvas_output_view_set.
Jun 4 2019, 4:26 AM · efl
herb requested review of D9067: efl_ui_layout_orientation: fix the bitwise condition logic.
Jun 4 2019, 4:08 AM · efl

Apr 24 2019

herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158431, @q66 wrote:

No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.

Apr 24 2019, 2:43 AM · efl
herb updated the diff for D8696: eo_parser: fix unreachable code.

update code

Apr 24 2019, 2:41 AM · efl
herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158404, @q66 wrote:

The goto is unnecessary, syntax error means a long jump

@q66
Hi, you mean these codes are intended?
but actually the following codes are not reachable.
2198: if (is_enum)
2199: eo_lexer_syntax_error(ls, "enums cannot have @free");

Apr 24 2019, 1:02 AM · efl

Apr 23 2019

herb requested review of D8696: eo_parser: fix unreachable code.
Apr 23 2019, 10:14 PM · efl

Apr 22 2019

herb closed D8683: elc_hoversel: fix selected event compatibility issue.
Apr 22 2019, 11:59 PM · efl
herb updated the diff for D8683: elc_hoversel: fix selected event compatibility issue.

update code

Apr 22 2019, 11:49 PM · efl
herb requested review of D8683: elc_hoversel: fix selected event compatibility issue.
Apr 22 2019, 11:38 PM · efl

Apr 17 2019

herb requested review of D8628: elm_notify: fix theme apply logic for new return value.
Apr 17 2019, 12:53 AM · efl

Mar 28 2019

herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 2:35 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 1:18 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

update the codes

Mar 28 2019, 12:52 AM · efl

Mar 27 2019

herb requested review of D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.
Mar 27 2019, 9:38 PM · efl

Mar 21 2019

herb requested review of D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Mar 21 2019, 7:15 PM · efl

Jan 27 2019

herb requested review of D7798: efl_ui_selection_manager: change strcat to strncat for safety.
Jan 27 2019, 11:11 PM · efl
herb requested review of D7797: efl_ui_dnd: fix the wrong parameter passing.
Jan 27 2019, 11:07 PM · efl

Sep 21 2018

herb requested review of D7089: elm_entry: update documentation for elm_entnry_textonly_mode_set/get.
Sep 21 2018, 2:01 AM · efl

Sep 20 2018

herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:48 PM · efl
herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:44 PM · efl
herb updated the summary of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:40 PM · efl
herb requested review of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:24 PM · efl
herb requested review of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:21 PM · efl
herb requested review of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:15 PM · efl
herb retitled D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup from Efl.Ui.Popup.Alert: add icon parameter for icon button to Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:10 PM · efl
herb requested review of D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:09 PM · efl

Aug 8 2018

herb added a member for reviewers: herb.
Aug 8 2018, 1:04 AM

May 1 2018

herb added a comment to D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

currently, this patch is not available. I will abandon this :)

May 1 2018, 6:30 PM · efl

Apr 26 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update interface scrollable code

Apr 26 2018, 1:49 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply indentation

Apr 26 2018, 12:55 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 26 2018, 12:21 AM

Apr 25 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 25 2018, 11:40 PM

Apr 24 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

remove the unnecessary function

Apr 24 2018, 1:14 AM
herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@raster, @cedric
applying 'efl. 'prefix for parts is finished I think. could you verify this patch?
and then I will make the new patch for new signal policy as you and jaehyun mentioned :)

Apr 24 2018, 1:01 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply efl_part name policy more

Apr 24 2018, 12:29 AM

Apr 20 2018

herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@cedric, @raster
I just finished removing the legacy part name and added "efl." prefix to all parts used in source code in edc/efl :)

Apr 20 2018, 6:03 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 20 2018, 5:40 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 5:06 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 4:20 AM

Apr 16 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 16 2018, 4:50 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

modified more parts

Apr 16 2018, 4:34 AM