Page MenuHomePhabricator

herb (Taehyub Kim)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
May 8 2014, 7:56 PM (262 w, 4 d)
Availability
Available

Recent Activity

Wed, Apr 24

herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158431, @q66 wrote:

No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.

Wed, Apr 24, 2:43 AM · efl
herb updated the diff for D8696: eo_parser: fix unreachable code.

update code

Wed, Apr 24, 2:41 AM · efl
herb added a comment to D8696: eo_parser: fix unreachable code.
In D8696#158404, @q66 wrote:

The goto is unnecessary, syntax error means a long jump

@q66
Hi, you mean these codes are intended?
but actually the following codes are not reachable.
2198: if (is_enum)
2199: eo_lexer_syntax_error(ls, "enums cannot have @free");

Wed, Apr 24, 1:02 AM · efl

Tue, Apr 23

herb requested review of D8696: eo_parser: fix unreachable code.
Tue, Apr 23, 10:14 PM · efl

Mon, Apr 22

herb closed D8683: elc_hoversel: fix selected event compatibility issue.
Mon, Apr 22, 11:59 PM · efl
herb updated the diff for D8683: elc_hoversel: fix selected event compatibility issue.

update code

Mon, Apr 22, 11:49 PM · efl
herb requested review of D8683: elc_hoversel: fix selected event compatibility issue.
Mon, Apr 22, 11:38 PM · efl

Apr 17 2019

herb requested review of D8628: elm_notify: fix theme apply logic for new return value.
Apr 17 2019, 12:53 AM · efl

Mar 28 2019

herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 2:35 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

modify the code

Mar 28 2019, 1:18 AM · efl
herb updated the diff for D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.

update the codes

Mar 28 2019, 12:52 AM · efl

Mar 27 2019

herb requested review of D8492: efl_ui_alert_popup: add new feature for applying side button style of alert popup.
Mar 27 2019, 9:38 PM · efl

Mar 21 2019

herb requested review of D8443: efl_ui_layout: Eina_Error type has been modified to work correctly..
Mar 21 2019, 7:15 PM · efl

Jan 27 2019

herb requested review of D7798: efl_ui_selection_manager: change strcat to strncat for safety.
Jan 27 2019, 11:11 PM · efl
herb requested review of D7797: efl_ui_dnd: fix the wrong parameter passing.
Jan 27 2019, 11:07 PM · efl

Sep 21 2018

herb requested review of D7089: elm_entry: update documentation for elm_entnry_textonly_mode_set/get.
Sep 21 2018, 2:01 AM · efl

Sep 20 2018

herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:48 PM · efl
herb updated the diff for D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.

update the code

Sep 20 2018, 10:44 PM · efl
herb updated the summary of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:41 PM · efl
herb updated the summary of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:40 PM · efl
herb requested review of D7082: ecore_con_legacy: add null checking.
Sep 20 2018, 10:24 PM · efl
herb requested review of D7081: eina_vpath: fix the memory leak.
Sep 20 2018, 10:21 PM · efl
herb requested review of D7080: ecore_main: fix the invalid return value.
Sep 20 2018, 10:15 PM · efl
herb retitled D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup from Efl.Ui.Popup.Alert: add icon parameter for icon button to Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:10 PM · efl
herb requested review of D7079: Efl.Ui.Popup.Alert: add icon parameter for icon button of popup.
Sep 20 2018, 10:09 PM · efl

Aug 8 2018

herb added a member for reviewers: herb.
Aug 8 2018, 1:04 AM

May 1 2018

herb added a comment to D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

currently, this patch is not available. I will abandon this :)

May 1 2018, 6:30 PM · efl

Apr 26 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update interface scrollable code

Apr 26 2018, 1:49 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply indentation

Apr 26 2018, 12:55 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 26 2018, 12:21 AM

Apr 25 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

updated source code

Apr 25 2018, 11:40 PM

Apr 24 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

remove the unnecessary function

Apr 24 2018, 1:14 AM
herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@raster, @cedric
applying 'efl. 'prefix for parts is finished I think. could you verify this patch?
and then I will make the new patch for new signal policy as you and jaehyun mentioned :)

Apr 24 2018, 1:01 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

apply efl_part name policy more

Apr 24 2018, 12:29 AM

Apr 20 2018

herb added a comment to D5934: efl theme: remove the elm legacy name of efl ui theme.

@cedric, @raster
I just finished removing the legacy part name and added "efl." prefix to all parts used in source code in edc/efl :)

Apr 20 2018, 6:03 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 20 2018, 5:40 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 5:06 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update source code

Apr 20 2018, 4:20 AM

Apr 16 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 16 2018, 4:50 AM
herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

modified more parts

Apr 16 2018, 4:34 AM

Apr 13 2018

herb updated the diff for D5934: efl theme: remove the elm legacy name of efl ui theme.

update the code

Apr 13 2018, 1:43 AM

Apr 3 2018

herb updated the diff for D5858: Efl.Ui.Bg_Widet: added Efl.Ui.Bg_Widget.Part_Bg part to support "background" part name.

update the code

Apr 3 2018, 11:35 PM · efl

Mar 23 2018

herb updated the diff for D5845: efl_ui_scroll_alert_popup: rename from efl_ui_popup_alert_scroll to efl_ui_scroll_alert_popup.

update the code

Mar 23 2018, 12:50 AM · efl

Dec 12 2017

herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:38 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:25 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 10:08 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 12 2017, 9:30 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

Efl.Ui.Popup.Alert.Text: add expandable property with group calculation

Dec 12 2017, 9:28 PM

Dec 10 2017

herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:21 PM
herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:11 PM
herb updated the diff for D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.

update the code

Dec 10 2017, 10:08 PM
herb added a comment to D5630: efl_ui_popup_alert_scroll: Add expandable property.

@Jaehyun_Cho
I uploaded two patches you mentioned.

Dec 10 2017, 5:47 PM
herb updated the diff for D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.

update the code

Dec 10 2017, 5:42 PM

Dec 8 2017

herb created D5631: efl.ui.popup.alert.scroll: add more test cases for efl.ui.popup.alert.scroll popup.
Dec 8 2017, 12:03 AM

Dec 7 2017

herb added a comment to D5630: efl_ui_popup_alert_scroll: Add expandable property.

@Jaehyun_Cho

  1. could you separate the efl.ui.popup.alert patch from this path?
  2. could you add comment for group size calculation logic how it works?
Dec 7 2017, 11:45 PM
herb created D5618: Efl.Ui.Popup.Alert: add message signal process function for scroller size calculation.
Dec 7 2017, 2:35 AM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 7 2017, 2:31 AM

Dec 5 2017

herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 9:59 PM
herb updated the diff for D5600: Efl.Ui.Popup: add popup_size property.

update the code

Dec 5 2017, 9:48 PM
herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 9:24 PM
herb updated the diff for D5547: efl_ui_popup_alert_text: add expandable feature.

update the code

Dec 5 2017, 4:22 AM
herb abandoned D5498: Efl.Ui.Popup: add resize callback to update align.
Dec 5 2017, 3:48 AM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 5 2017, 3:42 AM
herb created D5600: Efl.Ui.Popup: add popup_size property.
Dec 5 2017, 2:55 AM
herb updated the diff for D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.

update the code

Dec 5 2017, 1:38 AM

Dec 4 2017

herb abandoned D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.
Dec 4 2017, 8:29 PM
herb updated the diff for D5557: Efl.Ui.Popup.Scroll: add expandable feature.

update the code

Dec 4 2017, 12:01 AM

Nov 29 2017

herb created D5557: Efl.Ui.Popup.Scroll: add expandable feature.
Nov 29 2017, 12:56 AM

Nov 28 2017

herb created D5554: Efl.Ui.Popup: calculate the alignment when the size is changed.
Nov 28 2017, 8:37 PM
herb created D5547: efl_ui_popup_alert_text: add expandable feature.
Nov 28 2017, 3:52 AM

Nov 20 2017

herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 20 2017, 12:31 AM
herb created D5498: Efl.Ui.Popup: add resize callback to update align.
Nov 20 2017, 12:29 AM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 20 2017, 12:25 AM

Nov 14 2017

herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 14 2017, 6:23 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 14 2017, 12:21 AM

Nov 13 2017

herb added a comment to D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

@jpeg I modified the code as you commented :)

Nov 13 2017, 11:16 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

update the code

Nov 13 2017, 11:13 PM
herb updated the diff for D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.

add more test cases and update the code

Nov 13 2017, 11:06 PM
herb created D5464: Efl.Ui.Popup.Alert.Text: add expandable feature to expand horizontally.
Nov 13 2017, 3:29 AM

Oct 27 2017

herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

update the code

Oct 27 2017, 1:57 AM

Oct 26 2017

herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

update the code

Oct 26 2017, 7:44 PM

Oct 25 2017

herb updated the diff for D5372: Efl.Ui.Popup: add timeout signal.

change the callback function

Oct 25 2017, 7:41 PM
herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

update description

Oct 25 2017, 12:11 AM
herb updated the diff for D5366: modified Efl.Ui.Popup Sample Code.

modified the sample

Oct 25 2017, 12:09 AM
herb created D5373: Efl.Ui.Popup: add _calc_align function in sizing eval function.
Oct 25 2017, 12:05 AM
herb created D5372: Efl.Ui.Popup: add timeout signal.
Oct 25 2017, 12:00 AM

Oct 24 2017

herb created D5366: modified Efl.Ui.Popup Sample Code.
Oct 24 2017, 6:08 AM

Oct 18 2017

herb closed D5339: ecore: remove doxygen warning messages.
Oct 18 2017, 3:42 AM
herb created D5339: ecore: remove doxygen warning messages.
Oct 18 2017, 1:12 AM

Sep 20 2017

herb updated the diff for D5205: Efl.Ui.Popup: implement timeout feature.

update the code

Sep 20 2017, 9:29 PM
herb updated the diff for D5205: Efl.Ui.Popup: implement timeout feature.

update the code

Sep 20 2017, 3:41 AM
herb updated the diff for D5205: Efl.Ui.Popup: implement timeout feature.

update the code

Sep 20 2017, 3:37 AM
herb updated the diff for D5205: Efl.Ui.Popup: implement timeout feature.

update the code

Sep 20 2017, 1:14 AM

Sep 19 2017

herb updated the diff for D5205: Efl.Ui.Popup: implement timeout feature.

update the code

Sep 19 2017, 4:13 AM

Sep 18 2017

herb created D5205: Efl.Ui.Popup: implement timeout feature.
Sep 18 2017, 1:31 AM

Sep 17 2017

herb created D5204: Efl.Ui.Popup.Alert.Scroll: add a sizing check variable for safety of sizing evaluation while scroller is changed.
Sep 17 2017, 11:46 PM

Aug 30 2017

herb abandoned D5078: Efl.Ui.Popup.Scroll.Alert: Add Efl.Ui.Popup.Scroll.Alert Class Code.
Aug 30 2017, 11:16 PM
herb added a comment to T5326: Refactor ctxpopup, popup and notify.

I will remove the patches which are not related to the latest design.

Aug 30 2017, 10:48 PM · efl: widgets, Restricted Project
herb updated the diff for D5123: Efl.Ui.Popup.Alert.Scroll: add initial code for Efl.Ui.Popup.Alert.Scroll.

remove the space

Aug 30 2017, 9:15 PM