Page MenuHomePhabricator

herdsman (Daniel Hirt)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Dec 31 2013, 12:06 AM (258 w, 4 d)
Availability
Available

Recent Activity

Wed, Dec 5

herdsman added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

I am not sure about the third point:

To improve the above situation, [...] so the expensive properties can be set only once [...]

Wed, Dec 5, 3:19 AM · Restricted Project

Mon, Dec 3

herdsman added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

Just adding that the constructors block should be used to not only ALLOW (i.e. "optional" methods) setting the state of the object, but also REQUIRE setting its state.

Mon, Dec 3, 9:11 AM · Restricted Project

Wed, Nov 28

herdsman requested changes to D7366: ui/text: Postpone scrollable property in efl_add.

I will mark so we can further discuss this before landing.

Wed, Nov 28, 2:18 AM · efl
herdsman added a comment to D7366: ui/text: Postpone scrollable property in efl_add.

Please give me today to just see that everything is in order.
This is a proper fix to T7468, and I intended to fix it similarly.

Wed, Nov 28, 2:18 AM · efl
herdsman added a reviewer for D7368: textblock: Fix crash with filters: herdsman.
Wed, Nov 28, 1:59 AM · efl
herdsman added a reviewer for D7369: tests: Rework "gfx filters" test case to use eo: herdsman.
Wed, Nov 28, 1:58 AM · efl

Mon, Nov 26

herdsman closed T7468: elementary: Hello World example does not render labels as Invalid.

See last comment.

Mon, Nov 26, 5:40 AM · regression, efl: widgets
herdsman added a comment to T7468: elementary: Hello World example does not render labels.

We've discussed this a bit on IRC and on another ticket, so I will add a bit of input here in addition to closing this:

Mon, Nov 26, 3:45 AM · regression, efl: widgets

Mon, Nov 19

herdsman added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

Continuing our conversation on IRC, I will express my opinions here:

Mon, Nov 19, 6:02 AM · Restricted Project

Sun, Nov 18

herdsman closed T7468: elementary: Hello World example does not render labels as Resolved by committing rEFL2c0f094da5a8: Ui text: fix size evaluation on construction.
Sun, Nov 18, 2:52 AM · regression, efl: widgets

Sat, Nov 17

herdsman added a comment to T7468: elementary: Hello World example does not render labels.

Thanks for reporting.
I will work on resolving this regression.

Sat, Nov 17, 12:10 PM · regression, efl: widgets

Fri, Nov 16

herdsman closed T7466: Evas test is broken with hyphen enabled as Resolved by committing rEFLde72dd57303a: Evas textblock: fix test to use provided hyphen dictionary.
Fri, Nov 16, 1:28 AM · efl: canvas, efl (efl-1.21)

Nov 14 2018

herdsman closed D7204: evas textblock: remove white space after line-break by a next item.
Nov 14 2018, 12:44 AM · efl
herdsman accepted D7204: evas textblock: remove white space after line-break by a next item.

Hi! Thanks for the patch. I have some time today to review.

Nov 14 2018, 12:21 AM · efl

Nov 8 2018

herdsman closed T7456: edje test suite failing with meson as Resolved by committing rEFLe8ed36af105f: Canvas layout: fix test for meson builds.
Nov 8 2018, 1:45 AM · efl: layout engine
herdsman added a comment to T7456: edje test suite failing with meson.

Oh, OK. Let me check.
Thanks for reporting.

Nov 8 2018, 1:20 AM · efl: layout engine

Sep 17 2018

herdsman closed D6045: edje: Remove hack code.
Sep 17 2018, 8:13 AM · efl
herdsman accepted D6045: edje: Remove hack code.

Yes, this was meant for efl-1.22. Didn't want to disrupt all the work for efl-1.21.

Sep 17 2018, 7:33 AM · efl

Jul 17 2018

herdsman added a comment to D6599: macos: allow text to be selected..

Is there a particular reason we have to iterate to the very top parent instead of using elm_widget_top_get?
I wonder if this never worked, or something that's been recently changed.

Jul 17 2018, 3:56 AM · efl

Jul 16 2018

herdsman added a comment to T7144: Eina_Bool type.

Okay, I feel less concerned now. I assumed the treatment is the same as it was to a signed char.
However, upon further testing, the bitfield bool value was converted from the stored 1 to 1 (or: true), as opposed to -1, (which I expected it to be).
Looks like C99 adds an implicit conversion for bool types.

Jul 16 2018, 6:04 AM · efl: data types, Restricted Project
herdsman added a comment to T7144: Eina_Bool type.

Fwiw, please consider that for bitfields of one bit (e.g. bool changed: 1;) the values will be 0 and -1 due to bool being a signed char. If we ensure consistency on usage it shouldn't be an issue.

Jul 16 2018, 4:38 AM · efl: data types, Restricted Project
herdsman added a comment to D6553: eo: Fix efl_new without initializing parameters.

Never said it was okay.
Anyway, if you believe this need to be fixed at some point, please open a ticket.
We can decide on the priority for win32 builds.

Jul 16 2018, 1:02 AM · efl
herdsman added a comment to T7113: DND broken and crashes elm_test.

Got raster here to shoot down the bad bugs :)

Jul 16 2018, 1:01 AM · efl: widgets, Restricted Project, efl (efl-1.21)

Jul 15 2018

herdsman added a comment to D6553: eo: Fix efl_new without initializing parameters.

I too was concerned about it. However, efl_add and efl_add_ref are both implemented in the same manner.

Jul 15 2018, 9:52 PM · efl
herdsman added a comment to D6592: Eina binbuf: add explicit null-check before magic-check.

I thought about it, but ended up preferring the explicit solution. I briefly scanned and didn't see EINA_MAGIC_CHECK used as a null-check replacement.

Jul 15 2018, 2:49 PM · efl
herdsman added a reviewer for D6592: Eina binbuf: add explicit null-check before magic-check: zmike.
Jul 15 2018, 6:35 AM · efl

Jul 12 2018

herdsman closed T7130: efl latest breaks dnd in enlightenment as Resolved by committing rEFLe9925e609f36: Selection manager: properly clean in drop_target_del.
Jul 12 2018, 11:46 PM · efl: widgets
herdsman closed D6579: Selection manager: properly clean in drop_target_del.
Jul 12 2018, 11:46 PM · efl
herdsman triaged T7140: Remove printf from tests as TODO priority.
Jul 12 2018, 11:44 PM · Testing, Restricted Project
herdsman added a comment to D6576: efl_ui_scroll : apply finalize and invalidate object..

This appears to be a duplicate of D6574. Was it abandoned?

Jul 12 2018, 1:28 PM · efl
herdsman added reviewers for D6579: Selection manager: properly clean in drop_target_del: zmike, raster.
Jul 12 2018, 8:28 AM · efl
herdsman added a revision to T7130: efl latest breaks dnd in enlightenment: D6579: Selection manager: properly clean in drop_target_del.
Jul 12 2018, 8:27 AM · efl: widgets
herdsman added a comment to D6574: efl_ui_scroll : apply finalize and invalidate object..

pd->smanager, pd->box and pd->pan are bound to the object's lifecycle, so I would suggest to not explicitly efl_del those in the invalidate() call.
From what I understand, the invalidate() is meant for cases where you have to have access to the child before it gets deleted (which now occurs before the parent's destructor).

Jul 12 2018, 3:33 AM · efl
herdsman closed D6529: evas textblock: adds missing legacy types.
Jul 12 2018, 2:26 AM · efl
herdsman accepted D6529: evas textblock: adds missing legacy types.

Oh, right. That is unfortunate.

Jul 12 2018, 2:26 AM · efl

Jul 10 2018

herdsman requested changes to D6552: elm_fileselector: move to focus compostition.

May I ask to reword so that it says "Focus Composition" and not just "Composition"?
I was rather confused.

Jul 10 2018, 5:03 AM · efl

Jul 9 2018

Herald added a reviewer for D6536: Ui.Scroll_Manager: restrict to Efl.Ui.Pan type for 'pan' property: devilhorns.
Jul 9 2018, 6:52 AM · efl
herdsman requested changes to D6529: evas textblock: adds missing legacy types.

May I ask to provide a version in which those types were available?
I would like to verify that they are indeed "missing" now.

Jul 9 2018, 3:03 AM · efl

Jul 3 2018

herdsman added a comment to D5490: evas textblock: add/apply cursor cluster APIs based on grapheme cluster.
In D5490#111480, @zmike wrote:

Upon further consideration, I think the best choice for managing this would be to:

  • create a slowvote on phab to discuss/vote on inclusion
  • add the committers group on cc with a comment to check the voting link

    This will enable us to reduce dependence on a mailing list which has repeatedly proven unreliable in the past.
Jul 3 2018, 8:39 AM · efl
herdsman accepted D5490: evas textblock: add/apply cursor cluster APIs based on grapheme cluster.

@zmike, I have done a bunch of testing and I believe it will be a great addition to the upcoming release.
Asking your permission to merge this feature to master.

Jul 3 2018, 5:34 AM · efl
herdsman added a comment to D4283: edje: Apply color_class to TEXTBLOCK part's style.

I added a few inline comments.

Jul 3 2018, 5:30 AM · efl
herdsman requested changes to D4283: edje: Apply color_class to TEXTBLOCK part's style.

So far so good, but I would like to ask it to be its own test, as there is still work to be done (i.e. have the change not being global, but per object).
Also, I would rather see such test demonstrate more color classes other than "entry text", for demonstration and coverage purposes.

Jul 3 2018, 4:47 AM · efl

Jul 2 2018

herdsman added a comment to D4283: edje: Apply color_class to TEXTBLOCK part's style.

Just a heads up as this patch is going through another round of review by me.
I will provide my insight (and hopefully accept) ASAP.

Jul 2 2018, 8:59 AM · efl
herdsman closed T3399: [evas_textblock] Markup translation from <br/> to <ps/> as Resolved by committing rEFLf6acd6f9e4de: Evas Textblock: Don't convert <br/> to <ps/> after changing text.
Jul 2 2018, 8:33 AM · efl: widgets
herdsman closed D3874: Evas Textblock: Don't convert <br/> to <ps/> after changing text.
Jul 2 2018, 8:33 AM · efl
herdsman accepted D3874: Evas Textblock: Don't convert <br/> to <ps/> after changing text.

Alright. Good patch!

Jul 2 2018, 8:29 AM · efl
herdsman closed T6986: evas_suite fails due to textblock assertion as Resolved by committing rEFL27c677f1e088: Evas textblock: clear ellipsis item at start of layout.
Jul 2 2018, 3:53 AM · Restricted Project, efl (efl-1.21), efl: rendering
herdsman closed T6986: evas_suite fails due to textblock assertion, a subtask of T6838: improve test reliability, as Resolved.
Jul 2 2018, 3:53 AM · Restricted Project, Testing
herdsman closed D3707: Evas font: add comparison for fallbacks in evas_font_desc_cmp().
Jul 2 2018, 3:53 AM · efl
herdsman closed D3703: Evas font: fix inifinite loop problem for fallback fonts.
Jul 2 2018, 3:53 AM · efl
herdsman accepted D3703: Evas font: fix inifinite loop problem for fallback fonts.

This will be followed by D3707.

Jul 2 2018, 1:05 AM · efl

Jun 28 2018

herdsman accepted D3707: Evas font: add comparison for fallbacks in evas_font_desc_cmp().

This will be pushed after D3703

Jun 28 2018, 8:11 AM · efl
herdsman added a comment to D3703: Evas font: fix inifinite loop problem for fallback fonts.

I will simplify this line for you, if you don't mind. :)

Jun 28 2018, 7:18 AM · efl
herdsman added a comment to D3703: Evas font: fix inifinite loop problem for fallback fonts.

The discussion here was a bit confusing.
So to sum up: D3707 introduced the infinite loop bug. OK.
This patch fixes it.

Jun 28 2018, 7:12 AM · efl
herdsman updated subscribers of T7090: EDI: Popup Close Crash (focus_manager?).

@bu5hm4n, I tend to agree with you.

Jun 28 2018, 6:32 AM · regression, efl (efl-1.21)
herdsman added a comment to T5282: Terminology loves emoticons so much, it wants to show them off as HUGE.

@charlesmilette, also I would like to verify that you are testing efl-git and not v1.20.
Thanks.

Jun 28 2018, 5:09 AM · efl: rendering, Terminology
herdsman added a comment to T5282: Terminology loves emoticons so much, it wants to show them off as HUGE.

@charlesmilette, thanks for the input.
Unfortunately, I am still unable to reproduce.
I have tried "Fire Mono" and the font in terminology, and did the "curl" command. Everything seems to be intact.
Let's try additional steps, if you don't mind.
Much appreciated.

Jun 28 2018, 3:02 AM · efl: rendering, Terminology

Jun 27 2018

Herald added a reviewer for D6467: Elm label: fix "horizontal_fixed" usage with different styles: devilhorns.
Jun 27 2018, 2:25 PM · efl
herdsman added a revision to T5382: elm label overrides theme styles: D6467: Elm label: fix "horizontal_fixed" usage with different styles.
Jun 27 2018, 2:25 PM · efl (efl-1.21), efl: widgets
herdsman triaged T5282: Terminology loves emoticons so much, it wants to show them off as HUGE as Normal priority.

If anyone can provide a test scenario for this, please do.
I can't reproduce this.

Jun 27 2018, 1:20 PM · efl: rendering, Terminology

Jun 22 2018

herdsman closed T2994: RTL language ellipsis support in evas TEXT as Resolved.

Resolved a long time ago.
Here is a quick test program for RTL (see attached file):

$ edje_cc label_text.edc
$ edje_player label_text.edj

Jun 22 2018, 9:20 AM · efl (efl-1.21), efl: rendering
herdsman added a comment to D6365: Edje: recalc edje before fetching the real part.

Pushed. Also, fixed some grammar mistakes, and also removed the local fix. New test still passes.

Jun 22 2018, 7:13 AM · efl
herdsman added a commit to T7057: Edje: add tests for TEXT and TEXTBLOCK parts: rEFL8f95b17f39cb: Edje: recalc edje before fetching the real part.
Jun 22 2018, 7:12 AM
herdsman closed D6365: Edje: recalc edje before fetching the real part.
Jun 22 2018, 7:12 AM · efl
Herald edited projects for D6365: Edje: recalc edje before fetching the real part, added: efl; removed efl (efl-1.21).
Jun 22 2018, 2:54 AM · efl
herdsman requested review of D6365: Edje: recalc edje before fetching the real part.
Jun 22 2018, 2:51 AM · efl
Herald added a reviewer for D6365: Edje: recalc edje before fetching the real part: devilhorns.
Jun 22 2018, 2:51 AM · efl
herdsman closed D6364: edje: fix text set/get issue without edje calculation.
Jun 22 2018, 2:39 AM · efl
herdsman added a comment to D6364: edje: fix text set/get issue without edje calculation.

Absolutely good point: additional API should also include tests (even basic ones like in this case), to easily spot regressions.

Jun 22 2018, 2:21 AM · efl
herdsman created T7057: Edje: add tests for TEXT and TEXTBLOCK parts.
Jun 22 2018, 2:17 AM

Jun 21 2018

herdsman requested changes to D6347: Fix segfault when parsing EO_LIFECYCLE_DEBUG envvar.

Since 2 can never occur, the following lines will be dead code.

Jun 21 2018, 4:57 AM · efl

Jun 20 2018

herdsman requested changes to D5721: elementary: Fix textblock empty check logic.

This patch doesn't describe an issue that was fixed. Why the @fix tag, then?

Jun 20 2018, 11:59 AM · efl
herdsman added a comment to T6986: evas_suite fails due to textblock assertion.

Nothing here ATM.
I am running the equivalent:

while true; do ./tests/evas/evas_suite "Object Textblock" || break; done
Jun 20 2018, 10:54 AM · Restricted Project, efl (efl-1.21), efl: rendering
herdsman closed T6279: segfault in edje_player as Resolved by committing rEFLff8c383649bc: Edje load: add safecheck for TEXTBLOCK-specific code path.
Jun 20 2018, 9:31 AM · efl: widgets, efl (efl-1.21), Bug Report

Jun 12 2018

herdsman lowered the priority of T6310: Add Text drawing support in Ector from TODO to Wishlist.
Jun 12 2018, 4:45 AM · efl: rendering

Jun 11 2018

herdsman closed T5713: Text line spacing regression as Resolved.

Resolved this one a while ago.

Jun 11 2018, 10:29 AM · regression, efl: rendering
herdsman closed T6997: Broken textblock. as Resolved by committing rEFLa99f3374135f: edje: fix an issue "description.text.text" is not shown.
Jun 11 2018, 9:14 AM · efl: widgets, regression
herdsman closed D6257: edje: fix an issue "description.text.text" is not shown.
Jun 11 2018, 9:14 AM · efl
herdsman accepted D6257: edje: fix an issue "description.text.text" is not shown.

Works!
Thank you :)

Jun 11 2018, 7:43 AM · efl
herdsman added a comment to T6997: Broken textblock..

Hi @Hermet can you try this patch? Thank you.
@zmike, seems like it is. Quickfix is referenced here, so I'll accept and push.

Jun 11 2018, 6:08 AM · efl: widgets, regression

Jun 8 2018

herdsman added a comment to T6988: Study viability of removing EO files for legacy API.

Shouldn't @commiters be subscribed here?

Jun 8 2018, 1:38 AM · efl: language bindings

Jun 7 2018

herdsman added a comment to D6045: edje: Remove hack code.

I noticed that "recalc_apply" is called when the !ed->calc_only condition occurs.
Do you have any information what the !calc_only is used for, if you happened to investigate on those tricky spots.
I am worried that removing this call from when edje wants to "recalc" will lead to unwanted behavior.

Jun 7 2018, 3:40 AM · efl
Herald added a project to D5841: evas font: add/apply font glyph lru list: efl.

This is still under review, as I want to have a decent method to measure the performance gain/hit here.

Jun 7 2018, 3:36 AM · efl
Herald added a project to D6001: evas textblock: prevent invalid read from a free'd cursor: efl.

That is unfortunate.
As a (hopefully) temporary solution, please add a FIXME that describes the problem with how the paragraph direction update happens.
After I push and read this the issue, we will formulate a plan to somehow fix that.
In general, FIXMEs are easier to find in code.

Jun 7 2018, 3:35 AM · efl

Jun 6 2018

herdsman added a comment to T6988: Study viability of removing EO files for legacy API.

This has been in the discussion in the last few days.
I believe this ticket needs to elaborate what the actual issues are, specifically this:

Problem is, a lot of workarounds have been added to Eolian in order to accommodate for all the quirks in the Legacy API, which are impairing the bindings work. It would be far cleaner and faster if the Legacy API went back to C land and the EO files were used exclusively for the EFL API.

Jun 6 2018, 5:12 AM · efl: language bindings
herdsman added a comment to T6986: evas_suite fails due to textblock assertion.

OK. As I wasn't able to reproduce this, may I ask for your build options ("configure" flags).
I tried disabling harfbuzz, but tests still pass.

Jun 6 2018, 4:28 AM · Restricted Project, efl (efl-1.21), efl: rendering

Jun 5 2018

herdsman added a comment to T6986: evas_suite fails due to textblock assertion.

I will investigate this tomorrow.
Is this something recent, or has been like that for a while?

Jun 5 2018, 11:20 AM · Restricted Project, efl (efl-1.21), efl: rendering

Jun 4 2018

herdsman added a comment to D5490: evas textblock: add/apply cursor cluster APIs based on grapheme cluster.

[snip]
This feature is pending above a half year.
I think if the core concept is acceptable, it has to be merged to main branch. To see any side effect as much as possible by EFL developers.
If there is a chance to reduce code duplication, let's make additional patches. :)

Jun 4 2018, 2:22 AM · efl

May 29 2018

herdsman requested changes to D5490: evas textblock: add/apply cursor cluster APIs based on grapheme cluster.

Hi,
Sorry it took me some time to give feedback, as this is quite a large patch and I have been busy with other reviews and work.

May 29 2018, 6:45 AM · efl

May 17 2018

herdsman edited the content of Weekly Meeting - May #2.
May 17 2018, 2:58 AM
herdsman edited the content of Weekly Meeting - May #2.
May 17 2018, 2:51 AM
herdsman renamed Weekly Meeting - May #2 from Weekly meeting May 2 to Weekly Meeting - May #2.
May 17 2018, 2:51 AM

May 16 2018

herdsman closed D5692: evas textblock: manage default style properly for new interfaces.
May 16 2018, 12:42 PM · efl
herdsman closed D4697: evas textblock: update format nodes when a Evas Textblock Style is updated.
May 16 2018, 12:42 PM · efl
herdsman accepted D5692: evas textblock: manage default style properly for new interfaces.

Rebased and approved.
Also, please note that I remove the changes made to START_TEST(efl_canvas_text_cursor), as they seem unrelated to the commit message.
Thank you! Much appreciated.

May 16 2018, 12:20 PM · efl
herdsman accepted D4697: evas textblock: update format nodes when a Evas Textblock Style is updated.

Rebased to master.

May 16 2018, 10:52 AM · efl

May 14 2018

herdsman added a comment to D6149: edje: don't give a wrong Edje data when an Edje object has group parts.

Agreed. No need for extra checks in non-legacy code path.
I dislike the inline comments, though. We don't need those.
Please remove the comments and I'll then push this patch.

May 14 2018, 9:22 AM · efl

May 10 2018

herdsman requested changes to D6149: edje: don't give a wrong Edje data when an Edje object has group parts.

Good observation.
I think that we can actually save code by removing lines 6289 to 6299 of the lines in edje_object_part_text_get and simply call _edje_efl_text_text_get with the original given ed.
The warning should be moved to the latter function, too.
Unless, I am missing something that might break functionality.

May 10 2018, 3:41 AM · efl

May 7 2018

herdsman added a comment to D6045: edje: Remove hack code.

Performance improvement is always welcome! :)

May 7 2018, 7:17 AM · efl
herdsman added a comment to D6045: edje: Remove hack code.

I am a bit confused about the following:

May 7 2018, 3:41 AM · efl