- User Since
- Apr 15 2013, 2:09 AM (339 w, 3 d)
Dec 16 2018
Thank you for your first patch!
I leaved a inline comment. Please check that comment. :)
And please check the following things.
Dec 6 2018
Dec 5 2018
Dec 4 2018
Add more condition for using xlocale.h
Oh, thank you for testing. :)
Because of firewall of office, I couldn't push my patch to a dev branch directly.
I'll update it soon. Thank you!
Nov 30 2018
Previous patch for eina_convert (D6644) caused a build failure from OS X. :(
So I uploaded this patch. But, I can't run build test on OS X.
Is there a way to test it on OS X using build system?
Nov 13 2018
Use USHRT_MAX to avoid overflow problem itself.
This is an example.
If you want to check the issue caused by overflow, please run this patch.
Before test it, you need to enable EDJE_CALC_CACHE.
Oct 24 2018
If you want to see a visualized one of the test case, please test it.
fix a comment in test case.
Oct 3 2018
remove an unwanted change from this patch
elementary entry: apply scale to entry_edje when an entry is scrollable
Sep 28 2018
It fixed many issues caused by recent changes in Edje.
I'll accept this patch. Thank you.
Sep 27 2018
add since tag
Remove error/critical messages with/without GL
I found you pushed patch to use efl_unref() for removing error messages from efl_del when there is no parent.
But, if you enable GL engine support, fb->buffer will have a parent. So, efl_unref() will print the critical error messages.
Hmm... efl_unref also prints another error messages. I think it is not the perfect solution for the issue.
It needs more legacy alias names. I found the following alias has to be included.
Sep 21 2018
Sep 20 2018
fix build failure
Sep 17 2018
update brief documents for Elm_Textpath.
Uh oh.... I didn't modified copied documents. LOL.
Please, review only its purpose. I'll update documents if the patch is acceptable.
If it is not acceptable, I'll abandon this and maintain this in Tizen platform only.
Sep 13 2018
Sep 10 2018
Sep 9 2018
Thank you for patch. There are few things to check.
- Please , put bracket on both conditions of if in edje_util.c. Normally, EFL puts brackets both side if we needed it.
- Please, test your new test case with new condition for edje_recalc_do(): avoiding calling edje_recalc_do() when Edje is not dirty.
Aug 21 2018
Init and free locale in eina_init, eina_shutdown
Thank you for good opinion. I'll update it.
Aug 13 2018
So, is this OK?
If I need to check it more, please let me know.
Jul 30 2018
update the document
I don't agree renaming internal functions to new/del. Actually, _get function just return static locale variable. new/free or new/del makes confuse people.
update the following things.
Jul 29 2018
fix build failure from Windows OS
Jul 26 2018
Thank you. I missed your comment in the previous update.
fix build error Windows OS.
add a simple test case
fix build error in Windows OS.
Jul 25 2018
fix a tiny code indentation
remove changes of Evas Textblock
Ok. Then, I'll split changes of Evas Textblock into an another patch after applying this.
Also, I'll update commit message with @feature tag.
Jul 24 2018
add eina_convert_strtod_c API and apply it to evas_object_textblock
Jul 23 2018
Thank you for review!
Jul 20 2018
Jul 11 2018
And please check a similar legacy type support from the Efl.Ui.Button.
Thank you for review!
It was generated by Eolian of efl 1.16.0. (Tizen 4.0)
I attached a generated .eo.legacy.h file of the Textblock.
Jul 8 2018
Jun 22 2018
Thank you for quick review! :)
I feel EFL became really hard to maintain recently.
After applying new interfaces into legacy code and legacy API.
It is not your fault but the strategy for new interface implementation.
Anyway, thank you for review!
We are struggling to fix the issues caused by recent upstream patches..
Please, add test cases when you guys try to change existing behaviors even if you are a committer.
Jun 15 2018
I passed the patch file to @smohanty to push it directly.
So, I abandon this.
Jun 11 2018
Thank you for quick review!
Jun 4 2018
Remove an irrelevant change from test_entry.c
Thank you for comment.
Update the following things...
- Add/Apply a helper function for creating "grapheme_breaks".
- Add/Apply a helper function for reducing code duplication of prev/next function.
Jun 3 2018
Then, I can abandon this patch! :)
May 25 2018
I also added a debugging code in this patch which is disabled for default.
I think I has to maintain this widget instead of @thiepha.
So, please, just submitted debugging code with the patch. For my debugging convenience.
Remove a wrong comment
Removed: uniniialized value is used in loop condition statement.
May 17 2018
Remove inline comments.
May 14 2018
May 10 2018
Thank you for comment.
As I know, you used _edje_part_fetch() function at that point to check the given part is TEXT or TEXTBLOCK part.
In legacy, edje_object_part_text_get() used to checked the given part type.
But, after applying efl_part() concept, efl_canvas_layout_part_* checked part type before doing something.
So, only for legacy API, the type has to be checked manually like now.
Apr 27 2018
Good point! :)
As you said calling _evas_textblock_changed() in render_pre() with delete_me=2 states caused the problem.
But, with current paragraph direction API architecture (INHERIT feature without additional API), there was no way to avoid to calling _evas_textblock_changed() function.
The textblock/text object needed to catch changes of its smart parent's paragraph_direction when its render_pre() was called.
So, I think I can put a additional condition before calling _evas_textblock_changed().
I found it is reproducible in upstream. But, not for Textblock obj.
Entry 'unfocused' callback called Entry 'focused' callback called Entry 'unfocused' callback called ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:1320 _efl_canvas_image_internal_efl_object_destructor() SYB:: IMAGE destructor START!! ... obj[0x4000009f9201] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:1327 _efl_canvas_image_internal_efl_object_destructor() SYB:: IMAGE destructor DONE!! ... obj[0x4000009f9201] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:1320 _efl_canvas_image_internal_efl_object_destructor() SYB:: IMAGE destructor START!! ... obj[0x4000009f9a03] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:1327 _efl_canvas_image_internal_efl_object_destructor() SYB:: IMAGE destructor DONE!! ... obj[0x4000009f9a03] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_render.c:928 _evas_render_phase1_object_changed_normal() SYB:: PUSH a deleted object to STACK ?? obj[0x4000009f9201][image] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_render.c:928 _evas_render_phase1_object_changed_normal() SYB:: PUSH a deleted object to STACK ?? obj[0x4000009f9a03][image] delete_me ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:2275 evas_object_image_render_pre() SYB:: WTF ... obj[0x4000009f9201] ... delete_me ERR<7098>:evas_main lib/evas/canvas/evas_object_image.c:2275 evas_object_image_render_pre() SYB:: WTF ... obj[0x4000009f9a03] ... delete_me Entry 'focused' callback called
Apr 26 2018
Yes, I checked it many times. The render_pre() was called after processing its destructor function.
And when I checked delete_me flag in the render_pre() function, it was 2. (obj->delete_me)
Apr 25 2018
The main question of this patch is...
An object's render or render_pre functions could be called after processing its destructor function?
Right now, it is reproducible when only elc_popup is deleted in Tizen.
Of course, elc_popup has a lot of custom code for Tizen UX.
If I get a reproducible case in upstream, I'll write the scenario.
A render_pre function could be called after processing an object's destructor function.
Here is a log of that problem case.
Apr 23 2018
Sorry, but I think [(int) pos < 0] and [pos > INT_MAX] are same in this case.
I moved the fix from Elementary to Edje.
It also remove negative position feature from Edje's legacy API.
Apr 19 2018
Actually, the issues caused by cursor next/prev/up/down are pretty bad for us.
I need to hurry to apply this to Tizen. So, I'll cherry-pick it to our code.
Please, let me know if you have additional requirements.
make it pretty
fix usage of Efl_Part