- User Since
- Apr 15 2013, 2:09 AM (411 w, 2 d)
Dec 16 2020
Nov 11 2020
I ran a test case, it fix a memory leak issue.
Oct 20 2020
Sep 24 2020
Sep 4 2020
Aug 28 2020
update the documentation for .size_formatted, .size_native
I discussed this patch with @woohyun .
The conclusion is that let's update the documentation and give sizes without style paddings as your last suggestion via messenger.
So, I'll update the documentation on this patch.
Aug 25 2020
The description only shows a example when there is no margin and padding.
What about the margin? As I know, the margin value is added to the both sizes(formatted and native)!
I think there is no rule about how to handle style padding in any descriptions.
Aug 24 2020
Actually, the descriptions for formatted size and native size are not clear.
The descriptions only describe about size with or without line wrapping.
Aug 20 2020
Aug 3 2020
The code indentation is WTH!
There are so many TABs in the rest of code.
Because of TAB in other lines, it looks like HECK.
Fix code indentation.
Jul 16 2020
Thank you for answer.
By the way, the pixel art in your profile picture looks awesome. :)
Jul 15 2020
I agree that it would break all themes. I'll abandon this anyway. But, still I have doubt and I think it is a bug.
Here is a example:
Jun 16 2020
It looks good. I've seen a quite good performance improvement with this patch.
Dec 16 2018
Thank you for your first patch!
I leaved a inline comment. Please check that comment. :)
And please check the following things.
Dec 6 2018
Dec 5 2018
Dec 4 2018
Add more condition for using xlocale.h
Oh, thank you for testing. :)
Because of firewall of office, I couldn't push my patch to a dev branch directly.
I'll update it soon. Thank you!
Nov 30 2018
Previous patch for eina_convert (D6644) caused a build failure from OS X. :(
So I uploaded this patch. But, I can't run build test on OS X.
Is there a way to test it on OS X using build system?
Nov 13 2018
Use USHRT_MAX to avoid overflow problem itself.
This is an example.
If you want to check the issue caused by overflow, please run this patch.
Before test it, you need to enable EDJE_CALC_CACHE.
Oct 24 2018
If you want to see a visualized one of the test case, please test it.
fix a comment in test case.
Oct 3 2018
remove an unwanted change from this patch
elementary entry: apply scale to entry_edje when an entry is scrollable
Sep 28 2018
It fixed many issues caused by recent changes in Edje.
I'll accept this patch. Thank you.
Sep 27 2018
add since tag
Remove error/critical messages with/without GL
I found you pushed patch to use efl_unref() for removing error messages from efl_del when there is no parent.
But, if you enable GL engine support, fb->buffer will have a parent. So, efl_unref() will print the critical error messages.
Hmm... efl_unref also prints another error messages. I think it is not the perfect solution for the issue.
It needs more legacy alias names. I found the following alias has to be included.
Sep 21 2018
Sep 20 2018
fix build failure
Sep 17 2018
update brief documents for Elm_Textpath.
Uh oh.... I didn't modified copied documents. LOL.
Please, review only its purpose. I'll update documents if the patch is acceptable.
If it is not acceptable, I'll abandon this and maintain this in Tizen platform only.
Sep 13 2018
Sep 10 2018
Sep 9 2018
Thank you for patch. There are few things to check.
- Please , put bracket on both conditions of if in edje_util.c. Normally, EFL puts brackets both side if we needed it.
- Please, test your new test case with new condition for edje_recalc_do(): avoiding calling edje_recalc_do() when Edje is not dirty.
Aug 21 2018
Init and free locale in eina_init, eina_shutdown
Thank you for good opinion. I'll update it.
Aug 13 2018
So, is this OK?
If I need to check it more, please let me know.
Jul 30 2018
update the document
I don't agree renaming internal functions to new/del. Actually, _get function just return static locale variable. new/free or new/del makes confuse people.
update the following things.
Jul 29 2018
fix build failure from Windows OS
Jul 26 2018
Thank you. I missed your comment in the previous update.
fix build error Windows OS.
add a simple test case
fix build error in Windows OS.
Jul 25 2018
fix a tiny code indentation
remove changes of Evas Textblock
Ok. Then, I'll split changes of Evas Textblock into an another patch after applying this.
Also, I'll update commit message with @feature tag.
Jul 24 2018
add eina_convert_strtod_c API and apply it to evas_object_textblock
Jul 23 2018
Thank you for review!
Jul 20 2018
Jul 11 2018
And please check a similar legacy type support from the Efl.Ui.Button.
Thank you for review!
It was generated by Eolian of efl 1.16.0. (Tizen 4.0)
I attached a generated .eo.legacy.h file of the Textblock.
Jul 8 2018
Jun 22 2018
Thank you for quick review! :)
I feel EFL became really hard to maintain recently.
After applying new interfaces into legacy code and legacy API.
It is not your fault but the strategy for new interface implementation.
Anyway, thank you for review!
We are struggling to fix the issues caused by recent upstream patches..
Please, add test cases when you guys try to change existing behaviors even if you are a committer.
Jun 15 2018
I passed the patch file to @smohanty to push it directly.
So, I abandon this.
Jun 11 2018
Thank you for quick review!