Page MenuHomePhabricator

iscaro (Guilherme Iscaro)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2016, 8:00 AM (156 w, 4 d)
Availability
Available

Recent Activity

Sep 4 2017

barbieri awarded D5131: Add new Future/Promise API. a Love token.
Sep 4 2017, 9:08 AM
iscaro added a comment to T5966: eina_mempool_from invalid memory read..

Thanks for the fix (commit c9a0237770a7fb0f1d94c9f99b7cab68399a922f), however it looks like you forgot to fix the problem for the one_big backend.

Sep 4 2017, 8:00 AM · efl

Sep 1 2017

iscaro updated the diff for D5131: Add new Future/Promise API..

This update adds the efl_net and efl_io_copier migration to Eina_Promise

Sep 1 2017, 9:35 AM

Aug 31 2017

iscaro created T5966: eina_mempool_from invalid memory read..
Aug 31 2017, 9:36 AM · efl
iscaro added inline comments to D4718: Remove some unnecessary Edje dependencies..
Aug 31 2017, 6:36 AM · efl

Aug 30 2017

iscaro added a comment to T5583: [Experiment] Function pointers in EO.
In T5583#96929, @q66 wrote:
Aug 30 2017, 2:15 PM · efl
iscaro added inline comments to D4718: Remove some unnecessary Edje dependencies..
Aug 30 2017, 1:52 PM · efl

Aug 29 2017

iscaro added a comment to T5583: [Experiment] Function pointers in EO.

I'm using this new feature in a new code, however there's a feature missing. I would like to declare a function as @extern (since the function is already defined in a header file elsewhere).

Aug 29 2017, 7:12 AM · efl

Aug 25 2017

iscaro added inline comments to D5131: Add new Future/Promise API..
Aug 25 2017, 7:46 PM
iscaro added reviewers for D5131: Add new Future/Promise API.: barbieri, cedric, felipealmeida.
Aug 25 2017, 4:46 PM
iscaro added a comment to D5131: Add new Future/Promise API..

This branch can also be found at dev/iscaro/future

Aug 25 2017, 4:43 PM
iscaro created D5131: Add new Future/Promise API..
Aug 25 2017, 4:42 PM

Aug 3 2017

iscaro added a comment to T5119: efl-net valgrind errors.

This should be fixed by c61ac48f1a3647a3010392d44781388fcae6a2a2. However the same problem may occur if promises/futures are not reworked.

Aug 3 2017, 11:58 AM · efl

Aug 2 2017

iscaro added reviewers for D5064: Fixes for T5234.: barbieri, cedric.

This fix is available at my branch: devs/iscaro/copier_file

Aug 2 2017, 1:32 PM
iscaro created D5064: Fixes for T5234..
Aug 2 2017, 1:29 PM

Jul 28 2017

iscaro closed T5180: efl-net error as Resolved by committing rEFL493f75587d3f: Ecore_Conn: Set EOS only if the connection is not closed.#algo..
Jul 28 2017, 11:51 AM · efl

Jul 27 2017

iscaro added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.
Jul 27 2017, 9:11 AM · efl
iscaro added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

The patch looks good to me. Gustavo also mentioned the tcp, udp, ssl, unix, etc legacy behaviour. Are these all fine and do not need further tweaking? Just this patch plus CLOEXEC as default later on?

Jul 27 2017, 7:47 AM · efl

Jul 26 2017

iscaro added a comment to T5722: ecore_ipc_server_add can't create CLOEXEC sockets, E leaks the sockets to all child processes.

Hello everyone. I created a patch fixing the problem. Please, send me some thoughts.
I also plan to set CLOEXEC to true by default, but I'll do that in another patch.

Jul 26 2017, 9:56 AM · efl

Jun 8 2017

iscaro added inline comments to D4718: Remove some unnecessary Edje dependencies..
Jun 8 2017, 8:12 AM · efl

Apr 17 2017

iscaro added a comment to D4718: Remove some unnecessary Edje dependencies..

Hey @cedric , can we merge this one now?

Apr 17 2017, 6:39 AM · efl

Mar 23 2017

iscaro accepted D4738: evas_events: look for seats on hash instead of input devices.

+1 Looks good.

Mar 23 2017, 3:55 PM

Mar 15 2017

iscaro added a comment to D4718: Remove some unnecessary Edje dependencies..

Who should I add to the reviewers list?

Mar 15 2017, 1:42 PM · efl
iscaro added reviewers for D4718: Remove some unnecessary Edje dependencies.: bdilly, barbieri, raster.
Mar 15 2017, 1:40 PM · efl
iscaro added a comment to D4718: Remove some unnecessary Edje dependencies..

Forgot to mention. I push this series to devs/iscaro/edje-deps

Mar 15 2017, 1:37 PM · efl
iscaro created D4718: Remove some unnecessary Edje dependencies..
Mar 15 2017, 1:36 PM · efl

Mar 2 2017

iscaro added a comment to D4696: Efl.Canvas.Object: Multi-seat API should not be exposed to legacy..

Please, take a look when possible.
I also pushed this branch to devs/iscaro/legacy_api.

Mar 2 2017, 8:46 AM
iscaro added reviewers for D4696: Efl.Canvas.Object: Multi-seat API should not be exposed to legacy.: jpeg, cedric, barbieri, bdilly, stefan_schmidt.
Mar 2 2017, 8:45 AM
iscaro created D4696: Efl.Canvas.Object: Multi-seat API should not be exposed to legacy..
Mar 2 2017, 8:42 AM

Jan 3 2017

iscaro closed D4547: Evas Canvas: Remove focused_objects property. by committing rEFL194d6b2f9bd3: Evas Canvas: Remove focused_objects property. (authored by iscaro).
Jan 3 2017, 10:33 PM
iscaro added a comment to D4494: Eina.Hash.Tuple: register data type to be recognizable in Eo.

Hi @jpeg and @conr2d,

Jan 3 2017, 11:27 AM
iscaro added reviewers for D4547: Evas Canvas: Remove focused_objects property.: jpeg, bdilly, barbieri, conr2d.
Jan 3 2017, 11:27 AM
iscaro retitled D4547: Evas Canvas: Remove focused_objects property. from to Evas Canvas: Remove focused_objects property..
Jan 3 2017, 11:26 AM

Dec 21 2016

iscaro accepted D4499: edje: support filtering allowed seats per part.

lgtm

Dec 21 2016, 1:55 PM
iscaro added a comment to D4494: Eina.Hash.Tuple: register data type to be recognizable in Eo.

If the API is not required, then please remove it :)

Dec 21 2016, 5:04 AM

Dec 19 2016

iscaro added inline comments to D4499: edje: support filtering allowed seats per part.
Dec 19 2016, 12:55 PM
iscaro updated the diff for D4450: Ecore Evas - New APIs for pointer devices..

Changes since last version:

Dec 19 2016, 11:35 AM · Restricted Project, efl
iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..

@zmike thanks for the review. I'll send a new version ASAP.

Dec 19 2016, 10:47 AM · Restricted Project, efl
iscaro accepted D4498: evas: a couple fixes regarding events filter.

lgtm

Dec 19 2016, 9:01 AM · efl
iscaro added a comment to D4494: Eina.Hash.Tuple: register data type to be recognizable in Eo.
In D4494#75652, @jpeg wrote:

I don't like this at all for a few reasons:

  1. Evas.Canvas is not part of the public EO API (Efl.Ui.WIn is the only canvas)
Dec 19 2016, 5:04 AM

Dec 15 2016

iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..
In D4450#75533, @zmike wrote:

Please tag patch submissions with accurate project names and CC me on all Wayland-related patches in the future.

Dec 15 2016, 10:07 AM · Restricted Project, efl
iscaro updated the diff for D4450: Ecore Evas - New APIs for pointer devices..

Changes since last version:

  • Removed ecore_evas_cursor_device_unset().
Dec 15 2016, 10:01 AM · Restricted Project, efl

Dec 14 2016

iscaro accepted D4451: edje: add getter for devices by name.

This new version looks good!

Dec 14 2016, 12:49 PM
iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..
In D4450#75373, @jpeg wrote:

Oh btw do we also need the function ecore_evas_cursor_device_unset? Isn't it like _get() and _set(NULL)?
Otherwise it looks good to me, overall.

Dec 14 2016, 12:36 PM · Restricted Project, efl

Dec 13 2016

iscaro added a comment to D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get().
In D4474#75375, @jpeg wrote:
In D4474#75369, @cedric wrote:

Please proceed with landing.

Cabin crew, doors to manual and cross check.

Dec 13 2016, 5:36 AM

Dec 12 2016

iscaro updated the diff for D4450: Ecore Evas - New APIs for pointer devices..

Changes since last version:

  • This series address the changes requested by @jpeg.
Dec 12 2016, 9:28 AM · Restricted Project, efl
iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..

@jpeg Thanks for the review. I will update this series ASAP.

Dec 12 2016, 8:21 AM · Restricted Project, efl
iscaro added a comment to D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get().
In D4474#75260, @jpeg wrote:

Looks good

Dec 12 2016, 5:07 AM

Dec 9 2016

iscaro added reviewers for D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get(): bdilly, raster, cedric.

@raster, I changed the storage from hash to eina_inlist. At least under elementary_test massif don't even bother reporting the memory usage any more. I've uploaded the screenshots so you can check it. Please, let me know if this patch also reduces the memory usage for the case that you reported. Thanks.

Dec 9 2016, 9:58 AM
iscaro retitled D4474: Evas: Reduce memory usage at _evas_object_pointer_data_get() from to Evas: Reduce memory usage at _evas_object_pointer_data_get().
Dec 9 2016, 9:54 AM
iscaro added a comment to D4451: edje: add getter for devices by name.

lgtm

Dec 9 2016, 9:17 AM
iscaro updated the diff for D4468: Evas: Add API to block input events in Efl.Canvas.Object..

Changes since last version:

  • The if statement now have parenthesis as jpeg requests.
  • Efl.Input.Interface.seat_filter property now uses a global value {}

statement.

Dec 9 2016, 5:50 AM
iscaro added a comment to D4468: Evas: Add API to block input events in Efl.Canvas.Object..
In D4468#75127, @jpeg wrote:

When the whitelist is cleared all seats can send events to the object. Is this wanted behaviour?
Otherwise cool feature!

Dec 9 2016, 5:48 AM

Dec 7 2016

iscaro added reviewers for D4468: Evas: Add API to block input events in Efl.Canvas.Object.: bdilly, cedric, jpeg.

This series will help @bdilly to implement event filters in EDC files.

Dec 7 2016, 10:46 AM
iscaro retitled D4468: Evas: Add API to block input events in Efl.Canvas.Object. from to Evas: Add API to block input events in Efl.Canvas.Object..
Dec 7 2016, 10:44 AM

Dec 6 2016

iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..

Thank you for your review @jpeg. I will send the changes that you requested after more people make comments.

Dec 6 2016, 5:18 AM · Restricted Project, efl

Dec 5 2016

iscaro added reviewers for D4459: Ecore Evas VNC: Properly shutdown server during cleanup.: bdilly, cedric.
Dec 5 2016, 12:28 PM
iscaro retitled D4459: Ecore Evas VNC: Properly shutdown server during cleanup. from to Ecore Evas VNC: Properly shutdown server during cleanup..
Dec 5 2016, 12:25 PM
iscaro added inline comments to D4451: edje: add getter for devices by name.
Dec 5 2016, 12:19 PM
iscaro added a comment to D4450: Ecore Evas - New APIs for pointer devices..

Could you guys please take a look ?

Dec 5 2016, 11:03 AM · Restricted Project, efl

Dec 2 2016

iscaro added reviewers for D4450: Ecore Evas - New APIs for pointer devices.: bdilly, barbieri, cedric.

Could you guys please take a look ?

Dec 2 2016, 12:34 PM · Restricted Project, efl
iscaro retitled D4450: Ecore Evas - New APIs for pointer devices. from to Ecore Evas - New APIs for pointer devices..
Dec 2 2016, 12:34 PM · Restricted Project, efl
iscaro updated the diff for D4445: Efl.Input.Devices ref/unref fixes..

Changes since last version:

  • Add efl_replace() function.
Dec 2 2016, 5:50 AM
iscaro updated the diff for D4415: Evas: Add support for per seat locks and modifiers..

Changes since last version:

  • Adding a new commit (5ded9223315f067) which fixes the problem

pointed by @bdilly

Dec 2 2016, 4:38 AM

Dec 1 2016

iscaro added inline comments to D4445: Efl.Input.Devices ref/unref fixes..
Dec 1 2016, 11:41 AM
iscaro added reviewers for D4445: Efl.Input.Devices ref/unref fixes.: bdilly, barbieri, cedric.
Dec 1 2016, 10:49 AM
iscaro retitled D4445: Efl.Input.Devices ref/unref fixes. from to Efl.Input.Devices ref/unref fixes..
Dec 1 2016, 10:48 AM

Nov 30 2016

iscaro closed D4434: Ecore Evas VNC: Increase keytable size. by committing rEFL619540fcc0bd: Ecore Evas VNC: Increase keytable size. (authored by iscaro).
Nov 30 2016, 6:43 PM
iscaro updated the diff for D4415: Evas: Add support for per seat locks and modifiers..

Changes since last version.

  • This fixes the problem pointer by @bdilly. The main reason for the bug,

was that some mouse move events were being generated with the incorrect
mouse device.

Nov 30 2016, 2:05 PM

Nov 29 2016

iscaro added a comment to D4415: Evas: Add support for per seat locks and modifiers..
In D4415#74503, @bdilly wrote:

Not sure if related to the inline comment, but the pointer in / out logic seems buggy at the moment.
I've done a few tests here with two seats with mouses going over a few different evas objects and changing focus between them on click.
At some points when clicking on other object with a seat generates a pointer,out for the other seat.
I'll try to post a comprehensible log later.

Nov 29 2016, 4:30 AM

Nov 28 2016

iscaro added reviewers for D4434: Ecore Evas VNC: Increase keytable size.: cedric, barbieri, bdilly.

Could you guys please take a look?

Nov 28 2016, 11:41 AM
iscaro retitled D4434: Ecore Evas VNC: Increase keytable size. from to Ecore Evas VNC: Increase keytable size..
Nov 28 2016, 11:40 AM
iscaro updated the diff for D4415: Evas: Add support for per seat locks and modifiers..

Rebasing with master.

Nov 28 2016, 11:33 AM
iscaro added a comment to D4415: Evas: Add support for per seat locks and modifiers..
In D4415#74460, @cedric wrote:

This look quite straight forward to me. I will let @bdilly tests and push whenever you guys fill ready.

Nov 28 2016, 11:29 AM

Nov 25 2016

iscaro updated the diff for D4406: Add new multi-seat events..

Rebasing with new master.

Nov 25 2016, 6:12 AM

Nov 24 2016

iscaro accepted D4428: ecore_wl2: avoid adding repeated devices.

lgtm

Nov 24 2016, 12:37 PM

Nov 18 2016

iscaro added reviewers for D4415: Evas: Add support for per seat locks and modifiers.: cedric, jpeg, barbieri, bdilly.

Hello, could you guys please take a look when possible?

Nov 18 2016, 12:32 PM
iscaro retitled D4415: Evas: Add support for per seat locks and modifiers. from to Evas: Add support for per seat locks and modifiers..
Nov 18 2016, 12:30 PM
iscaro updated the diff for D4406: Add new multi-seat events..

Changes since last version:

Nov 18 2016, 12:14 PM
iscaro added a comment to D4412: Evas: Use events to set canvas focus in/out..
In D4412#74041, @jpeg wrote:

Yes this is exactly what I meant :) What do you think about it?
This could help unify all focus events, provide more information as we need, like object, seat, timestamp, ...

Now I'm rejecting because I believe this will break legacy API :) I believe evas_callbacks.c needs to be adapted and evas_events_legacy.c as well to translate between this new EO object and a simple NULL or the Evas_Object only. Easy to do from here.

Nov 18 2016, 9:52 AM
iscaro added inline comments to D4412: Evas: Use events to set canvas focus in/out..
Nov 18 2016, 9:25 AM
iscaro added a comment to D4412: Evas: Use events to set canvas focus in/out..

@jpeg I updated this pull request. Now all focus event use the same info and I took care to do not break the legacy API.

Nov 18 2016, 9:23 AM
iscaro updated the diff for D4412: Evas: Use events to set canvas focus in/out..

Completing the feature.
Changes since V1:

  • Unified all events info types.
  • Removed focus,in/out and focus,device,in/out from Efl.Canvas.Object.
Nov 18 2016, 9:22 AM

Nov 17 2016

iscaro added reviewers for D4412: Evas: Use events to set canvas focus in/out.: bdilly, barbieri, jpeg, cedric.

@jpeg Is this what you had in mind?

Nov 17 2016, 12:31 PM
iscaro retitled D4412: Evas: Use events to set canvas focus in/out. from to Evas: Use events to set canvas focus in/out..
Nov 17 2016, 12:29 PM
iscaro added a comment to D4406: Add new multi-seat events..

Hey @jpeg, thanks for your comments. I will address them and send a new version ASAP.

Nov 17 2016, 6:05 AM

Nov 16 2016

iscaro added inline comments to D4406: Add new multi-seat events..
Nov 16 2016, 1:51 PM
iscaro accepted D4407: ecore_wl2: ref / unref evas devices on ecore events.
Nov 16 2016, 10:58 AM
iscaro added a comment to D4407: ecore_wl2: ref / unref evas devices on ecore events.

This looks good. However I think you can make things even simpler. Instead of having a lot of free functions that depends on the event type you could simple do something like:

Nov 16 2016, 10:26 AM
iscaro added reviewers for D4408: Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT.: bdilly, barbieri, jpeg, cedric.
Nov 16 2016, 10:18 AM
iscaro added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..

Please check https://phab.enlightenment.org/D4408

Nov 16 2016, 10:18 AM
iscaro retitled D4408: Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT. from to Ecore Wayland: Remove ECORE_WL2_SEAT_CAPABILITIES_NO_SEAT..
Nov 16 2016, 10:18 AM
iscaro added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..
In D4390#73890, @bdilly wrote:
In D4390#73706, @jpeg wrote:

Do we really need the distinction between NO_SEAT and NONE for capabilities? It looks confusing to me as cap != 0 does not mean the device is useful. If the device has only NONE capabilities, it's pretty damn useless (even if it's a 'valid' device). I would say merge NO_SEAT and NONE and the patch is good to go.

This fixes the issue indeed.

Actually I can see a difference between NO_SEAT and NONE.
NONE always happens in a seat lifetime, btw. At first a seat is announced by wayland. Then you register callbacks for capabilities changes. And when the capabilities changes is called you'll have more capabilities (pointer / keyboard / touch). So in the meantime, during this interval, you'll have a seat with no capabilities. If a ecore_evas is created at that moment, a new seat evas device should be added, but not keyboard or mouse.

On the other hand, if it's capabilities is set to NO_SEAT, not even a seat evas device should be created.
But is it possible to have such scenario? An input without seat? If it is, we should have both NO_SEAT and NONE.
If not, just drop NO_SEAT.

Nov 16 2016, 10:15 AM
iscaro added reviewers for D4406: Add new multi-seat events.: bdilly, barbieri, cedric.
Nov 16 2016, 8:55 AM
iscaro retitled D4406: Add new multi-seat events. from to Add new multi-seat events..
Nov 16 2016, 8:55 AM
iscaro closed D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup. by committing rEFL9ba11c5cd020: Ecore Evas Wayland: Create the devices during Ecore_Evas setup. (authored by iscaro).
Nov 16 2016, 2:55 AM

Nov 14 2016

iscaro added a comment to D4396: Evas focus: Do not allow two objects focused by the same seat..

I'm sorry for any trouble that this bug may have caused to you guys.

Nov 14 2016, 11:58 AM
iscaro added a comment to D4390: Ecore Evas Wayland: Create the devices during Ecore_Evas setup..
In D4390#73706, @jpeg wrote:

Do we really need the distinction between NO_SEAT and NONE for capabilities? It looks confusing to me as cap != 0 does not mean the device is useful. If the device has only NONE capabilities, it's pretty damn useless (even if it's a 'valid' device). I would say merge NO_SEAT and NONE and the patch is good to go.

This fixes the issue indeed.

Nov 14 2016, 9:56 AM
iscaro added reviewers for D4396: Evas focus: Do not allow two objects focused by the same seat.: cedric, netstar, bdilly, barbieri, ProhtMeyhet.

This should fix T4864 and T4886

Nov 14 2016, 8:15 AM
iscaro added a revision to T4864: EFL: Evas Event Crash (X11): D4396: Evas focus: Do not allow two objects focused by the same seat..
Nov 14 2016, 8:15 AM · efl