Page MenuHomePhabricator

jayji (Jean Guyomarc'h)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 14 2013, 1:42 AM (292 w, 4 d)
Availability
Available

Recent Activity

Jan 6 2019

jayji created T7549: Error messages when terminology starts.
Jan 6 2019, 4:59 AM · Terminology

Jan 5 2019

jayji created T7548: Initial state of the terminal is invalid.
Jan 5 2019, 8:29 AM · Terminology

Jan 3 2019

jayji added a comment to T7543: Terminology receives a SIGSEGV when resized down and neovim running .

I can confirm it changes nothing ;)

Jan 3 2019, 1:51 PM · Terminology
jayji added a comment to T7543: Terminology receives a SIGSEGV when resized down and neovim running .

yes. I made sure with -u NONE that it was not a fancy plugin that caused the problem. I'm using NVIM v0.3.1 by the way

Jan 3 2019, 1:47 PM · Terminology
jayji added a comment to T7543: Terminology receives a SIGSEGV when resized down and neovim running .

Here is valgrind's log:

.
Funny, I cannot reproduce with nano/vim. But systematically with neovim (nvim -u NONE).

Jan 3 2019, 12:57 PM · Terminology
jayji created T7543: Terminology receives a SIGSEGV when resized down and neovim running .
Jan 3 2019, 12:27 PM · Terminology

Aug 22 2018

jayji accepted D6865: ecore_cocoa: move MARKUP outside of ecore_cocoa.

Okay, looks good to me.

Aug 22 2018, 11:20 AM · efl
jayji added a reviewer for D6894: ecore: fix built-in event types generation: zmike.
Aug 22 2018, 11:18 AM · efl
jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

Mhh.. it works for me. I've made a patch. Hopefully it will solve the problem.

Aug 22 2018, 11:18 AM · efl (efl-1.21), efl: system integration
jayji requested review of D6894: ecore: fix built-in event types generation.
Aug 22 2018, 11:17 AM · efl
jayji added a revision to T6605: Ecore_Exe seems to send spurious events: D6894: ecore: fix built-in event types generation.
Aug 22 2018, 11:17 AM · efl (efl-1.21), efl: system integration
jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

Mhh,.. I'm actually not quite sure why just changing the initialization value in the constructor from -1 to 0 is not the way to go.

Aug 22 2018, 10:27 AM · efl (efl-1.21), efl: system integration
jayji requested changes to D6865: ecore_cocoa: move MARKUP outside of ecore_cocoa.
Aug 22 2018, 10:12 AM · efl

Aug 21 2018

jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

Oh wait... ecore code seems wrong

Aug 21 2018, 1:43 PM · efl (efl-1.21), efl: system integration
jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

Well, it seems that

Aug 21 2018, 1:24 PM · efl (efl-1.21), efl: system integration

Aug 18 2018

jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

It crashed again this night... but there is too much eo stuff... What I can see is that the data field of Efl_Loop_Message is NULL (that's the final NULL ptr)

Aug 18 2018, 4:12 AM · efl (efl-1.21), efl: system integration

Aug 17 2018

jayji added a comment to T6605: Ecore_Exe seems to send spurious events.

It is pretty hard to reproduce, as it usually happens over night (but not regularly). I'll investigate the next core dump.

Aug 17 2018, 12:26 PM · efl (efl-1.21), efl: system integration
jayji added a comment to T7306: cocoa build broken.

I don't know if this will help, but ecore_cocoa_clipboard_set() (that calls evas_textblock_text_markup_to_utf8) is beta API (the whole cocoa clipboard API is). It was (badly) designed to be used by Elementary only. Maybe the caller of this function can run the evas_textblock_text_markup_to_utf8() first, and pass its output as the data parameter?

Aug 17 2018, 12:21 PM · macOS, efl: meson, Restricted Project

Aug 11 2018

jayji reopened T6605: Ecore_Exe seems to send spurious events as "Open".

Actually, on EFL commit c57b3912a5f65632e17b023d9c12ae6e1fcc819a, I still have this problem.

Aug 11 2018, 2:28 AM · efl (efl-1.21), efl: system integration

Aug 5 2018

jayji added a comment to T7144: Eina_Bool type.

I'd prefer to use unsigned x : 1; instead of bool x : 1;.
I personally am not a fan of bitfields, because of their undefined and implementation-defined behaviors and the fact they are not always well-handled by compilers (e.g. Diab).

Aug 5 2018, 12:05 PM · efl: data types, Restricted Project

Aug 3 2018

jayji created T7250: Safety checks triggered when the app closes.
Aug 3 2018, 12:23 PM · efl (efl-1.22), efl: widgets
jayji closed T6605: Ecore_Exe seems to send spurious events as Resolved.

This seems to have been fixed :)

Aug 3 2018, 12:16 PM · efl (efl-1.21), efl: system integration
jayji added a comment to T7144: Eina_Bool type.

+1 on this one!
Btw, I don't understand one would like to write a bool bitfield instead of using a proper integer type .

Aug 3 2018, 11:55 AM · efl: data types, Restricted Project

Apr 6 2018

jayji added a comment to T6768: Project Roadmap.

Maybe most people want a roadmap, but they don't feel the need to participate to it?
or they might propose changes to it later?

Apr 6 2018, 11:52 PM · efl

Mar 26 2018

jayji edited the content of Filenotify.
Mar 26 2018, 12:27 PM

Mar 25 2018

jayji created Filenotify.
Mar 25 2018, 1:31 AM
jayji edited the content of Eovim.
Mar 25 2018, 1:05 AM

Mar 7 2018

jayji added a comment to D5738: eina: remove usless newline.

Hi, not on this differential. I think you can safely close this one.

Mar 7 2018, 9:29 AM

Feb 26 2018

jayji edited the content of Eovim Design Document.
Feb 26 2018, 2:51 AM

Jan 23 2018

jayji added a comment to D5738: eina: remove usless newline.

This is interesting. On my machine, results are always better, but I see you have a wider range of materials to test on :D
Also, sorry for taking to long to reply, but since I do not work professionally on the EFL, the time I can allocate to that sometimes changes without warning :/

Jan 23 2018, 9:28 AM

Jan 15 2018

jayji added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.
  • I didn't thought about vectorization taking more CPU. I'll have a look. But I've seen less time spent by frame.
  • My _ are just visual separators, they have no meaning to the measure. You can see it as a non-secable whitespace
Jan 15 2018, 11:20 AM · Restricted Project, Restricted Project, efl: data types
jayji updated the summary of D5738: eina: remove usless newline.
Jan 15 2018, 11:05 AM
jayji requested review of D5738: eina: remove usless newline.

This is a first commit round addressing T6580. Please let me know what you think about it.
To measure the performance impact, I've used the following script: python3 ./run_bench.py. It spawns elementary_test with autobounce, and collects the results. It produces a final data.csv that aggregates the results. A mean is displayed on stdout at the end of the runs.

Jan 15 2018, 11:04 AM
jayji added a revision to T6580: EFL perceived responsiveness is not as good as it used to be: D5738: eina: remove usless newline.
Jan 15 2018, 10:59 AM · Restricted Project, Restricted Project, efl: data types

Jan 13 2018

jayji added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

I've made some progress on the _eo_obj_pointer_get. I'm not really sure why there was two tables to reach the final pointer, but I now use only one table. So I end up with one less indirection. I managed to grab some more precious frames by using aggressive inlining of code per domain and a jump table with pointer to labels (I've always wanted to use that!!). And finally, I used the AVX2 vectorization to retrieve in one go the information from the Eo_Id.

Jan 13 2018, 2:09 PM · Restricted Project, Restricted Project, efl: data types

Jan 10 2018

jayji updated the task description for T6605: Ecore_Exe seems to send spurious events.
Jan 10 2018, 11:42 PM · efl (efl-1.21), efl: system integration
jayji created T6605: Ecore_Exe seems to send spurious events.
Jan 10 2018, 11:41 PM · efl (efl-1.21), efl: system integration

Jan 8 2018

jayji added a comment to T6580: EFL perceived responsiveness is not as good as it used to be.

the ptr indirection is hugely helpful in stability. i don't think we should drop it at all. we should get it to be faster though.

Jan 8 2018, 1:48 AM · Restricted Project, Restricted Project, efl: data types

Jan 7 2018

jayji edited the content of Eovim.
Jan 7 2018, 2:44 AM

Jan 6 2018

jayji created T6580: EFL perceived responsiveness is not as good as it used to be.
Jan 6 2018, 9:35 AM · Restricted Project, Restricted Project, efl: data types

Jan 4 2018

jayji edited the content of Eovim Design Document.
Jan 4 2018, 1:25 AM

Jan 3 2018

jayji edited the content of Eovim Design Document.
Jan 3 2018, 6:01 AM

Jan 1 2018

jayji edited the content of Eovim.
Jan 1 2018, 1:52 PM
jayji edited the content of Eovim.
Jan 1 2018, 1:52 PM
jayji edited the content of Eovim.
Jan 1 2018, 1:51 PM
jayji created Eovim Design Document.
Jan 1 2018, 1:49 PM

Dec 31 2017

jayji edited the content of Eovim.
Dec 31 2017, 3:19 AM
jayji edited the content of Eovim.
Dec 31 2017, 3:02 AM
jayji edited the content of Eovim.
Dec 31 2017, 2:59 AM

Dec 30 2017

jayji edited the content of Eovim.
Dec 30 2017, 8:22 AM

Dec 29 2017

jayji created T6570: Valgrind absolutely hates the shaders.
Dec 29 2017, 1:32 PM · efl
jayji created T6569: Memory corruption, leading to segfault.
Dec 29 2017, 1:27 PM · Terminology
jayji added a comment to T6448: Mac OS EFL Build Fail.

@netstar this time it is not thanks to me, someone made a fancy patch that happened to fix the build :)

Dec 29 2017, 7:58 AM · efl, macOS

Dec 28 2017

jayji closed T6448: Mac OS EFL Build Fail as Resolved.

Fixed by some Christmas magic :)

Dec 28 2017, 10:49 AM · efl, macOS

Dec 27 2017

jayji edited the content of Eovim.
Dec 27 2017, 2:01 PM

Dec 20 2017

jayji added a comment to T6448: Mac OS EFL Build Fail.

Yes, when I wrote EAPI, it is because EWAPI expands to EAPI and something else I don't remember.

Dec 20 2017, 1:48 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

If EAPI is not defined when those symbols are encountered, we are doomed.
In elc_ctxpopup.c for example (which includes elm_ctxpopup.eo.h, and therefore has the first DECLARATION of _ELM_CTXPOPUP_EVENT_DISMISSED) we already are outside of Elementary.h, so that's dead.

Dec 20 2017, 12:59 AM · efl, macOS

Dec 19 2017

jayji reopened T6448: Mac OS EFL Build Fail as "Open".

@raster sorry for breaking efl first, but 036cf62cc7bb1c5cb743f6d28f4b6c5fc024a414 broke the build on macOS.

Dec 19 2017, 9:16 AM · efl, macOS
jayji placed T4444: OSX - Bad handling of window resizing up for grabs.
Dec 19 2017, 7:03 AM · efl: display system, macOS
jayji closed T6448: Mac OS EFL Build Fail as Resolved by committing rEFLa1e05aa0890f: evas/elm: fix visibility of some symbols.
Dec 19 2017, 6:15 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

And now:

Dec 19 2017, 5:29 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

And there are cyclic includes as well:

Dec 19 2017, 5:13 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

What was done in evas_font.h in D5419: Remove evas internal dependency from the evas_font module seems pretty weird to me. Why do we re-define EAPI there?

Dec 19 2017, 4:47 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

I have this:

Dec 19 2017, 4:39 AM · efl, macOS
jayji added a comment to T6448: Mac OS EFL Build Fail.

I'll have a look at this, haven't built efl on mac for a while.
It would be much nicer if we had a meson build to speed up build time :/

Dec 19 2017, 3:48 AM · efl, macOS

Dec 1 2017

jayji edited the content of Eovim.
Dec 1 2017, 12:38 PM

Nov 22 2017

jayji edited the content of Eovim.
Nov 22 2017, 12:48 PM

Nov 19 2017

jayji created T6388: No permalinks links to the documentation .
Nov 19 2017, 4:41 AM · efl
jayji created T6387: Missing doc for Ecore_Timer.
Nov 19 2017, 4:38 AM · efl

Oct 28 2017

jayji added a comment to T6262: Refactor EFL_MAIN* and efl_exit* from elm into efl.

Okay, now I better understand where you were going. How about the rationale: if you use a module, it is that you will use it (#include in C, import in python, something else in some other language). So if you do the following in C:

Oct 28 2017, 7:17 AM · Restricted Project, efl
jayji added a comment to T6228: Add ability to set a return code from efl_exit().

I can roll with that. A helper to sort out just the exit code would be nice.

Oct 28 2017, 6:55 AM · Restricted Project, efl

Oct 27 2017

jayji added a comment to T6262: Refactor EFL_MAIN* and efl_exit* from elm into efl.

My grain of salt:

Oct 27 2017, 12:21 PM · Restricted Project, efl

Oct 26 2017

jayji added a comment to T6228: Add ability to set a return code from efl_exit().

Still seems weird to me. We (EFL) don't do anything with this value, I think this is really up to the user to pass whatever it wants. So int _seems_ more appropriate to me.
If we want to support anything, why not pass a void*? (this is a real suggesion) So one can do this (in python for instance):

Oct 26 2017, 12:37 PM · Restricted Project, efl

Oct 19 2017

jayji reopened T6228: Add ability to set a return code from efl_exit() as "Open".

While you are thinking, I re-open the issue, just so it does not get forgotten ;)

Oct 19 2017, 12:44 PM · Restricted Project, efl
jayji reopened T6228: Add ability to set a return code from efl_exit(), a subtask of T5301: Make EFL easier to use by improving its interface, as Open.
Oct 19 2017, 12:44 PM · Restricted Project, efl, Restricted Project
jayji reopened T6228: Add ability to set a return code from efl_exit(), a subtask of T6201: Complete enough of EFL interfaces for the example apps, as Open.
Oct 19 2017, 12:44 PM · efl: widgets

Oct 17 2017

jayji added a comment to T6228: Add ability to set a return code from efl_exit().

Bigger than an int, I'm not sure, since it is against the C standard. But my point here is that systems may (and do) return bigger than unsigned char.
Windows does (https://msdn.microsoft.com/en-us/library/windows/desktop/ms683189(v=vs.85).aspx).

Oct 17 2017, 12:54 PM · Restricted Project, efl
jayji added a comment to T6228: Add ability to set a return code from efl_exit().

But isn't that a bit too POSIX-specific? The C standards (§5.1.2.2.1) states it shall be an int. since int is compatible with unsigned char, why not being closer than the C standard rather than a specific implementation?

Oct 17 2017, 12:27 PM · Restricted Project, efl
jayji added a comment to T6228: Add ability to set a return code from efl_exit().

Sorry, but why is this an unsigned char instead of an int?

Oct 17 2017, 10:55 AM · Restricted Project, efl

Oct 9 2017

jayji edited the content of Eovim.
Oct 9 2017, 2:40 PM

Oct 8 2017

jayji edited the content of Eovim.
Oct 8 2017, 2:45 PM
jayji edited the content of Eovim.
Oct 8 2017, 1:46 PM
jayji edited the content of Eovim.
Oct 8 2017, 1:18 PM

Oct 2 2017

jayji created Eovim.
Oct 2 2017, 1:12 PM

Sep 23 2017

jayji edited the content of Packaging Status.
Sep 23 2017, 1:18 AM · Restricted Project, efl

Sep 18 2017

jayji created T6044: Project templating fails with special characters in projects settings.
Sep 18 2017, 10:28 PM · Restricted Project

Sep 4 2017

jayji added a comment to T5245: macOS graphical programs crash on termination.

Lol. Found (at least for the edje_cc stuff). Commit will follow... shame...

Sep 4 2017, 3:12 PM · macOS, efl
jayji added a comment to T5245: macOS graphical programs crash on termination.

and I got EINA ERROR: resource busy on mutex_destroy 0xblabhabl
Than it exits normally (seems legit, since we didn't join the right id
But I also don't have 100% clean code, since I've reworked this file a bit.

Sep 4 2017, 9:30 AM · macOS, efl
jayji added a comment to T5245: macOS graphical programs crash on termination.

seems dreadful :D I'll try this out, though.
What really bugs me with this file is have the conditions are handled

Sep 4 2017, 9:28 AM · macOS, efl

Sep 3 2017

jayji added a comment to T5245: macOS graphical programs crash on termination.

Ahah here is the explaination of why eina_thread_join() does not return :

Sep 3 2017, 2:45 PM · macOS, efl
jayji added a comment to T5245: macOS graphical programs crash on termination.

My take on the problem would "just" be memory corruption. Something that valgrind could easily spot, if it was available... But on the other hand that seems macOS 10.12 SPECIFIC. And I don't like that...
I've also noticed ununderstandable thread join behaviour (that were not present before). eina_thead_join() does not return in some cases, even though the thread did exit. Since the threads are joinable, the only reason I can think of is that there was an earlier memory corruption. Also, when lldb is fired up, eina_thread_join() always return! Yay!
I've suspected the eina_freeq for some time, but couldn't prove it's involvment. What is funny is that when graphics are involved (i.e. elementary), it's eina_module that goes rogue.

Sep 3 2017, 2:19 PM · macOS, efl
jayji added a comment to T5245: macOS graphical programs crash on termination.

Nooooooooooooooooooooooooo... it spread to edje_cc making build break on master...............
and diff between efl-1.20 and master does not show anything suspiscious...

Sep 3 2017, 10:23 AM · macOS, efl

Sep 2 2017

jayji edited the content of Packaging Status.
Sep 2 2017, 1:14 PM · Restricted Project, efl
jayji edited the content of Packaging Status.
Sep 2 2017, 1:13 PM · Restricted Project, efl

Aug 22 2017

jayji edited the content of Packaging Status.
Aug 22 2017, 1:28 PM · Restricted Project, efl

Aug 7 2017

jayji added a comment to D5023: Allow to override build date.

Hi, seems to work fine on macOS 10.12 as well:

Aug 7 2017, 2:11 PM

Jul 16 2017

jayji added a comment to T5245: macOS graphical programs crash on termination.

I'm pretty sure git bisect will be of no use. The bug has been there for a loong time. Also, since the osx build has been broken multiple times, over large commit periods, bisecting is trumendeous hard.
I've actually tried to bisect at some point, but since I'm taking about 20 minutes to build efl (even with a lot of things disabled), I found this unfeasible.

Jul 16 2017, 8:55 AM · macOS, efl
jayji added a comment to T5245: macOS graphical programs crash on termination.

@stefan_schmidt unfortunately valgrind seems to still not have decent macOS 10.12 support, making the thing still hard to pinpoint.
I don't know if the kludge is worth it, as I've experienced the crash in some situations even with the kludge on.
I'll spend some time today on this... hoping for the best...

Jul 16 2017, 8:02 AM · macOS, efl

Mar 24 2017

jayji added a comment to T5245: macOS graphical programs crash on termination.

@stefan_schmidt Here is the evil: https://git.enlightenment.org/core/efl.git/commit/?h=devs/jayji/kludge
Feel free to push it/rewrite the description if necessary.

Mar 24 2017, 12:03 AM · macOS, efl

Mar 23 2017

jayji added a comment to T5245: macOS graphical programs crash on termination.

We still have this as a release blocker here. Any chance we can narrow this down a bit?

Mar 23 2017, 1:25 PM · macOS, efl