Page MenuHomePhabricator

jpeg (Jean-Philippe André)Administrator
yet another French

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 29 2013, 7:50 PM (293 w, 4 d)
Roles
Administrator
Availability
Available

Silly French living in Korea, former VLC contributor.

Regarding EFL, I worked mostly on the following components, all in Evas:

  • Evas GL (direct rendering, GLESv1, etc...)
  • ETC1, ETC2, S3TC texture compression
  • Text/Image filters
  • Masking

I also contributed a lot to the EFL Interfaces aka. Unified API, on the path to EFL2.

Recent Activity

Sat, Dec 1

jpeg added a comment to D7367: ui/flip: fix efl_pack usage.

So objects are removed from the list now before adding them again? To avoid duplicates?

Sat, Dec 1, 2:01 AM · efl

Tue, Nov 27

jpeg added reviewers for D7369: tests: Rework "gfx filters" test case to use eo: cedric, segfaultxavi, Jaehyun.
Tue, Nov 27, 2:11 AM · efl
jpeg requested review of D7369: tests: Rework "gfx filters" test case to use eo.
Tue, Nov 27, 2:10 AM · efl
jpeg added reviewers for D7368: textblock: Fix crash with filters: cedric, segfaultxavi, Jaehyun.
Tue, Nov 27, 2:10 AM · efl
jpeg requested review of D7368: textblock: Fix crash with filters.
Tue, Nov 27, 2:10 AM · efl
jpeg added reviewers for D7367: ui/flip: fix efl_pack usage: cedric, Jaehyun, segfaultxavi.
Tue, Nov 27, 2:09 AM · efl
jpeg requested review of D7367: ui/flip: fix efl_pack usage.
Tue, Nov 27, 2:09 AM · efl
jpeg added reviewers for D7366: ui/text: Postpone scrollable property in efl_add: cedric, Jaehyun, segfaultxavi.
Tue, Nov 27, 2:08 AM · efl
jpeg requested review of D7366: ui/text: Postpone scrollable property in efl_add.
Tue, Nov 27, 2:07 AM · efl
jpeg added a comment to T5317: Add a tab/pageview widget.

The test case is cool and works fine at first but exhibits many bugs and tons of ERR messages along the way (eg. unpack_all does not delete the current page, etc...)

Tue, Nov 27, 1:59 AM · efl: widgets, Restricted Project
jpeg added a comment to T5318: Improve flip.

Efl.Ui.Flip "pack" API is completely broken. I think one of the two APIs should be used: front/back or pack but probably not both.

Tue, Nov 27, 1:55 AM · efl: widgets, Restricted Project
jpeg abandoned D3924: [evas] Implement rotation, flip, roi for tbm native surface type.

This is more than 2 years old, with zero follow-up.

Tue, Nov 27, 1:54 AM · efl
jpeg commandeered D3924: [evas] Implement rotation, flip, roi for tbm native surface type.

I will drop this.

Tue, Nov 27, 1:53 AM · efl

Mon, Nov 26

Herald updated subscribers of D6098: efl: major rewrite of efl_part..
Mon, Nov 26, 1:24 AM · efl
jpeg awarded D6098: efl: major rewrite of efl_part. a Like token.
Mon, Nov 26, 1:24 AM · efl

Feb 7 2018

jpeg added a comment to T5351: New Naviframe API.

Three components:

  • FrameStack, Frame, NavigationBar.
  • Client-side implementation since Tizen E won't support it well.
  • Use events to propagate things like "back button pressed" in this way: button -> bar -> frame -> stack. App should be able to listen to this publicly defined event (eg. "pop,requested").
  • Add "autopop" property, true by default, for each frame, so app can block frame pop on back button click (eg. in order to show a popup "do you want to save?").
Feb 7 2018, 10:20 PM · efl (efl-1.21), efl: widgets, Restricted Project
jpeg added a comment to T5301: Make EFL easier to use by improving its interface.

Quick recap before I leave.

Feb 7 2018, 10:15 PM · Restricted Project, efl, Restricted Project
jpeg accepted D5797: efl_part: use efl_ui_widget's default_part_get.
Feb 7 2018, 10:01 PM
jpeg added a comment to T5319: Refactor scrollable mixin.

Yes those APIs are necessary, but they are still "not clean" in Efl.Ui.Widget, see T5363. They must be well documented, and it must be clear whether they should be in Widget or only in the Scrollable interface.

Feb 7 2018, 6:49 PM · efl: widgets, Restricted Project
jpeg added a comment to D5782: elementary: fix legacy widget type name for backward compat.
In D5782#99070, @raster wrote:

almost done... just "which efl version is this for" is missing (see above review requests) :)

Feb 7 2018, 6:44 PM
jpeg added a comment to D5795: ector: Updated the ector_buffer_pixels_set() api with stride info.

looks good. can you do these 2 tiny changes?

Feb 7 2018, 6:41 PM

Feb 6 2018

jpeg assigned T6666: Apps are not compiling against current efl using Efl_Ui.h to herdsman.

Test code, for the lazy:

#include <Efl_Ui.h>
Feb 6 2018, 4:29 AM · efl (efl-1.21), efl: widgets
jpeg requested changes to D5782: elementary: fix legacy widget type name for backward compat.

I'm surprise it even works for you...
Other than the string compare, good job! This is a HUGE patch, so... good job :)

Feb 6 2018, 1:01 AM
jpeg accepted D5790: ecore/evas: add NULL checks to handle argument is NULL..

Looks fine but this should have been two patches, ideally :)

Feb 6 2018, 12:59 AM

Feb 1 2018

jpeg updated subscribers of D5782: elementary: fix legacy widget type name for backward compat.

@jpeg

Hmm. I don't get it. What's going on there? MY_CLASS_NAME_LEGACY is correctly defined as "elm_button" (and not "Elm_Button" anyway).

The "elm_button" is supa dupa legacy. It is older than "Elm_Button".
The "Elm_Button" was appeaed and it was returned from "elm_object_widget_type_get()". The "elm_button" became leagacy and it was returned from evas_object_type_get().

Now, "Efl.Ui.Button" is appeared. So, "Elm_Button" and "elm_button" have to be legacy.
If the object is added from "elm_button_add()", it has to show legacy name just like before.
Efl.Ui.Button_Legacy is totally new name. Not Legacy.

How did you get the wrong type name???

Try elm_object_widget_type_get() function. It will return object's given class name.

Feb 1 2018, 10:55 PM
jpeg requested changes to D5782: elementary: fix legacy widget type name for backward compat.

Hmm. I don't get it. What's going on there? MY_CLASS_NAME_LEGACY is correctly defined as "elm_button" (and not "Elm_Button" anyway).
How did you get the wrong type name???
This change should either be done on ALL legacy widgets or there is some logic error somewhere which needs to be fixed. One way or another, this change is dubious.

Feb 1 2018, 6:51 PM

Jan 31 2018

jpeg added inline comments to D5776: ecore_event: Check for the valid type.
Jan 31 2018, 12:17 AM

Jan 30 2018

jpeg closed T3575: perf regressions (filter related?) as Wontfix.
Jan 30 2018, 11:26 PM · efl
jpeg placed T5328: Refactor/rename container, pack, ... interface up for grabs.
Jan 30 2018, 11:22 PM · efl, Restricted Project

Jan 29 2018

jpeg added a comment to T6514: fix eolian function redefine errors.

Meh. We are down to ~10 APIs or less that clash in the Unified API. It seems easier to me to use a tiny bit of creativity here rather than add complexity to all our binding generators (or API users, in case of C++). Note that in C++ a name clash can be worked around, but a newly introduced name clash will prevent existing apps from compiling (as obj.my_func now resolves to two real functions, C++ compiler will fail to figure out which one).
I think it's more important to continue resolving the clashes, then somehow discard any error/warning for legacy-only EO files, but straight out error in case of a Unified API EO file.

Jan 29 2018, 9:47 PM · Restricted Project, efl
jpeg accepted D5766: edje_object: fix typo in EAPI edje_object_color_class_description_get.
Jan 29 2018, 9:25 PM
jpeg added a comment to D5765: PROTOTYPE: Efl.Ui.Widget: implement Efl.Gfx.Color_Class.

Oops I pressed Submit too early.
I wonder if it's a good idea to have this API unconditionally format the color class name, as it makes it behave differently between the low-level and the high-level.
Low-level: "efl/button/bg/active" (or whatever the real names are, ofc), and high-level is only "active". Passing "efl/button/bg/active" won't work... It should work.
It sounds like a problem similar to "theme" in Efl.Ui.Layout. What do you think?

Jan 29 2018, 9:21 PM · efl
jpeg updated subscribers of D5765: PROTOTYPE: Efl.Ui.Widget: implement Efl.Gfx.Color_Class.

Please discuss this with @singh.amitesh. He has pending patches for color. Also for now color_class_code resides in Color instead of Color_Class (it belongs to Color_Class, obviously).

Jan 29 2018, 9:14 PM · efl

Jan 28 2018

jpeg accepted D5741: elm_test: add elementary_test for Efl.Ui.Button.
Jan 28 2018, 8:22 PM
jpeg accepted D5742: Efl.Ui.Image: remove previous image when NULL is set.

looks ok

Jan 28 2018, 8:21 PM

Jan 25 2018

jpeg added inline comments to D5742: Efl.Ui.Image: remove previous image when NULL is set.
Jan 25 2018, 9:46 PM

Jan 24 2018

jpeg added a comment to D5762: ecore_timer: Check for the valid callback func.

I don't see any new test case for this? Looks like you should check that ecore_timer_add(NULL) returns NULL, no?

Jan 24 2018, 11:04 PM
jpeg reassigned T6641: The elm_access_object_register in Interface World from cedric to stanluk.

@stanluk is the boss for accessibility :)

Jan 24 2018, 7:09 PM · efl: widgets, Restricted Project
jpeg added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

Thanks. Stupid Window class.
Fixed in 426ccba6bdbd3bf6a83dd8778d1404e8b9c9c453

Jan 24 2018, 6:45 PM
jpeg added a comment to D5759: efl_ui_focus_layer: avoid a call to NULL.

Yeah I thought about commenting "why not else if (manager) instead?"... :)

Jan 24 2018, 6:26 PM
jpeg added a comment to D5758: elm_hover: remove focus_layer related code.

Tested, works. Lgtm but please @bu5hm4n should review this.

Jan 24 2018, 2:03 AM
jpeg accepted D5760: eolian_gen: remove reference to elm_entry because it is not installed.
Jan 24 2018, 1:57 AM
jpeg accepted D5759: efl_ui_focus_layer: avoid a call to NULL.
Jan 24 2018, 1:49 AM

Jan 23 2018

jpeg accepted D5757: efl_ui_win: Avoid a call to NULL.

lgtm

Jan 23 2018, 10:49 PM
jpeg added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

Okay then I will test this myself. Thanks!

Jan 23 2018, 10:33 PM
jpeg added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

Let me know when this is done. It mostly looks good. Though now I wonder if creating all those EO files was necessary and we couldn't have just used the EO macros to create the classes internally. No big deal, it's just more work making EO files, but it's also much cleaner.

Jan 23 2018, 10:30 PM
jpeg added a comment to T6392: Remove on_focus_update.

No. I didn't know about this ticket.
I'm not sure this can "easily" be done. @bu5m4n would know best here, of course, but I'm not convinced that on_focus_update is the same as focus_set.

Jan 23 2018, 6:36 PM · Restricted Project, Restricted Project, Restricted Project

Jan 22 2018

jpeg added a comment to D5748: efl_ui_legacy: add new interface to indicate legacy widget.

Isn't this basically ready to be merged, now?

Jan 22 2018, 9:58 PM
jpeg added a comment to T6514: fix eolian function redefine errors.

So far simple renames have been the preferred method, even if it sometimes leads to less than perfect method names.

Jan 22 2018, 9:58 PM · Restricted Project, efl
jpeg added a comment to D5749: elementary: Add missed type for legacy..

Do we need to do typedef for the following classes as well?

Elm_Bg
Elm_Image
Elm_Win
Elm_Progressbar
Elm_Multibuttonentry

Jan 22 2018, 9:48 PM
jpeg added a comment to T6627: hoversels broke after this commit.

it was just warnings anyway. but no, i didn't see more pop up after your patch

Jan 22 2018, 8:40 PM · efl
jpeg added a comment to T6514: fix eolian function redefine errors.

Good question. In the base object class we get efl_name_get() for C.
So far in case of a method name clash like this we would just "prefix" the conflicting APIs. Example here Efl.Ui.Win.win_name gives obj.win_name() in bindings, efl_ui_win_name() in C. But the window name is not very useful, while the AP (EEID maybe?) and technology names are very useful.
Not sure what to do... call them "ap_name" or "eeid" and "technology" or "technology_name"? Hmm...
While I find that __ prefix is not a bad idea, it should also apply to all other methods in Efl.Object to be consistent. eolian_gen would need to know about it (so that base functions like efl_del remain as-is, for instance).

Jan 22 2018, 4:17 AM · Restricted Project, efl
jpeg accepted D5755: elementary config: Fix to use ELEMENTARY_BASE_DIR for configure path.
Jan 22 2018, 4:01 AM
jpeg added a comment to T6617: evas is broken.

and without osmesa installed you get a NULL egl api handle... this is actually how it SHOULD work. gl is not possible. so ... what about these changes i made actually breaks anything that shouldn't be? were we returning a non-null gl api handle even if osmesa was not found... but then how could that work anyway? i am pretty certain long ago we were returning a null gl api handle when no osmesa was found and perhaps someone changed that to make it always return a handle anyway?

Between fb048e73120b3909 and 24447641d38cb9bf7b evas_gl_new() returned non-NULL even if OSMesa is not present. All actual function calls would fail (context create, etc). Before and after those patches evas_gl_new() always returns NULL.

Jan 22 2018, 3:59 AM · efl
jpeg added a comment to T6627: hoversels broke after this commit.

Thanks for the fix.

Jan 22 2018, 2:23 AM · efl

Jan 21 2018

jpeg added a comment to D5430: efl_ui_pager: add a new class.

@eunue where are we on this?

Jan 21 2018, 6:59 PM · Restricted Project, efl
jpeg added a comment to T5301: Make EFL easier to use by improving its interface.

I disagree with the combining of toolbar and tab bar. Whilst they may be similar from a ui (and also external api) point of view the function differently.

Tab bar should indicate current tab and allow through api the addition of views attached to a tab button. Whereas toolbar is simply a list of tool buttons probably with separators...

Jan 21 2018, 6:59 PM · Restricted Project, efl, Restricted Project

Jan 19 2018

jpeg updated subscribers of T6514: fix eolian function redefine errors.
Jan 19 2018, 12:41 AM · Restricted Project, efl

Jan 18 2018

jpeg added a comment to T6514: fix eolian function redefine errors.

Current status:

eolian: efl_gfx_path.eo:259:7: function 'interpolate' redefined (originally at efl_vg.eo:96:7)
eolian: efl_gfx_path.eo:62:7: function 'bounds_get' redefined (originally at ector_renderer.eo:110:7)
eolian: efl_gfx_path.eo:62:7: function 'bounds_get' redefined (originally at efl_vg.eo:85:7)
eolian: efl_net_control_access_point.eo:161:13: function 'name' redefined (originally at efl_object.eo:63:10)
eolian: efl_net_control_technology.eo:70:13: function 'name' redefined (originally at efl_object.eo:63:10)
eolian: efl_net_session.eo:89:13: function 'name' redefined (originally at efl_object.eo:63:10)
eolian: efl_player.eo:44:14: function 'position' redefined (originally at efl_gfx.eo:21:10)
eolian: efl_text_cursor.eo:37:10: function 'cursor' redefined (originally at efl_ui_cursor.eo:43:10)
eolian: efl_text_font.eo:59:17: function 'font' redefined (originally at efl_text_properties.eo:21:10)
eolian: efl_text_font.eo:66:17: function 'font_source' redefined (originally at efl_text_properties.eo:48:10)
eolian: efl_ui_focus_object.eo:29:13: function 'focus' redefined (originally at elm_widget_item.eo:154:17)
eolian: efl_ui_list_model.eo:32:10: function 'size' redefined (originally at efl_gfx.eo:39:10)
eolian: efl_ui_model_factory_connect.eo:5:7: function 'connect' redefined (originally at efl_ui_model_connect.eo:5:7)
eolian: efl_ui_text.eo:146:10: function 'password' redefined (originally at efl_text_format.eo:102:17)
eolian: efl_ui_zoom.eo:53:10: function 'zoom' redefined (originally at efl_gfx_map.eo:253:7)
eolian: efl_vg.eo:17:10: function 'name' redefined (originally at efl_object.eo:63:10)

efl_gfx_path, efl_vg -> @smohanty
efl_net -> @barbieri
efl_player -> @taxi2se
efl_ui_list, efl_ui_model_factory_connect -> @felipealmeida
efl_ui_text -> @herdsman
efl_ui_zoom -> @singh.amitesh

Jan 18 2018, 11:28 PM · Restricted Project, efl
jpeg added a comment to T5315: Refactoring Edje/Elm_Layout.

Efl.Ui.Layout work is completed (only one API: theme).

Jan 18 2018, 10:09 PM · efl: widgets, Restricted Project
jpeg added a comment to T5321: Refactor ATSPI interface.

I think you're the boss.
Everything right now is marked as beta, except for:

  • Efl.Ui.Widget.access_info
  • Efl.Access.attribute_append
  • Efl.Access.attribute_clear

But the last two are actually protected behind an extra EFL_BETA_API_SUPPORT. There are some C API's inside efl_access.h as well, also behind EFL_BETA_API_SUPPORT.
In other words, nothing except Efl.Ui.Widget.access_info is stable, assuming we release the EO API.

Jan 18 2018, 10:05 PM · Restricted Project, efl
jpeg added a comment to T6441: Refactor Elm interfaces to Efl.Ui.

grep -r "Elm" src/lib/efl/interfaces

src/lib/efl/interfaces/efl_config.eo: - Elm_Color_Class list -> no need to return the struct, only the name matters
src/lib/efl/interfaces/efl_config.eo: - Elm_Color_Overlay -> see with Jee-Yong and his color patch (common intf)

Jan 18 2018, 9:44 PM · Restricted Project, efl: widgets, Restricted Project
jpeg added a comment to T5301: Make EFL easier to use by improving its interface.

As mentioned in T6441, I think this is the current state of Efl.Ui wrt. this task.

Jan 18 2018, 9:43 PM · Restricted Project, efl, Restricted Project
jpeg added a comment to T6441: Refactor Elm interfaces to Efl.Ui.
  • elm_interface_scrollable is not needed, as it is replaced by "has a" Efl.Ui.Scroller (as opposed to "is a" scrollable mixin).
  • elm_interface_fileselector is needed as part of the fileselector. No one is working on this currently, and Tizen shows no interest in it. It will only be done if someone steps in voluntarily to do work on it. It shouldn't be a blocker (I full well understand the value of a good fileselector! But it's a big task to improve and adapt the existing one, or replace it by something better!)
  • elm_color_class: thanks for the reminder! I'll have a look :)
Jan 18 2018, 9:40 PM · Restricted Project, efl: widgets, Restricted Project
jpeg lowered the priority of T5356: Refactor fileselector from High to Wishlist.

Not a priority for Tizen. While super useful this is not a blocker for a stable EO API.

Jan 18 2018, 2:38 AM · efl: widgets, Restricted Project
jpeg lowered the priority of T5321: Refactor ATSPI interface from High to Wishlist.

Most of this has been handled already, I think, API-wise. All unstable things have been marked as beta.

Jan 18 2018, 2:37 AM · Restricted Project, efl
jpeg reassigned T5378: New filter APIs for copy and paste text hooking from herb to thiepha.

What was this for? Is it needed?
I see no update on D4966

Jan 18 2018, 2:17 AM · efl: rendering, Restricted Project
jpeg renamed T6182: Focus: custom_chain / explicit order setting from custom_chain / explisit order setting to Focus: custom_chain / explicit order setting.
Jan 18 2018, 2:01 AM · Restricted Project
jpeg closed T5527: EO: Dnd (Drag & Drop) as Resolved.

commit 07e7bbd4b5cc17bbf8c1e48e500396e66f98120e
Author: Thiep Ha <thiepha@gmail.com>
Date: Tue Jan 16 16:33:30 2018 +0900

Jan 18 2018, 1:55 AM · Restricted Project, efl
jpeg closed T5527: EO: Dnd (Drag & Drop), a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Jan 18 2018, 1:55 AM · Restricted Project, efl, Restricted Project
jpeg updated the task description for T5363: Cleanup elm_widget.eo.
Jan 18 2018, 12:59 AM · efl: widgets, Restricted Project
jpeg added a comment to T5319: Refactor scrollable mixin.

Widget still has 4 unclear methods defined:

/* FIXME: Scroll API. Not sure how those APIs should be exposed with
 * the new scrollable API. */
scroll_hold_push {
   [[Push scroll hold]]
}
scroll_hold_pop {
   [[Pop scroller hold]]
}
scroll_freeze_push {
   [[Push scroller freeze]]
}
scroll_freeze_pop {
   [[Pop scroller freeze]]
}
Jan 18 2018, 12:55 AM · efl: widgets, Restricted Project
jpeg raised the priority of T5716: Base background object from Wishlist to Normal.

Most of this has already been implemented. Good!

Jan 18 2018, 12:51 AM · efl: widgets, Restricted Project
jpeg assigned T6441: Refactor Elm interfaces to Efl.Ui to woohyun.

Do we need fileselector now? A proper interface would require a LOT of work.

Jan 18 2018, 12:49 AM · Restricted Project, efl: widgets, Restricted Project
jpeg lowered the priority of T5328: Refactor/rename container, pack, ... interface from High to Pending on user input.
Jan 18 2018, 12:34 AM · efl, Restricted Project
jpeg reassigned T6360: EO: Item and Item_List API's from jpeg to cedric.

This depends on @cedric's work on the model. Come on.

Jan 18 2018, 12:34 AM · efl: widgets, Restricted Project

Jan 17 2018

jpeg added a comment to T5328: Refactor/rename container, pack, ... interface.

I think I made a mistake at first by inheriting Pack_Grid from Pack_Linear... it's probably not a good idea after all (removing that inheritance could simplify the code).
We could also have a better namespace? But I'm not sure.
Any specific issue here, @cedric ?

Jan 17 2018, 11:55 PM · efl, Restricted Project
jpeg reassigned T5315: Refactoring Edje/Elm_Layout from jpeg to herdsman.

Last missing bit for me is @herdsman's removal of item_provider_cb, and maybe @taxi2se's work with Playable interface.

Jan 17 2018, 11:50 PM · efl: widgets, Restricted Project
jpeg reassigned T5329: Cleanup elm_general.eot from jpeg to herdsman.

This is 99% done. Only offenders are Efl.Ui.Text (many API's) and Efl.Ui.List (only one unimplemented API).

Jan 17 2018, 11:47 PM · efl: widgets, Restricted Project
jpeg closed T5322: One window ! as Resolved.

Okay. I think this is it.
Stack API is beta. Types I believe are useless (use a subclass). Some methods / properties lack proper documentation. But overall this looks better now.
If you reopen this, please mention specific points to address.

Jan 17 2018, 9:30 PM · Restricted Project, efl
jpeg closed T5322: One window !, a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Jan 17 2018, 9:30 PM · Restricted Project, efl, Restricted Project
jpeg reassigned T5810: EFL "new" theme for EO objects from singh.amitesh to taxi2se.

I think @taxi2se handled a lot of this already.

Jan 17 2018, 9:30 PM · efl: widgets, Restricted Project
jpeg added a comment to T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

It's not really a big task. It's already the case for all things related to evas as evas object constructor looks for the evas.
Though you are perfectly right that a proper hint in EO would make sense.

Jan 17 2018, 2:02 AM · efl: main loop
jpeg added a comment to T6617: evas is broken.

It was assuming that if evas_gl_new() returns something then surely evas gl must work. The null checks can remain, but the assumption was absolutely not stupid.

Jan 17 2018, 2:00 AM · efl
jpeg added a comment to D5738: eina: remove usless newline.

The change in Eo.h is not internal by definition.
It will affect all apps already compiled assuming they had their own .eo files. Unlikely, but still to be considered.

Jan 17 2018, 1:22 AM
jpeg closed T6591: ^c on terminology does not work anymore in case of typo in command as Invalid.

Then just close it :D

Jan 17 2018, 12:55 AM · Terminology
jpeg added a comment to T5326: Refactor ctxpopup, popup and notify.

So called "list popup" (basically ctx menu) is still missing because some changes on model are still pending. Ping @cedric.

Jan 17 2018, 12:54 AM · efl: widgets, Restricted Project

Jan 16 2018

jpeg closed T6579: THEMES USAGE IS BROKEN as Resolved.

Please reopen if there are remaining issues. And please explain the test scenario (not necessarily the code path) :)

Jan 16 2018, 10:28 PM · efl
jpeg reopened T6617: evas is broken as "Open".

The patches submitted show that application logic must be adapted, which is not acceptable. I'll submit something soon.

Jan 16 2018, 10:15 PM · efl
jpeg added a comment to T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

you know what? make sure animation objects can't be created without a parent (try to find the evas from this parent. if null, then finalize or constructor should return null) - also change the test cases also.

Jan 16 2018, 9:35 PM · efl: main loop
jpeg added a comment to D5616: efl_ui_bg: add Efl.Ui.Bg interface.

See T6579 - When using custom themes, this broke the standard bg of some windows added with elm_win_util_standard_add. Somehow not all (weird). I'll fix it soon.

Jan 16 2018, 9:12 PM
jpeg added a comment to T6579: THEMES USAGE IS BROKEN.

Two small patches merged:
fe346d2ee2 elm_datetime: use legacy elm_button
1375705168 panes: Expose parts in EO file

Jan 16 2018, 9:04 PM · efl
jpeg added a comment to T6573: all the uses of efl_animation should use a parent object that traces back to the mainloop.

Okay then please close this if your saying is correct.
@taxi2se also please address Dave's concerns on the ML.

Jan 16 2018, 8:53 PM · efl: main loop
jpeg added a comment to T6579: THEMES USAGE IS BROKEN.

@taxi2se can you ping me again so we check these patches together? thanks

Jan 16 2018, 8:30 AM · efl
jpeg added a comment to T5351: New Naviframe API.
  1. "Frame_Stack", no?
  2. both: insert_at, insert_after (optional), insert_before
  3. good question. probably promote. that's a corner case
  4. what is Frame_Navigation? a subclass/style of Frame? then, yes, i guess it could be? not sure :)
Jan 16 2018, 8:22 AM · efl (efl-1.21), efl: widgets, Restricted Project
jpeg added a comment to D5738: eina: remove usless newline.

Well, it's in. To be honest I am quite dubious that the cache was actually helpful... It's too specific.
But I wonder if merging this patch isn't breaking ABI??

Jan 16 2018, 8:16 AM
jpeg added a comment to T6326: evas functions do not error when null is passed.

Half done. I think you can do E. I didn't push anything for E but you should see a lot of messages.
Also, you might be interested in changing some NULL check the old (evas) EAPI to print a warning as well (I have evas_callbacks.c in mind).

Jan 16 2018, 8:09 AM · efl: rendering, efl: layout engine
jpeg updated the task description for T6616: focus: Many calls to NULL objects.
Jan 16 2018, 3:20 AM · efl: widgets
jpeg triaged T6616: focus: Many calls to NULL objects as Normal priority.
Jan 16 2018, 3:08 AM · efl: widgets
jpeg added a comment to D5738: eina: remove usless newline.

Note that this broke eo_suite.

Jan 16 2018, 2:57 AM