Page MenuHomePhabricator

jptiz (João Paulo Taylor Ienczak Zanette)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2019, 7:24 AM (31 w, 3 d)
Availability
Available

Recent Activity

Mon, Jul 6

jptiz requested review of D12044: build: Drop meson.source_root().
Mon, Jul 6, 1:51 PM · efl

Wed, Jul 1

jptiz closed D11994: Meson.build cleanup..
Wed, Jul 1, 1:14 AM · efl

Tue, Jun 30

jptiz added a comment to D11994: Meson.build cleanup..

Ok, I think that's it for this patch. Should I squash the commits it or will it be squashed by who lands the patch?

Tue, Jun 30, 8:33 PM · efl
jptiz updated the summary of D11994: Meson.build cleanup..
Tue, Jun 30, 8:25 PM · efl
jptiz updated the summary of D11994: Meson.build cleanup..
Tue, Jun 30, 8:24 PM · efl
jptiz updated the diff for D11994: Meson.build cleanup..

Removed 6 and 8 from this patch, so we stick with just:

Tue, Jun 30, 8:22 PM · efl
jptiz added a comment to D11994: Meson.build cleanup..

6: Mhm, -Wall does not find its way into the cflags of the build.ninja file, even if the default warning is 3. That should be fixed.

Tue, Jun 30, 8:05 PM · efl
jptiz accepted D12022: windows: Fix path for file sanitization.
Tue, Jun 30, 12:29 PM · efl

Mon, Jun 29

jptiz added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Ok, took my time to think of the arguments here. So let me reorganize the ideas...

Mon, Jun 29, 4:36 PM · efl
jptiz added a comment to T8761: Standardize external dependency handling.

My mind just messed up some phrases in the last comment. Edited to make more sense :^D.

Mon, Jun 29, 2:17 PM · efl
jptiz added a comment to T8761: Standardize external dependency handling.

First Half of the issue

I think you can just remove the _dep prefix from these 4 vars ... no big deal, there is really no thought behind that scheme, just make sure the names do not collide :)
Mon, Jun 29, 2:13 PM · efl
jptiz triaged T8761: Standardize external dependency handling as Trivial priority.
Mon, Jun 29, 12:49 PM · efl

Fri, Jun 26

jptiz added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

i'm not very fond of wrapping in meson, because you don't have any control on how the lib is built. For example, is zlib built using the asm files ?

Fri, Jun 26, 2:55 PM · efl
jptiz updated the diff for D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Readd regexp on non-windows environments.

Fri, Jun 26, 1:18 PM · efl
jptiz updated the diff for D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Replace explicit dependency('zlib') with zlib variable.

Fri, Jun 26, 1:13 PM · efl
jptiz requested review of D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.
Fri, Jun 26, 1:07 PM · efl
jptiz added projects to T8760: Compile EFL natively on Windows.: efl, Unknown Object (Project).
Fri, Jun 26, 12:57 PM · Unknown Object (Project), efl
jptiz added a comment to D12024: windows: Fix file mapping.

Since D12031 has landed, I think this one can be closed.

Fri, Jun 26, 7:03 AM · efl

Thu, Jun 25

jptiz updated the diff for D11994: Meson.build cleanup..

Add back the accidentally-removed DLL_EXPORT=1.

Thu, Jun 25, 12:16 PM · efl
jptiz added a comment to D11994: Meson.build cleanup..

With these two comments, then: should I split 6 and 8 into two other patches? For 6 because we can track this in an isolated patch, and for 8 because of possible opinion divergence.

Sounds good :) (If getting out 8 is too much work, i dont have a issue with first merging that if the rest of the stuff is coming in a next patch :))
Thu, Jun 25, 9:16 AM · efl

Wed, Jun 24

jptiz updated the task description for T8761: Standardize external dependency handling.
Wed, Jun 24, 2:35 PM · efl
jptiz renamed T8761: Standardize external dependency handling from Standardize external dependency variable names to Standardize external dependency handling.
Wed, Jun 24, 2:34 PM · efl

Tue, Jun 23

jptiz added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

"A file name is relative to the current directory if it does not begin with one of the following etc... "
"A single backslash, for example, "\directory" or "\file.txt". This is also referred to as an absolute path."

i don't know if you should also consider /

It's common for applications ported to windows to consider both \ and / (e.g. neovim). Maybe it would be a nice idea if EFL accepted both as well? At least in Windows.

we do almost nothing about that. Usually, when one passes a path to a Windows file API, the API changes all the slashes to backslashes

Tue, Jun 23, 11:29 AM · efl
Herald closed T8761: Standardize external dependency handling as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Tue, Jun 23, 10:48 AM · efl
jptiz updated the task description for T8760: Compile EFL natively on Windows..
Tue, Jun 23, 10:27 AM · Unknown Object (Project), efl
jptiz added a comment to D12022: windows: Fix path for file sanitization.

i've looked at https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#fully-qualified-vs-relative-paths and i indeed see it can begin with \ (but not /) :

"A file name is relative to the current directory if it does not begin with one of the following etc... "
"A single backslash, for example, "\directory" or "\file.txt". This is also referred to as an absolute path."

i don't know if you should also consider /

Tue, Jun 23, 10:01 AM · efl
jptiz triaged T8760: Compile EFL natively on Windows. as High priority.
Tue, Jun 23, 9:48 AM · Unknown Object (Project), efl
jptiz accepted D12021: Fix eina file thread test on Windows.

more a coding convention

Tue, Jun 23, 8:54 AM · efl
jptiz added a comment to D12021: Fix eina file thread test on Windows.

last thing for me : we declare variables always at the beginning of the block (exception in eo/eolian)
otherwise, good for me (tested)

Tue, Jun 23, 7:59 AM · efl

Fri, Jun 19

jptiz added a comment to D11994: Meson.build cleanup..

1 / 2 / 3 / 4: fine for me.
We recently bumped min version to 0.50 so 5 & 7 Should hopefully work without issues.

Fri, Jun 19, 7:43 AM · efl

Thu, Jun 18

jptiz requested review of D11994: Meson.build cleanup..
Thu, Jun 18, 5:10 PM · efl

Tue, Jun 16

jptiz accepted D11983: Fix ENOMEM message on Windows and solaris.

Looks good :)

Tue, Jun 16, 5:29 PM · efl

Mon, Jun 15

jptiz abandoned D11939: [WIP] eapi: Fix usage of dllimport/export.

Ok, I agree that the current EAPI usage is sort of error-prone. I'm closing this and let it for further discussion in a later patch with Felipe's proposal.

Mon, Jun 15, 4:54 PM · efl

Jun 8 2020

jptiz updated the diff for D11939: [WIP] eapi: Fix usage of dllimport/export.

Set symbols in config.h

Jun 8 2020, 12:18 PM · efl
jptiz updated the diff for D11939: [WIP] eapi: Fix usage of dllimport/export.

Change EAPI definition where it is already defined.

Jun 8 2020, 10:46 AM · efl

Jun 5 2020

jptiz added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

I have to say that i do not like eina_api.h. Why not just altering the current EAPI defitionions ?

Jun 5 2020, 7:55 AM · efl

Jun 4 2020

jptiz added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

but eina_types.h must not be inluded by any program, never. It's Eina.h that must be included, always. eina_types.h is included explicitely only in eina source code. Also the order of all the eina_.h is important, and including for example, evil_private.h in between eina_*.h is just wrong. evil_private.h MUST be included before any eina header file used in eina source code.

Jun 4 2020, 12:19 PM · efl
jptiz added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

why not letting EAPI in eina_types.h ? I don't think that there is any benefit

Jun 4 2020, 11:51 AM · efl
jptiz added a comment to D11939: [WIP] eapi: Fix usage of dllimport/export.

why not letting EAPI in eina_types.h ? I don't think that there is any benefit

Jun 4 2020, 9:45 AM · efl
jptiz updated the summary of D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 8:58 AM · efl
jptiz updated the summary of D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 8:57 AM · efl
jptiz requested review of D11939: [WIP] eapi: Fix usage of dllimport/export.
Jun 4 2020, 8:50 AM · efl

May 25 2020

jptiz accepted D11851: build: move EFL_BUILD to package_c_args used in all subprojects.

Getting the patch straight from devs/stefan/efl-dll works pretty fine and passes tests. :)

May 25 2020, 8:58 AM · efl
jptiz accepted D11854: build: lib: harmonize the use of package_c_args in all libs.

Passing tests :)

May 25 2020, 7:29 AM · efl
jptiz added a comment to D11851: build: move EFL_BUILD to package_c_args used in all subprojects.

I applyed the patch locally here (against updated master), but it fails with the same error @stefan_schmidt had.

May 25 2020, 6:40 AM · efl
jptiz added a comment to D11855: build: modules: harmonize use of package_c_args.

I would love to see clang-format for that, but it doesn't seem to support it well (https://clang.llvm.org/docs/ClangFormatStyleOptions.html). I tried some small tests but didn't get good results (e.g. it interprets # as preprocessor directives, moving comments to start of line and breaking too long comments with \).

May 25 2020, 4:48 AM · efl

May 22 2020

jptiz added a comment to D11854: build: lib: harmonize the use of package_c_args in all libs.

Figured out what @bu5hm4n was saying, I think.

May 22 2020, 8:29 AM · efl

May 20 2020

jptiz accepted D11860: lib: add more c_args handling for places we missed before.

Seems reasonable and apparently nothing broke here.

May 20 2020, 6:01 AM · efl

May 19 2020

jptiz accepted D11855: build: modules: harmonize use of package_c_args.

Works and passes tests here (in Linux).

May 19 2020, 10:27 AM · efl
jptiz accepted D11853: benchmarks: use EFL_BUILD=1 in c_args.
May 19 2020, 8:32 AM · efl
jptiz accepted D11856: libs: headers: ensure we include headers in the correct order for EAPI.
May 19 2020, 7:11 AM · efl
jptiz accepted D11852: benchmark: fix ident in meson.build file.
May 19 2020, 7:07 AM · efl
jptiz accepted D11850: build: set DLL_EXPORT when on a windows system.
May 19 2020, 7:01 AM · efl

May 13 2020

jptiz abandoned D11771: cxx: Receive `v` by reference instead of value in `convert_to_c_impl`.

Marked it as false positive now.

@jptiz are you looking at the other cxx Coverity issues as well?

May 13 2020, 5:07 AM · efl

May 4 2020

jptiz requested review of D11771: cxx: Receive `v` by reference instead of value in `convert_to_c_impl`.
May 4 2020, 12:16 PM · efl
jptiz added a reviewer for D11770: cxx: Initialize _list and _node with nullptr: felipealmeida.
May 4 2020, 7:57 AM · efl
jptiz requested review of D11770: cxx: Initialize _list and _node with nullptr.
May 4 2020, 7:48 AM · efl

Feb 27 2020

jptiz added a comment to T8620: elementary_config crashes when clicking any of "Icons" tab options.

Maybe try to build efl with asan enabled, maybe that is causing it to crash ? (meson configure -Db_sanitize=address)

Feb 27 2020, 10:29 AM
jptiz added a comment to T8620: elementary_config crashes when clicking any of "Icons" tab options.
In T8620#150908, @zmike wrote:

Probably want to valgrind that, the errors printed here aren't related.

Feb 27 2020, 10:15 AM
jptiz created T8620: elementary_config crashes when clicking any of "Icons" tab options.
Feb 27 2020, 9:40 AM
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

You mean this?

Feb 27 2020, 9:23 AM · examples
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

True, my EFL was out of date!

Feb 27 2020, 7:46 AM · examples

Feb 21 2020

jptiz added a project to D11379: csharp: Generate default event implementations in Eo interfaces for dotnet.: Unknown Object (Project).
Feb 21 2020, 8:11 AM · Unknown Object (Project), efl: api

Feb 20 2020

jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

Oh, okay, found the neovim issue: the file is actually called "nvim.desktop", not "neovim.desktop", that's why. My eyes just didn't catch it at first.

Feb 20 2020, 1:28 PM · examples
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

About the purpose: understood, gonna update the main post.

Feb 20 2020, 1:24 PM · examples
jptiz triaged T8618: Homescreen example: Apps without icons are not clickable as TODO priority.
Feb 20 2020, 1:03 PM · examples
jptiz updated the diff for D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..

Add a test-case.

Feb 20 2020, 10:08 AM · Unknown Object (Project), efl: api

Feb 19 2020

jptiz planned changes to D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..

Add tests.

Feb 19 2020, 12:20 PM · Unknown Object (Project), efl: api
jptiz updated the summary of D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:19 PM · Unknown Object (Project), efl: api
jptiz edited projects for D11379: csharp: Generate default event implementations in Eo interfaces for dotnet., added: efl: api; removed efl.
Feb 19 2020, 12:18 PM · Unknown Object (Project), efl: api
jptiz requested review of D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:15 PM · Unknown Object (Project), efl: api
jptiz added a revision to T7744: C#: Support emitting events from C# implementation of Efl interfaces: D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:15 PM · efl: language bindings

Feb 18 2020

jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Add tests.

Feb 18 2020, 11:18 AM · efl

Feb 17 2020

jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

Just to add some (possibly) useful info:

Feb 17 2020, 11:13 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)
jptiz updated the summary of D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 17 2020, 6:50 AM · efl
jptiz added a task to D11281: C#: Add error checking for Eina.Success_Flag return type: T8383: Eo: Add `Error.Success_Flag` alias wrapping boolean property return values..
Feb 17 2020, 6:50 AM · efl
jptiz added a revision to T8383: Eo: Add `Error.Success_Flag` alias wrapping boolean property return values.: D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 17 2020, 6:50 AM · Unknown Object (Project), efl: language bindings

Feb 14 2020

jptiz accepted D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 14 2020, 4:28 PM · efl
jptiz added a comment to D11282: C#: Make NativeClass and NativeHandle internal for C# 8.

Got the following build error for efl_mono.dll:

Feb 14 2020, 4:25 PM · efl: language bindings

Feb 13 2020

jptiz accepted D11252: eolian-mono: Make Get/Set internal for generated properties.

Passes tests and has pretty nice refactors.

Feb 13 2020, 11:30 AM · efl
jptiz updated the summary of D11343: csharp: Prevent using system dll for eflcustomexportsmono.
Feb 13 2020, 10:10 AM · efl
jptiz requested review of D11343: csharp: Prevent using system dll for eflcustomexportsmono.
Feb 13 2020, 10:09 AM · efl
jptiz claimed T7744: C#: Support emitting events from C# implementation of Efl interfaces.
Feb 13 2020, 5:01 AM · efl: language bindings

Feb 12 2020

jptiz added a reviewer for D11331: csharp: Fix managed name when solving Get/SetType name clash: segfaultxavi.
Feb 12 2020, 7:28 AM · efl
jptiz requested review of D11331: csharp: Fix managed name when solving Get/SetType name clash.
Feb 12 2020, 7:26 AM · efl

Feb 11 2020

jptiz updated the diff for D11281: C#: Add error checking for Eina.Success_Flag return type.

Fix mess with arc: considering only last commit, not the entire dependencies.

Feb 11 2020, 9:48 AM · efl
jptiz updated the diff for D11281: C#: Add error checking for Eina.Success_Flag return type.

Add managed name to exception message and simplify ifs.

Feb 11 2020, 9:46 AM · efl

Feb 10 2020

jptiz closed T8384: C#: Create wrapper type with indexers for properties with keys as Invalid.

Indexers have been reverted as not good practices for our use-cases (as stated in D11114).

Feb 10 2020, 1:07 PM · efl: language bindings
jptiz closed T8384: C#: Create wrapper type with indexers for properties with keys, a subtask of T8048: eolian_mono: setters returning complex values should not be mapped to properties, as Invalid.
Feb 10 2020, 1:07 PM · Unknown Object (Project), efl: language bindings
jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

@felipealmeida So, I've found rEFL581bec9598943cc9274dfe7db1a73a4c878c3cdd, which makes struct immutable because of C# recommendations (and there's the reasoning I was looking for, too). Should we propose to make EO structs generate classes instead, then? Where could I read/who to talk about if it would or not go against the idea of EO structs?

Feb 10 2020, 6:06 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)

Feb 7 2020

jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

Oops, just realized actually structs don't have properties (https://www.enlightenment.org/contrib/docs/eo). Maybe changing an eo-struct would require creating a new one with modified values, letting mutability only to classes?

Feb 7 2020, 9:28 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)
jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

As far as I can see from struct_definition.hh, fields are intentionally read-only (don't know the reason, tho), while properties may be writable. Should we change that rule and add a set for them, then? Where could I find the reasoning about who should be read-only, etc.?

Feb 7 2020, 9:24 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)

Feb 6 2020

jptiz added a comment to T8488: C#: Implement `IList<T>` for `Eina.Array`.

Does this commit resolve this task? Or is there something missing?

Feb 6 2020, 10:23 AM · efl: language bindings

Jan 28 2020

jptiz accepted D11219: mono-tests: Fix build after DnD changes.

Looks good to me :)

Jan 28 2020, 9:55 AM · efl
jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Updated diff title to describe better what does it change.

Jan 28 2020, 8:32 AM · efl
jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Update to reflect changes from 581bec9598943cc9274dfe7db1a73a4c878c3cdd.

Jan 28 2020, 8:28 AM · efl

Jan 27 2020

jptiz added a comment to D11190: rewrite efl cnp and dnd handling.

The accessor<string> part is generating invalid C# code:

src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr'
src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'

As far as I can see, this is the first time we try to use this in our API.
Calling in the C# people... @felipealmeida, @jptiz, any idea what is happening?

Jan 27 2020, 1:40 PM · efl
jptiz requested review of D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.
Jan 27 2020, 1:36 PM · efl
jptiz added a child revision for D11190: rewrite efl cnp and dnd handling: D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.
Jan 27 2020, 1:36 PM · efl
jptiz updated the diff for D11202: csharp: Escape contents of struct fields' value tag..

Use current indent level instead of arbitrary level 2.

Jan 27 2020, 8:45 AM · efl