Page MenuHomePhabricator

jptiz (João Paulo Taylor Ienczak Zanette)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2019, 7:24 AM (17 w, 2 d)
Availability
Available

Recent Activity

Feb 27 2020

jptiz added a comment to T8620: elementary_config crashes when clicking any of "Icons" tab options.

Maybe try to build efl with asan enabled, maybe that is causing it to crash ? (meson configure -Db_sanitize=address)

Feb 27 2020, 10:29 AM
jptiz added a comment to T8620: elementary_config crashes when clicking any of "Icons" tab options.
In T8620#150908, @zmike wrote:

Probably want to valgrind that, the errors printed here aren't related.

Feb 27 2020, 10:15 AM
jptiz created T8620: elementary_config crashes when clicking any of "Icons" tab options.
Feb 27 2020, 9:40 AM
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

You mean this?

Feb 27 2020, 9:23 AM · examples
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

True, my EFL was out of date!

Feb 27 2020, 7:46 AM · examples

Feb 21 2020

jptiz added a project to D11379: csharp: Generate default event implementations in Eo interfaces for dotnet.: Unknown Object (Project).
Feb 21 2020, 8:11 AM · Unknown Object (Project), efl: api

Feb 20 2020

jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

Oh, okay, found the neovim issue: the file is actually called "nvim.desktop", not "neovim.desktop", that's why. My eyes just didn't catch it at first.

Feb 20 2020, 1:28 PM · examples
jptiz added a comment to T8618: Homescreen example: Apps without icons are not clickable.

About the purpose: understood, gonna update the main post.

Feb 20 2020, 1:24 PM · examples
jptiz triaged T8618: Homescreen example: Apps without icons are not clickable as TODO priority.
Feb 20 2020, 1:03 PM · examples
jptiz updated the diff for D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..

Add a test-case.

Feb 20 2020, 10:08 AM · Unknown Object (Project), efl: api

Feb 19 2020

jptiz planned changes to D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..

Add tests.

Feb 19 2020, 12:20 PM · Unknown Object (Project), efl: api
jptiz updated the summary of D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:19 PM · Unknown Object (Project), efl: api
jptiz edited projects for D11379: csharp: Generate default event implementations in Eo interfaces for dotnet., added: efl: api; removed efl.
Feb 19 2020, 12:18 PM · Unknown Object (Project), efl: api
jptiz requested review of D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:15 PM · Unknown Object (Project), efl: api
jptiz added a revision to T7744: C#: Support emitting events from C# implementation of Efl interfaces: D11379: csharp: Generate default event implementations in Eo interfaces for dotnet..
Feb 19 2020, 12:15 PM · efl: language bindings

Feb 18 2020

jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Add tests.

Feb 18 2020, 11:18 AM · efl

Feb 17 2020

jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

Just to add some (possibly) useful info:

Feb 17 2020, 11:13 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)
jptiz updated the summary of D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 17 2020, 6:50 AM · efl
jptiz added a task to D11281: C#: Add error checking for Eina.Success_Flag return type: T8383: Eo: Add `Error.Success_Flag` alias wrapping boolean property return values..
Feb 17 2020, 6:50 AM · efl
jptiz added a revision to T8383: Eo: Add `Error.Success_Flag` alias wrapping boolean property return values.: D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 17 2020, 6:50 AM · Unknown Object (Project), efl: language bindings

Feb 14 2020

jptiz accepted D11281: C#: Add error checking for Eina.Success_Flag return type.
Feb 14 2020, 4:28 PM · efl
jptiz added a comment to D11282: C#: Make NativeClass and NativeHandle internal for C# 8.

Got the following build error for efl_mono.dll:

Feb 14 2020, 4:25 PM · efl: language bindings

Feb 13 2020

jptiz accepted D11252: eolian-mono: Make Get/Set internal for generated properties.

Passes tests and has pretty nice refactors.

Feb 13 2020, 11:30 AM · efl
jptiz updated the summary of D11343: csharp: Prevent using system dll for eflcustomexportsmono.
Feb 13 2020, 10:10 AM · efl
jptiz requested review of D11343: csharp: Prevent using system dll for eflcustomexportsmono.
Feb 13 2020, 10:09 AM · efl
jptiz claimed T7744: C#: Support emitting events from C# implementation of Efl interfaces.
Feb 13 2020, 5:01 AM · efl: language bindings

Feb 12 2020

jptiz added a reviewer for D11331: csharp: Fix managed name when solving Get/SetType name clash: segfaultxavi.
Feb 12 2020, 7:28 AM · efl
jptiz requested review of D11331: csharp: Fix managed name when solving Get/SetType name clash.
Feb 12 2020, 7:26 AM · efl

Feb 11 2020

jptiz updated the diff for D11281: C#: Add error checking for Eina.Success_Flag return type.

Fix mess with arc: considering only last commit, not the entire dependencies.

Feb 11 2020, 9:48 AM · efl
jptiz updated the diff for D11281: C#: Add error checking for Eina.Success_Flag return type.

Add managed name to exception message and simplify ifs.

Feb 11 2020, 9:46 AM · efl

Feb 10 2020

jptiz closed T8384: C#: Create wrapper type with indexers for properties with keys as Invalid.

Indexers have been reverted as not good practices for our use-cases (as stated in D11114).

Feb 10 2020, 1:07 PM · efl: language bindings
jptiz closed T8384: C#: Create wrapper type with indexers for properties with keys, a subtask of T8048: eolian_mono: setters returning complex values should not be mapped to properties, as Invalid.
Feb 10 2020, 1:07 PM · Unknown Object (Project), efl: language bindings
jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

@felipealmeida So, I've found rEFL581bec9598943cc9274dfe7db1a73a4c878c3cdd, which makes struct immutable because of C# recommendations (and there's the reasoning I was looking for, too). Should we propose to make EO structs generate classes instead, then? Where could I read/who to talk about if it would or not go against the idea of EO structs?

Feb 10 2020, 6:06 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)

Feb 7 2020

jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

Oops, just realized actually structs don't have properties (https://www.enlightenment.org/contrib/docs/eo). Maybe changing an eo-struct would require creating a new one with modified values, letting mutability only to classes?

Feb 7 2020, 9:28 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)
jptiz added a comment to T8609: mono-bindings: Missing setter for struct fields.

As far as I can see from struct_definition.hh, fields are intentionally read-only (don't know the reason, tho), while properties may be writable. Should we change that rule and add a set for them, then? Where could I find the reasoning about who should be read-only, etc.?

Feb 7 2020, 9:24 AM · Unknown Object (Project), efl: language bindings, efl (efl-1.24)

Feb 6 2020

jptiz added a comment to T8488: C#: Implement `IList<T>` for `Eina.Array`.

Does this commit resolve this task? Or is there something missing?

Feb 6 2020, 10:23 AM · efl: language bindings

Jan 28 2020

jptiz accepted D11219: mono-tests: Fix build after DnD changes.

Looks good to me :)

Jan 28 2020, 9:55 AM · efl
jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Updated diff title to describe better what does it change.

Jan 28 2020, 8:32 AM · efl
jptiz updated the diff for D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.

Update to reflect changes from 581bec9598943cc9274dfe7db1a73a4c878c3cdd.

Jan 28 2020, 8:28 AM · efl

Jan 27 2020

jptiz added a comment to D11190: rewrite efl cnp and dnd handling.

The accessor<string> part is generating invalid C# code:

src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr'
src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'

As far as I can see, this is the first time we try to use this in our API.
Calling in the C# people... @felipealmeida, @jptiz, any idea what is happening?

Jan 27 2020, 1:40 PM · efl
jptiz requested review of D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.
Jan 27 2020, 1:36 PM · efl
jptiz added a child revision for D11190: rewrite efl cnp and dnd handling: D11210: csharp: Add IntPtr to/from IEnumerable conversion for "accessor" types.
Jan 27 2020, 1:36 PM · efl
jptiz updated the diff for D11202: csharp: Escape contents of struct fields' value tag..

Use current indent level instead of arbitrary level 2.

Jan 27 2020, 8:45 AM · efl
jptiz requested review of D11202: csharp: Escape contents of struct fields' value tag..
Jan 27 2020, 8:37 AM · efl
jptiz added a revision to T8588: Ampersand is not escaped in some <value> tags.: D11202: csharp: Escape contents of struct fields' value tag..
Jan 27 2020, 8:37 AM · Unknown Object (Project), efl: language bindings, efl: docs
jptiz reopened T8588: Ampersand is not escaped in some <value> tags. as "Open".
Jan 27 2020, 7:54 AM · Unknown Object (Project), efl: language bindings, efl: docs
Herald closed T8588: Ampersand is not escaped in some <value> tags. as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Jan 27 2020, 7:47 AM · Unknown Object (Project), efl: language bindings, efl: docs

Jan 20 2020

jptiz updated the diff for D10889: csharp: Generating documentation for tuple-value properties..

Reopen Diff and add "ItemX" for each item (where X is the item's index within the tuple).

Jan 20 2020, 10:42 AM · efl
jptiz commandeered D10889: csharp: Generating documentation for tuple-value properties..
Jan 20 2020, 10:39 AM · efl

Dec 18 2019

jptiz accepted D10911: c#: Fixing ca2208 for Eina.List..
Dec 18 2019, 1:27 PM · efl

Dec 17 2019

jptiz accepted D10900: csharp: Fix accessor IEnumerable implementation..
Dec 17 2019, 1:10 PM · efl
jptiz added a comment to D10889: csharp: Generating documentation for tuple-value properties..

Cool! Renders nicely with DocFX.

Dec 17 2019, 12:32 PM · efl
jptiz updated the diff for D10889: csharp: Generating documentation for tuple-value properties..

Removed whitespace changes.

Dec 17 2019, 11:50 AM · efl

Dec 16 2019

jptiz requested review of D10889: csharp: Generating documentation for tuple-value properties..
Dec 16 2019, 10:48 AM · efl
jptiz added a revision to T8468: C# documentation for tuple properties is wrong: D10889: csharp: Generating documentation for tuple-value properties..
Dec 16 2019, 10:47 AM · efl: language bindings, efl: docs

Dec 12 2019

jptiz added a comment to T8468: C# documentation for tuple properties is wrong.

Looks like we should not be using tuples as return values after all. It is recommended to use a explicit class, with proper fields and docs.

Dec 12 2019, 3:07 PM · efl: language bindings, efl: docs
jptiz updated the diff for D10809: csharp: Implement Deconstruct for structs..

csharp: Add 'since' documentation to deconstruct.

Dec 12 2019, 1:26 PM · efl
jptiz accepted D10669: csharp:Suppressing Warning and Add suffix collection..
Dec 12 2019, 12:57 PM · efl
jptiz updated the diff for D10809: csharp: Implement Deconstruct for structs..

Fix wrong generate_deconstruct_method return (shouldn't be negated).

Dec 12 2019, 12:51 PM · efl
jptiz accepted D10717: csharp: Suppressing non-events Raise methods..
Dec 12 2019, 10:17 AM · efl
jptiz updated the diff for D10809: csharp: Implement Deconstruct for structs..

Add "Depends on D10801."

Dec 12 2019, 7:55 AM · efl

Dec 11 2019

jptiz updated the diff for D10801: csharp: Add implicit conversion from tuples to structs..

Switch unused struct_.fields to attributes::unused.

Dec 11 2019, 12:35 PM · efl
jptiz added a comment to D10809: csharp: Implement Deconstruct for structs..

Shouldn't this be applied on top of D10801? It fails with a conflict in the struct_definition.hh blocks.

Dec 11 2019, 8:47 AM · efl

Dec 10 2019

jptiz added inline comments to D10742: c#: Implement IList<T> to Eina.List..
Dec 10 2019, 11:26 AM · efl
jptiz accepted D10852: csharp: Removed duplicated call_match implementations.
Dec 10 2019, 9:48 AM · efl

Dec 9 2019

jptiz accepted D10827: csharp: Refactor annotation selection function.
Dec 9 2019, 10:28 AM · efl
jptiz updated the diff for D10809: csharp: Implement Deconstruct for structs..

Squash commits into just one.

Dec 9 2019, 6:24 AM · efl
jptiz added inline comments to D10809: csharp: Implement Deconstruct for structs..
Dec 9 2019, 5:48 AM · efl
jptiz updated the diff for D10809: csharp: Implement Deconstruct for structs..
  • csharp: Fix missing comparison in test.
Dec 9 2019, 5:44 AM · efl

Dec 6 2019

jptiz updated the diff for D10801: csharp: Add implicit conversion from tuples to structs..
  • csharp: Fix test for complex struct packing.
Dec 6 2019, 2:20 PM · efl
jptiz accepted D10811: c#: Suppressing warning for CA1724..
Dec 6 2019, 1:45 PM · efl
jptiz accepted D10668: csharp: changing string literal with nameof..
Dec 6 2019, 1:01 PM · efl
jptiz requested changes to D10717: csharp: Suppressing non-events Raise methods..

Just fix lines eina_error.cs:{158,174} and eldbus_common.cs:1554: "an event" (since "e" is a vowel sound - check here).

Dec 6 2019, 11:10 AM · efl
jptiz accepted D10657: csharp: Marking property with static..
Dec 6 2019, 6:31 AM · efl

Dec 5 2019

jptiz requested review of D10809: csharp: Implement Deconstruct for structs..
Dec 5 2019, 10:18 AM · efl
jptiz added a revision to T8489: C# better syntaxes for new Eina.Size2D and new Eina.Position2D: D10809: csharp: Implement Deconstruct for structs..
Dec 5 2019, 10:18 AM · efl: language bindings

Dec 4 2019

jptiz added a comment to D10791: csharp: Property Indexer implementation.

I've got the following compilation error:

Dec 4 2019, 12:21 PM · efl
jptiz added inline comments to D10785: c#: Implement IList to Eina.Array..
Dec 4 2019, 11:57 AM · efl
jptiz updated the diff for D10801: csharp: Add implicit conversion from tuples to structs..

Add tests and remove implicit conversion for 1-field structs.

Dec 4 2019, 9:39 AM · efl
jptiz planned changes to D10801: csharp: Add implicit conversion from tuples to structs..

Going to add some tests.

Dec 4 2019, 6:32 AM · efl
jptiz requested review of D10801: csharp: Add implicit conversion from tuples to structs..
Dec 4 2019, 6:31 AM · efl
jptiz added a revision to T8489: C# better syntaxes for new Eina.Size2D and new Eina.Position2D: D10801: csharp: Add implicit conversion from tuples to structs..
Dec 4 2019, 6:31 AM · efl: language bindings
jptiz accepted D10790: Fix invalid XML comment in efl_mono.dll.config.
Dec 4 2019, 4:57 AM · efl

Dec 3 2019

jptiz added a comment to T8489: C# better syntaxes for new Eina.Size2D and new Eina.Position2D.

I was working on this task, but then I ran into a problem with generating tuples for structs with too many fields. More specifically, after generating:

Dec 3 2019, 12:35 PM · efl: language bindings

Dec 2 2019

jptiz accepted D10774: csharp: Simplify field_argument_assignment.
Dec 2 2019, 12:00 PM · efl