Page MenuHomePhabricator

jptiz (João Paulo Taylor Ienczak Zanette)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 2 2019, 7:24 AM (51 w, 2 d)
Availability
Available

Recent Activity

Thu, Nov 12

jptiz accepted D12188: eina: Rename EAPI macro to EINA_API in Eina library.
Thu, Nov 12, 1:15 PM · efl
jptiz added inline comments to D12188: eina: Rename EAPI macro to EINA_API in Eina library.
Thu, Nov 12, 12:53 PM · efl

Tue, Nov 10

jptiz accepted D12182: evil: Rename EAPI macro to EVIL_API in Evil library.
Tue, Nov 10, 5:25 AM · efl

Mon, Nov 9

jptiz accepted D12037: Implement eina_thread for native windows.
Mon, Nov 9, 6:05 AM · efl

Fri, Nov 6

jptiz added a project to T8853: Support CK_FORK=no on all tests: Restricted Project.
Fri, Nov 6, 7:58 AM · Restricted Project
jptiz triaged T8853: Support CK_FORK=no on all tests as High priority.
Fri, Nov 6, 7:56 AM · Restricted Project

Tue, Nov 3

jptiz added a comment to T8783: eina_file_test: unlink test may fail due to tmpfile is already open.

@jptiz normally it is fixed in git. See eacee53c2e795a1c5e187558ccced2d66390d761
At least, it works on my computer

Can you give it a try ?

Tue, Nov 3, 6:56 AM · efl

Fri, Oct 30

jptiz updated the task description for T8847: It is possible to select multiple items in genlist.
Fri, Oct 30, 2:34 PM
jptiz updated the task description for T8847: It is possible to select multiple items in genlist.
Fri, Oct 30, 2:13 PM
jptiz created T8847: It is possible to select multiple items in genlist.
Fri, Oct 30, 2:11 PM

Thu, Oct 29

jptiz added a comment to D12167: Eina value: fix test on Windows.

you can't have a cross-compiled way to use eina_value with long . So i think it would be better to deprecated eina_value with long (imho)

and for 32 bits, int is already tested

Thu, Oct 29, 1:26 PM · efl

Tue, Oct 27

jptiz accepted D12184: evil: undef setlocale to avoid recursion.
Tue, Oct 27, 7:05 AM · efl

Sep 18 2020

jptiz updated the diff for D12151: efreet: make efreet optional.

Better variable naming for deps. Organizing a coulpe of #ifdefs.

Sep 18 2020, 3:15 PM · efl
jptiz updated the diff for D12151: efreet: make efreet optional.

Let efreet enabled by default.

Sep 18 2020, 2:52 PM · efl
jptiz added a comment to D12151: efreet: make efreet optional.

This is really not ideal. A few feature will be broken when porting an EFL apps that use eio/efl_io_model/filemanager to Windows. Isn't it possible to get some of the feature of efreet to work on the platform you are working on?

Sep 18 2020, 1:55 PM · efl
jptiz requested review of D12151: efreet: make efreet optional.
Sep 18 2020, 1:31 PM · efl
jptiz added a revision to T8814: Make efreet optional: D12151: efreet: make efreet optional.
Sep 18 2020, 1:30 PM · Restricted Project, efl

Sep 17 2020

jptiz updated the diff for D12044: build: Drop meson.source_root().

Remove unnecessary message(file) (which was intended for temporary debugging)

Sep 17 2020, 2:26 PM · efl
jptiz reopened T8814: Make efreet optional as "Open".
Sep 17 2020, 1:31 PM · Restricted Project, efl
Herald closed T8814: Make efreet optional as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Sep 17 2020, 1:28 PM · Restricted Project, efl
jptiz added a comment to D12105: eolian_gen: Add support to response files..

This is ready for review again.

Sep 17 2020, 1:22 PM · efl

Sep 16 2020

jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Add a small comment about response_file test.

Sep 16 2020, 10:15 AM · efl

Sep 15 2020

jptiz created T8811: Tests: fail/fail_if/fail_unless are deprecated.
Sep 15 2020, 2:03 PM · Restricted Project

Sep 14 2020

jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Actually execute eolian_gen in _eolian_gen_execute_rsp function.

Sep 14 2020, 12:38 PM · efl

Aug 31 2020

jptiz accepted D12122: ecore_file_can_exec: fix .bat case.
Aug 31 2020, 6:48 AM · efl

Aug 30 2020

jptiz accepted D12118: ecore-file: fix ecore_file_can_exec() on Windows.
Aug 30 2020, 5:13 AM · efl

Aug 27 2020

jptiz added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

the 'return value' section.

I test only if the result is 0 or not.

Ooooh right. So in that case, it would be necessary to split Hi and Lo bits and compare them separately?

why ?

if it's != 0, then I consider (according to the doc) Windows application, MS-DOS .exe or .com files and Console application or .bat file

so all of them

Aug 27 2020, 6:08 AM · efl
jptiz added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

also see https://docs.microsoft.com/en-us/windows/win32/api/shellapi/nf-shellapi-shgetfileinfoa

the 'return value' section.

I test only if the result is 0 or not.
Aug 27 2020, 6:00 AM · efl
jptiz added a comment to D12118: ecore-file: fix ecore_file_can_exec() on Windows.

strange because i've tested on a .bat explicitely. Here the problem is a .sh which is not supported outside a unix shell

Aug 27 2020, 5:58 AM · efl
jptiz accepted D12118: ecore-file: fix ecore_file_can_exec() on Windows.

This patch makes sense for me. Also, since you looked into this part of EFL, I would like to point out: apparently Windows considers only .exe files to be executables (neither .bat or .ps1 or any other file is), so even with SHGetFileInfo, tests like this will fail (as it does even with this patch). I'll open a phab task for this later.

Aug 27 2020, 5:40 AM · efl
jptiz added a reviewer for D12118: ecore-file: fix ecore_file_can_exec() on Windows: lucas.
Aug 27 2020, 4:18 AM · efl
jptiz accepted D12111: Evil: add gettimeofday().
Aug 27 2020, 12:54 AM · efl

Aug 25 2020

jptiz added a parent task for T8795: Native-Windows: `unlink` needs all references to the file to be already closed: T8760: Compile EFL natively on Windows..
Aug 25 2020, 8:08 AM · Windows, efl
jptiz added a subtask for T8760: Compile EFL natively on Windows.: T8795: Native-Windows: `unlink` needs all references to the file to be already closed.
Aug 25 2020, 8:08 AM · Restricted Project, efl
jptiz accepted D12112: Ecore: more precise implementation of ecore_time_get on Windows.

Looking good

Aug 25 2020, 7:24 AM · efl

Aug 24 2020

jptiz added a comment to D12111: Evil: add gettimeofday().

see D12112

Oh right right. I should apply that before this one?

I think the order doesn't matter. But as HAVE_GETTIMEOFDAY was not defined you will need both.

Aug 24 2020, 1:11 PM · efl
jptiz added a comment to D12111: Evil: add gettimeofday().

see D12112

Aug 24 2020, 12:19 PM · efl
jptiz added a comment to D12111: Evil: add gettimeofday().

I've got an error in src/lib/ecore/ecore_time.c:

Aug 24 2020, 12:16 PM · efl
jptiz requested review of D12115: eina: Replace remove with rmdir and delete tmpstr.
Aug 24 2020, 9:57 AM · efl
jptiz updated the summary of D12115: eina: Replace remove with rmdir and delete tmpstr.
Aug 24 2020, 9:55 AM · efl
jptiz updated the test plan for D12115: eina: Replace remove with rmdir and delete tmpstr.
Aug 24 2020, 9:54 AM · efl

Aug 20 2020

jptiz planned changes to D12105: eolian_gen: Add support to response files..

Going to add a response-file test.

Aug 20 2020, 4:30 AM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Fix issue with rsp file path having the same size as final command-line string.

Aug 20 2020, 4:30 AM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Forgot to add int -> size_t changes.

Aug 20 2020, 3:57 AM · efl
jptiz added a comment to D12105: eolian_gen: Add support to response files..

Just my two cents: I think the tests should unconditionally run with the respones files, and not only if PATH_MAX is too small, this way we can ensure that the respone file is tested on any maschine that runs the tests.

Aug 20 2020, 2:00 AM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Fix wrong cherry-pick resolution (i.e. use options again instead of type, which was from another commit that is not on upstream).

Aug 20 2020, 1:42 AM · efl
jptiz added a comment to D12105: eolian_gen: Add support to response files..

Applies now, but shows errors when building:

[1/3252] Compiling C object 'src/bin/eolian/70b716a@@eolian_gen@exe/main.c.o'
../src/bin/eolian/main.c: In function ‘_read_options_from_response_file’:
../src/bin/eolian/main.c:524:22: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  524 |    for (int i = 0; i < file_length; ++i)
      |                      ^
../src/bin/eolian/main.c:543:22: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  543 |    for (int i = 0; i < file_length; ++i)
      |                      ^
../src/bin/eolian/main.c:548:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  548 |              while (i < file_length && contents[i] == '\0')
      |                       ^
../src/bin/eolian/main.c:553:20: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  553 |              if (i >= file_length)
      |                    ^~
Aug 20 2020, 12:44 AM · efl

Aug 19 2020

jptiz added a comment to D12105: eolian_gen: Add support to response files..

This does not apply to latest HEAD anymore, please rebase.

Aug 19 2020, 10:39 AM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Rebase to correct commit

Aug 19 2020, 10:39 AM · efl

Aug 18 2020

jptiz accepted D12108: eet test: use eina_file_mkstemp, fix include for vc++.
Aug 18 2020, 6:56 AM · efl

Aug 17 2020

jptiz accepted D12108: eet test: use eina_file_mkstemp, fix include for vc++.

Looks good to me.

Aug 17 2020, 4:53 PM · efl

Aug 14 2020

jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Inline options initialization.

Aug 14 2020, 9:35 AM · efl
jptiz added inline comments to D12105: eolian_gen: Add support to response files..
Aug 14 2020, 9:27 AM · efl

Aug 12 2020

jptiz requested review of D12106: eina: Use INVALID_FILE_ATTRIBUTES instead of magic number.
Aug 12 2020, 12:23 AM · efl

Aug 11 2020

jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Fixed INVALID_FILE_ATTRIBUTES in the right place.

Aug 11 2020, 2:02 PM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Fix CmdLineOptions case to Cmd_Line_Options and undo
INVALID_FILE_ATTRIBUTES change (which will be splitted into another patch).

Aug 11 2020, 1:58 PM · efl
jptiz added inline comments to D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:53 PM · efl
jptiz updated the diff for D12105: eolian_gen: Add support to response files..

Small enhancement for -r's description in usage

Aug 11 2020, 1:43 PM · efl
jptiz updated the summary of D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:39 PM · efl
jptiz added a task to D12105: eolian_gen: Add support to response files.: T8768: Add option in `eolian_gen` to take parameters from a response file.
Aug 11 2020, 1:39 PM · efl
jptiz added a revision to T8768: Add option in `eolian_gen` to take parameters from a response file: D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:39 PM · Restricted Project, efl
jptiz updated the summary of D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:38 PM · efl
jptiz requested review of D12105: eolian_gen: Add support to response files..
Aug 11 2020, 1:35 PM · efl

Aug 10 2020

jptiz updated the diff for D12103: eet: Fix 'No OPENSSL_Applink' error message..

Remove unused variable FILE *fp.

Aug 10 2020, 4:08 PM · efl
jptiz requested review of D12103: eet: Fix 'No OPENSSL_Applink' error message..
Aug 10 2020, 4:03 PM · efl

Aug 5 2020

jptiz updated the diff for D12095: evil: Remove OS version check.

Change diff to actually remove OS version check completely.

Aug 5 2020, 11:18 PM · efl
jptiz added a comment to D12095: evil: Remove OS version check.

actually, in 2020, i prefer dropping this test... faster evil_init

Aug 5 2020, 11:10 PM · efl
jptiz created T8784: Use `files` for file references..
Aug 5 2020, 10:10 AM · Restricted Project

Aug 4 2020

jptiz updated the diff for D12095: evil: Remove OS version check.

Reorder headers in order to have FORCEINLINE defined in versionhelpers.h

Aug 4 2020, 3:49 PM · efl
jptiz added a parent task for T8768: Add option in `eolian_gen` to take parameters from a response file: T8760: Compile EFL natively on Windows..
Aug 4 2020, 2:34 PM · Restricted Project, efl
jptiz added a subtask for T8760: Compile EFL natively on Windows.: T8768: Add option in `eolian_gen` to take parameters from a response file.
Aug 4 2020, 2:34 PM · Restricted Project, efl
jptiz claimed T8768: Add option in `eolian_gen` to take parameters from a response file.

Working on it.

Aug 4 2020, 2:33 PM · Restricted Project, efl
jptiz updated the summary of D12095: evil: Remove OS version check.
Aug 4 2020, 2:31 PM · efl
jptiz requested review of D12095: evil: Remove OS version check.
Aug 4 2020, 2:30 PM · efl
jptiz added a comment to T8783: eina_file_test: unlink test may fail due to tmpfile is already open.

@vtorri: I did some stub just to let this task open (and not ending up forgetting about it later haha), but there are some infos I don't have (the ones I let with a "?"). If you could provide them (and check if I understood the issue correctly), I would appreciate :)

Aug 4 2020, 1:23 PM · efl
jptiz added a project to T8783: eina_file_test: unlink test may fail due to tmpfile is already open: efl.
Aug 4 2020, 1:21 PM · efl
jptiz created T8783: eina_file_test: unlink test may fail due to tmpfile is already open.
Aug 4 2020, 1:21 PM · efl

Aug 1 2020

jptiz updated the diff for D12062: eina: Close file in unlink test.

Move test_file declaration to function's beginning.

Aug 1 2020, 8:11 AM · efl

Jul 29 2020

jptiz added inline comments to D12062: eina: Close file in unlink test.
Jul 29 2020, 8:41 PM · efl
jptiz added a comment to D12064: evil: Remove unnecessary delay for evil startup.

I am landing this, but you should look into fixing your git commit author

Lucas <Coquinho@users.noreply.github.com>

Missing last name and wrong email.

Jul 29 2020, 1:00 AM · efl

Jul 28 2020

jptiz updated the diff for D12064: evil: Remove unnecessary delay for evil startup.

Fixed a typo on Querry.

Jul 28 2020, 1:26 PM · efl
jptiz updated the diff for D12064: evil: Remove unnecessary delay for evil startup.

No more evil_second.

Jul 28 2020, 1:24 PM · efl
jptiz added a comment to T8751: Coverity issues in CXX bindings, examples and eolian_cxx.

I'll try working on a couple issues this week :)

Jul 28 2020, 9:38 AM

Jul 27 2020

jptiz updated the diff for D12064: evil: Remove unnecessary delay for evil startup.

Put back a call to QueryPerformanceFrequency.

Jul 27 2020, 11:26 AM · efl
jptiz updated the diff for D12064: evil: Remove unnecessary delay for evil startup.
  • Remove st, second and _evil_time_second;
  • Remove unnecessary if (QueryPerformanceFrequency(...)).
Jul 27 2020, 11:25 AM · efl

Jul 25 2020

jptiz updated the summary of D12064: evil: Remove unnecessary delay for evil startup.
Jul 25 2020, 3:55 PM · efl
jptiz retitled D12064: evil: Remove unnecessary delay for evil startup from evil: Remove unnecessary delay for evil startup (#335) to evil: Remove unnecessary delay for evil startup.
Jul 25 2020, 3:54 PM · efl
jptiz requested review of D12064: evil: Remove unnecessary delay for evil startup.
Jul 25 2020, 3:51 PM · efl

Jul 24 2020

jptiz added inline comments to D12062: eina: Close file in unlink test.
Jul 24 2020, 11:36 AM · efl

Jul 21 2020

jptiz requested review of D12062: eina: Close file in unlink test.
Jul 21 2020, 5:16 PM · efl

Jul 6 2020

jptiz requested review of D12044: build: Drop meson.source_root().
Jul 6 2020, 1:51 PM · efl

Jul 1 2020

jptiz closed D11994: Meson.build cleanup..
Jul 1 2020, 1:14 AM · efl

Jun 30 2020

jptiz added a comment to D11994: Meson.build cleanup..

Ok, I think that's it for this patch. Should I squash the commits it or will it be squashed by who lands the patch?

Jun 30 2020, 8:33 PM · efl
jptiz updated the summary of D11994: Meson.build cleanup..
Jun 30 2020, 8:25 PM · efl
jptiz updated the summary of D11994: Meson.build cleanup..
Jun 30 2020, 8:24 PM · efl
jptiz updated the diff for D11994: Meson.build cleanup..

Removed 6 and 8 from this patch, so we stick with just:

Jun 30 2020, 8:22 PM · efl
jptiz added a comment to D11994: Meson.build cleanup..

6: Mhm, -Wall does not find its way into the cflags of the build.ninja file, even if the default warning is 3. That should be fixed.

Jun 30 2020, 8:05 PM · efl
jptiz accepted D12022: windows: Fix path for file sanitization.
Jun 30 2020, 12:29 PM · efl

Jun 29 2020

jptiz added a comment to D12034: build: Use meson subprojects (wrap-dependency) as fallback for dependencies.

Ok, took my time to think of the arguments here. So let me reorganize the ideas...

Jun 29 2020, 4:36 PM · efl
jptiz added a comment to T8761: Standardize external dependency handling.

My mind just messed up some phrases in the last comment. Edited to make more sense :^D.

Jun 29 2020, 2:17 PM · efl