Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (156 w, 6 d)
Availability
Available

Recent Activity

Yesterday

jsuya added a comment to D8427: efl_access: add test cases for reading_info_type_set/get API.

HI, I recommend testing the initial value(maybe 0) in _type_set test , or change tests _type_set and _type_get to _type_set_get.

Wed, Mar 20, 5:50 PM · efl

Mon, Mar 18

jsuya updated the diff for D8399: Evas: Add type convert function for BIDI_Direction_Type..

Remove unneccessary code

Mon, Mar 18, 7:33 PM · efl
jsuya requested review of D8399: Evas: Add type convert function for BIDI_Direction_Type..
Mon, Mar 18, 6:39 PM · efl

Thu, Feb 28

jsuya planned changes to D7975: ector : Support multi mask layer(Add).

need more update.
ans This patch will be split into functional units.

Thu, Feb 28, 4:05 AM · efl
jsuya updated the diff for D7975: ector : Support multi mask layer(Add).

Update the code

Thu, Feb 28, 4:02 AM · efl

Thu, Feb 21

jsuya planned changes to D7975: ector : Support multi mask layer(Add).
Thu, Feb 21, 2:33 AM · efl
jsuya requested review of D7975: ector : Support multi mask layer(Add).
Thu, Feb 21, 2:32 AM · efl

Feb 14 2019

jsuya abandoned D7960: edje : Add zero character '\0' at result of memcpy.
Feb 14 2019, 10:00 PM · efl
jsuya requested review of D7960: edje : Add zero character '\0' at result of memcpy.
Feb 14 2019, 9:53 PM · efl
jsuya abandoned D7959: Remove use of sprintf by using the size..

this patch is not unnecessary.

Feb 14 2019, 9:43 PM · efl
jsuya updated the diff for D7959: Remove use of sprintf by using the size..

fix code

Feb 14 2019, 9:35 PM · efl
jsuya requested review of D7959: Remove use of sprintf by using the size..
Feb 14 2019, 9:16 PM · efl

Feb 7 2019

jsuya updated the diff for D7891: evas json: Load mask property from rlottie..

Add alpha property

Feb 7 2019, 11:43 PM · efl
jsuya updated the diff for D7891: evas json: Load mask property from rlottie..

modify message

Feb 7 2019, 1:09 AM · efl
jsuya requested review of D7891: evas json: Load mask property from rlottie..
Feb 7 2019, 12:55 AM · efl
jsuya requested review of D7890: Efl.Canvas.Vg.Object : Fix unnecessary resize function call..
Feb 7 2019, 12:21 AM · efl

Jan 29 2019

jsuya requested review of D7820: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 29 2019, 3:54 AM · efl
jsuya requested review of D7818: Efl.Ui.Animation_View: Implement Min/Max_Progress/Frame_Set/Get.
Jan 29 2019, 12:33 AM · efl

Jan 28 2019

jsuya abandoned D7813: evas_object_vg: Implement frame_rate_get function..

this function is not neccessary.

Jan 28 2019, 10:58 PM · efl
jsuya added a comment to D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

@segfaultxavi
I agree to change if there is a more correct name.
But I do not think Efl.Gfx.Animation_Controller is correct.

Jan 28 2019, 10:52 PM · efl
jsuya requested review of D7813: evas_object_vg: Implement frame_rate_get function..
Jan 28 2019, 10:42 PM · efl
jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

update docs

Jan 28 2019, 2:36 AM · efl

Jan 27 2019

jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

update code

Jan 27 2019, 11:40 PM · efl
jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

fix mistake

Jan 27 2019, 9:18 PM · efl
jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

remove unneccessary file

Jan 27 2019, 9:09 PM · efl
jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

update commit message

Jan 27 2019, 9:07 PM · efl
jsuya updated the diff for D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.

Update code
Efl.Gfx.Frame_Animation_Controller -> Efl.Gfx.Frame_Controller

Jan 27 2019, 8:58 PM · efl

Jan 24 2019

jsuya requested review of D7769: efl_gfx_image_animation_controller: Rename '*.Image_Animation_*' to '*.Frame_*'.
Jan 24 2019, 11:25 PM · efl
jsuya requested review of D7768: efl_ui_pager : Add missing meson config for pager test..
Jan 24 2019, 10:57 PM · efl

Jan 21 2019

jsuya requested review of D7716: Efl_Ui_Animation : Fix type errors for legacy APIs.
Jan 21 2019, 10:35 PM · efl

Jan 20 2019

jsuya updated the diff for D7668: Elm_Animation_View: Change Elm.Animation_View to Efl.Ui.Animation_View.

I update some docs.
@segfaultxavi
I can't use @Efl.Ui.Animation_View.file_set. it occur to 'failed validating reference' error.
Maybe, eolian docs can't find name of interface method.

Jan 20 2019, 8:39 PM · efl

Jan 17 2019

jsuya requested review of D7668: Elm_Animation_View: Change Elm.Animation_View to Efl.Ui.Animation_View.
Jan 17 2019, 1:54 AM · efl

Jan 15 2019

jsuya updated the diff for D7632: Elm_Animation_View : Change some EAPI to EOAPI.

update commit message

Jan 15 2019, 11:55 PM · efl
jsuya updated the diff for D7632: Elm_Animation_View : Change some EAPI to EOAPI.

update code

Jan 15 2019, 11:53 PM · efl
jsuya requested review of D7632: Elm_Animation_View : Change some EAPI to EOAPI.
Jan 15 2019, 6:22 PM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

update commit's comment

Jan 15 2019, 3:36 AM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

update comment

Jan 15 2019, 3:35 AM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

update code

Jan 15 2019, 3:14 AM · efl
jsuya added inline comments to D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Jan 15 2019, 2:09 AM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

fix typo

Jan 15 2019, 1:34 AM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

update code

Jan 15 2019, 1:32 AM · efl
jsuya updated the diff for D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.

Fix mistake

Jan 15 2019, 12:15 AM · efl
jsuya requested review of D7624: Elm_Animation_View : Add elm_animation_view_frame_set/get apis.
Jan 15 2019, 12:14 AM · efl

Jan 14 2019

jsuya requested review of D7616: Elm_Animation_View: Add elm_animation_view_frame_count_get api.
Jan 14 2019, 1:19 AM · efl

Jan 8 2019

jsuya requested review of D7558: Exactness: Add compress parameter for shot image.
Jan 8 2019, 3:23 AM

Jan 2 2019

jsuya abandoned D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Jan 2 2019, 10:52 PM · efl

Dec 30 2018

jsuya closed T7483: Issues of ea_gen as Resolved.

Most of the issues listed above have been resolved.
If additional issues occur, proceed to the new task.

Dec 30 2018, 9:57 PM
jsuya updated the task description for T7481: Upgrade GUI of ea_gen.
Dec 30 2018, 9:50 PM

Dec 27 2018

jsuya accepted D7499: DB: fix functions random generation.

Thank you :)

Dec 27 2018, 2:02 AM
jsuya closed T7513: Problem about calculating frequency of function in DB. as Resolved.

resolved with D7499

Dec 27 2018, 2:01 AM · regression

Dec 26 2018

jsuya requested review of D7519: GUI: Turn off scroller bounce.
Dec 26 2018, 10:46 PM
jsuya requested review of D7518: Config: Replace some events of classes to 'CLICK' event.
Dec 26 2018, 6:49 PM
jsuya abandoned D7511: GUI: Create ML by selecting widget from DB..

@akanad will make new patch

Dec 26 2018, 2:10 AM
jsuya added inline comments to D7499: DB: fix functions random generation.
Dec 26 2018, 1:46 AM
jsuya requested review of D7511: GUI: Create ML by selecting widget from DB..
Dec 26 2018, 12:08 AM

Dec 23 2018

jsuya added a comment to D7493: Test unit: Add some exu unit temporary..

It is not definitely decided.
But I think we need a repository for exu.
If there are no problems with dir names or filenames, I think I'm ok.
what do you think?

Dec 23 2018, 10:33 PM
jsuya added a comment to D7499: DB: fix functions random generation.

The result of calculation is 0 with type casting.
Eventually, max of the random function becomes -1, causing segfault.

Dec 23 2018, 9:04 PM

Dec 20 2018

jsuya updated the task description for T7513: Problem about calculating frequency of function in DB..
Dec 20 2018, 3:55 AM · regression
jsuya triaged T7513: Problem about calculating frequency of function in DB. as High priority.
Dec 20 2018, 3:55 AM · regression

Dec 19 2018

jsuya updated the summary of D7493: Test unit: Add some exu unit temporary..
Dec 19 2018, 10:22 PM
jsuya requested review of D7493: Test unit: Add some exu unit temporary..
Dec 19 2018, 9:49 PM
jsuya updated the diff for D7472: Player : Copy source exu's code to destination exu.

You are right.
I update the code with your advice.
thank you.

Dec 19 2018, 8:34 PM

Dec 18 2018

jsuya updated the diff for D7472: Player : Copy source exu's code to destination exu.

Fix code

Dec 18 2018, 9:43 PM

Dec 17 2018

jsuya requested review of D7472: Player : Copy source exu's code to destination exu.
Dec 17 2018, 5:51 PM
jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

I changed class name(Efl.Access.Event_Handler->Event_Manager)
because the class name generated by efl.access.* conflicts with
the existing system, eo(base?) class name.

Dec 17 2018, 4:28 PM · efl
jsuya added a comment to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

@bu5hm4n Thank you for your advice.

Dec 17 2018, 4:28 PM · efl

Dec 16 2018

jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

update code

Dec 16 2018, 10:22 PM · efl
jsuya requested review of D7464: Update code after EFL @0d2b624f.
Dec 16 2018, 9:11 PM

Dec 9 2018

jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

Change to class name for build error.

Dec 9 2018, 10:30 PM · efl
jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

update code

Dec 9 2018, 8:21 PM · efl

Dec 7 2018

jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

I update code according to @Jaehyun_Choi.
(I tried that changed the class name to Efl.Access.Events and build it. But same error occured.)

Dec 7 2018, 1:03 AM · efl

Dec 6 2018

jsuya added inline comments to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Dec 6 2018, 1:58 AM · efl
jsuya updated the diff for D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

Update the code according to @kimcinoo feedback.

Dec 6 2018, 1:56 AM · efl
jsuya requested review of D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Dec 6 2018, 12:10 AM · efl

Dec 3 2018

jsuya accepted D7387: DB-SCN: adapt code to Exactness events fix.
Dec 3 2018, 8:41 PM
jsuya accepted D7386: Event: modify the way the events are triggered..
Dec 3 2018, 8:41 PM
jsuya added a comment to T7483: Issues of ea_gen.

there is another some issues

Dec 3 2018, 2:22 AM
jsuya added a comment to D7387: DB-SCN: adapt code to Exactness events fix.

I think EFL_EVENT is necessary.

Dec 3 2018, 12:09 AM

Nov 29 2018

jsuya updated subscribers of D7386: Event: modify the way the events are triggered..
Nov 29 2018, 11:07 PM
jsuya updated subscribers of D7387: DB-SCN: adapt code to Exactness events fix.
Nov 29 2018, 11:07 PM
jsuya added a comment to D7387: DB-SCN: adapt code to Exactness events fix.

@YOhoho is worried about some events being replaced by clicks.
because there may be cases that the event is called directly by callback_call.

Nov 29 2018, 11:06 PM
jsuya added a comment to D7387: DB-SCN: adapt code to Exactness events fix.

Hi thank you for your patch.

Nov 29 2018, 10:50 PM
jsuya added a comment to T7483: Issues of ea_gen.

The issue is solved.
I completely misunderstood this issue. haha....
Thank you :)

Nov 29 2018, 6:48 PM
jsuya accepted D7388: Suite: fix scale issues.

Thank you. The issue is solved.

Nov 29 2018, 6:46 PM
jsuya added a comment to T7483: Issues of ea_gen.

We have issue.
@YOhoho set to scale 1.3 at elementary_config and did test all tests. a lot of test were failed.

Nov 29 2018, 4:37 AM

Nov 28 2018

jsuya updated the task description for T7481: Upgrade GUI of ea_gen.
Nov 28 2018, 11:52 PM
jsuya updated the diff for D7384: GUI: Add language option(ml, c, ...) in preview.

update comment

Nov 28 2018, 11:49 PM
jsuya requested review of D7384: GUI: Add language option(ml, c, ...) in preview.
Nov 28 2018, 11:45 PM
jsuya requested review of D7383: GUI: Add feature that only successful cases are created.
Nov 28 2018, 9:05 PM
jsuya added a parent revision for D7376: GUI: Implement application run at preview: D7358: GUI: update app panel & ML view.
Nov 28 2018, 4:31 AM
jsuya added a child revision for D7358: GUI: update app panel & ML view: D7376: GUI: Implement application run at preview.
Nov 28 2018, 4:31 AM
jsuya updated the task description for T7481: Upgrade GUI of ea_gen.
Nov 28 2018, 4:28 AM
jsuya requested review of D7376: GUI: Implement application run at preview.
Nov 28 2018, 4:23 AM
jsuya updated the diff for D7375: scn_gen : Must have take shot on first time..

update code

Nov 28 2018, 3:05 AM
jsuya requested review of D7375: scn_gen : Must have take shot on first time..
Nov 28 2018, 2:59 AM
jsuya added a parent revision for D7374: GUI: Compare and display generated shot of scenario: D7358: GUI: update app panel & ML view.
Nov 28 2018, 2:50 AM
jsuya added a child revision for D7358: GUI: update app panel & ML view: D7374: GUI: Compare and display generated shot of scenario.
Nov 28 2018, 2:50 AM
jsuya requested review of D7374: GUI: Compare and display generated shot of scenario.
Nov 28 2018, 2:49 AM

Nov 27 2018

jsuya added a comment to T7483: Issues of ea_gen.

4.I agree your opinion.
Now I can't predict what kind of conflict will happen.
But i think this is the best way.

Nov 27 2018, 10:43 PM
jsuya added a comment to T7483: Issues of ea_gen.

5.Yes it is similar.
If test person have some test app code, he should be able to create an exu without reconfigure the app or ML.

Nov 27 2018, 4:55 AM