Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (224 w, 5 m)
Availability
Available

Recent Activity

Wed, Jun 24

jsuya requested review of D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Wed, Jun 24, 8:42 PM · efl

Mon, Jun 22

jsuya updated the test plan for D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Mon, Jun 22, 7:12 PM · efl
jsuya requested review of D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Mon, Jun 22, 7:10 PM · efl

Wed, Jun 17

jsuya requested changes to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

Please check my comment.

Wed, Jun 17, 2:53 AM · efl
jsuya added inline comments to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Wed, Jun 17, 2:52 AM · efl
jsuya added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

In my opinion, if Efl.Ui.Image needs to do the same, I think I can handle this on line 939. Is it only necessary to support legacy?

Wed, Jun 17, 2:47 AM · efl

Mon, Jun 15

jsuya abandoned D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Abandon this patch.
The way to include stroke width in container's path bounds is wrong.
We need an API of separate VG classes that can provide this feature(actual size with stroke width area), not a local function of VG Object.

Mon, Jun 15, 11:23 PM · efl
jsuya added inline comments to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Mon, Jun 15, 7:20 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Update code

Mon, Jun 15, 7:18 PM · efl
jsuya added inline comments to D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Mon, Jun 15, 6:45 PM · efl
jsuya updated the diff for D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Update code

Mon, Jun 15, 6:42 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Add initialization code.

Mon, Jun 15, 6:31 PM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Mon, Jun 15, 3:45 AM · efl
jsuya requested review of D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Mon, Jun 15, 3:19 AM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Mon, Jun 15, 3:09 AM · efl
jsuya requested review of D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Mon, Jun 15, 3:08 AM · efl

Thu, Jun 11

jsuya added a comment to D11967: elc_popup: add null checks for scrollable set/get apis.

It is an eo function. why is it necessary to check null for obj?

Thu, Jun 11, 12:13 AM · efl

Mon, Jun 8

jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

update commit message

Mon, Jun 8, 1:16 AM · efl
jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Update patch

  • add shareable parameter
Mon, Jun 8, 1:12 AM · efl

Sun, Jun 7

jsuya planned changes to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Please ignore my comment. I will update this patch as soon as possible.

Sun, Jun 7, 7:38 PM · efl
jsuya added a comment to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

I think it may be difficult to find or delete the vfd with vp applied as different vfd objects are added to the same key at vg_cache->vfd_hash.

Sun, Jun 7, 7:30 PM · efl

Thu, Jun 4

jsuya requested review of D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Thu, Jun 4, 2:58 AM · efl
jsuya added a child revision for D11929: evas_vg_cache: Add sector_list_get: D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Thu, Jun 4, 2:57 AM · efl

Wed, Jun 3

jsuya requested review of D11929: evas_vg_cache: Add sector_list_get.
Wed, Jun 3, 7:32 PM · efl
jsuya requested review of D11925: Efl.Canvas.Vg.Object: Fix backup size.
Wed, Jun 3, 5:48 PM · efl
jsuya closed D11917: Efl.Gfx.Path: Modify boundary calculation..
Wed, Jun 3, 5:23 PM · efl
jsuya requested review of D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..
Wed, Jun 3, 5:49 AM · efl
jsuya accepted D11923: build: move static out of none_static.
Wed, Jun 3, 5:13 AM · efl
jsuya abandoned D11916: Build: Add json dependency to vg_common.

Yes Thanks :)

Wed, Jun 3, 5:13 AM · efl

Jun 3 2020

jsuya added a comment to D11916: Build: Add json dependency to vg_common.

@bu5hm4n No not used.

Jun 3 2020, 4:36 AM · efl
jsuya added a comment to D11916: Build: Add json dependency to vg_common.

When building with json vg loader enabled, a build error occurred.

/usr/bin/ld: src/tests/evas/6440e44@@evas_suite@exe/.._.._static_libs_vg_common_vg_common_json.c.o: undefined reference to symbol 'lottie_animation_property_override'
/usr/local/lib/x86_64-linux-gnu/librlottie.so.0: error adding symbols: DSO missing from command line
Jun 3 2020, 4:23 AM · efl

Jun 2 2020

jsuya requested review of D11917: Efl.Gfx.Path: Modify boundary calculation..
Jun 2 2020, 11:07 PM · efl
jsuya requested review of D11916: Build: Add json dependency to vg_common.
Jun 2 2020, 10:35 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

Jun 2 2020, 7:33 PM · efl

Jun 1 2020

jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

Jun 1 2020, 10:26 PM · efl
jsuya abandoned D11912: vg_common_svg: Add missing break..

already fixed

Jun 1 2020, 9:19 PM · efl
jsuya requested review of D11912: vg_common_svg: Add missing break..
Jun 1 2020, 9:15 PM · efl
jsuya updated the diff for D11911: elm_hoversel: Add missing resize_job's free.

update comment

Jun 1 2020, 8:15 PM · efl
jsuya updated the diff for D11911: elm_hoversel: Add missing resize_job's free.

Update code

Jun 1 2020, 8:12 PM · efl
jsuya requested review of D11911: elm_hoversel: Add missing resize_job's free.
Jun 1 2020, 7:28 PM · efl

May 31 2020

jsuya updated the diff for D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..

Change enum name Change_flag to flags.

May 31 2020, 7:36 PM · efl

May 28 2020

jsuya accepted D11876: Support WebP Animation Image Files.

LGTM :)

May 28 2020, 3:41 AM · efl

May 27 2020

jsuya requested review of D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..
May 27 2020, 7:20 PM · efl
jsuya added inline comments to D11876: Support WebP Animation Image Files.
May 27 2020, 6:41 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

remove empty space

May 27 2020, 1:24 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

reuse boundary info

May 27 2020, 1:16 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

update code

May 27 2020, 1:01 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code
Refers to the object's viewbox.

May 27 2020, 12:14 AM · efl

May 26 2020

jsuya abandoned D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 26 2020, 2:54 AM · efl

May 25 2020

jsuya planned changes to D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 25 2020, 11:55 PM · efl
jsuya updated the summary of D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 25 2020, 11:24 PM · efl
jsuya requested review of D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 25 2020, 11:23 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

  • If boundary size is 0, don't merge.
  • VG obj's boundary is calculated only when pd->changed is ture.
May 25 2020, 10:26 PM · efl

May 21 2020

jsuya updated the test plan for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 21 2020, 1:30 AM · efl
jsuya requested review of D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 21 2020, 1:28 AM · efl

May 20 2020

jsuya added a comment to T8661: efl_gfx_path: path property.

HI :) I did a little check to solve this.
I understand why you should replace void * with array <> or iterator <>....
However, efl_gfx_path uses the data transmitted as parameters from user side and does not manage path memory separately.
If this is changed, the user who has used the existing API or the legacy API must create and pass the array type data. or legacy path apis manage to array memory.
I think, we are not ready for that yet. The path is used in many places.

May 20 2020, 11:45 PM · efl: rendering, efl: api

May 13 2020

jsuya updated the test plan for D11820: edje_calc: Add unload file for already loaded vector lottie file..
May 13 2020, 5:54 AM · efl
jsuya requested review of D11820: edje_calc: Add unload file for already loaded vector lottie file..
May 13 2020, 5:50 AM · efl

May 12 2020

jsuya accepted D11818: elm: refactor legacy _icon_signal_emit.

I agree. thanks

May 12 2020, 5:24 PM · efl
jsuya updated the diff for D11815: Efl.Canvas.Object.Animation: Prevent crash when called .animation_pause_set..

update comments

May 12 2020, 6:03 AM · efl
jsuya updated the diff for D11815: Efl.Canvas.Object.Animation: Prevent crash when called .animation_pause_set..

I updated code. thanks

May 12 2020, 6:01 AM · efl
jsuya updated the diff for D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.

update test results

May 12 2020, 5:54 AM · efl
jsuya updated the diff for D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.

Update code - use efl_finalized_get

May 12 2020, 5:53 AM · efl
jsuya updated the diff for D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.

I removed speed comparison. There are some improvements, but almost the same speed.

May 12 2020, 5:51 AM · efl
jsuya updated the diff for D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.

Update code - use efl_finalized_get

May 12 2020, 5:49 AM · efl
jsuya updated the diff for D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.

rebase patch

May 12 2020, 5:46 AM · efl
jsuya updated the diff for D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.

I removed speed comparison. There are some improvements, but almost the same speed.

May 12 2020, 5:45 AM · efl
jsuya updated the diff for D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.

test result update

May 12 2020, 5:39 AM · efl
jsuya updated the diff for D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.

update code - use efl_finalized_get

May 12 2020, 5:19 AM · efl
jsuya updated the diff for D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.

Update code - use efl_finalized_get

May 12 2020, 5:17 AM · efl
jsuya requested review of D11815: Efl.Canvas.Object.Animation: Prevent crash when called .animation_pause_set..
May 12 2020, 5:13 AM · efl

May 11 2020

jsuya updated the diff for D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.

update code

May 11 2020, 10:45 PM · efl
jsuya updated the diff for D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.

update code

May 11 2020, 10:42 PM · efl
jsuya updated the diff for D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.

update_code

May 11 2020, 10:39 PM · efl
jsuya requested review of D11813: Efl.Ui.Radio_Legacy: Prevent unnecessary signal emit for contents.
May 11 2020, 10:36 PM · efl
jsuya requested review of D11812: Efl.Ui.Check_Legacy: Prevent unnecessary signal emit for contents.
May 11 2020, 10:26 PM · efl
jsuya updated the diff for D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.

Fix typo

May 11 2020, 10:15 PM · efl
jsuya requested review of D11811: Efl.Ui.Progressbar_Legacy: Prevent unnecessary signal emit for contents.
May 11 2020, 10:13 PM · efl
jsuya requested review of D11810: Efl.Ui.Button_Legacy: Prevent duplicate signal emit of contents.
May 11 2020, 9:51 PM · efl
jsuya closed D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).
May 11 2020, 5:15 PM · efl
jsuya accepted D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).
May 11 2020, 5:12 PM · efl
jsuya updated the diff for D11809: evas_vg_node: deprecate evas_vg_node_geometry_set..

Thank you for review. Update code.

May 11 2020, 12:42 AM · efl

May 10 2020

jsuya updated the diff for D11809: evas_vg_node: deprecate evas_vg_node_geometry_set..

Update code

May 10 2020, 11:07 PM · efl
jsuya requested review of D11809: evas_vg_node: deprecate evas_vg_node_geometry_set..
May 10 2020, 7:06 PM · efl

May 7 2020

jsuya added a comment to D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).

@singh.amitesh ok. I got it. Thanks for comment

May 7 2020, 7:05 PM · efl

May 6 2020

jsuya added a comment to D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).

The code before modification refers to the location information of the object to be searched. However, the modified code does not consider the location information. This can make to compatibility issues.

May 6 2020, 7:01 PM · efl
jsuya requested changes to D11781: efl_canvas_vg_node: fix the implemenation function of the efl_canvas_vg_node(evas_object_above_get, evas_object_below_get).
May 6 2020, 6:55 PM · efl

Apr 27 2020

jsuya updated the test plan for D11758: efl_ui_image: Fix unnecessary unload of memfile_set..
Apr 27 2020, 3:09 AM · efl
jsuya requested review of D11758: efl_ui_image: Fix unnecessary unload of memfile_set..
Apr 27 2020, 3:08 AM · efl

Apr 13 2020

jsuya closed D11692: Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation..
Apr 13 2020, 7:38 PM · efl
jsuya updated the diff for D11692: Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation..

remove space

Apr 13 2020, 5:47 AM · efl
jsuya updated the diff for D11692: Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation..

Update patch.

  • Add checking for composition buffer.
Apr 13 2020, 5:46 AM · efl

Apr 12 2020

jsuya requested review of D11692: Efl.Canvas.Vg.Container: Prevent duplicate transpacency calculation..
Apr 12 2020, 11:22 PM · efl
jsuya accepted D11691: evas text: fix memory leak..

I think this is appropriate.

Apr 12 2020, 10:56 PM · efl
jsuya added a reviewer for D11691: evas text: fix memory leak.: jsuya.
Apr 12 2020, 10:54 PM · efl
jsuya requested review of D11689: Ector: Refer to visibility of Ector_Renderer when doing rle_update..
Apr 12 2020, 8:21 PM · efl

Mar 24 2020

jsuya updated the diff for D11563: elm_transit: Prevent adding duplicates.

DBG->WRN

Mar 24 2020, 5:01 AM · efl
jsuya requested review of D11563: elm_transit: Prevent adding duplicates.
Mar 24 2020, 4:56 AM · efl
jsuya requested review of D11562: elm_transit: replace evas_object_event_callback_xxx with efl_event_callback_xxx.
Mar 24 2020, 4:45 AM · efl
jsuya requested review of D11560: Efl.Ui.Vg_Animation: Enable transit event..
Mar 24 2020, 12:56 AM · efl