Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (182 w, 4 d)
Availability
Available

Recent Activity

Yesterday

jsuya requested review of D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Tue, Sep 17, 5:16 AM · efl

Mon, Sep 16

jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update commit

Mon, Sep 16, 1:00 AM · efl
jsuya added a child revision for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View: D9897: vg_common_json: Override value_provider list.
Mon, Sep 16, 1:00 AM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update message

Mon, Sep 16, 12:52 AM · efl

Tue, Sep 10

jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

update commit message

Tue, Sep 10, 5:42 AM · efl
jsuya requested review of D9897: vg_common_json: Override value_provider list.
Tue, Sep 10, 5:39 AM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

remove unnecessary code

Tue, Sep 10, 4:22 AM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

code update

Tue, Sep 10, 4:20 AM · efl
jsuya closed D9740: evas_vg_cache: Hashkey in cache uses evas.
Tue, Sep 10, 4:09 AM · efl
jsuya updated the diff for D9740: evas_vg_cache: Hashkey in cache uses evas.

update patch

Tue, Sep 10, 4:03 AM · efl
jsuya abandoned D9775: eldbus: Unref remain connections when called eldbus_shutdown.

thank you for comment @zmile

Tue, Sep 10, 1:21 AM · efl
jsuya updated the diff for D9740: evas_vg_cache: Hashkey in cache uses evas.

update patch

Tue, Sep 10, 1:16 AM · efl

Mon, Sep 9

jsuya updated the diff for D9740: evas_vg_cache: Hashkey in cache uses evas.

update commit message

Mon, Sep 9, 10:26 PM · efl
jsuya updated the diff for D9740: evas_vg_cache: Hashkey in cache uses evas.

Change vg object address to evas address in hash key.

Mon, Sep 9, 10:25 PM · efl
jsuya abandoned D9724: efl_canvas_vg_object: Support property change feature.

I created new patch D9874

Mon, Sep 9, 10:08 PM · efl
jsuya abandoned D9743: efl_ui_animation_view: Support property change feature.

I created new patch D9874

Mon, Sep 9, 10:08 PM · efl
jsuya requested review of D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.
Mon, Sep 9, 5:50 AM · efl

Wed, Sep 4

jsuya added a reviewer for D9831: elm/check: fix emission of legacy "changed" callback: akanad.

I think this patch can cause legacy widget compatibility issues. Isn't it?
elementary_test -> check -> Second check button

Wed, Sep 4, 10:28 PM · efl: widgets

Tue, Sep 3

jsuya requested review of D9833: vg_common_svg : Initialize "display" attribute.
Tue, Sep 3, 7:05 PM · efl
jsuya added a comment to D9817: freetype: Prevent lose of data when fixed point divide calculation..

@vtorri
Thank you for your metion.
I modified the commit message and the code.

Tue, Sep 3, 5:54 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

Fix commit message

Tue, Sep 3, 5:54 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

Fix wrong type(unsigned long long-> long long)

Tue, Sep 3, 5:53 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

update commit message

Tue, Sep 3, 4:27 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

update comment

Tue, Sep 3, 4:25 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

update code

Tue, Sep 3, 4:22 AM · efl
jsuya updated the diff for D9817: freetype: Prevent lose of data when fixed point divide calculation..

Update code

Tue, Sep 3, 4:16 AM · efl
jsuya planned changes to D9817: freetype: Prevent lose of data when fixed point divide calculation..
Tue, Sep 3, 3:12 AM · efl
jsuya requested review of D9817: freetype: Prevent lose of data when fixed point divide calculation..
Tue, Sep 3, 3:03 AM · efl

Wed, Aug 28

jsuya added a reviewer for D9775: eldbus: Unref remain connections when called eldbus_shutdown: JongminLee.
Wed, Aug 28, 7:12 PM · efl
jsuya requested review of D9775: eldbus: Unref remain connections when called eldbus_shutdown.
Wed, Aug 28, 7:12 PM · efl

Mon, Aug 26

jsuya updated the diff for D9743: efl_ui_animation_view: Support property change feature.

update commit message

Mon, Aug 26, 5:47 AM · efl
jsuya updated the diff for D9743: efl_ui_animation_view: Support property change feature.

update commit message

Mon, Aug 26, 5:43 AM · efl
jsuya requested review of D9743: efl_ui_animation_view: Support property change feature.
Mon, Aug 26, 5:36 AM · efl
jsuya requested review of D9740: evas_vg_cache: Hashkey in cache uses evas.
Mon, Aug 26, 4:13 AM · efl
jsuya updated the diff for D9724: efl_canvas_vg_object: Support property change feature.

summary update

Mon, Aug 26, 2:28 AM · efl
jsuya updated the diff for D9724: efl_canvas_vg_object: Support property change feature.

code update

Mon, Aug 26, 2:26 AM · efl
jsuya updated the diff for D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..

This just follow the naming rule for legacy naming.
However, there is no need to maintain this because there are no generated legacy apis anymore.
So I changed it to Efl_VG.
(Efl_Canvas_Vg_Object cannot be used by clearing the typedef because of the header call order.)

Mon, Aug 26, 12:43 AM · efl
jsuya requested review of D9738: spinner_cxx_example: Fix use wrong api.
Mon, Aug 26, 12:20 AM · efl

Fri, Aug 23

jsuya planned changes to D9724: efl_canvas_vg_object: Support property change feature.
Fri, Aug 23, 4:37 AM · efl
jsuya requested review of D9724: efl_canvas_vg_object: Support property change feature.
Fri, Aug 23, 4:36 AM · efl
jsuya requested review of D9721: slider_cxx_example: Fix use wrong api.
Fri, Aug 23, 1:55 AM · efl

Thu, Aug 22

jsuya requested review of D9718: efl_canvas_vg_object/evas_object_vg: Change to legacy naming rule..
Thu, Aug 22, 9:43 PM · efl

Wed, Aug 21

jsuya updated the diff for D9665: efl_canvas_vg_shape/ector_software : Set and use stroke miterlimit.

patch rebased

Wed, Aug 21, 8:56 PM · efl
jsuya updated the diff for D9667: edje_cc: Fix always true condition..

@zmike I modified comment and code.
@bu5hm4n Original code is always true condition. Please make sure this modification is suitable for your intention.

Wed, Aug 21, 5:53 PM · efl
jsuya requested review of D9667: edje_cc: Fix always true condition..
Wed, Aug 21, 12:06 AM · efl

Tue, Aug 20

jsuya requested review of D9666: vg_common_json: Support stroke miterlimit.
Tue, Aug 20, 11:25 PM · efl
jsuya requested review of D9665: efl_canvas_vg_shape/ector_software : Set and use stroke miterlimit.
Tue, Aug 20, 11:19 PM · efl
jsuya requested review of D9657: efl_gfx_shape: Add stroke_miterlimit property.
Tue, Aug 20, 10:29 PM · efl
jsuya requested review of D9656: ector_software_rasterizer: Change default value of stroke linejoin.
Tue, Aug 20, 10:06 PM · efl

Mon, Aug 19

jsuya requested review of D9640: evas_vg_load_svg: Support "display" attribute..
Mon, Aug 19, 11:37 PM · efl

Aug 19 2019

jsuya requested review of D9620: vg_common_svg: Apply node opacity to stroke color.
Aug 19 2019, 3:03 AM · efl

Aug 5 2019

jsuya updated the diff for D9472: elementary_test: Add the animation view test.

modify comment

Aug 5 2019, 9:17 PM · efl

Aug 4 2019

jsuya updated the diff for D9472: elementary_test: Add the animation view test.

update patch
@zmike thank you for your review.

Aug 4 2019, 11:55 PM · efl
jsuya requested review of D9492: ector_software_rasterizer: Add default value for stroke's miter_limit.
Aug 4 2019, 11:17 PM · efl

Aug 1 2019

jsuya updated the diff for D9472: elementary_test: Add the animation view test.

more update

Aug 1 2019, 6:37 PM · efl
jsuya updated the diff for D9472: elementary_test: Add the animation view test.

Change legacy apis to efl_ui apis.

Aug 1 2019, 6:33 PM · efl
jsuya updated the diff for D9472: elementary_test: Add the animation view test.

update summary

Aug 1 2019, 5:05 AM · efl
jsuya updated the diff for D9472: elementary_test: Add the animation view test.

Add code to output svg if Evas Vg Json(Lottie) Loader is not supported.

Aug 1 2019, 5:03 AM · efl
jsuya requested review of D9472: elementary_test: Add the animation view test.
Aug 1 2019, 3:25 AM · efl

Jul 25 2019

jsuya updated the diff for D9390: ector: Prevent access to NULL buffer in software rasterizer.

update code

Jul 25 2019, 12:54 AM · efl
jsuya requested review of D9390: ector: Prevent access to NULL buffer in software rasterizer.
Jul 25 2019, 12:50 AM · efl

Jul 23 2019

jsuya abandoned D9379: meson: Enable json of evas_loader.
Jul 23 2019, 1:03 AM · efl
jsuya requested review of D9379: meson: Enable json of evas_loader.
Jul 23 2019, 12:58 AM · efl

Jul 17 2019

jsuya updated the diff for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

remove unnecessary code

Jul 17 2019, 11:23 PM · efl
jsuya requested review of D9351: evas_vg_json: Add image embedded example.
Jul 17 2019, 11:08 PM · efl
jsuya added a child revision for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class: D9351: evas_vg_json: Add image embedded example.
Jul 17 2019, 11:08 PM · efl
jsuya updated the diff for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

update code

Jul 17 2019, 7:12 PM · efl
jsuya updated the diff for D9220: vg_common_json : Support image data of node.

update code

Jul 17 2019, 7:09 PM · efl
jsuya updated the diff for D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.

Fix wrong comments and change the Ector.Buffer
to be created and managed when the image data pointer is received.

Jul 17 2019, 7:08 PM · efl
jsuya updated the diff for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.

Update code that using Ector.Buffer

Jul 17 2019, 7:00 PM · efl
jsuya updated the diff for D9338: vg_common_svg: Gradient stop color use premultiplied color..

commit message update

Jul 17 2019, 1:14 AM · efl
jsuya updated the diff for D9338: vg_common_svg: Gradient stop color use premultiplied color..

code update

Jul 17 2019, 1:13 AM · efl

Jul 16 2019

jsuya requested review of D9338: vg_common_svg: Gradient stop color use premultiplied color..
Jul 16 2019, 10:04 PM · efl

Jul 15 2019

jsuya updated the diff for D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

update commit message

Jul 15 2019, 4:21 AM · efl
jsuya updated the diff for D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

add test sample in src/example/edje

Jul 15 2019, 4:14 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

@Hermet
Update patch
src/examples/edje/svg.edc (radialGrad1.svg) is work well
i added missing code.
this patch is same 5403af9.

Jul 15 2019, 3:53 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

update commit title

Jul 15 2019, 1:13 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

update patch

Jul 15 2019, 1:12 AM · efl
jsuya requested review of D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Jul 15 2019, 12:27 AM · efl

Jul 14 2019

jsuya requested review of D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Jul 14 2019, 6:59 PM · efl

Jul 8 2019

jsuya requested review of D9235: Ector.Renderer: Prevent too many unref..
Jul 8 2019, 1:16 AM · efl

Jul 7 2019

jsuya added a parent revision for D9220: vg_common_json : Support image data of node: D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Jul 7 2019, 7:23 PM · efl
jsuya added a child revision for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class: D9220: vg_common_json : Support image data of node.
Jul 7 2019, 7:23 PM · efl
jsuya requested review of D9220: vg_common_json : Support image data of node.
Jul 7 2019, 7:22 PM · efl
jsuya requested review of D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Jul 7 2019, 7:20 PM · efl
jsuya added a child revision for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class: D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Jul 7 2019, 7:20 PM · efl
jsuya requested review of D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Jul 7 2019, 7:14 PM · efl
jsuya abandoned D9203: ector_software_rasterizer: Use a premultiplied color..
Jul 7 2019, 6:53 PM · efl
jsuya requested review of D9217: efl_gfx_shape: Stroke color use a premultiplied color..
Jul 7 2019, 6:53 PM · efl
jsuya requested review of D9216: vg_common_json: Always set the alpha color of the container..
Jul 7 2019, 6:41 PM · efl

Jun 28 2019

jsuya requested review of D9203: ector_software_rasterizer: Use a premultiplied color..
Jun 28 2019, 3:33 AM · efl

Jun 19 2019

jsuya added inline comments to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 19 2019, 9:48 PM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Fix wrong condition and change member name.

Jun 19 2019, 9:42 PM · efl

Jun 13 2019

jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Modify the buffer to reuse when the layer has transparency.

Jun 13 2019, 11:58 PM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

add TODO comments

Jun 13 2019, 11:07 PM · efl
jsuya added inline comments to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 13 2019, 12:45 AM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update code
-modify coordinate calculation in draw_image

Jun 13 2019, 12:32 AM · efl

Jun 12 2019

jsuya added inline comments to D9083: efl_canvas_vg_container: Initialize alpha color.
Jun 12 2019, 9:19 PM · efl
jsuya updated the diff for D9083: efl_canvas_vg_container: Initialize alpha color.

fix typo

Jun 12 2019, 12:01 AM · efl

Jun 11 2019

jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update code
change function name and use Ector.Buffer

Jun 11 2019, 11:53 PM · efl