Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (279 w, 15 h)
Availability
Available

Recent Activity

Jun 17 2021

jsuya updated the diff for D12284: evas_vg_load_svg: Fix color parsing.

rebase

Jun 17 2021, 7:40 PM · efl
jsuya updated the diff for D12284: evas_vg_load_svg: Fix color parsing.

fix typo

Jun 17 2021, 7:39 PM · efl
jsuya updated the test plan for D12284: evas_vg_load_svg: Fix color parsing.
Jun 17 2021, 7:32 PM · efl
jsuya requested review of D12284: evas_vg_load_svg: Fix color parsing.
Jun 17 2021, 7:30 PM · efl

May 24 2021

jsuya abandoned D12278: eet_data: Prevent uninitialized pointer read.

Hi you are right. haha..
This change has already been fixed in D12279 So I'll abandon this.

May 24 2021, 1:43 AM · efl

May 23 2021

jsuya requested review of D12278: eet_data: Prevent uninitialized pointer read.
May 23 2021, 11:57 PM · efl

Mar 18 2021

jsuya closed D12251: ector image: Prevents drawing images outside buffer.
Mar 18 2021, 1:11 AM · efl

Mar 17 2021

jsuya requested review of D12251: ector image: Prevents drawing images outside buffer.
Mar 17 2021, 7:19 PM · efl

Feb 3 2021

jsuya accepted D12241: edje_entry: fix a potential error of null deref.
Feb 3 2021, 5:59 PM · efl

Jan 31 2021

jsuya closed D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.
Jan 31 2021, 5:01 PM · efl

Jan 28 2021

jsuya added a comment to D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.

@devilhorns Hi. Maybe.. you are right. Not changed, No need to render. I think so too. When the _efl_canvas_vg_object_render function starts, if pd->changed is false, it seems that render can be skipped. But I'm not sure if I can apply that code right now...

Jan 28 2021, 1:57 AM · efl

Jan 27 2021

jsuya updated the diff for D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.

update code

Jan 27 2021, 10:54 PM · efl
jsuya added a comment to D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.

I update a patch. thanks

Jan 27 2021, 9:54 PM · efl
jsuya updated the diff for D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.

Recover check "changed"

Jan 27 2021, 9:53 PM · efl
jsuya requested review of D12235: Efl.Canvas.Vg.Object: Skip render, if size of the drawing area is 0.
Jan 27 2021, 7:44 PM · efl
jsuya planned changes to D12234: Efl.Canvas.Vg.Object: Change to cache_drop when vg object is changed.
Jan 27 2021, 1:08 AM · efl
jsuya requested review of D12234: Efl.Canvas.Vg.Object: Change to cache_drop when vg object is changed.
Jan 27 2021, 12:23 AM · efl

Dec 15 2020

jsuya updated the test plan for D12215: edje_data: Add missing descriptor for image.max(min).limit.
Dec 15 2020, 8:52 PM · efl
jsuya requested review of D12215: edje_data: Add missing descriptor for image.max(min).limit.
Dec 15 2020, 8:39 PM · efl

Dec 14 2020

jsuya requested review of D12213: evas: Prevent null pointer access.
Dec 14 2020, 9:00 PM · efl

Dec 1 2020

jsuya abandoned D12199: vg_common_json: Fix build error.

It's my fault. My repo was not latest.
Thank you for check.

Dec 1 2020, 11:43 PM · efl
jsuya requested review of D12199: vg_common_json: Fix build error.
Dec 1 2020, 8:59 PM · efl

Nov 23 2020

jsuya added a comment to D12194: ui transit: improve zoom effect smoothness by subpixel rendering..

I have a question. In the case of _transit_effect_rotation_op, is anti_alias not necessary?

Nov 23 2020, 8:43 PM · efl

Nov 18 2020

jsuya added inline comments to D12192: evas gl: make 9 patch work.
Nov 18 2020, 4:56 PM · efl

Nov 16 2020

jsuya abandoned D12191: elm_hoversel: Fix spacer size calculation.

This can avoid unnecessary calculations, but it does not affect what is actually represented. Therefore, it should be abandon.

Nov 16 2020, 2:02 AM · efl
jsuya updated the diff for D12191: elm_hoversel: Fix spacer size calculation.

fix code

Nov 16 2020, 12:55 AM · efl
jsuya requested review of D12191: elm_hoversel: Fix spacer size calculation.
Nov 16 2020, 12:51 AM · efl

Oct 30 2020

jsuya requested review of D12185: vg_load_svg: Prevent memory overflow for tag_name.
Oct 30 2020, 3:07 AM · efl

Oct 13 2020

jsuya updated the diff for D12179: vg_load_svg: Implement ClipPath feature.

modify code

Oct 13 2020, 7:07 PM · efl
jsuya updated the test plan for D12179: vg_load_svg: Implement ClipPath feature.
Oct 13 2020, 7:05 PM · efl
jsuya requested review of D12179: vg_load_svg: Implement ClipPath feature.
Oct 13 2020, 7:04 PM · efl

Oct 11 2020

jsuya requested review of D12174: vg_load_svg: Add points copy of missing polygon/polyline.
Oct 11 2020, 10:02 PM · efl

Sep 21 2020

jsuya requested review of D12158: efl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m).
Sep 21 2020, 10:44 PM · efl

Sep 14 2020

jsuya requested review of D12146: vg_load_svg: Support dasharray attribute for stroke.
Sep 14 2020, 7:27 PM · efl

Sep 10 2020

jsuya added a comment to D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

@Hermet I have updated the patch. Please review again.

Sep 10 2020, 9:54 PM · efl
jsuya updated the diff for D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

Update commit comment

Sep 10 2020, 9:53 PM · efl
jsuya updated the diff for D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

Patch update

  • It doesn't traverse every frame. In render_pre, check the container's alpha and set flag to sync_render of VG object's data.
Sep 10 2020, 9:52 PM · efl
jsuya added inline comments to D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Sep 10 2020, 8:30 PM · efl
jsuya requested review of D12141: Efl.Canvas.Vg.Object: Fix typo.
Sep 10 2020, 7:42 PM · efl
jsuya requested review of D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Sep 10 2020, 7:41 PM · efl
jsuya requested review of D12139: vg_load_svg: Add Mask, ClipPath nodees as dummy..
Sep 10 2020, 7:40 PM · efl
jsuya requested review of D12138: vg_load_svg: Fix missing loader.gradients update.
Sep 10 2020, 7:40 PM · efl

Sep 9 2020

jsuya requested review of D12137: vg_load_svg: Supports case when only rx or ry is declared.
Sep 9 2020, 6:57 PM · efl

Sep 3 2020

jsuya updated the diff for D12129: vg_load_svg: Fix pointing to wrong parent.

Update comment

Sep 3 2020, 6:26 PM · efl
jsuya updated the diff for D12129: vg_load_svg: Fix pointing to wrong parent.

Update patch

Sep 3 2020, 6:25 PM · efl
jsuya requested review of D12129: vg_load_svg: Fix pointing to wrong parent.
Sep 3 2020, 1:24 AM · efl

Sep 2 2020

jsuya requested review of D12127: SvgLoader: Defs type nodes are not saved in loader's node list..
Sep 2 2020, 1:20 AM · efl

Aug 5 2020

jsuya closed D12092: elm_access: fix a potentional error of null deref.
Aug 5 2020, 1:03 AM · efl
jsuya closed D12091: evas/engine: fix a potentional error of null deref.
Aug 5 2020, 1:02 AM · efl
jsuya accepted D12092: elm_access: fix a potentional error of null deref.

Ok I understand this. Thank you for review :)

Aug 5 2020, 1:01 AM · efl
jsuya accepted D12091: evas/engine: fix a potentional error of null deref.

Looks good to me thanks

Aug 5 2020, 12:41 AM · efl

Aug 4 2020

jsuya requested changes to D12092: elm_access: fix a potentional error of null deref.

If there is no target (info's next or prev), elm_access finds the target once again in the focus_relation (539 line).
(I think previous diff is right.)
@kimcinoo Please check this change.

Aug 4 2020, 11:52 PM · efl
jsuya requested changes to D12091: evas/engine: fix a potentional error of null deref.

I think, If evas_cache_image_data for im2 is fail, you should be returned function before freeing "im" and dropping the image.

Aug 4 2020, 11:29 PM · efl
jsuya closed D12086: edje: fix a potentional error of null deref.
Aug 4 2020, 11:19 PM · efl
jsuya accepted D12086: edje: fix a potentional error of null deref.

Looks good to me

Aug 4 2020, 11:18 PM · efl
jsuya closed D12090: edje_edit: fix a potentional error of null deref.
Aug 4 2020, 11:16 PM · efl
jsuya closed D12094: edje_edit: add null check for return of eina_hash_find.
Aug 4 2020, 11:10 PM · efl
jsuya accepted D12094: edje_edit: add null check for return of eina_hash_find.

I agree

Aug 4 2020, 10:37 PM · efl
jsuya added a reviewer for D12094: edje_edit: add null check for return of eina_hash_find: jsuya.
Aug 4 2020, 10:36 PM · efl
jsuya accepted D12074: embryo_cc: ++safty code.

I agree this change

Aug 4 2020, 10:20 PM · efl
jsuya accepted D12090: edje_edit: fix a potentional error of null deref.

Looks good to me

Aug 4 2020, 9:29 PM · efl
jsuya requested changes to D12091: evas/engine: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 9:25 PM · efl
jsuya added a comment to D12084: evas_filter: Add null check for instruction.

@kimcinoo You are right. Thanks :) I updated patch.

Aug 4 2020, 8:31 PM · efl
jsuya updated the diff for D12084: evas_filter: Add null check for instruction.

Update patch

Aug 4 2020, 8:30 PM · efl
jsuya closed D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 5:53 AM · efl
jsuya added inline comments to D12090: edje_edit: fix a potentional error of null deref.
Aug 4 2020, 5:05 AM · efl
jsuya added reviewers for D12090: edje_edit: fix a potentional error of null deref: bu5hm4n, cedric, Hermet.
Aug 4 2020, 5:04 AM · efl
jsuya requested changes to D12090: edje_edit: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 5:04 AM · efl
jsuya added reviewers for D12086: edje: fix a potentional error of null deref: bu5hm4n, Hermet.
Aug 4 2020, 5:00 AM · efl
jsuya requested changes to D12086: edje: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 5:00 AM · efl
jsuya updated the diff for D12085: efl_ui_timepicker: Add null check for efl_text_get.

replaced by eina_streq. thank you for reivew

Aug 4 2020, 4:44 AM · efl
jsuya requested review of D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 1:17 AM · efl
jsuya requested review of D12084: evas_filter: Add null check for instruction.
Aug 4 2020, 12:41 AM · efl

Jul 29 2020

jsuya planned changes to D11929: evas_vg_cache: Add sector_list_get.
Jul 29 2020, 7:04 PM · efl
jsuya updated the diff for D11929: evas_vg_cache: Add sector_list_get.

rebase patch
(This patch is for testing. don't merge)

Jul 29 2020, 7:03 PM · efl

Jul 16 2020

jsuya planned changes to D11929: evas_vg_cache: Add sector_list_get.
Jul 16 2020, 11:42 PM · efl
jsuya planned changes to D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jul 16 2020, 11:42 PM · efl

Jun 24 2020

jsuya requested review of D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 8:42 PM · efl

Jun 22 2020

jsuya updated the test plan for D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 7:12 PM · efl
jsuya requested review of D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 7:10 PM · efl

Jun 17 2020

jsuya requested changes to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

Please check my comment.

Jun 17 2020, 2:53 AM · efl
jsuya added inline comments to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 2:52 AM · efl
jsuya added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

In my opinion, if Efl.Ui.Image needs to do the same, I think I can handle this on line 939. Is it only necessary to support legacy?

Jun 17 2020, 2:47 AM · efl

Jun 15 2020

jsuya abandoned D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Abandon this patch.
The way to include stroke width in container's path bounds is wrong.
We need an API of separate VG classes that can provide this feature(actual size with stroke width area), not a local function of VG Object.

Jun 15 2020, 11:23 PM · efl
jsuya added inline comments to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 7:20 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Update code

Jun 15 2020, 7:18 PM · efl
jsuya added inline comments to D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Jun 15 2020, 6:45 PM · efl
jsuya updated the diff for D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Update code

Jun 15 2020, 6:42 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Add initialization code.

Jun 15 2020, 6:31 PM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:45 AM · efl
jsuya requested review of D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Jun 15 2020, 3:19 AM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:09 AM · efl
jsuya requested review of D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:08 AM · efl

Jun 11 2020

jsuya added a comment to D11967: elc_popup: add null checks for scrollable set/get apis.

It is an eo function. why is it necessary to check null for obj?

Jun 11 2020, 12:13 AM · efl

Jun 8 2020

jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

update commit message

Jun 8 2020, 1:16 AM · efl
jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Update patch

  • add shareable parameter
Jun 8 2020, 1:12 AM · efl

Jun 7 2020

jsuya planned changes to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Please ignore my comment. I will update this patch as soon as possible.

Jun 7 2020, 7:38 PM · efl
jsuya added a comment to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

I think it may be difficult to find or delete the vfd with vp applied as different vfd objects are added to the same key at vg_cache->vfd_hash.

Jun 7 2020, 7:30 PM · efl

Jun 4 2020

jsuya requested review of D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jun 4 2020, 2:58 AM · efl
jsuya added a child revision for D11929: evas_vg_cache: Add sector_list_get: D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jun 4 2020, 2:57 AM · efl