Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (165 w, 3 d)
Availability
Available

Recent Activity

Thu, May 16

jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

add comments

Thu, May 16, 6:42 PM · efl
jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

update commit message

Thu, May 16, 6:10 PM · efl
jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

update code

Thu, May 16, 6:08 PM · efl

Tue, May 14

jsuya requested review of D8895: evas_vg_node: Move change flag value setting.
Tue, May 14, 9:24 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

Tue, May 14, 5:51 PM · efl

Mon, May 13

jsuya added inline comments to D8873: ector_software_rasterizer: Improved masking calculation..
Mon, May 13, 6:58 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

Code update
change floating operation to bitwise operation.
and
change single for loop to double for loop.(remove mod and divide calc)

Mon, May 13, 6:57 PM · efl

Thu, May 9

jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

Thu, May 9, 11:30 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

Thu, May 9, 9:10 PM · efl
jsuya requested review of D8873: ector_software_rasterizer: Improved masking calculation..
Thu, May 9, 9:01 PM · efl
jsuya updated the diff for D8869: ector_software_rasterizer : Move duplicate alloca.

change branch

Thu, May 9, 12:53 AM · efl
jsuya requested review of D8869: ector_software_rasterizer : Move duplicate alloca.
Thu, May 9, 12:49 AM · efl
jsuya abandoned D8857: ector_software_rasterizer: Remove alloca function..

It is wrong that BUFFER_SIZE is 2k. I think it's fine if it's a small buffer as appropriate.
Probably 1~255. or half of width.
The crash problem is solved by a little bit more change.
But I will abandon this revision.

Thu, May 9, 12:19 AM · efl

Wed, May 8

jsuya requested review of D8857: ector_software_rasterizer: Remove alloca function..
Wed, May 8, 1:03 AM · efl

Tue, May 7

jsuya requested review of D8855: ector_software_rasterizer: Support gradient mask blending.
Tue, May 7, 10:46 PM · efl

Wed, May 1

jsuya updated the diff for D8802: efl_ui_animation_view: Set max progress when play back..

update code

Wed, May 1, 11:31 PM · efl
jsuya requested review of D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
Wed, May 1, 11:23 PM · efl
jsuya requested review of D8802: efl_ui_animation_view: Set max progress when play back..
Wed, May 1, 11:22 PM · efl
jsuya planned changes to D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
Wed, May 1, 9:26 PM · efl
jsuya requested review of D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
Wed, May 1, 9:06 PM · efl

Fri, Apr 26

jsuya added a comment to D8718: efl_ui_animation_view : Change transit facade sequence..

Compile with: gcc -o animation_view_example animation_view_example.c -g pkg-config --cflags --libs elementary`

Fri, Apr 26, 12:44 AM · efl
jsuya requested review of D8718: efl_ui_animation_view : Change transit facade sequence..
Fri, Apr 26, 12:44 AM · efl

Thu, Apr 25

jsuya updated the diff for D8715: efl_ui_animation_view: Update callback is called only actual change time..

update comment

Thu, Apr 25, 10:41 PM · efl
jsuya requested review of D8716: efl_ui_animation_view: Fix current frame calc..
Thu, Apr 25, 10:22 PM · efl
jsuya requested review of D8715: efl_ui_animation_view: Update callback is called only actual change time..
Thu, Apr 25, 10:17 PM · efl
jsuya updated the diff for D8709: vg_common_json: Support mask with matte case..

update commit

Thu, Apr 25, 5:56 PM · efl
jsuya added inline comments to D8709: vg_common_json: Support mask with matte case..
Thu, Apr 25, 5:56 PM · efl
jsuya closed D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Thu, Apr 25, 1:02 AM · efl
jsuya requested review of D8711: efl_ui_animation_view: Remove docs in set/get..
Thu, Apr 25, 12:24 AM · efl

Wed, Apr 24

jsuya added a reviewer for D8710: README, doc : Fix typo: kimcinoo.
Wed, Apr 24, 11:57 PM · efl
jsuya requested review of D8710: README, doc : Fix typo.
Wed, Apr 24, 11:57 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

@segfaultxavi
This patch has been merged into devs/hermet/lottie branch before updating the fix you requested.
I will update your request with new patches.

Wed, Apr 24, 11:43 PM · efl
jsuya requested review of D8709: vg_common_json: Support mask with matte case..
Wed, Apr 24, 11:27 PM · efl
jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Remove all docs of set/get

Wed, Apr 24, 6:39 PM · efl

Tue, Apr 23

jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

undo wrong modify

Tue, Apr 23, 7:11 PM · efl
jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Update docs

Tue, Apr 23, 7:07 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Hi @segfaultxavi
This patch is working on devs/hermet/lottie branch.
@Hermet is preparing features related to this patch.

Tue, Apr 23, 7:07 PM · efl

Mon, Apr 22

jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Add more docs

Mon, Apr 22, 6:40 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Ok i will do that. :)

Mon, Apr 22, 6:40 PM · efl
jsuya requested review of D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Mon, Apr 22, 1:16 AM · efl

Sun, Apr 21

jsuya requested review of D8674: efl_ui_animation_view: Fix cmake build error.
Sun, Apr 21, 6:59 PM · efl

Apr 18 2019

jsuya updated the diff for D8663: vg_common_svg : Implement gradientTransform property of linearGradient.

update code

Apr 18 2019, 11:01 PM · efl
jsuya updated the diff for D8663: vg_common_svg : Implement gradientTransform property of linearGradient.

update code

Apr 18 2019, 9:47 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

update commit message

Apr 18 2019, 9:39 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

remove unnecessary values

Apr 18 2019, 9:38 PM · efl
jsuya added a parent revision for D8663: vg_common_svg : Implement gradientTransform property of linearGradient: D8662: vg_common_svg: Prevent duplicate operations for percentage value.
Apr 18 2019, 7:08 PM · efl
jsuya added a child revision for D8662: vg_common_svg: Prevent duplicate operations for percentage value: D8663: vg_common_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 7:08 PM · efl
jsuya requested review of D8663: vg_common_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 7:08 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

update code

Apr 18 2019, 6:57 PM · efl
jsuya abandoned D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 6:53 PM · efl
jsuya abandoned D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 18 2019, 6:53 PM · efl
jsuya abandoned D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.
Apr 18 2019, 6:53 PM · efl
jsuya requested review of D8662: vg_common_svg: Prevent duplicate operations for percentage value.
Apr 18 2019, 6:52 PM · efl

Apr 17 2019

jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

fix typo

Apr 17 2019, 6:18 PM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

modify code

Apr 17 2019, 6:17 PM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

update code :)

Apr 17 2019, 12:12 AM · efl
jsuya added inline comments to D8507: vg_json: Set multiple mask from json.
Apr 17 2019, 12:11 AM · efl

Apr 16 2019

jsuya added a comment to D8624: vg_load_svg : Implement gradientTransform property of linearGradient.

i attached test file.

Apr 16 2019, 10:10 PM · efl
jsuya added parent revisions for D8624: vg_load_svg : Implement gradientTransform property of linearGradient: D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface, D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 16 2019, 10:05 PM · efl
jsuya added a child revision for D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader: D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:04 PM · efl
jsuya added a child revision for D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface: D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:04 PM · efl
jsuya requested review of D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:03 PM · efl
jsuya added a comment to D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.

thank you for review

Apr 16 2019, 7:36 PM · efl
jsuya requested review of D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 16 2019, 7:28 PM · efl
jsuya updated the diff for D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.

Update code :)

Apr 16 2019, 7:27 PM · efl

Apr 11 2019

jsuya planned changes to D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 11 2019, 1:13 AM · efl
jsuya planned changes to D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.
Apr 11 2019, 1:13 AM · efl
jsuya requested review of D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 11 2019, 1:04 AM · efl
jsuya requested review of D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.
Apr 11 2019, 12:17 AM · efl
jsuya updated the diff for D8591: svg_parse: Support gradient when <defs/> is not declared..

update code

Apr 11 2019, 12:13 AM · efl

Apr 10 2019

jsuya requested review of D8594: vg_common_svg : Add missing eet data descriptor.
Apr 10 2019, 10:26 PM · efl
jsuya updated the diff for D8591: svg_parse: Support gradient when <defs/> is not declared..

update code that apply @Hermet's comments

Apr 10 2019, 4:54 AM · efl
jsuya added a comment to D8591: svg_parse: Support gradient when <defs/> is not declared..

i will update :)

Apr 10 2019, 4:53 AM · efl
jsuya requested review of D8591: svg_parse: Support gradient when <defs/> is not declared..
Apr 10 2019, 12:15 AM · efl

Apr 9 2019

jsuya requested review of D8590: svg_parse: The percentage gradient value divide by view's size.
Apr 9 2019, 11:39 PM · efl
jsuya updated the diff for D8589: svg_parse: Change initial value of gradientUnits of linearGradient.

fix build break

Apr 9 2019, 11:22 PM · efl
jsuya updated the diff for D8589: svg_parse: Change initial value of gradientUnits of linearGradient.

remove unnecessary members

Apr 9 2019, 10:29 PM · efl
jsuya requested review of D8589: svg_parse: Change initial value of gradientUnits of linearGradient.
Apr 9 2019, 10:25 PM · efl

Apr 4 2019

jsuya abandoned D7493: Test unit: Add some exu unit temporary..
Apr 4 2019, 11:16 PM
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

update code

Apr 4 2019, 11:13 PM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

remove unnecessary code

Apr 4 2019, 11:11 PM · efl
jsuya abandoned D7975: ector : Support multi mask layer(Add).
Apr 4 2019, 9:26 PM · efl
jsuya updated the diff for D8517: efl_canvas_vg_container : Support mask tree for multiple mask..

update code

Apr 4 2019, 9:25 PM · efl
jsuya added inline comments to D8517: efl_canvas_vg_container : Support mask tree for multiple mask..
Apr 4 2019, 9:24 PM · efl
jsuya updated the diff for D8509: ector_software_rasterizer: Implement mask blending function..

update code

Apr 4 2019, 7:29 PM · efl

Apr 2 2019

jsuya updated the diff for D8517: efl_canvas_vg_container : Support mask tree for multiple mask..

modify wrong code

Apr 2 2019, 11:42 PM · efl
jsuya updated the diff for D8517: efl_canvas_vg_container : Support mask tree for multiple mask..

Update code

Apr 2 2019, 11:40 PM · efl
jsuya added a reviewer for D8544: elm_entry: prevent from accessing null pointer: woohyun.
Apr 2 2019, 9:25 PM · efl
jsuya requested review of D8544: elm_entry: prevent from accessing null pointer.
Apr 2 2019, 9:24 PM · efl
jsuya abandoned D8534: jsuya : upload my info and key.
Apr 2 2019, 4:54 AM
jsuya requested review of D8534: jsuya : upload my info and key.
Apr 2 2019, 4:50 AM
jsuya updated the diff for D8509: ector_software_rasterizer: Implement mask blending function..

fix wrong update

Apr 2 2019, 4:11 AM · efl
jsuya updated the diff for D8509: ector_software_rasterizer: Implement mask blending function..

update commit

Apr 2 2019, 4:09 AM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

update commit

Apr 2 2019, 3:55 AM · efl
jsuya updated the diff for D8517: efl_canvas_vg_container : Support mask tree for multiple mask..

@Hermet
When mask is set, _prepare_mask is only called once in the draw container(real draw object)'s render_pre.
If container has a mask and this container is not a mask for another container,
then this container is a draw container(real draw object).
If i remove !pd->mask.target and add a level value,
the level will always be zero unless i get the level value from render_pre.
i think, adding an argument to render_pre is not a good idea.
All functions that overload _evas_vg_render_pre must be modified.

Apr 2 2019, 3:44 AM · efl

Apr 1 2019

jsuya updated the diff for D8517: efl_canvas_vg_container : Support mask tree for multiple mask..

update summary

Apr 1 2019, 12:33 AM · efl
jsuya abandoned D8508: efl_canvas_vg_container : Support mask tree for multiple mask..

@cedric
Thank you for review.
I have re-upload the patch with your advice in master branch.
D8517

Apr 1 2019, 12:28 AM · efl
jsuya requested review of D8517: efl_canvas_vg_container : Support mask tree for multiple mask..
Apr 1 2019, 12:18 AM · efl

Mar 31 2019

jsuya planned changes to D8509: ector_software_rasterizer: Implement mask blending function..
Mar 31 2019, 11:58 PM · efl
jsuya planned changes to D8507: vg_json: Set multiple mask from json.
Mar 31 2019, 11:58 PM · efl