Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (236 w, 2 d)
Availability
Available

Recent Activity

Mon, Sep 21

jsuya requested review of D12158: efl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m).
Mon, Sep 21, 10:44 PM · efl

Mon, Sep 14

jsuya requested review of D12146: vg_load_svg: Support dasharray attribute for stroke.
Mon, Sep 14, 7:27 PM · efl

Thu, Sep 10

jsuya added a comment to D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

@Hermet I have updated the patch. Please review again.

Thu, Sep 10, 9:54 PM · efl
jsuya updated the diff for D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

Update commit comment

Thu, Sep 10, 9:53 PM · efl
jsuya updated the diff for D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.

Patch update

  • It doesn't traverse every frame. In render_pre, check the container's alpha and set flag to sync_render of VG object's data.
Thu, Sep 10, 9:52 PM · efl
jsuya added inline comments to D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Thu, Sep 10, 8:30 PM · efl
jsuya requested review of D12141: Efl.Canvas.Vg.Object: Fix typo.
Thu, Sep 10, 7:42 PM · efl
jsuya requested review of D12140: Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously.
Thu, Sep 10, 7:41 PM · efl
jsuya requested review of D12139: vg_load_svg: Add Mask, ClipPath nodees as dummy..
Thu, Sep 10, 7:40 PM · efl
jsuya requested review of D12138: vg_load_svg: Fix missing loader.gradients update.
Thu, Sep 10, 7:40 PM · efl

Wed, Sep 9

jsuya requested review of D12137: vg_load_svg: Supports case when only rx or ry is declared.
Wed, Sep 9, 6:57 PM · efl

Thu, Sep 3

jsuya updated the diff for D12129: vg_load_svg: Fix pointing to wrong parent.

Update comment

Thu, Sep 3, 6:26 PM · efl
jsuya updated the diff for D12129: vg_load_svg: Fix pointing to wrong parent.

Update patch

Thu, Sep 3, 6:25 PM · efl
jsuya requested review of D12129: vg_load_svg: Fix pointing to wrong parent.
Thu, Sep 3, 1:24 AM · efl

Wed, Sep 2

jsuya requested review of D12127: SvgLoader: Defs type nodes are not saved in loader's node list..
Wed, Sep 2, 1:20 AM · efl

Aug 5 2020

jsuya closed D12092: elm_access: fix a potentional error of null deref.
Aug 5 2020, 1:03 AM · efl
jsuya closed D12091: evas/engine: fix a potentional error of null deref.
Aug 5 2020, 1:02 AM · efl
jsuya accepted D12092: elm_access: fix a potentional error of null deref.

Ok I understand this. Thank you for review :)

Aug 5 2020, 1:01 AM · efl
jsuya accepted D12091: evas/engine: fix a potentional error of null deref.

Looks good to me thanks

Aug 5 2020, 12:41 AM · efl

Aug 4 2020

jsuya requested changes to D12092: elm_access: fix a potentional error of null deref.

If there is no target (info's next or prev), elm_access finds the target once again in the focus_relation (539 line).
(I think previous diff is right.)
@kimcinoo Please check this change.

Aug 4 2020, 11:52 PM · efl
jsuya requested changes to D12091: evas/engine: fix a potentional error of null deref.

I think, If evas_cache_image_data for im2 is fail, you should be returned function before freeing "im" and dropping the image.

Aug 4 2020, 11:29 PM · efl
jsuya closed D12086: edje: fix a potentional error of null deref.
Aug 4 2020, 11:19 PM · efl
jsuya accepted D12086: edje: fix a potentional error of null deref.

Looks good to me

Aug 4 2020, 11:18 PM · efl
jsuya closed D12090: edje_edit: fix a potentional error of null deref.
Aug 4 2020, 11:16 PM · efl
jsuya closed D12094: edje_edit: add null check for return of eina_hash_find.
Aug 4 2020, 11:10 PM · efl
jsuya accepted D12094: edje_edit: add null check for return of eina_hash_find.

I agree

Aug 4 2020, 10:37 PM · efl
jsuya added a reviewer for D12094: edje_edit: add null check for return of eina_hash_find: jsuya.
Aug 4 2020, 10:36 PM · efl
jsuya accepted D12074: embryo_cc: ++safty code.

I agree this change

Aug 4 2020, 10:20 PM · efl
jsuya accepted D12090: edje_edit: fix a potentional error of null deref.

Looks good to me

Aug 4 2020, 9:29 PM · efl
jsuya requested changes to D12091: evas/engine: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 9:25 PM · efl
jsuya added a comment to D12084: evas_filter: Add null check for instruction.

@kimcinoo You are right. Thanks :) I updated patch.

Aug 4 2020, 8:31 PM · efl
jsuya updated the diff for D12084: evas_filter: Add null check for instruction.

Update patch

Aug 4 2020, 8:30 PM · efl
jsuya closed D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 5:53 AM · efl
jsuya added inline comments to D12090: edje_edit: fix a potentional error of null deref.
Aug 4 2020, 5:05 AM · efl
jsuya added reviewers for D12090: edje_edit: fix a potentional error of null deref: bu5hm4n, cedric, Hermet.
Aug 4 2020, 5:04 AM · efl
jsuya requested changes to D12090: edje_edit: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 5:04 AM · efl
jsuya added reviewers for D12086: edje: fix a potentional error of null deref: bu5hm4n, Hermet.
Aug 4 2020, 5:00 AM · efl
jsuya requested changes to D12086: edje: fix a potentional error of null deref.

Please check comment

Aug 4 2020, 5:00 AM · efl
jsuya updated the diff for D12085: efl_ui_timepicker: Add null check for efl_text_get.

replaced by eina_streq. thank you for reivew

Aug 4 2020, 4:44 AM · efl
jsuya requested review of D12085: efl_ui_timepicker: Add null check for efl_text_get.
Aug 4 2020, 1:17 AM · efl
jsuya requested review of D12084: evas_filter: Add null check for instruction.
Aug 4 2020, 12:41 AM · efl

Jul 29 2020

jsuya planned changes to D11929: evas_vg_cache: Add sector_list_get.
Jul 29 2020, 7:04 PM · efl
jsuya updated the diff for D11929: evas_vg_cache: Add sector_list_get.

rebase patch
(This patch is for testing. don't merge)

Jul 29 2020, 7:03 PM · efl

Jul 16 2020

jsuya planned changes to D11929: evas_vg_cache: Add sector_list_get.
Jul 16 2020, 11:42 PM · efl
jsuya planned changes to D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jul 16 2020, 11:42 PM · efl

Jun 24 2020

jsuya requested review of D12030: Revert "Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic".
Jun 24 2020, 8:42 PM · efl

Jun 22 2020

jsuya updated the test plan for D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 7:12 PM · efl
jsuya requested review of D12020: Efl.Gfx.Path: Change draw of a rounded rect from arc to quadratic.
Jun 22 2020, 7:10 PM · efl

Jun 17 2020

jsuya requested changes to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

Please check my comment.

Jun 17 2020, 2:53 AM · efl
jsuya added inline comments to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.
Jun 17 2020, 2:52 AM · efl
jsuya added a comment to D11979: elm_image: keep backword compatibility for elm_image_file_set API when setting url file set twice.

In my opinion, if Efl.Ui.Image needs to do the same, I think I can handle this on line 939. Is it only necessary to support legacy?

Jun 17 2020, 2:47 AM · efl

Jun 15 2020

jsuya abandoned D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Abandon this patch.
The way to include stroke width in container's path bounds is wrong.
We need an API of separate VG classes that can provide this feature(actual size with stroke width area), not a local function of VG Object.

Jun 15 2020, 11:23 PM · efl
jsuya added inline comments to D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 7:20 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Update code

Jun 15 2020, 7:18 PM · efl
jsuya added inline comments to D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Jun 15 2020, 6:45 PM · efl
jsuya updated the diff for D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..

Update code

Jun 15 2020, 6:42 PM · efl
jsuya updated the diff for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.

Add initialization code.

Jun 15 2020, 6:31 PM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:45 AM · efl
jsuya requested review of D11975: Efl.Canvas.Vg.Container : Don't refer to stroke when calculating path_bounds..
Jun 15 2020, 3:19 AM · efl
jsuya updated the test plan for D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:09 AM · efl
jsuya requested review of D11974: Efl.Canvas.Vg.Object: Fix wrong render area.
Jun 15 2020, 3:08 AM · efl

Jun 11 2020

jsuya added a comment to D11967: elc_popup: add null checks for scrollable set/get apis.

It is an eo function. why is it necessary to check null for obj?

Jun 11 2020, 12:13 AM · efl

Jun 8 2020

jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

update commit message

Jun 8 2020, 1:16 AM · efl
jsuya updated the diff for D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Update patch

  • add shareable parameter
Jun 8 2020, 1:12 AM · efl

Jun 7 2020

jsuya planned changes to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

Please ignore my comment. I will update this patch as soon as possible.

Jun 7 2020, 7:38 PM · efl
jsuya added a comment to D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..

I think it may be difficult to find or delete the vfd with vp applied as different vfd objects are added to the same key at vg_cache->vfd_hash.

Jun 7 2020, 7:30 PM · efl

Jun 4 2020

jsuya requested review of D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jun 4 2020, 2:58 AM · efl
jsuya added a child revision for D11929: evas_vg_cache: Add sector_list_get: D11931: Efl.Gfx.Frame_Contoller: Add sector_list property.
Jun 4 2020, 2:57 AM · efl

Jun 3 2020

jsuya requested review of D11929: evas_vg_cache: Add sector_list_get.
Jun 3 2020, 7:32 PM · efl
jsuya requested review of D11925: Efl.Canvas.Vg.Object: Fix backup size.
Jun 3 2020, 5:48 PM · efl
jsuya closed D11917: Efl.Gfx.Path: Modify boundary calculation..
Jun 3 2020, 5:23 PM · efl
jsuya requested review of D11924: evas_vg_cache: Don't caching vg file if value_provider is applied..
Jun 3 2020, 5:49 AM · efl
jsuya accepted D11923: build: move static out of none_static.
Jun 3 2020, 5:13 AM · efl
jsuya abandoned D11916: Build: Add json dependency to vg_common.

Yes Thanks :)

Jun 3 2020, 5:13 AM · efl
jsuya added a comment to D11916: Build: Add json dependency to vg_common.

@bu5hm4n No not used.

Jun 3 2020, 4:36 AM · efl
jsuya added a comment to D11916: Build: Add json dependency to vg_common.

When building with json vg loader enabled, a build error occurred.

/usr/bin/ld: src/tests/evas/6440e44@@evas_suite@exe/.._.._static_libs_vg_common_vg_common_json.c.o: undefined reference to symbol 'lottie_animation_property_override'
/usr/local/lib/x86_64-linux-gnu/librlottie.so.0: error adding symbols: DSO missing from command line
Jun 3 2020, 4:23 AM · efl

Jun 2 2020

jsuya requested review of D11917: Efl.Gfx.Path: Modify boundary calculation..
Jun 2 2020, 11:07 PM · efl
jsuya requested review of D11916: Build: Add json dependency to vg_common.
Jun 2 2020, 10:35 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

Jun 2 2020, 7:33 PM · efl

Jun 1 2020

jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

Jun 1 2020, 10:26 PM · efl
jsuya abandoned D11912: vg_common_svg: Add missing break..

already fixed

Jun 1 2020, 9:19 PM · efl
jsuya requested review of D11912: vg_common_svg: Add missing break..
Jun 1 2020, 9:15 PM · efl
jsuya updated the diff for D11911: elm_hoversel: Add missing resize_job's free.

update comment

Jun 1 2020, 8:15 PM · efl
jsuya updated the diff for D11911: elm_hoversel: Add missing resize_job's free.

Update code

Jun 1 2020, 8:12 PM · efl
jsuya requested review of D11911: elm_hoversel: Add missing resize_job's free.
Jun 1 2020, 7:28 PM · efl

May 31 2020

jsuya updated the diff for D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..

Change enum name Change_flag to flags.

May 31 2020, 7:36 PM · efl

May 28 2020

jsuya accepted D11876: Support WebP Animation Image Files.

LGTM :)

May 28 2020, 3:41 AM · efl

May 27 2020

jsuya requested review of D11894: Efl.Gfx.Vg.Value_Provider: Move internal function changed_flag to eo..
May 27 2020, 7:20 PM · efl
jsuya added inline comments to D11876: Support WebP Animation Image Files.
May 27 2020, 6:41 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

remove empty space

May 27 2020, 1:24 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

reuse boundary info

May 27 2020, 1:16 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

update code

May 27 2020, 1:01 AM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code
Refers to the object's viewbox.

May 27 2020, 12:14 AM · efl

May 26 2020

jsuya abandoned D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 26 2020, 2:54 AM · efl

May 25 2020

jsuya planned changes to D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 25 2020, 11:55 PM · efl
jsuya updated the summary of D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 25 2020, 11:24 PM · efl
jsuya requested review of D11880: evas_vg_load_eet: Prevent memory leak for vg load from eet..
May 25 2020, 11:23 PM · efl
jsuya updated the diff for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.

Update code

  • If boundary size is 0, don't merge.
  • VG obj's boundary is calculated only when pd->changed is ture.
May 25 2020, 10:26 PM · efl

May 21 2020

jsuya updated the test plan for D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 21 2020, 1:30 AM · efl
jsuya requested review of D11865: Efl.Canvas.Vg.Object: Optimize Ector Surface Size.
May 21 2020, 1:28 AM · efl