Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (201 w, 3 d)
Availability
Available

Recent Activity

Yesterday

jsuya requested review of D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Mon, Jan 27, 11:45 PM · efl
jsuya added a child revision for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale): D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Mon, Jan 27, 11:45 PM · efl
jsuya added a comment to T8476: efl_ui_animation_view.

I made that move autoplay and looping to Efl.Player and implements in Efl.Ui.Vg_animation.

Mon, Jan 27, 10:06 PM · efl (efl-1.24), efl: api
jsuya requested review of D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Mon, Jan 27, 9:40 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Mon, Jan 27, 9:40 PM · efl (efl-1.24), efl: api
jsuya updated the diff for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).

Update docs
Thank you for review.

Mon, Jan 27, 6:11 PM · efl

Thu, Jan 23

jsuya added a comment to D11158: Eolian eina_types: Add Eina.Matrix4 type.

@segfaultxavi thanks docs:)

Thu, Jan 23, 3:41 AM · efl
jsuya requested review of D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).
Thu, Jan 23, 3:39 AM · efl
jsuya closed D11157: Revert "efl_ui_image: Call unload file when calling file_set".
Thu, Jan 23, 12:39 AM · efl
jsuya requested review of D11158: Eolian eina_types: Add Eina.Matrix4 type.
Thu, Jan 23, 12:38 AM · efl

Wed, Jan 22

jsuya updated subscribers of T8476: efl_ui_animation_view.

@segfaultxavi @bu5hm4n ping~

Wed, Jan 22, 11:53 PM · efl (efl-1.24), efl: api
jsuya requested review of D11157: Revert "efl_ui_image: Call unload file when calling file_set".
Wed, Jan 22, 11:49 PM · efl

Tue, Jan 21

jsuya added a reviewer for D11148: efl_ui_image: Call unload file when calling file_set: zmike.
Tue, Jan 21, 9:52 PM · efl
jsuya requested review of D11148: efl_ui_image: Call unload file when calling file_set.
Tue, Jan 21, 9:47 PM · efl

Sun, Jan 19

jsuya requested review of D11129: vg_common_json: Supports transform properties.
Sun, Jan 19, 5:23 PM · efl

Thu, Jan 16

jsuya added a comment to T8476: efl_ui_animation_view.

Do we have any plans to move and implement autoplay and looping to Efl.Player?
Is there anything else I need to change in Efl.Ui.Vg_Animation before merging D10870?

Thu, Jan 16, 10:10 PM · efl (efl-1.24), efl: api
jsuya abandoned D11113: Efl.Canvas.Vg.Object: Turn on changed flag when file loadded.

this point is already resolved

Thu, Jan 16, 5:53 PM · efl
jsuya requested review of D11113: Efl.Canvas.Vg.Object: Turn on changed flag when file loadded.
Thu, Jan 16, 5:50 PM · efl
jsuya updated the diff for D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

@cedric
Events and properties were moved to Efl.Player through several patches. (T8476)
Is there anything else I need to change?

Thu, Jan 16, 4:35 AM · efl
jsuya added a commit to T8476: efl_ui_animation_view: rEFL2f4ca46544c9: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Thu, Jan 16, 3:14 AM · efl (efl-1.24), efl: api
jsuya closed D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Thu, Jan 16, 3:14 AM · efl
jsuya added a commit to T8476: efl_ui_animation_view: rEFL3a4c5cf6a5f3: tests: Add test cases for Efl.Ui.Vg_Animation.
Thu, Jan 16, 12:51 AM · efl (efl-1.24), efl: api
jsuya closed D11022: tests: Add test cases for Efl.Ui.Vg_Animation.
Thu, Jan 16, 12:51 AM · efl

Wed, Jan 15

jsuya updated the diff for D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

update docs

Wed, Jan 15, 6:20 PM · efl
jsuya added a comment to D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

thank you

Wed, Jan 15, 6:13 PM · efl
jsuya updated the diff for D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

Fix my mistake

Wed, Jan 15, 6:12 PM · efl

Tue, Jan 14

jsuya added a comment to D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

@bu5hm4n ping

Tue, Jan 14, 8:53 PM · efl
jsuya accepted D11098: elm/animation: correctly implement legacy class.
Tue, Jan 14, 8:51 PM · efl
jsuya accepted D11080: efl/player: merge in and rework events from vg_animation.

Thank you for your work.

Tue, Jan 14, 8:50 PM · efl
jsuya requested review of D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Tue, Jan 14, 8:49 PM · efl
jsuya added a child revision for D11080: efl/player: merge in and rework events from vg_animation: D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Tue, Jan 14, 8:49 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Tue, Jan 14, 8:49 PM · efl (efl-1.24), efl: api

Mon, Jan 13

jsuya requested changes to D11080: efl/player: merge in and rework events from vg_animation.

Could you check the events in test_ui_efl_vg_animation.c and test_efl_gfx_vg_value_provider.c?
and
elm_animation_view_add is not declared as a legacy class that implements the Efl.Ui.Legacy interface.
As a result, the merge of this patch can cause problems with elm_animation_view behavior.

Mon, Jan 13, 4:53 PM · efl

Fri, Jan 10

jsuya added a comment to T8476: efl_ui_animation_view.

@segfaultxavi
thank you for comments. I made D11061

Fri, Jan 10, 1:15 AM · efl (efl-1.24), efl: api
jsuya updated the diff for D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

rebase commit

Fri, Jan 10, 1:14 AM · efl
jsuya updated the diff for D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

modify message

Fri, Jan 10, 1:13 AM · efl
jsuya added a child revision for D11022: tests: Add test cases for Efl.Ui.Vg_Animation: D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Fri, Jan 10, 1:13 AM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Fri, Jan 10, 1:13 AM · efl (efl-1.24), efl: api
jsuya requested review of D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Fri, Jan 10, 1:11 AM · efl

Thu, Jan 9

jsuya updated the diff for D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

Update code

  • change ck function for double value.
  • add handle case of json loader not enabled.
Thu, Jan 9, 11:26 PM · efl
jsuya added a comment to T8476: efl_ui_animation_view.

We can move the event to the Efl.Player as you say. But for this efl_canvas_video(emotion), elm_image and elm_image_zoomable must also be modified.
Do you want to implement this work in this task?

Thu, Jan 9, 9:59 PM · efl (efl-1.24), efl: api

Wed, Jan 8

jsuya added a comment to T8476: efl_ui_animation_view.

I made testcases(D11022) related to this. and I have to update it.
I had a small problem with my development environment. So I couldn't update tc patch.
anyway I will update and confirm it as soon as possible.

Wed, Jan 8, 5:05 PM · efl (efl-1.24), efl: api

Mon, Jan 6

jsuya added inline comments to D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.
Mon, Jan 6, 5:41 PM · efl
jsuya updated the diff for D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.

update code

Mon, Jan 6, 5:41 PM · efl

Sun, Jan 5

jsuya requested review of D11022: tests: Add test cases for Efl.Ui.Vg_Animation.
Sun, Jan 5, 10:28 PM · efl
jsuya added a child revision for D11021: Efl.Ui.Vg_Animation: Fix state when changed speed: D11022: tests: Add test cases for Efl.Ui.Vg_Animation.
Sun, Jan 5, 10:28 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11022: tests: Add test cases for Efl.Ui.Vg_Animation.
Sun, Jan 5, 10:28 PM · efl (efl-1.24), efl: api
jsuya requested review of D11021: Efl.Ui.Vg_Animation: Fix state when changed speed.
Sun, Jan 5, 10:22 PM · efl

Wed, Jan 1

jsuya updated the diff for D10995: elm_animation_view: Fix play/play_back behavior.

update comment

Wed, Jan 1, 8:41 PM · efl
jsuya updated the diff for D10995: elm_animation_view: Fix play/play_back behavior.

update code

Wed, Jan 1, 8:38 PM · efl
jsuya planned changes to D10995: elm_animation_view: Fix play/play_back behavior.
Wed, Jan 1, 8:33 PM · efl
jsuya requested review of D10995: elm_animation_view: Fix play/play_back behavior.
Wed, Jan 1, 8:32 PM · efl

Mon, Dec 30

jsuya added inline comments to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.
Mon, Dec 30, 11:12 PM · efl
jsuya added a comment to D10989: evas vg: add an new interface efl_canvas_vg_container_children_direct_get().

I think it's better to replace iterator with eina_list. But I don't think this is bad either.

Mon, Dec 30, 9:42 PM · efl
jsuya accepted D10989: evas vg: add an new interface efl_canvas_vg_container_children_direct_get().
Mon, Dec 30, 9:37 PM · efl

Sun, Dec 29

jsuya updated the diff for D10953: Efl.Ui.Vg_Animation: Implaments Efl.Playable interface.

update commit

  • implement Efl.Playable.playable.get and Efl.Playable.seekable.get
Sun, Dec 29, 8:48 PM · efl

Dec 26 2019

jsuya added a comment to T8476: efl_ui_animation_view.

@segfaultxavi
I made a patch that implements Efl.Playerable. (D10953)
Please review this

Dec 26 2019, 9:45 PM · efl (efl-1.24), efl: api

Dec 23 2019

jsuya added a comment to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.

Hi @bu5hm4n
Please check the comments you reviewed.

Dec 23 2019, 8:28 PM · efl
jsuya closed D10961: evas_object_textblock: remove unreachable code.
Dec 23 2019, 6:37 PM · efl
jsuya accepted D10961: evas_object_textblock: remove unreachable code.

looks good to me

Dec 23 2019, 6:36 PM · efl
jsuya closed D10960: evas_vg_cache: Prevent memory leak.
Dec 23 2019, 5:54 PM · efl
jsuya updated the diff for D10931: Efl.Player: Add setter of playback_progress.

@zmike thank you for review
I have updated the code.

Dec 23 2019, 5:43 PM · efl
jsuya requested review of D10960: evas_vg_cache: Prevent memory leak.
Dec 23 2019, 4:57 PM · efl
jsuya updated the diff for D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

update commit message

Dec 23 2019, 1:16 AM · efl
jsuya added a child revision for D10953: Efl.Ui.Vg_Animation: Implaments Efl.Playable interface: D10870: Efl.Ui.Vg_Animation: Remove @beta mark.
Dec 23 2019, 1:16 AM · efl
jsuya updated the diff for D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

fix typo

Dec 23 2019, 1:15 AM · efl
jsuya updated the diff for D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

update patch

Dec 23 2019, 1:12 AM · efl
jsuya updated the diff for D10931: Efl.Player: Add setter of playback_progress.

Fix dependent patch number

Dec 23 2019, 1:06 AM · efl
jsuya added a child revision for D10915: Efl.Ui.Animation_View: Change state name: D10931: Efl.Player: Add setter of playback_progress.
Dec 23 2019, 1:06 AM · efl
jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

fix typo in elementary test

Dec 23 2019, 1:02 AM · efl

Dec 22 2019

jsuya requested review of D10953: Efl.Ui.Vg_Animation: Implaments Efl.Playable interface.
Dec 22 2019, 11:47 PM · efl
jsuya added a child revision for D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation: D10953: Efl.Ui.Vg_Animation: Implaments Efl.Playable interface.
Dec 22 2019, 11:47 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D10953: Efl.Ui.Vg_Animation: Implaments Efl.Playable interface.
Dec 22 2019, 11:47 PM · efl (efl-1.24), efl: api
jsuya updated the diff for D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation.

fix typo. thanks @segfaultxavi

Dec 22 2019, 11:00 PM · efl
jsuya added a comment to D10931: Efl.Player: Add setter of playback_progress.
Dec 22 2019, 10:38 PM · efl
jsuya updated the diff for D10931: Efl.Player: Add setter of playback_progress.

@bu5hm4n You are right. This code is weird.
The frame_duration was already used in progress_get and I referenced it.

Dec 22 2019, 10:38 PM · efl

Dec 20 2019

jsuya planned changes to D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

I will update it when some patches are complete.

Dec 20 2019, 6:09 AM · efl
jsuya added a comment to T8476: efl_ui_animation_view.

I have made a patch that renames Efl.Ui.Animation_View to Efl.Ui.Vg_Animation. D10939
And I'll also implement Efl.Playable

Dec 20 2019, 3:47 AM · efl (efl-1.24), efl: api
jsuya updated the diff for D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation.

fix message

Dec 20 2019, 3:40 AM · efl
jsuya added a child revision for D10931: Efl.Player: Add setter of playback_progress: D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation.
Dec 20 2019, 3:40 AM · efl
jsuya requested review of D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation.
Dec 20 2019, 3:38 AM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D10939: Efl.Ui.Animation_View : Change class name to Efl.Ui.Vg_Animation.
Dec 20 2019, 3:38 AM · efl (efl-1.24), efl: api
jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

Fix typo. @segfaultxavi Thanks :)

Dec 20 2019, 1:25 AM · efl
jsuya added inline comments to D10931: Efl.Player: Add setter of playback_progress.
Dec 20 2019, 1:23 AM · efl

Dec 19 2019

jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

fix typo

Dec 19 2019, 11:26 PM · efl
jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

update message

Dec 19 2019, 11:24 PM · efl
jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

Update patch
-backward -> backwards
-pause -> paused
-stop -> stopped
-modify elm_animation_view_state_get function.

Dec 19 2019, 11:24 PM · efl
jsuya added inline comments to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.
Dec 19 2019, 9:38 PM · efl
jsuya added inline comments to D10862: Efl.Ui.Animation_View: Implements Efl.Player interface.
Dec 19 2019, 9:36 PM · efl
jsuya requested review of D10931: Efl.Player: Add setter of playback_progress.
Dec 19 2019, 9:27 PM · efl
jsuya added a child revision for D10862: Efl.Ui.Animation_View: Implements Efl.Player interface: D10931: Efl.Player: Add setter of playback_progress.
Dec 19 2019, 9:27 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D10931: Efl.Player: Add setter of playback_progress.
Dec 19 2019, 9:27 PM · efl (efl-1.24), efl: api
jsuya updated the diff for D10907: Elm_Transit: Fix wrong intervention progress value.

remove empty space

Dec 19 2019, 8:13 PM · efl
jsuya updated the diff for D10907: Elm_Transit: Fix wrong intervention progress value.

clean up patch

Dec 19 2019, 8:11 PM · efl
jsuya updated the diff for D10907: Elm_Transit: Fix wrong intervention progress value.

update message

Dec 19 2019, 8:05 PM · efl
jsuya updated the diff for D10907: Elm_Transit: Fix wrong intervention progress value.

Fix to patch
inter_progress must use progress that does not apply the previous inter_progress.

Dec 19 2019, 8:04 PM · efl

Dec 18 2019

jsuya accepted D10916: ector software: catch up losing tasks among the threads..
Dec 18 2019, 11:36 PM · efl
jsuya updated the diff for D10915: Efl.Ui.Animation_View: Change state name.

update message

Dec 18 2019, 10:26 PM · efl
jsuya added a child revision for D10862: Efl.Ui.Animation_View: Implements Efl.Player interface: D10915: Efl.Ui.Animation_View: Change state name.
Dec 18 2019, 10:26 PM · efl
jsuya requested review of D10915: Efl.Ui.Animation_View: Change state name.
Dec 18 2019, 10:25 PM · efl