Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (191 w, 5 d)
Availability
Available

Recent Activity

Yesterday

jsuya added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

I agree that change cosf to cos.
But in my opinion, we should to keep note messages. And you also need to change the test. (src/tests/eina/eina_test_matrix.c)

Tue, Nov 19, 2:50 AM · efl
jsuya added a comment to D10679: Revert "efl_ui/layout: selectively inhibit theme,changed event".

Hi @bu5hm4n :)
sorry I don't know how to i get event name in _efl_ui_layout_base_efl_object_event_callback_priority_add function.
Can you tell me more detail?
And most of all I don't know why desc == EFL_CANVAS_GROUP_EVENT_MEMBER_ADDED was added.
7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f I checked this patch but I still don't understand.
So I couldn't find a way to improve this problem and made this revert patch.
I hope @zmike to check this :)

Tue, Nov 19, 2:22 AM · efl

Thu, Nov 14

jsuya requested review of D10679: Revert "efl_ui/layout: selectively inhibit theme,changed event".
Thu, Nov 14, 10:52 PM · efl
jsuya updated the diff for D10678: efl_ui_layout: Fix "theme,changed" callback not being called in legacy widget cases..

remove empty line

Thu, Nov 14, 10:18 PM · efl
jsuya requested review of D10678: efl_ui_layout: Fix "theme,changed" callback not being called in legacy widget cases..
Thu, Nov 14, 10:17 PM · efl

Wed, Nov 13

jsuya closed D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Wed, Nov 13, 6:31 PM · efl

Tue, Nov 12

jsuya closed D10654: wl_egl : Prevent access to NULL pointer.
Tue, Nov 12, 8:45 PM · efl
jsuya requested review of D10654: wl_egl : Prevent access to NULL pointer.
Tue, Nov 12, 8:42 PM · efl

Mon, Nov 11

jsuya requested review of D10648: evas_device: Fix typo in evas_device_pop.
Mon, Nov 11, 11:21 PM · efl
jsuya updated the diff for D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.

update patch

Mon, Nov 11, 9:53 PM · efl
jsuya closed D10507: Efl.Ui.Animation_View: Implement sector playing feature.
Mon, Nov 11, 9:30 PM · efl
jsuya closed D10506: Efl.Gfx.Frame_Controller: Add sector property.
Mon, Nov 11, 9:30 PM · efl
jsuya closed D10505: evas_cache_vg : Implements sector_get/set internal APIs.
Mon, Nov 11, 9:30 PM · efl
jsuya closed D10504: vg_loader: Get markers information form json data..
Mon, Nov 11, 9:29 PM · efl

Sun, Nov 10

jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

update patch

Sun, Nov 10, 6:16 PM · efl

Thu, Nov 7

jsuya requested review of D10627: efl_canvas_vg_node: Prevent access to NULL object for remove warning.
Thu, Nov 7, 11:17 PM · efl
jsuya updated the diff for D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..

@cedric I added a comment. And modified the eina_matrix3_rotate test. please check again.

Thu, Nov 7, 10:33 PM · efl

Wed, Nov 6

jsuya updated the diff for D10506: Efl.Gfx.Frame_Controller: Add sector property.

update message

Wed, Nov 6, 1:50 AM · efl
jsuya added a child revision for D10505: evas_cache_vg : Implements sector_get/set internal APIs: D10506: Efl.Gfx.Frame_Controller: Add sector property.
Wed, Nov 6, 1:50 AM · efl
jsuya updated the diff for D10506: Efl.Gfx.Frame_Controller: Add sector property.

update commie message

Wed, Nov 6, 1:41 AM · efl
jsuya updated the diff for D10506: Efl.Gfx.Frame_Controller: Add sector property.

update patch

  • add sector_set
Wed, Nov 6, 1:41 AM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

rebase patch

Wed, Nov 6, 1:03 AM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

update commit message

Wed, Nov 6, 1:03 AM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

update patch

  • add evas_cache_vg_anim_sector_set
Wed, Nov 6, 1:01 AM · efl
jsuya updated the diff for D10504: vg_loader: Get markers information form json data..

Update patch

  • use eina_stringshare and eina_inarray_reisze
Wed, Nov 6, 12:18 AM · efl

Sun, Nov 3

jsuya updated the diff for D10507: Efl.Ui.Animation_View: Implement sector playing feature.

Update patch

Sun, Nov 3, 8:25 PM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

add null check

Sun, Nov 3, 6:47 PM · efl
jsuya updated the diff for D10506: Efl.Gfx.Frame_Controller: Add sector property.

update commit message

Sun, Nov 3, 6:26 PM · efl
jsuya updated the diff for D10506: Efl.Gfx.Frame_Controller: Add sector property.

Update patch
-Change property name

Sun, Nov 3, 6:23 PM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

update commit message

Sun, Nov 3, 6:15 PM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

Change method name.

Sun, Nov 3, 6:14 PM · efl
jsuya updated the diff for D10505: evas_cache_vg : Implements sector_get/set internal APIs.

Update patch

Sun, Nov 3, 5:32 PM · efl
jsuya updated the diff for D10504: vg_loader: Get markers information form json data..

Update patch
-Change Eina_Array to Eina_Inarray

Sun, Nov 3, 4:53 PM · efl

Thu, Oct 31

jsuya closed D10584: ecore_event: Remove unused goto define.
Thu, Oct 31, 8:48 PM · efl
jsuya requested review of D10584: ecore_event: Remove unused goto define.
Thu, Oct 31, 7:54 PM · efl

Mon, Oct 28

jsuya closed T8377: possible svg leak as Resolved.

https://git.enlightenment.org/core/efl.git/commit/?id=cf61adaff17a698085655acac889c804cd2895a6
Added a patch to free the pointer. and I changed the state of 1382215 to Fix Submitted

Mon, Oct 28, 9:30 PM · efl
jsuya closed D10443: vg_common_svg: Free node tree for memory leak after eet write..
Mon, Oct 28, 9:20 PM · efl
jsuya added a comment to D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..

Hi @cedric please review this patch

Mon, Oct 28, 5:53 PM · efl

Fri, Oct 25

jsuya requested review of D10507: Efl.Ui.Animation_View: Implement sector playing feature.
Fri, Oct 25, 12:17 AM · efl
jsuya added a child revision for D10506: Efl.Gfx.Frame_Controller: Add sector property: D10507: Efl.Ui.Animation_View: Implement sector playing feature.
Fri, Oct 25, 12:17 AM · efl

Thu, Oct 24

jsuya requested review of D10506: Efl.Gfx.Frame_Controller: Add sector property.
Thu, Oct 24, 11:58 PM · efl
jsuya requested review of D10505: evas_cache_vg : Implements sector_get/set internal APIs.
Thu, Oct 24, 11:34 PM · efl
jsuya added a child revision for D10504: vg_loader: Get markers information form json data.: D10505: evas_cache_vg : Implements sector_get/set internal APIs.
Thu, Oct 24, 11:34 PM · efl
jsuya updated the diff for D10504: vg_loader: Get markers information form json data..

remove warning

Thu, Oct 24, 11:25 PM · efl
jsuya requested review of D10504: vg_loader: Get markers information form json data..
Thu, Oct 24, 11:22 PM · efl
jsuya added a comment to D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..

This can happen when parsing SVG files.
Here is an SVG example that draws X.
(SVG spec does not constrain the range of values.)
white X and red X is same. but white_x is wrong displayed in efl.
This is because the values of cos(and sin) are different in rotate(45).
white x causes a lot of unnecessary computation. But I do not think this is wrong.
Because organization of an SVG file can vary depending on the tool creates SVG file.

Thu, Oct 24, 6:56 PM · efl
jsuya requested review of D10467: Eina_Matrix : Use math header for cosf and sinf of rotate function..
Thu, Oct 24, 4:37 AM · efl

Oct 17 2019

jsuya requested review of D10443: vg_common_svg: Free node tree for memory leak after eet write..
Oct 17 2019, 11:47 PM · efl

Oct 16 2019

jsuya added a comment to T8377: possible svg leak.

Hi @zmike Could you give me coverity site URL that check this issue?
I tried to find it at https://scan.coverity.com/projects/enlightenment-efl But I don't think this is it.

Oct 16 2019, 5:48 PM · efl

Oct 15 2019

jsuya closed D10399: efl_canvas_vg : Propagates the alpha color of the parent.
Oct 15 2019, 11:15 PM · efl
jsuya updated the diff for D10399: efl_canvas_vg : Propagates the alpha color of the parent.

Update the patch to takes opacity from the parent, like the matrix transform.

Oct 15 2019, 12:43 AM · efl

Oct 14 2019

jsuya added a comment to D10371: vg_common_svg: Support opacity attribute of <g> element.

@Hermet Thank you for review
I made a new patch D10399 related to this patch.

Oct 14 2019, 8:13 PM · efl
jsuya updated the diff for D10371: vg_common_svg: Support opacity attribute of <g> element.

update message

Oct 14 2019, 8:11 PM · efl
jsuya updated the diff for D10399: efl_canvas_vg : Propagates the alpha color of the parent.

update commit

Oct 14 2019, 8:08 PM · efl
jsuya planned changes to D10399: efl_canvas_vg : Propagates the alpha color of the parent.
Oct 14 2019, 7:59 PM · efl
jsuya requested review of D10399: efl_canvas_vg : Propagates the alpha color of the parent.
Oct 14 2019, 7:59 PM · efl

Oct 11 2019

jsuya requested review of D10371: vg_common_svg: Support opacity attribute of <g> element.
Oct 11 2019, 3:24 AM · efl

Oct 10 2019

jsuya requested review of D10368: vg_common_json: Apply image's alpha color.
Oct 10 2019, 9:33 PM · efl

Oct 8 2019

jsuya added a comment to D10303: evas_vg_cache: Hashkey of cache use value provider list.

This patch has been agreed offline. We know that some malfunctions due to the cache function may occur. Need refactoring to fix some issues with cache. We will take care of it soon.

Oct 8 2019, 8:00 PM · efl
jsuya closed D10303: evas_vg_cache: Hashkey of cache use value provider list.
Oct 8 2019, 4:34 AM · efl
jsuya updated the diff for D10303: evas_vg_cache: Hashkey of cache use value provider list.

Update commit
Add api to not access vfd at vg_object.c

Oct 8 2019, 3:34 AM · efl
jsuya added a comment to D10303: evas_vg_cache: Hashkey of cache use value provider list.

@Hermet
I think. even if change property, if entry can caching situation, it have to cached.
If there is more than one entry, and same property changed and stop state at first frame, don't caching?

Oct 8 2019, 2:48 AM · efl
jsuya requested review of D10303: evas_vg_cache: Hashkey of cache use value provider list.
Oct 8 2019, 2:16 AM · efl

Oct 3 2019

jsuya closed D10268: efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State.
Oct 3 2019, 6:24 PM · efl

Oct 1 2019

jsuya requested review of D10268: efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State.
Oct 1 2019, 10:59 PM · efl
jsuya closed D10015: elementary_test: Add the value provider test for animation_view.
Oct 1 2019, 10:39 PM · efl
jsuya updated the diff for D10015: elementary_test: Add the value provider test for animation_view.

add header for build fail

Oct 1 2019, 10:39 PM · efl
jsuya closed D9897: vg_common_json: Override value_provider list.
Oct 1 2019, 10:31 PM · efl
jsuya closed D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.
Oct 1 2019, 10:29 PM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

enhance docs

Oct 1 2019, 10:20 PM · efl

Sep 26 2019

jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

rebase commit

Sep 26 2019, 4:03 AM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

modify data_key name

Sep 26 2019, 4:02 AM · efl
jsuya abandoned D10182: edje: Change strerror to eina_error_msg_get for thread safe..

thank you for review

Sep 26 2019, 1:55 AM · efl
jsuya requested review of D10182: edje: Change strerror to eina_error_msg_get for thread safe..
Sep 26 2019, 12:27 AM · efl

Sep 24 2019

jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update commit

Sep 24 2019, 12:18 AM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

update commit

  • Change keypath value type
  • Change property name transfomation to transform.
  • Remove pre-multiplied color check.
Sep 24 2019, 12:12 AM · efl

Sep 23 2019

jsuya requested review of D10104: efl_gfx_path: Add optimized path command.
Sep 23 2019, 7:04 PM · efl
jsuya closed D10074: efl_gfx_path: Support 'l' command for optimized path..
Sep 23 2019, 6:26 PM · efl
jsuya updated the diff for D10074: efl_gfx_path: Support 'l' command for optimized path..

update commit

Sep 23 2019, 12:21 AM · efl
jsuya requested review of D10074: efl_gfx_path: Support 'l' command for optimized path..
Sep 23 2019, 12:19 AM · efl

Sep 22 2019

jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

rebase commit

Sep 22 2019, 11:16 PM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

remove unused function

Sep 22 2019, 11:14 PM · efl
jsuya updated the diff for D10015: elementary_test: Add the value provider test for animation_view.

Add Todo comment

Sep 22 2019, 11:10 PM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

Update commit

  • fix vp list update.
Sep 22 2019, 10:37 PM · efl
jsuya updated the diff for D10015: elementary_test: Add the value provider test for animation_view.

update commit

Sep 22 2019, 10:33 PM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

rebase commit

Sep 22 2019, 7:25 PM · efl
jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

update commit

Sep 22 2019, 7:18 PM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update message

Sep 22 2019, 7:12 PM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update commit

Sep 22 2019, 7:10 PM · efl
jsuya abandoned D10071: vg_common_json: Override value_provider list.

abandon wrong revision

Sep 22 2019, 7:09 PM · efl
jsuya updated the diff for D9897: vg_common_json: Override value_provider list.

update commit

Sep 22 2019, 7:06 PM · efl
jsuya requested review of D10071: vg_common_json: Override value_provider list.
Sep 22 2019, 7:03 PM · efl
jsuya added a child revision for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View: D10071: vg_common_json: Override value_provider list.
Sep 22 2019, 7:03 PM · efl

Sep 20 2019

jsuya updated the diff for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.

update commit
Add ref,unref for vp
Remove copy property
Change enum and get function to internal api

Sep 20 2019, 1:10 AM · efl

Sep 19 2019

jsuya added inline comments to D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View.
Sep 19 2019, 7:02 PM · efl

Sep 18 2019

jsuya updated the diff for D10015: elementary_test: Add the value provider test for animation_view.

update revision

Sep 18 2019, 10:35 PM · efl
jsuya requested review of D10015: elementary_test: Add the value provider test for animation_view.
Sep 18 2019, 10:32 PM · efl
jsuya added a child revision for D9874: Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View: D10015: elementary_test: Add the value provider test for animation_view.
Sep 18 2019, 10:32 PM · efl
jsuya added a child revision for D9897: vg_common_json: Override value_provider list: D10015: elementary_test: Add the value provider test for animation_view.
Sep 18 2019, 10:32 PM · efl

Sep 17 2019

jsuya requested review of D9988: evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue.
Sep 17 2019, 5:16 AM · efl