Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (210 w, 6 d)
Availability
Available

Recent Activity

Tue, Mar 24

jsuya updated the diff for D11563: elm_transit: Prevent adding duplicates.

DBG->WRN

Tue, Mar 24, 5:01 AM · efl
jsuya requested review of D11563: elm_transit: Prevent adding duplicates.
Tue, Mar 24, 4:56 AM · efl
jsuya requested review of D11562: elm_transit: replace evas_object_event_callback_xxx with efl_event_callback_xxx.
Tue, Mar 24, 4:45 AM · efl
jsuya requested review of D11560: Efl.Ui.Vg_Animation: Enable transit event..
Tue, Mar 24, 12:56 AM · efl
jsuya abandoned D11553: elm_transit: Prevent memory leak for object data of transit..

i will make new patch for this issue :)

Tue, Mar 24, 12:54 AM · efl

Mon, Mar 23

jsuya updated the test plan for D11553: elm_transit: Prevent memory leak for object data of transit..
Mon, Mar 23, 5:40 AM · efl
jsuya requested review of D11553: elm_transit: Prevent memory leak for object data of transit..
Mon, Mar 23, 5:39 AM · efl

Thu, Mar 19

jsuya accepted D11541: canvas 3d: remove canvas3d edje.
Thu, Mar 19, 3:07 AM · efl

Tue, Mar 17

jsuya closed D11521: evas_vg: modified the join enum documentation.
Tue, Mar 17, 12:28 AM · efl
jsuya closed D11519: evas_vg: add since tags for evas vector APIs.
Tue, Mar 17, 12:28 AM · efl
jsuya closed D11518: evas_vg: refined the documentation for evas vector APIs.
Tue, Mar 17, 12:27 AM · efl
jsuya closed D11517: evas_vg: refined the evas vector APIs set.
Tue, Mar 17, 12:27 AM · efl

Mon, Mar 16

jsuya accepted D11519: evas_vg: add since tags for evas vector APIs.
Mon, Mar 16, 9:05 PM · efl
jsuya accepted D11517: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 9:05 PM · efl
jsuya accepted D11518: evas_vg: refined the documentation for evas vector APIs.
Mon, Mar 16, 9:04 PM · efl
jsuya accepted D11521: evas_vg: modified the join enum documentation.
Mon, Mar 16, 9:03 PM · efl
jsuya added inline comments to D11517: evas_vg: refined the evas vector APIs set.
Mon, Mar 16, 8:29 PM · efl

Thu, Mar 12

jsuya accepted D11491: efl_canvas_vg_shape: fix the wrong parameter order in the wrapper of evas_vg_shape_append_cubic_to().
Thu, Mar 12, 4:00 AM · efl
jsuya added a comment to D11492: evas_canvas_vg: modified the documentation for the evas vector APIs.

Could you please check more docs about these functions?

Thu, Mar 12, 12:14 AM · efl

Wed, Mar 11

jsuya requested review of D11490: edje_util: Prevent null pointer access.
Wed, Mar 11, 10:00 PM · efl
jsuya updated the diff for D11489: elm_main: Prevent duplicate settings for languages..

I will make a new patch that related to the null check on edje side.

Wed, Mar 11, 9:57 PM · efl
jsuya updated the diff for D11489: elm_main: Prevent duplicate settings for languages..

add null check

Wed, Mar 11, 9:49 PM · efl
jsuya requested review of D11489: elm_main: Prevent duplicate settings for languages..
Wed, Mar 11, 9:45 PM · efl

Tue, Mar 10

jsuya requested review of D11480: vg_common_json: register shape name as it's designed..
Tue, Mar 10, 2:46 AM · efl

Mon, Mar 9

jsuya requested review of D11478: edje: Rename Json to Lottie in edj supporting.
Mon, Mar 9, 9:48 PM · efl

Sun, Mar 8

jsuya requested review of D11474: Efl.Ui.Image: Modify current frame to start at 1.
Sun, Mar 8, 9:32 PM · efl

Feb 26 2020

jsuya closed D11419: evas_model_load_ply: Prevent memory leak.
Feb 26 2020, 4:58 PM · efl
jsuya requested review of D11419: evas_model_load_ply: Prevent memory leak.
Feb 26 2020, 4:48 AM · efl

Feb 25 2020

jsuya requested review of D11418: elementary_test/ui_spotlight: Fix warnings about use to uninitialized value..
Feb 25 2020, 11:05 PM · efl
jsuya requested review of D11417: test/suite_helpers : Fix warnings about use to uninitialized value..
Feb 25 2020, 11:04 PM · efl
jsuya requested review of D11416: elm_slider: Add return value check.
Feb 25 2020, 4:59 PM · efl

Feb 23 2020

jsuya updated the diff for D11399: vg_common_json: Fix to duplication of mask and matte..

fix bug

Feb 23 2020, 11:59 PM · efl
jsuya planned changes to D11399: vg_common_json: Fix to duplication of mask and matte..
Feb 23 2020, 11:28 PM · efl
jsuya requested review of D11399: vg_common_json: Fix to duplication of mask and matte..
Feb 23 2020, 11:22 PM · efl

Feb 17 2020

jsuya edited reviewers for D11366: edje: modify to respect user set fixed property, added: YOhoho, Hermet; removed: woohyun.
Feb 17 2020, 6:11 PM · efl
jsuya closed D11230: edje: Disable the json vector animation feature with a flag..
Feb 17 2020, 2:18 AM · efl
jsuya updated the diff for D11230: edje: Disable the json vector animation feature with a flag..

fix typo

Feb 17 2020, 2:18 AM · efl
jsuya accepted D11364: elm_transit: remove unnecessary image preload invocation.
Feb 17 2020, 1:10 AM · efl
jsuya updated the diff for D11230: edje: Disable the json vector animation feature with a flag..

Update code
PLAY_BACK -> REWIND

Feb 17 2020, 12:29 AM · efl
jsuya updated the diff for D11228: edje: add json file support feature.

modify code

Feb 17 2020, 12:26 AM · efl
jsuya updated the diff for D11228: edje: add json file support feature.

Update code
PLAY_BACK -> REWIND

Feb 17 2020, 12:23 AM · efl

Feb 13 2020

jsuya closed D11347: elm_dbus_menu: Remove unreached code..
Feb 13 2020, 11:29 PM · efl
jsuya closed D11345: eldbus_service: Prevent memory leak.
Feb 13 2020, 11:29 PM · efl
jsuya closed D11344: efl_ui_image : Avoid integral division.
Feb 13 2020, 11:29 PM · efl
jsuya requested review of D11347: elm_dbus_menu: Remove unreached code..
Feb 13 2020, 8:57 PM · efl
jsuya requested review of D11345: eldbus_service: Prevent memory leak.
Feb 13 2020, 8:42 PM · efl
jsuya requested review of D11344: efl_ui_image : Avoid integral division.
Feb 13 2020, 8:31 PM · efl

Feb 12 2020

jsuya accepted D11327: vg_common_json: use %zu for size_t.

LGTM

Feb 12 2020, 1:50 AM · efl

Feb 4 2020

jsuya requested review of D11278: software_evas_engine: Remove unnecessary member for ector_surface_set.
Feb 4 2020, 4:34 AM · efl

Jan 30 2020

jsuya added a comment to T8476: efl_ui_animation_view.

I merged a patch to remove beta. (D10870). Thank you for helping to make this task work well.

Jan 30 2020, 11:43 PM · efl (efl-1.24), efl: api
jsuya added a commit to T8476: efl_ui_animation_view: rEFL33bf1036e900: Efl.Ui.Vg_Animation: Remove @beta mark.
Jan 30 2020, 11:43 PM · efl (efl-1.24), efl: api
jsuya closed D10870: Efl.Ui.Vg_Animation: Remove @beta mark.
Jan 30 2020, 11:43 PM · efl

Jan 29 2020

jsuya updated the diff for D11230: edje: Disable the json vector animation feature with a flag..

minor fix..

Jan 29 2020, 11:51 PM · efl
jsuya updated the diff for D11230: edje: Disable the json vector animation feature with a flag..

Update patch

  • Change edje_cc to compile vg part(json).
  • Add more error message.
Jan 29 2020, 11:49 PM · efl
jsuya closed D11129: vg_common_json: Supports transform properties.
Jan 29 2020, 4:46 AM · efl
jsuya updated the diff for D11129: vg_common_json: Supports transform properties.

fix warning

Jan 29 2020, 4:45 AM · efl
jsuya closed D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Jan 29 2020, 4:42 AM · efl
jsuya requested review of D11228: edje: add json file support feature.

In D11230, Disabled this feature when the json loader was disabled.
This patch should be reviewed together.

Jan 29 2020, 3:43 AM · efl
jsuya requested review of D11230: edje: Disable the json vector animation feature with a flag..
Jan 29 2020, 3:40 AM · efl
jsuya added a child revision for D11228: edje: add json file support feature: D11230: edje: Disable the json vector animation feature with a flag..
Jan 29 2020, 3:40 AM · efl
jsuya updated the test plan for D11228: edje: add json file support feature.
Jan 29 2020, 2:03 AM · efl
jsuya planned changes to D11228: edje: add json file support feature.

This patch has a dependency on the json loader.
Preparing a patch to cover it.

Jan 29 2020, 1:57 AM · efl
jsuya requested review of D11228: edje: add json file support feature.
Jan 29 2020, 1:51 AM · efl
jsuya added inline comments to D11129: vg_common_json: Supports transform properties.
Jan 29 2020, 12:00 AM · efl
jsuya updated the diff for D11129: vg_common_json: Supports transform properties.

update comment

Jan 29 2020, 12:00 AM · efl

Jan 28 2020

jsuya added a child revision for D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4: D11129: vg_common_json: Supports transform properties.
Jan 28 2020, 11:59 PM · efl
jsuya updated the diff for D11129: vg_common_json: Supports transform properties.

Update code

  • Support Matrix4. User can use this to do the x, y, z axis transformation.
Jan 28 2020, 11:59 PM · efl
jsuya closed D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).
Jan 28 2020, 10:46 PM · efl
jsuya updated the diff for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).

I changed the order of matrix multiply in transpose.
For x, y, z to be in m14, m24, m34, it must satisfy below.
Transform Matrix = Translate * Rotate * Scale * Matrix
So I modified TC and fixed transpose.

Jan 28 2020, 10:45 PM · efl

Jan 27 2020

jsuya requested review of D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Jan 27 2020, 11:45 PM · efl
jsuya added a child revision for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale): D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Jan 27 2020, 11:45 PM · efl
jsuya added a comment to T8476: efl_ui_animation_view.

I made that move autoplay and looping to Efl.Player and implements in Efl.Ui.Vg_animation.

Jan 27 2020, 10:06 PM · efl (efl-1.24), efl: api
jsuya requested review of D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Jan 27 2020, 9:40 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Jan 27 2020, 9:40 PM · efl (efl-1.24), efl: api
jsuya updated the diff for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).

Update docs
Thank you for review.

Jan 27 2020, 6:11 PM · efl

Jan 23 2020

jsuya added a comment to D11158: Eolian eina_types: Add Eina.Matrix4 type.

@segfaultxavi thanks docs:)

Jan 23 2020, 3:41 AM · efl
jsuya requested review of D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).
Jan 23 2020, 3:39 AM · efl
jsuya closed D11157: Revert "efl_ui_image: Call unload file when calling file_set".
Jan 23 2020, 12:39 AM · efl
jsuya requested review of D11158: Eolian eina_types: Add Eina.Matrix4 type.
Jan 23 2020, 12:38 AM · efl

Jan 22 2020

jsuya updated subscribers of T8476: efl_ui_animation_view.

@segfaultxavi @bu5hm4n ping~

Jan 22 2020, 11:53 PM · efl (efl-1.24), efl: api
jsuya requested review of D11157: Revert "efl_ui_image: Call unload file when calling file_set".
Jan 22 2020, 11:49 PM · efl

Jan 21 2020

jsuya added a reviewer for D11148: efl_ui_image: Call unload file when calling file_set: zmike.
Jan 21 2020, 9:52 PM · efl
jsuya requested review of D11148: efl_ui_image: Call unload file when calling file_set.
Jan 21 2020, 9:47 PM · efl

Jan 19 2020

jsuya requested review of D11129: vg_common_json: Supports transform properties.
Jan 19 2020, 5:23 PM · efl

Jan 16 2020

jsuya added a comment to T8476: efl_ui_animation_view.

Do we have any plans to move and implement autoplay and looping to Efl.Player?
Is there anything else I need to change in Efl.Ui.Vg_Animation before merging D10870?

Jan 16 2020, 10:10 PM · efl (efl-1.24), efl: api
jsuya abandoned D11113: Efl.Canvas.Vg.Object: Turn on changed flag when file loadded.

this point is already resolved

Jan 16 2020, 5:53 PM · efl
jsuya requested review of D11113: Efl.Canvas.Vg.Object: Turn on changed flag when file loadded.
Jan 16 2020, 5:50 PM · efl
jsuya updated the diff for D10870: Efl.Ui.Vg_Animation: Remove @beta mark.

@cedric
Events and properties were moved to Efl.Player through several patches. (T8476)
Is there anything else I need to change?

Jan 16 2020, 4:35 AM · efl
jsuya added a commit to T8476: efl_ui_animation_view: rEFL2f4ca46544c9: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Jan 16 2020, 3:14 AM · efl (efl-1.24), efl: api
jsuya closed D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.
Jan 16 2020, 3:14 AM · efl
jsuya added a commit to T8476: efl_ui_animation_view: rEFL3a4c5cf6a5f3: tests: Add test cases for Efl.Ui.Vg_Animation.
Jan 16 2020, 12:51 AM · efl (efl-1.24), efl: api
jsuya closed D11022: tests: Add test cases for Efl.Ui.Vg_Animation.
Jan 16 2020, 12:51 AM · efl

Jan 15 2020

jsuya updated the diff for D11061: Efl.Ui.Vg_Animation: Change property name autorepeat to looping.

update docs

Jan 15 2020, 6:20 PM · efl
jsuya added a comment to D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

thank you

Jan 15 2020, 6:13 PM · efl
jsuya updated the diff for D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

Fix my mistake

Jan 15 2020, 6:12 PM · efl

Jan 14 2020

jsuya added a comment to D11022: tests: Add test cases for Efl.Ui.Vg_Animation.

@bu5hm4n ping

Jan 14 2020, 8:53 PM · efl
jsuya accepted D11098: elm/animation: correctly implement legacy class.
Jan 14 2020, 8:51 PM · efl
jsuya accepted D11080: efl/player: merge in and rework events from vg_animation.

Thank you for your work.

Jan 14 2020, 8:50 PM · efl
jsuya requested review of D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Jan 14 2020, 8:49 PM · efl
jsuya added a child revision for D11080: efl/player: merge in and rework events from vg_animation: D11100: elementary_test: Apply changed event related to Efl.Ui.Vg_Animation.
Jan 14 2020, 8:49 PM · efl