Page MenuHomePhabricator

jsuya (choi junsu)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Mar 18 2016, 4:39 AM (173 w, 4 d)
Availability
Available

Recent Activity

Yesterday

jsuya updated the diff for D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

update commit message

Mon, Jul 15, 4:21 AM · efl
jsuya updated the diff for D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.

add test sample in src/example/edje

Mon, Jul 15, 4:14 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

@Hermet
Update patch
src/examples/edje/svg.edc (radialGrad1.svg) is work well
i added missing code.
this patch is same 5403af9.

Mon, Jul 15, 3:53 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

update commit title

Mon, Jul 15, 1:13 AM · efl
jsuya updated the diff for D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.

update patch

Mon, Jul 15, 1:12 AM · efl
jsuya requested review of D9315: evas_vg_load_svg: Support multiple gradient without <defs> part.
Mon, Jul 15, 12:27 AM · efl

Sun, Jul 14

jsuya requested review of D9312: evas_vg_load_svg: Prevent duplicate operations on radial gradient variables.
Sun, Jul 14, 6:59 PM · efl

Mon, Jul 8

jsuya requested review of D9235: Ector.Renderer: Prevent too many unref..
Mon, Jul 8, 1:16 AM · efl

Sun, Jul 7

jsuya added a parent revision for D9220: vg_common_json : Support image data of node: D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Sun, Jul 7, 7:23 PM · efl
jsuya added a child revision for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class: D9220: vg_common_json : Support image data of node.
Sun, Jul 7, 7:23 PM · efl
jsuya requested review of D9220: vg_common_json : Support image data of node.
Sun, Jul 7, 7:22 PM · efl
jsuya requested review of D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Sun, Jul 7, 7:20 PM · efl
jsuya added a child revision for D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class: D9219: Efl.Canvas.Vg : Implement Efl.Canvas.Vg.Image class.
Sun, Jul 7, 7:20 PM · efl
jsuya requested review of D9218: Ector.Renderer : Implement Ector.Renderer.(Software).Image class.
Sun, Jul 7, 7:14 PM · efl
jsuya abandoned D9203: ector_software_rasterizer: Use a premultiplied color..
Sun, Jul 7, 6:53 PM · efl
jsuya requested review of D9217: efl_gfx_shape: Stroke color use a premultiplied color..
Sun, Jul 7, 6:53 PM · efl
jsuya requested review of D9216: vg_common_json: Always set the alpha color of the container..
Sun, Jul 7, 6:41 PM · efl

Fri, Jun 28

jsuya requested review of D9203: ector_software_rasterizer: Use a premultiplied color..
Fri, Jun 28, 3:33 AM · efl

Wed, Jun 19

jsuya added inline comments to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Wed, Jun 19, 9:48 PM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Fix wrong condition and change member name.

Wed, Jun 19, 9:42 PM · efl

Jun 13 2019

jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

Modify the buffer to reuse when the layer has transparency.

Jun 13 2019, 11:58 PM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

add TODO comments

Jun 13 2019, 11:07 PM · efl
jsuya added inline comments to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 13 2019, 12:45 AM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update code
-modify coordinate calculation in draw_image

Jun 13 2019, 12:32 AM · efl

Jun 12 2019

jsuya added inline comments to D9083: efl_canvas_vg_container: Initialize alpha color.
Jun 12 2019, 9:19 PM · efl
jsuya updated the diff for D9083: efl_canvas_vg_container: Initialize alpha color.

fix typo

Jun 12 2019, 12:01 AM · efl

Jun 11 2019

jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update code
change function name and use Ector.Buffer

Jun 11 2019, 11:53 PM · efl
jsuya requested review of D9083: efl_canvas_vg_container: Initialize alpha color.
Jun 11 2019, 9:19 PM · efl
jsuya updated the diff for D9081: vg_common_json: Set container's alpha color.

update code

Jun 11 2019, 2:24 AM · efl
jsuya updated the diff for D9081: vg_common_json: Set container's alpha color.

Fix code

Jun 11 2019, 2:20 AM · efl
jsuya requested review of D9081: vg_common_json: Set container's alpha color.
Jun 11 2019, 12:13 AM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update comments

Jun 11 2019, 12:06 AM · efl
jsuya updated the diff for D9072: ector: Fix precomp layer rendering issue when it has alpha value.

update patch

Jun 11 2019, 12:05 AM · efl

Jun 5 2019

jsuya planned changes to D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 5 2019, 12:16 AM · efl
jsuya requested review of D9072: ector: Fix precomp layer rendering issue when it has alpha value.
Jun 5 2019, 12:15 AM · efl

May 16 2019

jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

add comments

May 16 2019, 6:42 PM · efl
jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

update commit message

May 16 2019, 6:10 PM · efl
jsuya updated the diff for D8895: evas_vg_node: Move change flag value setting.

update code

May 16 2019, 6:08 PM · efl

May 14 2019

jsuya requested review of D8895: evas_vg_node: Move change flag value setting.
May 14 2019, 9:24 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

May 14 2019, 5:51 PM · efl

May 13 2019

jsuya added inline comments to D8873: ector_software_rasterizer: Improved masking calculation..
May 13 2019, 6:58 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

Code update
change floating operation to bitwise operation.
and
change single for loop to double for loop.(remove mod and divide calc)

May 13 2019, 6:57 PM · efl

May 9 2019

jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

May 9 2019, 11:30 PM · efl
jsuya updated the diff for D8873: ector_software_rasterizer: Improved masking calculation..

update code

May 9 2019, 9:10 PM · efl
jsuya requested review of D8873: ector_software_rasterizer: Improved masking calculation..
May 9 2019, 9:01 PM · efl
jsuya updated the diff for D8869: ector_software_rasterizer : Move duplicate alloca.

change branch

May 9 2019, 12:53 AM · efl
jsuya requested review of D8869: ector_software_rasterizer : Move duplicate alloca.
May 9 2019, 12:49 AM · efl
jsuya abandoned D8857: ector_software_rasterizer: Remove alloca function..

It is wrong that BUFFER_SIZE is 2k. I think it's fine if it's a small buffer as appropriate.
Probably 1~255. or half of width.
The crash problem is solved by a little bit more change.
But I will abandon this revision.

May 9 2019, 12:19 AM · efl

May 8 2019

jsuya requested review of D8857: ector_software_rasterizer: Remove alloca function..
May 8 2019, 1:03 AM · efl

May 7 2019

jsuya requested review of D8855: ector_software_rasterizer: Support gradient mask blending.
May 7 2019, 10:46 PM · efl

May 1 2019

jsuya updated the diff for D8802: efl_ui_animation_view: Set max progress when play back..

update code

May 1 2019, 11:31 PM · efl
jsuya requested review of D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 11:23 PM · efl
jsuya requested review of D8802: efl_ui_animation_view: Set max progress when play back..
May 1 2019, 11:22 PM · efl
jsuya planned changes to D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 9:26 PM · efl
jsuya requested review of D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 9:06 PM · efl

Apr 26 2019

jsuya added a comment to D8718: efl_ui_animation_view : Change transit facade sequence..

Compile with: gcc -o animation_view_example animation_view_example.c -g pkg-config --cflags --libs elementary`

Apr 26 2019, 12:44 AM · efl
jsuya requested review of D8718: efl_ui_animation_view : Change transit facade sequence..
Apr 26 2019, 12:44 AM · efl

Apr 25 2019

jsuya updated the diff for D8715: efl_ui_animation_view: Update callback is called only actual change time..

update comment

Apr 25 2019, 10:41 PM · efl
jsuya requested review of D8716: efl_ui_animation_view: Fix current frame calc..
Apr 25 2019, 10:22 PM · efl
jsuya requested review of D8715: efl_ui_animation_view: Update callback is called only actual change time..
Apr 25 2019, 10:17 PM · efl
jsuya updated the diff for D8709: vg_common_json: Support mask with matte case..

update commit

Apr 25 2019, 5:56 PM · efl
jsuya added inline comments to D8709: vg_common_json: Support mask with matte case..
Apr 25 2019, 5:56 PM · efl
jsuya closed D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Apr 25 2019, 1:02 AM · efl
jsuya requested review of D8711: efl_ui_animation_view: Remove docs in set/get..
Apr 25 2019, 12:24 AM · efl

Apr 24 2019

jsuya added a reviewer for D8710: README, doc : Fix typo: kimcinoo.
Apr 24 2019, 11:57 PM · efl
jsuya requested review of D8710: README, doc : Fix typo.
Apr 24 2019, 11:57 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

@segfaultxavi
This patch has been merged into devs/hermet/lottie branch before updating the fix you requested.
I will update your request with new patches.

Apr 24 2019, 11:43 PM · efl
jsuya requested review of D8709: vg_common_json: Support mask with matte case..
Apr 24 2019, 11:27 PM · efl
jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Remove all docs of set/get

Apr 24 2019, 6:39 PM · efl

Apr 23 2019

jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

undo wrong modify

Apr 23 2019, 7:11 PM · efl
jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Update docs

Apr 23 2019, 7:07 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Hi @segfaultxavi
This patch is working on devs/hermet/lottie branch.
@Hermet is preparing features related to this patch.

Apr 23 2019, 7:07 PM · efl

Apr 22 2019

jsuya updated the diff for D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Add more docs

Apr 22 2019, 6:40 PM · efl
jsuya added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

Ok i will do that. :)

Apr 22 2019, 6:40 PM · efl
jsuya requested review of D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Apr 22 2019, 1:16 AM · efl

Apr 21 2019

jsuya requested review of D8674: efl_ui_animation_view: Fix cmake build error.
Apr 21 2019, 6:59 PM · efl

Apr 18 2019

jsuya updated the diff for D8663: vg_common_svg : Implement gradientTransform property of linearGradient.

update code

Apr 18 2019, 11:01 PM · efl
jsuya updated the diff for D8663: vg_common_svg : Implement gradientTransform property of linearGradient.

update code

Apr 18 2019, 9:47 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

update commit message

Apr 18 2019, 9:39 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

remove unnecessary values

Apr 18 2019, 9:38 PM · efl
jsuya added a parent revision for D8663: vg_common_svg : Implement gradientTransform property of linearGradient: D8662: vg_common_svg: Prevent duplicate operations for percentage value.
Apr 18 2019, 7:08 PM · efl
jsuya added a child revision for D8662: vg_common_svg: Prevent duplicate operations for percentage value: D8663: vg_common_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 7:08 PM · efl
jsuya requested review of D8663: vg_common_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 7:08 PM · efl
jsuya updated the diff for D8662: vg_common_svg: Prevent duplicate operations for percentage value.

update code

Apr 18 2019, 6:57 PM · efl
jsuya abandoned D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 18 2019, 6:53 PM · efl
jsuya abandoned D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 18 2019, 6:53 PM · efl
jsuya abandoned D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.
Apr 18 2019, 6:53 PM · efl
jsuya requested review of D8662: vg_common_svg: Prevent duplicate operations for percentage value.
Apr 18 2019, 6:52 PM · efl

Apr 17 2019

jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

fix typo

Apr 17 2019, 6:18 PM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

modify code

Apr 17 2019, 6:17 PM · efl
jsuya updated the diff for D8507: vg_json: Set multiple mask from json.

update code :)

Apr 17 2019, 12:12 AM · efl
jsuya added inline comments to D8507: vg_json: Set multiple mask from json.
Apr 17 2019, 12:11 AM · efl

Apr 16 2019

jsuya added a comment to D8624: vg_load_svg : Implement gradientTransform property of linearGradient.

i attached test file.

Apr 16 2019, 10:10 PM · efl
jsuya added parent revisions for D8624: vg_load_svg : Implement gradientTransform property of linearGradient: D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface, D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 16 2019, 10:05 PM · efl
jsuya added a child revision for D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader: D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:04 PM · efl
jsuya added a child revision for D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface: D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:04 PM · efl
jsuya requested review of D8624: vg_load_svg : Implement gradientTransform property of linearGradient.
Apr 16 2019, 10:03 PM · efl
jsuya added a comment to D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.

thank you for review

Apr 16 2019, 7:36 PM · efl
jsuya requested review of D8596: vg_common_svg : Using Efl.Gfx.Gradient.Units.set/get interface at svg loader.
Apr 16 2019, 7:28 PM · efl
jsuya updated the diff for D8595: efl_gfx_gradient: Add Efl.Gfx.Gradient.Units.set/get interface.

Update code :)

Apr 16 2019, 7:27 PM · efl