Page MenuHomePhabricator

kimcinoo (Shinwoo Kim)
EFL Slow Follower

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2013, 5:25 PM (303 w, 5 d)
Availability
Available

Recent Activity

Thu, Dec 6

kimcinoo added a comment to D7427: evas: remove memory leaks from deleted Textblock objects.

+1

Thu, Dec 6, 10:42 PM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

I am sorry there would be a small typo.

Thu, Dec 6, 3:46 AM · efl
kimcinoo updated the test plan for D7425: efl_ui_win: make win work for evas_norender.
Thu, Dec 6, 3:08 AM · efl
kimcinoo requested review of D7425: efl_ui_win: make win work for evas_norender.
Thu, Dec 6, 2:59 AM · efl
kimcinoo added reviewers for D7424: Efl.Access: Separate event handle function from Efl.Access.Object.: stanluk, l.oleksak.
Thu, Dec 6, 12:55 AM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Thu, Dec 6, 12:55 AM · efl

Thu, Nov 29

kimcinoo accepted D7392: ecore: fix typo in comments..

No doubt

Thu, Nov 29, 4:44 PM · efl

Wed, Nov 28

kimcinoo added a comment to D6870: evas cache image: compare with cached image file.

This is not standing for the cache2. I just quoted comment of the cache2.
This is standing for the cache.

Wed, Nov 28, 8:50 PM · efl
kimcinoo updated the summary of D7344: evas map: calc map geometry when it is out of screen.
Wed, Nov 28, 12:41 AM · efl

Tue, Nov 27

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Follow naming convention.

Tue, Nov 27, 11:51 PM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Update map geometry on correct place.

Tue, Nov 27, 11:44 PM · efl
kimcinoo accepted D7370: gengrid : remove elm_access_text_set for code consistancy..
Tue, Nov 27, 3:16 AM · efl

Mon, Nov 26

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Check obj->map->cur.map->move_sync.enabled before doing everything

Mon, Nov 26, 9:47 PM · efl
kimcinoo requested review of D7344: evas map: calc map geometry when it is out of screen.

The sample is using evas_map_util_object_move_sync_set.
evas_object_map_set and evas_object_map_eanble_set are called onces and are not used whenever target object moves.
IMO the commit message would be enough. The geometry is updated only evas_render_mapped
-> evas_object_map_update
-> evas_object_map_update
-> _evas_map_calc_map_geometry is called.

Mon, Nov 26, 9:29 PM · efl

Thu, Nov 22

kimcinoo updated the test plan for D7344: evas map: calc map geometry when it is out of screen.
Thu, Nov 22, 9:28 PM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Update comment

Thu, Nov 22, 9:26 PM · efl
kimcinoo requested review of D7344: evas map: calc map geometry when it is out of screen.
Thu, Nov 22, 9:23 PM · efl

Nov 11 2018

kimcinoo accepted D7246: atspi: Send key events synchronously.
Nov 11 2018, 4:19 PM · efl
kimcinoo added a comment to D7220: ecore_wl2_window: use client window dimension.

Thank you for enlightening me.
CSD - Client side Decoration!! I thought it is standing for Child Smart Data. :-P

Nov 11 2018, 3:52 PM · efl

Nov 8 2018

kimcinoo requested changes to D7246: atspi: Send key events synchronously.
Nov 8 2018, 1:38 AM · efl
kimcinoo added a comment to D7246: atspi: Send key events synchronously.

Please keep EFL coding conventions (https://www.enlightenment.org/contrib/devs/coding-conventions.md)

Nov 8 2018, 1:37 AM · efl
kimcinoo added a comment to D7246: atspi: Send key events synchronously.

Would you please update commit message with more detailed information as @Hermet asked with separate channel?

Nov 8 2018, 1:32 AM · efl
kimcinoo added a reviewer for D7246: atspi: Send key events synchronously: Hermet.
Nov 8 2018, 1:23 AM · efl

Nov 4 2018

kimcinoo abandoned D7220: ecore_wl2_window: use client window dimension.

@zmike Sure. I just would like to want to know about the upstream is handling 0 sized confiugration.
@ManMower Thank you for interesting. BTW what is the CSD?

Nov 4 2018, 5:36 PM · efl

Nov 1 2018

kimcinoo added a comment to D7220: ecore_wl2_window: use client window dimension.

@ManMower I am handling _ecore_wl_window_cb_angle_change which does not exist on the Upsteam now.
Tizen still has _ecore_wl_window_cb_angle_change and use def_config...
But it seems that the Tizen enlightenment does not update (not send configure) def_config. So rotated window does not show.
TBH I would like to want to know your opinion with this change.

Nov 1 2018, 9:38 PM · efl

Oct 29 2018

kimcinoo requested review of D7220: ecore_wl2_window: use client window dimension.
Oct 29 2018, 9:56 PM · efl

Oct 12 2018

kimcinoo added a comment to D7029: evas_gl_image: remove from cache in free function.

This could be abandoned if D7030 is accepted.

Oct 12 2018, 12:45 AM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Check if related file is virtualized or not

Oct 12 2018, 12:43 AM · efl

Sep 21 2018

kimcinoo closed D7066: eina_vpath_vdg: free locally allocated memory before return.
Sep 21 2018, 12:32 AM · efl

Sep 20 2018

kimcinoo updated the diff for D7066: eina_vpath_vdg: free locally allocated memory before return.

Do not allocate memory with strdup

Sep 20 2018, 8:11 PM · efl
kimcinoo added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

Thank you for updates.
But I could find this usage from other places as well.
If this needs to change with eina_vpath_resolve_snprintf then it would be as follows.

Sep 20 2018, 8:02 PM · efl
kimcinoo added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

Maybe its better to use the vpath resolve variante which takes a static buffer, instead of the allocated string :)

Sep 20 2018, 3:40 AM · efl

Sep 19 2018

kimcinoo requested review of D7075: evas_object_smart: fix dereference of null.
Sep 19 2018, 7:28 PM · efl

Sep 18 2018

kimcinoo requested review of D7066: eina_vpath_vdg: free locally allocated memory before return.
Sep 18 2018, 10:46 PM · efl
kimcinoo added inline comments to D7029: evas_gl_image: remove from cache in free function.
Sep 18 2018, 9:44 PM · efl

Sep 17 2018

kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Check if related file is virtualized or not

Sep 17 2018, 6:39 PM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Fix incorrect update

Sep 17 2018, 6:36 PM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Check if related file is virtualized or not

Sep 17 2018, 6:32 PM · efl
kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

@cedric If the "when the number of user of a file goes to zero" means "file->refcount == 0" then it could become 0 when _evas_cache_image_entry_delete is called.
Please look into following summary of the "file->refcont".
(1) evas_object_image_mem_file_set -> eina_file_virtualize (file->refcount == 1)
(2) _evas_image_init_set -> eina_file_dup (file->refcount == 2)
(3) _evas_cache_image_entry_new -> eina_file_dup (file->refcount == 3)
(4) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_dds -> eina_file_dup (file->refcount == 4)
(5) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_close_dds -> eina_file_close (file->refcount == 3)
(6) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_jpeg -> -> emile_image_jpeg_file_open -> _emile_image_file_set -> eina_file_dup (file->refcount == 4)
(7) evas_object_image_mem_file_set -> eina_file_close (file->refcount == 3)

Sep 17 2018, 3:33 PM · efl
kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

@cedric I would like to share the issue.
An application which is works on evas gl engine calls evas_object_image_memfile_set in a timer callback.
The evas_object_image_memfile_set is using eina_file_virtualize with copy == TRUE.
This newly allocated memory is kept by the cache and never released only after the cache deletes related Image_Entry.
So memory usage becomes bigger and bigger whenever the timer callback is called.

Sep 17 2018, 5:15 AM · efl
kimcinoo requested review of D7030: evas_image_main: make the cache->usage count eina_file size.

Dear @cedric Hello. I am sorry but actually I do not have your point. Why is this not a good idea?
If the cache uses this change it could delete more image entries than before. Could this make a problem?
It would be same with reducing cache->limit.
The _evas_common_rgba_image_ram_usage(mem_size_get) calculates cache size for one process. Why did you comment regarding "shared with all other process"?
The mem_size_get counts sizeof(struct _RGBA_Image), strlen(ie->file) and strlen(ie->file). But it does not count eina_file size even though it is hold by the cache.
The allocated memory for eina_file can be released in _evas_cache_image_entry_delete only.
If the cache does not release it then a process could use 456527385 bytes (Please refer to the commit message).
If this is not a good idea then please let me know regrading better idea to solve it.

Sep 17 2018, 4:37 AM · efl

Sep 16 2018

kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

I have checked this on downstream. If there is not an objection then I would like to push this within a week.

Sep 16 2018, 3:30 PM · efl

Sep 13 2018

kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Move the changes to proper place

Sep 13 2018, 2:56 AM · efl
kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Please check this with D7030

Sep 13 2018, 12:58 AM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Do not multiply eina_file size

Sep 13 2018, 12:57 AM · efl
kimcinoo requested review of D7030: evas_image_main: make the cache->usage count eina_file size.
Sep 13 2018, 12:54 AM · efl
kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Check if image.data is null.

Sep 13 2018, 12:40 AM · efl
kimcinoo requested review of D7029: evas_gl_image: remove from cache in free function.
Sep 13 2018, 12:24 AM · efl

Sep 4 2018

kimcinoo closed D6968: edje_calc: remove unused variable.
Sep 4 2018, 1:40 AM · efl

Sep 3 2018

kimcinoo requested review of D6970: ecore_event: initialize uninitialized variable.
Sep 3 2018, 10:09 PM · efl
kimcinoo requested review of D6969: tests: fix a build error on the 0.12.0 check.
Sep 3 2018, 9:46 PM · efl

Sep 2 2018

kimcinoo closed D6960: docs: Fix typos in API reference doc.
Sep 2 2018, 6:56 PM · efl
kimcinoo accepted D6960: docs: Fix typos in API reference doc.
Sep 2 2018, 6:52 PM · efl

Aug 30 2018

kimcinoo closed D6955: elm_interface_scrollable: fix wrong pointer reference.
Aug 30 2018, 8:33 PM · efl
kimcinoo added a comment to D6922: evas: replace a current copy color function for neon.

+1 here!

Aug 30 2018, 2:54 PM · efl

Aug 28 2018

kimcinoo added a comment to D6915: Elm.Mapbuf: do not set is_static_clip to its content.

For your information Elm.Mapbuf's wd->resize_obj sets is_static_clip to true.

Aug 28 2018, 12:21 AM · efl
kimcinoo requested review of D6915: Elm.Mapbuf: do not set is_static_clip to its content.
Aug 28 2018, 12:19 AM · efl

Aug 23 2018

Herald added a project to T7345: Does 'make check' work well on the latest version of check?: enlightenment-git.
Aug 23 2018, 4:04 PM · enlightenment-git

Aug 22 2018

kimcinoo updated the diff for D6870: evas cache image: compare with cached image file.

Fix typo

Aug 22 2018, 10:57 PM · efl
kimcinoo updated the diff for D6870: evas cache image: compare with cached image file.

Rename test case

Aug 22 2018, 10:54 PM · efl
kimcinoo updated the diff for D6870: evas cache image: compare with cached image file.

Add test case

Aug 22 2018, 10:51 PM · efl

Aug 21 2018

kimcinoo added a comment to D6870: evas cache image: compare with cached image file.

@raster Thank you. If I got it correctly I need to use evas_object_image_data_get.

Aug 21 2018, 1:30 AM · efl

Aug 20 2018

kimcinoo added a reviewer for D6870: evas cache image: compare with cached image file: zmike.
Aug 20 2018, 3:28 PM · efl
kimcinoo added a comment to D6870: evas cache image: compare with cached image file.

@zmike I have no idea how to compare two images on the unit test. Would you please let me know if you have?

Aug 20 2018, 3:28 PM · efl
kimcinoo closed D6868: elm/win: check object class before using it.
Aug 20 2018, 12:16 AM · efl
kimcinoo updated the summary of D6870: evas cache image: compare with cached image file.
Aug 20 2018, 12:14 AM · efl
kimcinoo updated the diff for D6868: elm/win: check object class before using it.

Using EINA_SAFETY_ON_FALSE_RETURN_VAL to get rich information.

Aug 20 2018, 12:10 AM · efl

Aug 19 2018

kimcinoo added a reviewer for D6870: evas cache image: compare with cached image file: jypark.
Aug 19 2018, 11:51 PM · efl
kimcinoo requested review of D6870: evas cache image: compare with cached image file.
Aug 19 2018, 11:51 PM · efl
kimcinoo requested review of D6868: elm/win: check object class before using it.
Aug 19 2018, 4:01 PM · efl

Aug 17 2018

kimcinoo requested review of D6857: eina_file: check copied using copied.
Aug 17 2018, 5:42 AM · efl

Aug 8 2018

kimcinoo added a comment to D6777: gl_common: do not draw rect without texture.

@raster I am on the @Hermet's page. When I got this white rectangle issue, it was too embarrassing.
Only after checking line by line and change the smelly context color, finally I could find out and I could reach this destination.
BTW what is the glitches? And do you mean that the calling evas_gl_common_rect_draw when the !tex should make nothing?

Aug 8 2018, 2:45 PM · efl
kimcinoo added a comment to T7260: Porting Pixman Neon backend to EFL..

@Hermet but it gives incorrect result of image and crash as well on downstream. I can share it.

Aug 8 2018, 2:37 PM
kimcinoo accepted D6786: ecore-evas: make manual_render_set a no-op when setting the current value.
Aug 8 2018, 2:34 PM · efl: display system

Aug 7 2018

kimcinoo added a comment to D6777: gl_common: do not draw rect without texture.

@raster Hey. Do you mean that the calling evas_gl_common_rect_draw when the im->tex is NULL should make nothing?

Aug 7 2018, 9:50 PM · efl
kimcinoo requested review of D6778: evas_image: do not render while preloading.
Aug 7 2018, 4:25 PM · efl
kimcinoo requested review of D6777: gl_common: do not draw rect without texture.
Aug 7 2018, 3:57 PM · efl

Aug 6 2018

kimcinoo added a comment to D6751: eina_vpath: specilice the eina_vpath headers.

//It seems that the first commit of eina_vpath is following commit 1.20

Aug 6 2018, 12:48 AM · efl

Aug 5 2018

kimcinoo added a comment to D6739: evas image: fix screen flickering issue at partial + image preloading.

Please see evas_object_inform_call_image_preloaded.

Aug 5 2018, 5:11 PM · efl
kimcinoo added a comment to D6468: Efl.Canvas.Group: use desired function.

https://phab.enlightenment.org/D6740 is the unit test case for this change.

Aug 5 2018, 3:17 PM · efl

Aug 3 2018

kimcinoo updated the diff for D6740: test/evas: add to check smart class overriding.

Fix a small mistake

Aug 3 2018, 12:53 AM · efl

Aug 1 2018

kimcinoo added a comment to D6468: Efl.Canvas.Group: use desired function.

Err... I found what I have to use. The "--with-tests"
I though I have to use "--enable-tests".

Aug 1 2018, 10:27 PM · efl
kimcinoo added a comment to D6468: Efl.Canvas.Group: use desired function.

Yes but it would be hard to check using the check. If you have good idea to test please let me know.
BTW it seems that I could not execute test properly, even though I have the check.

Aug 1 2018, 10:13 PM · efl

Jul 31 2018

kimcinoo added inline comments to D6699: evas_events: Fix to set mouse_in state to all pointers in the seat..
Jul 31 2018, 2:46 PM · efl

Jul 30 2018

kimcinoo added a comment to D6468: Efl.Canvas.Group: use desired function.
In D6468#113075, @zmike wrote:

Okay, I understand a bit more now.

I think you have a good point, but I don't think this patch is correct.

  • Why are you comparing the move function to evas_object_smart_clipped_smart_set, shouldn't you compare to evas_object_smart_clipped_smart_move?
  • In the case where is_default_move is true, then this means evas_object_smart_clipped_smart_move is called twice here?
  • Isn't the result the same even if you call evas_object_smart_clipped_smart_move and then the user function after?
    • I guess this would have a different result in the case where there are move callbacks set or if the user's move function was doing a relative move...

      So it seems to me that the correct solution to this would be instead to just ensure that the smart move function for clipped objects is evas_object_smart_clipped_smart_move if the function has not been overridden. What do you think about that?
Jul 30 2018, 9:20 PM · efl
kimcinoo updated the diff for D6468: Efl.Canvas.Group: use desired function.

Remove unnecessary changes.

Jul 30 2018, 7:38 PM · efl
kimcinoo updated the diff for D6468: Efl.Canvas.Group: use desired function.

Use correct function evas_object_smart_clipped_smart_move to compare.
Handle condition following condition

Jul 30 2018, 7:35 PM · efl
kimcinoo added a comment to T7227: remove render2 from master.

Something is wrong :-(

Jul 30 2018, 7:27 PM · Active Work Proposal, efl (efl-1.22), major change, efl: rendering
kimcinoo updated subscribers of T7227: remove render2 from master.
Jul 30 2018, 6:14 PM · Active Work Proposal, efl (efl-1.22), major change, efl: rendering
kimcinoo added a comment to T7227: remove render2 from master.

Please do not overlook users such as https://phab.enlightenment.org/D6696

Jul 30 2018, 5:04 PM · Active Work Proposal, efl (efl-1.22), major change, efl: rendering

Jul 24 2018

kimcinoo added a comment to D6646: efl_ui_win: show internal objects again on show if first_draw flag is set.

err.. I could not push because of following error.

Jul 24 2018, 12:39 AM · efl: widgets
kimcinoo closed D6646: efl_ui_win: show internal objects again on show if first_draw flag is set.
Jul 24 2018, 12:37 AM · efl: widgets
kimcinoo accepted D6646: efl_ui_win: show internal objects again on show if first_draw flag is set.
Jul 24 2018, 12:37 AM · efl: widgets

Jul 23 2018

kimcinoo added a comment to T7172: Show, Hide and Show Efl.Ui.Win.

At first the _efl_ui_win_efl_gfx_entity_size_set is called before _efl_ui_win_show.
But the second evas_object_show(win) does not make _efl_ui_win_efl_gfx_entity_size_set be called.
So first_draw is not changed. As a result, the frame_object is not visible at the second show.

Jul 23 2018, 5:29 AM · enlightenment-git

Jul 22 2018

kimcinoo added inline comments to D6646: efl_ui_win: show internal objects again on show if first_draw flag is set.
Jul 22 2018, 11:55 PM · efl: widgets
kimcinoo added a comment to T7172: Show, Hide and Show Efl.Ui.Win.

Is the _efl_ui_win_efl_gfx_entity_size_set called before _efl_ui_win_show?

Jul 22 2018, 9:21 PM · enlightenment-git

Jul 20 2018

kimcinoo added a comment to T7172: Show, Hide and Show Efl.Ui.Win.

For your convenience, please refer to following sample.

Jul 20 2018, 5:34 AM · enlightenment-git
Herald added a project to T7172: Show, Hide and Show Efl.Ui.Win: enlightenment-git.
Jul 20 2018, 5:30 AM · enlightenment-git

Jul 12 2018

kimcinoo edited the content of Maintainers Reviewers.
Jul 12 2018, 9:12 PM · efl

Jul 9 2018

kimcinoo added a comment to D6468: Efl.Canvas.Group: use desired function.

Oh pong~ Sorry for this late pong :-( I'm too lazy. Spank.. Ah~ :-0

Jul 9 2018, 12:35 AM · efl