User Details
- User Since
- Feb 17 2013, 5:25 PM (313 w, 5 d)
- Availability
- Available
Wed, Feb 20
Wed, Feb 13
"bring to front"
"send to back"
which is same with EVIL's PowerPoint.
Please never mind. :-P
Tue, Feb 12
If final value is calculated by TO_INT_ROUND, then make _edje_part_pixel_adjust
use TO_INT_ROUND for eval value as well.
Fri, Feb 1
Fix one more incorrect calculation.
The _edje_part_pixel_adjust could change final.w(h) value to -1.
This value is using in the _edje_part_recalc_single_rel, and has caused
incorrect position.
Thu, Jan 31
Thu, Jan 24
Jan 8 2019
+2
Jan 2 2019
IMO i18n (https://phab.enlightenment.org/D7506) and l10n of EFL correspond with https://www.w3.org/International/questions/qa-i18n
Now I have got difference between i18n and l10n. Thank you.
Dec 30 2018
Interesting :D
I would like to want to know why eo needs 'the ability to get the size of object of a certain class' ?
Dec 26 2018
+2048
Dec 18 2018
Handle potential side effect
Dec 6 2018
+1
I am sorry there would be a small typo.
Nov 29 2018
Nov 28 2018
This is not standing for the cache2. I just quoted comment of the cache2.
This is standing for the cache.
Nov 27 2018
Follow naming convention.
Update map geometry on correct place.
Nov 26 2018
Check obj->map->cur.map->move_sync.enabled before doing everything
The sample is using evas_map_util_object_move_sync_set.
evas_object_map_set and evas_object_map_eanble_set are called onces and are not used whenever target object moves.
IMO the commit message would be enough. The geometry is updated only evas_render_mapped
-> evas_object_map_update
-> evas_object_map_update
-> _evas_map_calc_map_geometry is called if evas_map_util_object_move_sync_set is TRUE.
Nov 22 2018
Update comment
Nov 11 2018
Thank you for enlightening me.
CSD - Client side Decoration!! I thought it is standing for Child Smart Data. :-P
Nov 8 2018
Please keep EFL coding conventions (https://www.enlightenment.org/contrib/devs/coding-conventions.md)
Would you please update commit message with more detailed information as @Hermet asked with separate channel?
Nov 4 2018
Nov 1 2018
@ManMower I am handling _ecore_wl_window_cb_angle_change which does not exist on the Upsteam now.
Tizen still has _ecore_wl_window_cb_angle_change and use def_config...
But it seems that the Tizen enlightenment does not update (not send configure) def_config. So rotated window does not show.
TBH I would like to want to know your opinion with this change.
Oct 29 2018
Oct 12 2018
This could be abandoned if D7030 is accepted.
Check if related file is virtualized or not
Sep 21 2018
Sep 20 2018
Do not allocate memory with strdup
Thank you for updates.
But I could find this usage from other places as well.
If this needs to change with eina_vpath_resolve_snprintf then it would be as follows.
Sep 19 2018
Sep 18 2018
Sep 17 2018
Check if related file is virtualized or not
Fix incorrect update
Check if related file is virtualized or not
@cedric If the "when the number of user of a file goes to zero" means "file->refcount == 0" then it could become 0 when _evas_cache_image_entry_delete is called.
Please look into following summary of the "file->refcont".
(1) evas_object_image_mem_file_set -> eina_file_virtualize (file->refcount == 1)
(2) _evas_image_init_set -> eina_file_dup (file->refcount == 2)
(3) _evas_cache_image_entry_new -> eina_file_dup (file->refcount == 3)
(4) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_dds -> eina_file_dup (file->refcount == 4)
(5) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_close_dds -> eina_file_close (file->refcount == 3)
(6) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_jpeg -> -> emile_image_jpeg_file_open -> _emile_image_file_set -> eina_file_dup (file->refcount == 4)
(7) evas_object_image_mem_file_set -> eina_file_close (file->refcount == 3)
@cedric I would like to share the issue.
An application which is works on evas gl engine calls evas_object_image_memfile_set in a timer callback.
The evas_object_image_memfile_set is using eina_file_virtualize with copy == TRUE.
This newly allocated memory is kept by the cache and never released only after the cache deletes related Image_Entry.
So memory usage becomes bigger and bigger whenever the timer callback is called.
Dear @cedric Hello. I am sorry but actually I do not have your point. Why is this not a good idea?
If the cache uses this change it could delete more image entries than before. Could this make a problem?
It would be same with reducing cache->limit.
The _evas_common_rgba_image_ram_usage(mem_size_get) calculates cache size for one process. Why did you comment regarding "shared with all other process"?
The mem_size_get counts sizeof(struct _RGBA_Image), strlen(ie->file) and strlen(ie->file). But it does not count eina_file size even though it is hold by the cache.
The allocated memory for eina_file can be released in _evas_cache_image_entry_delete only.
If the cache does not release it then a process could use 456527385 bytes (Please refer to the commit message).
If this is not a good idea then please let me know regrading better idea to solve it.
Sep 16 2018
I have checked this on downstream. If there is not an objection then I would like to push this within a week.
Sep 13 2018
Move the changes to proper place
Please check this with D7030
Do not multiply eina_file size
Check if image.data is null.
Sep 4 2018
Sep 3 2018
Sep 2 2018
Aug 30 2018
+1 here!
Aug 28 2018
For your information Elm.Mapbuf's wd->resize_obj sets is_static_clip to true.
Aug 23 2018
Aug 22 2018
Fix typo
Rename test case
Add test case
Aug 21 2018
@raster Thank you. If I got it correctly I need to use evas_object_image_data_get.
Aug 20 2018
@zmike I have no idea how to compare two images on the unit test. Would you please let me know if you have?
Using EINA_SAFETY_ON_FALSE_RETURN_VAL to get rich information.
Aug 19 2018
Aug 17 2018
Aug 8 2018
@raster I am on the @Hermet's page. When I got this white rectangle issue, it was too embarrassing.
Only after checking line by line and change the smelly context color, finally I could find out and I could reach this destination.
BTW what is the glitches? And do you mean that the calling evas_gl_common_rect_draw when the !tex should make nothing?
@Hermet but it gives incorrect result of image and crash as well on downstream. I can share it.
Aug 7 2018
@raster Hey. Do you mean that the calling evas_gl_common_rect_draw when the im->tex is NULL should make nothing?
Aug 6 2018
//It seems that the first commit of eina_vpath is following commit 1.20
Aug 5 2018
Please see evas_object_inform_call_image_preloaded.
https://phab.enlightenment.org/D6740 is the unit test case for this change.
Aug 3 2018
Fix a small mistake
Aug 1 2018
Err... I found what I have to use. The "--with-tests"
I though I have to use "--enable-tests".
Yes but it would be hard to check using the check. If you have good idea to test please let me know.
BTW it seems that I could not execute test properly, even though I have the check.
Jul 31 2018
Jul 30 2018
Remove unnecessary changes.