Page MenuHomePhabricator

kimcinoo (Shinwoo Kim)
EFL Slow Follower

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2013, 5:25 PM (321 w, 5 d)
Availability
Available

Recent Activity

Today

kimcinoo closed D8666: Revert "edje_calc: make INTP use TO_INT_ROUND".
Fri, Apr 19, 1:25 AM · efl
kimcinoo abandoned D8665: edje_calc: do not adjust rounding twice.
Fri, Apr 19, 1:02 AM · efl
kimcinoo requested review of D8666: Revert "edje_calc: make INTP use TO_INT_ROUND".
Fri, Apr 19, 1:02 AM · efl

Yesterday

kimcinoo added a comment to D8665: edje_calc: do not adjust rounding twice.


Data comparison between commit and tries.

Thu, Apr 18, 9:54 PM · efl
kimcinoo requested review of D8665: edje_calc: do not adjust rounding twice.
Thu, Apr 18, 9:50 PM · efl

Tue, Apr 16

kimcinoo updated the test plan for D8618: evas: implement Efl.File.unload for evas image classes.
Tue, Apr 16, 3:06 PM · efl
kimcinoo abandoned D8616: evas_image: work file_set with NULL.

A correct way(https://phab.enlightenment.org/D8618) is coming

Tue, Apr 16, 2:50 PM · efl

Mon, Apr 15

kimcinoo requested review of D8616: evas_image: work file_set with NULL.
Mon, Apr 15, 11:03 PM · efl

Wed, Apr 10

kimcinoo added a comment to T7793: Segmentation fault on multi thread.

The following is commit message. This could explain more about the issue.

Wed, Apr 10, 2:05 AM
kimcinoo created T7793: Segmentation fault on multi thread.
Wed, Apr 10, 2:03 AM

Mon, Apr 1

kimcinoo requested review of D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.
Mon, Apr 1, 12:10 AM · efl

Sun, Mar 24

kimcinoo closed D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Sun, Mar 24, 6:18 PM · efl
kimcinoo accepted D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Sun, Mar 24, 6:18 PM · efl

Thu, Mar 21

kimcinoo requested changes to D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Thu, Mar 21, 3:10 AM · efl

Mar 20 2019

kimcinoo added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

@shilpasingh is it not possible to add test case to efl/src/tests/elementary/efl_ui_test_atspi.c ?

Mar 20 2019, 12:37 AM · efl
kimcinoo added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

I would like to merge this soon. The test case could be added by separated patch set (@bu5hm4n)

Mar 20 2019, 12:35 AM · efl
kimcinoo accepted D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 20 2019, 12:33 AM · efl

Mar 18 2019

kimcinoo added inline comments to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 18 2019, 2:59 PM · efl

Mar 10 2019

kimcinoo added a comment to D8281: ui.widget: enhance documentation of sub_object_add.

+1

Mar 10 2019, 7:59 PM · efl

Mar 6 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Rebase

Mar 6 2019, 6:10 PM · efl
kimcinoo updated the summary of D8105: edje_calc: add ERR message to find out incorrect size problem.
Mar 6 2019, 2:48 AM · efl
kimcinoo requested review of D8105: edje_calc: add ERR message to find out incorrect size problem.
Mar 6 2019, 2:41 AM · efl
kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Remove change not related to use of TO_INT_ROUND.

Mar 6 2019, 2:28 AM · efl

Mar 5 2019

kimcinoo closed D7246: atspi: Send key events synchronously.
Mar 5 2019, 12:03 AM · efl

Mar 4 2019

kimcinoo requested review of D8099: evas: make convert_rgb_32 keep consistency.
Mar 4 2019, 11:40 PM · efl

Feb 24 2019

kimcinoo added inline comments to D7842: edje_calc: make INTP use TO_INT_ROUND.
Feb 24 2019, 11:48 PM · efl

Feb 20 2019

kimcinoo requested review of D7973: evas_object_image: render_post returns if preloading..
Feb 20 2019, 10:57 PM · efl

Feb 13 2019

kimcinoo added a comment to D7934: Efl.Gfx.Stack: Rename raise and lower.

"bring to front"
"send to back"
which is same with EVIL's PowerPoint.
Please never mind. :-P

Feb 13 2019, 1:49 PM · efl

Feb 12 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

If final value is calculated by TO_INT_ROUND, then make _edje_part_pixel_adjust
use TO_INT_ROUND for eval value as well.

Feb 12 2019, 4:06 AM · efl

Feb 1 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Fix one more incorrect calculation.
The _edje_part_pixel_adjust could change final.w(h) value to -1.
This value is using in the _edje_part_recalc_single_rel, and has caused
incorrect position.

Feb 1 2019, 3:52 AM · efl

Jan 31 2019

kimcinoo updated the test plan for D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:33 AM · efl
kimcinoo updated the summary of D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:31 AM · efl
kimcinoo requested review of D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:30 AM · efl

Jan 24 2019

kimcinoo requested review of D7767: evas_clip: do not set clip->changed to true.
Jan 24 2019, 10:49 PM · efl

Jan 8 2019

kimcinoo added a comment to D7557: elementary genlist: make it sure object type..

+2

Jan 8 2019, 1:47 PM · efl

Jan 2 2019

kimcinoo added a comment to D7507: elementary: rename Efl.Ui.Translatable -> Efl.Ui.L10n.

IMO i18n (https://phab.enlightenment.org/D7506) and l10n of EFL correspond with https://www.w3.org/International/questions/qa-i18n
Now I have got difference between i18n and l10n. Thank you.

Jan 2 2019, 3:10 PM · efl

Dec 30 2018

kimcinoo added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Interesting :D

Dec 30 2018, 2:05 PM · efl
kimcinoo added a comment to D7441: eo: add the ability to get the size of object of a certain class..

I would like to want to know why eo needs 'the ability to get the size of object of a certain class' ?

Dec 30 2018, 2:02 PM · efl

Dec 26 2018

kimcinoo added a comment to D7512: evas textblock: fix render_pre bug related with clipper.

+2048

Dec 26 2018, 1:43 AM · efl

Dec 18 2018

kimcinoo updated the diff for D7425: efl_ui_win: make win work for evas_norender.

Handle potential side effect

Dec 18 2018, 2:40 AM · efl

Dec 6 2018

kimcinoo added a comment to D7427: evas: remove memory leaks from deleted Textblock objects.

+1

Dec 6 2018, 10:42 PM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

I am sorry there would be a small typo.

Dec 6 2018, 3:46 AM · efl
kimcinoo updated the test plan for D7425: efl_ui_win: make win work for evas_norender.
Dec 6 2018, 3:08 AM · efl
kimcinoo requested review of D7425: efl_ui_win: make win work for evas_norender.
Dec 6 2018, 2:59 AM · efl
kimcinoo added reviewers for D7424: Efl.Access: Separate event handle function from Efl.Access.Object.: stanluk, l.oleksak.
Dec 6 2018, 12:55 AM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Dec 6 2018, 12:55 AM · efl

Nov 29 2018

kimcinoo accepted D7392: ecore: fix typo in comments..

No doubt

Nov 29 2018, 4:44 PM · efl

Nov 28 2018

kimcinoo added a comment to D6870: evas cache image: compare with cached image file.

This is not standing for the cache2. I just quoted comment of the cache2.
This is standing for the cache.

Nov 28 2018, 8:50 PM · efl
kimcinoo updated the summary of D7344: evas map: calc map geometry when it is out of screen.
Nov 28 2018, 12:41 AM · efl

Nov 27 2018

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Follow naming convention.

Nov 27 2018, 11:51 PM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Update map geometry on correct place.

Nov 27 2018, 11:44 PM · efl
kimcinoo accepted D7370: gengrid : remove elm_access_text_set for code consistancy..
Nov 27 2018, 3:16 AM · efl

Nov 26 2018

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Check obj->map->cur.map->move_sync.enabled before doing everything

Nov 26 2018, 9:47 PM · efl
kimcinoo requested review of D7344: evas map: calc map geometry when it is out of screen.

The sample is using evas_map_util_object_move_sync_set.
evas_object_map_set and evas_object_map_eanble_set are called onces and are not used whenever target object moves.
IMO the commit message would be enough. The geometry is updated only evas_render_mapped
-> evas_object_map_update
-> evas_object_map_update
-> _evas_map_calc_map_geometry is called if evas_map_util_object_move_sync_set is TRUE.

Nov 26 2018, 9:29 PM · efl

Nov 22 2018

kimcinoo updated the test plan for D7344: evas map: calc map geometry when it is out of screen.
Nov 22 2018, 9:28 PM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Update comment

Nov 22 2018, 9:26 PM · efl
kimcinoo requested review of D7344: evas map: calc map geometry when it is out of screen.
Nov 22 2018, 9:23 PM · efl

Nov 11 2018

kimcinoo accepted D7246: atspi: Send key events synchronously.
Nov 11 2018, 4:19 PM · efl
kimcinoo added a comment to D7220: ecore_wl2_window: use client window dimension.

Thank you for enlightening me.
CSD - Client side Decoration!! I thought it is standing for Child Smart Data. :-P

Nov 11 2018, 3:52 PM · efl

Nov 8 2018

kimcinoo requested changes to D7246: atspi: Send key events synchronously.
Nov 8 2018, 1:38 AM · efl
kimcinoo added a comment to D7246: atspi: Send key events synchronously.

Please keep EFL coding conventions (https://www.enlightenment.org/contrib/devs/coding-conventions.md)

Nov 8 2018, 1:37 AM · efl
kimcinoo added a comment to D7246: atspi: Send key events synchronously.

Would you please update commit message with more detailed information as @Hermet asked with separate channel?

Nov 8 2018, 1:32 AM · efl
kimcinoo added a reviewer for D7246: atspi: Send key events synchronously: Hermet.
Nov 8 2018, 1:23 AM · efl

Nov 4 2018

kimcinoo abandoned D7220: ecore_wl2_window: use client window dimension.

@zmike Sure. I just would like to want to know about the upstream is handling 0 sized confiugration.
@ManMower Thank you for interesting. BTW what is the CSD?

Nov 4 2018, 5:36 PM · efl

Nov 1 2018

kimcinoo added a comment to D7220: ecore_wl2_window: use client window dimension.

@ManMower I am handling _ecore_wl_window_cb_angle_change which does not exist on the Upsteam now.
Tizen still has _ecore_wl_window_cb_angle_change and use def_config...
But it seems that the Tizen enlightenment does not update (not send configure) def_config. So rotated window does not show.
TBH I would like to want to know your opinion with this change.

Nov 1 2018, 9:38 PM · efl

Oct 29 2018

kimcinoo requested review of D7220: ecore_wl2_window: use client window dimension.
Oct 29 2018, 9:56 PM · efl

Oct 12 2018

kimcinoo added a comment to D7029: evas_gl_image: remove from cache in free function.

This could be abandoned if D7030 is accepted.

Oct 12 2018, 12:45 AM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Check if related file is virtualized or not

Oct 12 2018, 12:43 AM · efl

Sep 21 2018

kimcinoo closed D7066: eina_vpath_vdg: free locally allocated memory before return.
Sep 21 2018, 12:32 AM · efl

Sep 20 2018

kimcinoo updated the diff for D7066: eina_vpath_vdg: free locally allocated memory before return.

Do not allocate memory with strdup

Sep 20 2018, 8:11 PM · efl
kimcinoo added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

Thank you for updates.
But I could find this usage from other places as well.
If this needs to change with eina_vpath_resolve_snprintf then it would be as follows.

Sep 20 2018, 8:02 PM · efl
kimcinoo added a comment to D7066: eina_vpath_vdg: free locally allocated memory before return.

Maybe its better to use the vpath resolve variante which takes a static buffer, instead of the allocated string :)

Sep 20 2018, 3:40 AM · efl

Sep 19 2018

kimcinoo requested review of D7075: evas_object_smart: fix dereference of null.
Sep 19 2018, 7:28 PM · efl

Sep 18 2018

kimcinoo requested review of D7066: eina_vpath_vdg: free locally allocated memory before return.
Sep 18 2018, 10:46 PM · efl
kimcinoo added inline comments to D7029: evas_gl_image: remove from cache in free function.
Sep 18 2018, 9:44 PM · efl

Sep 17 2018

kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Check if related file is virtualized or not

Sep 17 2018, 6:39 PM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Fix incorrect update

Sep 17 2018, 6:36 PM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Check if related file is virtualized or not

Sep 17 2018, 6:32 PM · efl
kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

@cedric If the "when the number of user of a file goes to zero" means "file->refcount == 0" then it could become 0 when _evas_cache_image_entry_delete is called.
Please look into following summary of the "file->refcont".
(1) evas_object_image_mem_file_set -> eina_file_virtualize (file->refcount == 1)
(2) _evas_image_init_set -> eina_file_dup (file->refcount == 2)
(3) _evas_cache_image_entry_new -> eina_file_dup (file->refcount == 3)
(4) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_dds -> eina_file_dup (file->refcount == 4)
(5) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_close_dds -> eina_file_close (file->refcount == 3)
(6) evas_common_load_rgba_image_module_from_file -> evas_image_load_file_open_jpeg -> -> emile_image_jpeg_file_open -> _emile_image_file_set -> eina_file_dup (file->refcount == 4)
(7) evas_object_image_mem_file_set -> eina_file_close (file->refcount == 3)

Sep 17 2018, 3:33 PM · efl
kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

@cedric I would like to share the issue.
An application which is works on evas gl engine calls evas_object_image_memfile_set in a timer callback.
The evas_object_image_memfile_set is using eina_file_virtualize with copy == TRUE.
This newly allocated memory is kept by the cache and never released only after the cache deletes related Image_Entry.
So memory usage becomes bigger and bigger whenever the timer callback is called.

Sep 17 2018, 5:15 AM · efl
kimcinoo requested review of D7030: evas_image_main: make the cache->usage count eina_file size.

Dear @cedric Hello. I am sorry but actually I do not have your point. Why is this not a good idea?
If the cache uses this change it could delete more image entries than before. Could this make a problem?
It would be same with reducing cache->limit.
The _evas_common_rgba_image_ram_usage(mem_size_get) calculates cache size for one process. Why did you comment regarding "shared with all other process"?
The mem_size_get counts sizeof(struct _RGBA_Image), strlen(ie->file) and strlen(ie->file). But it does not count eina_file size even though it is hold by the cache.
The allocated memory for eina_file can be released in _evas_cache_image_entry_delete only.
If the cache does not release it then a process could use 456527385 bytes (Please refer to the commit message).
If this is not a good idea then please let me know regrading better idea to solve it.

Sep 17 2018, 4:37 AM · efl

Sep 16 2018

kimcinoo added a comment to D7030: evas_image_main: make the cache->usage count eina_file size.

I have checked this on downstream. If there is not an objection then I would like to push this within a week.

Sep 16 2018, 3:30 PM · efl

Sep 13 2018

kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Move the changes to proper place

Sep 13 2018, 2:56 AM · efl
kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Please check this with D7030

Sep 13 2018, 12:58 AM · efl
kimcinoo updated the diff for D7030: evas_image_main: make the cache->usage count eina_file size.

Do not multiply eina_file size

Sep 13 2018, 12:57 AM · efl
kimcinoo requested review of D7030: evas_image_main: make the cache->usage count eina_file size.
Sep 13 2018, 12:54 AM · efl
kimcinoo updated the diff for D7029: evas_gl_image: remove from cache in free function.

Check if image.data is null.

Sep 13 2018, 12:40 AM · efl
kimcinoo requested review of D7029: evas_gl_image: remove from cache in free function.
Sep 13 2018, 12:24 AM · efl

Sep 4 2018

kimcinoo closed D6968: edje_calc: remove unused variable.
Sep 4 2018, 1:40 AM · efl

Sep 3 2018

kimcinoo requested review of D6970: ecore_event: initialize uninitialized variable.
Sep 3 2018, 10:09 PM · efl
kimcinoo requested review of D6969: tests: fix a build error on the 0.12.0 check.
Sep 3 2018, 9:46 PM · efl

Sep 2 2018

kimcinoo closed D6960: docs: Fix typos in API reference doc.
Sep 2 2018, 6:56 PM · efl
kimcinoo accepted D6960: docs: Fix typos in API reference doc.
Sep 2 2018, 6:52 PM · efl

Aug 30 2018

kimcinoo closed D6955: elm_interface_scrollable: fix wrong pointer reference.
Aug 30 2018, 8:33 PM · efl
kimcinoo added a comment to D6922: evas: replace a current copy color function for neon.

+1 here!

Aug 30 2018, 2:54 PM · efl

Aug 28 2018

kimcinoo added a comment to D6915: Elm.Mapbuf: do not set is_static_clip to its content.

For your information Elm.Mapbuf's wd->resize_obj sets is_static_clip to true.

Aug 28 2018, 12:21 AM · efl
kimcinoo requested review of D6915: Elm.Mapbuf: do not set is_static_clip to its content.
Aug 28 2018, 12:19 AM · efl

Aug 23 2018

Herald added a project to T7345: Does 'make check' work well on the latest version of check?: enlightenment-git.
Aug 23 2018, 4:04 PM · enlightenment-git

Aug 22 2018

kimcinoo updated the diff for D6870: evas cache image: compare with cached image file.

Fix typo

Aug 22 2018, 10:57 PM · efl
kimcinoo updated the diff for D6870: evas cache image: compare with cached image file.

Rename test case

Aug 22 2018, 10:54 PM · efl