Page MenuHomePhabricator

kimcinoo (Shinwoo Kim)
EFL Slow Follower

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2013, 5:25 PM (329 w, 5 d)
Availability
Available

Recent Activity

Yesterday

kimcinoo added a comment to D9085: evas filter: make curve work for every.

Honestly I do not get what "Currently growbuf == outbuf is out of date." is. Do you mean that the outbuf is out of date, because it is same with growbuf? And is that for the first case that the outbuf is not dirty?

Fri, Jun 14, 2:45 AM · efl

Wed, Jun 12

kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Update comment.

Wed, Jun 12, 11:41 PM · efl
kimcinoo added a comment to D9085: evas filter: make curve work for every.

And It's very suspicious at this condition.

1288 if ((inbuf != outbuf) && out->dirty)

This condition might be related with this issue... Something make it out of the condition ...

Wed, Jun 12, 11:38 PM · efl
kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Use a temp buffer on grow_add side as well to reduce calling blend_add based on
valuable hermet's comment.

Wed, Jun 12, 11:28 PM · efl
kimcinoo added a comment to D7344: evas map: calc map geometry when it is out of screen.

Let me know more about 'map object'. Does it mean the object using Evas_Map such as button of evas_object_map_set(button, map)?

Wed, Jun 12, 3:40 AM · efl
kimcinoo updated the test plan for D9085: evas filter: make curve work for every.
Wed, Jun 12, 2:32 AM · efl
kimcinoo updated the test plan for D9085: evas filter: make curve work for every.
Wed, Jun 12, 2:32 AM · efl
kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Use correct name blendcmd instead of curvecmd

Wed, Jun 12, 2:10 AM · efl
kimcinoo requested review of D9085: evas filter: make curve work for every.
Wed, Jun 12, 2:07 AM · efl

Tue, Jun 4

kimcinoo added a comment to D9068: evas_out: add condition for efl_canvas_output_view_set.

It would be better if we have enhanced documentation and related TC as well. Thank you.

Tue, Jun 4, 2:46 PM · efl

Thu, May 23

kimcinoo updated the diff for D8930: Efl.Ui.Textpath: fix a size problem.

Enhanced based on comment. This is much more neat!

Thu, May 23, 1:46 AM · efl

Tue, May 21

kimcinoo added reviewers for D8930: Efl.Ui.Textpath: fix a size problem: Hermet, jsuya.
Tue, May 21, 5:48 AM · efl
kimcinoo requested review of D8930: Efl.Ui.Textpath: fix a size problem.
Tue, May 21, 5:47 AM · efl

Mon, May 20

kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comment.

Mon, May 20, 8:52 PM · efl
kimcinoo requested review of D8924: Efl.Ui.Textpath: draw text immediately in the position.set.
Mon, May 20, 4:51 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comment.

Mon, May 20, 4:10 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Remove unintended lines.

Mon, May 20, 3:14 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comments.

Mon, May 20, 3:11 AM · efl

May 14 2019

kimcinoo added a comment to D8892: Efl.Ui.Textpath: support center align for each direction.
  1. I've considered for the interface, how about using align_hint ?

If the "using align_hint" means kind of "using Efl.Gfx.Hint.hint_align", it could be more flexible than using these enums. But it seems that you did not mean Efl.Gfx.Hint.hint_align because this is hint on how to align an object inside its container.

May 14 2019, 2:57 PM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Remove unrelated changes

May 14 2019, 4:36 AM · efl
kimcinoo requested review of D8892: Efl.Ui.Textpath: support center align for each direction.
May 14 2019, 4:33 AM · efl

May 12 2019

kimcinoo updated the diff for D8875: Efl.Ui.Textpath: enhance to support legacy API.

Update based on a comment saying make it simpler

May 12 2019, 5:55 PM · efl

May 10 2019

kimcinoo updated the diff for D8875: Efl.Ui.Textpath: enhance to support legacy API.

fix typo

May 10 2019, 4:31 AM · efl
kimcinoo requested review of D8875: Efl.Ui.Textpath: enhance to support legacy API.
May 10 2019, 4:29 AM · efl

May 6 2019

kimcinoo accepted D8837: evas_render: deduplicate mapped mask render code.

+1024

May 6 2019, 8:00 PM · efl: rendering

May 2 2019

kimcinoo added a comment to D8719: gfx_filter: add an example.

The warning probably comes from

May 2 2019, 6:00 PM · efl
kimcinoo closed D8719: gfx_filter: add an example.
May 2 2019, 9:15 AM · efl
kimcinoo added a comment to D8719: gfx_filter: add an example.

@bu5hm4n
(1) Are you using gl engine?
(2) What is the result of eina_btlog?
(3) The result would be not caused by incorrect example.

May 2 2019, 5:16 AM · efl

May 1 2019

kimcinoo updated the diff for D8719: gfx_filter: add an example.

(Oooops... sorry...) Warnings are removed.

May 1 2019, 11:57 PM · efl
kimcinoo closed D8802: efl_ui_animation_view: Set max progress when play back..
May 1 2019, 11:46 PM · efl
kimcinoo accepted D8802: efl_ui_animation_view: Set max progress when play back..
May 1 2019, 11:46 PM · efl
kimcinoo requested changes to D8802: efl_ui_animation_view: Set max progress when play back..

sorry, this is a change to test arc

May 1 2019, 11:46 PM · efl
kimcinoo closed D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 11:44 PM · efl
kimcinoo accepted D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 11:24 PM · efl

Apr 29 2019

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Remove unnecessary changes

Apr 29 2019, 5:25 AM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Amend based on comments

Apr 29 2019, 5:20 AM · efl
kimcinoo added a comment to D8757: embryo_cc: Fix longjmp clobbering warning..

Um... no details?

Apr 29 2019, 4:25 AM · efl

Apr 28 2019

kimcinoo updated the diff for D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.

Amend based on comments

Apr 28 2019, 11:44 PM · efl
kimcinoo added inline comments to D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.
Apr 28 2019, 11:42 PM · efl
kimcinoo updated the diff for D8719: gfx_filter: add an example.

Add this to the meson build file

Apr 28 2019, 7:18 PM · efl

Apr 26 2019

kimcinoo requested review of D8719: gfx_filter: add an example.
Apr 26 2019, 1:21 AM · efl

Apr 25 2019

kimcinoo closed D8711: efl_ui_animation_view: Remove docs in set/get..
Apr 25 2019, 1:33 AM · efl
kimcinoo accepted D8711: efl_ui_animation_view: Remove docs in set/get..
Apr 25 2019, 1:31 AM · efl

Apr 24 2019

kimcinoo added a comment to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..

I cannot close this revision because I could not change status to 'accepted'
But it was possible 'git push' this change. Probably @segfaultxavi needs to accept this.

Apr 24 2019, 6:36 PM · efl
kimcinoo accepted D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Apr 24 2019, 6:24 PM · efl

Apr 22 2019

kimcinoo requested changes to D8675: Efl.Ui.Animation_View: Enhance documentation of elm_animation_view..
Apr 22 2019, 5:18 PM · efl

Apr 21 2019

kimcinoo updated the summary of D8673: ecore_wl2_input: fix a way it works when it has multiple input devices.
Apr 21 2019, 7:05 PM · efl
kimcinoo added a comment to D7344: evas map: calc map geometry when it is out of screen.

(Requesting changes here for hermet, so its out of the loop.)

Apr 21 2019, 6:05 PM · efl

Apr 19 2019

kimcinoo closed D8666: Revert "edje_calc: make INTP use TO_INT_ROUND".
Apr 19 2019, 1:25 AM · efl
kimcinoo abandoned D8665: edje_calc: do not adjust rounding twice.
Apr 19 2019, 1:02 AM · efl
kimcinoo requested review of D8666: Revert "edje_calc: make INTP use TO_INT_ROUND".
Apr 19 2019, 1:02 AM · efl

Apr 18 2019

kimcinoo added a comment to D8665: edje_calc: do not adjust rounding twice.


Data comparison between commit and tries.

Apr 18 2019, 9:54 PM · efl
kimcinoo requested review of D8665: edje_calc: do not adjust rounding twice.
Apr 18 2019, 9:50 PM · efl

Apr 16 2019

kimcinoo updated the test plan for D8618: evas: implement Efl.File.unload for evas image classes.
Apr 16 2019, 3:06 PM · efl
kimcinoo abandoned D8616: evas_image: work file_set with NULL.

A correct way(https://phab.enlightenment.org/D8618) is coming

Apr 16 2019, 2:50 PM · efl

Apr 15 2019

kimcinoo requested review of D8616: evas_image: work file_set with NULL.
Apr 15 2019, 11:03 PM · efl

Apr 10 2019

kimcinoo added a comment to T7793: Segmentation fault on multi thread.

The following is commit message. This could explain more about the issue.

Apr 10 2019, 2:05 AM
kimcinoo created T7793: Segmentation fault on multi thread.
Apr 10 2019, 2:03 AM

Apr 1 2019

kimcinoo requested review of D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.
Apr 1 2019, 12:10 AM · efl

Mar 24 2019

kimcinoo closed D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Mar 24 2019, 6:18 PM · efl
kimcinoo accepted D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Mar 24 2019, 6:18 PM · efl

Mar 21 2019

kimcinoo requested changes to D8435: efl_access: if 0 is set as reading_info_type, remove existing reading_info.
Mar 21 2019, 3:10 AM · efl

Mar 20 2019

kimcinoo added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

@shilpasingh is it not possible to add test case to efl/src/tests/elementary/efl_ui_test_atspi.c ?

Mar 20 2019, 12:37 AM · efl
kimcinoo added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

I would like to merge this soon. The test case could be added by separated patch set (@bu5hm4n)

Mar 20 2019, 12:35 AM · efl
kimcinoo accepted D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 20 2019, 12:33 AM · efl

Mar 18 2019

kimcinoo added inline comments to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.
Mar 18 2019, 2:59 PM · efl

Mar 10 2019

kimcinoo added a comment to D8281: ui.widget: enhance documentation of sub_object_add.

+1

Mar 10 2019, 7:59 PM · efl

Mar 6 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Rebase

Mar 6 2019, 6:10 PM · efl
kimcinoo updated the summary of D8105: edje_calc: add ERR message to find out incorrect size problem.
Mar 6 2019, 2:48 AM · efl
kimcinoo requested review of D8105: edje_calc: add ERR message to find out incorrect size problem.
Mar 6 2019, 2:41 AM · efl
kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Remove change not related to use of TO_INT_ROUND.

Mar 6 2019, 2:28 AM · efl

Mar 5 2019

kimcinoo closed D7246: atspi: Send key events synchronously.
Mar 5 2019, 12:03 AM · efl

Mar 4 2019

kimcinoo requested review of D8099: evas: make convert_rgb_32 keep consistency.
Mar 4 2019, 11:40 PM · efl

Feb 24 2019

kimcinoo added inline comments to D7842: edje_calc: make INTP use TO_INT_ROUND.
Feb 24 2019, 11:48 PM · efl

Feb 20 2019

kimcinoo requested review of D7973: evas_object_image: render_post returns if preloading..
Feb 20 2019, 10:57 PM · efl

Feb 13 2019

kimcinoo added a comment to D7934: Efl.Gfx.Stack: Rename raise and lower.

"bring to front"
"send to back"
which is same with EVIL's PowerPoint.
Please never mind. :-P

Feb 13 2019, 1:49 PM · efl

Feb 12 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

If final value is calculated by TO_INT_ROUND, then make _edje_part_pixel_adjust
use TO_INT_ROUND for eval value as well.

Feb 12 2019, 4:06 AM · efl

Feb 1 2019

kimcinoo updated the diff for D7842: edje_calc: make INTP use TO_INT_ROUND.

Fix one more incorrect calculation.
The _edje_part_pixel_adjust could change final.w(h) value to -1.
This value is using in the _edje_part_recalc_single_rel, and has caused
incorrect position.

Feb 1 2019, 3:52 AM · efl

Jan 31 2019

kimcinoo updated the test plan for D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:33 AM · efl
kimcinoo updated the summary of D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:31 AM · efl
kimcinoo requested review of D7842: edje_calc: make INTP use TO_INT_ROUND.
Jan 31 2019, 2:30 AM · efl

Jan 24 2019

kimcinoo requested review of D7767: evas_clip: do not set clip->changed to true.
Jan 24 2019, 10:49 PM · efl

Jan 8 2019

kimcinoo added a comment to D7557: elementary genlist: make it sure object type..

+2

Jan 8 2019, 1:47 PM · efl

Jan 2 2019

kimcinoo added a comment to D7507: elementary: rename Efl.Ui.Translatable -> Efl.Ui.L10n.

IMO i18n (https://phab.enlightenment.org/D7506) and l10n of EFL correspond with https://www.w3.org/International/questions/qa-i18n
Now I have got difference between i18n and l10n. Thank you.

Jan 2 2019, 3:10 PM · efl

Dec 30 2018

kimcinoo added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Interesting :D

Dec 30 2018, 2:05 PM · efl
kimcinoo added a comment to D7441: eo: add the ability to get the size of object of a certain class..

I would like to want to know why eo needs 'the ability to get the size of object of a certain class' ?

Dec 30 2018, 2:02 PM · efl

Dec 26 2018

kimcinoo added a comment to D7512: evas textblock: fix render_pre bug related with clipper.

+2048

Dec 26 2018, 1:43 AM · efl

Dec 18 2018

kimcinoo updated the diff for D7425: efl_ui_win: make win work for evas_norender.

Handle potential side effect

Dec 18 2018, 2:40 AM · efl

Dec 6 2018

kimcinoo added a comment to D7427: evas: remove memory leaks from deleted Textblock objects.

+1

Dec 6 2018, 10:42 PM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..

I am sorry there would be a small typo.

Dec 6 2018, 3:46 AM · efl
kimcinoo updated the test plan for D7425: efl_ui_win: make win work for evas_norender.
Dec 6 2018, 3:08 AM · efl
kimcinoo requested review of D7425: efl_ui_win: make win work for evas_norender.
Dec 6 2018, 2:59 AM · efl
kimcinoo added reviewers for D7424: Efl.Access: Separate event handle function from Efl.Access.Object.: stanluk, l.oleksak.
Dec 6 2018, 12:55 AM · efl
kimcinoo requested changes to D7424: Efl.Access: Separate event handle function from Efl.Access.Object..
Dec 6 2018, 12:55 AM · efl

Nov 29 2018

kimcinoo accepted D7392: ecore: fix typo in comments..

No doubt

Nov 29 2018, 4:44 PM · efl

Nov 28 2018

kimcinoo added a comment to D6870: evas cache image: compare with cached image file.

This is not standing for the cache2. I just quoted comment of the cache2.
This is standing for the cache.

Nov 28 2018, 8:50 PM · efl
kimcinoo updated the summary of D7344: evas map: calc map geometry when it is out of screen.
Nov 28 2018, 12:41 AM · efl

Nov 27 2018

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Follow naming convention.

Nov 27 2018, 11:51 PM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Update map geometry on correct place.

Nov 27 2018, 11:44 PM · efl
kimcinoo accepted D7370: gengrid : remove elm_access_text_set for code consistancy..
Nov 27 2018, 3:16 AM · efl