Page MenuHomePhabricator

kimcinoo (Shinwoo Kim)
EFL Slow Follower

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2013, 5:25 PM (339 w, 2 d)
Availability
Available

Recent Activity

Yesterday

kimcinoo added a comment to D9648: [WIP] efl_ui_filter: introduce filter widget.

Which approach is better among D9535, D9556 and this one?

Tue, Aug 20, 4:15 AM · efl
kimcinoo requested review of D9648: [WIP] efl_ui_filter: introduce filter widget.
Tue, Aug 20, 4:12 AM · efl

Mon, Aug 19

kimcinoo requested review of D9614: evas: fix png regression issue.
Mon, Aug 19, 1:38 AM · efl

Fri, Aug 16

kimcinoo retitled D9580: evas: fix png regression issue from evas: get back what we missed to evas: fix png regression issue.
Fri, Aug 16, 12:41 AM · efl

Thu, Aug 15

kimcinoo updated the summary of D9580: evas: fix png regression issue.
Thu, Aug 15, 11:26 PM · efl
kimcinoo updated the summary of D9580: evas: fix png regression issue.
Thu, Aug 15, 11:22 PM · efl
kimcinoo updated the summary of D9580: evas: fix png regression issue.
Thu, Aug 15, 11:21 PM · efl
kimcinoo added a comment to D9580: evas: fix png regression issue.

@cedric
(1) If it is possilbe and you do not mind, would you please let me know more about png_set_tRNS_to_alpha. I have no idea why the issue occurs without png_set_tRNS_to_alpha.
(2) The evas_image_load_file_data_png had used EINA_FILE_SEQUENTIAL for eina_file_map_all before the 9-patch commit. It could be another missing one. From the following change, your intention was that EINA_FILE_SEQUENTIAL should be used for pixels reading. Please make sure regarding this as well.

Thu, Aug 15, 11:18 PM · efl
kimcinoo updated the test plan for D9580: evas: fix png regression issue.
Thu, Aug 15, 11:04 PM · efl
kimcinoo requested review of D9580: evas: fix png regression issue.
Thu, Aug 15, 11:03 PM · efl

Tue, Aug 13

kimcinoo updated the summary of D9476: evas_map: draw what map did not draw before..
Tue, Aug 13, 1:27 AM · efl
kimcinoo updated the diff for D9476: evas_map: draw what map did not draw before..

Use changed_map.
Remove incorrect(unnecessary) move, resize callback call

Tue, Aug 13, 1:26 AM · efl
kimcinoo requested review of D9556: [WIP] Efl.Canvas.Group: implement Efl.Gfx.Filter interface.
Tue, Aug 13, 12:04 AM · efl

Mon, Aug 12

kimcinoo added a comment to D9476: evas_map: draw what map did not draw before..

if other properties has been changed such as texture uv, image, point color, smooth option, antialiasing, etc
Does here it needs to check out all the property diff?

Mon, Aug 12, 7:57 PM · efl
kimcinoo added a comment to D9476: evas_map: draw what map did not draw before..

I guess this function won't be triggered if user just make it object visible again without any map update,

Does this work properly?

Mon, Aug 12, 5:58 PM · efl

Sun, Aug 11

kimcinoo updated the summary of D9533: evas/textblock: optimize layouting when textblock has empty text.
Sun, Aug 11, 7:25 PM · efl
kimcinoo updated the summary of D9543: edje/style: Remove redundant style tags from style text..
Sun, Aug 11, 7:04 PM · efl

Fri, Aug 9

kimcinoo updated the summary of D9535: [WIP] Efl.Ui.Widget: implement Efl.Gfx.Blur interface.
Fri, Aug 9, 2:23 AM · efl
kimcinoo requested review of D9535: [WIP] Efl.Ui.Widget: implement Efl.Gfx.Blur interface.
Fri, Aug 9, 2:21 AM · efl

Thu, Aug 8

kimcinoo updated the diff for D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Fix crash issue and rendering issue on GL engine.
Remove incorrect error message. return value of ENFN->image_draw does not mean
that there is an unexpected error.

Thu, Aug 8, 4:06 AM · efl

Tue, Aug 6

kimcinoo added a comment to D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Is there any reason that filter only targets to group object? but not a single canvas object?
We can generally support filter for all types of graphical objects.

Tue, Aug 6, 12:47 AM · efl
kimcinoo updated the diff for D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Set context clip using clipper.

Tue, Aug 6, 12:43 AM · efl

Mon, Aug 5

kimcinoo updated the summary of D9476: evas_map: draw what map did not draw before..
Mon, Aug 5, 4:35 AM · efl
kimcinoo updated the diff for D9476: evas_map: draw what map did not draw before..

do not use changed_map but add a condition to check spans->pts.

Mon, Aug 5, 4:28 AM · efl

Fri, Aug 2

kimcinoo added a comment to D9476: evas_map: draw what map did not draw before..

@Hermet
As we discussed at a meeting. I have checked if render_pre is called or not when rect's visibility is changed to hide from show.
The result is that the render_pre is called.
The procedure is following.

(1) hide rect
(2) _phase1_object_process, the is_active is true. 
   Please have a look into evas_object_is_active in this case. One of is_visible or was_visible is ture, then is_active could be true. 
   In case of smart object, there is a condition checking was_visible in _phase1_object_mapped.
(3) _phase1_object_changed_normal, push rect to render_objects
(4) _phase1_direct calls render_pre
Fri, Aug 2, 3:24 AM · efl

Thu, Aug 1

kimcinoo updated the test plan for D9476: evas_map: draw what map did not draw before..
Thu, Aug 1, 5:28 AM · efl
kimcinoo requested review of D9476: evas_map: draw what map did not draw before..
Thu, Aug 1, 5:27 AM · efl

Tue, Jul 23

kimcinoo updated the diff for D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Fix invalid memory read issue when obj size is changed.

Tue, Jul 23, 6:29 PM · efl

Mon, Jul 22

kimcinoo updated the diff for D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Apply changes of children

Mon, Jul 22, 10:31 PM · efl

Jul 22 2019

kimcinoo updated the diff for D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.

Use offset correctly when filter surface draws to default surface

Jul 22 2019, 12:59 AM · efl

Jul 18 2019

kimcinoo requested review of D9353: [WIP] Efl.Canvas.Group: support Efl.Gfx.Filter.
Jul 18 2019, 4:53 AM · efl

Jul 15 2019

kimcinoo accepted D9314: efl_ui_textpath: deprecate elm_textpath_circle_set().
Jul 15 2019, 4:46 AM · efl

Jul 12 2019

kimcinoo requested review of D9301: evas image: apply filter at runtime.
Jul 12 2019, 1:41 AM · efl

Jul 11 2019

kimcinoo closed D9281: test: add Efl.Ui.Format related test.
Jul 11 2019, 8:41 AM · efl
kimcinoo updated the summary of D9281: test: add Efl.Ui.Format related test.
Jul 11 2019, 5:03 AM · efl
kimcinoo requested review of D9281: test: add Efl.Ui.Format related test.
Jul 11 2019, 5:02 AM · efl
kimcinoo closed D9276: Efl.Ui.Format: fix regressions.
Jul 11 2019, 4:21 AM · efl
kimcinoo added a comment to D9261: efl_ui_textpath: deprecate elm_textpath_circle_set().

Why don't you add some more information such as "deprecated since 1.23 use elm_textpath_circular_set" ?

Jul 11 2019, 3:41 AM · efl
kimcinoo updated the diff for D9276: Efl.Ui.Format: fix regressions.

Use EINA_UNUSED correctly

Jul 11 2019, 3:33 AM · efl

Jul 10 2019

kimcinoo closed D9277: efl_ui_*: fix regressions on legacy side.
Jul 10 2019, 10:31 PM · efl
kimcinoo updated the diff for D9277: efl_ui_*: fix regressions on legacy side.

same case on Efl.Ui.Slider

Jul 10 2019, 8:36 PM · efl
kimcinoo requested review of D9277: efl_ui_*: fix regressions on legacy side.
Jul 10 2019, 8:20 PM · efl
kimcinoo updated the summary of D9276: Efl.Ui.Format: fix regressions.
Jul 10 2019, 7:57 PM · efl
kimcinoo updated the diff for D9276: Efl.Ui.Format: fix regressions.

One more uninitialized variable from progressbar.

Jul 10 2019, 7:53 PM · efl
kimcinoo updated the diff for D9276: Efl.Ui.Format: fix regressions.

Fix one more uninitialized variable

Jul 10 2019, 7:42 PM · efl
kimcinoo updated the diff for D9276: Efl.Ui.Format: fix regressions.

elm_slider: fix uninitialized variable

Jul 10 2019, 7:37 PM · efl
kimcinoo requested review of D9276: Efl.Ui.Format: fix regressions.
Jul 10 2019, 5:54 PM · efl

Jul 8 2019

kimcinoo added a comment to D9183: evas_render: add restacked mapped obj to redraws rect.

Reviewed on https://review.tizen.org/gerrit/#/c/platform/upstream/efl/+/209046/ while phab was down.

Jul 8 2019, 8:15 PM · efl
kimcinoo closed D9183: evas_render: add restacked mapped obj to redraws rect.
Jul 8 2019, 8:05 PM · efl
kimcinoo updated the summary of D9183: evas_render: add restacked mapped obj to redraws rect.
Jul 8 2019, 7:37 PM · efl
kimcinoo updated the diff for D9183: evas_render: add restacked mapped obj to redraws rect.

Push restacked mapped object to restack_objs array

Jul 8 2019, 7:30 PM · efl

Jun 26 2019

kimcinoo updated the test plan for D9183: evas_render: add restacked mapped obj to redraws rect.
Jun 26 2019, 2:47 PM · efl
kimcinoo updated the test plan for D9183: evas_render: add restacked mapped obj to redraws rect.
Jun 26 2019, 5:54 AM · efl
kimcinoo updated the summary of D9183: evas_render: add restacked mapped obj to redraws rect.
Jun 26 2019, 5:52 AM · efl
kimcinoo updated the diff for D9183: evas_render: add restacked mapped obj to redraws rect.

Enhance commit message

Jun 26 2019, 5:48 AM · efl
kimcinoo updated the diff for D9183: evas_render: add restacked mapped obj to redraws rect.

Use correct comment

Jun 26 2019, 5:44 AM · efl
kimcinoo requested review of D9183: evas_render: add restacked mapped obj to redraws rect.
Jun 26 2019, 5:38 AM · efl

Jun 17 2019

kimcinoo added a comment to D9085: evas filter: make curve work for every.

The point here is, logically, the outbuf should be used as outter, not temporary. That's why we are saying it outbuf.

Now it's turned out that, curve requires temporary buffer always, grow buffer shouldn't use outbufer as temporary since it must have a temporary buffer.

Jun 17 2019, 10:49 PM · efl

Jun 14 2019

kimcinoo added a comment to D9085: evas filter: make curve work for every.

Honestly I do not get what "Currently growbuf == outbuf is out of date." is. Do you mean that the outbuf is out of date, because it is same with growbuf? And is that for the first case that the outbuf is not dirty?

Jun 14 2019, 2:45 AM · efl

Jun 12 2019

kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Update comment.

Jun 12 2019, 11:41 PM · efl
kimcinoo added a comment to D9085: evas filter: make curve work for every.

And It's very suspicious at this condition.

1288 if ((inbuf != outbuf) && out->dirty)

This condition might be related with this issue... Something make it out of the condition ...

Jun 12 2019, 11:38 PM · efl
kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Use a temp buffer on grow_add side as well to reduce calling blend_add based on
valuable hermet's comment.

Jun 12 2019, 11:28 PM · efl
kimcinoo added a comment to D7344: evas map: calc map geometry when it is out of screen.

Let me know more about 'map object'. Does it mean the object using Evas_Map such as button of evas_object_map_set(button, map)?

Jun 12 2019, 3:40 AM · efl
kimcinoo updated the test plan for D9085: evas filter: make curve work for every.
Jun 12 2019, 2:32 AM · efl
kimcinoo updated the test plan for D9085: evas filter: make curve work for every.
Jun 12 2019, 2:32 AM · efl
kimcinoo updated the diff for D9085: evas filter: make curve work for every.

Use correct name blendcmd instead of curvecmd

Jun 12 2019, 2:10 AM · efl
kimcinoo requested review of D9085: evas filter: make curve work for every.
Jun 12 2019, 2:07 AM · efl

Jun 4 2019

kimcinoo added a comment to D9068: evas_out: add condition for efl_canvas_output_view_set.

It would be better if we have enhanced documentation and related TC as well. Thank you.

Jun 4 2019, 2:46 PM · efl

May 23 2019

kimcinoo updated the diff for D8930: Efl.Ui.Textpath: fix a size problem.

Enhanced based on comment. This is much more neat!

May 23 2019, 1:46 AM · efl

May 21 2019

kimcinoo added reviewers for D8930: Efl.Ui.Textpath: fix a size problem: Hermet, jsuya.
May 21 2019, 5:48 AM · efl
kimcinoo requested review of D8930: Efl.Ui.Textpath: fix a size problem.
May 21 2019, 5:47 AM · efl

May 20 2019

kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comment.

May 20 2019, 8:52 PM · efl
kimcinoo requested review of D8924: Efl.Ui.Textpath: draw text immediately in the position.set.
May 20 2019, 4:51 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comment.

May 20 2019, 4:10 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Remove unintended lines.

May 20 2019, 3:14 AM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Update based on comments.

May 20 2019, 3:11 AM · efl

May 14 2019

kimcinoo added a comment to D8892: Efl.Ui.Textpath: support center align for each direction.
  1. I've considered for the interface, how about using align_hint ?

If the "using align_hint" means kind of "using Efl.Gfx.Hint.hint_align", it could be more flexible than using these enums. But it seems that you did not mean Efl.Gfx.Hint.hint_align because this is hint on how to align an object inside its container.

May 14 2019, 2:57 PM · efl
kimcinoo updated the diff for D8892: Efl.Ui.Textpath: support center align for each direction.

Remove unrelated changes

May 14 2019, 4:36 AM · efl
kimcinoo requested review of D8892: Efl.Ui.Textpath: support center align for each direction.
May 14 2019, 4:33 AM · efl

May 12 2019

kimcinoo updated the diff for D8875: Efl.Ui.Textpath: enhance to support legacy API.

Update based on a comment saying make it simpler

May 12 2019, 5:55 PM · efl

May 10 2019

kimcinoo updated the diff for D8875: Efl.Ui.Textpath: enhance to support legacy API.

fix typo

May 10 2019, 4:31 AM · efl
kimcinoo requested review of D8875: Efl.Ui.Textpath: enhance to support legacy API.
May 10 2019, 4:29 AM · efl

May 6 2019

kimcinoo accepted D8837: evas_render: deduplicate mapped mask render code.

+1024

May 6 2019, 8:00 PM · efl: rendering

May 2 2019

kimcinoo added a comment to D8719: gfx_filter: add an example.

The warning probably comes from

May 2 2019, 6:00 PM · efl
kimcinoo closed D8719: gfx_filter: add an example.
May 2 2019, 9:15 AM · efl
kimcinoo added a comment to D8719: gfx_filter: add an example.

@bu5hm4n
(1) Are you using gl engine?
(2) What is the result of eina_btlog?
(3) The result would be not caused by incorrect example.

May 2 2019, 5:16 AM · efl

May 1 2019

kimcinoo updated the diff for D8719: gfx_filter: add an example.

(Oooops... sorry...) Warnings are removed.

May 1 2019, 11:57 PM · efl
kimcinoo closed D8802: efl_ui_animation_view: Set max progress when play back..
May 1 2019, 11:46 PM · efl
kimcinoo accepted D8802: efl_ui_animation_view: Set max progress when play back..
May 1 2019, 11:46 PM · efl
kimcinoo requested changes to D8802: efl_ui_animation_view: Set max progress when play back..

sorry, this is a change to test arc

May 1 2019, 11:46 PM · efl
kimcinoo closed D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 11:44 PM · efl
kimcinoo accepted D8801: efl_ui_animation_view: Set PLAY state before call "start" callback..
May 1 2019, 11:24 PM · efl

Apr 29 2019

kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Remove unnecessary changes

Apr 29 2019, 5:25 AM · efl
kimcinoo updated the diff for D7344: evas map: calc map geometry when it is out of screen.

Amend based on comments

Apr 29 2019, 5:20 AM · efl
kimcinoo added a comment to D8757: embryo_cc: Fix longjmp clobbering warning..

Um... no details?

Apr 29 2019, 4:25 AM · efl

Apr 28 2019

kimcinoo updated the diff for D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.

Amend based on comments

Apr 28 2019, 11:44 PM · efl
kimcinoo added inline comments to D8516: evas_object_image: save EVAS_IMAGE_CONTENT_HINT_DYNAMIC image.
Apr 28 2019, 11:42 PM · efl
kimcinoo updated the diff for D8719: gfx_filter: add an example.

Add this to the meson build file

Apr 28 2019, 7:18 PM · efl

Apr 26 2019

kimcinoo requested review of D8719: gfx_filter: add an example.
Apr 26 2019, 1:21 AM · efl

Apr 25 2019

kimcinoo closed D8711: efl_ui_animation_view: Remove docs in set/get..
Apr 25 2019, 1:33 AM · efl