Page MenuHomePhabricator

kwo (Kim Woelders)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jan 27 2013, 2:13 AM (321 w, 2 d)
Availability
Available

Recent Activity

Nov 4 2018

kwo closed T5690: A click in top left corner of screen makes menu appear as Invalid.

No response - Closing.

Nov 4 2018, 1:10 AM · Restricted Project

Oct 5 2018

kwo added a comment to T5690: A click in top left corner of screen makes menu appear.

Sorrry about the late reply.. anyway..

Oct 5 2018, 8:50 AM · Restricted Project

Sep 29 2018

kwo claimed T5690: A click in top left corner of screen makes menu appear.
Sep 29 2018, 9:47 AM · Restricted Project

Jul 22 2018

kwo closed T5416: Missing text in image when displayed with imlib2 as Resolved.
Jul 22 2018, 12:47 AM · Unknown Object (Project), Bug Report
kwo closed T7173: imlib2-1.5.1 attempts to use x-shm-fd when X is running via ssh X11Forwarding as Invalid.
Jul 22 2018, 12:47 AM · Unknown Object (Project)
kwo added a comment to T5416: Missing text in image when displayed with imlib2.

Sorry, I didn't notice this bug report until recently.
I think the issue is fixed in git now.
Thanks for reporting :)

Jul 22 2018, 12:20 AM · Unknown Object (Project), Bug Report

Jul 20 2018

kwo claimed T7173: imlib2-1.5.1 attempts to use x-shm-fd when X is running via ssh X11Forwarding.

Both issues (lockup, log flooding) are Xorg bugs, although triggered by attempting to use MIT-SHM with fd passing over ssh (AFAIUI), which is new in imlib2-1.5.
Both issues are fixed in Xorg (haven't tested it though).
The flooding fix (https://cgit.freedesktop.org/xorg/xserver/commit/?id=d36128a72acac4d54813c52c93efefad2dc9af41) is in server version 1.20.
The lockup fix (https://cgit.freedesktop.org/xorg/xserver/commit/?id=ec7e2b54c5b4a34b2a077082967bc3ead30e227e) is only on master.

Jul 20 2018, 11:28 PM · Unknown Object (Project)
kwo claimed T5416: Missing text in image when displayed with imlib2.
Jul 20 2018, 9:10 PM · Unknown Object (Project), Bug Report

Mar 11 2018

kwo renamed T6743: Imlib2: Please add support for svg images from Please add support for svg images to Imlib2: Please add support for svg images.
Mar 11 2018, 10:46 AM · Unknown Object (Project)
kwo closed T6747: imlib2: unable to load gifs after loading another image as Resolved.

Assuming fixed long ago.

Mar 11 2018, 10:42 AM · Unknown Object (Project)

Mar 10 2018

kwo added a project to T6744: imlib2: Please add support for JPEG2000: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6743: Imlib2: Please add support for svg images: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6745: imlib2: Please add support for webp: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6749: imlib2: infinite loop with invalid bmp images: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6747: imlib2: unable to load gifs after loading another image: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6746: imlib2: XPM loader: uninitialized memory read: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6748: imlib2: cannot rescale+render images > 32767 width: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6750: imlib2: imlib_get_text_size() and imlib_text_draw_with_return_metrics() return different width: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6751: imlib2 does not load acii PNM files correctly: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a project to T6752: imlib2: fails to build from source when HAVE_X11_SHM_FD is not defined: Unknown Object (Project).
Mar 10 2018, 12:22 PM · Unknown Object (Project)
kwo added a comment to T6748: imlib2: cannot rescale+render images > 32767 width.

Correction - strike "(libpng apparently dislikes the image)" - the png loader just doesn't interact properly with libpng in various error cases.

Mar 10 2018, 5:28 AM · Unknown Object (Project)
kwo closed T6748: imlib2: cannot rescale+render images > 32767 width as Resolved.

This was reported 24 Apr 2015 so that was probably imlib2 1.4.6/7/8.
In 1.4.9 the maximum image dimension was lowered to 32767, so the shift/overflow/crash problem should no longer occur.
However, it appears that the png loader is buggy so imlib_load_image("test.png") returns an invalid image (no pixel data) instead of a null pointer (libpng apparently dislikes the image).
I'll deal with that separately.

Mar 10 2018, 3:19 AM · Unknown Object (Project)

Mar 9 2018

kwo closed T6751: imlib2 does not load acii PNM files correctly as Resolved.

Should now be fixed in git.
The committed fix is somewhat more radical than the suggested one.

Mar 9 2018, 1:11 PM · Unknown Object (Project)
kwo closed T6750: imlib2: imlib_get_text_size() and imlib_text_draw_with_return_metrics() return different width as Resolved.

I think that was fixed here: https://git.enlightenment.org/legacy/imlib2.git/commit/?id=9686658a3cea3b81cbed60424cadc29374c2ed09 (in 1.4.3).

Mar 9 2018, 9:46 AM · Unknown Object (Project)

Mar 7 2018

kwo added a comment to T6747: imlib2: unable to load gifs after loading another image.

I cannot reproduce this.
Tested with the imgif test program and giflib-5.1.4.

Mar 7 2018, 12:39 PM · Unknown Object (Project)
kwo closed T6749: imlib2: infinite loop with invalid bmp images as Resolved.

Should now be fixed in git.

Mar 7 2018, 11:29 AM · Unknown Object (Project)
kwo closed T6746: imlib2: XPM loader: uninitialized memory read as Resolved.

Should now be fixed in git.

Mar 7 2018, 10:50 AM · Unknown Object (Project)
kwo closed T6752: imlib2: fails to build from source when HAVE_X11_SHM_FD is not defined as Resolved.

Oops - embarrassing - should be fixed in git now.

Mar 7 2018, 10:49 AM · Unknown Object (Project)

Feb 5 2018

kwo accepted D5788: Add support for MIT-SHM FD-passing.

Looks good to me.

Feb 5 2018, 9:26 PM
kwo added a comment to D5788: Add support for MIT-SHM FD-passing.

No fallback to regular - sounds reasonable.

Feb 5 2018, 10:04 AM
kwo added a comment to D5787: introduce __imlib_ShmDestroyXImage() instead of __imlib_ShmDetach().

No, it's fine, I figured out to use arc.

Feb 5 2018, 9:55 AM
kwo added inline comments to D5788: Add support for MIT-SHM FD-passing.
Feb 5 2018, 7:47 AM
kwo accepted D5787: introduce __imlib_ShmDestroyXImage() instead of __imlib_ShmDetach().

Looks good to me.

Feb 5 2018, 7:00 AM

Feb 3 2018

kwo added a comment to D5788: Add support for MIT-SHM FD-passing.

Looks good to me otherwise, and even seems to work :)

Feb 3 2018, 9:05 AM
kwo added inline comments to D5787: introduce __imlib_ShmDestroyXImage() instead of __imlib_ShmDetach().
Feb 3 2018, 12:06 AM

Feb 1 2018

kwo accepted D5783: put a check for shared memory inside __imlib_ShmGetXImage().

Looks good to me.
I'm not familiar with Phabricator etc., so what now?
If you send me a regular git patch I can commit that so you can get appropriately attributed.

Feb 1 2018, 8:01 AM

Apr 13 2016

kwo closed D3891: Fix cross-endianness for masks (1-bit depth images).
Apr 13 2016, 1:16 PM
kwo accepted D3891: Fix cross-endianness for masks (1-bit depth images).
Apr 13 2016, 1:16 PM
kwo added a comment to D3891: Fix cross-endianness for masks (1-bit depth images).

Pushed.
I can't test this but it seems to match what is done elsewhere.

Apr 13 2016, 1:15 PM

Aug 28 2015

kwo committed rESIXfb9325ac9413: Use AC_USE_SYSTEM_EXTENSIONS. (authored by kwo).
Use AC_USE_SYSTEM_EXTENSIONS.
Aug 28 2015, 7:32 AM
kwo committed rESIXa3d74c32504d: Build .xz tarball too. (authored by kwo).
Build .xz tarball too.
Aug 28 2015, 7:32 AM
kwo committed rESIX7fecba2dbe85: 1.0.17.000. (authored by kwo).
1.0.17.000.
Aug 28 2015, 7:32 AM

Aug 19 2015

kwo committed rADEVS9984c03c2d85: Remove old key. (authored by kwo).
Remove old key.
Aug 19 2015, 4:27 AM
kwo committed rADEVS56aecacc75eb: New key. (authored by kwo).
New key.
Aug 19 2015, 4:06 AM

Jul 18 2015

kwo committed rESIX238d9f8200db: 1.0.17. (authored by kwo).
1.0.17.
Jul 18 2015, 11:32 AM

Jun 22 2015

kwo committed rESIXcf7d68ec4f51: 1.0.16.002. (authored by kwo).
1.0.16.002.
Jun 22 2015, 11:52 AM
kwo committed rESIXf0d6964caee8: Update po. (authored by kwo).
Update po.
Jun 22 2015, 11:52 AM
kwo committed rESIX02e023bb331c: Set NorthWestGravity when applying snapshot location. (authored by kwo).
Set NorthWestGravity when applying snapshot location.
Jun 22 2015, 11:15 AM
kwo committed rESIX08ad426b8b81: Fix ignoring ConfigureRequest from application. (authored by kwo).
Fix ignoring ConfigureRequest from application.
Jun 22 2015, 11:15 AM

Jun 18 2015

kwo committed rESIX4c8af1fda8ad: Require render version 0.11 before using XRenderCreateSolidFill(). (authored by kwo).
Require render version 0.11 before using XRenderCreateSolidFill().
Jun 18 2015, 2:51 PM

May 3 2015

kwo committed rESIXf4b11e47ec63: Fix stacking when there is only one window. (authored by kwo).
Fix stacking when there is only one window.
May 3 2015, 1:24 PM
kwo committed rESIX87ba89d9b442: Fixes for various build corner cases. (authored by kwo).
Fixes for various build corner cases.
May 3 2015, 1:24 PM
kwo committed rESIXeedd3f6789df: Use gettext 0.18. (authored by kwo).
Use gettext 0.18.
May 3 2015, 1:24 PM
kwo committed rESIXcd095e16370e: Eliminate deprecated usleep(). (authored by kwo).
Eliminate deprecated usleep().
May 3 2015, 1:24 PM