Page MenuHomePhabricator

kwo (Kim Woelders)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Jan 27 2013, 2:13 AM (514 w, 1 d)
Availability
Available

Recent Activity

May 9 2022

kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

Yeah, I agree that it was somewhat ambiguous.
I have changed the option to --enable-no-container, off by default.
So now all "experimental" options are off by default and must be --enabled to become active.
Hope that's better.

May 9 2022, 6:57 AM · Restricted Project

May 8 2022

kwo added a comment to T9008: Imlib2: doesn't load bz2 files with wrong extension.

Yeah, I think that this more or less intentionally has not worked ever (same thing with .gz and .xz loaders).
It is quite trivial to fix, but are there good reasons one way or the other - to allow this or leave it as is?
The next issue might become that if you rename pic.png.bz2 to pic.foo.bz2 that image won't load.
But that may be ok - avoiding potentially wasting time on decompressing stuff that probably doesn't contain an image anyway.
Should the file name only be used to speed up loader search (i.e. eventually relying only on file content) or should the file name have some significance?
Maybe add an option to select "naming strictness"? ... Maybe some day :)

May 8 2022, 10:46 AM · Restricted Project
kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

Ok, the --disable-container is in the "DO NOT USE" department and I am aware of other bugs with that setting. It's really just an experimental thing for me to play with.
Likewise with many of the other "DO NOT USE" options. If it doesn't cause you trouble then fine, otherwise bad luck, don't use it.
And --disable-container is particularly non-useful for users in general (and particularly likely to cause focus problems).

May 8 2022, 7:31 AM · Restricted Project

Apr 29 2022

kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

... the debug setting should be 1:7:8:129 to include enter/leave events.

Apr 29 2022, 4:11 AM · Restricted Project
kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

I still cannot reproduce this.
Reverting commit dd2c51ec effectively just disables the request serial number check (until the serial number becomes large, and then focusing will stop) in FocusHandleEnter() which causes other problems (although I cannot remember exactly which).
Does disabling the serial number check fix your problem (without reverting dd2c51ec)?
Could it be an X-server related issue? Which version are you using?
Could it be an e16 build thing? You seem to have a non-default build, e.g. GLX enabled, so what are your build options?
Could it be a theme thing? Does this happen with the winter theme?
Could you try running (an unmodified e16 from git) with environment variable EDEBUG=1:129 (or do "eesh debug events 1:129" when running) and log stdout during a session where the problem occurs?
Do I understand correctly that you see the problem just by having xterm's and/or urvxt's stacked on top of each other and closing them with Ctrl-D?

Apr 29 2022, 3:35 AM · Restricted Project

Apr 27 2022

kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

Sorry, I simply cannot reproduce this with 1.0.24 or current git at all.

Apr 27 2022, 9:10 PM · Restricted Project

Apr 22 2022

kwo closed T9005: Undocumented next/prev/mode? commands for eesh focus in E16 1.0.24 as Resolved.

They may as well be documented, I guess, so done.
However, the next and prev commands are rather obscure and I have considered removing them on numerous occasions.
Are you actually using them?

Apr 22 2022, 8:01 AM · Restricted Project
kwo added a comment to T9000: E16 feature-request: gadgets on the root-window.

I had forgotten all about that script. I have never really used it as it plays poorly with pagers with borders.
I have pushed a fix that makes stacking below optional, and added above option.
I'll probably take a look at the border issue too.

Apr 22 2022, 4:33 AM · Restricted Project

Apr 21 2022

kwo added a comment to T9001: imlib2: unable cope with svgs that has percentage as h/w.

Should be fix now for real. Worked only in debug-enabled build before. Sorry :)

Apr 21 2022, 1:23 AM · Restricted Project

Apr 19 2022

kwo added a comment to T9000: E16 feature-request: gadgets on the root-window.

The "Extended Window Manager Hints" specification (a standard defining common window manager/client interactions) defines only Above and Below (_NET_WM_STATE_ABOVE/BELOW) and implicitly Normal as neither Above nor Below.
Beyond that the stacking is specific to e16.
e16 internally works with "layers", some of which can be selected via the Window Options menu; 2=Below, 4=Normal, 6=Above, 8=On Top. A window will never be covered by one in a lower layer, but windows in the same layer may be raised/lowered with respect to each other.
There is stuff below Below - layer 1 which is not used for anything particular and layer 0 used for desktop type applications (_NET_WM_WINDOW_TYPE_DESKTOP), and there is stuff above On Top, e.g. e16 dialogs and menus.
I have changed the menu to

  • Lowest (layer 1, new)
  • Below
  • Normal
  • Above
  • Highest (layer 8, like before)
Apr 19 2022, 5:43 AM · Restricted Project

Apr 18 2022

kwo closed T9001: imlib2: unable cope with svgs that has percentage as h/w as Resolved.

I think this should be fixed in git.
Thanks :)

Apr 18 2022, 11:18 AM · Restricted Project

Apr 16 2022

kwo added a comment to T9000: E16 feature-request: gadgets on the root-window.

It seems to me there are two issues:

  1. Stacking

By default Pager and iconboxes are stacked at the "Normal" layer (layer 4), the same as all regular clients.
If your pagers etc. are stacked "Below" I think you must have put them there.
Stacking "Below" sets the stacking layer to 2. You can stack windows below that, at layer 1, with "eesh wop CLIENT layer 1".
You can use "eesh wop CLIENT layer ?" to query the layer.

  1. The root menus

I have just added an option to "pass through" pointer events on client windows "eesh wop CLIENT pass_ptr [on|off]".
Haven't tested it much but it may do what you are looking for.
If it's a good thing it should probably be added to one of the winops menus.

Apr 16 2022, 2:33 AM · Restricted Project

Apr 3 2022

kwo closed T8876: imlib2: Native support for AVIF as Resolved.

Right, most avif's I have tested do seem to be handled properly, although some are not, haven't figured out why. But let's deal with that some other day, when maybe someone comes with some insight :)

Apr 3 2022, 5:55 AM

Mar 6 2022

kwo added a comment to T8726: imlib2: Read image from memory (instead of a file).

Yeah, maybe. I've been considering making some more radical changes in the loader API though.

Mar 6 2022, 5:33 AM · Restricted Project
kwo reopened T8726: imlib2: Read image from memory (instead of a file) as "Open".

I have been thinking about doing something along those lines too :)

Mar 6 2022, 3:54 AM · Restricted Project

Feb 19 2022

kwo closed T8877: imlib2: Native support for HEIF as Resolved.

Right, closing :)

Feb 19 2022, 9:38 AM · efl

Feb 2 2022

kwo closed T8972: No focus after closing window in E16 1.0.24 as Invalid.

No response - Closing.

Feb 2 2022, 8:01 PM · Restricted Project

Jan 28 2022

kwo closed D12267: imlib2: added loader for HEIF files (uses libheif), implemented just `load2` for now.
Jan 28 2022, 11:37 PM · efl
kwo accepted D12267: imlib2: added loader for HEIF files (uses libheif), implemented just `load2` for now.

Updated patch received by email pushed.

Jan 28 2022, 11:37 PM · efl

Jan 25 2022

kwo added a comment to D12267: imlib2: added loader for HEIF files (uses libheif), implemented just `load2` for now.

I'm sorry about your trouble with phabricator. Unfortunately I'm not able to help you with that.
The easiest thing to do in that department would probably be to open a new issue.
If you could simply send me (kim@woelders.dk) a git patch based on current master that would be fine with me (and probably easiest too).
And could you please also point me in the direction of some samples to test the loader with?

Jan 25 2022, 12:03 AM · efl

Jan 21 2022

kwo closed T8987: Imlib2 fails to build on Ubuntu as Resolved.
Jan 21 2022, 12:43 PM · Restricted Project
kwo added a comment to T8987: Imlib2 fails to build on Ubuntu.

Ok, thanks, I was just curious :)
I have pushed a commit fixing the issue, I think.

Jan 21 2022, 7:40 AM · Restricted Project
kwo added a comment to T8987: Imlib2 fails to build on Ubuntu.

Right, I'll fix that.
Could you please let me know which compiler and options you are using?
Thanks :)

Jan 21 2022, 2:56 AM · Restricted Project

Jan 10 2022

kwo closed T6743: Imlib2: Please add support for svg images as Resolved.

SVG loader implemented.
It even seems to work :)

Jan 10 2022, 12:41 AM · Restricted Project

Dec 20 2021

kwo closed T8973: No focus while new window is being moved in E16 1.0.24 as Resolved.

Should now be fixed in git.
Thanks for reporting :)

Dec 20 2021, 9:58 PM · Restricted Project

Dec 19 2021

kwo added a comment to T8972: No focus after closing window in E16 1.0.24.

Hmm.. I cannot reproduce this.
Does it matter which applications the upper and lower are?
How do you close the window?
Please provide the rest of your configuration.

Dec 19 2021, 10:28 AM · Restricted Project
kwo closed T8969: Imlib2: Some performance issues as Resolved.

I have added some support for multi-frame images. webp and gif (and ico) loaders now support loading multi-frame images. Example usage in imlib2_view (somewhat conveluted, mostly for debug).
I'll close this issue now as there has been no follow-up on the performance issues.

Dec 19 2021, 7:04 AM · Restricted Project

Nov 29 2021

kwo added a comment to T8969: Imlib2: Some performance issues.

Pushed.
Yeah, it looks like my uninitialized iter usually had num_frames set so some large value so it seemed to work.
I' m fine with patches like this or sent to me directly, kim@woelders.dk.
Thanks :)

Nov 29 2021, 9:18 AM · Restricted Project

Nov 22 2021

kwo added a comment to T8969: Imlib2: Some performance issues.

1: If you don't have the "workaround", imlib2 will grab the X window content, blend the image onto the grabbed copy, and then write the blended result back.
If you do have the workaround you will do the blending in a forward flow not involving the X server and just write the result.
So wrt. X operations the first is like read-modify-write whereas the second is just write.
Non-alpha images don't need a blend so you can just do a write.
Since X-operations are relatively expensive (and particularly reads cause round-trip delays) it is always important to avoid them when possible.

Nov 22 2021, 11:18 AM · Restricted Project

Nov 21 2021

kwo added a comment to T8726: imlib2: Read image from memory (instead of a file).

You are right, of course. I may get around to sort that out some day :)

Nov 21 2021, 8:50 AM · Restricted Project

Nov 6 2021

kwo added a comment to T8964: imlib2: fails to load first frame of animated webp.

The build problem should be fixed now, thanks.

Nov 6 2021, 1:39 PM · Restricted Project
kwo added a comment to T8964: imlib2: fails to load first frame of animated webp.

I have only tested with two animated (and some non-amimated) webp images I happend to have.
If you have trouble with particular images could you please attach one or more examples or otherwise make them available to me?

Nov 6 2021, 8:17 AM · Restricted Project

Nov 5 2021

kwo added a comment to T8964: imlib2: fails to load first frame of animated webp.

Showing (first frame of) animated webp should now work in current git.

Nov 5 2021, 9:54 AM · Restricted Project

Nov 4 2021

kwo added a comment to T8964: imlib2: fails to load first frame of animated webp.

Right, I'll take at look at that.

Nov 4 2021, 12:20 AM · Restricted Project

Nov 1 2021

kwo added a comment to T8726: imlib2: Read image from memory (instead of a file).

Correct, imlib_load_image_fd(). imlib_load_image_from_fd() has only existed in my incorrect comments.
And yes, as is imlib2 cannot read an image from a pipe.

Nov 1 2021, 3:14 AM · Restricted Project

Sep 16 2021

kwo closed T8957: imlib2: Unable to load extension-less images as Resolved.

Already fixed in git. Will be in v1.7.4.

Sep 16 2021, 8:39 AM · Restricted Project

Sep 15 2021

kwo added a comment to T8957: imlib2: Unable to load extension-less images.

This problem was just fixed in git (yesterday). It was a regression since 1.6.x.
Imlib2 uses the file name extension only as a first guess. After that it tries all loaders.
All loaders do signature checks like you describe.
Thanks for reporting :)

Sep 15 2021, 8:28 PM · Restricted Project

Aug 12 2021

kwo closed T8953: imlib2 1.7.3 tarballs missing as Resolved.

Gah! Done.
Thanks :)

Aug 12 2021, 1:53 AM · Restricted Project

Aug 10 2021

kwo added a comment to D12267: imlib2: added loader for HEIF files (uses libheif), implemented just `load2` for now.

Hello Colocasian,
Being the imlib2 maintainer I probably should have made sure to get notifications about relevant phab issues (I think I will now).
Anyway, I just stumbled over the heif etc. stuff.
I have a couple of comments, otherwise it looks good to me.

Aug 10 2021, 9:58 AM · efl

Jul 15 2021

kwo added a comment to T8945: Maximized (new) windows unable to receive the focus.

I think this should now be fixed in git.

Jul 15 2021, 9:48 PM · Restricted Project

Jul 12 2021

kwo added a comment to T8945: Maximized (new) windows unable to receive the focus.

Ok, maybe I see it too.
Does the problem go away if you disable "Animate window maximization" (misc.movres.maximize_animate)?

Jul 12 2021, 12:52 PM · Restricted Project

Jul 11 2021

kwo added a comment to T8948: Touchscreen taps in E16 Pager.

Hmm.. e16 only deals with X11 pointer events and does not use libinput.
e16 does not know of (or at least care about) the type of input device.
Any difference in behavior between touchpad/mouse and touchscreen behavior must somehow come from the configuration of these devices which lies outside e16.
Maybe you can figure out what is going on by trying xev with the different devices.
One thing that may be significant is the time between key press/release events and between repeats (double click).
Unfortunately I don't have a computer with touchscreen to play with.

Jul 11 2021, 11:28 AM

Jul 8 2021

kwo added a comment to T8945: Maximized (new) windows unable to receive the focus.

I have now tied to reproduce this, but unfortunately no luck :(

Jul 8 2021, 8:21 AM · Restricted Project

Jun 23 2021

kwo added a comment to T8945: Maximized (new) windows unable to receive the focus.

I suspect there is some focus regression from 1.0.22 to 1.0.23 due to my attempts to fix some other focus issues.
I'll dig into it when time permits.

Jun 23 2021, 10:01 AM · Restricted Project

Jun 19 2021

kwo added a comment to T8945: Maximized (new) windows unable to receive the focus.

Which exact e16 version is this?
Please show the configuration (eesh show).

Jun 19 2021, 9:02 AM · Restricted Project

May 15 2021

kwo closed T8937: E16 default background as Invalid.

Ok, closing.

May 15 2021, 10:52 PM · Restricted Project

May 13 2021

kwo added a comment to T8937: E16 default background.

Looks to me like it works just fine (in e16 1.0.23).
Nothing has changed in that area in ages.

May 13 2021, 7:43 AM · Restricted Project

Apr 26 2021

kwo added a comment to T8931: systray not showing application icons.

Did you try to change the systray icon size, just to check? Note that the "good/bad" sizes seem to vary for different applications and for different versions of certain components (don't know which).
I have no luck reproducing any problem with size 32 and nm-applet, blueman-applet, kupfer, or xpad.

Apr 26 2021, 11:04 PM · Restricted Project
kwo added a comment to T8931: systray not showing application icons.

Different systray applications seem to have problems showing up in the e16 systray depending on the configured systray icon size.
On my box I can find sizes where all, some, or none of the systray apps show up.
Currently some of my "bad" (not all apps shown) sizes are 16, 22, 29, 30, 41, and "good" (all apps shown) sizes are 17, 20, 24, 31, 32, 36, 48.
Which sizes are good/bad seem to vary over time (gtk version?).
The default systray icon size was ~12 years ago changed from 24 to 16, which at the time apparently was a "good" size, to fix this issue.
Can you confirm that the problem is fixed by changing the systray icon size (in systray configuration dialog)?

Apr 26 2021, 1:29 AM · Restricted Project

Apr 2 2021

kwo added a comment to T8920: Remember options for desktop & location wrong.

Not sure exactly what you are asking, but it is not possible to remember the position of a window relative to the current screen (current virtual desktop area), only relative to the full NxM virtual desktop area.
The "Desktop" remembered is which one of the "multiple" desktops.
Multiple desktops are configured in the "Desks" configuration dialog.
Virtual desktops are configured in the "Areas" configuration dialog.
I think things work as you expect if you in "Desks" configure several multiple desktops and in "Areas" configure a 1x1 virtual desktop size.

Apr 2 2021, 12:46 AM · Restricted Project

Apr 1 2021

kwo added a comment to T8920: Remember options for desktop & location wrong.

Is this about e16?
If no then you probably should assign it to someone else.
If yes then..
Looks to me like its works as it should.
However, you may be confusing "desktops" as in multiple desktops and "screen areas" in virtual desktops.
"Location" remembers the position within the entire virtual desktop area.

Apr 1 2021, 10:58 PM · Restricted Project

Feb 10 2021

kwo added a comment to T8888: E16 should resize mouse and other options.

e16 only controls the cursor when the pointer is not in some application window.
Themes can set cursors in two different ways:

Feb 10 2021, 10:06 AM

Dec 6 2020

kwo closed T8739: imlib2 1.6 slow to determine image loadability as Resolved.

Yeah, this was probably caused by the webp loader introduced in 1.6.
Should be fixed in git.
Thanks :)

Dec 6 2020, 9:15 AM · Restricted Project
kwo closed T8808: imlib2: grab.c: Support 30bpp display in __imlib_GrabXImageToRGBA as Resolved.

Pushed, thanks :)

Dec 6 2020, 5:26 AM · Restricted Project
kwo closed T8799: imlib2: rend.c: __imlib_generic_render fails to render correctly when jump != 0 as Resolved.

Pushed, thanks :)

Dec 6 2020, 5:25 AM · Restricted Project
kwo closed T8682: Artifacts remaining elements in desktop from E16 gui's as Resolved.

Assuming fixed.

Dec 6 2020, 1:22 AM · Restricted Project
kwo closed T8726: imlib2: Read image from memory (instead of a file) as Resolved.

Feature is in 1.7.0 - imlib_load_image_from_fd().

Dec 6 2020, 1:18 AM · Restricted Project
kwo claimed T8739: imlib2 1.6 slow to determine image loadability.
Dec 6 2020, 1:16 AM · Restricted Project
kwo claimed T8799: imlib2: rend.c: __imlib_generic_render fails to render correctly when jump != 0 .
Dec 6 2020, 1:15 AM · Restricted Project
kwo claimed T8808: imlib2: grab.c: Support 30bpp display in __imlib_GrabXImageToRGBA.
Dec 6 2020, 1:15 AM · Restricted Project
kwo closed T8863: imlib2 fails build from source on big endian architectures as Resolved.

This was fixed in git more or less immediately after 1.7.0 was released.
I guess I should roll a 1.7.1 before too long.

Dec 6 2020, 1:14 AM · Restricted Project

Jun 8 2020

kwo closed D11946: Document the "absolute" parameter for the toggle_* wops.
Jun 8 2020, 11:26 AM
kwo accepted D11946: Document the "absolute" parameter for the toggle_* wops.
Jun 8 2020, 11:26 AM

May 18 2020

kwo added a comment to T8726: imlib2: Read image from memory (instead of a file).

I think that the feature you request has been implemented in git, after v1.6.1, so no official release yet.

May 18 2020, 8:23 AM · Restricted Project

May 15 2020

kwo added a comment to T8711: Better relative positioning elements in E16 .

The repositioning of things happens when the screen size (in pixels) changes. In this case the pagers are also resized (IIRC).
The screen size change may happen if the resolution is changed or if a monitor is hotplugged.
The resizing of the pagers is rather tricky, and I wouldn't be surprised if the sizes aren't always changed properly when changing back and forth between different screen sizes, particularly if the aspect ratio also changes.

May 15 2020, 11:07 PM · Restricted Project

May 6 2020

kwo added a comment to T8682: Artifacts remaining elements in desktop from E16 gui's.

Never mind about opening a separate issue.

May 6 2020, 10:57 AM · Restricted Project

May 2 2020

kwo added a comment to T8682: Artifacts remaining elements in desktop from E16 gui's.

I think the artifacts that appeared after the grey error screen (when compositing is enabled) should be fixed now.
Sound trouble will no longer use the grey error screen but generate a dialog notification.
The grey error screen can be tested with like "eesh exec foo".

May 2 2020, 1:18 AM · Restricted Project

May 1 2020

kwo added a comment to T8683: Pulseaudio alternative.

Yeah, sndio didn't work well for me either on linux. Haven't tried OpenBSD myself.

May 1 2020, 7:23 AM

Apr 30 2020

kwo added a comment to T8682: Artifacts remaining elements in desktop from E16 gui's.

I'm aware of the issue with garbage left after the e16 error screen if composting is enabled (which we have discussed before :) ).
I'll try yet another time to get around to maybe sort it out :)

Apr 30 2020, 10:57 AM · Restricted Project

Apr 27 2020

kwo added a comment to T8687: E16: Fullscreen windows should not be considered a popup window.

As it turns out, the zsnes fullscreen mode has nothing to do with the normal WM controlled fullscreen mode, which AFAIK works just nicely.
zsnes does various kinds of nastiness (as seen from a WM perspective) - it changes the screen resolution, maps a full size override-redrect ("pop-up") window and does its rendering there.
This window does not have any properties set and can therefore not be treated specially, like setting opacity to 100% (as is done for screen savers, see matches.cfg).

Apr 27 2020, 8:44 AM · Restricted Project

Apr 25 2020

kwo added a comment to T8683: Pulseaudio alternative.

configure says:

Apr 25 2020, 1:00 AM

Apr 14 2020

kwo closed D11678: Don't rescan loaders.

Pushed.

Apr 14 2020, 8:39 AM

Apr 13 2020

kwo added a comment to D11678: Don't rescan loaders.

But - the patch breaks compilation (__imlib_LoadAllLoaders is static).

Apr 13 2020, 7:20 AM
kwo accepted D11678: Don't rescan loaders.

Hmm.. It won't fix issues people may get when upgrading to the next imlib2 version (new loader API), but it would fix similar problems in the future.
And the cost would be not being able to add/update loaders while an application is running, but every time I come across the loader rescan thing I wonder whether or not the feature really is useful.
Ok, let's do it.

Apr 13 2020, 1:02 AM

Mar 4 2020

kwo closed D10262: Introduce imlib_load_image_from_fd().
Mar 4 2020, 8:17 AM
kwo accepted D10262: Introduce imlib_load_image_from_fd().
Mar 4 2020, 8:17 AM
kwo added a comment to D10262: Introduce imlib_load_image_from_fd().

Pushed, thanks :)
Indented according to current style.

Mar 4 2020, 8:17 AM

Mar 1 2020

kwo added a comment to D10262: Introduce imlib_load_image_from_fd().

I have now pushed the new loader API, in case you want to update your imlib_load_image_from_fd() implementation on top of that.

Mar 1 2020, 5:20 AM

Feb 26 2020

kwo closed D11425: GIF loader: Don't close file descriptor twice.
Feb 26 2020, 10:13 AM
kwo accepted D11425: GIF loader: Don't close file descriptor twice.

Looks right to me, thanks :)

Feb 26 2020, 10:12 AM

Feb 17 2020

kwo added a comment to D10262: Introduce imlib_load_image_from_fd().

The previous patches didn't apply - updated and more complete. Still WIP.

Feb 17 2020, 9:39 AM

Feb 15 2020

kwo added a comment to D10262: Introduce imlib_load_image_from_fd().

I'm somewhat busy these days so just some quick comments:

Feb 15 2020, 9:20 AM

Nov 15 2019

kwo closed D10618: tga loader: implement handling of palette.
Nov 15 2019, 8:17 AM
kwo accepted D10618: tga loader: implement handling of palette.

Pushed (with minor formatting adjustments).
Thanks :)

Nov 15 2019, 8:17 AM

Nov 8 2019

kwo added a comment to D10618: tga loader: implement handling of palette.

Looks good to me except that all of the error exits need proper cleanup (munmap(), __imlib_FreeData()).
I have made some cleanups in the tga loader so now you should just goto quit on error.
I have also eliminated the somewhat nasty WRITE_RGBA() macro - please use PIXEL_ARGB instead.
As for indentation - I use indent (version 2.2.12 - matters!), there is an .indent.pro in the top level directory, so you can just do like
$ indent src/modules/loaders/loader_tga.c
But no problem - I'm fine with amending the indent.

Nov 8 2019, 10:49 AM

Oct 15 2019

kwo closed D10398: Check filename before opening archive file..
Oct 15 2019, 11:43 AM
kwo accepted D10398: Check filename before opening archive file..

Pushed, along with a similar fix for the gz loader.

Oct 15 2019, 11:43 AM

Oct 9 2019

kwo added a comment to D10262: Introduce imlib_load_image_from_fd().
  1. Ok, I'll accept that it may be nice :)
  2. Yes, I think so. I'm not a big fan of long or camel cased names and there is no precedence in the module function names, so I suggest load_fd().
  3. Yes, I think it is even necessary in the error chain as if the "best" loader (guessed from extension) fails, the other loaders are tried.
  4. Hmm.. It's also the image cache key. Maybe it should just be regarded as such in the fd case. But then it should also never be used in actual file operations. Haven't check in detail if it is.
  5. Yeah, I know why the compiler might complain. I'm just saying that if there is a problem it is not introduced by your changes and should not be fixed as part of the fd changes.

My compiler (gcc 9.2.1) also complains, but only about the jpeg one which I can understand, and not about the png one, which seems bogus to me (does changing hasa to an int change anything?).

Oct 9 2019, 11:21 AM

Oct 4 2019

kwo added a comment to D10262: Introduce imlib_load_image_from_fd().

Sorry, I'm not happy with a number of things:

Oct 4 2019, 9:19 AM

Sep 30 2019

kwo closed D5788: Add support for MIT-SHM FD-passing.
Sep 30 2019, 10:30 AM
kwo closed D5787: introduce __imlib_ShmDestroyXImage() instead of __imlib_ShmDetach().
Sep 30 2019, 10:30 AM
kwo closed D5783: put a check for shared memory inside __imlib_ShmGetXImage().
Sep 30 2019, 10:30 AM
kwo closed D10222: Allow to use custom memory management functions for loaded images.
Sep 30 2019, 10:27 AM
kwo accepted D10222: Allow to use custom memory management functions for loaded images.

Pushed, thanks :)

Sep 30 2019, 10:23 AM
kwo added a comment to D10222: Allow to use custom memory management functions for loaded images.

The "not needed" comments are of course only about the free's before alloc's.

Sep 30 2019, 9:37 AM
kwo added a comment to D10222: Allow to use custom memory management functions for loaded images.

Your patch prompted me to fix a couple of memory leaks and do some cleanups.

Sep 30 2019, 9:33 AM

Sep 28 2019

kwo added a comment to D10222: Allow to use custom memory management functions for loaded images.

Thanks, I'll look at it, hopefully within the next couple of days.

Sep 28 2019, 10:15 AM

Aug 29 2019

kwo closed T6745: imlib2: Please add support for webp as Resolved.

Done.

Aug 29 2019, 7:40 AM · Restricted Project

Nov 4 2018

kwo closed T5690: A click in top left corner of screen makes menu appear as Invalid.

No response - Closing.

Nov 4 2018, 1:10 AM · Restricted Project

Oct 5 2018

kwo added a comment to T5690: A click in top left corner of screen makes menu appear.

Sorrry about the late reply.. anyway..

Oct 5 2018, 8:50 AM · Restricted Project