Page MenuHomePhabricator

lauromoura (Lauro Neto)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 1:00 PM (203 w, 17 h)
Availability
Available

Recent Activity

Fri, Jul 12

lauromoura added a comment to D9300: eo: fix to free unmanaged handle of language bindings manually in eo.

@Jaehyun_Cho D9306 fixes the issue in the spotlight widget, the underlaying issue is still present, but please not solved like this :)

Fri, Jul 12, 12:10 PM · efl

Thu, Jul 11

lauromoura requested review of D9282: csharp: Skip beta interfaces from the list of interfaces..
Thu, Jul 11, 6:55 AM · efl

Wed, Jul 10

lauromoura updated the diff for D9258: csharp: Fix build and doc generation re beta stuff.

Constant is finally, well, constant :)

Wed, Jul 10, 8:17 PM · Unknown Object (Project), efl
lauromoura added a parent revision for D9273: csharp: Enable conversion of container Eina.Values: D9272: csharp: Add helpers to get/set Values from Objects.
Wed, Jul 10, 3:20 PM · Unknown Object (Project), efl
lauromoura added a child revision for D9272: csharp: Add helpers to get/set Values from Objects: D9273: csharp: Enable conversion of container Eina.Values.
Wed, Jul 10, 3:19 PM · efl
lauromoura added a child revision for D9270: csharp: Tag exported API items.: D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Wed, Jul 10, 3:19 PM · efl
lauromoura added parent revisions for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: D9273: csharp: Enable conversion of container Eina.Values, D9270: csharp: Tag exported API items..
Wed, Jul 10, 3:19 PM · efl: language bindings, Unknown Object (Project)
lauromoura added a child revision for D9273: csharp: Enable conversion of container Eina.Values: D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Wed, Jul 10, 3:19 PM · Unknown Object (Project), efl
lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Updating after big changes.

Wed, Jul 10, 3:16 PM · efl: language bindings, Unknown Object (Project)
lauromoura requested review of D9273: csharp: Enable conversion of container Eina.Values.
Wed, Jul 10, 2:47 PM · Unknown Object (Project), efl
lauromoura requested review of D9272: csharp: Add helpers to get/set Values from Objects.
Wed, Jul 10, 2:46 PM · efl
lauromoura added a child revision for D9270: csharp: Tag exported API items.: D9272: csharp: Add helpers to get/set Values from Objects.
Wed, Jul 10, 2:46 PM · efl
lauromoura accepted D9271: csharp: fix some unit tests that rely on garbage collection.
Wed, Jul 10, 2:41 PM · efl
lauromoura requested review of D9270: csharp: Tag exported API items..
Wed, Jul 10, 12:56 PM · efl
lauromoura updated the diff for D9258: csharp: Fix build and doc generation re beta stuff.

Update after doc cop ticket.

Wed, Jul 10, 6:07 AM · Unknown Object (Project), efl

Tue, Jul 9

lauromoura added a project to D9259: csharp: Respect beta for implementable functions: Unknown Object (Project).
Tue, Jul 9, 12:27 PM · Unknown Object (Project), efl
lauromoura added a project to D9258: csharp: Fix build and doc generation re beta stuff: Unknown Object (Project).
Tue, Jul 9, 12:26 PM · Unknown Object (Project), efl
lauromoura requested review of D9259: csharp: Respect beta for implementable functions.
Tue, Jul 9, 12:26 PM · Unknown Object (Project), efl
lauromoura added a child revision for D9258: csharp: Fix build and doc generation re beta stuff: D9259: csharp: Respect beta for implementable functions.
Tue, Jul 9, 12:26 PM · Unknown Object (Project), efl
lauromoura requested review of D9258: csharp: Fix build and doc generation re beta stuff.
Tue, Jul 9, 12:25 PM · Unknown Object (Project), efl

Mon, Jul 8

lauromoura accepted D9247: csharp: update and disable tests that use deprecated eolian type notations.
Mon, Jul 8, 5:35 PM · efl
lauromoura accepted D9238: eolian_mono: fix non-beta build and support for slice/rw_slice keywords.
Mon, Jul 8, 5:35 PM · efl
lauromoura accepted D9240: csharp: fix build warning related with an unused field in an unit test.
Mon, Jul 8, 5:27 PM · efl

Fri, Jun 28

lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Another round with some fixes.

Fri, Jun 28, 3:18 PM · efl: language bindings, Unknown Object (Project)
lauromoura commandeered D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Fri, Jun 28, 3:10 PM · efl: language bindings, Unknown Object (Project)

Thu, Jun 27

lauromoura accepted D9178: csharp: fix Eina_Stringshare support in containers for manual and generated API.
Thu, Jun 27, 3:24 PM · efl
lauromoura triaged T8039: C#: Code lacks License headers as Normal priority.
Thu, Jun 27, 2:19 PM · Unknown Object (Project), efl: language bindings
lauromoura requested review of D9197: efl-mono: Fix value forwarding in promises/async.
Thu, Jun 27, 1:21 PM · efl
lauromoura added a project to D9196: csharp: Rename test util parameters: Unknown Object (Project).
Thu, Jun 27, 10:36 AM · Unknown Object (Project), efl
lauromoura requested review of D9196: csharp: Rename test util parameters.
Thu, Jun 27, 10:36 AM · Unknown Object (Project), efl
lauromoura added a project to D9195: csharp: Add missing prefix to enable interpolation: Unknown Object (Project).
Thu, Jun 27, 10:34 AM · Unknown Object (Project), efl
lauromoura requested review of D9195: csharp: Add missing prefix to enable interpolation.
Thu, Jun 27, 10:33 AM · Unknown Object (Project), efl
lauromoura updated the diff for D9189: csharp: Update after iterator changes.

Rebase and update after initial fix in a previous commit

Thu, Jun 27, 9:48 AM · efl
lauromoura triaged T8038: C#: Hide the Foo.Config classes as High priority.
Thu, Jun 27, 8:35 AM · Unknown Object (Project), efl: language bindings

Wed, Jun 26

lauromoura closed T7742: C#: Replace IntPtr constructor with factory method as Wontfix.

Well, making these constructors private would mean that we would have to add empty default constructors above in the inheritance tree, and these constructors wold have to be visible somehow. So, the current protected constructors with the remark of being only for internal use seems to be enough.

Wed, Jun 26, 2:24 PM · documentation, efl: language bindings
lauromoura closed T7742: C#: Replace IntPtr constructor with factory method, a subtask of T7702: Remove internally generated classes from EFL# doc, as Wontfix.
Wed, Jun 26, 2:24 PM · documentation, efl: language bindings
lauromoura requested review of D9189: csharp: Update after iterator changes.
Wed, Jun 26, 2:18 PM · efl
lauromoura added a revision to T8036: C#: Fix C# build after accessor/iterator changes: D9189: csharp: Update after iterator changes.
Wed, Jun 26, 2:17 PM · Unknown Object (Project), efl: language bindings, Restricted Project
lauromoura added a project to T8036: C#: Fix C# build after accessor/iterator changes: Unknown Object (Project).
Wed, Jun 26, 10:13 AM · Unknown Object (Project), efl: language bindings, Restricted Project
lauromoura triaged T8036: C#: Fix C# build after accessor/iterator changes as High priority.
Wed, Jun 26, 8:32 AM · Unknown Object (Project), efl: language bindings, Restricted Project
lauromoura updated subscribers of T8035: Unify handling of contents of complex types.

Adding Cedric as this may change how MVVM Models work.

Wed, Jun 26, 7:38 AM · Restricted Project

Tue, Jun 25

lauromoura triaged T8034: C#: Make C# classes partials as Normal priority.
Tue, Jun 25, 2:36 PM · efl: language bindings

Mon, Jun 24

lauromoura requested review of D9164: efl-mono: Add object type support for Eina.Value.
Mon, Jun 24, 1:59 PM · efl

Wed, Jun 19

lauromoura added a comment to T8017: efl-mono: in-tree examples do not build anymore.

I've pushed some build fixes to devs/lauromoura/csharp_examples but there seems to be some runtime issues.

Wed, Jun 19, 2:57 PM · efl: language bindings
lauromoura closed T7800: C#: Attach wrapper lifetime to the Eo instance, a subtask of T7742: C#: Replace IntPtr constructor with factory method, as Resolved.
Wed, Jun 19, 11:24 AM · documentation, efl: language bindings
lauromoura closed T7800: C#: Attach wrapper lifetime to the Eo instance as Resolved.

Resolved with D9014 (the WrapperSupervisor commit)

Wed, Jun 19, 11:24 AM · efl: language bindings
lauromoura accepted D9084: efl_mono: update docs of CreateWrapperFor.
Wed, Jun 19, 7:05 AM · efl

May 31 2019

lauromoura accepted D9014: csharp: Refactor wrapper lifetime..
May 31 2019, 1:41 PM · efl
lauromoura updated the diff for D9063: csharp: Add some tests.

Fix indentation

May 31 2019, 1:31 PM · efl
lauromoura requested review of D9063: csharp: Add some tests.
May 31 2019, 12:49 PM · efl

May 29 2019

lauromoura accepted D8756: ecore: add simple test for property_string_add..
May 29 2019, 3:36 PM · efl
lauromoura accepted D8755: ecore: add simple logic to generate synthetic string property assembling value of other properties..
May 29 2019, 3:35 PM · efl
lauromoura requested review of D9052: eolian-cxx: Fix some warnings from cppcheck.
May 29 2019, 11:13 AM · efl

May 24 2019

lauromoura updated the diff for D9020: csharp: Fix testing under dotnet.

Update

May 24 2019, 4:50 PM · efl
lauromoura requested review of D9020: csharp: Fix testing under dotnet.
May 24 2019, 8:34 AM · efl

May 23 2019

lauromoura requested review of D9015: csharp: Fix autotools build.
May 23 2019, 4:14 PM · efl
lauromoura added a comment to D8678: eo: add events to track the ownership status of an Eo object.

We've tried measuring the eo benchmarks for it using the release build[1] on an dell xps 15 9560 running ubuntu 18.10.

May 23 2019, 3:14 PM · efl

May 22 2019

lauromoura requested review of D8937: csharp: Split test files.
May 22 2019, 1:19 PM · efl

May 16 2019

lauromoura abandoned D8867: csharp: Slim Concrete classes..

Concrete classes serve as a wrapper for eventual private classes that implement the given interface, akin to the *Realized classes for abstracts.

May 16 2019, 7:21 AM · efl

May 13 2019

lauromoura requested review of D8889: csharp: Fix event marshalling for value types.
May 13 2019, 5:27 PM · efl
lauromoura added a revision to T7957: VisibilityChanged event contains wrong info: D8889: csharp: Fix event marshalling for value types.
May 13 2019, 5:27 PM · efl: language bindings, efl: api

May 8 2019

lauromoura requested review of D8867: csharp: Slim Concrete classes..
May 8 2019, 3:02 PM · efl

May 6 2019

lauromoura requested review of D8835: csharp: Add Part suffix for the part wrappers.
May 6 2019, 12:47 PM · efl
lauromoura added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I think this can be solved very easily by making C# suffix parts with Part automatically, just like events. Then we can remove the restriction that parts cannot be named like other properties (just like events).

Let me explain:

We have different kinds of symbols in EO files: Namespaces, Classes, Methods (and Properties), Events and Parts.
In C they can have the same name, symbol clashes are not a problem, and this is why originally our hierarchy had lots of duplicates.

When we started implementing bindings, some languages had issues with the symbol clashes: Python and C# cannot have a class named like a namespace (not even changing the case, because in Python class hierarchy maps to the filesystem, and the Windows filesystem is case-insensitive). In C# a property cannot have the same name as the class, etc.
We started solving these issues in different ways, and I think this was a mistake. For example, in C#, events are automatically suffixed with Evt so clashing is resolved, but not so parts.

As a result, these are the current rules that eolian is enforcing (as far as I understand):

  • Classes cannot clash with Namespaces
  • Methods (and Properties) cannot clash with anything
  • Events cannot clash with other events
  • Parts cannot clash with anything

    I think these rules work nicely for all cases except parts, which we have not used much yet. So, if the C# bindings suffix parts with Part just like events are suffixed Evt we can remove the restriction on part names and we can use more sensible names like text, icon and extra (without prefix). Of course, names will still need to be unique inside a widget's hierarchy (a part cannot have the same name as another part up in the hierarchy).

    What do you think @cedric, @SanghyeonLee, @lauromoura, @q66 ?
May 6 2019, 9:14 AM · efl

May 3 2019

lauromoura requested review of D8818: csharp: Fix property helper doc indent.
May 3 2019, 4:37 PM · efl
lauromoura added a revision to T7794: efl-mono: Property wrapper docs are not properly indented: D8818: csharp: Fix property helper doc indent.
May 3 2019, 4:37 PM · efl: docs, efl: language bindings
lauromoura requested review of D8817: pyolian: Fix tests.
May 3 2019, 3:37 PM · efl
lauromoura added a comment to T7813: mono-docs: Better docs for Event wrappers.

This is just a struct to wrap the event parameters. The event documentation itself is already present in the EventHandler field.

May 3 2019, 9:10 AM · efl: docs, efl: language bindings
lauromoura updated the diff for D8808: csharp: Add docs for aliases.

Update after Xavi's comments

May 3 2019, 6:58 AM · efl

May 2 2019

lauromoura closed D8811: cxx: Fix missing bits from header rename.
May 2 2019, 11:47 PM · efl
lauromoura requested changes to D8812: cxx: fix autotools build error.

I had added this fix in D8811 alongside others. Added you as reviewer there.

May 2 2019, 8:31 PM · efl
lauromoura added a reviewer for D8811: cxx: Fix missing bits from header rename: woohyun.
May 2 2019, 8:31 PM · efl
lauromoura added a reviewer for D8811: cxx: Fix missing bits from header rename: bu5hm4n.
May 2 2019, 3:05 PM · efl
lauromoura requested review of D8811: cxx: Fix missing bits from header rename.
May 2 2019, 2:47 PM · efl
lauromoura updated the diff for D8810: model: Add some missing docs bits..

Update fixing typo.

May 2 2019, 1:39 PM · efl
lauromoura reopened T7842: docs: Document Efl.Ui.TabBar methods as "Open".
May 2 2019, 1:36 PM · efl: docs, Restricted Project
lauromoura reopened T7842: docs: Document Efl.Ui.TabBar methods, a subtask of T5826: Improve overall EFL documentation, as Open.
May 2 2019, 1:36 PM · efl: docs, Restricted Project
lauromoura triaged T7843: docs: Document Efl.Ui.ListViewLayoutItem as Normal priority.
May 2 2019, 1:35 PM · efl: docs, Restricted Project
Herald closed T7842: docs: Document Efl.Ui.TabBar methods as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

May 2 2019, 1:34 PM · efl: docs, Restricted Project
lauromoura requested review of D8810: model: Add some missing docs bits..
May 2 2019, 1:03 PM · efl
lauromoura requested review of D8809: csharp: Some docs improvements..
May 2 2019, 1:02 PM · efl
lauromoura requested review of D8808: csharp: Add docs for aliases.
May 2 2019, 12:32 PM · efl
lauromoura added a revision to T7689: efl-mono: Eolian types are missing docs: D8808: csharp: Add docs for aliases.
May 2 2019, 12:32 PM · efl: language bindings
lauromoura added inline comments to D8803: evas_object_textblock: Fix binary search fail..
May 2 2019, 7:39 AM · efl
lauromoura updated the diff for D8803: evas_object_textblock: Fix binary search fail..

Update with test and extra fix

May 2 2019, 7:34 AM · efl
lauromoura commandeered D8803: evas_object_textblock: Fix binary search fail..
May 2 2019, 7:20 AM · efl

Apr 26 2019

lauromoura moved T7689: efl-mono: Eolian types are missing docs from TODO to InProgress on the efl: language bindings board.
Apr 26 2019, 3:41 PM · efl: language bindings

Apr 24 2019

lauromoura added a comment to D8678: eo: add events to track the ownership status of an Eo object.

Results of expedite-cmp (I've patched it to aggregate the average values of the comparison files in the second column):

Apr 24 2019, 2:55 PM · efl
lauromoura requested review of D8700: 2to3 modifications to expedite-cmp.
Apr 24 2019, 7:48 AM
lauromoura closed D8693: meson: Fix evas engine install directory..
Apr 24 2019, 6:11 AM · efl

Apr 23 2019

lauromoura added a comment to D8693: meson: Fix evas engine install directory..

I caught this error after doing a fresh install without old modules installed.

Apr 23 2019, 7:34 PM · efl
lauromoura requested review of D8693: meson: Fix evas engine install directory..
Apr 23 2019, 7:31 PM · efl
lauromoura accepted D8692: meson: ensure that buffer header is installed correctly.

E compiles correctly after this.

Apr 23 2019, 1:29 PM · efl

Apr 22 2019

lauromoura updated the diff for D8679: csharp: Fix test code memory handling.

Removed uneeded initializations

Apr 22 2019, 3:01 PM · efl
lauromoura planned changes to D8679: csharp: Fix test code memory handling.
Apr 22 2019, 2:54 PM · efl
lauromoura added a comment to D8679: csharp: Fix test code memory handling.

The failure occurred because the Dummy.TestObject.set_value implementation either freed the stored value or created the new one. This worked normally outside of debug mode probably due to mempool reusing the memory address. The debug build uses the pass-through mempool, making the problem appear.

Apr 22 2019, 2:48 PM · efl
lauromoura requested review of D8679: csharp: Fix test code memory handling.
Apr 22 2019, 2:44 PM · efl
lauromoura added a revision to T7792: efl-mono: testsuite fails when built in debug mode with meson: D8679: csharp: Fix test code memory handling.
Apr 22 2019, 2:44 PM · Restricted Project, efl: language bindings
lauromoura updated the diff for D8645: csharp: refactor native_inherit into a nested class..

Rebase and fix comment.

Apr 22 2019, 2:28 PM · efl

Apr 18 2019

lauromoura updated subscribers of T7792: efl-mono: testsuite fails when built in debug mode with meson.

Here I get a segfault when trying to create an empty Eina_Value (before assigning). And looks like there is more instability regarding Eina (at least with C# apps). Some calls to Eina.Log.Error also made the program crash. Will investigate more.

Apr 18 2019, 2:52 PM · Restricted Project, efl: language bindings