Page MenuHomePhabricator

lauromoura (Lauro Neto)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 1:00 PM (221 w, 1 d)
Availability
Available

Recent Activity

Today

lauromoura closed T8418: C#: CA1815: Override equals and operator equals on value types as Resolved.

Resolved and enabled CA1815 on the devs/lauromoura/stylecop branch.

Tue, Nov 19, 7:26 PM · efl: language bindings
lauromoura closed T8418: C#: CA1815: Override equals and operator equals on value types, a subtask of T8331: C#: Fix stylecop warnings, as Resolved.
Tue, Nov 19, 7:26 PM · efl: language bindings
lauromoura requested review of D10697: csharp: CA1307 Add missing StringComparison in manual code.
Tue, Nov 19, 7:24 PM · efl
lauromoura added a revision to T8405: C#: CA1307: Specify StringComparison: D10697: csharp: CA1307 Add missing StringComparison in manual code.
Tue, Nov 19, 7:24 PM · efl: language bindings
lauromoura requested review of D10696: csharp: CA1307 Add CultureInfo to generated code..
Tue, Nov 19, 7:23 PM · efl
lauromoura added a revision to T8405: C#: CA1307: Specify StringComparison: D10696: csharp: CA1307 Add CultureInfo to generated code..
Tue, Nov 19, 7:23 PM · efl: language bindings
lauromoura added inline comments to D10650: csharp: Specifying StringComparison..
Tue, Nov 19, 7:23 PM · efl
lauromoura requested changes to D10650: csharp: Specifying StringComparison..

Ooops. Looks like we might have an issue with this one on Mono (6.4.0.198 here):

Tue, Nov 19, 7:10 PM · efl
lauromoura accepted D10650: csharp: Specifying StringComparison..
Tue, Nov 19, 7:00 PM · efl
lauromoura closed D10694: csharp: Fix CA1815 for generated structs and aliases.
Tue, Nov 19, 4:50 PM · efl
lauromoura added a revision to T8418: C#: CA1815: Override equals and operator equals on value types: D10694: csharp: Fix CA1815 for generated structs and aliases.
Tue, Nov 19, 5:31 AM · efl: language bindings
lauromoura added a task to D10694: csharp: Fix CA1815 for generated structs and aliases: T8418: C#: CA1815: Override equals and operator equals on value types.
Tue, Nov 19, 5:31 AM · efl

Yesterday

lauromoura added inline comments to D10694: csharp: Fix CA1815 for generated structs and aliases.
Mon, Nov 18, 9:12 PM · efl
lauromoura requested review of D10694: csharp: Fix CA1815 for generated structs and aliases.
Mon, Nov 18, 9:08 PM · efl
lauromoura closed D10647: csharp: Add IEquatable on classes..
Mon, Nov 18, 8:41 PM · efl
lauromoura added a commit to T8418: C#: CA1815: Override equals and operator equals on value types: rEFL2c5ea739e7f9: csharp: Add IEquatable on classes..
Mon, Nov 18, 8:41 PM · efl: language bindings
lauromoura accepted D10647: csharp: Add IEquatable on classes..

There was a conflict after D10616 but I resolved locally.

Mon, Nov 18, 7:48 PM · efl
lauromoura added a comment to D10690: docs: Copy all images to output folder.

Something like this:

Mon, Nov 18, 6:54 AM · efl
lauromoura added a comment to D10690: docs: Copy all images to output folder.

Maybe a python script using shutil?

Mon, Nov 18, 6:34 AM · efl

Thu, Nov 14

lauromoura closed T8423: C#: CA2000: Dispose objects before losing scope as Resolved.

Fixed after these commits.

Thu, Nov 14, 7:47 PM · efl: language bindings
lauromoura closed T8423: C#: CA2000: Dispose objects before losing scope, a subtask of T8331: C#: Fix stylecop warnings, as Resolved.
Thu, Nov 14, 7:47 PM · efl: language bindings
lauromoura closed D10673: csharp: FunctionPtr wrappers are not IDisposable.
Thu, Nov 14, 7:25 PM · efl
lauromoura added a commit to T8423: C#: CA2000: Dispose objects before losing scope: rEFLe130d808cdc8: csharp: FunctionPtr wrappers are not IDisposable.
Thu, Nov 14, 7:25 PM · efl: language bindings
lauromoura added a commit to T8423: C#: CA2000: Dispose objects before losing scope: rEFL2272e21b3cc9: csharp: Silence CA2000 in tests.
Thu, Nov 14, 7:24 PM · efl: language bindings
lauromoura closed D10672: csharp: Silence CA2000 in tests.
Thu, Nov 14, 7:24 PM · efl
lauromoura added a commit to T8423: C#: CA2000: Dispose objects before losing scope: rEFLa0dd0b616a9b: csharp: Suppress CA2000 in native wrappers..
Thu, Nov 14, 7:24 PM · efl: language bindings
lauromoura closed D10671: csharp: Suppress CA2000 in native wrappers..
Thu, Nov 14, 7:24 PM · efl
lauromoura closed D10670: csharp: More CA2000 fixes.
Thu, Nov 14, 7:24 PM · efl
lauromoura added a commit to T8423: C#: CA2000: Dispose objects before losing scope: rEFLfe8496cb6e24: csharp: More CA2000 fixes.
Thu, Nov 14, 7:24 PM · efl: language bindings
lauromoura closed D10644: csharp: Disposing IDisposable objects..
Thu, Nov 14, 10:40 AM · efl
lauromoura added a commit to T8423: C#: CA2000: Dispose objects before losing scope: rEFLcd113d7aae74: csharp: Disposing IDisposable objects..
Thu, Nov 14, 10:40 AM · efl: language bindings
lauromoura requested review of D10674: edje: Remove warnings.
Thu, Nov 14, 10:39 AM · efl
lauromoura requested review of D10673: csharp: FunctionPtr wrappers are not IDisposable.
Thu, Nov 14, 10:31 AM · efl
lauromoura added a child revision for D10672: csharp: Silence CA2000 in tests: D10673: csharp: FunctionPtr wrappers are not IDisposable.
Thu, Nov 14, 10:31 AM · efl
lauromoura added a revision to T8423: C#: CA2000: Dispose objects before losing scope: D10673: csharp: FunctionPtr wrappers are not IDisposable.
Thu, Nov 14, 10:31 AM · efl: language bindings
lauromoura requested review of D10672: csharp: Silence CA2000 in tests.
Thu, Nov 14, 10:29 AM · efl
lauromoura added a child revision for D10671: csharp: Suppress CA2000 in native wrappers.: D10672: csharp: Silence CA2000 in tests.
Thu, Nov 14, 10:29 AM · efl
lauromoura added a revision to T8423: C#: CA2000: Dispose objects before losing scope: D10672: csharp: Silence CA2000 in tests.
Thu, Nov 14, 10:29 AM · efl: language bindings
lauromoura requested review of D10671: csharp: Suppress CA2000 in native wrappers..
Thu, Nov 14, 10:28 AM · efl
lauromoura added a child revision for D10670: csharp: More CA2000 fixes: D10671: csharp: Suppress CA2000 in native wrappers..
Thu, Nov 14, 10:28 AM · efl
lauromoura added a revision to T8423: C#: CA2000: Dispose objects before losing scope: D10671: csharp: Suppress CA2000 in native wrappers..
Thu, Nov 14, 10:28 AM · efl: language bindings
lauromoura added a parent revision for D10670: csharp: More CA2000 fixes: D10644: csharp: Disposing IDisposable objects..
Thu, Nov 14, 10:27 AM · efl
lauromoura added a child revision for D10644: csharp: Disposing IDisposable objects.: D10670: csharp: More CA2000 fixes.
Thu, Nov 14, 10:26 AM · efl
lauromoura requested review of D10670: csharp: More CA2000 fixes.
Thu, Nov 14, 10:25 AM · efl
lauromoura added a revision to T8423: C#: CA2000: Dispose objects before losing scope: D10670: csharp: More CA2000 fixes.
Thu, Nov 14, 10:25 AM · efl: language bindings
lauromoura accepted D10644: csharp: Disposing IDisposable objects..
Thu, Nov 14, 9:45 AM · efl
lauromoura created T8474: C#: Support optional parameters.
Thu, Nov 14, 8:44 AM · efl: language bindings
lauromoura added a comment to D10615: introduce efl_canvas_object_animation.

As StartAnimation receives their animation object by @move, the C# binding will automatically call efl_ref for it.

@lauromoura
It would be a good idea! We need to check if it would be fine for all other @move cases. (e.g. @property manager of Efl.Ui.Spotlight.Container)
But I think it would be fine for other @move cases as well :)

Thu, Nov 14, 6:52 AM · efl
lauromoura created T8473: C#: Add a way to report unmanaged memory consumption to the GC.
Thu, Nov 14, 6:33 AM · efl: language bindings
lauromoura added a comment to T8423: C#: CA2000: Dispose objects before losing scope.

In summary, C was evil because programmers could forget to free their resources, so humankind created C# that frees resources for you. And now CA2000 is telling me that I should free resources manually again? What's wrong with the world?

Thu, Nov 14, 6:11 AM · efl: language bindings
lauromoura added a comment to D10615: introduce efl_canvas_object_animation.
Thu, Nov 14, 4:45 AM · efl

Wed, Nov 13

lauromoura added a comment to T8423: C#: CA2000: Dispose objects before losing scope.

Taking a look at some of the most complicated cases in generated code, Here is a table of the occurrences:

Wed, Nov 13, 2:21 PM · efl: language bindings
lauromoura closed T8430: C#: CA2225: Operator overloads have named alternates as Resolved.

Fixed with these commits.

Wed, Nov 13, 6:18 AM · efl: language bindings
lauromoura closed T8430: C#: CA2225: Operator overloads have named alternates, a subtask of T8331: C#: Fix stylecop warnings, as Resolved.
Wed, Nov 13, 6:18 AM · efl: language bindings
lauromoura added inline comments to D10634: efl: improve Efl.BooleanModel test by checking the child del case..
Wed, Nov 13, 5:47 AM · efl
lauromoura closed D10652: csharp: Some missing conversions.
Wed, Nov 13, 5:06 AM · efl
lauromoura added a commit to T8430: C#: CA2225: Operator overloads have named alternates: rEFL600163320bec: csharp: Some missing conversions.
Wed, Nov 13, 5:06 AM · efl: language bindings
lauromoura closed D10653: csharp: Add conversion methods for generated types.
Wed, Nov 13, 5:06 AM · efl
lauromoura added a commit to T8430: C#: CA2225: Operator overloads have named alternates: rEFLbdf4396dfefb: csharp: Add conversion methods for generated types.
Wed, Nov 13, 5:06 AM · efl: language bindings

Tue, Nov 12

lauromoura closed D10655: eolian_mono: change OnXXXEvent access modifier from public to protected virtual.
Tue, Nov 12, 11:11 PM · efl
lauromoura accepted D10655: eolian_mono: change OnXXXEvent access modifier from public to protected virtual.
Tue, Nov 12, 11:10 PM · efl
lauromoura closed D10616: csharp: Add To and From methods for implicit conversion..
Tue, Nov 12, 2:18 PM · efl
lauromoura added a commit to T8430: C#: CA2225: Operator overloads have named alternates: rEFLfee55857e472: csharp: Add To and From methods for implicit conversion..
Tue, Nov 12, 2:18 PM · efl: language bindings
lauromoura requested review of D10653: csharp: Add conversion methods for generated types.
Tue, Nov 12, 2:01 PM · efl
lauromoura added a revision to T8430: C#: CA2225: Operator overloads have named alternates: D10653: csharp: Add conversion methods for generated types.
Tue, Nov 12, 2:01 PM · efl: language bindings
lauromoura requested review of D10652: csharp: Some missing conversions.
Tue, Nov 12, 2:00 PM · efl
lauromoura added a child revision for D10616: csharp: Add To and From methods for implicit conversion.: D10652: csharp: Some missing conversions.
Tue, Nov 12, 2:00 PM · efl
lauromoura added a revision to T8430: C#: CA2225: Operator overloads have named alternates: D10652: csharp: Some missing conversions.
Tue, Nov 12, 2:00 PM · efl: language bindings
lauromoura accepted D10616: csharp: Add To and From methods for implicit conversion..
Tue, Nov 12, 1:58 PM · efl
lauromoura closed D10639: eolian_mono: avoid keyword as a variable name.
Tue, Nov 12, 5:31 AM · efl
lauromoura closed D10638: mono: reduce duplicated event code.
Tue, Nov 12, 5:31 AM · efl
lauromoura closed D10630: dotnet: Generate doc and check for warnings.
Tue, Nov 12, 5:31 AM · efl
lauromoura accepted D10639: eolian_mono: avoid keyword as a variable name.
Tue, Nov 12, 5:17 AM · efl
lauromoura accepted D10638: mono: reduce duplicated event code.
Tue, Nov 12, 5:12 AM · efl

Fri, Nov 8

lauromoura added a comment to D10630: dotnet: Generate doc and check for warnings.

Sooooo what's this and how do I test it? :)

Fri, Nov 8, 8:46 AM · efl
lauromoura requested review of D10630: dotnet: Generate doc and check for warnings.
Fri, Nov 8, 8:22 AM · efl

Thu, Nov 7

lauromoura closed D10608: csharp: Localization strings with CultureInfo..
Thu, Nov 7, 7:01 PM · efl
lauromoura added a commit to T8404: C#: CA1305: Specify IFormatProvider: rEFL0a2c9f57ef98: csharp: Localization strings with CultureInfo..
Thu, Nov 7, 7:01 PM · efl: language bindings
lauromoura accepted D10608: csharp: Localization strings with CultureInfo..
Thu, Nov 7, 6:31 PM · efl
lauromoura closed D10619: csharp: Fix running headless tests in dotnet.
Thu, Nov 7, 6:07 PM · efl
lauromoura closed T8462: Provide generic access to parts from C# as Resolved by committing rEFLcb60b595d3bb: csharp: Make GetPart public..
Thu, Nov 7, 1:04 PM · efl (efl-1.24), efl: language bindings
lauromoura closed D10594: csharp: Make GetPart public..
Thu, Nov 7, 1:04 PM · efl
lauromoura added a comment to D9717: csharp: Revamp dotnet support.

@lauromoura
Is there any reason not to use csc directly?
csc has been available since mono 5.0.0 ( https://www.mono-project.com/docs/about-mono/releases/5.0.0/#c-compiler )

Thu, Nov 7, 12:30 PM · DO NOT MERGE, efl
lauromoura requested review of D10619: csharp: Fix running headless tests in dotnet.
Thu, Nov 7, 12:07 PM · efl

Wed, Nov 6

lauromoura closed D10609: csharp: Fix test build dependency.
Wed, Nov 6, 6:58 PM · efl
lauromoura closed D10602: efl: Make stable single-valued getters consistent..
Wed, Nov 6, 6:58 PM · efl
lauromoura closed D10575: csharp:comma have whitespace after and none before.
Wed, Nov 6, 6:47 PM · efl
lauromoura accepted D10575: csharp:comma have whitespace after and none before.
Wed, Nov 6, 6:46 PM · efl
lauromoura requested review of D10612: csharp: Iterate more in GC-dependent test.
Wed, Nov 6, 11:34 AM · efl
lauromoura added a revision to T8313: Failed mono testsuite on CI: D10612: csharp: Iterate more in GC-dependent test.
Wed, Nov 6, 11:34 AM
lauromoura added a comment to D10610: charp: Require mono bindings when using dotnet.

Not sure if pulling the bindings implicitly is a good idea. Should we just error out asking for -Dbindings=mono instead?

Wed, Nov 6, 10:43 AM · efl
lauromoura requested review of D10610: charp: Require mono bindings when using dotnet.
Wed, Nov 6, 10:41 AM · efl
lauromoura requested review of D10609: csharp: Fix test build dependency.
Wed, Nov 6, 10:18 AM · efl
lauromoura closed T8168: C#: Build with dotnet and upstream meson as Resolved by committing rEFL17a81bee4a53: csharp: Revamp dotnet support.
Wed, Nov 6, 6:42 AM · efl: language bindings
lauromoura closed T8168: C#: Build with dotnet and upstream meson, a subtask of T7394: C#: Fix class registration when running with dotnet core, as Resolved.
Wed, Nov 6, 6:42 AM · efl: language bindings
lauromoura closed D9717: csharp: Revamp dotnet support.
Wed, Nov 6, 6:42 AM · DO NOT MERGE, efl

Tue, Nov 5

lauromoura closed D10601: eolian: Imply @no_unused if @move in return..
Tue, Nov 5, 11:55 AM · efl
lauromoura requested review of D10602: efl: Make stable single-valued getters consistent..
Tue, Nov 5, 10:54 AM · efl
lauromoura added a child revision for D10601: eolian: Imply @no_unused if @move in return.: D10602: efl: Make stable single-valued getters consistent..
Tue, Nov 5, 10:54 AM · efl
lauromoura requested review of D10601: eolian: Imply @no_unused if @move in return..
Tue, Nov 5, 10:47 AM · efl