Page MenuHomePhabricator

lauromoura (Lauro Neto)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 1:00 PM (164 w, 1 d)
Availability
Available

Recent Activity

Today

lauromoura requested review of D7166: eina_cxx: Fix eina::value copy constructor..
Tue, Oct 16, 2:29 PM · efl

Thu, Oct 11

lauromoura edited the content of Windows.
Thu, Oct 11, 12:30 PM

Thu, Oct 4

lauromoura updated the diff for D7134: efl-csharp: Fixing C# examples.

Update removing the comment. Somehow I forgot it when splitting the patches.

Thu, Oct 4, 10:12 AM · efl

Wed, Oct 3

lauromoura added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

I've rebased the current new API work on top of yesterday (Oct 3rd) master (still in devs/lauromoura/csharp-new-classes) and it compiled without requiring any changes to the Eo files. All tests pass and a quick test showed at least elm examples are working. The generator new code requires some cleanup before pushing, though.

Wed, Oct 3, 9:42 PM · efl: language bindings, Restricted Project
lauromoura updated the diff for D7134: efl-csharp: Fixing C# examples.

Update with SetIcon change from D7133

Wed, Oct 3, 12:32 PM · efl
lauromoura abandoned D7133: efl-csharp: Add missing icon arg to SetButton.

Will merge this change into D134, as it already fixes the example build system.

Wed, Oct 3, 12:31 PM · efl
lauromoura requested review of D7136: csharp: Fix missing override keyword.
Wed, Oct 3, 12:25 PM · efl
lauromoura requested review of D7135: csharp: Temporarily disable missing docs warning.
Wed, Oct 3, 12:24 PM · efl
lauromoura requested review of D7134: efl-csharp: Fixing C# examples.
Wed, Oct 3, 12:23 PM · efl
lauromoura requested review of D7133: efl-csharp: Add missing icon arg to SetButton.
Wed, Oct 3, 12:23 PM · efl

Thu, Sep 27

lauromoura added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

About hiding them from the tree, these are the methods either returning (->) or receiving as a parameter (between ()) a Mixin type.

Thu, Sep 27, 1:01 PM · efl: language bindings, Restricted Project

Tue, Sep 25

lauromoura requested review of D7106: efl-csharp: Fix event struct marshalling..
Tue, Sep 25, 7:20 AM · efl

Sep 13 2018

lauromoura added a comment to T6128: Generate C# reference API documentation.

The Mono compiler already extracts the documentation from the generated code (eolian_mono adds them as C# comments) into a XML file that VS/MonoDevelop use. Maybe we could just add a script to transform the generated XML into the DokuWiki syntax.

Sep 13 2018, 12:31 PM · efl: language bindings, efl: docs

Sep 12 2018

lauromoura added a comment to T7204: Discussion about C# binding syntax.

I've pushed the current code to devs/lauromoura/csharp-new-classes.

Sep 12 2018, 6:02 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Sep 11 2018

lauromoura triaged T7394: C#: Fix class registration when running with dotnet core as High priority.
Sep 11 2018, 6:53 PM · efl: language bindings
lauromoura added a comment to T7204: Discussion about C# binding syntax.

@lauromoura

Thank you for explanation about how to build with meson.

I built with meson and then all elementary functions are successfully loaded by dlsym in class_initializer.
But I still don't know why those functions are not loaded by dlsym with dotnet build...
Our goal is to build EFL C# on Visual Studio so it still matters..

Please let me know if you build successfully with dotnet build.

Sep 11 2018, 6:46 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7375: Support widget styles in C# bindings.

This @ctor_param would behave just like a hint, right? So each language decides whether it should support them as explicit constructor parameters (C#) or keep it implicit through efl_added (C/C++).

Sep 11 2018, 11:59 AM · efl

Sep 10 2018

lauromoura requested review of D7017: efl-csharp: Add copy constructor for eina.Value..
Sep 10 2018, 8:36 PM · efl
lauromoura added a comment to T7375: Support widget styles in C# bindings.

There's an option we have been discussing on IRC. Currently the EO format has a constructors { } section which is unused, and it is not clear what its purpose is.

Sep 10 2018, 9:06 AM · efl

Sep 5 2018

lauromoura closed T7355: csharp: Cannot unregister event handlers as Resolved.

Marked as resolved. Somehow phab didn't close it after pushing.

Sep 5 2018, 1:59 PM · efl: language bindings

Sep 4 2018

lauromoura requested review of D6981: efl-csharp: Fix event callback removal..
Sep 4 2018, 1:43 PM · efl: language bindings
lauromoura added a comment to T7240: Not allow multi class inheritance in eo.

@lauromoura with that pyolian magic, can you list all classes inheriting from more than one class (not interface or mixin) ? In this way we can start evaluating how much work would require fixing that.

Sep 4 2018, 7:35 AM · efl: language bindings, Restricted Project

Sep 3 2018

lauromoura added a comment to T7204: Discussion about C# binding syntax.

@lauromoura

It is strange.. I called efl.All.Init(efl.Components.Ui); when I tested. And it did not work on the latest master branch.

I think maybe you tested on your local branch.

Please let me know your test branch or please test on the latest master branch. (if you test on master branch, then please do not use previously installed so files and header files from your local branch.)

Thank you :)

Sep 3 2018, 7:02 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Aug 31 2018

lauromoura added a comment to T7240: Not allow multi class inheritance in eo.

With help of pyolian, I could find these instances where we have abstract classes inheriting from regular classes somewhere in their inheritance chain:

Aug 31 2018, 6:23 PM · efl: language bindings, Restricted Project
lauromoura claimed T7359: efl-mono: Accessing the Global Config crashes on exit.

(Somehow I removed myself as the assignee...)

Aug 31 2018, 4:55 PM · efl: language bindings
lauromoura requested review of D6958: efl-csharp: Use value_new/free for wrapped values.
Aug 31 2018, 4:54 PM · efl
lauromoura added a revision to T7359: efl-mono: Accessing the Global Config crashes on exit: D6958: efl-csharp: Use value_new/free for wrapped values.
Aug 31 2018, 4:54 PM · efl: language bindings
lauromoura placed T7359: efl-mono: Accessing the Global Config crashes on exit up for grabs.

The problem seems to be eina.Value using malloc/free internally to create/delete Eina_Values while it should use eina_value_new/eina_value_free to alloc/free from the Value mempool.

Aug 31 2018, 1:37 PM · efl: language bindings
lauromoura added a comment to T7204: Discussion about C# binding syntax.

@lauromoura @felipealmeida

Thank you for sharing and fix D6956.

Regarding D6956, still override FinalizeAdd() is not called. (I tested dotnet run with user-defined class which inherits from efl.ui.ButtonInherit.)

The reason is because class_initializer of inherit class in cs file fails to load some efl functions from dlsym (i.e. descs[].api_func) (e.g. efl_selection_set).
This fails _eo_class_funcs_set in eo.c with error message "Class '%s': NULL API not allowed (NULL->%p '%s').".
The efl functions which cannot be loaded from dlsym are methods of mixin, class, and abstract class in elementary. (e.g. efl_selection_set)

My user-defined class is instantiated after efl.ui.Config.Init() is called, so I think that there should not be any problem to load elementary functions from dlsym in efl_ui_button.eo.cs file.
If you know anything about this problem, please share with us.

Thank you :)

Aug 31 2018, 6:18 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)

Aug 30 2018

lauromoura added a comment to T7204: Discussion about C# binding syntax.

@lauromoura @felipealmeida

Could you tell me what branch do you use for the latest development of C# bindings?

Aug 30 2018, 9:20 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura requested review of D6956: efl-csharp: Make sure efl_finalize overrides are callable.
Aug 30 2018, 9:10 PM · efl

Aug 24 2018

lauromoura requested review of D6908: csharp: Fix event registration in constructor..
Aug 24 2018, 7:06 AM · efl
lauromoura added a revision to T7346: C# bindings: event handler cannot be added in constructor: D6908: csharp: Fix event registration in constructor..
Aug 24 2018, 7:06 AM · efl: language bindings

Aug 21 2018

lauromoura added a comment to T7204: Discussion about C# binding syntax.

Another alternative would be hiding the init into the constructors/class methods, initializing the libraries lazily, at the cost of a bool check on each call for these functions.

Aug 21 2018, 3:19 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7204: Discussion about C# binding syntax.

@lauromoura Why are there init / shutdown functions at all? Isn't there a way to automatically init elementary when mono is spinning up ?

Aug 21 2018, 2:55 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7204: Discussion about C# binding syntax.

OK, understood, thanks.

I also understand now the need for the efl.All and efl.ui.Config artificial classes. However, since they serve the same purpose (C# does not support global methods), I really think they should have the same name. As you say, Config is already an Eo interface, so what about efl.Global and efl.ui.Global ?

Aug 21 2018, 2:22 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7204: Discussion about C# binding syntax.

Thanks a lot Lauro for the very detailed answer. I still have some questions though.

  • Regarding class instantiation, I wanted to clarify the type of the variable (unfortunately you used var in your example). So, is the following code still the recommended way? efl.ui.IBox box = new efl.ui.Box(win);
Aug 21 2018, 8:50 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7204: Discussion about C# binding syntax.

Hi @felipealmeida!

Any progress on this? I am unsure if you need anything from us or you are making progress on your own.

Aug 21 2018, 7:42 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura updated the diff for D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.

Update with more descriptive message

Aug 21 2018, 5:21 AM · efl

Aug 20 2018

lauromoura requested review of D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 20 2018, 8:56 PM · efl
lauromoura added a revision to T7324: Circular dependency: D6881: cxx: Remove libeolian_cxx dependency on eo_cxx.
Aug 20 2018, 8:56 PM · efl: meson, Restricted Project

Aug 6 2018

lauromoura added a comment to T7108: C# bindings: eo-intro tutorial has an ERROR on shutdown.

More info: This happens as the C# wrappers are kept alive by the GC and actually deleted only after the call to efl.All.Shutdown().

Aug 6 2018, 3:29 PM · efl: language bindings

Jul 23 2018

lauromoura added a comment to T7181: Life tutorial C# cannot be paused / resumed.

Could you check my branch devs/lauromoura/fix-csharp-life on the examples repo?

Jul 23 2018, 7:15 AM · efl: language bindings, efl: docs, examples

Jul 17 2018

lauromoura added a comment to T7161: C# bindings: EFL classes cannot be inherited from.

Do you mean generated classes? The "concrete" ones are indeed sealed as they shouldn't be inherited from. For this use the classes with the Inherit suffix (e.g. efl.ui.ButtonInherit).

Jul 17 2018, 8:42 PM · efl (efl-1.22), efl: language bindings

Jul 15 2018

lauromoura added a comment to T7137: C# binding DllImport problems with Mono 4.

Looks like we found where the value changes:

Jul 15 2018, 10:57 AM · efl: language bindings

Jul 13 2018

lauromoura added a comment to T7137: C# binding DllImport problems with Mono 4.

More info:

Jul 13 2018, 7:34 PM · efl: language bindings

Jul 12 2018

lauromoura added a comment to T7137: C# binding DllImport problems with Mono 4.

Just a clarification: The aforementioned commit does not actually introduce this bug, only reveals it through the efl.Loop_Timer instantiation. This may happen to other native calls from the binding.

Jul 12 2018, 10:43 AM · efl: language bindings
lauromoura triaged T7137: C# binding DllImport problems with Mono 4 as Normal priority.
Jul 12 2018, 10:40 AM · efl: language bindings

Jun 29 2018

lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

Mixed up revisions?

Jun 29 2018, 11:24 AM · efl

Jun 28 2018

lauromoura accepted D6470: configure: check if realpath program exists.

Worked fine here, both with and without realpath.

Jun 28 2018, 6:00 PM · efl

Jun 26 2018

lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

i use d-bus from win-builds

do you know how your d-bus has been compiled ?

Jun 26 2018, 5:03 AM · efl

Jun 25 2018

lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

Removed the call to dbus-session and it didn't seem to affect anything other than the kill errors.

Jun 25 2018, 4:33 PM · efl
lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.

From https://cgit.freedesktop.org/dbus/dbus/tree/tools/dbus-launch-win.c

Jun 25 2018, 4:26 PM · efl
lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.
In D6286#109365, @zmike wrote:

@lauromoura I will wait on your review before taking further action with this patch since you were looking into this for some time.

Jun 25 2018, 3:22 PM · efl

Jun 21 2018

Herald edited projects for D6359: tests: Use EFL_START/END_TEST in cxx tests, added: efl; removed Restricted Project.
Jun 21 2018, 5:20 PM · efl
Herald added a reviewer for D6359: tests: Use EFL_START/END_TEST in cxx tests: devilhorns.
Jun 21 2018, 4:53 PM · efl
lauromoura added a comment to D6351: eldbux-cxx: Remove test accessing system bus..
In D6351#108763, @zmike wrote:

Seems good.

Also those tests should all use EFL_START_TEST and EFL_END_TEST macros if they compile in C++ in order to provide profiling info.

Ok, I'll update.

Actually, all cxx tests are still using START_TEST. I think changing it would be better in another commit, along with the other tests.

Jun 21 2018, 4:12 PM · efl
lauromoura added a comment to D6351: eldbux-cxx: Remove test accessing system bus..
In D6351#108763, @zmike wrote:

Seems good.

Also those tests should all use EFL_START_TEST and EFL_END_TEST macros if they compile in C++ in order to provide profiling info.

Ok, I'll update.

Jun 21 2018, 4:12 PM · efl
lauromoura added a comment to D6351: eldbux-cxx: Remove test accessing system bus..
In D6351#108763, @zmike wrote:

Seems good.

Also those tests should all use EFL_START_TEST and EFL_END_TEST macros if they compile in C++ in order to provide profiling info.

Jun 21 2018, 3:33 PM · efl
Herald added a reviewer for D6351: eldbux-cxx: Remove test accessing system bus.: devilhorns.
Jun 21 2018, 1:37 PM · efl

Jun 15 2018

lauromoura added inline comments to D6286: Tests: remove warnings when compiling tests if fork is not available.
Jun 15 2018, 2:56 PM · efl
lauromoura added a comment to D6286: Tests: remove warnings when compiling tests if fork is not available.
./dbus-session.sh: ligne 7: -- : commande introuvable
kill : utilisation :kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... ou kill -l [sigspec]
FAIL tests/evil/evil_suite.exe (exit status: 127)

with dbus-session.sh being the script given by lauromoura

Jun 15 2018, 1:36 PM · efl
lauromoura requested changes to D6286: Tests: remove warnings when compiling tests if fork is not available.

It seems dbus-launch invocation is different from dbus-run-session and can't be used as a drop-in replacement. dbus-launch will start a new bus session and give the code to set the DBUS_SESSION_* variables to this new bus, while 'dbus-run-sesssion' takes a command and runs it on a new shell.

Jun 15 2018, 6:05 AM · efl

Jun 12 2018

lauromoura removed a parent revision for D6262: evil: Fix test compilation.: D6261: efl_mono: Fix call to System.Threading.Thread..
Jun 12 2018, 2:31 PM · Windows, efl
lauromoura removed a child revision for D6261: efl_mono: Fix call to System.Threading.Thread.: D6262: evil: Fix test compilation..
Jun 12 2018, 2:31 PM · efl
lauromoura planned changes to D6263: tests: Do not use dbus-run-session in Windows.
In D6263#107161, @zmike wrote:

I recall having an issue like this too recently when I was doing some Windows work; is this a PATH problem or ?

Disabling this seems bad since it will cause all eldbus tests to fail...

Jun 12 2018, 12:17 PM · Windows, efl
lauromoura added a project to D6263: tests: Do not use dbus-run-session in Windows: Windows.
Jun 12 2018, 12:07 PM · Windows, efl
lauromoura added a project to D6262: evil: Fix test compilation.: Windows.
Jun 12 2018, 12:06 PM · Windows, efl
lauromoura added a reviewer for D6261: efl_mono: Fix call to System.Threading.Thread.: felipealmeida.
Jun 12 2018, 12:05 PM · efl
Herald edited projects for D6261: efl_mono: Fix call to System.Threading.Thread., added: efl; removed efl: language bindings.
Jun 12 2018, 12:05 PM · efl
Herald added a reviewer for D6263: tests: Do not use dbus-run-session in Windows: devilhorns.
Jun 12 2018, 12:04 PM · Windows, efl
lauromoura added a child revision for D6262: evil: Fix test compilation.: D6263: tests: Do not use dbus-run-session in Windows.
Jun 12 2018, 12:04 PM · Windows, efl
Herald added a reviewer for D6262: evil: Fix test compilation.: devilhorns.
Jun 12 2018, 12:04 PM · Windows, efl
lauromoura added a child revision for D6261: efl_mono: Fix call to System.Threading.Thread.: D6262: evil: Fix test compilation..
Jun 12 2018, 12:04 PM · efl
Herald added a reviewer for D6261: efl_mono: Fix call to System.Threading.Thread.: devilhorns.
Jun 12 2018, 12:04 PM · efl

May 23 2018

lauromoura closed D6190: efl_mono: Initial support for Accessors..
May 23 2018, 3:00 PM · efl
lauromoura closed D6191: efl_mono: Generate support for accessors in .eos.
May 23 2018, 3:00 PM · efl
lauromoura closed D6189: efl_mono: Reject the promise when it's disposed..
May 23 2018, 3:00 PM · efl
lauromoura added a child revision for D6190: efl_mono: Initial support for Accessors.: D6191: efl_mono: Generate support for accessors in .eos.
May 23 2018, 2:28 PM · efl
lauromoura added a child revision for D6189: efl_mono: Reject the promise when it's disposed.: D6190: efl_mono: Initial support for Accessors..
May 23 2018, 2:28 PM · efl

May 18 2018

lauromoura closed D6178: efl_mono: Remove callback,add from event tests..
May 18 2018, 7:22 AM · efl

May 17 2018

lauromoura closed D6175: efl_mono: Start generating eina future in eolian_mono..
May 17 2018, 1:16 PM · efl
lauromoura closed D6174: efl_mono: Initial support for Futures/Promises.
May 17 2018, 1:15 PM · efl
lauromoura closed D6173: efl_mono: Fix eldbus warnings and typo..
May 17 2018, 1:15 PM · efl
lauromoura closed D6172: efl_mono: Add support for Eina.Error/Empty in eina.Value.
May 17 2018, 1:15 PM · efl
lauromoura closed D6171: efl_mono: Add documentation tag in part decl.
May 17 2018, 1:15 PM · efl
lauromoura closed D6170: efl_mono: Fix generation of event arguments.
May 17 2018, 1:15 PM · efl

May 16 2018

lauromoura added a child revision for D6174: efl_mono: Initial support for Futures/Promises: D6175: efl_mono: Start generating eina future in eolian_mono..
May 16 2018, 4:59 PM · efl
lauromoura added a child revision for D6173: efl_mono: Fix eldbus warnings and typo.: D6174: efl_mono: Initial support for Futures/Promises.
May 16 2018, 4:59 PM · efl
lauromoura added a child revision for D6172: efl_mono: Add support for Eina.Error/Empty in eina.Value: D6173: efl_mono: Fix eldbus warnings and typo..
May 16 2018, 4:59 PM · efl
lauromoura added a child revision for D6171: efl_mono: Add documentation tag in part decl: D6172: efl_mono: Add support for Eina.Error/Empty in eina.Value.
May 16 2018, 4:59 PM · efl
lauromoura added a child revision for D6170: efl_mono: Fix generation of event arguments: D6171: efl_mono: Add documentation tag in part decl.
May 16 2018, 4:59 PM · efl

May 11 2018

lauromoura closed D6157: efl_mono: Support type aliases..
May 11 2018, 9:30 AM · efl
lauromoura added a comment to D6157: efl_mono: Support type aliases..
  • The structs removed in eina_common.cs and workaround.cs seem cleanup work unrelated to this commit. Maybe they deserve a separate commit?
May 11 2018, 3:33 AM · efl

May 4 2018

lauromoura added a comment to T6887: MultibuttonEntry legacy name tests are failing.

This seems to have been fixed with ec59f8053a9a7ee7ff848a1bab1d0d980d914bc3, right?

May 4 2018, 11:55 AM · efl

May 3 2018

lauromoura closed D6051: efl_mono: Update tests and examples after rename.
May 3 2018, 2:47 PM · efl
lauromoura closed D6050: efl_mono: Change generated classes naming scheme.
May 3 2018, 2:47 PM · efl
lauromoura closed D6049: efl_mono: More uniformization of the handling of names.
May 3 2018, 2:47 PM · efl
lauromoura closed D6048: elm: Use ck_assert_str_eq for better error logging.
May 3 2018, 2:47 PM · efl
lauromoura updated the diff for D6050: efl_mono: Change generated classes naming scheme.

Update after Vitor explained better how these traits should behave.

May 3 2018, 1:30 PM · efl