Page MenuHomePhabricator

lauromoura (Lauro Neto)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 1:00 PM (212 w, 1 d)
Availability
Available

Recent Activity

Yesterday

lauromoura closed D9999: eolian-mono: add compiler's complaint methods..
Tue, Sep 17, 3:38 PM · efl
lauromoura accepted D9999: eolian-mono: add compiler's complaint methods..
Tue, Sep 17, 3:36 PM · efl

Mon, Sep 16

lauromoura reassigned T7407: efl-mono: Crash on focus callback when quitting focus example from lauromoura to brunobelo.
Mon, Sep 16, 3:53 AM · Restricted Project, efl: language bindings

Fri, Sep 13

lauromoura closed T8198: C#: Hash.DelByValue does not work as Resolved by committing rEFLe973b87bf845: csharp: Fix Hash.DelByValue.
Fri, Sep 13, 3:28 PM · Restricted Project, efl: language bindings
lauromoura closed D9853: csharp: Fix Hash.DelByValue.
Fri, Sep 13, 3:28 PM · efl
lauromoura requested review of D9934: cxx: Fix some warnings from -Wextra.
Fri, Sep 13, 3:19 PM · efl
lauromoura moved T8168: C#: Build with dotnet and upstream meson from Backlog to InProgress on the efl: language bindings board.
Fri, Sep 13, 11:23 AM · efl: language bindings
lauromoura moved T8198: C#: Hash.DelByValue does not work from Backlog to InProgress on the efl: language bindings board.
Fri, Sep 13, 11:23 AM · Restricted Project, efl: language bindings
lauromoura moved T8216: C#: Eo error messages in application shutdown from Backlog to InProgress on the efl: language bindings board.
Fri, Sep 13, 11:23 AM · Restricted Project, efl: language bindings

Wed, Sep 11

lauromoura closed D9904: csharp: Minor change to D9692.
Wed, Sep 11, 7:32 PM · efl
lauromoura accepted D9904: csharp: Minor change to D9692.

There are some other stuff that needs to be update for these examples to actually compile but these are good.

Wed, Sep 11, 7:30 PM · efl
lauromoura added inline comments to D9712: efl-mono: Additional blank line between all methods..
Wed, Sep 11, 7:17 PM · DO NOT MERGE, Restricted Project, efl: language bindings, efl (efl-1.23)
lauromoura closed T7770: efl-mono: examples initialized with Components.Basic fail to run as Resolved by committing rEFLc681b3a1b38a: csharp: Registering events when using Components.Basic..
Wed, Sep 11, 1:31 PM · efl (efl-1.23), examples, efl: language bindings
lauromoura closed D9909: csharp: Registering events when using Components.Basic..
Wed, Sep 11, 1:31 PM · efl
lauromoura accepted D9909: csharp: Registering events when using Components.Basic..

Example working with Basic after this.

Wed, Sep 11, 1:30 PM · efl
lauromoura closed D9891: eolian_mono: fix documentation warning by using "<" and ">".
Wed, Sep 11, 1:16 PM · efl
lauromoura accepted D9891: eolian_mono: fix documentation warning by using "<" and ">".
Wed, Sep 11, 1:15 PM · efl
lauromoura added a comment to T7770: efl-mono: examples initialized with Components.Basic fail to run.

The stringshare check has been fixed with the last string changes but the lock still remains.

Wed, Sep 11, 7:17 AM · efl (efl-1.23), examples, efl: language bindings
lauromoura added a comment to D9717: csharp: Revamp dotnet support.

@lauromoura
I cannot find a proper way to install Efl.Csharp.1.23.0.nupkg on Visual Studio Code on Ubuntu.
But that .nupkg can be installed Visual Studio on Windows.

Wed, Sep 11, 5:46 AM · DO NOT MERGE, efl
lauromoura added a comment to D9717: csharp: Revamp dotnet support.

I added DO_NOT_MERGE as we are in freeze and this is quite a big change in the build files.

Wed, Sep 11, 4:13 AM · DO NOT MERGE, efl
lauromoura added a project to D9717: csharp: Revamp dotnet support: DO NOT MERGE.
Wed, Sep 11, 4:12 AM · DO NOT MERGE, efl

Tue, Sep 10

lauromoura closed D9895: csharp: remove unused delegate and struct.
Tue, Sep 10, 7:46 PM · efl
lauromoura accepted D9895: csharp: remove unused delegate and struct.
Tue, Sep 10, 7:45 PM · efl
lauromoura requested changes to D9894: csharp: cleanup concrete class.

I'm not sure we can remove all these functions from the Concrete classes yet.

Tue, Sep 10, 7:39 PM · efl
lauromoura added a comment to D7373: efl_access: change Efl.Access.Object from mixin to interface.

Is this still valid or should be abandoned given the changes since to both the EFL hierarchy and C# support for mixins/interfaces?

Tue, Sep 10, 4:26 PM · efl
lauromoura closed D9893: csharp: skip static members from interfaces.
Tue, Sep 10, 4:19 PM · efl
lauromoura accepted D9893: csharp: skip static members from interfaces.
Tue, Sep 10, 4:17 PM · efl
lauromoura added a commit to T7494: C#: Mark protected methods as protected: rEFLdfb856158c8e: csharp: Skip non-public members from interfaces.
Tue, Sep 10, 3:41 PM · efl: language bindings
lauromoura closed D9800: csharp: Skip non-public members from interfaces.
Tue, Sep 10, 3:40 PM · efl
lauromoura closed D9887: CSharp: Cleanup test that inserts idle event and do not remove it.
Tue, Sep 10, 3:05 PM · efl
lauromoura closed T8201: C#: Add missing ToString() to Strbuf as Resolved by committing rEFL50a1572c093d: csharp: Adding ToString methods to Strbuf and custommarshaler..
Tue, Sep 10, 2:37 PM · Restricted Project, efl: language bindings
lauromoura closed D9842: csharp: Adding ToString methods to Strbuf and custommarshaler..
Tue, Sep 10, 2:37 PM · efl
lauromoura closed D9725: eolian-mono: Changing order of scope and modifier..
Tue, Sep 10, 1:31 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura added a comment to D9717: csharp: Revamp dotnet support.

I thought about generating and installing the nupkg but it seems referencing the DLL directly in the csproj like the code below would be enough.

Tue, Sep 10, 12:27 PM · DO NOT MERGE, efl
lauromoura closed D9902: build: unbreak destructors.
Tue, Sep 10, 11:12 AM · efl
lauromoura accepted D9902: build: unbreak destructors.

This fixes the tests and unbreaks master.

Tue, Sep 10, 11:11 AM · efl
lauromoura updated the diff for D9717: csharp: Revamp dotnet support.

Updated, now installing both the nupkg and the dll.

Tue, Sep 10, 7:50 AM · DO NOT MERGE, efl

Mon, Sep 9

lauromoura lowered the priority of T8162: C#: .cs file naming with PascalCase from High to Wishlist.

@lauromoura
It is confirmed that SA1402 is not mandatory but it is recommended.

Since SA1402 is problematic with eo and SA1402 requires additional effort, I think it would be better we do not apply SA1402 for now.

We focus on other mandatory rules and major issues and then we may consider SA1402 later when we are able to do it.

Mon, Sep 9, 2:05 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura closed T8166: C#: Remove I prefix from regular classes as Resolved.

Resolved in D9816

Mon, Sep 9, 2:04 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura closed T8166: C#: Remove I prefix from regular classes, a subtask of T7204: Discussion about C# binding syntax, as Resolved.
Mon, Sep 9, 2:04 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added inline comments to D9842: csharp: Adding ToString methods to Strbuf and custommarshaler..
Mon, Sep 9, 1:58 PM · efl
lauromoura accepted D9887: CSharp: Cleanup test that inserts idle event and do not remove it.

Nice catch!

Mon, Sep 9, 1:57 PM · efl
lauromoura accepted D9842: csharp: Adding ToString methods to Strbuf and custommarshaler..
Mon, Sep 9, 1:48 PM · efl
lauromoura abandoned D6263: tests: Do not use dbus-run-session in Windows.

Abandoning as autotools is no more.

Mon, Sep 9, 1:43 PM · Windows, efl
lauromoura requested review of D9886: evas: Avoid call of efl_del without parent.
Mon, Sep 9, 1:13 PM · efl
lauromoura added a revision to T8216: C#: Eo error messages in application shutdown: D9886: evas: Avoid call of efl_del without parent.
Mon, Sep 9, 1:13 PM · Restricted Project, efl: language bindings
lauromoura triaged T8216: C#: Eo error messages in application shutdown as High priority.
Mon, Sep 9, 12:43 PM · Restricted Project, efl: language bindings
lauromoura abandoned D7242: Efl.Ui.Tree_View: added new MVVM asynchronous widget.

Abandoning as this patch may need a lot of work just to rebase after all MVVM changes since last update.

Mon, Sep 9, 12:27 PM · efl
lauromoura commandeered D7242: Efl.Ui.Tree_View: added new MVVM asynchronous widget.
Mon, Sep 9, 12:25 PM · efl
lauromoura added a comment to T7603: Tree View Implementation.

There was an implementation of TreeView in D7242 late last year but this patch is outdated with the current changes in mvvm, interfaces, etc.

Mon, Sep 9, 12:25 PM · efl (efl-1.23), efl: mvvm
lauromoura closed T8211: eolian_cxx: Update after @by_ref/@cref changes as Resolved.

Marking as resolved after D9867.

Mon, Sep 9, 11:41 AM · Restricted Project, efl: language bindings
lauromoura updated the diff for D9867: eolian_cxx: Add support for @by_ref.

Updating with replacing the non-default type_c_type_get usage with the new param/return_c_type_get functions.

Mon, Sep 9, 9:05 AM · efl
lauromoura closed D9752: eolian_mono: remove redundant code in NativeMethods.
Mon, Sep 9, 12:25 AM · efl

Fri, Sep 6

lauromoura requested review of D9867: eolian_cxx: Add support for @by_ref.
Fri, Sep 6, 2:54 PM · efl
lauromoura requested review of D9866: eolian_cxx: Remove last usage of type_is_owned.
Fri, Sep 6, 11:25 AM · efl
lauromoura triaged T8211: eolian_cxx: Update after @by_ref/@cref changes as High priority.
Fri, Sep 6, 11:18 AM · Restricted Project, efl: language bindings
lauromoura updated the diff for D9800: csharp: Skip non-public members from interfaces.

Update after applying D9752.

Fri, Sep 6, 8:47 AM · efl

Thu, Sep 5

lauromoura edited parent revisions for D9800: csharp: Skip non-public members from interfaces, added: 1; removed: 1.
Thu, Sep 5, 3:47 PM · efl
lauromoura removed a child revision for D9799: efl: Make Efl.Part.part_get public: D9800: csharp: Skip non-public members from interfaces.
Thu, Sep 5, 3:47 PM · efl
lauromoura added a child revision for D9752: eolian_mono: remove redundant code in NativeMethods: D9800: csharp: Skip non-public members from interfaces.
Thu, Sep 5, 3:47 PM · efl
lauromoura planned changes to D9800: csharp: Skip non-public members from interfaces.

Need to change this after D9752 lands.

Thu, Sep 5, 3:47 PM · efl
lauromoura closed T8034: C#: Make C# classes partials as Resolved.

Marking as resolved given D9690 added support to generate partial classes.

Thu, Sep 5, 12:32 PM · efl: language bindings
lauromoura requested review of D9853: csharp: Fix Hash.DelByValue.
Thu, Sep 5, 10:05 AM · efl
lauromoura added a revision to T8198: C#: Hash.DelByValue does not work: D9853: csharp: Fix Hash.DelByValue.
Thu, Sep 5, 10:05 AM · Restricted Project, efl: language bindings

Wed, Sep 4

lauromoura added a comment to T8201: C#: Add missing ToString() to Strbuf.

Messed up with revisions from another task. Sorry.

Wed, Sep 4, 8:55 PM · Restricted Project, efl: language bindings
lauromoura removed revisions from T8201: C#: Add missing ToString() to Strbuf: D9844: bindings: Rename test cxx and csharp eo ownership tags, D9843: eolian_cxx: Replace type_is_owned with is_move.
Wed, Sep 4, 8:55 PM · Restricted Project, efl: language bindings
lauromoura removed a task from D9843: eolian_cxx: Replace type_is_owned with is_move: T8201: C#: Add missing ToString() to Strbuf.
Wed, Sep 4, 8:55 PM · efl
lauromoura removed a task from D9844: bindings: Rename test cxx and csharp eo ownership tags: T8201: C#: Add missing ToString() to Strbuf.
Wed, Sep 4, 8:55 PM · efl
lauromoura added a task to D9844: bindings: Rename test cxx and csharp eo ownership tags: T8199: eolian_cxx: Update after @move/@owned changes.
Wed, Sep 4, 8:54 PM · efl
lauromoura added a revision to T8199: eolian_cxx: Update after @move/@owned changes: D9844: bindings: Rename test cxx and csharp eo ownership tags.
Wed, Sep 4, 8:54 PM · Restricted Project, efl: language bindings
lauromoura added a task to D9843: eolian_cxx: Replace type_is_owned with is_move: T8199: eolian_cxx: Update after @move/@owned changes.
Wed, Sep 4, 8:54 PM · efl
lauromoura added a revision to T8199: eolian_cxx: Update after @move/@owned changes: D9843: eolian_cxx: Replace type_is_owned with is_move.
Wed, Sep 4, 8:54 PM · Restricted Project, efl: language bindings
lauromoura requested review of D9844: bindings: Rename test cxx and csharp eo ownership tags.
Wed, Sep 4, 8:53 PM · efl
lauromoura added a child revision for D9843: eolian_cxx: Replace type_is_owned with is_move: D9844: bindings: Rename test cxx and csharp eo ownership tags.
Wed, Sep 4, 8:53 PM · efl
lauromoura added a revision to T8201: C#: Add missing ToString() to Strbuf: D9844: bindings: Rename test cxx and csharp eo ownership tags.
Wed, Sep 4, 8:53 PM · Restricted Project, efl: language bindings
lauromoura requested review of D9843: eolian_cxx: Replace type_is_owned with is_move.
Wed, Sep 4, 8:52 PM · efl
lauromoura added a revision to T8201: C#: Add missing ToString() to Strbuf: D9843: eolian_cxx: Replace type_is_owned with is_move.
Wed, Sep 4, 8:52 PM · Restricted Project, efl: language bindings
lauromoura requested changes to D9842: csharp: Adding ToString methods to Strbuf and custommarshaler..
Wed, Sep 4, 3:28 PM · efl
lauromoura triaged T8203: Create manual binding for ecore_main_loop_thread_safe_call_async and ecore_main_loop_thread_safe_call_sync for C# as High priority.
Wed, Sep 4, 3:27 PM
lauromoura triaged T8201: C#: Add missing ToString() to Strbuf as High priority.
Wed, Sep 4, 9:05 AM · Restricted Project, efl: language bindings
lauromoura triaged T8199: eolian_cxx: Update after @move/@owned changes as High priority.
Wed, Sep 4, 6:48 AM · Restricted Project, efl: language bindings
lauromoura created T8199: eolian_cxx: Update after @move/@owned changes.
Wed, Sep 4, 6:47 AM · Restricted Project, efl: language bindings
lauromoura triaged T8198: C#: Hash.DelByValue does not work as High priority.
Wed, Sep 4, 5:11 AM · Restricted Project, efl: language bindings

Tue, Sep 3

lauromoura updated the diff for D9800: csharp: Skip non-public members from interfaces.

Fix code skipping doc reference conversion for property accessors.

Tue, Sep 3, 7:12 PM · efl
lauromoura updated the summary of D9800: csharp: Skip non-public members from interfaces.
Tue, Sep 3, 6:46 PM · efl
lauromoura updated the diff for D9800: csharp: Skip non-public members from interfaces.

Update by fixing property accessor generation.

Tue, Sep 3, 6:44 PM · efl
lauromoura accepted D9816: eolian-mono: Removing I prefix from classes..
Tue, Sep 3, 3:52 PM · efl
lauromoura added a parent revision for D9816: eolian-mono: Removing I prefix from classes.: D9692: eolian-mono: Renaming suffix for event and event args.
Tue, Sep 3, 3:32 PM · efl
lauromoura added a child revision for D9692: eolian-mono: Renaming suffix for event and event args: D9816: eolian-mono: Removing I prefix from classes..
Tue, Sep 3, 3:32 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

If actually needed, we could disable this rule for generated code and keep it only for the manual code.

Tue, Sep 3, 11:46 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

@Jaehyun_Cho, what would be the reason for these requirements? (We're not questioning them, just trying to understand the issue better. :) )

The main reason is to make class name and cs file name same :)
As you know, efl_ui_layout.eo.cs contains class Layout in the namespace Efl and Ui.
Therefore, it was suggested that efl_ui_layout.eo.cs should be renamed to Layout.cs which is the same name with class Layout. And Layout.cs should be moved to Efl.Ui namespace directory to avoid duplicate cs file names.

Tue, Sep 3, 11:44 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings

Mon, Sep 2

lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

@segfaultxavi
The main issues of this task are as follows.

  1. All C# source files (.cs) should be located in the directory named fully-qualified namespace.
    • e.g. cs file for class Efl.A.cs should be located in directory Efl. This means that Efl/A.cs
Mon, Sep 2, 10:52 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura requested changes to D9816: eolian-mono: Removing I prefix from classes..

This looks good for the *Concrete classes.

Mon, Sep 2, 7:52 PM · efl
lauromoura accepted D9725: eolian-mono: Changing order of scope and modifier..

Working good. Sorry for the delay reviewing the first version.

Mon, Sep 2, 7:14 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura requested changes to D9725: eolian-mono: Changing order of scope and modifier..

Needs rebase after D9690 (conflicted in klass.hh)

Mon, Sep 2, 3:42 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura closed T8133: C#: Support multi-value properties as Resolved.

Closing as it was commited in D9577

Mon, Sep 2, 8:32 AM
lauromoura added a comment to D9800: csharp: Skip non-public members from interfaces.

protected methods have been removed from interfaces, but they wrapper properties still exist. They should be removed too, right?

Mon, Sep 2, 7:36 AM · efl

Fri, Aug 30

lauromoura added a comment to D9569: efl_canvas_text: rename to efl_canvas_text_canvas.
In T8093#140311, @tasn wrote:

@woohyun, I'm going to reshuffle things in the text space so I wouldn't worry about making a decision/change yet. I'll take a look at the WPF naming scheme when changing though.

@tasn have a plan to reshuffle text space. I think we can discuss after text class refactoring if there is still name conflict.

Fri, Aug 30, 4:14 PM · efl
lauromoura accepted D9692: eolian-mono: Renaming suffix for event and event args.

Good to go. Examples to be updated in another diff.

Fri, Aug 30, 3:49 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura updated the summary of D9800: csharp: Skip non-public members from interfaces.
Fri, Aug 30, 12:37 PM · efl