Page MenuHomePhabricator

lauromoura (Lauro Neto)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2015, 1:00 PM (194 w, 6 d)
Availability
Available

Recent Activity

Thu, May 16

lauromoura abandoned D8867: csharp: Slim Concrete classes..

Concrete classes serve as a wrapper for eventual private classes that implement the given interface, akin to the *Realized classes for abstracts.

Thu, May 16, 7:21 AM · efl

Mon, May 13

lauromoura requested review of D8889: csharp: Fix event marshalling for value types.
Mon, May 13, 5:27 PM · efl
lauromoura added a revision to T7957: VisibilityChanged event contains wrong info: D8889: csharp: Fix event marshalling for value types.
Mon, May 13, 5:27 PM · efl: language bindings, efl: api

Wed, May 8

lauromoura requested review of D8867: csharp: Slim Concrete classes..
Wed, May 8, 3:02 PM · efl

Mon, May 6

lauromoura requested review of D8835: csharp: Add Part suffix for the part wrappers.
Mon, May 6, 12:47 PM · efl
lauromoura added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I think this can be solved very easily by making C# suffix parts with Part automatically, just like events. Then we can remove the restriction that parts cannot be named like other properties (just like events).

Let me explain:

We have different kinds of symbols in EO files: Namespaces, Classes, Methods (and Properties), Events and Parts.
In C they can have the same name, symbol clashes are not a problem, and this is why originally our hierarchy had lots of duplicates.

When we started implementing bindings, some languages had issues with the symbol clashes: Python and C# cannot have a class named like a namespace (not even changing the case, because in Python class hierarchy maps to the filesystem, and the Windows filesystem is case-insensitive). In C# a property cannot have the same name as the class, etc.
We started solving these issues in different ways, and I think this was a mistake. For example, in C#, events are automatically suffixed with Evt so clashing is resolved, but not so parts.

As a result, these are the current rules that eolian is enforcing (as far as I understand):

  • Classes cannot clash with Namespaces
  • Methods (and Properties) cannot clash with anything
  • Events cannot clash with other events
  • Parts cannot clash with anything

    I think these rules work nicely for all cases except parts, which we have not used much yet. So, if the C# bindings suffix parts with Part just like events are suffixed Evt we can remove the restriction on part names and we can use more sensible names like text, icon and extra (without prefix). Of course, names will still need to be unique inside a widget's hierarchy (a part cannot have the same name as another part up in the hierarchy).

    What do you think @cedric, @SanghyeonLee, @lauromoura, @q66 ?
Mon, May 6, 9:14 AM · efl

Fri, May 3

lauromoura requested review of D8818: csharp: Fix property helper doc indent.
Fri, May 3, 4:37 PM · efl
lauromoura added a revision to T7794: efl-mono: Property wrapper docs are not properly indented: D8818: csharp: Fix property helper doc indent.
Fri, May 3, 4:37 PM · efl: docs, efl: language bindings
lauromoura requested review of D8817: pyolian: Fix tests.
Fri, May 3, 3:37 PM · efl
lauromoura added a comment to T7813: mono-docs: Better docs for Event wrappers.

This is just a struct to wrap the event parameters. The event documentation itself is already present in the EventHandler field.

Fri, May 3, 9:10 AM · efl: docs, efl: language bindings
lauromoura updated the diff for D8808: csharp: Add docs for aliases.

Update after Xavi's comments

Fri, May 3, 6:58 AM · efl

Thu, May 2

lauromoura closed D8811: cxx: Fix missing bits from header rename.
Thu, May 2, 11:47 PM · efl
lauromoura requested changes to D8812: cxx: fix autotools build error.

I had added this fix in D8811 alongside others. Added you as reviewer there.

Thu, May 2, 8:31 PM · efl
lauromoura added a reviewer for D8811: cxx: Fix missing bits from header rename: woohyun.
Thu, May 2, 8:31 PM · efl
lauromoura added a reviewer for D8811: cxx: Fix missing bits from header rename: bu5hm4n.
Thu, May 2, 3:05 PM · efl
lauromoura requested review of D8811: cxx: Fix missing bits from header rename.
Thu, May 2, 2:47 PM · efl
lauromoura updated the diff for D8810: model: Add some missing docs bits..

Update fixing typo.

Thu, May 2, 1:39 PM · efl
lauromoura reopened T7842: docs: Document Efl.Ui.TabBar methods as "Open".
Thu, May 2, 1:36 PM · efl: docs, Restricted Project
lauromoura reopened T7842: docs: Document Efl.Ui.TabBar methods, a subtask of T5826: Improve overall EFL documentation, as Open.
Thu, May 2, 1:36 PM · efl: docs, Restricted Project
lauromoura triaged T7843: docs: Document Efl.Ui.ListViewLayoutItem as Normal priority.
Thu, May 2, 1:35 PM · efl: docs, Restricted Project
Herald closed T7842: docs: Document Efl.Ui.TabBar methods as Invalid.

This ticket has been closed as spam because it lacks a description. If this ticket is not spam, please reopen it after adding a description.

Thu, May 2, 1:34 PM · efl: docs, Restricted Project
lauromoura requested review of D8810: model: Add some missing docs bits..
Thu, May 2, 1:03 PM · efl
lauromoura requested review of D8809: csharp: Some docs improvements..
Thu, May 2, 1:02 PM · efl
lauromoura requested review of D8808: csharp: Add docs for aliases.
Thu, May 2, 12:32 PM · efl
lauromoura added a revision to T7689: efl-mono: Eolian types are missing docs: D8808: csharp: Add docs for aliases.
Thu, May 2, 12:32 PM · efl: language bindings
lauromoura added inline comments to D8803: evas_object_textblock: Fix binary search fail..
Thu, May 2, 7:39 AM · efl
lauromoura updated the diff for D8803: evas_object_textblock: Fix binary search fail..

Update with test and extra fix

Thu, May 2, 7:34 AM · efl
lauromoura commandeered D8803: evas_object_textblock: Fix binary search fail..
Thu, May 2, 7:20 AM · efl

Fri, Apr 26

lauromoura moved T7689: efl-mono: Eolian types are missing docs from TODO to InProgress on the efl: language bindings board.
Fri, Apr 26, 3:41 PM · efl: language bindings

Wed, Apr 24

lauromoura added a comment to D8678: eo: add events to track the ownership status of an Eo object.

Results of expedite-cmp (I've patched it to aggregate the average values of the comparison files in the second column):

Wed, Apr 24, 2:55 PM · efl
lauromoura requested review of D8700: 2to3 modifications to expedite-cmp.
Wed, Apr 24, 7:48 AM
lauromoura closed D8693: meson: Fix evas engine install directory..
Wed, Apr 24, 6:11 AM · efl

Tue, Apr 23

lauromoura added a comment to D8693: meson: Fix evas engine install directory..

I caught this error after doing a fresh install without old modules installed.

Tue, Apr 23, 7:34 PM · efl
lauromoura requested review of D8693: meson: Fix evas engine install directory..
Tue, Apr 23, 7:31 PM · efl
lauromoura accepted D8692: meson: ensure that buffer header is installed correctly.

E compiles correctly after this.

Tue, Apr 23, 1:29 PM · efl

Mon, Apr 22

lauromoura updated the diff for D8679: csharp: Fix test code memory handling.

Removed uneeded initializations

Mon, Apr 22, 3:01 PM · efl
lauromoura planned changes to D8679: csharp: Fix test code memory handling.
Mon, Apr 22, 2:54 PM · efl
lauromoura added a comment to D8679: csharp: Fix test code memory handling.

The failure occurred because the Dummy.TestObject.set_value implementation either freed the stored value or created the new one. This worked normally outside of debug mode probably due to mempool reusing the memory address. The debug build uses the pass-through mempool, making the problem appear.

Mon, Apr 22, 2:48 PM · efl
lauromoura requested review of D8679: csharp: Fix test code memory handling.
Mon, Apr 22, 2:44 PM · efl
lauromoura added a revision to T7792: efl-mono: testsuite fails when built in debug mode with meson: D8679: csharp: Fix test code memory handling.
Mon, Apr 22, 2:44 PM · Restricted Project, efl: language bindings
lauromoura updated the diff for D8645: csharp: refactor native_inherit into a nested class..

Rebase and fix comment.

Mon, Apr 22, 2:28 PM · efl

Apr 18 2019

lauromoura updated subscribers of T7792: efl-mono: testsuite fails when built in debug mode with meson.

Here I get a segfault when trying to create an empty Eina_Value (before assigning). And looks like there is more instability regarding Eina (at least with C# apps). Some calls to Eina.Log.Error also made the program crash. Will investigate more.

Apr 18 2019, 2:52 PM · Restricted Project, efl: language bindings
lauromoura moved T7792: efl-mono: testsuite fails when built in debug mode with meson from Backlog to InProgress on the efl: language bindings board.
Apr 18 2019, 11:31 AM · Restricted Project, efl: language bindings
lauromoura added a child revision for D8650: csharp: Fixes repeated method names.: Unknown Object (Differential Revision).
Apr 18 2019, 11:13 AM · efl
lauromoura requested review of D8650: csharp: Fixes repeated method names..
Apr 18 2019, 11:12 AM · efl
lauromoura added a child revision for D8645: csharp: refactor native_inherit into a nested class.: D8650: csharp: Fixes repeated method names..
Apr 18 2019, 11:11 AM · efl
lauromoura added a revision to T7791: efl-mono: Rules to prevent methods called like classes need to take the I interface prefix into account: D8650: csharp: Fixes repeated method names..
Apr 18 2019, 11:11 AM · efl: language bindings
lauromoura accepted D8648: ci: disable mingw build temporarily.
Apr 18 2019, 9:35 AM · efl
lauromoura added a comment to T7742: C#: Replace IntPtr constructor with factory method.

After D8550, Concrete classes constructors are private and regular classes intptrs constructors are protected.

Apr 18 2019, 6:53 AM · documentation, efl: language bindings
lauromoura added a subtask for T7742: C#: Replace IntPtr constructor with factory method: T7800: C#: Attach wrapper lifetime to the Eo instance.
Apr 18 2019, 6:51 AM · documentation, efl: language bindings
lauromoura added a parent task for T7800: C#: Attach wrapper lifetime to the Eo instance: T7742: C#: Replace IntPtr constructor with factory method.
Apr 18 2019, 6:51 AM · efl: language bindings

Apr 17 2019

lauromoura requested review of D8645: csharp: refactor native_inherit into a nested class..
Apr 17 2019, 2:57 PM · efl
lauromoura added a child revision for D8622: csharp: Small style changes: D8645: csharp: refactor native_inherit into a nested class..
Apr 17 2019, 2:57 PM · efl
lauromoura added a revision to T7743: C#: Hide NativeInherit classes from top level namespaces.: D8645: csharp: refactor native_inherit into a nested class..
Apr 17 2019, 2:57 PM · documentation, efl: language bindings
lauromoura abandoned D8613: csharp: Function coding style changes.

Abandoning as this will be split in future diffs.

Apr 17 2019, 12:21 PM · efl

Apr 16 2019

lauromoura requested review of D8622: csharp: Small style changes.
Apr 16 2019, 11:08 AM · efl
lauromoura added a child revision for D8614: csharp: klass style changes: D8622: csharp: Small style changes.
Apr 16 2019, 11:07 AM · efl: language bindings
lauromoura edited projects for D8614: csharp: klass style changes, added: efl: language bindings; removed efl.
Apr 16 2019, 7:43 AM · efl: language bindings
lauromoura updated the summary of D8614: csharp: klass style changes.
Apr 16 2019, 7:42 AM · efl: language bindings
lauromoura edited parent revisions for D8614: csharp: klass style changes, added: 1; removed: 1.
Apr 16 2019, 7:42 AM · efl: language bindings
lauromoura added a child revision for D8612: csharp: Simple spacing rules changes: D8614: csharp: klass style changes.
Apr 16 2019, 7:42 AM · efl
lauromoura removed a child revision for D8613: csharp: Function coding style changes: D8614: csharp: klass style changes.
Apr 16 2019, 7:42 AM · efl
lauromoura planned changes to D8613: csharp: Function coding style changes.

I have a working patch here moving the NativeInherit classes into a nested NativeMethods class. I'll do some more tests whether these SuppressMessage directives are necessary.

Apr 16 2019, 7:14 AM · efl
lauromoura updated the diff for D8612: csharp: Simple spacing rules changes.

Update moving check for empty string to root generate_tag.

Apr 16 2019, 6:15 AM · efl
lauromoura added a comment to D8612: csharp: Simple spacing rules changes.

Much nicer, but there is still some non-perfect whitespace:
If you search for ///< (without separating space) in klass.h and struct_definition.hh you can find many places.

Apr 16 2019, 6:12 AM · efl

Apr 15 2019

lauromoura added a parent revision for D8614: csharp: klass style changes: D8613: csharp: Function coding style changes.
Apr 15 2019, 3:11 PM · efl: language bindings
lauromoura added a child revision for D8613: csharp: Function coding style changes: D8614: csharp: klass style changes.
Apr 15 2019, 3:11 PM · efl
lauromoura requested review of D8614: csharp: klass style changes.
Apr 15 2019, 3:11 PM · efl: language bindings
lauromoura added a child revision for D6213: elm_colorselector: fix improperly named API theme parts: D8614: csharp: klass style changes.
Apr 15 2019, 3:11 PM · efl
lauromoura requested review of D8613: csharp: Function coding style changes.
Apr 15 2019, 2:51 PM · efl
lauromoura added a child revision for D8612: csharp: Simple spacing rules changes: D8613: csharp: Function coding style changes.
Apr 15 2019, 2:51 PM · efl
lauromoura requested review of D8612: csharp: Simple spacing rules changes.
Apr 15 2019, 2:20 PM · efl
lauromoura added a comment to T7418: efl-mono: Removing widgets leaves app in unstable state.

This probably will depend on T7800.

Apr 15 2019, 12:43 PM · efl: language bindings
lauromoura requested review of D8611: cxx: Fix eldbus meta include name.
Apr 15 2019, 12:36 PM · efl
lauromoura added a revision to T7805: error when installing c++ header: D8611: cxx: Fix eldbus meta include name.
Apr 15 2019, 12:36 PM · Restricted Project
lauromoura requested review of D8609: csharp: Remove warning about clashing GetType() methods.
Apr 15 2019, 9:32 AM · efl
lauromoura added a revision to T7727: C#: Clash with System.Object methods: D8609: csharp: Remove warning about clashing GetType() methods.
Apr 15 2019, 9:32 AM
lauromoura requested review of D8608: csharp: Remove unused variable `methods` warning..
Apr 15 2019, 7:25 AM · efl
lauromoura requested review of D8607: csharp: Rename MarshalTest to MarshalEo.
Apr 15 2019, 7:23 AM · efl
lauromoura updated the diff for D8593: csharp: Fix free_cb calling under dotnet..

Update after vitor comments

Apr 15 2019, 7:12 AM · efl

Apr 12 2019

lauromoura added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

Another task that we should take into account together with this is T7785, when C-land uses efl_add/add_ref/new to create instances of C#-derived classes (like in widget factories).

Apr 12 2019, 3:35 PM · efl: language bindings
lauromoura moved T7800: C#: Attach wrapper lifetime to the Eo instance from Backlog to InProgress on the efl: language bindings board.
Apr 12 2019, 3:30 PM · efl: language bindings
lauromoura updated subscribers of T7800: C#: Attach wrapper lifetime to the Eo instance.
Apr 12 2019, 3:23 PM · efl: language bindings
lauromoura added reviewers for D8601: csharp: Make concrete classes internal.: vitor.sousa, felipealmeida.
Apr 12 2019, 11:45 AM · efl
lauromoura requested review of D8601: csharp: Make concrete classes internal..
Apr 12 2019, 9:06 AM · efl
lauromoura added a revision to T7801: mono-docs: Concrete classes do not need any kind of documentation: D8601: csharp: Make concrete classes internal..
Apr 12 2019, 9:06 AM · efl: docs, efl: language bindings

Apr 11 2019

lauromoura triaged T7800: C#: Attach wrapper lifetime to the Eo instance as High priority.
Apr 11 2019, 2:20 PM · efl: language bindings

Apr 10 2019

lauromoura updated subscribers of D8593: csharp: Fix free_cb calling under dotnet..
Apr 10 2019, 6:02 PM · efl
lauromoura requested review of D8593: csharp: Fix free_cb calling under dotnet..
Apr 10 2019, 6:01 PM · efl

Apr 9 2019

lauromoura updated the diff for D8588: csharp: Fix GetUserMethods and NativeClass.

Remove uneeded Console.WriteLine

Apr 9 2019, 4:36 PM · efl
lauromoura requested review of D8588: csharp: Fix GetUserMethods and NativeClass.
Apr 9 2019, 2:44 PM · efl
lauromoura added inline comments to D8587: efl-mono: Allow doc XML tags to be nested.
Apr 9 2019, 12:06 PM · efl
lauromoura accepted D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 9 2019, 7:14 AM · efl

Apr 8 2019

lauromoura added a comment to T7773: Unhandled Exception with custom widget class.

The stack below fixes this instance of the FindProvider problem by making sure only C#-overriden methods are called from C. The proper way to handle private classes will be dealt with in T7789 and related tasks.

Apr 8 2019, 6:25 PM
lauromoura triaged T7790: C#: Make sure we are re-wrapping private classes instances correctly. as Normal priority.
Apr 8 2019, 6:20 PM · efl: language bindings
lauromoura triaged T7789: C#: Define how to deal with private classes passed from C as Normal priority.
Apr 8 2019, 6:12 PM · efl: language bindings
lauromoura added reviewers for D8580: csharp: Add some null checks.: felipealmeida, vitor.sousa, woohyun.
Apr 8 2019, 6:09 PM · efl
lauromoura requested changes to D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 8 2019, 5:58 PM · efl
lauromoura requested review of D8580: csharp: Add some null checks..
Apr 8 2019, 5:57 PM · efl
lauromoura accepted D8575: efl-mono: Fix example for new Application API for C#.
Apr 8 2019, 5:56 PM · efl