Page MenuHomePhabricator

minkyu (Minkyu Kang)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jan 11 2016, 2:03 AM (249 w, 6 d)
Availability
Available

Recent Activity

Mar 6 2018

minkyu closed D5695: elm_entry: recover cursor position when theme is changed.
Mar 6 2018, 7:06 PM · efl

Dec 20 2017

minkyu added reviewers for D5695: elm_entry: recover cursor position when theme is changed: cedric, jpeg, woohyun.
Dec 20 2017, 11:22 PM · efl
minkyu created D5695: elm_entry: recover cursor position when theme is changed.
Dec 20 2017, 11:19 PM · efl

Nov 16 2017

minkyu added a comment to T6368: Strange behaviour of elm_genlist_item_show function.

It look weird if check_scroll is true even though homogeneous is set.
Although I didn't investigate deeply, I found something.

Nov 16 2017, 11:34 PM · efl (efl-1.21), regression, efl: widgets

May 28 2017

minkyu requested changes to D4914: edje: Add edje_object_message_signal_recursive_process.
May 28 2017, 11:08 PM

Mar 2 2017

minkyu added inline comments to D4663: evas: add EVAS_BIDI_DIRECTION_ANY_RTL for evas_object_paragraph_direction_set API.
Mar 2 2017, 6:26 PM · efl

Feb 27 2017

minkyu closed D4554: elementary tooltip: adjust arrow if tooltip was moved by committing rEFLa2dd9fc99dbd: elementary tooltip: adjust arrow if tooltip was moved (authored by minkyu).
Feb 27 2017, 3:33 AM

Feb 23 2017

minkyu updated the test plan for D4554: elementary tooltip: adjust arrow if tooltip was moved.
Feb 23 2017, 12:33 AM
minkyu updated the diff for D4554: elementary tooltip: adjust arrow if tooltip was moved.

calcuate the rel_pos

Feb 23 2017, 12:31 AM

Feb 21 2017

minkyu updated the test plan for D4676: elementary gengrid: fix for working item reorder mode correctly.
Feb 21 2017, 1:29 AM
minkyu created D4676: elementary gengrid: fix for working item reorder mode correctly.
Feb 21 2017, 1:27 AM

Feb 11 2017

minkyu added a comment to D4554: elementary tooltip: adjust arrow if tooltip was moved.

@jpeg not yet. will be update soon.

Feb 11 2017, 5:46 AM

Jan 25 2017

minkyu added a reviewer for D4569: elm_genlist: do not check scroll if show_item is NULL: raster.
Jan 25 2017, 8:52 PM

Jan 17 2017

minkyu added a reviewer for D4569: elm_genlist: do not check scroll if show_item is NULL: SanghyeonLee.
Jan 17 2017, 3:08 AM
minkyu created D4569: elm_genlist: do not check scroll if show_item is NULL.
Jan 17 2017, 3:06 AM

Jan 10 2017

minkyu planned changes to D4554: elementary tooltip: adjust arrow if tooltip was moved.

rel_pos should be calculated.
this patch will be updated.

Jan 10 2017, 10:56 PM

Jan 5 2017

minkyu retitled D4554: elementary tooltip: adjust arrow if tooltip was moved from to elementary tooltip: adjust arrow if tooltip was moved.
Jan 5 2017, 11:57 PM

Dec 13 2016

minkyu accepted D4481: Remove redundant addition operator.

+1

Dec 13 2016, 12:38 AM

Dec 7 2016

minkyu updated subscribers of D4466: access: do not count initted if elm_modapi_init() is fail.
Dec 7 2016, 12:15 AM
minkyu retitled D4466: access: do not count initted if elm_modapi_init() is fail from to access: do not count initted if elm_modapi_init() is fail.
Dec 7 2016, 12:05 AM

Oct 24 2016

minkyu added reviewers for D4358: gengrid: check the edge correctly: Hermet, SanghyeonLee.
Oct 24 2016, 5:05 AM

Oct 20 2016

minkyu added inline comments to D4355: Elm: enable setting custom access info to hoversel items.
Oct 20 2016, 3:39 AM

Oct 19 2016

minkyu added a comment to D4310: elc_hoversel: add the item loop feature.

@jpeg
But, the default behaviour was wrong.

Oct 19 2016, 11:16 PM · efl
minkyu added a comment to D4310: elc_hoversel: add the item loop feature.

@Hermet @cedric ping.

Oct 19 2016, 9:01 PM · efl
minkyu added reviewers for D4358: gengrid: check the edge correctly: cedric, jpeg.
Oct 19 2016, 7:17 PM
minkyu retitled D4358: gengrid: check the edge correctly from to gengrid: check the edge correctly.
Oct 19 2016, 7:15 PM

Sep 28 2016

minkyu added a comment to D4310: elc_hoversel: add the item loop feature.

.. 47 line :)

Sep 28 2016, 7:42 PM · efl

Sep 26 2016

minkyu added a comment to D4254: elementary entry: send a signal to edje for notifying scrollable mode.

Guys! Could you please proceed with it?

Sep 26 2016, 3:23 AM

Sep 22 2016

minkyu added a comment to D4310: elc_hoversel: add the item loop feature.

@Hermet
I saw 39 line in elc_hoversel.h.
That area is for elm_object common APIs.
But APIs that I added are elm_widget APIs.
Is it correct to intend you?

Sep 22 2016, 9:22 PM · efl

Sep 21 2016

minkyu retitled D4310: elc_hoversel: add the item loop feature from to elc_hoversel: add the item loop feature.
Sep 21 2016, 12:27 AM · efl

Sep 1 2016

minkyu updated the test plan for D4272: elm_genlist: apply the item_select_on_focus_disable feature on key_action_move.
Sep 1 2016, 1:29 AM
minkyu retitled D4272: elm_genlist: apply the item_select_on_focus_disable feature on key_action_move from to elm_genlist: apply the item_select_on_focus_disable feature on key_action_move.
Sep 1 2016, 1:26 AM

Aug 31 2016

minkyu updated subscribers of T4478: Evas.Image: Border is not applied if map is enabled.
Aug 31 2016, 6:44 PM · efl: rendering

Aug 30 2016

minkyu added a comment to D4254: elementary entry: send a signal to edje for notifying scrollable mode.

@id213sin
clear. thanks!

Aug 30 2016, 10:06 PM
minkyu added a comment to D4254: elementary entry: send a signal to edje for notifying scrollable mode.

please make sure that do not need to send the signal when elm_entry_scrollable_set is called.

Aug 30 2016, 6:35 PM

Jul 25 2016

minkyu closed D4184: elm_bg: fix typo in doc by committing rEFL5a7535cc4cf2: elm_bg: fix typo in doc (authored by minkyu).
Jul 25 2016, 6:25 PM

Jul 21 2016

minkyu retitled D4184: elm_bg: fix typo in doc from to elm_bg: fix typo in doc.
Jul 21 2016, 11:11 PM

Jun 25 2016

minkyu retitled D4089: label: set sliding only if label size is valid from label: set sliding only if label size if valid to label: set sliding only if label size is valid.
Jun 25 2016, 6:45 AM

Jun 24 2016

minkyu retitled D4089: label: set sliding only if label size is valid from to label: set sliding only if label size if valid.
Jun 24 2016, 12:55 AM

Jun 7 2016

minkyu added a comment to D3916: genlist : do not focus if focus on selection is not enabled..

@SanghyeonLee do you have plan to re-submit?

Jun 7 2016, 9:06 PM

Jun 2 2016

minkyu updated the diff for D4007: tooltip: adjust the coordinate if tooltip was located out of screen.

cover default case.

Jun 2 2016, 5:53 PM
minkyu retitled D4007: tooltip: adjust the coordinate if tooltip was located out of screen from to tooltip: adjust the coordinate if tooltip was located out of screen.
Jun 2 2016, 2:37 AM

Mar 22 2016

minkyu added a comment to D3706: elm_widget : Correct to detect scale change on widget.

Guys, this patch has been pended about 1 month.
Please give feedback about Mr.Shin's comment.

Mar 22 2016, 2:42 AM

Mar 21 2016

minkyu updated the diff for D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call.

rebased

Mar 21 2016, 8:40 PM

Mar 15 2016

minkyu updated the diff for D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call.

rebased

Mar 15 2016, 5:33 PM

Mar 8 2016

minkyu added a comment to D3625: elm_object.h: Add 'elm_object_part_image_set()' API..

@kimcinoo right. "return" is redundant. (src/lib/elm_main.c:1786)

Mar 8 2016, 7:54 PM

Mar 6 2016

minkyu updated D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call.
Mar 6 2016, 10:04 PM
minkyu updated the diff for D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call.

exclude second case, it will be considered another patch

Mar 6 2016, 10:00 PM
minkyu accepted D3728: elm_notify: delete unnecessary smart move/resize..
Mar 6 2016, 5:29 PM

Mar 2 2016

minkyu added inline comments to D3625: elm_object.h: Add 'elm_object_part_image_set()' API..
Mar 2 2016, 6:41 PM

Feb 28 2016

minkyu retitled D3741: elm_image: fix the wrong return value from to elm_image: fix the wrong return value.
Feb 28 2016, 10:32 PM

Feb 27 2016

minkyu requested changes to D3728: elm_notify: delete unnecessary smart move/resize..

I think, it's better to modify the patch title.

Feb 27 2016, 5:14 AM

Feb 24 2016

minkyu added a member for efl: minkyu.
Feb 24 2016, 9:02 PM
minkyu added a comment to D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call.

@Hermet Hi!
_elm_image_efl_file_file_set is called by elm_image_file_set.
And elm_image_file_set call elm_obj_image_sizing_eval after efl_file_set.
Is there any other cases?

Feb 24 2016, 6:11 PM
minkyu added reviewers for D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call: Hermet, cedric.
Feb 24 2016, 2:51 AM
minkyu retitled D3730: elm_image: remove duplicate _elm_image_internal_sizing_eval call from to elm_image: remove duplicate _elm_image_internal_sizing_eval call.
Feb 24 2016, 2:48 AM
minkyu added a comment to D3706: elm_widget : Correct to detect scale change on widget.

@cedric ping. please check

Feb 24 2016, 2:14 AM

Feb 23 2016

minkyu added reviewers for D3724: elm_image: fix wrong API call for scaling: Hermet, cedric.
Feb 23 2016, 12:03 AM

Feb 22 2016

minkyu retitled D3724: elm_image: fix wrong API call for scaling from to elm_image: fix wrong API call for scaling.
Feb 22 2016, 11:57 PM

Feb 19 2016

minkyu added reviewers for D3718: elm_image: remove EINA_UNUSED: Hermet, seoz.
Feb 19 2016, 1:53 AM
minkyu retitled D3718: elm_image: remove EINA_UNUSED from to elm_image: remove EINA_UNUSED.
Feb 19 2016, 1:52 AM

Feb 5 2016

minkyu added a comment to D3625: elm_object.h: Add 'elm_object_part_image_set()' API..

@CHAN
I agree with convenience.
But I am just wondering about this macro.
This macro never check parameters, return values.
And developer can't know about the result.
And can't get img object - I'm not sure that developers want it.

Feb 5 2016, 5:04 AM

Feb 1 2016

minkyu added a comment to D3625: elm_object.h: Add 'elm_object_part_image_set()' API..

It looks risky for exceptions (when you failed to do something).
and such a multi-line macro should be wrapped with do..while(0).
braces can occur build error. please try it.

Feb 1 2016, 3:24 AM

Jan 27 2016

minkyu added inline comments to D3607: elm: add color interfaces.
Jan 27 2016, 11:06 PM · efl
minkyu updated subscribers of D3607: elm: add color interfaces.
Jan 27 2016, 5:17 PM · efl

Jan 21 2016

minkyu added inline comments to D3593: elm_panes: fixed range of middle cursor..
Jan 21 2016, 10:51 PM

Jan 19 2016

minkyu added a reviewer for D3574: elm_widget: cleanup _elm_widget_on_focus function: cedric.
Jan 19 2016, 1:28 AM
minkyu added a reviewer for D3573: elm_widget: use internal function for clearing the focus: cedric.
Jan 19 2016, 1:27 AM

Jan 14 2016

minkyu added reviewers for D3574: elm_widget: cleanup _elm_widget_on_focus function: seoz, Hermet.
Jan 14 2016, 11:48 PM
minkyu added reviewers for D3573: elm_widget: use internal function for clearing the focus: seoz, Hermet.
Jan 14 2016, 11:47 PM
minkyu retitled D3574: elm_widget: cleanup _elm_widget_on_focus function from to elm_widget: cleanup _elm_widget_on_focus function.
Jan 14 2016, 10:53 PM
minkyu retitled D3573: elm_widget: use internal function for clearing the focus from to elm_widget: use internal function for clearing the focus.
Jan 14 2016, 9:56 PM