- User Since
- Jan 24 2016, 4:38 PM (160 w, 3 d)
Jan 3 2019
Dont leak netstar!
Check for existence.
Add a comment about the change.
Brain netstar. Use.
Use safer PACKAGE_SYSCONF_DIR over eina_prefix*
Add test for directory existence.
Fix unused variable warning.
Dec 4 2018
Looks okay. Could check temp_filename for NULL ?
Nov 21 2018
I really think:
Nov 17 2018
Add other misspelt occurrences outside elm_code
Nov 7 2018
Oct 25 2018
That's fine, no problem :)
I'm not sure this is solvable sanely. Or if it needs solving?
Oct 24 2018
This is called every N seconds. If value is 0.0 the custom string set in unit_format_set doesnt get rendered only "0%"
Oct 23 2018
Sorry my explanations were a bit lacking.
It's not the first-run case.
Oct 22 2018
if (EINA_DBL_EQ(sd->val, val) && (!EINA_DBL_EQ(sd->val, sd->val_min)) && (!EINA_DBL_EQ(sd->val, sd->val_max))) return;
As far as I understand the unit format isn't a one-off call. It can be dynamic, as the progress bar itself is.
This should be backported. I can if it looks okay.
Oct 17 2018
Looks fine to me.
Oct 15 2018
Dont have time to test it just now, but it looks okay. I also looked over it briefly yesterday.
Oct 11 2018
./configure.ac: AC_DEFINE_UNQUOTED([OLD_LIBUDEV], , [using older version of libudev]) ./src/lib/eeze/eeze_udev_syspath.c:#ifndef OLD_LIBUDEV
This seems good.
Oct 10 2018
Oct 9 2018
Oct 4 2018
Looks fine to me. I was present during discussion in IRC also.
This looks okay. I can't actually test on every environment.
Oct 3 2018
I've just tested this properly. Works fine. :D
Oct 2 2018
Just to show from the console TMPDIR:
Dont modify that!
Oct 1 2018
To me this looks fine. Have built and looked over the code. Probably needs other eyes before a commit though.
Sep 28 2018
This looks okay. Maybe needs another reviewer to be sure and commit.
Sep 27 2018
Can you also confirm or deny whether pasting the same content size in an elm_entry does the same thing?
Hi, can you attach a file with the content size of a paste which breaks this for you?
Sep 25 2018
I've fixed this in git if you wouldn't mind testing?
Sep 24 2018
Hi Andrew, not sure what you think about this?
This is fine.
Sep 15 2018
Thanks for the report. Will look into it.
Sep 12 2018
This isn't a fix really. All it does is prevents a crash when the focus tree breaks...Basically rather than crash the application just loses all input from keyboard.....
Sep 11 2018
Sep 8 2018
This needs to be done differently. Will create new diff.
Abandon this as it's wrong.
Sep 7 2018
This is wrong. Abandoning.
For sure. I;'m running Debian unstable. This mimetype is showing up a lot.
Sep 6 2018
elm_code_file: preserve permissions when saving.
This is far too expensive here.
We have a ticket with a proposed change to fix this and do it automatically.
Can close this.
Okay, my thoughts on this:
Sep 5 2018
Maybe an obvious point but if this does fix https://phab.enlightenment.org/T7274 perhaps this could be backported also???
Thanks very much for spending so much time on this issue.