Page MenuHomePhabricator

netstar (Al Poole)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2016, 4:38 PM (160 w, 3 d)
Availability
Available

Recent Activity

Jan 3 2019

netstar closed D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..
Jan 3 2019, 11:16 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

nit nit

Jan 3 2019, 11:03 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Dont leak netstar!

Jan 3 2019, 10:53 AM · efl
netstar closed D7536: gadgets: pager (fix crash on mouse up)..
Jan 3 2019, 10:51 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Check for existence.

Jan 3 2019, 10:50 AM · efl
netstar closed D7535: e_main: initialise XDG environment earlier..
Jan 3 2019, 10:37 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Fix typo.

Jan 3 2019, 10:06 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Fix comments.

Jan 3 2019, 10:05 AM · enlightenment-git
netstar requested review of D7536: gadgets: pager (fix crash on mouse up)..
Jan 3 2019, 9:27 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Add a comment about the change.

Jan 3 2019, 7:41 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Brain netstar. Use.

Jan 3 2019, 7:03 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Use safer PACKAGE_SYSCONF_DIR over eina_prefix*

Jan 3 2019, 7:01 AM · efl
netstar requested review of D7535: e_main: initialise XDG environment earlier..
Jan 3 2019, 5:24 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Add test for directory existence.

Jan 3 2019, 5:15 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Fix unused variable warning.

Jan 3 2019, 5:13 AM · efl
netstar requested review of D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..
Jan 3 2019, 5:11 AM · efl

Dec 4 2018

netstar accepted D7412: eio-tests: fix deadlocking of the testsuite.

Looks okay. Could check temp_filename for NULL ?

Dec 4 2018, 7:52 AM · efl

Nov 21 2018

netstar added a comment to T7469: Find a better name for Efl.Factory.model_connect.

I really think:

Nov 21 2018, 1:16 PM · efl: mvvm, Restricted Project

Nov 17 2018

netstar updated the summary of D7299: efl: fix misspelt focused in API and documents..
Nov 17 2018, 6:30 AM · efl
netstar retitled D7299: efl: fix misspelt focused in API and documents. from elm_code: fix spelling of object members. to efl: fix misspelt focused in API and documents..
Nov 17 2018, 6:29 AM · efl
netstar updated the diff for D7299: efl: fix misspelt focused in API and documents..

Add other misspelt occurrences outside elm_code

Nov 17 2018, 6:29 AM · efl
netstar requested review of D7299: efl: fix misspelt focused in API and documents..
Nov 17 2018, 5:08 AM · efl
netstar closed D7298: elm_code: Allow widget to be focused..
Nov 17 2018, 5:05 AM · efl
netstar requested review of D7298: elm_code: Allow widget to be focused..
Nov 17 2018, 4:59 AM · efl
netstar abandoned D7297: Revert "Elm_Code: check pointer nullity before using it".
Nov 17 2018, 4:53 AM · efl
netstar requested review of D7297: Revert "Elm_Code: check pointer nullity before using it".
Nov 17 2018, 4:51 AM · efl

Nov 7 2018

netstar abandoned D7186: elm_progressbar: set custom unit format if value is 0.0..

Abandon this.

Nov 7 2018, 2:49 AM · efl

Oct 25 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

That's fine, no problem :)

Oct 25 2018, 7:47 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

I'm not sure this is solvable sanely. Or if it needs solving?

Oct 25 2018, 5:53 AM · efl

Oct 24 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

This is called every N seconds. If value is 0.0 the custom string set in unit_format_set doesnt get rendered only "0%"

Oct 24 2018, 4:00 AM · efl

Oct 23 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

Sorry my explanations were a bit lacking.

Oct 23 2018, 5:05 PM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

It's not the first-run case.

Oct 23 2018, 4:54 PM · efl

Oct 22 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..
if (EINA_DBL_EQ(sd->val, val) &&
    (!EINA_DBL_EQ(sd->val, sd->val_min)) && (!EINA_DBL_EQ(sd->val, sd->val_max))) return;
Oct 22 2018, 11:14 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

As far as I understand the unit format isn't a one-off call. It can be dynamic, as the progress bar itself is.

Oct 22 2018, 10:40 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

This should be backported. I can if it looks okay.

Oct 22 2018, 5:00 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

Before:

Oct 22 2018, 4:59 AM · efl
netstar requested review of D7186: elm_progressbar: set custom unit format if value is 0.0..
Oct 22 2018, 4:55 AM · efl

Oct 17 2018

netstar accepted D7170: build: move ELM_INTERNAL_API_ARGESFSDFEFC into buildsystem.

Looks fine to me.

Oct 17 2018, 6:07 AM · efl

Oct 15 2018

netstar accepted D7159: meson: fix build files size explosion.

Dont have time to test it just now, but it looks okay. I also looked over it briefly yesterday.

Oct 15 2018, 12:13 PM · efl

Oct 11 2018

netstar accepted D7145: meson: support older udev systems.
./configure.ac:  AC_DEFINE_UNQUOTED([OLD_LIBUDEV], [1], [using older version of libudev])
./src/lib/eeze/eeze_udev_syspath.c:#ifndef OLD_LIBUDEV
Oct 11 2018, 4:01 AM · efl
netstar accepted D7130: elementary: shutdown cocoa currently.

This seems good.

Oct 11 2018, 3:58 AM · efl

Oct 10 2018

netstar accepted D7155: meson: do not build deprecated wl & drm.

Seems fine.

Oct 10 2018, 5:37 AM · efl

Oct 9 2018

netstar accepted D7149: meson: add dl to eina.

Looks good.

Oct 9 2018, 1:32 PM · efl

Oct 4 2018

netstar accepted D7143: meson: add sizeof checks for meson.

Looks fine to me. I was present during discussion in IRC also.

Oct 4 2018, 10:24 AM · efl
netstar accepted D7144: meson: unify system properties.

This looks okay. I can't actually test on every environment.

Oct 4 2018, 10:23 AM · efl
netstar closed D7142: eeze: Add buildsystem to list of dependencies..
Oct 4 2018, 4:41 AM · efl
netstar requested review of D7142: eeze: Add buildsystem to list of dependencies..
Oct 4 2018, 4:35 AM · efl
netstar closed D7141: wallpaper: if previous advanced basic apply follows advanced setting..
Oct 4 2018, 3:54 AM · enlightenment-git
netstar requested review of D7141: wallpaper: if previous advanced basic apply follows advanced setting..
Oct 4 2018, 3:21 AM · enlightenment-git

Oct 3 2018

netstar accepted D7132: meson: install compat ethumb_client.pc file.

I've just tested this properly. Works fine. :D

Oct 3 2018, 9:31 AM · efl

Oct 2 2018

netstar closed D7128: macOS: make eina_environment_tmp_get() work as elsewhere..
Oct 2 2018, 7:16 AM · efl
netstar updated the diff for D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Final. Apologies.

Oct 2 2018, 4:25 AM · efl
netstar added a comment to D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Just to show from the console TMPDIR:

Oct 2 2018, 4:24 AM · efl
netstar updated the diff for D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Dont modify that!

Oct 2 2018, 4:22 AM · efl
netstar requested review of D7128: macOS: make eina_environment_tmp_get() work as elsewhere..
Oct 2 2018, 4:11 AM · efl

Oct 1 2018

netstar accepted D7105: efl_ui_dnd: fixup leaking inits and code duplication.

To me this looks fine. Have built and looked over the code. Probably needs other eyes before a commit though.

Oct 1 2018, 2:16 AM · efl

Sep 28 2018

netstar accepted D7120: eldbus: remove unreachable code..

This looks okay. Maybe needs another reviewer to be sure and commit.

Sep 28 2018, 4:43 AM · efl

Sep 27 2018

netstar added a comment to T7416: Pasting large chunks of text freezes Code Editor..

Can you also confirm or deny whether pasting the same content size in an elm_entry does the same thing?

Sep 27 2018, 4:40 AM · efl: widgets: code
netstar added a comment to T7416: Pasting large chunks of text freezes Code Editor..

Hi, can you attach a file with the content size of a paste which breaks this for you?

Sep 27 2018, 4:39 AM · efl: widgets: code
netstar closed D7101: efreet_menu: remove unused and unreachable code..
Sep 27 2018, 1:14 AM · efl

Sep 25 2018

netstar closed T7398: Evisum doesn't dsplay the state and cpu collumns properly... as Resolved.

I've fixed this in git if you wouldn't mind testing?

Sep 25 2018, 3:42 AM

Sep 24 2018

netstar added a comment to D6965: elm_code: minor refactoring..

Hi Andrew, not sure what you think about this?

Sep 24 2018, 9:43 AM · efl
netstar added a reviewer for D7101: efreet_menu: remove unused and unreachable code.: raster.
Sep 24 2018, 3:27 AM · efl
netstar requested review of D7101: efreet_menu: remove unused and unreachable code..
Sep 24 2018, 3:26 AM · efl
netstar closed D7095: elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text.
Sep 24 2018, 3:19 AM · efl
netstar accepted D7095: elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text.

This is fine.

Sep 24 2018, 3:15 AM · efl

Sep 15 2018

netstar added a comment to T7398: Evisum doesn't dsplay the state and cpu collumns properly....

Thanks for the report. Will look into it.

Sep 15 2018, 8:43 AM

Sep 12 2018

netstar closed D7027: evas_events: NULL check before evas_event_freezes_through..
Sep 12 2018, 12:20 PM · efl
netstar requested review of D7027: evas_events: NULL check before evas_event_freezes_through..
Sep 12 2018, 12:18 PM · efl
netstar closed D7026: efl_ui_focus_manager_calc: invalidate obj on delete..
Sep 12 2018, 12:02 PM · efl
netstar abandoned D7024: evas_events: NULL check before evas_event_freezes_through..

Closing this.

Sep 12 2018, 11:03 AM · efl
netstar requested review of D7026: efl_ui_focus_manager_calc: invalidate obj on delete..
Sep 12 2018, 10:58 AM · efl
netstar added a comment to D7024: evas_events: NULL check before evas_event_freezes_through..

This isn't a fix really. All it does is prevents a crash when the focus tree breaks...Basically rather than crash the application just loses all input from keyboard.....

Sep 12 2018, 3:39 AM · efl
netstar requested review of D7024: evas_events: NULL check before evas_event_freezes_through..
Sep 12 2018, 3:01 AM · efl

Sep 11 2018

netstar closed D7000: elm_code: Make sure we handle python3 mime type..
Sep 11 2018, 4:22 AM · efl

Sep 8 2018

netstar requested review of D7008: elm_code_file: preserve file permissions on save..
Sep 8 2018, 2:19 AM · efl
netstar abandoned D7001: elm_code_file: preserve permissions when saving..

This needs to be done differently. Will create new diff.

Sep 8 2018, 2:11 AM · efl
netstar added a comment to D7001: elm_code_file: preserve permissions when saving..

Abandon this as it's wrong.

Sep 8 2018, 1:55 AM · efl

Sep 7 2018

netstar abandoned D6998: elm_code: fix multi-line selection highlighting..

This is wrong. Abandoning.

Sep 7 2018, 12:24 PM · efl
netstar added a comment to D7000: elm_code: Make sure we handle python3 mime type..

Sep 7 2018, 10:22 AM · efl
netstar added a comment to D7000: elm_code: Make sure we handle python3 mime type..

For sure. I;'m running Debian unstable. This mimetype is showing up a lot.

Sep 7 2018, 10:12 AM · efl

Sep 6 2018

netstar requested review of D7001: elm_code_file: preserve permissions when saving..
Sep 6 2018, 5:06 PM · efl
netstar requested review of D7000: elm_code: Make sure we handle python3 mime type..
Sep 6 2018, 5:00 PM · efl
netstar abandoned D6999: elm_code: Make sure we handle python3 mime type..
Sep 6 2018, 4:58 PM · efl
netstar updated the diff for D6999: elm_code: Make sure we handle python3 mime type..

elm_code_file: preserve permissions when saving.

Sep 6 2018, 4:56 PM · efl
netstar requested review of D6999: elm_code: Make sure we handle python3 mime type..
Sep 6 2018, 4:20 PM · efl
netstar requested review of D6998: elm_code: fix multi-line selection highlighting..
Sep 6 2018, 9:58 AM · efl
netstar abandoned D6992: elm_code: add method to refresh syntax highlighting..
Sep 6 2018, 9:54 AM · efl
netstar triaged T7370: Desksanity: expse window drag to desktop as TODO priority.
Sep 6 2018, 5:31 AM · desksanity
netstar added a watcher for desksanity: netstar.
Sep 6 2018, 5:29 AM
netstar updated the diff for D6992: elm_code: add method to refresh syntax highlighting..

This is far too expensive here.

Sep 6 2018, 5:22 AM · efl
netstar added a comment to T6083: EDI multiline comment: add syntax refresh method to elm_code..

We have a ticket with a proposed change to fix this and do it automatically.

Sep 6 2018, 3:27 AM · efl: widgets, Restricted Project
netstar requested review of D6992: elm_code: add method to refresh syntax highlighting..
Sep 6 2018, 3:25 AM · efl
netstar edited projects for T6083: EDI multiline comment: add syntax refresh method to elm_code., added: Restricted Project, efl: widgets; removed Restricted Project, Restricted Project.
Sep 6 2018, 2:49 AM · efl: widgets, Restricted Project
netstar renamed T6083: EDI multiline comment: add syntax refresh method to elm_code. from EDI multiline comment updates with autosave off to EDI multiline comment: add syntax refresh method to elm_code..
Sep 6 2018, 2:43 AM · efl: widgets, Restricted Project
netstar added a comment to T6083: EDI multiline comment: add syntax refresh method to elm_code..

Can close this.

Sep 6 2018, 2:42 AM · efl: widgets, Restricted Project
netstar closed T5520: elm code does not support 3rd mouse button/emulated 3rd for paste as Wontfix.

Okay, my thoughts on this:

Sep 6 2018, 2:24 AM · efl: widgets, Restricted Project, Restricted Project

Sep 5 2018

netstar added a comment to D6987: elm_scroller: do not auto-scroll when scroller get focus first.

Maybe an obvious point but if this does fix https://phab.enlightenment.org/T7274 perhaps this could be backported also???

Sep 5 2018, 5:03 AM · efl
netstar lowered the priority of T7362: elm_panes: contact resizing issue from High to Normal.

Thanks very much for spending so much time on this issue.

Sep 5 2018, 5:02 AM · efl: widgets
netstar requested review of D6986: elm_code: make the hoversel not focusable..
Sep 5 2018, 2:47 AM · efl