Page MenuHomePhabricator

netstar (Al Poole)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jan 24 2016, 4:38 PM (186 w, 6 d)
Availability
Available

Recent Activity

Sat, Jul 27

netstar updated the task description for T8082: Pager (Live Preview Crash) Drag Windows.
Sat, Jul 27, 1:53 PM · enlightenment-git
netstar triaged T8082: Pager (Live Preview Crash) Drag Windows as Showstopper Issues priority.
Sat, Jul 27, 1:41 PM · enlightenment-git

Jul 11 2019

netstar closed D9279: ELM_CODE: Fix for theming of widget..
Jul 11 2019, 4:21 AM · efl
netstar requested review of D9279: ELM_CODE: Fix for theming of widget..
Jul 11 2019, 3:36 AM · efl

Jun 23 2019

netstar closed D9156: BUILD: Fix EFL build (1.22.x) on OpenBSD..

Done.

Jun 23 2019, 3:49 AM · efl

Jun 22 2019

netstar added a comment to D9156: BUILD: Fix EFL build (1.22.x) on OpenBSD..

This diff is already in master. It needed to be changed slightly in order to be backported into EFL 1.22.x.

Jun 22 2019, 2:29 PM · efl
netstar requested review of D9157: build: Fix build and behaviour on OpenBSD..
Jun 22 2019, 2:27 PM
netstar requested review of D9156: BUILD: Fix EFL build (1.22.x) on OpenBSD..
Jun 22 2019, 2:21 PM · efl

Jun 9 2019

netstar closed D9077: edje_cc_out: Exit instead of segfault on OpenBSD..
Jun 9 2019, 11:26 AM · efl
netstar accepted D9078: edje_cc: protect array lookup.

Works.

Jun 9 2019, 11:21 AM · efl

Jun 8 2019

netstar added a comment to D9077: edje_cc_out: Exit instead of segfault on OpenBSD..

Essentially when EFL is building and using edje_cc on Linux with the above patch the case is being triggered and exiting???

Jun 8 2019, 3:11 PM · efl
netstar added a comment to D9077: edje_cc_out: Exit instead of segfault on OpenBSD..

Okay. So it's breaking on Linux. You mean on Linux it's accessing invalid memory but not being caught by either valgrind and/or crashing?

Jun 8 2019, 3:07 PM · efl
netstar added a comment to D9077: edje_cc_out: Exit instead of segfault on OpenBSD..

Whether to error and continue?

Jun 8 2019, 1:27 AM · efl

Jun 7 2019

netstar updated the diff for D9077: edje_cc_out: Exit instead of segfault on OpenBSD..

meh

Jun 7 2019, 12:34 PM · efl
netstar updated the diff for D9077: edje_cc_out: Exit instead of segfault on OpenBSD..

Indent again. Note-to-self .vimrc.

Jun 7 2019, 12:33 PM · efl
netstar requested review of D9077: edje_cc_out: Exit instead of segfault on OpenBSD..
Jun 7 2019, 12:31 PM · efl

Jun 4 2019

netstar abandoned D9026: edje_cc: Fix segfault on BSD systems..

This is fixed.

Jun 4 2019, 9:36 AM · efl
netstar added a comment to D9026: edje_cc: Fix segfault on BSD systems..

Somebody fixed this. Whoever that was - cheers.

Jun 4 2019, 9:36 AM · efl

May 31 2019

netstar added a comment to D9026: edje_cc: Fix segfault on BSD systems..

@bu5hm4n that would be great if you could get a VM running (w/latest release). I don't have much time right now :(

May 31 2019, 3:41 AM · efl
netstar added a comment to D9026: edje_cc: Fix segfault on BSD systems..

Yes this happens with the default theme.

May 31 2019, 3:39 AM · efl

May 28 2019

netstar closed D9028: build: Fix on OpenBSD..
May 28 2019, 3:04 AM · efl

May 26 2019

netstar requested review of D9028: build: Fix on OpenBSD..
May 26 2019, 4:59 PM · efl
netstar updated the diff for D9026: edje_cc: Fix segfault on BSD systems..

Marcel Feedback array range.

May 26 2019, 9:15 AM · efl
netstar added a comment to D9026: edje_cc: Fix segfault on BSD systems..
#0  0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755
755         part = pc->parts[et->id];
(gdb) print pc
$1 = (Edje_Part_Collection *) 0xa3395ffba00
Current language:  auto; currently minimal
(gdb) print et->id
$2 = 66
(gdb) print part
$3 = (Edje_Part *) 0xa33794dae00
(gdb) print et
$4 = (Edje_Program_Target *) 0xa333e3afd50
(gdb) bt
#0  0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755
#1  0x00000a30d43895bb in check_groups (ef=0xa334abfc080) at bin/edje/edje_cc_out.c:2038
#2  0x00000a30d4388af7 in data_write () at bin/edje/edje_cc_out.c:2862
#3  0x00000a30d438753d in main (argc=2, argv=0x7f7ffffdebf8) at bin/edje/edje_cc.c:452
(gdb) bt
#0  0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755
#1  0x00000a30d43895bb in check_groups (ef=0xa334abfc080) at bin/edje/edje_cc_out.c:2038
#2  0x00000a30d4388af7 in data_write () at bin/edje/edje_cc_out.c:2862
#3  0x00000a30d438753d in main (argc=2, argv=0x7f7ffffdebf8) at bin/edje/edje_cc.c:452
(gdb) frame 0
#0  0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755
755         part = pc->parts[et->id];
(gdb) prnit pc->parts
Undefined command: "prnit".  Try "help".
(gdb) print pc->parts
$5 = (Edje_Part **) 0xa3322b2ae00
(gdb) print pc->parts[et->id];
Invalid character ';' in expression.
(gdb) print pc->parts[et->id]
Cannot access memory at address 0xa3322b2b010
May 26 2019, 8:41 AM · efl
netstar requested review of D9026: edje_cc: Fix segfault on BSD systems..
May 26 2019, 8:38 AM · efl

May 25 2019

netstar updated the summary of D9023: sysinfo: Use unifed API for querrying CPU state..
May 25 2019, 9:13 AM · enlightenment-git
netstar updated the diff for D9023: sysinfo: Use unifed API for querrying CPU state..

Indentation: oops.

May 25 2019, 8:53 AM · enlightenment-git
netstar requested review of D9023: sysinfo: Use unifed API for querrying CPU state..
May 25 2019, 8:51 AM · enlightenment-git

Mar 3 2019

netstar added a comment to T7710: Impossible to build EFL on FreeBSD.

vtorri who knows.

Mar 3 2019, 2:55 AM · efl (efl-1.22)
netstar closed T7710: Impossible to build EFL on FreeBSD as Resolved.

EFL builds here. It's FreeBSD-12.0. Make sure you remove any package that is including inotify headers because the EFL build will see these headers and assume we can use inotify but we cannot use it on FreeBSD. If you have inotify.h in /usr/local/include or elsewhere, remove it, or the package that is pulling in this bogus header.

Mar 3 2019, 2:23 AM · efl (efl-1.22)

Mar 2 2019

netstar closed T7710: Impossible to build EFL on FreeBSD as Resolved.

FreeBSD doesn't have inotify and if you start building EFL on a desktop machine where you pull in things like GIMP, it'll pull in inotify emulation with an inotify.h header that will break your build.

Mar 2 2019, 1:41 PM · efl (efl-1.22)

Feb 28 2019

netstar raised the priority of T7710: Impossible to build EFL on FreeBSD from High to Showstopper Issues.

So libc doesn't have environ symbol.

Feb 28 2019, 7:16 AM · efl (efl-1.22)
netstar added a comment to T7710: Impossible to build EFL on FreeBSD.

This isn't fixin anything.

Feb 28 2019, 3:07 AM · efl (efl-1.22)

Jan 3 2019

netstar closed D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..
Jan 3 2019, 11:16 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

nit nit

Jan 3 2019, 11:03 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Dont leak netstar!

Jan 3 2019, 10:53 AM · efl
netstar closed D7536: gadgets: pager (fix crash on mouse up)..
Jan 3 2019, 10:51 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Check for existence.

Jan 3 2019, 10:50 AM · efl
netstar closed D7535: e_main: initialise XDG environment earlier..
Jan 3 2019, 10:37 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Fix typo.

Jan 3 2019, 10:06 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Fix comments.

Jan 3 2019, 10:05 AM · enlightenment-git
netstar requested review of D7536: gadgets: pager (fix crash on mouse up)..
Jan 3 2019, 9:27 AM · enlightenment-git
netstar updated the diff for D7535: e_main: initialise XDG environment earlier..

Add a comment about the change.

Jan 3 2019, 7:41 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Brain netstar. Use.

Jan 3 2019, 7:03 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Use safer PACKAGE_SYSCONF_DIR over eina_prefix*

Jan 3 2019, 7:01 AM · efl
netstar requested review of D7535: e_main: initialise XDG environment earlier..
Jan 3 2019, 5:24 AM · enlightenment-git
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Add test for directory existence.

Jan 3 2019, 5:15 AM · efl
netstar updated the diff for D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..

Fix unused variable warning.

Jan 3 2019, 5:13 AM · efl
netstar requested review of D7534: efreet: Add installation prefix search for XDG_DATA_DIRS..
Jan 3 2019, 5:11 AM · efl

Dec 4 2018

netstar accepted D7412: eio-tests: fix deadlocking of the testsuite.

Looks okay. Could check temp_filename for NULL ?

Dec 4 2018, 7:52 AM · efl

Nov 21 2018

netstar added a comment to T7469: Find a better name for Efl.Factory.model_connect.

I really think:

Nov 21 2018, 1:16 PM · efl: mvvm, Restricted Project

Nov 17 2018

netstar updated the summary of D7299: efl: fix misspelt focused in API and documents..
Nov 17 2018, 6:30 AM · efl
netstar retitled D7299: efl: fix misspelt focused in API and documents. from elm_code: fix spelling of object members. to efl: fix misspelt focused in API and documents..
Nov 17 2018, 6:29 AM · efl
netstar updated the diff for D7299: efl: fix misspelt focused in API and documents..

Add other misspelt occurrences outside elm_code

Nov 17 2018, 6:29 AM · efl
netstar requested review of D7299: efl: fix misspelt focused in API and documents..
Nov 17 2018, 5:08 AM · efl
netstar closed D7298: elm_code: Allow widget to be focused..
Nov 17 2018, 5:05 AM · efl
netstar requested review of D7298: elm_code: Allow widget to be focused..
Nov 17 2018, 4:59 AM · efl
netstar abandoned D7297: Revert "Elm_Code: check pointer nullity before using it".
Nov 17 2018, 4:53 AM · efl
netstar requested review of D7297: Revert "Elm_Code: check pointer nullity before using it".
Nov 17 2018, 4:51 AM · efl

Nov 7 2018

netstar abandoned D7186: elm_progressbar: set custom unit format if value is 0.0..

Abandon this.

Nov 7 2018, 2:49 AM · efl

Oct 25 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

That's fine, no problem :)

Oct 25 2018, 7:47 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

I'm not sure this is solvable sanely. Or if it needs solving?

Oct 25 2018, 5:53 AM · efl

Oct 24 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

This is called every N seconds. If value is 0.0 the custom string set in unit_format_set doesnt get rendered only "0%"

Oct 24 2018, 4:00 AM · efl

Oct 23 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

Sorry my explanations were a bit lacking.

Oct 23 2018, 5:05 PM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

It's not the first-run case.

Oct 23 2018, 4:54 PM · efl

Oct 22 2018

netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..
if (EINA_DBL_EQ(sd->val, val) &&
    (!EINA_DBL_EQ(sd->val, sd->val_min)) && (!EINA_DBL_EQ(sd->val, sd->val_max))) return;
Oct 22 2018, 11:14 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

As far as I understand the unit format isn't a one-off call. It can be dynamic, as the progress bar itself is.

Oct 22 2018, 10:40 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

This should be backported. I can if it looks okay.

Oct 22 2018, 5:00 AM · efl
netstar added a comment to D7186: elm_progressbar: set custom unit format if value is 0.0..

Before:

Oct 22 2018, 4:59 AM · efl
netstar requested review of D7186: elm_progressbar: set custom unit format if value is 0.0..
Oct 22 2018, 4:55 AM · efl

Oct 17 2018

netstar accepted D7170: build: move ELM_INTERNAL_API_ARGESFSDFEFC into buildsystem.

Looks fine to me.

Oct 17 2018, 6:07 AM · efl

Oct 15 2018

netstar accepted D7159: meson: fix build files size explosion.

Dont have time to test it just now, but it looks okay. I also looked over it briefly yesterday.

Oct 15 2018, 12:13 PM · efl

Oct 11 2018

netstar accepted D7145: meson: support older udev systems.
./configure.ac:  AC_DEFINE_UNQUOTED([OLD_LIBUDEV], [1], [using older version of libudev])
./src/lib/eeze/eeze_udev_syspath.c:#ifndef OLD_LIBUDEV
Oct 11 2018, 4:01 AM · efl
netstar accepted D7130: elementary: shutdown cocoa currently.

This seems good.

Oct 11 2018, 3:58 AM · efl

Oct 10 2018

netstar accepted D7155: meson: do not build deprecated wl & drm.

Seems fine.

Oct 10 2018, 5:37 AM · efl

Oct 9 2018

netstar accepted D7149: meson: add dl to eina.

Looks good.

Oct 9 2018, 1:32 PM · efl

Oct 4 2018

netstar accepted D7143: meson: add sizeof checks for meson.

Looks fine to me. I was present during discussion in IRC also.

Oct 4 2018, 10:24 AM · efl
netstar accepted D7144: meson: unify system properties.

This looks okay. I can't actually test on every environment.

Oct 4 2018, 10:23 AM · efl
netstar closed D7142: eeze: Add buildsystem to list of dependencies..
Oct 4 2018, 4:41 AM · efl
netstar requested review of D7142: eeze: Add buildsystem to list of dependencies..
Oct 4 2018, 4:35 AM · efl
netstar closed D7141: wallpaper: if previous advanced basic apply follows advanced setting..
Oct 4 2018, 3:54 AM · enlightenment-git
netstar requested review of D7141: wallpaper: if previous advanced basic apply follows advanced setting..
Oct 4 2018, 3:21 AM · enlightenment-git

Oct 3 2018

netstar accepted D7132: meson: install compat ethumb_client.pc file.

I've just tested this properly. Works fine. :D

Oct 3 2018, 9:31 AM · efl

Oct 2 2018

netstar closed D7128: macOS: make eina_environment_tmp_get() work as elsewhere..
Oct 2 2018, 7:16 AM · efl
netstar updated the diff for D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Final. Apologies.

Oct 2 2018, 4:25 AM · efl
netstar added a comment to D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Just to show from the console TMPDIR:

Oct 2 2018, 4:24 AM · efl
netstar updated the diff for D7128: macOS: make eina_environment_tmp_get() work as elsewhere..

Dont modify that!

Oct 2 2018, 4:22 AM · efl
netstar requested review of D7128: macOS: make eina_environment_tmp_get() work as elsewhere..
Oct 2 2018, 4:11 AM · efl

Oct 1 2018

netstar accepted D7105: efl_ui_dnd: fixup leaking inits and code duplication.

To me this looks fine. Have built and looked over the code. Probably needs other eyes before a commit though.

Oct 1 2018, 2:16 AM · efl

Sep 28 2018

netstar accepted D7120: eldbus: remove unreachable code..

This looks okay. Maybe needs another reviewer to be sure and commit.

Sep 28 2018, 4:43 AM · efl

Sep 27 2018

netstar added a comment to T7416: Pasting large chunks of text freezes Code Editor..

Can you also confirm or deny whether pasting the same content size in an elm_entry does the same thing?

Sep 27 2018, 4:40 AM · efl: widgets: code
netstar added a comment to T7416: Pasting large chunks of text freezes Code Editor..

Hi, can you attach a file with the content size of a paste which breaks this for you?

Sep 27 2018, 4:39 AM · efl: widgets: code
netstar closed D7101: efreet_menu: remove unused and unreachable code..
Sep 27 2018, 1:14 AM · efl

Sep 25 2018

netstar closed T7398: Evisum doesn't dsplay the state and cpu collumns properly... as Resolved.

I've fixed this in git if you wouldn't mind testing?

Sep 25 2018, 3:42 AM

Sep 24 2018

netstar added a comment to D6965: elm_code: minor refactoring..

Hi Andrew, not sure what you think about this?

Sep 24 2018, 9:43 AM · efl
netstar added a reviewer for D7101: efreet_menu: remove unused and unreachable code.: raster.
Sep 24 2018, 3:27 AM · efl
netstar requested review of D7101: efreet_menu: remove unused and unreachable code..
Sep 24 2018, 3:26 AM · efl
netstar closed D7095: elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text.
Sep 24 2018, 3:19 AM · efl
netstar accepted D7095: elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text.

This is fine.

Sep 24 2018, 3:15 AM · efl

Sep 15 2018

netstar added a comment to T7398: Evisum doesn't dsplay the state and cpu collumns properly....

Thanks for the report. Will look into it.

Sep 15 2018, 8:43 AM