- User Since
- Jan 24 2016, 4:38 PM (186 w, 6 d)
Sat, Jul 27
Jul 11 2019
Jun 23 2019
Jun 22 2019
This diff is already in master. It needed to be changed slightly in order to be backported into EFL 1.22.x.
Jun 9 2019
Jun 8 2019
Essentially when EFL is building and using edje_cc on Linux with the above patch the case is being triggered and exiting???
Okay. So it's breaking on Linux. You mean on Linux it's accessing invalid memory but not being caught by either valgrind and/or crashing?
Whether to error and continue?
Jun 7 2019
Indent again. Note-to-self .vimrc.
Jun 4 2019
This is fixed.
Somebody fixed this. Whoever that was - cheers.
May 31 2019
@bu5hm4n that would be great if you could get a VM running (w/latest release). I don't have much time right now :(
Yes this happens with the default theme.
May 28 2019
May 26 2019
Marcel Feedback array range.
#0 0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755 755 part = pc->parts[et->id]; (gdb) print pc $1 = (Edje_Part_Collection *) 0xa3395ffba00 Current language: auto; currently minimal (gdb) print et->id $2 = 66 (gdb) print part $3 = (Edje_Part *) 0xa33794dae00 (gdb) print et $4 = (Edje_Program_Target *) 0xa333e3afd50 (gdb) bt #0 0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755 #1 0x00000a30d43895bb in check_groups (ef=0xa334abfc080) at bin/edje/edje_cc_out.c:2038 #2 0x00000a30d4388af7 in data_write () at bin/edje/edje_cc_out.c:2862 #3 0x00000a30d438753d in main (argc=2, argv=0x7f7ffffdebf8) at bin/edje/edje_cc.c:452 (gdb) bt #0 0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755 #1 0x00000a30d43895bb in check_groups (ef=0xa334abfc080) at bin/edje/edje_cc_out.c:2038 #2 0x00000a30d4388af7 in data_write () at bin/edje/edje_cc_out.c:2862 #3 0x00000a30d438753d in main (argc=2, argv=0x7f7ffffdebf8) at bin/edje/edje_cc.c:452 (gdb) frame 0 #0 0x00000a30d4392d8a in check_program (pc=0xa3395ffba00, ep=0xa32d44eb200, ef=0xa334abfc080) at bin/edje/edje_cc_out.c:755 755 part = pc->parts[et->id]; (gdb) prnit pc->parts Undefined command: "prnit". Try "help". (gdb) print pc->parts $5 = (Edje_Part **) 0xa3322b2ae00 (gdb) print pc->parts[et->id]; Invalid character ';' in expression. (gdb) print pc->parts[et->id] Cannot access memory at address 0xa3322b2b010
May 25 2019
Mar 3 2019
vtorri who knows.
EFL builds here. It's FreeBSD-12.0. Make sure you remove any package that is including inotify headers because the EFL build will see these headers and assume we can use inotify but we cannot use it on FreeBSD. If you have inotify.h in /usr/local/include or elsewhere, remove it, or the package that is pulling in this bogus header.
Mar 2 2019
FreeBSD doesn't have inotify and if you start building EFL on a desktop machine where you pull in things like GIMP, it'll pull in inotify emulation with an inotify.h header that will break your build.
Feb 28 2019
So libc doesn't have environ symbol.
This isn't fixin anything.
Jan 3 2019
Dont leak netstar!
Check for existence.
Add a comment about the change.
Brain netstar. Use.
Use safer PACKAGE_SYSCONF_DIR over eina_prefix*
Add test for directory existence.
Fix unused variable warning.
Dec 4 2018
Looks okay. Could check temp_filename for NULL ?
Nov 21 2018
I really think:
Nov 17 2018
Add other misspelt occurrences outside elm_code
Nov 7 2018
Oct 25 2018
That's fine, no problem :)
I'm not sure this is solvable sanely. Or if it needs solving?
Oct 24 2018
This is called every N seconds. If value is 0.0 the custom string set in unit_format_set doesnt get rendered only "0%"
Oct 23 2018
Sorry my explanations were a bit lacking.
It's not the first-run case.
Oct 22 2018
if (EINA_DBL_EQ(sd->val, val) && (!EINA_DBL_EQ(sd->val, sd->val_min)) && (!EINA_DBL_EQ(sd->val, sd->val_max))) return;
As far as I understand the unit format isn't a one-off call. It can be dynamic, as the progress bar itself is.
This should be backported. I can if it looks okay.
Oct 17 2018
Looks fine to me.
Oct 15 2018
Dont have time to test it just now, but it looks okay. I also looked over it briefly yesterday.
Oct 11 2018
./configure.ac: AC_DEFINE_UNQUOTED([OLD_LIBUDEV], , [using older version of libudev]) ./src/lib/eeze/eeze_udev_syspath.c:#ifndef OLD_LIBUDEV
This seems good.
Oct 10 2018
Oct 9 2018
Oct 4 2018
Looks fine to me. I was present during discussion in IRC also.
This looks okay. I can't actually test on every environment.
Oct 3 2018
I've just tested this properly. Works fine. :D
Oct 2 2018
Just to show from the console TMPDIR:
Dont modify that!
Oct 1 2018
To me this looks fine. Have built and looked over the code. Probably needs other eyes before a commit though.
Sep 28 2018
This looks okay. Maybe needs another reviewer to be sure and commit.
Sep 27 2018
Can you also confirm or deny whether pasting the same content size in an elm_entry does the same thing?
Hi, can you attach a file with the content size of a paste which breaks this for you?
Sep 25 2018
I've fixed this in git if you wouldn't mind testing?
Sep 24 2018
Hi Andrew, not sure what you think about this?
This is fine.
Sep 15 2018
Thanks for the report. Will look into it.