Page MenuHomePhabricator

ohduna (Duna Oh)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 24 2014, 6:05 PM (322 w, 1 d)
Availability
Available

Recent Activity

Feb 5 2017

ohduna added a comment to T5094: e + touchscreen - actually tried it before?.

@devilhorns - Thank you for letting me know. :)
If those patches are ready to share in dev branch (not master branch), I am happy to run tests in enlightenment.

Feb 5 2017, 8:43 PM · enlightenment-git, Restricted Project

Jan 26 2017

ohduna added a comment to T5094: e + touchscreen - actually tried it before?.

This task is about identification of event source device. I had a interest in this issue and tried to contribute. (refer to.. https://phab.enlightenment.org/D3860)
IMHO, we should fill 'dev' variable in events(Ecore_Event_XXX/Evas_Event_XXX) in drm backend, similar to wayland backend. Then, enlightenment could distinguish source devices from events and deal with that.
Do you agree on this? Shall I try this issue? Please let me know you guys ideas.
Thanks

Jan 26 2017, 12:42 AM · enlightenment-git, Restricted Project

Jan 25 2017

ohduna updated subscribers of T5094: e + touchscreen - actually tried it before?.
Jan 25 2017, 8:17 PM · enlightenment-git, Restricted Project

Oct 24 2016

ohduna added a comment to D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

Glad to hear from you. I'll revise this patch and update soon.
Thanks,

Oct 24 2016, 3:21 PM · enlightenment-git

Sep 18 2016

ohduna added a comment to D4194: elput: add/remove Ecore_Device and set dev value in Ecore_Events.

ping?

Sep 18 2016, 5:21 PM

Jul 29 2016

ohduna added a comment to D4194: elput: add/remove Ecore_Device and set dev value in Ecore_Events.

Please refer all kind comments at https://phab.enlightenment.org/D4179.

Jul 29 2016, 3:06 AM

Jul 27 2016

ohduna abandoned D4179: elput: add/remove/get Ecore_Device.

Thanks for all your comments.

Jul 27 2016, 7:36 PM
ohduna retitled D4194: elput: add/remove Ecore_Device and set dev value in Ecore_Events from to elput: add/remove Ecore_Device and set dev value in Ecore_Events.
Jul 27 2016, 7:33 PM
ohduna updated the diff for D4179: elput: add/remove/get Ecore_Device.

I had trouble with cute arcanist.. :(

Jul 27 2016, 1:47 AM
ohduna updated the diff for D4179: elput: add/remove/get Ecore_Device.

rebased again.. sorry..

Jul 27 2016, 1:08 AM
ohduna updated the diff for D4179: elput: add/remove/get Ecore_Device.

revised and rebased.
Thanks,

Jul 27 2016, 12:47 AM

Jul 21 2016

ohduna added a comment to D4179: elput: add/remove/get Ecore_Device.

Dear ManMower,

Jul 21 2016, 7:38 PM
ohduna added inline comments to D4179: elput: add/remove/get Ecore_Device.
Jul 21 2016, 5:56 PM
ohduna updated the diff for D4179: elput: add/remove/get Ecore_Device.

I revised according to devilhorns comment.
Thanks,

Jul 21 2016, 5:56 PM

Jul 20 2016

ohduna retitled D4179: elput: add/remove/get Ecore_Device from to elput: add/remove/get Ecore_Device.
Jul 20 2016, 10:37 PM

Jun 7 2016

ohduna added a comment to D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

Dear jpeg,
Good to hear that. I knew you have been working on EO-ifying devices and events. I will check out Efl.Input.Device first.
Thanks~

Jun 7 2016, 1:15 AM

May 3 2016

ohduna added a comment to D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

Hi,
It's been a month since I made this patch.
I just wonder if this patch needs to be rebased or changed or abandoned.
Or... would you recommend to split this patch into several patches(ecore_device/ecore_drm/ecore_input_evas)?
Thanks for your comments in advance. :)

May 3 2016, 1:18 AM
ohduna updated the diff for D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.

Thanks, ManMower.
I examined weston-simple-touch client as the way that you mentioned.
Mouse_Binding should work with mouse devices, not touch devices.
So I added check for mouse device when converting mouse event to e_binding_event_mouse_XXX.

May 3 2016, 1:00 AM · enlightenment-git

Apr 19 2016

ohduna added a comment to D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.

rebased this patch.

Apr 19 2016, 11:48 PM · enlightenment-git
ohduna updated the diff for D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.

add comments explaining why sending wl_touch events with "zero id"

Apr 19 2016, 11:46 PM · enlightenment-git
ohduna added a comment to D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.

Sorry for replying late, Derek.
As you can see, my implementation is very simple.
If event source of Evas_Event_Mouse_XXX is a touch device, we send down/up/motion events using wl_touch, not wl_pointer.

Apr 19 2016, 10:07 PM · enlightenment-git
ohduna added a comment to D3906: Ecore: Use calloc() to initialize Ecore_Event_Mouse_XXXX.

The same job about Ecore_Event_Key is already done.
https://git.enlightenment.org/core/efl.git/commit/?id=0ef41604e88b8a8224818824217ebc09c93789d5
Now, we ensure that all fields in Ecore_Event_XXX(Mouse/Key) will be properly initialized.

Apr 19 2016, 7:45 PM
ohduna retitled D3906: Ecore: Use calloc() to initialize Ecore_Event_Mouse_XXXX from to Ecore: Use calloc() to initialize Ecore_Event_Mouse_XXXX.
Apr 19 2016, 7:37 PM

Apr 6 2016

ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

need to include <Ecore.h> in Ecore_Input.h

Apr 6 2016, 2:58 AM

Apr 5 2016

ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

I think this patch are completely updated.
Please let me know your opinion of this commit.

Apr 5 2016, 9:51 PM
ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

restore previous diff I lost when rebasing..

Apr 5 2016, 9:40 PM
ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

rebase on top of upstream

Apr 5 2016, 7:46 PM
ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

revised according to zmike's comments.
I greatly appreciate your comments that helped improve this patch.

Apr 5 2016, 7:32 PM
ohduna added inline comments to D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.
Apr 5 2016, 6:31 PM

Apr 4 2016

ohduna added inline comments to D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.
Apr 4 2016, 10:51 PM · enlightenment-git
ohduna updated the diff for D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.

revised according to zmike's comment.
Thanks.

Apr 4 2016, 10:50 PM · enlightenment-git

Apr 3 2016

ohduna added reviewers for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events: zmike, devilhorns, ManMower.
Apr 3 2016, 8:44 PM
ohduna retitled D3860: e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX from to e_comp_wl: handle Evas_Device in Evas_Event_Mouse_XXX.
Apr 3 2016, 8:03 PM · enlightenment-git
ohduna updated the diff for D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events.

Ecore_Device is the Ecore-level Device infomation similar to Evas_Device.
Both are used for identification of source device where the event came from.
Ecore_Device has the string member named identifier which should be unique
distingusing input devices.
For now, the sys name of device provided by udes is used. ex)/dev/input/event2

Apr 3 2016, 7:13 PM

Apr 1 2016

ohduna retitled D3858: Ecore: introduce Ecore_Device and apply to Ecore_Events from to Ecore: introduce Ecore_Device and apply to Ecore_Events.
Apr 1 2016, 4:08 AM

Feb 14 2016

ohduna retitled D3678: ecore-drm: return FALSE in all case, not only when rotation property is successfully set. from to ecore-drm: return FALSE in all case, not only when rotation property is successfully set..
Feb 14 2016, 5:32 PM

Feb 2 2016

ohduna added a comment to D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.
In D3480#58744, @zmike wrote:

Hi, sorry to show up so late to this one.

Wouldn't it be better to handle this sort of thing client side? The client may be in a state where it really makes sense to leave a mouse cursor on screen (like, say, when a menu is visible).

With EFL apps the compositor doesn't know when a menu is popped up, so it would just hide the cursor anyway. And that's just the first example that came to mind, I'm guessing there could be other times when the client knows better than the compositor whether a cursor should be visible or not.

Hm that's an interesting thought. Under X11, applications such as mplayer handle this sort of thing internally. Perhaps it would be better to implement this in efl by sending a blank cursor in set_cursor ?

Feb 2 2016, 7:52 PM · enlightenment-git

Jan 27 2016

ohduna added a comment to D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.
Jan 27 2016, 5:30 PM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

ignored po files.. Please review this patch, again. :)

Jan 27 2016, 5:26 PM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

modified code in _e_comp_wl_cursor_reload()

Jan 27 2016, 2:59 AM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

Forget about po files.. my mistakes..

Jan 27 2016, 2:45 AM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

Restore po files.. ;)

Jan 27 2016, 2:15 AM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

Removed po files

Jan 27 2016, 1:59 AM · enlightenment-git
ohduna updated the diff for D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval.

I revised according to zmike comments. Please review again. :)
Thanks,

Jan 27 2016, 1:15 AM · enlightenment-git

Jan 13 2016

ohduna retitled D3566: ecore_wayland: move check for pointer capability into wl_input_cursor_from_name_set() from to ecore_wayland: move check for pointer capability into wl_input_cursor_from_name_set().
Jan 13 2016, 10:25 PM
ohduna added a comment to D3545: ecore_wayland: set touch_focus window when gets pointer_enter.

Thanks, ManMower.
I created new revision according your comment.
Please refer to https://phab.enlightenment.org/D3555

Jan 13 2016, 1:00 AM

Jan 11 2016

ohduna retitled D3555: ecore_wayland: send mouse_move when sets touch_focus window in cb_touch_down from to ecore_wayland: send mouse_move when sets touch_focus window in cb_touch_down.
Jan 11 2016, 12:47 AM

Jan 7 2016

ohduna retitled D3545: ecore_wayland: set touch_focus window when gets pointer_enter from to ecore_wayland: set touch_focus window when gets pointer_enter.
Jan 7 2016, 1:01 AM

Dec 22 2015

ohduna retitled D3480: add config for enabling cursor_timer which hides the mouse cursor after some interval from to add config for enabling cursor_timer which hides the mouse cursor after some interval.
Dec 22 2015, 12:18 AM · enlightenment-git

Dec 14 2015

ohduna added a reviewer for D3428: ecore-drm: Fix failure of setting/closing evdev->fd which causes fd leak: ManMower.
Dec 14 2015, 4:09 PM

Dec 10 2015

ohduna updated the diff for D3428: ecore-drm: Fix failure of setting/closing evdev->fd which causes fd leak.

Updated again. :)

Dec 10 2015, 5:00 PM
ohduna updated the diff for D3428: ecore-drm: Fix failure of setting/closing evdev->fd which causes fd leak.

I revised according to devilhorns comment. Please review again. :)

Dec 10 2015, 3:52 PM
ohduna retitled D3428: ecore-drm: Fix failure of setting/closing evdev->fd which causes fd leak from to ecore-drm: Fix failure of setting/closing evdev->fd which causes fd leak.
Dec 10 2015, 1:14 AM