Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (301 w, 3 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Yesterday

q66 accepted D7712: eolian: error out when owned type does not have a free function.
Mon, Jan 21, 12:38 PM · efl

Sat, Jan 19

q66 added a comment to T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.

The thing in charge of freeing the structure is in charge of freeing its owned fields. If they're not marked owned, it is assumed that the struct does not own them and they will be freed somewhere else. I wonder if this behavior is what we want though. Maybe we should make them owned by default, and reverse the behavior so that you explicitly have to mark the field *not* owned in order to prevent it from being freed as a part of the structure?

Sat, Jan 19, 8:03 AM · Restricted Project

Fri, Jan 18

q66 added a comment to T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.

Yes, we allow that. It means the struct owns the reference. If the field is not @owned, it will not be freed when freeing the structure. It is separate from owning on params; if the param is not owned, it means the caller will free it, if it is, it means the callee will free it. Either way, @owned fields will be freed by one of them.

Fri, Jan 18, 8:34 AM · Restricted Project
q66 accepted D7688: eolian: remove the old inheritance syntax.
Fri, Jan 18, 7:30 AM · efl
q66 requested changes to D7688: eolian: remove the old inheritance syntax.

you forgot an else

Fri, Jan 18, 7:25 AM · efl
q66 accepted D7687: efl: convert all interfaces to the new eolian syntax.
Fri, Jan 18, 7:22 AM · efl
q66 accepted D7686: efl: convert all abstracts to the new eolian syntax.
Fri, Jan 18, 7:22 AM · efl
q66 accepted D7685: efl: convert all mixins to new eolian syntax.
Fri, Jan 18, 7:22 AM · efl
q66 accepted D7684: efl: convert all classes to the new eolian syntax.
Fri, Jan 18, 7:21 AM · efl

Thu, Jan 17

q66 accepted D7680: eolian: make error messages usable.
Thu, Jan 17, 11:06 AM · efl
q66 closed T7632: eolian should only allow pure_virtual on abstract classes as Resolved.
Thu, Jan 17, 8:20 AM · efl (efl-1.22), Restricted Project
q66 added a comment to T7632: eolian should only allow pure_virtual on abstract classes.

Fixed in 18ab4f2eec444bbef11605bd0e2ba057709cbb7e.

Thu, Jan 17, 8:20 AM · efl (efl-1.22), Restricted Project
q66 abandoned D7673: eolian: ensure regular class cannot have a pure_virtual property/method.
Thu, Jan 17, 8:19 AM · efl
q66 commandeered D7673: eolian: ensure regular class cannot have a pure_virtual property/method.
Thu, Jan 17, 8:19 AM · efl
q66 closed D7672: elementary: make elm.web abstract.
Thu, Jan 17, 8:18 AM · efl
q66 added a commit to T7632: eolian should only allow pure_virtual on abstract classes: rEFL0a95767a0c95: efl_net: make efl.net.server.fd abstract.
Thu, Jan 17, 8:18 AM · efl (efl-1.22), Restricted Project
q66 added a commit to T7632: eolian should only allow pure_virtual on abstract classes: rEFLba065f9eed25: evas: make classes abstract.
Thu, Jan 17, 8:18 AM · efl (efl-1.22), Restricted Project
q66 closed D7670: efl_net: make efl.net.server.fd abstract.
Thu, Jan 17, 8:18 AM · efl
q66 closed D7671: evas: make classes abstract.
Thu, Jan 17, 8:18 AM · efl
q66 added a commit to T7632: eolian should only allow pure_virtual on abstract classes: rEFL48b43928bbbe: ecore_audio: remove pure virtual functions from classes.
Thu, Jan 17, 8:18 AM · efl (efl-1.22), Restricted Project
q66 closed D7669: ecore_audio: remove pure virtual functions from classes.
Thu, Jan 17, 8:18 AM · efl
q66 requested changes to D7673: eolian: ensure regular class cannot have a pure_virtual property/method.

actually, i found a better way for this, so please abandon the rev

Thu, Jan 17, 8:10 AM · efl
q66 added a comment to T7240: Not allow multi class inheritance in eo.

Landed the Eolian-side enforcement in 1b7129cea0d90f76a21bd6b4e40d1528141e087f.

Thu, Jan 17, 7:23 AM · efl: language bindings, Restricted Project
q66 accepted D7673: eolian: ensure regular class cannot have a pure_virtual property/method.
Thu, Jan 17, 7:18 AM · efl

Wed, Jan 16

q66 added a comment to T7632: eolian should only allow pure_virtual on abstract classes.

I did however disable explicit usage of it in interfaces in 90f604327586eb8fb3f0c9e7b83816573bea820d.

Wed, Jan 16, 11:38 AM · efl (efl-1.22), Restricted Project
q66 added a comment to T7632: eolian should only allow pure_virtual on abstract classes.

I added a check to help with this in eb830d8e46ce5aae656bc7d93a4d01bac0a82e5d. Methods/properties are implicitly pure_virtual in interfaces, so the ticket is a bit misleading, and it's currently also allowed (and used) in mixins. However, pure virtual methods are treated as unimplemented by 211064113104702b2c6bd279e9e8a04ee0e8254a, so any potential cases are caught by that.

Wed, Jan 16, 11:33 AM · efl (efl-1.22), Restricted Project
q66 accepted D7630: eolian_gen: void out keys depending on how they are setted.
Wed, Jan 16, 5:34 AM · efl
q66 accepted D7629: eolian: add free functions for the array and future..
Wed, Jan 16, 5:31 AM · efl
q66 accepted D7628: eolian: there is no eina_inlist_free.
Wed, Jan 16, 5:31 AM · efl

Thu, Jan 10

q66 accepted D7584: eolian: introduce the keyword required.

👍

Thu, Jan 10, 8:03 AM · efl
q66 requested changes to D7584: eolian: introduce the keyword required.

Besides that one thing, looks good to me, I think.

Thu, Jan 10, 7:48 AM · efl
q66 added a comment to D7564: meson: add a option for selecting lua interpreter.

Yes, have those two values for now, and if "lua" is selected, disable elua entirely. I will update it as necessary when luajit is removed.

Thu, Jan 10, 4:35 AM · efl
q66 added a comment to D7564: meson: add a option for selecting lua interpreter.

my proposal involves keeping support for *only* 5.3, so a build option will be unnecessary

Thu, Jan 10, 2:43 AM · efl

Wed, Jan 9

q66 added a comment to D7564: meson: add a option for selecting lua interpreter.

Also, it's not true that 5.1 is API/ABI compatible with luajit; it only applies the other way around, i.e. luajit is a superset of 5.1 functionality. While elua itself might compile with 5.1 (because it doesn't really use any C API calls beyond what 5.1 provides), it will be effectively useless because all the elua scripts rely on runtime luajit functionality (primarily the FFI)

Wed, Jan 9, 6:44 PM · efl
q66 requested changes to D7564: meson: add a option for selecting lua interpreter.

elua only supports luajit.

Wed, Jan 9, 6:40 PM · efl

Dec 20 2018

q66 closed D7478: tests: eolian_cxx: ensure property_holder.eo file lands in dist.
Dec 20 2018, 2:50 AM · efl
q66 accepted D7478: tests: eolian_cxx: ensure property_holder.eo file lands in dist.
Dec 20 2018, 2:46 AM · efl
q66 closed D7477: build: ensure we have a data_aux direcroy in our dist for the test eo files.
Dec 20 2018, 2:45 AM · efl
q66 accepted D7477: build: ensure we have a data_aux direcroy in our dist for the test eo files.
Dec 20 2018, 2:44 AM · efl

Dec 6 2018

q66 added a comment to T6128: Generate C# reference API documentation.

Well, since it covers all the C# docs, I'll just go ahead and remove it from our own generator for the time being. The current C# code is pretty much copy-paste-parts-of-the-generator-into-separate-file-and-modify and it's kind of a pain to do changes in it as i make them in the rest of the generator, so if we want C# support later in it, might as well just write it from scratch.

Dec 6 2018, 5:12 AM · efl: language bindings, efl: docs
q66 closed T7495: eolian build issue as Resolved by committing rEFL36a5b5bf1361: canvas: disable an eolian-style api reference.
Dec 6 2018, 2:45 AM · Restricted Project, efl (efl-1.22)
q66 updated subscribers of T7495: eolian build issue.
Dec 6 2018, 2:38 AM · Restricted Project, efl (efl-1.22)
q66 updated subscribers of T7495: eolian build issue.
Dec 6 2018, 2:38 AM · Restricted Project, efl (efl-1.22)
q66 claimed T7495: eolian build issue.

The API reference is correct. The problem is that the .eo file it's referencing is not being installed, which means it works in-tree but not when in the system...

Dec 6 2018, 2:37 AM · Restricted Project, efl (efl-1.22)

Dec 5 2018

q66 added a comment to T6128: Generate C# reference API documentation.

Does this mean we will not need C# support inside the eo doc generator?

Dec 5 2018, 11:54 AM · efl: language bindings, efl: docs

Dec 3 2018

q66 added a comment to T7477: Clarify how the "constructor" section in eo files is to be used.

@segfaultxavi as for tagging methods directly, well, eolian by design doesn't specifically enforce ordering of methods in their block, especially since generators typically work with Eolian_Implementation rather than Eolian_Function list directly; in a constructors section, we'd typically want the order of the fields to be strict, I'd assume.

Dec 3 2018, 3:11 PM · Restricted Project

Nov 30 2018

q66 moved T7477: Clarify how the "constructor" section in eo files is to be used from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 30 2018, 7:06 AM · Restricted Project
q66 closed T7452: eolian: check duplicate inheritance in the library as Wontfix.

this is not possible to do efficiently in the eolian library (would require revalidating classes multiple times, as well as keep a fresh hash table for each validation layer and that would likely add quite a bit of time)

Nov 30 2018, 7:05 AM · Restricted Project
q66 added a comment to T7240: Not allow multi class inheritance in eo.

That has for now optionally been done in T7365, once all the definitions are fixed, we can enable it unconditionally...

Nov 30 2018, 5:20 AM · efl: language bindings, Restricted Project
q66 closed T7365: eolian: Warn if a regular class appears anywhere other than the first place in an inheritance list as Resolved by committing rEFL454e9eb1d9f4: eolian: add optional warning for regular classes in ext list.
Nov 30 2018, 5:15 AM · Restricted Project, efl

Nov 29 2018

q66 closed T6577: Eolian documentation fallback as Resolved.

added in be7d76ece63844f1967ee12d042c920a8540ab4a

Nov 29 2018, 5:00 AM · efl: docs, efl: language bindings, Restricted Project
q66 abandoned D7245: eolian_aux: add initial eolian_aux APIs.
Nov 29 2018, 4:59 AM · efl

Nov 28 2018

q66 closed T7482: eo docs: Remove Doxygen tags from efl*.eo files as Resolved by committing rEFL05682eed7d57: eo-docs: Remove Doxygen tags from efl*.eo files.
Nov 28 2018, 4:34 AM · efl
q66 closed T7482: eo docs: Remove Doxygen tags from efl*.eo files, a subtask of T7453: C# bindings: Convert Eo comment format into proper XML comment format, as Resolved.
Nov 28 2018, 4:34 AM · efl: language bindings
q66 closed D7372: eo-docs: Remove Doxygen tags from efl*.eo files.
Nov 28 2018, 4:34 AM · efl
q66 accepted D7372: eo-docs: Remove Doxygen tags from efl*.eo files.
Nov 28 2018, 4:33 AM · efl

Nov 27 2018

q66 closed D7371: pyolian: Fix tests after class renames and API change.
Nov 27 2018, 1:26 PM · efl
q66 accepted D7371: pyolian: Fix tests after class renames and API change.
Nov 27 2018, 1:24 PM · efl
q66 requested changes to D7372: eo-docs: Remove Doxygen tags from efl*.eo files.

eolian in fact does have a way to do notes, just start the paragraph with "Note:", so like you did, but different case

Nov 27 2018, 8:22 AM · efl

Nov 23 2018

q66 added a comment to T7240: Not allow multi class inheritance in eo.

Initial work has been merged on T7459. I believe once that is done, we can restrict things in Eolian so that only interfaces/mixins are allowed in the "implements Foo, Bar" list, but that will need some .eo file refactoring...

Nov 23 2018, 5:08 AM · efl: language bindings, Restricted Project
q66 added a comment to T7459: eolian: new syntax for inheritance.

Initial work done in c8e0a1d2e2eaa5b8369eeb34a38b3b343788703f.
API updated in 14ce54c30321e3b78b979872427b07d9420d5c66.

Nov 23 2018, 5:05 AM · Restricted Project

Nov 21 2018

q66 added a comment to T7454: eolian: warn if event appears in more than one inherited class.

A fix for this issue has been introduced in 9535eff025d7be0810e07917ea642b44104995d5. However, it cannot be enabled just yet, since we have those conflicts (like resize) in the tree so those must be fixed first...

Nov 21 2018, 7:30 AM · Restricted Project, efl
q66 closed T5994: Missing Enum types documents in API references as Resolved.

this has been solved with the recent grouping changes, therefore closing

Nov 21 2018, 6:53 AM · efl: docs, efl: language bindings, Restricted Project

Nov 16 2018

q66 added a comment to T7462: eolian: add information to .eot/.eo files about what library module to link/load.

so that third party bindings can make use of it, obviously

Nov 16 2018, 3:49 AM · Restricted Project
q66 added a comment to T7462: eolian: add information to .eot/.eo files about what library module to link/load.

yep - and we need a standard way which is not a bash script

Nov 16 2018, 2:48 AM · Restricted Project

Nov 15 2018

q66 added a comment to T6840: Generate event wrapper for C.

welcome back @cedric o/

Nov 15 2018, 11:58 AM · efl: language bindings, Restricted Project, Restricted Project
q66 abandoned D7261: eolian: use 'free' for owned mstring but not string.
Nov 15 2018, 3:17 AM · efl

Nov 14 2018

q66 moved T7180: Make eolian_gen warn about missing documentation from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:30 AM · Restricted Project, efl: docs, Restricted Project
q66 moved T7463: eolian: separate modern and legacy APIs from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:25 AM · Restricted Project
q66 triaged T7463: eolian: separate modern and legacy APIs as TODO priority.
Nov 14 2018, 5:25 AM · Restricted Project
q66 moved T6577: Eolian documentation fallback from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:23 AM · efl: docs, efl: language bindings, Restricted Project
q66 raised the priority of T6577: Eolian documentation fallback from TODO to High.

eolian_aux which is currently under review (D7245) provides this.

Nov 14 2018, 5:23 AM · efl: docs, efl: language bindings, Restricted Project
q66 moved T6890: Eolian error integration from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:22 AM · efl: language bindings, Restricted Project
q66 moved T7454: eolian: warn if event appears in more than one inherited class from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:22 AM · Restricted Project, efl
q66 moved T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:21 AM · efl: language bindings, Restricted Project
q66 moved T7462: eolian: add information to .eot/.eo files about what library module to link/load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:21 AM · Restricted Project
q66 created T7462: eolian: add information to .eot/.eo files about what library module to link/load.
Nov 14 2018, 5:21 AM · Restricted Project
q66 moved T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:15 AM · Restricted Project
q66 created T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.
Nov 14 2018, 5:15 AM · Restricted Project
q66 moved T7460: eolian: remove ptr() from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:13 AM · Restricted Project
q66 created T7460: eolian: remove ptr().
Nov 14 2018, 5:13 AM · Restricted Project
q66 moved T7459: eolian: new syntax for inheritance from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:09 AM · Restricted Project
q66 created T7459: eolian: new syntax for inheritance.
Nov 14 2018, 5:09 AM · Restricted Project
q66 moved T7452: eolian: check duplicate inheritance in the library from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:04 AM · Restricted Project
q66 moved T7365: eolian: Warn if a regular class appears anywhere other than the first place in an inheritance list from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:03 AM · Restricted Project, efl
q66 moved T7240: Not allow multi class inheritance in eo from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Nov 14 2018, 5:03 AM · efl: language bindings, Restricted Project

Nov 12 2018

q66 requested review of D7261: eolian: use 'free' for owned mstring but not string.
Nov 12 2018, 6:26 AM · efl

Nov 8 2018

q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Not what I am getting

Nov 8 2018, 11:49 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Also, I believe you are wrong:

Nov 8 2018, 11:41 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

IS that so? That is interesting, because a potential change of implementation (i.e. potentially behavior of Eolian itself) should trigger re-generation of eo.* files (in order to account for the new behavior), and changed headers should rebuild the rest of it. At least that's how I see it, if Meson does not do it, we potentially have another problem at hand...

Nov 8 2018, 11:33 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Honestly, I think we should drop autotools as soon as possible.

Nov 8 2018, 10:46 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

why not? i don't see any particular disadvantage to it, and at least it allows addition of new APIs and being able to run tests on them without triggering a full EFL rebuild every time (as eolian_gen itself is most likely not going to depend on it)

Nov 8 2018, 3:00 AM · efl

Nov 7 2018

q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

I had plans for more, but I wasn't able to abstract these APIs well enough to make it into a reusable piece that makes sense. So for now there's these (they will help shorten the docgen) and more will be added gradually as I figure them out (but I won't actually focus on the library anymore once it's merged, just add new APIs as they make sense)

Nov 7 2018, 8:55 AM · efl
q66 requested review of D7245: eolian_aux: add initial eolian_aux APIs.
Nov 7 2018, 8:54 AM · efl

Nov 6 2018

q66 triaged T7452: eolian: check duplicate inheritance in the library as Normal priority.
Nov 6 2018, 4:06 AM · Restricted Project

Nov 2 2018

q66 added a comment to T6128: Generate C# reference API documentation.

Perfect. We can synchronize efforts later then.

Nov 2 2018, 7:20 AM · efl: language bindings, efl: docs

Nov 1 2018

q66 added a comment to T6128: Generate C# reference API documentation.

I took a break from that to work on meson, eolian_aux (which will be used to move some of the core from the docgen) and some other things, but the code is all in my personal dev repo... I will try to get a proper repository set up early next week or maybe even during this weekend. If somebody wants to help with working on the doc generator or even provide feedback on the generated output, go ahead, it would be much appreciated.

Nov 1 2018, 4:06 AM · efl: language bindings, efl: docs

Oct 30 2018

q66 closed T7399: eolian: Add @ctor_param hint to constructors section as Resolved.
Oct 30 2018, 6:49 PM · efl: language bindings
q66 closed D7221: eolian: Add @ctor_param parameter to constructors.
Oct 30 2018, 6:49 PM · efl
q66 accepted D7221: eolian: Add @ctor_param parameter to constructors.
Oct 30 2018, 6:47 PM · efl