q66 (Daniel Kolesa)
EFL Developer

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (253 w, 3 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Wed, Feb 14

q66 added a comment to T6704: add ability to print statistics for eo files.

I think this would be a good fit for a Lua script.

Wed, Feb 14, 11:46 AM · Restricted Project
q66 added a comment to T6703: Enable Smart screen border to window resize..

yeah, a wizard option is a good idea

Wed, Feb 14, 10:50 AM · enlightenment-git
q66 added a comment to T6703: Enable Smart screen border to window resize..

IMO it'd be best to actually remove those because most people I've seen use E were annoyed by those and removed them immediately; the maximizing behavior would be much more useful and expected for most.

Wed, Feb 14, 7:12 AM · enlightenment-git

Tue, Feb 13

q66 closed T6670: elua build issue (libeina.so) as Resolved.

I applied your patch.

Tue, Feb 13, 8:56 AM · efl
q66 added a commit to T6670: elua build issue (libeina.so): rEFLb7405b561651: elua: add eina in environment variable library path.
Tue, Feb 13, 8:55 AM · efl
q66 added a comment to T6700: eolian build rules do not regenerate based on dependencies.

yeah, I don't think we can fix this with autotools. Maybe meson would help though, @bu5hm4n any ideas?

Tue, Feb 13, 12:48 AM · Restricted Project

Dec 18 2017

q66 closed T6523: eolian_gen: SEGV as Resolved by committing rEFL03e77ea36111: eolian: fix use-after-free in eo_parser.
Dec 18 2017, 3:21 PM · efl

Dec 7 2017

q66 triaged T6486: Eolian: enum with keyword legacy as Normal priority.
Dec 7 2017, 4:27 AM
q66 added a comment to T6486: Eolian: enum with keyword legacy.

yeah, you're probably right; the current legacy field was never even meant to be a proper feature, more like a temporary hack to get enums for legacy APIs to behave as we want them to...

Dec 7 2017, 4:27 AM

Dec 6 2017

q66 closed D5611: eolian_cxx: Fix unit initialization.
Dec 6 2017, 8:43 AM
q66 accepted D5611: eolian_cxx: Fix unit initialization.

thanks

Dec 6 2017, 8:34 AM

Nov 2 2017

q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

I'd unlink it from T5826 but leave it open...

Nov 2 2017, 3:52 AM · efl

Nov 1 2017

q66 closed T5306: Add a efl_part information to .eo files as Resolved.

i guess i'll just close this since part information is already done since a few days ago...

Nov 1 2017, 5:13 AM · Restricted Project, efl
q66 closed T5306: Add a efl_part information to .eo files , a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Nov 1 2017, 5:13 AM · Restricted Project, efl
q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

Since I won't have time for the proper solution in near future (because of other work elsewhere) I'll let @ajwillia.ms proceed with his workaround for the time being. A real solution will be implemented later as time allows, but not bound by this project.

Nov 1 2017, 3:57 AM · efl

Oct 30 2017

q66 updated subscribers of T6283: Build break with nodejs binding.
Oct 30 2017, 9:41 AM · efl
q66 triaged T6283: Build break with nodejs binding as Normal priority.
Oct 30 2017, 9:39 AM · efl
q66 reassigned T6283: Build break with nodejs binding from q66 to felipealmeida.

This should be fixed by the maintainer.

Oct 30 2017, 9:39 AM · efl

Oct 27 2017

q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

We'll definitely need this, but I'm not sure whether processing some sort of XML from Doxygen is the best way to go at it... since this is just C we're dealing with, it's fairly simple as far as the language in headers goes; perhaps we could parse it manually (it shouldn't really be a big deal) which would allow for simpler integration into dokuwiki (doxygen carries a lot of clutter we'd have to strip off into the result). But I will need to investigate this to be able to tell for sure.

Oct 27 2017, 1:44 PM · efl

Oct 24 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

i expect to have it done by tomorrow evening...

Oct 24 2017, 8:50 AM · Restricted Project, efl

Oct 23 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

alright, let's get it in during this week

Oct 23 2017, 2:28 AM · Restricted Project, efl

Oct 17 2017

q66 edited the content of Documentation System.
Oct 17 2017, 3:02 AM
q66 edited the content of Documentation System.
Oct 17 2017, 3:00 AM
q66 edited the content of Documentation System.
Oct 17 2017, 1:44 AM

Oct 13 2017

q66 closed D5306: Passed by value have no meaning in set function..

Yeah, the test was wrong and so was the generator...

Oct 13 2017, 2:51 PM
q66 closed T6186: Reqeuest: Document on first parameter "obj" in eolian gen as Resolved by committing rEFL5699466dbabc: eolian gen: generate documentation for first object param if present.
Oct 13 2017, 6:18 AM
q66 added a comment to T6204: format function cb overhaul .

just FYI, keep in mind that if you "pass" the defined function as an argument in Eolian, it will actually generate *three* arguments in C; data, the actual funcptr, and a "free" funcptr (Eina_Free_Cb) - this is necessary to track lifetimes.

Oct 13 2017, 5:13 AM · Restricted Project, efl

Oct 11 2017

q66 raised the priority of T6186: Reqeuest: Document on first parameter "obj" in eolian gen from Wishlist to Trivial.
Oct 11 2017, 5:17 AM
q66 added a comment to T6186: Reqeuest: Document on first parameter "obj" in eolian gen.

you're right, that should be fixed.

Oct 11 2017, 3:14 AM

Sep 8 2017

q66 added a comment to T5994: Missing Enum types documents in API references.

yeah, the generation for this should probably be changed; it's just a tad difficult because there is no real indication of what the group should be... OTOH, this issue should not be very relevant anymore, because the old Doxygen documentation is getting deprecated anyway...

Sep 8 2017, 3:24 AM · Restricted Project

Aug 30 2017

q66 added a comment to T2728: fix compilation with Lua 5.2+.

I implemented a fix for the bytecode confusion in 67d1c0e51c01ba159f88adc6446cc31cee79c808 so similar cases should not happen again.

Aug 30 2017, 11:23 AM · efl
q66 added a comment to T5583: [Experiment] Function pointers in EO.

Done in 4a16e1d86253ce336464f26ee9244f25511cb8bb

Aug 30 2017, 7:05 AM · efl

Aug 28 2017

q66 added a comment to T5583: [Experiment] Function pointers in EO.

this is what happens when people push into eolian without letting me review first... i didn't feel like calling out the responsible person at first because it was a change that needed doing anyway but i guess i will have to:

Aug 28 2017, 8:34 AM · efl

Aug 18 2017

q66 added a comment to T2728: fix compilation with Lua 5.2+.

The right way really is to remove the bytecode if it fails loading and try loading the source file... so I guess I will do just that

Aug 18 2017, 8:57 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

looks like leftover cached bytecode made with previous version of luajit...

Aug 18 2017, 8:34 AM · efl

Aug 10 2017

q66 closed T5024: eolian should correctly handle return of properties with values const(Struct) as Resolved by committing rEFL706de57b9fa4: eolian: implement proper return type serialization.
Aug 10 2017, 3:48 AM · efl, Restricted Project

Aug 3 2017

q66 added a comment to T5832: Review and improve EFL references API documentation.

we should also figure out how to integrate the doxygen docs and the dokuwiki, because having two separate systems is just bad...

Aug 3 2017, 6:05 PM · efl
q66 deleted Run Doc System Locally.
Aug 3 2017, 6:38 AM
q66 edited the content of Documentation System.
Aug 3 2017, 6:38 AM

Jul 28 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

yeah, i think we can just proceed with this, if there are no further objections

Jul 28 2017, 3:50 PM · Restricted Project, efl

Jul 27 2017

q66 updated subscribers of Documentation System.
Jul 27 2017, 3:21 AM
q66 edited the content of Documentation System.
Jul 27 2017, 3:16 AM

Jul 19 2017

q66 added a comment to T5583: [Experiment] Function pointers in EO.

Yeah, if the function becomes three parameters, it's technically possible to implement. I just fear that this is 1) not really necessary 2) rather ugly API-wise... Also, the way Eolian currently works doesn't assume multiple things can be generated from one, so that'd have to be updated as well...

Jul 19 2017, 6:45 AM · efl
q66 added a comment to T5719: Force all apis to be implemented.

I don't think eolian_gen is the right place to put this at all. It should go into the validator in the library. If you want me to implement this, I can...

Jul 19 2017, 6:43 AM · efl

Jul 17 2017

q66 closed T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly as Resolved by committing rEFLd5bca5b0cbc9: eolian: always generate a class initializer.
Jul 17 2017, 2:06 AM
q66 triaged T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly as High priority.
Jul 17 2017, 1:50 AM
q66 added a comment to T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly.

yeah, will be a pretty simple fix

Jul 17 2017, 1:49 AM

Jun 28 2017

q66 edited the content of Enlightenment Developer Days 2017.
Jun 28 2017, 3:03 AM

Jun 16 2017

q66 added a comment to T5577: Support easy object instantiation with Edje External.

That sounds potentially sensible to me. EDD is coming up soon so we can also discuss the details more there.

Jun 16 2017, 2:07 AM · efl, Restricted Project

Jun 15 2017

q66 added a comment to T5577: Support easy object instantiation with Edje External.

I guess it's possible in theory, though it's more work than you think and I'm not sure if I like the idea yet. Also it doesn't properly handle types and other dependent things (which are shared between classes and multiple translation units) and I could probably think up a billion other potential issues that could get in the way, so the extra complexity is by no means small. Having to care about where things are put in the binary sounds super nasty and I hate it, too. So this is definitely not something to think about for this release cycle, if at all.

Jun 15 2017, 8:29 AM · efl, Restricted Project
q66 added a comment to T5577: Support easy object instantiation with Edje External.

what I wonder (actually I should know, but I never remember) and maybe @q66 can clarify is if we have that information available in runtime and how/where?

Jun 15 2017, 7:51 AM · efl, Restricted Project

Jun 14 2017

q66 added a comment to T5567: Simple factories (with or without model).

@jpeg they won't work unless we figure out lifetime and memory management tracking... if you have ideas, feel free to suggest

Jun 14 2017, 4:19 AM · Restricted Project, efl

May 22 2017

q66 added a comment to T5512: eolian can not parse an eo file.

The change 7007c3314d31d1c80d1670500d899ed9d7350a79 is a pretty bad idea as it seems to break build. It's never good to deifne a thing in two places like this, because it *will* result in conflict in Eolian for a good reason; the solution would be either putting the undefined type in the .eot file so it's in a single place, or just revert the commit for now.

May 22 2017, 7:47 AM · efl

May 19 2017

q66 added a comment to T5305: Add @internal tag.

yeah, _EXTRA_OPS should work for this purpose, even though it wasn't really written with this report in mind.

May 19 2017, 3:52 AM · Restricted Project, efl

Apr 6 2017

q66 added a comment to T5307: Add style description in .eo.

This is also something we could look into, however I've been doing some prototyping in my local tree and still not sure how I'd approach this. We should probably discuss this more and find some reasonable way for 1.20.

Apr 6 2017, 5:42 AM · Restricted Project, efl
q66 added a comment to T5306: Add a efl_part information to .eo files .

Yeah, I agree with @cedric here. This is something to look into. The parts syntax is probably good enough. I don't like the @part variant.

Apr 6 2017, 5:40 AM · Restricted Project, efl
q66 added a comment to T5305: Add @internal tag.

I've been thinking about this and even trying stuff in my tree, and I'm honestly still not sure whether it's a good idea... I can see we might need something like this at some point, I'm just not sure if it's worth it to define something that is internal anyway, not visible to public API, and not visible to bindings in .eo...

Apr 6 2017, 5:36 AM · Restricted Project, efl

Mar 7 2017

q66 closed T5208: generate better C signature for events as Resolved.

it does, just needs regeneration on website. well then

Mar 7 2017, 9:56 AM
q66 added a comment to T5208: generate better C signature for events.

I implemented this in bf7b3e5dfca740e5e1096fbbfb81cffb980f1b2a. I'll leave this open for now, so if you have any suggestions, i'll deal with those before closing.

Mar 7 2017, 8:17 AM

Feb 24 2017

q66 closed T5207: gendoc.lua to generate more complete yet simpler C docs as Resolved.

All the points except the event stuff are dealt with now, and event stuff is T5208, so closing.

Feb 24 2017, 8:14 AM

Dec 21 2016

q66 added a comment to D4502: Edje: add returned value by default(error) to edje_object_part_external_param_type_get.

yes, it works @artem.popov - if you had it expand to 0, this was before the recent bug fixes in the Eolian expression handling code (unlike previously, Eolian now fully validates all expressions and whether they match their data type, instead of silently expanding to 0 - but the particular 0 expansion previously was caused by a bug in the expr evaluator). If you still have it happening, a locally installed libeolian is probably at fault - autotools somehow prefers system libs as dependencies instead of the in-tree ones. The above fix expands to this with properly updated EFL:

Dec 21 2016, 8:59 AM
q66 added a comment to D4502: Edje: add returned value by default(error) to edje_object_part_external_param_type_get.

Just tested,

Dec 21 2016, 5:44 AM

Nov 29 2016

q66 added a comment to D4430: eolian: remove all duplicated affix.

The suffix abbreviation was meant to be just a simple thing to remove duplicates when two words follow each other. I do not consider this a bug fix since it potentially significantly changes some API names as well as Eolian behavior, so this sounds like a thing to be discussed and thought about first. Keep in mind that i'm not against having a feature like that as long as it's justified, but just pushing a patch like this without any prior conversation is wrong, and this doesn't go for just this patch.

Nov 29 2016, 10:14 AM
q66 added a comment to D4430: eolian: remove all duplicated affix.

Excuse me, but seriously guys? This lack of communication kinda pisses me off.

Nov 29 2016, 4:38 AM

Nov 3 2016

q66 closed T4825: Build Break EFL FreeBSD as Wontfix.

it's because autotools sucks and build is using installed libeolian library instead of in-tree during build; remove $PREFIX/lib/libeolian.so*

Nov 3 2016, 11:41 AM · efl

Oct 31 2016

q66 added a comment to D4343: eolian: omit "_CLASS" suffix when eo name ends with "_CLASS".

well it looks fine to me right now, but ping @tasn

Oct 31 2016, 4:07 AM

Oct 25 2016

q66 added a comment to T4761: EFL Build Fail (Linux ARMHF).

@barbieri deserves a spanking for this one, but it also helped me realize that eolian generator does not validate (so it only fails in elua), so I fixed that too now

Oct 25 2016, 7:03 AM · efl
q66 closed T4761: EFL Build Fail (Linux ARMHF) as Resolved by committing rEFL08f11e2c4616: ecore con: fix invalid doc reference.
Oct 25 2016, 6:55 AM · efl

Oct 19 2016

q66 closed D4356: eolian: fix build warning by committing rEFLc0a41034cdaa: eolian: fix build warning (authored by conr2d).
Oct 19 2016, 2:52 PM
q66 accepted D4356: eolian: fix build warning.
Oct 19 2016, 2:46 PM

Oct 12 2016

q66 added a comment to D4343: eolian: omit "_CLASS" suffix when eo name ends with "_CLASS".

I updated the generator to use an Eolian API instead manually concatenating now in d3d63ea8d39378b254728390809c44163bbadb63

Oct 12 2016, 6:15 AM

Oct 10 2016

q66 requested changes to D4343: eolian: omit "_CLASS" suffix when eo name ends with "_CLASS".

Hm, let's see. So if we're going to do this (need comments from @tasn too, as I'm not going to make this decision by myself) I'd at least properly do it for all object types (i.e. treat suffixes _MIXIN and _INTERFACE in the same manner). Also, I'm thinking this would be best added as a new API into the Eolian library. That way the generator won't have to special-case this, and it'll potentially help other generators too.

Oct 10 2016, 12:06 PM

Sep 9 2016

q66 closed T4443: Eolian generates wrong documentation for struct and enum fields as Resolved by committing rEFLdd9155cf24ca: eolian: properly add < in struct/enum field docs.
Sep 9 2016, 4:04 AM · efl

Aug 23 2016

q66 added a comment to T3849: Eolian does not parse a corner case within "implements".

BTW, here's a tip: if the "get" method in your class serves as some sort of singleton getter, (i.e. you want blah_get to retrieve some instance of Blah) name your method blah_get, and Eolian will automatically turn double words like blah_blah_get() to just blah_get().

Aug 23 2016, 5:46 AM · efl
q66 closed T3849: Eolian does not parse a corner case within "implements" as Resolved by committing rEFL1c78d2196bf0: eolian: enforce no get/set as method/property name rule.
Aug 23 2016, 5:44 AM · efl
q66 added a comment to T3849: Eolian does not parse a corner case within "implements".

We decided to make the names "get" and "set" reserved, so just don't use them as method names... the appropriate Eolian changes to verify this will come later.

Aug 23 2016, 5:33 AM · efl
q66 closed T4393: Add comment about return type of a event in .eo.h as Resolved by committing rEFLdf74455ec916: eolian gen: include return type in event docs.
Aug 23 2016, 4:06 AM · efl

Aug 11 2016

q66 added a comment to T2728: fix compilation with Lua 5.2+.

it is, but LuaJIT can actually JIT FFI calls and as a result generate the same code as a function pointer call would in C, while C calls are interpreted/slow (both because of the call itself, and argument/result marshalling)

Aug 11 2016, 6:06 AM · efl

Aug 9 2016

q66 added a comment to T2728: fix compilation with Lua 5.2+.

Well, my point was more about external scripts (say, ones part of potential third party Enlightenment themes). If EFL supports all four versions (luajit, 5.1, 5.2, 5.3) and a script that is part of an Enlightenment theme gets written against 5.2 or for example using a LuaJIT language extension, it will not work with EFL builds built against a different version of Lua (therefore preventing usage of that theme in that build of Enlightenment).

Aug 9 2016, 6:47 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

That's nice to know, but it's sort of useless anyway if we can't properly test on those targets, as with something the size of EFL things are bound to be broken in various places on untested setups...

Aug 9 2016, 4:45 AM · efl

Aug 2 2016

q66 added a comment to T2728: fix compilation with Lua 5.2+.

@aerodynamik I looked at the lua ffi a while ago, it wasn't really very usable and it had some semantics differences compared to luajit ffi

Aug 2 2016, 5:28 PM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

elua (which will become increasingly more used, once the efl lua bindings are fully functional) doesn't work without luajit at all (even now), bob (when it's written) will not work without luajit, etc.

Aug 2 2016, 3:23 PM · efl

Jul 31 2016

q66 added a comment to D4201: Support for OpenBSD non-PAM lokker authentication..

@zmike not familiar either, this stuff is only used by openbsd and freebsd/netbsd/etc use PAM just like linux, sorry

Jul 31 2016, 2:46 PM

Jul 19 2016

q66 triaged T2728: fix compilation with Lua 5.2+ as TODO priority.

Sounds good, let's do it when merge window opens.

Jul 19 2016, 7:54 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

I think we're good in that case. Do we want to drop it for 1.18 or leave it for next release?

Jul 19 2016, 7:39 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

windows and mac os support is fine. I tested it myself since I had luajit integrated in my game engine and didn't experience any issues.

Jul 19 2016, 7:02 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

We basically have two options. Either maintain support with all Lua versions - which is theoretically possible but then we can't guarantee that all scripts will keep working on all EFL installations (because of subtle language/library differences) and we'll have to drop it later anyway, or just drop everything but luajit... the choice is yours

Jul 19 2016, 2:28 AM · efl

Jun 14 2016

q66 added a comment to T3849: Eolian does not parse a corner case within "implements".

I have looked into this and it will require some changes around the place. Either way I will aim to get it in for 1.18.

Jun 14 2016, 7:03 AM · efl
q66 closed T3788: Eo doesnt allow inheriting regular classes in regular classes, eolian does as Resolved.

I added the necessary code to support this in 70d28666628a09c70895d4d426b719f9362b394f but apparently there are eo files in the EFL that don't conform to this (which is obviously wrong and as things will be broken under certain cases) so it's disabled for the time being... i will close this and deal with the issue further.

Jun 14 2016, 7:02 AM · efl

Jun 13 2016

q66 closed T3202: eolian fails on eo_prefix / legacy_prefix in a interface as Resolved.

I fixed the cursor position thing in 922e4e918182c4a6d012973a237b89b9248a017c so it will now correctly display at the beginning of the doc (I fixed it for other tokens as well). The rest of the report is not a bug, so closing.

Jun 13 2016, 7:00 AM · efl

Jun 9 2016

q66 closed T3645: eolian: support @protected for set / get as Resolved.

Implemented in 375179b47fa62dba2a1168d1e4e6a7ab877f7414.

Jun 9 2016, 8:57 AM · Restricted Project

May 25 2016

q66 added a comment to T3638: Using int instead of ptrdiff_t produces incorrect result, e.g. eina_stringshared_hash is broken..

how about the other cases across the EFL where an identical thing is done?

May 25 2016, 5:33 PM · efl
q66 added a comment to T3638: Using int instead of ptrdiff_t produces incorrect result, e.g. eina_stringshared_hash is broken..

that's my point, we shouldn't use ptrdiff_t for return, as it will break things, but using a branchless sign like i suggested would probably be a good idea (even though a decent compiler will optimize your version anyway)

May 25 2016, 7:15 AM · efl
q66 added a comment to T3638: Using int instead of ptrdiff_t produces incorrect result, e.g. eina_stringshared_hash is broken..

perhaps changing the compare func to return something like ptrdiff_t kdiff = key1 - key2; return (kdiff > 0) - (kdiff < 0); would be the best idea.

May 25 2016, 6:53 AM · efl
q66 added a comment to T3638: Using int instead of ptrdiff_t produces incorrect result, e.g. eina_stringshared_hash is broken..

actually there is an ABI problem, as eina_hash_new can take an arbitrary external key compare func, which we would break by changing the signature

May 25 2016, 6:44 AM · efl

May 23 2016

q66 added a comment to T3672: Eolian segfaults when receiving an invalid keyword combination.

Yo, fixed in 4bdb1f73b8ec55d4d00a2ce6607d47f388150ed2.

May 23 2016, 2:51 AM
q66 closed T3672: Eolian segfaults when receiving an invalid keyword combination as Resolved by committing rEFL4bdb1f73b8ec: eolian: handle invalid keywords correctly.
May 23 2016, 2:50 AM

May 17 2016

q66 closed T3111: Eolian doesn't respect eo_prefix for events as Resolved.

Closing this, fixed in 7782c0bcb956263e4b58b9ee5640381fe7b3c4f9

May 17 2016, 9:53 AM · efl
q66 edited the content of Eolian.
May 17 2016, 5:38 AM
q66 edited the content of Eolian.
May 17 2016, 5:34 AM