Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (335 w, 4 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Fri, Sep 13

q66 closed T8213: eolian: support $[...] syntax as Resolved by committing rEFL266fd9bb368b: eolian: support complex monospace syntax $[...].
Fri, Sep 13, 8:08 AM · Restricted Project, efl
q66 closed T8169: how to reference events with commas in eo docs? as Resolved.

as @segfaultxavi said

Fri, Sep 13, 7:56 AM · Restricted Project

Thu, Sep 12

q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.
In T8184#142189, @tasn wrote:
In T8184#142185, @q66 wrote:

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Yeah, we understand what "requires" means, as in why the name is there. Though how is it different than implements? As that's exactly what's going on here?

Thu, Sep 12, 12:00 PM
q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Thu, Sep 12, 7:52 AM

Tue, Sep 10

q66 closed T7460: eolian: remove ptr() as Resolved.

As of afc011d8931006bd020ba5130a581580f709edcf, usage of ptr() is banned in stable API. That's bound to be good enough for now, and removing it from beta is a separate task, so closing this as resolved.

Tue, Sep 10, 5:40 AM · Restricted Project

Mon, Sep 9

q66 closed D9867: eolian_cxx: Add support for @by_ref.
Mon, Sep 9, 9:19 AM · efl
q66 accepted D9867: eolian_cxx: Add support for @by_ref.
Mon, Sep 9, 9:09 AM · efl
q66 closed D9875: docs: remove nstate preview.
Mon, Sep 9, 6:56 AM · efl: docs
q66 accepted D9875: docs: remove nstate preview.
Mon, Sep 9, 6:55 AM · efl: docs

Fri, Sep 6

q66 requested changes to D9867: eolian_cxx: Add support for @by_ref.

this doesn't correctly fix the eolian_type_c_type_get usage yet, which means this will behave wrong with the tag; i still see EOLIAN_C_TYPE_DEFAULT/PARAM/RETURN being passed around.

Fri, Sep 6, 4:00 PM · efl
q66 closed D9866: eolian_cxx: Remove last usage of type_is_owned.
Fri, Sep 6, 3:57 PM · efl
q66 accepted D9866: eolian_cxx: Remove last usage of type_is_owned.
Fri, Sep 6, 3:56 PM · efl
q66 added a comment to T6890: Eolian error integration.

OK, I did that for now, but we'll need to figure out a proper one...

Fri, Sep 6, 9:05 AM · efl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFLcb2b6d666cf2: eolian_gen: make errors compile/work.
Fri, Sep 6, 9:04 AM · efl: language bindings, Restricted Project
q66 closed T8183: Eolian and composite objects: weird syntax as Resolved by committing rEFLeb25e92770f9: eolian: change composite syntax from block to inheritance section.
Fri, Sep 6, 6:14 AM

Thu, Sep 5

q66 closed D9844: bindings: Rename test cxx and csharp eo ownership tags.
Thu, Sep 5, 11:05 AM · efl
q66 added a commit to T8199: eolian_cxx: Update after @move/@owned changes: rEFL17c6cabaa44a: bindings: Rename test cxx and csharp eo ownership tags.
Thu, Sep 5, 11:05 AM · Restricted Project, efl: language bindings
q66 closed T8199: eolian_cxx: Update after @move/@owned changes as Resolved by committing rEFL1e8554821406: eolian_cxx: Replace type_is_owned with is_move.
Thu, Sep 5, 11:05 AM · Restricted Project, efl: language bindings
q66 closed D9843: eolian_cxx: Replace type_is_owned with is_move.
Thu, Sep 5, 11:05 AM · efl
q66 accepted D9844: bindings: Rename test cxx and csharp eo ownership tags.
Thu, Sep 5, 11:04 AM · efl
q66 accepted D9843: eolian_cxx: Replace type_is_owned with is_move.
Thu, Sep 5, 11:03 AM · efl
q66 closed T8035: Unify handling of contents of complex types as Resolved.

I think we've got this down, eolian properly checks and verifies this

Thu, Sep 5, 7:37 AM · Restricted Project
q66 moved T7955: eolian: remove keyword legacy from enums from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Thu, Sep 5, 5:23 AM · Restricted Project
q66 lowered the priority of T7955: eolian: remove keyword legacy from enums from High to TODO.

this is now banned in stable API... removal still pending

Thu, Sep 5, 5:23 AM · Restricted Project

Thu, Aug 29

q66 added a comment to T6890: Eolian error integration.

Hm, what should be do about this? Do we want this to be thread-safe? Because the error API is not...

Thu, Aug 29, 9:12 AM · efl: language bindings, Restricted Project
q66 closed T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient as Resolved.

Closing this as the system is generally sound. Syntax changes may happen but no design alterations

Thu, Aug 29, 6:29 AM · Restricted Project

Wed, Aug 28

q66 requested changes to D9510: eolian: Add @static to classes.

Please rebase for the @class -> @static method change

Wed, Aug 28, 1:23 AM · efl
q66 closed D9626: pyolian: Update after event and binbuf keywords.
Wed, Aug 28, 1:21 AM · efl
q66 closed D9421: eolian_aux: this must be recursive.
Wed, Aug 28, 1:21 AM · efl
q66 accepted D9421: eolian_aux: this must be recursive.
Wed, Aug 28, 1:20 AM · efl
q66 accepted D9626: pyolian: Update after event and binbuf keywords.
Wed, Aug 28, 1:20 AM · efl
q66 placed T8181: Memory Issue with Eo Legacy Widget Implementation. up for grabs.
Wed, Aug 28, 1:17 AM
q66 added a comment to T8181: Memory Issue with Eo Legacy Widget Implementation..

Okay, but I'm not sure why you assigned this to me, considering I'm not dealing with widgets.

Wed, Aug 28, 1:16 AM

Aug 16 2019

q66 closed T8140: ASAN detected memory leaks in eolian_gen as Resolved.
Aug 16 2019, 4:45 AM
q66 added a commit to T8140: ASAN detected memory leaks in eolian_gen: rEFL9f2e2f99c666: eolian: fix function pointer leak as reported by asan.
Aug 16 2019, 4:34 AM

Aug 14 2019

q66 closed D9572: efl_ui/win: implement unimplemented methods.
Aug 14 2019, 10:35 AM · efl
q66 closed D9562: efl_ui/layout: implement unimplemented methods.
Aug 14 2019, 10:35 AM · efl
q66 closed D9561: efl_ui: mark localization methods with @empty for containers.
Aug 14 2019, 10:35 AM · efl
q66 closed D9560: efl: remove Efl.Ui.I18n from canvas object inheritance.
Aug 14 2019, 10:35 AM · efl
q66 closed D9559: efl: mark a couple internal eo files as @beta.
Aug 14 2019, 10:34 AM · efl
q66 accepted D9572: efl_ui/win: implement unimplemented methods.
Aug 14 2019, 10:23 AM · efl
q66 accepted D9562: efl_ui/layout: implement unimplemented methods.
Aug 14 2019, 10:23 AM · efl
q66 accepted D9561: efl_ui: mark localization methods with @empty for containers.
Aug 14 2019, 10:22 AM · efl
q66 accepted D9560: efl: remove Efl.Ui.I18n from canvas object inheritance.
Aug 14 2019, 10:22 AM · efl
q66 accepted D9559: efl: mark a couple internal eo files as @beta.
Aug 14 2019, 10:22 AM · efl

Aug 9 2019

q66 added a comment to T7675: Do not allow static-function polymorphism.

Hm? why not just rename current @class to @static (which is easy and quick) and then only re-add @class later if it ends up being needed?

Aug 9 2019, 9:27 AM · BBQ, efl: data types, Restricted Project
q66 added a comment to T7675: Do not allow static-function polymorphism.

If it's just renaming to @static, then that's fine and easy

Aug 9 2019, 8:57 AM · BBQ, efl: data types, Restricted Project

Jul 26 2019

q66 closed D9412: eolian-cxx: Add binbuf and event keywords handling n.
Jul 26 2019, 4:21 AM · efl
q66 accepted D9412: eolian-cxx: Add binbuf and event keywords handling n.
Jul 26 2019, 4:01 AM · efl

Jul 23 2019

q66 closed D9349: eolian_mono: parse `binbuf` and `event` keywords, also re-enable binbuf tests.
Jul 23 2019, 5:10 AM · efl
q66 accepted D9349: eolian_mono: parse `binbuf` and `event` keywords, also re-enable binbuf tests.
Jul 23 2019, 5:09 AM · efl
q66 accepted D9369: eolian: start to express ownership transfere.

I think this is good

Jul 23 2019, 5:07 AM · efl

Jul 8 2019

q66 closed D9124: eolian: fix leak in eolian_state_file_path_parse.
Jul 8 2019, 7:56 AM · efl
q66 closed D9237: eolian_cxx: update eolian_cxx to recognize slice and rw_slice.
Jul 8 2019, 7:56 AM · efl
q66 closed D9236: eolian_cxx: update tests to no longer use forbidden eolian notations.
Jul 8 2019, 7:56 AM · efl
q66 accepted D9124: eolian: fix leak in eolian_state_file_path_parse.
Jul 8 2019, 7:17 AM · efl
q66 accepted D9236: eolian_cxx: update tests to no longer use forbidden eolian notations.
Jul 8 2019, 7:15 AM · efl
q66 accepted D9237: eolian_cxx: update eolian_cxx to recognize slice and rw_slice.

But the proper thing to do later on would be to create a wrapper type with the same layout as Eina_Slice (or Eina_Rw_Slice) but make it templated in order to respect Eolian's typeinfo. But for now this is fine

Jul 8 2019, 7:15 AM · efl
q66 added a commit to T6890: Eolian error integration: rEFL2a1fa5d2aad8: eolian_gen: introduce C generation support for error types.
Jul 8 2019, 7:08 AM · efl: language bindings, Restricted Project

Jun 26 2019

q66 triaged T8035: Unify handling of contents of complex types as High priority.
Jun 26 2019, 7:24 AM · Restricted Project

Jun 24 2019

q66 added a comment to T6890: Eolian error integration.

I added an initial syntax for this in the commit above. Please comment if you have any suggestions, objections etc.

Jun 24 2019, 6:22 AM · efl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFL1bbf4380abce: eolian: add library support for declaring and using errors.
Jun 24 2019, 6:14 AM · efl: language bindings, Restricted Project

May 30 2019

q66 closed T6716: allow enum/class/struct renaming as Resolved by committing rEFL9cba6a4f0e9d: eolian: allow complete symbol renaming for C.
May 30 2019, 7:29 AM · efl: language bindings, Restricted Project

May 28 2019

q66 added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I landed the patch so this can proceed probably.

May 28 2019, 8:21 AM · efl
q66 closed D9031: eolian: allow parts named like methods.
May 28 2019, 8:17 AM · efl
q66 added a comment to D9031: eolian: allow parts named like methods.

Just running tests before landing this now.

May 28 2019, 8:13 AM · efl
q66 accepted D9031: eolian: allow parts named like methods.

Hm, I think it's fine.

May 28 2019, 8:10 AM · efl

May 16 2019

q66 closed D8905: Eo: replace Evil.h with evil_private.h.
May 16 2019, 5:43 AM · efl
q66 accepted D8905: Eo: replace Evil.h with evil_private.h.
May 16 2019, 5:35 AM · efl

May 14 2019

q66 accepted D8890: efl-mono: Use Efl.Ui.Win API instead of Elm.Policy.

Looking good to me

May 14 2019, 4:51 AM · efl

May 9 2019

q66 moved T6716: allow enum/class/struct renaming from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 9 2019, 6:22 AM · efl: language bindings, Restricted Project
q66 raised the priority of T6716: allow enum/class/struct renaming from TODO to High.
May 9 2019, 6:22 AM · efl: language bindings, Restricted Project
q66 updated the task description for T7955: eolian: remove keyword legacy from enums.
May 9 2019, 6:21 AM · Restricted Project
q66 updated the task description for T7955: eolian: remove keyword legacy from enums.
May 9 2019, 6:20 AM · Restricted Project
q66 moved T7955: eolian: remove keyword legacy from enums from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 9 2019, 6:16 AM · Restricted Project
q66 closed T6486: Eolian: enum with keyword legacy as Wontfix.

https://phab.enlightenment.org/T7955

May 9 2019, 6:15 AM · efl: language bindings, Restricted Project
q66 triaged T7955: eolian: remove keyword legacy from enums as High priority.
May 9 2019, 6:10 AM · Restricted Project
q66 added a comment to T7240: Not allow multi class inheritance in eo.

Any update on this? Can it be closed? As far as Eolian is concerned it's been done for a while

May 9 2019, 5:40 AM · efl: language bindings, Restricted Project
q66 closed T7463: eolian: separate modern and legacy APIs as Resolved.

This has been done for a while.

May 9 2019, 5:25 AM · Restricted Project

May 6 2019

q66 closed T7911: "conflicting paths" error messages of eolian (on Windows) as Resolved by committing rEFL159e95516845: eolian: fix conflicts between eo file names in tests.
May 6 2019, 8:06 AM · Restricted Project

May 5 2019

q66 closed T7837: Eolian verify part types as Resolved by committing rEFL653fddfc1e17: eolian: add support for marking and checking parts as beta.
May 5 2019, 8:08 AM · Restricted Project

May 3 2019

q66 closed T7820: Eolian SegFault as Resolved by committing rEFLdb57523e7846: eolian: refactor parsing API and path handling.
May 3 2019, 8:07 AM · Restricted Project

Apr 24 2019

q66 closed D8696: eo_parser: fix unreachable code.
Apr 24 2019, 2:56 AM · efl
q66 accepted D8696: eo_parser: fix unreachable code.
Apr 24 2019, 2:56 AM · efl
q66 added a comment to D8696: eo_parser: fix unreachable code.

No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.

Apr 24 2019, 2:14 AM · efl

Apr 23 2019

q66 requested changes to D8696: eo_parser: fix unreachable code.

The goto is unnecessary, syntax error means a long jump

Apr 23 2019, 11:55 PM · efl

Apr 19 2019

q66 added a comment to T7820: Eolian SegFault.

that helps, i'll add guards for it once I am back

Apr 19 2019, 2:38 PM · Restricted Project

Apr 14 2019

q66 reassigned T7805: error when installing c++ header from q66 to lauromoura.
Apr 14 2019, 8:15 AM · Restricted Project

Mar 21 2019

q66 closed D8437: mono-tests: Fix after latest changes to eolian.
Mar 21 2019, 9:20 AM · efl
q66 accepted D8437: mono-tests: Fix after latest changes to eolian.
Mar 21 2019, 9:19 AM · efl
q66 closed T7759: Apply Calling convention rules checking to eolian as Resolved.

3f083b3ccba9cdc0f9cfe875fec030e228be69d0

Mar 21 2019, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed T7759: Apply Calling convention rules checking to eolian, a subtask of T7738: Calling convention for events in eolian, as Resolved.
Mar 21 2019, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed D8432: Windows, meson build : use posix *printf family function.
Mar 21 2019, 3:26 AM · efl
q66 accepted D8432: Windows, meson build : use posix *printf family function.
Mar 21 2019, 3:26 AM · efl

Mar 20 2019

q66 accepted D8425: eolian: enable event redef checking by default.
Mar 20 2019, 1:11 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

you still missed one

Mar 20 2019, 12:15 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

You can't just eina_hash_add into nhash without checking !oobj because if you do and the entry is already present, that's undefined behavior for our hash implementation, so either keep the if or make them eina_hash_set

Mar 20 2019, 11:52 AM · efl

Mar 18 2019

q66 added a comment to T7738: Calling convention for events in eolian.

That works too

Mar 18 2019, 1:45 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I intend to do away with const() as well as ptr() in the current form entirely, so having a new syntax is the better choice for it, besides, immutable by default is a better choice than mutable by default

Mar 18 2019, 1:15 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Or maybe, make them const by default and some kind of event tag to make it mutable where needed?

Mar 18 2019, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api