Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (291 w, 6 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Today

q66 added a comment to T7462: eolian: add information to .eot/.eo files about what library module to link/load.

so that third party bindings can make use of it, obviously

Fri, Nov 16, 3:49 AM · Restricted Project
q66 added a comment to T7462: eolian: add information to .eot/.eo files about what library module to link/load.

yep - and we need a standard way which is not a bash script

Fri, Nov 16, 2:48 AM · Restricted Project

Yesterday

q66 added a comment to T6840: Generate event wrapper for C.

welcome back @cedric o/

Thu, Nov 15, 11:58 AM · efl: language bindings, Restricted Project, Restricted Project
q66 abandoned D7261: eolian: use 'free' for owned mstring but not string.
Thu, Nov 15, 3:17 AM · efl

Wed, Nov 14

q66 moved T7180: Make eolian_gen warn about missing documentation from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:30 AM · Restricted Project, efl: docs, Restricted Project
q66 moved T7463: eolian: separate modern and legacy APIs from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:25 AM · Restricted Project
q66 triaged T7463: eolian: separate modern and legacy APIs as TODO priority.
Wed, Nov 14, 5:25 AM · Restricted Project
q66 moved T6577: Eolian documentation fallback from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:23 AM · efl: docs, efl: language bindings, Restricted Project
q66 raised the priority of T6577: Eolian documentation fallback from TODO to High.

eolian_aux which is currently under review (D7245) provides this.

Wed, Nov 14, 5:23 AM · efl: docs, efl: language bindings, Restricted Project
q66 moved T6890: Eolian error integration from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:22 AM · efl: language bindings, Restricted Project
q66 moved T7454: eolian: warn if event appears in more than one inherited class from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:22 AM · Restricted Project, efl
q66 moved T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:21 AM · efl: language bindings, Restricted Project
q66 moved T7462: eolian: add information to .eot/.eo files about what library module to link/load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:21 AM · Restricted Project
q66 created T7462: eolian: add information to .eot/.eo files about what library module to link/load.
Wed, Nov 14, 5:21 AM · Restricted Project
q66 moved T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:15 AM · Restricted Project
q66 created T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.
Wed, Nov 14, 5:15 AM · Restricted Project
q66 moved T7460: eolian: remove ptr() from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:13 AM · Restricted Project
q66 created T7460: eolian: remove ptr().
Wed, Nov 14, 5:13 AM · Restricted Project
q66 moved T7459: eolian: new syntax for inheritance from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:09 AM · Restricted Project
q66 created T7459: eolian: new syntax for inheritance.
Wed, Nov 14, 5:09 AM · Restricted Project
q66 moved T7452: eolian: check duplicate inheritance in the library from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:04 AM · Restricted Project
q66 moved T7365: eolian: Warn if a regular class appears anywhere other than the first place in an inheritance list from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:03 AM · Restricted Project, efl
q66 moved T7240: Not allow multi class inheritance in eo from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Nov 14, 5:03 AM · efl: language bindings, Restricted Project

Mon, Nov 12

q66 requested review of D7261: eolian: use 'free' for owned mstring but not string.
Mon, Nov 12, 6:26 AM · efl

Thu, Nov 8

q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Not what I am getting

Thu, Nov 8, 11:49 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Also, I believe you are wrong:

Thu, Nov 8, 11:41 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

IS that so? That is interesting, because a potential change of implementation (i.e. potentially behavior of Eolian itself) should trigger re-generation of eo.* files (in order to account for the new behavior), and changed headers should rebuild the rest of it. At least that's how I see it, if Meson does not do it, we potentially have another problem at hand...

Thu, Nov 8, 11:33 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

Honestly, I think we should drop autotools as soon as possible.

Thu, Nov 8, 10:46 AM · efl
q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

why not? i don't see any particular disadvantage to it, and at least it allows addition of new APIs and being able to run tests on them without triggering a full EFL rebuild every time (as eolian_gen itself is most likely not going to depend on it)

Thu, Nov 8, 3:00 AM · efl

Wed, Nov 7

q66 added a comment to D7245: eolian_aux: add initial eolian_aux APIs.

I had plans for more, but I wasn't able to abstract these APIs well enough to make it into a reusable piece that makes sense. So for now there's these (they will help shorten the docgen) and more will be added gradually as I figure them out (but I won't actually focus on the library anymore once it's merged, just add new APIs as they make sense)

Wed, Nov 7, 8:55 AM · efl
q66 requested review of D7245: eolian_aux: add initial eolian_aux APIs.
Wed, Nov 7, 8:54 AM · efl

Tue, Nov 6

q66 triaged T7452: eolian: check duplicate inheritance in the library as Normal priority.
Tue, Nov 6, 4:06 AM · Restricted Project

Fri, Nov 2

q66 added a comment to T6128: Generate C# reference API documentation.

Perfect. We can synchronize efforts later then.

Fri, Nov 2, 7:20 AM · efl: language bindings, efl: docs

Thu, Nov 1

q66 added a comment to T6128: Generate C# reference API documentation.

I took a break from that to work on meson, eolian_aux (which will be used to move some of the core from the docgen) and some other things, but the code is all in my personal dev repo... I will try to get a proper repository set up early next week or maybe even during this weekend. If somebody wants to help with working on the doc generator or even provide feedback on the generated output, go ahead, it would be much appreciated.

Thu, Nov 1, 4:06 AM · efl: language bindings, efl: docs

Tue, Oct 30

q66 closed T7399: eolian: Add @ctor_param hint to constructors section as Resolved.
Tue, Oct 30, 6:49 PM · efl: language bindings
q66 closed D7221: eolian: Add @ctor_param parameter to constructors.
Tue, Oct 30, 6:49 PM · efl
q66 accepted D7221: eolian: Add @ctor_param parameter to constructors.
Tue, Oct 30, 6:47 PM · efl
q66 added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

I still don't think that this will actually solve any real problem, but feel free to go ahead if you think it'll help, the constructor system is unlikely to stay in long term anyway

Tue, Oct 30, 4:45 AM · efl: language bindings

Thu, Oct 25

q66 closed D7214: meson: disable luajit & mono by default.
Thu, Oct 25, 2:50 PM · efl
q66 closed D7213: meson: do not add cs as required compiler.
Thu, Oct 25, 2:45 PM · efl
q66 accepted D7214: meson: disable luajit & mono by default.
Thu, Oct 25, 2:44 PM · efl
q66 accepted D7213: meson: do not add cs as required compiler.
Thu, Oct 25, 2:44 PM · efl

Wed, Oct 24

q66 closed D7187: meson: add eolian custom dependencies support.
Wed, Oct 24, 3:04 AM · efl
q66 closed T6700: eolian build rules do not regenerate based on dependencies as Resolved by committing rEFL5a3d79d3833a: meson: add eolian custom dependencies support.
Wed, Oct 24, 3:04 AM · efl: meson, efl: language bindings, Restricted Project
q66 closed T6700: eolian build rules do not regenerate based on dependencies, a subtask of T2251: Add dump of gnu style dependencies for eolian, as Resolved.
Wed, Oct 24, 3:04 AM · efl: meson, efl: language bindings, Restricted Project
q66 closed T2251: Add dump of gnu style dependencies for eolian as Resolved by committing rEFLd82deea833d1: eolian gen: add generation of build dependencies.
Wed, Oct 24, 3:03 AM · efl: meson, efl: language bindings, Restricted Project

Mon, Oct 22

q66 requested review of D7187: meson: add eolian custom dependencies support.
Mon, Oct 22, 7:43 AM · efl

Oct 12 2018

q66 requested changes to D7158: eolian: Support generate legacy group names for enum, brief, etc.

You are strduping the name, then returning it as a const char * and not freeing it, which results in an obvious memory leak; what you should do is move the declaration of legacy_group_name into _append_group, then pass it as a pointer to _get_group_name and snprintf into it when legacy is being used, then return it as a pointer, then no memory allocation is necessary, like this:

Oct 12 2018, 2:42 AM · efl

Oct 10 2018

q66 added a comment to D7138: eolian: Fix mangled documentation check.

the reason is to enforce consistent documentation format where brief documentation comes first, detailed description later, and the since tag last; there is no deeper technical decision behind this

Oct 10 2018, 1:05 AM · efl

Oct 9 2018

q66 added a comment to D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.

huh, that makes sense though... since the generated files changed, so the reference files in tests no longer match; it's a false positive but needs to be fixed anyway

Oct 9 2018, 4:08 PM · efl
q66 added a comment to D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.

👍

Oct 9 2018, 9:05 AM · efl
q66 accepted D7148: eolian: use the legacy_prefix to generate the legacy doxygen group names.

this looks fine, thanks

Oct 9 2018, 4:13 AM · efl

Oct 5 2018

q66 added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

When I talk of a mapping file, what I have in mind is something like D7085, but generalized, moved out of source code and not doing O(n) lookup for each alias (therefore using a hash table to do lookups instead)

Oct 5 2018, 5:21 AM · efl
q66 added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Option 2b as suggested by Xavi could also help, I strongly suggest looking into implementing it that way and see if it solves the problem for you.

Oct 5 2018, 5:16 AM · efl
q66 added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

If we are to add any sort of temporary fix to support legacy API documentation better, I suggest it is not done in the Eolian library or .eo files, but rather in the legacy header generator, using some kind of non-invasive approach that can be easily phased out once we've dealt with legacy APIs (for example, some kind of mapping file that can be easily expanded and later removed); the thing is, legacy APIs within .eo files are a non-ideal situation that creates a fair amount of burden on Eolian/eo and will likely be moved out into header files sometime in near future, and then there would be no need for any such workaround, because the docs for legacy will be like they used to be in the past. I'm open to having a temporary solution/workaround but not one that goes directly against our future goals.

Oct 5 2018, 5:15 AM · efl

Oct 4 2018

q66 added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Here is the thing; we have new documentation for generated eo API, on dokuwiki. Therefore, for that, doxygen is considered deprecated, and the only reason Eolian generates any Doxygen documentation comments is to help IDEs and other tools with suggestions, it is not intended for actual documentation generation. I am aware of the situation with legacy APIs, which are unfortunately also currently generated using Eolian; however, there is an ongoing investigation on how to deal with legacy APIs and things will very likely change significantly in near future, so there is no need right now to add something like this which would only introduce more APIs to deal with legacy into Eolian, when the ultimate goal is to reduce the amount of legacy stuff in Eolian. So what we need to do will only become clear depending on what path we will take with handling legacy in the EFL, but it will be different from what we have now.

Oct 4 2018, 8:22 AM · efl
q66 added a comment to D7138: eolian: Fix mangled documentation check.

@since has nothing to do with it; the ]] token simply terminates a documentation block regardless of presence of @since. The code just has an extra check that if you do use @since, then ]] has to follow, to prevent using @since in the middle of a documentation block.

Oct 4 2018, 8:16 AM · efl
q66 added a comment to T6128: Generate C# reference API documentation.

The generator rewrite is pretty much done btw, including refactored C# support. It will be announced and hopefully made into an official repository within a few days.

Oct 4 2018, 6:31 AM · efl: language bindings, efl: docs
q66 added a comment to T7399: eolian: Add @ctor_param hint to constructors section.

I said this before but I'm not at all happy with the constructor system as it is, so I don't think it's right to just keep extending it and make things even harder for generators. Right now things are difficult and don't map well to pretty much any OO language, on the other hand I'm not entirely sure how to deal with it either :/

Oct 4 2018, 6:27 AM · efl: language bindings
q66 added a comment to T7356: EO: Support elm_config APIs.

yeah we could probably have that, can you create a ticket and assign it to me?

Oct 4 2018, 6:26 AM · efl, Restricted Project
q66 requested changes to D7138: eolian: Fix mangled documentation check.

Not necessary. The docs don't care if the parens are balanced or not. Do you have a legitimate use case for this? If you do, show me, if not, it's another O(n) check in an inner loop that is called numerous times that will ultimately slow down everything. Additionally, the Unicode decoding is completely unnecessary to handle ASCII characters.

Oct 4 2018, 6:23 AM · efl
q66 added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Grouping is a purely legacy Doxygen feature and I don't think it's right to introduce it into docs at all. The generated Doxygen comments in the API are not for actual documentation, but more for IDE hints etc. where the group name does not matter.

Oct 4 2018, 6:13 AM · efl
q66 requested changes to D7085: eolian: Set widget and widget item in the same group in doxygen.

I'm not sure if I like this, because it means hardcoding things and the constant lookups (which are O(n) from the alias table) will slow down the entire Eolian. I don't think it's worth it to bother with correct doxygen grouping at all, because the dokuwiki based docs are the way to go and legacy will come down to how it's handled in the future, which is currently subject to investigation.

Oct 4 2018, 6:11 AM · efl

Sep 12 2018

q66 updated subscribers of T6128: Generate C# reference API documentation.
Sep 12 2018, 8:09 AM · efl: language bindings, efl: docs

Sep 4 2018

q66 added a comment to T7240: Not allow multi class inheritance in eo.

@segfaultxavi eolian does exactly the same check at compile-time that eo does at runtime: https://git.enlightenment.org/core/efl.git/tree/src/lib/eolian/database_validate.c#n802

Sep 4 2018, 4:39 AM · efl: language bindings, Restricted Project
q66 added a comment to T7240: Not allow multi class inheritance in eo.

because it's regular multi-class inheritance and it's how eo was designed? i mean, that's what this ticket is trying to point out

Sep 4 2018, 4:27 AM · efl: language bindings, Restricted Project

Aug 16 2018

q66 accepted D6850: Remove EOLIAN_TESTS_EOS_GENERATED.
Aug 16 2018, 10:23 AM · efl

Aug 7 2018

q66 accepted D6773: tests/eolian: remove eolian_decl test.

now looks good

Aug 7 2018, 9:09 AM · efl
q66 requested changes to D6773: tests/eolian: remove eolian_decl test.

this doesn't seem to delete decl.eo, remove that from tree too

Aug 7 2018, 9:08 AM · efl
q66 accepted D6773: tests/eolian: remove eolian_decl test.
Aug 7 2018, 9:07 AM · efl

Aug 1 2018

q66 updated the diff for D6721: build: disable Lua binding generation.

AM_CONDITIONAL inside EFL_LIB_START_OPTIONAL would result in the
variables not being defined with Elua disabled.

Aug 1 2018, 8:01 AM · efl

Jul 30 2018

q66 added a comment to D6692: build: always build elua, make bindings build optional.

fair enough.

Jul 30 2018, 4:47 AM · Restricted Project, efl (efl-1.22), Restricted Project

Jul 29 2018

Herald added a reviewer for D6692: build: always build elua, make bindings build optional: devilhorns.
Jul 29 2018, 4:26 PM · Restricted Project, efl (efl-1.22), Restricted Project
Herald added a reviewer for D6692: build: always build elua, make bindings build optional: devilhorns.
Jul 29 2018, 4:26 PM · Restricted Project, efl (efl-1.22), Restricted Project

Jul 27 2018

q66 added a comment to D6655: ci: use gold linker for linux builds.

maybe using clang and ld.lld would also be worth a try (lld should be even much faster than gold, and clang should also be at least a little bit faster)

Jul 27 2018, 2:54 AM · Restricted Project

Jul 26 2018

q66 claimed T6128: Generate C# reference API documentation.

As talked over previously, I will claim this task and integrate C# into the current documentation generator. Before that, I intend to rewrite the documentation generator using a simpler design, so that it will become easier to integrate C# and other languages into it.

Jul 26 2018, 2:32 AM · efl: language bindings, efl: docs

Jul 18 2018

q66 edited the content of Maintainers Reviewers.
Jul 18 2018, 7:36 PM · efl

Jul 15 2018

q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

That doesn't make it okay.

Jul 15 2018, 9:59 PM · efl
q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

This will obviously cause issues when e.g. using an efl dll on Windows with visual studio toolchain

Jul 15 2018, 9:51 PM · efl
q66 added a comment to D6553: eo: Fix efl_new without initializing parameters.

keep in mind that this is not portable, it's a GNU extension, so not sure if it's a good idea to use it in a public header

Jul 15 2018, 9:47 PM · efl

Jun 28 2018

q66 added a comment to T6406: elua doesn't work on aarch64 due to 47bit pointer restrictions .

@simotek think you could get me the backtrace so that i can finally deal with this?

Jun 28 2018, 6:11 AM · efl (efl-1.21), efl: language bindings, Restricted Project
q66 added a comment to T6713: in-tree binaries do not run using in-tree libraries during build.

I think this is currently not easily solvable using autotools. Perhaps setting LD_LIBRARY_PATH at the points when executables are being run would do the thing, but I'd say this is something to be addressed with switching to Meson.

Jun 28 2018, 6:09 AM · efl (efl-1.21), Restricted Project
q66 removed a project from T5994: Missing Enum types documents in API references: efl (efl-1.21).
Jun 28 2018, 6:04 AM · efl: docs, efl: language bindings, Restricted Project
q66 lowered the priority of T5994: Missing Enum types documents in API references from Normal to Pending on user input.

well, i tried looking into this but as things are right now it's unsolvable. I guess we'll need to decide 1) whether this needs a solution, considering all the eo files have new non-doxygen docs 2) what would be the best approach to making it solvable...

Jun 28 2018, 6:04 AM · efl: docs, efl: language bindings, Restricted Project

Jun 27 2018

q66 added a project to T5994: Missing Enum types documents in API references: efl (efl-1.21).
Jun 27 2018, 1:07 PM · efl: docs, efl: language bindings, Restricted Project
q66 triaged T5994: Missing Enum types documents in API references as Normal priority.
Jun 27 2018, 1:07 PM · efl: docs, efl: language bindings, Restricted Project
q66 triaged T6670: elua build issue (libeina.so) as Pending on user input priority.
Jun 27 2018, 12:53 PM · efl: language bindings, Restricted Project

Jun 25 2018

q66 lowered the priority of T6406: elua doesn't work on aarch64 due to 47bit pointer restrictions from High to Pending on user input.
Jun 25 2018, 11:50 AM · efl (efl-1.21), efl: language bindings, Restricted Project

Jun 22 2018

q66 added a comment to T2251: Add dump of gnu style dependencies for eolian.

this will need feature work so i removed the tag, but it'll get done for 1.22

Jun 22 2018, 7:39 AM · efl: meson, efl: language bindings, Restricted Project
q66 removed a project from T2251: Add dump of gnu style dependencies for eolian: efl (efl-1.21).
Jun 22 2018, 7:39 AM · efl: meson, efl: language bindings, Restricted Project

Jun 21 2018

q66 closed D6347: Fix segfault when parsing EO_LIFECYCLE_DEBUG envvar.
Jun 21 2018, 8:12 AM · efl
q66 accepted D6347: Fix segfault when parsing EO_LIFECYCLE_DEBUG envvar.
Jun 21 2018, 8:11 AM · efl
q66 closed T6667: string.h should not be assumed to define ssize_t as Resolved by committing rEFL1bcdc8af7be7: efl: include sys/types.h where ssize_t is used.
Jun 21 2018, 5:11 AM · efl: data types

Jun 11 2018

q66 edited projects for T3090: "Alt Gr" key stops working with Compose key and xim input method, added: efl: input; removed Restricted Project.
Jun 11 2018, 8:13 AM · efl: input
q66 edited projects for T3283: Creating your own mesh in Evas 3D doesn't get an aabb applied, AND you can't do so manually., added: efl; removed Restricted Project.
Jun 11 2018, 8:13 AM · efl: rendering
q66 edited projects for T1872: Terminology options -M, --maximized don't work, added: efl: display system; removed Restricted Project.
Jun 11 2018, 8:11 AM · efl: display system, Terminology
q66 edited projects for T2719: Translucency breaks on window mapping to X11, added: efl: display system; removed Restricted Project.
Jun 11 2018, 8:03 AM · efl: display system, Terminology
q66 edited projects for T5203: alt+esc sometimes crash, added: efl; removed Restricted Project.
Jun 11 2018, 8:02 AM · enlightenment-git
q66 edited projects for T5251: Moving the mouse creates a storm of strcmp(), added: efl: input; removed Restricted Project.
Jun 11 2018, 8:02 AM · efl: input
q66 edited projects for T5506: Add new API to edje_edit for manipulate evas.filter, added: efl: layout engine; removed Restricted Project.
Jun 11 2018, 8:01 AM · efl: layout engine, Restricted Project, Eflete