Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (326 w, 3 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Mon, Jul 8

q66 closed D9124: eolian: fix leak in eolian_state_file_path_parse.
Mon, Jul 8, 7:56 AM · efl
q66 closed D9237: eolian_cxx: update eolian_cxx to recognize slice and rw_slice.
Mon, Jul 8, 7:56 AM · efl
q66 closed D9236: eolian_cxx: update tests to no longer use forbidden eolian notations.
Mon, Jul 8, 7:56 AM · efl
q66 accepted D9124: eolian: fix leak in eolian_state_file_path_parse.
Mon, Jul 8, 7:17 AM · efl
q66 accepted D9236: eolian_cxx: update tests to no longer use forbidden eolian notations.
Mon, Jul 8, 7:15 AM · efl
q66 accepted D9237: eolian_cxx: update eolian_cxx to recognize slice and rw_slice.

But the proper thing to do later on would be to create a wrapper type with the same layout as Eina_Slice (or Eina_Rw_Slice) but make it templated in order to respect Eolian's typeinfo. But for now this is fine

Mon, Jul 8, 7:15 AM · efl
q66 added a commit to T6890: Eolian error integration: rEFL2a1fa5d2aad8: eolian_gen: introduce C generation support for error types.
Mon, Jul 8, 7:08 AM · efl: language bindings, Restricted Project

Wed, Jun 26

q66 triaged T8035: Unify handling of contents of complex types as High priority.
Wed, Jun 26, 7:24 AM · Restricted Project

Mon, Jun 24

q66 added a comment to T6890: Eolian error integration.

I added an initial syntax for this in the commit above. Please comment if you have any suggestions, objections etc.

Mon, Jun 24, 6:22 AM · efl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFL1bbf4380abce: eolian: add library support for declaring and using errors.
Mon, Jun 24, 6:14 AM · efl: language bindings, Restricted Project

May 30 2019

q66 closed T6716: allow enum/class/struct renaming as Resolved by committing rEFL9cba6a4f0e9d: eolian: allow complete symbol renaming for C.
May 30 2019, 7:29 AM · efl: language bindings, Restricted Project

May 28 2019

q66 added a comment to D8582: efl_ui : refactoring efl.part in item based classes..

I landed the patch so this can proceed probably.

May 28 2019, 8:21 AM · efl
q66 closed D9031: eolian: allow parts named like methods.
May 28 2019, 8:17 AM · efl
q66 added a comment to D9031: eolian: allow parts named like methods.

Just running tests before landing this now.

May 28 2019, 8:13 AM · efl
q66 accepted D9031: eolian: allow parts named like methods.

Hm, I think it's fine.

May 28 2019, 8:10 AM · efl

May 16 2019

q66 closed D8905: Eo: replace Evil.h with evil_private.h.
May 16 2019, 5:43 AM · efl
q66 accepted D8905: Eo: replace Evil.h with evil_private.h.
May 16 2019, 5:35 AM · efl

May 14 2019

q66 accepted D8890: efl-mono: Use Efl.Ui.Win API instead of Elm.Policy.

Looking good to me

May 14 2019, 4:51 AM · efl

May 9 2019

q66 moved T6716: allow enum/class/struct renaming from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 9 2019, 6:22 AM · efl: language bindings, Restricted Project
q66 raised the priority of T6716: allow enum/class/struct renaming from TODO to High.
May 9 2019, 6:22 AM · efl: language bindings, Restricted Project
q66 updated the task description for T7955: eolian: remove keyword legacy from enums.
May 9 2019, 6:21 AM · Restricted Project
q66 updated the task description for T7955: eolian: remove keyword legacy from enums.
May 9 2019, 6:20 AM · Restricted Project
q66 moved T7955: eolian: remove keyword legacy from enums from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 9 2019, 6:16 AM · Restricted Project
q66 closed T6486: Eolian: enum with keyword legacy as Wontfix.

https://phab.enlightenment.org/T7955

May 9 2019, 6:15 AM · efl: language bindings, Restricted Project
q66 triaged T7955: eolian: remove keyword legacy from enums as High priority.
May 9 2019, 6:10 AM · Restricted Project
q66 added a comment to T7240: Not allow multi class inheritance in eo.

Any update on this? Can it be closed? As far as Eolian is concerned it's been done for a while

May 9 2019, 5:40 AM · efl: language bindings, Restricted Project
q66 closed T7463: eolian: separate modern and legacy APIs as Resolved.

This has been done for a while.

May 9 2019, 5:25 AM · Restricted Project

May 6 2019

q66 closed T7911: "conflicting paths" error messages of eolian (on Windows) as Resolved by committing rEFL159e95516845: eolian: fix conflicts between eo file names in tests.
May 6 2019, 8:06 AM · Restricted Project

May 5 2019

q66 closed T7837: Eolian verify part types as Resolved by committing rEFL653fddfc1e17: eolian: add support for marking and checking parts as beta.
May 5 2019, 8:08 AM · Restricted Project

May 3 2019

q66 closed T7820: Eolian SegFault as Resolved by committing rEFLdb57523e7846: eolian: refactor parsing API and path handling.
May 3 2019, 8:07 AM · Restricted Project

Apr 24 2019

q66 closed D8696: eo_parser: fix unreachable code.
Apr 24 2019, 2:56 AM · efl
q66 accepted D8696: eo_parser: fix unreachable code.
Apr 24 2019, 2:56 AM · efl
q66 added a comment to D8696: eo_parser: fix unreachable code.

No, it's not intended, but all you need to do is simply remove the first is_enum check and leave the second one where it is.

Apr 24 2019, 2:14 AM · efl

Apr 23 2019

q66 requested changes to D8696: eo_parser: fix unreachable code.

The goto is unnecessary, syntax error means a long jump

Apr 23 2019, 11:55 PM · efl

Apr 19 2019

q66 added a comment to T7820: Eolian SegFault.

that helps, i'll add guards for it once I am back

Apr 19 2019, 2:38 PM · Restricted Project

Apr 14 2019

q66 reassigned T7805: error when installing c++ header from q66 to lauromoura.
Apr 14 2019, 8:15 AM · Restricted Project

Mar 21 2019

q66 closed D8437: mono-tests: Fix after latest changes to eolian.
Mar 21 2019, 9:20 AM · efl
q66 accepted D8437: mono-tests: Fix after latest changes to eolian.
Mar 21 2019, 9:19 AM · efl
q66 closed T7759: Apply Calling convention rules checking to eolian as Resolved.

3f083b3ccba9cdc0f9cfe875fec030e228be69d0

Mar 21 2019, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed T7759: Apply Calling convention rules checking to eolian, a subtask of T7738: Calling convention for events in eolian, as Resolved.
Mar 21 2019, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed D8432: Windows, meson build : use posix *printf family function.
Mar 21 2019, 3:26 AM · efl
q66 accepted D8432: Windows, meson build : use posix *printf family function.
Mar 21 2019, 3:26 AM · efl

Mar 20 2019

q66 accepted D8425: eolian: enable event redef checking by default.
Mar 20 2019, 1:11 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

you still missed one

Mar 20 2019, 12:15 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

You can't just eina_hash_add into nhash without checking !oobj because if you do and the entry is already present, that's undefined behavior for our hash implementation, so either keep the if or make them eina_hash_set

Mar 20 2019, 11:52 AM · efl

Mar 18 2019

q66 added a comment to T7738: Calling convention for events in eolian.

That works too

Mar 18 2019, 1:45 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I intend to do away with const() as well as ptr() in the current form entirely, so having a new syntax is the better choice for it, besides, immutable by default is a better choice than mutable by default

Mar 18 2019, 1:15 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Or maybe, make them const by default and some kind of event tag to make it mutable where needed?

Mar 18 2019, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Understood. Do we need a way to make objects const when possible?

Mar 18 2019, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

That sounds good to me. So basically the only types allowed are value types, objects and container types, minus list/iterator; everything is annotated without any qualifier, and everything is immutable and passed by reference, except objects. Maybe we should pass objects by const too? So that only @const methods can be called on it. That would make all event data completely immutable.

Mar 18 2019, 12:02 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I'd say that allowing less is always a good thing, as it allows for fewer errors/mistakes, so if we can do away with it, let's do it

Mar 18 2019, 11:39 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I don't think we currently specify how things are *meant* to be; we need to come up with something.

Mar 18 2019, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Any proposals on this?

Mar 18 2019, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
q66 updated the diff for D8322: efl: remove EFL_EO_API_SUPPORT macro.

rebase + remove leftover macro usage

Mar 18 2019, 4:03 AM · efl
q66 added a comment to D8322: efl: remove EFL_EO_API_SUPPORT macro.

The comment in elm_interface_scrollable.c is fine, doesn't need changing.

Mar 18 2019, 4:02 AM · efl
q66 added inline comments to D8322: efl: remove EFL_EO_API_SUPPORT macro.
Mar 18 2019, 4:00 AM · efl

Mar 15 2019

q66 added a comment to D8322: efl: remove EFL_EO_API_SUPPORT macro.

Looks like this one is good to go https://travis-ci.org/Enlightenment/efl/builds/506793582

Mar 15 2019, 7:55 AM · efl

Mar 14 2019

q66 updated the diff for D8322: efl: remove EFL_EO_API_SUPPORT macro.

rebase + more fixes

Mar 14 2019, 5:16 PM · efl

Mar 12 2019

q66 accepted D8310: eolian: Fix resource leak.
Mar 12 2019, 8:21 AM · efl
q66 requested review of D8322: efl: remove EFL_EO_API_SUPPORT macro.
Mar 12 2019, 7:50 AM · efl
q66 accepted D8316: eo: Fix missing varags cleanup.
Mar 12 2019, 7:49 AM · efl
q66 added a comment to T7736: C#: Support eolian variables.

Yeah, I'm ok with not having vars, as the abuse potential is there. Constants are another matter, these are constrained and rather trivial.

Mar 12 2019, 4:33 AM · efl: language bindings

Mar 11 2019

q66 abandoned D8258: efl: remove all remaining .eo.legacy.h includes.

I decided it's for the best to solve this properly at a later point

Mar 11 2019, 5:54 AM · efl
q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

marked missing classes beta, rebase

Mar 11 2019, 5:29 AM · efl

Mar 10 2019

q66 added a comment to D8258: efl: remove all remaining .eo.legacy.h includes.

We can not, these are a workaround for beta API enabled but eo API disabled, eo files still depend on those, we need to solve this properly later but that will take more effort than is reasonable right now

Mar 10 2019, 5:04 AM · efl

Mar 9 2019

q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

rebase

Mar 9 2019, 1:20 PM · efl
q66 updated the diff for D8258: efl: remove all remaining .eo.legacy.h includes.

rebase

Mar 9 2019, 1:20 PM · efl
q66 added a comment to D8266: eolian: enable checking of beta/stable contexts in all classes.

previously they weren't assumed anything, any checks regarding beta were simply skipped, but @beta could be used the same; the new behavior checks them, so i only fixed those classes that were newly causing errors

Mar 9 2019, 12:43 PM · efl
q66 accepted D8277: efl: ensure legacy is only relying on stable types.
Mar 9 2019, 7:05 AM · efl
q66 accepted D8276: eolian: drop env var checking that is unneccessary.
Mar 9 2019, 7:04 AM · efl

Mar 8 2019

q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

removed outdated comment

Mar 8 2019, 8:14 AM · efl
q66 requested review of D8266: eolian: enable checking of beta/stable contexts in all classes.
Mar 8 2019, 8:12 AM · efl
q66 updated the diff for D8258: efl: remove all remaining .eo.legacy.h includes.

rebase

Mar 8 2019, 7:52 AM · efl
q66 requested review of D8258: efl: remove all remaining .eo.legacy.h includes.
Mar 8 2019, 7:45 AM · efl
q66 requested review of D8255: eolian: remove legacy handling API and most of generation.
Mar 8 2019, 6:35 AM · efl
q66 accepted D8254: tests: add test for legacy-only build in elm_suite.
Mar 8 2019, 5:55 AM · Restricted Project
q66 accepted D8252: tests: add build test for EFL_NOLEGACY_API_SUPPORT in efl_ui_suite.
Mar 8 2019, 5:54 AM · Restricted Project
q66 accepted D8253: tests: use Efl_Ui.h for efl_ui test.
Mar 8 2019, 5:50 AM · efl
q66 requested review of D8251: elementary,evas: remove obsolete legacy includes.
Mar 8 2019, 5:27 AM · efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

rebase

Mar 8 2019, 4:36 AM · Restricted Project, efl

Mar 7 2019

q66 closed D8246: efl_ui_flip: remove no-op legacy from eo file.
Mar 7 2019, 2:51 PM · Restricted Project
q66 accepted D8246: efl_ui_flip: remove no-op legacy from eo file.
Mar 7 2019, 2:49 PM · Restricted Project
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

can't enable beta guards for types yet, as it triggers too much
brokenness which we can't fix in time

Mar 7 2019, 2:45 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

rebase

Mar 7 2019, 2:21 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

added support for marking function types beta

Mar 7 2019, 12:28 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

added generator support, fixed parser bug, rebase

Mar 7 2019, 8:11 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

There is also nothing wrong with the test results of your test, that is fully intended; the class is not in the Efl. namespace, therefore it's not treated as a stable class. Putting it in the Efl. namespace makes it warn normally:

Mar 7 2019, 6:10 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

Struct fields are checked implicitly by design just like all other types, it does not need any specific code. When a non-beta function/typedecl/whatever is encountered, the validator switches state into "stable" mode and any dependent types (which includes anything in struct fields) are required to be non-beta. I will investigate the other stuff.

Mar 7 2019, 5:52 AM · Restricted Project, efl
q66 accepted D8157: elm_clock: remove all legacy usage from eo files.
Mar 7 2019, 5:27 AM · Restricted Project
q66 accepted D8156: elm_calendar: remove all legacy usage from eo files.
Mar 7 2019, 5:26 AM · Restricted Project
q66 accepted D8155: elm_bubble: remove all legacy usage from eo files.
Mar 7 2019, 5:26 AM · Restricted Project
q66 accepted D8154: elm_box: remove all legacy usage from eo files.
Mar 7 2019, 5:26 AM · Restricted Project

Mar 5 2019

q66 added a comment to T7724: split out legacy from eo files.

I'll take src/lib/elementary/elm_*.eo.

Mar 5 2019, 6:57 PM · Restricted Project
q66 added a project to D8102: eolian: add support for marking type declarations beta: Restricted Project.
Mar 5 2019, 8:13 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

I know this changes Eolian API so since we're in a freeze it's probably not 100% ideal to merge this, but we need this to be able to stabilize at least something at all.

Mar 5 2019, 7:29 AM · Restricted Project, efl
q66 requested review of D8102: eolian: add support for marking type declarations beta.
Mar 5 2019, 7:28 AM · Restricted Project, efl

Mar 4 2019

q66 added a comment to T7720: eolian legacy type generation broken.

We have no Elm_Win_Type in eo files, nor Eolian provides any facilities to deal with legacy types, so this will need to be fixed manually as manual legacy APIs are pushed into the tree.

Mar 4 2019, 3:22 AM · efl (efl-1.22), Restricted Project, Restricted Project

Feb 28 2019

q66 closed T7523: eolian inlist-inarray as Resolved.

Removed in 4b1622b5fc7c6aaafb4d70f187ec5ea797275a26

Feb 28 2019, 5:33 PM · efl: language bindings, Restricted Project
q66 closed T7647: C# test suite inlist/inarray usage as Resolved.

bf4280e915ebbd4cbad2ee9c8fcd2730fd29eb6f

Feb 28 2019, 5:33 PM · efl: language bindings, Restricted Project
q66 closed T7647: C# test suite inlist/inarray usage, a subtask of T7523: eolian inlist-inarray, as Resolved.
Feb 28 2019, 5:33 PM · efl: language bindings, Restricted Project