q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (266 w, 3 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Fri, May 18

q66 closed D6169: Add missing event types.
Fri, May 18, 4:47 PM · efl
q66 accepted D6169: Add missing event types.
Fri, May 18, 4:36 PM · efl
q66 closed D6179: Do not expose callback,add & del events in bindings.
Fri, May 18, 7:49 AM · efl
q66 accepted D6179: Do not expose callback,add & del events in bindings.

yeah, this is fine.

Fri, May 18, 7:39 AM · efl

Wed, May 16

q66 added inline comments to D6169: Add missing event types.
Wed, May 16, 8:10 AM · efl
q66 added inline comments to D6169: Add missing event types.
Wed, May 16, 7:13 AM · efl
q66 requested changes to D6169: Add missing event types.

i'll let @cedric review the eo file updates, mostly looks good to me besides the inline comment i've come across to

Wed, May 16, 5:53 AM · efl

Thu, Apr 26

q66 abandoned D6005: eolian: Check for event/function clash..
Thu, Apr 26, 7:17 AM
q66 commandeered D6005: eolian: Check for event/function clash..
Thu, Apr 26, 7:17 AM
q66 added a comment to D6005: eolian: Check for event/function clash..

I added a check in f796a21d72c47d7661349f14e6533299f750654a, but currently our eo files fail with that, so it's behind an env var.

Thu, Apr 26, 7:17 AM

Wed, Apr 25

q66 requested changes to D6005: eolian: Check for event/function clash..

i noticed that part will need more rewriting anyway, i'll look into it tomorrow.

Wed, Apr 25, 1:39 PM
q66 triaged T6896: Create Eolian static checking tool as Normal priority.

Yes, definitely. I've already been working on this.

Wed, Apr 25, 3:19 AM · Unknown Object (Project)

Apr 18 2018

q66 added a comment to T6740: Proposal for project management and communication.

I also like the idea of an IRC meeting. Next or this weekend is good :)

Apr 18 2018, 1:06 AM · efl

Apr 17 2018

q66 lowered the priority of T6859: Enabling eo @property get to be @const when necessary from High to TODO.

Switching this to TODO, as the immediate issue is gone, but we might perhaps need some more work on constness that is yet to be discussed in order to make things right.

Apr 17 2018, 1:09 PM · Unknown Object (Project)
q66 added a commit to T6859: Enabling eo @property get to be @const when necessary: rEFLfcae7cab276c: eolian gen: enable constness generation on property getter impls.
Apr 17 2018, 11:32 AM · Unknown Object (Project)
q66 added a comment to T6840: Generate event wrapper for C.

Do we really still want this? As I see it, there is fairly little point in polluting public API with wrappers over callback_call, considering callback_call is mostly meant to be called from within implementation in the first place, i.e. leaking it into public API is probably bad.

Apr 17 2018, 7:21 AM · Unknown Object (Project), Restricted Project, efl

Apr 16 2018

q66 added a comment to T6406: elua doesn't work on aarch64 due to 47bit pointer restrictions .

Yeah, that'd help.

Apr 16 2018, 1:39 AM · Unknown Object (Project)

Apr 13 2018

q66 triaged T6406: elua doesn't work on aarch64 due to 47bit pointer restrictions as High priority.

Please give this a try after b8f28e2a99535a8e9780f9ea15572693bf0f7148

Apr 13 2018, 2:49 PM · Unknown Object (Project)
q66 added a comment to T6847: Rationalize class and namespace names.

yes, I was thinking this could potentially allow an array of extra checks we couldn't do before to happen.

Apr 13 2018, 9:59 AM · Restricted Project, efl
q66 added a comment to T6847: Rationalize class and namespace names.

I was thinking Eolian tests would be a good place to run the "global" check pass. It wouldn't run directly during build, but we generally make sure make check keeps passing.

Apr 13 2018, 7:28 AM · Restricted Project, efl
q66 added a comment to D5910: tests: remove sleep() calls from eo tests.

yeah, I think it's okay

Apr 13 2018, 7:13 AM
q66 added a comment to T6847: Rationalize class and namespace names.

It hasn't started yet. I've come to a conclusion that it is not possible to detect name clashes upon generation no matter what changes we make. I think perhaps we could take the middle ground and do checks only in stuff that is parsed at the time, and for global checking we could perhaps have another tool (sort of an Eolian static analyzer). But that's just a thought atm

Apr 13 2018, 7:12 AM · Restricted Project, efl
q66 closed T5535: EFL-git doesn't compile with gcc-7 as Resolved.

This has long been fixed/irrelevant.

Apr 13 2018, 3:50 AM · Unknown Object (Project), efl
q66 claimed T6700: eolian build rules do not regenerate based on dependencies.
Apr 13 2018, 3:48 AM · Unknown Object (Project)
q66 added a parent task for T6700: eolian build rules do not regenerate based on dependencies: Unknown Object (Maniphest Task).
Apr 13 2018, 3:47 AM · Unknown Object (Project)
q66 added a comment to T6700: eolian build rules do not regenerate based on dependencies.

I think we could possibly do this now that we have units, but gotta investigate how. It will probably depend on T2251.

Apr 13 2018, 3:46 AM · Unknown Object (Project)
q66 added a project to T5307: Add style description in .eo: Unknown Object (Project).
Apr 13 2018, 3:44 AM · Unknown Object (Project), Restricted Project, efl
q66 added a project to T6840: Generate event wrapper for C: Unknown Object (Project).
Apr 13 2018, 3:44 AM · Unknown Object (Project), Restricted Project, efl
q66 added a project to T6486: Eolian: enum with keyword legacy: Unknown Object (Project).
Apr 13 2018, 3:43 AM · Unknown Object (Project)
q66 added a project to T6859: Enabling eo @property get to be @const when necessary: Unknown Object (Project).
Apr 13 2018, 3:43 AM · Unknown Object (Project)
q66 edited projects for T6406: elua doesn't work on aarch64 due to 47bit pointer restrictions , added: Unknown Object (Project); removed efl.
Apr 13 2018, 3:42 AM · Unknown Object (Project)
q66 edited projects for T6670: elua build issue (libeina.so), added: Unknown Object (Project); removed efl.
Apr 13 2018, 3:42 AM · Unknown Object (Project)
q66 added a member for E on FreeBSD: q66.
Apr 13 2018, 3:36 AM

Apr 12 2018

q66 added a comment to T6859: Enabling eo @property get to be @const when necessary.

Yes, I noticed that as well. I thought we could perhaps make them const in the static funcs, but I'll have to investigate how much it breaks first.

Apr 12 2018, 10:13 AM · Unknown Object (Project)
q66 closed T6701: eolian error printed for wrong line as Resolved by committing rEFL2defb322144c: eolian: correct line/column number during doc reference validation.
Apr 12 2018, 6:24 AM · Unknown Object (Project)
q66 added a comment to T6859: Enabling eo @property get to be @const when necessary.

I'm looking into this, but I fail to see why this would be necessary. The object is always const on getters, i.e. it's implied and there shouldn't be a need to set it manually. It doesn't make sense on properties in general, because a setter by definition changes the object.

Apr 12 2018, 5:05 AM · Unknown Object (Project)

Apr 10 2018

q66 added a comment to T6847: Rationalize class and namespace names.

Additionally, to point out one of @segfaultxavi's points:

Apr 10 2018, 6:13 AM · Restricted Project, efl
q66 added a comment to T6847: Rationalize class and namespace names.

I really dislike the two-hierarchies thing. I think it makes everything unnecessarily more complicated, besides, C-only information in eo files should be kept to a minimum only for interfacing into C; most APIs are fine as they are, and where different name for C is necessary, Eolian already provides all needed features.

Apr 10 2018, 6:08 AM · Restricted Project, efl

Mar 30 2018

q66 added a comment to T6840: Generate event wrapper for C.

Yeah, I understand what you mean, I'm just not sure if I like the solution. I can't really think of anything else either, though.

Mar 30 2018, 2:06 PM · Unknown Object (Project), Restricted Project, efl
q66 added a comment to T6840: Generate event wrapper for C.

I'm not against the idea of generating the wrappers, but I'm not quite sure about the "empty" idea, it seems pretty hacky and ugly API-wise...

Mar 30 2018, 11:54 AM · Unknown Object (Project), Restricted Project, efl

Mar 2 2018

q66 added a comment to D5829: js,cxx,csharp: Updates after eolian changes.

I committed and pushed the changes, but dropped the JS. It's better to keep it in its current state, because doing stuff like passing NULL in those calls as first param is wrong and will fail, but it will still build - so let's make it easier for the person who ends up fixing it.

Mar 2 2018, 3:03 PM
q66 closed D5829: js,cxx,csharp: Updates after eolian changes.
Mar 2 2018, 3:00 PM
q66 accepted D5829: js,cxx,csharp: Updates after eolian changes.
Mar 2 2018, 2:55 PM
q66 requested changes to D5829: js,cxx,csharp: Updates after eolian changes.

the klass_def.hpp change is definitely wrong, you can cast state to unit, but not the other way around - besides, there is no reason not to use eolian_unit_class_by_name_get anyway.

Mar 2 2018, 1:52 PM

Feb 14 2018

q66 added a comment to T6704: add ability to print statistics for eo files.

I think this would be a good fit for a Lua script.

Feb 14 2018, 11:46 AM · Unknown Object (Project)
q66 added a comment to T6703: Enable Smart screen border to window resize..

yeah, a wizard option is a good idea

Feb 14 2018, 10:50 AM · enlightenment-git
q66 added a comment to T6703: Enable Smart screen border to window resize..

IMO it'd be best to actually remove those because most people I've seen use E were annoyed by those and removed them immediately; the maximizing behavior would be much more useful and expected for most.

Feb 14 2018, 7:12 AM · enlightenment-git

Feb 13 2018

q66 closed T6670: elua build issue (libeina.so) as Resolved.

I applied your patch.

Feb 13 2018, 8:56 AM · Unknown Object (Project)
q66 added a commit to T6670: elua build issue (libeina.so): rEFLb7405b561651: elua: add eina in environment variable library path.
Feb 13 2018, 8:55 AM · Unknown Object (Project)
q66 added a comment to T6700: eolian build rules do not regenerate based on dependencies.

yeah, I don't think we can fix this with autotools. Maybe meson would help though, @bu5hm4n any ideas?

Feb 13 2018, 12:48 AM · Unknown Object (Project)

Dec 18 2017

q66 closed T6523: eolian_gen: SEGV as Resolved by committing rEFL03e77ea36111: eolian: fix use-after-free in eo_parser.
Dec 18 2017, 3:21 PM · efl

Dec 7 2017

q66 triaged T6486: Eolian: enum with keyword legacy as Normal priority.
Dec 7 2017, 4:27 AM · Unknown Object (Project)
q66 added a comment to T6486: Eolian: enum with keyword legacy.

yeah, you're probably right; the current legacy field was never even meant to be a proper feature, more like a temporary hack to get enums for legacy APIs to behave as we want them to...

Dec 7 2017, 4:27 AM · Unknown Object (Project)

Dec 6 2017

q66 closed D5611: eolian_cxx: Fix unit initialization.
Dec 6 2017, 8:43 AM
q66 accepted D5611: eolian_cxx: Fix unit initialization.

thanks

Dec 6 2017, 8:34 AM

Nov 2 2017

q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

I'd unlink it from T5826 but leave it open...

Nov 2 2017, 3:52 AM · efl

Nov 1 2017

q66 closed T5306: Add a efl_part information to .eo files as Resolved.

i guess i'll just close this since part information is already done since a few days ago...

Nov 1 2017, 5:13 AM · Restricted Project, efl
q66 closed T5306: Add a efl_part information to .eo files , a subtask of T5301: Make EFL easier to use by improving its interface, as Resolved.
Nov 1 2017, 5:13 AM · Restricted Project, efl
q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

Since I won't have time for the proper solution in near future (because of other work elsewhere) I'll let @ajwillia.ms proceed with his workaround for the time being. A real solution will be implemented later as time allows, but not bound by this project.

Nov 1 2017, 3:57 AM · efl

Oct 30 2017

q66 updated subscribers of T6283: Build break with nodejs binding.
Oct 30 2017, 9:41 AM · efl
q66 triaged T6283: Build break with nodejs binding as Normal priority.
Oct 30 2017, 9:39 AM · efl
q66 reassigned T6283: Build break with nodejs binding from q66 to felipealmeida.

This should be fixed by the maintainer.

Oct 30 2017, 9:39 AM · efl

Oct 27 2017

q66 added a comment to T6126: Figure out how to extract Doxygen documentation and integrate it into our docuwiki.

We'll definitely need this, but I'm not sure whether processing some sort of XML from Doxygen is the best way to go at it... since this is just C we're dealing with, it's fairly simple as far as the language in headers goes; perhaps we could parse it manually (it shouldn't really be a big deal) which would allow for simpler integration into dokuwiki (doxygen carries a lot of clutter we'd have to strip off into the result). But I will need to investigate this to be able to tell for sure.

Oct 27 2017, 1:44 PM · efl

Oct 24 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

i expect to have it done by tomorrow evening...

Oct 24 2017, 8:50 AM · Restricted Project, efl

Oct 23 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

alright, let's get it in during this week

Oct 23 2017, 2:28 AM · Restricted Project, efl

Oct 17 2017

q66 edited the content of Documentation System.
Oct 17 2017, 3:02 AM
q66 edited the content of Documentation System.
Oct 17 2017, 3:00 AM
q66 edited the content of Documentation System.
Oct 17 2017, 1:44 AM

Oct 13 2017

q66 closed D5306: Passed by value have no meaning in set function..

Yeah, the test was wrong and so was the generator...

Oct 13 2017, 2:51 PM
q66 closed T6186: Reqeuest: Document on first parameter "obj" in eolian gen as Resolved by committing rEFL5699466dbabc: eolian gen: generate documentation for first object param if present.
Oct 13 2017, 6:18 AM
q66 added a comment to T6204: format function cb overhaul .

just FYI, keep in mind that if you "pass" the defined function as an argument in Eolian, it will actually generate *three* arguments in C; data, the actual funcptr, and a "free" funcptr (Eina_Free_Cb) - this is necessary to track lifetimes.

Oct 13 2017, 5:13 AM · Restricted Project, efl

Oct 11 2017

q66 raised the priority of T6186: Reqeuest: Document on first parameter "obj" in eolian gen from Wishlist to Trivial.
Oct 11 2017, 5:17 AM
q66 added a comment to T6186: Reqeuest: Document on first parameter "obj" in eolian gen.

you're right, that should be fixed.

Oct 11 2017, 3:14 AM

Sep 8 2017

q66 added a comment to T5994: Missing Enum types documents in API references.

yeah, the generation for this should probably be changed; it's just a tad difficult because there is no real indication of what the group should be... OTOH, this issue should not be very relevant anymore, because the old Doxygen documentation is getting deprecated anyway...

Sep 8 2017, 3:24 AM · Unknown Object (Project)

Aug 30 2017

q66 added a comment to T2728: fix compilation with Lua 5.2+.

I implemented a fix for the bytecode confusion in 67d1c0e51c01ba159f88adc6446cc31cee79c808 so similar cases should not happen again.

Aug 30 2017, 11:23 AM · efl
q66 added a comment to T5583: [Experiment] Function pointers in EO.

Done in 4a16e1d86253ce336464f26ee9244f25511cb8bb

Aug 30 2017, 7:05 AM · efl

Aug 28 2017

q66 added a comment to T5583: [Experiment] Function pointers in EO.

this is what happens when people push into eolian without letting me review first... i didn't feel like calling out the responsible person at first because it was a change that needed doing anyway but i guess i will have to:

Aug 28 2017, 8:34 AM · efl

Aug 18 2017

q66 added a comment to T2728: fix compilation with Lua 5.2+.

The right way really is to remove the bytecode if it fails loading and try loading the source file... so I guess I will do just that

Aug 18 2017, 8:57 AM · efl
q66 added a comment to T2728: fix compilation with Lua 5.2+.

looks like leftover cached bytecode made with previous version of luajit...

Aug 18 2017, 8:34 AM · efl

Aug 10 2017

q66 closed T5024: eolian should correctly handle return of properties with values const(Struct) as Resolved by committing rEFL706de57b9fa4: eolian: implement proper return type serialization.
Aug 10 2017, 3:48 AM · efl, Unknown Object (Project)

Aug 3 2017

q66 added a comment to T5832: Review and improve EFL references API documentation.

we should also figure out how to integrate the doxygen docs and the dokuwiki, because having two separate systems is just bad...

Aug 3 2017, 6:05 PM · efl
q66 deleted Run Doc System Locally.
Aug 3 2017, 6:38 AM
q66 edited the content of Documentation System.
Aug 3 2017, 6:38 AM

Jul 28 2017

q66 added a comment to T5306: Add a efl_part information to .eo files .

yeah, i think we can just proceed with this, if there are no further objections

Jul 28 2017, 3:50 PM · Restricted Project, efl

Jul 27 2017

q66 updated subscribers of Documentation System.
Jul 27 2017, 3:21 AM
q66 edited the content of Documentation System.
Jul 27 2017, 3:16 AM

Jul 19 2017

q66 added a comment to T5583: [Experiment] Function pointers in EO.

Yeah, if the function becomes three parameters, it's technically possible to implement. I just fear that this is 1) not really necessary 2) rather ugly API-wise... Also, the way Eolian currently works doesn't assume multiple things can be generated from one, so that'd have to be updated as well...

Jul 19 2017, 6:45 AM · efl
q66 added a comment to T5719: Force all apis to be implemented.

I don't think eolian_gen is the right place to put this at all. It should go into the validator in the library. If you want me to implement this, I can...

Jul 19 2017, 6:43 AM · efl

Jul 17 2017

q66 closed T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly as Resolved by committing rEFLd5bca5b0cbc9: eolian: always generate a class initializer.
Jul 17 2017, 2:06 AM
q66 triaged T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly as High priority.
Jul 17 2017, 1:50 AM
q66 added a comment to T5736: class_initializer is not generated when a class doesn't implements parent class's method explicitly.

yeah, will be a pretty simple fix

Jul 17 2017, 1:49 AM

Jun 28 2017

q66 edited the content of Enlightenment Developer Days 2017.
Jun 28 2017, 3:03 AM

Jun 16 2017

q66 added a comment to T5577: Support easy object instantiation with Edje External.

That sounds potentially sensible to me. EDD is coming up soon so we can also discuss the details more there.

Jun 16 2017, 2:07 AM · efl, Restricted Project

Jun 15 2017

q66 added a comment to T5577: Support easy object instantiation with Edje External.

I guess it's possible in theory, though it's more work than you think and I'm not sure if I like the idea yet. Also it doesn't properly handle types and other dependent things (which are shared between classes and multiple translation units) and I could probably think up a billion other potential issues that could get in the way, so the extra complexity is by no means small. Having to care about where things are put in the binary sounds super nasty and I hate it, too. So this is definitely not something to think about for this release cycle, if at all.

Jun 15 2017, 8:29 AM · efl, Restricted Project
q66 added a comment to T5577: Support easy object instantiation with Edje External.

what I wonder (actually I should know, but I never remember) and maybe @q66 can clarify is if we have that information available in runtime and how/where?

Jun 15 2017, 7:51 AM · efl, Restricted Project

Jun 14 2017

q66 added a comment to T5567: Simple factories (with or without model).

@jpeg they won't work unless we figure out lifetime and memory management tracking... if you have ideas, feel free to suggest

Jun 14 2017, 4:19 AM · Restricted Project, efl

May 22 2017

q66 added a comment to T5512: eolian can not parse an eo file.

The change 7007c3314d31d1c80d1670500d899ed9d7350a79 is a pretty bad idea as it seems to break build. It's never good to deifne a thing in two places like this, because it *will* result in conflict in Eolian for a good reason; the solution would be either putting the undefined type in the .eot file so it's in a single place, or just revert the commit for now.

May 22 2017, 7:47 AM · efl

May 19 2017

q66 added a comment to T5305: Add @internal tag.

yeah, _EXTRA_OPS should work for this purpose, even though it wasn't really written with this report in mind.

May 19 2017, 3:52 AM · Restricted Project, efl

Apr 6 2017

q66 added a comment to T5307: Add style description in .eo.

This is also something we could look into, however I've been doing some prototyping in my local tree and still not sure how I'd approach this. We should probably discuss this more and find some reasonable way for 1.20.

Apr 6 2017, 5:42 AM · Restricted Project, Restricted Project, efl
q66 added a comment to T5306: Add a efl_part information to .eo files .

Yeah, I agree with @cedric here. This is something to look into. The parts syntax is probably good enough. I don't like the @part variant.

Apr 6 2017, 5:40 AM · Restricted Project, efl