Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (310 w, 2 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Thu, Mar 21

q66 closed D8437: mono-tests: Fix after latest changes to eolian.
Thu, Mar 21, 9:20 AM · efl
q66 accepted D8437: mono-tests: Fix after latest changes to eolian.
Thu, Mar 21, 9:19 AM · efl
q66 closed T7759: Apply Calling convention rules checking to eolian as Resolved.

3f083b3ccba9cdc0f9cfe875fec030e228be69d0

Thu, Mar 21, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed T7759: Apply Calling convention rules checking to eolian, a subtask of T7738: Calling convention for events in eolian, as Resolved.
Thu, Mar 21, 8:04 AM · Restricted Project, efl (efl-1.22), efl: api
q66 closed D8432: Windows, meson build : use posix *printf family function.
Thu, Mar 21, 3:26 AM · efl
q66 accepted D8432: Windows, meson build : use posix *printf family function.
Thu, Mar 21, 3:26 AM · efl

Wed, Mar 20

q66 accepted D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 1:11 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

you still missed one

Wed, Mar 20, 12:15 PM · efl
q66 requested changes to D8425: eolian: enable event redef checking by default.

You can't just eina_hash_add into nhash without checking !oobj because if you do and the entry is already present, that's undefined behavior for our hash implementation, so either keep the if or make them eina_hash_set

Wed, Mar 20, 11:52 AM · efl

Mon, Mar 18

q66 added a comment to T7738: Calling convention for events in eolian.

That works too

Mon, Mar 18, 1:45 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I intend to do away with const() as well as ptr() in the current form entirely, so having a new syntax is the better choice for it, besides, immutable by default is a better choice than mutable by default

Mon, Mar 18, 1:15 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Or maybe, make them const by default and some kind of event tag to make it mutable where needed?

Mon, Mar 18, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Understood. Do we need a way to make objects const when possible?

Mon, Mar 18, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

That sounds good to me. So basically the only types allowed are value types, objects and container types, minus list/iterator; everything is annotated without any qualifier, and everything is immutable and passed by reference, except objects. Maybe we should pass objects by const too? So that only @const methods can be called on it. That would make all event data completely immutable.

Mon, Mar 18, 12:02 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I'd say that allowing less is always a good thing, as it allows for fewer errors/mistakes, so if we can do away with it, let's do it

Mon, Mar 18, 11:39 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I don't think we currently specify how things are *meant* to be; we need to come up with something.

Mon, Mar 18, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Any proposals on this?

Mon, Mar 18, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
q66 updated the diff for D8322: efl: remove EFL_EO_API_SUPPORT macro.

rebase + remove leftover macro usage

Mon, Mar 18, 4:03 AM · efl
q66 added a comment to D8322: efl: remove EFL_EO_API_SUPPORT macro.

The comment in elm_interface_scrollable.c is fine, doesn't need changing.

Mon, Mar 18, 4:02 AM · efl
q66 added inline comments to D8322: efl: remove EFL_EO_API_SUPPORT macro.
Mon, Mar 18, 4:00 AM · efl

Fri, Mar 15

q66 added a comment to D8322: efl: remove EFL_EO_API_SUPPORT macro.

Looks like this one is good to go https://travis-ci.org/Enlightenment/efl/builds/506793582

Fri, Mar 15, 7:55 AM · efl

Thu, Mar 14

q66 updated the diff for D8322: efl: remove EFL_EO_API_SUPPORT macro.

rebase + more fixes

Thu, Mar 14, 5:16 PM · efl

Tue, Mar 12

q66 accepted D8310: eolian: Fix resource leak.
Tue, Mar 12, 8:21 AM · efl
q66 requested review of D8322: efl: remove EFL_EO_API_SUPPORT macro.
Tue, Mar 12, 7:50 AM · efl
q66 accepted D8316: eo: Fix missing varags cleanup.
Tue, Mar 12, 7:49 AM · efl
q66 added a comment to T7736: C#: Support eolian variables.

Yeah, I'm ok with not having vars, as the abuse potential is there. Constants are another matter, these are constrained and rather trivial.

Tue, Mar 12, 4:33 AM · efl: language bindings

Mon, Mar 11

q66 abandoned D8258: efl: remove all remaining .eo.legacy.h includes.

I decided it's for the best to solve this properly at a later point

Mon, Mar 11, 5:54 AM · efl
q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

marked missing classes beta, rebase

Mon, Mar 11, 5:29 AM · efl

Sun, Mar 10

q66 added a comment to D8258: efl: remove all remaining .eo.legacy.h includes.

We can not, these are a workaround for beta API enabled but do API disabled, eo files still depend on those, we need to solve this properly later but that will take more effort than is reasonable right now

Sun, Mar 10, 5:04 AM · efl

Sat, Mar 9

q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

rebase

Sat, Mar 9, 1:20 PM · efl
q66 updated the diff for D8258: efl: remove all remaining .eo.legacy.h includes.

rebase

Sat, Mar 9, 1:20 PM · efl
q66 added a comment to D8266: eolian: enable checking of beta/stable contexts in all classes.

previously they weren't assumed anything, any checks regarding beta were simply skipped, but @beta could be used the same; the new behavior checks them, so i only fixed those classes that were newly causing errors

Sat, Mar 9, 12:43 PM · efl
q66 accepted D8277: efl: ensure legacy is only relying on stable types.
Sat, Mar 9, 7:05 AM · efl
q66 accepted D8276: eolian: drop env var checking that is unneccessary.
Sat, Mar 9, 7:04 AM · efl

Fri, Mar 8

q66 updated the diff for D8266: eolian: enable checking of beta/stable contexts in all classes.

removed outdated comment

Fri, Mar 8, 8:14 AM · efl
q66 requested review of D8266: eolian: enable checking of beta/stable contexts in all classes.
Fri, Mar 8, 8:12 AM · efl
q66 updated the diff for D8258: efl: remove all remaining .eo.legacy.h includes.

rebase

Fri, Mar 8, 7:52 AM · efl
q66 requested review of D8258: efl: remove all remaining .eo.legacy.h includes.
Fri, Mar 8, 7:45 AM · efl
q66 requested review of D8255: eolian: remove legacy handling API and most of generation.
Fri, Mar 8, 6:35 AM · efl
q66 accepted D8254: tests: add test for legacy-only build in elm_suite.
Fri, Mar 8, 5:55 AM · Restricted Project
q66 accepted D8252: tests: add build test for EFL_NOLEGACY_API_SUPPORT in efl_ui_suite.
Fri, Mar 8, 5:54 AM · Restricted Project
q66 accepted D8253: tests: use Efl_Ui.h for efl_ui test.
Fri, Mar 8, 5:50 AM · efl
q66 requested review of D8251: elementary,evas: remove obsolete legacy includes.
Fri, Mar 8, 5:27 AM · efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

rebase

Fri, Mar 8, 4:36 AM · Restricted Project, efl

Thu, Mar 7

q66 closed D8246: efl_ui_flip: remove no-op legacy from eo file.
Thu, Mar 7, 2:51 PM · Restricted Project
q66 accepted D8246: efl_ui_flip: remove no-op legacy from eo file.
Thu, Mar 7, 2:49 PM · Restricted Project
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

can't enable beta guards for types yet, as it triggers too much
brokenness which we can't fix in time

Thu, Mar 7, 2:45 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

rebase

Thu, Mar 7, 2:21 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

added support for marking function types beta

Thu, Mar 7, 12:28 PM · Restricted Project, efl
q66 updated the diff for D8102: eolian: add support for marking type declarations beta.

added generator support, fixed parser bug, rebase

Thu, Mar 7, 8:11 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

There is also nothing wrong with the test results of your test, that is fully intended; the class is not in the Efl. namespace, therefore it's not treated as a stable class. Putting it in the Efl. namespace makes it warn normally:

Thu, Mar 7, 6:10 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

Struct fields are checked implicitly by design just like all other types, it does not need any specific code. When a non-beta function/typedecl/whatever is encountered, the validator switches state into "stable" mode and any dependent types (which includes anything in struct fields) are required to be non-beta. I will investigate the other stuff.

Thu, Mar 7, 5:52 AM · Restricted Project, efl
q66 accepted D8157: elm_clock: remove all legacy usage from eo files.
Thu, Mar 7, 5:27 AM · Restricted Project
q66 accepted D8156: elm_calendar: remove all legacy usage from eo files.
Thu, Mar 7, 5:26 AM · Restricted Project
q66 accepted D8155: elm_bubble: remove all legacy usage from eo files.
Thu, Mar 7, 5:26 AM · Restricted Project
q66 accepted D8154: elm_box: remove all legacy usage from eo files.
Thu, Mar 7, 5:26 AM · Restricted Project

Tue, Mar 5

q66 added a comment to T7724: split out legacy from eo files.

I'll take src/lib/elementary/elm_*.eo.

Tue, Mar 5, 6:57 PM · Restricted Project
q66 added a project to D8102: eolian: add support for marking type declarations beta: Restricted Project.
Tue, Mar 5, 8:13 AM · Restricted Project, efl
q66 added a comment to D8102: eolian: add support for marking type declarations beta.

I know this changes Eolian API so since we're in a freeze it's probably not 100% ideal to merge this, but we need this to be able to stabilize at least something at all.

Tue, Mar 5, 7:29 AM · Restricted Project, efl
q66 requested review of D8102: eolian: add support for marking type declarations beta.
Tue, Mar 5, 7:28 AM · Restricted Project, efl

Mon, Mar 4

q66 added a comment to T7720: eolian legacy type generation broken.

We have no Elm_Win_Type in eo files, nor Eolian provides any facilities to deal with legacy types, so this will need to be fixed manually as manual legacy APIs are pushed into the tree.

Mon, Mar 4, 3:22 AM · efl (efl-1.22), Restricted Project, Restricted Project

Thu, Feb 28

q66 closed T7523: eolian inlist-inarray as Resolved.

Removed in 4b1622b5fc7c6aaafb4d70f187ec5ea797275a26

Thu, Feb 28, 5:33 PM · efl: language bindings, Restricted Project
q66 closed T7647: C# test suite inlist/inarray usage as Resolved.

bf4280e915ebbd4cbad2ee9c8fcd2730fd29eb6f

Thu, Feb 28, 5:33 PM · efl: language bindings, Restricted Project
q66 closed T7647: C# test suite inlist/inarray usage, a subtask of T7523: eolian inlist-inarray, as Resolved.
Thu, Feb 28, 5:33 PM · efl: language bindings, Restricted Project
q66 closed T7648: eolian: refactor inlist<> usage as Invalid.

will be re-implemented correctly from scratch next release

Thu, Feb 28, 5:32 PM · efl: language bindings, Restricted Project
q66 closed T7648: eolian: refactor inlist<> usage, a subtask of T7523: eolian inlist-inarray, as Invalid.
Thu, Feb 28, 5:32 PM · efl: language bindings, Restricted Project
q66 closed T7649: eolian: restrict inarray<> usage as Invalid.

will be re-implemented correctly from scratch next release

Thu, Feb 28, 5:32 PM · efl: language bindings, Restricted Project
q66 closed T7649: eolian: restrict inarray<> usage, a subtask of T7523: eolian inlist-inarray, as Invalid.
Thu, Feb 28, 5:32 PM · efl: language bindings, Restricted Project
q66 closed T7665: Possibly remove inlist/inarray for now? as Resolved.

4b1622b5fc7c6aaafb4d70f187ec5ea797275a26

Thu, Feb 28, 5:31 PM
q66 closed T7665: Possibly remove inlist/inarray for now?, a subtask of T7523: eolian inlist-inarray, as Resolved.
Thu, Feb 28, 5:31 PM · efl: language bindings, Restricted Project
q66 accepted D8056: efl-csharp: Remove generated inlist/inarray support.

This seems fine to me, but I need @felipealmeida to confirm whether it's fine to remove inlist/inarray from Eolian itself for the time being. The reasoning is that there are no users of it in our API right now, and it will take some more time to get it right, so it's best to leave it for next release.

Thu, Feb 28, 5:50 AM · efl

Mon, Feb 25

q66 closed D7999: eolian: validate betaness.
Mon, Feb 25, 5:00 AM · efl
q66 accepted D7999: eolian: validate betaness.
Mon, Feb 25, 4:59 AM · efl

Feb 22 2019

q66 requested changes to D7999: eolian: validate betaness.

no punctuation in error msgs please

Feb 22 2019, 9:18 AM · efl
q66 closed D7980: eolian: introduce typed slice types.
Feb 22 2019, 7:19 AM · efl

Feb 21 2019

q66 added a reviewer for D7980: eolian: introduce typed slice types: lauromoura.
Feb 21 2019, 6:32 AM · efl
q66 requested review of D7980: eolian: introduce typed slice types.
Feb 21 2019, 6:30 AM · efl
q66 closed T7691: Eolian: Inconsistent constant references in docs as Resolved by committing rEFLe335663da08e: eolian gen: emit doxygen references to constants in uppercase.
Feb 21 2019, 3:15 AM · Restricted Project, efl

Feb 13 2019

q66 accepted D7933: eolian: allow tagging complete classes as BETA.
Feb 13 2019, 9:40 AM · efl
q66 accepted D7924: Remove individual class BETA guards.
Feb 13 2019, 9:08 AM · efl
q66 accepted D7901: eolian: drop class function overriding.
Feb 13 2019, 7:17 AM · efl
q66 requested changes to D7901: eolian: drop class function overriding.
Feb 13 2019, 7:07 AM · efl
q66 accepted D7924: Remove individual class BETA guards.

Other than what @bu5hm4n pointed out, looks fine to me. So fix that and then @bu5hm4n can accept the rev and we can land it.

Feb 13 2019, 4:34 AM · efl

Jan 30 2019

q66 added a comment to T7523: eolian inlist-inarray.

Added support for iterative freeing of fields in inarray structs, though still not sure whether to keep it.

Jan 30 2019, 2:37 AM · efl: language bindings, Restricted Project

Jan 29 2019

q66 added a comment to T7523: eolian inlist-inarray.

I added a bunch of stuff in my branch: https://git.enlightenment.org/core/efl.git/log/?h=devs/q66/eolian-inlist-inarray

Jan 29 2019, 11:44 AM · efl: language bindings, Restricted Project
q66 added a subtask for T7523: eolian inlist-inarray: T7665: Possibly remove inlist/inarray for now?.
Jan 29 2019, 8:58 AM · efl: language bindings, Restricted Project
q66 added a parent task for T7665: Possibly remove inlist/inarray for now?: T7523: eolian inlist-inarray.
Jan 29 2019, 8:58 AM
q66 created T7665: Possibly remove inlist/inarray for now?.
Jan 29 2019, 8:58 AM

Jan 28 2019

q66 added a comment to T7648: eolian: refactor inlist<> usage.

Check here: https://git.enlightenment.org/core/efl.git/commit/?h=devs/q66/eolian-inlist-inarray&id=a9917a0c0fe96e5260d571dbc928e80d66fbd567

Jan 28 2019, 6:54 AM · efl: language bindings, Restricted Project
q66 added a comment to T7649: eolian: restrict inarray<> usage.

Check here: https://git.enlightenment.org/core/efl.git/commit/?h=devs/q66/eolian-inlist-inarray&id=a9917a0c0fe96e5260d571dbc928e80d66fbd567

Jan 28 2019, 6:54 AM · efl: language bindings, Restricted Project

Jan 23 2019

q66 accepted D7730: eolian: add support for the container array.
Jan 23 2019, 7:08 AM · efl

Jan 21 2019

q66 accepted D7712: eolian: error out when owned type does not have a free function.
Jan 21 2019, 12:38 PM · efl

Jan 19 2019

q66 added a comment to T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.

The thing in charge of freeing the structure is in charge of freeing its owned fields. If they're not marked owned, it is assumed that the struct does not own them and they will be freed somewhere else. I wonder if this behavior is what we want though. Maybe we should make them owned by default, and reverse the behavior so that you explicitly have to mark the field *not* owned in order to prevent it from being freed as a part of the structure?

Jan 19 2019, 8:03 AM · Restricted Project

Jan 18 2019

q66 added a comment to T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient.

Yes, we allow that. It means the struct owns the reference. If the field is not @owned, it will not be freed when freeing the structure. It is separate from owning on params; if the param is not owned, it means the caller will free it, if it is, it means the callee will free it. Either way, @owned fields will be freed by one of them.

Jan 18 2019, 8:34 AM · Restricted Project
q66 accepted D7688: eolian: remove the old inheritance syntax.
Jan 18 2019, 7:30 AM · efl
q66 requested changes to D7688: eolian: remove the old inheritance syntax.

you forgot an else

Jan 18 2019, 7:25 AM · efl
q66 accepted D7687: efl: convert all interfaces to the new eolian syntax.
Jan 18 2019, 7:22 AM · efl
q66 accepted D7686: efl: convert all abstracts to the new eolian syntax.
Jan 18 2019, 7:22 AM · efl
q66 accepted D7685: efl: convert all mixins to new eolian syntax.
Jan 18 2019, 7:22 AM · efl
q66 accepted D7684: efl: convert all classes to the new eolian syntax.
Jan 18 2019, 7:21 AM · efl