Page MenuHomePhabricator

q66 (Daniel Kolesa)
EFL Developer

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2013, 5:06 PM (363 w, 5 d)
Availability
Available

'q66' on IRC; Software Engineer at Samsung Electronics Czech (working for SRUK Open Source Group); OctaForge project maintainer, Elua maintainer, and a heavy Lua (ab)user.

Recent Activity

Feb 24 2020

q66 closed D11400: database_expr: fix memory leak when type error happens.
Feb 24 2020, 6:52 AM · efl
q66 accepted D11400: database_expr: fix memory leak when type error happens.

lgtm

Feb 24 2020, 6:51 AM · efl

Feb 13 2020

q66 updated the task description for T8328: edocgen: Remaining issues.
Feb 13 2020, 5:55 AM · efl: docs

Feb 6 2020

q66 updated the task description for T8328: edocgen: Remaining issues.
Feb 6 2020, 6:02 AM · efl: docs
q66 closed T8596: @c_name doesn't seem to work with enums as Resolved by committing rEFLd815c26f9c25: eolian: fix missing stringshare_ref.
Feb 6 2020, 5:45 AM · Restricted Project

Feb 5 2020

q66 accepted D11266: eolian: finally error on missing since tags.
Feb 5 2020, 6:11 AM · efl

Jan 30 2020

q66 updated the task description for T8328: edocgen: Remaining issues.
Jan 30 2020, 7:55 AM · efl: docs

Jan 27 2020

q66 added a comment to D9510: eolian: Add @static to classes.

this was created in order to have classes that only have static methods (i.e. I guess as a crutch to be able to have free-standing functions in eo). If we still need this we can land it

Jan 27 2020, 5:50 AM · efl

Jan 22 2020

q66 updated the task description for T8328: edocgen: Remaining issues.
Jan 22 2020, 8:54 AM · efl: docs
q66 abandoned D10318: add title headers for methods and properties.
Jan 22 2020, 8:54 AM
q66 commandeered D10318: add title headers for methods and properties.
Jan 22 2020, 8:54 AM

Jan 9 2020

q66 accepted D11050: eolian: enforce that list<> can only be used with @beta API..
Jan 9 2020, 2:08 PM · efl
q66 resigned from D11051: elementary: do not use list<> in Efl.Ui.Focus_Manager..

this looks fine to me but better reviewed by @bu5hm4n

Jan 9 2020, 6:37 AM · efl
q66 resigned from D11044: ecore_con: remove use of list<> from Efl.Net..
Jan 9 2020, 6:35 AM · efl
q66 accepted D11045: elementary: make focus manager update_children and update_order an internal function to not expose list<>..

otherwise looks good to me, but fix the thing @zmike said

Jan 9 2020, 6:34 AM · efl
q66 accepted D11046: eolian: move list<> tests to be @beta and preserve enough meaningful that are not @beta..
Jan 9 2020, 6:33 AM · efl
q66 accepted D11047: eolian_cxx: move tests of list<> to be protected by @beta..
Jan 9 2020, 6:32 AM · efl
q66 accepted D11048: evas: prepare separation of POST_RENDER event from being an unified and legacy event at the same time..
Jan 9 2020, 6:32 AM · efl
q66 accepted D11049: efl: mark @beta Efl.Gfx.Event.Render_Post..
Jan 9 2020, 6:31 AM · efl
q66 requested changes to D11050: eolian: enforce that list<> can only be used with @beta API..

the ifdef is no good, because that changes the layout/values of the enum depending on if you're compiling with BETA_API_SUPPORT or not, which sucks from ABI perspective; you need to make it have a placeholder of some sort in the other case

Jan 9 2020, 6:31 AM · efl

Jan 7 2020

q66 added a comment to D11026: efl/gesture: correct namespacing of all gesture enums in C.

the whole reason the keyword is still there is pretty much these 4 enums, nothing else in the tree uses it... i'd prefer to do away with it entirely

Jan 7 2020, 9:32 AM · efl

Dec 23 2019

q66 accepted D10948: eolian: inherit since information from struct and enum to field.

Hm, it displays now. Previously phab would not show it.

Dec 23 2019, 10:24 AM · efl
q66 added a comment to D10948: eolian: inherit since information from struct and enum to field.

I think the revision is wrong, it doesn't contain the previous changes but it should because they were reverted

Dec 23 2019, 10:12 AM · efl

Dec 22 2019

q66 added a comment to D10948: eolian: inherit since information from struct and enum to field.

We should do the same thing for enums.

Dec 22 2019, 8:49 AM · efl
q66 accepted D10948: eolian: inherit since information from struct and enum to field.
Dec 22 2019, 8:49 AM · efl

Dec 19 2019

q66 added a comment to D10917: efl: add @since tags for stabilized classes.

I implemented that already, it's behind an env var (EOLIAN_ENFORCE_SINCE)

Dec 19 2019, 9:45 AM · efl

Dec 13 2019

q66 added a comment to T8382: C#: Properties updates.

Hm, I guess it should check it. I'll look into it and see how viable it is. If we can't change it it shouldn't be a big deal though.

Dec 13 2019, 4:48 AM · efl: language bindings

Dec 6 2019

q66 added a comment to T8514: remove @move from get { } if ownership is not moved by getter.

?

Dec 6 2019, 4:05 AM · efl: api, efl (efl-1.24)

Dec 4 2019

q66 added a commit to T8491: eolian: composite does not follow inheritance: rEFL387947f6b151: eolian: account for entire inheritance trees when compositing.
Dec 4 2019, 7:08 AM · Restricted Project
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.

T8491 is fixed now.

Dec 4 2019, 6:34 AM · efl
q66 closed T8491: eolian: composite does not follow inheritance as Resolved by committing rEFLc360f5edb699: eolian: account for entire inheritance trees when compositing.
Dec 4 2019, 6:33 AM · Restricted Project
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.
Dec 4 2019, 6:10 AM · efl
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.
Dec 4 2019, 6:07 AM · efl

Dec 3 2019

q66 edited the content of Enlightenment Developer Days 2019.
Dec 3 2019, 6:09 AM
q66 accepted D10734: efl_ui_mutli_selectable: stabelize interfaces.

Otherwise looks good to me

Dec 3 2019, 4:47 AM · efl
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.

yeah, i'm on it

Dec 3 2019, 4:46 AM · efl

Dec 2 2019

q66 added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Dec 2 2019, 4:38 AM · efl
q66 added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Dec 2 2019, 2:49 AM · efl

Nov 29 2019

q66 accepted D10769: eo files: Avoid container<ptr(value_type)> usage..
Nov 29 2019, 12:16 PM · efl

Nov 21 2019

q66 added inline comments to D10646: Efl.Text.Attribute_Factory.
Nov 21 2019, 4:37 AM · efl

Nov 13 2019

q66 added a comment to D10660: eo: do not over compute the hash when propagating events..

Well, I fixed the root cause: 9ca573f40f1065cc717c0c5aabb787671bab852b

Nov 13 2019, 7:24 PM · efl
q66 requested changes to D10660: eo: do not over compute the hash when propagating events..

Still makes edje_cc hang, after introduction of 7f53d9158395504151e1ff3dcae715a799d913a8.

Nov 13 2019, 6:50 PM · efl

Nov 5 2019

q66 accepted D10601: eolian: Imply @no_unused if @move in return..

lgtm

Nov 5 2019, 11:49 AM · efl

Oct 9 2019

q66 added a comment to D10318: add title headers for methods and properties.

It definitely generated title headings last time I tried... that's the reason I added the distinction in the first place.

Oct 9 2019, 1:56 PM
q66 closed D10316: include PROPERTY documentation.

35b2a10dd5e05e668e025697075076851acff845

Oct 9 2019, 11:18 AM
q66 accepted D10316: include PROPERTY documentation.
Oct 9 2019, 11:16 AM
q66 requested changes to D10317: prevent crash.

This is already done differently

Oct 9 2019, 11:14 AM
q66 requested changes to D10318: add title headers for methods and properties.

You shouldn't need this. A title header is already emitted by the writer itself, see writer.lua, the __ctor method. It just uses the Dokuwiki title plugin by default, if you don't have it, pass --disable-title and it will fall back to headers.

Oct 9 2019, 11:14 AM
q66 accepted D10285: eolian: Leave default text for libeolian users.
Oct 9 2019, 7:17 AM · efl

Sep 30 2019

q66 added a commit to T7704: verify @since tags for stabilized apis: rEFL71c83d2005e0: efl: add code to enforce presence of @since tags.
Sep 30 2019, 11:13 AM · efl (efl-1.24), efl: docs, efl: api
q66 closed T8291: eolian: allow enabling the missing documentation check through a parameter as Wontfix.

No. This would create disparity in how the API behaves depending on an arbitrary switch, which is completely unacceptable.

Sep 30 2019, 11:06 AM · efl: docs, Restricted Project
q66 closed T7180: Make eolian_gen warn about missing documentation as Resolved.

2946cb3c325f27d77354ac1b83b614e3a1d9e1d5

Sep 30 2019, 10:00 AM · Restricted Project, efl: docs, Restricted Project
q66 closed T7180: Make eolian_gen warn about missing documentation, a subtask of T5826: Improve overall EFL documentation, as Resolved.
Sep 30 2019, 10:00 AM · efl: docs, Restricted Project
q66 closed D10238: eolian-cxx: Release iterators.
Sep 30 2019, 7:08 AM · efl
q66 added a commit to T8280: eolian_cxx not freeing iterators (thus leaking memory): rEFLf3199ba04bcb: eolian-cxx: Release iterators.
Sep 30 2019, 7:08 AM · efl (efl-1.24)
q66 added a commit to T8280: eolian_cxx not freeing iterators (thus leaking memory): rEFL507061a145b8: bindings: Fix disposal of eolian state.
Sep 30 2019, 7:08 AM · efl (efl-1.24)
q66 closed D10237: bindings: Fix disposal of eolian state.
Sep 30 2019, 7:08 AM · efl
q66 accepted D10238: eolian-cxx: Release iterators.
Sep 30 2019, 6:36 AM · efl
q66 accepted D10237: bindings: Fix disposal of eolian state.
Sep 30 2019, 6:36 AM · efl
q66 closed T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as Resolved.

Yeah, so it was the issue then :) I suspected something with alignment/padding with the union'd definition of Eolian_Expression not playing nice with the typecast, looks like my suspicion was correct.

Sep 30 2019, 5:07 AM
q66 added a comment to T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20).

can you try again after the latest commit?

Sep 30 2019, 2:34 AM
q66 triaged T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as High priority.
Sep 30 2019, 2:33 AM
q66 reopened T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as "Open".
Sep 30 2019, 2:33 AM
q66 closed T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as Resolved by committing rEFL27291b4486db: eolian: fix potential ABI violation in expr serialization.
Sep 30 2019, 2:33 AM

Sep 27 2019

q66 triaged T8280: eolian_cxx not freeing iterators (thus leaking memory) as Showstopper Issues priority.
Sep 27 2019, 6:31 AM · efl (efl-1.24)
q66 added a comment to T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20).

i'll need a better backtrace for this...

Sep 27 2019, 6:20 AM

Sep 20 2019

q66 added a commit to T8050: Inconsistencies in the usage of `Eina_Hash` make it unsuitable for bindings.: rEFL718f3cd49586: eolian: make hashes beta-only for now.
Sep 20 2019, 8:05 AM · Restricted Project, efl: api
q66 added a comment to T8012: Support default values @property's keys and method's params in eo.

This appears to be wrong. The "default values" are only allowed for property values {} block as well as for @out parameters, Eolian will not accept them for @in parameters. I.e. those values are default fallbacks.

Sep 20 2019, 8:03 AM · efl: language bindings, Restricted Project

Sep 19 2019

q66 moved T7462: eolian: add information to .eot/.eo files about what library module to link/load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 19 2019, 9:24 AM · Restricted Project
q66 closed T8218: eolian: typo in "composite" keyword as Resolved by committing rEFLbc793753cb5c: eolian: allow composites keyword in place of composite.
Sep 19 2019, 9:21 AM · Restricted Project, efl (efl-1.23)
q66 abandoned D10017: eolian: use composites as keyword name to harmonize on third person singular.
Sep 19 2019, 7:53 AM · efl
q66 commandeered D10017: eolian: use composites as keyword name to harmonize on third person singular.
Sep 19 2019, 7:53 AM · efl
q66 requested changes to D10017: eolian: use composites as keyword name to harmonize on third person singular.

Please don't, I already have this mostly done with other changes and this just creates more work for me.

Sep 19 2019, 5:10 AM · efl

Sep 13 2019

q66 closed T8213: eolian: support $[...] syntax as Resolved by committing rEFL266fd9bb368b: eolian: support complex monospace syntax $[...].
Sep 13 2019, 8:08 AM · Restricted Project, efl
q66 closed T8169: how to reference events with commas in eo docs? as Resolved.

as @segfaultxavi said

Sep 13 2019, 7:56 AM · Restricted Project

Sep 12 2019

q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.
In T8184#142189, @tasn wrote:
In T8184#142185, @q66 wrote:

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Yeah, we understand what "requires" means, as in why the name is there. Though how is it different than implements? As that's exactly what's going on here?

Sep 12 2019, 12:00 PM
q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Sep 12 2019, 7:52 AM

Sep 10 2019

q66 closed T7460: eolian: remove ptr() as Resolved.

As of afc011d8931006bd020ba5130a581580f709edcf, usage of ptr() is banned in stable API. That's bound to be good enough for now, and removing it from beta is a separate task, so closing this as resolved.

Sep 10 2019, 5:40 AM · Restricted Project

Sep 9 2019

q66 closed D9867: eolian_cxx: Add support for @by_ref.
Sep 9 2019, 9:19 AM · efl
q66 accepted D9867: eolian_cxx: Add support for @by_ref.
Sep 9 2019, 9:09 AM · efl
q66 closed D9875: docs: remove nstate preview.
Sep 9 2019, 6:56 AM · efl: docs
q66 accepted D9875: docs: remove nstate preview.
Sep 9 2019, 6:55 AM · efl: docs

Sep 6 2019

q66 requested changes to D9867: eolian_cxx: Add support for @by_ref.

this doesn't correctly fix the eolian_type_c_type_get usage yet, which means this will behave wrong with the tag; i still see EOLIAN_C_TYPE_DEFAULT/PARAM/RETURN being passed around.

Sep 6 2019, 4:00 PM · efl
q66 closed D9866: eolian_cxx: Remove last usage of type_is_owned.
Sep 6 2019, 3:57 PM · efl
q66 accepted D9866: eolian_cxx: Remove last usage of type_is_owned.
Sep 6 2019, 3:56 PM · efl
q66 added a comment to T6890: Eolian error integration.

OK, I did that for now, but we'll need to figure out a proper one...

Sep 6 2019, 9:05 AM · efl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFLcb2b6d666cf2: eolian_gen: make errors compile/work.
Sep 6 2019, 9:04 AM · efl: language bindings, Restricted Project
q66 closed T8183: Eolian and composite objects: weird syntax as Resolved by committing rEFLeb25e92770f9: eolian: change composite syntax from block to inheritance section.
Sep 6 2019, 6:14 AM

Sep 5 2019

q66 closed D9844: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:05 AM · efl
q66 added a commit to T8199: eolian_cxx: Update after @move/@owned changes: rEFL17c6cabaa44a: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:05 AM · Restricted Project, efl: language bindings
q66 closed T8199: eolian_cxx: Update after @move/@owned changes as Resolved by committing rEFL1e8554821406: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:05 AM · Restricted Project, efl: language bindings
q66 closed D9843: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:05 AM · efl
q66 accepted D9844: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:04 AM · efl
q66 accepted D9843: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:03 AM · efl
q66 closed T8035: Unify handling of contents of complex types as Resolved.

I think we've got this down, eolian properly checks and verifies this

Sep 5 2019, 7:37 AM · Restricted Project
q66 moved T7955: eolian: remove keyword legacy from enums from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 5 2019, 5:23 AM · Restricted Project
q66 lowered the priority of T7955: eolian: remove keyword legacy from enums from High to TODO.

this is now banned in stable API... removal still pending

Sep 5 2019, 5:23 AM · Restricted Project

Aug 29 2019

q66 added a comment to T6890: Eolian error integration.

Hm, what should be do about this? Do we want this to be thread-safe? Because the error API is not...

Aug 29 2019, 9:12 AM · efl: language bindings, Restricted Project
q66 closed T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient as Resolved.

Closing this as the system is generally sound. Syntax changes may happen but no design alterations

Aug 29 2019, 6:29 AM · Restricted Project

Aug 28 2019

q66 requested changes to D9510: eolian: Add @static to classes.

Please rebase for the @class -> @static method change

Aug 28 2019, 1:23 AM · efl